Kirill Bulatov
477a2a4f1b
zed 0.111.3
2023-11-05 16:19:59 +02:00
Kirill Bulatov
e986a93535
More heuristics for diagnostics updates ( #3236 )
...
Follow-up of https://github.com/zed-industries/zed/pull/3225
That PR enabled every `project::Event::DiskBasedDiagnosticsFinished` to
update the diagnostics, which turned out to be bad, Zed does query for
more diagnostics after every excerpt update, and that seems to be due to
`Event::Edited` emitted by the multibuffers created in the diagnostics
panel.
* now, instead of eagerly updating the diagnostics every time, only do
that if the panel has 0 or 1 caret placed and no changes were made in
the panel yet.
Otherwise, use previous approach and register the updated paths to defer
their update later.
* on every `update_excerpts` in the diagnostics panel, query the entire
diagnostics summary (and store it for the future comparisons), compare
old and new summaries and re-query diagnostics for every path that's not
in both summaries.
Also, query every path that was registered during the
`DiskBasedDiagnosticsFinished` updates that were not eagerly updated
before.
This way we're supposed to get all new diagnostics (for new paths added)
and re-check all old paths that might have stale diagnostics now.
* do diagnostics rechecks concurrently for every path now, speeding the
overall process
Release Notes:
- Fixed diagnostics triggering too eagerly during multicaret edits and
certain stale diagnostics not being removed in time
2023-11-05 16:19:07 +02:00
Kirill Bulatov
acb90ba336
zed 0.111.2
2023-11-03 22:20:46 +02:00
Kirill Bulatov
6780e80bf7
Refresh diagnostics inside the tab ( #3225 )
...
r-a now has 2 different types of diagnostics:
* "disk-based" ones that come from `cargo check` and related, that emit
`project::Event::DiskBasedDiagnosticsStarted` and
`DiskBasedDiagnosticsFinished`
* "flycheck" diagnostics from r-a itself, that it tries to dynamically
apply to every buffer open, that come with `DiagnosticsUpdated` event.
Latter diagnostics update frequently, on every file close and open, but
`diagnostics.rs` logic had never polled for new diagnostics after
registering the `DiagnosticsUpdated` event, so the only way we could
have newer diagnostics was to re-open the whole panel.
The PR fixes that, and also adds more debug logging to the module.
The logic of the fix looks very familiar to previous related fix:
https://github.com/zed-industries/zed/pull/3128
One notable thing after the fix: "flycheck" diagnostics stay forever if
the diagnostics panel is opened: excerpts in that panel do not allow the
buffer to get dropped (hence, closed in terms of r-a) and get the
updated, zero diagnostics.
If the diagnostics panel is opened and closed multiple times, those
errors gradually disappear.
Release Notes:
- Fixed diagnostics panel not refreshing its contents properly
2023-11-03 22:15:53 +02:00
Kirill Bulatov
7e17603059
Detect prettier in npm workspaces correctly ( #3219 )
...
Deals with https://github.com/zed-industries/community/issues/2016
Also refactored project code to spawn less default prettiers.
Release Notes:
- Fixed prettier not working in npm workspaces
2023-11-03 22:15:49 +02:00
Joseph T. Lyons
d2c0c4eac4
zed 0.111.1
2023-11-02 10:50:20 -04:00
Kyle Caverly
80469283ee
authenticate with completion provider on new inline assists ( #3209 )
...
authenticate with completion provider on new inline assists
Release Notes:
- Fixed bug which lead the inline assist functionality to never
authenticate
2023-11-02 10:40:10 -04:00
Joseph T. Lyons
463901820c
v0.111.x preview
2023-11-01 12:34:08 -04:00
Julia
b7625d81e8
Port multi_buffer to gpui2 ( #3193 )
...
Release Notes:
- N/A
2023-11-01 11:45:44 -04:00
Marshall Bowers
bbe53895ef
Return ColorScaleSets from individual color scale functions ( #3197 )
...
This PR adjusts the individual color scale functions to return
`ColorScaleSet`s instead of `DefaultColorScaleSet`s.
We only use the `DefaultColorScaleSet`s to simplify the construction of
the scales, so it isn't necessary to surface them outside of the
function.
Release Notes:
- N/A
2023-11-01 10:45:42 -04:00
Kyle Caverly
1b9619ca7f
added parsing support for <|S| |E|> spans ( #3184 )
...
added parsing support for <|S| and |E|> spans for inline generation
2023-11-01 10:26:01 -04:00
Marshall Bowers
272f856460
Use Refineable for ThemeStyles ( #3196 )
...
This PR updates the `ThemeStyles` struct to use the `Refineable` trait
instead of a custom declarative macro for generating refinements.
Release Notes:
- N/A
2023-10-31 23:33:51 -04:00
Marshall Bowers
36a73d657a
Remove old Theme definition ( #3195 )
...
This PR removes the old `Theme` definition in favor of the new
`ThemeVariant`s.
The new `SyntaxStyles` have been reverted to the old `SyntaxTheme` that
operates by storing the syntax styles as a vector of
`gpui2::HighlightStyle`s.
This is necessary for the intended usage by `language2`, where we find
the longest key in the theme's syntax styles that matches the capture
name:
18431051d9/crates/language2/src/highlight_map.rs (L15-L41)
2023-10-31 23:05:50 -04:00
Marshall Bowers
18431051d9
Rework theme2 with new theme structure ( #3194 )
...
This PR reworks the theme definition in the `theme2` crate to be based
off of the new theme work that @iamnbutler has been working on.
We're still developing the new theme system, but it is complete enough
that we can now load the default theme and use it to theme the storybook
(albeit with some further refining of the color palette required).
---------
Co-authored-by: Nate Butler <iamnbutler@gmail.com >
Co-authored-by: Marshall Bowers <marshall@zed.dev >
2023-10-31 22:23:00 -04:00
Julia
795369a1e3
Port multi_buffer to gpui2
2023-10-31 18:34:36 -04:00
Max Brunsfeld
ed5f1d3bdd
zed2 ( #3174 )
...
PR to get zed2 into main.
Because we have taken the approach of porting crates by renaming them to
`-2` we will need to manually reapply any changes that were made to
ported crates since the `zed2` branch diverged from master.
I think this is the list of PRs that may need changes ported manually.
Any changes to the following crates may need to be moved from crate `x`
to `x2` for each of the following crates: `audio call client copilot db
feature_flags fs fuzzy gpui install_cli language lsp prettier project
rpc settings storybook terminal theme ui zed`.
- [x] f75eb3f62 Conrad Irwin (origin/main, origin/HEAD, main) Merge
branch 'more-signing' (17 hours ago)
- [x] 832026a0a Julia Limit language server reinstallation attempts
(#3177 ) (18 hours ago)
- [x] 4539cef6d Julia Capture language server stderr during startup/init
and log if failure (#3175 ) (21 hours ago)
- [x] e6f2288a0 Conrad Irwin Don't use function_name in vim tests
(#3171 ) (2 days ago)
- [x] f67f42779 Mikayla Maki Rename IIFE to maybe (#3165 ) (2 days ago)
- [ ] 90f65ec9f Max Brunsfeld Remove logic for multiple channel parents
(#3162 ) (2 days ago)
- [ ] 4f859e025 Conrad Irwin link to channel notes (#3167 ) (2 days ago)
- [ ] b8bd070a8 Conrad Irwin Fix panic by disallowing multiple room
joins (#3149 ) (3 days ago)
- [ ] cc9e92857 Max Brunsfeld Guest roles (#3140 ) (3 days ago)
- [x] b090cefdd Kirill Bulatov Rework prettier tests (#3160 ) (3 days
ago)
- [ ] ff497810d Kyle Caverly move keychain access into semantic index as
opposed to on init (#3158 ) (3 days ago)
- [x] 2b95db087 Conrad Irwin Fix infinite loop in select all (#3154 ) (3
days ago)
- [ ] a5836b033 Max Brunsfeld Add chat mentions and a notifications
panel (#3121 ) (4 days ago)
- [ ] ef1a69156 Kyle Caverly update semantic search to use keychain as
fallback (#3151 ) (6 days ago)
- [x] 26638748b Kirill Bulatov Move prettier parsers data into languages
from LSP adapters (#3150 ) (6 days ago)
- [ ] 0dae0f602 Conrad Irwin pixel columns (#3052 ) (7 days ago)
- [x] cc7df91cc Julia Whoops (#3146 ) (7 days ago)
- [x] 808976ee2 Julia Magic incantations for Tailwind autocomplete in
more languages (#3141 ) (7 days ago)
- [ ] cc390ba86 Conrad Irwin Start writing role to database (#3120 ) (10
days ago)
- [ ] 2795091f0 Kyle Caverly Introduce Context Retrieval in Inline
Assistant (#3097 ) (10 days ago)
- [x] b168bded1 Conrad Irwin New entitlements: (#3118 ) (10 days ago)
- [x] 247cdb1e1 Joseph T. Lyons Fix telemetry-related crash on start up
(#3131 ) (11 days ago)
- [ ] 2323fd17b Julia Autocomplete docs (#3126 ) (2 weeks ago)
- [x] 16d9d77d8 Kirill Bulatov Update diagnostics indicator when
diagnostics are udpated (#3128 ) (2 weeks ago)
- [ ] 634202340 Kirill Bulatov Remove zed -> ... -> semantic_index ->
zed Cargo dependency cycle (#3127 ) (2 weeks ago)
Note: this list does not include any PRs that did not change crates that
have been converted; it also does not include any commits that were
pushed directly to master.
### To figure out what needs migrating, run:
```
git diff COMMIT^..COMMIT -- crates/audio crates/call crates/client crates/copilot crates/db crates/feature_flags crates/fs crates/fuzzy crates/gpui crates/install_cli crates/language crates/lsp crates/prettier crates/project crates/rpc crates/settings crates/storybook crates/terminal crates/theme crates/ui crates/zed
```
2023-10-31 10:12:17 -07:00
Antonio Scandurra
66b520a513
Call initialize on the rendered element on AnyView
2023-10-31 17:17:42 +01:00
Antonio Scandurra
0aa9c6b61d
Introduce AnyWeakView
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-10-31 16:19:46 +01:00
Antonio Scandurra
7b6514b178
Simplify AnyView
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-10-31 16:16:30 +01:00
Kirill Bulatov
6a3974ddbb
Remove TODOs
2023-10-31 13:08:18 +02:00
Kirill Bulatov
84c5494949
Fix prettier errors around Zed's settings.json/keymap.json files
...
Ports https://github.com/zed-industries/zed/pull/3191 to zed2
Deals with zed-industries/community#2191
Fix Zed starting too many prettier installations in the beginning, and not being able to format the config files.
2023-10-31 12:26:49 +02:00
Kirill Bulatov
45e695c906
Fix prettier errors around Zed's settings.json/keymap.json files ( #3191 )
...
Deals with https://github.com/zed-industries/community/issues/2191
Fix Zed starting too many prettier installations in the beginning, and
not being able to format the config files.
Release Notes:
- Fixed prettier not being able to format Zed's config files and spawning excessive prettier installations
2023-10-31 12:05:32 +02:00
Kirill Bulatov
6ee9beed73
Enqueue default prettier installations
2023-10-31 11:54:40 +02:00
Antonio Scandurra
88875fd006
Zed2 entities ( #3189 )
...
Adds an `Entity` trait for abstracting over `View`s and `Model`s, and
implements it for the `subscribe()` and `observe()` APIs.
The last commit also includes a fun experiment I added, using the
`Result` type to return the owned model handles back to the caller in
the case of downcast failure, inspired by the `binary_search*` methods.
2023-10-31 10:11:25 +01:00
Kirill Bulatov
c98a811c0b
Only process diagnostics if corresponding project is alive
...
Part of https://github.com/zed-industries/zed/pull/3128 that is possible
to apply now.
2023-10-31 10:40:49 +02:00
Julia
bcf3bac168
Port zed/src/languages to zed2 ( #3190 )
...
@SomeoneToIgnore I had to port
https://github.com/zed-industries/zed/pull/3150 to zed2 in the process,
giving you a heads-up
2023-10-30 22:04:54 -04:00
Julia
db34de6be4
Port zed/src/languages to zed2
2023-10-30 21:52:29 -04:00
Mikayla
f5b13071f1
experiment with a way to recover the any entities when downcasting fails
2023-10-30 18:08:38 -07:00
Mikayla
6f1197e00c
Change model to downcast with ownership
2023-10-30 18:00:37 -07:00
Mikayla
327a2f9967
Add the entity trait and implement for models, views, subscriptions, and observations
2023-10-30 17:50:21 -07:00
Max Brunsfeld
58446c2715
Merge branch 'zed2-render' into zed2
2023-10-30 15:37:00 -07:00
Max Brunsfeld
d6abd8a2b4
Add missing dev-dependency feature for editor multi_buffer dependency
2023-10-30 15:32:52 -07:00
Max Brunsfeld
30dffbb409
Introduce a Render trait, make views implement it
...
Don't pass a render function separately from the view.
Co-authored-by: Nathan Sobo <nathan@zed.dev >
Co-authored-by: Mikayla <mikayla@zed.dev >
Co-authored-by: Antonio <as-cii@zed.dev >
2023-10-30 15:19:40 -07:00
Joseph T. Lyons
f33fc1b6fa
Remove print statement
2023-10-30 18:14:04 -04:00
Joseph T. Lyons
d219ddbdaf
Add script to get crate-level completion status
2023-10-30 18:13:18 -04:00
Joseph T. Lyons
b76ce65a63
Port PR #3131 to zed2 ( #3187 )
...
Part of:
- https://github.com/zed-industries/zed/pull/3174
Release Notes:
- N/A
2023-10-30 17:47:00 -04:00
Marshall Bowers
607813e646
Tweak style for color scale story
2023-10-30 17:45:37 -04:00
Joseph T. Lyons
613afd3f66
Port PR #3131 to zed2
2023-10-30 17:41:26 -04:00
Marshall Bowers
49571127da
theme2: Correctly reference the dark alpha scale
2023-10-30 17:35:13 -04:00
Marshall Bowers
609836397b
Merge branch 'theme-color-scales' into zed2
2023-10-30 17:31:51 -04:00
Marshall Bowers
a02d806715
Add a story showcasing the color scales
2023-10-30 17:31:15 -04:00
Marshall Bowers
991f58409e
Fix alpha channel values for color scales
2023-10-30 17:20:43 -04:00
Marshall Bowers
e0f68c77b0
Add type alias for steps in color scales
2023-10-30 17:08:37 -04:00
Marshall Bowers
b128377cd2
Register all of the color scales
2023-10-30 17:03:33 -04:00
Marshall Bowers
ccccf84867
Define all color scales
2023-10-30 17:00:46 -04:00
Kirill Bulatov
fd6f6cc9f8
Return proper full paths for single file workspaces
2023-10-30 22:33:44 +02:00
Kirill Bulatov
29a32039ba
Start message numbering during prettier init, log error message text
2023-10-30 22:26:06 +02:00
Marshall Bowers
7841a56a11
Start work on defining color scales
2023-10-30 16:21:59 -04:00
KCaverly
b34f0c3bee
update prettier2, call2 and project2 to use fs2
2023-10-30 16:21:58 -04:00
Kirill Bulatov
033d0ae610
Remember default prettier and its plugin installation
2023-10-30 22:09:36 +02:00
Antonio Scandurra
0128079de0
WIP
2023-10-30 20:36:48 +01:00
Marshall Bowers
78573fb140
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-30 15:17:16 -04:00
Marshall Bowers
942167e046
Format ui2
2023-10-30 15:17:11 -04:00
Kyle Caverly
0efbc81b0f
port ai to zed2 ( #3186 )
...
port ai to zed2
2023-10-30 20:09:49 +01:00
KCaverly
c17b246bac
updated for model handle rename
2023-10-30 15:04:16 -04:00
Antonio Scandurra
bc4f8fbf4e
Rename other references from "handle" to "model"
...
Co-Authored-By: Max <max@zed.dev >
Co-Authored-By: Mikayla <mikayla@zed.dev >
2023-10-30 19:54:32 +01:00
KCaverly
5ff70f7dba
keeping this bad boy green during fmt checks
2023-10-30 14:49:31 -04:00
Marshall Bowers
ba789fc0c4
Remove old theme constructs
2023-10-30 14:47:44 -04:00
KCaverly
d5077d9d0c
Merge branch 'zed2' of github.com:zed-industries/zed into zed2-ai
2023-10-30 14:47:13 -04:00
Antonio Scandurra
1a54ac0d69
Rename Handle to Model
2023-10-30 19:44:01 +01:00
KCaverly
04ab68502b
port ai crate to ai2, with all tests passing
2023-10-30 14:40:31 -04:00
Marshall Bowers
14d24a9ac6
Remove references to old_theme
2023-10-30 14:36:49 -04:00
Marshall Bowers
7bacdefa2e
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-30 14:28:27 -04:00
Marshall Bowers
7b4e699d0e
Remove themed wrapper
2023-10-30 14:28:25 -04:00
KCaverly
204aba07f6
Merge branch 'main' of github.com:zed-industries/zed into zed2
2023-10-30 13:44:50 -04:00
Piotr Osiewicz
510ab60bd4
zed2-backport: Elixir next ls bad cpu type ( #3185 )
2023-10-30 18:44:47 +01:00
Piotr Osiewicz
e63a611c81
lsp/next-ls: Fix wrong nls binary being fetched.
...
CPU types had to be swapped around.
Fixed zed-industries/community#2185
2023-10-30 18:43:11 +01:00
KCaverly
08e9b2e848
added parsing support for <|S| |E|> spans
2023-10-30 13:32:47 -04:00
Piotr Osiewicz
dc8a853842
lsp/next-ls: Fix wrong nls binary being fetched. ( #3181 )
...
CPU types had to be swapped around.
Fixed zed-industries/community#2185
Release Notes:
- Fixed Elixir next-ls LSP installation failing due to fetching a binary
for the wrong architecture (zed-industries/community#2185 ).
2023-10-30 18:27:05 +01:00
Marshall Bowers
b31a004def
Add menu2 crate
2023-10-30 12:56:23 -04:00
Marshall Bowers
d3cd5f3ec5
Format theme2
2023-10-30 11:26:30 -04:00
Marshall Bowers
3d8516b25f
Convert all themes
2023-10-30 11:22:04 -04:00
Marshall Bowers
7a66ebae71
Emit modules for each theme
2023-10-30 11:21:33 -04:00
Kyle Caverly
4986d4771d
Model cleanup ( #3157 )
...
Small reorganization for the AI crates. I seperated out the base traits
and providers, to get closer to an abstraction for AI completions as
opposed to OpenAI specific functionality.
2023-10-30 16:15:11 +01:00
KCaverly
142b94bdd4
Merge branch 'main' of github.com:zed-industries/zed into model_cleanup
2023-10-30 11:07:29 -04:00
KCaverly
f3c113fe02
clean up warnings and fix tests in the ai crate
2023-10-30 11:07:24 -04:00
Marshall Bowers
2879d231b1
Revert changes to themes
2023-10-30 11:06:45 -04:00
Marshall Bowers
3591ffe4a7
Emit all themes at once
2023-10-30 11:04:03 -04:00
Marshall Bowers
b8ae949dbe
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-30 10:40:48 -04:00
Marshall Bowers
61cc3b93e3
Factor out ThemePrinter into its own module
2023-10-30 10:40:46 -04:00
KCaverly
a2c3971ad6
moved authentication for the semantic index into the EmbeddingProvider
2023-10-30 10:02:27 -04:00
Antonio Scandurra
25e882d72a
Remove randomness from GPUI2 block_with_timeout
2023-10-30 12:10:55 +01:00
Kirill Bulatov
b3c3adab50
Port prettier panic fix to gpui2
2023-10-30 13:00:49 +02:00
Kirill Bulatov
bd30ce837d
Do not panic when looking for prettier ( #3182 )
...
Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1698655595438009
Instead of checking FS, derive the prettier path needed and let prettier
invocation fail in logs instead.
2023-10-30 12:59:46 +02:00
Kirill Bulatov
6aca2289eb
Do not panic when looking for prettier ( #3182 )
...
Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1698655595438009
Instead of checking FS, derive the prettier path needed and let prettier
invocation fail in logs instead.
2023-10-30 12:58:47 +02:00
Kirill Bulatov
b46a4b5680
Be more lenient when searching for prettier instance
...
Do not check FS for existence (we'll error when start running prettier),
simplify the code for looking it up
2023-10-30 12:13:58 +02:00
Kirill Bulatov
249bec3cac
Do not panic on prettier search
2023-10-30 12:13:54 +02:00
Kirill Bulatov
f16ff79ff8
Properly log prettier paths
2023-10-30 11:17:11 +02:00
Kirill Bulatov
96bbb5cdea
Properly log prettier paths
2023-10-30 11:14:00 +02:00
Joseph T. Lyons
37a561df0a
Do not call scroll_to() twice when circularly navigating popover menus ( #3180 )
...
The tweaks made to add circular navigation to autocompletion / code
action menus accidentally was calling `scroll_to` twice in some cases -
just fixing that.
Release Notes:
- N/A
2023-10-29 15:02:09 -04:00
Joseph T. Lyons
dd89b2e6d4
Pull duplicate call out of if-else block
2023-10-29 13:54:32 -05:00
Joseph T. Lyons
34747bbbbc
Do not call scroll_to twice
2023-10-29 13:47:02 -05:00
KCaverly
1e8b23d8fb
replace api_key with ProviderCredential throughout the AssistantPanel
2023-10-28 18:16:45 -04:00
KCaverly
558f54c424
added credential provider to completion provider
2023-10-28 16:35:43 -04:00
Joseph T. Lyons
10b581f250
Port journal to GPUI2 ( #3178 )
...
Release Notes:
- N/A
2023-10-28 17:42:42 +02:00
Joseph T. Lyons
6b65d76014
Port journal to GPUI2
2023-10-28 11:37:25 -04:00
Nathan Sobo
e27427dce8
Merge branch 'gpui2-docs' into zed2
2023-10-27 17:07:28 -06:00
Nathan Sobo
f88ca2e7da
Add docs for window.rs, but still incomplete
2023-10-27 22:29:59 +02:00
Nathan Sobo
ad7c49e4bb
Add doc comments to app.rs
2023-10-27 21:19:48 +02:00
Conrad Irwin
b4225ac82a
Port changes from #3118 to zed2
2023-10-27 13:27:55 +02:00
Conrad Irwin
ba189f2af1
Port changes from #3154 to zed2
2023-10-27 13:24:37 +02:00
KCaverly
7af77b1cf9
moved TestCompletionProvider into ai
2023-10-27 12:26:01 +02:00
Conrad Irwin
67ecc2fe04
Comment out failing gpui2 test
2023-10-27 11:24:23 +02:00
Conrad Irwin
af0c010b4a
Remove deadlock from gpui2 pasteboard
2023-10-27 11:14:13 +02:00
Conrad Irwin
d2ab0d651e
Get cargo test --workspace compiling again
2023-10-27 11:03:30 +02:00
Conrad Irwin
079de6fdf7
Rename last async_iife
2023-10-27 10:56:24 +02:00
Conrad Irwin
4a6a17d866
Merge branch 'main' into zed2
2023-10-27 10:55:15 +02:00
Conrad Irwin
5f5234c5da
Fix fs2 tests
2023-10-27 10:51:36 +02:00
Conrad Irwin
c1904b493b
Fix cargo fmt
2023-10-27 10:44:57 +02:00
KCaverly
ec9d79b6fe
add concept of LanguageModel to CompletionProvider
2023-10-27 08:51:30 +02:00
KCaverly
6c8bb4b05e
ensure OpenAIEmbeddingProvider is using the provider credentials
2023-10-27 08:33:35 +02:00
Nathan Sobo
bcdffc9963
Merge branch 'zed2-views' into zed2
2023-10-26 19:41:59 +02:00
Nathan Sobo
a1c3826858
Add View::update which provides a ViewContext
2023-10-26 19:41:42 +02:00
Conrad Irwin
f75eb3f626
Merge branch 'more-signing'
2023-10-26 18:27:58 +02:00
Conrad Irwin
071e9b4871
Revert entitlements change
2023-10-26 18:27:34 +02:00
Conrad Irwin
30e7978dcf
Try more signing
2023-10-26 18:27:33 +02:00
Antonio Scandurra
8e3314e680
WIP
2023-10-26 18:17:45 +02:00
Julia
832026a0a2
Limit language server reinstallation attempts ( #3177 )
...
Release Notes:
- Fixed a case where a sufficiently broken language server system
configuration could cause an infinite repeated server reinstallation,
consuming resources indefinitely.
2023-10-26 17:20:13 +02:00
Julia
a23e05c20b
Limit language server reinstallation attempts
...
zed2 electric boogaloo
2023-10-26 17:16:04 +02:00
Antonio Scandurra
516236e044
Disable livekit on zed2
2023-10-26 17:15:19 +02:00
Antonio Scandurra
637cff3ebd
WIP
2023-10-26 17:15:19 +02:00
Julia
8db3b3b4ca
Limit language server reinstallation attempts
2023-10-26 17:14:34 +02:00
Joseph T. Lyons
98d03f6e7a
Revert "Add activity_indicator2"
...
This reverts commit 88a3a57789 .
2023-10-26 17:13:40 +02:00
Marshall Bowers
560e115656
Pull syntax colors from JSON theme
2023-10-26 17:06:05 +02:00
Marshall Bowers
973ca8d4f0
ui2: Remove dependency on theme crate
2023-10-26 16:50:04 +02:00
Marshall Bowers
692aeff263
ui2: Remove dependency on settings crate
2023-10-26 16:50:04 +02:00
Joseph T. Lyons
88a3a57789
Add activity_indicator2
2023-10-26 16:49:39 +02:00
Marshall Bowers
61694bba6a
Remove unneeded constructors for stories
2023-10-26 16:46:49 +02:00
Max Brunsfeld
65045b9c52
Get remaining language2 tests passing
2023-10-26 16:38:50 +02:00
Max Brunsfeld
0eae962abf
Represent theme's syntax colors with string keys
...
Co-authored-by: Marshall Bowers <marshall@zed.dev >
2023-10-26 16:38:50 +02:00
Marshall Bowers
a569c82492
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-26 15:59:21 +02:00
Marshall Bowers
ed233d583f
ui2: Remove ElementExt trait
2023-10-26 15:59:18 +02:00
Max Brunsfeld
b3ad8c1c3e
Get most of the language2 tests passing
...
Co-authored-by: Conrad <conrad@zed.dev >
2023-10-26 15:57:12 +02:00
Max Brunsfeld
3cc91e5742
Add missing seed variable for gpui2 test macro
...
Co-authored-by: Conrad <conrad@zed.dev >
2023-10-26 15:57:12 +02:00
Marshall Bowers
6784ccd9fe
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-26 15:54:48 +02:00
Marshall Bowers
1887f3b594
Rename S type to V
2023-10-26 15:54:43 +02:00
Max Brunsfeld
8bc2071414
Fix gpui2 bugs
...
* Compile error for tests that take StdRng
* Dynamic type dowcasting error when emitting events
* Slot error when dropping handles
Co-authored-by: Conrad <conrad@zed.dev >
2023-10-26 15:54:19 +02:00
Antonio Scandurra
58e8012d8c
Make zed2 compile again
2023-10-26 15:45:30 +02:00
Marshall Bowers
8a70ef3e8f
Remove unused state_type
2023-10-26 15:45:08 +02:00
Marshall Bowers
eb19071d84
ui2: Clean up takes
2023-10-26 15:44:39 +02:00
Marshall Bowers
7b4a895ab9
ui2: Clean up drains
2023-10-26 15:41:29 +02:00
Marshall Bowers
d62c51a4b8
Merge branch 'gpui2-element-renderer' into zed2
2023-10-26 15:23:02 +02:00
Marshall Bowers
fccc4ca85c
Initialize element before layout
2023-10-26 15:22:48 +02:00
Marshall Bowers
42095f0673
Remove debug from derive Component proc macro
2023-10-26 15:22:38 +02:00
Marshall Bowers
88ef74ec8f
Checkpoint: Compiling after view type removal
2023-10-26 15:20:38 +02:00
Max Brunsfeld
6fe393db2a
Fix compile errors with lsp2
...
Co-authored-by: Jospeh <joseph@zed.dev >
2023-10-26 14:48:04 +02:00
Max Brunsfeld
69e5ecc015
Enable client tests
...
* implement Executor::advance_clock
Co-authored-by: Conrad <conrad@zed.dev >
Co-authored-by: Kyle <kyle@zed.dev >
Co-authored-by: Joseph <joseph@zed.dev >
2023-10-26 14:44:13 +02:00
Marshall Bowers
c9c9db903d
Fix Component derive macro
2023-10-26 14:20:25 +02:00
Julia
4539cef6d7
Capture language server stderr during startup/init and log if failure ( #3175 )
...
Gives us some more debugging information
Release Notes:
- N/A
2023-10-26 14:17:29 +02:00
KCaverly
ca82ec8e8e
fixed truncation error in fake language model
2023-10-26 14:05:55 +02:00
Julia
0eafb8886d
zed2: Capture language server stderr during startup/init and log if failure ( #3176 )
...
zed2 electric boogaloo
Release Notes:
- N/A
2023-10-26 13:59:04 +02:00
Kirill Bulatov
27d2accb51
Fix the formatting
2023-10-26 13:52:04 +02:00
Kirill Bulatov
0a04c5734b
Update mouse position during file drag and drop
2023-10-26 13:50:35 +02:00
Julia
8a0fb668f7
Capture language server stderr during startup/init and log if failure
...
zed2 electric boogaloo
2023-10-26 13:50:24 +02:00
Nathan Sobo
f4cff69729
WIP: Macro not working fully yet
2023-10-26 13:18:58 +02:00
Max Brunsfeld
a4b7e3c9f6
Merge branch 'zed2-hangs' into zed2
2023-10-26 12:48:35 +02:00
Conrad Irwin
065d26f5b2
Get RPC2 tests passing
...
Co-authored-by: Conrad <conrad@zed.dev >
Co-authored-by: Kyle <kyle@zed.dev >
2023-10-26 12:47:37 +02:00
Nathan Sobo
0285284ae1
Rename IntoAnyElement trait to Component
2023-10-26 12:46:52 +02:00
Nathan Sobo
8ecfea55cd
Replace derive Element with derive IntoAnyElement everywhere
2023-10-26 12:38:23 +02:00
Julia
170ebd8221
Capture language server stderr during startup/init and log if failure
2023-10-26 12:29:22 +02:00
Nathan Sobo
315744ec20
Add derive macro for IntoAnyElement
2023-10-26 12:20:46 +02:00
Antonio Scandurra
06c22206af
Add install_cli2
...
Co-authored-by: Mikayla <mikayla@zed.dev >
Co-Authored-By: Kirill <kirill@zed.dev >
2023-10-26 12:09:54 +02:00
Antonio Scandurra
6172cd9015
Merge branch 'zed2-room' into zed2
2023-10-26 11:57:11 +02:00
Antonio Scandurra
3bcae6d7de
Add call2
...
Co-Authored-By: Kirill Bulatov <kirill@zed.dev >
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-10-26 11:56:34 +02:00
Nathan Sobo
927278e20d
Remove IntoAnyElement bound from Element trait
2023-10-26 11:49:36 +02:00
Conrad Irwin
71ad3e1b20
Add rpc2
2023-10-26 11:48:25 +02:00
Conrad Irwin
693246ba26
Fix fs2 import on zed
2023-10-26 11:41:15 +02:00
Conrad Irwin
b875be9689
Fix settings2 tests
2023-10-26 11:39:32 +02:00
Conrad Irwin
07b9ec29e6
Revert "Fix settings2 crate tests"
...
This reverts commit 6e9c779c51 .
2023-10-26 11:33:58 +02:00
Nathan Sobo
db15db45ce
WIP
2023-10-26 11:31:47 +02:00
Conrad Irwin
6e9c779c51
Fix settings2 crate tests
2023-10-26 11:27:23 +02:00
Kirill Bulatov
483ac9491a
Start fixing room2
2023-10-26 11:27:12 +02:00
Conrad Irwin
6cf7d0b81c
Fix macro some more
2023-10-26 11:27:03 +02:00
Conrad Irwin
6185c935a6
Fix small bugs in gpui2::test
2023-10-26 11:23:07 +02:00
Nathan Sobo
45a8aea0f0
Make FnOnces that render elements IntoAnyElement
2023-10-26 11:21:42 +02:00
KCaverly
3447a9478c
updated authentication for embedding provider
2023-10-26 11:18:16 +02:00
Nathan Sobo
db7d12f628
WIP
2023-10-26 10:59:27 +02:00
Marshall Bowers
4266ead958
WIP: Trait bounds
2023-10-26 10:46:02 +02:00
Conrad Irwin
5651ef7ca2
Use quit to end tests
2023-10-26 10:40:04 +02:00
Conrad Irwin
51aa0d6a94
Clearer error on importing both gpui and gpui2
2023-10-26 10:39:52 +02:00
Piotr Osiewicz
bc3572f80e
util: Improve error message for failing requests to GH. ( #3159 )
...
Release notes:
- N/A
Co-authored-by: Julia Risley <julia@zed.dev >
2023-10-26 10:39:45 +02:00
Piotr Osiewicz
1ec6638c7f
vue: use anyhow::ensure instead of asserting on filesystem state ( #3173 )
...
Release Notes:
- Fixed a crash on failed assertion in Vue.js language support.
2023-10-26 10:16:21 +02:00
Marshall Bowers
e31a9401a8
Merge branch 'remove-view-state-associated-type' into gpui2-element-renderer
2023-10-26 10:10:17 +02:00
Marshall Bowers
65389a8fac
Merge branch 'zed2' into gpui2-element-renderer
2023-10-26 10:10:10 +02:00
Marshall Bowers
9fb9885931
Checkpoint: Compiling
2023-10-26 10:08:39 +02:00
Marshall Bowers
8b972f6d8e
WIP: Fix compilation of gpui2
2023-10-26 09:51:33 +02:00
Marshall Bowers
965bfd8439
WIP: Pass in V to Element
2023-10-26 09:45:26 +02:00
Marshall Bowers
9c10152c89
Use Display instead of custom to_string
2023-10-26 09:30:21 +02:00
Marshall Bowers
28ef30f7a2
Removed unused ui2::color module
2023-10-26 09:26:22 +02:00
Conrad Irwin
e6f2288a0c
Don't use function_name in vim tests ( #3171 )
...
Remove dependency on function name from vim tests.
We want to remove this from gpui2, and it looks like we can!
2023-10-25 23:36:48 +02:00
Conrad Irwin
ffcec011f8
Don't use function_name in vim tests
2023-10-25 23:26:57 +02:00
Marshall Bowers
06bff41818
WIP: ElementRenderer
2023-10-25 21:08:34 +02:00
Antonio Scandurra
c5763cdb99
Fix errors in passing TestAppContext in async gpui2 tests
2023-10-25 21:08:00 +02:00
Antonio Scandurra
43d230cb2d
Introduce a gpui2::test macro
...
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com >
Co-Authored-By: Max Brunsfeld <max@zed.dev >
Co-Authored-By: Kyle <kyle@zed.dev >
2023-10-25 21:08:00 +02:00
Marshall Bowers
7ec9cc08c7
Fix z-index targeting for drag and drop
2023-10-25 20:49:40 +02:00
Marshall Bowers
5355007719
Clean up some warnings
2023-10-25 20:40:50 +02:00
Marshall Bowers
b5eae86b67
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-25 20:38:03 +02:00
Marshall Bowers
e67048ee7b
Load themes from settings and rework Settings trait
2023-10-25 20:37:55 +02:00
Antonio Scandurra
5ba04dce2b
Assert handles are passed to the right contexts
2023-10-25 19:46:13 +02:00
Piotr Osiewicz
7f6bb3d1eb
Extract multi_buffer module out of editor ( #3170 )
...
Release Notes:
- N/A
2023-10-25 19:31:47 +02:00
Antonio Scandurra
412c0ff7dc
Add fs2
...
Co-Authored-By: Max <max@zed.dev >
Co-Authored-By: Conrad <conrad.irwin@gmail.com >
Co-Authored-By: Kyle <kyle@zed.dev >
2023-10-25 19:17:50 +02:00
Julia
1936ba5e30
F8 navigation bugs ( #3163 )
...
Release Notes:
- Fixed "go to previous hunk" getting suck on deletion.
- Fixed a rare case where "go to (prev) diagnostic" could get stuck with
specifically overlapping diagnostics.
2023-10-25 19:03:45 +02:00
Antonio Scandurra
9986e526e5
Stop depending on gpui in client2 and settings2
2023-10-25 18:47:03 +02:00
Joseph T. Lyons
3460e95899
vcs_menu: Fix a circular view handle in modal picker. ( #3168 )
...
Release Notes:
- Fixed a crash in modal branch picker.
2023-10-25 18:44:48 +02:00
Piotr Osiewicz
39480364bd
vcs_menu: Fix a circular view handle in modal picker.
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-10-25 18:34:14 +02:00
Antonio Scandurra
1b75603f63
Implement os_name, os_version and app_version for TestPlatform
...
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com >
Co-Authored-By: Kyle <kyle@zed.dev >
2023-10-25 18:30:06 +02:00
Antonio Scandurra
52f9f90ccb
Implement TestAppContext::new
...
Co-Authored-By: Max <max@zed.dev >
Co-Authored-By: Conrad <conrad@zed.dev >
Co-Authored-By: Kyle <kyle@zed.dev >
2023-10-25 18:28:05 +02:00
Marshall Bowers
98e2490807
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-25 18:20:22 +02:00
Marshall Bowers
a0fe859d87
Make theme converter spit out valid Rust structs
2023-10-25 18:20:16 +02:00
Antonio Scandurra
51fb33d8ef
Allow different app contexts to race
...
Co-Authored-By: Max <max@zed.dev >
Co-Authored-By: Kyle <kyle@zed.dev >
Co-Authored-By: Conrad <conrad@zed.dev >
2023-10-25 18:11:38 +02:00
Max Brunsfeld
3a369bc207
Name embedded.provisionprofile the same on stable as other channels
2023-10-25 18:02:27 +02:00
Antonio Scandurra
92535ba2c4
Introduce TestAppContext
...
Co-Authored-By: Max <max@zed.dev >
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com >
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-10-25 17:55:20 +02:00
Antonio Scandurra
6f6495ccbf
Fix error
2023-10-25 17:41:40 +02:00
Marshall Bowers
08a4e53cfe
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-25 17:38:52 +02:00
Marshall Bowers
c8a86c2dd1
theme2: Add Rosé Pine themes
2023-10-25 17:38:48 +02:00
Max Brunsfeld
841a5ef7b8
collab 0.27.0
2023-10-25 17:38:09 +02:00
Max Brunsfeld
2c5caf91bc
Bump RPC version for channels + notifications changes
2023-10-25 17:37:14 +02:00
Antonio Scandurra
3566d920c5
Add deterministic TestDispatcher
...
Co-Authored-By: Conrad Irwin <conrad@zed.dev >
Co-Authored-By: Max Brunsfeld <max@zed.dev >
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-10-25 17:33:55 +02:00
Marshall Bowers
cee8175c19
theme2: Add Sandcastle theme
2023-10-25 17:27:25 +02:00
Marshall Bowers
751df45263
Print out Theme structs in theme_converter
2023-10-25 17:24:34 +02:00
Max Brunsfeld
eb8d376274
Avoid unused import in release builds
2023-10-25 17:16:29 +02:00
Mikayla Maki
f67f42779b
Rename IIFE to maybe ( #3165 )
...
Too good of an idea to forget
Release Notes:
- N/A
2023-10-25 17:09:12 +02:00
Marshall Bowers
6b5947a1fa
Start work on theme converter
2023-10-25 16:54:26 +02:00
Marshall Bowers
437d147935
Rename player to players
2023-10-25 16:39:06 +02:00
Marshall Bowers
0867175a4e
Remove reference to removed ThemeColor
2023-10-25 16:34:03 +02:00
Marshall Bowers
4fcbc91aca
Add note about fixing dead_code and unused_variables warnings in ui2
2023-10-25 16:33:33 +02:00
Marshall Bowers
e1032c5341
Remove ThemeColor in favor of theme2::Theme
2023-10-25 16:32:44 +02:00
KCaverly
71bc35d241
catchup with main
2023-10-25 16:31:00 +02:00
Joseph T. Lyons
c44d1cda9a
collab 0.26.0
2023-10-25 16:24:53 +02:00
Mikayla
26a3d41dc7
Change from try (reserved keyword) to maybe
2023-10-25 07:10:21 -07:00
Joseph T. Lyons
71c72d8e08
v0.111.x dev
2023-10-25 16:07:54 +02:00
Marshall Bowers
bb3f59252e
Rename theme2 getter to theme
2023-10-25 16:04:49 +02:00
Marshall Bowers
258496700f
Rename theme getter to old_theme
2023-10-25 16:02:47 +02:00
Marshall Bowers
8043d0d8a9
Reference theme2 colors in ThemeColor
2023-10-25 15:58:56 +02:00
Max Brunsfeld
90f65ec9fe
Remove logic for multiple channel parents ( #3162 )
...
This PR simplifies our state management for channels, and logic for
inheriting channel permissions, by removing the ability for channels to
have multiple parent channels.
2023-10-25 15:57:55 +02:00
Conrad Irwin
4f859e0253
link to channel notes ( #3167 )
...
Release Notes:
- Add links to channel notes
2023-10-25 15:53:34 +02:00
Marshall Bowers
dd34bb273e
Load Theme from theme2 into the storybook
2023-10-25 15:50:50 +02:00
Max Brunsfeld
b5cbfb8f1d
Allow moving channels to the root
2023-10-25 15:50:37 +02:00
Max Brunsfeld
32367eba14
Set up UI to allow dragging a channel to the root
2023-10-25 15:39:02 +02:00
Max Brunsfeld
42259a4007
Fix channel dragging
...
Co-authored-by: Conrad <conrad@zed.dev >
Co-authored-by: Joseph <joseph@zed.dev >
2023-10-25 09:41:16 +02:00
Conrad Irwin
70eeefa1f8
Fix channel collapsing
2023-10-25 09:27:17 +02:00
Conrad Irwin
6f173c64b3
Fix tests by re-instating paths in the new format
2023-10-25 09:22:06 +02:00
Conrad Irwin
b8bd070a83
Fix panic by disallowing multiple room joins ( #3149 )
...
Release Notes:
- Fixed panic that could occur when switching channels quickly
2023-10-24 23:57:08 +02:00
Joseph T. Lyons
c77376225d
Allow completion menus to be cycled ( #3164 )
...
Not a huge ask from the community, but something that I run into
frequently is not being able to cycle the auto completion menus past the
beginning / end, so I quickly added it. This matches VS Code behavior:
https://github.com/zed-industries/zed/assets/19867440/bc4606d7-2076-4036-aedc-f3cf5ba349dc
Release Notes:
- Enhanced popover menus with circular navigation
([#632 ](https://github.com/zed-industries/community/issues/632 )).
2023-10-24 23:08:10 +02:00
Mikayla Maki
beb0af9763
Rename IIFE to try
...
Too good of an idea to forget
2023-10-24 21:13:22 +02:00
Conrad Irwin
1411b98a5d
link to channel notes
2023-10-24 19:48:31 +02:00
Joseph T. Lyons
1c5b321058
Allow completion menus to be cycled
2023-10-24 19:29:44 +02:00
Kirill Bulatov
a01b507ef4
Add OS file drop event handler
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-10-24 19:26:06 +02:00
Conrad Irwin
dfc34e582a
Fix extra race
2023-10-24 18:54:55 +02:00
Marshall Bowers
5b04f965fa
Update Cargo.lock
2023-10-24 18:25:48 +02:00
Kirill Bulatov
77991ad865
Fix compilation
2023-10-24 18:22:26 +02:00
Marshall Bowers
afad2fbfa2
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-24 17:58:42 +02:00
Marshall Bowers
d6bd000aa8
Rename cx.global_default_mut to cx.global_default
2023-10-24 17:58:14 +02:00
Julia
bfdff4e2e0
When navigating diagnostics, skip diagnostic containing cursor
...
Slightly unfortunate but prevents an issue with weirdly overlapping
diagnostics causing the cursor to bounce between them
2023-10-24 17:56:56 +02:00
Marshall Bowers
4ca7ddfc42
Finish up ThemeRegistry and remove AnyAssetSource
2023-10-24 17:47:41 +02:00
Marshall Bowers
51c66f508b
Merge branch 'zed2' into theme2
2023-10-24 17:29:25 +02:00
Max Brunsfeld
5c03b6a610
Remove logic for multiple channel parents
...
Co-authored-by: Conrad <conrad@zed.dev >
Co-authored-by: Kyle <kyle@zed.dev >
Co-authored-by: Joseph <joseph@zed.dev >
2023-10-24 17:29:23 +02:00
Max Brunsfeld
cc9e92857b
Guest roles ( #3140 )
...
Release Notes:
- Added a "guest" role to channels, and made that the default when a new
user joins a public channel.
2023-10-24 17:29:14 +02:00
Marshall Bowers
4740d6ed61
Checkpoint
2023-10-24 17:29:03 +02:00
Kirill Bulatov
18930c33fe
Make audio2
2023-10-24 17:15:59 +02:00
Marshall Bowers
5fb8321ee0
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-24 17:00:11 +02:00
Marshall Bowers
09866ec3e9
WIP
2023-10-24 16:59:24 +02:00
Marshall Bowers
9f8aaa4cdb
Add AnyAssetSource
2023-10-24 16:59:01 +02:00
Kirill Bulatov
1ad7f3a16d
Finish ???-ing project2.rs
2023-10-24 16:35:34 +02:00
Antonio Scandurra
11953e613b
Checkpoint
2023-10-24 16:15:20 +02:00
Nate Butler
0f03f8ff8a
Tweak notification styles ( #3161 )
...
[[PR Description]]
Tweak notification visual styles
Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/ <public_issue_number_if_exists>)).
2023-10-24 10:03:24 -04:00
Nate Butler
c8dfccff36
Revert "Add meta_text to style metaline"
...
This reverts commit beb91fa094 .
2023-10-24 09:57:33 -04:00
Nate Butler
beb91fa094
Add meta_text to style metaline
2023-10-24 09:51:26 -04:00
Antonio Scandurra
9aaf7d0c46
Checkpoint
2023-10-24 15:30:16 +02:00
Nate Butler
c9e670397f
Give notifications a bit more breathing room by default
2023-10-24 09:25:49 -04:00
Nate Butler
463b24949e
Tweak notification styles
2023-10-24 09:22:58 -04:00
Antonio Scandurra
191285a8f1
Checkpoint
2023-10-24 15:18:51 +02:00
Nathan Sobo
9f9137cf76
Remove failed attempt at eliminating static bounds on entities
2023-10-24 15:12:51 +02:00
Nate Butler
9f48cdac83
Lower the default state intensities
2023-10-24 08:41:39 -04:00
Kirill Bulatov
b090cefdde
Rework prettier tests ( #3160 )
...
Do not infuse `FakeNodeRuntime` with prettier exceptions, rather keep
the default formatter installation method as no-op.
2023-10-24 15:34:55 +03:00
Nate Butler
bfb37bbe94
Merge branch 'n/elevation' into zed2
2023-10-24 08:34:54 -04:00
Marshall Bowers
8117e7933c
Add missing bounds to Themed
2023-10-24 14:30:26 +02:00
Kirill Bulatov
e9ce935991
Rework prettier tests
...
Do not infuse `FakeNodeRuntime` with prettier exceptions, rather keep
the default formatter installation method as no-op.
2023-10-24 14:25:46 +02:00
Nathan Sobo
2285a35016
Merge branch 'fewer-bounds' into zed2
2023-10-24 14:24:06 +02:00
Nathan Sobo
0910760b76
Reduce the need for Send + Sync bounds on generics
2023-10-24 14:20:01 +02:00
Marshall Bowers
cf380a9f62
Remove set_ prefix for List setters
2023-10-24 14:18:51 +02:00
Marshall Bowers
24e21a4c29
Merge branch 'zed2' of github.com:zed-industries/zed into zed2
2023-10-24 14:11:22 +02:00
Marshall Bowers
bb35583998
Merge branch 'gpui2' into zed2
2023-10-24 14:11:13 +02:00
Kirill Bulatov
0e48465adb
Add a draft of the mac platform file drag and drop events
2023-10-24 14:09:46 +02:00
Kirill Bulatov
4d5ca37edb
Fix the branch compilation
2023-10-24 14:04:45 +02:00
Kyle Caverly
ff497810dd
move keychain access into semantic index as opposed to on init ( #3158 )
...
remove keychain request during init
Release Notes:
- Move keychain request to inside indexing.
- Move install_default_formatters to a no op during tests
2023-10-24 13:43:10 +02:00
KCaverly
feefb8d063
fixed format! call for prettier::
2023-10-24 13:37:34 +02:00
KCaverly
0dd45bbf21
fully qualify paths inside conditional compilation methods
2023-10-24 13:35:28 +02:00
Marshall Bowers
23ad0a2c58
Return a Result from load_embedded_fonts
2023-10-24 13:31:01 +02:00
KCaverly
8ffe5a3ec7
move keychain access into semantic index as opposed to on init
2023-10-24 13:26:37 +02:00
Antonio Scandurra
9a53da28bc
WIP
2023-10-24 13:10:37 +02:00
Marshall Bowers
f2710f37c5
Fix default font family
2023-10-24 12:49:18 +02:00
Marshall Bowers
785901c75e
Load embedded fonts
2023-10-24 12:32:30 +02:00
Marshall Bowers
171db00f6e
Fix stack overflow
2023-10-24 11:39:15 +02:00
Marshall Bowers
6f5cf10acb
Comment out .state setting
2023-10-24 11:39:10 +02:00
Marshall Bowers
6a532af1fd
Swap the parameters to IconButton
2023-10-24 11:26:19 +02:00
Marshall Bowers
47f979d457
Pass IDs to IconButtons instead of generating them
2023-10-24 11:20:31 +02:00
Julia
48cdefe6cf
Re-understand that the line just below git deletion is "inside" hunk
...
Fixes "go to previous hunk" getting stuck on a deletion, never going
further up
2023-10-24 11:17:42 +02:00
Conrad Irwin
3358420f6a
fix format
2023-10-24 11:17:17 +02:00
Conrad Irwin
2b95db087b
Fix infinite loop in select all ( #3154 )
...
[[PR Description]]
Release Notes:
- Fixed an infinite loop in select all matches
([#2170 ](https://github.com/zed-industries/community/issues/2170 )).
2023-10-24 02:58:48 -06:00
Conrad Irwin
aa6990bb6b
Fix set_channel_visibility for public channels
2023-10-24 10:55:10 +02:00
Conrad Irwin
0e035c1a95
Fix character selection
2023-10-24 10:50:08 +02:00
Antonio Scandurra
953857f8e3
WIP
2023-10-24 10:31:35 +02:00
Antonio Scandurra
18eb4a7292
WIP
2023-10-24 10:01:19 +02:00
Conrad Irwin
e6087e0ed9
Fix tests
2023-10-24 09:46:46 +02:00
Conrad Irwin
67e590202a
vim surround ( #3152 )
...
- Fix some bugs with vim objects
- Add | as a bracket and a motion
- Fix neovim tests with angle brackets
Release Notes:
- vim: Fixed `i` and `a` objects with softwrap, and a few other edge
cases
- vim: Added support for `ci"` to find the next quoted string on the
line
- vim: Added support for `|` as a bracket (for languages like ruby and
rust)
- vim: Added support for `<count>|` to jump to a specific column
2023-10-24 01:33:34 -06:00
Piotr Osiewicz
97a0864134
grammars: Update Bash grammar ( #3155 )
...
Fixes zed-industries/community#2168
Release Notes:
- Updated Bash (Shell script) Tree-sitter grammar (fixes
zed-industries/community#2168 )
2023-10-24 09:16:06 +02:00
Piotr Osiewicz
6c163afb84
bash: Add highlighting of ANSI c string ( #3153 )
...
Fixes zed-industries/community#2169
Release Notes:
- Fixed highlighting of ANSI C strings ($'foo') in "Shell script"
language buffers.
2023-10-24 09:15:35 +02:00
Nate Butler
e99d862f3f
WIP Button Refactor
2023-10-23 14:50:53 -04:00
Nate Butler
c1c9db2ae2
Add elevation enums + docs
2023-10-23 13:50:39 -04:00
Conrad Irwin
ea4e67fb76
Merge branch 'main' into guest-exp
2023-10-23 17:47:21 +02:00
Antonio Scandurra
4d621f355d
WIP
2023-10-23 17:41:22 +02:00
Antonio Scandurra
05cbceec24
WIP
2023-10-23 17:36:49 +02:00
Nate Butler
297cef14ed
WIP add Elevation Docs
2023-10-23 11:21:48 -04:00
KCaverly
0dfbfdd164
catchup with main
2023-10-23 17:21:37 +02:00
Nathan Sobo
192b3512fd
Merge branch 'gpui2-drag-drop' into zed2
2023-10-23 17:18:07 +02:00
Nate Butler
3a326bfa7e
🤦 Remove references to system_color
2023-10-23 11:05:17 -04:00
Nate Butler
dd55ccef34
Merge branch 'n/d' into zed2
2023-10-23 11:01:36 -04:00
Nate Butler
1e13e273d2
Add ThemeColor interface for UI coloring and remove redundancy
2023-10-23 11:01:04 -04:00
Nate Butler
438cf529bb
Remove duplicate ThemeColor defs
2023-10-23 11:00:45 -04:00
Nathan Sobo
ec0b2e5430
Add on_drop listeners
2023-10-23 16:59:16 +02:00
Antonio Scandurra
21d4546a86
WIP
2023-10-23 16:39:30 +02:00
Antonio Scandurra
7832120a4c
WIP
2023-10-23 16:38:34 +02:00
Antonio Scandurra
efbf0c828d
WIP
2023-10-23 16:38:34 +02:00
Nate Butler
c9d214e8ef
Start crate doc
2023-10-23 10:21:30 -04:00
Nathan Sobo
38a7b39070
Don't start dragging until you move to 2px
2023-10-23 16:20:01 +02:00
Nathan Sobo
239b0c2f71
Clear active state when drag starts
2023-10-23 16:10:04 +02:00
Conrad Irwin
6e4e19d8fc
Fix infinite loop in select all
2023-10-23 16:08:12 +02:00
Nate Butler
cc445f7cef
Start scaffolding out the Copilot Modal UI
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-10-23 10:00:02 -04:00
Nathan Sobo
258fcaea94
Position drag handle relative to cursor
2023-10-23 15:20:33 +02:00
Nathan Sobo
fc927f7406
Checkpoint
2023-10-23 15:14:10 +02:00
Nathan Sobo
d1adce5890
Show red box when dragging
2023-10-23 15:09:22 +02:00
Max Brunsfeld
a5836b0337
Add chat mentions and a notifications panel ( #3121 )
...
### Todo
* Displaying notifications
* [x] show them in panel
* [x] indicate read/unread status
* [x] allow requesting more by scrolling down
* [ ] style the panel
* [x] style the status bar icon
* Chat mentions
* [x] highlight mentions when editing message
* [x] persist mentions
* [x] highlight mentions when rendering saved messages
* Creating notifications
* [x] contact request received
* [x] contact request accepted
* [x] channel invitation received
* [x] mentioned in a chat message
* [x] Indicate responses to notifications
* Mark notifications as read
* [x] when viewing a contact request acceptance in the notification
panel
* [x] responding to contact invite
* [x] responding to channel invite
* [x] viewing a channel message mention
* [x] Replace previous notifications with auto-dismissing,
non-interactive toasts
### Release Notes:
- Added a notification panel, which displays notifications about contact
requests and channel invitations.
- Added the ability to `@`-mention users in the chat, so that they will
be notified of your message.
2023-10-23 15:05:05 +02:00
Antonio Scandurra
4e6fb9034d
WIP
2023-10-23 14:59:57 +02:00
Max Brunsfeld
4d491ca3a1
Tweak styling of notifications
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-10-23 14:58:03 +02:00
Max Brunsfeld
2f0eaafc39
Format timestamps more tersely in the notification panel
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-10-23 14:34:38 +02:00
Nathan Sobo
96f2c4a9de
Checkpoint
2023-10-23 14:15:12 +02:00
KCaverly
4e90e45999
move embedding truncation to base model
2023-10-23 14:07:45 +02:00
Max Brunsfeld
8766e5f0d0
Avoid flickering toast when mentioned in already-visible chat channel
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-10-23 13:48:49 +02:00
Piotr Osiewicz
812ff9a97d
Account for markdown styling in mentions offset calculation.
...
This also means that we can support smart punctuation.
Co-authored-by: Max <max@zed.dev >
2023-10-23 12:50:57 +02:00
Antonio Scandurra
a72434f67b
WIP
2023-10-23 12:16:33 +02:00
Antonio Scandurra
c0e8ae5dfa
WIP
2023-10-23 11:53:24 +02:00
Antonio Scandurra
0de4a93ec7
WIP
2023-10-23 11:43:08 +02:00
Nathan Sobo
da8919002f
Fix runtime errors
2023-10-23 11:34:35 +02:00
Antonio Scandurra
5247f217fd
Checkpoint
2023-10-23 11:06:58 +02:00
Antonio Scandurra
56462ef793
Checkpoint
2023-10-23 10:59:29 +02:00
Conrad Irwin
b495669c86
Fix neovim tests with angle brackets
2023-10-22 22:24:35 -06:00
Conrad Irwin
3cf98c4fae
Add | as a bracket and a motion
...
Although vim/nvim doesn't have | as brackets, it's common in langauges like Rust
and Ruby, and I expect it to work.
2023-10-22 22:17:34 -06:00
Conrad Irwin
9589f5573d
Fix some bugs with vim objects
...
- softwrap interaction
- correct selection if cursor is on opening marker
2023-10-22 21:44:34 -06:00
Antonio Scandurra
a0b667a2ca
WIP
2023-10-22 19:56:25 +02:00
Antonio Scandurra
e7c04d4aca
Checkpoint
2023-10-22 18:56:11 +02:00
Antonio Scandurra
72435af170
Checkpoint
2023-10-22 18:34:45 +02:00
Antonio Scandurra
ce75be91e1
Checkpoint
2023-10-22 18:25:24 +02:00
Antonio Scandurra
db6a3e1783
WIP
2023-10-22 18:01:00 +02:00
Max Brunsfeld
763b13e700
Avoid duplicate acks for messages with mentions
2023-10-22 18:00:02 +02:00
Max Brunsfeld
59adcc1744
Load more notifications when scrolling down
2023-10-22 17:10:21 +02:00
Antonio Scandurra
50bbdd5cab
WIP
2023-10-22 16:53:59 +02:00
Antonio Scandurra
5d10dc7e58
WIP
2023-10-22 16:49:14 +02:00
Antonio Scandurra
7171818d24
WIP
2023-10-22 16:36:29 +02:00
Antonio Scandurra
48033463c8
WIP
2023-10-22 16:33:59 +02:00
Antonio Scandurra
6ffeb048b3
WIP
2023-10-22 16:27:23 +02:00
Max Brunsfeld
23400a5a70
Start styling notification panel
2023-10-22 16:03:33 +02:00
Max Brunsfeld
c20e781441
Inherit PATH in zed-local script
2023-10-22 16:03:13 +02:00
KCaverly
2b780ee7b2
add base model to EmbeddingProvider, not yet leveraged for truncation
2023-10-22 15:00:09 +02:00
KCaverly
d1dec8314a
move OpenAIEmbeddings to OpenAIEmbeddingProvider in providers folder
2023-10-22 14:46:22 +02:00
KCaverly
d813ae8845
replace OpenAIRequest with more generalized Box<dyn CompletionRequest>
2023-10-22 14:33:19 +02:00
KCaverly
05ae978cb7
move OpenAICompletionProvider to providers location
2023-10-22 13:57:13 +02:00
KCaverly
3712794e56
move OpenAILanguageModel to providers folder
2023-10-22 13:47:28 +02:00
KCaverly
a62baf34f2
rename templates to prompts in ai crate
2023-10-22 13:46:49 +02:00
KCaverly
0b57ab7303
cleaned up truncate vs truncate start
2023-10-22 13:34:22 +02:00
Antonio Scandurra
5423012368
WIP
2023-10-22 13:15:29 +02:00
Max Brunsfeld
234ccbe51f
Merge branch 'main' into notifications
2023-10-22 12:25:30 +02:00
Max Brunsfeld
4a0358a513
Mark contact acceptance notifications as read automatically
2023-10-22 12:22:47 +02:00
Antonio Scandurra
f4135e6bcf
WIP
2023-10-22 12:21:28 +02:00
Max Brunsfeld
fce09e8c92
Mark chat mention notifications as read when viewing the message
2023-10-22 11:57:10 +02:00
Nathan Sobo
909fbb9538
Checkpoint
2023-10-21 19:07:59 +02:00
Nathan Sobo
89f4718ea1
Checkpoint
2023-10-21 18:48:30 +02:00
Antonio Scandurra
2e2825ae98
WIP
2023-10-21 18:41:09 +02:00
Antonio Scandurra
3740c9d852
WIP
2023-10-21 18:33:08 +02:00
Antonio Scandurra
7bb99c9b9c
WIP
2023-10-21 18:30:44 +02:00
Antonio Scandurra
aa3fb28f81
WIP
2023-10-21 18:21:14 +02:00
Antonio Scandurra
b7d30fca2b
WIP
2023-10-21 17:52:47 +02:00
Kyle Caverly
ef1a69156d
update semantic search to use keychain as fallback ( #3151 )
...
Use the keychain for authenticating as fallback when api_key is not
present in environment variables.
Release Notes:
- Add consistency between OPENAI_API_KEY management in Semantic Search
and Assistant
2023-10-21 10:34:32 -04:00
KCaverly
4835c77840
update text for project search if not authenticated
2023-10-21 10:28:54 -04:00
KCaverly
106115676d
update semantic search to use keychain as fallback
2023-10-21 10:19:50 -04:00
Antonio Scandurra
e4fe9538d7
Checkpoint
2023-10-21 16:01:47 +02:00
Antonio Scandurra
f3979a9f28
Checkpoint
2023-10-21 15:59:52 +02:00
Piotr Osiewicz
fc37abc356
vcs_menu: Query branches on open instead of per keystroke ( #3144 )
...
Release Notes:
- Improved performance of branch picker by querying branches on menu
open instead of querying once per each keystroke. (fixes
zed-industries/community#2161 )
2023-10-21 14:01:01 +02:00
Mikayla
b8936e5fca
Finish room initialization concurrency test
2023-10-21 03:15:18 -07:00
Mikayla
7e4de2ac16
Restore synchronization
2023-10-21 03:08:25 -07:00
Mikayla
5365fd2149
WIP: Add test for panic, temporarily rollback synchronization changes
2023-10-21 03:05:57 -07:00
Kirill Bulatov
26638748bb
Move prettier parsers data into languages from LSP adapters ( #3150 )
...
Release Notes:
- Fixed incorrect prettier parsers sometimes being applied to certain
files
2023-10-21 02:22:21 +03:00
Kirill Bulatov
7748848b6e
Move prettier parsers data into languages from LSP adapters
2023-10-21 01:14:03 +02:00
Conrad Irwin
0dae0f6027
pixel columns ( #3052 )
...
@ForLoveOfCats and I found a few speedups that make this acceptably fast
(able to update ~10k selections in <100ms), so the remaining work here
is to fix the tests, and then ship!
Release notes:
- Updated up/down to work based on pixel positions
([#1966 ](https://github.com/zed-industries/community/issues/1966 ))
([#759 ](https://github.com/zed-industries/community/issues/759 ))
- vim: Fixed off-by-one in visual block mode
([2123](https://github.com/zed-industries/community/issues/2123 ))
2023-10-20 15:01:27 -06:00
Conrad Irwin
2de34a905d
Hide any circumstantial evidence that this didn't work perfectly first
...
time
2023-10-20 14:45:37 -06:00
Marshall Bowers
7719ed0d6c
Remove unnecessary iterator
2023-10-20 16:34:33 -04:00
Conrad Irwin
fd8e6110b1
Fix panic by disallowing multiple room joins
2023-10-20 14:34:25 -06:00
Conrad Irwin
15fe2627d0
Remove screen sharing indicator ( #3148 )
...
Release Notes:
- Removed the screen-sharing indicator from calls. Newer versions of
macOS have a better indicator, and ours panics when you click on it.
2023-10-20 14:33:45 -06:00
Marshall Bowers
cbdd1d6d6c
Use children instead of when
2023-10-20 16:30:52 -04:00
Marshall Bowers
080638216a
Wire up NotificationsPanel story
2023-10-20 16:30:45 -04:00
Marshall Bowers
4dc2440024
Enable text wrapping for Details
2023-10-20 16:13:54 -04:00
Marshall Bowers
a6d8915b6c
Document more styles
2023-10-20 15:59:47 -04:00
Conrad Irwin
f422a3c5d0
Add "workspace: Toggle Vim Mode" ( #3147 )
...
Co-Authored-By: Marshall <elliott.codes@gmail.com >
Release Notes:
- vim: Add "Toggle Vim Mode" command
2023-10-20 13:07:51 -06:00
Conrad Irwin
31872227f1
Remove screen sharing indicator
...
This is now redundant given macOS has the same icon, and it panics when
you click on it :D.
2023-10-20 13:04:45 -06:00
Conrad Irwin
fae5b1e391
Fix build columnar selection logic
2023-10-20 12:55:41 -06:00
Conrad Irwin
43d682f6b8
Handle pixel-down to last line when no trailing newline
2023-10-20 12:46:14 -06:00
Conrad Irwin
352a554c74
Fix bug in vim visual block mode
2023-10-20 11:49:10 -06:00
Conrad Irwin
c7991ef04c
Add "workspace: Toggle Vim Mode"
...
Co-Authored-By: Marshall <elliott.codes@gmail.com >
2023-10-20 11:41:13 -06:00
Conrad Irwin
1c36134cf9
Fix single column vim selections
2023-10-20 11:17:19 -06:00
Conrad Irwin
b596b4153f
Fix test
2023-10-20 10:34:09 -06:00
Julia
cc7df91cc6
Whoops ( #3146 )
...
Whoops, this is what I get for working past-midnight lol, I never pushed
the last commit for https://github.com/zed-industries/zed/pull/3141 so
this PR remedies that
Release Notes:
- NA
2023-10-20 12:07:33 -04:00
Julia
7c3a8a3774
Add Tailwind autocomplete in ERB, PHP, and Laravel Blade
2023-10-20 12:06:05 -04:00
Julia
808976ee28
Magic incantations for Tailwind autocomplete in more languages ( #3141 )
...
Release Notes:
- Added Tailwind autocomplete to Svelte files
([#2029 ](https://github.com/zed-industries/community/issues/2029 )).
- Added Tailwind autocomplete to Phoenix HEEX files
([#2057 ](https://github.com/zed-industries/community/issues/2057 )).
- Added Tailwind autocomplete to Phoenix ~H sigil in Elixir files
([#2057 ](https://github.com/zed-industries/community/issues/2057 )).
- Added Tailwind autocomplete to ERB files
([#2153 ](https://github.com/zed-industries/community/issues/2153 )).
- Added Tailwind autocomplete to PHP files
([#2159 ](https://github.com/zed-industries/community/issues/2159 )).
- Added Tailwind autocomplete to Laravel Blade files
([#2159 ](https://github.com/zed-industries/community/issues/2159 )).
2023-10-20 12:02:55 -04:00
Antonio Scandurra
825c352b6a
Checkpoint
2023-10-20 17:58:37 +02:00
Marshall Bowers
b0b7f27f3a
Merge branch 'gpui2' of github.com:zed-industries/zed into gpui2
2023-10-20 11:32:11 -04:00
Marshall Bowers
c831c5749a
Remove more unneeded Clone bounds
2023-10-20 11:32:10 -04:00
Antonio Scandurra
1409fc0da3
Checkpoint
2023-10-20 17:31:47 +02:00
Marshall Bowers
901af8de3f
Remove Clone bound from Avatar
2023-10-20 11:13:13 -04:00
Marshall Bowers
d9a030157e
Remove Clone bound from Keybinding
2023-10-20 11:12:37 -04:00
Marshall Bowers
a0996c1807
Remove Clone bound from ChatMessage
2023-10-20 11:10:13 -04:00
Antonio Scandurra
a3dcaf21cb
Checkpoint
2023-10-20 16:31:03 +02:00
Antonio Scandurra
8ad7ebf02f
Checkpoint
2023-10-20 16:31:00 +02:00
Piotr Osiewicz
e32aa95092
Touch up render function
2023-10-20 15:33:55 +02:00
Piotr Osiewicz
6844bb6510
Highlight mentions in the Saved chat messages
2023-10-20 15:30:36 +02:00
Antonio Scandurra
47aa387b91
Checkpoint
2023-10-20 15:13:53 +02:00
Antonio Scandurra
6150df71b2
Checkpoint
2023-10-20 15:08:54 +02:00
Antonio Scandurra
fd94f2a5b5
Checkpoint
2023-10-20 12:59:02 +02:00
Antonio Scandurra
847a1cb068
Checkpoint
2023-10-20 12:23:22 +02:00
Antonio Scandurra
c1f7c9bb87
Checkpoint
2023-10-20 12:12:06 +02:00
Antonio Scandurra
ac181183cc
Checkpoint
2023-10-20 11:46:29 +02:00
Antonio Scandurra
8a11053f1f
Checkpoint
2023-10-20 11:44:19 +02:00
Antonio Scandurra
b0acaed02f
Checkpoint
2023-10-20 11:08:24 +02:00
Antonio Scandurra
c3a917f8b3
Checkpoint
2023-10-20 11:02:00 +02:00
Antonio Scandurra
766ee836b5
Checkpoint
2023-10-20 11:00:52 +02:00
Antonio Scandurra
68bc22f9cd
Checkpoint
2023-10-20 10:55:06 +02:00
Conrad Irwin
e03e5364d2
Wire through LiveKit permissions
2023-10-19 23:23:33 -06:00
Conrad Irwin
aa4b8d7246
Fix notifications for membership changes too
2023-10-19 23:05:06 -06:00
Nate Butler
0609628645
List actions for ListDetailsEntries
2023-10-19 20:17:41 -04:00
Nate Butler
32028fbbb1
Checkpoint – Notifications Panel
2023-10-19 20:04:21 -04:00
Antonio Scandurra
e3d948f60b
Checkpoint
2023-10-19 23:56:43 +02:00
Antonio Scandurra
40c6f738b4
Checkpoint
2023-10-19 23:54:17 +02:00
Antonio Scandurra
296fc92721
Checkpoint
2023-10-19 23:47:32 +02:00
Antonio Scandurra
21b4ae3fdc
Merge
2023-10-19 23:40:38 +02:00
Antonio Scandurra
d69105bb77
Checkpoint
2023-10-19 23:39:22 +02:00
Antonio Scandurra
4a6c8ff809
Checkpoint
2023-10-19 23:35:09 +02:00
Antonio Scandurra
1f6d9369d6
Checkpoint
2023-10-19 23:30:14 +02:00
Antonio Scandurra
3a70f02cbf
Checkpoint
2023-10-19 23:21:26 +02:00
Max Brunsfeld
44cb55fbe9
Fix scrolling to messages on clicking of notifications
2023-10-19 14:04:34 -07:00
Antonio Scandurra
dd7e1c505c
Checkpoint
2023-10-19 23:00:19 +02:00
Marshall Bowers
94f0140f62
Assign each IconButton an ID based on the icon
2023-10-19 16:50:33 -04:00
Marshall Bowers
28b29d0985
Give each Tab its own ID
2023-10-19 16:42:21 -04:00
Marshall Bowers
52f2521f6a
Wire up active style for Tab
2023-10-19 16:37:54 -04:00
Marshall Bowers
e1e8b63eb5
Remove Clone bound from IconElement
2023-10-19 16:37:15 -04:00
Marshall Bowers
a1aba32209
Remove Clone bound from Button and Details
2023-10-19 16:35:44 -04:00
Marshall Bowers
fa3916d1bf
Remove Clone bound for HighlightedLabel
2023-10-19 16:34:08 -04:00
Marshall Bowers
3ac7ef90ef
Remove Clone bound for Input
2023-10-19 16:32:48 -04:00
Marshall Bowers
4050bf43c4
Remove Clone bound for Label
2023-10-19 16:31:24 -04:00
Max Brunsfeld
851d7d0bc4
Rename NewNotification proto message to AddNotification
2023-10-19 13:29:14 -07:00
Antonio Scandurra
0fbf84e6bc
Checkpoint
2023-10-19 22:28:42 +02:00
Marshall Bowers
d91b423a45
Remove unused Interactive impl for FakeSettings
2023-10-19 16:16:09 -04:00
Marshall Bowers
2bbce2f0fd
Merge branch 'gpui2' of github.com:zed-industries/zed into gpui2
2023-10-19 16:14:39 -04:00
Marshall Bowers
1be1bffb29
Wire up active style for Breadcrumb
2023-10-19 16:13:25 -04:00
Marshall Bowers
92542e6b94
Identify IconButton
2023-10-19 16:12:21 -04:00
Kyle Caverly
9c49191031
decrease temperature for inline assist on code content ( #3145 )
...
"Temperature" is a parameter in OpenAI GPT models, to control for
randomess in the generated content. To decrease the probability of
either escaping the markdown blocks and creating invalid code, we
decreased temperature for all Non-Prose files. For Markdown or Plain
Text, in which more creativity may be a good thing, we increase the
temperature to allow for more randomness. Along with this, we ask the
generate inline prompt to include only the code and not markdown blocks,
as it appears that lower temperature may decrease the probability of
introducing random markdown blocks.
Release Notes (Internal Only):
- Decrease temperature for inline assist on code content.
2023-10-19 16:11:29 -04:00
Marshall Bowers
3932c1064e
Merge branch 'gpui2' into gpui2-theme-to-color
2023-10-19 16:10:44 -04:00
Antonio Scandurra
d446b91117
Checkpoint
2023-10-19 22:10:39 +02:00
Antonio Scandurra
673257bbbc
Checkpoint
2023-10-19 22:05:01 +02:00
Antonio Scandurra
180ed7da81
Checkpoint
2023-10-19 22:05:01 +02:00
Antonio Scandurra
38d8ab2285
Checkpoint
2023-10-19 22:05:01 +02:00
Antonio Scandurra
c17a4d8453
Checkpoint
2023-10-19 22:05:01 +02:00
Antonio Scandurra
e74285f6d2
Checkpoint
2023-10-19 22:05:01 +02:00
Max Brunsfeld
33f06d3104
Index notifications to allow faster lookup by kind, entity id
2023-10-19 13:03:27 -07:00
Max Brunsfeld
841cfac1f8
Fix filtering when providing non-admins info about channel members
2023-10-19 12:54:47 -07:00
KCaverly
71fb23f769
decrease temperature for inline assist on code content
2023-10-19 15:44:49 -04:00
Max Brunsfeld
150ed641ae
Render read notifications in a different color
2023-10-19 12:40:10 -07:00
Max Brunsfeld
5b90507310
Navigate to chat messages when clicking them in the notification panel
2023-10-19 12:31:45 -07:00
Conrad Irwin
0eff7c6ca9
Add read-only channel notes support
...
Fix some bugs where ChannelNotes and ChannelChat had old cached channel
instances
2023-10-19 13:20:49 -06:00
Marshall Bowers
2189983323
Add missing Clone bounds
2023-10-19 15:02:00 -04:00
Kyle Caverly
e45491d2f8
Introduction of PromptTemplate and PromptChains ( #3139 )
...
(This PR was written 100% by the Inline Assistant)
This PR brings in new components into our ai and assistant crates namely
PromptTemplate and PromptChains. They offer a new way to generate
prompts that allow for a more flexible and dynamic approach than before.
Release Notes:
- Introduced PromptTemplate: an abstract base for individual parts of
the prompt.
- Added PromptChains: manage multiple PromptTemplates, sort them based
on priority and regulate the output size based on tokens.
- Provided new PromptArguments structure to encapsulate arguments needed
for PromptTemplate.
- Extended repository_context to include PromptCodeSnippet.
2023-10-19 14:44:43 -04:00
Nate Butler
58650b7d2d
Checkpoint - Still Broken
2023-10-19 14:38:01 -04:00
KCaverly
19c2df4822
outlined when truncation is taking place in the prompt
2023-10-19 14:33:52 -04:00
Marshall Bowers
d5fc831321
Restore more active styles
2023-10-19 14:23:45 -04:00
Marshall Bowers
743949753a
Fix mutual-exclusivity of right panels
2023-10-19 14:19:10 -04:00
Marshall Bowers
184f5f2397
Restore active styles for Inputs
2023-10-19 14:17:35 -04:00
Marshall Bowers
597aa0475e
Remove unused import
2023-10-19 14:10:13 -04:00
Marshall Bowers
70984faee2
Merge branch 'gpui2' of github.com:zed-industries/zed into gpui2
2023-10-19 14:06:35 -04:00
Marshall Bowers
e657e4d1d1
Wire up livestream debug toggle
2023-10-19 14:06:31 -04:00
Max Brunsfeld
d62f114c02
Create notifications for mentioned users
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-10-19 10:52:40 -07:00
Antonio Scandurra
9e20ccc01a
Checkpoint
2023-10-19 19:51:05 +02:00
Antonio Scandurra
1343ea66c9
Checkpoint
2023-10-19 19:51:05 +02:00
Antonio Scandurra
2b90b8d6b7
Checkpoint
2023-10-19 19:51:05 +02:00
Antonio Scandurra
90d34c1251
Checkpoint
2023-10-19 19:51:05 +02:00
Antonio Scandurra
93ff79febf
Checkpoint
2023-10-19 19:51:05 +02:00
Antonio Scandurra
7fef03a7db
Checkpoint
2023-10-19 19:51:05 +02:00
Antonio Scandurra
30269381e8
Checkpoint
2023-10-19 19:51:05 +02:00
Antonio Scandurra
9985f388ac
Checkpoint
2023-10-19 19:51:05 +02:00
Marshall Bowers
a869de3b1f
Add ability to toggle user settings
2023-10-19 13:38:19 -04:00
Marshall Bowers
4aac733238
Pass the settings to build_child
2023-10-19 13:23:08 -04:00
Marshall Bowers
7ed891e0c6
Merge branch 'gpui2' into gpui2ui-debug-panel
2023-10-19 13:04:37 -04:00
Marshall Bowers
a1f7a97ff5
Pull the settings from the global state
2023-10-19 13:02:32 -04:00
Nate Butler
bca97f7186
Checkpoint – Broken
2023-10-19 12:58:17 -04:00
Marshall Bowers
61e09ff532
Checkpoint: Thread WindowContext through to user_settings
2023-10-19 12:58:17 -04:00
Nate Butler
8e465b4393
Add basic debug panel
2023-10-19 12:09:39 -04:00
Marshall Bowers
b16d37953d
Use line_height in z_index stories
2023-10-19 12:06:05 -04:00
Marshall Bowers
f5c76d93bc
Add missing Arc for on_click handler
2023-10-19 10:25:54 -04:00
Antonio Scandurra
98c0e00a2c
Checkpoint
2023-10-19 15:52:17 +02:00
Antonio Scandurra
3d8e9a593e
Checkpoint
2023-10-19 15:44:02 +02:00
Antonio Scandurra
ffa3362e16
Checkpoint
2023-10-19 15:36:37 +02:00
Kirill Bulatov
999e9c3d5d
Sort hint request ranges before asserting to avoid flackiness ( #3142 )
2023-10-19 11:11:47 +03:00
Kirill Bulatov
40104c06e2
Sort hint request ranges before asserting to avoid flackiness
2023-10-19 11:05:47 +03:00
Julia
36731ba6b3
Magic incantations for Tailwind autocomplete in Svelte, Elixir ~H, Heex
2023-10-19 01:54:42 -04:00
Conrad Irwin
9d07561d99
Merge branch 'main' into pixel-columns
2023-10-18 23:00:56 -06:00
Conrad Irwin
3eb8aa8085
Refactor TextLayoutDetails construction
2023-10-18 22:56:11 -06:00
Conrad Irwin
138fa45ecb
recert config change
2023-10-18 22:23:38 -06:00
Conrad Irwin
cb76b2a6ad
Make vim visual block work better
2023-10-18 22:23:06 -06:00
Conrad Irwin
3853009d92
Refactor to avoid some (mostly hypothetical) races
...
Tidy up added code to reduce duplicity of X and X_internals.
2023-10-18 21:42:10 -06:00
Max Brunsfeld
5257fb8533
Fix compile error in db seed executable
2023-10-18 18:05:51 -07:00
Max Brunsfeld
ac54d2b927
Fix possibility of extra mention insertion on nonce collision
2023-10-18 18:04:56 -07:00
Nate Butler
e34a488b55
WIP
2023-10-18 20:58:24 -04:00
Max Brunsfeld
b07f9fe3b5
Merge branch 'main' into notifications
2023-10-18 17:20:04 -07:00
Max Brunsfeld
d05404a4df
Persist chat mentions
2023-10-18 16:56:03 -07:00
Nate Butler
c22778bd92
Remove debugs
2023-10-18 19:15:17 -04:00
Nate Butler
65828c14fc
Use ui_size to build icon button
2023-10-18 19:12:02 -04:00
KCaverly
178a84bcf6
progress on smarter truncation strategy for file context
2023-10-18 17:56:59 -04:00
Conrad Irwin
2b11463567
Fix notifications on channel changes
2023-10-18 15:56:33 -06:00
Nate Butler
7cb00aeb34
Update line heights, buttons to respond to UI scale
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-10-18 17:55:17 -04:00
Nate Butler
7b2782c0f6
Use ui_size to set relative font sizes
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-10-18 17:02:57 -04:00
KCaverly
587fd707ba
added smarter error handling for file_context prompts without provided buffers
2023-10-18 16:40:09 -04:00
KCaverly
f59f2eccd5
added dumb truncation strategies to file_context and generate
2023-10-18 16:32:14 -04:00
KCaverly
a0e01e075d
fix for error when truncating a length less than the string length
2023-10-18 16:31:29 -04:00
Nate Butler
3f076eeda6
Remove unused code from storybook 2
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-10-18 16:27:34 -04:00
KCaverly
32853c2044
added initial placeholder for truncation without a valid strategy
2023-10-18 16:23:53 -04:00
Nate Butler
a35d350cbd
Update storybook2 to run the workspace by default
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-10-18 16:21:04 -04:00
Nate Butler
a6a50113da
Merge branch 'n/gpui2ui-settings' into gpui2
2023-10-18 16:17:57 -04:00
Nate Butler
8b637e194e
Update approach to settings
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-10-18 16:16:58 -04:00
KCaverly
473067db31
update PromptPriority to accomodate for both Mandatory and Ordered prompts
2023-10-18 15:56:39 -04:00
Nate Butler
289255d67a
Update UI elements and implement user settings for customization
2023-10-18 15:42:10 -04:00
Max Brunsfeld
199740902a
Fix possibility of infinite loop in selections_with_autoclose_regions ( #3138 )
...
Previously, that method could loop forever if the editor's autoclose
regions had unexpected selection ids.
Something must have changed recently that allowed this invariant to be
violated, but regardless, this code should not have relied on that
invariant to terminate like this.
2023-10-18 11:34:35 -07:00
Marshall Bowers
549e78d7b3
Use SharedString for Inputs
2023-10-18 14:28:28 -04:00
KCaverly
aa1825681c
update the assistant panel to use new prompt templates
2023-10-18 14:20:12 -04:00
Marshall Bowers
5a42ca6772
Merge branch 'gpui2' of github.com:zed-industries/zed into gpui2
2023-10-18 14:19:29 -04:00
Marshall Bowers
8dad3ad8ea
Use SharedString for Lists
2023-10-18 14:19:26 -04:00
Max Brunsfeld
655c9ece2d
Fix possibility of infinite loop in selections_with_autoclose_regions
...
Previously, that method could loop forever if the editor's autoclose
regions had unexpected selection ids.
Co-authored-by: Piotr <piotr@zed.dev >
2023-10-18 11:16:14 -07:00
Antonio Scandurra
159d798c34
Checkpoint
2023-10-18 20:13:19 +02:00
Marshall Bowers
856d23626f
Use SharedString for Palette and PaletteItems
2023-10-18 14:03:13 -04:00
Antonio Scandurra
8890636a56
Checkpoint
2023-10-18 19:30:53 +02:00
Joseph T. Lyons
4e68b588be
collab 0.25.0
2023-10-18 13:17:17 -04:00
KCaverly
b9bb27512c
fix template ordering during prompt chain generation
2023-10-18 13:10:31 -04:00
KCaverly
fa61c1b9c1
add prompt template for generate inline content
2023-10-18 13:03:11 -04:00
Antonio Scandurra
a0634fa79e
Checkpoint
2023-10-18 18:39:47 +02:00
Antonio Scandurra
03937a9f89
WIP
2023-10-18 18:39:47 +02:00
Marshall Bowers
24086191af
Split Label and HighlightedLabel
2023-10-18 12:37:47 -04:00
Joseph T. Lyons
cf429ba284
v0.110.x dev
2023-10-18 12:31:12 -04:00
KCaverly
178a79fc47
added prompt template for file context without truncation
2023-10-18 12:29:10 -04:00
Marshall Bowers
f0b9e9a89d
Use SharedString for Keybindings
2023-10-18 12:26:51 -04:00
Piotr Osiewicz
99121ad5cd
buffer_search: Discard empty search suggestions. ( #3136 )
...
Now when buffer_search::Deploy action is triggered (with cmd-f), we'll
keep the previous query in query_editor (if there was one) instead of
replacing it with empty query.
This addresses this bit of feedback from Jose:
> If no text is selected, `cmd + f` should not delete the text in the
search bar when refocusing
Release Notes:
- Improved buffer search by not clearing out query editor when no text
is selected and "buffer search: deploy" (default keybind: cmd-f) is
triggered.
2023-10-18 18:05:13 +02:00
Marshall Bowers
6e3393c93f
Use SharedString for Buttons
2023-10-18 10:59:42 -04:00
Marshall Bowers
aa41f97e38
Merge branch 'gpui2' of github.com:zed-industries/zed into gpui2
2023-10-18 10:58:54 -04:00
Marshall Bowers
2b53c67789
Use SharedString for Labels
2023-10-18 10:58:50 -04:00
Antonio Scandurra
731ce1721a
Checkpoint
2023-10-18 16:55:55 +02:00
Marshall Bowers
8321b9430e
Wire up hover styles on Buttons
2023-10-18 10:53:42 -04:00
Marshall Bowers
7f69350e4d
Fix typo in doc comment
2023-10-18 10:45:20 -04:00
Marshall Bowers
1a156c1060
Merge branch 'gpui2' of github.com:zed-industries/zed into gpui2
2023-10-18 10:44:43 -04:00
Antonio Scandurra
7149f99f02
Checkpoint
2023-10-18 16:43:20 +02:00
Marshall Bowers
5491398a64
Merge branch 'gpui2' into gpui2-ui
2023-10-18 10:43:15 -04:00
KCaverly
4b8771f3e2
Merge branch 'main' of github.com:zed-industries/zed into prompt_template
2023-10-18 10:42:16 -04:00
Kyle Caverly
fea6d70d4d
return code inside a markdown block during inline assist ( #3137 )
...
Reverted prior small change in inline prompting.
We should now only return code in a markdown block during inline
assists.
2023-10-18 10:40:53 -04:00
Antonio Scandurra
0e4bd485e0
Checkpoint
2023-10-18 16:36:48 +02:00
KCaverly
ed8a2c8793
revert change to return only the text and inside return all text inside markdown blocks
2023-10-18 10:35:11 -04:00
Antonio Scandurra
fecb27232e
Checkpoint
2023-10-18 16:30:48 +02:00
Antonio Scandurra
f58a9bad42
Checkpoint
2023-10-18 16:30:03 +02:00
Antonio Scandurra
f4d50c4dca
Checkpoint
2023-10-18 16:27:58 +02:00
Antonio Scandurra
036e266bae
Checkpoint
2023-10-18 16:21:52 +02:00
Antonio Scandurra
d98c347902
Checkpoint
2023-10-18 16:13:36 +02:00
Antonio Scandurra
1270bcc6ed
Checkpoint
2023-10-18 16:10:58 +02:00
Antonio Scandurra
8914b94577
Checkpoint
2023-10-18 15:46:17 +02:00
Antonio Scandurra
acca8ea786
Checkpoint
2023-10-18 15:24:35 +02:00
Antonio Scandurra
eaef1c8b8e
Checkpoint
2023-10-18 15:17:22 +02:00
Antonio Scandurra
0dfe70125b
Checkpoint
2023-10-18 14:41:46 +02:00
Antonio Scandurra
5afd83c883
Checkpoint
2023-10-18 14:36:16 +02:00
Mikayla
0ce1ec5d15
Restrict DAG-related functionality, but retain infrastructure for implementing symlinks
2023-10-18 05:28:05 -07:00
Antonio Scandurra
a61b34cab5
Checkpoint
2023-10-18 14:12:50 +02:00
Antonio Scandurra
ad1b96720a
Checkpoint
2023-10-18 13:36:26 +02:00
Antonio Scandurra
296a2b8e5d
Rename fill to bg
2023-10-18 09:39:23 +02:00
Antonio Scandurra
597a9f9548
Use text color to paint SVGs
2023-10-18 09:39:20 +02:00
Antonio Scandurra
e031718747
Checkpoint
2023-10-18 09:22:49 +02:00
Antonio Scandurra
6452ff203e
Checkpoint
2023-10-18 09:15:44 +02:00
Conrad Irwin
70aed4a605
Sync Role as part of channels
...
Begin to fix guest notifications
2023-10-17 22:48:44 -06:00
Max Brunsfeld
821419ee5b
Add a unit test for the mention-searching logic in MessageEditor
2023-10-17 20:15:49 -07:00
Conrad Irwin
72ed8a6dd2
Allow guests to chat
2023-10-17 19:03:02 -06:00
Max Brunsfeld
ee87ac2f9b
Start work on chat mentions
2023-10-17 17:59:42 -07:00
Max Brunsfeld
660021f5e5
Fix more issues with the channels panel
...
* Put the newest notifications at the top
* Have at most 1 notification toast, which is non-interactive,
but focuses the notification panel on click, and auto-dismisses
on a timer.
2023-10-17 15:43:06 -07:00
Conrad Irwin
783f05172b
Make sure guests join as guests
2023-10-17 15:40:23 -06:00
Marshall Bowers
79e0509bf9
Begin documenting flex styles
2023-10-17 17:32:30 -04:00
KCaverly
02853bbd60
added prompt template for repository context
2023-10-17 17:29:07 -04:00
Marshall Bowers
218922d9f8
Document gap styles
2023-10-17 17:21:52 -04:00
Marshall Bowers
7a2b04a5d1
Document border width styles
2023-10-17 16:47:37 -04:00
Marshall Bowers
dc32e56a9c
Document rounded styles
2023-10-17 16:35:21 -04:00
Marshall Bowers
490cc7ded6
Add more placeholder doc strings
2023-10-17 16:24:36 -04:00
KCaverly
a874a09b7e
added openai language model tokenizer and LanguageModel trait
2023-10-17 16:21:03 -04:00
Antonio Scandurra
4db0350f06
Checkpoint
2023-10-17 22:16:48 +02:00
Marshall Bowers
edc52e5b28
Tweak grammar
2023-10-17 16:16:38 -04:00
Marshall Bowers
a1a1284696
Document top/right/bottom/left styles
2023-10-17 16:13:55 -04:00
Marshall Bowers
6f849e8f64
Document padding styles
2023-10-17 16:10:30 -04:00
Marshall Bowers
3e32504526
Document .size()
2023-10-17 16:07:52 -04:00
Marshall Bowers
6e84d3cce0
Document margin styles
2023-10-17 16:06:11 -04:00
Marshall Bowers
8c02de6c61
Document width and height styles
2023-10-17 16:06:07 -04:00
Marshall Bowers
f09df31480
Emit doc strings for custom value setters
2023-10-17 16:01:36 -04:00
Antonio Scandurra
a8697df9e3
Checkpoint
2023-10-17 21:54:28 +02:00
Marshall Bowers
6f30d6b4d0
Add placeholder doc strings for style prefixes
2023-10-17 15:53:54 -04:00
Joseph T. Lyons
13c7bbbac6
Shorten GitHub release message
2023-10-17 15:47:17 -04:00
Conrad Irwin
cc390ba862
Start writing role to database ( #3120 )
...
Scaffolding for guest members in channels
Release notes:
- You can now set channels to "public" which will allow anyone to join
and become a member. In a future release guests joining public channels
will have reduced permissions.
2023-10-17 13:40:58 -06:00
Antonio Scandurra
61490fbaa8
Checkpoint
2023-10-17 21:40:24 +02:00
Antonio Scandurra
4ce7f059c3
Checkpoint
2023-10-17 21:37:09 +02:00
Conrad Irwin
04a28fe831
Fix lint errors
2023-10-17 13:32:08 -06:00
Conrad Irwin
1c5e07f4a2
update sidebar for public channels
2023-10-17 13:30:09 -06:00
Antonio Scandurra
deb0e57c49
Checkpoint
2023-10-17 21:11:52 +02:00
Kyle Caverly
2795091f0c
Introduce Context Retrieval in Inline Assistant ( #3097 )
...
This PR introduces a new Inline Assistant feature "Retrieve Context", to
dynamically fill the content in your generation prompt based on relevant
results returned from the Semantic Search for the Prompt.
Release Notes:
- Introduce "Retrieve Context" button in Inline Assistant
2023-10-17 15:04:36 -04:00
Kirill Bulatov
c380d437c6
Cap every language server logs ( #3134 )
...
* on opening a language server's logs, a new editor for server logs is
now created from `\n`-joined `VecDeque` elements instead of a buffer, as
before
* every `VecDeque` entry is a log line we receiver out of stderr or LSP
server, and their general amount is capped with `let
MAX_STORED_LOG_ENTRIES: usize = 2000;`
* currently opened editor with logs (`Editor::multi_line`) keeps getting
log lines appended and may get over this cap, but only last stored 2000
entries will be restored on reopen
* similarly, cap rpc message logs
Release Notes:
- Improved memory usage by storing less language LSP server and rpc logs
2023-10-17 21:51:21 +03:00
Kirill Bulatov
a95cce9a60
Reduce max log lines, clean log buffers better
2023-10-17 21:47:21 +03:00
Kirill Bulatov
08af830fd7
Do not create buffers for rpc logs
2023-10-17 21:43:34 +03:00
Kirill Bulatov
c872c86c4a
Remove another needless log buffer
2023-10-17 21:43:34 +03:00
Kirill Bulatov
ba5c188630
Update editor with current buffer logs
2023-10-17 21:43:34 +03:00
Kirill Bulatov
5a4161d293
Do not detach subscriptions
2023-10-17 21:43:34 +03:00
Kirill Bulatov
33296802fb
Add a rough prototype
2023-10-17 21:43:34 +03:00
Max Brunsfeld
52834dbf21
Add notifications integration test
2023-10-17 11:21:38 -07:00
Nate Butler
8db389313b
Add link & public icons
2023-10-17 13:34:51 -04:00
Max Brunsfeld
f2d36a47ae
Generalize notifications' actor id to entity id
...
This way, we can retrieve channel invite notifications when
responding to the invites.
2023-10-17 10:34:50 -07:00
Piotr Osiewicz
31241f48be
workspace: Do not scan for .gitignore files if a .git directory is encountered along the way ( #3135 )
...
Partially fixes zed-industries/community#575
This PR will see one more fix to the case I've spotted while working on
this: namely, if a project has several nested repositories, e.g for a
structure:
/a
/a/.git/
/a/.gitignore
/a/b/
/a/b/.git/
/a/b/.gitignore
/b/ should not account for a's .gitignore at all - which is sort of
similar to the fix in commit #c416fbb, but for the paths in the project.
The release note is kinda bad, I'll try to reword it too.
- [ ] Improve release note.
- [x] Address the same bug for project files.
Release Notes:
- Fixed .gitignore files beyond the first .git directory being respected
by the worktree (zed-industries/community#575 ).
2023-10-17 18:56:03 +02:00
Antonio Scandurra
19c1a54fea
WIP
2023-10-17 18:45:01 +02:00
Antonio Scandurra
850d43c1e8
WIP
2023-10-17 18:37:53 +02:00
Conrad Irwin
5b39fc8123
Temporarily join public channels as a member
2023-10-17 10:29:43 -06:00
Antonio Scandurra
ec368c8102
WIP
2023-10-17 18:28:58 +02:00
Conrad Irwin
3412becfc5
Fix some tests
2023-10-17 10:15:20 -06:00
Max Brunsfeld
f225039d36
Display invite response buttons inline in notification panel
2023-10-17 09:12:55 -07:00
Conrad Irwin
2456c077f6
Fix channel test ordering
2023-10-17 10:01:31 -06:00
KCaverly
ad92fe49c7
implement initial concept of prompt chain
2023-10-17 11:58:45 -04:00
Conrad Irwin
9cc55f895c
Merge branch 'main' into guests
2023-10-17 09:54:17 -06:00
Conrad Irwin
851701cb6f
Fix get_most_public_ancestor
2023-10-17 09:41:34 -06:00
Antonio Scandurra
c04171abf6
WIP
2023-10-17 13:32:49 +02:00
Antonio Scandurra
488d08b43c
WIP
2023-10-17 12:46:50 +02:00
Mikayla
465d726bd4
Minor adjustments
2023-10-17 03:05:01 -07:00
Antonio Scandurra
18abb068b1
Checkpoint
2023-10-17 11:35:48 +02:00
Antonio Scandurra
cec5280013
Checkpoint
2023-10-17 11:31:13 +02:00
Mikayla Maki
adabf0107f
Update IDs on interactive elements in LSP log viewer ( #3133 )
...
This PR fixes a panic in the LSP log viewer when rendering the popover
UI. This did not ship to preview or stable, and so does not require a
release note.
Release Notes:
- N/A
2023-10-17 02:27:37 -07:00
Mikayla Maki
fd03915f85
Adjust chat to allow channel admins to delete all messages ( #3132 )
...
As it says on the tin
Release Notes:
- Changed chat permissions so that admins of a channel can delete any
message in a channel.
2023-10-17 02:24:14 -07:00
Mikayla
a81484f13f
Update IDs on interactive elements in LSP log viewer
2023-10-17 02:22:34 -07:00
Antonio Scandurra
c126ff10a7
Checkpoint
2023-10-17 11:21:02 +02:00
Antonio Scandurra
bb348c1353
Checkpoint
2023-10-17 11:20:11 +02:00
Mikayla
162f625716
Adjust chat permisisons to allow deletion for channel admins
2023-10-17 02:16:17 -07:00
Antonio Scandurra
fb1e7eef6b
Checkpoint
2023-10-17 11:08:48 +02:00
Antonio Scandurra
ac5b32c491
Checkpoint
2023-10-17 10:14:22 +02:00
Antonio Scandurra
b526fc070d
Merge branch 'gpui2-text-wrap' into gpui2
2023-10-17 09:03:16 +02:00
Antonio Scandurra
88ae4679d1
Checkpoint
2023-10-17 09:03:01 +02:00
Antonio Scandurra
9e7a579365
Checkpoint
2023-10-17 08:57:20 +02:00
Antonio Scandurra
b040ae8d4d
Checkpoint
2023-10-17 08:52:26 +02:00
Antonio Scandurra
c6e20aed9b
Checkpoint
2023-10-17 08:32:33 +02:00
Nathan Sobo
695a24d8a7
Checkpoint
2023-10-17 08:26:12 +02:00
Conrad Irwin
b168bded1d
New entitlements: ( #3118 )
...
Release Notes:
- Support Universal Links for Channel links
- Share credentials between Stable and Preview
2023-10-16 22:10:14 -06:00
Nathan Sobo
2472142532
Checkpoint
2023-10-17 06:09:03 +02:00
Nathan Sobo
bf49f55c95
Include length in run to not use tuples
2023-10-17 05:15:00 +02:00
Nathan Sobo
0df1eb71cb
Use cloned
2023-10-17 05:08:56 +02:00
Conrad Irwin
c12f0d2697
Provisioning profiles for stable and preview
2023-10-16 20:38:10 -06:00
Conrad Irwin
6ffbc3a0f5
Allow pasting ZED urls in the command palette in development
2023-10-16 20:03:44 -06:00
KCaverly
500af6d775
progress on prompt chains
2023-10-16 18:47:10 -04:00
Conrad Irwin
2feb091961
Ensure that invitees do not have permissions
...
They have to accept the invite, (which joining the channel will do),
first.
2023-10-16 16:24:10 -06:00
Conrad Irwin
4e7b35c917
Make joining a channel as a guest always succeed
2023-10-16 15:14:13 -06:00
Marshall Bowers
c8b452d411
Merge branch 'gpui2-ui' into gpui2
2023-10-16 16:54:40 -04:00
Marshall Bowers
708034d1d3
Call is_toggled as a method
2023-10-16 15:55:43 -04:00
Max Brunsfeld
c66385f0f9
Add an empty state to the notification panel
2023-10-16 12:54:44 -07:00
Nate Butler
247728b723
Update indexing icon
...
Co-Authored-By: Kyle Caverly <22121886+KCaverly@users.noreply.github.com >
2023-10-16 15:53:29 -04:00
Max Brunsfeld
522b76e452
Merge branch 'main' into notifications
2023-10-16 12:37:52 -07:00
Nathan Sobo
3127c78bc7
Fix compile error
2023-10-16 20:19:04 +02:00
Nathan Sobo
938dd8b9ca
Checkpoint
2023-10-16 20:16:35 +02:00
Nathan Sobo
847376cd8f
WIP
2023-10-16 20:15:41 +02:00
Nathan Sobo
1a3650ef2a
Get everything rendering again
2023-10-16 20:15:24 +02:00
Joseph T. Lyons
247cdb1e1a
Fix telemetry-related crash on start up ( #3131 )
...
Fixes (hopefully)
[#2136 ](https://github.com/zed-industries/community/issues/2136 ).
Release Notes:
- N/A
2023-10-16 14:01:52 -04:00
Nate Butler
129273036a
Add notifications panel to workspace UI structure
2023-10-16 13:11:52 -04:00
Nate Butler
97d77440e7
Simplify static panes for now
2023-10-16 13:07:15 -04:00
Joseph T. Lyons
75fbf2ca78
Fix telemetry-related crash on start up
2023-10-16 13:07:07 -04:00
KCaverly
40755961ea
added initial template outline
2023-10-16 11:54:32 -04:00
KCaverly
29f45a2e38
clean up warnings
2023-10-16 10:02:11 -04:00
KCaverly
5e1e0b4759
remove print from prompts
2023-10-16 09:55:45 -04:00
KCaverly
d2e769027a
catchup with main
2023-10-16 09:47:07 -04:00
Piotr Osiewicz
cc335db9e0
editor/language: hoist out non-generic parts of edit functions. ( #3130 )
...
This reduces LLVM IR size of editor (that's one of the heaviest crates
to build) by almost 5%.
LLVM IR size of `editor` before this PR: 3280386
LLVM IR size with `editor::edit` changed: 3227092
LLVM IR size with `editor::edit` and `language::edit` changed: 3146807
Release Notes:
- N/A
2023-10-16 13:17:44 +02:00
Piotr Osiewicz
6f4008ebab
copilot: Propagate action if suggest_next is not possible. ( #3129 )
...
One of our users ran into an issue where typing "true quote" characters
(option-[ for „ and option-] for ‚) was not possible; I've narrowed it
down to a collision with Copilot's NextSuggestion and PreviousSuggestion
action default keybinds. I explicitly did not want to alter the key
bindings, so I've went with a more neutral fix - one that propagates the
keystroke if there's no Copilot action to be taken (user is not using
Copilot etc). Note however that typing true quotes while using a Copilot
is still not possible, as for that we'd have to change a keybind.
Fixes zed-industries/community#2072
Release Notes:
- Fixed Copilot's "Suggest next" and "Suggest previous" actions
colliding with true quotes key bindings (`option-[` and `option-]`). The
keystrokes are now propagated if there's no Copilot action to be taken
at cursor's position.
2023-10-15 17:27:36 +02:00
Max Brunsfeld
ff245c61d2
Reduce duplication in notification queries
2023-10-13 17:10:46 -07:00
Max Brunsfeld
cb7b011d6b
Avoid creating duplicate invite notifications
2023-10-13 16:57:28 -07:00
Max Brunsfeld
5a0afcc835
Simplify notification serialization
2023-10-13 16:09:46 -07:00
Max Brunsfeld
83fb8d20b7
Remove contact notifications when cancelling a contact request
2023-10-13 16:09:46 -07:00
Conrad Irwin
f6f9b5c8cb
Wire through public access toggle
2023-10-13 16:59:30 -06:00
Marshall Bowers
5e43c332f1
Merge branch 'gpui2-ui' into gpui2
2023-10-13 17:44:28 -04:00
Marshall Bowers
6891e86621
Add state to BufferSearch
2023-10-13 17:44:21 -04:00
Marshall Bowers
3c1ec2e9ca
Add rudimentary UI for BufferSearch
2023-10-13 17:36:27 -04:00
Marshall Bowers
49caeeafce
Merge branch 'gpui2-ui' into gpui2
2023-10-13 17:20:54 -04:00
Marshall Bowers
349ad7858b
Add placeholder BufferSearch
2023-10-13 17:20:44 -04:00
Marshall Bowers
c70f220db3
Wire up buffer search toggle for EditorPane
2023-10-13 17:14:09 -04:00
Conrad Irwin
f8fd77b83e
fix migration
2023-10-13 15:08:09 -06:00
Conrad Irwin
af11cc6cfd
show warnings by default
2023-10-13 15:07:49 -06:00
Conrad Irwin
e20bc87152
Add some sanity checks for new user channel graph
2023-10-13 14:30:20 -06:00
Conrad Irwin
bb408936e9
Ignore old admin column
2023-10-13 14:08:40 -06:00
Conrad Irwin
e050d168a7
Delete some old code, reame ChannelMembers -> Members
2023-10-13 13:39:46 -06:00
Conrad Irwin
9c6f5de551
Use new get_channel_descendants for delete
2023-10-13 13:17:19 -06:00
Nate Butler
39e3ddb080
Update bell.svg
2023-10-13 15:00:32 -04:00
Nate Butler
603765732e
Checkpoint
2023-10-13 14:50:37 -04:00
Nathan Sobo
297b6b282c
Make all geometry types Default to support movement-based refinement
2023-10-13 12:41:00 -06:00
Max Brunsfeld
e590b43545
Merge branch 'main' into notifications
2023-10-13 11:31:53 -07:00
Max Brunsfeld
bc6ba5f547
Bump protocol version
2023-10-13 11:23:39 -07:00
Max Brunsfeld
8db86dcebf
Connect notification panel to notification toasts
2023-10-13 11:21:45 -07:00
Conrad Irwin
a8e352a473
Rewrite get_user_channels with new permissions
2023-10-13 11:46:03 -06:00
Julia
2323fd17b0
Autocomplete docs ( #3126 )
...
Release Notes:
- Added documentation display for autocomplete items.
- Fixed autocomplete filtering blocking the Zed UI, causing hitches and
input delays with large completion lists.
- Fixed hover popup link not firing if the mouse moved a slight amount
while clicking.
- Added support for absolute path file links in hover popup and
autocomplete docs.
2023-10-13 13:26:45 -04:00
Antonio Scandurra
fedb787b4f
WIP
2023-10-13 19:06:03 +02:00
Antonio Scandurra
90f226193c
Checkpoint
2023-10-13 19:06:03 +02:00
Piotr Osiewicz
bfbe4ae4b4
Piotr/z 651 vue support ( #3123 )
...
Release Notes:
- Added Vue language support.
2023-10-13 18:58:59 +02:00
Marshall Bowers
e477fa7a93
Wire up call controls in the TitleBar
2023-10-13 12:46:35 -04:00
Marshall Bowers
f3679b37a2
Change TitleBar to a view
2023-10-13 12:21:51 -04:00
Nate Butler
b30b1d145c
Refactor button rendering to use ThemeColor instead of direct theme calls
2023-10-13 11:47:13 -04:00
Nate Butler
e902d5d917
Add example NotificationToast to workspace
2023-10-13 11:47:05 -04:00
Nate Butler
8bd4107423
Fix toast contents not filling container
2023-10-13 11:46:48 -04:00
Nate Butler
7ba305e033
Hook up buttons in NotificationToast
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-10-13 11:03:59 -04:00
Nate Butler
caa0eb6e29
Add missing derive Element
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-10-13 10:47:39 -04:00
Nate Butler
c6d831a564
Update NotificationToast implementation and use in Workspace component
2023-10-13 10:35:30 -04:00
Nate Butler
943c02bf79
Refactor NotificationToast structure to include primary and secondary actions
2023-10-13 10:20:26 -04:00
Nate Butler
c32b081029
Add notification toast component and remove ToastVariant from toast.rs
2023-10-13 10:05:50 -04:00
Kirill Bulatov
16d9d77d88
Update diagnostics indicator when diagnostics are udpated ( #3128 )
...
Release Notes:
- Fixed diagnostics indicator not showing proper diagnostics count
2023-10-13 12:30:26 +03:00
Kirill Bulatov
803ab81eb6
Update diagnostics indicator when diagnostics are udpated
2023-10-13 12:13:18 +03:00
Kirill Bulatov
634202340b
Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle ( #3127 )
...
rust-analyzer complains about a bunch of dependency cycles:
```
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> assistant(Idx::<CrateData>(35)), alternative path: assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> breadcrumbs(Idx::<CrateData>(88)), alternative path: breadcrumbs(Idx::<CrateData>(88)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> collab_ui(Idx::<CrateData>(129)), alternative path: collab_ui(Idx::<CrateData>(129)) -> feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> feedback(Idx::<CrateData>(219)), alternative path: feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> quick_action_bar(Idx::<CrateData>(480)), alternative path: quick_action_bar(Idx::<CrateData>(480)) -> assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> search(Idx::<CrateData>(553)), alternative path: search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> semantic_index(Idx::<CrateData>(556)), alternative path: semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> terminal_view(Idx::<CrateData>(643)), alternative path: terminal_view(Idx::<CrateData>(643)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> vim(Idx::<CrateData>(748)), alternative path: vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> welcome(Idx::<CrateData>(775)), alternative path: welcome(Idx::<CrateData>(775)) -> vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> assistant(Idx::<CrateData>(35)), alternative path: assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> breadcrumbs(Idx::<CrateData>(88)), alternative path: breadcrumbs(Idx::<CrateData>(88)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> collab_ui(Idx::<CrateData>(129)), alternative path: collab_ui(Idx::<CrateData>(129)) -> feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> feedback(Idx::<CrateData>(219)), alternative path: feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> quick_action_bar(Idx::<CrateData>(480)), alternative path: quick_action_bar(Idx::<CrateData>(480)) -> assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> search(Idx::<CrateData>(553)), alternative path: search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> semantic_index(Idx::<CrateData>(556)), alternative path: semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> terminal_view(Idx::<CrateData>(643)), alternative path: terminal_view(Idx::<CrateData>(643)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> vim(Idx::<CrateData>(748)), alternative path: vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> welcome(Idx::<CrateData>(775)), alternative path: welcome(Idx::<CrateData>(775)) -> vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
```
so move the example into `zed` instead.
2023-10-13 10:35:35 +03:00
Kirill Bulatov
525ff6bf74
Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle
2023-10-13 10:27:08 +03:00
Conrad Irwin
65a0ebf975
Update get_channel_participant_details to include guests
2023-10-12 21:36:21 -06:00
Conrad Irwin
da2b8082b3
Rename members to participants in db crate
2023-10-12 20:42:42 -06:00
Julia
ec4391b88e
Add setting to disable completion docs
2023-10-12 22:08:47 -04:00
Conrad Irwin
a7db2aa39d
Add check_is_channel_participant
...
Refactor permission checks to load ancestor permissions into memory
for all checks to make the different logics more explicit.
2023-10-12 19:59:50 -06:00
Julia
1c3ecc4ad2
Whooooops
2023-10-12 21:00:31 -04:00
Max Brunsfeld
034e9935d4
Remove old contact request notification mechanism, use notification instead
2023-10-12 17:42:32 -07:00
Max Brunsfeld
3241128840
Make notification db representation more flexible
2023-10-12 17:42:32 -07:00
Max Brunsfeld
fed3ffb681
Set up notification store for integration tests
2023-10-12 17:42:30 -07:00
Max Brunsfeld
1e1256dbdd
Set RUST_LOG to info by default in zed-local script
2023-10-12 17:41:09 -07:00
Max Brunsfeld
69c65597d9
Fix use statement order
2023-10-12 17:41:09 -07:00
Max Brunsfeld
d1756b621f
Start work on notification panel
2023-10-12 17:41:09 -07:00
Max Brunsfeld
50cf25ae97
Add notification doc comments
2023-10-12 17:41:09 -07:00
Max Brunsfeld
cf6ce0dbad
Start work on storing notifications in the database
2023-10-12 17:41:07 -07:00
Julia
c4fc9f7ed8
Eagerly attempt to resolve missing completion documentation
2023-10-12 19:28:17 -04:00
Marshall Bowers
44a30e269e
Restore elevation docs
2023-10-12 18:18:44 -04:00
Marshall Bowers
ef18aaa66f
Merge branch 'main' into gpui2
2023-10-12 17:43:05 -04:00
Marshall Bowers
45f3a98359
Remove old ui and storybook crates ( #3125 )
...
This PR deletes the old `ui` and `storybook` crates in favor of their
newer variants that we'll be landing to `main` in the near future.
### Motivation
These crates are based off the old version of GPUI 2 (the `gpui2`
crate).
At this point we have since transitioned to the new version of GPUI 2
(the `gpui3` crate, currently still on the `gpui2` branch).
Having both copies around is confusing, so the old ones are going the
way of the dinosaurs.
Release Notes:
- N/A
2023-10-12 17:40:20 -04:00
Marshall Bowers
36bca4f0d6
Restore click events on Buttons using on_mouse_down
2023-10-12 16:56:48 -04:00
Marshall Bowers
6e5ad75c5c
Use Workspace::view to construct the view
2023-10-12 16:52:32 -04:00
Marshall Bowers
79a61c28d7
Remove global WorkspaceState
2023-10-12 16:23:10 -04:00
Julia
d23bb3b05d
Unbork markdown parse test by making links match
2023-10-12 16:18:54 -04:00
Max Brunsfeld
bac43ae38e
Fix panic when following due to disconnected channel notes views ( #3124 )
...
In addition to fixing a panic, this makes it slightly more convenient to
re-open disconnected channel notes views. I didn't make it automatic,
but it will at least replace the previous, disconnected view.
Release Notes:
- Fixed a crash that sometimes occurred when following someone with a
disconnected channel notes view open.
2023-10-12 13:16:58 -07:00
Marshall Bowers
e900ea20b7
Fix toggling of left panel
2023-10-12 16:12:09 -04:00
Marshall Bowers
8496d02fe1
Hold the story view in the StoryWrapper
2023-10-12 16:11:59 -04:00
Marshall Bowers
fc94c4ea40
Render stories as Views
2023-10-12 16:06:54 -04:00
Marshall Bowers
c90d976d7a
Remove debug logging in Element derive macro
2023-10-12 15:52:42 -04:00
Marshall Bowers
d320d3a8bf
Remove hacky children
2023-10-12 15:50:09 -04:00
Marshall Bowers
24bab48043
Use new children approach for Toolbar
2023-10-12 15:47:26 -04:00
Max Brunsfeld
f5d6d7caca
Mark channel notes as disconnected immediately upon explicitly signing out
2023-10-12 12:39:02 -07:00
Max Brunsfeld
85fe11ff11
Replace disconnected channel notes views when re-opening the notes
2023-10-12 12:38:23 -07:00
Marshall Bowers
30979caf25
Use new children approach for Panes and Toasts
2023-10-12 15:37:50 -04:00
Nathan Sobo
ce8533f83b
Checkpoint
2023-10-12 13:27:46 -06:00
Mikayla
78432d08ca
Add channel visibility columns and protos
2023-10-12 12:21:41 -07:00
Conrad Irwin
540436a1f9
Push role refactoring through RPC/client
2023-10-12 13:05:54 -06:00
Max Brunsfeld
2e5461ee4d
Exclude disconnected channel views from following messages
2023-10-12 11:55:39 -07:00
Antonio Scandurra
2044ccdc0b
WIP
2023-10-12 19:40:13 +02:00
Antonio Scandurra
ca35573ad5
WIP
2023-10-12 19:30:00 +02:00
Julia
85332eacbd
Race completion filter w/completion request & make not block UI
2023-10-12 13:23:26 -04:00
Marshall Bowers
6dbe983461
Checkpoint: Back to a compiling state
2023-10-12 12:22:23 -04:00
Marshall Bowers
262f5886a4
Checkpoint
2023-10-12 12:18:35 -04:00
Julia
4688a94a54
Allow file links in markdown & filter links a bit aggressively
2023-10-12 12:11:27 -04:00
Marshall Bowers
207d843aee
Fix issues in storybook2
2023-10-12 10:44:18 -04:00
Marshall Bowers
a6b872bb0c
Temporarily disable click handlers
2023-10-12 10:44:11 -04:00
Marshall Bowers
8cd112110e
Reconcile with upstream changes
2023-10-12 10:40:47 -04:00
Marshall Bowers
9581279919
Fix some merge errors
2023-10-12 10:27:50 -04:00
Marshall Bowers
002458f4c8
Merge branch 'gpui2' into gpui2-ui
2023-10-12 10:27:43 -04:00
Kirill Bulatov
a50977e0fd
Add prettier support ( #3122 )
2023-10-12 17:13:10 +03:00
Kirill Bulatov
ef73bf799c
Fix license issue
2023-10-12 16:26:28 +03:00
Kirill Bulatov
7aea95704e
Revert unnecessary style changes
2023-10-12 16:17:41 +03:00
Antonio Scandurra
564a8bdc19
Checkpoint
2023-10-12 14:58:31 +02:00
Kirill Bulatov
09ef3ccf67
Fix tailwind prettier plugin discovery
2023-10-12 15:58:00 +03:00
Antonio Scandurra
1f84cdb88c
Checkpoint
2023-10-12 14:49:06 +02:00
Kirill Bulatov
12d7d8db0a
Make all formatting to happen on the client's buffers, as needed
2023-10-12 15:29:57 +03:00
Kirill Bulatov
1bfde4bfa2
Add more tests
2023-10-12 15:14:51 +03:00
Antonio Scandurra
80c0a6ead3
Checkpoint
2023-10-12 13:25:49 +02:00
Kirill Bulatov
7f4ebf50d3
Make the first prettier test pass
2023-10-12 13:30:49 +03:00
Kirill Bulatov
a528c6c686
Prettier server style fixes
2023-10-12 12:31:30 +03:00
Antonio Scandurra
23f11fcd5e
Merge branch 'main' into gpui2
2023-10-12 10:55:17 +02:00
Nathan Sobo
3dad0d9811
Add group_active
2023-10-11 21:48:21 -06:00
Nathan Sobo
d920f7edc1
Add group hovers
2023-10-11 21:34:08 -06:00
Conrad Irwin
690d9fb971
Add a role column to the database and start using it
...
We cannot yet stop using `admin` because stable will continue writing
it.
2023-10-11 20:05:57 -06:00
Nathan Sobo
f37b83a0ea
WIP
2023-10-11 17:18:39 -06:00
Nate Butler
12573ed2e7
Refine project panel, list item
2023-10-11 19:15:27 -04:00
Conrad Irwin
be1800884e
Make collaboration warning more useful ( #3119 )
...
Release Notes:
- Fixed the titlebar upgrade UI to restart zed when an update is
available
2023-10-11 15:35:41 -06:00
Conrad Irwin
f6d0934b5d
deep considered harmful
2023-10-11 15:17:46 -06:00
Nathan Sobo
93c233b1cf
Checkpoint
2023-10-11 13:22:40 -06:00
Nathan Sobo
47b64a5074
Checkpoint
2023-10-11 12:51:56 -06:00
Julia
a09ee3a41b
Fire markdown link on mouse down
...
Previously any amount of mouse movement would disqualify the mouse down
and up from being a click, being a drag instead, which is a long
standing UX issue. We can get away with just firing on mouse down here
for now
2023-10-11 14:39:34 -04:00
Joseph T. Lyons
d6fa06b3be
collab 0.24.0
2023-10-11 13:51:01 -04:00
Julia
0cec0c1c1d
Fixup layout
2023-10-11 13:41:58 -04:00
Nathan Sobo
e2da2b232e
Checkpoint
2023-10-11 11:40:42 -06:00
Joseph T. Lyons
bdf1731db3
v0.109.x dev
2023-10-11 12:40:57 -04:00
Marshall Bowers
5477b87774
Hook up assistant panel
2023-10-11 12:38:06 -04:00
Marshall Bowers
7478e63ea0
Simplify state interactions
2023-10-11 12:32:05 -04:00
Marshall Bowers
922d1462a8
Merge branch 'gpui2-ui' of github.com:zed-industries/zed into gpui2-ui
2023-10-11 12:24:34 -04:00
Marshall Bowers
8f410d5e2e
Add support for switching between the project and collab panels
2023-10-11 12:24:33 -04:00
Nate Butler
0d8c743dfe
Refine project panel, list
2023-10-11 12:22:24 -04:00
Kirill Bulatov
e50f4c0ee5
Add prettier tests infrastructure
2023-10-11 19:13:28 +03:00
Marshall Bowers
b6a9c58994
Push language selector handler down into StatusBar
2023-10-11 12:11:22 -04:00
Marshall Bowers
382693a199
Adjust icon color based on whether the various components are open
2023-10-11 12:09:08 -04:00
Marshall Bowers
acf2c2c6a5
Add ability to toggle the terminal
2023-10-11 12:01:17 -04:00
Antonio Scandurra
006f840570
Checkpoint
2023-10-11 17:53:29 +02:00
Conrad Irwin
2d6725a41a
Make collaboration warning more useful
2023-10-11 09:50:22 -06:00
Conrad Irwin
7c867b6e54
New entitlements:
...
* Universal links
* Shared keychain group (to make development easier)
2023-10-11 09:36:12 -06:00
Antonio Scandurra
457df8d3f3
Start and stop display link on the main thread
2023-10-11 16:38:54 +02:00
Antonio Scandurra
b6e4208ea8
Checkpoint
2023-10-11 15:08:28 +02:00
Antonio Scandurra
56fba5541a
Checkpoint
2023-10-11 14:19:04 +02:00
Kirill Bulatov
4a88a9e253
Initialize prettier right after the buffer gets it language
2023-10-11 14:48:32 +03:00
Antonio Scandurra
a69dbafe3c
Checkpoint
2023-10-11 12:47:19 +02:00
Antonio Scandurra
a9c69bf774
Checkpoint
2023-10-11 12:45:09 +02:00
Kirill Bulatov
986a516bf1
Small style fixes
2023-10-11 12:56:29 +03:00
Kirill Bulatov
9bf22c56cd
Rebase fixes
2023-10-11 12:56:29 +03:00
Kirill Bulatov
b5705e079f
Draft remote prettier formatting
2023-10-11 12:56:29 +03:00
Kirill Bulatov
2ec2036c2f
Invoke remote Prettier commands
2023-10-11 12:56:29 +03:00
Kirill Bulatov
faf1d38a6d
Draft local and remote prettier separation
2023-10-11 12:56:29 +03:00
Kirill Bulatov
6c1c7eaf75
Better detect Svelte plugins
2023-10-11 12:56:29 +03:00
Kirill Bulatov
2d5741aef8
Better prettier format logging
2023-10-11 12:56:29 +03:00
Kirill Bulatov
a9f80a603c
Resolve prettier config before every formatting
2023-10-11 12:56:29 +03:00
Kirill Bulatov
658b58378e
Properly use WorktreeId
2023-10-11 12:56:29 +03:00
Kirill Bulatov
8a807102a6
Properly support prettier plugins
2023-10-11 12:56:29 +03:00
Kirill Bulatov
afee29ad3f
Do not clear cache for default prettiers
2023-10-11 12:56:29 +03:00
Kirill Bulatov
6ec3927dd3
Allow to configure default prettier
2023-10-11 12:56:29 +03:00
Kirill Bulatov
b109075bf2
Watch for prettier file changes
2023-10-11 12:56:29 +03:00
Kirill Bulatov
f4667cbc33
Resolve prettier config on server init
2023-10-11 12:56:29 +03:00
Kirill Bulatov
d021842fa1
Properly log pre-lsp prettier_server events
2023-10-11 12:56:29 +03:00
Kirill Bulatov
f42cb109a0
Improve prettier_server LSP names in the log panel
2023-10-11 12:56:29 +03:00
Kirill Bulatov
1b70e7d0df
Before server startup, log to stderr
2023-10-11 12:56:29 +03:00
Kirill Bulatov
b687270207
Implement missing prettier_server clear method
2023-10-11 12:56:29 +03:00
Kirill Bulatov
06cac18d78
Return message id in prettier_server error responses
2023-10-11 12:56:29 +03:00
Kirill Bulatov
6cac58b34c
Add prettier language servers to LSP logs panel
2023-10-11 12:56:29 +03:00
Kirill Bulatov
4b15a2bd63
Rebase fixes
2023-10-11 12:56:29 +03:00
Kirill Bulatov
e8409a0108
Even more generic header printing in prettier_server
2023-10-11 12:56:29 +03:00
Kirill Bulatov
39ad3a625c
Generify prettier properties, add tabWidth
2023-10-11 12:56:29 +03:00
Kirill Bulatov
2a5b9b635b
Better pass prettier options
2023-10-11 12:56:29 +03:00
Kirill Bulatov
e2056756ef
Calculate the diff
2023-10-11 12:56:29 +03:00
Kirill Bulatov
6a8e3fd02d
Add more parameters into prettier invocations
2023-10-11 12:56:29 +03:00
Kirill Bulatov
2a68f01402
Draft prettier_server formatting
2023-10-11 12:56:29 +03:00
Kirill Bulatov
dca93fb177
Initialize prettier_server.js wrapper along with default prettier
2023-10-11 12:56:29 +03:00
Kirill Bulatov
010bb73ac2
Use LSP-like protocol for prettier wrapper commands
2023-10-11 12:56:29 +03:00
Kirill Bulatov
bb2cc2d157
Async-ify prettier wrapper
2023-10-11 12:56:29 +03:00
Kirill Bulatov
86618a64c6
Require prettier argument and library in the wrapper
2023-10-11 12:56:29 +03:00
Kirill Bulatov
1ff17bd15d
Install default prettier and plugins on startup
2023-10-11 12:56:29 +03:00
Kirill Bulatov
12ea12e4e7
Make language adapters able to require certain bundled formatters
2023-10-11 12:56:29 +03:00
Kirill Bulatov
4f956d71e2
Slightly better prettier settings and discovery
2023-10-11 12:56:29 +03:00
Kirill Bulatov
ce6b31d938
Make NodeRuntime non-static for prettier runner
2023-10-11 12:56:29 +03:00
Kirill Bulatov
a8387b8b19
Use proper NodeRuntime in the formatter interface
2023-10-11 12:56:28 +03:00
Kirill Bulatov
a420d9cdc7
Add prettier search
2023-10-11 12:56:28 +03:00
Kirill Bulatov
a8dfa01362
Prepare prettier file lookup code infra
2023-10-11 12:56:28 +03:00
Kirill Bulatov
92f23e626e
Properly connect prettier lookup/creation methods
2023-10-11 12:56:28 +03:00
Kirill Bulatov
553abd01be
Draft a project part of the prettier
2023-10-11 12:56:28 +03:00
Julia
eced842dfc
Get started with a prettier server package
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-10-11 12:56:28 +03:00
Antonio Scandurra
b6a3d9ce59
Checkpoint
2023-10-11 11:03:08 +02:00
Antonio Scandurra
eebbc807e5
Checkpoint
2023-10-11 10:45:57 +02:00
Antonio Scandurra
0fb7364235
Checkpoint
2023-10-11 09:17:25 +02:00
Joseph T. Lyons
76191fe47d
Fix Discord text truncation
2023-10-11 01:54:32 -04:00
Nathan Sobo
f1cc62c21f
WIP
2023-10-10 22:49:47 -06:00
Nathan Sobo
f53b63eaf6
Checkpoint
2023-10-10 22:14:47 -06:00
Conrad Irwin
821997d372
Revert accidental build change
2023-10-10 19:59:57 -06:00
Conrad Irwin
85b76b1143
Don't wrap on paragraphs ( #3094 )
...
Release Notes:
- vim: `{` and `}` will no longer wrap around end of file
([#2116 ](https://github.com/zed-industries/community/issues/2116 )).
2023-10-10 19:25:40 -06:00
Conrad Irwin
9004254fbf
vim: Add shift-y ( #3117 )
...
Release Notes:
- vim: Add `Y` to copy line-wise (this copies vim's behaviour, which
differs from nvim's)
2023-10-10 19:25:32 -06:00
Conrad Irwin
1de9add304
vim: Add shift-y
2023-10-10 18:46:49 -06:00
Max Brunsfeld
7a39455af9
Fix inclusion of spurious views from other projects in FollowResponse ( #3116 )
...
A logic error in https://github.com/zed-industries/zed/pull/2993 caused
follow responses to sometimes contain extra views for other unshared
projects 😱 . These views would generally fail to deserialize on the
other end. This would create a broken intermediate state, where the
following relationship was registered on the server (and on the leader's
client), but the follower didn't have the state necessary for following
into certain views.
Release Notes:
- Fixed a bug where following would sometimes fail if the leader had
another unshared project open.
2023-10-10 15:53:11 -07:00
Max Brunsfeld
96d60eff23
Fix inclusion of spurious views from other projects in FollowResponse
2023-10-10 15:40:40 -07:00
Marshall Bowers
a69f93d214
Wire up toggling of project and chat panels
2023-10-10 18:35:20 -04:00
Marshall Bowers
8e1638b773
Add working toggle for LanguageSelector
2023-10-10 18:21:44 -04:00
Marshall Bowers
95ef61bc45
Thread click handler through from workspace to language selector
2023-10-10 18:02:08 -04:00
Marshall Bowers
c142676b20
Add click handlers to some of the buttons in the StatusBar
2023-10-10 17:26:53 -04:00
Marshall Bowers
be843227a1
Add on_click to IconButton
2023-10-10 17:26:33 -04:00
Marshall Bowers
48d9b49ada
Wire up click handlers on Buttons
2023-10-10 17:19:18 -04:00
Mikayla Maki
19f774a4a4
Update channel rooms to be ephemeral ( #3115 )
...
This fixes a bug that was introduced by
https://github.com/zed-industries/zed/pull/3093 , which assumed that
rooms for channels where ephemeral, by making rooms for channels
ephemeral.
Release Notes:
- N/A
2023-10-10 13:28:42 -07:00
Mikayla
d7d027bcf1
Rename release channel to enviroment
2023-10-10 13:23:03 -07:00
Joseph T. Lyons
e6228ca682
Slim down pull request template
2023-10-10 16:04:31 -04:00
Marshall Bowers
f2ee61553f
Colocate element stories with their elements
2023-10-10 16:00:04 -04:00
Marshall Bowers
30088afa89
Colocate component stories with their components
2023-10-10 15:52:58 -04:00
Mikayla
40430cf01b
Update channel rooms to be ephemeral
...
Remove redundant live kit initialization code
Fix bug in recent channel links changes where channel rooms would have the incorrect release set
co-authored-by: Conrad Irwin <conrad.irwin@gmail.com >
co-authored-by: Max <max@zed.dev >
2023-10-10 12:39:16 -07:00
Marshall Bowers
b1d88ced61
Add an example of colocating a story for a UI component with its definition
2023-10-10 15:30:16 -04:00
Marshall Bowers
5b7ca6435c
Comment out overridden widths
2023-10-10 15:17:44 -04:00
Marshall Bowers
a6ae6b0752
Merge branch 'gpui2' into gpui2-ui
2023-10-10 15:12:59 -04:00
Nathan Sobo
61b8ad38bd
Remove state erasure for now
2023-10-10 12:44:40 -06:00
Nathan Sobo
e714653478
Checkpoint
2023-10-10 12:42:44 -06:00
Nathan Sobo
d70b4f04f6
Checkpoint
2023-10-10 12:41:28 -06:00
Antonio Scandurra
9eff99de49
--amend
2023-10-10 20:02:34 +02:00
Antonio Scandurra
4855b8f3de
WIP
2023-10-10 20:02:23 +02:00
Antonio Scandurra
84ad2cb827
Checkpoint
2023-10-10 19:48:32 +02:00
Antonio Scandurra
0e537cced4
Revert outline summarization ( #3114 )
...
This pull request essentially reverts #3067 : we noticed that only using
the function signatures produces far worse results in codegen, and so
that feels like a regression compared to before. We should re-enable
this once we have a smarter approach to fetching context during codegen,
possibly when #3097 lands.
As a drive-by, we also fixed a longstanding bug that caused codegen to
include the final line of a selection even if the selection ended at the
start of the line.
Ideally, I'd like to hot fix this to preview so that it goes to stable
during the weekly release.
/cc: @KCaverly @nathansobo
Release Notes:
- N/A
2023-10-10 19:20:54 +02:00
Antonio Scandurra
b366592878
Don't include start of a line when selection ends at start of line
2023-10-10 19:11:13 +02:00
Antonio Scandurra
5cf92980f0
Revert summarizing file content until we can be more intelligent about what we send
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-10-10 17:51:17 +02:00
Marshall Bowers
8f7f38536d
Re-enable hover styles
2023-10-10 11:48:25 -04:00
Antonio Scandurra
97edec6e72
WIP
2023-10-10 17:31:42 +02:00
Marshall Bowers
40d58c9bc3
Use Self::State in children_any and child_any
2023-10-10 11:26:18 -04:00
Marshall Bowers
f76c9041bb
Merge branch 'gpui2' into marshall/gpui2-playground
2023-10-10 11:24:45 -04:00
Conrad Irwin
66af1707a1
Add channel links ( #3093 )
...
Release notes:
- `mute_on_join` setting now defaults to false.
- Right click on a channel to "Copy Channel Link", these links work to
open Zed and auto-join the channel
Blocked on: https://github.com/zed-industries/zed.dev/pull/388
2023-10-10 08:53:50 -06:00
Antonio Scandurra
96fbf9fd06
Checkpoint
2023-10-10 16:47:09 +02:00
Julia
801af95a13
Make completion documentation scroll & fix accompanying panic from tag
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-10-10 10:08:29 -04:00
Julia
f5af5f7334
Avoid leaving selected item index past end of matches list
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-10-10 09:27:18 -04:00
Antonio Scandurra
48a12be538
WIP
2023-10-10 15:03:47 +02:00
Antonio Scandurra
012a7743ad
Checkpoint
2023-10-10 14:43:55 +02:00
Antonio Scandurra
678235023f
Checkpoint
2023-10-10 13:07:53 +02:00
Antonio Scandurra
a4afb72535
Checkpoint: beziers
2023-10-10 13:01:35 +02:00
Kirill Bulatov
1db24e5f2a
Omit history files with path that does not exist on disk anymore ( #3113 )
2023-10-10 11:55:06 +02:00
Kirill Bulatov
639ae671ae
Omit history files with path that does not exist on disk anymore
2023-10-10 12:26:48 +03:00
Julia
354882f2c0
Enable completion menu to resolve documentation when guest
2023-10-10 00:16:15 -04:00
Joseph T. Lyons
1a4e9ecfef
Truncate Discord release note text ( #3112 )
...
Hopefully this works the first time 😅
Release Notes:
- N/A
2023-10-10 00:07:48 -04:00
Joseph T. Lyons
dcdd74dff4
Truncate Discord release note text
2023-10-10 00:00:57 -04:00
Conrad Irwin
ab050d1890
Use Horizontal ranges everywhere
2023-10-09 21:48:50 -06:00
Conrad Irwin
002e2cc42c
Round better for up/down
2023-10-09 21:48:32 -06:00
Conrad Irwin
ef7e2c5d86
Get the project running!
2023-10-09 21:48:31 -06:00
Conrad Irwin
e7badb38e9
Refactor to pass a TextLayoutDetails around
2023-10-09 21:47:58 -06:00
Conrad Irwin
dacc8cb5f4
Begin to use pixels for column selection
...
For zed-industries/community#759
For zed-industries/community#1966
Co-Authored-By: Julia <floc@unpromptedtirade.com >
2023-10-09 21:47:58 -06:00
Conrad Irwin
a801a4aeef
Remove some unnecessary Eqs
2023-10-09 21:47:58 -06:00
Nathan Sobo
fe60f264c4
Checkpoint
2023-10-09 21:46:49 -06:00
Nathan Sobo
dfdb691f73
Checkpoint
2023-10-09 21:30:14 -06:00
Nathan Sobo
9fe5836240
Move events module up
2023-10-09 21:19:56 -06:00
Nathan Sobo
8074e6b46a
Add basic mouse event handling
2023-10-09 21:17:56 -06:00
Conrad Irwin
d4ef764305
Merge branch 'main' into links
2023-10-09 20:08:48 -06:00
Nathan Sobo
f763ed9a7e
Checkpoint
2023-10-09 19:54:29 -06:00
Conrad Irwin
8922437fcd
code review
2023-10-09 19:06:55 -06:00
Max Brunsfeld
6e98cd5aad
More small following-related fixes ( #3110 )
2023-10-09 15:25:22 -07:00
Marshall Bowers
08f4576aa6
Rename helper style
2023-10-09 18:17:01 -04:00
Max Brunsfeld
1d29709c32
Avoid possible panic in Room::most_active_project
...
Participants' locations might momentarily reference projects that have already been unshared.
2023-10-09 15:04:01 -07:00
Marshall Bowers
7610028a89
Add a story showcasing z-index
2023-10-09 18:00:49 -04:00
Max Brunsfeld
bdcbf9b92e
Add a Reconnect action, for simulating connection blips
2023-10-09 14:46:33 -07:00
Max Brunsfeld
b807b3c785
Handle participants' participant index changing
...
This normally doesn't happen, but it can happen if a participant
loses connection ungracefully, restarts their app, and then
explicitly joins again.
2023-10-09 14:45:19 -07:00
Max Brunsfeld
90b54a45e8
Log a warning when leader activates an unknown view
2023-10-09 14:29:45 -07:00
Kirill Bulatov
bb85d6f63e
Detect file paths that end with : ( #3109 )
...
New rustc messages look like
```
thread 'tests::test_history_items_vs_very_good_external_match' panicked at crates/file_finder/src/file_finder.rs:1902:13:
assertion `left == right` failed: Only one history item contains collab_ui, it should be present and others should be filtered out
left: 0
right: 1
```
now and we fail to parse that `13:` bit properly, fix that.
One caveat is that we highlight the entire word including the trailing
`:`:
<img width="914" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/d653a8ff-3e6e-4e3d-b6ea-dad0c8db0f06 ">
this is unfortunate, but better than nothing (as now).
This is due to the fact, that we detect words with regex inside the
`terminal.rs` and send events to other place that's able to check paths
for existence (and whether that's a path at all), currently there's no
way to detect a path and sanitize it in `terminal.rs`
Release Notes:
- N/A
2023-10-09 23:16:03 +02:00
Marshall Bowers
0d903f4d0d
Clean up theme loading
2023-10-09 17:00:10 -04:00
Kirill Bulatov
ba4f4e0a3e
Detect file paths that end with :
...
New rustc messages look like
```
thread 'tests::test_history_items_vs_very_good_external_match' panicked at crates/file_finder/src/file_finder.rs:1902:13:
assertion `left == right` failed: Only one history item contains collab_ui, it should be present and others should be filtered out
left: 0
right: 1
```
now and we fail to parse that `13:` bit properly, fix that.
2023-10-09 23:55:58 +03:00
Marshall Bowers
312f3d2ab9
Change how the default theme gets determined
2023-10-09 16:53:28 -04:00
Max Brunsfeld
6b710dc146
Fix bug that allowed following multiple people in one pane ( #3108 )
...
I've also simplified the representation of a workspace's leaders, so
that it encodes in the type that there can only be one leader per pane.
Release Notes:
- Fixed a bug where you could accidentally follow multiple collaborators
in one pane at the same time.
2023-10-09 13:50:51 -07:00
Marshall Bowers
def67295e5
Add theme loading
2023-10-09 16:37:20 -04:00
Kirill Bulatov
0823a18cff
Ignore history items' paths when matching search queries ( #3107 )
...
Follow-up of https://github.com/zed-industries/zed/pull/3059
Before:

After:

Release Notes:
- N/A
2023-10-09 22:35:11 +02:00
Max Brunsfeld
ca735ad70f
Ensure there's only one leader per pane
2023-10-09 13:32:38 -07:00
Max Brunsfeld
af90077a6a
Add failing test for switching leaders in a pane
2023-10-09 13:30:14 -07:00
Kirill Bulatov
9cba45910e
Ignore history items' paths when matching search queries
2023-10-09 23:14:32 +03:00
Marshall Bowers
613973d2b1
Add support for switching between the two hardcoded themes
2023-10-09 15:52:57 -04:00
Max Brunsfeld
29ccdb3cd9
Unify the two local zed scripts, take a flag for an instance count ( #3106 )
...
This PR introduces a new script for running Zed against a local collab
server, called `script/zed-local`. This script replaces the two existing
scripts that we had for this purpose: `script/zed-with-local-servers`
and `script/start-local-collaboration`.
By default, the script starts one single instance of Zed, but you can
pass a numeric flag to start 1, 2, 3 or 4 instances. So to start up two
instances side by side, (like `start-local-collaboration` script), you'd
do this:
```
script/zed-local -2
```
But you can also start *three* (or even four) instances, each taking up
a quarter of the screen, like this:
```
script/zed-local -3
```
Like before, you can pass other arguments to the script, and they will
be passed through to the first zed instance.
Also, unlike the `start-local-collaboration` script, this script now
requires a call to GitHub to determine your GitHub username. It just
logs you in as Nathan by default, unless you set `ZED_IMPERSONATE`
explicitly.
2023-10-09 12:52:20 -07:00
Max Brunsfeld
1e4f5145cf
Update docs to refer to new zed-local script
2023-10-09 12:49:12 -07:00
Max Brunsfeld
a0ab9fe56b
Unify the 2 local zed scripts, take a flag for instance count
2023-10-09 12:40:36 -07:00
Conrad Irwin
fb57299a1d
re-trigger build with new profile?
2023-10-09 13:40:22 -06:00
Conrad Irwin
162cb19cff
Only allow one release channel in a call
2023-10-09 12:59:18 -06:00
Julia
7020050b06
Fix hover_popover.rs after bad rebase
2023-10-09 14:28:53 -04:00
Conrad Irwin
abfb4490d5
Focus the currently active project if there is one
...
(also consider your own projects in "most_active_projects")
2023-10-09 12:05:26 -06:00
Antonio Scandurra
7b610f8dd8
WIP
2023-10-09 19:50:48 +02:00
Marshall Bowers
8b3a357949
Add note about CSS hack
2023-10-09 13:39:08 -04:00
Marshall Bowers
f73708d725
Add a Toast in the bottom-right corner
2023-10-09 13:32:19 -04:00
Marshall Bowers
d3c79c7078
Add div.z_index
2023-10-09 13:19:32 -04:00
Antonio Scandurra
d889cdecde
Checkpoint
2023-10-09 19:13:57 +02:00
Marshall Bowers
2654942b3c
Use command modifier for example keybindings in CommandPalette
2023-10-09 12:51:57 -04:00
Marshall Bowers
ed2c8cdc25
Add strikethrough support back to Label
2023-10-09 12:33:52 -04:00
Marshall Bowers
19434afe0a
Add back negative margins, now that they're supported again
2023-10-09 12:33:30 -04:00
Marshall Bowers
a7c4ae530d
Update gpui3_macros::style_helpers! based on its gpui2 equivalent
2023-10-09 12:31:22 -04:00
Max Brunsfeld
b2d735e573
Always log panics ( #2896 )
...
I just panicked and wanted to see the cause, but forgot that panic files
get deleted when Zed uploads them.
Release Notes:
- Panics are now written to `~/Library/Logs/Zed/Zed.log`
2023-10-09 09:21:08 -07:00
Max Brunsfeld
044701e907
Add a crate-dep-graph script, remove a few unnecessary dependencies ( #3103 )
...
This was motivated by me trying to decide which crate I should put a
`NotificationStore` in.
Run `script/crate-dep-graph` to generate an SVG showing the dependency
graph of our `crates` folder, and open it in a web browser.
After running this command, I noticed a couple of dependencies that
didn't make sense and were easy to remove.
Current dependency graph:

2023-10-09 09:20:06 -07:00
Marshall Bowers
42e9800bde
Add Details component
2023-10-09 11:55:27 -04:00
Marshall Bowers
d956bd3743
Add RecentProjects component
2023-10-09 11:47:22 -04:00
Conrad Irwin
6084486dcd
Code quality
2023-10-09 09:44:09 -06:00
Marshall Bowers
100a4731e2
Add ThemeSelector component
2023-10-09 11:44:08 -04:00
Marshall Bowers
000ae27aff
Add LanguageSelector component
2023-10-09 11:39:42 -04:00
Marshall Bowers
06b0707aa9
Add MultiBuffer component
2023-10-09 11:36:09 -04:00
Marshall Bowers
ac93449788
Remove unused Arc import
2023-10-09 11:32:10 -04:00
Marshall Bowers
02d32de044
Add Toast component
2023-10-09 11:31:56 -04:00
Conrad Irwin
8f4d81903c
Add "Copy Link" to channel right click menu
2023-10-09 09:30:00 -06:00
Marshall Bowers
333e3e4f01
Add ContextMenu component
2023-10-09 11:25:33 -04:00
Marshall Bowers
f7721d0523
Add CommandPalette component
2023-10-09 11:20:10 -04:00
Marshall Bowers
e5473fc51a
Add Palette component
2023-10-09 11:15:50 -04:00
Marshall Bowers
a08ceadd1a
Rename view_type to state_type
2023-10-09 11:11:03 -04:00
Marshall Bowers
dc2ddfb42c
Add Keybinding component
2023-10-09 11:09:44 -04:00
Marshall Bowers
4eeed14d34
Add CollabPanel component
2023-10-09 11:04:53 -04:00
Conrad Irwin
5dbda70235
Fix ./script/bundle to allow passing key
2023-10-09 08:59:25 -06:00
Kirill Bulatov
38d53a6fe2
Bump curl-sys to fix Sonoma issues with it
...
See https://github.com/alexcrichton/curl-rust/issues/524
2023-10-09 17:09:58 +03:00
Antonio Scandurra
6a4c2a0d40
WIP
2023-10-09 16:02:55 +02:00
Joseph T. Lyons
77a932fe3b
Add enable vim mode checkbox to welcome screen ( #3105 )
...
Had a user state that they didn't know how to enable vim mode and that
it was "almost a non-starter" for them. IMO, it is a big enough feature
to warrant being on the welcome screen.
<img width="968" alt="SCR-20231008-rnhj"
src="https://github.com/zed-industries/zed/assets/19867440/a189c646-1fa7-497c-b6d9-37cb1caa0492 ">
Release Notes:
- Added an `Enable vim mode` checkbox to the welcome screen
2023-10-08 21:27:31 -04:00
Joseph T. Lyons
4b2c24dd8c
Add enable vim mode checkbox to welcome screen
2023-10-08 20:07:59 -04:00
Marshall Bowers
8814ea8241
Time compute_layout
2023-10-07 12:23:25 -04:00
Marshall Bowers
8f6649e29e
Merge branch 'gpui2' into marshall/gpui2-playground
2023-10-07 12:16:48 -04:00
Marshall Bowers
73360d37f7
Merge branch 'main' into gpui2
2023-10-07 12:15:23 -04:00
Marshall Bowers
eb642551ac
Add TitleBar component and wire up to the workspace
2023-10-07 12:10:39 -04:00
Marshall Bowers
f33d41af63
Add Facepile and PlayerStack components
2023-10-07 12:02:42 -04:00
Marshall Bowers
5e7954f152
Add TrafficLights component
2023-10-07 11:55:10 -04:00
Marshall Bowers
9e79ad5a62
Add ChatPanel component
2023-10-07 11:50:41 -04:00
Marshall Bowers
0dcbc47e15
Remove duplicate module declaration
2023-10-07 11:42:50 -04:00
Marshall Bowers
b8b8fe6120
Add Button component
2023-10-07 11:41:48 -04:00
Marshall Bowers
ff066ef177
Add EditorPane component and wire up in the workspace
2023-10-07 11:33:11 -04:00
Marshall Bowers
63e834ce73
Add Toolbar component
2023-10-07 11:21:09 -04:00
Marshall Bowers
b118e60160
Add Breadcrumb component
2023-10-07 11:18:06 -04:00
Marshall Bowers
00e8531898
Add TabBar component
2023-10-07 11:13:54 -04:00
Marshall Bowers
7c8d662315
Increase storybook window size
2023-10-07 11:09:21 -04:00
Marshall Bowers
2f6d67cad6
Update Cargo.lock
2023-10-07 10:56:21 -04:00
Marshall Bowers
f5e5b44bc1
Merge branch 'gpui2' into marshall/gpui2-playground
2023-10-07 10:54:17 -04:00
Marshall Bowers
f795177ab6
Fix icon paths
2023-10-07 10:51:19 -04:00
Marshall Bowers
a4bde421db
Revert changes to gpui2 crate
2023-10-07 10:50:50 -04:00
Marshall Bowers
f6a4151f60
Merge branch 'main' into gpui2
2023-10-07 10:50:05 -04:00
Conrad Irwin
34b7537948
Add universal links support to mac platform
2023-10-06 23:15:37 -06:00
Conrad Irwin
66120fb97a
Try universal link entitlement too
2023-10-06 22:25:00 -06:00
Mikayla
6de69de868
Remove change to linker args
2023-10-06 16:04:45 -07:00
Marshall Bowers
82577b4acc
Add Terminal component
2023-10-06 18:50:49 -04:00
Conrad Irwin
f6bc229d1d
More progress and some debug logs to remove
2023-10-06 16:48:29 -06:00
Marshall Bowers
8db7f7ed37
Add Tab component
2023-10-06 18:43:25 -04:00
Marshall Bowers
d5ffd4a1fb
Add Pane and PaneGroup components
2023-10-06 18:37:28 -04:00
Marshall Bowers
b53579858a
Add StatusBar component
2023-10-06 18:25:55 -04:00
Marshall Bowers
28d504d7d3
Add WorkspaceElement component
2023-10-06 18:19:12 -04:00
Conrad Irwin
63a230f92e
Make joining on boot work
2023-10-06 16:11:45 -06:00
Marshall Bowers
56c2ac048d
Add ProjectPanel component
2023-10-06 17:58:23 -04:00
Marshall Bowers
208d5df106
Add Buffer component
2023-10-06 17:47:10 -04:00
Marshall Bowers
d09f53c380
Add AssistantPanel component
2023-10-06 17:24:52 -04:00
Max Brunsfeld
f8ca86c6a7
Remove workspace -> channel dependency
2023-10-06 14:19:25 -07:00
Conrad Irwin
4128e2ffcb
Fix panic if the host is not there.
2023-10-06 15:18:25 -06:00
Marshall Bowers
696aee3891
Add IconButton component
2023-10-06 17:16:00 -04:00
Marshall Bowers
bcad2f4e9e
Move UI out of storybook2 and into ui2
2023-10-06 17:07:59 -04:00
Marshall Bowers
1cf5cdbeca
Add ui2 crate
2023-10-06 16:52:05 -04:00
Marshall Bowers
8e94f3902b
Merge branch 'marshall/merge-main-into-gpui2' into marshall/gpui2-playground
2023-10-06 16:47:40 -04:00
Max Brunsfeld
3412bb75be
Remove call -> channel dependency
2023-10-06 13:39:10 -07:00
Max Brunsfeld
17925ed563
Remove unnecessary dependencies on client and rpc
2023-10-06 13:14:53 -07:00
Max Brunsfeld
43da36948b
Add a crate-dep-graph script for showing the crate dependency graph
2023-10-06 13:14:39 -07:00
Marshall Bowers
88a6a41c7c
Revert changes to gpui2 crate
2023-10-06 15:49:53 -04:00
Conrad Irwin
b58c42cd53
TEMP
2023-10-06 13:47:35 -06:00
Marshall Bowers
d37785c214
Fix icon paths
2023-10-06 15:46:02 -04:00
Marshall Bowers
b369a6dc2a
Merge branch 'main' into marshall/merge-main-into-gpui2
2023-10-06 15:41:18 -04:00
Max Brunsfeld
9f32a6e209
collab 0.23.3
2023-10-06 11:25:46 -07:00
Max Brunsfeld
3f66caedfc
Fix error in query for last N channel messages ( #3100 )
2023-10-06 11:24:34 -07:00
Joseph T. Lyons
1dd82df59e
Use display name for release channel in panic events ( #3101 )
...
This was a mistake from long ago - something I've been meaning to fix
for a long time. All other events use `display_name()`, but panic
events, which leads to mistakes when filtering out `Zed Dev`, which
isn't the format that `dev_name()` returns. I'm adding a fix to zed.dev
as well:
- https://github.com/zed-industries/zed.dev/pull/393
so that the values are adjusted for all clients, not just ones with this
fix. I will correct the data in clickhouse, and adjust the queries in
metabase.
Release Notes:
- N/A
2023-10-06 14:20:06 -04:00
Joseph T. Lyons
81bc86be07
Use display name for release channel in panic events
2023-10-06 14:04:38 -04:00
Max Brunsfeld
663649a100
Fix error in query for last N channel messages
2023-10-06 10:58:34 -07:00
Marshall Bowers
5ee6814947
Fix compile errors
2023-10-06 13:54:37 -04:00
Marshall Bowers
65cd4f5838
Restore Sized bound on StyleHelpers
2023-10-06 13:45:56 -04:00
Marshall Bowers
7fd35d68bb
Merge branch 'gpui2' into marshall/gpui2-playground
2023-10-06 13:45:11 -04:00
Marshall Bowers
ad8187b151
Merge branch 'main' into marshall/gpui2-playground
2023-10-06 13:33:04 -04:00
Joseph T. Lyons
1e557dddcc
Add session id to panic events ( #3098 )
...
Release Notes:
- N/A
2023-10-06 13:32:45 -04:00
Julia
f18f870206
Re-enable language servers
2023-10-06 13:26:39 -04:00
Julia
9d8cff1275
If documentation included in original completion then parse up front
2023-10-06 13:26:39 -04:00
Julia
32a29cd4d3
Unbork info popover parsing/rendering and make better
2023-10-06 13:26:39 -04:00
Julia
8dca4c3f9a
Don't need editor style to parse markdown
2023-10-06 13:26:39 -04:00
Julia
a881b1f5fb
Wait for language to load when parsing markdown
2023-10-06 13:26:39 -04:00
Julia
ea6f366d23
If documentation exists and hasn't been parsed, do so at render and keep
2023-10-06 13:26:38 -04:00
Julia
b8876f2b17
Preparse documentation markdown when resolving completion
2023-10-06 13:26:38 -04:00
Julia
fe62423344
Asynchronously request completion documentation if not present
2023-10-06 13:26:38 -04:00
Julia
fcaf48eb49
Use completion item default data when provided
2023-10-06 13:26:38 -04:00
Julia
77ba25328c
Most of getting completion documentation resolved & cached MD parsing
2023-10-06 13:26:38 -04:00
Julia
ca88717f0c
Make completion docs scrollable
2023-10-06 13:26:38 -04:00
Julia
e8be14e5d6
Merge info popover's and autocomplete docs' markdown rendering
2023-10-06 13:26:38 -04:00
Julia
370a3cafd0
Add markdown rendering to alongside completion docs
2023-10-06 13:26:38 -04:00
Julia
1584dae9c2
Actually display the correct completion's doc
2023-10-06 13:26:38 -04:00
Julia
e802c072f7
Start hacking in autocomplete docs
2023-10-06 13:26:38 -04:00
Marshall Bowers
456baaa112
Mainline GPUI2 UI work ( #3099 )
...
This PR mainlines the current state of new GPUI2-based UI from the
`gpui2-ui` branch.
Included in this is a performance improvement to make use of the
`TextLayoutCache` when calling `layout` for `Text` elements.
Release Notes:
- N/A
---------
Co-authored-by: Nate Butler <iamnbutler@gmail.com >
Co-authored-by: Antonio Scandurra <me@as-cii.com >
2023-10-06 13:18:56 -04:00
Joseph T. Lyons
2c7e37e9ff
Add session id to panic events
2023-10-06 12:32:20 -04:00
Conrad Irwin
2d99b327fc
Don't wrap on paragraphs
...
For zed-industries/community#2116
2023-10-06 10:32:15 -06:00
Marshall Bowers
79ad5c08e4
Add profiling information for compute_layout
2023-10-06 10:48:25 -04:00
KCaverly
391179657c
clean up redundancies in prompts and ensure tokens are being reserved for generation when filling semantic context
2023-10-06 16:43:19 +02:00
KCaverly
ecfece3ac4
catchup with main
2023-10-06 16:30:31 +02:00
KCaverly
ed548a0de2
ensure indexing is only done when permissioned
2023-10-06 16:08:36 +02:00
KCaverly
84553899f6
updated spacing for assistant context status icon
2023-10-06 15:43:28 +02:00
Antonio Scandurra
ca6eb5511c
Checkpoint: underlines
2023-10-06 15:34:37 +02:00
Piotr Osiewicz
c46137e40d
chore: Upgrade to Rust 1.73 ( #3096 )
...
Release Notes:
- N/A
2023-10-06 14:50:29 +02:00
Piotr Osiewicz
b391f5615b
rust: Highlight async functions in completions ( #3095 )
...
Before (code in screenshot is from this branch,
`crates/zed/languages/rust.rs:179`):

Notice how the last 2 entries (that are async functions) are not
highlighted properly.
After:

This is slightly suboptimal, as it's hard to tell that this is an async
function - I guess adding an `async` prefix is not really an option, as
then we should have a prefix for non-async functions too. Still, at
least you can tell that something is a function in the first place. :)
Release Notes:
- Fixed Rust async functions not being highlighted in completions.
2023-10-06 14:43:03 +02:00
KCaverly
38ccf23567
add indexing on inline assistant opening
2023-10-06 08:46:40 +03:00
KCaverly
c0a1328532
fix spawn bug from calling
2023-10-06 08:30:54 +03:00
Nathan Sobo
65c7765c07
Checkpoint
2023-10-05 21:02:26 -06:00
Nathan Sobo
e99f6c03c1
Synchronize access when starting and stopping display links
...
Hoping this prevents panics we were observing when starting.
2023-10-05 20:46:26 -06:00
Mikayla
31062d424f
make bundle script incremental when using debug or local builds
2023-10-05 16:56:44 -07:00
Max Brunsfeld
559433bed0
Fix panic when immediately closing a window while opening paths ( #3092 )
...
Fixes this panic that I've been seeing in Slack:
[example](https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1696530575535779 )
```
thread 'main' panicked at 'assertion failed: opened_items.len() == project_paths_to_open.len()'
crates/workspace/src/workspace.rs:3628
<backtrace::capture::Backtrace>::create
<backtrace::capture::Backtrace>::new
Zed::init_panic_hook::{closure#0}
std::panicking::rust_panic_with_hook
std::panicking::begin_panic_handler::{{closure}}
std::sys_common::backtrace::__rust_end_short_backtrace
_rust_begin_unwind
core::panicking::panic_fmt
core::panicking::panic
<workspace::Workspace>::new_local::{closure#0}::{closure#0}
```
I believe it was caused by a window being closed immediately, while it
was still loading some paths. There was a mismatch in expectation
between the `workspace::open_items` function (which contains this
assertion), and the `Workspace::load_workspace` method. That later
method can return an empty vector if the workspace handle is dropped
while it is executing.
Release Notes:
- Fixed a crash when closing a Zed window immediately after opening it
2023-10-05 16:28:23 -07:00
Max Brunsfeld
8fafae2cfa
Fix panic when immediately closing a window while opening paths
2023-10-05 16:21:14 -07:00
Max Brunsfeld
b3c9473bc8
collab 0.23.2
2023-10-05 16:06:28 -07:00
Max Brunsfeld
b77c815bcd
Fix bugs in handling mutual following ( #3091 )
...
This fixes some bugs in our following logic, due to our attempts to
prevent infinite loops when two people follow each other.
* Propagate all of leader's views to a new follower, even if those views
were originally created by that follower.
* Propagate active view changes to followers, even if the active view is
following that follower.
* Avoid redundant active view updates on the client.
Release Notes:
- Fixed bugs where it was impossible to follow someone into a view that
they previously following you into.
2023-10-05 15:16:58 -07:00
Conrad Irwin
13192fa03c
Code to allow opening zed:/channel/1234
...
Refactored a bit how url arguments are handled to avoid adding too much
extra complexity to main.
2023-10-05 14:57:45 -07:00
Conrad Irwin
b258ee5f77
Fix ./script/bundle -l
2023-10-05 14:55:39 -07:00
Conrad Irwin
a63eccf188
Add url schemes to Zed
2023-10-05 14:55:39 -07:00
Mikayla Maki
37de4a9990
Add markdown parsing to channel chat ( #3088 )
...
TODO:
- [x] Add markdown rendering to channel chat
- [x] Unify (?) rendering logic between hover popover and chat
- [x] ~~Determine how to deal with document-oriented markdown like `#`~~
Unimportant until we want to do something special with `#channel`
- [x] Tidy up spacing and styles in chat panel
Release Notes:
- Added markdown rendering to channel chat
- Improved channel chat message style
- Fixed a bug where long chat messages would not soft wrap
2023-10-05 14:30:12 -07:00
Mikayla
c4870e1b6b
re-unify markdown parsing between hover_popover and chat
2023-10-05 14:22:41 -07:00
Nathan Sobo
6f7c305308
Checkpoint
2023-10-05 14:42:29 -06:00
Max Brunsfeld
438dd42f7d
Fix bugs in handling mutual following
...
* Propagate all of leader's views to a new follower, even if those views
were originally created by that follower.
* Propagate active view changes to followers, even if the active view is
following that follower.
* Avoid redundant active view updates on the client.
2023-10-05 13:28:46 -07:00
Mikayla
f57d563578
Improve chat rendering
2023-10-05 11:58:41 -07:00
Joseph T. Lyons
c8535440d3
Add session id ( #3090 )
...
Release Notes:
- N/A
2023-10-05 14:57:08 -04:00
Joseph T. Lyons
84ea34f918
Add session id
2023-10-05 14:50:48 -04:00
Mikayla
44ada52185
Fix bug where chat text wouldn't wrap to width
2023-10-05 11:06:29 -07:00
Conrad Irwin
78b1231386
Clear SelectionGoal on input ( #3089 )
...
Release Notes:
- `up` and `down` now go to the correct place after inserting
2023-10-05 09:57:36 -06:00
Antonio Scandurra
fe3ef08f39
Checkpoint!
2023-10-05 09:34:54 -06:00
Conrad Irwin
f1c743286d
Clear SelectionGoal on input
2023-10-05 09:02:52 -06:00
Antonio Scandurra
657a25178d
Checkpoint
2023-10-05 17:00:37 +02:00
KCaverly
0666fa80ac
moved status to icon with additional information in tooltip
2023-10-05 16:49:25 +03:00
Antonio Scandurra
f3560caf93
Checkpoint
2023-10-05 15:34:57 +02:00
Antonio Scandurra
2e056e9b0b
WIP
2023-10-05 15:30:47 +02:00
Antonio Scandurra
92bda1231e
Use content mask for quad as well
2023-10-05 12:11:28 +02:00
KCaverly
ec1b4e6f85
added initial working status in inline assistant prompt
2023-10-05 13:01:11 +03:00
Antonio Scandurra
7643bd61fd
Checkpoint
2023-10-05 10:59:50 +02:00
Antonio Scandurra
bf73b40529
Draw only once on next frame callbacks
2023-10-05 10:57:16 +02:00
Nathan Sobo
ed20397a2b
Checkpoint
2023-10-05 00:13:17 -06:00
Nathan Sobo
1c70ca2214
Checkpoint
2023-10-05 00:08:45 -06:00
Nathan Sobo
77b9a7aa5a
Checkpoint
2023-10-04 23:59:21 -06:00
Nathan Sobo
0d0c760d94
Checkpoint
2023-10-04 23:03:00 -06:00
Nathan Sobo
177e385bb9
Checkpoint: Fix a crash
2023-10-04 22:59:01 -06:00
Nathan Sobo
699a5d2944
Checkpoint
2023-10-04 20:35:24 -06:00
Mikayla
d298afba01
Create markdown text element and add to channel chat
2023-10-04 17:47:30 -07:00
Marshall Bowers
45d08c70f0
Add .when to Elements
2023-10-04 18:33:28 -04:00
Marshall Bowers
77feecc623
Add List component
2023-10-04 18:25:43 -04:00
Mikayla Maki
acffc7e7f0
Remove old code from notes icon click handler ( #3085 )
...
Release Notes:
- Fix clicking the notes icon when people are in the channel (preview
only)
2023-10-04 15:15:25 -07:00
Mikayla Maki
b0e56b7c54
107 channel touch ups ( #3087 )
...
Release Notes:
- Add user avatars to channel chat messages
- Group messages by sender
- Fix visual bugs in new chat and note buttons
2023-10-04 15:14:39 -07:00
Max Brunsfeld
df2fa87e6b
collab 0.23.1
2023-10-04 15:12:17 -07:00
Max Brunsfeld
a27be35325
Ensure chat messages are retrieved in order of id ( #3086 )
...
Also, remove logic for implicitly marking chat messages as observed when
they are fetched. I think this is unnecessary, because the client always
explicitly acknowledges messages when they are shown.
Release Notes:
- Fixed a bug where chat messages were shown out of order (preview only)
2023-10-04 15:10:49 -07:00
Mikayla
2f3c3d510f
Fix hit boxes and hover styles for new buttons
...
co-authored-by: conrad <conrad.irwin@gmail.com >
2023-10-04 14:44:50 -07:00
Max Brunsfeld
d09767a90b
Ensure chat messages are retrieved in order of id
2023-10-04 14:43:53 -07:00
Conrad Irwin
427a857e9a
Fix panic in increment ( #3084 )
...
Release Notes:
- Fixes a panic in vim when incrementing a non-number.
2023-10-04 15:39:24 -06:00
Conrad Irwin
e9842091e4
save tweaks ( #3031 )
...
- use SaveAll instead of Save
- TODO: fix where closing a multi-buffer gives a confusing save prompt
2023-10-04 15:38:07 -06:00
Marshall Bowers
332f3f5617
Merge branch 'gpui2' into marshall/gpui2-playground
2023-10-04 17:32:21 -04:00
Mikayla
73e78a2257
Adjust channel rendering to group related messages
2023-10-04 14:29:08 -07:00
Conrad Irwin
f7cd0e84f9
Remove old code from notes icon click handler
2023-10-04 15:18:26 -06:00
Conrad Irwin
a4e77af571
Fix panic in increment
2023-10-04 15:13:01 -06:00
Nathan Sobo
c8bc68c267
Checkpoint
2023-10-04 15:08:04 -06:00
Nathan Sobo
02d6b91b73
Checkpoint
2023-10-04 15:05:04 -06:00
Mikayla
5074bccae4
Add image avatars to channel messages
2023-10-04 14:04:02 -07:00
Conrad Irwin
7d94b0325f
Fix renaming ( #3083 )
...
Release Notes:
- Fix bugs arising from saving an untitled buffer
2023-10-04 14:50:31 -06:00
Conrad Irwin
ff1722d307
Fix tracking newly saved buffers
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-10-04 14:44:21 -06:00
Nathan Sobo
e68b24f839
Checkpoint
2023-10-04 13:43:21 -06:00
Marshall Bowers
339ba7986f
Add Avatar element
2023-10-04 15:34:14 -04:00
Joseph T. Lyons
6cb674a0aa
collab 0.23.0
2023-10-04 15:01:38 -04:00
Joseph T. Lyons
6db47478cf
v0.108.x dev
2023-10-04 15:00:53 -04:00
Mikayla Maki
01b45f4f23
Show when a channel resource changes ( #3074 )
...
This PR adds a mechanism for notifying the client when a channel note
has been edited or a message has been changed.
TODO:
- [x] Fix infinite loop when opening the chat panel
- [x] Switch to client-side ack model of observation detection
- [x] Add client-side-only change detection (e.g. for when a channel
note is open locally but not focused)
- [x] Review implementation / query performance.
- [x] Fix lack of ACK on restart for channel buffers
- [x] remove channel note opening on click
- [x] Fix channel messages sent while chat channel is in the background
not showing the channel as changed.
Release Notes:
- N/A
2023-10-04 11:57:33 -07:00
Mikayla
4d61d01943
Add an RPC handler for channel buffer acks
...
co-authored-by: max <max@zed.dev >
2023-10-04 11:47:13 -07:00
Mikayla
dd0edcd203
Changed the on-click behavior of joining a channel to not open the chat, and only open 1 project instead of all projects
...
Co-authored-by: conrad <conrad.irwin@gmail.com >
Co-authored-by: max <max@zed.dev >
2023-10-04 11:46:08 -07:00
Antonio Scandurra
ebc80597d5
WIP
2023-10-04 20:09:55 +02:00
Antonio Scandurra
d28c81571c
Checkpoint
2023-10-04 19:59:24 +02:00
Antonio Scandurra
dc9a260425
Checkpoint
2023-10-04 19:53:29 +02:00
Marshall Bowers
249e6fe637
Add Icon element
2023-10-04 13:46:45 -04:00
Marshall Bowers
e84b8747a1
Add storybook CLI
2023-10-04 13:33:28 -04:00
Mikayla
e548572f12
Fix channel messages test
2023-10-04 10:13:02 -07:00
Marshall Bowers
0323a60d85
Remove unneeded theme function
...
This also fixes the panic when trying to declare the `GPUIApplication` class.
2023-10-04 13:11:02 -04:00
Marshall Bowers
a05cbf8169
Begin setting up stories
2023-10-04 12:49:06 -04:00
Antonio Scandurra
5aa45607eb
Checkpoint
2023-10-04 18:38:08 +02:00
Antonio Scandurra
133c3a330c
Checkpoint
2023-10-04 17:59:29 +02:00
Antonio Scandurra
f9646208e9
Checkpoint
2023-10-04 17:48:28 +02:00
Marshall Bowers
4b793f44ef
Wire up hacky children for Panel
2023-10-04 11:22:33 -04:00
Marshall Bowers
aae4f00a4b
Render Panel
2023-10-04 10:58:23 -04:00
Marshall Bowers
366a4918c3
Fix icon paths
2023-10-04 10:52:39 -04:00
Antonio Scandurra
bc1801fb03
Checkpoint
2023-10-04 16:42:28 +02:00
Marshall Bowers
25cd12cf33
Fix icon name
2023-10-04 10:41:21 -04:00
Marshall Bowers
90e22da930
Render workspace
2023-10-04 10:37:29 -04:00
Marshall Bowers
e6c7e57711
Merge branch 'gpui2' into marshall/gpui2-playground
2023-10-04 10:33:40 -04:00
Antonio Scandurra
d385bc9cce
Allow tinting images grayscale
2023-10-04 15:27:51 +02:00
Antonio Scandurra
1816ab95a0
Checkpoint: start rendering images
2023-10-04 15:03:21 +02:00
Antonio Scandurra
5c750b6880
Checkpoint: emojis rendering
2023-10-04 12:41:21 +02:00
Antonio Scandurra
cd1c137542
WIP
2023-10-04 11:53:20 +02:00
Antonio Scandurra
4cf2ba20c2
Checkpoint: render SVGs
2023-10-04 10:51:47 +02:00
Antonio Scandurra
a1ee2db6d1
Use Courier for now, to avoid panicking
2023-10-04 08:48:05 +02:00
Mikayla
db8096ccdc
Fix most tests for new chat changes
2023-10-03 20:50:17 -07:00
Nathan Sobo
25a2554bdd
Checkpoint
2023-10-03 21:23:32 -06:00
Mikayla
3bc7024f8b
Fix unit test
...
co-authored-by: Conrad <conrad.irwin@gmail.com >
2023-10-03 20:03:57 -07:00
Mikayla
4ff80a7074
Fix a few mouse event id bugs and move facepile to the left
...
co-authored-by: conrad <conrad.irwin@gmail.com >
2023-10-03 19:45:33 -07:00
Mikayla
23ee8211c7
Lower frequency of popup warning when leaving a call
...
co-authored-by: conrad <conrad.irwin@gmail.com >
2023-10-03 19:30:05 -07:00
Nathan Sobo
1e0ff65337
Checkpoint
2023-10-03 20:19:59 -06:00
Nathan Sobo
da211bef96
Checkpoint
2023-10-03 20:04:17 -06:00
Max Brunsfeld
95342c8c33
Merge branch 'main' into channel-changes
2023-10-03 17:52:28 -07:00
Max Brunsfeld
61e0289014
Acknowledge channel notes and chat changes when views are active
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-10-03 17:40:10 -07:00
Max Brunsfeld
af09861f5c
Specify uuid crate in the root Cargo.toml
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-10-03 17:39:24 -07:00
Nathan Sobo
7f9e3bc787
Checkpoint
2023-10-03 17:58:11 -06:00
Nathan Sobo
d995192dde
Checkpoint: Get basic workspace rendering
2023-10-03 17:39:03 -06:00
Nathan Sobo
c57e19c8fa
Checkpoint: Glyphs rendering how I'd like
2023-10-03 17:29:36 -06:00
Nathan Sobo
550d9a9f71
Checkpoint
2023-10-03 16:17:25 -06:00
Nathan Sobo
4208ac2958
WIP
2023-10-03 15:17:45 -06:00
Nathan Sobo
45429b5400
WIP
2023-10-03 14:25:29 -06:00
Nathan Sobo
d3916b84c9
Checkpoint
2023-10-03 13:55:53 -06:00
Conrad Irwin
55d2b9b3c9
join channels ( #3082 )
...
Release Notes:
- Clicking on a channel in the sidebar will now join the channel and
open the notes
- If you join a channel that already shared projects, you will join the
projects automatically and follow the host.
- Clicking on the current channel in the sidebar will re-open the notes.
- Chat can now be accessed from the right click menu of channels.
- (probably not worth mentioning) Various improvements to hover states
and tooltips in the collab ui; and if you click on a channel while in
another call, confirm before switching.
2023-10-03 13:54:11 -06:00
Nathan Sobo
3b27d41c72
Checkpoint
2023-10-03 13:52:10 -06:00
Conrad Irwin
044fb9e2f5
Confirm on switching channels
2023-10-03 13:45:48 -06:00
Mikayla
6007c8705c
Upgrade SeaORM to latest version, also upgrade sqlite bindings, rustqlite, and remove SeaQuery
...
co-authored-by: Max <max@zed.dev >
2023-10-03 12:16:53 -07:00
Nathan Sobo
a8c1958c75
Checkpoint
2023-10-03 13:03:29 -06:00
Conrad Irwin
d696b394c4
Tooltips for contacts
2023-10-03 12:54:39 -06:00
Mikayla
32c4138758
Added db message and edit operation observation
...
Co-authored-by: Max <max@zed.dev >
2023-10-03 11:39:59 -07:00
Conrad Irwin
d8bfe77a3b
Scroll so that collab panel is in good state for calls
2023-10-03 12:00:02 -06:00
Joseph T. Lyons
8b0969b698
Update cpu and memory event code ( #3081 )
...
Release Notes:
- N/A
2023-10-03 13:36:35 -04:00
Conrad Irwin
66dfa47c66
Update collab ui to join channels again
2023-10-03 11:36:01 -06:00
Joseph T. Lyons
b10255a6dd
Update cpu and memory event code
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-10-03 13:29:08 -04:00
Nathan Sobo
3698e89b88
Checkpoint
2023-10-03 11:16:42 -06:00
Antonio Scandurra
bfa211fb02
Checkpoint
2023-10-03 18:04:45 +02:00
Antonio Scandurra
dc40ac854a
WIP
2023-10-03 17:53:44 +02:00
Antonio Scandurra
2b6d041cb6
Checkpoint
2023-10-03 17:36:12 +02:00
Antonio Scandurra
8a58733d91
Checkpoint
2023-10-03 16:53:49 +02:00
Antonio Scandurra
e49b411205
Checkpoint
2023-10-03 16:30:41 +02:00
KCaverly
933c21f3d3
add initial (non updating status) toast
2023-10-03 16:53:57 +03:00
KCaverly
f40d3e82c0
add user prompt for permission to index the project, for context retrieval
2023-10-03 16:26:08 +03:00
Antonio Scandurra
08464ee26e
Checkpoint
2023-10-03 15:23:49 +02:00
Antonio Scandurra
12ba10bc2c
Checkpoint
2023-10-03 14:48:08 +02:00
Nathan Sobo
dcaf4c905f
Checkpoint
2023-10-03 05:57:15 -06:00
Nathan Sobo
6046ed4f5c
Checkpoint
2023-10-03 05:51:59 -06:00
KCaverly
1a2756a232
start greedily indexing when inline assistant is started, if project has been previously indexed
2023-10-03 14:07:42 +03:00
KCaverly
ed894cc06f
only render retrieve context button if semantic index is enabled
2023-10-03 12:09:35 +03:00
KCaverly
166ca2a227
catching up with main
2023-10-03 12:05:00 +03:00
Kyle Caverly
cf5d89d13c
Leverage embeddings query to collapse syntax nodes if not selected ( #3067 )
...
Reverts zed-industries/zed#3049
2023-10-03 12:02:47 +03:00
KCaverly
9f160537ef
move collapsed only matches outside item parent in embedding.scm
2023-10-03 11:56:45 +03:00
KCaverly
bfe76467b0
add retrieve context button to inline assistant
2023-10-03 11:19:54 +03:00
Conrad Irwin
18e7305b6d
Change channel join behavior
...
- Clicking on a channel name now joins the channel if you are not in it
- (or opens the notes if you are already there).
- When joining a channel, previously shared projects are opened
automatically.
- If there are no previously shared projects, the notes are opened.
2023-10-02 23:20:06 -06:00
Conrad Irwin
d9813a5bec
show host in titlebar ( #3072 )
...
Release Notes:
- show host in the titlebar of shared projects
- clicking on faces in the titlebar will now always follow the person
(it used to toggle)
- clicking on someone in the channel panel will follow that person
- highlight the currently open project in the channel panel
- fixes a bug where sometimes following between workspaces would not
work
2023-10-02 21:02:02 -06:00
Conrad Irwin
d7867cd1e2
Add/fix mouse interactions in current call sidebar
2023-10-02 19:38:45 -06:00
Marshall Bowers
30afc8b1d2
WIP: Panel
2023-10-02 20:16:55 -04:00
Mikayla
32b4b4d24d
Add message and operation ACK messages to protos
2023-10-02 17:10:03 -07:00
Joseph T. Lyons
7d32a717af
Add memory and cpu events ( #3080 )
...
Release Notes:
- N/A
2023-10-02 19:42:49 -04:00
Joseph T. Lyons
892350fa2d
Add memory and cpu events
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-10-02 19:35:31 -04:00
Max Brunsfeld
0db4b29452
Avoid N+1 query for channels with new messages
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-10-02 16:22:28 -07:00
Marshall Bowers
74ac6eb8a3
Begin building out new ui crate in storybook2
2023-10-02 18:59:44 -04:00
Max Brunsfeld
d9d997b218
Avoid N+1 query for channels with notes changes
...
Also, start work on new timing for recording observed notes edits.
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-10-02 15:58:34 -07:00
Max Brunsfeld
84c4db13fb
Avoid spurious notifies in chat channel select
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-10-02 15:57:59 -07:00
Conrad Irwin
528fa5c57b
Refactor to remove toggle_follow
2023-10-02 16:51:02 -06:00
Marshall Bowers
9a9a35bf40
Move Sized bound up onto StyleHelpers
2023-10-02 18:46:25 -04:00
Marshall Bowers
d14dc35efe
Merge branch 'gpui2' into marshall/gpui2-playground
2023-10-02 18:36:22 -04:00
Conrad Irwin
27d784b23e
Fix bug in following
...
Prior to this change you could only follow across workspaces when you
were heading to the first window.
2023-10-02 16:29:42 -06:00
Marshall Bowers
9e1f7c4c18
Mainline GPUI2 UI work ( #3079 )
...
This PR mainlines the current state of new GPUI2-based UI from the
`gpui2-ui` branch.
Release Notes:
- N/A
---------
Co-authored-by: Nate Butler <iamnbutler@gmail.com >
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com >
Co-authored-by: Nate <nate@zed.dev >
2023-10-02 18:20:47 -04:00
Marshall Bowers
77e67c19fe
Fix deadlock when obtaining the font ID
2023-10-02 16:10:41 -04:00
Nathan Sobo
91582257fb
WIP
2023-10-02 14:02:28 -06:00
Nathan Sobo
66ef5549e9
Checkpoint
2023-10-02 13:34:07 -06:00
Nathan Sobo
79e1e1a747
Checkpoint
2023-10-02 13:16:10 -06:00
Nathan Sobo
0b13c0a437
Checkpoint
2023-10-02 12:47:45 -06:00
Julia
08361eb84e
Detach completion confirmation task when selecting with mouse ( #3078 )
...
Otherwise the spawn to resolve the additional edits never runs causing
autocomplete to never add imports automatically when clicking with the
mouse
Release Notes:
- Fixed auto-complete additional edits, such as auto-import, not
applying when selecting a completion with a mouse click.
2023-10-02 13:32:06 -04:00
Julia
3d68fcad0b
Detach completion confirmation task when selecting with mouse
...
Otherwise the spawn to resolve the additional edits never runs causing
autocomplete to never add imports automatically when clicking with the
mouse
2023-10-02 13:18:49 -04:00
Conrad Irwin
7f44083a96
Remove unused function
2023-10-02 11:03:55 -06:00
Conrad Irwin
39af2bb0a4
Ensure notifications are dismissed
...
Before this change if you joined a project without clicking on the
notification it would never disappear.
Fix a related bug where if you have more than one monitor, the
notification was only dismissed from one of them.
2023-10-02 11:01:21 -06:00
KCaverly
e9637267ef
add placeholder button for retrieving additional context
2023-10-02 19:50:57 +03:00
KCaverly
f20f096a30
searching the semantic index, and passing returned snippets to prompt generation
2023-10-02 19:15:59 +03:00
Conrad Irwin
9dc292772a
Add a screen for gpui tests
...
Allows me to test notifications
2023-10-02 09:53:30 -06:00
Antonio Scandurra
bf5d9e3224
Sort matches before processing them
2023-10-02 17:50:52 +02:00
Antonio Scandurra
d70014cfd0
Summarize file in the background
2023-10-02 15:36:10 +02:00
Piotr Osiewicz
a785eb9141
auto-update: Link to the current release's changelog, not the latest one ( #3076 )
...
An user complained in zed-industries/community#2093 that we always link
to the latest release changelog, not the one that they've just updated
to.
Release Notes:
- Fixed changelog link in update notification always leading to the
latest release changelog, not the one that was updated to. Fixes
zed-industries/community#2093 .
2023-10-02 15:24:09 +02:00
Antonio Scandurra
f52200a340
Prevent deploying the inline assistant when selection spans multiple excerpts
2023-10-02 15:21:58 +02:00
Antonio Scandurra
df7ac9b815
💄
2023-10-02 14:36:16 +02:00
Antonio Scandurra
64a55681e6
Summarize the contents of a file using the embedding query
2023-10-02 14:32:13 +02:00
Mikayla
1d5b665f13
Implement channel changes for messages
2023-10-01 22:32:11 -07:00
Mikayla
51cf6a5ff3
Add database implementation of channel message change tracking
2023-10-01 22:32:11 -07:00
Mikayla
e0ff7ba180
Add channel note indicator and clear changed status
2023-10-01 22:32:10 -07:00
Mikayla
9ba975d6ad
Channel notifications from the server works
2023-10-01 22:30:21 -07:00
Mikayla
1469c02998
Add observed_channel_notes table and implement note diffing
2023-10-01 22:26:27 -07:00
Joseph T. Lyons
95e09dd2e9
Add Nushell support to venv activation ( #3073 )
...
This PR adds an option to run `activate.nu` in the automatic venv
activation code (relevant comment
[here](https://github.com/zed-industries/community/issues/2103#issuecomment-1742355651 ))
Release Notes:
- Added a `nushell` option to the
`terminal.detect_venv.on.activate_script` setting
([2103](https://github.com/zed-industries/community/issues/2103 )).
2023-10-01 23:55:57 -04:00
Joseph T. Lyons
e5e63ed201
Add Nushell support to venv activation
2023-10-01 23:38:30 -04:00
Nathan Sobo
4212a45767
WIP
2023-09-30 10:01:59 -06:00
Nathan Sobo
ef01a64826
Fix infinite loop
2023-09-30 09:43:52 -06:00
Marshall Bowers
46b4118b9e
Checkpoint: Things are running, but with a stack overflow
2023-09-29 22:57:17 -04:00
Marshall Bowers
c7fc5f3ab7
Checkpoint: Fix downcasting
2023-09-29 22:53:24 -04:00
Marshall Bowers
f50a23accd
Adjust window dimensions
...
Since resizing freezes the window.
2023-09-29 21:55:34 -04:00
Marshall Bowers
43a1296150
Checkpoint: Storybook window showing
2023-09-29 21:51:27 -04:00
Marshall Bowers
3b38641f98
Fix stack overflow by removing Deref and DerefMut impls
2023-09-29 21:21:08 -04:00
Marshall Bowers
8cac89d17c
Checkpoint: Compiling
2023-09-29 20:51:52 -04:00
Conrad Irwin
92bb9a5fdc
Make following more good
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-09-29 17:59:19 -06:00
Marshall Bowers
963f179d7f
Checkpoint: Cast through std::mem::transmute
2023-09-29 19:41:31 -04:00
Marshall Bowers
103183f494
WIP: Parameterize over thread
2023-09-29 19:20:18 -04:00
Conrad Irwin
1cfc2f0c07
Show host in titlebar
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-09-29 16:37:00 -06:00
Conrad Irwin
219715449d
More logging on collab by default
2023-09-29 16:37:00 -06:00
Max Brunsfeld
f011a3df52
Allow following participants who aren't in the same project ( #2993 )
...
The goal of this PR is to make Following more intuitive.
### Old Behavior
Previously, following was scoped to a project. In order to follow
someone in a given window, the window needed to contain a shared
project, and the leader needed to be present in the project. Otherwise,
following failed.
### New Behavior
* You can always follow **any** participant in the current call, in any
pane of any window.
* When following someone in a project that you're both collaborating in,
it works the same as before.
* When following someone in an unshared project, or a project that they
don't have open, you'll only get updates about the leader's views that
don't belong to a project, such as channel notes views. When the leader
focuses a file in a different project, you'll get the "follow $LEADER to
their active project" indicator
### Todo
* [x] Change db schema and RPC protocol so a project id isn't required
for following
* [x] Change client to allow following into non-project items regardless
of the leader's project
* [x] Assign colors to users in a way that doesn't require users to be
in a shared project.
2023-09-29 15:18:05 -07:00
Max Brunsfeld
7adaa2046d
Show current user as follower when following in unshared projects
2023-09-29 15:08:25 -07:00
Max Brunsfeld
948871969f
Fix active view update when center pane is not focused
2023-09-29 14:37:28 -07:00
Mikayla Maki
57707a80e6
Refactor elixir LSP settings ( #3071 )
...
This PR is a bit of a last minute change, but I realized there was
actually a third player in the Elixir LSP space who wants support as
well,
[lexical](https://github.com/zed-industries/community/issues/1567 ). I
realized that the settings arrangement I shipped in this preview
precludes adding a third kind of LSP. I don't have the time to learn how
to fully support this LSP, but I thought I'd at least refactor how the
settings are represented before this hits stable.
Release Notes:
- Changed the new `"elixir": { "next": "on" }` setting to `"elixir": {
"lsp": "next_ls" }`. The `elixir.lsp` setting requires a full restart to
take effect. (Preview only)
2023-09-29 14:25:05 -07:00
Max Brunsfeld
55da5bc25d
Switch .leader_replica_id -> .leader_peer_id
2023-09-29 14:16:38 -07:00
Max Brunsfeld
c718b810f6
Merge branch 'main' into allow-following-outside-of-projects
2023-09-29 14:15:33 -07:00
Max Brunsfeld
afd293ee87
Update active view when activating a window
2023-09-29 14:12:51 -07:00
Mikayla
752bc5dcdd
Refactor elixir LSP settings
2023-09-29 14:12:50 -07:00
Max Brunsfeld
973f03e73e
Fix bug in follower updates for non-project items
2023-09-29 14:09:14 -07:00
Max Brunsfeld
555c9847d4
Add ZED_ALWAYS_ACTIVE env var, use it in local collaboration script
...
This makes zed always behave as if the app is active, even if no window is focused.
It prevents the 'viewing a window outside of zed' state during collaboration.
2023-09-29 13:43:43 -07:00
Nathan Sobo
c1a35a29a8
WIP
2023-09-29 14:34:40 -06:00
Nathan Sobo
7a6c27cf24
WIP
2023-09-29 14:04:58 -06:00
Conrad Irwin
d9c1cf9874
vim: Fix accidental visual selection when following ( #3068 )
...
Release Notes:
- vim: Fix a bug where following could put you in visual mode
2023-09-29 13:59:59 -06:00
Mikayla Maki
1155f1b0e1
Add support for the TextDocumentSyncKind LSP option ( #3070 )
...
fixes https://github.com/zed-industries/community/issues/2098
Release Notes:
- Fixed a bug in Zed's LSP implementation when using Next LS.
2023-09-29 12:25:37 -07:00
Nathan Sobo
dcc314f088
Checkpoint
2023-09-29 13:22:53 -06:00
Mikayla
31ff5bffd6
Fix tests relying on off-spec behavior
2023-09-29 12:19:58 -07:00
Mikayla
4887ea3563
Add support for the TextDocumentSyncKind LSP options
2023-09-29 12:05:21 -07:00
Kyle Caverly
dbaaf4216d
add scheme for full parseable files in semantic index ( #3069 )
...
add scheme as a parseable file type in semantic index.
Each file will operate as a single embedding, in which no real scheme
syntax or tree-sitter level data is stored.
Release Notes:
- Added scheme to Semantic Index
2023-09-29 14:42:15 -04:00
Antonio Scandurra
53c25690f9
WIP: Use a different approach to codegen outline
2023-09-29 20:37:07 +02:00
KCaverly
3c12e711a4
add scheme for full parseable files in semantic index
2023-09-29 14:35:02 -04:00
Conrad Irwin
9b7bd4e9ae
vim: Fix accidental visual selection when following
2023-09-29 12:08:25 -06:00
Max Brunsfeld
026b3a1d0f
Remove uneeded Workspace::project_remote_id_changed method
2023-09-29 08:54:23 -07:00
Antonio Scandurra
d9c08de58a
Revert "Revert "leverage file outline and selection as opposed to entire file""
2023-09-29 17:15:26 +02:00
Marshall Bowers
c379a6f2fb
ui: Fix glyph used for option key in Keybinding ( #3066 )
...
This PR fixes the glyph used for the option key in the new `Keybinding`
component.
Same fix as in #3065 , but applied to the new `Keybinding` component so
that we don't regress when switching to GPUI2.
<img width="750" alt="Screenshot 2023-09-29 at 10 50 15 AM"
src="https://github.com/zed-industries/zed/assets/1486634/8c6147e9-fa05-4804-954c-b8e3b98cbdf0 ">
Release Notes:
- N/A
2023-09-29 11:02:35 -04:00
Piotr Osiewicz
488a3eeace
ui: Mirror option key in keybindings ( #3065 )
...


Release Notes:
- Fixed option key's appearance in keybindings
2023-09-29 16:45:49 +02:00
Antonio Scandurra
4dd9c9e2b9
Introduce the ability to include or exclude warnings from project diagnostics ( #3056 )
...

Release Notes:
- Added the ability to exclude warnings from project diagnostics. By
default, they will be on but they can be disabled temporarily by
clicking on the warnings icon. The default behavior can be changed by
changing the new `diagnostics.include_warnings` setting.
2023-09-29 13:13:04 +01:00
Max Brunsfeld
ca0a4bdf8e
Introduce a WorkspaceStore for handling following
2023-09-28 18:58:52 -07:00
Marshall Bowers
247c7eff14
storybook: Fix kitchen sink story ( #3064 )
...
This PR fixes the kitchen sink story in the storybook.
Included are some additional changes that make it so the kitchen sink is
automatically populated by all of the defined stories.
Release Notes:
- N/A
2023-09-28 21:22:50 -04:00
Max Brunsfeld
837ec5a27c
Remove stray file
2023-09-28 17:14:53 -07:00
Max Brunsfeld
5a15692589
🎨 Workspace::leader_updated
2023-09-28 17:13:10 -07:00
Max Brunsfeld
0058702749
Remove unused db query method
2023-09-28 17:13:10 -07:00
Max Brunsfeld
e34ebbc665
Remove unused dependencies on theme
2023-09-28 17:13:10 -07:00
Max Brunsfeld
38a9e6fde1
Fix removal of followers on Unfollow
2023-09-28 16:46:43 -07:00
Marshall Bowers
f26ca0866c
Mainline GPUI2 UI work ( #3062 )
...
This PR mainlines the current state of new GPUI2-based UI from the
`gpui2-ui` branch.
Release Notes:
- N/A
---------
Co-authored-by: Nate Butler <iamnbutler@gmail.com >
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
Co-authored-by: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com >
Co-authored-by: Nate <nate@zed.dev >
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-09-28 19:36:21 -04:00
Conrad Irwin
e7ee8a95f6
vim: Fix some dw edge cases ( #3058 )
...
Release Notes:
- vim: Fix `dw` on the last word of a line, and on empty lines.
2023-09-28 15:32:29 -06:00
Conrad Irwin
91adefedfa
vim keybinding updates ( #3057 )
...
Release Notes:
- vim: Add ctrl-i to go forward
([#1732 ](https://github.com/zed-industries/community/issues/1732 )).
ctrl-o was already supported.
- vim: Add `g <space>` to open the current snippet in its own file.
- vim: Escape will now return to normal mode even if completion menus
are open (use `ctrl-x ctrl-z` to hide menus, as in vim).
- vim: Add key bindings for Zed's various completion mechanisms:
- - `ctrl-x ctrl-o` to open the completion menu,
- - `ctrl-x ctrl-l` to open the LSP action menu,
- - `ctrl-x ctrl-c` to trigger Copilot (requires configuring copilot),
- - `ctrl-x ctrl-a` to trigger the inline Assistant (requires
configuring openAI),
NOTE: we should add these to the docs before shipping 0.107 to stable.
2023-09-28 15:32:21 -06:00
Conrad Irwin
2f5eaa8475
vim increment ( #3054 )
...
- vim: add ctrl-a/ctrl-x for increment/decrement
2023-09-28 15:32:11 -06:00
Joseph T. Lyons
da964fae93
Enable semantic_index by default ( #3061 )
...
Release Notes:
- Enabled the `semantic_index` setting by default.
2023-09-28 17:24:00 -04:00
Max Brunsfeld
e9c1ad6acd
Undo making project optional on stored follower states
...
Following works without a project, but following in unshared projects does
not need to be replicated to other participants.
2023-09-28 14:21:44 -07:00
Joseph T. Lyons
f965ee9b1b
Enable semantic_index by default
2023-09-28 17:17:26 -04:00
Max Brunsfeld
ce940da8e9
Fix errors from assuming all room_participant rows had a non-null participant_index
...
Rows representing pending participants have a null participant_index.
Co-authored-by: Conrad <conrad@zed.dev >
2023-09-28 12:03:53 -07:00
Max Brunsfeld
a8b35eb8f5
Merge branch 'main' into allow-following-outside-of-projects
2023-09-28 11:58:28 -07:00
Max Brunsfeld
0c95e5a6ca
Fix coloring of local selections when following
...
Co-authored-by: Conrad <conrad@zed.dev >
2023-09-28 11:37:47 -07:00
Max Brunsfeld
0f39b63801
Rename color_index to participant_index
...
Co-authored-by: Conrad <conrad@zed.dev >
2023-09-28 11:37:22 -07:00
Max Brunsfeld
545b5e0161
Assign unique color indices to room participants, use those instead of replica_ids
...
Co-authored-by: Conrad <conrad@zed.dev >
Co-authored-by: Antonio <antonio@zed.dev >
2023-09-28 11:06:09 -07:00
Joseph T. Lyons
3cf7164a54
Fix text transformation commands for multiple line, single selection cases ( #3060 )
...
If you highlight the following block of text (with a single selection):
```
The quick brown
fox jumps over
the lazy dog
```
and run `editor: convert to upper camel case`, you'll get:
```
TheQuickBrown
foxJumpsOver
theLazyDog
```
instead of:
```
TheQuickBrown
FoxJumpsOver
TheLazyDog
```
The same thing happens for `editor: convert to title case`. This happens
because [`to_case` crate](https://crates.io/crates/convert_case ) doesn't
allow the user to define '\n' as a boundary. I wanted to fix this at the
lib level, so I filled [an
issue](https://github.com/rutrum/convert-case/issues/16 ) but I never
heard back. What's strange is VS Code and Sublime I think both exhibit
the same output as we do currently, but I don't personally think this
feels right (happy to hear opposing opinions). I'm just doing the naive
thing to hack around this limitation of the `to_case` crate.
I did some testing and it seems I only need to adjust `editor: convert
to title case` and `editor: convert to upper camel case`. The way the
other transformations are implemented in `to_case` don't seem to have
this issue.
Release Notes:
- Fixed a bug where running certain text transfomration commands on a
single selection covering multiple lines would not transform all
selected lines as expected.
2023-09-28 14:04:17 -04:00
Nathan Sobo
3f50779a17
Checkpoint
2023-09-28 12:02:52 -06:00
Kirill Bulatov
a8188a2f33
Improve file finder ergonomics ( #3059 )
...
Deals with https://github.com/zed-industries/community/issues/2086
Part of https://github.com/zed-industries/community/issues/351
Initial:
<img width="585" alt="Screenshot 2023-09-28 at 09 50 05"
src="https://github.com/zed-industries/zed/assets/2690773/e0149312-dfe3-4b7c-948c-0f593d6f540c ">
First query letter input (only two history items match that, both are
preserved on top, with their order preserved also)
<img width="603" alt="Screenshot 2023-09-28 at 09 50 08"
src="https://github.com/zed-industries/zed/assets/2690773/85ab2f4c-bb9c-4811-b8b0-b5c14a370ae2 ">
Second query letter input, no matching history items:
<img width="614" alt="Screenshot 2023-09-28 at 09 50 11"
src="https://github.com/zed-industries/zed/assets/2690773/6d380403-a43c-4f00-a05b-88f43f91fefb ">
Remove second query letter, history items match again and pop to the
top:
<img width="574" alt="Screenshot 2023-09-28 at 09 50 15"
src="https://github.com/zed-industries/zed/assets/2690773/5981ca53-6bc8-4305-ae36-27144080e1a2 ">
* allows `file_finder::Toggle` (cmd-p by default) to cycle through file
finder items (ESC closes the modal still)
* on query typing, preserve history items that match the query and keep
them on top, with their ordering preserved
* show history items' matched letters
Release Notes:
- Improve file finder ergonomics: allow cycle through items with the
toggle action, preserve matching history items on query input
2023-09-28 19:53:09 +03:00
Kirill Bulatov
d30385f07c
Show path matches inside history items matching the query
2023-09-28 09:49:25 -07:00
Kirill Bulatov
1b5ff68c43
Show matching search history whenever possible
2023-09-28 09:34:20 -07:00
Kirill Bulatov
97eabe6f81
Add tests
2023-09-28 09:00:25 -07:00
Kirill Bulatov
57a95d1799
Preserve matching history items and their order
2023-09-28 06:55:49 -07:00
Kirill Bulatov
541dd994a9
Cycle file finder entries on cmd-p
2023-09-28 06:55:49 -07:00
Piotr Osiewicz
81a107f503
assets: Add keybinds to replace ( #3055 )
...
Release Notes:
- N/A
2023-09-28 13:04:14 +02:00
Nathan Sobo
5ab1034698
Checkpoint
2023-09-28 01:16:47 -06:00
Nathan Sobo
13ba450c4c
Checkpoint
2023-09-28 00:46:15 -06:00
Nathan Sobo
c5470d4050
Checkpoint
2023-09-27 23:24:07 -06:00
Nathan Sobo
7e49c7d782
Checkpoint
2023-09-27 23:19:32 -06:00
Nathan Sobo
769a04517f
Checkpoint - No warnings
2023-09-27 23:10:22 -06:00
Conrad Irwin
768c991909
vim: Fix some dw edge cases
2023-09-27 23:09:09 -06:00
Nathan Sobo
1ee70a0146
Checkpoint
2023-09-27 23:05:39 -06:00
Nathan Sobo
8be8047b8d
Checkpoint
2023-09-27 22:02:48 -06:00
Conrad Irwin
51b24bbaf3
Add vim-style completion bindings:
2023-09-27 21:29:18 -06:00
Conrad Irwin
2cb320e246
Escape returns to normal mode even if completion is open
...
For zed-industries/community#1746
2023-09-27 21:28:30 -06:00
Nathan Sobo
7524f7fbe8
Checkpoint
2023-09-27 21:25:06 -06:00
Nathan Sobo
9fefb1d898
Checkpoint
2023-09-27 21:14:09 -06:00
Conrad Irwin
73fc1c1c56
Add g space for option-enter
...
vimify all the things
2023-09-27 21:05:58 -06:00
Conrad Irwin
d1baff1743
Add ctrl-i to go forward
...
For zed-industries/community#1732
2023-09-27 21:04:13 -06:00
Conrad Irwin
dd1cf5c3cf
vim: add ctrl-a/ctrl-x
...
For zed-industries/community#1411
For zed-industries/community#619
2023-09-27 19:49:31 -06:00
Conrad Irwin
9246c11c35
Don't prompt to save unchanged files ( #3053 )
...
- don't prompt to save a set of unchanged files when closing
(preview-only)
2023-09-27 19:20:08 -06:00
Antonio Scandurra
0e6002dca2
Fix tests
2023-09-27 18:19:35 -06:00
Antonio Scandurra
78908bc5cb
Introduce a new include_warnings setting under diagnostics
2023-09-27 18:08:08 -06:00
Nathan Sobo
49672bfc5f
Checkpoint
2023-09-27 17:51:12 -06:00
Antonio Scandurra
f603d682cd
Add an include/exclude warnings toggle in project diagnostics
2023-09-27 17:47:19 -06:00
Nathan Sobo
b364d404a9
Checkpoint
2023-09-27 17:25:04 -06:00
Nathan Sobo
96f9c67e77
Checkpoint
2023-09-27 17:17:30 -06:00
Conrad Irwin
6cebcac805
fix tests
2023-09-27 17:02:47 -06:00
Conrad Irwin
3573896fe0
Don't prompt to save unchanged files
2023-09-27 16:07:35 -06:00
Nathan Sobo
e9a84a21e4
Checkpoint
2023-09-27 15:35:51 -06:00
Conrad Irwin
25429f760c
ctrl-a/x for vim
2023-09-27 12:32:01 -06:00
Joseph T. Lyons
ece4875973
v0.107.x dev
2023-09-27 12:26:48 -04:00
Kyle Caverly
2c0547079a
Revert "leverage file outline and selection as opposed to entire file" ( #3049 )
...
Reverts zed-industries/zed#3040
2023-09-27 12:21:11 -04:00
Kyle Caverly
b3b3a56164
Revert "leverage file outline and selection as opposed to entire file"
2023-09-27 12:21:03 -04:00
Kyle Caverly
4242b45646
Revert "removed stale dbg in assistant from main" ( #3048 )
...
Reverts zed-industries/zed#3046
2023-09-27 12:19:54 -04:00
Kyle Caverly
cab80cbe9d
Revert "removed stale dbg in assistant from main"
2023-09-27 12:19:44 -04:00
Julia
d671a8a21d
Bump update notification size back up ( #3047 )
...
Regressed:
<img width="422" alt="CleanShot 2023-09-27 at 11 07 37@2x"
src="https://github.com/zed-industries/zed/assets/30666851/636d7bec-4518-45e6-87bd-84b45dda28e1 ">
Fixed:
<img width="424" alt="CleanShot 2023-09-27 at 11 04 13@2x"
src="https://github.com/zed-industries/zed/assets/30666851/186a1d49-4daf-4211-891a-dacfd1144311 ">
Release Notes:
- N/A
2023-09-27 11:25:16 -04:00
Julia
6b88ac9c32
Bump update notification size back up
2023-09-27 11:04:25 -04:00
Piotr Osiewicz
6ccaf55e54
search: Reorder items in search bar ( #3039 )
...
Release Notes:
- Reordered items in project and buffer search bar
2023-09-27 16:51:20 +02:00
Kyle Caverly
edf29aa67d
implement new search strategy ( #3029 )
...
Augment current search strategy in semantic search, reducing search
times by ~60%
Release Notes:
- Implemented minimum batch sizes for concurrent database reads.
- Batch embedding matrix multiplication.
- Calculate matmul with ndarray
2023-09-27 10:37:48 -04:00
KCaverly
0e6fd645fd
leverage embeddings len returned in construction matrix multiplication
2023-09-27 10:33:04 -04:00
Conrad Irwin
c63cc78ffd
vim: Fix ctrl-u/ctrl-d ( #3044 )
...
- vim: Fix ctrl-d/ctrl-u to match vim (when :set scrolloff=3)
2023-09-27 07:48:50 -06:00
KCaverly
3682751455
Merge branch 'main' of github.com:zed-industries/zed into faster_semantic_search
2023-09-27 09:43:39 -04:00
KCaverly
abefa2738b
removed blas and increase batch size for vector search
2023-09-27 09:43:23 -04:00
Kyle Caverly
4ccd69350b
removed stale dbg in assistant from main ( #3046 )
...
remove small dbg! statement in main
2023-09-27 09:13:41 -04:00
KCaverly
0d6880adb3
removed stale dbg in assistant from main
2023-09-27 09:13:00 -04:00
Kyle Caverly
2f368de397
leverage file outline and selection as opposed to entire file ( #3040 )
...
Transition generate prompt for inline assist to leverage outline as
opposed to full file.
This enables, us to leverage the inline assist for large files.
Release Notes:
- Change inline assist to use tree-sitter based outlines for code
generation instead of full files
2023-09-27 09:10:18 -04:00
KCaverly
650a160f04
update test outline for prompt tests for new cursor span
2023-09-27 09:06:53 -04:00
Piotr Osiewicz
ecb037fc0e
language: Add block_comment to CSS ( #3045 )
...
Fixes zed-industries/community#2081
Release Notes:
- Fixed "toggle comment" action not working in CSS buffers.
2023-09-27 11:56:26 +02:00
Conrad Irwin
8e1bbf32be
vim: Fix ctrl-u/ctrl-d
...
They should work by exactly half a screen, and also move the cursor.
2023-09-26 22:28:04 -06:00
Conrad Irwin
30bb3a109e
Add SwapPaneInDirection ( #3043 )
...
- Add cmd-k shift-{left,right,up,down} to swap panes in that direction
- vim: Add ctrl-w shift-{h,j,k,l} to swap panes in that direction
([#278 ](https://github.com/zed-industries/community/issues/278 ))
2023-09-26 22:18:02 -06:00
Conrad Irwin
37b6e1cbb7
Add SwapPaneInDirection
...
Add keybindings for vim (and non-vim)
2023-09-26 22:00:51 -06:00
Kirill Bulatov
cb83b49432
Hide inlay hints toggle if they are not supported by the current editor ( #3041 )
...
Release Notes:
- N/A
2023-09-27 01:16:02 +03:00
Marshall Bowers
568fec0f54
Add Sized bound to StyleHelpers ( #3042 )
...
This PR adds a `Sized` bound to the `StyleHelpers` trait.
All of the individual methods on this trait already had a `Self: Sized`
bound, so moving it up to the trait level will make it so we don't have
to repeat ourselves so much.
There's an open question of whether we can hoist the `Sized` bound to
`Styleable`, but it's possible there are cases where we'd want to have a
`Styleable` trait object.
Release Notes:
- N/A
2023-09-26 18:15:41 -04:00
Kirill Bulatov
7e2cef98a7
Hide inlay hints toggle if they are not supported by the current editor
2023-09-26 23:52:11 +02:00
KCaverly
90f17d4a28
updated codegen match to leverage unused values
2023-09-26 17:11:20 -04:00
KCaverly
e8dd412ac1
update inline generate prompt to leverage more explicit <|START| and |END|> spans
2023-09-26 17:10:31 -04:00
KCaverly
54c63063e4
changed inline assist generate prompt to leverage outline as opposed to entire prior file
...
Co-Authored-by: Antonio <antonio@zed.dev >
2023-09-26 16:23:48 -04:00
Antonio Scandurra
58dadad8ec
WIP
2023-09-26 13:42:58 -06:00
Joseph T. Lyons
e9e558d8c8
Rework call events api ( #3038 )
...
There were times when events with bad data were being emitted. What we
found was that places where certain collaboration-related code could
fail, like sending an invite, would still send events; those events
would be in a bad state, as certain elements, such as a room, weren't
constructed as expected, causing the event to have missing data. The new
API guarantees that we have data in the correct configuration. In the
future, we will add events for certain types of failures within Zed, to
cover things like invites failing.
Release Notes:
- N/A
2023-09-26 14:29:25 -04:00
Joseph T. Lyons
0897ed561f
Rework call events api
...
There were time when events with bad data were being emitted. What we found was that places where certain collaboration-related code could fail, like sending an, would still send events, and those events be in a bad state, as certain elements weren't constructed as expected, thus missing in the event. The new API guarantees that we have data in the correct configuration. In the future, we will add events for certain types of failures within Zed.
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-09-26 14:18:32 -04:00
Piotr Osiewicz
e263805847
workspace: change save prompt for unnamed buffers ( #3037 )
...
Release Notes:
- N/A
2023-09-26 19:35:10 +02:00
Antonio Scandurra
bfe2205ecb
Checkpoint
2023-09-26 11:34:41 -06:00
Antonio Scandurra
04d3ea9563
Checkpoint
2023-09-26 11:29:44 -06:00
Piotr Osiewicz
8c47f117db
editor: Start transaction in replace impl ( #3036 )
...
This fixes the undo with replace in project
/cc @maxbrunsfeld
Release Notes:
- N/A
2023-09-26 19:21:15 +02:00
Piotr Osiewicz
36f022bb58
project_replace: Fix up key bindings ( #3034 )
...
Release Notes:
- N/A
2023-09-26 18:40:41 +02:00
KCaverly
e75f56a0f2
move to system blas
2023-09-26 12:39:22 -04:00
Marshall Bowers
342a00b89e
Remove dbg! from styleable_helpers! ( #3035 )
...
This PR removes a leftover `dbg!` from `styleable_helpers!`.
We already removed this in the `gpui2-ui` branch, but getting this on
`main` since @KCaverly pointed it out.
Release Notes:
- N/A
2023-09-26 10:49:55 -04:00
KCaverly
330a71d28b
fixed bug limiting number of results returned
2023-09-26 10:29:55 -04:00
KCaverly
ea278b5b12
ensure desc sort and cleanup unused imports
2023-09-26 09:53:49 -04:00
Kirill Bulatov
5e7f0c65fe
Fix another place where Copilot may panic ( #3033 )
2023-09-26 11:12:36 +03:00
Kirill Bulatov
b131a2cb98
Fix another place where Copilot may panic
2023-09-26 10:51:13 +03:00
Joseph T. Lyons
b5a39de3e2
Add reset_db script
2023-09-25 21:45:28 -04:00
Conrad Irwin
42df5ef45e
vim: Add multicursor shortcuts ( #3032 )
...
Adding a few bindings to bring first class feeling multiselect to zed's
vim emulation.
gn and gN are similar to similar vim bindings, ga is similar to gA (and
I doubt we need vim's real ga), g> and g< are just made up.
Release Notes:
- vim: `g n` / `g N` to select next/previous
- vim: `g >` / `g <` to skip current selection and select next/previous
- vim: `g a` to select all
2023-09-25 17:18:12 -05:00
Conrad Irwin
b29e295e1b
vim: Add multicursor shortcuts
...
- g n / g N to select next/previous
- g > / g < to select next/previous replacing current
- g a to select all matches
2023-09-25 15:32:03 -06:00
Mikayla Maki
8c90157990
Fix space and copy/paste when editing a channel ( #3030 )
...
This fixes several bugs with how spaces and keyboard commands interact
with channel creating / renaming.
fixes
https://github.com/zed-industries/community/discussions/2076#discussioncomment-7096959
Release Notes:
- N/A
2023-09-25 15:20:00 -05:00
Conrad Irwin
b454f43b6c
Add cmd-+ as an alias for cmd-= ( #3028 )
...
Release Notes:
- Allow cmd-+ in addition to cmd-= for zoom in
([#1021 ](https://github.com/zed-industries/community/issues/1021 )).
Although I had initially thought this was something more to do with
option key handling, it turns out to be a straightforward and reasonable
feature request.
2023-09-25 14:45:46 -05:00
Conrad Irwin
53194ede5e
Use SaveAll instead of Save
...
If we're closing items we should not be writing files that have not
changed (e.g. empty untitled buffers)
2023-09-25 13:14:30 -06:00
Conrad Irwin
d17d38fe70
vim: Command ( #2951 )
...
Release Notes:
- vim: Add v1 of command mode
([#279 ](https://github.com/zed-industries/community/issues/279 )). The
goal was to cover 90% of what most people actually do, but it is very
incomplete. Known omissions are that ranges cannot be specified (except
that `:%s//` must always specify the % range), commands cannot take
arguments (you can `:w` but not `:w [file]`), and there is no history.
Please file feature requests on
https://github.com/zed-industries/community as you notice things that
could be better.
- `:` triggers zed's command palette. If you type a known vim command it
will run it, otherwise you get zed's normal fuzzy search. For this
release supported commands are limited to:
- - `:w[rite][!]`, `:wq[!]`, `:q[uit][!]`, `:wa[ll][!]`, `:wqa[ll][!]`,
`:qa[ll][!]`, `:[e]x[it][!]`, `:up[date]` to save/close tab(s) and
pane(s).
- - `:cq` to quit completely.
- - `:vs[plit]`, `:sp[lit]` to split vertically/horizontally
- - `:new`, `:vne[w]` to create a new file in a new pane above or to the
left
- - `:tabedit`, `:tabnew` to create a new file in a new tab.
- - `:tabn[ext]`, `:tabp[rev]` to go to previous/next tabs
- - `:tabc[lose]` to close tabs
- - `:cn[ext]`, `:cp[rev]`, `:ln[ext]`, `:lp[rev]` to go to the
next/prev diagnostics.
- - `:cc`, `:ll` to open the errors page
- - `:<number>` to jump to a line number.
- - `:$` to jump to end of file
- - `:%s/foo/bar/` (note that /g is always implied, the range must
always be %, and zed uses different regex syntax to vim)
- - `:/foo` and `:?foo` to jump to next/prev line matching foo
- - `:j[oin]`, to join the current line (no range is yet supported)
- - `:d[elete][l][p]`, to delete the current line (no range is yet
supported)
- - `:s[ort] [i]` to sort the current selection (case-insensitively)
- vim: Add `ctrl-w o` (closes everything except the current item) and
`ctrl-w n` (creates a new file in the pane above).
([#1884 ](https://github.com/zed-industries/community/issues/1884 ))
- all: Add a "Discard" option to prompt when saving a file with
conflicts (previously this only appeared on close, not on save).
Internal changes:
- The Picker will now wait for pending queries before confirming (to
handle people typing `: w enter` rapidly.
- workspace::save_item and Pane::save_item are now merged together, and
the behavior controlled by `workspace::SaveIntent`.
- Many actions related to closing/saving items now take an optional
`SaveIntent`.
-
2023-09-25 14:07:22 -05:00
Mikayla
667fc25766
Fix space and copy/paste when editing a channel
2023-09-25 11:31:02 -07:00
Conrad Irwin
359847d047
Revert "Revert "workspace: Improve save prompt. ( #3025 )""
...
This reverts commit 5c75450a77 .
2023-09-25 12:18:03 -06:00
Antonio Scandurra
15567493ba
WIP
2023-09-25 11:55:05 -06:00
Mikayla Maki
591ec02cea
Add support for the experimental Next LS for Elixir ( #3024 )
...
This is a PR I built for a friend of a friend at StrangeLoop, who is
making a much better LSP for elixir that elixir folks want to experiment
with. This PR also improves the our debug log viewer to handle LSP
restarts.
TODO:
- [ ] Make sure NextLS binary loading works.
Release Notes:
- Added support for the experimental Next LS for Elxir, to enable it add
the following field to your settings to enable:
```json
"elixir": {
"next": "on"
}
```
2023-09-25 12:52:56 -05:00
Antonio Scandurra
a1e080d495
Checkpoint
2023-09-25 11:48:51 -06:00
Mikayla
c2fca054ae
Fix compile and test errors
2023-09-25 10:46:09 -07:00
Julia
bf6c2f0dfd
Activate correct item when clicking on a code action with the mouse ( #3027 )
...
Release Notes:
- Fixed clicking a code action only ever performing the first action in
the list rather than the one clicked on.
2023-09-25 13:45:20 -04:00
KCaverly
86ec0b1d9f
implement new search strategy
2023-09-25 13:44:19 -04:00
Conrad Irwin
769c330b3d
Merge branch 'vim-command'
2023-09-25 11:41:13 -06:00
Conrad Irwin
5c75450a77
Revert "workspace: Improve save prompt. ( #3025 )"
...
This reverts commit 0a491e773b .
2023-09-25 11:41:09 -06:00
Mikayla
ad7c1f3c81
Download next-ls automatically from github
2023-09-25 10:40:20 -07:00
Conrad Irwin
23767f734f
Add cmd-+ as an alias for cmd-=
...
For github.com/zed-industries/community#1021
2023-09-25 11:31:34 -06:00
Julia
80eaabd360
Activate correct item when clicking on a code action with the mouse
2023-09-25 13:31:00 -04:00
Julia
ff5d0f2aeb
Trigger scroll_to on code action list when moving selection ( #3026 )
...
Release Notes:
- Fixed the code action popup menu not scrolling as selection moves.
2023-09-25 11:21:24 -04:00
Julia
a278428bd5
Trigger scroll_to on code action list when moving selection
2023-09-25 11:13:50 -04:00
Piotr Osiewicz
0a491e773b
workspace: Improve save prompt. ( #3025 )
...
Add buffer path to the prompt.
Z-2903
Release Notes:
- Added a "Save all/Discard all" prompt when closing a pane with
multiple edited buffers.
2023-09-25 16:15:29 +02:00
Antonio Scandurra
45540a00ee
Checkpoint
2023-09-24 17:12:59 -06:00
Antonio Scandurra
55f4aa3b34
Checkpoint
2023-09-24 16:52:33 -06:00
Mikayla
8b63e45f0b
Implement LSP adapter methods for syntax highlighting
2023-09-24 05:08:05 -07:00
Mikayla
052cb459a6
Improve lsp log viewer's behavior in the presence of LSP restarts
...
Improve settings interface to local LSP
2023-09-24 04:59:55 -07:00
Antonio Scandurra
a7803570dc
Checkpoint
2023-09-23 17:26:22 -06:00
Antonio Scandurra
b516ea2fe2
Checkpoint
2023-09-23 15:56:40 -06:00
Antonio Scandurra
1fa45c69d6
Checkpoint
2023-09-23 15:52:16 -06:00
Antonio Scandurra
c4abd93b9b
WIP
2023-09-23 15:24:01 -06:00
Antonio Scandurra
91c1768939
Checkpoint
2023-09-23 15:03:05 -06:00
Antonio Scandurra
1a5d6aa498
Checkpoint
2023-09-23 14:20:07 -06:00
Antonio Scandurra
fb69f3d45f
Checkpoint
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-09-23 12:21:52 -06:00
Antonio Scandurra
3fbe93f029
Checkpoint
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-09-23 11:06:10 -06:00
Antonio Scandurra
df388d9f33
Checkpoint
2023-09-23 09:10:33 -06:00
Marshall Bowers
0697d08e54
Restructure ui into just elements and components ( #3023 )
...
This PR restructures the `ui` crate into just `elements` and
`components`.
This was already done on the `gpui2-ui` branch, just getting it onto
`main`.
Release Notes:
- N/A
---------
Co-authored-by: Nate Butler <nate@zed.dev >
2023-09-22 21:27:47 -04:00
Marshall Bowers
895386cfaf
Mainline Icon and IconButton changes ( #3022 )
...
This PR mainlines the `Icon` and `IconButton` changes from the
`gpui2-ui` branch.
Release Notes:
- N/A
Co-authored-by: Nate Butler <nate@zed.dev >
2023-09-22 19:14:12 -04:00
Antonio Scandurra
6a95f9e349
WIP
2023-09-22 16:31:26 -06:00
Marshall Bowers
ad62a966a6
Display available stories in storybook CLI ( #3021 )
...
This PR updates the storybook CLI to support displaying all of the
available stories.
The `--help` flag will now show a list of all the available stories:
<img width="1435" alt="Screenshot 2023-09-22 at 6 11 00 PM"
src="https://github.com/zed-industries/zed/assets/1486634/284e1a24-46ec-462e-9709-0f9b6e94931f ">
Inputting an invalid story name will also show the list of available
stories:
<img width="1435" alt="Screenshot 2023-09-22 at 6 10 43 PM"
src="https://github.com/zed-industries/zed/assets/1486634/1ce3ae3f-ab03-4976-a06a-5a2b5f61eae3 ">
Release Notes:
- N/A
2023-09-22 18:16:16 -04:00
Marshall Bowers
fe4248cf34
Scaffold Toolbar and Breadcrumb components ( #3020 )
...
This PR scaffolds the `Toolbar` and `Breadcrumb` components.
Right now they both just consist of hardcoded data.
<img width="846" alt="Screenshot 2023-09-22 at 4 54 00 PM"
src="https://github.com/zed-industries/zed/assets/1486634/70578df2-7216-42d2-97ef-d38b83fb4a25 ">
<img width="799" alt="Screenshot 2023-09-22 at 4 46 04 PM"
src="https://github.com/zed-industries/zed/assets/1486634/73ca3d8a-baf9-4ed4-b4c4-279c674672a3 ">
Release Notes:
- N/A
2023-09-22 16:57:33 -04:00
Antonio Scandurra
a237aa8164
Checkpoint
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-09-22 14:53:25 -06:00
Antonio Scandurra
3dc1e917bf
Checkpoint
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-09-22 14:40:39 -06:00
Marshall Bowers
27e3e09bb9
Label component states in stories ( #3019 )
...
This PR updates the UI component stories to label the various states
that they are in.
Release Notes:
- N/A
2023-09-22 15:48:32 -04:00
Antonio Scandurra
d1791a999d
Checkpoint
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-09-22 13:30:51 -06:00
Marshall Bowers
d0b15ed940
Report which requested font families are not present on the system ( #3006 )
...
This PR improves the error message when `FontCache.load_family` attempts
to load a font that is not present on the system.
I ran into this while trying to run the `storybook` for the first time.
The error message indicated that a font family was not found, but did
not provide any information as to which font family was being loaded.
### Before
```
Compiling storybook v0.1.0 (/Users/maxdeviant/projects/zed/crates/storybook)
Finished dev [unoptimized + debuginfo] target(s) in 8.52s
Running `/Users/maxdeviant/projects/zed/target/debug/storybook`
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: could not find a non-empty font family matching one of the given names', crates/theme/src/theme_settings.rs:132:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
libc++abi: terminating due to uncaught foreign exception
fish: Job 1, 'cargo run' terminated by signal SIGABRT (Abort)
```
### After
```
Compiling storybook v0.1.0 (/Users/maxdeviant/projects/zed/crates/storybook)
Finished dev [unoptimized + debuginfo] target(s) in 7.90s
Running `/Users/maxdeviant/projects/zed/target/debug/storybook`
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: could not find a non-empty font family matching one of the given names: `Zed Mono`', crates/theme/src/theme_settings.rs:132:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
libc++abi: terminating due to uncaught foreign exception
fish: Job 1, 'cargo run' terminated by signal SIGABRT (Abort)
```
Release Notes:
- N/A
2023-09-22 15:27:42 -04:00
Antonio Scandurra
e4e9da7673
Checkpoint
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-09-22 12:44:37 -06:00
Marshall Bowers
8b6e982495
Remove manual mapping in FromStr implementation for StorySelector ( #3018 )
...
This PR removes the need for writing manual mappings in the `FromStr`
implementation for the `StorySelector` enum used in the storybook CLI.
We are now using the
[`EnumString`](https://docs.rs/strum/0.25.0/strum/derive.EnumString.html )
trait from `strum` to automatically derive snake_cased names for the
enums.
This will cut down on some of the manual work needed to wire up more
stories to the storybook.
Release Notes:
- N/A
2023-09-22 14:06:09 -04:00
Marshall Bowers
71c1e36d1e
Put Theme behind an Arc ( #3017 )
...
This PR puts the `Theme` returned from the `theme` function behind an
`Arc`.
### Motivation
While working on wiring up window focus events for the `TitleBar`
component we ran into issues where `theme` was holding an immutable
borrow to the `ViewContext` for the entirety of the `render` scope,
which prevented having mutable borrows in the same scope.
### Explanation
To avoid this, we can make `theme` return an `Arc<Theme>` to allow for
cheap clones and avoiding the issues with the borrow checker.
Release Notes:
- N/A
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com >
2023-09-22 13:35:30 -04:00
Antonio Scandurra
343c426307
Checkpoint
2023-09-22 10:02:11 -06:00
Marshall Bowers
d8c6adf338
Factor story boilerplate out into separate components ( #3016 )
...
This PR factors out the bulk of the boilerplate required to setup a
story in the storybook out into separate components.
The pattern we're using here is adapted from the "[associated
component](https://maxdeviant.com/posts/2021/react-associated-components/ )"
pattern in React.
Release Notes:
- N/A
2023-09-22 11:38:01 -04:00
Nathan Sobo
e979d75cb8
WIP
2023-09-22 08:34:43 -06:00
Kirill Bulatov
afa7045847
Tone down inlay hint update logs
2023-09-22 17:04:11 +03:00
Kyle Caverly
e84339ef4a
reorganize AI crates to structure future development ( #3015 )
...
Reorganized assistant/semantic_index crates and introduced AI crate to
include shared functionality.
Release Notes:
- Moved most of the Assistant functionality from ai crate to assistant
crate
- Moved interaction with embedding providers from semantic_index to ai
crate
2023-09-22 09:54:46 -04:00
KCaverly
fbd6b5b434
cargo fmt
2023-09-22 09:46:06 -04:00
KCaverly
dc49dec4f0
catchup with main
2023-09-22 09:43:39 -04:00
KCaverly
68c37ca2a4
move embedding provider to ai crate
2023-09-22 09:33:59 -04:00
Kirill Bulatov
1f1c669673
Do not resubscribe for Copilot logs events ( #3014 )
...
Last follow-up of https://github.com/zed-industries/zed/pull/3002
Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1695281196667609
Copilot sends multiple events about its LSP server readiness, not
necessarily recreating the server from scratch (e.g. due to re-sign in
action). Avoid re-adding same log subscriptions on the same LSP server,
which causes panics.
Release Notes:
- N/A
2023-09-22 13:48:13 +03:00
Kirill Bulatov
d61565d227
Do not resubscribe for Copilot logs events
...
Copilot sends multiple events about its LSP server readiness, not necessarily recreating the server from scratch (e.g. due to re-sign in action).
Avoid re-adding same log subscriptions on the same LSP server, which
causes panics.
2023-09-22 13:40:20 +03:00
Nate Butler
a5e055f8a5
Bring UI crate up to date ( #3013 )
...
Merges various in-progress gpui2 component branches with the new `ui`
crate.
2023-09-21 23:54:11 -04:00
Nate Butler
30b105afd5
Remove leftover state doc
2023-09-21 23:51:03 -04:00
Nate Butler
d14e4d41ea
Merge branch 'main' into nate/bring-ui-crate-up-to-date
2023-09-21 23:47:17 -04:00
Nate Butler
f54634aeb2
Bring UI crate up to date
2023-09-21 23:46:06 -04:00
Marshall Bowers
5083ab7694
Add TrafficLights component ( #3011 )
...
This PR adds a `TrafficLights` component for GPUI2.
<img width="861" alt="Screenshot 2023-09-21 at 11 32 10 PM"
src="https://github.com/zed-industries/zed/assets/1486634/0fe0e847-49b3-44dc-bd4c-64f12f0051c1 ">
Release Notes:
- N/A
2023-09-21 23:42:18 -04:00
KCaverly
48e151495f
introduce ai crate with completion providers
2023-09-21 22:44:56 -04:00
Marshall Bowers
66358f2900
Update storybook to support stories for individual components ( #3010 )
...
This PR updates the `storybook` with support for adding stories for
individual components.
### Motivation
Right now we just have one story in the storybook that renders an entire
`WorkspaceElement`.
While iterating on the various UI components, it will be helpful to be
able to create stories of those components just by themselves.
This is especially true for components that have a number of different
states, as we can render the components in all of the various states in
a single layout.
### Explanation
We achieve this by adding a simple CLI to the storybook.
The `storybook` binary now accepts an optional `[STORY]` parameter that
can be used to indicate which story should be loaded. If this parameter
is not provided, it will load the workspace story as it currently does.
Passing a story name will load the corresponding story, if it exists.
For example:
```
cargo run -- elements/avatar
```
<img width="723" alt="Screenshot 2023-09-21 at 10 29 52 PM"
src="https://github.com/zed-industries/zed/assets/1486634/5df489ed-8607-4024-9c19-c5f4541f97c9 ">
```
cargo run -- components/facepile
```
<img width="785" alt="Screenshot 2023-09-21 at 10 30 07 PM"
src="https://github.com/zed-industries/zed/assets/1486634/e04a4577-7403-405d-b23c-e765b7a06229 ">
Release Notes:
- N/A
2023-09-21 22:41:53 -04:00
KCaverly
5f6334696a
rename ai crate to assistant crate
2023-09-21 21:54:59 -04:00
Mikayla
02a85b1252
Add local next LSP adapter
2023-09-21 18:09:02 -07:00
Nate Butler
4628639ac6
Update ambiguous theme import ( #3009 )
...
Fixes an ambiguous reference to `theme` causing storybook not to build.
2023-09-21 20:32:41 -04:00
Nate Butler
8440ac3a54
Fix fmt complaining about order
2023-09-21 20:25:25 -04:00
Nate Butler
1e6ac8caf2
theme::* -> crate::theme::*;
2023-09-21 20:21:56 -04:00
Max Brunsfeld
7711530704
Simplify titlebar facepile click rendering / mouse handling
2023-09-21 17:12:59 -07:00
Max Brunsfeld
4ffa167256
Allow following into channel notes regardless of project
2023-09-21 17:12:59 -07:00
Marshall Bowers
baa07e935e
Extract UI elements from storybook into new ui crate ( #3008 )
...
This PR extracts the various UI elements from the `storybook` crate into
a new `ui` library crate.
Release Notes:
- N/A
2023-09-21 19:25:35 -04:00
Marshall Bowers
c252eae32e
Reorganize ui module exports ( #3007 )
...
This PR reorganizes the exports for the `ui` module in the `storybook`
crate.
### Motivation
Currently we expose each of the various elements/components/modules in
two places:
- Through the module itself (e.g., `ui::element::Avatar`)
- Through the `ui` module's re-exports (e.g., `ui::Avatar`)
This means it's possible to import any given item from two spots, which
can lead to inconsistencies in the consumers. Additionally, it also
means we're shipping the exact module structure underneath `ui` as part
of the public API.
### Explanation
To avoid this, we can avoid exposing each of the individual modules
underneath `ui::{element, component, module}` and instead export just
the module contents themselves.
This makes the `ui` module namespace flat.
Release Notes:
- N/A
2023-09-21 17:46:37 -04:00
Marshall Bowers
92d3115f3d
Fix some typos in tools.md
2023-09-21 17:21:40 -04:00
Marshall Bowers
6bbf614a37
Fix some typos in README.md
2023-09-21 16:56:04 -04:00
Max Brunsfeld
ed8b022b51
Add initial failing test for following to channel notes in an unshared project
2023-09-21 13:14:15 -07:00
Max Brunsfeld
f34c6bd1ce
Start work on allowing following without a shared project
2023-09-21 13:14:15 -07:00
Max Brunsfeld
c71566e7f5
Make project id optional when following - server only
2023-09-21 13:14:15 -07:00
Max Brunsfeld
83455028b0
Procfile: run zed.dev via 'next dev', not 'vercel dev'
2023-09-21 13:14:15 -07:00
Nathan Sobo
d120d0cf2e
Checkpoint
2023-09-21 14:10:53 -06:00
Nathan Sobo
a0416e9c6d
WIP
2023-09-21 13:46:31 -06:00
Nathan Sobo
a53c0b9472
WIP
2023-09-21 13:39:54 -06:00
Kyle Caverly
3c2b05be90
add semantic index status, for non authenticated users ( #3005 )
...
Update project search semantic ui to accommodate for users who have not
set the OPENAI_API_KEY in their environment variables.
Release Notes:
- Expand Semantic Index status to include status for non authenticated
users
- Update Search UI to illustrate this status.
2023-09-21 14:18:58 -04:00
Nathan Sobo
8573c6e8c6
WIP
2023-09-21 12:18:09 -06:00
KCaverly
7b63369df2
move api authentication to embedding provider
2023-09-21 14:00:00 -04:00
KCaverly
997f362cc2
add semantic index status, for non authenticated users
2023-09-21 13:40:01 -04:00
Max Brunsfeld
59e561dcf9
Bump rust from 1.72.0 to 1.72.1
2023-09-21 10:17:55 -07:00
Nate Butler
056353f8a8
Correct icon_margin_scale for fold indicator ( #3003 )
...
Fixes a design regression on Preview where the fold icon became small
due to the icon standardization PR.
Release Notes:
- [Preview] Fixed an issue with the size of the fold line icon.
2023-09-21 12:52:54 -04:00
Max Brunsfeld
19a9753663
Fix channel move cancel ( #3004 )
...
Release Notes:
- Fixes a bug where channels could no longer be rearranged with drag and
drop.
2023-09-21 09:11:09 -07:00
Mikayla
66dd0e9ec0
Switch drag end event to be fired after mouse up
2023-09-21 08:58:36 -07:00
Nate Butler
d74b8ec4e3
Correct icon_margin_scale
2023-09-21 11:57:35 -04:00
Piotr Osiewicz
dbfa1d7263
[WIP] Replace in project ( #2984 )
...
Targeting Preview of 09.27.
This is still pending several touchups/clearups:
- We should watch multibuffer for changes and rescan the excerpts. This
should also update match count.
- Closing editor while multibuffer with 100's of changed files is open
leads to us prompting for save once per each file in the multibuffer.
One could in theory save in multibuffer before closing it (thus avoiding
unnecessary prompts), but it'd be cool to be able to "Save all"/"Discard
All".
Release Notes:
- Added "Replace in project" functionality
2023-09-21 16:27:58 +02:00
Kirill Bulatov
d090fd25e4
Supplementary LSP server log improvements ( #3002 )
...
Follow-up of https://github.com/zed-industries/zed/pull/2991 improving
rough edges around supplementary LSP servers:
* Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1695281196667609
Copilot init panic
* Makes LSP server list scrollable in the panel
* Shows supplementary servers' RPC logs in the panel
Release Notes:
- N/A
2023-09-21 11:22:56 +03:00
Kirill Bulatov
1c53b0a1c0
Properly re-add Copilot LSP server
2023-09-21 11:02:03 +03:00
Kirill Bulatov
a2ac5ae478
Fix RPC logs not being displayed for supplementary servers
2023-09-21 11:00:05 +03:00
Kirill Bulatov
ead7155b0f
Make LSP panel scrollable
...
co-authored-by: Max <max@zed.dev >
2023-09-21 10:59:19 +03:00
Nathan Sobo
dfeb702544
WIP - Next: implement Element derive macro
2023-09-20 22:26:46 -06:00
Conrad Irwin
32f8733313
Code review changes
2023-09-20 21:29:45 -06:00
Conrad Irwin
4bf4c780be
Revert accidental Cargo change
2023-09-20 20:50:22 -06:00
Conrad Irwin
7a7ff4bb96
Fix save related tests, and refactor saves again
2023-09-20 20:44:42 -06:00
Conrad Irwin
a59da3634b
Fix backward search from command
2023-09-20 20:44:42 -06:00
Conrad Irwin
a25fcfdfa7
Iron out some edge-cases
2023-09-20 20:44:42 -06:00
Conrad Irwin
2d9db0fed1
Flesh out v1.0 of vim :
2023-09-20 20:44:41 -06:00
Conrad Irwin
6ad1f19a21
Add NewFileInDirection
2023-09-20 20:44:26 -06:00
Conrad Irwin
88a32ae48d
Merge Workspace::save_item into Pane::save_item
...
These methods were slightly different which caused (for example) there
to be no "Discard" option in the conflict case at the workspace level.
To make this work, a new SaveBehavior (::PromptForNewPath) was added to
support SaveAs.
2023-09-20 20:44:26 -06:00
Conrad Irwin
a4f96e6452
tests: wait deterministically after simulating_keystrokes
2023-09-20 20:44:26 -06:00
Conrad Irwin
e27b7d7812
Ensure the picker waits for pending updates
...
Particularly in development builds (and in tests), when typing in the
command palette, I tend to hit enter before the suggestions have
settled.
2023-09-20 20:44:26 -06:00
Conrad Irwin
ba5d84f7e8
Fix vim tests on my machine
...
In a rare case of "it broke on my machine" I haven't been able to run
the vim tests locally for a few days; turns out I ran out of swap file
names...
2023-09-20 20:44:26 -06:00
Conrad Irwin
ea3a1745f5
Add vim-specific interactions to command
...
This mostly adds the commonly requested set (:wq and friends) and
a few that I use frequently
:<line> to go to a line number
:vsp / :sp to create a split
:cn / :cp to go to diagnostics
2023-09-20 20:44:26 -06:00
Nathan Sobo
6d2b27689d
WIP
2023-09-20 20:40:30 -06:00
Nathan Sobo
a8bb3dd9a3
WIP
2023-09-20 20:28:32 -06:00
Max Brunsfeld
d42093e069
collab 0.22.1
2023-09-20 17:39:21 -07:00
Max Brunsfeld
98482f0150
Fix select all bugs ( #3001 )
...
Release Notes:
- Restore `cmd-shift-d` as 'editor::DuplicateLine' and move
`editor::SelectAllMatches` to `cmd-shift-L`, like in VS Code. The
previous action for `cmd-shift-l`, `editor::SplitSelectionIntoLines`,
has been moved to the sublime base keymap.
- Fixes a panic when using 'editor::SelectAllMatches' on an empty line.
2023-09-20 17:21:10 -07:00
Mikayla
58f4efb579
fix default keybindings for select all matches
2023-09-20 17:14:19 -07:00
Mikayla
fe10875285
Fix panic on select all when query is empty
2023-09-20 17:10:23 -07:00
Mikayla Maki
e0fe97401d
Fix bugs from channel moving ( #3000 )
...
This PR fixes several bugs related to channel moving and it's
unintuitive behavior when attempting to re-order channels
Release Notes:
- N/A
2023-09-20 17:01:14 -07:00
Mikayla
f2f507e619
Fix bug in channel rendering
...
Fix drag and drop stale state bug revealed by the channel panel
co-authored-by: Max <max@zed.dev >
2023-09-20 16:40:29 -07:00
Conrad Irwin
f4d4a2f41b
vim fixes for find&replace ( #2995 )
...
* allow replacing with the empty string to delete
* fix <enter> for ReplaceNext (in vim mode)
Release Notes:
- allow replacement to be empty
2023-09-20 16:42:39 -06:00
Mikayla
4ff44dfa3b
Fix bugs in moving channels that could cause channels to be stranded or moved unexpectedly
...
Made channel linking not query in a loop
co-authored-by: Max <max@zed.dev >
2023-09-20 15:32:06 -07:00
Max Brunsfeld
ee16b2051e
Fix opening channel notes from collab panel context menu ( #2998 )
...
Release Notes:
- Fixed a bug where the 'Open Notes' action in the collaboration panel
context menu didn't work (preview only).
2023-09-20 13:55:23 -07:00
Max Brunsfeld
3633f091c5
Fix opening channel notes from context menu
2023-09-20 13:45:35 -07:00
Nathan Sobo
44608517c1
WIP
2023-09-20 14:32:55 -06:00
Conrad Irwin
841b4d648c
Fix vim panic when over-shooting with j ( #2997 )
...
Release Notes:
- vim: fix a panic when using `j` to go beyond end of file
2023-09-20 12:17:07 -06:00
Nathan Sobo
5b0e333967
Checkpoint
2023-09-20 12:16:26 -06:00
Conrad Irwin
01b2db4845
Fix vim test recording
2023-09-20 12:01:04 -06:00
Joseph T. Lyons
e7d73b833b
collab 0.22.0
2023-09-20 13:59:36 -04:00
Nate Butler
f7696114bb
Add an initial set of GPUI2 components to the storybook ( #2990 )
...
This PR adds an initial set of components to `crates/storybook/src/ui`.
All changes still are contained to inside storybook. Merging to keep up
to date with main.
2023-09-20 13:52:47 -04:00
Conrad Irwin
8de67fd9d9
Fix vim panic when over-shooting with j
2023-09-20 11:20:35 -06:00
Nate Butler
be6690bf0b
Update tracker.md
2023-09-20 13:08:20 -04:00
Joseph T. Lyons
a86dc942d6
v0.106.x dev
2023-09-20 13:02:13 -04:00
Nate Butler
6dcb0bafb0
WIP Project Tracker
2023-09-20 12:53:08 -04:00
Kyle Caverly
5fe8aa064f
Keyboard navigation and setting persistence for project search ( #2996 )
...
Enable keyboard shortcuts for Project Search modes, and ensure project
search settings are persisted search to search.
Release Notes:
- Added alt-cmd-s to Toggle Semantic Search Mode
- Added alt-cmd-g to Toggle Regex Search Mode
- Added alt-cmd-x to Toggle Text Search Mode
- Defaulted new project searches to using last used search mode and
settings.
2023-09-20 12:44:30 -04:00
Joseph T. Lyons
7f4d285205
Add select all command to the editor ( #2963 )
...
Equivalent to hitting cmd-d as many times as possible
cc: @JosephTLyons this PR needs a bit of work on user-facing naming and
interactions:
- [x] ~~I thought cmd-shift-d would be nice for this action, but that is
already taken by a sublime key binding. Could we use the VSCode binding?
I left the sublime text binding in but commented out.~~ Gonna just leave
it as is
- [x] ~~I went through 'SelectAllMatches' and 'SelectAll' as names for
this action, but ran into conflicts with the buffer search action and
the existing SelectAll (`cmd-a`) action. I decided to go with
`SelectNextAll`, but could use your help here.~~ Decided to go with
'SelectAllMatches'
Release Notes:
- Added a `editor::SelectAllMatches` command, bound to `cmd-shift-d`,
for selecting all matching occurrences under your selection. Note that
this has replaced the previous binding for `editor::DuplicateLine`.
2023-09-20 12:42:23 -04:00
KCaverly
37a0c6615f
remove conditional action registration for activate semantic search mode
2023-09-20 12:38:29 -04:00
Mikayla
fdf5278bbf
Only autoscroll on select_next operations
2023-09-20 09:31:12 -07:00
Nathan Sobo
83dae46ec6
Checkpoint
2023-09-20 10:17:29 -06:00
KCaverly
22d095bd35
enable project search states to persist between workspace project searches
2023-09-20 12:12:01 -04:00
Mikayla
8cc7a02390
Fix rebase
2023-09-20 08:34:18 -07:00
Mikayla
03d4191685
Fix infinite loop in select all matches
2023-09-20 08:25:21 -07:00
Mikayla
c074bfd441
Add select all command to the editor, equivalent to hitting cmd-d as many times as possible
2023-09-20 08:25:20 -07:00
KCaverly
28ed406d54
add keymaps for activating text, regex and semantic modes
2023-09-20 10:04:43 -04:00
Mikayla
0cceb3fdf1
Get nextLS running
2023-09-20 06:55:24 -07:00
KCaverly
912e6e8091
create initial action for Semantic search mode
2023-09-20 09:48:27 -04:00
Kirill Bulatov
a366ad02ce
Add a way to display unrelated to language support language servers' logs ( #2991 )
...
Copilot is being used in every buffer, but we do not see its logs that
easily.
In the future, prettier wrapper will pretend to be an LSP server, it is
better to log its messages somewhere, so prepare an infrastructure for
that.
<img width="1727" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/d31a257c-9608-46fa-8be1-f0a2a2bdbdb7 ">
Copilot seem to have no rpc messages logged for some reason now,
prettier wrapper might be a better case to investigate this, so leaving
as is.
Release Notes:
- N/A
2023-09-20 12:14:31 +03:00
Kirill Bulatov
6ebe49ec59
Show Copilot logs right after its LSP server start
2023-09-20 12:08:32 +03:00
Kirill Bulatov
82010b68c1
Avoid extra LSP log events
2023-09-20 11:27:52 +03:00
Nathan Sobo
7885eaf974
Checkpoint
2023-09-19 21:55:49 -06:00
Conrad Irwin
4331cb8058
Initialize workspace properly in tests ( #2994 )
...
For vim command I'd like to be able to test that e.g. workspace::Save
works.
2023-09-19 21:02:38 -06:00
Nathan Sobo
37d0f06e07
Checkpoint
2023-09-19 20:55:13 -06:00
Conrad Irwin
1295e5b41f
vim: Use explicit global, not default ( #2987 )
...
This should have no user-visible impact, but tidies up one of the
awkwardnesses
of how vim uses global state at the moment.
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-09-19 20:52:25 -06:00
Conrad Irwin
5bb8ba5028
Initialize workspace properly in tests
...
For vim command I'd like to be able to test that e.g. workspace::Save
works.
2023-09-19 20:49:29 -06:00
Conrad Irwin
2da664ed17
vim fixes for find&replace
...
* allow replacing with the empty string to delete
* fix <enter> for ReplaceNext
2023-09-19 20:48:01 -06:00
Mikayla Maki
e37373a636
Add UI/UX for moving channels ( #2976 )
...
TODO:
- [x] Add drag and drop
- [x] Polish up in-flight decisions.
- [x] Fix chat panel panic
- [x] Add nice hover effect highlighting the matching ones
- [x] Fix and test keyboard
Release Notes:
- N/A
2023-09-19 17:56:22 -07:00
Mikayla
ac65e7590c
Add hover styles to channels matching the current selection
...
Fix chat desync from moving / linking channels
2023-09-19 17:50:02 -07:00
Nate Butler
2699f170ca
Checkpoint - Details
2023-09-19 19:18:23 -04:00
Kyle Caverly
2f44055079
Semantic index eval ( #2988 )
...
v0 of the Semantic Index evaluate test suite
Release Notes:
- Added eval.rs as an example to the semantic-index crates
- Generates test metrics for two small projects, as a starting point to
systematically evaluate retrieval quality
2023-09-19 19:17:06 -04:00
KCaverly
11b3bfdc99
fix warnings
2023-09-19 19:05:26 -04:00
KCaverly
25cb79e475
remove git2 dependency for repository cloning in semantic_index eval
2023-09-19 18:55:15 -04:00
Mikayla
d5f0ce0e20
Finish implementing drag and drop
2023-09-19 15:51:00 -07:00
Piotr Osiewicz
4525509804
buffer/replace: Advance match index on each replace. ( #2992 )
...
Release Notes:
- Fixed "Replace next" not advancing the match index.
2023-09-19 23:56:22 +02:00
Mikayla
f3b91082a6
Improve drag and drop to look and feel better
...
WIP: Change rendering of drag and drop based on alt-modifier
2023-09-19 14:48:34 -07:00
Kirill Bulatov
7bc4f0bc11
Send copilot log messages into the log panel
2023-09-19 23:41:55 +03:00
KCaverly
b57b5c0b33
updated git2 to use ssl
2023-09-19 16:36:51 -04:00
KCaverly
d85acceeec
move git2 to workspace dependency globally
2023-09-19 16:13:47 -04:00
Kirill Bulatov
5e1b284846
Show supplementary language servers in the logs panel
2023-09-19 22:29:27 +03:00
Nathan Sobo
8406c0d9a3
Checkpoint
2023-09-19 13:27:57 -06:00
Nathan Sobo
e762f7f3c0
Checkpoint
2023-09-19 13:09:00 -06:00
Kirill Bulatov
556f398780
Send and receive Copilot events
2023-09-19 21:53:31 +03:00
Mikayla
9bff3b6916
Add basic drag and drop support
2023-09-19 11:20:01 -07:00
Kyle Caverly
ae019fb7d3
remove release channel flags in semantic_index ( #2989 )
...
Remove Release channel filters from semantic_index allowing the index to
be released to stable.
Release Notes:
- Remove Release channel filters in enabled and semantic_index
initialization
2023-09-19 12:39:26 -04:00
Nate Butler
65aa4d5642
Draw indent guides using indent_level
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-09-19 12:38:46 -04:00
KCaverly
4f1a59ebf5
formatting
2023-09-19 12:27:33 -04:00
KCaverly
fc8dd8433c
remove release channel flags in semantic_index
2023-09-19 12:20:59 -04:00
Nate Butler
3a9f5d6ddc
use u32 as indent_level
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-09-19 11:59:55 -04:00
Nate Butler
748ad5f05a
Make list_item toggleable, improve optional left_icon on list item
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-09-19 11:52:35 -04:00
KCaverly
183758a7c5
fix Cargo.lock for merge
2023-09-19 11:44:51 -04:00
Nathan Sobo
89519b1521
WIP
2023-09-19 08:46:02 -06:00
Kirill Bulatov
9eadfc80ba
Add Copilot server to LSP logs panel
2023-09-19 16:25:09 +03:00
Nate Butler
7e300079ce
WIP
2023-09-19 08:31:22 -04:00
Kirill Bulatov
5b0b2fe50b
Add a specific server id to a Copilot LSP
2023-09-19 12:32:05 +03:00
Kirill Bulatov
91fac2aa76
Automatically subscribe for lsp logs of every server added
...
Avoid re-adding the server on new logs events.
2023-09-19 11:52:21 +03:00
Nate Butler
26f442a675
Merge branch 'main' into nate/gpui2-ui-components
2023-09-19 00:26:41 -04:00
Nate Butler
8aa4fbea83
Add icon, list_item, work on project panel
2023-09-19 00:25:46 -04:00
Mikayla
dadad397ef
Finish optimizing channel representations and operations
2023-09-18 20:24:37 -07:00
Nathan Sobo
2701be91e3
Add negative style helpers
2023-09-18 20:47:40 -06:00
Nathan Sobo
f2e87a3429
Add Element::when method
2023-09-18 20:25:12 -06:00
Nathan Sobo
c7a3186d08
Checkpoint
2023-09-18 20:17:27 -06:00
Nathan Sobo
a5e4ceb735
Checkpoint: Add methods for setting arbitrary lengths
2023-09-18 19:48:22 -06:00
Nate Butler
b725cadf48
Checkpoint
2023-09-18 19:59:01 -04:00
Nathan Sobo
df9a05ba92
Checkpoint
2023-09-18 17:40:47 -06:00
KCaverly
25bd357426
add recall and precision to semantic index
2023-09-18 18:25:02 -04:00
Conrad Irwin
71e519aa3b
vim: Use explicit global, not default
2023-09-18 14:22:41 -06:00
Conrad Irwin
adf313bd33
Fix vim-related panic ( #2986 )
...
Release Notes:
- fix panic that happens during collaboration (preview-only)
2023-09-18 12:21:38 -06:00
Conrad Irwin
417f28effe
Fix vim-related panic
2023-09-18 12:13:50 -06:00
Piotr Osiewicz
230061d838
chore: Enable v0 symbol mangling ( #2985 )
...
https://github.com/rust-lang/rust/issues/60705
Due to modification of .cargo/config.toml your `cargo build` should pick
this change up automatically. Use `legacy` instead of `v0` if you find
yourself in need of old mangling scheme for whatever reason
Release Notes:
- Improved precision of backtraces in application crashes
2023-09-18 18:58:59 +02:00
Piotr Osiewicz
616d328f3c
chore: Use aho-corasick 1.1 in direct dependencies ( #2983 )
...
Nothing too fancy, we've depended indirectly on 1.0/1.1 already, so this
is essentially bookkeeping.
Release Notes:
- N/A
2023-09-18 17:01:08 +02:00
Conrad Irwin
5c22e40e99
vim: Fix Y on last line ( #2975 )
...
For zed-industries/community#2044
Release Notes:
- vim: Fix y in VISUAL LINE mode when last line has no trailing newline
([#2044 ](https://github.com/zed-industries/community/issues/2044 )).
2023-09-18 08:54:48 -06:00
Conrad Irwin
5c8ff05577
clip FoldPoint earlier ( #2982 )
...
fold_point_to_display_point calls to_offset on the fold point, which
panics if it hasn't been clipped.
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1694850156370919
Release Notes:
- vim: Fix a crash when moving up/down in some circumstances.
2023-09-18 08:53:38 -06:00
Conrad Irwin
4244e7893f
Clip twice
2023-09-18 08:28:21 -06:00
KCaverly
566bb9f71b
add map to evaluation suite for semantic_index
2023-09-18 09:57:52 -04:00
Piotr Osiewicz
0598a8243d
chore: Hoist non-generic part out of add_action_internal. ( #2981 )
...
add_action_internal shows up often in downstream crates (as it should
be, since it's a generic function it's codegened in each crate that uses
it); it adds non-trivial amounts of LLVM IR to the build as a whole
which we can cut down a bit by doing the inner fn trick.
Release Notes:
- N/A
2023-09-18 11:55:44 +02:00
Conrad Irwin
c4797f87b4
clip FoldPoint earlier
...
fold_point_to_display_point calls to_offset on the fold point, which
panics if it hasn't been clipped.
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1694850156370919
2023-09-16 12:58:39 -07:00
Mikayla Maki
c3f6fcc682
Added 'open in terminal' action to the project panel context menu ( #2980 )
...
Also slightly re-arranged the project panel context menu
Release Notes:
- Added an 'open in terminal' action to the context menu on folders in
the project panel
2023-09-15 21:49:04 -07:00
Mikayla
d46816589e
Added 'open in terminal' action to the project panel context menu
...
Also slightly re-arranged the project panel context menu
2023-09-15 21:33:22 -07:00
Nate Butler
db1dacde5d
Add facepile, indicator, follow_group
2023-09-15 22:10:51 -04:00
Mikayla
5f9c56c8b0
WIP: Send the channel name and the channel edges seperately, so we're not repeating them constantly
...
This commit is currently broken and includes debug data for a failed attempt at rewriting the insert_edge logic
2023-09-15 17:57:23 -07:00
Mikayla
363867c65b
Make DAG tests order independent
2023-09-15 13:44:01 -07:00
Mikayla
52057c5619
Simplify path representation in collab panel
...
Optimize set representation in collab
2023-09-15 13:35:46 -07:00
Nate Butler
9f2a9d43b1
Organize design system under ui
2023-09-15 16:34:56 -04:00
Mikayla
5400605483
Fix merge conflicts
2023-09-15 12:30:26 -07:00
Joseph T. Lyons
5df9a57a8b
Add assistant events ( #2978 )
...
Add assistant events
Release Notes:
- N/A
2023-09-15 15:25:35 -04:00
Kyle Caverly
b9c1f3d558
enable includes filtering for open and modified buffers ( #2979 )
...
enable include file filtering for semantic searching in open and
modified buffers
Release Notes:
- Added include based filtering for modified buffers
2023-09-15 15:23:24 -04:00
KCaverly
1433160a08
enable include based filtering for search inside open and modified buffers
2023-09-15 15:16:20 -04:00
Nate Butler
0aff0c105d
Add missing logo_96 icon, fix a few incorrect paths ( #2977 )
...
🙈 I missed a few
Thanks @maxbrunsfeld / @mikayla-maki
2023-09-15 14:57:40 -04:00
Mikayla
f9fff3a7b2
fmt
2023-09-15 11:39:56 -07:00
Mikayla
16707d16f6
Improve context-menu behavior
2023-09-15 11:39:56 -07:00
Mikayla
d424e27164
Finish testing new channel store client behavior
2023-09-15 11:39:56 -07:00
Mikayla
67ad75a376
Clean up implementation of channel index, get simple channel moving test cases working
2023-09-15 11:39:56 -07:00
Mikayla
9afb67f2cf
Implement final move, link, unlink db APIs
2023-09-15 11:39:56 -07:00
Mikayla
7fa68a9aa4
WIP: improve move and link handling around 'root paths', currently very incorrect and in need of a deeper rework
2023-09-15 11:39:56 -07:00
Mikayla
cda54b8b5f
Improve database and RPC API for moving and linking channels, improve test legibility
2023-09-15 11:39:55 -07:00
Mikayla
439f627d9a
Add move, link, and unlink operations
2023-09-15 11:36:58 -07:00
Mikayla
77cdbdb12a
remove extraneous depth field
2023-09-15 11:28:36 -07:00
Mikayla
8222102d01
Render the DAG
2023-09-15 11:28:34 -07:00
Mikayla
3a62d2988a
Finish integration tests for channel moving
...
Refactor channel store to combine the channels_by_id and channel_paths into a 'ChannelIndex'
2023-09-15 11:23:43 -07:00
Mikayla
9e68d4a8ea
WIP: Add channel DAG related RPC messages, change update message
2023-09-15 11:23:12 -07:00
Nate Butler
9a4ecf0f88
Add missing logo_96 icon, fix a few incorrect paths
2023-09-15 14:21:33 -04:00
Mikayla
49fbb27ce9
Improve channel deletion to be DAG aware
2023-09-15 11:20:04 -07:00
Mikayla
bd9e964a69
Add removing of previous channel channel, allowing for channel moving operations
2023-09-15 11:20:04 -07:00
Mikayla
fc78db39ef
Expand DAG tests to include more complex tree operations and removal behavior
2023-09-15 11:20:04 -07:00
Mikayla
d5512fad0d
Add channel linking operation
2023-09-15 11:20:04 -07:00
Mikayla
aa9a9be7e9
Add channel moving test
2023-09-15 11:20:04 -07:00
Max Brunsfeld
119d1c9746
Reintroduce channel chat ( #2945 )
...
### Todo
* [x] Add back chat functionality, connected to channels
* [x] Channels panel
* [x] channels with active calls take up two rows, facepile goes on the
second row
* [x] icons for note, phone, (maybe chat) appear on the right of channel
names
* [x] clicking a channel opens the chat
* [x] style
* [x] Chat panel
* [ ] Render markdown in chat messages
* [x] style
* [x] Hide unless user is staff or has `channels_alpha` feature flag.
2023-09-15 11:19:34 -07:00
Max Brunsfeld
b8fd4f5d40
Restore user_group_16 icon
2023-09-15 11:16:30 -07:00
Nate Butler
d6f24feb4a
WIP
2023-09-15 14:14:28 -04:00
Max Brunsfeld
3dba52340e
Update paths to moved icons
2023-09-15 11:14:04 -07:00
Max Brunsfeld
6c3fd2a687
Merge branch 'main' into chat-again
2023-09-15 11:06:39 -07:00
Nate Butler
40e785fdff
Merge branch 'main' into nate/gpui2-ui-components
2023-09-15 13:57:15 -04:00
Nate Butler
4c9100eae3
Unify icons using multiple variants, remove all unused icons ( #2974 )
...
There are around ~400 icons in the `assets/icons` folder, but in reality
including file icons we only use around 50. In a number of places we use
different variants of the same icon, even in different styles.
This PR unifies the icons we use, removes the duplicates, and cleans out
unused icons.
Release Notes:
- Made icons more consistent throughout the app.
2023-09-15 13:55:13 -04:00
Conrad Irwin
b02bd9bce1
Fix Y on last line with no trailing new line
...
For zed-industries/community#2044
2023-09-15 11:14:04 -06:00
Max Brunsfeld
099969ed79
Ensure the chat panel is fully feature flagged
2023-09-15 10:13:43 -07:00
Nate Butler
966da65293
Fix notification close icon size
2023-09-15 12:59:57 -04:00
Nate Butler
29cd00f78d
Fix close tab icon size
2023-09-15 12:56:49 -04:00
Nate Butler
24974ee2fa
Unify icons using multiple variants, remove all unused icons
2023-09-15 12:50:49 -04:00
Conrad Irwin
0617bab731
Make cargo test -p gpui work ( #2972 )
...
Fix from @maxbrunsfeld
https://zed-industries.slack.com/archives/C04S5TU0RSN/p1694722631644249
2023-09-15 10:38:48 -06:00
Conrad Irwin
3eb2b75e6f
vim: shift-d and shift-x in visual mode ( #2973 )
...
Release Notes:
- vim: Support `shift-d` and `shift-x` to delete in visual mode
2023-09-15 10:38:37 -06:00
Conrad Irwin
9ef7004383
Add shift-d and shift-x as aliases for d and x in visual mode
2023-09-15 10:26:43 -06:00
Conrad Irwin
3e01d78a80
Make cargo test -p gpui work
2023-09-15 10:24:12 -06:00
Conrad Irwin
7c77baa7c1
Fix multi-character shortcuts with modifiers ( #2968 )
...
This moves the IME shortcut handling over to the keystroke matcher so
that it
can not clear pending matches when trying out the IME equivalent.
Release Notes:
- vim: add `g s` / `g S` to show symbols in the current buffer /
workspace
- Fix multi-key shortcuts with modifiers (preview-only)
2023-09-15 10:15:01 -06:00
Nate Butler
70a91c5426
Checkpoint
2023-09-15 11:41:21 -04:00
Joseph T. Lyons
f4e40b3411
Ignore .idea directory
...
I'm testing RustRover
2023-09-15 11:17:02 -04:00
KCaverly
04bd107ada
add ndcg@k to evaluate metrics
2023-09-15 10:36:21 -04:00
KCaverly
3a661c5977
catchup with main
2023-09-15 09:31:33 -04:00
Antonio Scandurra
c9863d6475
Don't dismiss inline assistant when an error occurs ( #2971 )
...
Release Notes:
- Fixed a bug that was preventing errors from being shown in the inline
assistant when it was still deployed. (preview-only)
2023-09-15 12:36:50 +02:00
Antonio Scandurra
925da97599
Don't dismiss inline assistant when an error occurs
2023-09-15 12:32:37 +02:00
Antonio Scandurra
a1250b8525
Include modified buffers in semantic search results ( #2970 )
...
This pull request introduces an additional step to
`SemanticIndex::search_project` that includes the content of buffers
that are modified but haven't been saved yet. In most cases, the buffer
will contain a small portion of changed spans that are potentially not
included in the index. To reuse all the other spans that haven't
changed, we will query the database for embeddings by their digest. This
means we have to index spans by their digest, which means some penalty
when writing, but in our tests this didn't seem to make indexing much
slower.
Release Notes:
- Improved semantic search to include results from modified buffers.
(preview-only)
2023-09-15 12:24:10 +02:00
Antonio Scandurra
ae85a520f2
Refactor semantic searching of modified buffers
2023-09-15 12:12:20 +02:00
Kirill Bulatov
8d3c251cc2
Rework inlay hover model ( #2969 )
...
Fixes
```
thread 'main' panicked at 'byte index 2 is not a char boundary; it is inside '…' (bytes 0..3) of `…)`'
```
panics like
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1694535396473329
by reworking the inlay hover model:
* avoid storing "hardcoded" coordinates of hovered inlay labels (such as
`InlayOffset`), instead, remember `inlay_id` and apply required
highlights there when hint with the same id is handled
* add randomized tests on inlay highlights
* sped up inlay hint cache lookup by inlay_id
As a downside, background highlights are no long appearing on inlay
hints, but Zed does not receive any tooltips for inlays anyway (r-a does
not send them for some reason, other LSP seem to have no such feature?),
so it does not matter now.
Nontheless, if the logic for displaying hint pop-ups is present and
works for harcoded tooltips in r-a, only background highlight is missing
now.
Release Notes:
- Fixed inlay hint highlights causing panic for certain cases with
"large" characters
2023-09-15 10:40:02 +03:00
Kirill Bulatov
8c1df5afa2
Empty both hint cache storages correctly
2023-09-15 10:33:32 +03:00
Nathan Sobo
0a2a5be71c
Checkpoint
2023-09-14 21:42:56 -06:00
Max Brunsfeld
492e961e82
Bump protocol version
2023-09-14 18:39:31 -07:00
Max Brunsfeld
6ce672fb32
Add tooltips and actions for opening notes+call from chat
...
No keyboard shortcut yet.
2023-09-14 18:38:37 -07:00
Max Brunsfeld
b75971196f
Add buttons for opening channel notes and joining call, in chat panel header
2023-09-14 18:05:44 -07:00
Nathan Sobo
4fd4f44bb7
Checkpoint
2023-09-14 18:51:03 -06:00
Max Brunsfeld
dd7c687041
Style the chat panel further
2023-09-14 17:19:08 -07:00
KCaverly
796bdd3da7
update searching in modified buffers to accomodate for excluded paths
2023-09-14 19:42:06 -04:00
Max Brunsfeld
59269d422b
Allow deleting chat messages
2023-09-14 16:29:40 -07:00
Nathan Sobo
378b2fbd9e
WIP
2023-09-14 16:52:04 -06:00
Nathan Sobo
1f9b52d5e1
Checkpoint
2023-09-14 16:19:48 -06:00
Max Brunsfeld
89327eb84e
Start styling the chat panel
2023-09-14 15:16:08 -07:00
Nathan Sobo
b30bb56483
Checkpoint
2023-09-14 16:14:42 -06:00
Max Brunsfeld
9d8c6a7ed1
Merge branch 'main' into chat-again
2023-09-14 14:50:45 -07:00
Nathan Sobo
ba22da00bf
Checkpoint
2023-09-14 15:49:54 -06:00
Nathan Sobo
cee5ddee53
Checkpoint
2023-09-14 15:34:39 -06:00
Piotr Osiewicz
a1353b8bb9
search_bar: Add toggle_replace_on_a_pane. ( #2966 )
...
This allows users to add a keybind to ToggleReplace from Editor/Pane
contexts.
Release Notes:
- Fixed replace in buffer not reacting to keyboard shortcuts outside of
search bar<preview-only>.
2023-09-14 23:25:27 +02:00
Nathan Sobo
c74c60a629
Slotmaps
2023-09-14 15:21:49 -06:00
Kirill Bulatov
e7b5880af0
Combine both text and inlay highlights in randomized tests
2023-09-14 23:53:56 +03:00
Max Brunsfeld
877d67b97d
Provide an admin REST API for use by zed.dev ( #2962 )
...
We're using [PostgREST](https://hub.docker.com/r/postgrest/postgrest )
Todo:
* [x] Add instructions for installing postgrest to local development
docs
* [x] Deploy to staging
* [x] Deploy to production
* [x] Add DNS record for `admin-staging.zed.dev` pointing to the staging
db
* [x] Add a DNS record for `admin.zed.dev` pointing to the production db
2023-09-14 13:48:54 -07:00
Nathan Sobo
e4f8fe941e
Checkpoint
2023-09-14 14:47:02 -06:00
Nathan Sobo
b9e1ca1385
Checkpoint
2023-09-14 14:42:04 -06:00
Kirill Bulatov
f9b70718ac
Store hints in the map, not the snapshot
2023-09-14 23:36:33 +03:00
Conrad Irwin
4667110d0f
Fix multi-key shortcuts with modifiers
...
To make this work we need to move the handling of multiple possible key
events into the keyboard shortcut system.
This was broken in #2957 .
2023-09-14 14:35:17 -06:00
Kirill Bulatov
4e9f0adcef
Improve inlay hint cache lookup
2023-09-14 23:31:50 +03:00
Kirill Bulatov
8ae3f79235
Restructure inlay highlights data for proper access
2023-09-14 23:05:22 +03:00
Conrad Irwin
06555a423b
vim: g s/S for outline/project symbols
2023-09-14 13:49:02 -06:00
Kyle Caverly
9b901df256
small fix to rate status update ( #2967 )
...
Small fix to update code for rate limiting status.
Release Notes (Preview only)
- Fixed update to only stop updating status, when the rate limit is
reset to None
2023-09-14 15:43:30 -04:00
KCaverly
8ff3e37044
small fix to rate status update
2023-09-14 15:42:21 -04:00
Kirill Bulatov
9b43acfc88
Remove useless background highlights code
2023-09-14 22:18:30 +03:00
Kirill Bulatov
396efec6e1
Uncomment the rest of the tests
2023-09-14 22:18:26 +03:00
Kirill Bulatov
47e0535f1c
Randomize inlay highlight range start
2023-09-14 22:08:12 +03:00
Kirill Bulatov
129fb62182
Consider offsets in inlay chunks
2023-09-14 22:08:12 +03:00
Kirill Bulatov
a9de6c3dba
Properly handle inlay highlights in the InlayMap
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-09-14 22:08:12 +03:00
Kirill Bulatov
80b96eb05b
Add inlay highlight test
2023-09-14 22:08:12 +03:00
Kirill Bulatov
42bd2be2f3
Implement inlay highlighting
2023-09-14 22:08:12 +03:00
Kirill Bulatov
890a587254
Use standalone inlay background highlights
2023-09-14 22:08:12 +03:00
Kirill Bulatov
9f5314e938
Unify highlights in *Map
2023-09-14 22:08:12 +03:00
Kirill Bulatov
6c00cd8a35
Do not combine inlay and text highlights on the *Map level
2023-09-14 22:08:12 +03:00
KCaverly
c19c8899fe
add initial search inside modified buffers
2023-09-14 14:58:34 -04:00
Piotr Osiewicz
1eb74acb3e
editor: Do not run brace completion on empty text. ( #2965 )
...
Users of keyboard layout with IME complained about the peculiar
behaviour where typing in "sss" and then removing all of it left behind
one 's' and also appended a closing brace. This was not reproducible on
a buffer without language, so I've suspected that brace insertion might
be a problem here. For whatever reason when the user removes the last
character from a run that triggered IME, we receive a notification about
an empty insertion. Sadly, brace completion does not handle an empty
input properly and we erroneously insert a closing brace when deleting
the followup characters. In fact, the brace inserted is always the
closing brace for the first entry in language's config.toml 'brackets'
field (see Scheme vs Markdown). This guard also allows for the proper
removal of the first character.
Closes community tickets zed-industries/community#877
zed-industries/community#1329
Z-2869
Release Notes:
- Fixed handling of bracket completion for international keyboard
layouts that use IME. This led to Zed erroneously inserting the `}`
character while removing the first character that triggered IME.
2023-09-14 20:24:21 +02:00
Antonio Scandurra
f86e5a987f
WIP
2023-09-14 17:42:30 +02:00
Antonio Scandurra
6a271617b4
Make path optional when parsing file
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-14 17:09:08 +02:00
KCaverly
137dda3ee6
wip eval framework for semantic index
2023-09-14 09:30:19 -04:00
Joseph T. Lyons
24698b61fd
Fix toggle replace tooltip ( #2964 )
...
Release Notes:
- N/A
2023-09-13 20:24:05 -04:00
Joseph T. Lyons
15bdff1c5b
Fix toggle replace tooltip
2023-09-13 20:19:14 -04:00
KCaverly
0c1b2e5aa6
cleaned up warnings
2023-09-13 20:04:53 -04:00
KCaverly
eff44f9aa4
semantic index eval, indexing appropriately
2023-09-13 20:02:15 -04:00
Max Brunsfeld
18c899a0a8
Remove dead code for old admin pages
2023-09-13 15:02:59 -07:00
Max Brunsfeld
4ea6d12fe2
Document that PostgREST needs to be installed for running locally
2023-09-13 13:46:17 -07:00
Max Brunsfeld
dddd37f8a6
Run postgrest as part of foreman
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-09-13 12:32:15 -07:00
Max Brunsfeld
3910efe3ab
Use PostgREST instead of pgAdmin
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-09-13 11:47:20 -07:00
Nate Butler
fd10b49742
Fix .active() interaction state
...
Co-Authored-By: Nathan Sobo <1789+nathansobo@users.noreply.github.com >
2023-09-13 13:56:13 -04:00
Joseph T. Lyons
974bc07631
collab 0.21.0
2023-09-13 13:34:08 -04:00
Nathan Sobo
1c20a8cd31
Checkpoint
2023-09-13 11:07:24 -06:00
Max Brunsfeld
c4a5caa587
Get pgadmin loading the passfile
2023-09-13 10:05:13 -07:00
Nate Butler
a316e25034
Checkpoint
2023-09-13 12:50:01 -04:00
Nate Butler
f54f2c52e9
Checkpoint
2023-09-13 12:40:28 -04:00
Joseph T. Lyons
a6cb5f99f3
v0.105.x dev
2023-09-13 12:22:33 -04:00
Nathan Sobo
1adb7fa58c
Checkpoint
2023-09-13 09:28:04 -06:00
Nathan Sobo
dcf6059a15
Checkpoint
2023-09-13 08:55:14 -06:00
KCaverly
6f29582fb0
progress on eval
2023-09-13 10:32:36 -04:00
Nathan Sobo
8a6e9f90be
Checkpoint
2023-09-13 08:13:45 -06:00
Antonio Scandurra
5697a87f4a
Fix indentation issues when generating or transforming code with inline assistant ( #2961 )
...
This pull request extracts a separate `Codegen` struct that models the
interaction with OpenAI and takes care of diffing, auto-indenting and
reporting regions to highlight.
As part of this refactoring, we're now relying less on the AI model to
indent code. The new logic lets tree-sitter decide how the first line
should be indented. Then, for every subsequent line reported by ChatGPT,
it calculates an indent delta relative to the first reported line and
applies it to the indent level chosen by tree-sitter.
Release Notes:
- Improved auto-indentation when using the inline assistant.
2023-09-13 12:45:44 +02:00
Antonio Scandurra
127d03516f
Diff lines one chunk at a time after discovering indentation
2023-09-13 11:57:10 +02:00
Antonio Scandurra
70c9b8f8fd
Merge remote-tracking branch 'origin/main' into polish-codegen
2023-09-13 11:41:32 +02:00
Antonio Scandurra
b8c437529c
Never use the indentation that comes from OpenAI
2023-09-13 11:40:28 +02:00
Nathan Sobo
77af33ba5d
WIP
2023-09-13 00:03:56 -06:00
Max Brunsfeld
94db0be3ec
Start work on deploying pgAdmin to k8s cluster
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-09-12 21:06:43 -07:00
Max Brunsfeld
54838664ae
Retrieve load balancer certificate id from DigitalOcean on each deploy
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-09-12 21:04:59 -07:00
Nathan Sobo
faabed1df0
Checkpoint
2023-09-12 21:34:03 -06:00
Nathan Sobo
cae5c76bed
Checkpoint
2023-09-12 21:07:35 -06:00
Nathan Sobo
53b698adb6
Checkpoint
2023-09-12 20:40:05 -06:00
KCaverly
d4fbe99052
add eval for gpt-engineer
2023-09-12 21:27:35 -04:00
KCaverly
0d14bbbf5b
add eval values for tree-sitter
2023-09-12 20:36:06 -04:00
Conrad Irwin
329a0724e0
vim counts ( #2958 )
...
Release Notes:
- vim: Fix counts with operators (`2yy`, `d3d`, etc.)
([#1496 ](https://github.com/zed-industries/community/issues/1496 ))
([#970 ](https://github.com/zed-industries/community/issues/970 )).
- vim: Add support for counts with insert actions (`2i`, `2o`, `2a`,
etc.)
- vim: add `_` and `g_`
2023-09-12 14:32:00 -06:00
KCaverly
66c967da88
start work on eval script for semantic_index
2023-09-12 16:25:31 -04:00
Piotr Osiewicz
a63b78d5a0
Replace in buffer adjustments ( #2960 )
...
This PR addresses feedback from @maxbrunsfeld on new replace in buffer.
It fixes:
- missing padding surrounding replace input.
- missing padding around replace buttons.
- missing `.notify` call which made the replace fields not show up
immediately sometimes.
Release Notes:
- N/A
---------
Co-authored-by: Max <max@zed.dev >
2023-09-12 22:08:39 +02:00
Julia
65e0a67625
Lsp status bugfix ( #2959 )
...
Release Notes:
- Fixed a case where language server download statuses could be skipped.
- Fixed a case where language server diagnostic progress could get stuck
when restarting a language server.
2023-09-12 15:59:00 -04:00
Nate Butler
bbc4673f17
Checkpoint
2023-09-12 15:18:13 -04:00
Julia
c6f293076e
Avoid keeping stale LSP progress indicator state when server is removed
2023-09-12 15:14:49 -04:00
Conrad Irwin
0958def770
Remove another supported exemption
2023-09-12 12:48:36 -06:00
Nathan Sobo
dc2733998e
WIP
2023-09-12 12:43:08 -06:00
Max Brunsfeld
d97c9d8dfd
Merge branch 'main' into chat-again
2023-09-12 11:26:54 -07:00
Julia
b0facf8e1e
Use unbounded channel(s) for LSP binary status messaging
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-09-12 13:45:36 -04:00
Piotr Osiewicz
4cb8647702
Z 1200/replace in buffer ( #2922 )
...
This is still WIP, mostly pending styling. I added a pretty rudimentary
text field and no buttons whatsoever other than that. I am targeting a
Preview of 09.13, as I am gonna be on PTO for the next week.
I dislike the current implementation slightly because of `regex`'s crate
syntax and lack of support of backreferences. What strikes me as odd wrt
to syntax is that it will just replace a capture name with empty string
if that capture is missing from the regex. While this is perfectly fine
behaviour for conditionally-matched capture groups (e.g. `(foo)?`), I
think it should still error out if there's no group with a given name
(conditional or not).
Release Notes:
- Added "Replace" functionality to buffer search.
2023-09-12 18:46:54 +02:00
Conrad Irwin
dcaba9d9e7
Remove supported exception
...
(and refactor tests to be more linear)
2023-09-12 10:13:24 -06:00
Conrad Irwin
7daed1b2c3
Fix 0 used in a count
2023-09-12 09:56:23 -06:00
Nate Butler
0d161519e4
Checkpoint
2023-09-12 11:34:27 -04:00
Nathan Sobo
5dad97779a
WIP
2023-09-12 07:34:42 -06:00
Conrad Irwin
c2c521015a
Fix bug where cursors became invisible if replaying was interrupted
2023-09-11 20:56:22 -06:00
Max Brunsfeld
1c50587cad
Remove channel chat participant when connection is lost
2023-09-11 17:37:05 -07:00
Conrad Irwin
76d55244a1
Clear counts when switching modes
2023-09-11 18:30:31 -06:00
Max Brunsfeld
f2112b9aad
Rejoin channel chats upon reconnecting
2023-09-11 17:11:33 -07:00
Conrad Irwin
d868d00985
vim: ALlow counts on insert actions
...
This re-uses the existing repeat infrastructure.
2023-09-11 18:09:47 -06:00
Max Brunsfeld
f53a1ee46d
Put channel call participants back in channel row
...
Open both the channel notes and the channel chat when clicking a channel
2023-09-11 13:44:41 -07:00
Conrad Irwin
cee549e1ef
vim: Fix count handling to allow pre/post counts
...
Fixes 2yy, d3d, etc.
For zed-industries/community#970
For zed-industries/community#1496
2023-09-11 14:35:47 -06:00
Conrad Irwin
e8a6ecd6ac
Allow a count with CurrentLine
...
Add _ and g_ too while we're here.
2023-09-11 14:19:43 -06:00
Nathan Sobo
3ba8857491
Checkpoint
2023-09-11 12:58:55 -06:00
Nate Butler
c545788168
Add Storybook Components ( #2956 )
...
[[PR Description]]
Started building out some early components in the storybook using a
modified version of the classic Atomic Design model @mikayla-maki and I
are exploring.
<img width="1134" alt="atomic_design"
src="https://github.com/zed-industries/zed/assets/1714999/9093a8b5-a71d-41d4-bae2-f7562494c5f3 ">
This PR adds a few things:
- `tab`, `tab_bar` and `icon_button` components
- Dynamic documentation for the proc macro generated methods like `w_8`,
`px_2`, etc.
- Continues to build out the Zed workspace demo
Release Notes:
- N/A
2023-09-11 14:47:35 -04:00
Kirill Bulatov
017aa1fdfb
Allow installing rustup via homebrew
2023-09-11 21:35:08 +03:00
Nathan Sobo
fe6f0a253b
Merge remote-tracking branch 'origin/main' into chat-again
2023-09-11 12:08:01 -06:00
Conrad Irwin
0c2bc6e553
Fix some international keybindings ( #2957 )
...
This adds primitive interaction with the IME system for keyboard
shortcuts in zed.
- Consult the IME functionality when handling keyboard shortcuts. This
allows you to bind to characters (like " on a Brazillian keybaord, or $
on a Czech keyboard) that aren't typed with an unmodified key.
([#1981 ](https://github.com/zed-industries/community/issues/1981 ))
([#1913 ](https://github.com/zed-industries/community/issues/1913 ))
Co-authored-with: Antonio Scandurra <me@as-cii.com >
2023-09-11 11:56:57 -06:00
Conrad Irwin
e017dc6a5e
Fix ctrl-` on Brazillian too
2023-09-11 11:33:04 -06:00
Conrad Irwin
0a6e577e10
Fix some international keybindings
...
This adds primitive interaction with the IME system for keyboard
shortcuts in zed.
For zed-industries/community#1981
For zed-industroes/community#1913
2023-09-11 10:35:42 -06:00
Conrad Irwin
b922d0f132
Use rustup (not brew) for rust
2023-09-11 10:15:22 -06:00
Piotr Osiewicz
f66dd43a84
Z 2620 - Sort command palette's entries by name and use count ( #2954 )
...
Release Notes:
- Improved command palette's command ordering; commands are sorted
lexicographically and by command's use count in the current session.
2023-09-11 17:50:09 +02:00
Nate Butler
c7ad89d7fa
Merge branch 'main' into nate/storybook-components
2023-09-11 11:49:49 -04:00
Nate Butler
04fc9d2d33
Fix incorrect workspace order
2023-09-11 11:42:54 -04:00
Nate Butler
1376115db2
Use enabled for active tabs
2023-09-11 11:40:03 -04:00
Nathan Sobo
c3a3543ebb
Introduce gpui2 and storybook crates ( #2919 )
...
This PR splits `crates/gpui/playground` with two new crates: `gpui2` and
`storybook`.
GPUI 2 re-exports most of `gpui`, but makes some adjustments. I want to
keep the scope focused. This isn't literally version 2.0 of GPUI or
anything. It's just a convenient way to make a create with fewer
dependencies where we can iterate quickly on aspects of GPUI's design.
Most of the focus is on improving our approach to element layout and
styling.
The `storybook` crate is pretty empty for now, but it's where I intend
to start rebuilding interfaces. I welcome anyone else to join me in
this, though until I get one interface fully built, buyer beware. You
may need to pair on it with me.
2023-09-11 09:19:43 -06:00
Nathan Sobo
15ea4af5e7
Merge branch 'main' into storybook
2023-09-11 09:13:46 -06:00
Nate Butler
917884ffaf
Restructure storybook modules and components
...
Co-Authored-By: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com >
2023-09-11 11:05:10 -04:00
Nathan Sobo
e0fdc7d0aa
Eliminate PaintContext
2023-09-11 09:00:59 -06:00
Nathan Sobo
a24d94cfda
Eliminate LayoutContext
2023-09-11 08:47:00 -06:00
Kyle Caverly
d4da5540ac
Rate limiting status ( #2955 )
...
Add a rate limit remaining status to Project Search Semantic Search
minor text
Release Notes (Preview-Only):
- Added tracking functionality within EmbeddingProvider, to track rate
limit expiry
- Update minor text within Project Search to show countdown remaining
before rate limit expiry
2023-09-11 10:40:11 -04:00
Nate Butler
2774eae21a
Checkpoint
2023-09-11 10:36:49 -04:00
KCaverly
74ab41000b
Merge branch 'main' of github.com:zed-industries/zed into rate_limiting_status
2023-09-11 10:26:22 -04:00
KCaverly
e678c7d9ee
swap
...
SystemTime for Instant throughout rate_limit_expiry tracking
2023-09-11 10:26:14 -04:00
KCaverly
7df21f86dd
move cx notify observe for rate_limit_expiry into ProjectState in the semantic index
...
Co-authored-by: Antonio <antonio@zed.dev >
2023-09-11 10:11:40 -04:00
Antonio Scandurra
6d9333dc3b
Add a failing test for codegen autoindent
2023-09-11 14:35:15 +02:00
Antonio Scandurra
02078140c0
Extract code generation logic into its own module
2023-09-11 11:25:37 +02:00
Mikayla Maki
49c80201f3
Add syntax highlighting for nu ( #2952 )
...
Unfortunately, their language server implementation uses [VSCode
directly](https://github.com/neovim/nvim-lspconfig/issues/2592 ), so I
don't think we can bundle it in yet. For reference, I also started
prepping a [Zed
repository](https://github.com/zed-industries/nushell-lsp ) for serving
the nu language server but have archived it since discovering the issue.
Release Notes:
- Added syntax highlighting for Nushell script files
2023-09-09 16:00:55 -07:00
Mikayla
2be34ef254
Add syntax highlighting for nu scripts
2023-09-09 15:39:39 -07:00
Nate Butler
e84e791dde
Checkpoint
2023-09-09 17:51:23 -04:00
Mikayla
ef03e206d6
WIP: Add nushell support
2023-09-09 14:01:53 -07:00
Nate Butler
9bb8eae985
init tab_bar
2023-09-09 13:38:57 -04:00
Nate Butler
69f380b689
Fix doc typo
2023-09-09 11:30:35 -04:00
Nate Butler
5ad9a6bb3c
Add docs for styleable_helpers proc macros
2023-09-09 11:29:31 -04:00
Conrad Irwin
7cc05c99c2
Update getting started
...
Just ran through this again.
2023-09-08 23:46:12 -06:00
Nate Butler
8dd6fcc186
Add icon_button
2023-09-08 22:16:12 -04:00
Max Brunsfeld
f5f85b3f76
Add missing notify when changing ChatPanel's channel
2023-09-08 17:29:16 -07:00
Max Brunsfeld
c2121c25c1
Restructure collab panel to allow opening chat + notes w/ one click
2023-09-08 17:06:39 -07:00
Max Brunsfeld
a91f5244a9
Mute on join if ZED_IMPERSONATE is set
2023-09-08 16:24:37 -07:00
Conrad Irwin
e29ce489c8
vim: Add ZZ and ZQ ( #2950 )
...
The major change here is a refactoring to allow controling the save
behaviour when closing items, which is pre-work needed for vim command
palette.
For zed-industries/community#1868
Release Notes:
- vim: Add `ZZ` and `ZQ` to close the current item.
([#1868 ](https://github.com/zed-industries/community/issues/1868 ))
2023-09-08 16:58:04 -06:00
Conrad Irwin
4c92172cca
Partially roll back refactoring
2023-09-08 16:49:50 -06:00
Conrad Irwin
ba1c350dad
vim: Add ZZ and ZQ
...
The major change here is a refactoring to allow controling the save
behaviour when closing items, which is pre-work needed for vim command
palette.
For zed-industries/community#1868
2023-09-08 16:25:20 -06:00
Nathan Sobo
ebf8b32811
Checkpoint
2023-09-08 16:25:10 -06:00
Nathan Sobo
6b23f74636
Checkpoint
2023-09-08 16:08:31 -06:00
KCaverly
37915ec4f2
updated notify to accomodate for updated countdown
2023-09-08 16:53:16 -04:00
Max Brunsfeld
ed7bc91dbd
Create chat panel settings
2023-09-08 13:28:19 -07:00
Nathan Sobo
362b1a44be
Merge branch 'main' into storybook
2023-09-08 14:18:44 -06:00
Nathan Sobo
c3b1264c05
Checkpoint
2023-09-08 14:09:29 -06:00
Nathan Sobo
14fc386dc8
Checkpoint
2023-09-08 13:54:15 -06:00
Nathan Sobo
53a50b8df4
Move refreshing to window
2023-09-08 13:27:29 -06:00
KCaverly
bf43f93197
updated semantic_index reset status to leverage target reset system time as opposed to duration
2023-09-08 15:04:50 -04:00
Conrad Irwin
5d782b6cf0
vim . to replay ( #2936 )
...
Release Notes:
- vim: Add `.` to replay
([#946 ](https://github.com/zed-industries/community/issues/946 ))
- vim: Fix `J` in visual mode, and with counts.
2023-09-08 11:52:35 -06:00
Conrad Irwin
88dae22e3e
Don't replay ShowCharacterPalette
2023-09-08 11:35:00 -06:00
Conrad Irwin
f069cd0485
Fix f,t on soft-wrapped lines ( #2940 )
...
Release Notes:
- vim: fix `f` and `t` on softwrapped lines
2023-09-08 11:34:12 -06:00
Max Brunsfeld
ddda5a559b
Restore chat functionality with a very rough UI
2023-09-08 09:59:35 -07:00
Joseph T. Lyons
e1d4d911b4
Add tooltip to language selector ( #2949 )
...
Release Notes:
- N/A
2023-09-08 12:48:37 -04:00
Joseph T. Lyons
a0701777d5
Make tooltip title case to match other tooltips
2023-09-08 12:44:49 -04:00
Joseph T. Lyons
f4a9d3f269
Add tooltip to language selector
2023-09-08 12:41:32 -04:00
KCaverly
a5ee8fc805
initial outline for rate limiting status updates
2023-09-08 12:35:15 -04:00
Julia
87472a9de6
Fix Python's cached binary retrieval being borked ( #2948 )
...
We fixed this while brainstorming a better approach to handle server
binaries and if we already have a fix for this one then we might as well
have this not be broken while the new mechanism is being built
Release Notes:
- Fixed Python language server not launching without a network
connection.
2023-09-08 12:21:18 -04:00
Nathan Sobo
21d390fa4a
Support overflow scroll
2023-09-08 10:20:45 -06:00
Conrad Irwin
5f897f45a8
Fix f,t on soft-wrapped lines
...
Also remove the (dangerously confusing) display_map.find_while
2023-09-08 10:16:46 -06:00
Julia
74ccb3df63
Fix Python's cached binary retrieval being borked
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-09-08 12:09:31 -04:00
Nathan Sobo
713d72942d
Fix bounds calculations
2023-09-08 06:45:23 -06:00
Nathan Sobo
7738867639
Always pass parent origin when painting elements
2023-09-08 06:32:20 -06:00
Antonio Scandurra
e9747d0fea
Find keystrokes defined on a child but handled by a parent ( #2947 )
...
This fixes a bug that was preventing keystrokes from being shown on
tooltips for the "Buffer Search" and "Inline Assist" buttons in the
toolbar.
This pull request makes the behavior of `keystrokes_for_action` more
consistent with the behavior of `available_actions`. It seems reasonable
that, if a child view defines a keystroke for an action and that action
is handled on a parent, we should show the child's keystroke.
Release Notes:
- Fixed a bug that was preventing certain keystrokes from being shown in
tooltips.
2023-09-08 14:11:30 +02:00
Antonio Scandurra
ddc8a126da
Find keystrokes defined on a child but handled by a parent
...
This fixes a bug that was preventing keystrokes from being shown on tooltips
for the "Buffer Search" and "Inline Assist" buttons in the toolbar.
This commit makes the behavior of `keystrokes_for_action` more consistent with
the behavior of `available_actions`. It seems reasonable that, if a child view
defines a keystroke for an action and that action is handled on a parent, we
should show the child's keystroke.
2023-09-08 12:50:59 +02:00
Antonio Scandurra
6ad2ec4825
Make channel notes act as an editor to enable inline assistant ( #2946 )
...
I think it should be fine to make channel notes act as editors, so I'll
go ahead and merge this but cc'ing @mikayla-maki and @maxbrunsfeld, in
case I'm overlooking something.
Release Notes:
- Added the inline assistant to channel notes.
2023-09-08 11:51:14 +02:00
Antonio Scandurra
4e818fed4a
Make channel notes act as an editor to enable inline assistant
2023-09-08 11:20:49 +02:00
Nathan Sobo
d311bd04ff
Add basic inspector
2023-09-07 22:24:02 -06:00
Max Brunsfeld
da5a77badf
Start work on restoring server-side code for chat messages
2023-09-07 16:32:49 -07:00
Nate Butler
e7760e1a3f
Outline workspace
2023-09-07 16:25:02 -04:00
Nate Butler
ab8a9e912f
Remove accidentally added files
2023-09-07 16:19:06 -04:00
Nathan Sobo
4307a06073
WIP
2023-09-07 14:16:44 -06:00
Max Brunsfeld
e7b7ac9d8c
Make toolbar horizontal padding more consistent ( #2944 )
...
* increase horizontal padding of toolbar itself, remove padding that was
added to individual toolbar items like feedback button.
* make feedback info text and breadcrumbs have the same additional
padding as quick action buttons.
Release Notes:
- Fixed some inconsistencies in the layout of toolbars.
2023-09-07 13:12:26 -07:00
Nate Butler
14ea5a1485
Checkpoint
2023-09-07 16:01:32 -04:00
Max Brunsfeld
56d9a578bd
Make toolbar horizontal padding more consistent
...
* increase horizontal padding of toolbar itself, remove padding
that was added to individual toolbar items like feedback button.
* make feedback info text and breadcrumbs have the same additional padding as
quick action buttons.
2023-09-07 12:53:46 -07:00
Nate Butler
5fb9c60905
Checkpoint
2023-09-07 15:33:50 -04:00
Julia
5b0f4ac9e8
Stop LiveKitBridge Package.resolved from constantly updating ( #2943 )
...
Stop that damned LiveKitBridge Package.resolved from continually
changing and act more like a lock file
Release Notes:
- N/A
2023-09-07 14:58:55 -04:00
Julia
4d2933a4d7
Include JS template literal as string type for overrides ( #2939 )
...
Allows us to trigger Tailwind completions within template literals in
JSX elements
Release Notes:
- Fixed Tailwind autocomplete not appearing in template literals.
2023-09-07 14:58:41 -04:00
Kyle Caverly
560d6b1644
update semantic search to show no results if search query is blank ( #2942 )
...
Update semantic search to show no search results if search query is
blank
2023-09-07 14:58:00 -04:00
Julia
a6ce382368
Stop LiveKitBridge Package.resolved from constantly updating
2023-09-07 14:50:36 -04:00
KCaverly
cf5d1d91a4
update semantic search to go to no results if search query is blank
2023-09-07 14:43:41 -04:00
Max Brunsfeld
3422eb65e8
Restore channel chat model and panel view
2023-09-07 11:38:27 -07:00
Antonio Scandurra
98999b1e9a
Start indexing right away when project was already indexed before ( #2941 )
...
Release notes:
- Improved semantic search indexing to start in the background if the
project was already indexed before.
2023-09-07 19:47:26 +02:00
Antonio Scandurra
eda7e00645
Implement SemanticIndex::status and use it in project search
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-07 19:39:30 +02:00
Nate Butler
f7b2edb59a
Checkpoint
2023-09-07 13:15:38 -04:00
Conrad Irwin
8e2e00e003
add vim-specific J (with repeatability)
2023-09-07 11:08:07 -06:00
Antonio Scandurra
47d7aa0b91
Allow searching before indexing is complete
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-07 19:04:45 +02:00
Nate Butler
17c5bbfd96
Update titlebar style
2023-09-07 12:58:42 -04:00
Nate Butler
23a8d8fba4
Merge workspace and collab panel demos
2023-09-07 12:55:47 -04:00
Antonio Scandurra
65e17e212d
Eagerly index project on workspace creation if it was indexed before
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-07 18:51:55 +02:00
Conrad Irwin
48bb2a3321
TEMP
2023-09-07 10:51:18 -06:00
Nate Butler
a87711d157
Merge branch 'nate/wip-storybook-workspace' into storybook
2023-09-07 12:51:05 -04:00
Conrad Irwin
1b1d7f22cc
Add visual area repeating
2023-09-07 10:45:38 -06:00
Julia
1969a12a0b
Include JS template literal as string type for overrides
2023-09-07 10:55:04 -04:00
Nathan Sobo
37ef28a3bf
Merge branch 'main' into storybook
2023-09-07 07:56:57 -06:00
Antonio Scandurra
3b784668c0
Rework how we track projects and worktrees in semantic index ( #2938 )
...
This pull request introduces several improvements to the semantic search
experience. We're still missing collaboration and searching modified
buffers, which we'll tackle after we take a detour into reducing the
number of tokens used to generate embeddings.
Release Notes:
- Fixed a bug that could prevent semantic search from working when
deploying right after opening a project.
- Fixed a panic that could sometimes occur when using semantic search
while simultaneously changing a file.
- Fixed a bug that prevented semantic search from including new
worktrees when adding them to a project.
2023-09-07 15:30:19 +02:00
Antonio Scandurra
a45c8c380f
💄
2023-09-07 15:25:23 +02:00
Antonio Scandurra
757a285852
Keep dropping the documents table if it exists
...
This is because we renamed `documents` to `spans`.
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-07 15:15:16 +02:00
Antonio Scandurra
93b889a93b
Merge remote-tracking branch 'origin/main' into semantic-search-watch-worktrees
2023-09-07 15:07:46 +02:00
Antonio Scandurra
3ad1befb11
Remove unneeded logging
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-07 15:07:21 +02:00
Joseph T. Lyons
425a3969c8
Allow call events to be logged without a room id ( #2937 )
...
Prior to this PR, we assumed that all call events needed a room_id, but
we now have call-based actions that don't need a room_id - for instance,
you can right click a channel and view the notes while not in a call. In
this case, there is no room_id. We want to be able to track these
events, which requires removing the restriction that requires a room_id.
Release Notes:
- N/A
2023-09-06 23:08:36 -04:00
Joseph T. Lyons
39e13b6675
Allow call events to be logged without a room id
2023-09-06 22:53:05 -04:00
Nathan Sobo
a8d5d93757
Max out corner radii to half the smaller dimension of the parent box
2023-09-06 17:21:05 -06:00
Nathan Sobo
99ad60460a
Add support for fetching/rendering images
2023-09-06 17:13:43 -06:00
Max Brunsfeld
d03a89ca19
Rejoin channel notes after brief connection loss ( #2930 )
...
* [x] Re-send operations that weren't sent while disconnected
* [x] Apply other clients' operations that were missed while
disconnected
* [x] Update collaborators that joined / left while disconnected
* [x] Inform current collaborators that your peer id has changed
* [x] Refresh channel buffer collaborators on server restart
* [x] randomized test
2023-09-06 15:11:21 -07:00
Max Brunsfeld
58f58a629b
Tolerate channel buffer operations being re-sent
2023-09-06 14:58:25 -07:00
Max Brunsfeld
ed2aed4f93
Update test name in randomized-test-minimize script
2023-09-06 14:29:11 -07:00
Max Brunsfeld
b75e69d31b
Check that channel notes text converges in randomized test
2023-09-06 14:25:07 -07:00
Nathan Sobo
6d4dd0e7a4
Checkpoint
2023-09-06 15:22:35 -06:00
Max Brunsfeld
e779adfe46
Add basic randomized integration test for channel notes
2023-09-06 14:09:36 -07:00
Max Brunsfeld
66c3879306
Extract randomized test infrastructure for use in other tests
2023-09-06 14:08:43 -07:00
Nathan Sobo
46451f2a8b
Render borders in gpui2 divs
2023-09-06 14:31:44 -06:00
Nathan Sobo
5a778fbde6
Checkpoint
2023-09-06 14:16:15 -06:00
Conrad Irwin
f22d53eef9
Make test more deterministic
...
Otherwise these pass only when --features=neovim is set
2023-09-06 14:14:49 -06:00
Conrad Irwin
20f98e4d17
vim . to replay
...
Co-Authored-By: maxbrunsfeld@gmail.com
2023-09-06 13:49:55 -06:00
Nate Butler
0d1fb7f29e
WIP
2023-09-06 15:44:14 -04:00
Kyle Caverly
bbeb82f884
Token count fix ( #2935 )
...
Fix token count for OpenAIEmbeddings
Release Notes (Preview Only)
- update token count calculation for truncated OpenAIEmbeddings
- increased request timeout for OpenAI
2023-09-06 15:15:02 -04:00
KCaverly
265d02a583
update request timeout for open ai embeddings
2023-09-06 15:09:46 -04:00
KCaverly
17237f748c
update token_count for OpenAIEmbeddings to accomodate for truncation
2023-09-06 15:09:15 -04:00
Nate Butler
5337d9605a
Add size rounded prefixes
...
Co-Authored-By: Nathan Sobo <1789+nathansobo@users.noreply.github.com >
2023-09-06 14:18:29 -04:00
Joseph T. Lyons
f4237ace40
collab 0.20.0
2023-09-06 13:33:39 -04:00
Joseph T. Lyons
5b5c232cd1
Revert "Temporarily comment out cargo check commands"
...
This reverts commit 29e35531af .
2023-09-06 12:54:53 -04:00
Joseph T. Lyons
15609b4803
v0.104.x dev
2023-09-06 12:53:50 -04:00
Joseph T. Lyons
29e35531af
Temporarily comment out cargo check commands
2023-09-06 12:53:50 -04:00
Nathan Sobo
707427d9f5
Select caret based on expanded boolean
2023-09-06 10:24:22 -06:00
Nathan Sobo
a2e91e45d9
Use preview server when not on stable ( #2909 )
...
This PR updates our client code to connect to preview whenever we're not
on stable. This will make it more likely that we'll be able to
collaborate on a dev build, but obviously won't work if there's a
protocol change on main that hasn't made its way to preview yet.
2023-09-06 10:09:08 -06:00
Julia
246b699bfd
Remove NodeRuntime static & add fake implementation for tests ( #2934 )
...
Release Notes:
- N/A
2023-09-06 11:27:28 -04:00
Julia
8d672f5d4c
Remove NodeRuntime static & add fake implementation for tests
2023-09-06 11:18:55 -04:00
Antonio Scandurra
ce62173534
Rename Document to Span
2023-09-06 17:03:08 +02:00
Antonio Scandurra
de0f53b39f
Ensure SemanticIndex::search waits for indexing to complete
2023-09-06 11:40:59 +02:00
Antonio Scandurra
c802680084
Clip ranges returned by SemanticIndex::search
...
The files may have changed since the last time they were parsed, so the
ranges returned by `SemanticIndex::search` may be out of bounds.
2023-09-06 09:41:51 +02:00
Nathan Sobo
de77e56dc6
Checkpoint
2023-09-05 18:53:25 -06:00
Nate Butler
a3039ad95b
Add list items for scroll testing
2023-09-05 18:52:05 -04:00
Nathan Sobo
85aedf9bed
WIP: Icons not yet rendering
2023-09-05 16:40:52 -06:00
Nate Butler
6cb9cf70b7
Mark placeholder SVGs
2023-09-05 17:32:59 -04:00
Nate Butler
1ea0d500be
Ignore cargo-target
2023-09-05 17:27:09 -04:00
Nate Butler
7f85780c78
Add fraction sizes for tailwind lengths
2023-09-05 17:27:00 -04:00
Joseph T. Lyons
9272e9354a
Add operation for opening channel notes in channel-based calls ( #2933 )
...
Release Notes:
- N/A
2023-09-05 17:24:19 -04:00
Nathan Sobo
5a9c76e080
Fix hoverable elements moving on hover
2023-09-05 15:17:09 -06:00
Nate Butler
477f4ddbbd
Continue collab_panel
2023-09-05 17:13:33 -04:00
Joseph T. Lyons
653d4976cd
Add operation for opening channel notes in channel based calls
2023-09-05 17:13:09 -04:00
Nate Butler
0695e8d3b9
Work on sample collab_panel story in the storybook
...
Co-Authored-By: Nathan Sobo <1789+nathansobo@users.noreply.github.com >
2023-09-05 15:19:44 -04:00
Nathan Sobo
e08c0fc4ce
Checkpoint
2023-09-05 12:50:07 -06:00
Max Brunsfeld
ec5ff20b4c
Implement clearing stale channel buffer participants on server restart
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-09-05 11:34:24 -07:00
Nathan Sobo
9ec7569e09
Checkpoint
2023-09-05 12:16:21 -06:00
Kyle Caverly
49af2874bb
Eager background indexing ( #2928 )
...
This PR ships a series of optimizations for the semantic search engine.
Mostly focused on removing invalid states, optimizing requests to
OpenAI, and reducing token usage.
Release Notes (Preview-Only):
- Added eager incremental indexing in the background on a debounce.
- Added a local embeddings cache for reducing redundant calls to OpenAI.
- Moved to an Embeddings Queue model which ensures optimal batch sizes
at the token level, and atomic file & document writes.
- Adjusted OpenAI Embedding API requests to use provided backoff delays
during Rate Limiting.
- Removed flush races between parsing files step and embedding queue
steps.
- Moved truncation to parsing step reducing the probability that OpenAI
encounters bad data.
2023-09-05 13:15:54 -04:00
Nathan Sobo
0307cb8a88
Start sketching a collab panel in storybook
...
Co-Authored-By: Nate Butler <nate@zed.dev >
2023-09-05 10:02:36 -06:00
Conrad Irwin
c2c04616b4
vim S ( #2929 )
...
Release Notes:
- vim: Add `S` to substitute line ([#1897 ](https://github.com/zed-industries/community/issues/1897 )).
2023-09-05 09:39:08 -06:00
Conrad Irwin
27143e2fb4
Split ContextMenu actions ( #2931 )
...
This should have no user-visible impact.
For vim `.` to repeat it's important that actions are replayable.
Currently editor::MoveDown *sometimes* moves the cursor down, and
*sometimes* selects the next completion.
For replay we need to be able to separate the two.
2023-09-05 09:38:08 -06:00
Antonio Scandurra
95b72a73ad
Re-index project when a worktree is registered
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-05 17:17:58 +02:00
Antonio Scandurra
3c70b127bd
Simplify SemanticIndex::index_project
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-05 16:54:48 +02:00
Nate Butler
4855063151
Fix cropped search filters ( #2932 )
...
Because of the way we set up tools that add rows inside the toolbar it
is complicated to tighten up the spacing inside the toolbar.
This PR just reverts the changes I made previously. We'll need to
properly add rows below the toolbar instead of rendering search inside
of it to have non-equal height tools be able to descend from it.
Release Notes:
- Preview – Fixed an issue where search filters were partially cut off
in the UI.
2023-09-05 10:49:38 -04:00
Nate Butler
e2479a7172
Fix cropped search filters
2023-09-05 10:24:49 -04:00
Antonio Scandurra
6b1dc63fc0
Retrieve embeddings based on pending files
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-05 16:16:12 +02:00
Antonio Scandurra
7b5a41dda2
Move retrieval of embeddings from the db into reindex_changed_files
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-09-05 16:09:24 +02:00
Antonio Scandurra
d4cff68475
🎨
2023-09-05 15:52:36 +02:00
Kirill Bulatov
42976b6014
Add LSP logs clear button ( #2913 )
...
LSP logs tend to accumulate and hinder performance (e.g. search is
slower over 20 MB of json files).
Add a way to clear them.
Release Notes:
- N/A
2023-09-05 12:11:35 +03:00
Conrad Irwin
56db21d54b
Split ContextMenu actions
...
This should have no user-visible impact.
For vim `.` to repeat it's important that actions are replayable.
Currently editor::MoveDown *sometimes* moves the cursor down, and
*sometimes* selects the next completion.
For replay we need to be able to separate the two.
2023-09-02 21:04:19 -06:00
Conrad Irwin
55dd0b176c
Use consistent naming
2023-09-02 19:52:18 -06:00
Conrad Irwin
3a7b551e33
Fix tests with no neovim
2023-09-02 19:43:05 -06:00
Max Brunsfeld
6827ddf97d
Start work on refreshing channel buffer collaborators on server restart
2023-09-01 17:51:00 -07:00
Max Brunsfeld
e6babce556
Broadcast new peer ids for rejoined channel collaborators
2023-09-01 17:23:55 -07:00
Max Brunsfeld
d7e4cb4ab1
executor: timers must be used
2023-09-01 16:52:41 -07:00
Max Brunsfeld
d370c72fbf
Start work on rejoining channel buffers
2023-09-01 16:52:12 -07:00
KCaverly
8dbc0fe033
update pragma settings for improved database performance
2023-09-01 17:07:20 -04:00
Conrad Irwin
da16167db1
Fix find_{,preceding}boundary to work on buffer text ( #2912 )
...
Fixes movement::find_boundary to work on the buffer, not on display
points.
The user-visible impact is that the "until end of word" commands now
correctly go to the end of a soft-wrapped word (instead of to the first
character of the wrapped line).
It also fixes a bug where the callback passed to these methods was
called with the content of inlay hints.
[[PR Description]]
Release Notes:
- fix finding end of word on soft-wrapped lines
2023-09-01 12:14:16 -07:00
Conrad Irwin
af12977d17
vim: Add S to substitute line
...
For zed-industries/community#1897
2023-09-01 13:13:59 -06:00
Conrad Irwin
aa7b65bbaf
Merge branch 'main' into vim-softwrap-word
2023-09-01 12:23:56 -06:00
Conrad Irwin
0e41c6c5b3
Fix accidental visual selection on scroll ( #2927 )
...
Release Notes:
- vim: Fix bug where scrolling vertically would sometimes enter visual
mode
2023-09-01 10:58:10 -07:00
Conrad Irwin
6d7949654b
Fix accidental visual selection on scroll
...
As part of this fix partial page distance calculations to more closely
match vim.
2023-09-01 11:14:27 -06:00
KCaverly
54235f4fb1
updated embeddings background delay to 5 minutes
...
Co-authored-by: Max <max@zed.dev >
2023-09-01 13:04:09 -04:00
KCaverly
e86964eb5d
optimize insert file in vector database
...
Co-authored-by: Max <max@zed.dev >
2023-09-01 13:01:37 -04:00
Nathan Sobo
2fa9c037c8
Merge remote-tracking branch 'origin' into storybook
2023-09-01 10:08:48 -06:00
Nathan Sobo
6275c560e7
Fix warnings for a clean build
2023-09-01 10:08:41 -06:00
KCaverly
524533cfb2
flush embeddings queue when no files are parsed for 250 milliseconds
...
Co-authored-by: Antonio <antonio@zed.dev >
2023-09-01 11:24:08 -04:00
KCaverly
c4db914f0a
move embeddings queue to use single hashmap for all changed paths
...
Co-authored-by: Antonio <me@as-cii.com >
2023-09-01 08:59:25 -04:00
Antonio Scandurra
2bf417fa45
Avoid duplicate entries in inline assistant's prompt history ( #2926 )
...
Release Notes:
- Improved the inline assistant's prompt history to avoid including the
same entry multiple times. (preview-only)
2023-09-01 09:20:14 +02:00
Antonio Scandurra
d868ec920f
Avoid duplicate entries in inline assistant's prompt history
2023-09-01 09:15:29 +02:00
Max Brunsfeld
7bcc59c8a5
Remove the concept of a local clock; use lamport clocks for all per-replica versioning ( #2924 )
...
### Background
Currently, our CRDT uses three different types of timestamps:
| clock type | representation | purpose |
|-----|----------------|----------|
| `Local` | replica id + u32 | uniquely identifies operations |
| `Lamport` | replica id + u32 | provides a consistent total ordering
for all operations |
| `Global` | N local clocks | fully defines the partial ordering between
all concurrent operations |
All text operations include *each* type of timestamp. And every
`Fragment` in a buffer's fragment tree contains both a local and a
lamport timestamp.
### Change
An operation can be uniquely identified by its lamport timestamp, so we
don't really need a concept of a local timestamp. In this PR, I've
removed the concept of a local timestamp. Version vectors
(`clock::Global`) now store vectors of *lamport* timestamps.
Eliminating local timestamps reduces the memory footprint of a buffer by
four bytes per fragment, reduces the size of our `UpdateBuffer` RPC
messages, and reduces the amount of data we need to store in our
database for channel buffers. It also makes our CRDT a bit easier to
understand, IMO, because there is now only one scalar value that we
increment per replica.
It's possible I'm missing something here though. @as-cii, @nathansobo
it'd be good to get your 👀
2023-08-31 16:47:08 -07:00
Max Brunsfeld
1e60454643
Renumber protobuf fields, bump protocol version
2023-08-31 16:31:26 -07:00
Max Brunsfeld
03f0365d4d
Remove local timestamps from CRDT operations
...
Use lamport timestamps for everything.
2023-08-31 16:23:06 -07:00
KCaverly
afa59abbcd
WIP: work towards wiring up a embeddings_for_digest hashmap that is stored for all indexed files
2023-08-31 16:42:39 -04:00
Max Brunsfeld
00aae5abee
Assistant: propagate cancel action if there is no pending inline assist ( #2923 )
...
Release Notes:
- Fixed a bug where modals could not be dismissed with `escape` when
certain views were active in the workspace (preview only).
2023-08-31 11:17:09 -07:00
Max Brunsfeld
eecd4e39cc
Propagate Cancel action if there is no pending inline assist
2023-08-31 11:09:36 -07:00
KCaverly
50cfb067e7
fill embeddings with database values and skip during embeddings queue
2023-08-31 13:19:17 -04:00
Antonio Scandurra
220533ff1a
WIP
2023-08-31 18:00:57 +02:00
Antonio Scandurra
2503d54d19
Rename Sha1 to DocumentDigest
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-08-31 18:00:36 +02:00
Antonio Scandurra
3001a46f69
Reify Embedding/Sha1 structs that can be (de)serialized from SQL
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-08-31 17:55:43 +02:00
Kirill Bulatov
fe2300fdaa
Style the clear button better, add border to button constructor options
2023-08-31 18:31:21 +03:00
Kirill Bulatov
7b5974e8e9
Add LSP logs clear button
2023-08-31 18:31:21 +03:00
Antonio Scandurra
c763e728d1
Write to and read from the database in a transactional way
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-08-31 16:59:54 +02:00
Antonio Scandurra
35440be98e
Abstract away how database transactions are executed
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-08-31 16:54:11 +02:00
Kirill Bulatov
ddc6214216
Tailwind autocomplete ( #2920 )
...
Release Notes:
- Added basic Tailwind CSS autocomplete support
([#746 ](https://github.com/zed-industries/community/issues/746 )).
2023-08-31 16:55:46 +03:00
Kirill Bulatov
5731ef51cd
Fix plugin LSP adapter intefrace
2023-08-31 15:32:24 +03:00
Kirill Bulatov
e682db7101
Route completion requests through remote protocol, if needed
2023-08-31 15:22:13 +03:00
Kirill Bulatov
5bc5831032
Fix wrong assertion in the test
2023-08-31 14:31:43 +03:00
Kirill Bulatov
292af55ebc
Ensure all client LSP queries are forwarded via collab
2023-08-31 14:29:37 +03:00
Kirill Bulatov
fff385a585
Fix project tests
2023-08-31 13:01:53 +03:00
Kirill Bulatov
9e12df43d0
Post-rebase fixes
2023-08-31 11:53:46 +03:00
Julia
ff3865a4ad
Merge branch 'main' into multi-server-completions-tailwind
2023-08-30 22:58:37 -04:00
Julia
529adb95a1
Scope Tailwind in JS/TS to within string
...
In some situations outside JSX elements Tailwind will never
respond to a completion request, holding up the tsserver completions.
Only submit the request to Tailwind when we wouldn't get tsserver
completions anyway and don't submit to Tailwind when we know we won't
get Tailwind completions
Co-Authored-By: Kirill Bulatov <kirill@zed.dev >
2023-08-30 21:14:39 -04:00
Nathan Sobo
3b5ee59273
Split playground into gpui2 and storybook
2023-08-30 16:12:14 -06:00
KCaverly
7d4d6c871b
fix bug for truncation ensuring no valid inputs are sent to openai
2023-08-30 17:42:16 -04:00
Nathan Sobo
ee11be98e5
Add gpui2 crate
2023-08-30 15:00:11 -06:00
KCaverly
5abad58b0d
moved semantic index to use embeddings queue to batch and managed for atomic database writes
...
Co-authored-by: Max <max@zed.dev >
2023-08-30 16:58:45 -04:00
Nathan Sobo
746f77bf7c
Checkpoint
2023-08-30 14:40:57 -06:00
KCaverly
76ce52df4e
move queuing to embedding_queue functionality and update embedding provider to include trait items for max tokens per batch"
...
Co-authored-by: Max <max@zed.dev >
2023-08-30 16:01:28 -04:00
Nathan Sobo
1d491fcd78
Get playground rendering with backward compatible theming
2023-08-30 11:09:34 -06:00
KCaverly
9781047156
move truncation to parsing step leveraging the EmbeddingProvider trait
2023-08-30 12:13:26 -04:00
Nathan Sobo
d763946b18
Checkpoint: Working toward compatibility with themes
2023-08-30 10:11:00 -06:00
KCaverly
76caea80f7
add should_truncate to embedding providers
2023-08-30 11:58:45 -04:00
Kirill Bulatov
7e5735c8f1
Reap overly long LSP requests with a 2m timeout
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-08-30 18:41:41 +03:00
KCaverly
e377ada1a9
added token count to documents during parsing
2023-08-30 11:05:46 -04:00
Nathan Sobo
48d3e2d9b9
Move views_to_notify_if_ancestors_change to Window
2023-08-29 21:58:44 -06:00
Nathan Sobo
2e7356a53e
Store new_parents on Window instead of layout context
2023-08-29 21:43:48 -06:00
Nathan Sobo
42cd257287
Remove text style stack from LayoutContext
2023-08-29 21:33:08 -06:00
Nathan Sobo
81957c49d5
Merge remote-tracking branch 'origin' into divs
2023-08-29 21:14:14 -06:00
Conrad Irwin
d3650594c3
Fix find_{,preceding}boundary to work on buffer text
...
Before this change the bounday could mistakenly have happened on a soft
line wrap.
Also fixes interaction with inlays better.
2023-08-29 18:03:29 -07:00
Julia
e3a0252b04
Make multi-server completion requests not serial
2023-08-29 20:42:13 -04:00
Nathan Sobo
a0b6e500cf
WIP
2023-08-29 18:40:24 -06:00
Nathan Sobo
a56fab8c11
Remove unused proc macro
2023-08-29 18:30:57 -06:00
KCaverly
a7e6a65deb
reindex files in the background after they have not been edited for 10 minutes
...
Co-authored-by: Max <max@zed.dev >
2023-08-29 17:14:44 -04:00
KCaverly
4f8b95cf0d
add proper handling for open ai rate limit delays
2023-08-29 15:44:51 -04:00
Julia
0e6c91818f
Woooooops, don't notify the language server until initialized
2023-08-29 15:37:51 -04:00
Nathan Sobo
2d411303bb
Use preview server when not on stable
2023-08-29 10:07:22 -06:00
Julia
15628af04b
Style language server name in completion menu
...
Omit in buffers with one or zero running language servers with the
capability to provide completions
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-08-29 11:21:02 -04:00
Nathan Sobo
9371754942
Provide themes to subtrees via context
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-08-28 16:07:26 -06:00
Nathan Sobo
fd1633ac4b
Render a titlebar you can barely see
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-08-28 14:24:27 -06:00
Nathan Sobo
b5aedc144d
Allow layout to be called on element in any phase of its lifecyle.
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-08-28 14:23:16 -06:00
Julia
35b7787e02
Add Tailwind server to TSX
2023-08-28 15:19:16 -04:00
Julia
ded6decb29
Initial unstyled language server short name in completions
...
Co-Authored-By: Kirill Bulatov <kirill@zed.dev >
2023-08-28 11:27:45 -04:00
Nathan Sobo
5bb780073e
Relativize child layouts to their parent origin
2023-08-25 23:22:53 -06:00
Nathan Sobo
3bebfbcd50
Checkpoint
2023-08-25 23:15:58 -06:00
Nathan Sobo
8ad736da8d
WIP
2023-08-25 22:19:49 -06:00
Nathan Sobo
7cd416c63e
Always log panics
2023-08-25 21:42:18 -06:00
Nathan Sobo
147aa0f695
WIP
2023-08-25 21:41:21 -06:00
Julia
fc457d45f5
Add word_characters to language overrides & use for more things
...
Use word_characters to feed completion trigger characters as well and
also recognize kebab as a potential sub-word splitter. This is fine for
non-kebab-case languages because we'd only ever attempt to split a word
with a kebab in it in language scopes which are kebab-cased
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-08-25 18:46:30 -04:00
Nathan Sobo
cf007a3d3b
Start working on restoring button
2023-08-23 16:17:45 -06:00
Nathan Sobo
4c000379d2
Click events, children
2023-08-23 16:02:56 -06:00
Nathan Sobo
8e3b23e510
Rename Window::mouse_position to last_mouse_position
...
We want to encourage people to use WindowContext::mouse_position, which
requests the position from the platform.
Co-Authored-By: Conrad Irwin <conrad@zed.dev >
2023-08-23 13:28:22 -06:00
Nathan Sobo
684db11afd
Use platform API to request mouse position
...
Co-Authored-By: Conrad Irwin <conrad@zed.dev >
2023-08-23 13:10:41 -06:00
Nathan Sobo
5996b6b46b
Use RefinementCascade to compose pressability and hoverability
...
Co-Authored-By: Conrad Irwin <conrad@zed.dev >
2023-08-23 12:18:12 -06:00
Nathan Sobo
569d99a5a1
Add hover styling support
2023-08-23 09:08:05 -06:00
Julia
a394aaa524
Add Tailwind server to JS/TS
2023-08-23 00:11:15 -04:00
Julia
68408f3838
Add VSCode CSS language server & add Tailwind to .css files
2023-08-22 23:50:40 -04:00
Julia
affb73d651
Only generate workspace/configuration for relevant adapter
2023-08-22 23:36:04 -04:00
Kirill Bulatov
814896de3f
Reenable html, remove emmet due to the lack of the code
2023-08-22 12:51:14 +03:00
Kirill Bulatov
a35b3f39c5
Expand word characters for html and css
2023-08-22 12:41:59 +03:00
Piotr Osiewicz
007d1b09ac
Z 2819 ( #2872 )
...
This PR adds new config option to language config called
`word_boundaries` that controls which characters should be recognised as
word boundary for a given language. This will improve our UX for
languages such as PHP and Tailwind.
Release Notes:
- Improved completions for PHP
[#1820 ](https://github.com/zed-industries/community/issues/1820 )
---------
Co-authored-by: Julia Risley <julia@zed.dev >
2023-08-22 12:23:30 +03:00
Julia
c842e87079
Use updated lsp-types fork branch
2023-08-18 11:57:19 -04:00
Julia
a979e32127
Utilize LSP completion itemDefaults a bit
...
Tailwind likes to throw a lot of completion data at us, this gets it to
send less. Previously it would respond to a completion with 2.5 MB JSON
blob, now it is more like 0.8 MB.
Relies on a local copy of lsp-types with the `itemDefaults` field added.
I don't have write perms to push to our fork of the crate atm, sorry :)
2023-08-17 21:57:39 -04:00
Kirill Bulatov
4f0fa21c04
Provide more data to tailwind langserver
...
Tailwind needs user languages and language-to-language-id mappings to
start providing completions for those languages.
And also it has emmet completions disabled by default, enable them.
2023-08-17 16:14:55 +03:00
Julia
e54f16f372
Register initial request handlers before launching server
2023-08-16 21:25:17 -04:00
Julia
8839b07a25
Add broken Tailwind language server
2023-08-16 11:53:05 -04:00
Julia
40ce099780
Use originating language server to resolve additional completion edits
2023-08-15 16:34:15 -04:00
Julia
7a67ec5743
Add support for querying multiple language servers for completions
2023-08-15 12:48:30 -04:00