fix: Fixed adding tabs to essentials with a different container, b=(closes #8019), c=compact-mode, tabs

fix: use list-style rather than menu for appMenu items

src/browser/app/profile/zen-browser.js

@@ -204,7 +204,6 @@ pref('zen.startup.smooth-scroll-in-tabs', true);
 pref('zen.workspaces.hide-default-container-indicator', true);
 pref('zen.workspaces.force-container-workspace', false);
 pref('zen.workspaces.open-new-tab-if-last-unpinned-tab-is-closed', false);
-pref('zen.workspaces.show-workspace-indicator', true);
 pref('zen.workspaces.swipe-actions', true);
 pref('zen.workspaces.wrap-around-navigation', true);
 pref('zen.workspaces.natural-scroll', false);
@@ -293,6 +292,8 @@ pref('image.jxl.enabled', true, locked);
 pref("svg.context-properties.content.enabled", true);
 pref("image.avif.enabled", true, locked);
 
+pref("media.eme.enabled", true);
+
 // Smooth scrolling
 #ifndef XP_MACOSX
 pref("apz.overscroll.enabled", true);

src/browser/components/urlbar/UrlbarInput-sys-mjs.patch

@@ -1,5 +1,5 @@
 diff --git a/browser/components/urlbar/UrlbarInput.sys.mjs b/browser/components/urlbar/UrlbarInput.sys.mjs
-index 4b69136aa31bfef3a1d3b57ad0c75fe07fa26be0..8d1a80e97fa711352d4b725f2d299a073dbae4db 100644
+index 4b69136aa31bfef3a1d3b57ad0c75fe07fa26be0..f001ffe262b26389c5af68e29d0785500969c344 100644
 --- a/browser/components/urlbar/UrlbarInput.sys.mjs
 +++ b/browser/components/urlbar/UrlbarInput.sys.mjs
 @@ -68,6 +68,13 @@ XPCOMUtils.defineLazyPreferenceGetter(
@@ -93,7 +93,7 @@ index 4b69136aa31bfef3a1d3b57ad0c75fe07fa26be0..8d1a80e97fa711352d4b725f2d299a07
 +    if (lazy.ZEN_URLBAR_BEHAVIOR == 'float' || (lazy.ZEN_URLBAR_BEHAVIOR == 'floating-on-type' && !this.focusedViaMousedown)) {
 +      this.setAttribute("zen-floating-urlbar", "true");
 +      // Divide the window by 2 and subtract the urlbar height to get the top
-+      this.textbox.style.setProperty("--zen-urlbar-top", `${(this.window.innerHeight / 6)}px`);
++      this.textbox.style.setProperty("--zen-urlbar-top", `${(this.window.innerHeight / 4)}px`);
 +    } else {
 +      this.removeAttribute("zen-floating-urlbar");
 +    }

src/browser/themes/shared/zen-icons/icons.css

@@ -967,23 +967,23 @@ menuitem[id='placesContext_showAllBookmarks'],
 }
 
 #appMenuRecentlyClosedTabs {
-  --menu-image: url('container-tab.svg');
+  list-style-image: url('container-tab.svg') !important;
 }
 
 #appMenuClearRecentHistory {
-  --menu-image: url('edit-delete.svg');
+  list-style-image: url('edit-delete.svg') !important;
 }
 
 #appMenuRecentlyClosedWindows {
-  --menu-image: url('window.svg');
+  list-style-image: url('window.svg') !important;
 }
 
 #appMenuSearchHistory {
-  --menu-image: url('search-glass.svg');
+  list-style-image: url('search-glass.svg') !important;
 }
 
 #PanelUI-historyMore {
-  --menu-image: url('manage.svg');
+  list-style-image: url('manage.svg') !important;
 }
 
 menuitem[id='placesContext_new:bookmark'],

src/zen/compact-mode/ZenCompactMode.mjs

@@ -35,11 +35,12 @@ var gZenCompactModeManager = {
     lazyCompactMode.mainAppWrapper.removeAttribute('zen-compact-mode');
     this._wasInCompactMode = isCompactMode;
 
-    this.addMouseActions();
     this.addContextMenu();
   },
 
   init() {
+    this.addMouseActions();
+
     Services.prefs.addObserver('zen.tabs.vertical.right-side', this._updateSidebarIsOnRight.bind(this));
 
     gZenUIManager.addPopupTrackingAttribute(this.sidebar);
@@ -412,19 +413,33 @@ var gZenCompactModeManager = {
   },
 
   addMouseActions() {
+    gURLBar.textbox.addEventListener('mouseenter', (event) => {
+      if (!gZenVerticalTabsManager._hasSetSingleToolbar) {
+        return;
+      }
+      if (event.target.closest('#urlbar[zen-floating-urlbar]')) {
+        // Ignore sidebar mouse enter if the urlbar is floating
+        this.clearFlashTimeout('has-hover' + gZenVerticalTabsManager._hasSetSingleToolbar);
+        window.requestAnimationFrame(() => {
+          this.sidebar.removeAttribute('zen-has-hover');
+        });
+        this._hasHoveredUrlbar = true;
+        return;
+      }
+    });
+
     for (let i = 0; i < this.hoverableElements.length; i++) {
       let target = this.hoverableElements[i].element;
       const onEnter = (event) => {
-        if (event.type === 'mouseenter' && !event.target.matches(':hover')) return;
-        // Dont register the hover if the urlbar is floating and we are hovering over it
-        this.clearFlashTimeout('has-hover' + target.id);
-        if (
-          event.target.closest('#urlbar[zen-floating-urlbar]') ||
-          this.sidebar.getAttribute('supress-primary-adjustment') === 'true'
-        ) {
-          return;
-        }
-        window.requestAnimationFrame(() => target.setAttribute('zen-has-hover', 'true'));
+        setTimeout(() => {
+          if (event.type === 'mouseenter' && !event.target.matches(':hover')) return;
+          // Dont register the hover if the urlbar is floating and we are hovering over it
+          this.clearFlashTimeout('has-hover' + target.id);
+          if (this.sidebar.getAttribute('supress-primary-adjustment') === 'true' || this._hasHoveredUrlbar) {
+            return;
+          }
+          window.requestAnimationFrame(() => target.setAttribute('zen-has-hover', 'true'));
+        }, 0);
       };
 
       const onLeave = (event) => {
@@ -452,10 +467,14 @@ var gZenCompactModeManager = {
         }
 
         if (
-          this.hoverableElements[i].keepHoverDuration &&
-          !event.target.querySelector('#urlbar[zen-floating-urlbar]') &&
-          !(this.sidebar.getAttribute('supress-primary-adjustment') === 'true')
+          event.explicitOriginalTarget.closest('#urlbar[zen-floating-urlbar]') ||
+          this.sidebar.getAttribute('supress-primary-adjustment') === 'true' ||
+          this._hasHoveredUrlbar
         ) {
+          return;
+        }
+
+        if (this.hoverableElements[i].keepHoverDuration) {
           this.flashElement(target, this.hoverableElements[i].keepHoverDuration, 'has-hover' + target.id, 'zen-has-hover');
         } else {
           this._removeHoverFrames[target.id] = window.requestAnimationFrame(() => target.removeAttribute('zen-has-hover'));
@@ -493,6 +512,12 @@ var gZenCompactModeManager = {
         );
       }
     });
+
+    gURLBar.textbox.addEventListener('mouseleave', (event) => {
+      setTimeout(() => {
+        delete this._hasHoveredUrlbar;
+      }, 0);
+    });
   },
 
   _getCrossedEdge(posX, posY, element = document.documentElement, maxDistance = 10) {

src/zen/compact-mode/zen-compact-mode.css

@@ -43,7 +43,7 @@
       }
 
       #navigator-toolbox {
-        --zen-toolbox-max-width: 48px !important;
+        --zen-toolbox-max-width: 66px !important;
         --zen-compact-float: var(--zen-element-separation);
 
         /* Initial padding for when we are animating */
@@ -163,7 +163,7 @@
       #navigator-toolbox:has(.tabbrowser-tab:active),
       &[zen-renaming-tab='true'] #navigator-toolbox,
       #navigator-toolbox:has(
-          *:is([panelopen='true'], [open='true'], #urlbar:focus-within):not(#urlbar[zen-floating-urlbar='true']):not(tab):not(.zen-compact-mode-ignore)
+          *:is([panelopen='true'], [open='true'], #urlbar:focus-within, [breakout-extend='true']):not(#urlbar[zen-floating-urlbar='true']):not(tab):not(.zen-compact-mode-ignore)
         ) {
         &:not([animate='true']) {
           --zen-compact-mode-func: linear(

src/zen/tabs/ZenPinnedTabManager.mjs

@@ -665,6 +665,8 @@
         } else {
           gBrowser.pinTab(tab);
         }
+        tab.setAttribute('zenDefaultUserContextId', true);
+        ZenWorkspaces.switchTabIfNeeded(tab);
         this._onTabMove(tab);
         this.onTabIconChanged(tab);
 

src/zen/workspaces/ZenGradientGenerator.mjs

@@ -380,12 +380,15 @@
         <hbox class="zen-theme-picker-custom-list-item">
           <html:div class="zen-theme-picker-dot custom"></html:div>
           <label class="zen-theme-picker-custom-list-item-label"></label>
-          <toolbarbutton class="zen-theme-picker-custom-list-item-remove toolbarbutton-1" oncommand="gZenThemePicker.removeCustomColor(event);"></toolbarbutton>
+          <toolbarbutton class="zen-theme-picker-custom-list-item-remove toolbarbutton-1"></toolbarbutton>
         </hbox>
       `);
       listItems.querySelector('.zen-theme-picker-custom-list-item').setAttribute('data-color', color);
       listItems.querySelector('.zen-theme-picker-dot').style.setProperty('--zen-theme-picker-dot-color', color);
       listItems.querySelector('.zen-theme-picker-custom-list-item-label').textContent = color;
+      listItems
+        .querySelector('.zen-theme-picker-custom-list-item-remove')
+        .addEventListener('command', this.removeCustomColor.bind(this));
 
       this.customColorList.appendChild(listItems);
     }

src/zen/workspaces/ZenWorkspaces.mjs

@@ -799,10 +799,12 @@ var ZenWorkspaces = new (class extends ZenMultiWindowFeature {
     const currentTab = gBrowser.selectedTab;
     let showed = false;
     if (this._tabToRemoveForEmpty) {
-      this.selectEmptyTab();
-      gBrowser.removeTab(this._tabToRemoveForEmpty);
+      if (gZenVerticalTabsManager._canReplaceNewTab) {
+        this.selectEmptyTab();
+        gBrowser.removeTab(this._tabToRemoveForEmpty);
+        showed = true;
+      }
       delete this._tabToRemoveForEmpty;
-      showed = true;
     } else {
       const currentTabURL = currentTab.linkedBrowser?.currentURI?.spec;
       // Check for empty tab being restored

src/zen/workspaces/zen-workspaces.css

@@ -507,12 +507,6 @@
   }
 }
 
-@media not -moz-pref('zen.workspaces.show-workspace-indicator') {
-  #zen-current-workspace-indicator-container {
-    display: none !important;
-  }
-}
-
 #zen-current-workspace-indicator-container[hidden='true'] {
   display: none !important;
 }

surfer.json

@@ -19,7 +19,7 @@
       "brandShortName": "Zen",
       "brandFullName": "Zen Browser",
       "release": {
-        "displayVersion": "1.12b",
+        "displayVersion": "1.12.1b",
         "github": {
           "repo": "zen-browser/desktop"
         },
@@ -39,7 +39,7 @@
       "brandShortName": "Twilight",
       "brandFullName": "Zen Twilight",
       "release": {
-        "displayVersion": "1.12t",
+        "displayVersion": "1.12.1t",
         "github": {
           "repo": "zen-browser/desktop"
         }