fix: Fixed window controls not being accessible on fullscreen when element separation is 0, b=(no-bug), c=tabs

remove --cask flag from mac install instructions as it isn't necessary

README.md

@@ -85,7 +85,7 @@ winget install --id Zen-Team.Zen-Browser
 You can also install Zen using Homebrew:
 
 ```
-brew install --cask zen-browser
+brew install zen-browser
 ```
 
 #### Linux
@@ -118,11 +118,11 @@ To upgrade the browser to a newer version, use the embedded update functionality
 
 ## 👨‍💻 Development and Contributing
 
-Some components used by @zen-browser as an attempt to make firefox forks a better place, and for other to enjoy the beauty of OSS. You can find them [here](https://github.com/zen-browser/desktop/tree/dev/src/browser/base/zen-components).
+Some components used by @zen-browser as an attempt to make firefox forks a better place, and for other to enjoy the beauty of OSS. You can find them [here](https://github.com/zen-browser/desktop/tree/dev/src/zen).
 
 #### `Run Locally`
 
-In order to download and run Zen locally, please follow [these instructions](https://docs.zen-browser.app/building).
+In order to download and run Zen locally, please follow [these instructions](https://docs.zen-browser.app/guides/building).
 
 #### `Special Thanks`
 

src/browser/app/profile/zen-browser.js

@@ -475,4 +475,5 @@ pref("layers.gpu-process.enabled", true);
 
 // Picture-in-picture
 pref("media.videocontrols.picture-in-picture.video-toggle.enabled", true);
-pref("media.videocontrols.picture-in-picture.enable-when-switching-tabs.enabled", true);
+// TODO: Enable once we have a proper settings page
+pref("media.videocontrols.picture-in-picture.enable-when-switching-tabs.enabled", false);

src/browser/components/customizableui/CustomizableUI-sys-mjs.patch

@@ -1,5 +1,5 @@
 diff --git a/browser/components/customizableui/CustomizableUI.sys.mjs b/browser/components/customizableui/CustomizableUI.sys.mjs
-index 9392b42a1de7310719a6cc8aaf11bd857e8fa69a..24dc9acd733ae401f8cdfb2351a7275d16ee46c8 100644
+index 9392b42a1de7310719a6cc8aaf11bd857e8fa69a..1c5b80678fc3a4d17b0632a765b8182d88986bcc 100644
 --- a/browser/components/customizableui/CustomizableUI.sys.mjs
 +++ b/browser/components/customizableui/CustomizableUI.sys.mjs
 @@ -13,6 +13,7 @@ ChromeUtils.defineESModuleGetters(lazy, {
@@ -188,13 +188,12 @@ index 9392b42a1de7310719a6cc8aaf11bd857e8fa69a..24dc9acd733ae401f8cdfb2351a7275d
        }
        child.removeAttribute("cui-anchorid");
        child.removeAttribute("overflowedItem");
-@@ -7186,6 +7190,9 @@ class OverflowableToolbar {
-    * @param {MouseEvent} aEvent the click event.
-    */
-   #onClickDefaultListButton(aEvent) {
-+    if (aEvent.view.gZenVerticalTabsManager._hasSetSingleToolbar && this.#toolbar.id == 'nav-bar') {
-+      return;
-+    }
-     if (this.#defaultListButton.open) {
-       this.#defaultListButton.open = false;
-       lazy.PanelMultiView.hidePopup(this.#defaultListPanel);
+@@ -7369,7 +7373,7 @@ class OverflowableToolbar {
+         break;
+       }
+       case "mousedown": {
+-        if (aEvent.button != 0) {
++        if (aEvent.button != 0 || this.#toolbar.id == "zen-sidebar-top-buttons") { // Fix https://github.com/zen-browser/desktop/issues/7718
+           break;
+         }
+         if (aEvent.target == this.#defaultListButton) {

src/browser/components/preferences/zen-settings.js

@@ -1024,4 +1024,9 @@ Preferences.addAll([
     type: 'bool',
     default: true,
   },
+  {
+    id: 'media.videocontrols.picture-in-picture.enabled',
+    type: 'bool',
+    default: true,
+  },
 ]);

src/browser/themes/windows/browser-css.patch

@@ -1,8 +1,8 @@
 diff --git a/browser/themes/windows/browser.css b/browser/themes/windows/browser.css
-index 9af78803f0005a2b89e1c73f52153ed4d9e3154a..b63dc3d050144f048ac6a326acd57cc85fa8a3a7 100644
+index 9af78803f0005a2b89e1c73f52153ed4d9e3154a..f5b21a09347f5890da3eef0efa38a66195c8e418 100644
 --- a/browser/themes/windows/browser.css
 +++ b/browser/themes/windows/browser.css
-@@ -40,14 +40,13 @@
+@@ -40,13 +40,12 @@
           * override these on the tabs toolbar because the accent color is
           * arbitrary, so the hardcoded colors from browser-custom-colors might
           * not provide sufficient contrast. */
@@ -12,9 +12,8 @@ index 9af78803f0005a2b89e1c73f52153ed4d9e3154a..b63dc3d050144f048ac6a326acd57cc8
        }
      }
  
-     &[sizemode="normal"] #navigator-toolbox {
--      border-top: .5px solid ActiveBorder;
-+      /* border-top: .5px solid ActiveBorder; Zen: Remove annoying top border, dont remove */
+-    &[sizemode="normal"] #navigator-toolbox {
++    &[sizemode="normal"] #browser {
+       border-top: .5px solid ActiveBorder;
        &:-moz-window-inactive {
          border-top-color: InactiveBorder;
-       }

src/zen/tabs/zen-tabs/vertical-tabs-topbar.inc.css

@@ -16,7 +16,8 @@ z-index: 1;
 
   &:not([zen-has-hover='true']):not([has-popup-menu]):not(:focus-within):not(:has(*:is([panelopen='true'], [open='true']))) {
     transition-delay: 0.2s;
-    height: calc(var(--zen-element-separation) + 0.5px);
+    /* In order to still use it on fullscreen, even if it's 0px, add .1px (almost invisible) */
+    height: calc(var(--zen-element-separation) + 0.1px);
     overflow: hidden;
     opacity: 0;
     & > * {

src/zen/workspaces/ZenWorkspaces.mjs

@@ -110,9 +110,9 @@ var ZenWorkspaces = new (class extends ZenMultiWindowFeature {
     );
   }
 
-  selectEmptyTab(newTabTarget = null) {
+  selectEmptyTab(newTabTarget = null, selectURLBar = true) {
     if (this._emptyTab && gZenVerticalTabsManager._canReplaceNewTab) {
-      if (gBrowser.selectedTab !== this._emptyTab) {
+      if (gBrowser.selectedTab !== this._emptyTab && selectURLBar) {
         window.addEventListener(
           'TabSelect',
           () => {
@@ -1745,7 +1745,7 @@ var ZenWorkspaces = new (class extends ZenMultiWindowFeature {
       !onInit
     ) {
       prevTabUsed = gBrowser.selectedTab;
-      this.selectEmptyTab();
+      this.selectEmptyTab(null, false);
     }
     for (const tab of hiddenTabs) {
       gBrowser.hideTab(tab, undefined, true);

surfer.json

@@ -19,7 +19,7 @@
       "brandShortName": "Zen",
       "brandFullName": "Zen Browser",
       "release": {
-        "displayVersion": "1.11.4b",
+        "displayVersion": "1.11.5b",
         "github": {
           "repo": "zen-browser/desktop"
         },
@@ -39,7 +39,7 @@
       "brandShortName": "Twilight",
       "brandFullName": "Zen Twilight",
       "release": {
-        "displayVersion": "1.11.4t",
+        "displayVersion": "1.11.5t",
         "github": {
           "repo": "zen-browser/desktop"
         }