7a37dd9433
Fix bundled file persistence by introducing SerializationMode enum Closes: #38094 What's the issue? Opening bundled files like Default Key Bindings (zed://settings/keymap-default.json) was causing SQLite foreign key constraint errors. The editor was trying to save state for these read-only assets just like regular files, but since bundled files don't have database entries, the foreign key constraint would fail. The fix Replaced the boolean serialize_dirty_buffers flag with a type-safe SerializationMode enum: ```rust pub enum SerializationMode { Enabled, // Regular files persist across sessions Disabled, // Bundled files don't persist } ``` This prevents serialization at the source: workspace_id() returns None for disabled editors, serialize() bails early, and should_serialize() returns false. When opening bundled files, we set the mode to Disabled from the start, so they're treated as transient views that never interact with the persistence layer. Changes - editor.rs: Added SerializationMode enum and updated serialization methods to respect it - items.rs: Guarded should_serialize() to prevent disabled editors from being serialized - zed.rs: Set SerializationMode::Disabled in open_bundled_file() Result Bundled files open cleanly without SQLite errors and don't persist across workspace reloads (expected behavior). Regular file persistence remains unaffected. Release Notes: Fixed SQLite foreign key constraint errors when opening bundled files like Default Key Bindings. --------- Co-authored-by: MrSubidubi <finn@zed.dev>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.