Compare commits

...

5 Commits

Author SHA1 Message Date
Joseph T Lyons
a4fdbe279c zed 0.145.1 2024-07-19 15:12:32 -04:00
gcp-cherry-pick-bot[bot]
ab3e296920 Fix tooltips sometimes continuously displaying when the button is selected (cherry-pick #14832) (#14835)
Cherry-picked Fix tooltips sometimes continuously displaying when the
button is selected (#14832)

Release Notes:

- Fixed sometime tooltip will continuously display when the button is
selected.

---

@mrnugget The #13857 This change has led into a bug, the selected item
before tooltip will continuous display if there are no other tooltips.




https://github.com/user-attachments/assets/06b4a9a4-dede-4c18-b020-e20b6090341f

Co-authored-by: Jason Lee <huacnlee@gmail.com>
2024-07-19 13:06:14 -06:00
Thorsten Ball
3fd127c2f6 go: Fix quoting of targeting expression for non-fish shells (#14821)
This fixes #14818.

The change in #14055 broke the tasks in `zsh` (and I suspect in `bash`,
`sh` too), because what was executed was NOT

    $ go test . -run '^TestThis$'

but instead this:

    $ go test . -run \'^TestThis$\'

And in `zsh` this means that `'` is part of the argument passed to `go`,
which means the targeting string is wrong.

Since the problem in `fish` doesn't seem to be the `^` but the `$`, we
can only escape that, which makes the escaped string work in `zsh` and
`fish` and `bash` (in which I've tested this change here)

Release Notes:

- go: Fix running single tests by changing the quoted expression in the
`go test` command to work again in `bash`, `zsh`, etc.
([#14818](https://github.com/zed-industries/zed/issues/14818))
2024-07-19 14:54:52 -04:00
Joseph T Lyons
29b5ddfaf3 Add PR author to release notes scraper script 2024-07-17 13:21:11 -04:00
Joseph T Lyons
fb45c30c1d v0.145.x preview 2024-07-17 11:29:05 -04:00
6 changed files with 13 additions and 6 deletions

2
Cargo.lock generated
View File

@@ -13628,7 +13628,7 @@ dependencies = [
[[package]]
name = "zed"
version = "0.145.0"
version = "0.145.1"
dependencies = [
"activity_indicator",
"anyhow",

View File

@@ -1866,6 +1866,11 @@ impl Interactivity {
});
}
// Ensure to remove active tooltip if tooltip builder is none
if self.tooltip_builder.is_none() {
element_state.active_tooltip.take();
}
if let Some(tooltip_builder) = self.tooltip_builder.take() {
let tooltip_is_hoverable = tooltip_builder.hoverable;
let active_tooltip = element_state

View File

@@ -518,7 +518,7 @@ impl ContextProvider for GoContextProvider {
"test".into(),
GO_PACKAGE_TASK_VARIABLE.template_value(),
"-run".into(),
format!("'^{}$'", VariableName::Symbol.template_value(),),
format!("^{}\\$", VariableName::Symbol.template_value(),),
],
tags: vec!["go-test".to_owned()],
..TaskTemplate::default()
@@ -549,7 +549,7 @@ impl ContextProvider for GoContextProvider {
"-v".into(),
"-run".into(),
format!(
"'^{}$/^{}$'",
"^{}\\$/^{}\\$",
VariableName::Symbol.template_value(),
GO_SUBTEST_NAME_TASK_VARIABLE.template_value(),
),
@@ -570,7 +570,7 @@ impl ContextProvider for GoContextProvider {
"-benchmem".into(),
"-run=^$".into(),
"-bench".into(),
format!("'^{}$'", VariableName::Symbol.template_value()),
format!("^{}\\$", VariableName::Symbol.template_value()),
],
tags: vec!["go-benchmark".to_owned()],
..TaskTemplate::default()

View File

@@ -2,7 +2,7 @@
description = "The fast, collaborative code editor."
edition = "2021"
name = "zed"
version = "0.145.0"
version = "0.145.1"
publish = false
license = "GPL-3.0-or-later"
authors = ["Zed Team <hi@zed.dev>"]

View File

@@ -1 +1 @@
dev
preview

View File

@@ -59,6 +59,7 @@ async function main() {
const releaseNotesHeader = /^\s*Release Notes:(.+)/ims;
let releaseNotes = pullRequest.body || "";
let contributor = pullRequest.user.login || "";
const captures = releaseNotesHeader.exec(releaseNotes);
const notes = captures ? captures[1] : "MISSING";
const skippableNoteRegex = /^\s*-?\s*n\/?a\s*/ims;
@@ -68,6 +69,7 @@ async function main() {
}
console.log("*", pullRequest.title);
console.log(" PR URL: ", webURL);
console.log(" Author: ", contributor);
// If the pull request contains a 'closes' line, print the closed issue.
const fixesMatch = (pullRequest.body || "").match(FIXES_REGEX);