wait for workspace window to show

.factory/prompts/docs-automation/phase2-explore.md

@@ -1,55 +0,0 @@
-# Phase 2: Explore Repository
-
-You are analyzing a codebase to understand its structure before reviewing documentation impact.
-
-## Objective
-Produce a structured overview of the repository to inform subsequent documentation analysis.
-
-## Instructions
-
-1. **Identify Primary Languages and Frameworks**
-   - Scan for Cargo.toml, package.json, or other manifest files
-   - Note the primary language(s) and key dependencies
-
-2. **Map Documentation Structure**
-   - This project uses **mdBook** (https://rust-lang.github.io/mdBook/)
-   - Documentation is in `docs/src/`
-   - Table of contents: `docs/src/SUMMARY.md` (mdBook format: https://rust-lang.github.io/mdBook/format/summary.html)
-   - Style guide: `docs/.rules`
-   - Agent guidelines: `docs/AGENTS.md`
-   - Formatting: Prettier (config in `docs/.prettierrc`)
-
-3. **Identify Build and Tooling**
-   - Note build systems (cargo, npm, etc.)
-   - Identify documentation tooling (mdbook, etc.)
-
-4. **Output Format**
-Produce a JSON summary:
-
-```json
-{
-  "primary_language": "Rust",
-  "frameworks": ["GPUI"],
-  "documentation": {
-    "system": "mdBook",
-    "location": "docs/src/",
-    "toc_file": "docs/src/SUMMARY.md",
-    "toc_format": "https://rust-lang.github.io/mdBook/format/summary.html",
-    "style_guide": "docs/.rules",
-    "agent_guidelines": "docs/AGENTS.md",
-    "formatter": "prettier",
-    "formatter_config": "docs/.prettierrc",
-    "custom_preprocessor": "docs_preprocessor (handles {#kb action::Name} syntax)"
-  },
-  "key_directories": {
-    "source": "crates/",
-    "docs": "docs/src/",
-    "extensions": "extensions/"
-  }
-}
-```
-
-## Constraints
-- Read-only: Do not modify any files
-- Focus on structure, not content details
-- Complete within 2 minutes

.factory/prompts/docs-automation/phase3-analyze.md

@@ -1,57 +0,0 @@
-# Phase 3: Analyze Changes
-
-You are analyzing code changes to understand their nature and scope.
-
-## Objective
-Produce a clear, neutral summary of what changed in the codebase.
-
-## Input
-You will receive:
-- List of changed files from the triggering commit/PR
-- Repository structure from Phase 2
-
-## Instructions
-
-1. **Categorize Changed Files**
-   - Source code (which crates/modules)
-   - Configuration
-   - Tests
-   - Documentation (already existing)
-   - Other
-
-2. **Analyze Each Change**
-   - Review diffs for files likely to impact documentation
-   - Focus on: public APIs, settings, keybindings, commands, user-visible behavior
-
-3. **Identify What Did NOT Change**
-   - Note stable interfaces or behaviors
-   - Important for avoiding unnecessary documentation updates
-
-4. **Output Format**
-Produce a markdown summary:
-
-```markdown
-## Change Analysis
-
-### Changed Files Summary
-| Category | Files | Impact Level |
-| --- | --- | --- |
-| Source - [crate] | file1.rs, file2.rs | High/Medium/Low |
-| Settings | settings.json | Medium |
-| Tests | test_*.rs | None |
-
-### Behavioral Changes
-- **[Feature/Area]**: Description of what changed from user perspective
-- **[Feature/Area]**: Description...
-
-### Unchanged Areas
-- [Area]: Confirmed no changes to [specific behavior]
-
-### Files Requiring Deeper Review
-- `path/to/file.rs`: Reason for deeper review
-```
-
-## Constraints
-- Read-only: Do not modify any files
-- Neutral tone: Describe what changed, not whether it's good/bad
-- Do not propose documentation changes yet

.factory/prompts/docs-automation/phase4-plan.md

@@ -1,76 +0,0 @@
-# Phase 4: Plan Documentation Impact
-
-You are determining whether and how documentation should be updated based on code changes.
-
-## Objective
-Produce a structured documentation plan that will guide Phase 5 execution.
-
-## Documentation System
-This is an **mdBook** site (https://rust-lang.github.io/mdBook/):
-- `docs/src/SUMMARY.md` defines book structure per https://rust-lang.github.io/mdBook/format/summary.html
-- If adding new pages, they MUST be added to SUMMARY.md
-- Use `{#kb action::ActionName}` syntax for keybindings (custom preprocessor expands these)
-- Prettier formatting (80 char width) will be applied automatically
-
-## Input
-You will receive:
-- Change analysis from Phase 3
-- Repository structure from Phase 2
-- Documentation guidelines from `docs/AGENTS.md`
-
-## Instructions
-
-1. **Review AGENTS.md**
-   - Load and apply all rules from `docs/AGENTS.md`
-   - Respect scope boundaries (in-scope vs out-of-scope)
-
-2. **Evaluate Documentation Impact**
-   For each behavioral change from Phase 3:
-   - Does existing documentation cover this area?
-   - Is the documentation now inaccurate or incomplete?
-   - Classify per AGENTS.md "Change Classification" section
-
-3. **Identify Specific Updates**
-   For each required update:
-   - Exact file path
-   - Specific section or heading
-   - Type of change (update existing, add new, deprecate)
-   - Description of the change
-
-4. **Flag Uncertainty**
-   Explicitly mark:
-   - Assumptions you're making
-   - Areas where human confirmation is needed
-   - Ambiguous requirements
-
-5. **Output Format**
-Use the exact format specified in `docs/AGENTS.md` Phase 4 section:
-
-```markdown
-## Documentation Impact Assessment
-
-### Summary
-Brief description of code changes analyzed.
-
-### Documentation Updates Required: [Yes/No]
-
-### Planned Changes
-
-#### 1. [File Path]
-- **Section**: [Section name or "New section"]
-- **Change Type**: [Update/Add/Deprecate]
-- **Reason**: Why this change is needed
-- **Description**: What will be added/modified
-
-### Uncertainty Flags
-- [ ] [Description of any assumptions or areas needing confirmation]
-
-### No Changes Needed
-- [List files reviewed but not requiring updates, with brief reason]
-```
-
-## Constraints
-- Read-only: Do not modify any files
-- Conservative: When uncertain, flag for human review rather than planning changes
-- Scoped: Only plan changes that trace directly to code changes from Phase 3
-- No scope expansion: Do not plan "improvements" unrelated to triggering changes

.factory/prompts/docs-automation/phase5-apply.md

@@ -1,67 +0,0 @@
-# Phase 5: Apply Documentation Plan
-
-You are executing a pre-approved documentation plan for an **mdBook** documentation site.
-
-## Objective
-Implement exactly the changes specified in the documentation plan from Phase 4.
-
-## Documentation System
-- **mdBook**: https://rust-lang.github.io/mdBook/
-- **SUMMARY.md**: Follows mdBook format (https://rust-lang.github.io/mdBook/format/summary.html)
-- **Prettier**: Will be run automatically after this phase (80 char line width)
-- **Custom preprocessor**: Use `{#kb action::ActionName}` for keybindings instead of hardcoding
-
-## Input
-You will receive:
-- Documentation plan from Phase 4
-- Documentation guidelines from `docs/AGENTS.md`
-- Style rules from `docs/.rules`
-
-## Instructions
-
-1. **Validate Plan**
-   - Confirm all planned files are within scope per AGENTS.md
-   - Verify no out-of-scope files are targeted
-
-2. **Execute Each Planned Change**
-   For each item in "Planned Changes":
-   - Navigate to the specified file
-   - Locate the specified section
-   - Apply the described change
-   - Follow style rules from `docs/.rules`
-
-3. **Style Compliance**
-   Every edit must follow `docs/.rules`:
-   - Second person, present tense
-   - No hedging words ("simply", "just", "easily")
-   - Proper keybinding format (`Cmd+Shift+P`)
-   - Settings Editor first, JSON second
-   - Correct terminology (folder not directory, etc.)
-
-4. **Preserve Context**
-   - Maintain surrounding content structure
-   - Keep consistent heading levels
-   - Preserve existing cross-references
-
-## Constraints
-- Execute ONLY changes listed in the plan
-- Do not discover new documentation targets
-- Do not make stylistic improvements outside planned sections
-- Do not expand scope beyond what Phase 4 specified
-- If a planned change cannot be applied (file missing, section not found), skip and note it
-
-## Output
-After applying changes, output a summary:
-
-```markdown
-## Applied Changes
-
-### Successfully Applied
-- `path/to/file.md`: [Brief description of change]
-
-### Skipped (Could Not Apply)
-- `path/to/file.md`: [Reason - e.g., "Section not found"]
-
-### Warnings
-- [Any issues encountered during application]
-```

.factory/prompts/docs-automation/phase6-summarize.md

@@ -1,54 +0,0 @@
-# Phase 6: Summarize Changes
-
-You are generating a summary of documentation updates for PR review.
-
-## Objective
-Create a clear, reviewable summary of all documentation changes made.
-
-## Input
-You will receive:
-- Applied changes report from Phase 5
-- Original change analysis from Phase 3
-- Git diff of documentation changes
-
-## Instructions
-
-1. **Gather Change Information**
-   - List all modified documentation files
-   - Identify the corresponding code changes that triggered each update
-
-2. **Generate Summary**
-   Use the format specified in `docs/AGENTS.md` Phase 6 section:
-
-```markdown
-## Documentation Update Summary
-
-### Changes Made
-| File | Change | Related Code |
-| --- | --- | --- |
-| docs/src/path.md | Brief description | PR #123 or commit SHA |
-
-### Rationale
-Brief explanation of why these updates were made, linking back to the triggering code changes.
-
-### Review Notes
-- Items reviewers should pay special attention to
-- Any uncertainty flags from Phase 4 that were addressed
-- Assumptions made during documentation
-```
-
-3. **Add Context for Reviewers**
-   - Highlight any changes that might be controversial
-   - Note if any planned changes were skipped and why
-   - Flag areas where reviewer expertise is especially needed
-
-## Output Format
-The summary should be suitable for:
-- PR description body
-- Commit message (condensed version)
-- Team communication
-
-## Constraints
-- Read-only (documentation changes already applied in Phase 5)
-- Factual: Describe what was done, not justify why it's good
-- Complete: Account for all changes, including skipped items

.factory/prompts/docs-automation/phase7-commit.md

@@ -1,67 +0,0 @@
-# Phase 7: Commit and Open PR
-
-You are creating a git branch, committing documentation changes, and opening a PR.
-
-## Objective
-Package documentation updates into a reviewable pull request.
-
-## Input
-You will receive:
-- Summary from Phase 6
-- List of modified files
-
-## Instructions
-
-1. **Create Branch**
-   ```sh
-   git checkout -b docs/auto-update-{date}
-   ```
-   Use format: `docs/auto-update-YYYY-MM-DD` or `docs/auto-update-{short-sha}`
-
-2. **Stage and Commit**
-   - Stage only documentation files in `docs/src/`
-   - Do not stage any other files
-   
-   Commit message format:
-   ```
-   docs: auto-update documentation for [brief description]
-   
-   [Summary from Phase 6, condensed]
-   
-   Triggered by: [commit SHA or PR reference]
-   
-   Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
-   ```
-
-3. **Push Branch**
-   ```sh
-   git push -u origin docs/auto-update-{date}
-   ```
-
-4. **Create Pull Request**
-   Use the Phase 6 summary as the PR body.
-   
-   PR Title: `docs: [Brief description of documentation updates]`
-   
-   Labels (if available): `documentation`, `automated`
-   
-   Base branch: `main`
-
-## Constraints
-- Do NOT auto-merge
-- Do NOT request specific reviewers (let CODEOWNERS handle it)
-- Do NOT modify files outside `docs/src/`
-- If no changes to commit, exit gracefully with message "No documentation changes to commit"
-
-## Output
-```markdown
-## PR Created
-
-- **Branch**: docs/auto-update-{date}
-- **PR URL**: https://github.com/zed-industries/zed/pull/XXXX
-- **Status**: Ready for review
-
-### Commit
-- SHA: {commit-sha}
-- Files: {count} documentation files modified
-```

.github/actionlint.yml

@@ -25,7 +25,6 @@ self-hosted-runner:
     - namespace-profile-32x64-ubuntu-2204
     # Namespace Ubuntu 24.04 (like ubuntu-latest)
     - namespace-profile-2x4-ubuntu-2404
-    - namespace-profile-8x32-ubuntu-2404
     # Namespace Limited Preview
     - namespace-profile-8x16-ubuntu-2004-arm-m4
     - namespace-profile-8x32-ubuntu-2004-arm-m4

.github/actions/build_docs/action.yml

@@ -19,18 +19,6 @@ runs:
       shell: bash -euxo pipefail {0}
       run: ./script/linux
 
-    - name: Install mold linker
-      shell: bash -euxo pipefail {0}
-      run: ./script/install-mold
-
-    - name: Download WASI SDK
-      shell: bash -euxo pipefail {0}
-      run: ./script/download-wasi-sdk
-
-    - name: Generate action metadata
-      shell: bash -euxo pipefail {0}
-      run: ./script/generate-action-metadata
-
     - name: Check for broken links (in MD)
       uses: lycheeverse/lychee-action@82202e5e9c2f4ef1a55a3d02563e1cb6041e5332 # v2.4.1
       with:

.github/workflows/autofix_pr.yml

@@ -54,10 +54,6 @@ jobs:
     - name: autofix_pr::run_autofix::run_cargo_fmt
       run: cargo fmt --all
       shell: bash -euxo pipefail {0}
-    - name: autofix_pr::run_autofix::run_cargo_fix
-      if: ${{ inputs.run_clippy }}
-      run: cargo fix --workspace --release --all-targets --all-features --allow-dirty --allow-staged
-      shell: bash -euxo pipefail {0}
     - name: autofix_pr::run_autofix::run_clippy_fix
       if: ${{ inputs.run_clippy }}
       run: cargo clippy --workspace --release --all-targets --all-features --fix --allow-dirty --allow-staged

.github/workflows/community_close_stale_issues.yml

@@ -1,40 +1,29 @@
 name: "Close Stale Issues"
 on:
   schedule:
-    - cron: "0 2 * * 5"
+    - cron: "0 8 31 DEC *"
   workflow_dispatch:
-    inputs:
-      debug-only:
-        description: "Run in dry-run mode (no changes made)"
-        type: boolean
-        default: false
-      operations-per-run:
-        description: "Max number of issues to process (default: 1000)"
-        type: number
-        default: 1000
 
 jobs:
   stale:
     if: github.repository_owner == 'zed-industries'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@997185467fa4f803885201cee163a9f38240193d # v10
+      - uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           stale-issue-message: >
-            Hi there!
-            Zed development moves fast and a significant number of bugs become outdated.
-            If you can reproduce this bug on the latest stable Zed, please let us know by leaving a comment with the Zed version.
-            If the bug doesn't appear for you anymore, feel free to close the issue yourself; otherwise, the bot will close it in a couple of weeks.
+            Hi there! 👋
+
+            We're working to clean up our issue tracker by closing older bugs that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and it will be kept open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, it will close automatically in 14 days.
 
             Thanks for your help!
-          close-issue-message: "This issue was closed due to inactivity. If you're still experiencing this problem, please leave a comment with your Zed version so that we can reopen the issue."
+          close-issue-message: "This issue was closed due to inactivity. If you're still experiencing this problem, please open a new issue with a link to this issue."
           days-before-stale: 60
           days-before-close: 14
           only-issue-types: "Bug,Crash"
-          operations-per-run: ${{ inputs.operations-per-run || 1000 }}
+          operations-per-run: 1000
           ascending: true
           enable-statistics: true
-          debug-only: ${{ inputs.debug-only }}
           stale-issue-label: "stale"
           exempt-issue-labels: "never stale"

.github/workflows/docs_automation.yml

@@ -1,264 +0,0 @@
-name: Documentation Automation
-
-on:
-  # push:
-  #   branches: [main]
-  #   paths:
-  #     - 'crates/**'
-  #     - 'extensions/**'
-  workflow_dispatch:
-    inputs:
-      pr_number:
-        description: 'PR number to analyze (gets full PR diff)'
-        required: false
-        type: string
-      trigger_sha:
-        description: 'Commit SHA to analyze (ignored if pr_number is set)'
-        required: false
-        type: string
-
-permissions:
-  contents: write
-  pull-requests: write
-
-env:
-  FACTORY_API_KEY: ${{ secrets.FACTORY_API_KEY }}
-  DROID_MODEL: claude-opus-4-5-20251101
-
-jobs:
-  docs-automation:
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Install Droid CLI
-        id: install-droid
-        run: |
-          curl -fsSL https://app.factory.ai/cli | sh
-          echo "${HOME}/.local/bin" >> "$GITHUB_PATH"
-          echo "DROID_BIN=${HOME}/.local/bin/droid" >> "$GITHUB_ENV"
-          # Verify installation
-          "${HOME}/.local/bin/droid" --version
-
-      - name: Setup Node.js (for Prettier)
-        uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-
-      - name: Install Prettier
-        run: npm install -g prettier
-
-      - name: Get changed files
-        id: changed
-        run: |
-          if [ -n "${{ inputs.pr_number }}" ]; then
-            # Get full PR diff
-            echo "Analyzing PR #${{ inputs.pr_number }}"
-            echo "source=pr" >> "$GITHUB_OUTPUT"
-            echo "ref=${{ inputs.pr_number }}" >> "$GITHUB_OUTPUT"
-            gh pr diff "${{ inputs.pr_number }}" --name-only > /tmp/changed_files.txt
-          elif [ -n "${{ inputs.trigger_sha }}" ]; then
-            # Get single commit diff
-            SHA="${{ inputs.trigger_sha }}"
-            echo "Analyzing commit $SHA"
-            echo "source=commit" >> "$GITHUB_OUTPUT"
-            echo "ref=$SHA" >> "$GITHUB_OUTPUT"
-            git diff --name-only "${SHA}^" "$SHA" > /tmp/changed_files.txt
-          else
-            # Default to current commit
-            SHA="${{ github.sha }}"
-            echo "Analyzing commit $SHA"
-            echo "source=commit" >> "$GITHUB_OUTPUT"
-            echo "ref=$SHA" >> "$GITHUB_OUTPUT"
-            git diff --name-only "${SHA}^" "$SHA" > /tmp/changed_files.txt || git diff --name-only HEAD~1 HEAD > /tmp/changed_files.txt
-          fi
-
-          echo "Changed files:"
-          cat /tmp/changed_files.txt
-        env:
-          GH_TOKEN: ${{ github.token }}
-
-      # Phase 0: Guardrails are loaded via AGENTS.md in each phase
-
-      # Phase 2: Explore Repository (Read-Only - default)
-      - name: "Phase 2: Explore Repository"
-        id: phase2
-        run: |
-          "$DROID_BIN" exec \
-            -m "$DROID_MODEL" \
-            -f .factory/prompts/docs-automation/phase2-explore.md \
-            > /tmp/phase2-output.txt 2>&1 || true
-          echo "Repository exploration complete"
-          cat /tmp/phase2-output.txt
-
-      # Phase 3: Analyze Changes (Read-Only - default)
-      - name: "Phase 3: Analyze Changes"
-        id: phase3
-        run: |
-          CHANGED_FILES=$(tr '\n' ' ' < /tmp/changed_files.txt)
-          echo "Analyzing changes in: $CHANGED_FILES"
-
-          # Build prompt with context
-          cat > /tmp/phase3-prompt.md << 'EOF'
-          $(cat .factory/prompts/docs-automation/phase3-analyze.md)
-
-          ## Context
-
-          ### Changed Files
-          $CHANGED_FILES
-
-          ### Phase 2 Output
-          $(cat /tmp/phase2-output.txt)
-          EOF
-
-          "$DROID_BIN" exec \
-            -m "$DROID_MODEL" \
-            "$(cat .factory/prompts/docs-automation/phase3-analyze.md)
-
-            Changed files: $CHANGED_FILES" \
-            > /tmp/phase3-output.md 2>&1 || true
-          echo "Change analysis complete"
-          cat /tmp/phase3-output.md
-
-      # Phase 4: Plan Documentation Impact (Read-Only - default)
-      - name: "Phase 4: Plan Documentation Impact"
-        id: phase4
-        run: |
-          "$DROID_BIN" exec \
-            -m "$DROID_MODEL" \
-            -f .factory/prompts/docs-automation/phase4-plan.md \
-            > /tmp/phase4-plan.md 2>&1 || true
-          echo "Documentation plan complete"
-          cat /tmp/phase4-plan.md
-
-          # Check if updates are required
-          if grep -q "NO_UPDATES_REQUIRED" /tmp/phase4-plan.md; then
-            echo "updates_required=false" >> "$GITHUB_OUTPUT"
-          else
-            echo "updates_required=true" >> "$GITHUB_OUTPUT"
-          fi
-
-      # Phase 5: Apply Plan (Write-Enabled with --auto medium)
-      - name: "Phase 5: Apply Documentation Plan"
-        id: phase5
-        if: steps.phase4.outputs.updates_required == 'true'
-        run: |
-          "$DROID_BIN" exec \
-            -m "$DROID_MODEL" \
-            --auto medium \
-            -f .factory/prompts/docs-automation/phase5-apply.md \
-            > /tmp/phase5-report.md 2>&1 || true
-          echo "Documentation updates applied"
-          cat /tmp/phase5-report.md
-
-      # Phase 5b: Format with Prettier
-      - name: "Phase 5b: Format with Prettier"
-        id: phase5b
-        if: steps.phase4.outputs.updates_required == 'true'
-        run: |
-          echo "Formatting documentation with Prettier..."
-          cd docs && prettier --write src/
-
-          echo "Verifying Prettier formatting passes..."
-          cd docs && prettier --check src/
-
-          echo "Prettier formatting complete"
-
-      # Phase 6: Summarize Changes (Read-Only - default)
-      - name: "Phase 6: Summarize Changes"
-        id: phase6
-        if: steps.phase4.outputs.updates_required == 'true'
-        run: |
-          # Get git diff of docs
-          git diff docs/src/ > /tmp/docs-diff.txt || true
-
-          "$DROID_BIN" exec \
-            -m "$DROID_MODEL" \
-            -f .factory/prompts/docs-automation/phase6-summarize.md \
-            > /tmp/phase6-summary.md 2>&1 || true
-          echo "Summary generated"
-          cat /tmp/phase6-summary.md
-
-      # Phase 7: Commit and Open PR
-      - name: "Phase 7: Create PR"
-        id: phase7
-        if: steps.phase4.outputs.updates_required == 'true'
-        run: |
-          # Check if there are actual changes
-          if git diff --quiet docs/src/; then
-            echo "No documentation changes detected"
-            exit 0
-          fi
-
-          # Configure git
-          git config user.name "factory-droid[bot]"
-          git config user.email "138933559+factory-droid[bot]@users.noreply.github.com"
-
-          # Daily batch branch - one branch per day, multiple commits accumulate
-          BRANCH_NAME="docs/auto-update-$(date +%Y-%m-%d)"
-
-          # Stash local changes from phase 5
-          git stash push -m "docs-automation-changes" -- docs/src/
-
-          # Check if branch already exists on remote
-          if git ls-remote --exit-code --heads origin "$BRANCH_NAME" > /dev/null 2>&1; then
-            echo "Branch $BRANCH_NAME exists, checking out and updating..."
-            git fetch origin "$BRANCH_NAME"
-            git checkout -B "$BRANCH_NAME" "origin/$BRANCH_NAME"
-          else
-            echo "Creating new branch $BRANCH_NAME..."
-            git checkout -b "$BRANCH_NAME"
-          fi
-
-          # Apply stashed changes
-          git stash pop || true
-
-          # Stage and commit
-          git add docs/src/
-          SUMMARY=$(head -50 < /tmp/phase6-summary.md)
-          git commit -m "docs: auto-update documentation
-
-          ${SUMMARY}
-
-          Triggered by: ${{ steps.changed.outputs.source }} ${{ steps.changed.outputs.ref }}
-
-          Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>"
-
-          # Push
-          git push -u origin "$BRANCH_NAME"
-
-          # Check if PR already exists for this branch
-          EXISTING_PR=$(gh pr list --head "$BRANCH_NAME" --json number --jq '.[0].number' || echo "")
-
-          if [ -n "$EXISTING_PR" ]; then
-            echo "PR #$EXISTING_PR already exists for branch $BRANCH_NAME, updated with new commit"
-          else
-            # Create new PR
-            gh pr create \
-              --title "docs: automated documentation update ($(date +%Y-%m-%d))" \
-              --body-file /tmp/phase6-summary.md \
-              --base main || true
-            echo "PR created on branch: $BRANCH_NAME"
-          fi
-        env:
-          GH_TOKEN: ${{ github.token }}
-
-      # Summary output
-      - name: "Summary"
-        if: always()
-        run: |
-          echo "## Documentation Automation Summary" >> "$GITHUB_STEP_SUMMARY"
-          echo "" >> "$GITHUB_STEP_SUMMARY"
-
-          if [ "${{ steps.phase4.outputs.updates_required }}" == "false" ]; then
-            echo "No documentation updates required for this change." >> "$GITHUB_STEP_SUMMARY"
-          elif [ -f /tmp/phase6-summary.md ]; then
-            cat /tmp/phase6-summary.md >> "$GITHUB_STEP_SUMMARY"
-          else
-            echo "Workflow completed. Check individual phase outputs for details." >> "$GITHUB_STEP_SUMMARY"
-          fi

.github/workflows/extension_bump.yml

@@ -66,7 +66,7 @@ jobs:
     if: |-
       (github.repository_owner == 'zed-industries' || github.repository_owner == 'zed-extensions') &&
       (inputs.force-bump == 'true' || needs.check_bump_needed.outputs.needs_bump == 'true')
-    runs-on: namespace-profile-2x4-ubuntu-2404
+    runs-on: namespace-profile-8x16-ubuntu-2204
     steps:
     - id: generate-token
       name: extension_bump::generate_token
@@ -119,7 +119,7 @@ jobs:
     needs:
     - check_bump_needed
     if: (github.repository_owner == 'zed-industries' || github.repository_owner == 'zed-extensions') && github.event_name == 'push' && github.ref == 'refs/heads/main' && needs.check_bump_needed.outputs.needs_bump == 'false'
-    runs-on: namespace-profile-2x4-ubuntu-2404
+    runs-on: namespace-profile-8x16-ubuntu-2204
     steps:
     - id: generate-token
       name: extension_bump::generate_token

.github/workflows/extension_release.yml

@@ -13,7 +13,7 @@ on:
 jobs:
   create_release:
     if: (github.repository_owner == 'zed-industries' || github.repository_owner == 'zed-extensions')
-    runs-on: namespace-profile-2x4-ubuntu-2404
+    runs-on: namespace-profile-8x16-ubuntu-2204
     steps:
     - id: generate-token
       name: extension_bump::generate_token

.github/workflows/extension_tests.yml

@@ -51,7 +51,7 @@ jobs:
     needs:
     - orchestrate
     if: needs.orchestrate.outputs.check_rust == 'true'
-    runs-on: namespace-profile-4x8-ubuntu-2204
+    runs-on: namespace-profile-16x32-ubuntu-2204
     steps:
     - name: steps::checkout_repo
       uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
@@ -79,7 +79,7 @@ jobs:
     needs:
     - orchestrate
     if: needs.orchestrate.outputs.check_extension == 'true'
-    runs-on: namespace-profile-8x32-ubuntu-2404
+    runs-on: namespace-profile-2x4-ubuntu-2404
     steps:
     - name: steps::checkout_repo
       uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683

.github/workflows/extension_workflow_rollout.yml

@@ -1,106 +0,0 @@
-# Generated from xtask::workflows::extension_workflow_rollout
-# Rebuild with `cargo xtask workflows`.
-name: extension_workflow_rollout
-env:
-  CARGO_TERM_COLOR: always
-on:
-  workflow_dispatch: {}
-jobs:
-  fetch_extension_repos:
-    runs-on: namespace-profile-2x4-ubuntu-2404
-    steps:
-    - id: list-repos
-      name: extension_workflow_rollout::fetch_extension_repos::get_repositories
-      uses: actions/github-script@v7
-      with:
-        script: |
-          const repos = await github.paginate(github.rest.repos.listForOrg, {
-              org: 'zed-extensions',
-              type: 'public',
-              per_page: 100,
-          });
-
-          const filteredRepos = repos
-              .filter(repo => !repo.archived)
-              .filter(repo => repo.name !== 'workflows' && repo.name !== 'material-icon-theme')
-              .map(repo => repo.name);
-
-          console.log(`Found ${filteredRepos.length} extension repos`);
-          return filteredRepos;
-        result-encoding: json
-    outputs:
-      repos: ${{ steps.list-repos.outputs.result }}
-    timeout-minutes: 5
-  rollout_workflows_to_extension:
-    needs:
-    - fetch_extension_repos
-    if: needs.fetch_extension_repos.outputs.repos != '[]'
-    runs-on: namespace-profile-2x4-ubuntu-2404
-    strategy:
-      matrix:
-        repo: ${{ fromJson(needs.fetch_extension_repos.outputs.repos) }}
-      fail-fast: false
-      max-parallel: 5
-    steps:
-    - id: generate-token
-      name: extension_bump::generate_token
-      uses: actions/create-github-app-token@v2
-      with:
-        app-id: ${{ secrets.ZED_ZIPPY_APP_ID }}
-        private-key: ${{ secrets.ZED_ZIPPY_APP_PRIVATE_KEY }}
-        owner: zed-extensions
-        repositories: ${{ matrix.repo }}
-        permission-pull-requests: write
-        permission-contents: write
-        permission-workflows: write
-    - name: checkout_zed_repo
-      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
-      with:
-        clean: false
-        path: zed
-    - name: steps::checkout_repo_with_token
-      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
-      with:
-        clean: false
-        token: ${{ steps.generate-token.outputs.token }}
-        repository: zed-extensions/${{ matrix.repo }}
-        path: extension
-    - name: extension_workflow_rollout::rollout_workflows_to_extension::copy_workflow_files
-      run: |
-        mkdir -p extension/.github/workflows
-        cp zed/extensions/workflows/shared/*.yml extension/.github/workflows/
-      shell: bash -euxo pipefail {0}
-    - id: short-sha
-      name: extension_workflow_rollout::rollout_workflows_to_extension::get_short_sha
-      run: |
-        echo "sha_short=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"
-      shell: bash -euxo pipefail {0}
-      working-directory: zed
-    - id: create-pr
-      name: extension_workflow_rollout::rollout_workflows_to_extension::create_pull_request
-      uses: peter-evans/create-pull-request@v7
-      with:
-        path: extension
-        title: Update CI workflows to zed@${{ steps.short-sha.outputs.sha_short }}
-        body: |
-          This PR updates the CI workflow files from the main Zed repository
-          based on the commit zed-industries/zed@${{ github.sha }}
-        commit-message: Update CI workflows to zed@${{ steps.short-sha.outputs.sha_short }}
-        branch: update-workflows
-        committer: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
-        author: zed-zippy[bot] <234243425+zed-zippy[bot]@users.noreply.github.com>
-        base: main
-        delete-branch: true
-        token: ${{ steps.generate-token.outputs.token }}
-        sign-commits: true
-    - name: extension_workflow_rollout::rollout_workflows_to_extension::enable_auto_merge
-      run: |
-        PR_NUMBER="${{ steps.create-pr.outputs.pull-request-number }}"
-        if [ -n "$PR_NUMBER" ]; then
-            cd extension
-            gh pr merge "$PR_NUMBER" --auto --squash
-        fi
-      shell: bash -euxo pipefail {0}
-      env:
-        GH_TOKEN: ${{ steps.generate-token.outputs.token }}
-    timeout-minutes: 10

.github/workflows/good_first_issue_notifier.yml

@@ -6,7 +6,7 @@ on:
 
 jobs:
   handle-good-first-issue:
-    if: github.event.label.name == '.contrib/good first issue' && github.repository_owner == 'zed-industries'
+    if: github.event.label.name == 'good first issue' && github.repository_owner == 'zed-industries'
     runs-on: ubuntu-latest
 
     steps:

.github/workflows/release.yml

@@ -74,6 +74,12 @@ jobs:
     - name: steps::clippy
       run: ./script/clippy
       shell: bash -euxo pipefail {0}
+    - name: steps::trigger_autofix
+      if: failure() && github.event_name == 'pull_request' && github.actor != 'zed-zippy[bot]'
+      run: gh workflow run autofix_pr.yml -f pr_number=${{ github.event.pull_request.number }} -f run_clippy=true
+      shell: bash -euxo pipefail {0}
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     - name: steps::cargo_install_nextest
       uses: taiki-e/install-action@nextest
     - name: steps::clear_target_dir_if_large

.github/workflows/run_tests.yml

@@ -74,12 +74,18 @@ jobs:
       uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2
       with:
         version: '9'
-    - name: steps::prettier
+    - name: ./script/prettier
       run: ./script/prettier
       shell: bash -euxo pipefail {0}
     - name: steps::cargo_fmt
       run: cargo fmt --all -- --check
       shell: bash -euxo pipefail {0}
+    - name: steps::trigger_autofix
+      if: failure() && github.event_name == 'pull_request' && github.actor != 'zed-zippy[bot]'
+      run: gh workflow run autofix_pr.yml -f pr_number=${{ github.event.pull_request.number }} -f run_clippy=false
+      shell: bash -euxo pipefail {0}
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     - name: ./script/check-todos
       run: ./script/check-todos
       shell: bash -euxo pipefail {0}
@@ -160,6 +166,12 @@ jobs:
     - name: steps::clippy
       run: ./script/clippy
       shell: bash -euxo pipefail {0}
+    - name: steps::trigger_autofix
+      if: failure() && github.event_name == 'pull_request' && github.actor != 'zed-zippy[bot]'
+      run: gh workflow run autofix_pr.yml -f pr_number=${{ github.event.pull_request.number }} -f run_clippy=true
+      shell: bash -euxo pipefail {0}
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     - name: steps::cargo_install_nextest
       uses: taiki-e/install-action@nextest
     - name: steps::clear_target_dir_if_large
@@ -353,9 +365,6 @@ jobs:
     - name: steps::download_wasi_sdk
       run: ./script/download-wasi-sdk
       shell: bash -euxo pipefail {0}
-    - name: ./script/generate-action-metadata
-      run: ./script/generate-action-metadata
-      shell: bash -euxo pipefail {0}
     - name: run_tests::check_docs::install_mdbook
       uses: peaceiris/actions-mdbook@ee69d230fe19748b7abf22df32acaa93833fad08
       with:

.gitignore

@@ -36,7 +36,6 @@
 DerivedData/
 Packages
 xcuserdata/
-crates/docs_preprocessor/actions.json
 
 # Don't commit any secrets to the repo.
 .env

CONTRIBUTING.md

@@ -23,6 +23,7 @@ In particular we love PRs that are:
 
 If you're looking for concrete ideas:
 
+- [Curated board of issues](https://github.com/orgs/zed-industries/projects/69) suitable for everyone from first-time contributors to seasoned community champions.
 - [Triaged bugs with confirmed steps to reproduce](https://github.com/zed-industries/zed/issues?q=is%3Aissue%20state%3Aopen%20type%3ABug%20label%3Astate%3Areproducible).
 - [Area labels](https://github.com/zed-industries/zed/labels?q=area%3A*) to browse bugs in a specific part of the product you care about (after clicking on an area label, add type:Bug to the search).
 

Cargo.lock

@@ -226,9 +226,9 @@ dependencies = [
 
 [[package]]
 name = "agent-client-protocol"
-version = "0.9.2"
+version = "0.9.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d3e527d7dfe0f334313d42d1d9318f0a79665f6f21c440d0798f230a77a7ed6c"
+checksum = "c2ffe7d502c1e451aafc5aff655000f84d09c9af681354ac0012527009b1af13"
 dependencies = [
  "agent-client-protocol-schema",
  "anyhow",
@@ -243,9 +243,9 @@ dependencies = [
 
 [[package]]
 name = "agent-client-protocol-schema"
-version = "0.10.5"
+version = "0.10.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6903a00e8ac822f9bacac59a1932754d7387c72ebb7c9c7439ad021505591da4"
+checksum = "8af81cc2d5c3f9c04f73db452efd058333735ba9d51c2cf7ef33c9fee038e7e6"
 dependencies = [
  "anyhow",
  "derive_more 2.0.1",
@@ -268,7 +268,6 @@ dependencies = [
  "client",
  "collections",
  "env_logger 0.11.8",
- "feature_flags",
  "fs",
  "futures 0.3.31",
  "gpui",
@@ -794,7 +793,7 @@ dependencies = [
  "url",
  "wayland-backend",
  "wayland-client",
- "wayland-protocols",
+ "wayland-protocols 0.32.9",
  "zbus",
 ]
 
@@ -3526,33 +3525,6 @@ dependencies = [
  "theme",
 ]
 
-[[package]]
-name = "component_preview"
-version = "0.1.0"
-dependencies = [
- "anyhow",
- "client",
- "collections",
- "component",
- "db",
- "fs",
- "gpui",
- "language",
- "log",
- "node_runtime",
- "notifications",
- "project",
- "release_channel",
- "reqwest_client",
- "session",
- "settings",
- "theme",
- "ui",
- "ui_input",
- "uuid",
- "workspace",
-]
-
 [[package]]
 name = "compression-codecs"
 version = "0.4.31"
@@ -5049,6 +5021,8 @@ name = "docs_preprocessor"
 version = "0.1.0"
 dependencies = [
  "anyhow",
+ "command_palette",
+ "gpui",
  "mdbook",
  "regex",
  "serde",
@@ -5057,6 +5031,7 @@ dependencies = [
  "task",
  "theme",
  "util",
+ "zed",
  "zlog",
 ]
 
@@ -5213,7 +5188,6 @@ dependencies = [
  "anyhow",
  "arrayvec",
  "brotli",
- "buffer_diff",
  "client",
  "clock",
  "cloud_api_types",
@@ -5251,10 +5225,7 @@ dependencies = [
  "strum 0.27.2",
  "telemetry",
  "telemetry_events",
- "text",
  "thiserror 2.0.17",
- "time",
- "toml 0.8.23",
  "ui",
  "util",
  "uuid",
@@ -5359,10 +5330,8 @@ dependencies = [
  "anyhow",
  "buffer_diff",
  "client",
- "clock",
  "cloud_llm_client",
  "codestral",
- "collections",
  "command_palette_hooks",
  "copilot",
  "edit_prediction",
@@ -5371,20 +5340,18 @@ dependencies = [
  "feature_flags",
  "fs",
  "futures 0.3.31",
+ "git",
  "gpui",
  "indoc",
  "language",
- "language_model",
+ "log",
  "lsp",
  "markdown",
  "menu",
  "multi_buffer",
  "paths",
- "pretty_assertions",
  "project",
  "regex",
- "release_channel",
- "semver",
  "serde_json",
  "settings",
  "supermaven",
@@ -5397,7 +5364,6 @@ dependencies = [
  "workspace",
  "zed_actions",
  "zeta_prompt",
- "zlog",
 ]
 
 [[package]]
@@ -7404,7 +7370,7 @@ dependencies = [
  "wayland-backend",
  "wayland-client",
  "wayland-cursor",
- "wayland-protocols",
+ "wayland-protocols 0.31.2",
  "wayland-protocols-plasma",
  "wayland-protocols-wlr",
  "windows 0.61.3",
@@ -8655,7 +8621,6 @@ dependencies = [
  "extension",
  "gpui",
  "language",
- "lsp",
  "paths",
  "project",
  "schemars",
@@ -8967,8 +8932,6 @@ dependencies = [
  "credentials_provider",
  "deepseek",
  "editor",
- "extension",
- "extension_host",
  "fs",
  "futures 0.3.31",
  "google_ai",
@@ -12608,7 +12571,6 @@ dependencies = [
  "gpui",
  "language",
  "menu",
- "notifications",
  "pretty_assertions",
  "project",
  "rayon",
@@ -12686,8 +12648,6 @@ dependencies = [
  "paths",
  "rope",
  "serde",
- "strum 0.27.2",
- "tempfile",
  "text",
  "util",
  "uuid",
@@ -18967,6 +18927,18 @@ dependencies = [
  "xcursor",
 ]
 
+[[package]]
+name = "wayland-protocols"
+version = "0.31.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "8f81f365b8b4a97f422ac0e8737c438024b5951734506b0e1d775c73030561f4"
+dependencies = [
+ "bitflags 2.9.4",
+ "wayland-backend",
+ "wayland-client",
+ "wayland-scanner",
+]
+
 [[package]]
 name = "wayland-protocols"
 version = "0.32.9"
@@ -18981,14 +18953,14 @@ dependencies = [
 
 [[package]]
 name = "wayland-protocols-plasma"
-version = "0.3.9"
+version = "0.2.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a07a14257c077ab3279987c4f8bb987851bf57081b93710381daea94f2c2c032"
+checksum = "23803551115ff9ea9bce586860c5c5a971e360825a0309264102a9495a5ff479"
 dependencies = [
  "bitflags 2.9.4",
  "wayland-backend",
  "wayland-client",
- "wayland-protocols",
+ "wayland-protocols 0.31.2",
  "wayland-scanner",
 ]
 
@@ -19001,7 +18973,7 @@ dependencies = [
  "bitflags 2.9.4",
  "wayland-backend",
  "wayland-client",
- "wayland-protocols",
+ "wayland-protocols 0.32.9",
  "wayland-scanner",
 ]
 
@@ -20303,16 +20275,6 @@ dependencies = [
  "zlog",
 ]
 
-[[package]]
-name = "worktree_benchmarks"
-version = "0.1.0"
-dependencies = [
- "fs",
- "gpui",
- "settings",
- "worktree",
-]
-
 [[package]]
 name = "writeable"
 version = "0.6.1"
@@ -20681,7 +20643,6 @@ dependencies = [
  "collections",
  "command_palette",
  "component",
- "component_preview",
  "copilot",
  "crashes",
  "dap",
@@ -20787,6 +20748,7 @@ dependencies = [
  "tree-sitter-md",
  "tree-sitter-rust",
  "ui",
+ "ui_input",
  "ui_prompt",
  "url",
  "urlencoding",
@@ -20966,7 +20928,7 @@ dependencies = [
 
 [[package]]
 name = "zed_glsl"
-version = "0.2.0"
+version = "0.1.0"
 dependencies = [
  "zed_extension_api 0.1.0",
 ]
@@ -20980,7 +20942,7 @@ dependencies = [
 
 [[package]]
 name = "zed_proto"
-version = "0.3.1"
+version = "0.3.0"
 dependencies = [
  "zed_extension_api 0.7.0",
 ]

Cargo.toml

@@ -39,7 +39,6 @@ members = [
     "crates/command_palette",
     "crates/command_palette_hooks",
     "crates/component",
-    "crates/component_preview",
     "crates/context_server",
     "crates/copilot",
     "crates/crashes",
@@ -199,7 +198,6 @@ members = [
     "crates/web_search_providers",
     "crates/workspace",
     "crates/worktree",
-    "crates/worktree_benchmarks",
     "crates/x_ai",
     "crates/zed",
     "crates/zed_actions",
@@ -276,7 +274,6 @@ collections = { path = "crates/collections", version = "0.1.0" }
 command_palette = { path = "crates/command_palette" }
 command_palette_hooks = { path = "crates/command_palette_hooks" }
 component = { path = "crates/component" }
-component_preview  = { path = "crates/component_preview" }
 context_server = { path = "crates/context_server" }
 copilot = { path = "crates/copilot" }
 crashes = { path = "crates/crashes" }
@@ -441,7 +438,7 @@ ztracing_macro = { path = "crates/ztracing_macro" }
 # External crates
 #
 
-agent-client-protocol = { version = "=0.9.2", features = ["unstable"] }
+agent-client-protocol = { version = "=0.9.0", features = ["unstable"] }
 aho-corasick = "1.1"
 alacritty_terminal = "0.25.1-rc1"
 any_vec = "0.14"

README.md

@@ -20,6 +20,7 @@ Other platforms are not yet available:
 - [Building Zed for macOS](./docs/src/development/macos.md)
 - [Building Zed for Linux](./docs/src/development/linux.md)
 - [Building Zed for Windows](./docs/src/development/windows.md)
+- [Running Collaboration Locally](./docs/src/development/local-collaboration.md)
 
 ### Contributing
 

assets/keymaps/default-linux.json

@@ -227,7 +227,6 @@
       "ctrl-g": "search::SelectNextMatch",
       "ctrl-shift-g": "search::SelectPreviousMatch",
       "ctrl-k l": "agent::OpenRulesLibrary",
-      "ctrl-shift-v": "agent::PasteRaw",
     },
   },
   {
@@ -241,7 +240,6 @@
       "ctrl-alt-l": "agent::OpenRulesLibrary",
       "ctrl-i": "agent::ToggleProfileSelector",
       "ctrl-alt-/": "agent::ToggleModelSelector",
-      "alt-tab": "agent::CycleFavoriteModels",
       "ctrl-shift-j": "agent::ToggleNavigationMenu",
       "ctrl-alt-i": "agent::ToggleOptionsMenu",
       "ctrl-alt-shift-n": "agent::ToggleNewThreadMenu",
@@ -254,6 +252,7 @@
       "ctrl-y": "agent::AllowOnce",
       "ctrl-alt-y": "agent::AllowAlways",
       "ctrl-alt-z": "agent::RejectOnce",
+      "alt-tab": "agent::CycleFavoriteModels",
     },
   },
   {
@@ -285,6 +284,36 @@
       "ctrl-alt-t": "agent::NewThread",
     },
   },
+  {
+    "context": "MessageEditor && !Picker > Editor && !use_modifier_to_send",
+    "bindings": {
+      "enter": "agent::Chat",
+      "ctrl-enter": "agent::ChatWithFollow",
+      "ctrl-i": "agent::ToggleProfileSelector",
+      "shift-ctrl-r": "agent::OpenAgentDiff",
+      "ctrl-shift-y": "agent::KeepAll",
+      "ctrl-shift-n": "agent::RejectAll",
+    },
+  },
+  {
+    "context": "MessageEditor && !Picker > Editor && use_modifier_to_send",
+    "bindings": {
+      "ctrl-enter": "agent::Chat",
+      "enter": "editor::Newline",
+      "ctrl-i": "agent::ToggleProfileSelector",
+      "shift-ctrl-r": "agent::OpenAgentDiff",
+      "ctrl-shift-y": "agent::KeepAll",
+      "ctrl-shift-n": "agent::RejectAll",
+    },
+  },
+  {
+    "context": "EditMessageEditor > Editor",
+    "bindings": {
+      "escape": "menu::Cancel",
+      "enter": "menu::Confirm",
+      "alt-enter": "editor::Newline",
+    },
+  },
   {
     "context": "AgentFeedbackMessageEditor > Editor",
     "bindings": {
@@ -299,25 +328,14 @@
       "ctrl-enter": "menu::Confirm",
     },
   },
-  {
-    "context": "AcpThread > Editor",
-    "use_key_equivalents": true,
-    "bindings": {
-      "ctrl-enter": "agent::ChatWithFollow",
-      "ctrl-i": "agent::ToggleProfileSelector",
-      "ctrl-shift-r": "agent::OpenAgentDiff",
-      "ctrl-shift-y": "agent::KeepAll",
-      "ctrl-shift-n": "agent::RejectAll",
-      "ctrl-shift-v": "agent::PasteRaw",
-      "shift-tab": "agent::CycleModeSelector",
-      "alt-tab": "agent::CycleFavoriteModels",
-    },
-  },
   {
     "context": "AcpThread > Editor && !use_modifier_to_send",
     "use_key_equivalents": true,
     "bindings": {
       "enter": "agent::Chat",
+      "shift-ctrl-r": "agent::OpenAgentDiff",
+      "ctrl-shift-y": "agent::KeepAll",
+      "ctrl-shift-n": "agent::RejectAll",
     },
   },
   {
@@ -325,7 +343,11 @@
     "use_key_equivalents": true,
     "bindings": {
       "ctrl-enter": "agent::Chat",
-      "enter": "editor::Newline",
+      "shift-ctrl-r": "agent::OpenAgentDiff",
+      "ctrl-shift-y": "agent::KeepAll",
+      "ctrl-shift-n": "agent::RejectAll",
+      "shift-tab": "agent::CycleModeSelector",
+      "alt-tab": "agent::CycleFavoriteModels",
     },
   },
   {
@@ -792,7 +814,7 @@
     },
   },
   {
-    "context": "InlineAssistant",
+    "context": "PromptEditor",
     "bindings": {
       "ctrl-[": "agent::CyclePreviousInlineAssist",
       "ctrl-]": "agent::CycleNextInlineAssist",

assets/keymaps/default-macos.json

@@ -267,7 +267,6 @@
       "cmd-shift-g": "search::SelectPreviousMatch",
       "cmd-k l": "agent::OpenRulesLibrary",
       "alt-tab": "agent::CycleFavoriteModels",
-      "cmd-shift-v": "agent::PasteRaw",
     },
   },
   {
@@ -282,7 +281,6 @@
       "cmd-alt-p": "agent::ManageProfiles",
       "cmd-i": "agent::ToggleProfileSelector",
       "cmd-alt-/": "agent::ToggleModelSelector",
-      "alt-tab": "agent::CycleFavoriteModels",
       "cmd-shift-j": "agent::ToggleNavigationMenu",
       "cmd-alt-m": "agent::ToggleOptionsMenu",
       "cmd-alt-shift-n": "agent::ToggleNewThreadMenu",
@@ -295,6 +293,7 @@
       "cmd-y": "agent::AllowOnce",
       "cmd-alt-y": "agent::AllowAlways",
       "cmd-alt-z": "agent::RejectOnce",
+      "alt-tab": "agent::CycleFavoriteModels",
     },
   },
   {
@@ -326,6 +325,39 @@
       "cmd-alt-t": "agent::NewThread",
     },
   },
+  {
+    "context": "MessageEditor && !Picker > Editor && !use_modifier_to_send",
+    "use_key_equivalents": true,
+    "bindings": {
+      "enter": "agent::Chat",
+      "cmd-enter": "agent::ChatWithFollow",
+      "cmd-i": "agent::ToggleProfileSelector",
+      "shift-ctrl-r": "agent::OpenAgentDiff",
+      "cmd-shift-y": "agent::KeepAll",
+      "cmd-shift-n": "agent::RejectAll",
+    },
+  },
+  {
+    "context": "MessageEditor && !Picker > Editor && use_modifier_to_send",
+    "use_key_equivalents": true,
+    "bindings": {
+      "cmd-enter": "agent::Chat",
+      "enter": "editor::Newline",
+      "cmd-i": "agent::ToggleProfileSelector",
+      "shift-ctrl-r": "agent::OpenAgentDiff",
+      "cmd-shift-y": "agent::KeepAll",
+      "cmd-shift-n": "agent::RejectAll",
+    },
+  },
+  {
+    "context": "EditMessageEditor > Editor",
+    "use_key_equivalents": true,
+    "bindings": {
+      "escape": "menu::Cancel",
+      "enter": "menu::Confirm",
+      "alt-enter": "editor::Newline",
+    },
+  },
   {
     "context": "AgentFeedbackMessageEditor > Editor",
     "use_key_equivalents": true,
@@ -347,25 +379,16 @@
       "cmd-enter": "menu::Confirm",
     },
   },
-  {
-    "context": "AcpThread > Editor",
-    "use_key_equivalents": true,
-    "bindings": {
-      "shift-ctrl-r": "agent::OpenAgentDiff",
-      "cmd-shift-y": "agent::KeepAll",
-      "cmd-shift-n": "agent::RejectAll",
-      "cmd-enter": "agent::ChatWithFollow",
-      "cmd-shift-v": "agent::PasteRaw",
-      "cmd-i": "agent::ToggleProfileSelector",
-      "shift-tab": "agent::CycleModeSelector",
-      "alt-tab": "agent::CycleFavoriteModels",
-    },
-  },
   {
     "context": "AcpThread > Editor && !use_modifier_to_send",
     "use_key_equivalents": true,
     "bindings": {
       "enter": "agent::Chat",
+      "shift-ctrl-r": "agent::OpenAgentDiff",
+      "cmd-shift-y": "agent::KeepAll",
+      "cmd-shift-n": "agent::RejectAll",
+      "shift-tab": "agent::CycleModeSelector",
+      "alt-tab": "agent::CycleFavoriteModels",
     },
   },
   {
@@ -373,7 +396,11 @@
     "use_key_equivalents": true,
     "bindings": {
       "cmd-enter": "agent::Chat",
-      "enter": "editor::Newline",
+      "shift-ctrl-r": "agent::OpenAgentDiff",
+      "cmd-shift-y": "agent::KeepAll",
+      "cmd-shift-n": "agent::RejectAll",
+      "shift-tab": "agent::CycleModeSelector",
+      "alt-tab": "agent::CycleFavoriteModels",
     },
   },
   {
@@ -853,7 +880,7 @@
     },
   },
   {
-    "context": "InlineAssistant > Editor",
+    "context": "PromptEditor",
     "use_key_equivalents": true,
     "bindings": {
       "cmd-alt-/": "agent::ToggleModelSelector",

assets/keymaps/default-windows.json

@@ -227,7 +227,6 @@
       "ctrl-g": "search::SelectNextMatch",
       "ctrl-shift-g": "search::SelectPreviousMatch",
       "ctrl-k l": "agent::OpenRulesLibrary",
-      "ctrl-shift-v": "agent::PasteRaw",
     },
   },
   {
@@ -241,7 +240,6 @@
       "shift-alt-l": "agent::OpenRulesLibrary",
       "shift-alt-p": "agent::ManageProfiles",
       "ctrl-i": "agent::ToggleProfileSelector",
-      "alt-tab": "agent::CycleFavoriteModels",
       "shift-alt-/": "agent::ToggleModelSelector",
       "shift-alt-j": "agent::ToggleNavigationMenu",
       "shift-alt-i": "agent::ToggleOptionsMenu",
@@ -255,6 +253,7 @@
       "shift-alt-a": "agent::AllowOnce",
       "ctrl-alt-y": "agent::AllowAlways",
       "shift-alt-z": "agent::RejectOnce",
+      "alt-tab": "agent::CycleFavoriteModels",
     },
   },
   {
@@ -287,6 +286,39 @@
       "ctrl-alt-t": "agent::NewThread",
     },
   },
+  {
+    "context": "MessageEditor && !Picker > Editor && !use_modifier_to_send",
+    "use_key_equivalents": true,
+    "bindings": {
+      "enter": "agent::Chat",
+      "ctrl-enter": "agent::ChatWithFollow",
+      "ctrl-i": "agent::ToggleProfileSelector",
+      "ctrl-shift-r": "agent::OpenAgentDiff",
+      "ctrl-shift-y": "agent::KeepAll",
+      "ctrl-shift-n": "agent::RejectAll",
+    },
+  },
+  {
+    "context": "MessageEditor && !Picker > Editor && use_modifier_to_send",
+    "use_key_equivalents": true,
+    "bindings": {
+      "ctrl-enter": "agent::Chat",
+      "enter": "editor::Newline",
+      "ctrl-i": "agent::ToggleProfileSelector",
+      "ctrl-shift-r": "agent::OpenAgentDiff",
+      "ctrl-shift-y": "agent::KeepAll",
+      "ctrl-shift-n": "agent::RejectAll",
+    },
+  },
+  {
+    "context": "EditMessageEditor > Editor",
+    "use_key_equivalents": true,
+    "bindings": {
+      "escape": "menu::Cancel",
+      "enter": "menu::Confirm",
+      "alt-enter": "editor::Newline",
+    },
+  },
   {
     "context": "AgentFeedbackMessageEditor > Editor",
     "use_key_equivalents": true,
@@ -302,25 +334,16 @@
       "ctrl-enter": "menu::Confirm",
     },
   },
-  {
-    "context": "AcpThread > Editor",
-    "use_key_equivalents": true,
-    "bindings": {
-      "ctrl-enter": "agent::ChatWithFollow",
-      "ctrl-i": "agent::ToggleProfileSelector",
-      "ctrl-shift-r": "agent::OpenAgentDiff",
-      "ctrl-shift-y": "agent::KeepAll",
-      "ctrl-shift-n": "agent::RejectAll",
-      "ctrl-shift-v": "agent::PasteRaw",
-      "shift-tab": "agent::CycleModeSelector",
-      "alt-tab": "agent::CycleFavoriteModels",
-    },
-  },
   {
     "context": "AcpThread > Editor && !use_modifier_to_send",
     "use_key_equivalents": true,
     "bindings": {
       "enter": "agent::Chat",
+      "ctrl-shift-r": "agent::OpenAgentDiff",
+      "ctrl-shift-y": "agent::KeepAll",
+      "ctrl-shift-n": "agent::RejectAll",
+      "shift-tab": "agent::CycleModeSelector",
+      "alt-tab": "agent::CycleFavoriteModels",
     },
   },
   {
@@ -328,7 +351,11 @@
     "use_key_equivalents": true,
     "bindings": {
       "ctrl-enter": "agent::Chat",
-      "enter": "editor::Newline",
+      "ctrl-shift-r": "agent::OpenAgentDiff",
+      "ctrl-shift-y": "agent::KeepAll",
+      "ctrl-shift-n": "agent::RejectAll",
+      "shift-tab": "agent::CycleModeSelector",
+      "alt-tab": "agent::CycleFavoriteModels",
     },
   },
   {
@@ -796,7 +823,7 @@
     },
   },
   {
-    "context": "InlineAssistant",
+    "context": "PromptEditor",
     "use_key_equivalents": true,
     "bindings": {
       "ctrl-[": "agent::CyclePreviousInlineAssist",

assets/keymaps/linux/cursor.json

@@ -24,7 +24,7 @@
     },
   },
   {
-    "context": "InlineAssistant > Editor",
+    "context": "InlineAssistEditor",
     "use_key_equivalents": true,
     "bindings": {
       "ctrl-shift-backspace": "editor::Cancel",

assets/keymaps/macos/cursor.json

@@ -24,7 +24,7 @@
     },
   },
   {
-    "context": "InlineAssistant > Editor",
+    "context": "InlineAssistEditor",
     "use_key_equivalents": true,
     "bindings": {
       "cmd-shift-backspace": "editor::Cancel",

assets/settings/default.json

@@ -1178,10 +1178,6 @@
   "remove_trailing_whitespace_on_save": true,
   // Whether to start a new line with a comment when a previous line is a comment as well.
   "extend_comment_on_newline": true,
-  // Whether to continue markdown lists when pressing enter.
-  "extend_list_on_newline": true,
-  // Whether to indent list items when pressing tab after a list marker.
-  "indent_list_on_tab": true,
   // Removes any lines containing only whitespace at the end of the file and
   // ensures just one newline at the end.
   "ensure_final_newline_on_save": true,
@@ -1325,14 +1321,6 @@
   "hidden_files": ["**/.*"],
   // Git gutter behavior configuration.
   "git": {
-    // Global switch to enable or disable all git integration features.
-    // If set to true, disables all git integration features.
-    // If set to false, individual git integration features below will be independently enabled or disabled.
-    "disable_git": false,
-    // Whether to enable git status tracking.
-    "enable_status": true,
-    // Whether to enable git diff display.
-    "enable_diff": true,
     // Control whether the git gutter is shown. May take 2 values:
     // 1. Show the gutter
     //      "git_gutter": "tracked_files"

crates/acp_thread/src/acp_thread.rs

@@ -11,7 +11,6 @@ use language::language_settings::FormatOnSave;
 pub use mention::*;
 use project::lsp_store::{FormatTrigger, LspFormatTarget};
 use serde::{Deserialize, Serialize};
-use serde_json::to_string_pretty;
 use settings::Settings as _;
 use task::{Shell, ShellBuilder};
 pub use terminal::*;
@@ -193,7 +192,6 @@ pub struct ToolCall {
     pub locations: Vec<acp::ToolCallLocation>,
     pub resolved_locations: Vec<Option<AgentLocation>>,
     pub raw_input: Option<serde_json::Value>,
-    pub raw_input_markdown: Option<Entity<Markdown>>,
     pub raw_output: Option<serde_json::Value>,
 }
 
@@ -224,11 +222,6 @@ impl ToolCall {
             }
         }
 
-        let raw_input_markdown = tool_call
-            .raw_input
-            .as_ref()
-            .and_then(|input| markdown_for_raw_output(input, &language_registry, cx));
-
         let result = Self {
             id: tool_call.tool_call_id,
             label: cx
@@ -239,7 +232,6 @@ impl ToolCall {
             resolved_locations: Vec::default(),
             status,
             raw_input: tool_call.raw_input,
-            raw_input_markdown,
             raw_output: tool_call.raw_output,
         };
         Ok(result)
@@ -315,7 +307,6 @@ impl ToolCall {
         }
 
         if let Some(raw_input) = raw_input {
-            self.raw_input_markdown = markdown_for_raw_output(&raw_input, &language_registry, cx);
             self.raw_input = Some(raw_input);
         }
 
@@ -884,7 +875,6 @@ pub enum AcpThreadEvent {
     Refusal,
     AvailableCommandsUpdated(Vec<acp::AvailableCommand>),
     ModeUpdated(acp::SessionModeId),
-    ConfigOptionsUpdated(Vec<acp::SessionConfigOption>),
 }
 
 impl EventEmitter<AcpThreadEvent> for AcpThread {}
@@ -1194,10 +1184,6 @@ impl AcpThread {
                 current_mode_id,
                 ..
             }) => cx.emit(AcpThreadEvent::ModeUpdated(current_mode_id)),
-            acp::SessionUpdate::ConfigOptionUpdate(acp::ConfigOptionUpdate {
-                config_options,
-                ..
-            }) => cx.emit(AcpThreadEvent::ConfigOptionsUpdated(config_options)),
             _ => {}
         }
         Ok(())
@@ -1369,7 +1355,6 @@ impl AcpThread {
                     locations: Vec::new(),
                     resolved_locations: Vec::new(),
                     raw_input: None,
-                    raw_input_markdown: None,
                     raw_output: None,
                 };
                 self.push_entry(AgentThreadEntry::ToolCall(failed_tool_call), cx);
@@ -1998,42 +1983,37 @@ impl AcpThread {
     fn update_last_checkpoint(&mut self, cx: &mut Context<Self>) -> Task<Result<()>> {
         let git_store = self.project.read(cx).git_store().clone();
 
-        let Some((_, message)) = self.last_user_message() else {
+        let old_checkpoint = if let Some((_, message)) = self.last_user_message() {
+            if let Some(checkpoint) = message.checkpoint.as_ref() {
+                checkpoint.git_checkpoint.clone()
+            } else {
+                return Task::ready(Ok(()));
+            }
+        } else {
             return Task::ready(Ok(()));
         };
-        let Some(user_message_id) = message.id.clone() else {
-            return Task::ready(Ok(()));
-        };
-        let Some(checkpoint) = message.checkpoint.as_ref() else {
-            return Task::ready(Ok(()));
-        };
-        let old_checkpoint = checkpoint.git_checkpoint.clone();
 
         let new_checkpoint = git_store.update(cx, |git, cx| git.checkpoint(cx));
         cx.spawn(async move |this, cx| {
-            let Some(new_checkpoint) = new_checkpoint
+            let new_checkpoint = new_checkpoint
                 .await
                 .context("failed to get new checkpoint")
-                .log_err()
-            else {
-                return Ok(());
-            };
-
-            let equal = git_store
-                .update(cx, |git, cx| {
-                    git.compare_checkpoints(old_checkpoint.clone(), new_checkpoint, cx)
-                })?
-                .await
-                .unwrap_or(true);
-
-            this.update(cx, |this, cx| {
-                if let Some((ix, message)) = this.user_message_mut(&user_message_id) {
-                    if let Some(checkpoint) = message.checkpoint.as_mut() {
-                        checkpoint.show = !equal;
-                        cx.emit(AcpThreadEvent::EntryUpdated(ix));
-                    }
-                }
-            })?;
+                .log_err();
+            if let Some(new_checkpoint) = new_checkpoint {
+                let equal = git_store
+                    .update(cx, |git, cx| {
+                        git.compare_checkpoints(old_checkpoint.clone(), new_checkpoint, cx)
+                    })?
+                    .await
+                    .unwrap_or(true);
+                this.update(cx, |this, cx| {
+                    let (ix, message) = this.last_user_message().context("no user message")?;
+                    let checkpoint = message.checkpoint.as_mut().context("no checkpoint")?;
+                    checkpoint.show = !equal;
+                    cx.emit(AcpThreadEvent::EntryUpdated(ix));
+                    anyhow::Ok(())
+                })??;
+            }
 
             Ok(())
         })
@@ -2433,10 +2413,8 @@ fn markdown_for_raw_output(
             )
         })),
         value => Some(cx.new(|cx| {
-            let pretty_json = to_string_pretty(value).unwrap_or_else(|_| value.to_string());
-
             Markdown::new(
-                format!("```json\n{}\n```", pretty_json).into(),
+                format!("```json\n{}\n```", value).into(),
                 Some(language_registry.clone()),
                 None,
                 cx,
@@ -4079,67 +4057,4 @@ mod tests {
             "Should have exactly 2 terminals (the completed ones from before checkpoint)"
         );
     }
-
-    /// Tests that update_last_checkpoint correctly updates the original message's checkpoint
-    /// even when a new user message is added while the async checkpoint comparison is in progress.
-    ///
-    /// This is a regression test for a bug where update_last_checkpoint would fail with
-    /// "no checkpoint" if a new user message (without a checkpoint) was added between when
-    /// update_last_checkpoint started and when its async closure ran.
-    #[gpui::test]
-    async fn test_update_last_checkpoint_with_new_message_added(cx: &mut TestAppContext) {
-        init_test(cx);
-
-        let fs = FakeFs::new(cx.executor());
-        fs.insert_tree(path!("/test"), json!({".git": {}, "file.txt": "content"}))
-            .await;
-        let project = Project::test(fs.clone(), [Path::new(path!("/test"))], cx).await;
-
-        let handler_done = Arc::new(AtomicBool::new(false));
-        let handler_done_clone = handler_done.clone();
-        let connection = Rc::new(FakeAgentConnection::new().on_user_message(
-            move |_, _thread, _cx| {
-                handler_done_clone.store(true, SeqCst);
-                async move { Ok(acp::PromptResponse::new(acp::StopReason::EndTurn)) }.boxed_local()
-            },
-        ));
-
-        let thread = cx
-            .update(|cx| connection.new_thread(project, Path::new(path!("/test")), cx))
-            .await
-            .unwrap();
-
-        let send_future = thread.update(cx, |thread, cx| thread.send_raw("First message", cx));
-        let send_task = cx.background_executor.spawn(send_future);
-
-        // Tick until handler completes, then a few more to let update_last_checkpoint start
-        while !handler_done.load(SeqCst) {
-            cx.executor().tick();
-        }
-        for _ in 0..5 {
-            cx.executor().tick();
-        }
-
-        thread.update(cx, |thread, cx| {
-            thread.push_entry(
-                AgentThreadEntry::UserMessage(UserMessage {
-                    id: Some(UserMessageId::new()),
-                    content: ContentBlock::Empty,
-                    chunks: vec!["Injected message (no checkpoint)".into()],
-                    checkpoint: None,
-                    indented: false,
-                }),
-                cx,
-            );
-        });
-
-        cx.run_until_parked();
-        let result = send_task.await;
-
-        assert!(
-            result.is_ok(),
-            "send should succeed even when new message added during update_last_checkpoint: {:?}",
-            result.err()
-        );
-    }
 }

crates/acp_thread/src/connection.rs

@@ -86,14 +86,6 @@ pub trait AgentConnection {
         None
     }
 
-    fn session_config_options(
-        &self,
-        _session_id: &acp::SessionId,
-        _cx: &App,
-    ) -> Option<Rc<dyn AgentSessionConfigOptions>> {
-        None
-    }
-
     fn into_any(self: Rc<Self>) -> Rc<dyn Any>;
 }
 
@@ -133,26 +125,6 @@ pub trait AgentSessionModes {
     fn set_mode(&self, mode: acp::SessionModeId, cx: &mut App) -> Task<Result<()>>;
 }
 
-pub trait AgentSessionConfigOptions {
-    /// Get all current config options with their state
-    fn config_options(&self) -> Vec<acp::SessionConfigOption>;
-
-    /// Set a config option value
-    /// Returns the full updated list of config options
-    fn set_config_option(
-        &self,
-        config_id: acp::SessionConfigId,
-        value: acp::SessionConfigValueId,
-        cx: &mut App,
-    ) -> Task<Result<Vec<acp::SessionConfigOption>>>;
-
-    /// Whenever the config options are updated the receiver will be notified.
-    /// Optional for agents that don't update their config options dynamically.
-    fn watch(&self, _cx: &mut App) -> Option<watch::Receiver<()>> {
-        None
-    }
-}
-
 #[derive(Debug)]
 pub struct AuthRequired {
     pub description: Option<String>,
@@ -230,15 +202,12 @@ pub trait AgentModelSelector: 'static {
     fn should_render_footer(&self) -> bool {
         false
     }
-}
 
-/// Icon for a model in the model selector.
-#[derive(Debug, Clone, PartialEq, Eq)]
-pub enum AgentModelIcon {
-    /// A built-in icon from Zed's icon set.
-    Named(IconName),
-    /// Path to a custom SVG icon file.
-    Path(SharedString),
+    /// Whether this selector supports the favorites feature.
+    /// Only the native agent uses the model ID format that maps to settings.
+    fn supports_favorites(&self) -> bool {
+        false
+    }
 }
 
 #[derive(Debug, Clone, PartialEq, Eq)]
@@ -246,7 +215,7 @@ pub struct AgentModelInfo {
     pub id: acp::ModelId,
     pub name: SharedString,
     pub description: Option<SharedString>,
-    pub icon: Option<AgentModelIcon>,
+    pub icon: Option<IconName>,
 }
 
 impl From<acp::ModelInfo> for AgentModelInfo {

crates/acp_tools/src/acp_tools.rs

@@ -4,20 +4,22 @@ use std::{
     fmt::Display,
     rc::{Rc, Weak},
     sync::Arc,
+    time::Duration,
 };
 
 use agent_client_protocol as acp;
 use collections::HashMap;
 use gpui::{
-    App, Empty, Entity, EventEmitter, FocusHandle, Focusable, Global, ListAlignment, ListState,
-    StyleRefinement, Subscription, Task, TextStyleRefinement, Window, actions, list, prelude::*,
+    App, ClipboardItem, Empty, Entity, EventEmitter, FocusHandle, Focusable, Global, ListAlignment,
+    ListState, StyleRefinement, Subscription, Task, TextStyleRefinement, Window, actions, list,
+    prelude::*,
 };
 use language::LanguageRegistry;
 use markdown::{CodeBlockRenderer, Markdown, MarkdownElement, MarkdownStyle};
 use project::Project;
 use settings::Settings;
 use theme::ThemeSettings;
-use ui::{CopyButton, Tooltip, WithScrollbar, prelude::*};
+use ui::{Tooltip, WithScrollbar, prelude::*};
 use util::ResultExt as _;
 use workspace::{
     Item, ItemHandle, ToolbarItemEvent, ToolbarItemLocation, ToolbarItemView, Workspace,
@@ -542,11 +544,15 @@ impl Render for AcpTools {
 
 pub struct AcpToolsToolbarItemView {
     acp_tools: Option<Entity<AcpTools>>,
+    just_copied: bool,
 }
 
 impl AcpToolsToolbarItemView {
     pub fn new() -> Self {
-        Self { acp_tools: None }
+        Self {
+            acp_tools: None,
+            just_copied: false,
+        }
     }
 }
 
@@ -566,14 +572,37 @@ impl Render for AcpToolsToolbarItemView {
         h_flex()
             .gap_2()
             .child({
-                let message = acp_tools
-                    .read(cx)
-                    .serialize_observed_messages()
-                    .unwrap_or_default();
+                let acp_tools = acp_tools.clone();
+                IconButton::new(
+                    "copy_all_messages",
+                    if self.just_copied {
+                        IconName::Check
+                    } else {
+                        IconName::Copy
+                    },
+                )
+                .icon_size(IconSize::Small)
+                .tooltip(Tooltip::text(if self.just_copied {
+                    "Copied!"
+                } else {
+                    "Copy All Messages"
+                }))
+                .disabled(!has_messages)
+                .on_click(cx.listener(move |this, _, _window, cx| {
+                    if let Some(content) = acp_tools.read(cx).serialize_observed_messages() {
+                        cx.write_to_clipboard(ClipboardItem::new_string(content));
 
-                CopyButton::new(message)
-                    .tooltip_label("Copy All Messages")
-                    .disabled(!has_messages)
+                        this.just_copied = true;
+                        cx.spawn(async move |this, cx| {
+                            cx.background_executor().timer(Duration::from_secs(2)).await;
+                            this.update(cx, |this, cx| {
+                                this.just_copied = false;
+                                cx.notify();
+                            })
+                        })
+                        .detach();
+                    }
+                }))
             })
             .child(
                 IconButton::new("clear_messages", IconName::Trash)

crates/action_log/src/action_log.rs

@@ -6,7 +6,7 @@ use futures::{FutureExt, StreamExt, channel::mpsc};
 use gpui::{
     App, AppContext, AsyncApp, Context, Entity, SharedString, Subscription, Task, WeakEntity,
 };
-use language::{Anchor, Buffer, BufferEvent, Point, ToPoint};
+use language::{Anchor, Buffer, BufferEvent, DiskState, Point, ToPoint};
 use project::{Project, ProjectItem, lsp_store::OpenLspBufferHandle};
 use std::{cmp, ops::Range, sync::Arc};
 use text::{Edit, Patch, Rope};
@@ -150,7 +150,7 @@ impl ActionLog {
                 if buffer
                     .read(cx)
                     .file()
-                    .is_some_and(|file| file.disk_state().is_deleted())
+                    .is_some_and(|file| file.disk_state() == DiskState::Deleted)
                 {
                     // If the buffer had been edited by a tool, but it got
                     // deleted externally, we want to stop tracking it.
@@ -162,7 +162,7 @@ impl ActionLog {
                 if buffer
                     .read(cx)
                     .file()
-                    .is_some_and(|file| !file.disk_state().is_deleted())
+                    .is_some_and(|file| file.disk_state() != DiskState::Deleted)
                 {
                     // If the buffer had been deleted by a tool, but it got
                     // resurrected externally, we want to clear the edits we
@@ -769,7 +769,7 @@ impl ActionLog {
                 tracked.version != buffer.version
                     && buffer
                         .file()
-                        .is_some_and(|file| !file.disk_state().is_deleted())
+                        .is_some_and(|file| file.disk_state() != DiskState::Deleted)
             })
             .map(|(buffer, _)| buffer)
     }

crates/agent/src/agent.rs

@@ -30,7 +30,7 @@ use futures::{StreamExt, future};
 use gpui::{
     App, AppContext, AsyncApp, Context, Entity, SharedString, Subscription, Task, WeakEntity,
 };
-use language_model::{IconOrSvg, LanguageModel, LanguageModelProvider, LanguageModelRegistry};
+use language_model::{LanguageModel, LanguageModelProvider, LanguageModelRegistry};
 use project::{Project, ProjectItem, ProjectPath, Worktree};
 use prompt_store::{
     ProjectContext, PromptStore, RULES_FILE_NAMES, RulesFileContext, UserRulesContext,
@@ -93,7 +93,7 @@ impl LanguageModels {
     fn refresh_list(&mut self, cx: &App) {
         let providers = LanguageModelRegistry::global(cx)
             .read(cx)
-            .visible_providers()
+            .providers()
             .into_iter()
             .filter(|provider| provider.is_authenticated(cx))
             .collect::<Vec<_>>();
@@ -153,10 +153,7 @@ impl LanguageModels {
             id: Self::model_id(model),
             name: model.name().0,
             description: None,
-            icon: Some(match provider.icon() {
-                IconOrSvg::Svg(path) => acp_thread::AgentModelIcon::Path(path),
-                IconOrSvg::Icon(name) => acp_thread::AgentModelIcon::Named(name),
-            }),
+            icon: Some(provider.icon()),
         }
     }
 
@@ -167,7 +164,7 @@ impl LanguageModels {
     fn authenticate_all_language_model_providers(cx: &mut App) -> Task<()> {
         let authenticate_all_providers = LanguageModelRegistry::global(cx)
             .read(cx)
-            .visible_providers()
+            .providers()
             .iter()
             .map(|provider| (provider.id(), provider.name(), provider.authenticate(cx)))
             .collect::<Vec<_>>();
@@ -429,7 +426,7 @@ impl NativeAgent {
                 .into_iter()
                 .flat_map(|(contents, prompt_metadata)| match contents {
                     Ok(contents) => Some(UserRulesContext {
-                        uuid: prompt_metadata.id.as_user()?,
+                        uuid: prompt_metadata.id.user_id()?,
                         title: prompt_metadata.title.map(|title| title.to_string()),
                         contents,
                     }),
@@ -1167,6 +1164,10 @@ impl acp_thread::AgentModelSelector for NativeAgentModelSelector {
     fn should_render_footer(&self) -> bool {
         true
     }
+
+    fn supports_favorites(&self) -> bool {
+        true
+    }
 }
 
 impl acp_thread::AgentConnection for NativeAgentConnection {
@@ -1629,9 +1630,7 @@ mod internal_tests {
                     id: acp::ModelId::new("fake/fake"),
                     name: "Fake".into(),
                     description: None,
-                    icon: Some(acp_thread::AgentModelIcon::Named(
-                        ui::IconName::ZedAssistant
-                    )),
+                    icon: Some(ui::IconName::ZedAssistant),
                 }]
             )])
         );

crates/agent/src/native_agent_server.rs

@@ -1,14 +1,10 @@
 use std::{any::Any, path::Path, rc::Rc, sync::Arc};
 
-use agent_client_protocol as acp;
 use agent_servers::{AgentServer, AgentServerDelegate};
-use agent_settings::AgentSettings;
 use anyhow::Result;
-use collections::HashSet;
 use fs::Fs;
 use gpui::{App, Entity, SharedString, Task};
 use prompt_store::PromptStore;
-use settings::{LanguageModelSelection, Settings as _, update_settings_file};
 
 use crate::{HistoryStore, NativeAgent, NativeAgentConnection, templates::Templates};
 
@@ -75,38 +71,6 @@ impl AgentServer for NativeAgentServer {
     fn into_any(self: Rc<Self>) -> Rc<dyn Any> {
         self
     }
-
-    fn favorite_model_ids(&self, cx: &mut App) -> HashSet<acp::ModelId> {
-        AgentSettings::get_global(cx).favorite_model_ids()
-    }
-
-    fn toggle_favorite_model(
-        &self,
-        model_id: acp::ModelId,
-        should_be_favorite: bool,
-        fs: Arc<dyn Fs>,
-        cx: &App,
-    ) {
-        let selection = model_id_to_selection(&model_id);
-        update_settings_file(fs, cx, move |settings, _| {
-            let agent = settings.agent.get_or_insert_default();
-            if should_be_favorite {
-                agent.add_favorite_model(selection.clone());
-            } else {
-                agent.remove_favorite_model(&selection);
-            }
-        });
-    }
-}
-
-/// Convert a ModelId (e.g. "anthropic/claude-3-5-sonnet") to a LanguageModelSelection.
-fn model_id_to_selection(model_id: &acp::ModelId) -> LanguageModelSelection {
-    let id = model_id.0.as_ref();
-    let (provider, model) = id.split_once('/').unwrap_or(("", id));
-    LanguageModelSelection {
-        provider: provider.to_owned().into(),
-        model: model.to_owned(),
-    }
 }
 
 #[cfg(test)]

crates/agent_servers/Cargo.toml

@@ -21,7 +21,6 @@ acp_tools.workspace = true
 acp_thread.workspace = true
 action_log.workspace = true
 agent-client-protocol.workspace = true
-feature_flags.workspace = true
 anyhow.workspace = true
 async-trait.workspace = true
 client.workspace = true

crates/agent_servers/src/acp.rs

@@ -4,7 +4,6 @@ use action_log::ActionLog;
 use agent_client_protocol::{self as acp, Agent as _, ErrorCode};
 use anyhow::anyhow;
 use collections::HashMap;
-use feature_flags::{AcpBetaFeatureFlag, FeatureFlagAppExt as _};
 use futures::AsyncBufReadExt as _;
 use futures::io::BufReader;
 use project::Project;
@@ -39,7 +38,6 @@ pub struct AcpConnection {
     agent_capabilities: acp::AgentCapabilities,
     default_mode: Option<acp::SessionModeId>,
     default_model: Option<acp::ModelId>,
-    default_config_options: HashMap<String, String>,
     root_dir: PathBuf,
     // NB: Don't move this into the wait_task, since we need to ensure the process is
     // killed on drop (setting kill_on_drop on the command seems to not always work).
@@ -49,29 +47,11 @@ pub struct AcpConnection {
     _stderr_task: Task<Result<()>>,
 }
 
-struct ConfigOptions {
-    config_options: Rc<RefCell<Vec<acp::SessionConfigOption>>>,
-    tx: Rc<RefCell<watch::Sender<()>>>,
-    rx: watch::Receiver<()>,
-}
-
-impl ConfigOptions {
-    fn new(config_options: Rc<RefCell<Vec<acp::SessionConfigOption>>>) -> Self {
-        let (tx, rx) = watch::channel(());
-        Self {
-            config_options,
-            tx: Rc::new(RefCell::new(tx)),
-            rx,
-        }
-    }
-}
-
 pub struct AcpSession {
     thread: WeakEntity<AcpThread>,
     suppress_abort_err: bool,
     models: Option<Rc<RefCell<acp::SessionModelState>>>,
     session_modes: Option<Rc<RefCell<acp::SessionModeState>>>,
-    config_options: Option<ConfigOptions>,
 }
 
 pub async fn connect(
@@ -80,7 +60,6 @@ pub async fn connect(
     root_dir: &Path,
     default_mode: Option<acp::SessionModeId>,
     default_model: Option<acp::ModelId>,
-    default_config_options: HashMap<String, String>,
     is_remote: bool,
     cx: &mut AsyncApp,
 ) -> Result<Rc<dyn AgentConnection>> {
@@ -90,7 +69,6 @@ pub async fn connect(
         root_dir,
         default_mode,
         default_model,
-        default_config_options,
         is_remote,
         cx,
     )
@@ -107,7 +85,6 @@ impl AcpConnection {
         root_dir: &Path,
         default_mode: Option<acp::SessionModeId>,
         default_model: Option<acp::ModelId>,
-        default_config_options: HashMap<String, String>,
         is_remote: bool,
         cx: &mut AsyncApp,
     ) -> Result<Self> {
@@ -240,7 +217,6 @@ impl AcpConnection {
             agent_capabilities: response.agent_capabilities,
             default_mode,
             default_model,
-            default_config_options,
             _io_task: io_task,
             _wait_task: wait_task,
             _stderr_task: stderr_task,
@@ -280,7 +256,6 @@ impl AgentConnection for AcpConnection {
         let sessions = self.sessions.clone();
         let default_mode = self.default_mode.clone();
         let default_model = self.default_model.clone();
-        let default_config_options = self.default_config_options.clone();
         let cwd = cwd.to_path_buf();
         let context_server_store = project.read(cx).context_server_store().read(cx);
         let mcp_servers = if project.read(cx).is_local() {
@@ -347,21 +322,8 @@ impl AgentConnection for AcpConnection {
                     }
                 })?;
 
-            let use_config_options = cx.update(|cx| cx.has_flag::<AcpBetaFeatureFlag>())?;
-
-            // Config options take precedence over legacy modes/models
-            let (modes, models, config_options) = if use_config_options && let Some(opts) = response.config_options {
-                (
-                    None,
-                    None,
-                    Some(Rc::new(RefCell::new(opts))),
-                )
-            } else {
-                // Fall back to legacy modes/models
-                let modes = response.modes.map(|modes| Rc::new(RefCell::new(modes)));
-                let models = response.models.map(|models| Rc::new(RefCell::new(models)));
-                (modes, models, None)
-            };
+            let modes = response.modes.map(|modes| Rc::new(RefCell::new(modes)));
+            let models = response.models.map(|models| Rc::new(RefCell::new(models)));
 
             if let Some(default_mode) = default_mode {
                 if let Some(modes) = modes.as_ref() {
@@ -449,92 +411,6 @@ impl AgentConnection for AcpConnection {
                 }
             }
 
-            if let Some(config_opts) = config_options.as_ref() {
-                let defaults_to_apply: Vec<_> = {
-                    let config_opts_ref = config_opts.borrow();
-                    config_opts_ref
-                        .iter()
-                        .filter_map(|config_option| {
-                            let default_value = default_config_options.get(&*config_option.id.0)?;
-
-                            let is_valid = match &config_option.kind {
-                                acp::SessionConfigKind::Select(select) => match &select.options {
-                                    acp::SessionConfigSelectOptions::Ungrouped(options) => {
-                                        options.iter().any(|opt| &*opt.value.0 == default_value.as_str())
-                                    }
-                                    acp::SessionConfigSelectOptions::Grouped(groups) => groups
-                                        .iter()
-                                        .any(|g| g.options.iter().any(|opt| &*opt.value.0 == default_value.as_str())),
-                                    _ => false,
-                                },
-                                _ => false,
-                            };
-
-                            if is_valid {
-                                let initial_value = match &config_option.kind {
-                                    acp::SessionConfigKind::Select(select) => {
-                                        Some(select.current_value.clone())
-                                    }
-                                    _ => None,
-                                };
-                                Some((config_option.id.clone(), default_value.clone(), initial_value))
-                            } else {
-                                log::warn!(
-                                    "`{}` is not a valid value for config option `{}` in {}",
-                                    default_value,
-                                    config_option.id.0,
-                                    name
-                                );
-                                None
-                            }
-                        })
-                        .collect()
-                };
-
-                for (config_id, default_value, initial_value) in defaults_to_apply {
-                    cx.spawn({
-                        let default_value_id = acp::SessionConfigValueId::new(default_value.clone());
-                        let session_id = response.session_id.clone();
-                        let config_id_clone = config_id.clone();
-                        let config_opts = config_opts.clone();
-                        let conn = conn.clone();
-                        async move |_| {
-                            let result = conn
-                                .set_session_config_option(
-                                    acp::SetSessionConfigOptionRequest::new(
-                                        session_id,
-                                        config_id_clone.clone(),
-                                        default_value_id,
-                                    ),
-                                )
-                                .await
-                                .log_err();
-
-                            if result.is_none() {
-                                if let Some(initial) = initial_value {
-                                    let mut opts = config_opts.borrow_mut();
-                                    if let Some(opt) = opts.iter_mut().find(|o| o.id == config_id_clone) {
-                                        if let acp::SessionConfigKind::Select(select) =
-                                            &mut opt.kind
-                                        {
-                                            select.current_value = initial;
-                                        }
-                                    }
-                                }
-                            }
-                        }
-                    })
-                    .detach();
-
-                    let mut opts = config_opts.borrow_mut();
-                    if let Some(opt) = opts.iter_mut().find(|o| o.id == config_id) {
-                        if let acp::SessionConfigKind::Select(select) = &mut opt.kind {
-                            select.current_value = acp::SessionConfigValueId::new(default_value);
-                        }
-                    }
-                }
-            }
-
             let session_id = response.session_id;
             let action_log = cx.new(|_| ActionLog::new(project.clone()))?;
             let thread = cx.new(|cx| {
@@ -556,7 +432,6 @@ impl AgentConnection for AcpConnection {
                 suppress_abort_err: false,
                 session_modes: modes,
                 models,
-                config_options: config_options.map(|opts| ConfigOptions::new(opts))
             };
             sessions.borrow_mut().insert(session_id, session);
 
@@ -692,25 +567,6 @@ impl AgentConnection for AcpConnection {
         }
     }
 
-    fn session_config_options(
-        &self,
-        session_id: &acp::SessionId,
-        _cx: &App,
-    ) -> Option<Rc<dyn acp_thread::AgentSessionConfigOptions>> {
-        let sessions = self.sessions.borrow();
-        let session = sessions.get(session_id)?;
-
-        let config_opts = session.config_options.as_ref()?;
-
-        Some(Rc::new(AcpSessionConfigOptions {
-            session_id: session_id.clone(),
-            connection: self.connection.clone(),
-            state: config_opts.config_options.clone(),
-            watch_tx: config_opts.tx.clone(),
-            watch_rx: config_opts.rx.clone(),
-        }) as _)
-    }
-
     fn into_any(self: Rc<Self>) -> Rc<dyn Any> {
         self
     }
@@ -829,49 +685,6 @@ impl acp_thread::AgentModelSelector for AcpModelSelector {
     }
 }
 
-struct AcpSessionConfigOptions {
-    session_id: acp::SessionId,
-    connection: Rc<acp::ClientSideConnection>,
-    state: Rc<RefCell<Vec<acp::SessionConfigOption>>>,
-    watch_tx: Rc<RefCell<watch::Sender<()>>>,
-    watch_rx: watch::Receiver<()>,
-}
-
-impl acp_thread::AgentSessionConfigOptions for AcpSessionConfigOptions {
-    fn config_options(&self) -> Vec<acp::SessionConfigOption> {
-        self.state.borrow().clone()
-    }
-
-    fn set_config_option(
-        &self,
-        config_id: acp::SessionConfigId,
-        value: acp::SessionConfigValueId,
-        cx: &mut App,
-    ) -> Task<Result<Vec<acp::SessionConfigOption>>> {
-        let connection = self.connection.clone();
-        let session_id = self.session_id.clone();
-        let state = self.state.clone();
-
-        let watch_tx = self.watch_tx.clone();
-
-        cx.foreground_executor().spawn(async move {
-            let response = connection
-                .set_session_config_option(acp::SetSessionConfigOptionRequest::new(
-                    session_id, config_id, value,
-                ))
-                .await?;
-
-            *state.borrow_mut() = response.config_options.clone();
-            watch_tx.borrow_mut().send(()).ok();
-            Ok(response.config_options)
-        })
-    }
-
-    fn watch(&self, _cx: &mut App) -> Option<watch::Receiver<()>> {
-        Some(self.watch_rx.clone())
-    }
-}
-
 struct ClientDelegate {
     sessions: Rc<RefCell<HashMap<acp::SessionId, AcpSession>>>,
     cx: AsyncApp,
@@ -965,21 +778,6 @@ impl acp::Client for ClientDelegate {
             }
         }
 
-        if let acp::SessionUpdate::ConfigOptionUpdate(acp::ConfigOptionUpdate {
-            config_options,
-            ..
-        }) = &notification.update
-        {
-            if let Some(opts) = &session.config_options {
-                *opts.config_options.borrow_mut() = config_options.clone();
-                opts.tx.borrow_mut().send(()).ok();
-            } else {
-                log::error!(
-                    "Got a `ConfigOptionUpdate` notification, but the agent didn't specify `config_options` during session setup."
-                );
-            }
-        }
-
         // Clone so we can inspect meta both before and after handing off to the thread
         let update_clone = notification.update.clone();
 

crates/agent_servers/src/agent_servers.rs

@@ -10,7 +10,7 @@ pub mod e2e_tests;
 pub use claude::*;
 use client::ProxySettings;
 pub use codex::*;
-use collections::{HashMap, HashSet};
+use collections::HashMap;
 pub use custom::*;
 use fs::Fs;
 pub use gemini::*;
@@ -56,19 +56,9 @@ impl AgentServerDelegate {
 pub trait AgentServer: Send {
     fn logo(&self) -> ui::IconName;
     fn name(&self) -> SharedString;
-    fn connect(
-        &self,
-        root_dir: Option<&Path>,
-        delegate: AgentServerDelegate,
-        cx: &mut App,
-    ) -> Task<Result<(Rc<dyn AgentConnection>, Option<task::SpawnInTerminal>)>>;
-
-    fn into_any(self: Rc<Self>) -> Rc<dyn Any>;
-
-    fn default_mode(&self, _cx: &App) -> Option<agent_client_protocol::SessionModeId> {
+    fn default_mode(&self, _cx: &mut App) -> Option<agent_client_protocol::SessionModeId> {
         None
     }
-
     fn set_default_mode(
         &self,
         _mode_id: Option<agent_client_protocol::SessionModeId>,
@@ -77,7 +67,7 @@ pub trait AgentServer: Send {
     ) {
     }
 
-    fn default_model(&self, _cx: &App) -> Option<agent_client_protocol::ModelId> {
+    fn default_model(&self, _cx: &mut App) -> Option<agent_client_protocol::ModelId> {
         None
     }
 
@@ -89,49 +79,14 @@ pub trait AgentServer: Send {
     ) {
     }
 
-    fn favorite_model_ids(&self, _cx: &mut App) -> HashSet<agent_client_protocol::ModelId> {
-        HashSet::default()
-    }
-
-    fn default_config_option(&self, _config_id: &str, _cx: &App) -> Option<String> {
-        None
-    }
-
-    fn set_default_config_option(
+    fn connect(
         &self,
-        _config_id: &str,
-        _value_id: Option<&str>,
-        _fs: Arc<dyn Fs>,
-        _cx: &mut App,
-    ) {
-    }
+        root_dir: Option<&Path>,
+        delegate: AgentServerDelegate,
+        cx: &mut App,
+    ) -> Task<Result<(Rc<dyn AgentConnection>, Option<task::SpawnInTerminal>)>>;
 
-    fn favorite_config_option_value_ids(
-        &self,
-        _config_id: &agent_client_protocol::SessionConfigId,
-        _cx: &mut App,
-    ) -> HashSet<agent_client_protocol::SessionConfigValueId> {
-        HashSet::default()
-    }
-
-    fn toggle_favorite_config_option_value(
-        &self,
-        _config_id: agent_client_protocol::SessionConfigId,
-        _value_id: agent_client_protocol::SessionConfigValueId,
-        _should_be_favorite: bool,
-        _fs: Arc<dyn Fs>,
-        _cx: &App,
-    ) {
-    }
-
-    fn toggle_favorite_model(
-        &self,
-        _model_id: agent_client_protocol::ModelId,
-        _should_be_favorite: bool,
-        _fs: Arc<dyn Fs>,
-        _cx: &App,
-    ) {
-    }
+    fn into_any(self: Rc<Self>) -> Rc<dyn Any>;
 }
 
 impl dyn AgentServer {

crates/agent_servers/src/claude.rs

@@ -1,5 +1,4 @@
 use agent_client_protocol as acp;
-use collections::HashSet;
 use fs::Fs;
 use settings::{SettingsStore, update_settings_file};
 use std::path::Path;
@@ -31,7 +30,7 @@ impl AgentServer for ClaudeCode {
         ui::IconName::AiClaude
     }
 
-    fn default_mode(&self, cx: &App) -> Option<acp::SessionModeId> {
+    fn default_mode(&self, cx: &mut App) -> Option<acp::SessionModeId> {
         let settings = cx.read_global(|settings: &SettingsStore, _| {
             settings.get::<AllAgentServersSettings>(None).claude.clone()
         });
@@ -52,7 +51,7 @@ impl AgentServer for ClaudeCode {
         });
     }
 
-    fn default_model(&self, cx: &App) -> Option<acp::ModelId> {
+    fn default_model(&self, cx: &mut App) -> Option<acp::ModelId> {
         let settings = cx.read_global(|settings: &SettingsStore, _| {
             settings.get::<AllAgentServersSettings>(None).claude.clone()
         });
@@ -73,139 +72,6 @@ impl AgentServer for ClaudeCode {
         });
     }
 
-    fn favorite_model_ids(&self, cx: &mut App) -> HashSet<acp::ModelId> {
-        let settings = cx.read_global(|settings: &SettingsStore, _| {
-            settings.get::<AllAgentServersSettings>(None).claude.clone()
-        });
-
-        settings
-            .as_ref()
-            .map(|s| {
-                s.favorite_models
-                    .iter()
-                    .map(|id| acp::ModelId::new(id.clone()))
-                    .collect()
-            })
-            .unwrap_or_default()
-    }
-
-    fn toggle_favorite_model(
-        &self,
-        model_id: acp::ModelId,
-        should_be_favorite: bool,
-        fs: Arc<dyn Fs>,
-        cx: &App,
-    ) {
-        update_settings_file(fs, cx, move |settings, _| {
-            let favorite_models = &mut settings
-                .agent_servers
-                .get_or_insert_default()
-                .claude
-                .get_or_insert_default()
-                .favorite_models;
-
-            let model_id_str = model_id.to_string();
-            if should_be_favorite {
-                if !favorite_models.contains(&model_id_str) {
-                    favorite_models.push(model_id_str);
-                }
-            } else {
-                favorite_models.retain(|id| id != &model_id_str);
-            }
-        });
-    }
-
-    fn default_config_option(&self, config_id: &str, cx: &App) -> Option<String> {
-        let settings = cx.read_global(|settings: &SettingsStore, _| {
-            settings.get::<AllAgentServersSettings>(None).claude.clone()
-        });
-
-        settings
-            .as_ref()
-            .and_then(|s| s.default_config_options.get(config_id).cloned())
-    }
-
-    fn set_default_config_option(
-        &self,
-        config_id: &str,
-        value_id: Option<&str>,
-        fs: Arc<dyn Fs>,
-        cx: &mut App,
-    ) {
-        let config_id = config_id.to_string();
-        let value_id = value_id.map(|s| s.to_string());
-        update_settings_file(fs, cx, move |settings, _| {
-            let config_options = &mut settings
-                .agent_servers
-                .get_or_insert_default()
-                .claude
-                .get_or_insert_default()
-                .default_config_options;
-
-            if let Some(value) = value_id.clone() {
-                config_options.insert(config_id.clone(), value);
-            } else {
-                config_options.remove(&config_id);
-            }
-        });
-    }
-
-    fn favorite_config_option_value_ids(
-        &self,
-        config_id: &acp::SessionConfigId,
-        cx: &mut App,
-    ) -> HashSet<acp::SessionConfigValueId> {
-        let settings = cx.read_global(|settings: &SettingsStore, _| {
-            settings.get::<AllAgentServersSettings>(None).claude.clone()
-        });
-
-        settings
-            .as_ref()
-            .and_then(|s| s.favorite_config_option_values.get(config_id.0.as_ref()))
-            .map(|values| {
-                values
-                    .iter()
-                    .cloned()
-                    .map(acp::SessionConfigValueId::new)
-                    .collect()
-            })
-            .unwrap_or_default()
-    }
-
-    fn toggle_favorite_config_option_value(
-        &self,
-        config_id: acp::SessionConfigId,
-        value_id: acp::SessionConfigValueId,
-        should_be_favorite: bool,
-        fs: Arc<dyn Fs>,
-        cx: &App,
-    ) {
-        let config_id = config_id.to_string();
-        let value_id = value_id.to_string();
-
-        update_settings_file(fs, cx, move |settings, _| {
-            let favorites = &mut settings
-                .agent_servers
-                .get_or_insert_default()
-                .claude
-                .get_or_insert_default()
-                .favorite_config_option_values;
-
-            let entry = favorites.entry(config_id.clone()).or_insert_with(Vec::new);
-
-            if should_be_favorite {
-                if !entry.iter().any(|v| v == &value_id) {
-                    entry.push(value_id.clone());
-                }
-            } else {
-                entry.retain(|v| v != &value_id);
-                if entry.is_empty() {
-                    favorites.remove(&config_id);
-                }
-            }
-        });
-    }
-
     fn connect(
         &self,
         root_dir: Option<&Path>,
@@ -219,14 +85,6 @@ impl AgentServer for ClaudeCode {
         let extra_env = load_proxy_env(cx);
         let default_mode = self.default_mode(cx);
         let default_model = self.default_model(cx);
-        let default_config_options = cx.read_global(|settings: &SettingsStore, _| {
-            settings
-                .get::<AllAgentServersSettings>(None)
-                .claude
-                .as_ref()
-                .map(|s| s.default_config_options.clone())
-                .unwrap_or_default()
-        });
 
         cx.spawn(async move |cx| {
             let (command, root_dir, login) = store
@@ -249,7 +107,6 @@ impl AgentServer for ClaudeCode {
                 root_dir.as_ref(),
                 default_mode,
                 default_model,
-                default_config_options,
                 is_remote,
                 cx,
             )

crates/agent_servers/src/codex.rs

@@ -5,7 +5,6 @@ use std::{any::Any, path::Path};
 use acp_thread::AgentConnection;
 use agent_client_protocol as acp;
 use anyhow::{Context as _, Result};
-use collections::HashSet;
 use fs::Fs;
 use gpui::{App, AppContext as _, SharedString, Task};
 use project::agent_server_store::{AllAgentServersSettings, CODEX_NAME};
@@ -32,7 +31,7 @@ impl AgentServer for Codex {
         ui::IconName::AiOpenAi
     }
 
-    fn default_mode(&self, cx: &App) -> Option<acp::SessionModeId> {
+    fn default_mode(&self, cx: &mut App) -> Option<acp::SessionModeId> {
         let settings = cx.read_global(|settings: &SettingsStore, _| {
             settings.get::<AllAgentServersSettings>(None).codex.clone()
         });
@@ -53,7 +52,7 @@ impl AgentServer for Codex {
         });
     }
 
-    fn default_model(&self, cx: &App) -> Option<acp::ModelId> {
+    fn default_model(&self, cx: &mut App) -> Option<acp::ModelId> {
         let settings = cx.read_global(|settings: &SettingsStore, _| {
             settings.get::<AllAgentServersSettings>(None).codex.clone()
         });
@@ -74,139 +73,6 @@ impl AgentServer for Codex {
         });
     }
 
-    fn favorite_model_ids(&self, cx: &mut App) -> HashSet<acp::ModelId> {
-        let settings = cx.read_global(|settings: &SettingsStore, _| {
-            settings.get::<AllAgentServersSettings>(None).codex.clone()
-        });
-
-        settings
-            .as_ref()
-            .map(|s| {
-                s.favorite_models
-                    .iter()
-                    .map(|id| acp::ModelId::new(id.clone()))
-                    .collect()
-            })
-            .unwrap_or_default()
-    }
-
-    fn toggle_favorite_model(
-        &self,
-        model_id: acp::ModelId,
-        should_be_favorite: bool,
-        fs: Arc<dyn Fs>,
-        cx: &App,
-    ) {
-        update_settings_file(fs, cx, move |settings, _| {
-            let favorite_models = &mut settings
-                .agent_servers
-                .get_or_insert_default()
-                .codex
-                .get_or_insert_default()
-                .favorite_models;
-
-            let model_id_str = model_id.to_string();
-            if should_be_favorite {
-                if !favorite_models.contains(&model_id_str) {
-                    favorite_models.push(model_id_str);
-                }
-            } else {
-                favorite_models.retain(|id| id != &model_id_str);
-            }
-        });
-    }
-
-    fn default_config_option(&self, config_id: &str, cx: &App) -> Option<String> {
-        let settings = cx.read_global(|settings: &SettingsStore, _| {
-            settings.get::<AllAgentServersSettings>(None).codex.clone()
-        });
-
-        settings
-            .as_ref()
-            .and_then(|s| s.default_config_options.get(config_id).cloned())
-    }
-
-    fn set_default_config_option(
-        &self,
-        config_id: &str,
-        value_id: Option<&str>,
-        fs: Arc<dyn Fs>,
-        cx: &mut App,
-    ) {
-        let config_id = config_id.to_string();
-        let value_id = value_id.map(|s| s.to_string());
-        update_settings_file(fs, cx, move |settings, _| {
-            let config_options = &mut settings
-                .agent_servers
-                .get_or_insert_default()
-                .codex
-                .get_or_insert_default()
-                .default_config_options;
-
-            if let Some(value) = value_id.clone() {
-                config_options.insert(config_id.clone(), value);
-            } else {
-                config_options.remove(&config_id);
-            }
-        });
-    }
-
-    fn favorite_config_option_value_ids(
-        &self,
-        config_id: &acp::SessionConfigId,
-        cx: &mut App,
-    ) -> HashSet<acp::SessionConfigValueId> {
-        let settings = cx.read_global(|settings: &SettingsStore, _| {
-            settings.get::<AllAgentServersSettings>(None).codex.clone()
-        });
-
-        settings
-            .as_ref()
-            .and_then(|s| s.favorite_config_option_values.get(config_id.0.as_ref()))
-            .map(|values| {
-                values
-                    .iter()
-                    .cloned()
-                    .map(acp::SessionConfigValueId::new)
-                    .collect()
-            })
-            .unwrap_or_default()
-    }
-
-    fn toggle_favorite_config_option_value(
-        &self,
-        config_id: acp::SessionConfigId,
-        value_id: acp::SessionConfigValueId,
-        should_be_favorite: bool,
-        fs: Arc<dyn Fs>,
-        cx: &App,
-    ) {
-        let config_id = config_id.to_string();
-        let value_id = value_id.to_string();
-
-        update_settings_file(fs, cx, move |settings, _| {
-            let favorites = &mut settings
-                .agent_servers
-                .get_or_insert_default()
-                .codex
-                .get_or_insert_default()
-                .favorite_config_option_values;
-
-            let entry = favorites.entry(config_id.clone()).or_insert_with(Vec::new);
-
-            if should_be_favorite {
-                if !entry.iter().any(|v| v == &value_id) {
-                    entry.push(value_id.clone());
-                }
-            } else {
-                entry.retain(|v| v != &value_id);
-                if entry.is_empty() {
-                    favorites.remove(&config_id);
-                }
-            }
-        });
-    }
-
     fn connect(
         &self,
         root_dir: Option<&Path>,
@@ -220,14 +86,6 @@ impl AgentServer for Codex {
         let extra_env = load_proxy_env(cx);
         let default_mode = self.default_mode(cx);
         let default_model = self.default_model(cx);
-        let default_config_options = cx.read_global(|settings: &SettingsStore, _| {
-            settings
-                .get::<AllAgentServersSettings>(None)
-                .codex
-                .as_ref()
-                .map(|s| s.default_config_options.clone())
-                .unwrap_or_default()
-        });
 
         cx.spawn(async move |cx| {
             let (command, root_dir, login) = store
@@ -251,7 +109,6 @@ impl AgentServer for Codex {
                 root_dir.as_ref(),
                 default_mode,
                 default_model,
-                default_config_options,
                 is_remote,
                 cx,
             )

crates/agent_servers/src/custom.rs

@@ -2,7 +2,6 @@ use crate::{AgentServer, AgentServerDelegate, load_proxy_env};
 use acp_thread::AgentConnection;
 use agent_client_protocol as acp;
 use anyhow::{Context as _, Result};
-use collections::HashSet;
 use fs::Fs;
 use gpui::{App, AppContext as _, SharedString, Task};
 use project::agent_server_store::{AllAgentServersSettings, ExternalAgentServerName};
@@ -30,7 +29,7 @@ impl AgentServer for CustomAgentServer {
         IconName::Terminal
     }
 
-    fn default_mode(&self, cx: &App) -> Option<acp::SessionModeId> {
+    fn default_mode(&self, cx: &mut App) -> Option<acp::SessionModeId> {
         let settings = cx.read_global(|settings: &SettingsStore, _| {
             settings
                 .get::<AllAgentServersSettings>(None)
@@ -44,86 +43,6 @@ impl AgentServer for CustomAgentServer {
             .and_then(|s| s.default_mode().map(acp::SessionModeId::new))
     }
 
-    fn favorite_config_option_value_ids(
-        &self,
-        config_id: &acp::SessionConfigId,
-        cx: &mut App,
-    ) -> HashSet<acp::SessionConfigValueId> {
-        let settings = cx.read_global(|settings: &SettingsStore, _| {
-            settings
-                .get::<AllAgentServersSettings>(None)
-                .custom
-                .get(&self.name())
-                .cloned()
-        });
-
-        settings
-            .as_ref()
-            .and_then(|s| s.favorite_config_option_values(config_id.0.as_ref()))
-            .map(|values| {
-                values
-                    .iter()
-                    .cloned()
-                    .map(acp::SessionConfigValueId::new)
-                    .collect()
-            })
-            .unwrap_or_default()
-    }
-
-    fn toggle_favorite_config_option_value(
-        &self,
-        config_id: acp::SessionConfigId,
-        value_id: acp::SessionConfigValueId,
-        should_be_favorite: bool,
-        fs: Arc<dyn Fs>,
-        cx: &App,
-    ) {
-        let name = self.name();
-        let config_id = config_id.to_string();
-        let value_id = value_id.to_string();
-
-        update_settings_file(fs, cx, move |settings, _| {
-            let settings = settings
-                .agent_servers
-                .get_or_insert_default()
-                .custom
-                .entry(name.clone())
-                .or_insert_with(|| settings::CustomAgentServerSettings::Extension {
-                    default_model: None,
-                    default_mode: None,
-                    favorite_models: Vec::new(),
-                    default_config_options: Default::default(),
-                    favorite_config_option_values: Default::default(),
-                });
-
-            match settings {
-                settings::CustomAgentServerSettings::Custom {
-                    favorite_config_option_values,
-                    ..
-                }
-                | settings::CustomAgentServerSettings::Extension {
-                    favorite_config_option_values,
-                    ..
-                } => {
-                    let entry = favorite_config_option_values
-                        .entry(config_id.clone())
-                        .or_insert_with(Vec::new);
-
-                    if should_be_favorite {
-                        if !entry.iter().any(|v| v == &value_id) {
-                            entry.push(value_id.clone());
-                        }
-                    } else {
-                        entry.retain(|v| v != &value_id);
-                        if entry.is_empty() {
-                            favorite_config_option_values.remove(&config_id);
-                        }
-                    }
-                }
-            }
-        });
-    }
-
     fn set_default_mode(&self, mode_id: Option<acp::SessionModeId>, fs: Arc<dyn Fs>, cx: &mut App) {
         let name = self.name();
         update_settings_file(fs, cx, move |settings, _| {
@@ -135,9 +54,6 @@ impl AgentServer for CustomAgentServer {
                 .or_insert_with(|| settings::CustomAgentServerSettings::Extension {
                     default_model: None,
                     default_mode: None,
-                    favorite_models: Vec::new(),
-                    default_config_options: Default::default(),
-                    favorite_config_option_values: Default::default(),
                 });
 
             match settings {
@@ -149,7 +65,7 @@ impl AgentServer for CustomAgentServer {
         });
     }
 
-    fn default_model(&self, cx: &App) -> Option<acp::ModelId> {
+    fn default_model(&self, cx: &mut App) -> Option<acp::ModelId> {
         let settings = cx.read_global(|settings: &SettingsStore, _| {
             settings
                 .get::<AllAgentServersSettings>(None)
@@ -174,9 +90,6 @@ impl AgentServer for CustomAgentServer {
                 .or_insert_with(|| settings::CustomAgentServerSettings::Extension {
                     default_model: None,
                     default_mode: None,
-                    favorite_models: Vec::new(),
-                    default_config_options: Default::default(),
-                    favorite_config_option_values: Default::default(),
                 });
 
             match settings {
@@ -188,125 +101,6 @@ impl AgentServer for CustomAgentServer {
         });
     }
 
-    fn favorite_model_ids(&self, cx: &mut App) -> HashSet<acp::ModelId> {
-        let settings = cx.read_global(|settings: &SettingsStore, _| {
-            settings
-                .get::<AllAgentServersSettings>(None)
-                .custom
-                .get(&self.name())
-                .cloned()
-        });
-
-        settings
-            .as_ref()
-            .map(|s| {
-                s.favorite_models()
-                    .iter()
-                    .map(|id| acp::ModelId::new(id.clone()))
-                    .collect()
-            })
-            .unwrap_or_default()
-    }
-
-    fn toggle_favorite_model(
-        &self,
-        model_id: acp::ModelId,
-        should_be_favorite: bool,
-        fs: Arc<dyn Fs>,
-        cx: &App,
-    ) {
-        let name = self.name();
-        update_settings_file(fs, cx, move |settings, _| {
-            let settings = settings
-                .agent_servers
-                .get_or_insert_default()
-                .custom
-                .entry(name.clone())
-                .or_insert_with(|| settings::CustomAgentServerSettings::Extension {
-                    default_model: None,
-                    default_mode: None,
-                    favorite_models: Vec::new(),
-                    default_config_options: Default::default(),
-                    favorite_config_option_values: Default::default(),
-                });
-
-            let favorite_models = match settings {
-                settings::CustomAgentServerSettings::Custom {
-                    favorite_models, ..
-                }
-                | settings::CustomAgentServerSettings::Extension {
-                    favorite_models, ..
-                } => favorite_models,
-            };
-
-            let model_id_str = model_id.to_string();
-            if should_be_favorite {
-                if !favorite_models.contains(&model_id_str) {
-                    favorite_models.push(model_id_str);
-                }
-            } else {
-                favorite_models.retain(|id| id != &model_id_str);
-            }
-        });
-    }
-
-    fn default_config_option(&self, config_id: &str, cx: &App) -> Option<String> {
-        let settings = cx.read_global(|settings: &SettingsStore, _| {
-            settings
-                .get::<AllAgentServersSettings>(None)
-                .custom
-                .get(&self.name())
-                .cloned()
-        });
-
-        settings
-            .as_ref()
-            .and_then(|s| s.default_config_option(config_id).map(|s| s.to_string()))
-    }
-
-    fn set_default_config_option(
-        &self,
-        config_id: &str,
-        value_id: Option<&str>,
-        fs: Arc<dyn Fs>,
-        cx: &mut App,
-    ) {
-        let name = self.name();
-        let config_id = config_id.to_string();
-        let value_id = value_id.map(|s| s.to_string());
-        update_settings_file(fs, cx, move |settings, _| {
-            let settings = settings
-                .agent_servers
-                .get_or_insert_default()
-                .custom
-                .entry(name.clone())
-                .or_insert_with(|| settings::CustomAgentServerSettings::Extension {
-                    default_model: None,
-                    default_mode: None,
-                    favorite_models: Vec::new(),
-                    default_config_options: Default::default(),
-                    favorite_config_option_values: Default::default(),
-                });
-
-            match settings {
-                settings::CustomAgentServerSettings::Custom {
-                    default_config_options,
-                    ..
-                }
-                | settings::CustomAgentServerSettings::Extension {
-                    default_config_options,
-                    ..
-                } => {
-                    if let Some(value) = value_id.clone() {
-                        default_config_options.insert(config_id.clone(), value);
-                    } else {
-                        default_config_options.remove(&config_id);
-                    }
-                }
-            }
-        });
-    }
-
     fn connect(
         &self,
         root_dir: Option<&Path>,
@@ -318,23 +112,6 @@ impl AgentServer for CustomAgentServer {
         let is_remote = delegate.project.read(cx).is_via_remote_server();
         let default_mode = self.default_mode(cx);
         let default_model = self.default_model(cx);
-        let default_config_options = cx.read_global(|settings: &SettingsStore, _| {
-            settings
-                .get::<AllAgentServersSettings>(None)
-                .custom
-                .get(&self.name())
-                .map(|s| match s {
-                    project::agent_server_store::CustomAgentServerSettings::Custom {
-                        default_config_options,
-                        ..
-                    }
-                    | project::agent_server_store::CustomAgentServerSettings::Extension {
-                        default_config_options,
-                        ..
-                    } => default_config_options.clone(),
-                })
-                .unwrap_or_default()
-        });
         let store = delegate.store.downgrade();
         let extra_env = load_proxy_env(cx);
         cx.spawn(async move |cx| {
@@ -360,7 +137,6 @@ impl AgentServer for CustomAgentServer {
                 root_dir.as_ref(),
                 default_mode,
                 default_model,
-                default_config_options,
                 is_remote,
                 cx,
             )

crates/agent_servers/src/e2e_tests.rs

@@ -455,12 +455,20 @@ pub async fn init_test(cx: &mut TestAppContext) -> Arc<FakeFs> {
             project::agent_server_store::AllAgentServersSettings {
                 claude: Some(BuiltinAgentServerSettings {
                     path: Some("claude-code-acp".into()),
-                    ..Default::default()
+                    args: None,
+                    env: None,
+                    ignore_system_version: None,
+                    default_mode: None,
+                    default_model: None,
                 }),
                 gemini: Some(crate::gemini::tests::local_command().into()),
                 codex: Some(BuiltinAgentServerSettings {
                     path: Some("codex-acp".into()),
-                    ..Default::default()
+                    args: None,
+                    env: None,
+                    ignore_system_version: None,
+                    default_mode: None,
+                    default_model: None,
                 }),
                 custom: collections::HashMap::default(),
             },

crates/agent_servers/src/gemini.rs

@@ -4,10 +4,9 @@ use std::{any::Any, path::Path};
 use crate::{AgentServer, AgentServerDelegate, load_proxy_env};
 use acp_thread::AgentConnection;
 use anyhow::{Context as _, Result};
-use gpui::{App, AppContext as _, SharedString, Task};
+use gpui::{App, SharedString, Task};
 use language_models::provider::google::GoogleLanguageModelProvider;
-use project::agent_server_store::{AllAgentServersSettings, GEMINI_NAME};
-use settings::SettingsStore;
+use project::agent_server_store::GEMINI_NAME;
 
 #[derive(Clone)]
 pub struct Gemini;
@@ -34,14 +33,6 @@ impl AgentServer for Gemini {
         let mut extra_env = load_proxy_env(cx);
         let default_mode = self.default_mode(cx);
         let default_model = self.default_model(cx);
-        let default_config_options = cx.read_global(|settings: &SettingsStore, _| {
-            settings
-                .get::<AllAgentServersSettings>(None)
-                .gemini
-                .as_ref()
-                .map(|s| s.default_config_options.clone())
-                .unwrap_or_default()
-        });
 
         cx.spawn(async move |cx| {
             extra_env.insert("SURFACE".to_owned(), "zed".to_owned());
@@ -74,7 +65,6 @@ impl AgentServer for Gemini {
                 root_dir.as_ref(),
                 default_mode,
                 default_model,
-                default_config_options,
                 is_remote,
                 cx,
             )

crates/agent_ui/src/acp.rs

@@ -1,4 +1,3 @@
-mod config_options;
 mod entry_view_state;
 mod message_editor;
 mod mode_selector;

crates/agent_ui/src/acp/config_options.rs

@@ -1,772 +0,0 @@
-use std::{cmp::Reverse, rc::Rc, sync::Arc};
-
-use acp_thread::AgentSessionConfigOptions;
-use agent_client_protocol as acp;
-use agent_servers::AgentServer;
-use collections::HashSet;
-use fs::Fs;
-use fuzzy::StringMatchCandidate;
-use gpui::{
-    BackgroundExecutor, Context, DismissEvent, Entity, Subscription, Task, Window, prelude::*,
-};
-use ordered_float::OrderedFloat;
-use picker::popover_menu::PickerPopoverMenu;
-use picker::{Picker, PickerDelegate};
-use settings::SettingsStore;
-use ui::{
-    ElevationIndex, IconButton, ListItem, ListItemSpacing, PopoverMenuHandle, Tooltip, prelude::*,
-};
-use util::ResultExt as _;
-
-use crate::ui::HoldForDefault;
-
-const PICKER_THRESHOLD: usize = 5;
-
-pub struct ConfigOptionsView {
-    config_options: Rc<dyn AgentSessionConfigOptions>,
-    selectors: Vec<Entity<ConfigOptionSelector>>,
-    agent_server: Rc<dyn AgentServer>,
-    fs: Arc<dyn Fs>,
-    config_option_ids: Vec<acp::SessionConfigId>,
-    _refresh_task: Task<()>,
-}
-
-impl ConfigOptionsView {
-    pub fn new(
-        config_options: Rc<dyn AgentSessionConfigOptions>,
-        agent_server: Rc<dyn AgentServer>,
-        fs: Arc<dyn Fs>,
-        window: &mut Window,
-        cx: &mut Context<Self>,
-    ) -> Self {
-        let selectors = Self::build_selectors(&config_options, &agent_server, &fs, window, cx);
-        let config_option_ids = Self::config_option_ids(&config_options);
-
-        let rx = config_options.watch(cx);
-        let refresh_task = cx.spawn_in(window, async move |this, cx| {
-            if let Some(mut rx) = rx {
-                while let Ok(()) = rx.recv().await {
-                    this.update_in(cx, |this, window, cx| {
-                        this.refresh_selectors_if_needed(window, cx);
-                        cx.notify();
-                    })
-                    .log_err();
-                }
-            }
-        });
-
-        Self {
-            config_options,
-            selectors,
-            agent_server,
-            fs,
-            config_option_ids,
-            _refresh_task: refresh_task,
-        }
-    }
-
-    fn config_option_ids(
-        config_options: &Rc<dyn AgentSessionConfigOptions>,
-    ) -> Vec<acp::SessionConfigId> {
-        config_options
-            .config_options()
-            .into_iter()
-            .map(|option| option.id)
-            .collect()
-    }
-
-    fn refresh_selectors_if_needed(&mut self, window: &mut Window, cx: &mut Context<Self>) {
-        let current_ids = Self::config_option_ids(&self.config_options);
-        if current_ids != self.config_option_ids {
-            self.config_option_ids = current_ids;
-            self.rebuild_selectors(window, cx);
-        }
-    }
-
-    fn rebuild_selectors(&mut self, window: &mut Window, cx: &mut Context<Self>) {
-        self.selectors = Self::build_selectors(
-            &self.config_options,
-            &self.agent_server,
-            &self.fs,
-            window,
-            cx,
-        );
-        cx.notify();
-    }
-
-    fn build_selectors(
-        config_options: &Rc<dyn AgentSessionConfigOptions>,
-        agent_server: &Rc<dyn AgentServer>,
-        fs: &Arc<dyn Fs>,
-        window: &mut Window,
-        cx: &mut Context<Self>,
-    ) -> Vec<Entity<ConfigOptionSelector>> {
-        config_options
-            .config_options()
-            .into_iter()
-            .map(|option| {
-                let config_options = config_options.clone();
-                let agent_server = agent_server.clone();
-                let fs = fs.clone();
-                cx.new(|cx| {
-                    ConfigOptionSelector::new(
-                        config_options,
-                        option.id.clone(),
-                        agent_server,
-                        fs,
-                        window,
-                        cx,
-                    )
-                })
-            })
-            .collect()
-    }
-}
-
-impl Render for ConfigOptionsView {
-    fn render(&mut self, _window: &mut Window, _cx: &mut Context<Self>) -> impl IntoElement {
-        if self.selectors.is_empty() {
-            return div().into_any_element();
-        }
-
-        h_flex()
-            .gap_1()
-            .children(self.selectors.iter().cloned())
-            .into_any_element()
-    }
-}
-
-struct ConfigOptionSelector {
-    config_options: Rc<dyn AgentSessionConfigOptions>,
-    config_id: acp::SessionConfigId,
-    picker_handle: PopoverMenuHandle<Picker<ConfigOptionPickerDelegate>>,
-    picker: Entity<Picker<ConfigOptionPickerDelegate>>,
-    setting_value: bool,
-}
-
-impl ConfigOptionSelector {
-    pub fn new(
-        config_options: Rc<dyn AgentSessionConfigOptions>,
-        config_id: acp::SessionConfigId,
-        agent_server: Rc<dyn AgentServer>,
-        fs: Arc<dyn Fs>,
-        window: &mut Window,
-        cx: &mut Context<Self>,
-    ) -> Self {
-        let option_count = config_options
-            .config_options()
-            .iter()
-            .find(|opt| opt.id == config_id)
-            .map(count_config_options)
-            .unwrap_or(0);
-
-        let is_searchable = option_count >= PICKER_THRESHOLD;
-
-        let picker = {
-            let config_options = config_options.clone();
-            let config_id = config_id.clone();
-            let agent_server = agent_server.clone();
-            let fs = fs.clone();
-            cx.new(move |picker_cx| {
-                let delegate = ConfigOptionPickerDelegate::new(
-                    config_options,
-                    config_id,
-                    agent_server,
-                    fs,
-                    window,
-                    picker_cx,
-                );
-
-                if is_searchable {
-                    Picker::list(delegate, window, picker_cx)
-                } else {
-                    Picker::nonsearchable_list(delegate, window, picker_cx)
-                }
-                .show_scrollbar(true)
-                .width(rems(20.))
-                .max_height(Some(rems(20.).into()))
-            })
-        };
-
-        Self {
-            config_options,
-            config_id,
-            picker_handle: PopoverMenuHandle::default(),
-            picker,
-            setting_value: false,
-        }
-    }
-
-    fn current_option(&self) -> Option<acp::SessionConfigOption> {
-        self.config_options
-            .config_options()
-            .into_iter()
-            .find(|opt| opt.id == self.config_id)
-    }
-
-    fn current_value_name(&self) -> String {
-        let Some(option) = self.current_option() else {
-            return "Unknown".to_string();
-        };
-
-        match &option.kind {
-            acp::SessionConfigKind::Select(select) => {
-                find_option_name(&select.options, &select.current_value)
-                    .unwrap_or_else(|| "Unknown".to_string())
-            }
-            _ => "Unknown".to_string(),
-        }
-    }
-
-    fn render_trigger_button(&self, _window: &mut Window, _cx: &mut Context<Self>) -> Button {
-        let Some(option) = self.current_option() else {
-            return Button::new("config-option-trigger", "Unknown")
-                .label_size(LabelSize::Small)
-                .color(Color::Muted)
-                .disabled(true);
-        };
-
-        let icon = if self.picker_handle.is_deployed() {
-            IconName::ChevronUp
-        } else {
-            IconName::ChevronDown
-        };
-
-        Button::new(
-            ElementId::Name(format!("config-option-{}", option.id.0).into()),
-            self.current_value_name(),
-        )
-        .label_size(LabelSize::Small)
-        .color(Color::Muted)
-        .icon(icon)
-        .icon_size(IconSize::XSmall)
-        .icon_position(IconPosition::End)
-        .icon_color(Color::Muted)
-        .disabled(self.setting_value)
-    }
-}
-
-impl Render for ConfigOptionSelector {
-    fn render(&mut self, window: &mut Window, cx: &mut Context<Self>) -> impl IntoElement {
-        let Some(option) = self.current_option() else {
-            return div().into_any_element();
-        };
-
-        let trigger_button = self.render_trigger_button(window, cx);
-
-        let option_name = option.name.clone();
-        let option_description: Option<SharedString> = option.description.map(Into::into);
-
-        let tooltip = Tooltip::element(move |_window, _cx| {
-            let mut content = v_flex().gap_1().child(Label::new(option_name.clone()));
-            if let Some(desc) = option_description.as_ref() {
-                content = content.child(
-                    Label::new(desc.clone())
-                        .size(LabelSize::Small)
-                        .color(Color::Muted),
-                );
-            }
-            content.into_any()
-        });
-
-        PickerPopoverMenu::new(
-            self.picker.clone(),
-            trigger_button,
-            tooltip,
-            gpui::Corner::BottomRight,
-            cx,
-        )
-        .with_handle(self.picker_handle.clone())
-        .render(window, cx)
-        .into_any_element()
-    }
-}
-
-#[derive(Clone)]
-enum ConfigOptionPickerEntry {
-    Separator(SharedString),
-    Option(ConfigOptionValue),
-}
-
-#[derive(Clone)]
-struct ConfigOptionValue {
-    value: acp::SessionConfigValueId,
-    name: String,
-    description: Option<String>,
-    group: Option<String>,
-}
-
-struct ConfigOptionPickerDelegate {
-    config_options: Rc<dyn AgentSessionConfigOptions>,
-    config_id: acp::SessionConfigId,
-    agent_server: Rc<dyn AgentServer>,
-    fs: Arc<dyn Fs>,
-    filtered_entries: Vec<ConfigOptionPickerEntry>,
-    all_options: Vec<ConfigOptionValue>,
-    selected_index: usize,
-    selected_description: Option<(usize, SharedString, bool)>,
-    favorites: HashSet<acp::SessionConfigValueId>,
-    _settings_subscription: Subscription,
-}
-
-impl ConfigOptionPickerDelegate {
-    fn new(
-        config_options: Rc<dyn AgentSessionConfigOptions>,
-        config_id: acp::SessionConfigId,
-        agent_server: Rc<dyn AgentServer>,
-        fs: Arc<dyn Fs>,
-        window: &mut Window,
-        cx: &mut Context<Picker<Self>>,
-    ) -> Self {
-        let favorites = agent_server.favorite_config_option_value_ids(&config_id, cx);
-
-        let all_options = extract_options(&config_options, &config_id);
-        let filtered_entries = options_to_picker_entries(&all_options, &favorites);
-
-        let current_value = get_current_value(&config_options, &config_id);
-        let selected_index = current_value
-            .and_then(|current| {
-                filtered_entries.iter().position(|entry| {
-                    matches!(entry, ConfigOptionPickerEntry::Option(opt) if opt.value == current)
-                })
-            })
-            .unwrap_or(0);
-
-        let agent_server_for_subscription = agent_server.clone();
-        let config_id_for_subscription = config_id.clone();
-        let settings_subscription =
-            cx.observe_global_in::<SettingsStore>(window, move |picker, window, cx| {
-                let new_favorites = agent_server_for_subscription
-                    .favorite_config_option_value_ids(&config_id_for_subscription, cx);
-                if new_favorites != picker.delegate.favorites {
-                    picker.delegate.favorites = new_favorites;
-                    picker.refresh(window, cx);
-                }
-            });
-
-        cx.notify();
-
-        Self {
-            config_options,
-            config_id,
-            agent_server,
-            fs,
-            filtered_entries,
-            all_options,
-            selected_index,
-            selected_description: None,
-            favorites,
-            _settings_subscription: settings_subscription,
-        }
-    }
-
-    fn current_value(&self) -> Option<acp::SessionConfigValueId> {
-        get_current_value(&self.config_options, &self.config_id)
-    }
-}
-
-impl PickerDelegate for ConfigOptionPickerDelegate {
-    type ListItem = AnyElement;
-
-    fn match_count(&self) -> usize {
-        self.filtered_entries.len()
-    }
-
-    fn selected_index(&self) -> usize {
-        self.selected_index
-    }
-
-    fn set_selected_index(&mut self, ix: usize, _: &mut Window, cx: &mut Context<Picker<Self>>) {
-        self.selected_index = ix.min(self.filtered_entries.len().saturating_sub(1));
-        cx.notify();
-    }
-
-    fn can_select(
-        &mut self,
-        ix: usize,
-        _window: &mut Window,
-        _cx: &mut Context<Picker<Self>>,
-    ) -> bool {
-        match self.filtered_entries.get(ix) {
-            Some(ConfigOptionPickerEntry::Option(_)) => true,
-            Some(ConfigOptionPickerEntry::Separator(_)) | None => false,
-        }
-    }
-
-    fn placeholder_text(&self, _window: &mut Window, _cx: &mut App) -> Arc<str> {
-        "Select an option…".into()
-    }
-
-    fn update_matches(
-        &mut self,
-        query: String,
-        window: &mut Window,
-        cx: &mut Context<Picker<Self>>,
-    ) -> Task<()> {
-        let all_options = self.all_options.clone();
-
-        cx.spawn_in(window, async move |this, cx| {
-            let filtered_options = match this
-                .read_with(cx, |_, cx| {
-                    if query.is_empty() {
-                        None
-                    } else {
-                        Some((all_options.clone(), query.clone(), cx.background_executor().clone()))
-                    }
-                })
-                .ok()
-                .flatten()
-            {
-                Some((options, q, executor)) => fuzzy_search_options(options, &q, executor).await,
-                None => all_options,
-            };
-
-            this.update_in(cx, |this, window, cx| {
-                this.delegate.filtered_entries =
-                    options_to_picker_entries(&filtered_options, &this.delegate.favorites);
-
-                let current_value = this.delegate.current_value();
-                let new_index = current_value
-                    .and_then(|current| {
-                        this.delegate.filtered_entries.iter().position(|entry| {
-                            matches!(entry, ConfigOptionPickerEntry::Option(opt) if opt.value == current)
-                        })
-                    })
-                    .unwrap_or(0);
-
-                this.set_selected_index(new_index, Some(picker::Direction::Down), true, window, cx);
-                cx.notify();
-            })
-            .ok();
-        })
-    }
-
-    fn confirm(&mut self, _secondary: bool, window: &mut Window, cx: &mut Context<Picker<Self>>) {
-        if let Some(ConfigOptionPickerEntry::Option(option)) =
-            self.filtered_entries.get(self.selected_index)
-        {
-            if window.modifiers().secondary() {
-                let default_value = self
-                    .agent_server
-                    .default_config_option(self.config_id.0.as_ref(), cx);
-                let is_default = default_value.as_deref() == Some(&*option.value.0);
-
-                self.agent_server.set_default_config_option(
-                    self.config_id.0.as_ref(),
-                    if is_default {
-                        None
-                    } else {
-                        Some(option.value.0.as_ref())
-                    },
-                    self.fs.clone(),
-                    cx,
-                );
-            }
-
-            let task = self.config_options.set_config_option(
-                self.config_id.clone(),
-                option.value.clone(),
-                cx,
-            );
-
-            cx.spawn(async move |_, _| {
-                if let Err(err) = task.await {
-                    log::error!("Failed to set config option: {:?}", err);
-                }
-            })
-            .detach();
-
-            cx.emit(DismissEvent);
-        }
-    }
-
-    fn dismissed(&mut self, window: &mut Window, cx: &mut Context<Picker<Self>>) {
-        cx.defer_in(window, |picker, window, cx| {
-            picker.set_query("", window, cx);
-        });
-    }
-
-    fn render_match(
-        &self,
-        ix: usize,
-        selected: bool,
-        _: &mut Window,
-        cx: &mut Context<Picker<Self>>,
-    ) -> Option<Self::ListItem> {
-        match self.filtered_entries.get(ix)? {
-            ConfigOptionPickerEntry::Separator(title) => Some(
-                div()
-                    .when(ix > 0, |this| this.mt_1())
-                    .child(
-                        div()
-                            .px_2()
-                            .py_1()
-                            .text_xs()
-                            .text_color(cx.theme().colors().text_muted)
-                            .child(title.clone()),
-                    )
-                    .into_any_element(),
-            ),
-            ConfigOptionPickerEntry::Option(option) => {
-                let current_value = self.current_value();
-                let is_selected = current_value.as_ref() == Some(&option.value);
-
-                let default_value = self
-                    .agent_server
-                    .default_config_option(self.config_id.0.as_ref(), cx);
-                let is_default = default_value.as_deref() == Some(&*option.value.0);
-
-                let is_favorite = self.favorites.contains(&option.value);
-
-                let option_name = option.name.clone();
-                let description = option.description.clone();
-
-                Some(
-                    div()
-                        .id(("config-option-picker-item", ix))
-                        .when_some(description, |this, desc| {
-                            let desc: SharedString = desc.into();
-                            this.on_hover(cx.listener(move |menu, hovered, _, cx| {
-                                if *hovered {
-                                    menu.delegate.selected_description =
-                                        Some((ix, desc.clone(), is_default));
-                                } else if matches!(menu.delegate.selected_description, Some((id, _, _)) if id == ix)
-                                {
-                                    menu.delegate.selected_description = None;
-                                }
-                                cx.notify();
-                            }))
-                        })
-                        .child(
-                            ListItem::new(ix)
-                                .inset(true)
-                                .spacing(ListItemSpacing::Sparse)
-                                .toggle_state(selected)
-                                .child(h_flex().w_full().child(Label::new(option_name).truncate()))
-                                .end_slot(div().pr_2().when(is_selected, |this| {
-                                    this.child(Icon::new(IconName::Check).color(Color::Accent))
-                                }))
-                                .end_hover_slot(div().pr_1p5().child({
-                                    let (icon, color, tooltip) = if is_favorite {
-                                        (IconName::StarFilled, Color::Accent, "Unfavorite")
-                                    } else {
-                                        (IconName::Star, Color::Default, "Favorite")
-                                    };
-
-                                    let config_id = self.config_id.clone();
-                                    let value_id = option.value.clone();
-                                    let agent_server = self.agent_server.clone();
-                                    let fs = self.fs.clone();
-
-                                    IconButton::new(("toggle-favorite-config-option", ix), icon)
-                                        .layer(ElevationIndex::ElevatedSurface)
-                                        .icon_color(color)
-                                        .icon_size(IconSize::Small)
-                                        .tooltip(Tooltip::text(tooltip))
-                                        .on_click(move |_, _, cx| {
-                                            agent_server.toggle_favorite_config_option_value(
-                                                config_id.clone(),
-                                                value_id.clone(),
-                                                !is_favorite,
-                                                fs.clone(),
-                                                cx,
-                                            );
-                                        })
-                                })),
-                        )
-                        .into_any_element(),
-                )
-            }
-        }
-    }
-
-    fn documentation_aside(
-        &self,
-        _window: &mut Window,
-        _cx: &mut Context<Picker<Self>>,
-    ) -> Option<ui::DocumentationAside> {
-        self.selected_description
-            .as_ref()
-            .map(|(_, description, is_default)| {
-                let description = description.clone();
-                let is_default = *is_default;
-
-                ui::DocumentationAside::new(
-                    ui::DocumentationSide::Left,
-                    ui::DocumentationEdge::Top,
-                    Rc::new(move |_| {
-                        v_flex()
-                            .gap_1()
-                            .child(Label::new(description.clone()))
-                            .child(HoldForDefault::new(is_default))
-                            .into_any_element()
-                    }),
-                )
-            })
-    }
-}
-
-fn extract_options(
-    config_options: &Rc<dyn AgentSessionConfigOptions>,
-    config_id: &acp::SessionConfigId,
-) -> Vec<ConfigOptionValue> {
-    let Some(option) = config_options
-        .config_options()
-        .into_iter()
-        .find(|opt| &opt.id == config_id)
-    else {
-        return Vec::new();
-    };
-
-    match &option.kind {
-        acp::SessionConfigKind::Select(select) => match &select.options {
-            acp::SessionConfigSelectOptions::Ungrouped(options) => options
-                .iter()
-                .map(|opt| ConfigOptionValue {
-                    value: opt.value.clone(),
-                    name: opt.name.clone(),
-                    description: opt.description.clone(),
-                    group: None,
-                })
-                .collect(),
-            acp::SessionConfigSelectOptions::Grouped(groups) => groups
-                .iter()
-                .flat_map(|group| {
-                    group.options.iter().map(|opt| ConfigOptionValue {
-                        value: opt.value.clone(),
-                        name: opt.name.clone(),
-                        description: opt.description.clone(),
-                        group: Some(group.name.clone()),
-                    })
-                })
-                .collect(),
-            _ => Vec::new(),
-        },
-        _ => Vec::new(),
-    }
-}
-
-fn get_current_value(
-    config_options: &Rc<dyn AgentSessionConfigOptions>,
-    config_id: &acp::SessionConfigId,
-) -> Option<acp::SessionConfigValueId> {
-    config_options
-        .config_options()
-        .into_iter()
-        .find(|opt| &opt.id == config_id)
-        .and_then(|opt| match &opt.kind {
-            acp::SessionConfigKind::Select(select) => Some(select.current_value.clone()),
-            _ => None,
-        })
-}
-
-fn options_to_picker_entries(
-    options: &[ConfigOptionValue],
-    favorites: &HashSet<acp::SessionConfigValueId>,
-) -> Vec<ConfigOptionPickerEntry> {
-    let mut entries = Vec::new();
-
-    let mut favorite_options = Vec::new();
-
-    for option in options {
-        if favorites.contains(&option.value) {
-            favorite_options.push(option.clone());
-        }
-    }
-
-    if !favorite_options.is_empty() {
-        entries.push(ConfigOptionPickerEntry::Separator("Favorites".into()));
-        for option in favorite_options {
-            entries.push(ConfigOptionPickerEntry::Option(option));
-        }
-
-        // If the remaining list would start ungrouped (group == None), insert a separator so
-        // Favorites doesn't visually run into the main list.
-        if let Some(option) = options.first()
-            && option.group.is_none()
-        {
-            entries.push(ConfigOptionPickerEntry::Separator("All Options".into()));
-        }
-    }
-
-    let mut current_group: Option<String> = None;
-    for option in options {
-        if option.group != current_group {
-            if let Some(group_name) = &option.group {
-                entries.push(ConfigOptionPickerEntry::Separator(
-                    group_name.clone().into(),
-                ));
-            }
-            current_group = option.group.clone();
-        }
-        entries.push(ConfigOptionPickerEntry::Option(option.clone()));
-    }
-
-    entries
-}
-
-async fn fuzzy_search_options(
-    options: Vec<ConfigOptionValue>,
-    query: &str,
-    executor: BackgroundExecutor,
-) -> Vec<ConfigOptionValue> {
-    let candidates = options
-        .iter()
-        .enumerate()
-        .map(|(ix, opt)| StringMatchCandidate::new(ix, &opt.name))
-        .collect::<Vec<_>>();
-
-    let mut matches = fuzzy::match_strings(
-        &candidates,
-        query,
-        false,
-        true,
-        100,
-        &Default::default(),
-        executor,
-    )
-    .await;
-
-    matches.sort_unstable_by_key(|mat| {
-        let candidate = &candidates[mat.candidate_id];
-        (Reverse(OrderedFloat(mat.score)), candidate.id)
-    });
-
-    matches
-        .into_iter()
-        .map(|mat| options[mat.candidate_id].clone())
-        .collect()
-}
-
-fn find_option_name(
-    options: &acp::SessionConfigSelectOptions,
-    value_id: &acp::SessionConfigValueId,
-) -> Option<String> {
-    match options {
-        acp::SessionConfigSelectOptions::Ungrouped(opts) => opts
-            .iter()
-            .find(|o| &o.value == value_id)
-            .map(|o| o.name.clone()),
-        acp::SessionConfigSelectOptions::Grouped(groups) => groups.iter().find_map(|group| {
-            group
-                .options
-                .iter()
-                .find(|o| &o.value == value_id)
-                .map(|o| o.name.clone())
-        }),
-        _ => None,
-    }
-}
-
-fn count_config_options(option: &acp::SessionConfigOption) -> usize {
-    match &option.kind {
-        acp::SessionConfigKind::Select(select) => match &select.options {
-            acp::SessionConfigSelectOptions::Ungrouped(options) => options.len(),
-            acp::SessionConfigSelectOptions::Grouped(groups) => {
-                groups.iter().map(|g| g.options.len()).sum()
-            }
-            _ => 0,
-        },
-        _ => 0,
-    }
-}

crates/agent_ui/src/acp/message_editor.rs

@@ -31,10 +31,10 @@ use rope::Point;
 use settings::Settings;
 use std::{cell::RefCell, fmt::Write, rc::Rc, sync::Arc};
 use theme::ThemeSettings;
-use ui::{ContextMenu, prelude::*};
+use ui::prelude::*;
 use util::{ResultExt, debug_panic};
 use workspace::{CollaboratorId, Workspace};
-use zed_actions::agent::{Chat, PasteRaw};
+use zed_actions::agent::Chat;
 
 pub struct MessageEditor {
     mention_set: Entity<MentionSet>,
@@ -132,21 +132,6 @@ impl MessageEditor {
                 placement: Some(ContextMenuPlacement::Above),
             });
             editor.register_addon(MessageEditorAddon::new());
-
-            editor.set_custom_context_menu(|editor, _point, window, cx| {
-                let has_selection = editor.has_non_empty_selection(&editor.display_snapshot(cx));
-
-                Some(ContextMenu::build(window, cx, |menu, _, _| {
-                    menu.action("Cut", Box::new(editor::actions::Cut))
-                        .action_disabled_when(
-                            !has_selection,
-                            "Copy",
-                            Box::new(editor::actions::Copy),
-                        )
-                        .action("Paste", Box::new(editor::actions::Paste))
-                }))
-            });
-
             editor
         });
         let mention_set =
@@ -558,9 +543,6 @@ impl MessageEditor {
     }
 
     fn paste(&mut self, _: &Paste, window: &mut Window, cx: &mut Context<Self>) {
-        let Some(workspace) = self.workspace.upgrade() else {
-            return;
-        };
         let editor_clipboard_selections = cx
             .read_from_clipboard()
             .and_then(|item| item.entries().first().cloned())
@@ -571,127 +553,133 @@ impl MessageEditor {
                 _ => None,
             });
 
-        // Insert creases for pasted clipboard selections that:
-        // 1. Contain exactly one selection
-        // 2. Have an associated file path
-        // 3. Span multiple lines (not single-line selections)
-        // 4. Belong to a file that exists in the current project
-        let should_insert_creases = util::maybe!({
-            let selections = editor_clipboard_selections.as_ref()?;
-            if selections.len() > 1 {
-                return Some(false);
-            }
-            let selection = selections.first()?;
-            let file_path = selection.file_path.as_ref()?;
-            let line_range = selection.line_range.as_ref()?;
+        let has_file_context = editor_clipboard_selections
+            .as_ref()
+            .is_some_and(|selections| {
+                selections
+                    .iter()
+                    .any(|sel| sel.file_path.is_some() && sel.line_range.is_some())
+            });
 
-            if line_range.start() == line_range.end() {
-                return Some(false);
-            }
-
-            Some(
-                workspace
-                    .read(cx)
-                    .project()
-                    .read(cx)
-                    .project_path_for_absolute_path(file_path, cx)
-                    .is_some(),
-            )
-        })
-        .unwrap_or(false);
-
-        if should_insert_creases && let Some(selections) = editor_clipboard_selections {
-            cx.stop_propagation();
-            let insertion_target = self
-                .editor
-                .read(cx)
-                .selections
-                .newest_anchor()
-                .start
-                .text_anchor;
-
-            let project = workspace.read(cx).project().clone();
-            for selection in selections {
-                if let (Some(file_path), Some(line_range)) =
-                    (selection.file_path, selection.line_range)
-                {
-                    let crease_text =
-                        acp_thread::selection_name(Some(file_path.as_ref()), &line_range);
-
-                    let mention_uri = MentionUri::Selection {
-                        abs_path: Some(file_path.clone()),
-                        line_range: line_range.clone(),
-                    };
-
-                    let mention_text = mention_uri.as_link().to_string();
-                    let (excerpt_id, text_anchor, content_len) =
-                        self.editor.update(cx, |editor, cx| {
-                            let buffer = editor.buffer().read(cx);
-                            let snapshot = buffer.snapshot(cx);
-                            let (excerpt_id, _, buffer_snapshot) = snapshot.as_singleton().unwrap();
-                            let text_anchor = insertion_target.bias_left(&buffer_snapshot);
-
-                            editor.insert(&mention_text, window, cx);
-                            editor.insert(" ", window, cx);
-
-                            (*excerpt_id, text_anchor, mention_text.len())
-                        });
-
-                    let Some((crease_id, tx)) = insert_crease_for_mention(
-                        excerpt_id,
-                        text_anchor,
-                        content_len,
-                        crease_text.into(),
-                        mention_uri.icon_path(cx),
-                        None,
-                        self.editor.clone(),
-                        window,
-                        cx,
-                    ) else {
-                        continue;
-                    };
-                    drop(tx);
-
-                    let mention_task = cx
-                        .spawn({
-                            let project = project.clone();
-                            async move |_, cx| {
-                                let project_path = project
-                                    .update(cx, |project, cx| {
-                                        project.project_path_for_absolute_path(&file_path, cx)
-                                    })
-                                    .map_err(|e| e.to_string())?
-                                    .ok_or_else(|| "project path not found".to_string())?;
-
-                                let buffer = project
-                                    .update(cx, |project, cx| project.open_buffer(project_path, cx))
-                                    .map_err(|e| e.to_string())?
-                                    .await
-                                    .map_err(|e| e.to_string())?;
-
-                                buffer
-                                    .update(cx, |buffer, cx| {
-                                        let start = Point::new(*line_range.start(), 0)
-                                            .min(buffer.max_point());
-                                        let end = Point::new(*line_range.end() + 1, 0)
-                                            .min(buffer.max_point());
-                                        let content = buffer.text_for_range(start..end).collect();
-                                        Mention::Text {
-                                            content,
-                                            tracked_buffers: vec![cx.entity()],
-                                        }
-                                    })
-                                    .map_err(|e| e.to_string())
-                            }
-                        })
-                        .shared();
-
-                    self.mention_set.update(cx, |mention_set, _cx| {
-                        mention_set.insert_mention(crease_id, mention_uri.clone(), mention_task)
-                    });
+        if has_file_context {
+            if let Some((workspace, selections)) =
+                self.workspace.upgrade().zip(editor_clipboard_selections)
+            {
+                let Some(first_selection) = selections.first() else {
+                    return;
+                };
+                if let Some(file_path) = &first_selection.file_path {
+                    // In case someone pastes selections from another window
+                    // with a different project, we don't want to insert the
+                    // crease (containing the absolute path) since the agent
+                    // cannot access files outside the project.
+                    let is_in_project = workspace
+                        .read(cx)
+                        .project()
+                        .read(cx)
+                        .project_path_for_absolute_path(file_path, cx)
+                        .is_some();
+                    if !is_in_project {
+                        return;
+                    }
                 }
+
+                cx.stop_propagation();
+                let insertion_target = self
+                    .editor
+                    .read(cx)
+                    .selections
+                    .newest_anchor()
+                    .start
+                    .text_anchor;
+
+                let project = workspace.read(cx).project().clone();
+                for selection in selections {
+                    if let (Some(file_path), Some(line_range)) =
+                        (selection.file_path, selection.line_range)
+                    {
+                        let crease_text =
+                            acp_thread::selection_name(Some(file_path.as_ref()), &line_range);
+
+                        let mention_uri = MentionUri::Selection {
+                            abs_path: Some(file_path.clone()),
+                            line_range: line_range.clone(),
+                        };
+
+                        let mention_text = mention_uri.as_link().to_string();
+                        let (excerpt_id, text_anchor, content_len) =
+                            self.editor.update(cx, |editor, cx| {
+                                let buffer = editor.buffer().read(cx);
+                                let snapshot = buffer.snapshot(cx);
+                                let (excerpt_id, _, buffer_snapshot) =
+                                    snapshot.as_singleton().unwrap();
+                                let text_anchor = insertion_target.bias_left(&buffer_snapshot);
+
+                                editor.insert(&mention_text, window, cx);
+                                editor.insert(" ", window, cx);
+
+                                (*excerpt_id, text_anchor, mention_text.len())
+                            });
+
+                        let Some((crease_id, tx)) = insert_crease_for_mention(
+                            excerpt_id,
+                            text_anchor,
+                            content_len,
+                            crease_text.into(),
+                            mention_uri.icon_path(cx),
+                            None,
+                            self.editor.clone(),
+                            window,
+                            cx,
+                        ) else {
+                            continue;
+                        };
+                        drop(tx);
+
+                        let mention_task = cx
+                            .spawn({
+                                let project = project.clone();
+                                async move |_, cx| {
+                                    let project_path = project
+                                        .update(cx, |project, cx| {
+                                            project.project_path_for_absolute_path(&file_path, cx)
+                                        })
+                                        .map_err(|e| e.to_string())?
+                                        .ok_or_else(|| "project path not found".to_string())?;
+
+                                    let buffer = project
+                                        .update(cx, |project, cx| {
+                                            project.open_buffer(project_path, cx)
+                                        })
+                                        .map_err(|e| e.to_string())?
+                                        .await
+                                        .map_err(|e| e.to_string())?;
+
+                                    buffer
+                                        .update(cx, |buffer, cx| {
+                                            let start = Point::new(*line_range.start(), 0)
+                                                .min(buffer.max_point());
+                                            let end = Point::new(*line_range.end() + 1, 0)
+                                                .min(buffer.max_point());
+                                            let content =
+                                                buffer.text_for_range(start..end).collect();
+                                            Mention::Text {
+                                                content,
+                                                tracked_buffers: vec![cx.entity()],
+                                            }
+                                        })
+                                        .map_err(|e| e.to_string())
+                                }
+                            })
+                            .shared();
+
+                        self.mention_set.update(cx, |mention_set, _cx| {
+                            mention_set.insert_mention(crease_id, mention_uri.clone(), mention_task)
+                        });
+                    }
+                }
+                return;
             }
-            return;
         }
 
         if self.prompt_capabilities.borrow().image
@@ -702,13 +690,6 @@ impl MessageEditor {
         }
     }
 
-    fn paste_raw(&mut self, _: &PasteRaw, window: &mut Window, cx: &mut Context<Self>) {
-        let editor = self.editor.clone();
-        window.defer(cx, move |window, cx| {
-            editor.update(cx, |editor, cx| editor.paste(&Paste, window, cx));
-        });
-    }
-
     pub fn insert_dragged_files(
         &mut self,
         paths: Vec<project::ProjectPath>,
@@ -986,7 +967,6 @@ impl Render for MessageEditor {
             .on_action(cx.listener(Self::chat))
             .on_action(cx.listener(Self::chat_with_follow))
             .on_action(cx.listener(Self::cancel))
-            .on_action(cx.listener(Self::paste_raw))
             .capture_action(cx.listener(Self::paste))
             .flex_1()
             .child({

crates/agent_ui/src/acp/mode_selector.rs

@@ -186,17 +186,6 @@ impl Render for ModeSelector {
                     move |_window, cx| {
                         v_flex()
                             .gap_1()
-                            .child(
-                                h_flex()
-                                    .gap_2()
-                                    .justify_between()
-                                    .child(Label::new("Toggle Mode Menu"))
-                                    .child(KeyBinding::for_action_in(
-                                        &ToggleProfileSelector,
-                                        &focus_handle,
-                                        cx,
-                                    )),
-                            )
                             .child(
                                 h_flex()
                                     .pb_1()
@@ -211,6 +200,17 @@ impl Render for ModeSelector {
                                         cx,
                                     )),
                             )
+                            .child(
+                                h_flex()
+                                    .gap_2()
+                                    .justify_between()
+                                    .child(Label::new("Toggle Mode Menu"))
+                                    .child(KeyBinding::for_action_in(
+                                        &ToggleProfileSelector,
+                                        &focus_handle,
+                                        cx,
+                                    )),
+                            )
                             .into_any()
                     }
                 }),

crates/agent_ui/src/acp/model_selector.rs

@@ -1,21 +1,21 @@
 use std::{cmp::Reverse, rc::Rc, sync::Arc};
 
-use acp_thread::{AgentModelIcon, AgentModelInfo, AgentModelList, AgentModelSelector};
+use acp_thread::{AgentModelInfo, AgentModelList, AgentModelSelector};
 use agent_client_protocol::ModelId;
 use agent_servers::AgentServer;
+use agent_settings::AgentSettings;
 use anyhow::Result;
 use collections::{HashSet, IndexMap};
 use fs::Fs;
 use futures::FutureExt;
 use fuzzy::{StringMatchCandidate, match_strings};
 use gpui::{
-    Action, AsyncWindowContext, BackgroundExecutor, DismissEvent, FocusHandle, Subscription, Task,
-    WeakEntity,
+    Action, AsyncWindowContext, BackgroundExecutor, DismissEvent, FocusHandle, Task, WeakEntity,
 };
 use itertools::Itertools;
 use ordered_float::OrderedFloat;
 use picker::{Picker, PickerDelegate};
-use settings::SettingsStore;
+use settings::Settings;
 use ui::{DocumentationAside, DocumentationEdge, DocumentationSide, IntoElement, prelude::*};
 use util::ResultExt;
 use zed_actions::agent::OpenSettings;
@@ -54,9 +54,7 @@ pub struct AcpModelPickerDelegate {
     selected_index: usize,
     selected_description: Option<(usize, SharedString, bool)>,
     selected_model: Option<AgentModelInfo>,
-    favorites: HashSet<ModelId>,
     _refresh_models_task: Task<()>,
-    _settings_subscription: Subscription,
     focus_handle: FocusHandle,
 }
 
@@ -104,19 +102,6 @@ impl AcpModelPickerDelegate {
             })
         };
 
-        let agent_server_for_subscription = agent_server.clone();
-        let settings_subscription =
-            cx.observe_global_in::<SettingsStore>(window, move |picker, window, cx| {
-                // Only refresh if the favorites actually changed to avoid redundant work
-                // when other settings are modified (e.g., user editing settings.json)
-                let new_favorites = agent_server_for_subscription.favorite_model_ids(cx);
-                if new_favorites != picker.delegate.favorites {
-                    picker.delegate.favorites = new_favorites;
-                    picker.refresh(window, cx);
-                }
-            });
-        let favorites = agent_server.favorite_model_ids(cx);
-
         Self {
             selector,
             agent_server,
@@ -126,9 +111,7 @@ impl AcpModelPickerDelegate {
             selected_model: None,
             selected_index: 0,
             selected_description: None,
-            favorites,
             _refresh_models_task: refresh_models_task,
-            _settings_subscription: settings_subscription,
             focus_handle,
         }
     }
@@ -137,37 +120,40 @@ impl AcpModelPickerDelegate {
         self.selected_model.as_ref()
     }
 
-    pub fn favorites_count(&self) -> usize {
-        self.favorites.len()
-    }
-
     pub fn cycle_favorite_models(&mut self, window: &mut Window, cx: &mut Context<Picker<Self>>) {
-        if self.favorites.is_empty() {
+        if !self.selector.supports_favorites() {
             return;
         }
 
-        let Some(models) = &self.models else {
+        let favorites = AgentSettings::get_global(cx).favorite_model_ids();
+
+        if favorites.is_empty() {
+            return;
+        }
+
+        let Some(models) = self.models.clone() else {
             return;
         };
 
-        let all_models: Vec<&AgentModelInfo> = match models {
-            AgentModelList::Flat(list) => list.iter().collect(),
-            AgentModelList::Grouped(index_map) => index_map.values().flatten().collect(),
+        let all_models: Vec<AgentModelInfo> = match models {
+            AgentModelList::Flat(list) => list,
+            AgentModelList::Grouped(index_map) => index_map
+                .into_values()
+                .flatten()
+                .collect::<Vec<AgentModelInfo>>(),
         };
 
-        let favorite_models: Vec<_> = all_models
-            .into_iter()
-            .filter(|model| self.favorites.contains(&model.id))
+        let favorite_models = all_models
+            .iter()
+            .filter(|model| favorites.contains(&model.id))
             .unique_by(|model| &model.id)
-            .collect();
+            .cloned()
+            .collect::<Vec<_>>();
 
-        if favorite_models.is_empty() {
-            return;
-        }
-
-        let current_id = self.selected_model.as_ref().map(|m| &m.id);
+        let current_id = self.selected_model.as_ref().map(|m| m.id.clone());
 
         let current_index_in_favorites = current_id
+            .as_ref()
             .and_then(|id| favorite_models.iter().position(|m| &m.id == id))
             .unwrap_or(usize::MAX);
 
@@ -234,7 +220,11 @@ impl PickerDelegate for AcpModelPickerDelegate {
         window: &mut Window,
         cx: &mut Context<Picker<Self>>,
     ) -> Task<()> {
-        let favorites = self.favorites.clone();
+        let favorites = if self.selector.supports_favorites() {
+            Arc::new(AgentSettings::get_global(cx).favorite_model_ids())
+        } else {
+            Default::default()
+        };
 
         cx.spawn_in(window, async move |this, cx| {
             let filtered_models = match this
@@ -252,7 +242,7 @@ impl PickerDelegate for AcpModelPickerDelegate {
 
             this.update_in(cx, |this, window, cx| {
                 this.delegate.filtered_entries =
-                    info_list_to_picker_entries(filtered_models, &favorites);
+                    info_list_to_picker_entries(filtered_models, favorites);
                 // Finds the currently selected model in the list
                 let new_index = this
                     .delegate
@@ -327,20 +317,21 @@ impl PickerDelegate for AcpModelPickerDelegate {
                 let default_model = self.agent_server.default_model(cx);
                 let is_default = default_model.as_ref() == Some(&model_info.id);
 
+                let supports_favorites = self.selector.supports_favorites();
+
                 let is_favorite = *is_favorite;
                 let handle_action_click = {
                     let model_id = model_info.id.clone();
                     let fs = self.fs.clone();
-                    let agent_server = self.agent_server.clone();
 
-                    cx.listener(move |_, _, _, cx| {
-                        agent_server.toggle_favorite_model(
+                    move |cx: &App| {
+                        crate::favorite_models::toggle_model_id_in_settings(
                             model_id.clone(),
                             !is_favorite,
                             fs.clone(),
                             cx,
                         );
-                    })
+                    }
                 };
 
                 Some(
@@ -359,15 +350,13 @@ impl PickerDelegate for AcpModelPickerDelegate {
                         })
                         .child(
                             ModelSelectorListItem::new(ix, model_info.name.clone())
-                                .map(|this| match &model_info.icon {
-                                    Some(AgentModelIcon::Path(path)) => this.icon_path(path.clone()),
-                                    Some(AgentModelIcon::Named(icon)) => this.icon(*icon),
-                                    None => this,
-                                })
+                                .when_some(model_info.icon, |this, icon| this.icon(icon))
                                 .is_selected(is_selected)
                                 .is_focused(selected)
-                                .is_favorite(is_favorite)
-                                .on_toggle_favorite(handle_action_click),
+                                .when(supports_favorites, |this| {
+                                    this.is_favorite(is_favorite)
+                                        .on_toggle_favorite(handle_action_click)
+                                }),
                         )
                         .into_any_element(),
                 )
@@ -417,7 +406,7 @@ impl PickerDelegate for AcpModelPickerDelegate {
 
 fn info_list_to_picker_entries(
     model_list: AgentModelList,
-    favorites: &HashSet<ModelId>,
+    favorites: Arc<HashSet<ModelId>>,
 ) -> Vec<AcpModelPickerEntry> {
     let mut entries = Vec::new();
 
@@ -583,11 +572,13 @@ mod tests {
         }
     }
 
-    fn create_favorites(models: Vec<&str>) -> HashSet<ModelId> {
-        models
-            .into_iter()
-            .map(|m| ModelId::new(m.to_string()))
-            .collect()
+    fn create_favorites(models: Vec<&str>) -> Arc<HashSet<ModelId>> {
+        Arc::new(
+            models
+                .into_iter()
+                .map(|m| ModelId::new(m.to_string()))
+                .collect(),
+        )
     }
 
     fn get_entry_model_ids(entries: &[AcpModelPickerEntry]) -> Vec<&str> {
@@ -610,6 +601,141 @@ mod tests {
             .collect()
     }
 
+    #[gpui::test]
+    fn test_favorites_section_appears_when_favorites_exist(_cx: &mut TestAppContext) {
+        let models = create_model_list(vec![
+            ("zed", vec!["zed/claude", "zed/gemini"]),
+            ("openai", vec!["openai/gpt-5"]),
+        ]);
+        let favorites = create_favorites(vec!["zed/gemini"]);
+
+        let entries = info_list_to_picker_entries(models, favorites);
+
+        assert!(matches!(
+            entries.first(),
+            Some(AcpModelPickerEntry::Separator(s)) if s == "Favorite"
+        ));
+
+        let model_ids = get_entry_model_ids(&entries);
+        assert_eq!(model_ids[0], "zed/gemini");
+    }
+
+    #[gpui::test]
+    fn test_no_favorites_section_when_no_favorites(_cx: &mut TestAppContext) {
+        let models = create_model_list(vec![("zed", vec!["zed/claude", "zed/gemini"])]);
+        let favorites = create_favorites(vec![]);
+
+        let entries = info_list_to_picker_entries(models, favorites);
+
+        assert!(matches!(
+            entries.first(),
+            Some(AcpModelPickerEntry::Separator(s)) if s == "zed"
+        ));
+    }
+
+    #[gpui::test]
+    fn test_models_have_correct_actions(_cx: &mut TestAppContext) {
+        let models = create_model_list(vec![
+            ("zed", vec!["zed/claude", "zed/gemini"]),
+            ("openai", vec!["openai/gpt-5"]),
+        ]);
+        let favorites = create_favorites(vec!["zed/claude"]);
+
+        let entries = info_list_to_picker_entries(models, favorites);
+
+        for entry in &entries {
+            if let AcpModelPickerEntry::Model(info, is_favorite) = entry {
+                if info.id.0.as_ref() == "zed/claude" {
+                    assert!(is_favorite, "zed/claude should be a favorite");
+                } else {
+                    assert!(!is_favorite, "{} should not be a favorite", info.id.0);
+                }
+            }
+        }
+    }
+
+    #[gpui::test]
+    fn test_favorites_appear_in_both_sections(_cx: &mut TestAppContext) {
+        let models = create_model_list(vec![
+            ("zed", vec!["zed/claude", "zed/gemini"]),
+            ("openai", vec!["openai/gpt-5", "openai/gpt-4"]),
+        ]);
+        let favorites = create_favorites(vec!["zed/gemini", "openai/gpt-5"]);
+
+        let entries = info_list_to_picker_entries(models, favorites);
+        let model_ids = get_entry_model_ids(&entries);
+
+        assert_eq!(model_ids[0], "zed/gemini");
+        assert_eq!(model_ids[1], "openai/gpt-5");
+
+        assert!(model_ids[2..].contains(&"zed/gemini"));
+        assert!(model_ids[2..].contains(&"openai/gpt-5"));
+    }
+
+    #[gpui::test]
+    fn test_favorites_are_not_duplicated_when_repeated_in_other_sections(_cx: &mut TestAppContext) {
+        let models = create_model_list(vec![
+            ("Recommended", vec!["zed/claude", "anthropic/claude"]),
+            ("Zed", vec!["zed/claude", "zed/gpt-5"]),
+            ("Antropic", vec!["anthropic/claude"]),
+            ("OpenAI", vec!["openai/gpt-5"]),
+        ]);
+
+        let favorites = create_favorites(vec!["zed/claude"]);
+
+        let entries = info_list_to_picker_entries(models, favorites);
+        let labels = get_entry_labels(&entries);
+
+        assert_eq!(
+            labels,
+            vec![
+                "Favorite",
+                "zed/claude",
+                "Recommended",
+                "zed/claude",
+                "anthropic/claude",
+                "Zed",
+                "zed/claude",
+                "zed/gpt-5",
+                "Antropic",
+                "anthropic/claude",
+                "OpenAI",
+                "openai/gpt-5"
+            ]
+        );
+    }
+
+    #[gpui::test]
+    fn test_flat_model_list_with_favorites(_cx: &mut TestAppContext) {
+        let models = AgentModelList::Flat(vec![
+            acp_thread::AgentModelInfo {
+                id: acp::ModelId::new("zed/claude".to_string()),
+                name: "Claude".into(),
+                description: None,
+                icon: None,
+            },
+            acp_thread::AgentModelInfo {
+                id: acp::ModelId::new("zed/gemini".to_string()),
+                name: "Gemini".into(),
+                description: None,
+                icon: None,
+            },
+        ]);
+        let favorites = create_favorites(vec!["zed/gemini"]);
+
+        let entries = info_list_to_picker_entries(models, favorites);
+
+        assert!(matches!(
+            entries.first(),
+            Some(AcpModelPickerEntry::Separator(s)) if s == "Favorite"
+        ));
+
+        assert!(entries.iter().any(|e| matches!(
+            e,
+            AcpModelPickerEntry::Separator(s) if s == "All"
+        )));
+    }
+
     #[gpui::test]
     async fn test_fuzzy_match(cx: &mut TestAppContext) {
         let models = create_model_list(vec![
@@ -649,185 +775,4 @@ mod tests {
             ],
         );
     }
-
-    #[gpui::test]
-    fn test_favorites_section_appears_when_favorites_exist(_cx: &mut TestAppContext) {
-        let models = create_model_list(vec![
-            ("zed", vec!["zed/claude", "zed/gemini"]),
-            ("openai", vec!["openai/gpt-5"]),
-        ]);
-        let favorites = create_favorites(vec!["zed/gemini"]);
-
-        let entries = info_list_to_picker_entries(models, &favorites);
-
-        assert!(matches!(
-            entries.first(),
-            Some(AcpModelPickerEntry::Separator(s)) if s == "Favorite"
-        ));
-
-        let model_ids = get_entry_model_ids(&entries);
-        assert_eq!(model_ids[0], "zed/gemini");
-    }
-
-    #[gpui::test]
-    fn test_no_favorites_section_when_no_favorites(_cx: &mut TestAppContext) {
-        let models = create_model_list(vec![("zed", vec!["zed/claude", "zed/gemini"])]);
-        let favorites = create_favorites(vec![]);
-
-        let entries = info_list_to_picker_entries(models, &favorites);
-
-        assert!(matches!(
-            entries.first(),
-            Some(AcpModelPickerEntry::Separator(s)) if s == "zed"
-        ));
-    }
-
-    #[gpui::test]
-    fn test_models_have_correct_actions(_cx: &mut TestAppContext) {
-        let models = create_model_list(vec![
-            ("zed", vec!["zed/claude", "zed/gemini"]),
-            ("openai", vec!["openai/gpt-5"]),
-        ]);
-        let favorites = create_favorites(vec!["zed/claude"]);
-
-        let entries = info_list_to_picker_entries(models, &favorites);
-
-        for entry in &entries {
-            if let AcpModelPickerEntry::Model(info, is_favorite) = entry {
-                if info.id.0.as_ref() == "zed/claude" {
-                    assert!(is_favorite, "zed/claude should be a favorite");
-                } else {
-                    assert!(!is_favorite, "{} should not be a favorite", info.id.0);
-                }
-            }
-        }
-    }
-
-    #[gpui::test]
-    fn test_favorites_appear_in_both_sections(_cx: &mut TestAppContext) {
-        let models = create_model_list(vec![
-            ("zed", vec!["zed/claude", "zed/gemini"]),
-            ("openai", vec!["openai/gpt-5", "openai/gpt-4"]),
-        ]);
-        let favorites = create_favorites(vec!["zed/gemini", "openai/gpt-5"]);
-
-        let entries = info_list_to_picker_entries(models, &favorites);
-        let model_ids = get_entry_model_ids(&entries);
-
-        assert_eq!(model_ids[0], "zed/gemini");
-        assert_eq!(model_ids[1], "openai/gpt-5");
-
-        assert!(model_ids[2..].contains(&"zed/gemini"));
-        assert!(model_ids[2..].contains(&"openai/gpt-5"));
-    }
-
-    #[gpui::test]
-    fn test_favorites_are_not_duplicated_when_repeated_in_other_sections(_cx: &mut TestAppContext) {
-        let models = create_model_list(vec![
-            ("Recommended", vec!["zed/claude", "anthropic/claude"]),
-            ("Zed", vec!["zed/claude", "zed/gpt-5"]),
-            ("Antropic", vec!["anthropic/claude"]),
-            ("OpenAI", vec!["openai/gpt-5"]),
-        ]);
-
-        let favorites = create_favorites(vec!["zed/claude"]);
-
-        let entries = info_list_to_picker_entries(models, &favorites);
-        let labels = get_entry_labels(&entries);
-
-        assert_eq!(
-            labels,
-            vec![
-                "Favorite",
-                "zed/claude",
-                "Recommended",
-                "zed/claude",
-                "anthropic/claude",
-                "Zed",
-                "zed/claude",
-                "zed/gpt-5",
-                "Antropic",
-                "anthropic/claude",
-                "OpenAI",
-                "openai/gpt-5"
-            ]
-        );
-    }
-
-    #[gpui::test]
-    fn test_flat_model_list_with_favorites(_cx: &mut TestAppContext) {
-        let models = AgentModelList::Flat(vec![
-            acp_thread::AgentModelInfo {
-                id: acp::ModelId::new("zed/claude".to_string()),
-                name: "Claude".into(),
-                description: None,
-                icon: None,
-            },
-            acp_thread::AgentModelInfo {
-                id: acp::ModelId::new("zed/gemini".to_string()),
-                name: "Gemini".into(),
-                description: None,
-                icon: None,
-            },
-        ]);
-        let favorites = create_favorites(vec!["zed/gemini"]);
-
-        let entries = info_list_to_picker_entries(models, &favorites);
-
-        assert!(matches!(
-            entries.first(),
-            Some(AcpModelPickerEntry::Separator(s)) if s == "Favorite"
-        ));
-
-        assert!(entries.iter().any(|e| matches!(
-            e,
-            AcpModelPickerEntry::Separator(s) if s == "All"
-        )));
-    }
-
-    #[gpui::test]
-    fn test_favorites_count_returns_correct_count(_cx: &mut TestAppContext) {
-        let empty_favorites: HashSet<ModelId> = HashSet::default();
-        assert_eq!(empty_favorites.len(), 0);
-
-        let one_favorite = create_favorites(vec!["model-a"]);
-        assert_eq!(one_favorite.len(), 1);
-
-        let multiple_favorites = create_favorites(vec!["model-a", "model-b", "model-c"]);
-        assert_eq!(multiple_favorites.len(), 3);
-
-        let with_duplicates = create_favorites(vec!["model-a", "model-a", "model-b"]);
-        assert_eq!(with_duplicates.len(), 2);
-    }
-
-    #[gpui::test]
-    fn test_is_favorite_flag_set_correctly_in_entries(_cx: &mut TestAppContext) {
-        let models = AgentModelList::Flat(vec![
-            acp_thread::AgentModelInfo {
-                id: acp::ModelId::new("favorite-model".to_string()),
-                name: "Favorite".into(),
-                description: None,
-                icon: None,
-            },
-            acp_thread::AgentModelInfo {
-                id: acp::ModelId::new("regular-model".to_string()),
-                name: "Regular".into(),
-                description: None,
-                icon: None,
-            },
-        ]);
-        let favorites = create_favorites(vec!["favorite-model"]);
-
-        let entries = info_list_to_picker_entries(models, &favorites);
-
-        for entry in &entries {
-            if let AcpModelPickerEntry::Model(info, is_favorite) = entry {
-                if info.id.0.as_ref() == "favorite-model" {
-                    assert!(*is_favorite, "favorite-model should have is_favorite=true");
-                } else if info.id.0.as_ref() == "regular-model" {
-                    assert!(!*is_favorite, "regular-model should have is_favorite=false");
-                }
-            }
-        }
-    }
 }

crates/agent_ui/src/acp/model_selector_popover.rs

@@ -1,14 +1,18 @@
 use std::rc::Rc;
 use std::sync::Arc;
 
-use acp_thread::{AgentModelIcon, AgentModelInfo, AgentModelSelector};
+use acp_thread::{AgentModelInfo, AgentModelSelector};
+use agent_servers::AgentServer;
+use agent_settings::AgentSettings;
 use fs::Fs;
 use gpui::{Entity, FocusHandle};
 use picker::popover_menu::PickerPopoverMenu;
-use ui::{ButtonLike, PopoverMenuHandle, TintColor, Tooltip, prelude::*};
+use settings::Settings as _;
+use ui::{ButtonLike, KeyBinding, PopoverMenuHandle, TintColor, Tooltip, prelude::*};
+use zed_actions::agent::ToggleModelSelector;
 
+use crate::CycleFavoriteModels;
 use crate::acp::{AcpModelSelector, model_selector::acp_model_selector};
-use crate::ui::ModelSelectorTooltip;
 
 pub struct AcpModelSelectorPopover {
     selector: Entity<AcpModelSelector>,
@@ -19,7 +23,7 @@ pub struct AcpModelSelectorPopover {
 impl AcpModelSelectorPopover {
     pub(crate) fn new(
         selector: Rc<dyn AgentModelSelector>,
-        agent_server: Rc<dyn agent_servers::AgentServer>,
+        agent_server: Rc<dyn AgentServer>,
         fs: Arc<dyn Fs>,
         menu_handle: PopoverMenuHandle<AcpModelSelector>,
         focus_handle: FocusHandle,
@@ -60,14 +64,13 @@ impl AcpModelSelectorPopover {
 
 impl Render for AcpModelSelectorPopover {
     fn render(&mut self, window: &mut Window, cx: &mut Context<Self>) -> impl IntoElement {
-        let selector = self.selector.read(cx);
-        let model = selector.delegate.active_model();
+        let model = self.selector.read(cx).delegate.active_model();
         let model_name = model
             .as_ref()
             .map(|model| model.name.clone())
             .unwrap_or_else(|| SharedString::from("Select a Model"));
 
-        let model_icon = model.as_ref().and_then(|model| model.icon.clone());
+        let model_icon = model.as_ref().and_then(|model| model.icon);
 
         let focus_handle = self.focus_handle.clone();
 
@@ -77,13 +80,43 @@ impl Render for AcpModelSelectorPopover {
             (Color::Muted, IconName::ChevronDown)
         };
 
-        let show_cycle_row = selector.delegate.favorites_count() > 1;
-
         let tooltip = Tooltip::element({
-            move |_, _cx| {
-                ModelSelectorTooltip::new(focus_handle.clone())
-                    .show_cycle_row(show_cycle_row)
-                    .into_any_element()
+            move |_, cx| {
+                let focus_handle = focus_handle.clone();
+                let should_show_cycle_row = !AgentSettings::get_global(cx)
+                    .favorite_model_ids()
+                    .is_empty();
+
+                v_flex()
+                    .gap_1()
+                    .child(
+                        h_flex()
+                            .gap_2()
+                            .justify_between()
+                            .child(Label::new("Change Model"))
+                            .child(KeyBinding::for_action_in(
+                                &ToggleModelSelector,
+                                &focus_handle,
+                                cx,
+                            )),
+                    )
+                    .when(should_show_cycle_row, |this| {
+                        this.child(
+                            h_flex()
+                                .pt_1()
+                                .gap_2()
+                                .border_t_1()
+                                .border_color(cx.theme().colors().border_variant)
+                                .justify_between()
+                                .child(Label::new("Cycle Favorited Models"))
+                                .child(KeyBinding::for_action_in(
+                                    &CycleFavoriteModels,
+                                    &focus_handle,
+                                    cx,
+                                )),
+                        )
+                    })
+                    .into_any()
             }
         });
 
@@ -92,14 +125,7 @@ impl Render for AcpModelSelectorPopover {
             ButtonLike::new("active-model")
                 .selected_style(ButtonStyle::Tinted(TintColor::Accent))
                 .when_some(model_icon, |this, icon| {
-                    this.child(
-                        match icon {
-                            AgentModelIcon::Path(path) => Icon::from_external_svg(path),
-                            AgentModelIcon::Named(icon_name) => Icon::new(icon_name),
-                        }
-                        .color(color)
-                        .size(IconSize::XSmall),
-                    )
+                    this.child(Icon::new(icon).color(color).size(IconSize::XSmall))
                 })
                 .child(
                     Label::new(model_name)

crates/agent_ui/src/acp/thread_history.rs

@@ -1,7 +1,7 @@
 use crate::acp::AcpThreadView;
 use crate::{AgentPanel, RemoveHistory, RemoveSelectedThread};
 use agent::{HistoryEntry, HistoryStore};
-use chrono::{Datelike as _, Local, NaiveDate, TimeDelta, Utc};
+use chrono::{Datelike as _, Local, NaiveDate, TimeDelta};
 use editor::{Editor, EditorEvent};
 use fuzzy::StringMatchCandidate;
 use gpui::{
@@ -402,22 +402,7 @@ impl AcpThreadHistory {
         let selected = ix == self.selected_index;
         let hovered = Some(ix) == self.hovered_index;
         let timestamp = entry.updated_at().timestamp();
-
-        let display_text = match format {
-            EntryTimeFormat::DateAndTime => {
-                let entry_time = entry.updated_at();
-                let now = Utc::now();
-                let duration = now.signed_duration_since(entry_time);
-                let days = duration.num_days();
-
-                format!("{}d", days)
-            }
-            EntryTimeFormat::TimeOnly => format.format_timestamp(timestamp, self.local_timezone),
-        };
-
-        let title = entry.title().clone();
-        let full_date =
-            EntryTimeFormat::DateAndTime.format_timestamp(timestamp, self.local_timezone);
+        let thread_timestamp = format.format_timestamp(timestamp, self.local_timezone);
 
         h_flex()
             .w_full()
@@ -438,14 +423,11 @@ impl AcpThreadHistory {
                                     .truncate(),
                             )
                             .child(
-                                Label::new(display_text)
+                                Label::new(thread_timestamp)
                                     .color(Color::Muted)
                                     .size(LabelSize::XSmall),
                             ),
                     )
-                    .tooltip(move |_, cx| {
-                        Tooltip::with_meta(title.clone(), None, full_date.clone(), cx)
-                    })
                     .on_hover(cx.listener(move |this, is_hovered, _window, cx| {
                         if *is_hovered {
                             this.hovered_index = Some(ix);

crates/agent_ui/src/agent_configuration.rs

@@ -22,8 +22,7 @@ use gpui::{
 };
 use language::LanguageRegistry;
 use language_model::{
-    IconOrSvg, LanguageModelProvider, LanguageModelProviderId, LanguageModelRegistry,
-    ZED_CLOUD_PROVIDER_ID,
+    LanguageModelProvider, LanguageModelProviderId, LanguageModelRegistry, ZED_CLOUD_PROVIDER_ID,
 };
 use language_models::AllLanguageModelSettings;
 use notifications::status_toast::{StatusToast, ToastIcon};
@@ -118,7 +117,7 @@ impl AgentConfiguration {
     }
 
     fn build_provider_configuration_views(&mut self, window: &mut Window, cx: &mut Context<Self>) {
-        let providers = LanguageModelRegistry::read_global(cx).visible_providers();
+        let providers = LanguageModelRegistry::read_global(cx).providers();
         for provider in providers {
             self.add_provider_configuration_view(&provider, window, cx);
         }
@@ -262,12 +261,9 @@ impl AgentConfiguration {
                                     .w_full()
                                     .gap_1p5()
                                     .child(
-                                        match provider.icon() {
-                                            IconOrSvg::Svg(path) => Icon::from_external_svg(path),
-                                            IconOrSvg::Icon(name) => Icon::new(name),
-                                        }
-                                        .size(IconSize::Small)
-                                        .color(Color::Muted),
+                                        Icon::new(provider.icon())
+                                            .size(IconSize::Small)
+                                            .color(Color::Muted),
                                     )
                                     .child(
                                         h_flex()
@@ -420,7 +416,7 @@ impl AgentConfiguration {
         &mut self,
         cx: &mut Context<Self>,
     ) -> impl IntoElement {
-        let providers = LanguageModelRegistry::read_global(cx).visible_providers();
+        let providers = LanguageModelRegistry::read_global(cx).providers();
 
         let popover_menu = PopoverMenu::new("add-provider-popover")
             .trigger(
@@ -1370,9 +1366,6 @@ async fn open_new_agent_servers_entry_in_settings_editor(
                                 env: Some(HashMap::default()),
                                 default_mode: None,
                                 default_model: None,
-                                favorite_models: vec![],
-                                default_config_options: Default::default(),
-                                favorite_config_option_values: Default::default(),
                             },
                         );
                 }

crates/agent_ui/src/agent_diff.rs

@@ -17,7 +17,7 @@ use gpui::{
     Global, SharedString, Subscription, Task, WeakEntity, Window, prelude::*,
 };
 
-use language::{Buffer, Capability, OffsetRangeExt, Point};
+use language::{Buffer, Capability, DiskState, OffsetRangeExt, Point};
 use multi_buffer::PathKey;
 use project::{Project, ProjectItem, ProjectPath};
 use settings::{Settings, SettingsStore};
@@ -192,7 +192,7 @@ impl AgentDiffPane {
                     && buffer
                         .read(cx)
                         .file()
-                        .is_some_and(|file| file.disk_state().is_deleted())
+                        .is_some_and(|file| file.disk_state() == DiskState::Deleted)
                 {
                     editor.fold_buffer(snapshot.text.remote_id(), cx)
                 }
@@ -1363,8 +1363,7 @@ impl AgentDiff {
             | AcpThreadEvent::PromptCapabilitiesUpdated
             | AcpThreadEvent::AvailableCommandsUpdated(_)
             | AcpThreadEvent::Retry(_)
-            | AcpThreadEvent::ModeUpdated(_)
-            | AcpThreadEvent::ConfigOptionsUpdated(_) => {}
+            | AcpThreadEvent::ModeUpdated(_) => {}
         }
     }
 

crates/agent_ui/src/agent_model_selector.rs

@@ -1,15 +1,14 @@
 use crate::{
     ModelUsageContext,
     language_model_selector::{LanguageModelSelector, language_model_selector},
-    ui::ModelSelectorTooltip,
 };
 use fs::Fs;
 use gpui::{Entity, FocusHandle, SharedString};
-use language_model::IconOrSvg;
 use picker::popover_menu::PickerPopoverMenu;
 use settings::update_settings_file;
 use std::sync::Arc;
 use ui::{ButtonLike, PopoverMenuHandle, TintColor, Tooltip, prelude::*};
+use zed_actions::agent::ToggleModelSelector;
 
 pub struct AgentModelSelector {
     selector: Entity<LanguageModelSelector>,
@@ -81,12 +80,6 @@ impl AgentModelSelector {
     pub fn active_model(&self, cx: &App) -> Option<language_model::ConfiguredModel> {
         self.selector.read(cx).delegate.active_model(cx)
     }
-
-    pub fn cycle_favorite_models(&self, window: &mut Window, cx: &mut Context<Self>) {
-        self.selector.update(cx, |selector, cx| {
-            selector.delegate.cycle_favorite_models(window, cx);
-        });
-    }
 }
 
 impl Render for AgentModelSelector {
@@ -104,30 +97,13 @@ impl Render for AgentModelSelector {
             Color::Muted
         };
 
-        let show_cycle_row = self.selector.read(cx).delegate.favorites_count() > 1;
-
         let focus_handle = self.focus_handle.clone();
 
-        let tooltip = Tooltip::element({
-            move |_, _cx| {
-                ModelSelectorTooltip::new(focus_handle.clone())
-                    .show_cycle_row(show_cycle_row)
-                    .into_any_element()
-            }
-        });
-
         PickerPopoverMenu::new(
             self.selector.clone(),
             ButtonLike::new("active-model")
                 .when_some(provider_icon, |this, icon| {
-                    this.child(
-                        match icon {
-                            IconOrSvg::Svg(path) => Icon::from_external_svg(path),
-                            IconOrSvg::Icon(name) => Icon::new(name),
-                        }
-                        .color(color)
-                        .size(IconSize::XSmall),
-                    )
+                    this.child(Icon::new(icon).color(color).size(IconSize::XSmall))
                 })
                 .selected_style(ButtonStyle::Tinted(TintColor::Accent))
                 .child(
@@ -139,9 +115,11 @@ impl Render for AgentModelSelector {
                 .child(
                     Icon::new(IconName::ChevronDown)
                         .color(color)
-                        .size(IconSize::XSmall),
+                        .size(IconSize::Small),
                 ),
-            tooltip,
+            move |_window, cx| {
+                Tooltip::for_action_in("Change Model", &ToggleModelSelector, &focus_handle, cx)
+            },
             gpui::Corner::TopRight,
             cx,
         )

crates/agent_ui/src/agent_panel.rs

@@ -2428,7 +2428,7 @@ impl AgentPanel {
                 let history_is_empty = self.history_store.read(cx).is_empty(cx);
 
                 let has_configured_non_zed_providers = LanguageModelRegistry::read_global(cx)
-                    .visible_providers()
+                    .providers()
                     .iter()
                     .any(|provider| {
                         provider.is_authenticated(cx)

crates/agent_ui/src/agent_ui.rs

@@ -348,8 +348,7 @@ fn init_language_model_settings(cx: &mut App) {
         |_, event: &language_model::Event, cx| match event {
             language_model::Event::ProviderStateChanged(_)
             | language_model::Event::AddedProvider(_)
-            | language_model::Event::RemovedProvider(_)
-            | language_model::Event::ProvidersChanged => {
+            | language_model::Event::RemovedProvider(_) => {
                 update_active_language_model_from_settings(cx);
             }
             _ => {}

crates/agent_ui/src/completion_provider.rs

@@ -1586,7 +1586,7 @@ pub(crate) fn search_rules(
                     None
                 } else {
                     Some(RulesContextEntry {
-                        prompt_id: metadata.id.as_user()?,
+                        prompt_id: metadata.id.user_id()?,
                         title: metadata.title?,
                     })
                 }

crates/agent_ui/src/favorite_models.rs

@@ -1,5 +1,6 @@
 use std::sync::Arc;
 
+use agent_client_protocol::ModelId;
 use fs::Fs;
 use language_model::LanguageModel;
 use settings::{LanguageModelSelection, update_settings_file};
@@ -12,11 +13,20 @@ fn language_model_to_selection(model: &Arc<dyn LanguageModel>) -> LanguageModelS
     }
 }
 
+fn model_id_to_selection(model_id: &ModelId) -> LanguageModelSelection {
+    let id = model_id.0.as_ref();
+    let (provider, model) = id.split_once('/').unwrap_or(("", id));
+    LanguageModelSelection {
+        provider: provider.to_owned().into(),
+        model: model.to_owned(),
+    }
+}
+
 pub fn toggle_in_settings(
     model: Arc<dyn LanguageModel>,
     should_be_favorite: bool,
     fs: Arc<dyn Fs>,
-    cx: &mut App,
+    cx: &App,
 ) {
     let selection = language_model_to_selection(&model);
     update_settings_file(fs, cx, move |settings, _| {
@@ -28,3 +38,20 @@ pub fn toggle_in_settings(
         }
     });
 }
+
+pub fn toggle_model_id_in_settings(
+    model_id: ModelId,
+    should_be_favorite: bool,
+    fs: Arc<dyn Fs>,
+    cx: &App,
+) {
+    let selection = model_id_to_selection(&model_id);
+    update_settings_file(fs, cx, move |settings, _| {
+        let agent = settings.agent.get_or_insert_default();
+        if should_be_favorite {
+            agent.add_favorite_model(selection.clone());
+        } else {
+            agent.remove_favorite_model(&selection);
+        }
+    });
+}

crates/agent_ui/src/inline_assistant.rs

@@ -1259,26 +1259,28 @@ impl InlineAssistant {
                 let bottom = top + 1.0;
                 (top, bottom)
             });
-            let height_in_lines = editor.visible_line_count().unwrap_or(0.);
-            let vertical_scroll_margin = editor.vertical_scroll_margin() as ScrollOffset;
-            let scroll_target_top = (scroll_target_range.0 - vertical_scroll_margin)
-                // Don't scroll up too far in the case of a large vertical_scroll_margin.
-                .max(scroll_target_range.0 - height_in_lines / 2.0);
-            let scroll_target_bottom = (scroll_target_range.1 + vertical_scroll_margin)
-                // Don't scroll down past where the top would still be visible.
-                .min(scroll_target_top + height_in_lines);
+            let mut scroll_target_top = scroll_target_range.0;
+            let mut scroll_target_bottom = scroll_target_range.1;
 
+            scroll_target_top -= editor.vertical_scroll_margin() as ScrollOffset;
+            scroll_target_bottom += editor.vertical_scroll_margin() as ScrollOffset;
+
+            let height_in_lines = editor.visible_line_count().unwrap_or(0.);
             let scroll_top = editor.scroll_position(cx).y;
             let scroll_bottom = scroll_top + height_in_lines;
 
             if scroll_target_top < scroll_top {
                 editor.set_scroll_position(point(0., scroll_target_top), window, cx);
             } else if scroll_target_bottom > scroll_bottom {
-                editor.set_scroll_position(
-                    point(0., scroll_target_bottom - height_in_lines),
-                    window,
-                    cx,
-                );
+                if (scroll_target_bottom - scroll_target_top) <= height_in_lines {
+                    editor.set_scroll_position(
+                        point(0., scroll_target_bottom - height_in_lines),
+                        window,
+                        cx,
+                    );
+                } else {
+                    editor.set_scroll_position(point(0., scroll_target_top), window, cx);
+                }
             }
         });
     }

crates/agent_ui/src/inline_prompt_editor.rs

@@ -40,9 +40,7 @@ use crate::completion_provider::{
 use crate::mention_set::paste_images_as_context;
 use crate::mention_set::{MentionSet, crease_for_mention};
 use crate::terminal_codegen::TerminalCodegen;
-use crate::{
-    CycleFavoriteModels, CycleNextInlineAssist, CyclePreviousInlineAssist, ModelUsageContext,
-};
+use crate::{CycleNextInlineAssist, CyclePreviousInlineAssist, ModelUsageContext};
 
 actions!(inline_assistant, [ThumbsUpResult, ThumbsDownResult]);
 
@@ -150,7 +148,7 @@ impl<T: 'static> Render for PromptEditor<T> {
             .into_any_element();
 
         v_flex()
-            .key_context("InlineAssistant")
+            .key_context("PromptEditor")
             .capture_action(cx.listener(Self::paste))
             .block_mouse_except_scroll()
             .size_full()
@@ -164,6 +162,10 @@ impl<T: 'static> Render for PromptEditor<T> {
             .bg(cx.theme().colors().editor_background)
             .child(
                 h_flex()
+                    .on_action(cx.listener(|this, _: &ToggleModelSelector, window, cx| {
+                        this.model_selector
+                            .update(cx, |model_selector, cx| model_selector.toggle(window, cx));
+                    }))
                     .on_action(cx.listener(Self::confirm))
                     .on_action(cx.listener(Self::cancel))
                     .on_action(cx.listener(Self::move_up))
@@ -172,15 +174,6 @@ impl<T: 'static> Render for PromptEditor<T> {
                     .on_action(cx.listener(Self::thumbs_down))
                     .capture_action(cx.listener(Self::cycle_prev))
                     .capture_action(cx.listener(Self::cycle_next))
-                    .on_action(cx.listener(|this, _: &ToggleModelSelector, window, cx| {
-                        this.model_selector
-                            .update(cx, |model_selector, cx| model_selector.toggle(window, cx));
-                    }))
-                    .on_action(cx.listener(|this, _: &CycleFavoriteModels, window, cx| {
-                        this.model_selector.update(cx, |model_selector, cx| {
-                            model_selector.cycle_favorite_models(window, cx);
-                        });
-                    }))
                     .child(
                         WithRemSize::new(ui_font_size)
                             .h_full()
@@ -862,7 +855,7 @@ impl<T: 'static> PromptEditor<T> {
                                         .map(|this| {
                                             if rated {
                                                 this.disabled(true)
-                                                    .icon_color(Color::Disabled)
+                                                    .icon_color(Color::Ignored)
                                                     .tooltip(move |_, cx| {
                                                         Tooltip::with_meta(
                                                             "Good Result",
@@ -872,15 +865,8 @@ impl<T: 'static> PromptEditor<T> {
                                                         )
                                                     })
                                             } else {
-                                                this.icon_color(Color::Muted).tooltip(
-                                                    move |_, cx| {
-                                                        Tooltip::for_action(
-                                                            "Good Result",
-                                                            &ThumbsUpResult,
-                                                            cx,
-                                                        )
-                                                    },
-                                                )
+                                                this.icon_color(Color::Muted)
+                                                    .tooltip(Tooltip::text("Good Result"))
                                             }
                                         })
                                         .on_click(cx.listener(|this, _, window, cx| {
@@ -893,7 +879,7 @@ impl<T: 'static> PromptEditor<T> {
                                         .map(|this| {
                                             if rated {
                                                 this.disabled(true)
-                                                    .icon_color(Color::Disabled)
+                                                    .icon_color(Color::Ignored)
                                                     .tooltip(move |_, cx| {
                                                         Tooltip::with_meta(
                                                             "Bad Result",
@@ -903,15 +889,8 @@ impl<T: 'static> PromptEditor<T> {
                                                         )
                                                     })
                                             } else {
-                                                this.icon_color(Color::Muted).tooltip(
-                                                    move |_, cx| {
-                                                        Tooltip::for_action(
-                                                            "Bad Result",
-                                                            &ThumbsDownResult,
-                                                            cx,
-                                                        )
-                                                    },
-                                                )
+                                                this.icon_color(Color::Muted)
+                                                    .tooltip(Tooltip::text("Bad Result"))
                                             }
                                         })
                                         .on_click(cx.listener(|this, _, window, cx| {
@@ -1109,6 +1088,7 @@ impl<T: 'static> PromptEditor<T> {
         let colors = cx.theme().colors();
 
         div()
+            .key_context("InlineAssistEditor")
             .size_full()
             .p_2()
             .pl_1()

crates/agent_ui/src/language_model_selector.rs

@@ -7,8 +7,8 @@ use gpui::{
     Action, AnyElement, App, BackgroundExecutor, DismissEvent, FocusHandle, Subscription, Task,
 };
 use language_model::{
-    AuthenticateError, ConfiguredModel, IconOrSvg, LanguageModel, LanguageModelId,
-    LanguageModelProvider, LanguageModelProviderId, LanguageModelRegistry,
+    AuthenticateError, ConfiguredModel, LanguageModel, LanguageModelId, LanguageModelProvider,
+    LanguageModelProviderId, LanguageModelRegistry,
 };
 use ordered_float::OrderedFloat;
 use picker::{Picker, PickerDelegate};
@@ -20,14 +20,14 @@ use crate::ui::{ModelSelectorFooter, ModelSelectorHeader, ModelSelectorListItem}
 
 type OnModelChanged = Arc<dyn Fn(Arc<dyn LanguageModel>, &mut App) + 'static>;
 type GetActiveModel = Arc<dyn Fn(&App) -> Option<ConfiguredModel> + 'static>;
-type OnToggleFavorite = Arc<dyn Fn(Arc<dyn LanguageModel>, bool, &mut App) + 'static>;
+type OnToggleFavorite = Arc<dyn Fn(Arc<dyn LanguageModel>, bool, &App) + 'static>;
 
 pub type LanguageModelSelector = Picker<LanguageModelPickerDelegate>;
 
 pub fn language_model_selector(
     get_active_model: impl Fn(&App) -> Option<ConfiguredModel> + 'static,
     on_model_changed: impl Fn(Arc<dyn LanguageModel>, &mut App) + 'static,
-    on_toggle_favorite: impl Fn(Arc<dyn LanguageModel>, bool, &mut App) + 'static,
+    on_toggle_favorite: impl Fn(Arc<dyn LanguageModel>, bool, &App) + 'static,
     popover_styles: bool,
     focus_handle: FocusHandle,
     window: &mut Window,
@@ -55,7 +55,7 @@ pub fn language_model_selector(
 
 fn all_models(cx: &App) -> GroupedModels {
     let lm_registry = LanguageModelRegistry::global(cx).read(cx);
-    let providers = lm_registry.visible_providers();
+    let providers = lm_registry.providers();
 
     let mut favorites_index = FavoritesIndex::default();
 
@@ -94,7 +94,7 @@ type FavoritesIndex = HashMap<LanguageModelProviderId, HashSet<LanguageModelId>>
 #[derive(Clone)]
 struct ModelInfo {
     model: Arc<dyn LanguageModel>,
-    icon: IconOrSvg,
+    icon: IconName,
     is_favorite: bool,
 }
 
@@ -133,7 +133,7 @@ impl LanguageModelPickerDelegate {
     fn new(
         get_active_model: impl Fn(&App) -> Option<ConfiguredModel> + 'static,
         on_model_changed: impl Fn(Arc<dyn LanguageModel>, &mut App) + 'static,
-        on_toggle_favorite: impl Fn(Arc<dyn LanguageModel>, bool, &mut App) + 'static,
+        on_toggle_favorite: impl Fn(Arc<dyn LanguageModel>, bool, &App) + 'static,
         popover_styles: bool,
         focus_handle: FocusHandle,
         window: &mut Window,
@@ -203,7 +203,7 @@ impl LanguageModelPickerDelegate {
     fn authenticate_all_providers(cx: &mut App) -> Task<()> {
         let authenticate_all_providers = LanguageModelRegistry::global(cx)
             .read(cx)
-            .visible_providers()
+            .providers()
             .iter()
             .map(|provider| (provider.id(), provider.name(), provider.authenticate(cx)))
             .collect::<Vec<_>>();
@@ -250,10 +250,6 @@ impl LanguageModelPickerDelegate {
         (self.get_active_model)(cx)
     }
 
-    pub fn favorites_count(&self) -> usize {
-        self.all_models.favorites.len()
-    }
-
     pub fn cycle_favorite_models(&mut self, window: &mut Window, cx: &mut Context<Picker<Self>>) {
         if self.all_models.favorites.is_empty() {
             return;
@@ -478,7 +474,7 @@ impl PickerDelegate for LanguageModelPickerDelegate {
 
         let configured_providers = language_model_registry
             .read(cx)
-            .visible_providers()
+            .providers()
             .into_iter()
             .filter(|provider| provider.is_authenticated(cx))
             .collect::<Vec<_>>();
@@ -565,18 +561,12 @@ impl PickerDelegate for LanguageModelPickerDelegate {
                 let handle_action_click = {
                     let model = model_info.model.clone();
                     let on_toggle_favorite = self.on_toggle_favorite.clone();
-                    cx.listener(move |picker, _, window, cx| {
-                        on_toggle_favorite(model.clone(), !is_favorite, cx);
-                        picker.refresh(window, cx);
-                    })
+                    move |cx: &App| on_toggle_favorite(model.clone(), !is_favorite, cx)
                 };
 
                 Some(
                     ModelSelectorListItem::new(ix, model_info.model.name().0)
-                        .map(|this| match &model_info.icon {
-                            IconOrSvg::Icon(icon_name) => this.icon(*icon_name),
-                            IconOrSvg::Svg(icon_path) => this.icon_path(icon_path.clone()),
-                        })
+                        .icon(model_info.icon)
                         .is_selected(is_selected)
                         .is_focused(selected)
                         .is_favorite(is_favorite)
@@ -712,7 +702,7 @@ mod tests {
                     .any(|(fav_provider, fav_name)| *fav_provider == provider && *fav_name == name);
                 ModelInfo {
                     model: Arc::new(TestLanguageModel::new(name, provider)),
-                    icon: IconOrSvg::Icon(IconName::Ai),
+                    icon: IconName::Ai,
                     is_favorite,
                 }
             })

crates/agent_ui/src/mention_set.rs

@@ -12,8 +12,8 @@ use editor::{
 };
 use futures::{AsyncReadExt as _, FutureExt as _, future::Shared};
 use gpui::{
-    AppContext, ClipboardEntry, Context, Empty, Entity, EntityId, Image, ImageFormat, Img,
-    SharedString, Task, WeakEntity,
+    Animation, AnimationExt as _, AppContext, ClipboardEntry, Context, Empty, Entity, EntityId,
+    Image, ImageFormat, Img, SharedString, Task, WeakEntity, pulsating_between,
 };
 use http_client::{AsyncBody, HttpClientWithUrl};
 use itertools::Either;
@@ -32,14 +32,13 @@ use std::{
     path::{Path, PathBuf},
     rc::Rc,
     sync::Arc,
+    time::Duration,
 };
 use text::OffsetRangeExt;
-use ui::{Disclosure, Toggleable, prelude::*};
+use ui::{ButtonLike, Disclosure, TintColor, Toggleable, prelude::*};
 use util::{ResultExt, debug_panic, rel_path::RelPath};
 use workspace::{Workspace, notifications::NotifyResultExt as _};
 
-use crate::ui::MentionCrease;
-
 pub type MentionTask = Shared<Task<Result<Mention, String>>>;
 
 #[derive(Debug, Clone, Eq, PartialEq)]
@@ -755,8 +754,25 @@ fn render_fold_icon_button(
                 .update(cx, |editor, cx| editor.is_range_selected(&fold_range, cx))
                 .unwrap_or_default();
 
-            MentionCrease::new(fold_id, icon_path.clone(), label.clone())
-                .is_toggled(is_in_text_selection)
+            ButtonLike::new(fold_id)
+                .style(ButtonStyle::Filled)
+                .selected_style(ButtonStyle::Tinted(TintColor::Accent))
+                .toggle_state(is_in_text_selection)
+                .child(
+                    h_flex()
+                        .gap_1()
+                        .child(
+                            Icon::from_path(icon_path.clone())
+                                .size(IconSize::XSmall)
+                                .color(Color::Muted),
+                        )
+                        .child(
+                            Label::new(label.clone())
+                                .size(LabelSize::Small)
+                                .buffer_font(cx)
+                                .single_line(),
+                        ),
+                )
                 .into_any_element()
         }
     })
@@ -931,14 +947,12 @@ impl Render for LoadingContext {
             .editor
             .update(cx, |editor, cx| editor.is_range_selected(&self.range, cx))
             .unwrap_or_default();
-
-        let id = ElementId::from(("loading_context", self.id));
-
-        MentionCrease::new(id, self.icon.clone(), self.label.clone())
-            .is_toggled(is_in_text_selection)
-            .is_loading(self.loading.is_some())
-            .when_some(self.image.clone(), |this, image_task| {
-                this.image_preview(move |_, cx| {
+        ButtonLike::new(("loading-context", self.id))
+            .style(ButtonStyle::Filled)
+            .selected_style(ButtonStyle::Tinted(TintColor::Accent))
+            .toggle_state(is_in_text_selection)
+            .when_some(self.image.clone(), |el, image_task| {
+                el.hoverable_tooltip(move |_, cx| {
                     let image = image_task.peek().cloned().transpose().ok().flatten();
                     let image_task = image_task.clone();
                     cx.new::<ImageHover>(|cx| ImageHover {
@@ -957,6 +971,35 @@ impl Render for LoadingContext {
                     .into()
                 })
             })
+            .child(
+                h_flex()
+                    .gap_1()
+                    .child(
+                        Icon::from_path(self.icon.clone())
+                            .size(IconSize::XSmall)
+                            .color(Color::Muted),
+                    )
+                    .child(
+                        Label::new(self.label.clone())
+                            .size(LabelSize::Small)
+                            .buffer_font(cx)
+                            .single_line(),
+                    )
+                    .map(|el| {
+                        if self.loading.is_some() {
+                            el.with_animation(
+                                "loading-context-crease",
+                                Animation::new(Duration::from_secs(2))
+                                    .repeat()
+                                    .with_easing(pulsating_between(0.4, 0.8)),
+                                |label, delta| label.opacity(delta),
+                            )
+                            .into_any()
+                        } else {
+                            el.into_any()
+                        }
+                    }),
+            )
     }
 }
 

crates/agent_ui/src/profile_selector.rs

@@ -191,9 +191,6 @@ impl Render for ProfileSelector {
                     let container = || h_flex().gap_1().justify_between();
                     v_flex()
                         .gap_1()
-                        .child(container().child(Label::new("Toggle Profile Menu")).child(
-                            KeyBinding::for_action_in(&ToggleProfileSelector, &focus_handle, cx),
-                        ))
                         .child(
                             container()
                                 .pb_1()
@@ -206,6 +203,9 @@ impl Render for ProfileSelector {
                                     cx,
                                 )),
                         )
+                        .child(container().child(Label::new("Toggle Profile Menu")).child(
+                            KeyBinding::for_action_in(&ToggleProfileSelector, &focus_handle, cx),
+                        ))
                         .into_any()
                 }
             }),

crates/agent_ui/src/text_thread_editor.rs

@@ -1,8 +1,8 @@
 use crate::{
     language_model_selector::{LanguageModelSelector, language_model_selector},
-    ui::{BurnModeTooltip, ModelSelectorTooltip},
+    ui::BurnModeTooltip,
 };
-use agent_settings::CompletionMode;
+use agent_settings::{AgentSettings, CompletionMode};
 use anyhow::Result;
 use assistant_slash_command::{SlashCommand, SlashCommandOutputSection, SlashCommandWorkingSet};
 use assistant_slash_commands::{DefaultSlashCommand, FileSlashCommand, selections_creases};
@@ -33,8 +33,7 @@ use language::{
     language_settings::{SoftWrap, all_language_settings},
 };
 use language_model::{
-    ConfigurationError, IconOrSvg, LanguageModelExt, LanguageModelImage, LanguageModelRegistry,
-    Role,
+    ConfigurationError, LanguageModelExt, LanguageModelImage, LanguageModelRegistry, Role,
 };
 use multi_buffer::MultiBufferRow;
 use picker::{Picker, popover_menu::PickerPopoverMenu};
@@ -72,7 +71,7 @@ use workspace::{
     pane,
     searchable::{SearchEvent, SearchableItem},
 };
-use zed_actions::agent::{AddSelectionToThread, PasteRaw, ToggleModelSelector};
+use zed_actions::agent::{AddSelectionToThread, ToggleModelSelector};
 
 use crate::CycleFavoriteModels;
 
@@ -1699,9 +1698,6 @@ impl TextThreadEditor {
         window: &mut Window,
         cx: &mut Context<Self>,
     ) {
-        let Some(workspace) = self.workspace.upgrade() else {
-            return;
-        };
         let editor_clipboard_selections = cx
             .read_from_clipboard()
             .and_then(|item| item.entries().first().cloned())
@@ -1712,101 +1708,84 @@ impl TextThreadEditor {
                 _ => None,
             });
 
-        // Insert creases for pasted clipboard selections that:
-        // 1. Contain exactly one selection
-        // 2. Have an associated file path
-        // 3. Span multiple lines (not single-line selections)
-        // 4. Belong to a file that exists in the current project
-        let should_insert_creases = util::maybe!({
-            let selections = editor_clipboard_selections.as_ref()?;
-            if selections.len() > 1 {
-                return Some(false);
-            }
-            let selection = selections.first()?;
-            let file_path = selection.file_path.as_ref()?;
-            let line_range = selection.line_range.as_ref()?;
+        let has_file_context = editor_clipboard_selections
+            .as_ref()
+            .is_some_and(|selections| {
+                selections
+                    .iter()
+                    .any(|sel| sel.file_path.is_some() && sel.line_range.is_some())
+            });
 
-            if line_range.start() == line_range.end() {
-                return Some(false);
-            }
+        if has_file_context {
+            if let Some(clipboard_item) = cx.read_from_clipboard() {
+                if let Some(ClipboardEntry::String(clipboard_text)) =
+                    clipboard_item.entries().first()
+                {
+                    if let Some(selections) = editor_clipboard_selections {
+                        cx.stop_propagation();
 
-            Some(
-                workspace
-                    .read(cx)
-                    .project()
-                    .read(cx)
-                    .project_path_for_absolute_path(file_path, cx)
-                    .is_some(),
-            )
-        })
-        .unwrap_or(false);
+                        let text = clipboard_text.text();
+                        self.editor.update(cx, |editor, cx| {
+                            let mut current_offset = 0;
+                            let weak_editor = cx.entity().downgrade();
 
-        if should_insert_creases && let Some(clipboard_item) = cx.read_from_clipboard() {
-            if let Some(ClipboardEntry::String(clipboard_text)) = clipboard_item.entries().first() {
-                if let Some(selections) = editor_clipboard_selections {
-                    cx.stop_propagation();
+                            for selection in selections {
+                                if let (Some(file_path), Some(line_range)) =
+                                    (selection.file_path, selection.line_range)
+                                {
+                                    let selected_text =
+                                        &text[current_offset..current_offset + selection.len];
+                                    let fence = assistant_slash_commands::codeblock_fence_for_path(
+                                        file_path.to_str(),
+                                        Some(line_range.clone()),
+                                    );
+                                    let formatted_text = format!("{fence}{selected_text}\n```");
 
-                    let text = clipboard_text.text();
-                    self.editor.update(cx, |editor, cx| {
-                        let mut current_offset = 0;
-                        let weak_editor = cx.entity().downgrade();
+                                    let insert_point = editor
+                                        .selections
+                                        .newest::<Point>(&editor.display_snapshot(cx))
+                                        .head();
+                                    let start_row = MultiBufferRow(insert_point.row);
 
-                        for selection in selections {
-                            if let (Some(file_path), Some(line_range)) =
-                                (selection.file_path, selection.line_range)
-                            {
-                                let selected_text =
-                                    &text[current_offset..current_offset + selection.len];
-                                let fence = assistant_slash_commands::codeblock_fence_for_path(
-                                    file_path.to_str(),
-                                    Some(line_range.clone()),
-                                );
-                                let formatted_text = format!("{fence}{selected_text}\n```");
+                                    editor.insert(&formatted_text, window, cx);
 
-                                let insert_point = editor
-                                    .selections
-                                    .newest::<Point>(&editor.display_snapshot(cx))
-                                    .head();
-                                let start_row = MultiBufferRow(insert_point.row);
+                                    let snapshot = editor.buffer().read(cx).snapshot(cx);
+                                    let anchor_before = snapshot.anchor_after(insert_point);
+                                    let anchor_after = editor
+                                        .selections
+                                        .newest_anchor()
+                                        .head()
+                                        .bias_left(&snapshot);
 
-                                editor.insert(&formatted_text, window, cx);
+                                    editor.insert("\n", window, cx);
 
-                                let snapshot = editor.buffer().read(cx).snapshot(cx);
-                                let anchor_before = snapshot.anchor_after(insert_point);
-                                let anchor_after = editor
-                                    .selections
-                                    .newest_anchor()
-                                    .head()
-                                    .bias_left(&snapshot);
+                                    let crease_text = acp_thread::selection_name(
+                                        Some(file_path.as_ref()),
+                                        &line_range,
+                                    );
 
-                                editor.insert("\n", window, cx);
+                                    let fold_placeholder = quote_selection_fold_placeholder(
+                                        crease_text,
+                                        weak_editor.clone(),
+                                    );
+                                    let crease = Crease::inline(
+                                        anchor_before..anchor_after,
+                                        fold_placeholder,
+                                        render_quote_selection_output_toggle,
+                                        |_, _, _, _| Empty.into_any(),
+                                    );
+                                    editor.insert_creases(vec![crease], cx);
+                                    editor.fold_at(start_row, window, cx);
 
-                                let crease_text = acp_thread::selection_name(
-                                    Some(file_path.as_ref()),
-                                    &line_range,
-                                );
-
-                                let fold_placeholder = quote_selection_fold_placeholder(
-                                    crease_text,
-                                    weak_editor.clone(),
-                                );
-                                let crease = Crease::inline(
-                                    anchor_before..anchor_after,
-                                    fold_placeholder,
-                                    render_quote_selection_output_toggle,
-                                    |_, _, _, _| Empty.into_any(),
-                                );
-                                editor.insert_creases(vec![crease], cx);
-                                editor.fold_at(start_row, window, cx);
-
-                                current_offset += selection.len;
-                                if !selection.is_entire_line && current_offset < text.len() {
-                                    current_offset += 1;
+                                    current_offset += selection.len;
+                                    if !selection.is_entire_line && current_offset < text.len() {
+                                        current_offset += 1;
+                                    }
                                 }
                             }
-                        }
-                    });
-                    return;
+                        });
+                        return;
+                    }
                 }
             }
         }
@@ -1965,12 +1944,6 @@ impl TextThreadEditor {
         }
     }
 
-    fn paste_raw(&mut self, _: &PasteRaw, window: &mut Window, cx: &mut Context<Self>) {
-        self.editor.update(cx, |editor, cx| {
-            editor.paste(&editor::actions::Paste, window, cx);
-        });
-    }
-
     fn update_image_blocks(&mut self, cx: &mut Context<Self>) {
         self.editor.update(cx, |editor, cx| {
             let buffer = editor.buffer().read(cx).snapshot(cx);
@@ -2232,10 +2205,10 @@ impl TextThreadEditor {
             .default_model()
             .map(|default| default.provider);
 
-        let provider_icon = active_provider
-            .as_ref()
-            .map(|p| p.icon())
-            .unwrap_or(IconOrSvg::Icon(IconName::Ai));
+        let provider_icon = match active_provider {
+            Some(provider) => provider.icon(),
+            None => IconName::Ai,
+        };
 
         let focus_handle = self.editor().focus_handle(cx);
 
@@ -2245,25 +2218,43 @@ impl TextThreadEditor {
             (Color::Muted, IconName::ChevronDown)
         };
 
-        let provider_icon_element = match provider_icon {
-            IconOrSvg::Svg(path) => Icon::from_external_svg(path),
-            IconOrSvg::Icon(name) => Icon::new(name),
-        }
-        .color(color)
-        .size(IconSize::XSmall);
-
-        let show_cycle_row = self
-            .language_model_selector
-            .read(cx)
-            .delegate
-            .favorites_count()
-            > 1;
-
         let tooltip = Tooltip::element({
-            move |_, _cx| {
-                ModelSelectorTooltip::new(focus_handle.clone())
-                    .show_cycle_row(show_cycle_row)
-                    .into_any_element()
+            move |_, cx| {
+                let focus_handle = focus_handle.clone();
+                let should_show_cycle_row = !AgentSettings::get_global(cx)
+                    .favorite_model_ids()
+                    .is_empty();
+
+                v_flex()
+                    .gap_1()
+                    .child(
+                        h_flex()
+                            .gap_2()
+                            .justify_between()
+                            .child(Label::new("Change Model"))
+                            .child(KeyBinding::for_action_in(
+                                &ToggleModelSelector,
+                                &focus_handle,
+                                cx,
+                            )),
+                    )
+                    .when(should_show_cycle_row, |this| {
+                        this.child(
+                            h_flex()
+                                .pt_1()
+                                .gap_2()
+                                .border_t_1()
+                                .border_color(cx.theme().colors().border_variant)
+                                .justify_between()
+                                .child(Label::new("Cycle Favorited Models"))
+                                .child(KeyBinding::for_action_in(
+                                    &CycleFavoriteModels,
+                                    &focus_handle,
+                                    cx,
+                                )),
+                        )
+                    })
+                    .into_any()
             }
         });
 
@@ -2274,7 +2265,7 @@ impl TextThreadEditor {
                 .child(
                     h_flex()
                         .gap_0p5()
-                        .child(provider_icon_element)
+                        .child(Icon::new(provider_icon).color(color).size(IconSize::XSmall))
                         .child(
                             Label::new(model_name)
                                 .color(color)
@@ -2636,7 +2627,6 @@ impl Render for TextThreadEditor {
             .capture_action(cx.listener(TextThreadEditor::copy))
             .capture_action(cx.listener(TextThreadEditor::cut))
             .capture_action(cx.listener(TextThreadEditor::paste))
-            .on_action(cx.listener(TextThreadEditor::paste_raw))
             .capture_action(cx.listener(TextThreadEditor::cycle_message_role))
             .capture_action(cx.listener(TextThreadEditor::confirm_command))
             .on_action(cx.listener(TextThreadEditor::assist))

crates/agent_ui/src/ui.rs

@@ -4,7 +4,6 @@ mod burn_mode_tooltip;
 mod claude_code_onboarding_modal;
 mod end_trial_upsell;
 mod hold_for_default;
-mod mention_crease;
 mod model_selector_components;
 mod onboarding_modal;
 mod usage_callout;
@@ -15,7 +14,6 @@ pub use burn_mode_tooltip::*;
 pub use claude_code_onboarding_modal::*;
 pub use end_trial_upsell::*;
 pub use hold_for_default::*;
-pub use mention_crease::*;
 pub use model_selector_components::*;
 pub use onboarding_modal::*;
 pub use usage_callout::*;

crates/agent_ui/src/ui/hold_for_default.rs

@@ -27,7 +27,7 @@ impl RenderOnce for HoldForDefault {
                 PlatformStyle::platform(),
                 None,
                 Some(TextSize::Default.rems(cx).into()),
-                false,
+                true,
             )))
             .child(div().map(|this| {
                 if self.is_default {

crates/agent_ui/src/ui/mention_crease.rs

@@ -1,100 +0,0 @@
-use std::time::Duration;
-
-use gpui::{Animation, AnimationExt, AnyView, IntoElement, Window, pulsating_between};
-use settings::Settings;
-use theme::ThemeSettings;
-use ui::{ButtonLike, TintColor, prelude::*};
-
-#[derive(IntoElement)]
-pub struct MentionCrease {
-    id: ElementId,
-    icon: SharedString,
-    label: SharedString,
-    is_toggled: bool,
-    is_loading: bool,
-    image_preview: Option<Box<dyn Fn(&mut Window, &mut App) -> AnyView + 'static>>,
-}
-
-impl MentionCrease {
-    pub fn new(
-        id: impl Into<ElementId>,
-        icon: impl Into<SharedString>,
-        label: impl Into<SharedString>,
-    ) -> Self {
-        Self {
-            id: id.into(),
-            icon: icon.into(),
-            label: label.into(),
-            is_toggled: false,
-            is_loading: false,
-            image_preview: None,
-        }
-    }
-
-    pub fn is_toggled(mut self, is_toggled: bool) -> Self {
-        self.is_toggled = is_toggled;
-        self
-    }
-
-    pub fn is_loading(mut self, is_loading: bool) -> Self {
-        self.is_loading = is_loading;
-        self
-    }
-
-    pub fn image_preview(
-        mut self,
-        builder: impl Fn(&mut Window, &mut App) -> AnyView + 'static,
-    ) -> Self {
-        self.image_preview = Some(Box::new(builder));
-        self
-    }
-}
-
-impl RenderOnce for MentionCrease {
-    fn render(self, window: &mut Window, cx: &mut App) -> impl IntoElement {
-        let settings = ThemeSettings::get_global(cx);
-        let font_size = settings.agent_buffer_font_size(cx);
-        let buffer_font = settings.buffer_font.clone();
-
-        let button_height = DefiniteLength::Absolute(AbsoluteLength::Pixels(
-            px(window.line_height().into()) - px(1.),
-        ));
-
-        ButtonLike::new(self.id)
-            .style(ButtonStyle::Outlined)
-            .size(ButtonSize::Compact)
-            .height(button_height)
-            .selected_style(ButtonStyle::Tinted(TintColor::Accent))
-            .toggle_state(self.is_toggled)
-            .when_some(self.image_preview, |this, image_preview| {
-                this.hoverable_tooltip(image_preview)
-            })
-            .child(
-                h_flex()
-                    .pb_px()
-                    .gap_1()
-                    .font(buffer_font)
-                    .text_size(font_size)
-                    .child(
-                        Icon::from_path(self.icon.clone())
-                            .size(IconSize::XSmall)
-                            .color(Color::Muted),
-                    )
-                    .child(self.label.clone())
-                    .map(|this| {
-                        if self.is_loading {
-                            this.with_animation(
-                                "loading-context-crease",
-                                Animation::new(Duration::from_secs(2))
-                                    .repeat()
-                                    .with_easing(pulsating_between(0.4, 0.8)),
-                                |label, delta| label.opacity(delta),
-                            )
-                            .into_any()
-                        } else {
-                            this.into_any()
-                        }
-                    }),
-            )
-    }
-}

crates/agent_ui/src/ui/model_selector_components.rs

@@ -1,13 +1,5 @@
-use gpui::{Action, ClickEvent, FocusHandle, prelude::*};
+use gpui::{Action, FocusHandle, prelude::*};
 use ui::{ElevationIndex, KeyBinding, ListItem, ListItemSpacing, Tooltip, prelude::*};
-use zed_actions::agent::ToggleModelSelector;
-
-use crate::CycleFavoriteModels;
-
-enum ModelIcon {
-    Name(IconName),
-    Path(SharedString),
-}
 
 #[derive(IntoElement)]
 pub struct ModelSelectorHeader {
@@ -47,11 +39,11 @@ impl RenderOnce for ModelSelectorHeader {
 pub struct ModelSelectorListItem {
     index: usize,
     title: SharedString,
-    icon: Option<ModelIcon>,
+    icon: Option<IconName>,
     is_selected: bool,
     is_focused: bool,
     is_favorite: bool,
-    on_toggle_favorite: Option<Box<dyn Fn(&ClickEvent, &mut Window, &mut App) + 'static>>,
+    on_toggle_favorite: Option<Box<dyn Fn(&App) + 'static>>,
 }
 
 impl ModelSelectorListItem {
@@ -68,12 +60,7 @@ impl ModelSelectorListItem {
     }
 
     pub fn icon(mut self, icon: IconName) -> Self {
-        self.icon = Some(ModelIcon::Name(icon));
-        self
-    }
-
-    pub fn icon_path(mut self, path: SharedString) -> Self {
-        self.icon = Some(ModelIcon::Path(path));
+        self.icon = Some(icon);
         self
     }
 
@@ -92,10 +79,7 @@ impl ModelSelectorListItem {
         self
     }
 
-    pub fn on_toggle_favorite(
-        mut self,
-        handler: impl Fn(&ClickEvent, &mut Window, &mut App) + 'static,
-    ) -> Self {
+    pub fn on_toggle_favorite(mut self, handler: impl Fn(&App) + 'static) -> Self {
         self.on_toggle_favorite = Some(Box::new(handler));
         self
     }
@@ -121,12 +105,9 @@ impl RenderOnce for ModelSelectorListItem {
                     .gap_1p5()
                     .when_some(self.icon, |this, icon| {
                         this.child(
-                            match icon {
-                                ModelIcon::Name(icon_name) => Icon::new(icon_name),
-                                ModelIcon::Path(icon_path) => Icon::from_external_svg(icon_path),
-                            }
-                            .color(model_icon_color)
-                            .size(IconSize::Small),
+                            Icon::new(icon)
+                                .color(model_icon_color)
+                                .size(IconSize::Small),
                         )
                     })
                     .child(Label::new(self.title).truncate()),
@@ -147,7 +128,7 @@ impl RenderOnce for ModelSelectorListItem {
                             .icon_color(color)
                             .icon_size(IconSize::Small)
                             .tooltip(Tooltip::text(tooltip))
-                            .on_click(move |event, window, cx| (handle_click)(event, window, cx)),
+                            .on_click(move |_, _, cx| (handle_click)(cx)),
                     )
                 }
             }))
@@ -193,57 +174,3 @@ impl RenderOnce for ModelSelectorFooter {
             )
     }
 }
-
-#[derive(IntoElement)]
-pub struct ModelSelectorTooltip {
-    focus_handle: FocusHandle,
-    show_cycle_row: bool,
-}
-
-impl ModelSelectorTooltip {
-    pub fn new(focus_handle: FocusHandle) -> Self {
-        Self {
-            focus_handle,
-            show_cycle_row: true,
-        }
-    }
-
-    pub fn show_cycle_row(mut self, show: bool) -> Self {
-        self.show_cycle_row = show;
-        self
-    }
-}
-
-impl RenderOnce for ModelSelectorTooltip {
-    fn render(self, _window: &mut Window, cx: &mut App) -> impl IntoElement {
-        v_flex()
-            .gap_1()
-            .child(
-                h_flex()
-                    .gap_2()
-                    .justify_between()
-                    .child(Label::new("Change Model"))
-                    .child(KeyBinding::for_action_in(
-                        &ToggleModelSelector,
-                        &self.focus_handle,
-                        cx,
-                    )),
-            )
-            .when(self.show_cycle_row, |this| {
-                this.child(
-                    h_flex()
-                        .pt_1()
-                        .gap_2()
-                        .border_t_1()
-                        .border_color(cx.theme().colors().border_variant)
-                        .justify_between()
-                        .child(Label::new("Cycle Favorited Models"))
-                        .child(KeyBinding::for_action_in(
-                            &CycleFavoriteModels,
-                            &self.focus_handle,
-                            cx,
-                        )),
-                )
-            })
-    }
-}

crates/agent_ui_v2/src/thread_history.rs

@@ -1,5 +1,5 @@
 use agent::{HistoryEntry, HistoryStore};
-use chrono::{Datelike as _, Local, NaiveDate, TimeDelta, Utc};
+use chrono::{Datelike as _, Local, NaiveDate, TimeDelta};
 use editor::{Editor, EditorEvent};
 use fuzzy::StringMatchCandidate;
 use gpui::{
@@ -411,22 +411,7 @@ impl AcpThreadHistory {
         let selected = ix == self.selected_index;
         let hovered = Some(ix) == self.hovered_index;
         let timestamp = entry.updated_at().timestamp();
-
-        let display_text = match format {
-            EntryTimeFormat::DateAndTime => {
-                let entry_time = entry.updated_at();
-                let now = Utc::now();
-                let duration = now.signed_duration_since(entry_time);
-                let days = duration.num_days();
-
-                format!("{}d", days)
-            }
-            EntryTimeFormat::TimeOnly => format.format_timestamp(timestamp, self.local_timezone),
-        };
-
-        let title = entry.title().clone();
-        let full_date =
-            EntryTimeFormat::DateAndTime.format_timestamp(timestamp, self.local_timezone);
+        let thread_timestamp = format.format_timestamp(timestamp, self.local_timezone);
 
         h_flex()
             .w_full()
@@ -447,14 +432,11 @@ impl AcpThreadHistory {
                                     .truncate(),
                             )
                             .child(
-                                Label::new(display_text)
+                                Label::new(thread_timestamp)
                                     .color(Color::Muted)
                                     .size(LabelSize::XSmall),
                             ),
                     )
-                    .tooltip(move |_, cx| {
-                        Tooltip::with_meta(title.clone(), None, full_date.clone(), cx)
-                    })
                     .on_hover(cx.listener(move |this, is_hovered, _window, cx| {
                         if *is_hovered {
                             this.hovered_index = Some(ix);

crates/ai_onboarding/src/agent_api_keys_onboarding.rs

@@ -1,9 +1,9 @@
 use gpui::{Action, IntoElement, ParentElement, RenderOnce, point};
-use language_model::{IconOrSvg, LanguageModelRegistry, ZED_CLOUD_PROVIDER_ID};
+use language_model::{LanguageModelRegistry, ZED_CLOUD_PROVIDER_ID};
 use ui::{Divider, List, ListBulletItem, prelude::*};
 
 pub struct ApiKeysWithProviders {
-    configured_providers: Vec<(IconOrSvg, SharedString)>,
+    configured_providers: Vec<(IconName, SharedString)>,
 }
 
 impl ApiKeysWithProviders {
@@ -13,8 +13,7 @@ impl ApiKeysWithProviders {
             |this: &mut Self, _registry, event: &language_model::Event, cx| match event {
                 language_model::Event::ProviderStateChanged(_)
                 | language_model::Event::AddedProvider(_)
-                | language_model::Event::RemovedProvider(_)
-                | language_model::Event::ProvidersChanged => {
+                | language_model::Event::RemovedProvider(_) => {
                     this.configured_providers = Self::compute_configured_providers(cx)
                 }
                 _ => {}
@@ -27,9 +26,9 @@ impl ApiKeysWithProviders {
         }
     }
 
-    fn compute_configured_providers(cx: &App) -> Vec<(IconOrSvg, SharedString)> {
+    fn compute_configured_providers(cx: &App) -> Vec<(IconName, SharedString)> {
         LanguageModelRegistry::read_global(cx)
-            .visible_providers()
+            .providers()
             .iter()
             .filter(|provider| {
                 provider.is_authenticated(cx) && provider.id() != ZED_CLOUD_PROVIDER_ID
@@ -48,14 +47,7 @@ impl Render for ApiKeysWithProviders {
                 .map(|(icon, name)| {
                     h_flex()
                         .gap_1p5()
-                        .child(
-                            match icon {
-                                IconOrSvg::Icon(icon_name) => Icon::new(icon_name),
-                                IconOrSvg::Svg(icon_path) => Icon::from_external_svg(icon_path),
-                            }
-                            .size(IconSize::XSmall)
-                            .color(Color::Muted),
-                        )
+                        .child(Icon::new(icon).size(IconSize::XSmall).color(Color::Muted))
                         .child(Label::new(name))
                 });
         div()

crates/ai_onboarding/src/agent_panel_onboarding_content.rs

@@ -11,7 +11,7 @@ use crate::{AgentPanelOnboardingCard, ApiKeysWithoutProviders, ZedAiOnboarding};
 pub struct AgentPanelOnboarding {
     user_store: Entity<UserStore>,
     client: Arc<Client>,
-    has_configured_providers: bool,
+    configured_providers: Vec<(IconName, SharedString)>,
     continue_with_zed_ai: Arc<dyn Fn(&mut Window, &mut App)>,
 }
 
@@ -27,9 +27,8 @@ impl AgentPanelOnboarding {
             |this: &mut Self, _registry, event: &language_model::Event, cx| match event {
                 language_model::Event::ProviderStateChanged(_)
                 | language_model::Event::AddedProvider(_)
-                | language_model::Event::RemovedProvider(_)
-                | language_model::Event::ProvidersChanged => {
-                    this.has_configured_providers = Self::has_configured_providers(cx)
+                | language_model::Event::RemovedProvider(_) => {
+                    this.configured_providers = Self::compute_available_providers(cx)
                 }
                 _ => {}
             },
@@ -39,16 +38,20 @@ impl AgentPanelOnboarding {
         Self {
             user_store,
             client,
-            has_configured_providers: Self::has_configured_providers(cx),
+            configured_providers: Self::compute_available_providers(cx),
             continue_with_zed_ai: Arc::new(continue_with_zed_ai),
         }
     }
 
-    fn has_configured_providers(cx: &App) -> bool {
+    fn compute_available_providers(cx: &App) -> Vec<(IconName, SharedString)> {
         LanguageModelRegistry::read_global(cx)
-            .visible_providers()
+            .providers()
             .iter()
-            .any(|provider| provider.is_authenticated(cx) && provider.id() != ZED_CLOUD_PROVIDER_ID)
+            .filter(|provider| {
+                provider.is_authenticated(cx) && provider.id() != ZED_CLOUD_PROVIDER_ID
+            })
+            .map(|provider| (provider.icon(), provider.name().0))
+            .collect()
     }
 }
 
@@ -78,7 +81,7 @@ impl Render for AgentPanelOnboarding {
                 }),
             )
             .map(|this| {
-                if enrolled_in_trial || is_pro_user || self.has_configured_providers {
+                if enrolled_in_trial || is_pro_user || !self.configured_providers.is_empty() {
                     this
                 } else {
                     this.child(ApiKeysWithoutProviders::new())

crates/buffer_diff/src/buffer_diff.rs

@@ -314,12 +314,6 @@ impl BufferDiffSnapshot {
         self.inner.hunks.is_empty()
     }
 
-    pub fn base_text_string(&self) -> Option<String> {
-        self.inner
-            .base_text_exists
-            .then(|| self.inner.base_text.text())
-    }
-
     pub fn secondary_diff(&self) -> Option<&BufferDiffSnapshot> {
         self.secondary_diff.as_deref()
     }
@@ -1165,34 +1159,6 @@ impl BufferDiff {
         new_index_text
     }
 
-    pub fn stage_or_unstage_all_hunks(
-        &mut self,
-        stage: bool,
-        buffer: &text::BufferSnapshot,
-        file_exists: bool,
-        cx: &mut Context<Self>,
-    ) {
-        let hunks = self
-            .hunks_intersecting_range(Anchor::MIN..Anchor::MAX, buffer, cx)
-            .collect::<Vec<_>>();
-        let Some(secondary) = self.secondary_diff.as_ref() else {
-            return;
-        };
-        self.inner.stage_or_unstage_hunks_impl(
-            &secondary.read(cx).inner,
-            stage,
-            &hunks,
-            buffer,
-            file_exists,
-        );
-        if let Some((first, last)) = hunks.first().zip(hunks.last()) {
-            let changed_range = first.buffer_range.start..last.buffer_range.end;
-            cx.emit(BufferDiffEvent::DiffChanged {
-                changed_range: Some(changed_range),
-            });
-        }
-    }
-
     pub fn range_to_hunk_range(
         &self,
         range: Range<Anchor>,

crates/collab/src/api/contributors.rs

@@ -113,7 +113,7 @@ impl CopilotSweAgentBot {
     const USER_ID: i32 = 198982749;
     /// The alias of the GitHub copilot user. Although https://api.github.com/users/copilot
     /// yields a 404, GitHub still refers to the copilot bot user as @Copilot in some cases.
-    const NAME_ALIAS: &'static str = "Copilot";
+    const NAME_ALIAS: &'static str = "copilot";
 
     /// Returns the `created_at` timestamp for the Dependabot bot user.
     fn created_at() -> &'static NaiveDateTime {

crates/collab/src/tests/integration_tests.rs

@@ -6745,13 +6745,8 @@ async fn test_preview_tabs(cx: &mut TestAppContext) {
     });
 
     // Split pane to the right
-    pane.update_in(cx, |pane, window, cx| {
-        pane.split(
-            workspace::SplitDirection::Right,
-            workspace::SplitMode::default(),
-            window,
-            cx,
-        );
+    pane.update(cx, |pane, cx| {
+        pane.split(workspace::SplitDirection::Right, cx);
     });
     cx.run_until_parked();
     let right_pane = workspace.read_with(cx, |workspace, _| workspace.active_pane().clone());

crates/collab_ui/src/collab_panel.rs

@@ -31,9 +31,9 @@ use smallvec::SmallVec;
 use std::{mem, sync::Arc};
 use theme::{ActiveTheme, ThemeSettings};
 use ui::{
-    Avatar, AvatarAvailabilityIndicator, Button, Color, ContextMenu, CopyButton, Facepile,
-    HighlightedLabel, Icon, IconButton, IconName, IconSize, Indicator, Label, ListHeader, ListItem,
-    Tab, Tooltip, prelude::*, tooltip_container,
+    Avatar, AvatarAvailabilityIndicator, Button, Color, ContextMenu, Facepile, HighlightedLabel,
+    Icon, IconButton, IconName, IconSize, Indicator, Label, ListHeader, ListItem, Tab, Tooltip,
+    prelude::*, tooltip_container,
 };
 use util::{ResultExt, TryFutureExt, maybe};
 use workspace::{
@@ -2527,9 +2527,16 @@ impl CollabPanel {
 
         let button = match section {
             Section::ActiveCall => channel_link.map(|channel_link| {
-                CopyButton::new(channel_link)
+                let channel_link_copy = channel_link;
+                IconButton::new("channel-link", IconName::Copy)
+                    .icon_size(IconSize::Small)
+                    .size(ButtonSize::None)
                     .visible_on_hover("section-header")
-                    .tooltip_label("Copy Channel Link")
+                    .on_click(move |_, _, cx| {
+                        let item = ClipboardItem::new_string(channel_link_copy.clone());
+                        cx.write_to_clipboard(item)
+                    })
+                    .tooltip(Tooltip::text("Copy channel link"))
                     .into_any_element()
             }),
             Section::Contacts => Some(

crates/component_preview/Cargo.toml

@@ -1,45 +0,0 @@
-[package]
-name = "component_preview"
-version = "0.1.0"
-edition.workspace = true
-publish.workspace = true
-license = "GPL-3.0-or-later"
-
-[lints]
-workspace = true
-
-[lib]
-path = "src/component_preview.rs"
-
-[features]
-default = []
-preview = []
-test-support = ["db/test-support"]
-
-[dependencies]
-anyhow.workspace = true
-client.workspace = true
-collections.workspace = true
-component.workspace = true
-db.workspace = true
-fs.workspace = true
-gpui.workspace = true
-language.workspace = true
-log.workspace = true
-node_runtime.workspace = true
-notifications.workspace = true
-project.workspace = true
-release_channel.workspace = true
-reqwest_client.workspace = true
-session.workspace = true
-settings.workspace = true
-theme.workspace = true
-ui.workspace = true
-ui_input.workspace = true
-uuid.workspace = true
-workspace.workspace = true
-
-[[example]]
-name = "component_preview"
-path = "examples/component_preview.rs"
-required-features = ["preview"]

crates/component_preview/LICENSE-GPL

@@ -1 +0,0 @@
-LICENSE-GPL

crates/component_preview/examples/component_preview.rs

@@ -1,18 +0,0 @@
-//! Component Preview Example
-//!
-//! Run with: `cargo run -p component_preview --example component_preview --features="preview"`
-//!
-//! To use this in other projects, add the following to your `Cargo.toml`:
-//!
-//! ```toml
-//! [dependencies]
-//! component_preview = { path = "../component_preview", features = ["preview"] }
-//!
-//! [[example]]
-//! name = "component_preview"
-//! path = "examples/component_preview.rs"
-//! ```
-
-fn main() {
-    component_preview::run_component_preview();
-}

crates/component_preview/src/component_preview_example.rs

@@ -1,145 +0,0 @@
-/// Run the component preview application.
-///
-/// This initializes the application with minimal required infrastructure
-/// and opens a workspace with the ComponentPreview item.
-#[cfg(feature = "preview")]
-pub fn run_component_preview() {
-    use fs::RealFs;
-    use gpui::{
-        AppContext as _, Application, Bounds, KeyBinding, WindowBounds, WindowOptions, actions,
-        size,
-    };
-
-    use client::{Client, UserStore};
-    use language::LanguageRegistry;
-    use node_runtime::NodeRuntime;
-    use project::Project;
-    use reqwest_client::ReqwestClient;
-    use session::{AppSession, Session};
-    use std::sync::Arc;
-    use ui::{App, px};
-    use workspace::{AppState, Workspace, WorkspaceStore};
-
-    use crate::{ComponentPreview, init};
-
-    actions!(zed, [Quit]);
-
-    fn quit(_: &Quit, cx: &mut App) {
-        cx.quit();
-    }
-
-    Application::new().run(|cx| {
-        component::init();
-
-        cx.on_action(quit);
-        cx.bind_keys([KeyBinding::new("cmd-q", Quit, None)]);
-        let version = release_channel::AppVersion::load(env!("CARGO_PKG_VERSION"), None, None);
-        release_channel::init(version, cx);
-
-        let http_client =
-            ReqwestClient::user_agent("component_preview").expect("Failed to create HTTP client");
-        cx.set_http_client(Arc::new(http_client));
-
-        let fs = Arc::new(RealFs::new(None, cx.background_executor().clone()));
-        <dyn fs::Fs>::set_global(fs.clone(), cx);
-
-        settings::init(cx);
-        theme::init(theme::LoadThemes::JustBase, cx);
-
-        let languages = Arc::new(LanguageRegistry::new(cx.background_executor().clone()));
-        let client = Client::production(cx);
-        client::init(&client, cx);
-
-        let user_store = cx.new(|cx| UserStore::new(client.clone(), cx));
-        let workspace_store = cx.new(|cx| WorkspaceStore::new(client.clone(), cx));
-        let session_id = uuid::Uuid::new_v4().to_string();
-        let session = cx.background_executor().block(Session::new(session_id));
-        let session = cx.new(|cx| AppSession::new(session, cx));
-        let node_runtime = NodeRuntime::unavailable();
-
-        let app_state = Arc::new(AppState {
-            languages,
-            client,
-            user_store,
-            workspace_store,
-            fs,
-            build_window_options: |_, _| Default::default(),
-            node_runtime,
-            session,
-        });
-        AppState::set_global(Arc::downgrade(&app_state), cx);
-
-        workspace::init(app_state.clone(), cx);
-        init(app_state.clone(), cx);
-
-        let size = size(px(1200.), px(800.));
-        let bounds = Bounds::centered(None, size, cx);
-
-        cx.open_window(
-            WindowOptions {
-                window_bounds: Some(WindowBounds::Windowed(bounds)),
-                ..Default::default()
-            },
-            {
-                move |window, cx| {
-                    let app_state = app_state;
-                    theme::setup_ui_font(window, cx);
-
-                    let project = Project::local(
-                        app_state.client.clone(),
-                        app_state.node_runtime.clone(),
-                        app_state.user_store.clone(),
-                        app_state.languages.clone(),
-                        app_state.fs.clone(),
-                        None,
-                        false,
-                        cx,
-                    );
-
-                    let workspace = cx.new(|cx| {
-                        Workspace::new(
-                            Default::default(),
-                            project.clone(),
-                            app_state.clone(),
-                            window,
-                            cx,
-                        )
-                    });
-
-                    workspace.update(cx, |workspace, cx| {
-                        let weak_workspace = cx.entity().downgrade();
-                        let language_registry = app_state.languages.clone();
-                        let user_store = app_state.user_store.clone();
-
-                        let component_preview = cx.new(|cx| {
-                            ComponentPreview::new(
-                                weak_workspace,
-                                project,
-                                language_registry,
-                                user_store,
-                                None,
-                                None,
-                                window,
-                                cx,
-                            )
-                            .expect("Failed to create component preview")
-                        });
-
-                        workspace.add_item_to_active_pane(
-                            Box::new(component_preview),
-                            None,
-                            true,
-                            window,
-                            cx,
-                        );
-                    });
-
-                    workspace
-                }
-            },
-        )
-        .expect("Failed to open component preview window");
-
-        cx.activate(true);
-    });
-}

crates/debugger_ui/src/debugger_panel.rs

@@ -1579,10 +1579,8 @@ impl Panel for DebugPanel {
         Some(proto::PanelId::DebugPanel)
     }
 
-    fn icon(&self, _window: &Window, cx: &App) -> Option<IconName> {
-        DebuggerSettings::get_global(cx)
-            .button
-            .then_some(IconName::Debug)
+    fn icon(&self, _window: &Window, _cx: &App) -> Option<IconName> {
+        Some(IconName::Debug)
     }
 
     fn icon_tooltip(&self, _window: &Window, cx: &App) -> Option<&'static str> {

crates/deepseek/src/deepseek.rs

@@ -103,9 +103,8 @@ impl Model {
 
     pub fn max_output_tokens(&self) -> Option<u64> {
         match self {
-            // Their API treats this max against the context window, which means we hit the limit a lot
-            // Using the default value of None in the API instead
-            Self::Chat | Self::Reasoner => None,
+            Self::Chat => Some(8_192),
+            Self::Reasoner => Some(64_000),
             Self::Custom {
                 max_output_tokens, ..
             } => *max_output_tokens,

crates/docs_preprocessor/Cargo.toml

@@ -7,6 +7,8 @@ license = "GPL-3.0-or-later"
 
 [dependencies]
 anyhow.workspace = true
+command_palette.workspace = true
+gpui.workspace = true
 # We are specifically pinning this version of mdbook, as later versions introduce issues with double-nested subdirectories.
 # Ask @maxdeviant about this before bumping.
 mdbook = "= 0.4.40"
@@ -15,6 +17,7 @@ serde.workspace = true
 serde_json.workspace = true
 settings.workspace = true
 util.workspace = true
+zed.workspace = true
 zlog.workspace = true
 task.workspace = true
 theme.workspace = true
@@ -24,4 +27,4 @@ workspace = true
 
 [[bin]]
 name = "docs_preprocessor"
-path = "src/main.rs"
+path = "src/main.rs"

crates/docs_preprocessor/src/main.rs

@@ -22,13 +22,16 @@ static KEYMAP_WINDOWS: LazyLock<KeymapFile> = LazyLock::new(|| {
     load_keymap("keymaps/default-windows.json").expect("Failed to load Windows keymap")
 });
 
-static ALL_ACTIONS: LazyLock<Vec<ActionDef>> = LazyLock::new(load_all_actions);
+static ALL_ACTIONS: LazyLock<Vec<ActionDef>> = LazyLock::new(dump_all_gpui_actions);
 
 const FRONT_MATTER_COMMENT: &str = "<!-- ZED_META {} -->";
 
 fn main() -> Result<()> {
     zlog::init();
     zlog::init_output_stderr();
+    // call a zed:: function so everything in `zed` crate is linked and
+    // all actions in the actual app are registered
+    zed::stdout_is_a_pty();
     let args = std::env::args().skip(1).collect::<Vec<_>>();
 
     match args.get(0).map(String::as_str) {
@@ -69,8 +72,8 @@ enum PreprocessorError {
 impl PreprocessorError {
     fn new_for_not_found_action(action_name: String) -> Self {
         for action in &*ALL_ACTIONS {
-            for alias in &action.deprecated_aliases {
-                if alias == action_name.as_str() {
+            for alias in action.deprecated_aliases {
+                if alias == &action_name {
                     return PreprocessorError::DeprecatedActionUsed {
                         used: action_name,
                         should_be: action.name.to_string(),
@@ -211,7 +214,7 @@ fn template_and_validate_keybindings(book: &mut Book, errors: &mut HashSet<Prepr
         chapter.content = regex
             .replace_all(&chapter.content, |caps: &regex::Captures| {
                 let action = caps[1].trim();
-                if is_missing_action(action) {
+                if find_action_by_name(action).is_none() {
                     errors.insert(PreprocessorError::new_for_not_found_action(
                         action.to_string(),
                     ));
@@ -241,12 +244,10 @@ fn template_and_validate_actions(book: &mut Book, errors: &mut HashSet<Preproces
             .replace_all(&chapter.content, |caps: &regex::Captures| {
                 let name = caps[1].trim();
                 let Some(action) = find_action_by_name(name) else {
-                    if actions_available() {
-                        errors.insert(PreprocessorError::new_for_not_found_action(
-                            name.to_string(),
-                        ));
-                    }
-                    return format!("<code class=\"hljs\">{}</code>", name);
+                    errors.insert(PreprocessorError::new_for_not_found_action(
+                        name.to_string(),
+                    ));
+                    return String::new();
                 };
                 format!("<code class=\"hljs\">{}</code>", &action.human_name)
             })
@@ -256,19 +257,11 @@ fn template_and_validate_actions(book: &mut Book, errors: &mut HashSet<Preproces
 
 fn find_action_by_name(name: &str) -> Option<&ActionDef> {
     ALL_ACTIONS
-        .binary_search_by(|action| action.name.as_str().cmp(name))
+        .binary_search_by(|action| action.name.cmp(name))
         .ok()
         .map(|index| &ALL_ACTIONS[index])
 }
 
-fn actions_available() -> bool {
-    !ALL_ACTIONS.is_empty()
-}
-
-fn is_missing_action(name: &str) -> bool {
-    actions_available() && find_action_by_name(name).is_none()
-}
-
 fn find_binding(os: &str, action: &str) -> Option<String> {
     let keymap = match os {
         "macos" => &KEYMAP_MACOS,
@@ -391,13 +384,18 @@ fn template_and_validate_json_snippets(book: &mut Book, errors: &mut HashSet<Pre
                 let keymap = settings::KeymapFile::parse(&snippet_json_fixed)
                     .context("Failed to parse keymap JSON")?;
                 for section in keymap.sections() {
-                    for (_keystrokes, action) in section.bindings() {
+                    for (keystrokes, action) in section.bindings() {
+                        keystrokes
+                            .split_whitespace()
+                            .map(|source| gpui::Keystroke::parse(source))
+                            .collect::<std::result::Result<Vec<_>, _>>()
+                            .context("Failed to parse keystroke")?;
                         if let Some((action_name, _)) = settings::KeymapFile::parse_action(action)
                             .map_err(|err| anyhow::format_err!(err))
                             .context("Failed to parse action")?
                         {
                             anyhow::ensure!(
-                                !is_missing_action(action_name),
+                                find_action_by_name(action_name).is_some(),
                                 "Action not found: {}",
                                 action_name
                             );
@@ -493,35 +491,27 @@ where
     });
 }
 
-#[derive(Debug, serde::Serialize, serde::Deserialize)]
+#[derive(Debug, serde::Serialize)]
 struct ActionDef {
-    name: String,
+    name: &'static str,
     human_name: String,
-    deprecated_aliases: Vec<String>,
-    #[serde(rename = "documentation")]
-    docs: Option<String>,
+    deprecated_aliases: &'static [&'static str],
+    docs: Option<&'static str>,
 }
 
-fn load_all_actions() -> Vec<ActionDef> {
-    let asset_path = concat!(env!("CARGO_MANIFEST_DIR"), "/actions.json");
-    match std::fs::read_to_string(asset_path) {
-        Ok(content) => {
-            let mut actions: Vec<ActionDef> =
-                serde_json::from_str(&content).expect("Failed to parse actions.json");
-            actions.sort_by(|a, b| a.name.cmp(&b.name));
-            actions
-        }
-        Err(err) => {
-            if std::env::var("CI").is_ok() {
-                panic!("actions.json not found at {}: {}", asset_path, err);
-            }
-            eprintln!(
-                "Warning: actions.json not found, action validation will be skipped: {}",
-                err
-            );
-            Vec::new()
-        }
-    }
+fn dump_all_gpui_actions() -> Vec<ActionDef> {
+    let mut actions = gpui::generate_list_of_all_registered_actions()
+        .map(|action| ActionDef {
+            name: action.name,
+            human_name: command_palette::humanize_action_name(action.name),
+            deprecated_aliases: action.deprecated_aliases,
+            docs: action.documentation,
+        })
+        .collect::<Vec<ActionDef>>();
+
+    actions.sort_by_key(|a| a.name);
+
+    actions
 }
 
 fn handle_postprocessing() -> Result<()> {
@@ -657,7 +647,7 @@ fn generate_big_table_of_actions() -> String {
     let mut output = String::new();
 
     let mut actions_sorted = actions.iter().collect::<Vec<_>>();
-    actions_sorted.sort_by_key(|a| a.name.as_str());
+    actions_sorted.sort_by_key(|a| a.name);
 
     // Start the definition list with custom styling for better spacing
     output.push_str("<dl style=\"line-height: 1.8;\">\n");
@@ -674,7 +664,7 @@ fn generate_big_table_of_actions() -> String {
         output.push_str("<dd style=\"margin-left: 2em; margin-bottom: 1em;\">\n");
 
         // Add the description, escaping HTML if needed
-        if let Some(description) = action.docs.as_ref() {
+        if let Some(description) = action.docs {
             output.push_str(
                 &description
                     .replace("&", "&amp;")
@@ -684,7 +674,7 @@ fn generate_big_table_of_actions() -> String {
             output.push_str("<br>\n");
         }
         output.push_str("Keymap Name: <code>");
-        output.push_str(&action.name);
+        output.push_str(action.name);
         output.push_str("</code><br>\n");
         if !action.deprecated_aliases.is_empty() {
             output.push_str("Deprecated Alias(es): ");

crates/edit_prediction/Cargo.toml

@@ -19,7 +19,6 @@ ai_onboarding.workspace = true
 anyhow.workspace = true
 arrayvec.workspace = true
 brotli.workspace = true
-buffer_diff.workspace = true
 client.workspace = true
 cloud_llm_client.workspace = true
 collections.workspace = true
@@ -53,10 +52,7 @@ settings.workspace = true
 strum.workspace = true
 telemetry.workspace = true
 telemetry_events.workspace = true
-text.workspace = true
 thiserror.workspace = true
-time.workspace = true
-toml.workspace = true
 ui.workspace = true
 util.workspace = true
 uuid.workspace = true

crates/edit_prediction/src/capture_example.rs

@@ -1,391 +0,0 @@
-use crate::{
-    EditPredictionStore, StoredEvent,
-    cursor_excerpt::editable_and_context_ranges_for_cursor_position, example_spec::ExampleSpec,
-};
-use anyhow::Result;
-use buffer_diff::BufferDiffSnapshot;
-use collections::HashMap;
-use gpui::{App, Entity, Task};
-use language::{Buffer, ToPoint as _};
-use project::{Project, WorktreeId};
-use std::{collections::hash_map, fmt::Write as _, path::Path, sync::Arc};
-use text::BufferSnapshot as TextBufferSnapshot;
-
-pub fn capture_example(
-    project: Entity<Project>,
-    buffer: Entity<Buffer>,
-    cursor_anchor: language::Anchor,
-    cx: &mut App,
-) -> Option<Task<Result<ExampleSpec>>> {
-    let ep_store = EditPredictionStore::try_global(cx)?;
-    let snapshot = buffer.read(cx).snapshot();
-    let file = snapshot.file()?;
-    let worktree_id = file.worktree_id(cx);
-    let repository = project.read(cx).active_repository(cx)?;
-    let repository_snapshot = repository.read(cx).snapshot();
-    let worktree = project.read(cx).worktree_for_id(worktree_id, cx)?;
-    let cursor_path = worktree.read(cx).root_name().join(file.path());
-    if worktree.read(cx).abs_path() != repository_snapshot.work_directory_abs_path {
-        return None;
-    }
-
-    let repository_url = repository_snapshot
-        .remote_origin_url
-        .clone()
-        .or_else(|| repository_snapshot.remote_upstream_url.clone())?;
-    let revision = repository_snapshot.head_commit.as_ref()?.sha.to_string();
-
-    let mut events = ep_store.update(cx, |store, cx| {
-        store.edit_history_for_project_with_pause_split_last_event(&project, cx)
-    });
-
-    let git_store = project.read(cx).git_store().clone();
-
-    Some(cx.spawn(async move |mut cx| {
-        let snapshots_by_path =
-            collect_snapshots(&project, &git_store, worktree_id, &events, &mut cx).await?;
-
-        events.retain(|stored_event| {
-            match stored_event.event.as_ref() {
-                zeta_prompt::Event::BufferChange { path, .. } => {
-                    if !snapshots_by_path.contains_key(path) {
-                        return false;
-                    }
-                }
-            }
-            true
-        });
-
-        let line_comment_prefix = snapshot
-            .language()
-            .and_then(|lang| lang.config().line_comments.first())
-            .map(|s| s.to_string())
-            .unwrap_or_default();
-        let (cursor_excerpt, cursor_offset) = cx
-            .background_executor()
-            .spawn(async move { compute_cursor_excerpt(&snapshot, cursor_anchor) })
-            .await;
-        let uncommitted_diff = cx
-            .background_executor()
-            .spawn(async move { compute_uncommitted_diff(snapshots_by_path) })
-            .await;
-
-        let mut edit_history = String::new();
-        for stored_event in &events {
-            zeta_prompt::write_event(&mut edit_history, &stored_event.event);
-            if !edit_history.ends_with('\n') {
-                edit_history.push('\n');
-            }
-        }
-
-        let mut spec = ExampleSpec {
-            name: generate_timestamp_name(),
-            repository_url,
-            revision,
-            tags: Vec::new(),
-            reasoning: None,
-            uncommitted_diff,
-            cursor_path: cursor_path.as_std_path().into(),
-            cursor_position: String::new(),
-            edit_history,
-            expected_patches: Vec::new(),
-        };
-        spec.set_cursor_excerpt(&cursor_excerpt, cursor_offset, &line_comment_prefix);
-        Ok(spec)
-    }))
-}
-
-fn compute_cursor_excerpt(
-    snapshot: &language::BufferSnapshot,
-    cursor_anchor: language::Anchor,
-) -> (String, usize) {
-    use text::ToOffset as _;
-
-    let cursor_point = cursor_anchor.to_point(snapshot);
-    let (_editable_range, context_range) =
-        editable_and_context_ranges_for_cursor_position(cursor_point, snapshot, 100, 50);
-    let context_start_offset = context_range.start.to_offset(snapshot);
-    let cursor_offset = cursor_anchor.to_offset(snapshot);
-    let cursor_offset_in_excerpt = cursor_offset.saturating_sub(context_start_offset);
-    let excerpt = snapshot.text_for_range(context_range).collect::<String>();
-    (excerpt, cursor_offset_in_excerpt)
-}
-
-async fn collect_snapshots(
-    project: &Entity<Project>,
-    git_store: &Entity<project::git_store::GitStore>,
-    worktree_id: WorktreeId,
-    events: &[StoredEvent],
-    cx: &mut gpui::AsyncApp,
-) -> Result<HashMap<Arc<Path>, (TextBufferSnapshot, BufferDiffSnapshot)>> {
-    let mut snapshots_by_path = HashMap::default();
-    let root_name = project.read_with(cx, |project, cx| {
-        project
-            .worktree_for_id(worktree_id, cx)
-            .unwrap()
-            .read(cx)
-            .root_name()
-            .to_owned()
-    })?;
-    for stored_event in events {
-        let zeta_prompt::Event::BufferChange { path, .. } = stored_event.event.as_ref();
-        if let Some((project_path, full_path)) = project.read_with(cx, |project, cx| {
-            let project_path = project
-                .find_project_path(path, cx)
-                .filter(|path| path.worktree_id == worktree_id)?;
-            let full_path = root_name.join(&project_path.path).as_std_path().into();
-            Some((project_path, full_path))
-        })? {
-            if let hash_map::Entry::Vacant(entry) = snapshots_by_path.entry(full_path) {
-                let buffer = project
-                    .update(cx, |project, cx| {
-                        project.open_buffer(project_path.clone(), cx)
-                    })?
-                    .await?;
-                let diff = git_store
-                    .update(cx, |git_store, cx| {
-                        git_store.open_uncommitted_diff(buffer.clone(), cx)
-                    })?
-                    .await?;
-                let diff_snapshot = diff.update(cx, |diff, cx| diff.snapshot(cx))?;
-                entry.insert((stored_event.old_snapshot.clone(), diff_snapshot));
-            }
-        }
-    }
-    Ok(snapshots_by_path)
-}
-
-fn compute_uncommitted_diff(
-    snapshots_by_path: HashMap<Arc<Path>, (TextBufferSnapshot, BufferDiffSnapshot)>,
-) -> String {
-    let mut uncommitted_diff = String::new();
-    for (full_path, (before_text, diff_snapshot)) in snapshots_by_path {
-        if let Some(head_text) = &diff_snapshot.base_text_string() {
-            let file_diff = language::unified_diff(head_text, &before_text.text());
-            if !file_diff.is_empty() {
-                let path_str = full_path.to_string_lossy();
-                writeln!(uncommitted_diff, "--- a/{path_str}").ok();
-                writeln!(uncommitted_diff, "+++ b/{path_str}").ok();
-                uncommitted_diff.push_str(&file_diff);
-                if !uncommitted_diff.ends_with('\n') {
-                    uncommitted_diff.push('\n');
-                }
-            }
-        }
-    }
-    uncommitted_diff
-}
-
-fn generate_timestamp_name() -> String {
-    let format = time::format_description::parse("[year]-[month]-[day] [hour]:[minute]:[second]");
-    match format {
-        Ok(format) => {
-            let now = time::OffsetDateTime::now_local()
-                .unwrap_or_else(|_| time::OffsetDateTime::now_utc());
-            now.format(&format)
-                .unwrap_or_else(|_| "unknown-time".to_string())
-        }
-        Err(_) => "unknown-time".to_string(),
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use client::{Client, UserStore};
-    use clock::FakeSystemClock;
-    use gpui::{AppContext as _, TestAppContext, http_client::FakeHttpClient};
-    use indoc::indoc;
-    use language::{Anchor, Point};
-    use project::{FakeFs, Project};
-    use serde_json::json;
-    use settings::SettingsStore;
-    use std::path::Path;
-
-    #[gpui::test]
-    async fn test_capture_example(cx: &mut TestAppContext) {
-        init_test(cx);
-        let fs = FakeFs::new(cx.executor());
-
-        let committed_contents = indoc! {"
-            fn main() {
-                one();
-                two();
-                three();
-                four();
-                five();
-                six();
-                seven();
-                eight();
-                nine();
-            }
-        "};
-
-        let disk_contents = indoc! {"
-            fn main() {
-                // comment 1
-                one();
-                two();
-                three();
-                four();
-                five();
-                six();
-                seven();
-                eight();
-                // comment 2
-                nine();
-            }
-        "};
-
-        fs.insert_tree(
-            "/project",
-            json!({
-                ".git": {},
-                "src": {
-                    "main.rs": disk_contents,
-                }
-            }),
-        )
-        .await;
-
-        fs.set_head_for_repo(
-            Path::new("/project/.git"),
-            &[("src/main.rs", committed_contents.to_string())],
-            "abc123def456",
-        );
-        fs.set_remote_for_repo(
-            Path::new("/project/.git"),
-            "origin",
-            "https://github.com/test/repo.git",
-        );
-
-        let project = Project::test(fs.clone(), ["/project".as_ref()], cx).await;
-
-        let buffer = project
-            .update(cx, |project, cx| {
-                project.open_local_buffer("/project/src/main.rs", cx)
-            })
-            .await
-            .unwrap();
-
-        let ep_store = cx.read(|cx| EditPredictionStore::try_global(cx).unwrap());
-        ep_store.update(cx, |ep_store, cx| {
-            ep_store.register_buffer(&buffer, &project, cx)
-        });
-        cx.run_until_parked();
-
-        buffer.update(cx, |buffer, cx| {
-            let point = Point::new(6, 0);
-            buffer.edit([(point..point, "    // comment 3\n")], None, cx);
-            let point = Point::new(4, 0);
-            buffer.edit([(point..point, "    // comment 4\n")], None, cx);
-
-            pretty_assertions::assert_eq!(
-                buffer.text(),
-                indoc! {"
-                    fn main() {
-                        // comment 1
-                        one();
-                        two();
-                        // comment 4
-                        three();
-                        four();
-                        // comment 3
-                        five();
-                        six();
-                        seven();
-                        eight();
-                        // comment 2
-                        nine();
-                    }
-                "}
-            );
-        });
-        cx.run_until_parked();
-
-        let mut example = cx
-            .update(|cx| capture_example(project.clone(), buffer.clone(), Anchor::MIN, cx).unwrap())
-            .await
-            .unwrap();
-        example.name = "test".to_string();
-
-        pretty_assertions::assert_eq!(
-            example,
-            ExampleSpec {
-                name: "test".to_string(),
-                repository_url: "https://github.com/test/repo.git".to_string(),
-                revision: "abc123def456".to_string(),
-                tags: Vec::new(),
-                reasoning: None,
-                uncommitted_diff: indoc! {"
-                    --- a/project/src/main.rs
-                    +++ b/project/src/main.rs
-                    @@ -1,4 +1,5 @@
-                     fn main() {
-                    +    // comment 1
-                         one();
-                         two();
-                         three();
-                    @@ -7,5 +8,6 @@
-                         six();
-                         seven();
-                         eight();
-                    +    // comment 2
-                         nine();
-                     }
-                "}
-                .to_string(),
-                cursor_path: Path::new("project/src/main.rs").into(),
-                cursor_position: indoc! {"
-                    fn main() {
-                    ^[CURSOR_POSITION]
-                        // comment 1
-                        one();
-                        two();
-                        // comment 4
-                        three();
-                        four();
-                        // comment 3
-                        five();
-                        six();
-                        seven();
-                        eight();
-                        // comment 2
-                        nine();
-                    }
-                "}
-                .to_string(),
-                edit_history: indoc! {"
-                    --- a/project/src/main.rs
-                    +++ b/project/src/main.rs
-                    @@ -2,8 +2,10 @@
-                         // comment 1
-                         one();
-                         two();
-                    +    // comment 4
-                         three();
-                         four();
-                    +    // comment 3
-                         five();
-                         six();
-                         seven();
-                "}
-                .to_string(),
-                expected_patches: Vec::new()
-            }
-        );
-    }
-
-    fn init_test(cx: &mut TestAppContext) {
-        cx.update(|cx| {
-            let settings_store = SettingsStore::test(cx);
-            cx.set_global(settings_store);
-            zlog::init_test();
-            let http_client = FakeHttpClient::with_404_response();
-            let client = Client::new(Arc::new(FakeSystemClock::new()), http_client, cx);
-            language_model::init(client.clone(), cx);
-            let user_store = cx.new(|cx| UserStore::new(client.clone(), cx));
-            EditPredictionStore::global(&client, &user_store, cx);
-        })
-    }
-}

crates/edit_prediction/src/edit_prediction.rs

@@ -35,7 +35,6 @@ use semver::Version;
 use serde::de::DeserializeOwned;
 use settings::{EditPredictionProvider, SettingsStore, update_settings_file};
 use std::collections::{VecDeque, hash_map};
-use text::Edit;
 use workspace::Workspace;
 
 use std::ops::Range;
@@ -58,9 +57,9 @@ pub mod open_ai_response;
 mod prediction;
 pub mod sweep_ai;
 
+#[cfg(any(test, feature = "test-support", feature = "cli-support"))]
 pub mod udiff;
 
-mod capture_example;
 mod zed_edit_prediction_delegate;
 pub mod zeta1;
 pub mod zeta2;
@@ -75,7 +74,6 @@ pub use crate::prediction::EditPrediction;
 pub use crate::prediction::EditPredictionId;
 use crate::prediction::EditPredictionResult;
 pub use crate::sweep_ai::SweepAi;
-pub use capture_example::capture_example;
 pub use language_model::ApiKeyState;
 pub use telemetry_events::EditPredictionRating;
 pub use zed_edit_prediction_delegate::ZedEditPredictionDelegate;
@@ -233,15 +231,8 @@ pub struct EditPredictionFinishedDebugEvent {
 
 pub type RequestDebugInfo = predict_edits_v3::DebugInfo;
 
-/// An event with associated metadata for reconstructing buffer state.
-#[derive(Clone)]
-pub struct StoredEvent {
-    pub event: Arc<zeta_prompt::Event>,
-    pub old_snapshot: TextBufferSnapshot,
-}
-
 struct ProjectState {
-    events: VecDeque<StoredEvent>,
+    events: VecDeque<Arc<zeta_prompt::Event>>,
     last_event: Option<LastEvent>,
     recent_paths: VecDeque<ProjectPath>,
     registered_buffers: HashMap<gpui::EntityId, RegisteredBuffer>,
@@ -257,7 +248,7 @@ struct ProjectState {
 }
 
 impl ProjectState {
-    pub fn events(&self, cx: &App) -> Vec<StoredEvent> {
+    pub fn events(&self, cx: &App) -> Vec<Arc<zeta_prompt::Event>> {
         self.events
             .iter()
             .cloned()
@@ -269,7 +260,7 @@ impl ProjectState {
             .collect()
     }
 
-    pub fn events_split_by_pause(&self, cx: &App) -> Vec<StoredEvent> {
+    pub fn events_split_by_pause(&self, cx: &App) -> Vec<Arc<zeta_prompt::Event>> {
         self.events
             .iter()
             .cloned()
@@ -424,7 +415,7 @@ impl LastEvent {
         &self,
         license_detection_watchers: &HashMap<WorktreeId, Rc<LicenseDetectionWatcher>>,
         cx: &App,
-    ) -> Option<StoredEvent> {
+    ) -> Option<Arc<zeta_prompt::Event>> {
         let path = buffer_path_with_id_fallback(self.new_file.as_ref(), &self.new_snapshot, cx);
         let old_path = buffer_path_with_id_fallback(self.old_file.as_ref(), &self.old_snapshot, cx);
 
@@ -439,22 +430,19 @@ impl LastEvent {
                     })
                 });
 
-        let diff = compute_diff_between_snapshots(&self.old_snapshot, &self.new_snapshot)?;
+        let diff = language::unified_diff(&self.old_snapshot.text(), &self.new_snapshot.text());
 
         if path == old_path && diff.is_empty() {
             None
         } else {
-            Some(StoredEvent {
-                event: Arc::new(zeta_prompt::Event::BufferChange {
-                    old_path,
-                    path,
-                    diff,
-                    in_open_source_repo,
-                    // TODO: Actually detect if this edit was predicted or not
-                    predicted: false,
-                }),
-                old_snapshot: self.old_snapshot.clone(),
-            })
+            Some(Arc::new(zeta_prompt::Event::BufferChange {
+                old_path,
+                path,
+                diff,
+                in_open_source_repo,
+                // TODO: Actually detect if this edit was predicted or not
+                predicted: false,
+            }))
         }
     }
 
@@ -487,52 +475,6 @@ impl LastEvent {
     }
 }
 
-pub(crate) fn compute_diff_between_snapshots(
-    old_snapshot: &TextBufferSnapshot,
-    new_snapshot: &TextBufferSnapshot,
-) -> Option<String> {
-    let edits: Vec<Edit<usize>> = new_snapshot
-        .edits_since::<usize>(&old_snapshot.version)
-        .collect();
-
-    let (first_edit, last_edit) = edits.first().zip(edits.last())?;
-
-    let old_start_point = old_snapshot.offset_to_point(first_edit.old.start);
-    let old_end_point = old_snapshot.offset_to_point(last_edit.old.end);
-    let new_start_point = new_snapshot.offset_to_point(first_edit.new.start);
-    let new_end_point = new_snapshot.offset_to_point(last_edit.new.end);
-
-    const CONTEXT_LINES: u32 = 3;
-
-    let old_context_start_row = old_start_point.row.saturating_sub(CONTEXT_LINES);
-    let new_context_start_row = new_start_point.row.saturating_sub(CONTEXT_LINES);
-    let old_context_end_row =
-        (old_end_point.row + 1 + CONTEXT_LINES).min(old_snapshot.max_point().row);
-    let new_context_end_row =
-        (new_end_point.row + 1 + CONTEXT_LINES).min(new_snapshot.max_point().row);
-
-    let old_start_line_offset = old_snapshot.point_to_offset(Point::new(old_context_start_row, 0));
-    let new_start_line_offset = new_snapshot.point_to_offset(Point::new(new_context_start_row, 0));
-    let old_end_line_offset = old_snapshot
-        .point_to_offset(Point::new(old_context_end_row + 1, 0).min(old_snapshot.max_point()));
-    let new_end_line_offset = new_snapshot
-        .point_to_offset(Point::new(new_context_end_row + 1, 0).min(new_snapshot.max_point()));
-    let old_edit_range = old_start_line_offset..old_end_line_offset;
-    let new_edit_range = new_start_line_offset..new_end_line_offset;
-
-    let old_region_text: String = old_snapshot.text_for_range(old_edit_range).collect();
-    let new_region_text: String = new_snapshot.text_for_range(new_edit_range).collect();
-
-    let diff = language::unified_diff_with_offsets(
-        &old_region_text,
-        &new_region_text,
-        old_context_start_row,
-        new_context_start_row,
-    );
-
-    Some(diff)
-}
-
 fn buffer_path_with_id_fallback(
     file: Option<&Arc<dyn File>>,
     snapshot: &TextBufferSnapshot,
@@ -688,14 +630,12 @@ impl EditPredictionStore {
     pub fn clear_history(&mut self) {
         for project_state in self.projects.values_mut() {
             project_state.events.clear();
-            project_state.last_event.take();
         }
     }
 
     pub fn clear_history_for_project(&mut self, project: &Entity<Project>) {
         if let Some(project_state) = self.projects.get_mut(&project.entity_id()) {
             project_state.events.clear();
-            project_state.last_event.take();
         }
     }
 
@@ -703,7 +643,7 @@ impl EditPredictionStore {
         &self,
         project: &Entity<Project>,
         cx: &App,
-    ) -> Vec<StoredEvent> {
+    ) -> Vec<Arc<zeta_prompt::Event>> {
         self.projects
             .get(&project.entity_id())
             .map(|project_state| project_state.events(cx))
@@ -714,7 +654,7 @@ impl EditPredictionStore {
         &self,
         project: &Entity<Project>,
         cx: &App,
-    ) -> Vec<StoredEvent> {
+    ) -> Vec<Arc<zeta_prompt::Event>> {
         self.projects
             .get(&project.entity_id())
             .map(|project_state| project_state.events_split_by_pause(cx))
@@ -1596,10 +1536,8 @@ impl EditPredictionStore {
 
         self.get_or_init_project(&project, cx);
         let project_state = self.projects.get(&project.entity_id()).unwrap();
-        let stored_events = project_state.events(cx);
-        let has_events = !stored_events.is_empty();
-        let events: Vec<Arc<zeta_prompt::Event>> =
-            stored_events.into_iter().map(|e| e.event).collect();
+        let events = project_state.events(cx);
+        let has_events = !events.is_empty();
         let debug_tx = project_state.debug_tx.clone();
 
         let snapshot = active_buffer.read(cx).snapshot();
@@ -2046,9 +1984,7 @@ impl EditPredictionStore {
             "Edit Prediction Rated",
             rating,
             inputs = prediction.inputs,
-            output = prediction
-                .edit_preview
-                .as_unified_diff(prediction.snapshot.file(), &prediction.edits),
+            output = prediction.edit_preview.as_unified_diff(&prediction.edits),
             feedback
         );
         self.client.telemetry().flush_events().detach();

crates/edit_prediction/src/edit_prediction_tests.rs

@@ -1,5 +1,5 @@
 use super::*;
-use crate::{compute_diff_between_snapshots, udiff::apply_diff_to_string, zeta1::MAX_EVENT_TOKENS};
+use crate::{udiff::apply_diff_to_string, zeta1::MAX_EVENT_TOKENS};
 use client::{UserStore, test::FakeServer};
 use clock::{FakeSystemClock, ReplicaId};
 use cloud_api_types::{CreateLlmTokenResponse, LlmToken};
@@ -360,7 +360,7 @@ async fn test_edit_history_getter_pause_splits_last_event(cx: &mut TestAppContex
         ep_store.edit_history_for_project(&project, cx)
     });
     assert_eq!(events.len(), 1);
-    let zeta_prompt::Event::BufferChange { diff, .. } = events[0].event.as_ref();
+    let zeta_prompt::Event::BufferChange { diff, .. } = events[0].as_ref();
     assert_eq!(
         diff.as_str(),
         indoc! {"
@@ -377,7 +377,7 @@ async fn test_edit_history_getter_pause_splits_last_event(cx: &mut TestAppContex
         ep_store.edit_history_for_project_with_pause_split_last_event(&project, cx)
     });
     assert_eq!(events.len(), 2);
-    let zeta_prompt::Event::BufferChange { diff, .. } = events[0].event.as_ref();
+    let zeta_prompt::Event::BufferChange { diff, .. } = events[0].as_ref();
     assert_eq!(
         diff.as_str(),
         indoc! {"
@@ -389,7 +389,7 @@ async fn test_edit_history_getter_pause_splits_last_event(cx: &mut TestAppContex
         "}
     );
 
-    let zeta_prompt::Event::BufferChange { diff, .. } = events[1].event.as_ref();
+    let zeta_prompt::Event::BufferChange { diff, .. } = events[1].as_ref();
     assert_eq!(
         diff.as_str(),
         indoc! {"
@@ -2082,74 +2082,6 @@ async fn test_unauthenticated_with_custom_url_allows_prediction_impl(cx: &mut Te
     );
 }
 
-#[gpui::test]
-fn test_compute_diff_between_snapshots(cx: &mut TestAppContext) {
-    let buffer = cx.new(|cx| {
-        Buffer::local(
-            indoc! {"
-                zero
-                one
-                two
-                three
-                four
-                five
-                six
-                seven
-                eight
-                nine
-                ten
-                eleven
-                twelve
-                thirteen
-                fourteen
-                fifteen
-                sixteen
-                seventeen
-                eighteen
-                nineteen
-                twenty
-                twenty-one
-                twenty-two
-                twenty-three
-                twenty-four
-            "},
-            cx,
-        )
-    });
-
-    let old_snapshot = buffer.read_with(cx, |buffer, _| buffer.text_snapshot());
-
-    buffer.update(cx, |buffer, cx| {
-        let point = Point::new(12, 0);
-        buffer.edit([(point..point, "SECOND INSERTION\n")], None, cx);
-        let point = Point::new(8, 0);
-        buffer.edit([(point..point, "FIRST INSERTION\n")], None, cx);
-    });
-
-    let new_snapshot = buffer.read_with(cx, |buffer, _| buffer.text_snapshot());
-
-    let diff = compute_diff_between_snapshots(&old_snapshot, &new_snapshot).unwrap();
-
-    assert_eq!(
-        diff,
-        indoc! {"
-            @@ -6,10 +6,12 @@
-             five
-             six
-             seven
-            +FIRST INSERTION
-             eight
-             nine
-             ten
-             eleven
-            +SECOND INSERTION
-             twelve
-             thirteen
-             fourteen
-            "}
-    );
-}
-
 #[ctor::ctor]
 fn init_logger() {
     zlog::init_test();

crates/edit_prediction/src/example_spec.rs

@@ -1,90 +1,39 @@
-use anyhow::{Context as _, Result};
 use serde::{Deserialize, Serialize};
-use std::{borrow::Cow, fmt::Write as _, mem, path::Path, sync::Arc};
+use std::{fmt::Write as _, mem, path::Path, sync::Arc};
 
-pub const CURSOR_POSITION_MARKER: &str = "[CURSOR_POSITION]";
-pub const INLINE_CURSOR_MARKER: &str = "<|user_cursor|>";
-
-#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Clone, Debug, Serialize, Deserialize)]
 pub struct ExampleSpec {
     #[serde(default)]
     pub name: String,
     pub repository_url: String,
     pub revision: String,
-    #[serde(default, skip_serializing_if = "Vec::is_empty")]
-    pub tags: Vec<String>,
-    #[serde(default, skip_serializing_if = "Option::is_none")]
-    pub reasoning: Option<String>,
     #[serde(default)]
     pub uncommitted_diff: String,
     pub cursor_path: Arc<Path>,
     pub cursor_position: String,
     pub edit_history: String,
-    pub expected_patches: Vec<String>,
+    pub expected_patch: String,
 }
 
-const REASONING_HEADING: &str = "Reasoning";
 const UNCOMMITTED_DIFF_HEADING: &str = "Uncommitted Diff";
 const EDIT_HISTORY_HEADING: &str = "Edit History";
 const CURSOR_POSITION_HEADING: &str = "Cursor Position";
 const EXPECTED_PATCH_HEADING: &str = "Expected Patch";
 const EXPECTED_CONTEXT_HEADING: &str = "Expected Context";
-
-#[derive(Serialize, Deserialize)]
-struct FrontMatter<'a> {
-    repository_url: Cow<'a, str>,
-    revision: Cow<'a, str>,
-    #[serde(default, skip_serializing_if = "Vec::is_empty")]
-    tags: Vec<String>,
-}
+const REPOSITORY_URL_FIELD: &str = "repository_url";
+const REVISION_FIELD: &str = "revision";
 
 impl ExampleSpec {
-    /// Generate a sanitized filename for this example.
-    pub fn filename(&self) -> String {
-        self.name
-            .chars()
-            .map(|c| match c {
-                ' ' | ':' | '~' | '^' | '?' | '*' | '[' | '\\' | '@' | '{' | '/' | '<' | '>'
-                | '|' | '"' => '-',
-                c => c,
-            })
-            .collect()
-    }
-
     /// Format this example spec as markdown.
     pub fn to_markdown(&self) -> String {
-        use std::fmt::Write as _;
-
-        let front_matter = FrontMatter {
-            repository_url: Cow::Borrowed(&self.repository_url),
-            revision: Cow::Borrowed(&self.revision),
-            tags: self.tags.clone(),
-        };
-        let front_matter_toml =
-            toml::to_string_pretty(&front_matter).unwrap_or_else(|_| String::new());
-
         let mut markdown = String::new();
 
-        _ = writeln!(markdown, "+++");
-        markdown.push_str(&front_matter_toml);
-        if !markdown.ends_with('\n') {
-            markdown.push('\n');
-        }
-        _ = writeln!(markdown, "+++");
-        markdown.push('\n');
-
         _ = writeln!(markdown, "# {}", self.name);
         markdown.push('\n');
 
-        if let Some(reasoning) = &self.reasoning {
-            _ = writeln!(markdown, "## {}", REASONING_HEADING);
-            markdown.push('\n');
-            markdown.push_str(reasoning);
-            if !markdown.ends_with('\n') {
-                markdown.push('\n');
-            }
-            markdown.push('\n');
-        }
+        _ = writeln!(markdown, "repository_url = {}", self.repository_url);
+        _ = writeln!(markdown, "revision = {}", self.revision);
+        markdown.push('\n');
 
         if !self.uncommitted_diff.is_empty() {
             _ = writeln!(markdown, "## {}", UNCOMMITTED_DIFF_HEADING);
@@ -126,48 +75,34 @@ impl ExampleSpec {
 
         _ = writeln!(markdown, "## {}", EXPECTED_PATCH_HEADING);
         markdown.push('\n');
-        for patch in &self.expected_patches {
-            _ = writeln!(markdown, "```diff");
-            markdown.push_str(patch);
-            if !markdown.ends_with('\n') {
-                markdown.push('\n');
-            }
-            _ = writeln!(markdown, "```");
+        _ = writeln!(markdown, "```diff");
+        markdown.push_str(&self.expected_patch);
+        if !markdown.ends_with('\n') {
             markdown.push('\n');
         }
+        _ = writeln!(markdown, "```");
+        markdown.push('\n');
 
         markdown
     }
 
     /// Parse an example spec from markdown.
-    pub fn from_markdown(mut input: &str) -> anyhow::Result<Self> {
+    pub fn from_markdown(name: String, input: &str) -> anyhow::Result<Self> {
         use pulldown_cmark::{CodeBlockKind, CowStr, Event, HeadingLevel, Parser, Tag, TagEnd};
 
+        let parser = Parser::new(input);
+
         let mut spec = ExampleSpec {
-            name: String::new(),
+            name,
             repository_url: String::new(),
             revision: String::new(),
-            tags: Vec::new(),
-            reasoning: None,
             uncommitted_diff: String::new(),
             cursor_path: Path::new("").into(),
             cursor_position: String::new(),
             edit_history: String::new(),
-            expected_patches: Vec::new(),
+            expected_patch: String::new(),
         };
 
-        if let Some(rest) = input.strip_prefix("+++\n")
-            && let Some((front_matter, rest)) = rest.split_once("+++\n")
-        {
-            if let Ok(data) = toml::from_str::<FrontMatter<'_>>(front_matter) {
-                spec.repository_url = data.repository_url.into_owned();
-                spec.revision = data.revision.into_owned();
-                spec.tags = data.tags;
-            }
-            input = rest.trim_start();
-        }
-
-        let parser = Parser::new(input);
         let mut text = String::new();
         let mut block_info: CowStr = "".into();
 
@@ -188,9 +123,20 @@ impl ExampleSpec {
             match event {
                 Event::Text(line) => {
                     text.push_str(&line);
-                }
-                Event::End(TagEnd::Heading(HeadingLevel::H1)) => {
-                    spec.name = mem::take(&mut text);
+
+                    if let Section::Start = current_section
+                        && let Some((field, value)) = line.split_once('=')
+                    {
+                        match field.trim() {
+                            REPOSITORY_URL_FIELD => {
+                                spec.repository_url = value.trim().to_string();
+                            }
+                            REVISION_FIELD => {
+                                spec.revision = value.trim().to_string();
+                            }
+                            _ => {}
+                        }
+                    }
                 }
                 Event::End(TagEnd::Heading(HeadingLevel::H2)) => {
                     let title = mem::take(&mut text);
@@ -248,7 +194,7 @@ impl ExampleSpec {
                             mem::take(&mut text);
                         }
                         Section::ExpectedPatch => {
-                            spec.expected_patches.push(mem::take(&mut text));
+                            spec.expected_patch = mem::take(&mut text);
                         }
                         Section::Start | Section::Other => {}
                     }
@@ -263,326 +209,4 @@ impl ExampleSpec {
 
         Ok(spec)
     }
-
-    /// Returns the excerpt of text around the cursor, and the offset of the cursor within that
-    /// excerpt.
-    ///
-    /// The cursor's position is marked with a special comment that appears
-    /// below the cursor line, which contains the string `[CURSOR_POSITION]`,
-    /// preceded by an arrow marking the cursor's column. The arrow can be
-    /// either:
-    /// - `^` - The cursor column is at the position of the `^` character (pointing up to the cursor)
-    /// - `<` - The cursor column is at the first non-whitespace character on that line.
-    pub fn cursor_excerpt(&self) -> Result<(String, usize)> {
-        let input = &self.cursor_position;
-
-        // Check for inline cursor marker first
-        if let Some(inline_offset) = input.find(INLINE_CURSOR_MARKER) {
-            let excerpt = input[..inline_offset].to_string()
-                + &input[inline_offset + INLINE_CURSOR_MARKER.len()..];
-            return Ok((excerpt, inline_offset));
-        }
-
-        let marker_offset = input
-            .find(CURSOR_POSITION_MARKER)
-            .context("missing [CURSOR_POSITION] marker")?;
-        let marker_line_start = input[..marker_offset]
-            .rfind('\n')
-            .map(|pos| pos + 1)
-            .unwrap_or(0);
-        let marker_line_end = input[marker_line_start..]
-            .find('\n')
-            .map(|pos| marker_line_start + pos + 1)
-            .unwrap_or(input.len());
-        let marker_line = &input[marker_line_start..marker_line_end].trim_end_matches('\n');
-
-        let cursor_column = if let Some(cursor_offset) = marker_line.find('^') {
-            cursor_offset
-        } else if let Some(less_than_pos) = marker_line.find('<') {
-            marker_line
-                .find(|c: char| !c.is_whitespace())
-                .unwrap_or(less_than_pos)
-        } else {
-            anyhow::bail!(
-                "cursor position marker line must contain '^' or '<' before [CURSOR_POSITION]"
-            );
-        };
-
-        let mut excerpt = input[..marker_line_start].to_string() + &input[marker_line_end..];
-        excerpt.truncate(excerpt.trim_end_matches('\n').len());
-
-        // The cursor is on the line above the marker line.
-        let cursor_line_end = marker_line_start.saturating_sub(1);
-        let cursor_line_start = excerpt[..cursor_line_end]
-            .rfind('\n')
-            .map(|pos| pos + 1)
-            .unwrap_or(0);
-        let cursor_offset = cursor_line_start + cursor_column;
-
-        Ok((excerpt, cursor_offset))
-    }
-
-    /// Sets the cursor position excerpt from a plain excerpt and cursor byte offset.
-    ///
-    /// The `line_comment_prefix` is used to format the marker line as a comment.
-    /// If the cursor column is less than the comment prefix length, the `<` format is used.
-    /// Otherwise, the `^` format is used.
-    pub fn set_cursor_excerpt(
-        &mut self,
-        excerpt: &str,
-        cursor_offset: usize,
-        line_comment_prefix: &str,
-    ) {
-        // Find which line the cursor is on and its column
-        let cursor_line_start = excerpt[..cursor_offset]
-            .rfind('\n')
-            .map(|pos| pos + 1)
-            .unwrap_or(0);
-        let cursor_line_end = excerpt[cursor_line_start..]
-            .find('\n')
-            .map(|pos| cursor_line_start + pos + 1)
-            .unwrap_or(excerpt.len());
-        let cursor_line = &excerpt[cursor_line_start..cursor_line_end];
-        let cursor_line_indent = &cursor_line[..cursor_line.len() - cursor_line.trim_start().len()];
-        let cursor_column = cursor_offset - cursor_line_start;
-
-        // Build the marker line
-        let mut marker_line = String::new();
-        if cursor_column < line_comment_prefix.len() {
-            for _ in 0..cursor_column {
-                marker_line.push(' ');
-            }
-            marker_line.push_str(line_comment_prefix);
-            write!(marker_line, " <{}", CURSOR_POSITION_MARKER).unwrap();
-        } else {
-            if cursor_column >= cursor_line_indent.len() + line_comment_prefix.len() {
-                marker_line.push_str(cursor_line_indent);
-            }
-            marker_line.push_str(line_comment_prefix);
-            while marker_line.len() < cursor_column {
-                marker_line.push(' ');
-            }
-            write!(marker_line, "^{}", CURSOR_POSITION_MARKER).unwrap();
-        }
-
-        // Build the final cursor_position string
-        let mut result = String::with_capacity(excerpt.len() + marker_line.len() + 2);
-        result.push_str(&excerpt[..cursor_line_end]);
-        if !result.ends_with('\n') {
-            result.push('\n');
-        }
-        result.push_str(&marker_line);
-        if cursor_line_end < excerpt.len() {
-            result.push('\n');
-            result.push_str(&excerpt[cursor_line_end..]);
-        }
-
-        self.cursor_position = result;
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use indoc::indoc;
-
-    #[test]
-    fn test_cursor_excerpt_with_caret() {
-        let mut spec = ExampleSpec {
-            name: String::new(),
-            repository_url: String::new(),
-            revision: String::new(),
-            tags: Vec::new(),
-            reasoning: None,
-            uncommitted_diff: String::new(),
-            cursor_path: Path::new("test.rs").into(),
-            cursor_position: String::new(),
-            edit_history: String::new(),
-            expected_patches: Vec::new(),
-        };
-
-        // Cursor before `42`
-        let excerpt = indoc! {"
-            fn main() {
-                let x = 42;
-                println!(\"{}\", x);
-            }"
-        };
-        let offset = excerpt.find("42").unwrap();
-        let position_string = indoc! {"
-            fn main() {
-                let x = 42;
-                //      ^[CURSOR_POSITION]
-                println!(\"{}\", x);
-            }"
-        }
-        .to_string();
-
-        spec.set_cursor_excerpt(excerpt, offset, "//");
-        assert_eq!(spec.cursor_position, position_string);
-        assert_eq!(
-            spec.cursor_excerpt().unwrap(),
-            (excerpt.to_string(), offset)
-        );
-
-        // Cursor after `l` in `let`
-        let offset = excerpt.find("et x").unwrap();
-        let position_string = indoc! {"
-            fn main() {
-                let x = 42;
-            //   ^[CURSOR_POSITION]
-                println!(\"{}\", x);
-            }"
-        }
-        .to_string();
-
-        spec.set_cursor_excerpt(excerpt, offset, "//");
-        assert_eq!(spec.cursor_position, position_string);
-        assert_eq!(
-            spec.cursor_excerpt().unwrap(),
-            (excerpt.to_string(), offset)
-        );
-
-        // Cursor before `let`
-        let offset = excerpt.find("let").unwrap();
-        let position_string = indoc! {"
-            fn main() {
-                let x = 42;
-            //  ^[CURSOR_POSITION]
-                println!(\"{}\", x);
-            }"
-        }
-        .to_string();
-
-        spec.set_cursor_excerpt(excerpt, offset, "//");
-        assert_eq!(spec.cursor_position, position_string);
-        assert_eq!(
-            spec.cursor_excerpt().unwrap(),
-            (excerpt.to_string(), offset)
-        );
-
-        // Cursor at beginning of the line with `let`
-        let offset = excerpt.find("    let").unwrap();
-        let position_string = indoc! {"
-            fn main() {
-                let x = 42;
-            // <[CURSOR_POSITION]
-                println!(\"{}\", x);
-            }"
-        }
-        .to_string();
-
-        spec.set_cursor_excerpt(excerpt, offset, "//");
-        assert_eq!(spec.cursor_position, position_string);
-        assert_eq!(
-            spec.cursor_excerpt().unwrap(),
-            (excerpt.to_string(), offset)
-        );
-
-        // Cursor at end of line, after the semicolon
-        let offset = excerpt.find(';').unwrap() + 1;
-        let position_string = indoc! {"
-            fn main() {
-                let x = 42;
-                //         ^[CURSOR_POSITION]
-                println!(\"{}\", x);
-            }"
-        }
-        .to_string();
-
-        spec.set_cursor_excerpt(excerpt, offset, "//");
-        assert_eq!(spec.cursor_position, position_string);
-        assert_eq!(
-            spec.cursor_excerpt().unwrap(),
-            (excerpt.to_string(), offset)
-        );
-
-        // Caret at end of file (no trailing newline)
-        let excerpt = indoc! {"
-            fn main() {
-                let x = 42;"
-        };
-        let offset = excerpt.find(';').unwrap() + 1;
-        let position_string = indoc! {"
-            fn main() {
-                let x = 42;
-                //         ^[CURSOR_POSITION]"
-        }
-        .to_string();
-
-        spec.set_cursor_excerpt(excerpt, offset, "//");
-        assert_eq!(spec.cursor_position, position_string);
-        assert_eq!(
-            spec.cursor_excerpt().unwrap(),
-            (excerpt.to_string(), offset)
-        );
-    }
-
-    #[test]
-    fn test_cursor_excerpt_with_inline_marker() {
-        let mut spec = ExampleSpec {
-            name: String::new(),
-            repository_url: String::new(),
-            revision: String::new(),
-            tags: Vec::new(),
-            reasoning: None,
-            uncommitted_diff: String::new(),
-            cursor_path: Path::new("test.rs").into(),
-            cursor_position: String::new(),
-            edit_history: String::new(),
-            expected_patches: Vec::new(),
-        };
-
-        // Cursor before `42` using inline marker
-        spec.cursor_position = indoc! {"
-            fn main() {
-                let x = <|user_cursor|>42;
-                println!(\"{}\", x);
-            }"
-        }
-        .to_string();
-
-        let expected_excerpt = indoc! {"
-            fn main() {
-                let x = 42;
-                println!(\"{}\", x);
-            }"
-        };
-        let expected_offset = expected_excerpt.find("42").unwrap();
-
-        assert_eq!(
-            spec.cursor_excerpt().unwrap(),
-            (expected_excerpt.to_string(), expected_offset)
-        );
-
-        // Cursor at beginning of line
-        spec.cursor_position = indoc! {"
-            fn main() {
-            <|user_cursor|>    let x = 42;
-            }"
-        }
-        .to_string();
-
-        let expected_excerpt = indoc! {"
-            fn main() {
-                let x = 42;
-            }"
-        };
-        let expected_offset = expected_excerpt.find("    let").unwrap();
-
-        assert_eq!(
-            spec.cursor_excerpt().unwrap(),
-            (expected_excerpt.to_string(), expected_offset)
-        );
-
-        // Cursor at end of file
-        spec.cursor_position = "fn main() {}<|user_cursor|>".to_string();
-        let expected_excerpt = "fn main() {}";
-        let expected_offset = expected_excerpt.len();
-
-        assert_eq!(
-            spec.cursor_excerpt().unwrap(),
-            (expected_excerpt.to_string(), expected_offset)
-        );
-    }
 }

crates/edit_prediction/src/mercury.rs

@@ -6,7 +6,7 @@ use crate::{
 use anyhow::{Context as _, Result};
 use futures::AsyncReadExt as _;
 use gpui::{
-    App, AppContext as _, Entity, Global, SharedString, Task,
+    App, AppContext as _, Entity, SharedString, Task,
     http_client::{self, AsyncBody, Method},
 };
 use language::{OffsetRangeExt as _, ToOffset, ToPoint as _};
@@ -300,19 +300,14 @@ pub const MERCURY_CREDENTIALS_URL: SharedString =
     SharedString::new_static("https://api.inceptionlabs.ai/v1/edit/completions");
 pub const MERCURY_CREDENTIALS_USERNAME: &str = "mercury-api-token";
 pub static MERCURY_TOKEN_ENV_VAR: std::sync::LazyLock<EnvVar> = env_var!("MERCURY_AI_TOKEN");
-
-struct GlobalMercuryApiKey(Entity<ApiKeyState>);
-
-impl Global for GlobalMercuryApiKey {}
+pub static MERCURY_API_KEY: std::sync::OnceLock<Entity<ApiKeyState>> = std::sync::OnceLock::new();
 
 pub fn mercury_api_token(cx: &mut App) -> Entity<ApiKeyState> {
-    if let Some(global) = cx.try_global::<GlobalMercuryApiKey>() {
-        return global.0.clone();
-    }
-    let entity =
-        cx.new(|_| ApiKeyState::new(MERCURY_CREDENTIALS_URL, MERCURY_TOKEN_ENV_VAR.clone()));
-    cx.set_global(GlobalMercuryApiKey(entity.clone()));
-    entity
+    MERCURY_API_KEY
+        .get_or_init(|| {
+            cx.new(|_| ApiKeyState::new(MERCURY_CREDENTIALS_URL, MERCURY_TOKEN_ENV_VAR.clone()))
+        })
+        .clone()
 }
 
 pub fn load_mercury_api_token(cx: &mut App) -> Task<Result<(), language_model::AuthenticateError>> {

crates/edit_prediction/src/sweep_ai.rs

@@ -1,7 +1,7 @@
 use anyhow::Result;
 use futures::AsyncReadExt as _;
 use gpui::{
-    App, AppContext as _, Entity, Global, SharedString, Task,
+    App, AppContext as _, Entity, SharedString, Task,
     http_client::{self, AsyncBody, Method},
 };
 use language::{Point, ToOffset as _};
@@ -272,19 +272,14 @@ pub const SWEEP_CREDENTIALS_URL: SharedString =
     SharedString::new_static("https://autocomplete.sweep.dev");
 pub const SWEEP_CREDENTIALS_USERNAME: &str = "sweep-api-token";
 pub static SWEEP_AI_TOKEN_ENV_VAR: std::sync::LazyLock<EnvVar> = env_var!("SWEEP_AI_TOKEN");
-
-struct GlobalSweepApiKey(Entity<ApiKeyState>);
-
-impl Global for GlobalSweepApiKey {}
+pub static SWEEP_API_KEY: std::sync::OnceLock<Entity<ApiKeyState>> = std::sync::OnceLock::new();
 
 pub fn sweep_api_token(cx: &mut App) -> Entity<ApiKeyState> {
-    if let Some(global) = cx.try_global::<GlobalSweepApiKey>() {
-        return global.0.clone();
-    }
-    let entity =
-        cx.new(|_| ApiKeyState::new(SWEEP_CREDENTIALS_URL, SWEEP_AI_TOKEN_ENV_VAR.clone()));
-    cx.set_global(GlobalSweepApiKey(entity.clone()));
-    entity
+    SWEEP_API_KEY
+        .get_or_init(|| {
+            cx.new(|_| ApiKeyState::new(SWEEP_CREDENTIALS_URL, SWEEP_AI_TOKEN_ENV_VAR.clone()))
+        })
+        .clone()
 }
 
 pub fn load_sweep_api_token(cx: &mut App) -> Task<Result<(), language_model::AuthenticateError>> {

crates/edit_prediction/src/udiff.rs

@@ -14,8 +14,10 @@ use anyhow::anyhow;
 use collections::HashMap;
 use gpui::AsyncApp;
 use gpui::Entity;
-use language::{Anchor, Buffer, OffsetRangeExt as _, TextBufferSnapshot, text_diff};
-use project::Project;
+use language::{Anchor, Buffer, OffsetRangeExt as _, TextBufferSnapshot};
+use project::{Project, ProjectPath};
+use util::paths::PathStyle;
+use util::rel_path::RelPath;
 
 #[derive(Clone, Debug)]
 pub struct OpenedBuffers(#[allow(unused)] HashMap<String, Entity<Buffer>>);
@@ -28,26 +30,54 @@ pub async fn apply_diff(
 ) -> Result<OpenedBuffers> {
     let mut included_files = HashMap::default();
 
+    let worktree_id = project.read_with(cx, |project, cx| {
+        anyhow::Ok(
+            project
+                .visible_worktrees(cx)
+                .next()
+                .context("no worktrees")?
+                .read(cx)
+                .id(),
+        )
+    })??;
+
+    for line in diff_str.lines() {
+        let diff_line = DiffLine::parse(line);
+
+        if let DiffLine::OldPath { path } = diff_line {
+            let buffer = project
+                .update(cx, |project, cx| {
+                    let project_path = ProjectPath {
+                        worktree_id,
+                        path: RelPath::new(Path::new(path.as_ref()), PathStyle::Posix)?.into_arc(),
+                    };
+                    anyhow::Ok(project.open_buffer(project_path, cx))
+                })??
+                .await?;
+
+            included_files.insert(path.to_string(), buffer);
+        }
+    }
+
     let ranges = [Anchor::MIN..Anchor::MAX];
+
     let mut diff = DiffParser::new(diff_str);
     let mut current_file = None;
     let mut edits = vec![];
 
     while let Some(event) = diff.next()? {
         match event {
-            DiffEvent::Hunk { path, hunk } => {
-                let buffer = match current_file {
+            DiffEvent::Hunk {
+                path: file_path,
+                hunk,
+            } => {
+                let (buffer, ranges) = match current_file {
                     None => {
-                        let buffer = project
-                            .update(cx, |project, cx| {
-                                let project_path = project
-                                    .find_project_path(path.as_ref(), cx)
-                                    .context("no such path")?;
-                                anyhow::Ok(project.open_buffer(project_path, cx))
-                            })??
-                            .await?;
-                        included_files.insert(path.to_string(), buffer.clone());
-                        current_file = Some(buffer);
+                        let buffer = included_files
+                            .get_mut(file_path.as_ref())
+                            .expect("Opened all files in diff");
+
+                        current_file = Some((buffer, ranges.as_slice()));
                         current_file.as_ref().unwrap()
                     }
                     Some(ref current) => current,
@@ -55,14 +85,14 @@ pub async fn apply_diff(
 
                 buffer.read_with(cx, |buffer, _| {
                     edits.extend(
-                        resolve_hunk_edits_in_buffer(hunk, buffer, ranges.as_slice())
+                        resolve_hunk_edits_in_buffer(hunk, buffer, ranges)
                             .with_context(|| format!("Diff:\n{diff_str}"))?,
                     );
                     anyhow::Ok(())
                 })??;
             }
             DiffEvent::FileEnd { renamed_to } => {
-                let buffer = current_file
+                let (buffer, _) = current_file
                     .take()
                     .context("Got a FileEnd event before an Hunk event")?;
 
@@ -98,69 +128,10 @@ pub async fn apply_diff(
     Ok(OpenedBuffers(included_files))
 }
 
-/// Extract the diff for a specific file from a multi-file diff.
-/// Returns an error if the file is not found in the diff.
-pub fn extract_file_diff(full_diff: &str, file_path: &str) -> Result<String> {
-    let mut result = String::new();
-    let mut in_target_file = false;
-    let mut found_file = false;
-
-    for line in full_diff.lines() {
-        if line.starts_with("diff --git") {
-            if in_target_file {
-                break;
-            }
-            in_target_file = line.contains(&format!("a/{}", file_path))
-                || line.contains(&format!("b/{}", file_path));
-            if in_target_file {
-                found_file = true;
-            }
-        }
-
-        if in_target_file {
-            result.push_str(line);
-            result.push('\n');
-        }
-    }
-
-    if !found_file {
-        anyhow::bail!("File '{}' not found in diff", file_path);
-    }
-
-    Ok(result)
-}
-
-/// Strip unnecessary git metadata lines from a diff, keeping only the lines
-/// needed for patch application: path headers (--- and +++), hunk headers (@@),
-/// and content lines (+, -, space).
-pub fn strip_diff_metadata(diff: &str) -> String {
-    let mut result = String::new();
-
-    for line in diff.lines() {
-        let dominated = DiffLine::parse(line);
-        match dominated {
-            // Keep path headers, hunk headers, and content lines
-            DiffLine::OldPath { .. }
-            | DiffLine::NewPath { .. }
-            | DiffLine::HunkHeader(_)
-            | DiffLine::Context(_)
-            | DiffLine::Deletion(_)
-            | DiffLine::Addition(_) => {
-                result.push_str(line);
-                result.push('\n');
-            }
-            // Skip garbage lines (diff --git, index, etc.)
-            DiffLine::Garbage(_) => {}
-        }
-    }
-
-    result
-}
-
-pub fn apply_diff_to_string(original: &str, diff_str: &str) -> Result<String> {
+pub fn apply_diff_to_string(diff_str: &str, text: &str) -> Result<String> {
     let mut diff = DiffParser::new(diff_str);
 
-    let mut text = original.to_string();
+    let mut text = text.to_string();
 
     while let Some(event) = diff.next()? {
         match event {
@@ -180,51 +151,6 @@ pub fn apply_diff_to_string(original: &str, diff_str: &str) -> Result<String> {
     Ok(text)
 }
 
-/// Returns the individual edits that would be applied by a diff to the given content.
-/// Each edit is a tuple of (byte_range_in_content, replacement_text).
-/// Uses sub-line diffing to find the precise character positions of changes.
-/// Returns an empty vec if the hunk context is not found or is ambiguous.
-pub fn edits_for_diff(content: &str, diff_str: &str) -> Result<Vec<(Range<usize>, String)>> {
-    let mut diff = DiffParser::new(diff_str);
-    let mut result = Vec::new();
-
-    while let Some(event) = diff.next()? {
-        match event {
-            DiffEvent::Hunk { hunk, .. } => {
-                if hunk.context.is_empty() {
-                    return Ok(Vec::new());
-                }
-
-                // Find the context in the content
-                let first_match = content.find(&hunk.context);
-                let Some(context_offset) = first_match else {
-                    return Ok(Vec::new());
-                };
-
-                // Check for ambiguity - if context appears more than once, reject
-                if content[context_offset + 1..].contains(&hunk.context) {
-                    return Ok(Vec::new());
-                }
-
-                // Use sub-line diffing to find precise edit positions
-                for edit in &hunk.edits {
-                    let old_text = &content
-                        [context_offset + edit.range.start..context_offset + edit.range.end];
-                    let edits_within_hunk = text_diff(old_text, &edit.text);
-                    for (inner_range, inner_text) in edits_within_hunk {
-                        let absolute_start = context_offset + edit.range.start + inner_range.start;
-                        let absolute_end = context_offset + edit.range.start + inner_range.end;
-                        result.push((absolute_start..absolute_end, inner_text.to_string()));
-                    }
-                }
-            }
-            DiffEvent::FileEnd { .. } => {}
-        }
-    }
-
-    Ok(result)
-}
-
 struct PatchFile<'a> {
     old_path: Cow<'a, str>,
     new_path: Cow<'a, str>,
@@ -947,135 +873,4 @@ mod tests {
 
         FakeFs::new(cx.background_executor.clone())
     }
-
-    #[test]
-    fn test_extract_file_diff() {
-        let multi_file_diff = indoc! {r#"
-            diff --git a/file1.txt b/file1.txt
-            index 1234567..abcdefg 100644
-            --- a/file1.txt
-            +++ b/file1.txt
-            @@ -1,3 +1,4 @@
-             line1
-            +added line
-             line2
-             line3
-            diff --git a/file2.txt b/file2.txt
-            index 2345678..bcdefgh 100644
-            --- a/file2.txt
-            +++ b/file2.txt
-            @@ -1,2 +1,2 @@
-            -old line
-            +new line
-             unchanged
-        "#};
-
-        let file1_diff = extract_file_diff(multi_file_diff, "file1.txt").unwrap();
-        assert_eq!(
-            file1_diff,
-            indoc! {r#"
-                diff --git a/file1.txt b/file1.txt
-                index 1234567..abcdefg 100644
-                --- a/file1.txt
-                +++ b/file1.txt
-                @@ -1,3 +1,4 @@
-                 line1
-                +added line
-                 line2
-                 line3
-            "#}
-        );
-
-        let file2_diff = extract_file_diff(multi_file_diff, "file2.txt").unwrap();
-        assert_eq!(
-            file2_diff,
-            indoc! {r#"
-                diff --git a/file2.txt b/file2.txt
-                index 2345678..bcdefgh 100644
-                --- a/file2.txt
-                +++ b/file2.txt
-                @@ -1,2 +1,2 @@
-                -old line
-                +new line
-                 unchanged
-            "#}
-        );
-
-        let result = extract_file_diff(multi_file_diff, "nonexistent.txt");
-        assert!(result.is_err());
-    }
-
-    #[test]
-    fn test_edits_for_diff() {
-        let content = indoc! {"
-            fn main() {
-                let x = 1;
-                let y = 2;
-                println!(\"{} {}\", x, y);
-            }
-        "};
-
-        let diff = indoc! {"
-            --- a/file.rs
-            +++ b/file.rs
-            @@ -1,5 +1,5 @@
-             fn main() {
-            -    let x = 1;
-            +    let x = 42;
-                 let y = 2;
-                 println!(\"{} {}\", x, y);
-             }
-        "};
-
-        let edits = edits_for_diff(content, diff).unwrap();
-        assert_eq!(edits.len(), 1);
-
-        let (range, replacement) = &edits[0];
-        // With sub-line diffing, the edit should start at "1" (the actual changed character)
-        let expected_start = content.find("let x = 1;").unwrap() + "let x = ".len();
-        assert_eq!(range.start, expected_start);
-        // The deleted text is just "1"
-        assert_eq!(range.end, expected_start + "1".len());
-        // The replacement text
-        assert_eq!(replacement, "42");
-
-        // Verify the cursor would be positioned at the column of "1"
-        let line_start = content[..range.start]
-            .rfind('\n')
-            .map(|p| p + 1)
-            .unwrap_or(0);
-        let cursor_column = range.start - line_start;
-        // "    let x = " is 12 characters, so column 12
-        assert_eq!(cursor_column, "    let x = ".len());
-    }
-
-    #[test]
-    fn test_strip_diff_metadata() {
-        let diff_with_metadata = indoc! {r#"
-            diff --git a/file.txt b/file.txt
-            index 1234567..abcdefg 100644
-            --- a/file.txt
-            +++ b/file.txt
-            @@ -1,3 +1,4 @@
-             context line
-            -removed line
-            +added line
-             more context
-        "#};
-
-        let stripped = strip_diff_metadata(diff_with_metadata);
-
-        assert_eq!(
-            stripped,
-            indoc! {r#"
-                --- a/file.txt
-                +++ b/file.txt
-                @@ -1,3 +1,4 @@
-                 context line
-                -removed line
-                +added line
-                 more context
-            "#}
-        );
-    }
 }

crates/edit_prediction_cli/src/anthropic_client.rs

@@ -1,10 +1,8 @@
 use anthropic::{
-    ANTHROPIC_API_URL, Event, Message, Request as AnthropicRequest, RequestContent,
-    Response as AnthropicResponse, ResponseContent, Role, non_streaming_completion,
-    stream_completion,
+    ANTHROPIC_API_URL, Message, Request as AnthropicRequest, RequestContent,
+    Response as AnthropicResponse, Role, non_streaming_completion,
 };
 use anyhow::Result;
-use futures::StreamExt as _;
 use http_client::HttpClient;
 use indoc::indoc;
 use reqwest_client::ReqwestClient;
@@ -17,12 +15,12 @@ use std::path::Path;
 use std::sync::Arc;
 
 pub struct PlainLlmClient {
-    pub http_client: Arc<dyn HttpClient>,
-    pub api_key: String,
+    http_client: Arc<dyn HttpClient>,
+    api_key: String,
 }
 
 impl PlainLlmClient {
-    pub fn new() -> Result<Self> {
+    fn new() -> Result<Self> {
         let http_client: Arc<dyn http_client::HttpClient> = Arc::new(ReqwestClient::new());
         let api_key = std::env::var("ANTHROPIC_API_KEY")
             .map_err(|_| anyhow::anyhow!("ANTHROPIC_API_KEY environment variable not set"))?;
@@ -32,7 +30,7 @@ impl PlainLlmClient {
         })
     }
 
-    pub async fn generate(
+    async fn generate(
         &self,
         model: &str,
         max_tokens: u64,
@@ -65,72 +63,6 @@ impl PlainLlmClient {
 
         Ok(response)
     }
-
-    pub async fn generate_streaming<F>(
-        &self,
-        model: &str,
-        max_tokens: u64,
-        messages: Vec<Message>,
-        mut on_progress: F,
-    ) -> Result<AnthropicResponse>
-    where
-        F: FnMut(usize, &str),
-    {
-        let request = AnthropicRequest {
-            model: model.to_string(),
-            max_tokens,
-            messages,
-            tools: Vec::new(),
-            thinking: None,
-            tool_choice: None,
-            system: None,
-            metadata: None,
-            stop_sequences: Vec::new(),
-            temperature: None,
-            top_k: None,
-            top_p: None,
-        };
-
-        let mut stream = stream_completion(
-            self.http_client.as_ref(),
-            ANTHROPIC_API_URL,
-            &self.api_key,
-            request,
-            None,
-        )
-        .await
-        .map_err(|e| anyhow::anyhow!("{:?}", e))?;
-
-        let mut response: Option<AnthropicResponse> = None;
-        let mut text_content = String::new();
-
-        while let Some(event_result) = stream.next().await {
-            let event = event_result.map_err(|e| anyhow::anyhow!("{:?}", e))?;
-
-            match event {
-                Event::MessageStart { message } => {
-                    response = Some(message);
-                }
-                Event::ContentBlockDelta { delta, .. } => {
-                    if let anthropic::ContentDelta::TextDelta { text } = delta {
-                        text_content.push_str(&text);
-                        on_progress(text_content.len(), &text_content);
-                    }
-                }
-                _ => {}
-            }
-        }
-
-        let mut response = response.ok_or_else(|| anyhow::anyhow!("No response received"))?;
-
-        if response.content.is_empty() && !text_content.is_empty() {
-            response
-                .content
-                .push(ResponseContent::Text { text: text_content });
-        }
-
-        Ok(response)
-    }
 }
 
 pub struct BatchingLlmClient {
@@ -476,29 +408,6 @@ impl AnthropicClient {
         }
     }
 
-    #[allow(dead_code)]
-    pub async fn generate_streaming<F>(
-        &self,
-        model: &str,
-        max_tokens: u64,
-        messages: Vec<Message>,
-        on_progress: F,
-    ) -> Result<Option<AnthropicResponse>>
-    where
-        F: FnMut(usize, &str),
-    {
-        match self {
-            AnthropicClient::Plain(plain_llm_client) => plain_llm_client
-                .generate_streaming(model, max_tokens, messages, on_progress)
-                .await
-                .map(Some),
-            AnthropicClient::Batch(_) => {
-                anyhow::bail!("Streaming not supported with batching client")
-            }
-            AnthropicClient::Dummy => panic!("Dummy LLM client is not expected to be used"),
-        }
-    }
-
     pub async fn sync_batches(&self) -> Result<()> {
         match self {
             AnthropicClient::Plain(_) => Ok(()),

crates/edit_prediction_cli/src/distill.rs

@@ -1,15 +1,20 @@
-use anyhow::Result;
+use anyhow::{Result, anyhow};
 use std::mem;
 
 use crate::example::Example;
 
 pub async fn run_distill(example: &mut Example) -> Result<()> {
-    let predictions = mem::take(&mut example.predictions)
-        .into_iter()
-        .map(|p| p.actual_patch)
-        .collect();
+    let [prediction]: [_; 1] =
+        mem::take(&mut example.predictions)
+            .try_into()
+            .map_err(|preds: Vec<_>| {
+                anyhow!(
+                    "Example has {} predictions, but it should have exactly one",
+                    preds.len()
+                )
+            })?;
 
-    example.spec.expected_patches = predictions;
+    example.spec.expected_patch = prediction.actual_patch;
     example.prompt = None;
     example.predictions = Vec::new();
     example.score = Vec::new();

crates/edit_prediction_cli/src/example.rs

@@ -1,4 +1,4 @@
-use crate::{PredictionProvider, PromptFormat};
+use crate::{PredictionProvider, PromptFormat, metrics::ClassificationMetrics};
 use anyhow::{Context as _, Result};
 use collections::HashMap;
 use edit_prediction::example_spec::ExampleSpec;
@@ -87,6 +87,7 @@ pub struct ExamplePrediction {
 #[derive(Clone, Debug, Serialize, Deserialize)]
 pub struct ExampleScore {
     pub delta_chr_f: f32,
+    pub line_match: ClassificationMetrics,
 }
 
 impl Example {
@@ -189,11 +190,7 @@ pub fn read_examples(inputs: &[PathBuf]) -> Vec<Example> {
                     .collect::<Vec<Example>>(),
             ),
             "md" => {
-                let mut example = parse_markdown_example(&content).unwrap();
-                if example.spec.name.is_empty() {
-                    example.spec.name = filename;
-                }
-                examples.push(example);
+                examples.push(parse_markdown_example(filename, &content).unwrap());
             }
             ext => {
                 panic!("{} has invalid example extension `{ext}`", path.display())
@@ -239,8 +236,8 @@ pub fn group_examples_by_repo(examples: &mut [Example]) -> Vec<Vec<&mut Example>
     examples_by_repo.into_values().collect()
 }
 
-fn parse_markdown_example(input: &str) -> Result<Example> {
-    let spec = ExampleSpec::from_markdown(input)?;
+fn parse_markdown_example(name: String, input: &str) -> Result<Example> {
+    let spec = ExampleSpec::from_markdown(name, input)?;
     Ok(Example {
         spec,
         buffer: None,

crates/edit_prediction_cli/src/format_prompt.rs

@@ -30,12 +30,7 @@ pub async fn run_format_prompt(
             let prompt = TeacherPrompt::format_prompt(example);
             example.prompt = Some(ExamplePrompt {
                 input: prompt,
-                expected_output: example
-                    .spec
-                    .expected_patches
-                    .first()
-                    .cloned()
-                    .unwrap_or_default(),
+                expected_output: example.spec.expected_patch.clone(), // TODO
                 format: prompt_format,
             });
         }
@@ -50,11 +45,6 @@ pub async fn run_format_prompt(
             let snapshot = state.buffer.read_with(&cx, |buffer, _| buffer.snapshot())?;
             let project = state.project.clone();
             let (_, input) = ep_store.update(&mut cx, |ep_store, cx| {
-                let events = ep_store
-                    .edit_history_for_project(&project, cx)
-                    .into_iter()
-                    .map(|e| e.event)
-                    .collect();
                 anyhow::Ok(zeta2_prompt_input(
                     &snapshot,
                     example
@@ -63,7 +53,7 @@ pub async fn run_format_prompt(
                         .context("context must be set")?
                         .files
                         .clone(),
-                    events,
+                    ep_store.edit_history_for_project(&project, cx),
                     example.spec.cursor_path.clone(),
                     example
                         .buffer
@@ -73,15 +63,8 @@ pub async fn run_format_prompt(
                 ))
             })??;
             let prompt = format_zeta_prompt(&input);
-            let expected_output = zeta2_output_for_patch(
-                &input,
-                &example
-                    .spec
-                    .expected_patches
-                    .first()
-                    .context("expected patches is empty")?
-                    .clone(),
-            )?;
+            let expected_output =
+                zeta2_output_for_patch(&input, &example.spec.expected_patch.clone())?;
             example.prompt = Some(ExamplePrompt {
                 input: prompt,
                 expected_output,
@@ -98,7 +81,6 @@ impl TeacherPrompt {
     const PROMPT: &str = include_str!("teacher.prompt.md");
     pub(crate) const EDITABLE_REGION_START: &str = "<|editable_region_start|>\n";
     pub(crate) const EDITABLE_REGION_END: &str = "<|editable_region_end|>";
-    pub(crate) const USER_CURSOR_MARKER: &str = "<|user_cursor|>";
 
     /// Truncate edit history to this number of last lines
     const MAX_HISTORY_LINES: usize = 128;
@@ -194,15 +176,13 @@ impl TeacherPrompt {
         result.push_str(Self::EDITABLE_REGION_START);
 
         // TODO: control number of lines around cursor
-        let (mut excerpt, offset) = example.spec.cursor_excerpt().unwrap();
-        excerpt.insert_str(offset, Self::USER_CURSOR_MARKER);
-        result.push_str(&excerpt);
-        if !result.ends_with('\n') {
+        result.push_str(&example.spec.cursor_position);
+        if !example.spec.cursor_position.ends_with('\n') {
             result.push('\n');
         }
 
-        result.push_str(Self::EDITABLE_REGION_END);
-        result.push_str("\n`````");
+        result.push_str(&format!("{}\n", Self::EDITABLE_REGION_END));
+        result.push_str("`````");
 
         result
     }

crates/edit_prediction_cli/src/git.rs

@@ -1,110 +0,0 @@
-use anyhow::{Context as _, Result};
-use collections::HashMap;
-use futures::lock::{Mutex, OwnedMutexGuard};
-use std::{
-    cell::RefCell,
-    path::{Path, PathBuf},
-    sync::Arc,
-};
-
-use crate::paths::REPOS_DIR;
-
-thread_local! {
-    static REPO_LOCKS: RefCell<HashMap<PathBuf, Arc<Mutex<()>>>> = RefCell::new(HashMap::default());
-}
-
-#[must_use]
-pub async fn lock_repo(path: impl AsRef<Path>) -> OwnedMutexGuard<()> {
-    REPO_LOCKS
-        .with(|cell| {
-            cell.borrow_mut()
-                .entry(path.as_ref().to_path_buf())
-                .or_default()
-                .clone()
-        })
-        .lock_owned()
-        .await
-}
-
-pub async fn run_git(repo_path: &Path, args: &[&str]) -> Result<String> {
-    let output = smol::process::Command::new("git")
-        .current_dir(repo_path)
-        .args(args)
-        .output()
-        .await?;
-
-    anyhow::ensure!(
-        output.status.success(),
-        "`git {}` within `{}` failed with status: {}\nstderr:\n{}\nstdout:\n{}",
-        args.join(" "),
-        repo_path.display(),
-        output.status,
-        String::from_utf8_lossy(&output.stderr),
-        String::from_utf8_lossy(&output.stdout),
-    );
-    Ok(String::from_utf8(output.stdout)?.trim().to_string())
-}
-
-pub fn parse_repo_url(url: &str) -> Result<(String, String)> {
-    if url.contains('@') {
-        let (_, path) = url.split_once(':').context("expected : in git url")?;
-        let (owner, repo) = path.split_once('/').context("expected / in git url")?;
-        Ok((owner.to_string(), repo.trim_end_matches(".git").to_string()))
-    } else {
-        let parsed = http_client::Url::parse(url)?;
-        let mut segments = parsed.path_segments().context("empty http url")?;
-        let owner = segments.next().context("expected owner")?;
-        let repo = segments.next().context("expected repo")?;
-        Ok((owner.to_string(), repo.trim_end_matches(".git").to_string()))
-    }
-}
-
-pub fn repo_path_for_url(url: &str) -> Result<PathBuf> {
-    let (owner, name) = parse_repo_url(url)?;
-    Ok(REPOS_DIR.join(&owner).join(&name))
-}
-
-pub async fn ensure_repo_cloned(repo_url: &str) -> Result<PathBuf> {
-    let repo_path = repo_path_for_url(repo_url)?;
-    let _lock = lock_repo(&repo_path).await;
-
-    if !repo_path.is_dir() {
-        log::info!("Cloning {} into {:?}", repo_url, repo_path);
-        std::fs::create_dir_all(&repo_path)?;
-        run_git(&repo_path, &["init"]).await?;
-        run_git(&repo_path, &["remote", "add", "origin", repo_url]).await?;
-    }
-
-    // Always fetch to get latest commits
-    run_git(&repo_path, &["fetch", "origin"]).await?;
-
-    // Check if we have a valid HEAD, if not checkout FETCH_HEAD
-    let has_head = run_git(&repo_path, &["rev-parse", "HEAD"]).await.is_ok();
-    if !has_head {
-        // Use reset to set HEAD without needing a branch
-        run_git(&repo_path, &["reset", "--hard", "FETCH_HEAD"]).await?;
-    }
-
-    Ok(repo_path)
-}
-
-pub async fn fetch_if_needed(repo_path: &Path, revision: &str) -> Result<String> {
-    let resolved = run_git(
-        repo_path,
-        &["rev-parse", &format!("{}^{{commit}}", revision)],
-    )
-    .await;
-
-    if let Ok(sha) = resolved {
-        return Ok(sha);
-    }
-
-    if run_git(repo_path, &["fetch", "--depth", "1", "origin", revision])
-        .await
-        .is_err()
-    {
-        run_git(repo_path, &["fetch", "origin"]).await?;
-    }
-
-    run_git(repo_path, &["rev-parse", "FETCH_HEAD"]).await
-}

crates/edit_prediction_cli/src/load_project.rs

@@ -1,19 +1,29 @@
 use crate::{
     example::{Example, ExampleBuffer, ExampleState},
-    git,
     headless::EpAppState,
-    paths::WORKTREES_DIR,
+    paths::{REPOS_DIR, WORKTREES_DIR},
     progress::{InfoStyle, Progress, Step, StepProgress},
 };
 use anyhow::{Context as _, Result};
+use collections::HashMap;
 use edit_prediction::EditPredictionStore;
 use edit_prediction::udiff::OpenedBuffers;
-use futures::AsyncWriteExt as _;
+use futures::{
+    AsyncWriteExt as _,
+    lock::{Mutex, OwnedMutexGuard},
+};
 use gpui::{AsyncApp, Entity};
 use language::{Anchor, Buffer, LanguageNotFound, ToOffset, ToPoint};
-use project::Project;
 use project::buffer_store::BufferStoreEvent;
-use std::{fs, path::PathBuf, sync::Arc};
+use project::{Project, ProjectPath};
+use std::{
+    cell::RefCell,
+    fs,
+    path::{Path, PathBuf},
+    sync::Arc,
+};
+use util::{paths::PathStyle, rel_path::RelPath};
+use zeta_prompt::CURSOR_MARKER;
 
 pub async fn run_load_project(
     example: &mut Example,
@@ -76,22 +86,37 @@ async fn cursor_position(
         return Err(error);
     }
 
-    let cursor_path = project
-        .read_with(cx, |project, cx| {
-            project.find_project_path(&example.spec.cursor_path, cx)
-        })?
-        .with_context(|| {
-            format!(
-                "failed to find cursor path {}",
-                example.spec.cursor_path.display()
-            )
-        })?;
+    let worktree = project.read_with(cx, |project, cx| {
+        project
+            .visible_worktrees(cx)
+            .next()
+            .context("No visible worktrees")
+    })??;
+
+    let cursor_path = RelPath::new(&example.spec.cursor_path, PathStyle::Posix)
+        .context("Failed to create RelPath")?
+        .into_arc();
     let cursor_buffer = project
-        .update(cx, |project, cx| project.open_buffer(cursor_path, cx))?
+        .update(cx, |project, cx| {
+            project.open_buffer(
+                ProjectPath {
+                    worktree_id: worktree.read(cx).id(),
+                    path: cursor_path,
+                },
+                cx,
+            )
+        })?
         .await?;
-
-    let (cursor_excerpt, cursor_offset_within_excerpt) = example.spec.cursor_excerpt()?;
-
+    let cursor_offset_within_excerpt = example
+        .spec
+        .cursor_position
+        .find(CURSOR_MARKER)
+        .context("missing cursor marker")?;
+    let mut cursor_excerpt = example.spec.cursor_position.clone();
+    cursor_excerpt.replace_range(
+        cursor_offset_within_excerpt..(cursor_offset_within_excerpt + CURSOR_MARKER.len()),
+        "",
+    );
     let excerpt_offset = cursor_buffer.read_with(cx, |buffer, _cx| {
         let text = buffer.text();
 
@@ -187,17 +212,17 @@ async fn setup_project(
 
 async fn setup_worktree(example: &Example, step_progress: &StepProgress) -> Result<PathBuf> {
     let (repo_owner, repo_name) = example.repo_name().context("failed to get repo name")?;
-    let repo_dir = git::repo_path_for_url(&example.spec.repository_url)?;
+    let repo_dir = REPOS_DIR.join(repo_owner.as_ref()).join(repo_name.as_ref());
     let worktree_path = WORKTREES_DIR
         .join(repo_owner.as_ref())
         .join(repo_name.as_ref());
-    let repo_lock = git::lock_repo(&repo_dir).await;
+    let repo_lock = lock_repo(&repo_dir).await;
 
     if !repo_dir.is_dir() {
         step_progress.set_substatus(format!("cloning {}", repo_name));
         fs::create_dir_all(&repo_dir)?;
-        git::run_git(&repo_dir, &["init"]).await?;
-        git::run_git(
+        run_git(&repo_dir, &["init"]).await?;
+        run_git(
             &repo_dir,
             &["remote", "add", "origin", &example.spec.repository_url],
         )
@@ -205,26 +230,53 @@ async fn setup_worktree(example: &Example, step_progress: &StepProgress) -> Resu
     }
 
     // Resolve the example to a revision, fetching it if needed.
-    step_progress.set_substatus("fetching");
-    let revision = git::fetch_if_needed(&repo_dir, &example.spec.revision).await?;
+    let revision = run_git(
+        &repo_dir,
+        &[
+            "rev-parse",
+            &format!("{}^{{commit}}", example.spec.revision),
+        ],
+    )
+    .await;
+    let revision = if let Ok(revision) = revision {
+        revision
+    } else {
+        step_progress.set_substatus("fetching");
+        if run_git(
+            &repo_dir,
+            &["fetch", "--depth", "1", "origin", &example.spec.revision],
+        )
+        .await
+        .is_err()
+        {
+            run_git(&repo_dir, &["fetch", "origin"]).await?;
+        }
+        let revision = run_git(&repo_dir, &["rev-parse", "FETCH_HEAD"]).await?;
+        revision
+    };
 
     // Create the worktree for this example if needed.
     step_progress.set_substatus("preparing worktree");
     if worktree_path.is_dir() {
-        git::run_git(&worktree_path, &["clean", "--force", "-d"]).await?;
-        git::run_git(&worktree_path, &["reset", "--hard", "HEAD"]).await?;
-        git::run_git(&worktree_path, &["checkout", revision.as_str()]).await?;
+        run_git(&worktree_path, &["clean", "--force", "-d"]).await?;
+        run_git(&worktree_path, &["reset", "--hard", "HEAD"]).await?;
+        run_git(&worktree_path, &["checkout", revision.as_str()]).await?;
     } else {
         let worktree_path_string = worktree_path.to_string_lossy();
-        let branch_name = example.spec.filename();
-        git::run_git(
+        run_git(
             &repo_dir,
-            &["branch", "-f", &branch_name, revision.as_str()],
+            &["branch", "-f", &example.spec.name, revision.as_str()],
         )
         .await?;
-        git::run_git(
+        run_git(
             &repo_dir,
-            &["worktree", "add", "-f", &worktree_path_string, &branch_name],
+            &[
+                "worktree",
+                "add",
+                "-f",
+                &worktree_path_string,
+                &example.spec.name,
+            ],
         )
         .await?;
     }
@@ -267,3 +319,39 @@ async fn apply_edit_history(
 ) -> Result<OpenedBuffers> {
     edit_prediction::udiff::apply_diff(&example.spec.edit_history, project, cx).await
 }
+
+thread_local! {
+    static REPO_LOCKS: RefCell<HashMap<PathBuf, Arc<Mutex<()>>>> = RefCell::new(HashMap::default());
+}
+
+#[must_use]
+pub async fn lock_repo(path: impl AsRef<Path>) -> OwnedMutexGuard<()> {
+    REPO_LOCKS
+        .with(|cell| {
+            cell.borrow_mut()
+                .entry(path.as_ref().to_path_buf())
+                .or_default()
+                .clone()
+        })
+        .lock_owned()
+        .await
+}
+
+async fn run_git(repo_path: &Path, args: &[&str]) -> Result<String> {
+    let output = smol::process::Command::new("git")
+        .current_dir(repo_path)
+        .args(args)
+        .output()
+        .await?;
+
+    anyhow::ensure!(
+        output.status.success(),
+        "`git {}` within `{}` failed with status: {}\nstderr:\n{}\nstdout:\n{}",
+        args.join(" "),
+        repo_path.display(),
+        output.status,
+        String::from_utf8_lossy(&output.stderr),
+        String::from_utf8_lossy(&output.stdout),
+    );
+    Ok(String::from_utf8(output.stdout)?.trim().to_string())
+}

crates/edit_prediction_cli/src/main.rs

@@ -2,7 +2,6 @@ mod anthropic_client;
 mod distill;
 mod example;
 mod format_prompt;
-mod git;
 mod headless;
 mod load_project;
 mod metrics;
@@ -11,7 +10,6 @@ mod predict;
 mod progress;
 mod retrieve_context;
 mod score;
-mod synthesize;
 
 use clap::{Args, CommandFactory, Parser, Subcommand, ValueEnum};
 use edit_prediction::EditPredictionStore;
@@ -30,7 +28,6 @@ use crate::predict::run_prediction;
 use crate::progress::Progress;
 use crate::retrieve_context::run_context_retrieval;
 use crate::score::run_scoring;
-use crate::synthesize::{SynthesizeConfig, run_synthesize};
 
 #[derive(Parser, Debug)]
 #[command(name = "ep")]
@@ -70,8 +67,6 @@ enum Command {
     Distill,
     /// Print aggregated scores
     Eval(PredictArgs),
-    /// Generate eval examples by analyzing git commits from a repository
-    Synthesize(SynthesizeArgs),
     /// Remove git repositories and worktrees
     Clean,
 }
@@ -123,9 +118,6 @@ impl Display for Command {
                     .unwrap()
                     .get_name()
             ),
-            Command::Synthesize(args) => {
-                write!(f, "synthesize --repo={}", args.repo)
-            }
             Command::Clean => write!(f, "clean"),
         }
     }
@@ -151,7 +143,7 @@ struct PredictArgs {
     repetitions: usize,
 }
 
-#[derive(Clone, Copy, Debug, PartialEq, ValueEnum, Serialize, Deserialize)]
+#[derive(Clone, Copy, Debug, ValueEnum, Serialize, Deserialize)]
 enum PredictionProvider {
     Sweep,
     Mercury,
@@ -161,29 +153,6 @@ enum PredictionProvider {
     TeacherNonBatching,
 }
 
-#[derive(Debug, Args)]
-struct SynthesizeArgs {
-    /// Repository URL (git@github.com:owner/repo or https://...)
-    #[clap(long)]
-    repo: String,
-
-    /// Number of examples to generate
-    #[clap(long, default_value_t = 5)]
-    count: usize,
-
-    /// Maximum commits to scan before giving up
-    #[clap(long, default_value_t = 100)]
-    max_commits: usize,
-
-    /// Only generate examples that require retrieved context to make a correct prediction
-    #[clap(long)]
-    require_context: bool,
-
-    /// Ignore state file and reprocess all commits
-    #[clap(long)]
-    fresh: bool,
-}
-
 impl EpArgs {
     fn output_path(&self) -> Option<PathBuf> {
         if self.in_place {
@@ -220,26 +189,6 @@ fn main() {
             std::fs::remove_dir_all(&*paths::DATA_DIR).unwrap();
             return;
         }
-        Command::Synthesize(synth_args) => {
-            let Some(output_dir) = args.output else {
-                panic!("output dir is required");
-            };
-            let config = SynthesizeConfig {
-                repo_url: synth_args.repo.clone(),
-                count: synth_args.count,
-                max_commits: synth_args.max_commits,
-                output_dir,
-                require_context: synth_args.require_context,
-                fresh: synth_args.fresh,
-            };
-            smol::block_on(async {
-                if let Err(e) = run_synthesize(config).await {
-                    eprintln!("Error: {:?}", e);
-                    std::process::exit(1);
-                }
-            });
-            return;
-        }
         _ => {}
     }
 
@@ -307,7 +256,7 @@ fn main() {
                                         run_scoring(example, &args, app_state.clone(), cx.clone())
                                             .await?;
                                     }
-                                    Command::Clean | Command::Synthesize(_) => {
+                                    Command::Clean => {
                                         unreachable!()
                                     }
                                 }

crates/edit_prediction_cli/src/metrics.rs

@@ -1,17 +1,34 @@
-use collections::HashMap;
+use collections::{HashMap, HashSet};
+use edit_prediction::udiff::DiffLine;
+use serde::{Deserialize, Serialize};
 
 type Counts = HashMap<String, usize>;
 type CountsDelta = HashMap<String, isize>;
 
-#[derive(Default, Debug, Clone)]
-struct ClassificationMetrics {
-    true_positives: usize,
-    false_positives: usize,
-    false_negatives: usize,
+#[derive(Default, Debug, Clone, Serialize, Deserialize)]
+pub struct ClassificationMetrics {
+    pub true_positives: usize,
+    pub false_positives: usize,
+    pub false_negatives: usize,
 }
 
 impl ClassificationMetrics {
-    fn from_counts(expected: &Counts, actual: &Counts) -> ClassificationMetrics {
+    pub fn from_sets(
+        expected: &HashSet<String>,
+        actual: &HashSet<String>,
+    ) -> ClassificationMetrics {
+        let true_positives = expected.intersection(actual).count();
+        let false_positives = actual.difference(expected).count();
+        let false_negatives = expected.difference(actual).count();
+
+        ClassificationMetrics {
+            true_positives,
+            false_positives,
+            false_negatives,
+        }
+    }
+
+    pub fn from_counts(expected: &Counts, actual: &Counts) -> ClassificationMetrics {
         let mut true_positives = 0;
         let mut false_positives = 0;
         let mut false_negatives = 0;
@@ -39,7 +56,27 @@ impl ClassificationMetrics {
         }
     }
 
-    fn precision(&self) -> f64 {
+    pub fn aggregate<'a>(
+        scores: impl Iterator<Item = &'a ClassificationMetrics>,
+    ) -> ClassificationMetrics {
+        let mut true_positives = 0;
+        let mut false_positives = 0;
+        let mut false_negatives = 0;
+
+        for score in scores {
+            true_positives += score.true_positives;
+            false_positives += score.false_positives;
+            false_negatives += score.false_negatives;
+        }
+
+        ClassificationMetrics {
+            true_positives,
+            false_positives,
+            false_negatives,
+        }
+    }
+
+    pub fn precision(&self) -> f64 {
         if self.true_positives + self.false_positives == 0 {
             0.0
         } else {
@@ -47,13 +84,42 @@ impl ClassificationMetrics {
         }
     }
 
-    fn recall(&self) -> f64 {
+    pub fn recall(&self) -> f64 {
         if self.true_positives + self.false_negatives == 0 {
             0.0
         } else {
             self.true_positives as f64 / (self.true_positives + self.false_negatives) as f64
         }
     }
+
+    pub fn f1_score(&self) -> f64 {
+        let recall = self.recall();
+        let precision = self.precision();
+        if precision + recall == 0.0 {
+            0.0
+        } else {
+            2.0 * precision * recall / (precision + recall)
+        }
+    }
+}
+
+pub fn line_match_score(
+    expected_patch: &[DiffLine],
+    actual_patch: &[DiffLine],
+) -> ClassificationMetrics {
+    let expected_change_lines = expected_patch
+        .iter()
+        .filter(|line| matches!(line, DiffLine::Addition(_) | DiffLine::Deletion(_)))
+        .map(|line| line.to_string())
+        .collect();
+
+    let actual_change_lines = actual_patch
+        .iter()
+        .filter(|line| matches!(line, DiffLine::Addition(_) | DiffLine::Deletion(_)))
+        .map(|line| line.to_string())
+        .collect();
+
+    ClassificationMetrics::from_sets(&expected_change_lines, &actual_change_lines)
 }
 
 enum ChrfWhitespace {
@@ -69,26 +135,55 @@ const CHR_F_WHITESPACE: ChrfWhitespace = ChrfWhitespace::Ignore;
 /// Computes a delta-chrF score that compares two sets of edits.
 ///
 /// This metric works by:
-/// 1. Computing n-gram count differences (deltas) between original→expected and original→actual
-/// 2. Comparing these deltas to measure how well actual edits match expected edits
-///
-/// Returns a score from 0.0 to 100.0, where 100.0 means the actual edits perfectly match
-/// the expected edits.
-pub fn delta_chr_f(original: &str, expected: &str, actual: &str) -> f64 {
-    // Edge case: if all texts are identical, the edits match perfectly
-    if original == expected && expected == actual {
+/// 1. Reconstructing original, golden (expected result), and actual texts from diffs
+/// 2. Computing n-gram count differences (deltas) between original→golden and original→actual
+/// 3. Comparing these deltas to measure how well actual edits match expected edits
+pub fn delta_chr_f(expected: &[DiffLine], actual: &[DiffLine]) -> f64 {
+    // Reconstruct texts from diffs
+    let mut original_text = String::new(); // state of the text before any edits
+    let mut golden_text = String::new(); // text after applying golden edits
+    let mut actual_text = String::new(); // text after applying actual edits
+
+    for line in expected {
+        match line {
+            DiffLine::Context(s) => {
+                original_text.push_str(s);
+                golden_text.push_str(s);
+            }
+            DiffLine::Deletion(s) => {
+                original_text.push_str(s);
+            }
+            DiffLine::Addition(s) => {
+                golden_text.push_str(s);
+            }
+            _ => {}
+        }
+    }
+
+    for line in actual {
+        match line {
+            DiffLine::Context(s) | DiffLine::Addition(s) => {
+                actual_text.push_str(s);
+            }
+            _ => {}
+        }
+    }
+
+    // Edge case
+    if original_text == golden_text && golden_text == actual_text {
         return 100.0;
     }
 
-    let original_ngrams = chr_f_ngram_counts(original);
-    let expected_ngrams = chr_f_ngram_counts(expected);
-    let actual_ngrams = chr_f_ngram_counts(actual);
+    // Compute the metric
+    let original_ngrams = chr_f_ngram_counts(&original_text);
+    let golden_ngrams = chr_f_ngram_counts(&golden_text);
+    let actual_ngrams = chr_f_ngram_counts(&actual_text);
 
     let mut total_precision = 0.0;
     let mut total_recall = 0.0;
 
     for order in 0..CHR_F_CHAR_ORDER {
-        let expected_delta = compute_ngram_delta(&expected_ngrams[order], &original_ngrams[order]);
+        let expected_delta = compute_ngram_delta(&golden_ngrams[order], &original_ngrams[order]);
         let actual_delta = compute_ngram_delta(&actual_ngrams[order], &original_ngrams[order]);
 
         if expected_delta.is_empty() && actual_delta.is_empty() {
@@ -160,7 +255,7 @@ fn ngram_delta_to_counts(delta: &CountsDelta) -> Counts {
     for (ngram, &delta) in delta {
         if delta > 0 {
             counts.insert(ngram.clone(), delta as usize);
-        } else if delta < 0 {
+        } else {
             counts.insert(format!("¬{ngram}"), delta.unsigned_abs());
         }
     }
@@ -183,68 +278,94 @@ fn count_ngrams(text: &str, n: usize) -> Counts {
 #[cfg(test)]
 mod test {
     use super::*;
+    use edit_prediction::udiff::DiffLine;
 
     #[test]
     fn test_delta_chr_f_perfect_match() {
-        let original = "fn main() {    println!(\"Hello\");}";
-        let expected = "fn main() {    println!(\"Hello, World!\");}";
+        let diff = vec![
+            DiffLine::Context("fn main() {"),
+            DiffLine::Deletion("    println!(\"Hello\");"),
+            DiffLine::Addition("    println!(\"Hello, World!\");"),
+            DiffLine::Context("}"),
+        ];
 
-        let score = delta_chr_f(original, expected, expected);
+        let score = delta_chr_f(&diff, &diff);
         assert!((score - 100.0).abs() < 1e-2);
     }
 
     #[test]
     fn test_delta_chr_f_wrong_edit() {
         // When the edit is wrong
-        let original = "one two three";
-        let expected = "one three"; // deleted "two "
-        let actual = "one two four"; // deleted "three", added "four"
+        let expected = vec![
+            DiffLine::Context("one "),
+            DiffLine::Deletion("two "),
+            DiffLine::Context("three"),
+        ];
+
+        let actual = vec![
+            DiffLine::Context("one "),
+            DiffLine::Context("two "),
+            DiffLine::Deletion("three"),
+            DiffLine::Addition("four"),
+        ];
 
         // Then the score should be low
-        let score = delta_chr_f(original, expected, actual);
+        let score = delta_chr_f(&expected, &actual);
         assert!(score > 20.0 && score < 40.0);
     }
 
     #[test]
     fn test_delta_chr_f_partial_match() {
-        let original = "let x = 42;";
-        let expected = "let x = 100;";
-        let actual = "let x = 99;";
+        let expected = vec![
+            DiffLine::Deletion("let x = 42;"),
+            DiffLine::Addition("let x = 100;"),
+        ];
+
+        let actual = vec![
+            DiffLine::Deletion("let x = 42;"),
+            DiffLine::Addition("let x = 99;"),
+        ];
 
         // We got the edit location right, but the replacement text is wrong.
         // Deleted ngrams will match, bringing the score somewhere in the middle.
-        let score = delta_chr_f(original, expected, actual);
+        let score = delta_chr_f(&expected, &actual);
         assert!(score > 40.0 && score < 60.0);
     }
 
     #[test]
     fn test_delta_chr_f_missed_edit() {
         // When predictions makes no changes
-        let original = "prefix old suffix";
-        let expected = "prefix new suffix";
-        let actual = "prefix old suffix"; // no change
+        let expected = vec![
+            DiffLine::Context("prefix "),
+            DiffLine::Deletion("old"),
+            DiffLine::Addition("new"),
+            DiffLine::Context(" suffix"),
+        ];
+
+        let actual = vec![
+            DiffLine::Context("prefix "),
+            DiffLine::Context("old"),
+            DiffLine::Context(" suffix"),
+        ];
 
         // Then the score should be low (all expected changes are false negatives)
-        let score = delta_chr_f(original, expected, actual);
+        let score = delta_chr_f(&expected, &actual);
         assert!(score < 20.0);
     }
 
     #[test]
     fn test_delta_chr_f_extra_edit() {
         // When adding unexpected content
-        let original = "helloworld";
-        let expected = "helloworld"; // no change expected
-        let actual = "helloextraworld"; // added "extra"
+        let expected = vec![DiffLine::Context("hello"), DiffLine::Context("world")];
+
+        let actual = vec![
+            DiffLine::Context("hello"),
+            DiffLine::Addition("extra"),
+            DiffLine::Context("world"),
+        ];
 
         // Then the score should be low (all actual changes are false positives)
-        let score = delta_chr_f(original, expected, actual);
+        let score = delta_chr_f(&expected, &actual);
         assert!(score < 20.0);
     }
-
-    #[test]
-    fn test_delta_chr_f_no_changes() {
-        let text = "unchanged text";
-        let score = delta_chr_f(text, text, text);
-        assert!((score - 100.0).abs() < 1e-2);
-    }
 }

crates/edit_prediction_cli/src/paths.rs

@@ -17,11 +17,7 @@ pub static RUN_DIR: LazyLock<PathBuf> = LazyLock::new(|| {
         .join(chrono::Local::now().format("%d-%m-%y-%H_%M_%S").to_string())
 });
 pub static LATEST_EXAMPLE_RUN_DIR: LazyLock<PathBuf> = LazyLock::new(|| DATA_DIR.join("latest"));
-pub static LATEST_FAILED_EXAMPLES_DIR: LazyLock<PathBuf> =
-    LazyLock::new(|| DATA_DIR.join("latest_failed"));
 pub static LLM_CACHE_DB: LazyLock<PathBuf> = LazyLock::new(|| CACHE_DIR.join("llm_cache.sqlite"));
-pub static SYNTHESIZE_STATE_FILE: LazyLock<PathBuf> =
-    LazyLock::new(|| DATA_DIR.join("synthesize_state.json"));
 pub static FAILED_EXAMPLES_DIR: LazyLock<PathBuf> =
     LazyLock::new(|| ensure_dir(&RUN_DIR.join("failed")));