return step xml tags to workflow prompt

.github/workflows/ci.yml

@@ -167,7 +167,6 @@ jobs:
       APPLE_NOTARIZATION_USERNAME: ${{ secrets.APPLE_NOTARIZATION_USERNAME }}
       APPLE_NOTARIZATION_PASSWORD: ${{ secrets.APPLE_NOTARIZATION_PASSWORD }}
       ZED_CLIENT_CHECKSUM_SEED: ${{ secrets.ZED_CLIENT_CHECKSUM_SEED }}
-      ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON: ${{ secrets.ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON }}
       DIGITALOCEAN_SPACES_ACCESS_KEY: ${{ secrets.DIGITALOCEAN_SPACES_ACCESS_KEY }}
       DIGITALOCEAN_SPACES_SECRET_KEY: ${{ secrets.DIGITALOCEAN_SPACES_SECRET_KEY }}
     steps:
@@ -277,7 +276,6 @@ jobs:
     needs: [linux_tests]
     env:
       ZED_CLIENT_CHECKSUM_SEED: ${{ secrets.ZED_CLIENT_CHECKSUM_SEED }}
-      ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON: ${{ secrets.ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON }}
     steps:
       - name: Add Rust to the PATH
         run: echo "$HOME/.cargo/bin" >> $GITHUB_PATH
@@ -348,7 +346,6 @@ jobs:
     needs: [linux_tests]
     env:
       ZED_CLIENT_CHECKSUM_SEED: ${{ secrets.ZED_CLIENT_CHECKSUM_SEED }}
-      ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON: ${{ secrets.ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4

.github/workflows/release_actions.yml

@@ -16,7 +16,7 @@ jobs:
           fi
           echo "::set-output name=URL::$URL"
       - name: Get content
-        uses: 2428392/gh-truncate-string-action@e6b5885fb83c81ca9a700a91b079baec2133be3e # v1.4.0
+        uses: 2428392/gh-truncate-string-action@67b1b814955634208b103cff064be3cb1c7a19be # v1.3.0
         id: get-content
         with:
           stringToTruncate: |

.github/workflows/release_nightly.yml

@@ -67,7 +67,6 @@ jobs:
       DIGITALOCEAN_SPACES_ACCESS_KEY: ${{ secrets.DIGITALOCEAN_SPACES_ACCESS_KEY }}
       DIGITALOCEAN_SPACES_SECRET_KEY: ${{ secrets.DIGITALOCEAN_SPACES_SECRET_KEY }}
       ZED_CLIENT_CHECKSUM_SEED: ${{ secrets.ZED_CLIENT_CHECKSUM_SEED }}
-      ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON: ${{ secrets.ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON }}
     steps:
       - name: Install Node
         uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4
@@ -107,7 +106,6 @@ jobs:
       DIGITALOCEAN_SPACES_ACCESS_KEY: ${{ secrets.DIGITALOCEAN_SPACES_ACCESS_KEY }}
       DIGITALOCEAN_SPACES_SECRET_KEY: ${{ secrets.DIGITALOCEAN_SPACES_SECRET_KEY }}
       ZED_CLIENT_CHECKSUM_SEED: ${{ secrets.ZED_CLIENT_CHECKSUM_SEED }}
-      ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON: ${{ secrets.ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4
@@ -141,7 +139,6 @@ jobs:
       DIGITALOCEAN_SPACES_ACCESS_KEY: ${{ secrets.DIGITALOCEAN_SPACES_ACCESS_KEY }}
       DIGITALOCEAN_SPACES_SECRET_KEY: ${{ secrets.DIGITALOCEAN_SPACES_SECRET_KEY }}
       ZED_CLIENT_CHECKSUM_SEED: ${{ secrets.ZED_CLIENT_CHECKSUM_SEED }}
-      ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON: ${{ secrets.ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4

.zed/tasks.json

@@ -3,10 +3,5 @@
     "label": "clippy",
     "command": "./script/clippy",
     "args": []
-  },
-  {
-    "label": "cargo run --profile release-fast",
-    "command": "cargo",
-    "args": ["run", "--profile", "release-fast"]
   }
 ]

Cargo.lock

@@ -223,7 +223,6 @@ name = "anthropic"
 version = "0.1.0"
 dependencies = [
  "anyhow",
- "chrono",
  "futures 0.3.30",
  "http_client",
  "isahc",
@@ -233,7 +232,6 @@ dependencies = [
  "strum",
  "thiserror",
  "tokio",
- "util",
 ]
 
 [[package]]
@@ -360,7 +358,6 @@ dependencies = [
  "clock",
  "collections",
  "command_palette_hooks",
- "context_servers",
  "ctor",
  "db",
  "editor",
@@ -369,7 +366,6 @@ dependencies = [
  "fs",
  "futures 0.3.30",
  "fuzzy",
- "globset",
  "gpui",
  "handlebars",
  "heed",
@@ -401,7 +397,6 @@ dependencies = [
  "serde_json",
  "serde_json_lenient",
  "settings",
- "similar",
  "smallvec",
  "smol",
  "telemetry_events",
@@ -796,9 +791,9 @@ dependencies = [
 
 [[package]]
 name = "async-stripe"
-version = "0.38.1"
+version = "0.37.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "97ddaa6999d246ba2c6c84d830a1ba0cd16c9234d58701988b3869f0e5bd732d"
+checksum = "e2f14b5943a52cf051bbbbb68538e93a69d1e291934174121e769f4b181113f5"
 dependencies = [
  "chrono",
  "futures-util",
@@ -988,9 +983,9 @@ dependencies = [
 
 [[package]]
 name = "aws-config"
-version = "1.5.5"
+version = "1.5.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "4e95816a168520d72c0e7680c405a5a8c1fb6a035b4bc4b9d7b0de8e1a941697"
+checksum = "caf6cfe2881cb1fcbba9ae946fb9a6480d3b7a714ca84c74925014a89ef3387a"
 dependencies = [
  "aws-credential-types",
  "aws-runtime",
@@ -1008,6 +1003,7 @@ dependencies = [
  "fastrand 2.1.0",
  "hex",
  "http 0.2.12",
+ "hyper",
  "ring",
  "time",
  "tokio",
@@ -1030,9 +1026,9 @@ dependencies = [
 
 [[package]]
 name = "aws-runtime"
-version = "1.4.0"
+version = "1.3.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f42c2d4218de4dcd890a109461e2f799a1a2ba3bcd2cde9af88360f5df9266c6"
+checksum = "87c5f920ffd1e0526ec9e70e50bf444db50b204395a0fa7016bbf9e31ea1698f"
 dependencies = [
  "aws-credential-types",
  "aws-sigv4",
@@ -1046,7 +1042,6 @@ dependencies = [
  "fastrand 2.1.0",
  "http 0.2.12",
  "http-body 0.4.6",
- "once_cell",
  "percent-encoding",
  "pin-project-lite",
  "tracing",
@@ -1055,9 +1050,9 @@ dependencies = [
 
 [[package]]
 name = "aws-sdk-s3"
-version = "1.43.0"
+version = "1.42.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "9ccda7e730ace3cb8bbd4071bc650c6d294364891f9564bd4e43adfc8dea3177"
+checksum = "558bbcec8db82a1a8af1610afcb3b10d00652d25ad366a0558eecdff2400a1d1"
 dependencies = [
  "ahash 0.8.11",
  "aws-credential-types",
@@ -1090,9 +1085,9 @@ dependencies = [
 
 [[package]]
 name = "aws-sdk-sso"
-version = "1.37.0"
+version = "1.36.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1074e818fbe4f9169242d78448b15be8916a79daa38ea1231f2e2e10d993fcd2"
+checksum = "6acca681c53374bf1d9af0e317a41d12a44902ca0f2d1e10e5cb5bb98ed74f35"
 dependencies = [
  "aws-credential-types",
  "aws-runtime",
@@ -1112,9 +1107,9 @@ dependencies = [
 
 [[package]]
 name = "aws-sdk-ssooidc"
-version = "1.38.0"
+version = "1.37.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "29755c51e33fa3f678598f64324a169cf4b7d3c4865d2709d4308f53366a92a4"
+checksum = "b79c6bdfe612503a526059c05c9ccccbf6bd9530b003673cb863e547fd7c0c9a"
 dependencies = [
  "aws-credential-types",
  "aws-runtime",
@@ -1134,9 +1129,9 @@ dependencies = [
 
 [[package]]
 name = "aws-sdk-sts"
-version = "1.37.0"
+version = "1.36.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6e52dc3fd7dfa6c01a69cf3903e00aa467261639138a05b06cd92314d2c8fb07"
+checksum = "32e6ecdb2bd756f3b2383e6f0588dc10a4e65f5d551e70a56e0bfe0c884673ce"
 dependencies = [
  "aws-credential-types",
  "aws-runtime",
@@ -1197,9 +1192,9 @@ dependencies = [
 
 [[package]]
 name = "aws-smithy-checksums"
-version = "0.60.12"
+version = "0.60.11"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "598b1689d001c4d4dc3cb386adb07d37786783aee3ac4b324bcadac116bf3d23"
+checksum = "48c4134cf3adaeacff34d588dbe814200357b0c466d730cf1c0d8054384a2de4"
 dependencies = [
  "aws-smithy-http",
  "aws-smithy-types",
@@ -1296,9 +1291,9 @@ dependencies = [
 
 [[package]]
 name = "aws-smithy-runtime-api"
-version = "1.7.2"
+version = "1.7.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "e086682a53d3aa241192aa110fa8dfce98f2f5ac2ead0de84d41582c7e8fdb96"
+checksum = "30819352ed0a04ecf6a2f3477e344d2d1ba33d43e0f09ad9047c12e0d923616f"
 dependencies = [
  "aws-smithy-async",
  "aws-smithy-types",
@@ -2211,9 +2206,9 @@ dependencies = [
 
 [[package]]
 name = "clap"
-version = "4.5.15"
+version = "4.5.13"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "11d8838454fda655dafd3accb2b6e2bea645b9e4078abe84a22ceb947235c5cc"
+checksum = "0fbb260a053428790f3de475e304ff84cdbc4face759ea7a3e64c1edd938a7fc"
 dependencies = [
  "clap_builder",
  "clap_derive",
@@ -2221,9 +2216,9 @@ dependencies = [
 
 [[package]]
 name = "clap_builder"
-version = "4.5.15"
+version = "4.5.13"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "216aec2b177652e3846684cbfe25c9964d18ec45234f0f5da5157b207ed1aab6"
+checksum = "64b17d7ea74e9f833c7dbf2cbe4fb12ff26783eda4782a8975b72f895c9b4d99"
 dependencies = [
  "anstream",
  "anstyle",
@@ -2673,27 +2668,6 @@ dependencies = [
  "tiny-keccak",
 ]
 
-[[package]]
-name = "context_servers"
-version = "0.1.0"
-dependencies = [
- "anyhow",
- "collections",
- "futures 0.3.30",
- "gpui",
- "log",
- "parking_lot",
- "postage",
- "schemars",
- "serde",
- "serde_json",
- "settings",
- "smol",
- "url",
- "util",
- "workspace",
-]
-
 [[package]]
 name = "convert_case"
 version = "0.4.0"
@@ -2762,9 +2736,9 @@ dependencies = [
 
 [[package]]
 name = "core-foundation-sys"
-version = "0.8.7"
+version = "0.8.6"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "773648b94d0e5d620f64f280777445740e61fe701025087ec8b57f45c791888b"
+checksum = "06ea2b9bc92be3c2baa9334a323ebca2d6f074ff852cd1d7b11064035cd3868f"
 
 [[package]]
 name = "core-graphics"
@@ -3167,12 +3141,12 @@ dependencies = [
 
 [[package]]
 name = "ctrlc"
-version = "3.4.5"
+version = "3.4.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "90eeab0aa92f3f9b4e87f258c72b139c207d251f9cbc1080a0086b86a8870dd3"
+checksum = "672465ae37dc1bc6380a6547a8883d5dd397b0f1faaad4f265726cc7042a5345"
 dependencies = [
- "nix 0.29.0",
- "windows-sys 0.59.0",
+ "nix 0.28.0",
+ "windows-sys 0.52.0",
 ]
 
 [[package]]
@@ -5059,9 +5033,9 @@ checksum = "2304e00983f87ffb38b55b444b5e3b60a884b5d30c0fca7d82fe33449bbe55ea"
 
 [[package]]
 name = "heed"
-version = "0.20.5"
+version = "0.20.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7d4f449bab7320c56003d37732a917e18798e2f1709d80263face2b4f9436ddb"
+checksum = "2bc30da4a93ff8cb98e535d595d6de42731d4719d707bc1c86f579158751a24e"
 dependencies = [
  "bitflags 2.6.0",
  "byteorder",
@@ -6246,18 +6220,18 @@ dependencies = [
 
 [[package]]
 name = "linkme"
-version = "0.3.28"
+version = "0.3.27"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3c943daedff228392b791b33bba32e75737756e80a613e32e246c6ce9cbab20a"
+checksum = "ccb76662d78edc9f9bf56360d6919bdacc8b7761227727e5082f128eeb90bbf5"
 dependencies = [
  "linkme-impl",
 ]
 
 [[package]]
 name = "linkme-impl"
-version = "0.3.28"
+version = "0.3.27"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "cb26336e6dc7cc76e7927d2c9e7e3bb376d7af65a6f56a0b16c47d18a9b1abc5"
+checksum = "f8dccda732e04fa3baf2e17cf835bfe2601c7c2edafd64417c627dabae3a8cda"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -6316,9 +6290,9 @@ dependencies = [
 
 [[package]]
 name = "lmdb-master-sys"
-version = "0.2.4"
+version = "0.2.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "472c3760e2a8d0f61f322fb36788021bb36d573c502b50fa3e2bcaac3ec326c9"
+checksum = "57640c190703d5ccf4a86aff4aeb749b2d287a8cb1723c76b51f39d77ab53b24"
 dependencies = [
  "cc",
  "doxygen-rs",
@@ -7592,29 +7566,6 @@ version = "2.3.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "e3148f5046208a5d56bcfc03053e3ca6334e51da8dfb19b6cdc8b306fae3283e"
 
-[[package]]
-name = "performance"
-version = "0.1.0"
-dependencies = [
- "anyhow",
- "collections",
- "gpui",
- "log",
- "schemars",
- "serde",
- "settings",
- "util",
- "workspace",
-]
-
-[[package]]
-name = "perplexity"
-version = "0.1.0"
-dependencies = [
- "serde",
- "zed_extension_api 0.1.0",
-]
-
 [[package]]
 name = "pest"
 version = "2.7.11"
@@ -9058,9 +9009,9 @@ dependencies = [
 
 [[package]]
 name = "runtimelib"
-version = "0.15.0"
+version = "0.14.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a7d76d28b882a7b889ebb04e79bc2b160b3061821ea596ff0f4a838fc7a76db0"
+checksum = "0c3d817764e3971867351e6103955b17d808f5330e9ef63aaaaab55bf8c664c1"
 dependencies = [
  "anyhow",
  "async-dispatcher",
@@ -9582,18 +9533,18 @@ dependencies = [
 
 [[package]]
 name = "serde"
-version = "1.0.207"
+version = "1.0.204"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5665e14a49a4ea1b91029ba7d3bca9f299e1f7cfa194388ccc20f14743e784f2"
+checksum = "bc76f558e0cbb2a839d37354c575f1dc3fdc6546b5be373ba43d95f231bf7c12"
 dependencies = [
  "serde_derive",
 ]
 
 [[package]]
 name = "serde_derive"
-version = "1.0.207"
+version = "1.0.204"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6aea2634c86b0e8ef2cfdc0c340baede54ec27b1e46febd7f80dffb2aa44a00e"
+checksum = "e0cd7e117be63d3c3678776753929474f3b04a43a080c744d6b0ae2a8c28e222"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -9633,9 +9584,9 @@ dependencies = [
 
 [[package]]
 name = "serde_json"
-version = "1.0.125"
+version = "1.0.122"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "83c8e735a073ccf5be70aa8066aa984eaf2fa000db6c8d0100ae605b366d31ed"
+checksum = "784b6203951c57ff748476b126ccb5e8e2959a5c19e5c617ab1956be3dbc68da"
 dependencies = [
  "indexmap 2.3.0",
  "itoa",
@@ -9969,13 +9920,6 @@ dependencies = [
  "autocfg",
 ]
 
-[[package]]
-name = "slash_commands_example"
-version = "0.1.0"
-dependencies = [
- "zed_extension_api 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)",
-]
-
 [[package]]
 name = "slice-group-by"
 version = "0.3.1"
@@ -10565,7 +10509,6 @@ dependencies = [
  "theme",
  "ui",
  "util",
- "windows 0.58.0",
 ]
 
 [[package]]
@@ -13839,7 +13782,7 @@ dependencies = [
 
 [[package]]
 name = "zed"
-version = "0.151.0"
+version = "0.149.0"
 dependencies = [
  "activity_indicator",
  "anyhow",
@@ -13900,7 +13843,6 @@ dependencies = [
  "outline_panel",
  "parking_lot",
  "paths",
- "performance",
  "profiling",
  "project",
  "project_panel",
@@ -13988,7 +13930,7 @@ dependencies = [
 
 [[package]]
 name = "zed_elixir"
-version = "0.0.8"
+version = "0.0.7"
 dependencies = [
  "zed_extension_api 0.0.6",
 ]
@@ -14034,23 +13976,12 @@ dependencies = [
  "wit-bindgen",
 ]
 
-[[package]]
-name = "zed_extension_api"
-version = "0.1.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "594fd10dd0f2f853eb243e2425e7c95938cef49adb81d9602921d002c5e6d9d9"
-dependencies = [
- "serde",
- "serde_json",
- "wit-bindgen",
-]
-
 [[package]]
 name = "zed_gleam"
-version = "0.2.0"
+version = "0.1.3"
 dependencies = [
  "html_to_markdown 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)",
- "zed_extension_api 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)",
+ "zed_extension_api 0.1.0",
 ]
 
 [[package]]
@@ -14062,7 +13993,7 @@ dependencies = [
 
 [[package]]
 name = "zed_haskell"
-version = "0.1.1"
+version = "0.1.0"
 dependencies = [
  "zed_extension_api 0.0.6",
 ]
@@ -14176,9 +14107,9 @@ dependencies = [
 
 [[package]]
 name = "zed_zig"
-version = "0.2.0"
+version = "0.1.5"
 dependencies = [
- "zed_extension_api 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)",
+ "zed_extension_api 0.0.6",
 ]
 
 [[package]]

Cargo.toml

@@ -19,7 +19,6 @@ members = [
     "crates/collections",
     "crates/command_palette",
     "crates/command_palette_hooks",
-    "crates/context_servers",
     "crates/copilot",
     "crates/db",
     "crates/dev_server_projects",
@@ -70,7 +69,6 @@ members = [
     "crates/outline",
     "crates/outline_panel",
     "crates/paths",
-    "crates/performance",
     "crates/picker",
     "crates/prettier",
     "crates/project",
@@ -146,12 +144,10 @@ members = [
     "extensions/lua",
     "extensions/ocaml",
     "extensions/php",
-    "extensions/perplexity",
     "extensions/prisma",
     "extensions/purescript",
     "extensions/ruff",
     "extensions/ruby",
-    "extensions/slash-commands-example",
     "extensions/snippets",
     "extensions/svelte",
     "extensions/terraform",
@@ -193,7 +189,6 @@ collab_ui = { path = "crates/collab_ui" }
 collections = { path = "crates/collections" }
 command_palette = { path = "crates/command_palette" }
 command_palette_hooks = { path = "crates/command_palette_hooks" }
-context_servers = { path = "crates/context_servers" }
 copilot = { path = "crates/copilot" }
 db = { path = "crates/db" }
 dev_server_projects = { path = "crates/dev_server_projects" }
@@ -243,7 +238,6 @@ open_ai = { path = "crates/open_ai" }
 outline = { path = "crates/outline" }
 outline_panel = { path = "crates/outline_panel" }
 paths = { path = "crates/paths" }
-performance = { path = "crates/performance" }
 picker = { path = "crates/picker" }
 plugin = { path = "crates/plugin" }
 plugin_macros = { path = "crates/plugin_macros" }
@@ -383,7 +377,7 @@ rand = "0.8.5"
 regex = "1.5"
 repair_json = "0.1.0"
 rsa = "0.9.6"
-runtimelib = { version = "0.15", default-features = false, features = [
+runtimelib = { version = "0.14", default-features = false, features = [
     "async-dispatcher-runtime",
 ] }
 rusqlite = { version = "0.29.0", features = ["blob", "array", "modern_sqlite"] }
@@ -467,7 +461,7 @@ which = "6.0.0"
 wit-component = "0.201"
 
 [workspace.dependencies.async-stripe]
-version = "0.38"
+version = "0.37"
 default-features = false
 features = [
     "runtime-tokio-hyper-rustls",

assets/icons/ai_anthropic_hosted.svg

@@ -1,12 +0,0 @@
-<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
-<rect width="16" height="16" rx="2" fill="black" fill-opacity="0.2"/>
-<g clip-path="url(#clip0_1916_18)">
-<path d="M10.652 3.79999H8.816L12.164 12.2H14L10.652 3.79999Z" fill="#1F1F1E"/>
-<path d="M5.348 3.79999L2 12.2H3.872L4.55672 10.436H8.05927L8.744 12.2H10.616L7.268 3.79999H5.348ZM5.16224 8.87599L6.308 5.92399L7.45374 8.87599H5.16224Z" fill="#1F1F1E"/>
-</g>
-<defs>
-<clipPath id="clip0_1916_18">
-<rect width="12" height="8.4" fill="white" transform="translate(2 3.79999)"/>
-</clipPath>
-</defs>
-</svg>

assets/icons/database_zap.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="lucide lucide-database-zap"><ellipse cx="12" cy="5" rx="9" ry="3"/><path d="M3 5V19A9 3 0 0 0 15 21.84"/><path d="M21 5V8"/><path d="M21 12L18 17H22L19 22"/><path d="M3 12A9 3 0 0 0 14.59 14.87"/></svg>

assets/icons/ellipsis_vertical.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="lucide lucide-ellipsis-vertical"><circle cx="12" cy="12" r="1"/><circle cx="12" cy="5" r="1"/><circle cx="12" cy="19" r="1"/></svg>

assets/icons/magic_wand.svg

@@ -0,0 +1,10 @@
+<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
+    <path d="M3 13L7.01562 8.98438" stroke="black" stroke-width="1.5" stroke-linecap="round"/>
+    <path d="M8.6875 7.3125L9.5 6.5" stroke="black" stroke-width="1.5" stroke-linecap="round"/>
+    <path d="M7 5V3" stroke="black" stroke-width="1.5" stroke-linecap="round"/>
+    <path d="M12 5V3" stroke="black" stroke-width="1.5" stroke-linecap="round"/>
+    <path d="M12 10V8" stroke="black" stroke-width="1.5" stroke-linecap="round"/>
+    <path d="M6 4L8 4" stroke="black" stroke-width="1.5" stroke-linecap="round"/>
+    <path d="M11 4L13 4" stroke="black" stroke-width="1.5" stroke-linecap="round"/>
+    <path d="M11 9L13 9" stroke="black" stroke-width="1.5" stroke-linecap="round"/>
+</svg>

assets/icons/search_code.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="lucide lucide-search-code"><path d="m13 13.5 2-2.5-2-2.5"/><path d="m21 21-4.3-4.3"/><path d="M9 8.5 7 11l2 2.5"/><circle cx="11" cy="11" r="8"/></svg>

assets/icons/slash.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="lucide lucide-slash"><path d="M22 2 2 22"/></svg>

assets/icons/slash_square.svg

@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" class="lucide lucide-square-slash"><rect width="18" height="18" x="3" y="3" rx="2"/><line x1="9" x2="15" y1="15" y2="9"/></svg>

assets/keymaps/default-macos.json

@@ -89,9 +89,9 @@
       "alt-right": "editor::MoveToNextWordEnd",
       "alt-f": "editor::MoveToNextWordEnd",
       "cmd-left": "editor::MoveToBeginningOfLine",
-      "ctrl-a": "editor::MoveToBeginningOfLine",
+      "ctrl-a": ["editor::MoveToBeginningOfLine", { "stop_at_soft_wraps": false }],
       "cmd-right": "editor::MoveToEndOfLine",
-      "ctrl-e": "editor::MoveToEndOfLine",
+      "ctrl-e": ["editor::MoveToEndOfLine", { "stop_at_soft_wraps": false }],
       "cmd-up": "editor::MoveToBeginning",
       "cmd-down": "editor::MoveToEnd",
       "shift-up": "editor::SelectUp",

assets/prompts/content_prompt.hbs

@@ -1,13 +1,5 @@
 {{#if language_name}}
-Here's a file of {{language_name}} that I'm going to ask you to make an edit to.
-{{else}}
-Here's a file of text that I'm going to ask you to make an edit to.
-{{/if}}
-
-{{#if is_insert}}
-The point you'll need to insert at is marked with <insert_here></insert_here>.
-{{else}}
-The section you'll need to rewrite is marked with <rewrite_this></rewrite_this> tags.
+File language: {{language_name}}
 {{/if}}
 
 <document>
@@ -15,47 +7,35 @@ The section you'll need to rewrite is marked with <rewrite_this></rewrite_this>
 </document>
 
 {{#if is_truncated}}
-The context around the relevant section has been truncated (possibly in the middle of a line) for brevity.
+Note: Context around the relevant section has been truncated for brevity.
 {{/if}}
 
-{{#if is_insert}}
-You can't replace {{content_type}}, your answer will be inserted in place of the `<insert_here></insert_here>` tags. Don't include the insert_here tags in your output.
-
-Generate {{content_type}} based on the following prompt:
-
+Editing instructions:
+1. Rewrite the section marked with <rewrite_this></rewrite_this> tags based on this prompt:
 <prompt>
 {{{user_prompt}}}
 </prompt>
 
-Match the indentation in the original file in the inserted {{content_type}}, don't include any indentation on blank lines.
-
-Immediately start with the following format with no remarks:
-
-```
-\{{INSERTED_CODE}}
-```
-{{else}}
-Edit the section of {{content_type}} in <rewrite_this></rewrite_this> tags based on the following prompt:
-
-<prompt>
-{{{user_prompt}}}
-</prompt>
-
-{{#if rewrite_section}}
-And here's the section to rewrite based on that prompt again for reference:
+2. Within <rewrite_this></rewrite_this>, make changes only in these subsections:
+   {{#if has_insertion}}
+   - Insert text where marked with <insert_here></insert_here> tags
+   {{/if}}
+   {{#if has_replacement}}
+   - Edit text surrounded by <edit_here></edit_here> tags
+   {{/if}}
 
+3. Section to edit:
 <rewrite_this>
-{{{rewrite_section}}}
+{{{rewrite_section_with_selections}}}
 </rewrite_this>
-{{/if}}
 
-Only make changes that are necessary to fulfill the prompt, leave everything else as-is. All surrounding {{content_type}} will be preserved.
+4. Guidelines:
+   - Only make changes necessary to fulfill the prompt
+   - Preserve all surrounding {{content_type}}
+   - Maintain the original indentation level
+   - Rewrite the entire section, even if no changes are needed
+   - Do not include <rewrite_this>, <insert_here>, or <edit_here> tags in your output
 
-Start at the indentation level in the original file in the rewritten {{content_type}}. Don't stop until you've rewritten the entire section, even if you have no more changes to make, always write out the whole section with no unnecessary elisions.
-
-Immediately start with the following format with no remarks:
-
-```
-\{{REWRITTEN_CODE}}
-```
-{{/if}}
+Output format:
+Immediately start with the following, ensuring no leading whitespace:
+```{{REWRITTEN_CODE}}```

assets/prompts/edit_workflow.hbs

@@ -1,20 +1,14 @@
 <workflow>
 Guide the user through code changes in numbered steps that focus on individual functions, type definitions, etc.
-Surround each distinct step in a <step></step> XML tag. The user will be performing these steps in a code editor
-named Zed, which is where they will have entered this prompt and will be seeing the response.
+Surround each distinct step in a <step></step> XML tag.
 
 <instructions>
 - Use the language of the file for code fence blocks unless otherwise specified.
 - Include a code or file action in each step.
-- Only put code in separate steps if it should either go in separate files, or in different (non-contiguous) places in the same file.
 - Provide error handling and input validation where appropriate.
 - Adapt explanations based on the user's perceived level of expertise.
 - Include comments in code examples to enhance understanding.
 - Consider more complex programming scenarios when relevant.
-- Avoid using the terminal to perform filesystem operations such as creating, deleting, renaming, and editing files. Assume the user prefers to use Zed for these operations, unless the prompt suggests that the user is expecting terminal commands.
-- When creating a new file, Zed will automatically create any necessary directories in that file's path. So when a step will create a new file in Zed, don't mention needing to create the directory that it will go in.
-- Assume the user is performing these actions in the Zed code editor, so avoid redundancies like "In your code editor, ..." or "In Zed, ..."
-- Be concise without leaving out important information.
 </instructions>
 
 Examples of user-assistant dialogs with step numbers and user follow-up requests:
@@ -205,14 +199,13 @@ func NewPerson(name string, age int, email string) (*Person, error) {
     return &Person{Name: name, Age: age, Email: email}, nil
 }
 ```
-</step>
-<step>Implement the Greet method for the Person struct
+
+Implement the Greet method for the Person struct
 ```go
 func (p *Person) Greet() string {
     return fmt.Sprintf("Hello, I'm %s, %d years old. You can reach me at %s.", p.Name, p.Age, p.Email)
 }
 ```
-</step>
 
 This code defines a Person struct, a NewPerson function with age validation, and a Greet method.</assistant>
 </turn>

assets/prompts/step_resolution.hbs

@@ -1,28 +1,22 @@
-<overview>
-Your task is to map a step from a workflow to locations in source code where code needs to be changed to fulfill that step.
-Given a workflow containing background context plus a series of <step> tags, you will resolve *one* of these step tags to resolve to one or more locations in the code.
-With each location, you will produce a brief, one-line description of the changes to be made.
+Your task is to map a step from the conversation above to suggestions on symbols inside the provided source files.
 
-<guidelines>
+Guidelines:
 - There's no need to describe *what* to do, just *where* to do it.
-- Only reference locations that actually exist (unless you're creating a file).
 - If creating a file, assume any subsequent updates are included at the time of creation.
-- Don't create and then update a file. Always create new files in shot.
+- Don't create and then update a file.
+- We'll create it in one shot.
 - Prefer updating symbols lower in the syntax tree if possible.
 - Never include suggestions on a parent symbol and one of its children in the same suggestions block.
 - Never nest an operation with another operation or include CDATA or other content. All suggestions are leaf nodes.
+- Include a description attribute for each operation with a brief, one-line description of the change to perform.
 - Descriptions are required for all suggestions except delete.
 - When generating multiple suggestions, ensure the descriptions are specific to each individual operation.
 - Avoid referring to the location in the description. Focus on the change to be made, not the location where it's made. That's implicit with the symbol you provide.
 - Don't generate multiple suggestions at the same location. Instead, combine them together in a single operation with a succinct combined description.
-- To add imports respond with a suggestion where the `"symbol"` key is set to `"#imports"`
-</guidelines>
-</overview>
 
-<examples>
-<example>
-<workflow_context>
-<message role="user">
+Example 1:
+
+User:
 ```rs src/rectangle.rs
 struct Rectangle {
     width: f64,
@@ -36,21 +30,12 @@ impl Rectangle {
 }
 ```
 
-We need to add methods to calculate the area and perimeter of the rectangle. Can you help with that?
-</message>
-<message role="assistant">
-Sure, I can help with that!
-
 <step>Add new methods 'calculate_area' and 'calculate_perimeter' to the Rectangle struct</step>
 <step>Implement the 'Display' trait for the Rectangle struct</step>
-</message>
-</workflow_context>
 
-<step_to_resolve>
-Add new methods 'calculate_area' and 'calculate_perimeter' to the Rectangle struct
-</step_to_resolve>
+What are the suggestions for the step: <step>Add a new method 'calculate_area' to the Rectangle struct</step>
 
-<incorrect_output reason="NEVER append multiple children at the same location.">
+A (wrong):
 {
   "title": "Add Rectangle methods",
   "suggestions": [
@@ -68,9 +53,10 @@ Add new methods 'calculate_area' and 'calculate_perimeter' to the Rectangle stru
     }
   ]
 }
-</incorrect_output>
 
-<correct_output>
+This demonstrates what NOT to do. NEVER append multiple children at the same location.
+
+A (corrected):
 {
   "title": "Add Rectangle methods",
   "suggestions": [
@@ -82,13 +68,11 @@ Add new methods 'calculate_area' and 'calculate_perimeter' to the Rectangle stru
     }
   ]
 }
-</correct_output>
 
-<step_to_resolve>
-Implement the 'Display' trait for the Rectangle struct
-</step_to_resolve>
+User:
+What are the suggestions for the step: <step>Implement the 'Display' trait for the Rectangle struct</step>
 
-<output>
+A:
 {
   "title": "Implement Display for Rectangle",
   "suggestions": [
@@ -100,11 +84,10 @@ Implement the 'Display' trait for the Rectangle struct
     }
   ]
 }
-</output>
 
-<example>
-<workflow_context>
-<message role="user">
+Example 2:
+
+User:
 ```rs src/user.rs
 struct User {
     pub name: String,
@@ -122,19 +105,13 @@ impl User {
     }
 }
 ```
-</message>
-<message role="assistant">
-Certainly!
+
 <step>Update the 'print_info' method to use formatted output</step>
 <step>Remove the 'email' field from the User struct</step>
-</message>
-</workflow_context>
 
-<step_to_resolve>
-Update the 'print_info' method to use formatted output
-</step_to_resolve>
+What are the suggestions for the step: <step>Update the 'print_info' method to use formatted output</step>
 
-<output>
+A:
 {
   "title": "Use formatted output",
   "suggestions": [
@@ -146,13 +123,11 @@ Update the 'print_info' method to use formatted output
     }
   ]
 }
-</output>
 
-<step_to_resolve>
-Remove the 'email' field from the User struct
-</step_to_resolve>
+User:
+What are the suggestions for the step: <step>Remove the 'email' field from the User struct</step>
 
-<output>
+A:
 {
   "title": "Remove email field",
   "suggestions": [
@@ -163,12 +138,10 @@ Remove the 'email' field from the User struct
       }
     ]
 }
-</output>
-</example>
 
-<example>
-<workflow_context>
-<message role="user">
+Example 3:
+
+User:
 ```rs src/vehicle.rs
 struct Vehicle {
     make: String,
@@ -186,36 +159,28 @@ impl Vehicle {
     }
 }
 ```
-</message>
-<message role="assistant">
+
 <step>Add a 'use std::fmt;' statement at the beginning of the file</step>
 <step>Add a new method 'start_engine' in the Vehicle impl block</step>
-</message>
-</workflow_context>
 
-<step_to_resolve>
-Add a 'use std::fmt;' statement at the beginning of the file
-</step_to_resolve>
+What are the suggestions for the step: <step>Add a 'use std::fmt;' statement at the beginning of the file</step>
 
-<output>
+A:
 {
   "title": "Add use std::fmt statement",
   "suggestions": [
     {
       "kind": "PrependChild",
       "path": "src/vehicle.rs",
-      "symbol": "#imports",
       "description": "Add 'use std::fmt' statement"
     }
   ]
 }
-</output>
 
-<step_to_resolve>
-Add a new method 'start_engine' in the Vehicle impl block
-</step_to_resolve>
+User:
+What are the suggestions for the step: <step>Add a new method 'start_engine' in the Vehicle impl block</step>
 
-<output>
+A:
 {
   "title": "Add start_engine method",
   "suggestions": [
@@ -227,12 +192,10 @@ Add a new method 'start_engine' in the Vehicle impl block
     }
   ]
 }
-</output>
-</example>
 
-<example>
-<workflow_context>
-<message role="user">
+Example 4:
+
+User:
 ```rs src/employee.rs
 struct Employee {
     name: String,
@@ -256,18 +219,12 @@ impl Employee {
     }
 }
 ```
-</message>
-<message role="assistant">
+
 <step>Make salary an f32</step>
-<step>Remove the 'department' field and update the 'print_details' method</step>
-</message>
-</workflow_context>
 
-<step_to_resolve>
-Make salary an f32
-</step_to_resolve>
+What are the suggestions for the step: <step>Make salary an f32</step>
 
-<incorrect_output reason="NEVER include suggestions on a parent symbol and one of its children in the same suggestions block.">
+A (wrong):
 {
   "title": "Change salary to f32",
   "suggestions": [
@@ -285,9 +242,10 @@ Make salary an f32
     }
   ]
 }
-</incorrect_output>
 
-<correct_output>
+This example demonstrates what not to do. `struct Employee salary` is a child of `struct Employee`.
+
+A (corrected):
 {
   "title": "Change salary to f32",
   "suggestions": [
@@ -299,13 +257,11 @@ Make salary an f32
     }
   ]
 }
-</correct_output>
 
-<step_to_resolve>
-Remove the 'department' field and update the 'print_details' method
-</step_to_resolve>
+User:
+What are the correct suggestions for the step: <step>Remove the 'department' field and update the 'print_details' method</step>
 
-<output>
+A:
 {
   "title": "Remove department",
   "suggestions": [
@@ -322,12 +278,10 @@ Remove the 'department' field and update the 'print_details' method
     }
   ]
 }
-</output>
-</example>
 
-<example>
-<workflow_context>
-<message role="user">
+Example 5:
+
+User:
 ```rs src/game.rs
 struct Player {
     name: String,
@@ -351,17 +305,10 @@ impl Game {
     }
 }
 ```
-</message>
-<message role="assistant">
+
 <step>Add a 'level' field to Player and update the 'new' method</step>
-</message>
-</workflow_context>
 
-<step_to_resolve>
-Add a 'level' field to Player and update the 'new' method
-</step_to_resolve>
-
-<output>
+A:
 {
   "title": "Add level field to Player",
   "suggestions": [
@@ -379,12 +326,10 @@ Add a 'level' field to Player and update the 'new' method
     }
   ]
 }
-</output>
-</example>
 
-<example>
-<workflow_context>
-<message role="user">
+Example 6:
+
+User:
 ```rs src/config.rs
 use std::collections::HashMap;
 
@@ -398,24 +343,16 @@ impl Config {
     }
 }
 ```
-</message>
-<message role="assistant">
+
 <step>Add a 'load_from_file' method to Config and import necessary modules</step>
-</message>
-</workflow_context>
 
-<step_to_resolve>
-Add a 'load_from_file' method to Config and import necessary modules
-</step_to_resolve>
-
-<output>
+A:
 {
   "title": "Add load_from_file method",
   "suggestions": [
     {
       "kind": "PrependChild",
       "path": "src/config.rs",
-      "symbol": "#imports",
       "description": "Import std::fs and std::io modules"
     },
     {
@@ -426,12 +363,10 @@ Add a 'load_from_file' method to Config and import necessary modules
     }
   ]
 }
-</output>
-</example>
 
-<example>
-<workflow_context>
-<message role="user">
+Example 7:
+
+User:
 ```rs src/database.rs
 pub(crate) struct Database {
     connection: Connection,
@@ -448,17 +383,10 @@ impl Database {
     }
 }
 ```
-</message>
-<message role="assistant">
+
 <step>Add error handling to the 'query' method and create a custom error type</step>
-</message>
-</workflow_context>
 
-<step_to_resolve>
-Add error handling to the 'query' method and create a custom error type
-</step_to_resolve>
-
-<output>
+A:
 {
   "title": "Add error handling to query",
   "suggestions": [
@@ -481,16 +409,5 @@ Add error handling to the 'query' method and create a custom error type
     }
   ]
 }
-</output>
-</example>
-</examples>
 
 Now generate the suggestions for the following step:
-
-<workflow_context>
-{{{workflow_context}}}
-</workflow_context>
-
-<step_to_resolve>
-{{{step_to_resolve}}}
-</step_to_resolve>

assets/settings/default.json

@@ -395,9 +395,9 @@
     // The default model to use when creating new contexts.
     "default_model": {
       // The provider to use.
-      "provider": "zed.dev",
+      "provider": "openai",
       // The model to use.
-      "model": "claude-3-5-sonnet"
+      "model": "gpt-4o"
     }
   },
   // The settings for slash commands.
@@ -1010,16 +1010,5 @@
   //     ]
   //   }
   // ]
-  "ssh_connections": null,
-  // Configures the Context Server Protocol binaries
-  //
-  // Examples:
-  // {
-  //   "id": "server-1",
-  //   "executable": "/path",
-  //   "args": ['arg1", "args2"]
-  // }
-  "experimental.context_servers": {
-    "servers": []
-  }
+  "ssh_connections": null
 }

compose.yml

@@ -33,31 +33,5 @@ services:
     volumes:
       - ./livekit.yaml:/livekit.yaml
 
-  postgrest_app:
-    image: postgrest/postgrest
-    container_name: postgrest_app
-    ports:
-      - 8081:8081
-    environment:
-      PGRST_DB_URI: postgres://postgres@postgres:5432/zed
-    volumes:
-      - ./crates/collab/postgrest_app.conf:/etc/postgrest.conf
-    command: postgrest /etc/postgrest.conf
-    depends_on:
-      - postgres
-
-  postgrest_llm:
-    image: postgrest/postgrest
-    container_name: postgrest_llm
-    ports:
-      - 8082:8082
-    environment:
-      PGRST_DB_URI: postgres://postgres@postgres:5432/zed_llm
-    volumes:
-      - ./crates/collab/postgrest_llm.conf:/etc/postgrest.conf
-    command: postgrest /etc/postgrest.conf
-    depends_on:
-      - postgres
-
 volumes:
   postgres_data:

crates/anthropic/Cargo.toml

@@ -17,7 +17,6 @@ path = "src/anthropic.rs"
 
 [dependencies]
 anyhow.workspace = true
-chrono.workspace = true
 futures.workspace = true
 http_client.workspace = true
 isahc.workspace = true
@@ -26,7 +25,6 @@ serde.workspace = true
 serde_json.workspace = true
 strum.workspace = true
 thiserror.workspace = true
-util.workspace = true
 
 [dev-dependencies]
 tokio.workspace = true

crates/anthropic/src/anthropic.rs

@@ -1,30 +1,19 @@
 mod supported_countries;
 
 use anyhow::{anyhow, Context, Result};
-use chrono::{DateTime, Utc};
 use futures::{io::BufReader, stream::BoxStream, AsyncBufReadExt, AsyncReadExt, Stream, StreamExt};
 use http_client::{AsyncBody, HttpClient, Method, Request as HttpRequest};
 use isahc::config::Configurable;
-use isahc::http::{HeaderMap, HeaderValue};
 use serde::{Deserialize, Serialize};
+use std::str::FromStr;
 use std::time::Duration;
-use std::{pin::Pin, str::FromStr};
 use strum::{EnumIter, EnumString};
 use thiserror::Error;
-use util::ResultExt as _;
 
 pub use supported_countries::*;
 
 pub const ANTHROPIC_API_URL: &'static str = "https://api.anthropic.com";
 
-#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
-#[derive(Clone, Debug, Default, Serialize, Deserialize, PartialEq)]
-pub struct AnthropicModelCacheConfiguration {
-    pub min_total_token: usize,
-    pub should_speculate: bool,
-    pub max_cache_anchors: usize,
-}
-
 #[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
 #[derive(Clone, Debug, Default, Serialize, Deserialize, PartialEq, EnumIter)]
 pub enum Model {
@@ -41,13 +30,8 @@ pub enum Model {
     Custom {
         name: String,
         max_tokens: usize,
-        /// The name displayed in the UI, such as in the assistant panel model dropdown menu.
-        display_name: Option<String>,
         /// Override this model with a different Anthropic model for tool calls.
         tool_override: Option<String>,
-        /// Indicates whether this custom model supports caching.
-        cache_configuration: Option<AnthropicModelCacheConfiguration>,
-        max_output_tokens: Option<u32>,
     },
 }
 
@@ -82,24 +66,7 @@ impl Model {
             Self::Claude3Opus => "Claude 3 Opus",
             Self::Claude3Sonnet => "Claude 3 Sonnet",
             Self::Claude3Haiku => "Claude 3 Haiku",
-            Self::Custom {
-                name, display_name, ..
-            } => display_name.as_ref().unwrap_or(name),
-        }
-    }
-
-    pub fn cache_configuration(&self) -> Option<AnthropicModelCacheConfiguration> {
-        match self {
-            Self::Claude3_5Sonnet | Self::Claude3Haiku => Some(AnthropicModelCacheConfiguration {
-                min_total_token: 2_048,
-                should_speculate: true,
-                max_cache_anchors: 4,
-            }),
-            Self::Custom {
-                cache_configuration,
-                ..
-            } => cache_configuration.clone(),
-            _ => None,
+            Self::Custom { name, .. } => name,
         }
     }
 
@@ -113,16 +80,6 @@ impl Model {
         }
     }
 
-    pub fn max_output_tokens(&self) -> u32 {
-        match self {
-            Self::Claude3Opus | Self::Claude3Sonnet | Self::Claude3Haiku => 4_096,
-            Self::Claude3_5Sonnet => 8_192,
-            Self::Custom {
-                max_output_tokens, ..
-            } => max_output_tokens.unwrap_or(4_096),
-        }
-    }
-
     pub fn tool_model_id(&self) -> &str {
         if let Self::Custom {
             tool_override: Some(tool_override),
@@ -147,10 +104,7 @@ pub async fn complete(
         .method(Method::POST)
         .uri(uri)
         .header("Anthropic-Version", "2023-06-01")
-        .header(
-            "Anthropic-Beta",
-            "tools-2024-04-04,prompt-caching-2024-07-31,max-tokens-3-5-sonnet-2024-07-15",
-        )
+        .header("Anthropic-Beta", "tools-2024-04-04")
         .header("X-Api-Key", api_key)
         .header("Content-Type", "application/json");
 
@@ -198,66 +152,6 @@ pub async fn stream_completion(
     request: Request,
     low_speed_timeout: Option<Duration>,
 ) -> Result<BoxStream<'static, Result<Event, AnthropicError>>, AnthropicError> {
-    stream_completion_with_rate_limit_info(client, api_url, api_key, request, low_speed_timeout)
-        .await
-        .map(|output| output.0)
-}
-
-/// https://docs.anthropic.com/en/api/rate-limits#response-headers
-#[derive(Debug)]
-pub struct RateLimitInfo {
-    pub requests_limit: usize,
-    pub requests_remaining: usize,
-    pub requests_reset: DateTime<Utc>,
-    pub tokens_limit: usize,
-    pub tokens_remaining: usize,
-    pub tokens_reset: DateTime<Utc>,
-}
-
-impl RateLimitInfo {
-    fn from_headers(headers: &HeaderMap<HeaderValue>) -> Result<Self> {
-        let tokens_limit = get_header("anthropic-ratelimit-tokens-limit", headers)?.parse()?;
-        let requests_limit = get_header("anthropic-ratelimit-requests-limit", headers)?.parse()?;
-        let tokens_remaining =
-            get_header("anthropic-ratelimit-tokens-remaining", headers)?.parse()?;
-        let requests_remaining =
-            get_header("anthropic-ratelimit-requests-remaining", headers)?.parse()?;
-        let requests_reset = get_header("anthropic-ratelimit-requests-reset", headers)?;
-        let tokens_reset = get_header("anthropic-ratelimit-tokens-reset", headers)?;
-        let requests_reset = DateTime::parse_from_rfc3339(requests_reset)?.to_utc();
-        let tokens_reset = DateTime::parse_from_rfc3339(tokens_reset)?.to_utc();
-
-        Ok(Self {
-            requests_limit,
-            tokens_limit,
-            requests_remaining,
-            tokens_remaining,
-            requests_reset,
-            tokens_reset,
-        })
-    }
-}
-
-fn get_header<'a>(key: &str, headers: &'a HeaderMap) -> Result<&'a str, anyhow::Error> {
-    Ok(headers
-        .get(key)
-        .ok_or_else(|| anyhow!("missing header `{key}`"))?
-        .to_str()?)
-}
-
-pub async fn stream_completion_with_rate_limit_info(
-    client: &dyn HttpClient,
-    api_url: &str,
-    api_key: &str,
-    request: Request,
-    low_speed_timeout: Option<Duration>,
-) -> Result<
-    (
-        BoxStream<'static, Result<Event, AnthropicError>>,
-        Option<RateLimitInfo>,
-    ),
-    AnthropicError,
-> {
     let request = StreamingRequest {
         base: request,
         stream: true,
@@ -267,10 +161,7 @@ pub async fn stream_completion_with_rate_limit_info(
         .method(Method::POST)
         .uri(uri)
         .header("Anthropic-Version", "2023-06-01")
-        .header(
-            "Anthropic-Beta",
-            "tools-2024-04-04,prompt-caching-2024-07-31,max-tokens-3-5-sonnet-2024-07-15",
-        )
+        .header("Anthropic-Beta", "tools-2024-04-04")
         .header("X-Api-Key", api_key)
         .header("Content-Type", "application/json");
     if let Some(low_speed_timeout) = low_speed_timeout {
@@ -287,9 +178,8 @@ pub async fn stream_completion_with_rate_limit_info(
         .await
         .context("failed to send request to Anthropic")?;
     if response.status().is_success() {
-        let rate_limits = RateLimitInfo::from_headers(response.headers());
         let reader = BufReader::new(response.into_body());
-        let stream = reader
+        Ok(reader
             .lines()
             .filter_map(|line| async move {
                 match line {
@@ -303,8 +193,7 @@ pub async fn stream_completion_with_rate_limit_info(
                     Err(error) => Some(Err(AnthropicError::Other(anyhow!(error)))),
                 }
             })
-            .boxed();
-        Ok((stream, rate_limits.log_err()))
+            .boxed())
     } else {
         let mut body = Vec::new();
         response
@@ -337,7 +226,7 @@ pub fn extract_text_from_events(
         match response {
             Ok(response) => match response {
                 Event::ContentBlockStart { content_block, .. } => match content_block {
-                    Content::Text { text, .. } => Some(Ok(text)),
+                    Content::Text { text } => Some(Ok(text)),
                     _ => None,
                 },
                 Event::ContentBlockDelta { delta, .. } => match delta {
@@ -352,69 +241,13 @@ pub fn extract_text_from_events(
     })
 }
 
-pub async fn extract_tool_args_from_events(
-    tool_name: String,
-    mut events: Pin<Box<dyn Send + Stream<Item = Result<Event>>>>,
-) -> Result<impl Send + Stream<Item = Result<String>>> {
-    let mut tool_use_index = None;
-    while let Some(event) = events.next().await {
-        if let Event::ContentBlockStart {
-            index,
-            content_block,
-        } = event?
-        {
-            if let Content::ToolUse { name, .. } = content_block {
-                if name == tool_name {
-                    tool_use_index = Some(index);
-                    break;
-                }
-            }
-        }
-    }
-
-    let Some(tool_use_index) = tool_use_index else {
-        return Err(anyhow!("tool not used"));
-    };
-
-    Ok(events.filter_map(move |event| {
-        let result = match event {
-            Err(error) => Some(Err(error)),
-            Ok(Event::ContentBlockDelta { index, delta }) => match delta {
-                ContentDelta::TextDelta { .. } => None,
-                ContentDelta::InputJsonDelta { partial_json } => {
-                    if index == tool_use_index {
-                        Some(Ok(partial_json))
-                    } else {
-                        None
-                    }
-                }
-            },
-            _ => None,
-        };
-
-        async move { result }
-    }))
-}
-
-#[derive(Debug, Serialize, Deserialize, Copy, Clone)]
-#[serde(rename_all = "lowercase")]
-pub enum CacheControlType {
-    Ephemeral,
-}
-
-#[derive(Debug, Serialize, Deserialize, Copy, Clone)]
-pub struct CacheControl {
-    #[serde(rename = "type")]
-    pub cache_type: CacheControlType,
-}
-
 #[derive(Debug, Serialize, Deserialize)]
 pub struct Message {
     pub role: Role,
     pub content: Vec<Content>,
 }
 
-#[derive(Debug, Serialize, Deserialize, Eq, PartialEq, Hash)]
+#[derive(Debug, Serialize, Deserialize)]
 #[serde(rename_all = "lowercase")]
 pub enum Role {
     User,
@@ -425,31 +258,19 @@ pub enum Role {
 #[serde(tag = "type")]
 pub enum Content {
     #[serde(rename = "text")]
-    Text {
-        text: String,
-        #[serde(skip_serializing_if = "Option::is_none")]
-        cache_control: Option<CacheControl>,
-    },
+    Text { text: String },
     #[serde(rename = "image")]
-    Image {
-        source: ImageSource,
-        #[serde(skip_serializing_if = "Option::is_none")]
-        cache_control: Option<CacheControl>,
-    },
+    Image { source: ImageSource },
     #[serde(rename = "tool_use")]
     ToolUse {
         id: String,
         name: String,
         input: serde_json::Value,
-        #[serde(skip_serializing_if = "Option::is_none")]
-        cache_control: Option<CacheControl>,
     },
     #[serde(rename = "tool_result")]
     ToolResult {
         tool_use_id: String,
         content: String,
-        #[serde(skip_serializing_if = "Option::is_none")]
-        cache_control: Option<CacheControl>,
     },
 }
 

crates/assistant/Cargo.toml

@@ -33,13 +33,11 @@ clock.workspace = true
 collections.workspace = true
 command_palette_hooks.workspace = true
 db.workspace = true
-context_servers.workspace = true
 editor.workspace = true
 feature_flags.workspace = true
 fs.workspace = true
 futures.workspace = true
 fuzzy.workspace = true
-globset.workspace = true
 gpui.workspace = true
 handlebars.workspace = true
 heed.workspace = true
@@ -69,7 +67,6 @@ serde.workspace = true
 serde_json.workspace = true
 settings.workspace = true
 smallvec.workspace = true
-similar.workspace = true
 smol.workspace = true
 telemetry_events.workspace = true
 terminal.workspace = true

crates/assistant/src/assistant.rs

@@ -3,17 +3,16 @@
 pub mod assistant_panel;
 pub mod assistant_settings;
 mod context;
+pub(crate) mod context_inspector;
 pub mod context_store;
 mod inline_assistant;
 mod model_selector;
 mod prompt_library;
 mod prompts;
 mod slash_command;
-pub(crate) mod slash_command_picker;
 pub mod slash_command_settings;
 mod streaming_diff;
 mod terminal_inline_assistant;
-mod workflow;
 
 pub use assistant_panel::{AssistantPanel, AssistantPanelEvent};
 use assistant_settings::AssistantSettings;
@@ -21,11 +20,9 @@ use assistant_slash_command::SlashCommandRegistry;
 use client::{proto, Client};
 use command_palette_hooks::CommandPaletteFilter;
 pub use context::*;
-use context_servers::ContextServerRegistry;
 pub use context_store::*;
 use feature_flags::FeatureFlagAppExt;
 use fs::Fs;
-use gpui::Context as _;
 use gpui::{actions, impl_actions, AppContext, Global, SharedString, UpdateGlobal};
 use indexed_docs::IndexedDocsRegistry;
 pub(crate) use inline_assistant::*;
@@ -34,19 +31,18 @@ use language_model::{
 };
 pub(crate) use model_selector::*;
 pub use prompts::PromptBuilder;
-use prompts::PromptLoadingParams;
+use prompts::PromptOverrideContext;
 use semantic_index::{CloudEmbeddingProvider, SemanticIndex};
 use serde::{Deserialize, Serialize};
 use settings::{update_settings_file, Settings, SettingsStore};
 use slash_command::{
-    context_server_command, default_command, diagnostics_command, docs_command, fetch_command,
-    file_command, now_command, project_command, prompt_command, search_command, symbols_command,
-    tab_command, terminal_command, workflow_command,
+    default_command, diagnostics_command, docs_command, fetch_command, file_command, now_command,
+    project_command, prompt_command, search_command, symbols_command, tabs_command,
+    terminal_command, workflow_command,
 };
 use std::sync::Arc;
 pub(crate) use streaming_diff::*;
 use util::ResultExt;
-pub use workflow::*;
 
 use crate::slash_command_settings::SlashCommandSettings;
 
@@ -60,14 +56,16 @@ actions!(
         InsertIntoEditor,
         ToggleFocus,
         InsertActivePrompt,
+        ShowConfiguration,
         DeployHistory,
         DeployPromptLibrary,
         ConfirmCommand,
         ToggleModelSelector,
+        DebugWorkflowSteps
     ]
 );
 
-const DEFAULT_CONTEXT_LINES: usize = 50;
+const DEFAULT_CONTEXT_LINES: usize = 20;
 
 #[derive(Clone, Default, Deserialize, PartialEq)]
 pub struct InlineAssist {
@@ -184,7 +182,7 @@ impl Assistant {
 pub fn init(
     fs: Arc<dyn Fs>,
     client: Arc<Client>,
-    stdout_is_a_pty: bool,
+    dev_mode: bool,
     cx: &mut AppContext,
 ) -> Arc<PromptBuilder> {
     cx.set_global(Assistant::default());
@@ -221,13 +219,10 @@ pub fn init(
     init_language_model_settings(cx);
     assistant_slash_command::init(cx);
     assistant_panel::init(cx);
-    context_servers::init(cx);
 
-    let prompt_builder = prompts::PromptBuilder::new(Some(PromptLoadingParams {
+    let prompt_builder = prompts::PromptBuilder::new(Some(PromptOverrideContext {
+        dev_mode,
         fs: fs.clone(),
-        repo_path: stdout_is_a_pty
-            .then(|| std::env::current_dir().log_err())
-            .flatten(),
         cx,
     }))
     .log_err()
@@ -264,69 +259,9 @@ pub fn init(
     })
     .detach();
 
-    register_context_server_handlers(cx);
-
     prompt_builder
 }
 
-fn register_context_server_handlers(cx: &mut AppContext) {
-    cx.subscribe(
-        &context_servers::manager::ContextServerManager::global(cx),
-        |manager, event, cx| match event {
-            context_servers::manager::Event::ServerStarted { server_id } => {
-                cx.update_model(
-                    &manager,
-                    |manager: &mut context_servers::manager::ContextServerManager, cx| {
-                        let slash_command_registry = SlashCommandRegistry::global(cx);
-                        let context_server_registry = ContextServerRegistry::global(cx);
-                        if let Some(server) = manager.get_server(server_id) {
-                            cx.spawn(|_, _| async move {
-                                let Some(protocol) = server.client.read().clone() else {
-                                    return;
-                                };
-
-                                if let Some(prompts) = protocol.list_prompts().await.log_err() {
-                                    for prompt in prompts
-                                        .into_iter()
-                                        .filter(context_server_command::acceptable_prompt)
-                                    {
-                                        log::info!(
-                                            "registering context server command: {:?}",
-                                            prompt.name
-                                        );
-                                        context_server_registry.register_command(
-                                            server.id.clone(),
-                                            prompt.name.as_str(),
-                                        );
-                                        slash_command_registry.register_command(
-                                            context_server_command::ContextServerSlashCommand::new(
-                                                &server, prompt,
-                                            ),
-                                            true,
-                                        );
-                                    }
-                                }
-                            })
-                            .detach();
-                        }
-                    },
-                );
-            }
-            context_servers::manager::Event::ServerStopped { server_id } => {
-                let slash_command_registry = SlashCommandRegistry::global(cx);
-                let context_server_registry = ContextServerRegistry::global(cx);
-                if let Some(commands) = context_server_registry.get_commands(server_id) {
-                    for command_name in commands {
-                        slash_command_registry.unregister_command_by_name(&command_name);
-                        context_server_registry.unregister_command(&server_id, &command_name);
-                    }
-                }
-            }
-        },
-    )
-    .detach();
-}
-
 fn init_language_model_settings(cx: &mut AppContext) {
     update_active_language_model_from_settings(cx);
 
@@ -359,7 +294,7 @@ fn register_slash_commands(prompt_builder: Option<Arc<PromptBuilder>>, cx: &mut
     let slash_command_registry = SlashCommandRegistry::global(cx);
     slash_command_registry.register_command(file_command::FileSlashCommand, true);
     slash_command_registry.register_command(symbols_command::OutlineSlashCommand, true);
-    slash_command_registry.register_command(tab_command::TabSlashCommand, true);
+    slash_command_registry.register_command(tabs_command::TabsSlashCommand, true);
     slash_command_registry.register_command(project_command::ProjectSlashCommand, true);
     slash_command_registry.register_command(prompt_command::PromptSlashCommand, true);
     slash_command_registry.register_command(default_command::DefaultSlashCommand, false);

crates/assistant/src/assistant_settings.rs

@@ -543,8 +543,8 @@ mod tests {
             assert_eq!(
                 AssistantSettings::get_global(cx).default_model,
                 LanguageModelSelection {
-                    provider: "zed.dev".into(),
-                    model: "claude-3-5-sonnet".into(),
+                    provider: "openai".into(),
+                    model: "gpt-4o".into(),
                 }
             );
         });

crates/assistant/src/context_inspector.rs

@@ -0,0 +1,219 @@
+use std::{ops::Range, sync::Arc};
+
+use collections::{HashMap, HashSet};
+use editor::{
+    display_map::{BlockDisposition, BlockProperties, BlockStyle, CustomBlockId},
+    Editor,
+};
+use gpui::{AppContext, Model, View};
+use text::{Bias, ToOffset, ToPoint};
+use ui::{
+    div, h_flex, px, Color, Element as _, ParentElement as _, Styled, ViewContext, WindowContext,
+};
+
+use crate::{Context, ResolvedWorkflowStep, WorkflowSuggestion};
+
+type StepRange = Range<language::Anchor>;
+
+struct DebugInfo {
+    range: Range<editor::Anchor>,
+    block_id: CustomBlockId,
+}
+
+pub(crate) struct ContextInspector {
+    active_debug_views: HashMap<Range<language::Anchor>, DebugInfo>,
+    context: Model<Context>,
+    editor: View<Editor>,
+}
+
+impl ContextInspector {
+    pub(crate) fn new(editor: View<Editor>, context: Model<Context>) -> Self {
+        Self {
+            editor,
+            context,
+            active_debug_views: Default::default(),
+        }
+    }
+
+    pub(crate) fn is_active(&self, range: &StepRange) -> bool {
+        self.active_debug_views.contains_key(range)
+    }
+
+    pub(crate) fn refresh(&mut self, range: &StepRange, cx: &mut WindowContext<'_>) {
+        if self.deactivate_for(range, cx) {
+            self.activate_for_step(range.clone(), cx);
+        }
+    }
+    fn crease_content(
+        context: &Model<Context>,
+        range: StepRange,
+        cx: &mut AppContext,
+    ) -> Option<Arc<str>> {
+        use std::fmt::Write;
+        let step = context.read(cx).workflow_step_for_range(range)?;
+        let mut output = String::from("\n\n");
+        match &step.status {
+            crate::WorkflowStepStatus::Resolved(ResolvedWorkflowStep { title, suggestions }) => {
+                writeln!(output, "Resolution:").ok()?;
+                writeln!(output, "  {title:?}").ok()?;
+                for (buffer, suggestion_groups) in suggestions {
+                    let buffer = buffer.read(cx);
+                    let buffer_path = buffer
+                        .file()
+                        .and_then(|file| file.path().to_str())
+                        .unwrap_or("untitled");
+                    let snapshot = buffer.text_snapshot();
+                    writeln!(output, "  {buffer_path}:").ok()?;
+                    for group in suggestion_groups {
+                        for suggestion in &group.suggestions {
+                            pretty_print_workflow_suggestion(&mut output, suggestion, &snapshot);
+                        }
+                    }
+                }
+            }
+            crate::WorkflowStepStatus::Pending(_) => {
+                writeln!(output, "Resolution: Pending").ok()?;
+            }
+            crate::WorkflowStepStatus::Error(error) => {
+                writeln!(output, "Resolution: Error").ok()?;
+                writeln!(output, "{error:?}").ok()?;
+            }
+        }
+
+        Some(output.into())
+    }
+    pub(crate) fn activate_for_step(&mut self, range: StepRange, cx: &mut WindowContext<'_>) {
+        let text = Self::crease_content(&self.context, range.clone(), cx)
+            .unwrap_or_else(|| Arc::from("Error fetching debug info"));
+        self.editor.update(cx, |editor, cx| {
+            let buffer = editor.buffer().read(cx).as_singleton()?;
+            let snapshot = buffer.read(cx).text_snapshot();
+            let start_offset = range.end.to_offset(&snapshot) + 1;
+            let start_offset = snapshot.clip_offset(start_offset, Bias::Right);
+            let text_len = text.len();
+            buffer.update(cx, |this, cx| {
+                this.edit([(start_offset..start_offset, text)], None, cx);
+            });
+
+            let end_offset = start_offset + text_len;
+            let multibuffer_snapshot = editor.buffer().read(cx).snapshot(cx);
+            let anchor_before = multibuffer_snapshot.anchor_after(start_offset);
+            let anchor_after = multibuffer_snapshot.anchor_before(end_offset);
+
+            let block_id = editor
+                .insert_blocks(
+                    [BlockProperties {
+                        position: anchor_after,
+                        height: 0,
+                        style: BlockStyle::Sticky,
+                        render: Box::new(move |cx| {
+                            div()
+                                .w_full()
+                                .px(cx.gutter_dimensions.full_width())
+                                .child(h_flex().h(px(1.)).bg(Color::Warning.color(cx)))
+                                .into_any()
+                        }),
+                        disposition: BlockDisposition::Below,
+                        priority: 0,
+                    }],
+                    None,
+                    cx,
+                )
+                .into_iter()
+                .next()?;
+            let info = DebugInfo {
+                range: anchor_before..anchor_after,
+                block_id,
+            };
+            self.active_debug_views.insert(range, info);
+            Some(())
+        });
+    }
+
+    fn deactivate_impl(editor: &mut Editor, debug_data: DebugInfo, cx: &mut ViewContext<Editor>) {
+        editor.remove_blocks(HashSet::from_iter([debug_data.block_id]), None, cx);
+        editor.edit([(debug_data.range, Arc::<str>::default())], cx)
+    }
+    pub(crate) fn deactivate_for(&mut self, range: &StepRange, cx: &mut WindowContext<'_>) -> bool {
+        if let Some(debug_data) = self.active_debug_views.remove(range) {
+            self.editor.update(cx, |this, cx| {
+                Self::deactivate_impl(this, debug_data, cx);
+            });
+            true
+        } else {
+            false
+        }
+    }
+
+    pub(crate) fn deactivate(&mut self, cx: &mut WindowContext<'_>) {
+        let steps_to_disable = std::mem::take(&mut self.active_debug_views);
+
+        self.editor.update(cx, move |editor, cx| {
+            for (_, debug_data) in steps_to_disable {
+                Self::deactivate_impl(editor, debug_data, cx);
+            }
+        });
+    }
+}
+fn pretty_print_anchor(
+    out: &mut String,
+    anchor: &language::Anchor,
+    snapshot: &text::BufferSnapshot,
+) {
+    use std::fmt::Write;
+    let point = anchor.to_point(snapshot);
+    write!(out, "{}:{}", point.row, point.column).ok();
+}
+fn pretty_print_range(
+    out: &mut String,
+    range: &Range<language::Anchor>,
+    snapshot: &text::BufferSnapshot,
+) {
+    use std::fmt::Write;
+    write!(out, "    Range: ").ok();
+    pretty_print_anchor(out, &range.start, snapshot);
+    write!(out, "..").ok();
+    pretty_print_anchor(out, &range.end, snapshot);
+}
+
+fn pretty_print_workflow_suggestion(
+    out: &mut String,
+    suggestion: &WorkflowSuggestion,
+    snapshot: &text::BufferSnapshot,
+) {
+    use std::fmt::Write;
+    let (range, description, position) = match suggestion {
+        WorkflowSuggestion::Update { range, description } => (Some(range), Some(description), None),
+        WorkflowSuggestion::CreateFile { description } => (None, Some(description), None),
+        WorkflowSuggestion::AppendChild {
+            position,
+            description,
+        }
+        | WorkflowSuggestion::InsertSiblingBefore {
+            position,
+            description,
+        }
+        | WorkflowSuggestion::InsertSiblingAfter {
+            position,
+            description,
+        }
+        | WorkflowSuggestion::PrependChild {
+            position,
+            description,
+        } => (None, Some(description), Some(position)),
+
+        WorkflowSuggestion::Delete { range } => (Some(range), None, None),
+    };
+    if let Some(description) = description {
+        writeln!(out, "    Description: {description}").ok();
+    }
+    if let Some(range) = range {
+        pretty_print_range(out, range, snapshot);
+    }
+    if let Some(position) = position {
+        write!(out, "    Position: ").ok();
+        pretty_print_anchor(out, position, snapshot);
+        write!(out, "\n").ok();
+    }
+    write!(out, "\n").ok();
+}

crates/assistant/src/model_selector.rs

@@ -1,16 +1,15 @@
 use feature_flags::ZedPro;
-use gpui::Action;
 use gpui::DismissEvent;
-
 use language_model::{LanguageModel, LanguageModelAvailability, LanguageModelRegistry};
 use proto::Plan;
-use workspace::ShowConfiguration;
 
 use std::sync::Arc;
 use ui::ListItemSpacing;
 
 use crate::assistant_settings::AssistantSettings;
+use crate::ShowConfiguration;
 use fs::Fs;
+use gpui::Action;
 use gpui::SharedString;
 use gpui::Task;
 use picker::{Picker, PickerDelegate};
@@ -37,7 +36,7 @@ pub struct ModelPickerDelegate {
 #[derive(Clone)]
 struct ModelInfo {
     model: Arc<dyn LanguageModel>,
-    icon: IconName,
+    provider_icon: IconName,
     availability: LanguageModelAvailability,
     is_selected: bool,
 }
@@ -150,8 +149,6 @@ impl PickerDelegate for ModelPickerDelegate {
         use feature_flags::FeatureFlagAppExt;
         let model_info = self.filtered_models.get(ix)?;
         let show_badges = cx.has_flag::<ZedPro>();
-        let provider_name: String = model_info.model.provider_name().0.into();
-
         Some(
             ListItem::new(ix)
                 .inset(true)
@@ -159,7 +156,7 @@ impl PickerDelegate for ModelPickerDelegate {
                 .selected(selected)
                 .start_slot(
                     div().pr_1().child(
-                        Icon::new(model_info.icon)
+                        Icon::new(model_info.provider_icon)
                             .color(Color::Muted)
                             .size(IconSize::Medium),
                     ),
@@ -169,16 +166,11 @@ impl PickerDelegate for ModelPickerDelegate {
                         .w_full()
                         .justify_between()
                         .font_buffer(cx)
-                        .min_w(px(240.))
+                        .min_w(px(200.))
                         .child(
                             h_flex()
                                 .gap_2()
                                 .child(Label::new(model_info.model.name().0.clone()))
-                                .child(
-                                    Label::new(provider_name)
-                                        .size(LabelSize::XSmall)
-                                        .color(Color::Muted),
-                                )
                                 .children(match model_info.availability {
                                     LanguageModelAvailability::Public => None,
                                     LanguageModelAvailability::RequiresPlan(Plan::Free) => None,
@@ -269,17 +261,16 @@ impl<T: PopoverTrigger> RenderOnce for ModelSelector<T> {
             .iter()
             .flat_map(|provider| {
                 let provider_id = provider.id();
-                let icon = provider.icon();
+                let provider_icon = provider.icon();
                 let selected_model = selected_model.clone();
                 let selected_provider = selected_provider.clone();
 
                 provider.provided_models(cx).into_iter().map(move |model| {
                     let model = model.clone();
-                    let icon = model.icon().unwrap_or(icon);
 
                     ModelInfo {
                         model: model.clone(),
-                        icon,
+                        provider_icon,
                         availability: model.availability(),
                         is_selected: selected_model.as_ref() == Some(&model.id())
                             && selected_provider.as_ref() == Some(&provider_id),
@@ -304,6 +295,5 @@ impl<T: PopoverTrigger> RenderOnce for ModelSelector<T> {
             .menu(move |_cx| Some(picker_view.clone()))
             .trigger(self.trigger)
             .attach(gpui::AnchorCorner::BottomLeft)
-            .when_some(self.handle, |menu, handle| menu.with_handle(handle))
     }
 }

crates/assistant/src/prompt_library.rs

@@ -11,8 +11,8 @@ use futures::{
 };
 use fuzzy::StringMatchCandidate;
 use gpui::{
-    actions, point, size, transparent_black, Action, AppContext, BackgroundExecutor, Bounds,
-    EventEmitter, Global, HighlightStyle, PromptLevel, ReadGlobal, Subscription, Task, TextStyle,
+    actions, point, size, transparent_black, AppContext, BackgroundExecutor, Bounds, EventEmitter,
+    Global, HighlightStyle, PromptLevel, ReadGlobal, Subscription, Task, TextStyle,
     TitlebarOptions, UpdateGlobal, View, WindowBounds, WindowHandle, WindowOptions,
 };
 use heed::{
@@ -38,7 +38,7 @@ use std::{
 use text::LineEnding;
 use theme::ThemeSettings;
 use ui::{
-    div, prelude::*, IconButtonShape, KeyBinding, ListItem, ListItemSpacing, ParentElement, Render,
+    div, prelude::*, IconButtonShape, ListItem, ListItemSpacing, ParentElement, Render,
     SharedString, Styled, Tooltip, ViewContext, VisualContext,
 };
 use util::{ResultExt, TryFutureExt};
@@ -100,7 +100,7 @@ pub fn open_prompt_library(
                     WindowOptions {
                         titlebar: Some(TitlebarOptions {
                             title: Some("Prompt Library".into()),
-                            appears_transparent: !cfg!(windows),
+                            appears_transparent: true,
                             traffic_light_position: Some(point(px(9.0), px(9.0))),
                         }),
                         window_bounds: Some(WindowBounds::Windowed(bounds)),
@@ -155,14 +155,6 @@ impl PickerDelegate for PromptPickerDelegate {
         self.matches.len()
     }
 
-    fn no_matches_text(&self, _cx: &mut WindowContext) -> SharedString {
-        if self.store.prompt_count() == 0 {
-            "No prompts.".into()
-        } else {
-            "No prompts found matching your search.".into()
-        }
-    }
-
     fn selected_index(&self) -> usize {
         self.selected_index
     }
@@ -494,10 +486,7 @@ impl PromptLibrary {
                             let mut editor = Editor::auto_width(cx);
                             editor.set_placeholder_text("Untitled", cx);
                             editor.set_text(prompt_metadata.title.unwrap_or_default(), cx);
-                            if prompt_id.is_built_in() {
-                                editor.set_read_only(true);
-                                editor.set_show_inline_completions(false);
-                            }
+                            editor.set_read_only(prompt_id.is_built_in());
                             editor
                         });
                         let body_editor = cx.new_view(|cx| {
@@ -509,10 +498,7 @@ impl PromptLibrary {
                             });
 
                             let mut editor = Editor::for_buffer(buffer, None, cx);
-                            if prompt_id.is_built_in() {
-                                editor.set_read_only(true);
-                                editor.set_show_inline_completions(false);
-                            }
+                            editor.set_read_only(prompt_id.is_built_in());
                             editor.set_soft_wrap_mode(SoftWrap::EditorWidth, cx);
                             editor.set_show_gutter(false, cx);
                             editor.set_show_wrap_guides(false, cx);
@@ -790,7 +776,6 @@ impl PromptLibrary {
                                     messages: vec![LanguageModelRequestMessage {
                                         role: Role::System,
                                         content: vec![body.to_string().into()],
-                                        cache: false,
                                     }],
                                     stop: Vec::new(),
                                     temperature: 1.,
@@ -1109,55 +1094,7 @@ impl Render for PromptLibrary {
             .font(ui_font)
             .text_color(theme.colors().text)
             .child(self.render_prompt_list(cx))
-            .map(|el| {
-                if self.store.prompt_count() == 0 {
-                    el.child(
-                        v_flex()
-                            .w_2_3()
-                            .h_full()
-                            .items_center()
-                            .justify_center()
-                            .gap_4()
-                            .bg(cx.theme().colors().editor_background)
-                            .child(
-                                h_flex()
-                                    .gap_2()
-                                    .child(
-                                        Icon::new(IconName::Book)
-                                            .size(IconSize::Medium)
-                                            .color(Color::Muted),
-                                    )
-                                    .child(
-                                        Label::new("No prompts yet")
-                                            .size(LabelSize::Large)
-                                            .color(Color::Muted),
-                                    ),
-                            )
-                            .child(
-                                h_flex()
-                                    .child(h_flex())
-                                    .child(
-                                        v_flex()
-                                            .gap_1()
-                                            .child(Label::new("Create your first prompt:"))
-                                            .child(
-                                                Button::new("create-prompt", "New Prompt")
-                                                    .full_width()
-                                                    .key_binding(KeyBinding::for_action(
-                                                        &NewPrompt, cx,
-                                                    ))
-                                                    .on_click(|_, cx| {
-                                                        cx.dispatch_action(NewPrompt.boxed_clone())
-                                                    }),
-                                            ),
-                                    )
-                                    .child(h_flex()),
-                            ),
-                    )
-                } else {
-                    el.child(self.render_active_prompt(cx))
-                }
-            })
+            .child(self.render_active_prompt(cx))
     }
 }
 
@@ -1405,11 +1342,6 @@ impl PromptStore {
         })
     }
 
-    /// Returns the number of prompts in the store.
-    fn prompt_count(&self) -> usize {
-        self.metadata_cache.read().metadata.len()
-    }
-
     fn metadata(&self, id: PromptId) -> Option<PromptMetadata> {
         self.metadata_cache.read().metadata_by_id.get(&id).cloned()
     }

crates/assistant/src/prompts.rs

@@ -1,24 +1,24 @@
-use anyhow::Result;
 use assets::Assets;
 use fs::Fs;
 use futures::StreamExt;
-use gpui::AssetSource;
-use handlebars::{Handlebars, RenderError};
+use handlebars::{Handlebars, RenderError, TemplateError};
 use language::BufferSnapshot;
 use parking_lot::Mutex;
 use serde::Serialize;
-use std::{ops::Range, path::PathBuf, sync::Arc, time::Duration};
+use std::{ops::Range, sync::Arc, time::Duration};
 use util::ResultExt;
 
 #[derive(Serialize)]
 pub struct ContentPromptContext {
     pub content_type: String,
     pub language_name: Option<String>,
-    pub is_insert: bool,
     pub is_truncated: bool,
     pub document_content: String,
     pub user_prompt: String,
-    pub rewrite_section: Option<String>,
+    pub rewrite_section: String,
+    pub rewrite_section_with_selections: String,
+    pub has_insertion: bool,
+    pub has_replacement: bool,
 }
 
 #[derive(Serialize)]
@@ -31,171 +31,128 @@ pub struct TerminalAssistantPromptContext {
     pub user_prompt: String,
 }
 
-/// Context required to generate a workflow step resolution prompt.
-#[derive(Debug, Serialize)]
-pub struct StepResolutionContext {
-    /// The full context, including <step>...</step> tags
-    pub workflow_context: String,
-    /// The text of the specific step from the context to resolve
-    pub step_to_resolve: String,
-}
-
-pub struct PromptLoadingParams<'a> {
-    pub fs: Arc<dyn Fs>,
-    pub repo_path: Option<PathBuf>,
-    pub cx: &'a gpui::AppContext,
-}
-
 pub struct PromptBuilder {
     handlebars: Arc<Mutex<Handlebars<'static>>>,
 }
 
+pub struct PromptOverrideContext<'a> {
+    pub dev_mode: bool,
+    pub fs: Arc<dyn Fs>,
+    pub cx: &'a mut gpui::AppContext,
+}
+
 impl PromptBuilder {
-    pub fn new(loading_params: Option<PromptLoadingParams>) -> Result<Self> {
+    pub fn new(override_cx: Option<PromptOverrideContext>) -> Result<Self, Box<TemplateError>> {
         let mut handlebars = Handlebars::new();
-        Self::register_built_in_templates(&mut handlebars)?;
+        Self::register_templates(&mut handlebars)?;
 
         let handlebars = Arc::new(Mutex::new(handlebars));
 
-        if let Some(params) = loading_params {
-            Self::watch_fs_for_template_overrides(params, handlebars.clone());
+        if let Some(override_cx) = override_cx {
+            Self::watch_fs_for_template_overrides(override_cx, handlebars.clone());
         }
 
         Ok(Self { handlebars })
     }
 
-    /// Watches the filesystem for changes to prompt template overrides.
-    ///
-    /// This function sets up a file watcher on the prompt templates directory. It performs
-    /// an initial scan of the directory and registers any existing template overrides.
-    /// Then it continuously monitors for changes, reloading templates as they are
-    /// modified or added.
-    ///
-    /// If the templates directory doesn't exist initially, it waits for it to be created.
-    /// If the directory is removed, it restores the built-in templates and waits for the
-    /// directory to be recreated.
-    ///
-    /// # Arguments
-    ///
-    /// * `params` - A `PromptLoadingParams` struct containing the filesystem, repository path,
-    ///   and application context.
-    /// * `handlebars` - An `Arc<Mutex<Handlebars>>` for registering and updating templates.
     fn watch_fs_for_template_overrides(
-        mut params: PromptLoadingParams,
+        PromptOverrideContext { dev_mode, fs, cx }: PromptOverrideContext,
         handlebars: Arc<Mutex<Handlebars<'static>>>,
     ) {
-        params.repo_path = None;
-        let templates_dir = paths::prompt_overrides_dir(params.repo_path.as_deref());
-        params.cx.background_executor()
+        cx.background_executor()
             .spawn(async move {
-                let Some(parent_dir) = templates_dir.parent() else {
-                    return;
+                let templates_dir = if dev_mode {
+                    std::env::current_dir()
+                        .ok()
+                        .and_then(|pwd| {
+                            let pwd_assets_prompts = pwd.join("assets").join("prompts");
+                            pwd_assets_prompts.exists().then_some(pwd_assets_prompts)
+                        })
+                        .unwrap_or_else(|| paths::prompt_overrides_dir().clone())
+                } else {
+                    paths::prompt_overrides_dir().clone()
                 };
 
-                let mut found_dir_once = false;
-                loop {
-                    // Check if the templates directory exists and handle its status
-                    // If it exists, log its presence and check if it's a symlink
-                    // If it doesn't exist:
-                    //   - Log that we're using built-in prompts
-                    //   - Check if it's a broken symlink and log if so
-                    //   - Set up a watcher to detect when it's created
-                    // After the first check, set the `found_dir_once` flag
-                    // This allows us to avoid logging when looping back around after deleting the prompt overrides directory.
-                    let dir_status = params.fs.is_dir(&templates_dir).await;
-                    let symlink_status = params.fs.read_link(&templates_dir).await.ok();
-                    if dir_status {
-                        let mut log_message = format!("Prompt template overrides directory found at {}", templates_dir.display());
-                        if let Some(target) = symlink_status {
-                            log_message.push_str(" -> ");
-                            log_message.push_str(&target.display().to_string());
-                        }
-                        log::info!("{}.", log_message);
-                    } else {
-                        if !found_dir_once {
-                            log::info!("No prompt template overrides directory found at {}. Using built-in prompts.", templates_dir.display());
-                            if let Some(target) = symlink_status {
-                                log::info!("Symlink found pointing to {}, but target is invalid.", target.display());
-                            }
-                        }
-
-                        if params.fs.is_dir(parent_dir).await {
-                            let (mut changes, _watcher) = params.fs.watch(parent_dir, Duration::from_secs(1)).await;
-                            while let Some(changed_paths) = changes.next().await {
-                                if changed_paths.iter().any(|p| p == &templates_dir) {
-                                    let mut log_message = format!("Prompt template overrides directory detected at {}", templates_dir.display());
-                                    if let Ok(target) = params.fs.read_link(&templates_dir).await {
-                                        log_message.push_str(" -> ");
-                                        log_message.push_str(&target.display().to_string());
-                                    }
-                                    log::info!("{}.", log_message);
-                                    break;
-                                }
-                            }
-                        } else {
-                            return;
-                        }
+                // Create the prompt templates directory if it doesn't exist
+                if !fs.is_dir(&templates_dir).await {
+                    if let Err(e) = fs.create_dir(&templates_dir).await {
+                        log::error!("Failed to create prompt templates directory: {}", e);
+                        return;
                     }
-
-                    found_dir_once = true;
-
-                    // Initial scan of the prompt overrides directory
-                    if let Ok(mut entries) = params.fs.read_dir(&templates_dir).await {
-                        while let Some(Ok(file_path)) = entries.next().await {
-                            if file_path.to_string_lossy().ends_with(".hbs") {
-                                if let Ok(content) = params.fs.load(&file_path).await {
-                                    let file_name = file_path.file_stem().unwrap().to_string_lossy();
-                                    log::info!("Registering prompt template override: {}", file_name);
-                                    handlebars.lock().register_template_string(&file_name, content).log_err();
-                                }
-                            }
-                        }
-                    }
-
-                    // Watch both the parent directory and the template overrides directory:
-                    // - Monitor the parent directory to detect if the template overrides directory is deleted.
-                    // - Monitor the template overrides directory to re-register templates when they change.
-                    // Combine both watch streams into a single stream.
-                    let (parent_changes, parent_watcher) = params.fs.watch(parent_dir, Duration::from_secs(1)).await;
-                    let (changes, watcher) = params.fs.watch(&templates_dir, Duration::from_secs(1)).await;
-                    let mut combined_changes = futures::stream::select(changes, parent_changes);
-
-                    while let Some(changed_paths) = combined_changes.next().await {
-                        if changed_paths.iter().any(|p| p == &templates_dir) {
-                            if !params.fs.is_dir(&templates_dir).await {
-                                log::info!("Prompt template overrides directory removed. Restoring built-in prompt templates.");
-                                Self::register_built_in_templates(&mut handlebars.lock()).log_err();
-                                break;
-                            }
-                        }
-                        for changed_path in changed_paths {
-                            if changed_path.starts_with(&templates_dir) && changed_path.extension().map_or(false, |ext| ext == "hbs") {
-                                log::info!("Reloading prompt template override: {}", changed_path.display());
-                                if let Some(content) = params.fs.load(&changed_path).await.log_err() {
-                                    let file_name = changed_path.file_stem().unwrap().to_string_lossy();
-                                    handlebars.lock().register_template_string(&file_name, content).log_err();
-                                }
-                            }
-                        }
-                    }
-
-                    drop(watcher);
-                    drop(parent_watcher);
                 }
+
+                // Initial scan of the prompts directory
+                if let Ok(mut entries) = fs.read_dir(&templates_dir).await {
+                    while let Some(Ok(file_path)) = entries.next().await {
+                        if file_path.to_string_lossy().ends_with(".hbs") {
+                            if let Ok(content) = fs.load(&file_path).await {
+                                let file_name = file_path.file_stem().unwrap().to_string_lossy();
+
+                                match handlebars.lock().register_template_string(&file_name, content) {
+                                    Ok(_) => {
+                                        log::info!(
+                                            "Successfully registered template override: {} ({})",
+                                            file_name,
+                                            file_path.display()
+                                        );
+                                    },
+                                    Err(e) => {
+                                        log::error!(
+                                            "Failed to register template during initial scan: {} ({})",
+                                            e,
+                                            file_path.display()
+                                        );
+                                    },
+                                }
+                            }
+                        }
+                    }
+                }
+
+                // Watch for changes
+                let (mut changes, watcher) = fs.watch(&templates_dir, Duration::from_secs(1)).await;
+                while let Some(changed_paths) = changes.next().await {
+                    for changed_path in changed_paths {
+                        if changed_path.extension().map_or(false, |ext| ext == "hbs") {
+                            log::info!("Reloading template: {}", changed_path.display());
+                            if let Some(content) = fs.load(&changed_path).await.log_err() {
+                                let file_name = changed_path.file_stem().unwrap().to_string_lossy();
+                                let file_path = changed_path.to_string_lossy();
+                                match handlebars.lock().register_template_string(&file_name, content) {
+                                    Ok(_) => log::info!(
+                                        "Successfully reloaded template: {} ({})",
+                                        file_name,
+                                        file_path
+                                    ),
+                                    Err(e) => log::error!(
+                                        "Failed to register template: {} ({})",
+                                        e,
+                                        file_path
+                                    ),
+                                }
+                            }
+                        }
+                    }
+                }
+                drop(watcher);
             })
             .detach();
     }
 
-    fn register_built_in_templates(handlebars: &mut Handlebars) -> Result<()> {
-        for path in Assets.list("prompts")? {
-            if let Some(id) = path.split('/').last().and_then(|s| s.strip_suffix(".hbs")) {
-                if let Some(prompt) = Assets.load(path.as_ref()).log_err().flatten() {
-                    log::info!("Registering built-in prompt template: {}", id);
-                    handlebars
-                        .register_template_string(id, String::from_utf8_lossy(prompt.as_ref()))?
-                }
-            }
-        }
+    fn register_templates(handlebars: &mut Handlebars) -> Result<(), Box<TemplateError>> {
+        let mut register_template = |id: &str| {
+            let prompt = Assets::get(&format!("prompts/{}.hbs", id))
+                .unwrap_or_else(|| panic!("{} prompt template not found", id))
+                .data;
+            handlebars
+                .register_template_string(id, String::from_utf8_lossy(&prompt))
+                .map_err(Box::new)
+        };
+
+        register_template("content_prompt")?;
+        register_template("terminal_assistant_prompt")?;
+        register_template("edit_workflow")?;
+        register_template("step_resolution")?;
 
         Ok(())
     }
@@ -205,7 +162,8 @@ impl PromptBuilder {
         user_prompt: String,
         language_name: Option<&str>,
         buffer: BufferSnapshot,
-        range: Range<usize>,
+        transform_range: Range<usize>,
+        selected_ranges: Vec<Range<usize>>,
     ) -> Result<String, RenderError> {
         let content_type = match language_name {
             None | Some("Markdown" | "Plain Text") => "text",
@@ -213,21 +171,20 @@ impl PromptBuilder {
         };
 
         const MAX_CTX: usize = 50000;
-        let is_insert = range.is_empty();
         let mut is_truncated = false;
 
-        let before_range = 0..range.start;
+        let before_range = 0..transform_range.start;
         let truncated_before = if before_range.len() > MAX_CTX {
             is_truncated = true;
-            range.start - MAX_CTX..range.start
+            transform_range.start - MAX_CTX..transform_range.start
         } else {
             before_range
         };
 
-        let after_range = range.end..buffer.len();
+        let after_range = transform_range.end..buffer.len();
         let truncated_after = if after_range.len() > MAX_CTX {
             is_truncated = true;
-            range.end..range.end + MAX_CTX
+            transform_range.end..transform_range.end + MAX_CTX
         } else {
             after_range
         };
@@ -236,37 +193,61 @@ impl PromptBuilder {
         for chunk in buffer.text_for_range(truncated_before) {
             document_content.push_str(chunk);
         }
-        if is_insert {
-            document_content.push_str("<insert_here></insert_here>");
-        } else {
-            document_content.push_str("<rewrite_this>\n");
-            for chunk in buffer.text_for_range(range.clone()) {
-                document_content.push_str(chunk);
-            }
-            document_content.push_str("\n</rewrite_this>");
+        document_content.push_str("<rewrite_this>\n");
+        for chunk in buffer.text_for_range(transform_range.clone()) {
+            document_content.push_str(chunk);
         }
+        document_content.push_str("\n</rewrite_this>");
+
         for chunk in buffer.text_for_range(truncated_after) {
             document_content.push_str(chunk);
         }
 
-        let rewrite_section = if !is_insert {
-            let mut section = String::new();
-            for chunk in buffer.text_for_range(range.clone()) {
-                section.push_str(chunk);
+        let mut rewrite_section = String::new();
+        for chunk in buffer.text_for_range(transform_range.clone()) {
+            rewrite_section.push_str(chunk);
+        }
+
+        let rewrite_section_with_selections = {
+            let mut section_with_selections = String::new();
+            let mut last_end = 0;
+            for selected_range in &selected_ranges {
+                if selected_range.start > last_end {
+                    section_with_selections.push_str(
+                        &rewrite_section[last_end..selected_range.start - transform_range.start],
+                    );
+                }
+                if selected_range.start == selected_range.end {
+                    section_with_selections.push_str("<insert_here></insert_here>");
+                } else {
+                    section_with_selections.push_str("<edit_here>");
+                    section_with_selections.push_str(
+                        &rewrite_section[selected_range.start - transform_range.start
+                            ..selected_range.end - transform_range.start],
+                    );
+                    section_with_selections.push_str("</edit_here>");
+                }
+                last_end = selected_range.end - transform_range.start;
             }
-            Some(section)
-        } else {
-            None
+            if last_end < rewrite_section.len() {
+                section_with_selections.push_str(&rewrite_section[last_end..]);
+            }
+            section_with_selections
         };
 
+        let has_insertion = selected_ranges.iter().any(|range| range.start == range.end);
+        let has_replacement = selected_ranges.iter().any(|range| range.start != range.end);
+
         let context = ContentPromptContext {
             content_type: content_type.to_string(),
             language_name: language_name.map(|s| s.to_string()),
-            is_insert,
             is_truncated,
             document_content,
             user_prompt,
             rewrite_section,
+            rewrite_section_with_selections,
+            has_insertion,
+            has_replacement,
         };
 
         self.handlebars.lock().render("content_prompt", &context)
@@ -297,10 +278,7 @@ impl PromptBuilder {
         self.handlebars.lock().render("edit_workflow", &())
     }
 
-    pub fn generate_step_resolution_prompt(
-        &self,
-        context: &StepResolutionContext,
-    ) -> Result<String, RenderError> {
-        self.handlebars.lock().render("step_resolution", context)
+    pub fn generate_step_resolution_prompt(&self) -> Result<String, RenderError> {
+        self.handlebars.lock().render("step_resolution", &())
     }
 }

crates/assistant/src/slash_command.rs

@@ -1,6 +1,5 @@
 use crate::assistant_panel::ContextEditor;
 use anyhow::Result;
-use assistant_slash_command::AfterCompletion;
 pub use assistant_slash_command::{SlashCommand, SlashCommandOutput, SlashCommandRegistry};
 use editor::{CompletionProvider, Editor};
 use fuzzy::{match_strings, StringMatchCandidate};
@@ -19,7 +18,6 @@ use std::{
 use ui::ActiveTheme;
 use workspace::Workspace;
 
-pub mod context_server_command;
 pub mod default_command;
 pub mod diagnostics_command;
 pub mod docs_command;
@@ -30,7 +28,7 @@ pub mod project_command;
 pub mod prompt_command;
 pub mod search_command;
 pub mod symbols_command;
-pub mod tab_command;
+pub mod tabs_command;
 pub mod terminal_command;
 pub mod workflow_command;
 
@@ -43,8 +41,8 @@ pub(crate) struct SlashCommandCompletionProvider {
 pub(crate) struct SlashCommandLine {
     /// The range within the line containing the command name.
     pub name: Range<usize>,
-    /// Ranges within the line containing the command arguments.
-    pub arguments: Vec<Range<usize>>,
+    /// The range within the line containing the command argument.
+    pub argument: Option<Range<usize>>,
 }
 
 impl SlashCommandCompletionProvider {
@@ -98,45 +96,38 @@ impl SlashCommandCompletionProvider {
                         let command = commands.command(&mat.string)?;
                         let mut new_text = mat.string.clone();
                         let requires_argument = command.requires_argument();
-                        let accepts_arguments = command.accepts_arguments();
-                        if requires_argument || accepts_arguments {
+                        if requires_argument {
                             new_text.push(' ');
                         }
 
-                        let confirm =
-                            editor
-                                .clone()
-                                .zip(workspace.clone())
-                                .map(|(editor, workspace)| {
+                        let confirm = editor.clone().zip(workspace.clone()).and_then(
+                            |(editor, workspace)| {
+                                (!requires_argument).then(|| {
                                     let command_name = mat.string.clone();
                                     let command_range = command_range.clone();
                                     let editor = editor.clone();
                                     let workspace = workspace.clone();
                                     Arc::new(
                                         move |intent: CompletionIntent, cx: &mut WindowContext| {
-                                            if !requires_argument
-                                                && (!accepts_arguments || intent.is_complete())
-                                            {
+                                            if intent.is_complete() {
                                                 editor
                                                     .update(cx, |editor, cx| {
                                                         editor.run_command(
                                                             command_range.clone(),
                                                             &command_name,
-                                                            &[],
+                                                            None,
                                                             true,
-                                                            false,
                                                             workspace.clone(),
                                                             cx,
                                                         );
                                                     })
                                                     .ok();
-                                                false
-                                            } else {
-                                                requires_argument || accepts_arguments
                                             }
                                         },
                                     ) as Arc<_>
-                                });
+                                })
+                            },
+                        );
                         Some(project::Completion {
                             old_range: name_range.clone(),
                             documentation: Some(Documentation::SingleLine(command.description())),
@@ -144,6 +135,7 @@ impl SlashCommandCompletionProvider {
                             label: command.label(cx),
                             server_id: LanguageServerId(0),
                             lsp_completion: Default::default(),
+                            show_new_completions_on_confirm: requires_argument,
                             confirm,
                         })
                     })
@@ -155,10 +147,9 @@ impl SlashCommandCompletionProvider {
     fn complete_command_argument(
         &self,
         command_name: &str,
-        arguments: &[String],
+        argument: String,
         command_range: Range<Anchor>,
         argument_range: Range<Anchor>,
-        last_argument_range: Range<Anchor>,
         cx: &mut WindowContext,
     ) -> Task<Result<Vec<project::Completion>>> {
         let new_cancel_flag = Arc::new(AtomicBool::new(false));
@@ -168,7 +159,7 @@ impl SlashCommandCompletionProvider {
         let commands = SlashCommandRegistry::global(cx);
         if let Some(command) = commands.command(command_name) {
             let completions = command.complete_argument(
-                arguments,
+                argument,
                 new_cancel_flag.clone(),
                 self.workspace.clone(),
                 cx,
@@ -176,76 +167,63 @@ impl SlashCommandCompletionProvider {
             let command_name: Arc<str> = command_name.into();
             let editor = self.editor.clone();
             let workspace = self.workspace.clone();
-            let arguments = arguments.to_vec();
             cx.background_executor().spawn(async move {
                 Ok(completions
                     .await?
                     .into_iter()
-                    .map(|new_argument| {
-                        let confirm =
+                    .map(|command_argument| {
+                        let confirm = if command_argument.run_command {
                             editor
                                 .clone()
                                 .zip(workspace.clone())
                                 .map(|(editor, workspace)| {
                                     Arc::new({
-                                        let mut completed_arguments = arguments.clone();
-                                        if new_argument.replace_previous_arguments {
-                                            completed_arguments.clear();
-                                        } else {
-                                            completed_arguments.pop();
-                                        }
-                                        completed_arguments.push(new_argument.new_text.clone());
-
                                         let command_range = command_range.clone();
                                         let command_name = command_name.clone();
+                                        let command_argument = command_argument.new_text.clone();
                                         move |intent: CompletionIntent, cx: &mut WindowContext| {
-                                            if new_argument.after_completion.run()
-                                                || intent.is_complete()
-                                            {
+                                            if intent.is_complete() {
                                                 editor
                                                     .update(cx, |editor, cx| {
                                                         editor.run_command(
                                                             command_range.clone(),
                                                             &command_name,
-                                                            &completed_arguments,
+                                                            Some(&command_argument),
                                                             true,
-                                                            false,
                                                             workspace.clone(),
                                                             cx,
                                                         );
                                                     })
                                                     .ok();
-                                                false
-                                            } else {
-                                                !new_argument.after_completion.run()
                                             }
                                         }
                                     }) as Arc<_>
-                                });
+                                })
+                        } else {
+                            None
+                        };
 
-                        let mut new_text = new_argument.new_text.clone();
-                        if new_argument.after_completion == AfterCompletion::Continue {
+                        let mut new_text = command_argument.new_text.clone();
+                        if !command_argument.run_command {
                             new_text.push(' ');
                         }
 
                         project::Completion {
-                            old_range: if new_argument.replace_previous_arguments {
-                                argument_range.clone()
-                            } else {
-                                last_argument_range.clone()
-                            },
-                            label: new_argument.label,
+                            old_range: argument_range.clone(),
+                            label: command_argument.label,
                             new_text,
                             documentation: None,
                             server_id: LanguageServerId(0),
                             lsp_completion: Default::default(),
+                            show_new_completions_on_confirm: !command_argument.run_command,
                             confirm,
                         }
                     })
                     .collect())
             })
         } else {
-            Task::ready(Ok(Vec::new()))
+            cx.background_executor()
+                .spawn(async move { Ok(Vec::new()) })
         }
     }
 }
@@ -258,7 +236,7 @@ impl CompletionProvider for SlashCommandCompletionProvider {
         _: editor::CompletionContext,
         cx: &mut ViewContext<Editor>,
     ) -> Task<Result<Vec<project::Completion>>> {
-        let Some((name, arguments, command_range, last_argument_range)) =
+        let Some((name, argument, command_range, argument_range)) =
             buffer.update(cx, |buffer, _cx| {
                 let position = buffer_position.to_point(buffer);
                 let line_start = Point::new(position.row, 0);
@@ -269,52 +247,32 @@ impl CompletionProvider for SlashCommandCompletionProvider {
                 let command_range_start = Point::new(position.row, call.name.start as u32 - 1);
                 let command_range_end = Point::new(
                     position.row,
-                    call.arguments.last().map_or(call.name.end, |arg| arg.end) as u32,
+                    call.argument.as_ref().map_or(call.name.end, |arg| arg.end) as u32,
                 );
                 let command_range = buffer.anchor_after(command_range_start)
                     ..buffer.anchor_after(command_range_end);
 
                 let name = line[call.name.clone()].to_string();
-                let (arguments, last_argument_range) = if let Some(argument) = call.arguments.last()
-                {
-                    let last_arg_start =
+
+                Some(if let Some(argument) = call.argument {
+                    let start =
                         buffer.anchor_after(Point::new(position.row, argument.start as u32));
-                    let first_arg_start = call.arguments.first().expect("we have the last element");
-                    let first_arg_start =
-                        buffer.anchor_after(Point::new(position.row, first_arg_start.start as u32));
-                    let arguments = call
-                        .arguments
-                        .iter()
-                        .filter_map(|argument| Some(line.get(argument.clone())?.to_string()))
-                        .collect::<Vec<_>>();
-                    let argument_range = first_arg_start..buffer_position;
-                    (
-                        Some((arguments, argument_range)),
-                        last_arg_start..buffer_position,
-                    )
+                    let argument = line[argument.clone()].to_string();
+                    (name, Some(argument), command_range, start..buffer_position)
                 } else {
                     let start =
                         buffer.anchor_after(Point::new(position.row, call.name.start as u32));
-                    (None, start..buffer_position)
-                };
-
-                Some((name, arguments, command_range, last_argument_range))
+                    (name, None, command_range, start..buffer_position)
+                })
             })
         else {
             return Task::ready(Ok(Vec::new()));
         };
 
-        if let Some((arguments, argument_range)) = arguments {
-            self.complete_command_argument(
-                &name,
-                &arguments,
-                command_range,
-                argument_range,
-                last_argument_range,
-                cx,
-            )
+        if let Some(argument) = argument {
+            self.complete_command_argument(&name, argument, command_range, argument_range, cx)
         } else {
-            self.complete_command_name(&name, command_range, last_argument_range, cx)
+            self.complete_command_name(&name, command_range, argument_range, cx)
         }
     }
 
@@ -356,10 +314,6 @@ impl CompletionProvider for SlashCommandCompletionProvider {
             false
         }
     }
-
-    fn sort_completions(&self) -> bool {
-        false
-    }
 }
 
 impl SlashCommandLine {
@@ -371,23 +325,16 @@ impl SlashCommandLine {
             if let Some(call) = &mut call {
                 // The command arguments start at the first non-whitespace character
                 // after the command name, and continue until the end of the line.
-                if let Some(argument) = call.arguments.last_mut() {
-                    if c.is_whitespace() {
-                        if (*argument).is_empty() {
-                            argument.start = next_ix;
-                            argument.end = next_ix;
-                        } else {
-                            argument.end = ix;
-                            call.arguments.push(next_ix..next_ix);
-                        }
-                    } else {
-                        argument.end = next_ix;
+                if let Some(argument) = &mut call.argument {
+                    if (*argument).is_empty() && c.is_whitespace() {
+                        argument.start = next_ix;
                     }
+                    argument.end = next_ix;
                 }
                 // The command name ends at the first whitespace character.
                 else if !call.name.is_empty() {
                     if c.is_whitespace() {
-                        call.arguments = vec![next_ix..next_ix];
+                        call.argument = Some(next_ix..next_ix);
                     } else {
                         call.name.end = next_ix;
                     }
@@ -403,7 +350,7 @@ impl SlashCommandLine {
             else if c == '/' {
                 call = Some(SlashCommandLine {
                     name: next_ix..next_ix,
-                    arguments: Vec::new(),
+                    argument: None,
                 });
             }
             // The line can't contain anything before the slash except for whitespace.

crates/assistant/src/slash_command/context_server_command.rs

@@ -1,134 +0,0 @@
-use anyhow::{anyhow, Result};
-use assistant_slash_command::{
-    ArgumentCompletion, SlashCommand, SlashCommandOutput, SlashCommandOutputSection,
-};
-use collections::HashMap;
-use context_servers::{
-    manager::{ContextServer, ContextServerManager},
-    protocol::PromptInfo,
-};
-use gpui::{Task, WeakView, WindowContext};
-use language::LspAdapterDelegate;
-use std::sync::atomic::AtomicBool;
-use std::sync::Arc;
-use ui::{IconName, SharedString};
-use workspace::Workspace;
-
-pub struct ContextServerSlashCommand {
-    server_id: String,
-    prompt: PromptInfo,
-}
-
-impl ContextServerSlashCommand {
-    pub fn new(server: &Arc<ContextServer>, prompt: PromptInfo) -> Self {
-        Self {
-            server_id: server.id.clone(),
-            prompt,
-        }
-    }
-}
-
-impl SlashCommand for ContextServerSlashCommand {
-    fn name(&self) -> String {
-        self.prompt.name.clone()
-    }
-
-    fn description(&self) -> String {
-        format!("Run context server command: {}", self.prompt.name)
-    }
-
-    fn menu_text(&self) -> String {
-        format!("Run '{}' from {}", self.prompt.name, self.server_id)
-    }
-
-    fn requires_argument(&self) -> bool {
-        self.prompt
-            .arguments
-            .as_ref()
-            .map_or(false, |args| !args.is_empty())
-    }
-
-    fn complete_argument(
-        self: Arc<Self>,
-        _arguments: &[String],
-        _cancel: Arc<AtomicBool>,
-        _workspace: Option<WeakView<Workspace>>,
-        _cx: &mut WindowContext,
-    ) -> Task<Result<Vec<ArgumentCompletion>>> {
-        Task::ready(Ok(Vec::new()))
-    }
-
-    fn run(
-        self: Arc<Self>,
-        arguments: &[String],
-        _workspace: WeakView<Workspace>,
-        _delegate: Option<Arc<dyn LspAdapterDelegate>>,
-        cx: &mut WindowContext,
-    ) -> Task<Result<SlashCommandOutput>> {
-        let server_id = self.server_id.clone();
-        let prompt_name = self.prompt.name.clone();
-
-        let prompt_args = match prompt_arguments(&self.prompt, arguments) {
-            Ok(args) => args,
-            Err(e) => return Task::ready(Err(e)),
-        };
-
-        let manager = ContextServerManager::global(cx);
-        let manager = manager.read(cx);
-        if let Some(server) = manager.get_server(&server_id) {
-            cx.foreground_executor().spawn(async move {
-                let Some(protocol) = server.client.read().clone() else {
-                    return Err(anyhow!("Context server not initialized"));
-                };
-                let result = protocol.run_prompt(&prompt_name, prompt_args).await?;
-
-                Ok(SlashCommandOutput {
-                    sections: vec![SlashCommandOutputSection {
-                        range: 0..result.len(),
-                        icon: IconName::ZedAssistant,
-                        label: SharedString::from(format!("Result from {}", prompt_name)),
-                    }],
-                    text: result,
-                    run_commands_in_text: false,
-                })
-            })
-        } else {
-            Task::ready(Err(anyhow!("Context server not found")))
-        }
-    }
-}
-
-fn prompt_arguments(prompt: &PromptInfo, arguments: &[String]) -> Result<HashMap<String, String>> {
-    match &prompt.arguments {
-        Some(args) if args.len() > 1 => Err(anyhow!(
-            "Prompt has more than one argument, which is not supported"
-        )),
-        Some(args) if args.len() == 1 => {
-            if !arguments.is_empty() {
-                let mut map = HashMap::default();
-                map.insert(args[0].name.clone(), arguments.join(" "));
-                Ok(map)
-            } else {
-                Err(anyhow!("Prompt expects argument but none given"))
-            }
-        }
-        Some(_) | None => {
-            if arguments.is_empty() {
-                Ok(HashMap::default())
-            } else {
-                Err(anyhow!("Prompt expects no arguments but some were given"))
-            }
-        }
-    }
-}
-
-/// MCP servers can return prompts with multiple arguments. Since we only
-/// support one argument, we ignore all others. This is the necessary predicate
-/// for this.
-pub fn acceptable_prompt(prompt: &PromptInfo) -> bool {
-    match &prompt.arguments {
-        None => true,
-        Some(args) if args.len() == 1 => true,
-        _ => false,
-    }
-}

crates/assistant/src/slash_command/default_command.rs

@@ -32,7 +32,7 @@ impl SlashCommand for DefaultSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        _arguments: &[String],
+        _query: String,
         _cancellation_flag: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         _cx: &mut WindowContext,
@@ -42,7 +42,7 @@ impl SlashCommand for DefaultSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        _arguments: &[String],
+        _argument: Option<&str>,
         _workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,

crates/assistant/src/slash_command/diagnostics_command.rs

@@ -103,13 +103,9 @@ impl SlashCommand for DiagnosticsSlashCommand {
         false
     }
 
-    fn accepts_arguments(&self) -> bool {
-        true
-    }
-
     fn complete_argument(
         self: Arc<Self>,
-        arguments: &[String],
+        query: String,
         cancellation_flag: Arc<AtomicBool>,
         workspace: Option<WeakView<Workspace>>,
         cx: &mut WindowContext,
@@ -117,7 +113,7 @@ impl SlashCommand for DiagnosticsSlashCommand {
         let Some(workspace) = workspace.and_then(|workspace| workspace.upgrade()) else {
             return Task::ready(Err(anyhow!("workspace was dropped")));
         };
-        let query = arguments.last().cloned().unwrap_or_default();
+        let query = query.split_whitespace().last().unwrap_or("").to_string();
 
         let paths = self.search_paths(query.clone(), cancellation_flag.clone(), &workspace, cx);
         let executor = cx.background_executor().clone();
@@ -153,8 +149,7 @@ impl SlashCommand for DiagnosticsSlashCommand {
                 .map(|completion| ArgumentCompletion {
                     label: completion.clone().into(),
                     new_text: completion,
-                    after_completion: assistant_slash_command::AfterCompletion::Run,
-                    replace_previous_arguments: false,
+                    run_command: true,
                 })
                 .collect())
         })
@@ -162,7 +157,7 @@ impl SlashCommand for DiagnosticsSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        arguments: &[String],
+        argument: Option<&str>,
         workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,
@@ -171,7 +166,7 @@ impl SlashCommand for DiagnosticsSlashCommand {
             return Task::ready(Err(anyhow!("workspace was dropped")));
         };
 
-        let options = Options::parse(arguments);
+        let options = Options::parse(argument);
 
         let task = collect_diagnostics(workspace.read(cx).project().clone(), options, cx);
 
@@ -249,20 +244,25 @@ struct Options {
 const INCLUDE_WARNINGS_ARGUMENT: &str = "--include-warnings";
 
 impl Options {
-    fn parse(arguments: &[String]) -> Self {
-        let mut include_warnings = false;
-        let mut path_matcher = None;
-        for arg in arguments {
-            if arg == INCLUDE_WARNINGS_ARGUMENT {
-                include_warnings = true;
-            } else {
-                path_matcher = PathMatcher::new(&[arg.to_owned()]).log_err();
-            }
-        }
-        Self {
-            include_warnings,
-            path_matcher,
-        }
+    fn parse(arguments_line: Option<&str>) -> Self {
+        arguments_line
+            .map(|arguments_line| {
+                let args = arguments_line.split_whitespace().collect::<Vec<_>>();
+                let mut include_warnings = false;
+                let mut path_matcher = None;
+                for arg in args {
+                    if arg == INCLUDE_WARNINGS_ARGUMENT {
+                        include_warnings = true;
+                    } else {
+                        path_matcher = PathMatcher::new(&[arg.to_owned()]).log_err();
+                    }
+                }
+                Self {
+                    include_warnings,
+                    path_matcher,
+                }
+            })
+            .unwrap_or_default()
     }
 
     fn match_candidates_for_args() -> [StringMatchCandidate; 1] {

crates/assistant/src/slash_command/docs_command.rs

@@ -161,7 +161,7 @@ impl SlashCommand for DocsSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        arguments: &[String],
+        query: String,
         _cancel: Arc<AtomicBool>,
         workspace: Option<WeakView<Workspace>>,
         cx: &mut WindowContext,
@@ -169,20 +169,22 @@ impl SlashCommand for DocsSlashCommand {
         self.ensure_rust_doc_providers_are_registered(workspace, cx);
 
         let indexed_docs_registry = IndexedDocsRegistry::global(cx);
-        let args = DocsSlashCommandArgs::parse(arguments);
+        let args = DocsSlashCommandArgs::parse(&query);
         let store = args
             .provider()
             .ok_or_else(|| anyhow!("no docs provider specified"))
             .and_then(|provider| IndexedDocsStore::try_global(provider, cx));
         cx.background_executor().spawn(async move {
-            fn build_completions(items: Vec<String>) -> Vec<ArgumentCompletion> {
+            fn build_completions(
+                provider: ProviderId,
+                items: Vec<String>,
+            ) -> Vec<ArgumentCompletion> {
                 items
                     .into_iter()
                     .map(|item| ArgumentCompletion {
                         label: item.clone().into(),
-                        new_text: item.to_string(),
-                        after_completion: assistant_slash_command::AfterCompletion::Run,
-                        replace_previous_arguments: false,
+                        new_text: format!("{provider} {item}"),
+                        run_command: true,
                     })
                     .collect()
             }
@@ -194,8 +196,7 @@ impl SlashCommand for DocsSlashCommand {
                         return Ok(vec![ArgumentCompletion {
                             label: "No available docs providers.".into(),
                             new_text: String::new(),
-                            after_completion: false.into(),
-                            replace_previous_arguments: false,
+                            run_command: false,
                         }]);
                     }
 
@@ -204,8 +205,7 @@ impl SlashCommand for DocsSlashCommand {
                         .map(|provider| ArgumentCompletion {
                             label: provider.to_string().into(),
                             new_text: provider.to_string(),
-                            after_completion: false.into(),
-                            replace_previous_arguments: false,
+                            run_command: false,
                         })
                         .collect())
                 }
@@ -225,7 +225,7 @@ impl SlashCommand for DocsSlashCommand {
                     let suggested_packages = store.clone().suggest_packages().await?;
                     let search_results = store.search(package).await;
 
-                    let mut items = build_completions(search_results);
+                    let mut items = build_completions(provider.clone(), search_results);
                     let workspace_crate_completions = suggested_packages
                         .into_iter()
                         .filter(|package_name| {
@@ -235,9 +235,8 @@ impl SlashCommand for DocsSlashCommand {
                         })
                         .map(|package_name| ArgumentCompletion {
                             label: format!("{package_name} (unindexed)").into(),
-                            new_text: format!("{package_name}"),
-                            after_completion: true.into(),
-                            replace_previous_arguments: false,
+                            new_text: format!("{provider} {package_name}"),
+                            run_command: true,
                         })
                         .collect::<Vec<_>>();
                     items.extend(workspace_crate_completions);
@@ -250,17 +249,20 @@ impl SlashCommand for DocsSlashCommand {
                             )
                             .into(),
                             new_text: provider.to_string(),
-                            after_completion: false.into(),
-                            replace_previous_arguments: false,
+                            run_command: false,
                         }]);
                     }
 
                     Ok(items)
                 }
-                DocsSlashCommandArgs::SearchItemDocs { item_path, .. } => {
+                DocsSlashCommandArgs::SearchItemDocs {
+                    provider,
+                    item_path,
+                    ..
+                } => {
                     let store = store?;
                     let items = store.search(item_path).await;
-                    Ok(build_completions(items))
+                    Ok(build_completions(provider, items))
                 }
             }
         })
@@ -268,16 +270,16 @@ impl SlashCommand for DocsSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        arguments: &[String],
+        argument: Option<&str>,
         _workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,
     ) -> Task<Result<SlashCommandOutput>> {
-        if arguments.is_empty() {
-            return Task::ready(Err(anyhow!("missing an argument")));
+        let Some(argument) = argument else {
+            return Task::ready(Err(anyhow!("missing argument")));
         };
 
-        let args = DocsSlashCommandArgs::parse(arguments);
+        let args = DocsSlashCommandArgs::parse(argument);
         let executor = cx.background_executor().clone();
         let task = cx.background_executor().spawn({
             let store = args
@@ -377,18 +379,12 @@ pub(crate) enum DocsSlashCommandArgs {
 }
 
 impl DocsSlashCommandArgs {
-    pub fn parse(arguments: &[String]) -> Self {
-        let Some(provider) = arguments
-            .get(0)
-            .cloned()
-            .filter(|arg| !arg.trim().is_empty())
-        else {
+    pub fn parse(argument: &str) -> Self {
+        let Some((provider, argument)) = argument.split_once(' ') else {
             return Self::NoProvider;
         };
+
         let provider = ProviderId(provider.into());
-        let Some(argument) = arguments.get(1) else {
-            return Self::NoProvider;
-        };
 
         if let Some((package, rest)) = argument.split_once(is_item_path_delimiter) {
             if rest.trim().is_empty() {
@@ -448,16 +444,16 @@ mod tests {
     #[test]
     fn test_parse_docs_slash_command_args() {
         assert_eq!(
-            DocsSlashCommandArgs::parse(&["".to_string()]),
+            DocsSlashCommandArgs::parse(""),
             DocsSlashCommandArgs::NoProvider
         );
         assert_eq!(
-            DocsSlashCommandArgs::parse(&["rustdoc".to_string()]),
+            DocsSlashCommandArgs::parse("rustdoc"),
             DocsSlashCommandArgs::NoProvider
         );
 
         assert_eq!(
-            DocsSlashCommandArgs::parse(&["rustdoc".to_string(), "".to_string()]),
+            DocsSlashCommandArgs::parse("rustdoc "),
             DocsSlashCommandArgs::SearchPackageDocs {
                 provider: ProviderId("rustdoc".into()),
                 package: "".into(),
@@ -465,7 +461,7 @@ mod tests {
             }
         );
         assert_eq!(
-            DocsSlashCommandArgs::parse(&["gleam".to_string(), "".to_string()]),
+            DocsSlashCommandArgs::parse("gleam "),
             DocsSlashCommandArgs::SearchPackageDocs {
                 provider: ProviderId("gleam".into()),
                 package: "".into(),
@@ -474,7 +470,7 @@ mod tests {
         );
 
         assert_eq!(
-            DocsSlashCommandArgs::parse(&["rustdoc".to_string(), "gpui".to_string()]),
+            DocsSlashCommandArgs::parse("rustdoc gpui"),
             DocsSlashCommandArgs::SearchPackageDocs {
                 provider: ProviderId("rustdoc".into()),
                 package: "gpui".into(),
@@ -482,7 +478,7 @@ mod tests {
             }
         );
         assert_eq!(
-            DocsSlashCommandArgs::parse(&["gleam".to_string(), "gleam_stdlib".to_string()]),
+            DocsSlashCommandArgs::parse("gleam gleam_stdlib"),
             DocsSlashCommandArgs::SearchPackageDocs {
                 provider: ProviderId("gleam".into()),
                 package: "gleam_stdlib".into(),
@@ -492,7 +488,7 @@ mod tests {
 
         // Adding an item path delimiter indicates we can start indexing.
         assert_eq!(
-            DocsSlashCommandArgs::parse(&["rustdoc".to_string(), "gpui:".to_string()]),
+            DocsSlashCommandArgs::parse("rustdoc gpui:"),
             DocsSlashCommandArgs::SearchPackageDocs {
                 provider: ProviderId("rustdoc".into()),
                 package: "gpui".into(),
@@ -500,7 +496,7 @@ mod tests {
             }
         );
         assert_eq!(
-            DocsSlashCommandArgs::parse(&["gleam".to_string(), "gleam_stdlib/".to_string()]),
+            DocsSlashCommandArgs::parse("gleam gleam_stdlib/"),
             DocsSlashCommandArgs::SearchPackageDocs {
                 provider: ProviderId("gleam".into()),
                 package: "gleam_stdlib".into(),
@@ -509,10 +505,7 @@ mod tests {
         );
 
         assert_eq!(
-            DocsSlashCommandArgs::parse(&[
-                "rustdoc".to_string(),
-                "gpui::foo::bar::Baz".to_string()
-            ]),
+            DocsSlashCommandArgs::parse("rustdoc gpui::foo::bar::Baz"),
             DocsSlashCommandArgs::SearchItemDocs {
                 provider: ProviderId("rustdoc".into()),
                 package: "gpui".into(),
@@ -520,10 +513,7 @@ mod tests {
             }
         );
         assert_eq!(
-            DocsSlashCommandArgs::parse(&[
-                "gleam".to_string(),
-                "gleam_stdlib/gleam/int".to_string()
-            ]),
+            DocsSlashCommandArgs::parse("gleam gleam_stdlib/gleam/int"),
             DocsSlashCommandArgs::SearchItemDocs {
                 provider: ProviderId("gleam".into()),
                 package: "gleam_stdlib".into(),

crates/assistant/src/slash_command/fetch_command.rs

@@ -117,7 +117,7 @@ impl SlashCommand for FetchSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        _arguments: &[String],
+        _query: String,
         _cancel: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         _cx: &mut WindowContext,
@@ -127,12 +127,12 @@ impl SlashCommand for FetchSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        arguments: &[String],
+        argument: Option<&str>,
         workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,
     ) -> Task<Result<SlashCommandOutput>> {
-        let Some(argument) = arguments.first() else {
+        let Some(argument) = argument else {
             return Task::ready(Err(anyhow!("missing URL")));
         };
         let Some(workspace) = workspace.upgrade() else {

crates/assistant/src/slash_command/file_command.rs

@@ -1,6 +1,6 @@
 use super::{diagnostics_command::write_single_file_diagnostics, SlashCommand, SlashCommandOutput};
-use anyhow::{anyhow, Context as _, Result};
-use assistant_slash_command::{AfterCompletion, ArgumentCompletion, SlashCommandOutputSection};
+use anyhow::{anyhow, Result};
+use assistant_slash_command::{ArgumentCompletion, SlashCommandOutputSection};
 use fuzzy::PathMatch;
 use gpui::{AppContext, Model, Task, View, WeakView};
 use language::{BufferSnapshot, CodeLabel, HighlightId, LineEnding, LspAdapterDelegate};
@@ -12,7 +12,7 @@ use std::{
     sync::{atomic::AtomicBool, Arc},
 };
 use ui::prelude::*;
-use util::ResultExt;
+use util::{paths::PathMatcher, ResultExt};
 use workspace::Workspace;
 
 pub(crate) struct FileSlashCommand;
@@ -122,7 +122,7 @@ impl SlashCommand for FileSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        arguments: &[String],
+        query: String,
         cancellation_flag: Arc<AtomicBool>,
         workspace: Option<WeakView<Workspace>>,
         cx: &mut WindowContext,
@@ -131,12 +131,7 @@ impl SlashCommand for FileSlashCommand {
             return Task::ready(Err(anyhow!("workspace was dropped")));
         };
 
-        let paths = self.search_paths(
-            arguments.last().cloned().unwrap_or_default(),
-            cancellation_flag,
-            &workspace,
-            cx,
-        );
+        let paths = self.search_paths(query, cancellation_flag, &workspace, cx);
         let comment_id = cx.theme().syntax().highlight_id("comment").map(HighlightId);
         cx.background_executor().spawn(async move {
             Ok(paths
@@ -164,12 +159,7 @@ impl SlashCommand for FileSlashCommand {
                     Some(ArgumentCompletion {
                         label,
                         new_text: text,
-                        after_completion: if path_match.is_dir {
-                            AfterCompletion::Compose
-                        } else {
-                            AfterCompletion::Run
-                        },
-                        replace_previous_arguments: false,
+                        run_command: true,
                     })
                 })
                 .collect())
@@ -178,7 +168,7 @@ impl SlashCommand for FileSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        arguments: &[String],
+        argument: Option<&str>,
         workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,
@@ -187,24 +177,23 @@ impl SlashCommand for FileSlashCommand {
             return Task::ready(Err(anyhow!("workspace was dropped")));
         };
 
-        if arguments.is_empty() {
+        let Some(argument) = argument else {
             return Task::ready(Err(anyhow!("missing path")));
         };
 
-        let task = collect_files(workspace.read(cx).project().clone(), arguments, cx);
+        let task = collect_files(workspace.read(cx).project().clone(), argument, cx);
 
         cx.foreground_executor().spawn(async move {
-            let output = task.await?;
+            let (text, ranges) = task.await?;
             Ok(SlashCommandOutput {
-                text: output.completion_text,
-                sections: output
-                    .files
+                text,
+                sections: ranges
                     .into_iter()
-                    .map(|file| {
+                    .map(|(range, path, entry_type)| {
                         build_entry_output_section(
-                            file.range_in_text,
-                            Some(&file.path),
-                            file.entry_type == EntryType::Directory,
+                            range,
+                            Some(&path),
+                            entry_type == EntryType::Directory,
                             None,
                         )
                     })
@@ -215,38 +204,18 @@ impl SlashCommand for FileSlashCommand {
     }
 }
 
-#[derive(Clone, Copy, PartialEq, Debug)]
+#[derive(Clone, Copy, PartialEq)]
 enum EntryType {
     File,
     Directory,
 }
 
-#[derive(Clone, PartialEq, Debug)]
-struct FileCommandOutput {
-    completion_text: String,
-    files: Vec<OutputFile>,
-}
-
-#[derive(Clone, PartialEq, Debug)]
-struct OutputFile {
-    range_in_text: Range<usize>,
-    path: PathBuf,
-    entry_type: EntryType,
-}
-
 fn collect_files(
     project: Model<Project>,
-    glob_inputs: &[String],
+    glob_input: &str,
     cx: &mut AppContext,
-) -> Task<Result<FileCommandOutput>> {
-    let Ok(matchers) = glob_inputs
-        .into_iter()
-        .map(|glob_input| {
-            custom_path_matcher::PathMatcher::new(&[glob_input.to_owned()])
-                .with_context(|| format!("invalid path {glob_input}"))
-        })
-        .collect::<anyhow::Result<Vec<custom_path_matcher::PathMatcher>>>()
-    else {
+) -> Task<Result<(String, Vec<(Range<usize>, PathBuf, EntryType)>)>> {
+    let Ok(matcher) = PathMatcher::new(&[glob_input.to_owned()]) else {
         return Task::ready(Err(anyhow!("invalid path")));
     };
 
@@ -256,7 +225,6 @@ fn collect_files(
         .worktrees(cx)
         .map(|worktree| worktree.read(cx).snapshot())
         .collect::<Vec<_>>();
-
     cx.spawn(|mut cx| async move {
         let mut text = String::new();
         let mut ranges = Vec::new();
@@ -265,16 +233,11 @@ fn collect_files(
             let mut directory_stack: Vec<(Arc<Path>, String, usize)> = Vec::new();
             let mut folded_directory_names_stack = Vec::new();
             let mut is_top_level_directory = true;
-
             for entry in snapshot.entries(false, 0) {
                 let mut path_including_worktree_name = PathBuf::new();
                 path_including_worktree_name.push(snapshot.root_name());
                 path_including_worktree_name.push(&entry.path);
-
-                if !matchers
-                    .iter()
-                    .any(|matcher| matcher.is_match(&path_including_worktree_name))
-                {
+                if !matcher.is_match(&path_including_worktree_name) {
                     continue;
                 }
 
@@ -283,11 +246,11 @@ fn collect_files(
                         break;
                     }
                     let (_, entry_name, start) = directory_stack.pop().unwrap();
-                    ranges.push(OutputFile {
-                        range_in_text: start..text.len().saturating_sub(1),
-                        path: PathBuf::from(entry_name),
-                        entry_type: EntryType::Directory,
-                    });
+                    ranges.push((
+                        start..text.len().saturating_sub(1),
+                        PathBuf::from(entry_name),
+                        EntryType::Directory,
+                    ));
                 }
 
                 let filename = entry
@@ -360,39 +323,24 @@ fn collect_files(
                         ) {
                             text.pop();
                         }
-                        ranges.push(OutputFile {
-                            range_in_text: prev_len..text.len(),
-                            path: path_including_worktree_name,
-                            entry_type: EntryType::File,
-                        });
+                        ranges.push((
+                            prev_len..text.len(),
+                            path_including_worktree_name,
+                            EntryType::File,
+                        ));
                         text.push('\n');
                     }
                 }
             }
 
-            while let Some((dir, entry, start)) = directory_stack.pop() {
-                if directory_stack.is_empty() {
-                    let mut root_path = PathBuf::new();
-                    root_path.push(snapshot.root_name());
-                    root_path.push(&dir);
-                    ranges.push(OutputFile {
-                        range_in_text: start..text.len(),
-                        path: root_path,
-                        entry_type: EntryType::Directory,
-                    });
-                } else {
-                    ranges.push(OutputFile {
-                        range_in_text: start..text.len(),
-                        path: PathBuf::from(entry.as_str()),
-                        entry_type: EntryType::Directory,
-                    });
-                }
+            while let Some((dir, _, start)) = directory_stack.pop() {
+                let mut root_path = PathBuf::new();
+                root_path.push(snapshot.root_name());
+                root_path.push(&dir);
+                ranges.push((start..text.len(), root_path, EntryType::Directory));
             }
         }
-        Ok(FileCommandOutput {
-            completion_text: text,
-            files: ranges,
-        })
+        Ok((text, ranges))
     })
 }
 
@@ -460,300 +408,3 @@ pub fn build_entry_output_section(
         label: label.into(),
     }
 }
-
-/// This contains a small fork of the util::paths::PathMatcher, that is stricter about the prefix
-/// check. Only subpaths pass the prefix check, rather than any prefix.
-mod custom_path_matcher {
-    use std::{fmt::Debug as _, path::Path};
-
-    use globset::{Glob, GlobSet, GlobSetBuilder};
-
-    #[derive(Clone, Debug, Default)]
-    pub struct PathMatcher {
-        sources: Vec<String>,
-        sources_with_trailing_slash: Vec<String>,
-        glob: GlobSet,
-    }
-
-    impl std::fmt::Display for PathMatcher {
-        fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-            self.sources.fmt(f)
-        }
-    }
-
-    impl PartialEq for PathMatcher {
-        fn eq(&self, other: &Self) -> bool {
-            self.sources.eq(&other.sources)
-        }
-    }
-
-    impl Eq for PathMatcher {}
-
-    impl PathMatcher {
-        pub fn new(globs: &[String]) -> Result<Self, globset::Error> {
-            let globs = globs
-                .into_iter()
-                .map(|glob| Glob::new(&glob))
-                .collect::<Result<Vec<_>, _>>()?;
-            let sources = globs.iter().map(|glob| glob.glob().to_owned()).collect();
-            let sources_with_trailing_slash = globs
-                .iter()
-                .map(|glob| glob.glob().to_string() + std::path::MAIN_SEPARATOR_STR)
-                .collect();
-            let mut glob_builder = GlobSetBuilder::new();
-            for single_glob in globs {
-                glob_builder.add(single_glob);
-            }
-            let glob = glob_builder.build()?;
-            Ok(PathMatcher {
-                glob,
-                sources,
-                sources_with_trailing_slash,
-            })
-        }
-
-        pub fn sources(&self) -> &[String] {
-            &self.sources
-        }
-
-        pub fn is_match<P: AsRef<Path>>(&self, other: P) -> bool {
-            let other_path = other.as_ref();
-            self.sources
-                .iter()
-                .zip(self.sources_with_trailing_slash.iter())
-                .any(|(source, with_slash)| {
-                    let as_bytes = other_path.as_os_str().as_encoded_bytes();
-                    let with_slash = if source.ends_with("/") {
-                        source.as_bytes()
-                    } else {
-                        with_slash.as_bytes()
-                    };
-
-                    as_bytes.starts_with(with_slash) || as_bytes.ends_with(source.as_bytes())
-                })
-                || self.glob.is_match(other_path)
-                || self.check_with_end_separator(other_path)
-        }
-
-        fn check_with_end_separator(&self, path: &Path) -> bool {
-            let path_str = path.to_string_lossy();
-            let separator = std::path::MAIN_SEPARATOR_STR;
-            if path_str.ends_with(separator) {
-                return false;
-            } else {
-                self.glob.is_match(path_str.to_string() + separator)
-            }
-        }
-    }
-}
-
-#[cfg(test)]
-mod test {
-    use fs::FakeFs;
-    use gpui::TestAppContext;
-    use project::Project;
-    use serde_json::json;
-    use settings::SettingsStore;
-
-    use crate::slash_command::file_command::collect_files;
-
-    pub fn init_test(cx: &mut gpui::TestAppContext) {
-        if std::env::var("RUST_LOG").is_ok() {
-            env_logger::try_init().ok();
-        }
-
-        cx.update(|cx| {
-            let settings_store = SettingsStore::test(cx);
-            cx.set_global(settings_store);
-            // release_channel::init(SemanticVersion::default(), cx);
-            language::init(cx);
-            Project::init_settings(cx);
-        });
-    }
-
-    #[gpui::test]
-    async fn test_file_exact_matching(cx: &mut TestAppContext) {
-        init_test(cx);
-        let fs = FakeFs::new(cx.executor());
-
-        fs.insert_tree(
-            "/root",
-            json!({
-                "dir": {
-                    "subdir": {
-                       "file_0": "0"
-                    },
-                    "file_1": "1",
-                    "file_2": "2",
-                    "file_3": "3",
-                },
-                "dir.rs": "4"
-            }),
-        )
-        .await;
-
-        let project = Project::test(fs, ["/root".as_ref()], cx).await;
-
-        let result_1 = cx
-            .update(|cx| collect_files(project.clone(), &["root/dir".to_string()], cx))
-            .await
-            .unwrap();
-
-        assert!(result_1.completion_text.starts_with("root/dir"));
-        // 4 files + 2 directories
-        assert_eq!(6, result_1.files.len());
-
-        let result_2 = cx
-            .update(|cx| collect_files(project.clone(), &["root/dir/".to_string()], cx))
-            .await
-            .unwrap();
-
-        assert_eq!(result_1, result_2);
-
-        let result = cx
-            .update(|cx| collect_files(project.clone(), &["root/dir*".to_string()], cx))
-            .await
-            .unwrap();
-
-        assert!(result.completion_text.starts_with("root/dir"));
-        // 5 files + 2 directories
-        assert_eq!(7, result.files.len());
-
-        // Ensure that the project lasts until after the last await
-        drop(project);
-    }
-
-    #[gpui::test]
-    async fn test_file_sub_directory_rendering(cx: &mut TestAppContext) {
-        init_test(cx);
-        let fs = FakeFs::new(cx.executor());
-
-        fs.insert_tree(
-            "/zed",
-            json!({
-                "assets": {
-                    "dir1": {
-                        ".gitkeep": ""
-                    },
-                    "dir2": {
-                        ".gitkeep": ""
-                    },
-                    "themes": {
-                        "ayu": {
-                            "LICENSE": "1",
-                        },
-                        "andromeda": {
-                            "LICENSE": "2",
-                        },
-                        "summercamp": {
-                            "LICENSE": "3",
-                        },
-                    },
-                },
-            }),
-        )
-        .await;
-
-        let project = Project::test(fs, ["/zed".as_ref()], cx).await;
-
-        let result = cx
-            .update(|cx| collect_files(project.clone(), &["zed/assets/themes".to_string()], cx))
-            .await
-            .unwrap();
-
-        // Sanity check
-        assert!(result.completion_text.starts_with("zed/assets/themes\n"));
-        assert_eq!(7, result.files.len());
-
-        // Ensure that full file paths are included in the real output
-        assert!(result
-            .completion_text
-            .contains("zed/assets/themes/andromeda/LICENSE"));
-        assert!(result
-            .completion_text
-            .contains("zed/assets/themes/ayu/LICENSE"));
-        assert!(result
-            .completion_text
-            .contains("zed/assets/themes/summercamp/LICENSE"));
-
-        assert_eq!("summercamp", result.files[5].path.to_string_lossy());
-
-        // Ensure that things are in descending order, with properly relativized paths
-        assert_eq!(
-            "zed/assets/themes/andromeda/LICENSE",
-            result.files[0].path.to_string_lossy()
-        );
-        assert_eq!("andromeda", result.files[1].path.to_string_lossy());
-        assert_eq!(
-            "zed/assets/themes/ayu/LICENSE",
-            result.files[2].path.to_string_lossy()
-        );
-        assert_eq!("ayu", result.files[3].path.to_string_lossy());
-        assert_eq!(
-            "zed/assets/themes/summercamp/LICENSE",
-            result.files[4].path.to_string_lossy()
-        );
-
-        // Ensure that the project lasts until after the last await
-        drop(project);
-    }
-
-    #[gpui::test]
-    async fn test_file_deep_sub_directory_rendering(cx: &mut TestAppContext) {
-        init_test(cx);
-        let fs = FakeFs::new(cx.executor());
-
-        fs.insert_tree(
-            "/zed",
-            json!({
-                "assets": {
-                    "themes": {
-                        "LICENSE": "1",
-                        "summercamp": {
-                            "LICENSE": "1",
-                            "subdir": {
-                                "LICENSE": "1",
-                                "subsubdir": {
-                                    "LICENSE": "3",
-                                }
-                            }
-                        },
-                    },
-                },
-            }),
-        )
-        .await;
-
-        let project = Project::test(fs, ["/zed".as_ref()], cx).await;
-
-        let result = cx
-            .update(|cx| collect_files(project.clone(), &["zed/assets/themes".to_string()], cx))
-            .await
-            .unwrap();
-
-        assert!(result.completion_text.starts_with("zed/assets/themes\n"));
-        assert_eq!(
-            "zed/assets/themes/LICENSE",
-            result.files[0].path.to_string_lossy()
-        );
-        assert_eq!(
-            "zed/assets/themes/summercamp/LICENSE",
-            result.files[1].path.to_string_lossy()
-        );
-        assert_eq!(
-            "zed/assets/themes/summercamp/subdir/LICENSE",
-            result.files[2].path.to_string_lossy()
-        );
-        assert_eq!(
-            "zed/assets/themes/summercamp/subdir/subsubdir/LICENSE",
-            result.files[3].path.to_string_lossy()
-        );
-        assert_eq!("subsubdir", result.files[4].path.to_string_lossy());
-        assert_eq!("subdir", result.files[5].path.to_string_lossy());
-        assert_eq!("summercamp", result.files[6].path.to_string_lossy());
-        assert_eq!("zed/assets/themes", result.files[7].path.to_string_lossy());
-
-        // Ensure that the project lasts until after the last await
-        drop(project);
-    }
-}

crates/assistant/src/slash_command/now_command.rs

@@ -32,7 +32,7 @@ impl SlashCommand for NowSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        _arguments: &[String],
+        _query: String,
         _cancel: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         _cx: &mut WindowContext,
@@ -42,7 +42,7 @@ impl SlashCommand for NowSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        _arguments: &[String],
+        _argument: Option<&str>,
         _workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         _cx: &mut WindowContext,

crates/assistant/src/slash_command/project_command.rs

@@ -103,7 +103,7 @@ impl SlashCommand for ProjectSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        _arguments: &[String],
+        _query: String,
         _cancel: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         _cx: &mut WindowContext,
@@ -117,7 +117,7 @@ impl SlashCommand for ProjectSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        _arguments: &[String],
+        _argument: Option<&str>,
         workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,

crates/assistant/src/slash_command/prompt_command.rs

@@ -29,13 +29,12 @@ impl SlashCommand for PromptSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        arguments: &[String],
+        query: String,
         _cancellation_flag: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         cx: &mut WindowContext,
     ) -> Task<Result<Vec<ArgumentCompletion>>> {
         let store = PromptStore::global(cx);
-        let query = arguments.to_owned().join(" ");
         cx.background_executor().spawn(async move {
             let prompts = store.await?.search(query).await;
             Ok(prompts
@@ -45,8 +44,7 @@ impl SlashCommand for PromptSlashCommand {
                     Some(ArgumentCompletion {
                         label: prompt_title.clone().into(),
                         new_text: prompt_title,
-                        after_completion: true.into(),
-                        replace_previous_arguments: true,
+                        run_command: true,
                     })
                 })
                 .collect())
@@ -55,18 +53,17 @@ impl SlashCommand for PromptSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        arguments: &[String],
+        title: Option<&str>,
         _workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,
     ) -> Task<Result<SlashCommandOutput>> {
-        let title = arguments.to_owned().join(" ");
-        if title.trim().is_empty() {
+        let Some(title) = title else {
             return Task::ready(Err(anyhow!("missing prompt name")));
         };
 
         let store = PromptStore::global(cx);
-        let title = SharedString::from(title.clone());
+        let title = SharedString::from(title.to_string());
         let prompt = cx.background_executor().spawn({
             let title = title.clone();
             async move {

crates/assistant/src/slash_command/search_command.rs

@@ -49,7 +49,7 @@ impl SlashCommand for SearchSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        _arguments: &[String],
+        _query: String,
         _cancel: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         _cx: &mut WindowContext,
@@ -59,7 +59,7 @@ impl SlashCommand for SearchSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        arguments: &[String],
+        argument: Option<&str>,
         workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,
@@ -67,13 +67,13 @@ impl SlashCommand for SearchSlashCommand {
         let Some(workspace) = workspace.upgrade() else {
             return Task::ready(Err(anyhow::anyhow!("workspace was dropped")));
         };
-        if arguments.is_empty() {
+        let Some(argument) = argument else {
             return Task::ready(Err(anyhow::anyhow!("missing search query")));
         };
 
         let mut limit = None;
         let mut query = String::new();
-        for part in arguments {
+        for part in argument.split(' ') {
             if let Some(parameter) = part.strip_prefix("--") {
                 if let Ok(count) = parameter.parse::<usize>() {
                     limit = Some(count);

crates/assistant/src/slash_command/symbols_command.rs

@@ -26,7 +26,7 @@ impl SlashCommand for OutlineSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        _arguments: &[String],
+        _query: String,
         _cancel: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         _cx: &mut WindowContext,
@@ -40,7 +40,7 @@ impl SlashCommand for OutlineSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        _arguments: &[String],
+        _argument: Option<&str>,
         workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,

crates/assistant/src/slash_command/tab_command.rs

@@ -1,318 +0,0 @@
-use super::{
-    diagnostics_command::write_single_file_diagnostics,
-    file_command::{build_entry_output_section, codeblock_fence_for_path},
-    SlashCommand, SlashCommandOutput,
-};
-use anyhow::{Context, Result};
-use assistant_slash_command::ArgumentCompletion;
-use collections::{HashMap, HashSet};
-use editor::Editor;
-use futures::future::join_all;
-use gpui::{Entity, Task, WeakView};
-use language::{BufferSnapshot, LspAdapterDelegate};
-use std::{
-    fmt::Write,
-    path::PathBuf,
-    sync::{atomic::AtomicBool, Arc},
-};
-use ui::WindowContext;
-use workspace::Workspace;
-
-pub(crate) struct TabSlashCommand;
-
-const ALL_TABS_COMPLETION_ITEM: &str = "all";
-
-impl SlashCommand for TabSlashCommand {
-    fn name(&self) -> String {
-        "tab".into()
-    }
-
-    fn description(&self) -> String {
-        "insert open tabs (active tab by default)".to_owned()
-    }
-
-    fn menu_text(&self) -> String {
-        "Insert Open Tabs".to_owned()
-    }
-
-    fn requires_argument(&self) -> bool {
-        false
-    }
-
-    fn accepts_arguments(&self) -> bool {
-        true
-    }
-
-    fn complete_argument(
-        self: Arc<Self>,
-        arguments: &[String],
-        cancel: Arc<AtomicBool>,
-        workspace: Option<WeakView<Workspace>>,
-        cx: &mut WindowContext,
-    ) -> Task<Result<Vec<ArgumentCompletion>>> {
-        let mut has_all_tabs_completion_item = false;
-        let argument_set = arguments
-            .iter()
-            .filter(|argument| {
-                if has_all_tabs_completion_item || ALL_TABS_COMPLETION_ITEM == argument.as_str() {
-                    has_all_tabs_completion_item = true;
-                    false
-                } else {
-                    true
-                }
-            })
-            .cloned()
-            .collect::<HashSet<_>>();
-        if has_all_tabs_completion_item {
-            return Task::ready(Ok(Vec::new()));
-        }
-
-        let active_item_path = workspace.as_ref().and_then(|workspace| {
-            workspace
-                .update(cx, |workspace, cx| {
-                    let snapshot = active_item_buffer(workspace, cx).ok()?;
-                    snapshot.resolve_file_path(cx, true)
-                })
-                .ok()
-                .flatten()
-        });
-        let current_query = arguments.last().cloned().unwrap_or_default();
-        let tab_items_search =
-            tab_items_for_queries(workspace, &[current_query], cancel, false, cx);
-        cx.spawn(|_| async move {
-            let tab_items = tab_items_search.await?;
-            let run_command = tab_items.len() == 1;
-            let tab_completion_items = tab_items.into_iter().filter_map(|(path, ..)| {
-                let path_string = path.as_deref()?.to_string_lossy().to_string();
-                if argument_set.contains(&path_string) {
-                    return None;
-                }
-                if active_item_path.is_some() && active_item_path == path {
-                    return None;
-                }
-                Some(ArgumentCompletion {
-                    label: path_string.clone().into(),
-                    new_text: path_string,
-                    replace_previous_arguments: false,
-                    after_completion: run_command.into(),
-                })
-            });
-
-            let active_item_completion = active_item_path
-                .as_deref()
-                .map(|active_item_path| active_item_path.to_string_lossy().to_string())
-                .filter(|path_string| !argument_set.contains(path_string))
-                .map(|path_string| ArgumentCompletion {
-                    label: path_string.clone().into(),
-                    new_text: path_string,
-                    replace_previous_arguments: false,
-                    after_completion: run_command.into(),
-                });
-
-            Ok(active_item_completion
-                .into_iter()
-                .chain(Some(ArgumentCompletion {
-                    label: ALL_TABS_COMPLETION_ITEM.into(),
-                    new_text: ALL_TABS_COMPLETION_ITEM.to_owned(),
-                    replace_previous_arguments: false,
-                    after_completion: true.into(),
-                }))
-                .chain(tab_completion_items)
-                .collect())
-        })
-    }
-
-    fn run(
-        self: Arc<Self>,
-        arguments: &[String],
-        workspace: WeakView<Workspace>,
-        _delegate: Option<Arc<dyn LspAdapterDelegate>>,
-        cx: &mut WindowContext,
-    ) -> Task<Result<SlashCommandOutput>> {
-        let tab_items_search = tab_items_for_queries(
-            Some(workspace),
-            arguments,
-            Arc::new(AtomicBool::new(false)),
-            true,
-            cx,
-        );
-
-        cx.background_executor().spawn(async move {
-            let mut sections = Vec::new();
-            let mut text = String::new();
-            let mut has_diagnostics = false;
-            for (full_path, buffer, _) in tab_items_search.await? {
-                let section_start_ix = text.len();
-                text.push_str(&codeblock_fence_for_path(full_path.as_deref(), None));
-                for chunk in buffer.as_rope().chunks() {
-                    text.push_str(chunk);
-                }
-                if !text.ends_with('\n') {
-                    text.push('\n');
-                }
-                writeln!(text, "```").unwrap();
-                if write_single_file_diagnostics(&mut text, full_path.as_deref(), &buffer) {
-                    has_diagnostics = true;
-                }
-                if !text.ends_with('\n') {
-                    text.push('\n');
-                }
-
-                let section_end_ix = text.len() - 1;
-                sections.push(build_entry_output_section(
-                    section_start_ix..section_end_ix,
-                    full_path.as_deref(),
-                    false,
-                    None,
-                ));
-            }
-
-            Ok(SlashCommandOutput {
-                text,
-                sections,
-                run_commands_in_text: has_diagnostics,
-            })
-        })
-    }
-}
-
-fn tab_items_for_queries(
-    workspace: Option<WeakView<Workspace>>,
-    queries: &[String],
-    cancel: Arc<AtomicBool>,
-    strict_match: bool,
-    cx: &mut WindowContext,
-) -> Task<anyhow::Result<Vec<(Option<PathBuf>, BufferSnapshot, usize)>>> {
-    let empty_query = queries.is_empty() || queries.iter().all(|query| query.trim().is_empty());
-    let queries = queries.to_owned();
-    cx.spawn(|mut cx| async move {
-        let mut open_buffers =
-            workspace
-                .context("no workspace")?
-                .update(&mut cx, |workspace, cx| {
-                    if strict_match && empty_query {
-                        let snapshot = active_item_buffer(workspace, cx)?;
-                        let full_path = snapshot.resolve_file_path(cx, true);
-                        return anyhow::Ok(vec![(full_path, snapshot, 0)]);
-                    }
-
-                    let mut timestamps_by_entity_id = HashMap::default();
-                    let mut open_buffers = Vec::new();
-
-                    for pane in workspace.panes() {
-                        let pane = pane.read(cx);
-                        for entry in pane.activation_history() {
-                            timestamps_by_entity_id.insert(entry.entity_id, entry.timestamp);
-                        }
-                    }
-
-                    for editor in workspace.items_of_type::<Editor>(cx) {
-                        if let Some(buffer) = editor.read(cx).buffer().read(cx).as_singleton() {
-                            if let Some(timestamp) =
-                                timestamps_by_entity_id.get(&editor.entity_id())
-                            {
-                                let snapshot = buffer.read(cx).snapshot();
-                                let full_path = snapshot.resolve_file_path(cx, true);
-                                open_buffers.push((full_path, snapshot, *timestamp));
-                            }
-                        }
-                    }
-
-                    Ok(open_buffers)
-                })??;
-
-        let background_executor = cx.background_executor().clone();
-        cx.background_executor()
-            .spawn(async move {
-                open_buffers.sort_by_key(|(_, _, timestamp)| *timestamp);
-                if empty_query
-                    || queries
-                        .iter()
-                        .any(|query| query == ALL_TABS_COMPLETION_ITEM)
-                {
-                    return Ok(open_buffers);
-                }
-
-                let matched_items = if strict_match {
-                    let match_candidates = open_buffers
-                        .iter()
-                        .enumerate()
-                        .filter_map(|(id, (full_path, ..))| {
-                            let path_string = full_path.as_deref()?.to_string_lossy().to_string();
-                            Some((id, path_string))
-                        })
-                        .fold(HashMap::default(), |mut candidates, (id, path_string)| {
-                            candidates
-                                .entry(path_string)
-                                .or_insert_with(|| Vec::new())
-                                .push(id);
-                            candidates
-                        });
-
-                    queries
-                        .iter()
-                        .filter_map(|query| match_candidates.get(query))
-                        .flatten()
-                        .copied()
-                        .filter_map(|id| open_buffers.get(id))
-                        .cloned()
-                        .collect()
-                } else {
-                    let match_candidates = open_buffers
-                        .iter()
-                        .enumerate()
-                        .filter_map(|(id, (full_path, ..))| {
-                            let path_string = full_path.as_deref()?.to_string_lossy().to_string();
-                            Some(fuzzy::StringMatchCandidate {
-                                id,
-                                char_bag: path_string.as_str().into(),
-                                string: path_string,
-                            })
-                        })
-                        .collect::<Vec<_>>();
-                    let mut processed_matches = HashSet::default();
-                    let file_queries = queries.iter().map(|query| {
-                        fuzzy::match_strings(
-                            &match_candidates,
-                            query,
-                            true,
-                            usize::MAX,
-                            &cancel,
-                            background_executor.clone(),
-                        )
-                    });
-
-                    join_all(file_queries)
-                        .await
-                        .into_iter()
-                        .flatten()
-                        .filter(|string_match| processed_matches.insert(string_match.candidate_id))
-                        .filter_map(|string_match| open_buffers.get(string_match.candidate_id))
-                        .cloned()
-                        .collect()
-                };
-                Ok(matched_items)
-            })
-            .await
-    })
-}
-
-fn active_item_buffer(
-    workspace: &mut Workspace,
-    cx: &mut ui::ViewContext<Workspace>,
-) -> anyhow::Result<BufferSnapshot> {
-    let active_editor = workspace
-        .active_item(cx)
-        .context("no active item")?
-        .downcast::<Editor>()
-        .context("active item is not an editor")?;
-    let snapshot = active_editor
-        .read(cx)
-        .buffer()
-        .read(cx)
-        .as_singleton()
-        .context("active editor is not a singleton buffer")?
-        .read(cx)
-        .snapshot();
-    Ok(snapshot)
-}

crates/assistant/src/slash_command/tabs_command.rs

@@ -0,0 +1,227 @@
+use super::{
+    diagnostics_command::write_single_file_diagnostics,
+    file_command::{build_entry_output_section, codeblock_fence_for_path},
+    SlashCommand, SlashCommandOutput,
+};
+use anyhow::{Context, Result};
+use assistant_slash_command::ArgumentCompletion;
+use collections::HashMap;
+use editor::Editor;
+use gpui::{Entity, Task, WeakView};
+use language::{BufferSnapshot, LspAdapterDelegate};
+use std::{
+    fmt::Write,
+    path::PathBuf,
+    sync::{atomic::AtomicBool, Arc},
+};
+use ui::WindowContext;
+use workspace::Workspace;
+
+pub(crate) struct TabsSlashCommand;
+
+const ALL_TABS_COMPLETION_ITEM: &str = "all";
+
+impl SlashCommand for TabsSlashCommand {
+    fn name(&self) -> String {
+        "tabs".into()
+    }
+
+    fn description(&self) -> String {
+        "insert open tabs (active tab by default)".to_owned()
+    }
+
+    fn menu_text(&self) -> String {
+        "Insert Open Tabs".to_owned()
+    }
+
+    fn requires_argument(&self) -> bool {
+        false
+    }
+
+    fn complete_argument(
+        self: Arc<Self>,
+        query: String,
+        cancel: Arc<AtomicBool>,
+        workspace: Option<WeakView<Workspace>>,
+        cx: &mut WindowContext,
+    ) -> Task<Result<Vec<ArgumentCompletion>>> {
+        let all_tabs_completion_item = if ALL_TABS_COMPLETION_ITEM.contains(&query) {
+            Some(ArgumentCompletion {
+                label: ALL_TABS_COMPLETION_ITEM.into(),
+                new_text: ALL_TABS_COMPLETION_ITEM.to_owned(),
+                run_command: true,
+            })
+        } else {
+            None
+        };
+        let tab_items_search = tab_items_for_query(workspace, query, cancel, false, cx);
+        cx.spawn(|_| async move {
+            let tab_completion_items =
+                tab_items_search
+                    .await?
+                    .into_iter()
+                    .filter_map(|(path, ..)| {
+                        let path_string = path.as_deref()?.to_string_lossy().to_string();
+                        Some(ArgumentCompletion {
+                            label: path_string.clone().into(),
+                            new_text: path_string,
+                            run_command: true,
+                        })
+                    });
+            Ok(all_tabs_completion_item
+                .into_iter()
+                .chain(tab_completion_items)
+                .collect::<Vec<_>>())
+        })
+    }
+
+    fn run(
+        self: Arc<Self>,
+        argument: Option<&str>,
+        workspace: WeakView<Workspace>,
+        _delegate: Option<Arc<dyn LspAdapterDelegate>>,
+        cx: &mut WindowContext,
+    ) -> Task<Result<SlashCommandOutput>> {
+        let tab_items_search = tab_items_for_query(
+            Some(workspace),
+            argument.map(ToOwned::to_owned).unwrap_or_default(),
+            Arc::new(AtomicBool::new(false)),
+            true,
+            cx,
+        );
+
+        cx.background_executor().spawn(async move {
+            let mut sections = Vec::new();
+            let mut text = String::new();
+            let mut has_diagnostics = false;
+            for (full_path, buffer, _) in tab_items_search.await? {
+                let section_start_ix = text.len();
+                text.push_str(&codeblock_fence_for_path(full_path.as_deref(), None));
+                for chunk in buffer.as_rope().chunks() {
+                    text.push_str(chunk);
+                }
+                if !text.ends_with('\n') {
+                    text.push('\n');
+                }
+                writeln!(text, "```").unwrap();
+                if write_single_file_diagnostics(&mut text, full_path.as_deref(), &buffer) {
+                    has_diagnostics = true;
+                }
+                if !text.ends_with('\n') {
+                    text.push('\n');
+                }
+
+                let section_end_ix = text.len() - 1;
+                sections.push(build_entry_output_section(
+                    section_start_ix..section_end_ix,
+                    full_path.as_deref(),
+                    false,
+                    None,
+                ));
+            }
+
+            Ok(SlashCommandOutput {
+                text,
+                sections,
+                run_commands_in_text: has_diagnostics,
+            })
+        })
+    }
+}
+
+fn tab_items_for_query(
+    workspace: Option<WeakView<Workspace>>,
+    mut query: String,
+    cancel: Arc<AtomicBool>,
+    use_active_tab_for_empty_query: bool,
+    cx: &mut WindowContext,
+) -> Task<anyhow::Result<Vec<(Option<PathBuf>, BufferSnapshot, usize)>>> {
+    cx.spawn(|mut cx| async move {
+        query.make_ascii_lowercase();
+        let mut open_buffers =
+            workspace
+                .context("no workspace")?
+                .update(&mut cx, |workspace, cx| {
+                    if use_active_tab_for_empty_query && query.trim().is_empty() {
+                        let active_editor = workspace
+                            .active_item(cx)
+                            .context("no active item")?
+                            .downcast::<Editor>()
+                            .context("active item is not an editor")?;
+                        let snapshot = active_editor
+                            .read(cx)
+                            .buffer()
+                            .read(cx)
+                            .as_singleton()
+                            .context("active editor is not a singleton buffer")?
+                            .read(cx)
+                            .snapshot();
+                        let full_path = snapshot.resolve_file_path(cx, true);
+                        return anyhow::Ok(vec![(full_path, snapshot, 0)]);
+                    }
+
+                    let mut timestamps_by_entity_id = HashMap::default();
+                    let mut open_buffers = Vec::new();
+
+                    for pane in workspace.panes() {
+                        let pane = pane.read(cx);
+                        for entry in pane.activation_history() {
+                            timestamps_by_entity_id.insert(entry.entity_id, entry.timestamp);
+                        }
+                    }
+
+                    for editor in workspace.items_of_type::<Editor>(cx) {
+                        if let Some(buffer) = editor.read(cx).buffer().read(cx).as_singleton() {
+                            if let Some(timestamp) =
+                                timestamps_by_entity_id.get(&editor.entity_id())
+                            {
+                                let snapshot = buffer.read(cx).snapshot();
+                                let full_path = snapshot.resolve_file_path(cx, true);
+                                open_buffers.push((full_path, snapshot, *timestamp));
+                            }
+                        }
+                    }
+
+                    Ok(open_buffers)
+                })??;
+
+        let background_executor = cx.background_executor().clone();
+        cx.background_executor()
+            .spawn(async move {
+                open_buffers.sort_by_key(|(_, _, timestamp)| *timestamp);
+                let query = query.trim();
+                if query.is_empty() || query == ALL_TABS_COMPLETION_ITEM {
+                    return Ok(open_buffers);
+                }
+
+                let match_candidates = open_buffers
+                    .iter()
+                    .enumerate()
+                    .filter_map(|(id, (full_path, ..))| {
+                        let path_string = full_path.as_deref()?.to_string_lossy().to_string();
+                        Some(fuzzy::StringMatchCandidate {
+                            id,
+                            char_bag: path_string.as_str().into(),
+                            string: path_string,
+                        })
+                    })
+                    .collect::<Vec<_>>();
+                let string_matches = fuzzy::match_strings(
+                    &match_candidates,
+                    &query,
+                    true,
+                    usize::MAX,
+                    &cancel,
+                    background_executor,
+                )
+                .await;
+
+                Ok(string_matches
+                    .into_iter()
+                    .filter_map(|string_match| open_buffers.get(string_match.candidate_id))
+                    .cloned()
+                    .collect())
+            })
+            .await
+    })
+}

crates/assistant/src/slash_command/terminal_command.rs

@@ -5,7 +5,7 @@ use anyhow::Result;
 use assistant_slash_command::{
     ArgumentCompletion, SlashCommand, SlashCommandOutput, SlashCommandOutputSection,
 };
-use gpui::{AppContext, Task, View, WeakView};
+use gpui::{AppContext, Task, WeakView};
 use language::{CodeLabel, LspAdapterDelegate};
 use terminal_view::{terminal_panel::TerminalPanel, TerminalView};
 use ui::prelude::*;
@@ -40,23 +40,23 @@ impl SlashCommand for TerminalSlashCommand {
         false
     }
 
-    fn accepts_arguments(&self) -> bool {
-        true
-    }
-
     fn complete_argument(
         self: Arc<Self>,
-        _arguments: &[String],
+        _query: String,
         _cancel: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         _cx: &mut WindowContext,
     ) -> Task<Result<Vec<ArgumentCompletion>>> {
-        Task::ready(Ok(Vec::new()))
+        Task::ready(Ok(vec![ArgumentCompletion {
+            label: LINE_COUNT_ARG.into(),
+            new_text: LINE_COUNT_ARG.to_string(),
+            run_command: true,
+        }]))
     }
 
     fn run(
         self: Arc<Self>,
-        arguments: &[String],
+        argument: Option<&str>,
         workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,
@@ -64,14 +64,19 @@ impl SlashCommand for TerminalSlashCommand {
         let Some(workspace) = workspace.upgrade() else {
             return Task::ready(Err(anyhow::anyhow!("workspace was dropped")));
         };
-
-        let Some(active_terminal) = resolve_active_terminal(&workspace, cx) else {
+        let Some(terminal_panel) = workspace.read(cx).panel::<TerminalPanel>(cx) else {
+            return Task::ready(Err(anyhow::anyhow!("no terminal panel open")));
+        };
+        let Some(active_terminal) = terminal_panel.read(cx).pane().and_then(|pane| {
+            pane.read(cx)
+                .active_item()
+                .and_then(|t| t.downcast::<TerminalView>())
+        }) else {
             return Task::ready(Err(anyhow::anyhow!("no active terminal")));
         };
 
-        let line_count = arguments
-            .get(0)
-            .and_then(|s| s.parse::<usize>().ok())
+        let line_count = argument
+            .and_then(|a| parse_argument(a))
             .unwrap_or(DEFAULT_CONTEXT_LINES);
 
         let lines = active_terminal
@@ -97,22 +102,12 @@ impl SlashCommand for TerminalSlashCommand {
     }
 }
 
-fn resolve_active_terminal(
-    workspace: &View<Workspace>,
-    cx: &WindowContext,
-) -> Option<View<TerminalView>> {
-    if let Some(terminal_view) = workspace
-        .read(cx)
-        .active_item(cx)
-        .and_then(|item| item.act_as::<TerminalView>(cx))
-    {
-        return Some(terminal_view);
+fn parse_argument(argument: &str) -> Option<usize> {
+    let mut args = argument.split(' ');
+    if args.next() == Some(LINE_COUNT_ARG) {
+        if let Some(line_count) = args.next().and_then(|s| s.parse::<usize>().ok()) {
+            return Some(line_count);
+        }
     }
-
-    let terminal_panel = workspace.read(cx).panel::<TerminalPanel>(cx)?;
-    terminal_panel.read(cx).pane().and_then(|pane| {
-        pane.read(cx)
-            .active_item()
-            .and_then(|t| t.downcast::<TerminalView>())
-    })
+    None
 }

crates/assistant/src/slash_command/workflow_command.rs

@@ -42,7 +42,7 @@ impl SlashCommand for WorkflowSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        _arguments: &[String],
+        _query: String,
         _cancel: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         _cx: &mut WindowContext,
@@ -52,7 +52,7 @@ impl SlashCommand for WorkflowSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        _arguments: &[String],
+        _argument: Option<&str>,
         _workspace: WeakView<Workspace>,
         _delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,

crates/assistant/src/slash_command_picker.rs

@@ -1,306 +0,0 @@
-use std::sync::Arc;
-
-use assistant_slash_command::SlashCommandRegistry;
-use gpui::AnyElement;
-use gpui::DismissEvent;
-use gpui::WeakView;
-use picker::PickerEditorPosition;
-
-use ui::ListItemSpacing;
-
-use gpui::SharedString;
-use gpui::Task;
-use picker::{Picker, PickerDelegate};
-use ui::{prelude::*, ListItem, PopoverMenu, PopoverTrigger};
-
-use crate::assistant_panel::ContextEditor;
-
-#[derive(IntoElement)]
-pub(super) struct SlashCommandSelector<T: PopoverTrigger> {
-    registry: Arc<SlashCommandRegistry>,
-    active_context_editor: WeakView<ContextEditor>,
-    trigger: T,
-}
-
-#[derive(Clone)]
-struct SlashCommandInfo {
-    name: SharedString,
-    description: SharedString,
-    args: Option<SharedString>,
-}
-
-#[derive(Clone)]
-enum SlashCommandEntry {
-    Info(SlashCommandInfo),
-    Advert {
-        name: SharedString,
-        renderer: fn(&mut WindowContext<'_>) -> AnyElement,
-        on_confirm: fn(&mut WindowContext<'_>),
-    },
-}
-
-impl AsRef<str> for SlashCommandEntry {
-    fn as_ref(&self) -> &str {
-        match self {
-            SlashCommandEntry::Info(SlashCommandInfo { name, .. })
-            | SlashCommandEntry::Advert { name, .. } => name,
-        }
-    }
-}
-
-pub(crate) struct SlashCommandDelegate {
-    all_commands: Vec<SlashCommandEntry>,
-    filtered_commands: Vec<SlashCommandEntry>,
-    active_context_editor: WeakView<ContextEditor>,
-    selected_index: usize,
-}
-
-impl<T: PopoverTrigger> SlashCommandSelector<T> {
-    pub(crate) fn new(
-        registry: Arc<SlashCommandRegistry>,
-        active_context_editor: WeakView<ContextEditor>,
-        trigger: T,
-    ) -> Self {
-        SlashCommandSelector {
-            registry,
-            active_context_editor,
-            trigger,
-        }
-    }
-}
-
-impl PickerDelegate for SlashCommandDelegate {
-    type ListItem = ListItem;
-
-    fn match_count(&self) -> usize {
-        self.filtered_commands.len()
-    }
-
-    fn selected_index(&self) -> usize {
-        self.selected_index
-    }
-
-    fn set_selected_index(&mut self, ix: usize, cx: &mut ViewContext<Picker<Self>>) {
-        self.selected_index = ix.min(self.filtered_commands.len().saturating_sub(1));
-        cx.notify();
-    }
-
-    fn placeholder_text(&self, _cx: &mut WindowContext) -> Arc<str> {
-        "Select a command...".into()
-    }
-
-    fn update_matches(&mut self, query: String, cx: &mut ViewContext<Picker<Self>>) -> Task<()> {
-        let all_commands = self.all_commands.clone();
-        cx.spawn(|this, mut cx| async move {
-            let filtered_commands = cx
-                .background_executor()
-                .spawn(async move {
-                    if query.is_empty() {
-                        all_commands
-                    } else {
-                        all_commands
-                            .into_iter()
-                            .filter(|model_info| {
-                                model_info
-                                    .as_ref()
-                                    .to_lowercase()
-                                    .contains(&query.to_lowercase())
-                            })
-                            .collect()
-                    }
-                })
-                .await;
-
-            this.update(&mut cx, |this, cx| {
-                this.delegate.filtered_commands = filtered_commands;
-                this.delegate.set_selected_index(0, cx);
-                cx.notify();
-            })
-            .ok();
-        })
-    }
-
-    fn separators_after_indices(&self) -> Vec<usize> {
-        let mut ret = vec![];
-        let mut previous_is_advert = false;
-
-        for (index, command) in self.filtered_commands.iter().enumerate() {
-            if previous_is_advert {
-                if let SlashCommandEntry::Info(_) = command {
-                    previous_is_advert = false;
-                    debug_assert_ne!(
-                        index, 0,
-                        "index cannot be zero, as we can never have a separator at 0th position"
-                    );
-                    ret.push(index - 1);
-                }
-            } else {
-                if let SlashCommandEntry::Advert { .. } = command {
-                    previous_is_advert = true;
-                    if index != 0 {
-                        ret.push(index - 1);
-                    }
-                }
-            }
-        }
-        ret
-    }
-    fn confirm(&mut self, _secondary: bool, cx: &mut ViewContext<Picker<Self>>) {
-        if let Some(command) = self.filtered_commands.get(self.selected_index) {
-            if let SlashCommandEntry::Info(info) = command {
-                self.active_context_editor
-                    .update(cx, |context_editor, cx| {
-                        context_editor.insert_command(&info.name, cx)
-                    })
-                    .ok();
-            } else if let SlashCommandEntry::Advert { on_confirm, .. } = command {
-                on_confirm(cx);
-            }
-            cx.emit(DismissEvent);
-        }
-    }
-
-    fn dismissed(&mut self, _cx: &mut ViewContext<Picker<Self>>) {}
-
-    fn editor_position(&self) -> PickerEditorPosition {
-        PickerEditorPosition::End
-    }
-
-    fn render_match(
-        &self,
-        ix: usize,
-        selected: bool,
-        cx: &mut ViewContext<Picker<Self>>,
-    ) -> Option<Self::ListItem> {
-        let command_info = self.filtered_commands.get(ix)?;
-
-        match command_info {
-            SlashCommandEntry::Info(info) => Some(
-                ListItem::new(ix)
-                    .inset(true)
-                    .spacing(ListItemSpacing::Sparse)
-                    .selected(selected)
-                    .child(
-                        h_flex()
-                            .group(format!("command-entry-label-{ix}"))
-                            .w_full()
-                            .min_w(px(220.))
-                            .child(
-                                v_flex()
-                                    .child(
-                                        h_flex()
-                                            .child(div().font_buffer(cx).child({
-                                                let mut label = format!("/{}", info.name);
-                                                if let Some(args) =
-                                                    info.args.as_ref().filter(|_| selected)
-                                                {
-                                                    label.push_str(&args);
-                                                }
-                                                Label::new(label).size(LabelSize::Small)
-                                            }))
-                                            .children(info.args.clone().filter(|_| !selected).map(
-                                                |args| {
-                                                    div()
-                                                        .font_buffer(cx)
-                                                        .child(
-                                                            Label::new(args).size(LabelSize::Small),
-                                                        )
-                                                        .visible_on_hover(format!(
-                                                            "command-entry-label-{ix}"
-                                                        ))
-                                                },
-                                            )),
-                                    )
-                                    .child(
-                                        Label::new(info.description.clone())
-                                            .size(LabelSize::Small)
-                                            .color(Color::Muted),
-                                    ),
-                            ),
-                    ),
-            ),
-            SlashCommandEntry::Advert { renderer, .. } => Some(
-                ListItem::new(ix)
-                    .inset(true)
-                    .spacing(ListItemSpacing::Sparse)
-                    .selected(selected)
-                    .child(renderer(cx)),
-            ),
-        }
-    }
-}
-
-impl<T: PopoverTrigger> RenderOnce for SlashCommandSelector<T> {
-    fn render(self, cx: &mut WindowContext) -> impl IntoElement {
-        let all_models = self
-            .registry
-            .featured_command_names()
-            .into_iter()
-            .filter_map(|command_name| {
-                let command = self.registry.command(&command_name)?;
-                let menu_text = SharedString::from(Arc::from(command.menu_text()));
-                let label = command.label(cx);
-                let args = label.filter_range.end.ne(&label.text.len()).then(|| {
-                    SharedString::from(
-                        label.text[label.filter_range.end..label.text.len()].to_owned(),
-                    )
-                });
-                Some(SlashCommandEntry::Info(SlashCommandInfo {
-                    name: command_name.into(),
-                    description: menu_text,
-                    args,
-                }))
-            })
-            .chain([SlashCommandEntry::Advert {
-                name: "create-your-command".into(),
-                renderer: |cx| {
-                    v_flex()
-                        .child(
-                            h_flex()
-                                .font_buffer(cx)
-                                .items_center()
-                                .gap_1()
-                                .child(div().font_buffer(cx).child(
-                                    Label::new("create-your-command").size(LabelSize::Small),
-                                ))
-                                .child(Icon::new(IconName::ArrowUpRight).size(IconSize::XSmall)),
-                        )
-                        .child(
-                            Label::new("Learn how to create a custom command")
-                                .size(LabelSize::Small)
-                                .color(Color::Muted),
-                        )
-                        .into_any_element()
-                },
-                on_confirm: |cx| cx.open_url("https://zed.dev/docs/extensions/slash-commands"),
-            }])
-            .collect::<Vec<_>>();
-
-        let delegate = SlashCommandDelegate {
-            all_commands: all_models.clone(),
-            active_context_editor: self.active_context_editor.clone(),
-            filtered_commands: all_models,
-            selected_index: 0,
-        };
-
-        let picker_view = cx.new_view(|cx| {
-            let picker = Picker::uniform_list(delegate, cx).max_height(Some(rems(20.).into()));
-            picker
-        });
-
-        let handle = self
-            .active_context_editor
-            .update(cx, |this, _| this.slash_menu_handle.clone())
-            .ok();
-        PopoverMenu::new("model-switcher")
-            .menu(move |_cx| Some(picker_view.clone()))
-            .trigger(self.trigger)
-            .attach(gpui::AnchorCorner::TopLeft)
-            .anchor(gpui::AnchorCorner::BottomLeft)
-            .offset(gpui::Point {
-                x: px(0.0),
-                y: px(-16.0),
-            })
-            .when_some(handle, |this, handle| this.with_handle(handle))
-    }
-}

crates/assistant/src/terminal_inline_assistant.rs

@@ -277,7 +277,6 @@ impl TerminalInlineAssistant {
         messages.push(LanguageModelRequestMessage {
             role: Role::User,
             content: vec![prompt.into()],
-            cache: false,
         });
 
         Ok(LanguageModelRequest {

crates/assistant/src/using-the-assistant.md

@@ -0,0 +1,25 @@
+### Using the Assistant
+
+Once you have configured a provider, you can interact with the provider's language models in a context editor.
+
+To create a new context editor, use the menu in the top right of the assistant panel and the `New Context` option.
+
+In the context editor, select a model from one of the configured providers, type a message in the `You` block, and submit with `cmd-enter` (or `ctrl-enter` on Linux).
+
+### Inline assistant
+
+When you're in a normal editor, you can use `ctrl-enter` to open the inline assistant.
+
+The inline assistant allows you to send the current selection (or the current line) to a language model and modify the selection with the language model's response.
+
+### Adding Prompts
+
+You can customize the default prompts that are used in new context editor, by opening the `Prompt Library`.
+
+Open the `Prompt Library` using either the menu in the top right of the assistant panel and choosing the `Prompt Library` option, or by using the `assistant: deploy prompt library` command when the assistant panel is focused.
+
+### Viewing past contexts
+
+You view all previous contexts by opening up the `History` tab in the assistant panel.
+
+Open the `History` using the menu in the top right of the assistant panel and choosing the `History`.

crates/assistant/src/workflow.rs

@@ -1,803 +0,0 @@
-mod step_view;
-
-use crate::{
-    prompts::StepResolutionContext, AssistantPanel, Context, InlineAssistId, InlineAssistant,
-};
-use anyhow::{anyhow, Error, Result};
-use collections::HashMap;
-use editor::Editor;
-use futures::future;
-use gpui::{
-    Model, ModelContext, Task, UpdateGlobal as _, View, WeakModel, WeakView, WindowContext,
-};
-use language::{Anchor, Buffer, BufferSnapshot, SymbolPath};
-use language_model::{LanguageModelRegistry, LanguageModelRequestMessage, Role};
-use project::Project;
-use rope::Point;
-use serde::{Deserialize, Serialize};
-use smol::stream::StreamExt;
-use std::{cmp, fmt::Write, ops::Range, sync::Arc};
-use text::{AnchorRangeExt as _, OffsetRangeExt as _};
-use util::ResultExt as _;
-use workspace::Workspace;
-
-pub use step_view::WorkflowStepView;
-
-const IMPORTS_SYMBOL: &str = "#imports";
-
-pub struct WorkflowStep {
-    context: WeakModel<Context>,
-    context_buffer_range: Range<Anchor>,
-    tool_output: String,
-    resolve_task: Option<Task<()>>,
-    pub resolution: Option<Result<WorkflowStepResolution, Arc<Error>>>,
-}
-
-#[derive(Clone, Debug, Eq, PartialEq)]
-pub struct WorkflowStepResolution {
-    pub title: String,
-    pub suggestion_groups: HashMap<Model<Buffer>, Vec<WorkflowSuggestionGroup>>,
-}
-
-#[derive(Clone, Debug, Eq, PartialEq)]
-pub struct WorkflowSuggestionGroup {
-    pub context_range: Range<language::Anchor>,
-    pub suggestions: Vec<WorkflowSuggestion>,
-}
-
-#[derive(Clone, Debug, Eq, PartialEq)]
-pub enum WorkflowSuggestion {
-    Update {
-        symbol_path: SymbolPath,
-        range: Range<language::Anchor>,
-        description: String,
-    },
-    CreateFile {
-        description: String,
-    },
-    InsertSiblingBefore {
-        symbol_path: SymbolPath,
-        position: language::Anchor,
-        description: String,
-    },
-    InsertSiblingAfter {
-        symbol_path: SymbolPath,
-        position: language::Anchor,
-        description: String,
-    },
-    PrependChild {
-        symbol_path: Option<SymbolPath>,
-        position: language::Anchor,
-        description: String,
-    },
-    AppendChild {
-        symbol_path: Option<SymbolPath>,
-        position: language::Anchor,
-        description: String,
-    },
-    Delete {
-        symbol_path: SymbolPath,
-        range: Range<language::Anchor>,
-    },
-}
-
-impl WorkflowStep {
-    pub fn new(range: Range<Anchor>, context: WeakModel<Context>) -> Self {
-        Self {
-            context_buffer_range: range,
-            tool_output: String::new(),
-            context,
-            resolution: None,
-            resolve_task: None,
-        }
-    }
-
-    pub fn resolve(&mut self, cx: &mut ModelContext<WorkflowStep>) -> Option<()> {
-        let range = self.context_buffer_range.clone();
-        let context = self.context.upgrade()?;
-        let context = context.read(cx);
-        let project = context.project()?;
-        let prompt_builder = context.prompt_builder();
-        let mut request = context.to_completion_request(cx);
-        let model = LanguageModelRegistry::read_global(cx).active_model();
-        let context_buffer = context.buffer();
-        let step_text = context_buffer
-            .read(cx)
-            .text_for_range(range.clone())
-            .collect::<String>();
-
-        let mut workflow_context = String::new();
-        for message in context.messages(cx) {
-            write!(&mut workflow_context, "<message role={}>", message.role).unwrap();
-            for chunk in context_buffer.read(cx).text_for_range(message.offset_range) {
-                write!(&mut workflow_context, "{chunk}").unwrap();
-            }
-            write!(&mut workflow_context, "</message>").unwrap();
-        }
-
-        self.resolve_task = Some(cx.spawn(|this, mut cx| async move {
-            let result = async {
-                let Some(model) = model else {
-                    return Err(anyhow!("no model selected"));
-                };
-
-                this.update(&mut cx, |this, cx| {
-                    this.tool_output.clear();
-                    this.resolution = None;
-                    this.result_updated(cx);
-                    cx.notify();
-                })?;
-
-                let resolution_context = StepResolutionContext {
-                    workflow_context,
-                    step_to_resolve: step_text.clone(),
-                };
-                let mut prompt =
-                    prompt_builder.generate_step_resolution_prompt(&resolution_context)?;
-                prompt.push_str(&step_text);
-                request.messages.push(LanguageModelRequestMessage {
-                    role: Role::User,
-                    content: vec![prompt.into()],
-                    cache: false,
-                });
-
-                // Invoke the model to get its edit suggestions for this workflow step.
-                let mut stream = model
-                    .use_tool_stream::<tool::WorkflowStepResolutionTool>(request, &cx)
-                    .await?;
-                while let Some(chunk) = stream.next().await {
-                    let chunk = chunk?;
-                    this.update(&mut cx, |this, cx| {
-                        this.tool_output.push_str(&chunk);
-                        cx.notify();
-                    })?;
-                }
-
-                let resolution = this.update(&mut cx, |this, _| {
-                    serde_json::from_str::<tool::WorkflowStepResolutionTool>(&this.tool_output)
-                })??;
-
-                this.update(&mut cx, |this, cx| {
-                    this.tool_output = serde_json::to_string_pretty(&resolution).unwrap();
-                    cx.notify();
-                })?;
-
-                // Translate the parsed suggestions to our internal types, which anchor the suggestions to locations in the code.
-                let suggestion_tasks: Vec<_> = resolution
-                    .suggestions
-                    .iter()
-                    .map(|suggestion| suggestion.resolve(project.clone(), cx.clone()))
-                    .collect();
-
-                // Expand the context ranges of each suggestion and group suggestions with overlapping context ranges.
-                let suggestions = future::join_all(suggestion_tasks)
-                    .await
-                    .into_iter()
-                    .filter_map(|task| task.log_err())
-                    .collect::<Vec<_>>();
-
-                let mut suggestions_by_buffer = HashMap::default();
-                for (buffer, suggestion) in suggestions {
-                    suggestions_by_buffer
-                        .entry(buffer)
-                        .or_insert_with(Vec::new)
-                        .push(suggestion);
-                }
-
-                let mut suggestion_groups_by_buffer = HashMap::default();
-                for (buffer, mut suggestions) in suggestions_by_buffer {
-                    let mut suggestion_groups = Vec::<WorkflowSuggestionGroup>::new();
-                    let snapshot = buffer.update(&mut cx, |buffer, _| buffer.snapshot())?;
-                    // Sort suggestions by their range so that earlier, larger ranges come first
-                    suggestions.sort_by(|a, b| a.range().cmp(&b.range(), &snapshot));
-
-                    // Merge overlapping suggestions
-                    suggestions.dedup_by(|a, b| b.try_merge(a, &snapshot));
-
-                    // Create context ranges for each suggestion
-                    for suggestion in suggestions {
-                        let context_range = {
-                            let suggestion_point_range = suggestion.range().to_point(&snapshot);
-                            let start_row = suggestion_point_range.start.row.saturating_sub(5);
-                            let end_row = cmp::min(
-                                suggestion_point_range.end.row + 5,
-                                snapshot.max_point().row,
-                            );
-                            let start = snapshot.anchor_before(Point::new(start_row, 0));
-                            let end = snapshot
-                                .anchor_after(Point::new(end_row, snapshot.line_len(end_row)));
-                            start..end
-                        };
-
-                        if let Some(last_group) = suggestion_groups.last_mut() {
-                            if last_group
-                                .context_range
-                                .end
-                                .cmp(&context_range.start, &snapshot)
-                                .is_ge()
-                            {
-                                // Merge with the previous group if context ranges overlap
-                                last_group.context_range.end = context_range.end;
-                                last_group.suggestions.push(suggestion);
-                            } else {
-                                // Create a new group
-                                suggestion_groups.push(WorkflowSuggestionGroup {
-                                    context_range,
-                                    suggestions: vec![suggestion],
-                                });
-                            }
-                        } else {
-                            // Create the first group
-                            suggestion_groups.push(WorkflowSuggestionGroup {
-                                context_range,
-                                suggestions: vec![suggestion],
-                            });
-                        }
-                    }
-
-                    suggestion_groups_by_buffer.insert(buffer, suggestion_groups);
-                }
-
-                Ok((resolution.step_title, suggestion_groups_by_buffer))
-            };
-
-            let result = result.await;
-            this.update(&mut cx, |this, cx| {
-                this.resolution = Some(match result {
-                    Ok((title, suggestion_groups)) => Ok(WorkflowStepResolution {
-                        title,
-                        suggestion_groups,
-                    }),
-                    Err(error) => Err(Arc::new(error)),
-                });
-                this.context
-                    .update(cx, |context, cx| context.workflow_step_updated(range, cx))
-                    .ok();
-                cx.notify();
-            })
-            .ok();
-        }));
-        None
-    }
-
-    fn result_updated(&mut self, cx: &mut ModelContext<Self>) {
-        self.context
-            .update(cx, |context, cx| {
-                context.workflow_step_updated(self.context_buffer_range.clone(), cx)
-            })
-            .ok();
-    }
-}
-
-impl WorkflowSuggestion {
-    pub fn range(&self) -> Range<language::Anchor> {
-        match self {
-            Self::Update { range, .. } => range.clone(),
-            Self::CreateFile { .. } => language::Anchor::MIN..language::Anchor::MAX,
-            Self::InsertSiblingBefore { position, .. }
-            | Self::InsertSiblingAfter { position, .. }
-            | Self::PrependChild { position, .. }
-            | Self::AppendChild { position, .. } => *position..*position,
-            Self::Delete { range, .. } => range.clone(),
-        }
-    }
-
-    pub fn description(&self) -> Option<&str> {
-        match self {
-            Self::Update { description, .. }
-            | Self::CreateFile { description }
-            | Self::InsertSiblingBefore { description, .. }
-            | Self::InsertSiblingAfter { description, .. }
-            | Self::PrependChild { description, .. }
-            | Self::AppendChild { description, .. } => Some(description),
-            Self::Delete { .. } => None,
-        }
-    }
-
-    fn description_mut(&mut self) -> Option<&mut String> {
-        match self {
-            Self::Update { description, .. }
-            | Self::CreateFile { description }
-            | Self::InsertSiblingBefore { description, .. }
-            | Self::InsertSiblingAfter { description, .. }
-            | Self::PrependChild { description, .. }
-            | Self::AppendChild { description, .. } => Some(description),
-            Self::Delete { .. } => None,
-        }
-    }
-
-    fn symbol_path(&self) -> Option<&SymbolPath> {
-        match self {
-            Self::Update { symbol_path, .. } => Some(symbol_path),
-            Self::InsertSiblingBefore { symbol_path, .. } => Some(symbol_path),
-            Self::InsertSiblingAfter { symbol_path, .. } => Some(symbol_path),
-            Self::PrependChild { symbol_path, .. } => symbol_path.as_ref(),
-            Self::AppendChild { symbol_path, .. } => symbol_path.as_ref(),
-            Self::Delete { symbol_path, .. } => Some(symbol_path),
-            Self::CreateFile { .. } => None,
-        }
-    }
-
-    fn kind(&self) -> &str {
-        match self {
-            Self::Update { .. } => "Update",
-            Self::CreateFile { .. } => "CreateFile",
-            Self::InsertSiblingBefore { .. } => "InsertSiblingBefore",
-            Self::InsertSiblingAfter { .. } => "InsertSiblingAfter",
-            Self::PrependChild { .. } => "PrependChild",
-            Self::AppendChild { .. } => "AppendChild",
-            Self::Delete { .. } => "Delete",
-        }
-    }
-
-    fn try_merge(&mut self, other: &Self, buffer: &BufferSnapshot) -> bool {
-        let range = self.range();
-        let other_range = other.range();
-
-        // Don't merge if we don't contain the other suggestion.
-        if range.start.cmp(&other_range.start, buffer).is_gt()
-            || range.end.cmp(&other_range.end, buffer).is_lt()
-        {
-            return false;
-        }
-
-        if let Some(description) = self.description_mut() {
-            if let Some(other_description) = other.description() {
-                description.push('\n');
-                description.push_str(other_description);
-            }
-        }
-        true
-    }
-
-    pub fn show(
-        &self,
-        editor: &View<Editor>,
-        excerpt_id: editor::ExcerptId,
-        workspace: &WeakView<Workspace>,
-        assistant_panel: &View<AssistantPanel>,
-        cx: &mut WindowContext,
-    ) -> Option<InlineAssistId> {
-        let mut initial_transaction_id = None;
-        let initial_prompt;
-        let suggestion_range;
-        let buffer = editor.read(cx).buffer().clone();
-        let snapshot = buffer.read(cx).snapshot(cx);
-
-        match self {
-            Self::Update {
-                range, description, ..
-            } => {
-                initial_prompt = description.clone();
-                suggestion_range = snapshot.anchor_in_excerpt(excerpt_id, range.start)?
-                    ..snapshot.anchor_in_excerpt(excerpt_id, range.end)?;
-            }
-            Self::CreateFile { description } => {
-                initial_prompt = description.clone();
-                suggestion_range = editor::Anchor::min()..editor::Anchor::min();
-            }
-            Self::InsertSiblingBefore {
-                position,
-                description,
-                ..
-            } => {
-                let position = snapshot.anchor_in_excerpt(excerpt_id, *position)?;
-                initial_prompt = description.clone();
-                suggestion_range = buffer.update(cx, |buffer, cx| {
-                    buffer.start_transaction(cx);
-                    let line_start = buffer.insert_empty_line(position, true, true, cx);
-                    initial_transaction_id = buffer.end_transaction(cx);
-                    buffer.refresh_preview(cx);
-
-                    let line_start = buffer.read(cx).anchor_before(line_start);
-                    line_start..line_start
-                });
-            }
-            Self::InsertSiblingAfter {
-                position,
-                description,
-                ..
-            } => {
-                let position = snapshot.anchor_in_excerpt(excerpt_id, *position)?;
-                initial_prompt = description.clone();
-                suggestion_range = buffer.update(cx, |buffer, cx| {
-                    buffer.start_transaction(cx);
-                    let line_start = buffer.insert_empty_line(position, true, true, cx);
-                    initial_transaction_id = buffer.end_transaction(cx);
-                    buffer.refresh_preview(cx);
-
-                    let line_start = buffer.read(cx).anchor_before(line_start);
-                    line_start..line_start
-                });
-            }
-            Self::PrependChild {
-                position,
-                description,
-                ..
-            } => {
-                let position = snapshot.anchor_in_excerpt(excerpt_id, *position)?;
-                initial_prompt = description.clone();
-                suggestion_range = buffer.update(cx, |buffer, cx| {
-                    buffer.start_transaction(cx);
-                    let line_start = buffer.insert_empty_line(position, false, true, cx);
-                    initial_transaction_id = buffer.end_transaction(cx);
-                    buffer.refresh_preview(cx);
-
-                    let line_start = buffer.read(cx).anchor_before(line_start);
-                    line_start..line_start
-                });
-            }
-            Self::AppendChild {
-                position,
-                description,
-                ..
-            } => {
-                let position = snapshot.anchor_in_excerpt(excerpt_id, *position)?;
-                initial_prompt = description.clone();
-                suggestion_range = buffer.update(cx, |buffer, cx| {
-                    buffer.start_transaction(cx);
-                    let line_start = buffer.insert_empty_line(position, true, false, cx);
-                    initial_transaction_id = buffer.end_transaction(cx);
-                    buffer.refresh_preview(cx);
-
-                    let line_start = buffer.read(cx).anchor_before(line_start);
-                    line_start..line_start
-                });
-            }
-            Self::Delete { range, .. } => {
-                initial_prompt = "Delete".to_string();
-                suggestion_range = snapshot.anchor_in_excerpt(excerpt_id, range.start)?
-                    ..snapshot.anchor_in_excerpt(excerpt_id, range.end)?;
-            }
-        }
-
-        InlineAssistant::update_global(cx, |inline_assistant, cx| {
-            Some(inline_assistant.suggest_assist(
-                editor,
-                suggestion_range,
-                initial_prompt,
-                initial_transaction_id,
-                Some(workspace.clone()),
-                Some(assistant_panel),
-                cx,
-            ))
-        })
-    }
-}
-
-pub mod tool {
-    use super::*;
-    use anyhow::Context as _;
-    use gpui::AsyncAppContext;
-    use language::{Outline, OutlineItem, ParseStatus};
-    use language_model::LanguageModelTool;
-    use project::ProjectPath;
-    use schemars::JsonSchema;
-    use std::path::Path;
-
-    #[derive(Debug, Serialize, Deserialize, JsonSchema)]
-    pub struct WorkflowStepResolutionTool {
-        /// An extremely short title for the edit step represented by these operations.
-        pub step_title: String,
-        /// A sequence of operations to apply to the codebase.
-        /// When multiple operations are required for a step, be sure to include multiple operations in this list.
-        pub suggestions: Vec<WorkflowSuggestionTool>,
-    }
-
-    impl LanguageModelTool for WorkflowStepResolutionTool {
-        fn name() -> String {
-            "edit".into()
-        }
-
-        fn description() -> String {
-            "suggest edits to one or more locations in the codebase".into()
-        }
-    }
-
-    /// A description of an operation to apply to one location in the codebase.
-    ///
-    /// This object represents a single edit operation that can be performed on a specific file
-    /// in the codebase. It encapsulates both the location (file path) and the nature of the
-    /// edit to be made.
-    ///
-    /// # Fields
-    ///
-    /// * `path`: A string representing the file path where the edit operation should be applied.
-    ///           This path is relative to the root of the project or repository.
-    ///
-    /// * `kind`: An enum representing the specific type of edit operation to be performed.
-    ///
-    /// # Usage
-    ///
-    /// `EditOperation` is used within a code editor to represent and apply
-    /// programmatic changes to source code. It provides a structured way to describe
-    /// edits for features like refactoring tools or AI-assisted coding suggestions.
-    #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize, JsonSchema)]
-    pub struct WorkflowSuggestionTool {
-        /// The path to the file containing the relevant operation
-        pub path: String,
-        #[serde(flatten)]
-        pub kind: WorkflowSuggestionToolKind,
-    }
-
-    impl WorkflowSuggestionTool {
-        pub(super) async fn resolve(
-            &self,
-            project: Model<Project>,
-            mut cx: AsyncAppContext,
-        ) -> Result<(Model<Buffer>, super::WorkflowSuggestion)> {
-            let path = self.path.clone();
-            let kind = self.kind.clone();
-            let buffer = project
-                .update(&mut cx, |project, cx| {
-                    let project_path = project
-                        .find_project_path(Path::new(&path), cx)
-                        .or_else(|| {
-                            // If we couldn't find a project path for it, put it in the active worktree
-                            // so that when we create the buffer, it can be saved.
-                            let worktree = project
-                                .active_entry()
-                                .and_then(|entry_id| project.worktree_for_entry(entry_id, cx))
-                                .or_else(|| project.worktrees(cx).next())?;
-                            let worktree = worktree.read(cx);
-
-                            Some(ProjectPath {
-                                worktree_id: worktree.id(),
-                                path: Arc::from(Path::new(&path)),
-                            })
-                        })
-                        .with_context(|| format!("worktree not found for {:?}", path))?;
-                    anyhow::Ok(project.open_buffer(project_path, cx))
-                })??
-                .await?;
-
-            let mut parse_status = buffer.read_with(&cx, |buffer, _cx| buffer.parse_status())?;
-            while *parse_status.borrow() != ParseStatus::Idle {
-                parse_status.changed().await?;
-            }
-
-            let snapshot = buffer.update(&mut cx, |buffer, _| buffer.snapshot())?;
-            let outline = snapshot.outline(None).context("no outline for buffer")?;
-
-            let suggestion = match kind {
-                WorkflowSuggestionToolKind::Update {
-                    symbol,
-                    description,
-                } => {
-                    let (symbol_path, symbol) = Self::resolve_symbol(&snapshot, &outline, &symbol)?;
-                    let start = symbol
-                        .annotation_range
-                        .map_or(symbol.range.start, |range| range.start);
-                    let start = Point::new(start.row, 0);
-                    let end = Point::new(
-                        symbol.range.end.row,
-                        snapshot.line_len(symbol.range.end.row),
-                    );
-                    let range = snapshot.anchor_before(start)..snapshot.anchor_after(end);
-                    WorkflowSuggestion::Update {
-                        range,
-                        description,
-                        symbol_path,
-                    }
-                }
-                WorkflowSuggestionToolKind::Create { description } => {
-                    WorkflowSuggestion::CreateFile { description }
-                }
-                WorkflowSuggestionToolKind::InsertSiblingBefore {
-                    symbol,
-                    description,
-                } => {
-                    let (symbol_path, symbol) = Self::resolve_symbol(&snapshot, &outline, &symbol)?;
-                    let position = snapshot.anchor_before(
-                        symbol
-                            .annotation_range
-                            .map_or(symbol.range.start, |annotation_range| {
-                                annotation_range.start
-                            }),
-                    );
-                    WorkflowSuggestion::InsertSiblingBefore {
-                        position,
-                        description,
-                        symbol_path,
-                    }
-                }
-                WorkflowSuggestionToolKind::InsertSiblingAfter {
-                    symbol,
-                    description,
-                } => {
-                    let (symbol_path, symbol) = Self::resolve_symbol(&snapshot, &outline, &symbol)?;
-                    let position = snapshot.anchor_after(symbol.range.end);
-                    WorkflowSuggestion::InsertSiblingAfter {
-                        position,
-                        description,
-                        symbol_path,
-                    }
-                }
-                WorkflowSuggestionToolKind::PrependChild {
-                    symbol,
-                    description,
-                } => {
-                    if let Some(symbol) = symbol {
-                        let (symbol_path, symbol) =
-                            Self::resolve_symbol(&snapshot, &outline, &symbol)?;
-
-                        let position = snapshot.anchor_after(
-                            symbol
-                                .body_range
-                                .map_or(symbol.range.start, |body_range| body_range.start),
-                        );
-                        WorkflowSuggestion::PrependChild {
-                            position,
-                            description,
-                            symbol_path: Some(symbol_path),
-                        }
-                    } else {
-                        WorkflowSuggestion::PrependChild {
-                            position: language::Anchor::MIN,
-                            description,
-                            symbol_path: None,
-                        }
-                    }
-                }
-                WorkflowSuggestionToolKind::AppendChild {
-                    symbol,
-                    description,
-                } => {
-                    if let Some(symbol) = symbol {
-                        let (symbol_path, symbol) =
-                            Self::resolve_symbol(&snapshot, &outline, &symbol)?;
-
-                        let position = snapshot.anchor_before(
-                            symbol
-                                .body_range
-                                .map_or(symbol.range.end, |body_range| body_range.end),
-                        );
-                        WorkflowSuggestion::AppendChild {
-                            position,
-                            description,
-                            symbol_path: Some(symbol_path),
-                        }
-                    } else {
-                        WorkflowSuggestion::PrependChild {
-                            position: language::Anchor::MAX,
-                            description,
-                            symbol_path: None,
-                        }
-                    }
-                }
-                WorkflowSuggestionToolKind::Delete { symbol } => {
-                    let (symbol_path, symbol) = Self::resolve_symbol(&snapshot, &outline, &symbol)?;
-                    let start = symbol
-                        .annotation_range
-                        .map_or(symbol.range.start, |range| range.start);
-                    let start = Point::new(start.row, 0);
-                    let end = Point::new(
-                        symbol.range.end.row,
-                        snapshot.line_len(symbol.range.end.row),
-                    );
-                    let range = snapshot.anchor_before(start)..snapshot.anchor_after(end);
-                    WorkflowSuggestion::Delete { range, symbol_path }
-                }
-            };
-
-            Ok((buffer, suggestion))
-        }
-
-        fn resolve_symbol(
-            snapshot: &BufferSnapshot,
-            outline: &Outline<Anchor>,
-            symbol: &str,
-        ) -> Result<(SymbolPath, OutlineItem<Point>)> {
-            if symbol == IMPORTS_SYMBOL {
-                let target_row = find_first_non_comment_line(snapshot);
-                Ok((
-                    SymbolPath(IMPORTS_SYMBOL.to_string()),
-                    OutlineItem {
-                        range: Point::new(target_row, 0)..Point::new(target_row + 1, 0),
-                        ..Default::default()
-                    },
-                ))
-            } else {
-                let (symbol_path, symbol) = outline
-                    .find_most_similar(symbol)
-                    .with_context(|| format!("symbol not found: {symbol}"))?;
-                Ok((symbol_path, symbol.to_point(snapshot)))
-            }
-        }
-    }
-
-    fn find_first_non_comment_line(snapshot: &BufferSnapshot) -> u32 {
-        let Some(language) = snapshot.language() else {
-            return 0;
-        };
-
-        let scope = language.default_scope();
-        let comment_prefixes = scope.line_comment_prefixes();
-
-        let mut chunks = snapshot.as_rope().chunks();
-        let mut target_row = 0;
-        loop {
-            let starts_with_comment = chunks
-                .peek()
-                .map(|chunk| {
-                    comment_prefixes
-                        .iter()
-                        .any(|s| chunk.starts_with(s.as_ref().trim_end()))
-                })
-                .unwrap_or(false);
-
-            if !starts_with_comment {
-                break;
-            }
-
-            target_row += 1;
-            if !chunks.next_line() {
-                break;
-            }
-        }
-        target_row
-    }
-
-    #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize, JsonSchema)]
-    #[serde(tag = "kind")]
-    pub enum WorkflowSuggestionToolKind {
-        /// Rewrites the specified symbol entirely based on the given description.
-        /// This operation completely replaces the existing symbol with new content.
-        Update {
-            /// A fully-qualified reference to the symbol, e.g. `mod foo impl Bar pub fn baz` instead of just `fn baz`.
-            /// The path should uniquely identify the symbol within the containing file.
-            symbol: String,
-            /// A brief description of the transformation to apply to the symbol.
-            description: String,
-        },
-        /// Creates a new file with the given path based on the provided description.
-        /// This operation adds a new file to the codebase.
-        Create {
-            /// A brief description of the file to be created.
-            description: String,
-        },
-        /// Inserts a new symbol based on the given description before the specified symbol.
-        /// This operation adds new content immediately preceding an existing symbol.
-        InsertSiblingBefore {
-            /// A fully-qualified reference to the symbol, e.g. `mod foo impl Bar pub fn baz` instead of just `fn baz`.
-            /// The new content will be inserted immediately before this symbol.
-            symbol: String,
-            /// A brief description of the new symbol to be inserted.
-            description: String,
-        },
-        /// Inserts a new symbol based on the given description after the specified symbol.
-        /// This operation adds new content immediately following an existing symbol.
-        InsertSiblingAfter {
-            /// A fully-qualified reference to the symbol, e.g. `mod foo impl Bar pub fn baz` instead of just `fn baz`.
-            /// The new content will be inserted immediately after this symbol.
-            symbol: String,
-            /// A brief description of the new symbol to be inserted.
-            description: String,
-        },
-        /// Inserts a new symbol as a child of the specified symbol at the start.
-        /// This operation adds new content as the first child of an existing symbol (or file if no symbol is provided).
-        PrependChild {
-            /// An optional fully-qualified reference to the symbol after the code you want to insert, e.g. `mod foo impl Bar pub fn baz` instead of just `fn baz`.
-            /// If provided, the new content will be inserted as the first child of this symbol.
-            /// If not provided, the new content will be inserted at the top of the file.
-            symbol: Option<String>,
-            /// A brief description of the new symbol to be inserted.
-            description: String,
-        },
-        /// Inserts a new symbol as a child of the specified symbol at the end.
-        /// This operation adds new content as the last child of an existing symbol (or file if no symbol is provided).
-        AppendChild {
-            /// An optional fully-qualified reference to the symbol before the code you want to insert, e.g. `mod foo impl Bar pub fn baz` instead of just `fn baz`.
-            /// If provided, the new content will be inserted as the last child of this symbol.
-            /// If not provided, the new content will be applied at the bottom of the file.
-            symbol: Option<String>,
-            /// A brief description of the new symbol to be inserted.
-            description: String,
-        },
-        /// Deletes the specified symbol from the containing file.
-        Delete {
-            /// An fully-qualified reference to the symbol to be deleted, e.g. `mod foo impl Bar pub fn baz` instead of just `fn baz`.
-            symbol: String,
-        },
-    }
-}

crates/assistant/src/workflow/step_view.rs

@@ -1,315 +0,0 @@
-use super::WorkflowStep;
-use crate::{Assist, Context};
-use editor::{
-    display_map::{BlockDisposition, BlockProperties, BlockStyle},
-    Editor, EditorEvent, ExcerptRange, MultiBuffer,
-};
-use gpui::{
-    div, AnyElement, AppContext, Context as _, Empty, EventEmitter, FocusableView, IntoElement,
-    Model, ParentElement as _, Render, SharedString, Styled as _, View, ViewContext,
-    VisualContext as _, WeakModel, WindowContext,
-};
-use language::{language_settings::SoftWrap, Anchor, Buffer, LanguageRegistry};
-use std::{ops::DerefMut, sync::Arc};
-use text::OffsetRangeExt;
-use theme::ActiveTheme as _;
-use ui::{
-    h_flex, v_flex, ButtonCommon as _, ButtonLike, ButtonStyle, Color, Icon, IconName,
-    InteractiveElement as _, Label, LabelCommon as _,
-};
-use workspace::{
-    item::{self, Item},
-    pane,
-    searchable::SearchableItemHandle,
-};
-
-pub struct WorkflowStepView {
-    step: WeakModel<WorkflowStep>,
-    tool_output_buffer: Model<Buffer>,
-    editor: View<Editor>,
-}
-
-impl WorkflowStepView {
-    pub fn new(
-        context: Model<Context>,
-        step: Model<WorkflowStep>,
-        language_registry: Arc<LanguageRegistry>,
-        cx: &mut ViewContext<Self>,
-    ) -> Self {
-        let tool_output_buffer =
-            cx.new_model(|cx| Buffer::local(step.read(cx).tool_output.clone(), cx));
-        let buffer = cx.new_model(|cx| {
-            let mut buffer = MultiBuffer::without_headers(0, language::Capability::ReadWrite);
-            buffer.push_excerpts(
-                context.read(cx).buffer().clone(),
-                [ExcerptRange {
-                    context: step.read(cx).context_buffer_range.clone(),
-                    primary: None,
-                }],
-                cx,
-            );
-            buffer.push_excerpts(
-                tool_output_buffer.clone(),
-                [ExcerptRange {
-                    context: Anchor::MIN..Anchor::MAX,
-                    primary: None,
-                }],
-                cx,
-            );
-            buffer
-        });
-
-        let buffer_snapshot = buffer.read(cx).snapshot(cx);
-        let output_excerpt = buffer_snapshot.excerpts().skip(1).next().unwrap().0;
-        let input_start_anchor = multi_buffer::Anchor::min();
-        let output_start_anchor = buffer_snapshot
-            .anchor_in_excerpt(output_excerpt, Anchor::MIN)
-            .unwrap();
-        let output_end_anchor = multi_buffer::Anchor::max();
-
-        let handle = cx.view().downgrade();
-        let editor = cx.new_view(|cx| {
-            let mut editor = Editor::for_multibuffer(buffer.clone(), None, false, cx);
-            editor.set_soft_wrap_mode(SoftWrap::EditorWidth, cx);
-            editor.set_show_line_numbers(false, cx);
-            editor.set_show_git_diff_gutter(false, cx);
-            editor.set_show_code_actions(false, cx);
-            editor.set_show_runnables(false, cx);
-            editor.set_show_wrap_guides(false, cx);
-            editor.set_show_indent_guides(false, cx);
-            editor.set_read_only(true);
-            editor.set_show_inline_completions(false);
-            editor.insert_blocks(
-                [
-                    BlockProperties {
-                        position: input_start_anchor,
-                        height: 1,
-                        style: BlockStyle::Fixed,
-                        render: Box::new(|cx| section_header("Step Input", cx)),
-                        disposition: BlockDisposition::Above,
-                        priority: 0,
-                    },
-                    BlockProperties {
-                        position: output_start_anchor,
-                        height: 1,
-                        style: BlockStyle::Fixed,
-                        render: Box::new(|cx| section_header("Tool Output", cx)),
-                        disposition: BlockDisposition::Above,
-                        priority: 0,
-                    },
-                    BlockProperties {
-                        position: output_end_anchor,
-                        height: 1,
-                        style: BlockStyle::Fixed,
-                        render: Box::new(move |cx| {
-                            if let Some(result) = handle.upgrade().and_then(|this| {
-                                this.update(cx.deref_mut(), |this, cx| this.render_result(cx))
-                            }) {
-                                v_flex()
-                                    .child(section_header("Output", cx))
-                                    .child(
-                                        div().pl(cx.gutter_dimensions.full_width()).child(result),
-                                    )
-                                    .into_any_element()
-                            } else {
-                                Empty.into_any_element()
-                            }
-                        }),
-                        disposition: BlockDisposition::Below,
-                        priority: 0,
-                    },
-                ],
-                None,
-                cx,
-            );
-            editor
-        });
-
-        cx.observe(&step, Self::step_updated).detach();
-        cx.observe_release(&step, Self::step_released).detach();
-
-        cx.spawn(|this, mut cx| async move {
-            if let Ok(language) = language_registry.language_for_name("JSON").await {
-                this.update(&mut cx, |this, cx| {
-                    this.tool_output_buffer.update(cx, |buffer, cx| {
-                        buffer.set_language(Some(language), cx);
-                    });
-                })
-                .ok();
-            }
-        })
-        .detach();
-
-        Self {
-            tool_output_buffer,
-            step: step.downgrade(),
-            editor,
-        }
-    }
-
-    pub fn step(&self) -> &WeakModel<WorkflowStep> {
-        &self.step
-    }
-
-    fn render_result(&mut self, cx: &mut ViewContext<Self>) -> Option<AnyElement> {
-        let step = self.step.upgrade()?;
-        let result = step.read(cx).resolution.as_ref()?;
-        match result {
-            Ok(result) => {
-                Some(
-                    v_flex()
-                        .child(result.title.clone())
-                        .children(result.suggestion_groups.iter().filter_map(
-                            |(buffer, suggestion_groups)| {
-                                let buffer = buffer.read(cx);
-                                let path = buffer.file().map(|f| f.path());
-                                let snapshot = buffer.snapshot();
-                                v_flex()
-                                    .mb_2()
-                                    .border_b_1()
-                                    .children(path.map(|path| format!("path: {}", path.display())))
-                                    .children(suggestion_groups.iter().map(|group| {
-                                        v_flex().pt_2().pl_2().children(
-                                            group.suggestions.iter().map(|suggestion| {
-                                                let range = suggestion.range().to_point(&snapshot);
-                                                v_flex()
-                                                    .children(
-                                                        suggestion.description().map(|desc| {
-                                                            format!("description: {desc}")
-                                                        }),
-                                                    )
-                                                    .child(format!("kind: {}", suggestion.kind()))
-                                                    .children(suggestion.symbol_path().map(
-                                                        |path| format!("symbol path: {}", path.0),
-                                                    ))
-                                                    .child(format!(
-                                                        "lines: {} - {}",
-                                                        range.start.row + 1,
-                                                        range.end.row + 1
-                                                    ))
-                                            }),
-                                        )
-                                    }))
-                                    .into()
-                            },
-                        ))
-                        .into_any_element(),
-                )
-            }
-            Err(error) => Some(format!("{:?}", error).into_any_element()),
-        }
-    }
-
-    fn step_updated(&mut self, step: Model<WorkflowStep>, cx: &mut ViewContext<Self>) {
-        self.tool_output_buffer.update(cx, |buffer, cx| {
-            let text = step.read(cx).tool_output.clone();
-            buffer.set_text(text, cx);
-        });
-        cx.notify();
-    }
-
-    fn step_released(&mut self, _: &mut WorkflowStep, cx: &mut ViewContext<Self>) {
-        cx.emit(EditorEvent::Closed);
-    }
-
-    fn resolve(&mut self, _: &Assist, cx: &mut ViewContext<Self>) {
-        self.step
-            .update(cx, |step, cx| {
-                step.resolve(cx);
-            })
-            .ok();
-    }
-}
-
-fn section_header(
-    name: &'static str,
-    cx: &mut editor::display_map::BlockContext,
-) -> gpui::AnyElement {
-    h_flex()
-        .pl(cx.gutter_dimensions.full_width())
-        .h_11()
-        .w_full()
-        .relative()
-        .gap_1()
-        .child(
-            ButtonLike::new("role")
-                .style(ButtonStyle::Filled)
-                .child(Label::new(name).color(Color::Default)),
-        )
-        .into_any_element()
-}
-
-impl Render for WorkflowStepView {
-    fn render(&mut self, cx: &mut ViewContext<Self>) -> impl IntoElement {
-        div()
-            .key_context("ContextEditor")
-            .on_action(cx.listener(Self::resolve))
-            .flex_grow()
-            .bg(cx.theme().colors().editor_background)
-            .child(self.editor.clone())
-    }
-}
-
-impl EventEmitter<EditorEvent> for WorkflowStepView {}
-
-impl FocusableView for WorkflowStepView {
-    fn focus_handle(&self, cx: &gpui::AppContext) -> gpui::FocusHandle {
-        self.editor.read(cx).focus_handle(cx)
-    }
-}
-
-impl Item for WorkflowStepView {
-    type Event = EditorEvent;
-
-    fn tab_content_text(&self, cx: &WindowContext) -> Option<SharedString> {
-        let step = self.step.upgrade()?.read(cx);
-        let context = step.context.upgrade()?.read(cx);
-        let buffer = context.buffer().read(cx);
-        let index = context
-            .workflow_step_index_for_range(&step.context_buffer_range, buffer)
-            .ok()?
-            + 1;
-        Some(format!("Step {index}").into())
-    }
-
-    fn tab_icon(&self, _cx: &WindowContext) -> Option<ui::Icon> {
-        Some(Icon::new(IconName::SearchCode))
-    }
-
-    fn to_item_events(event: &Self::Event, mut f: impl FnMut(item::ItemEvent)) {
-        match event {
-            EditorEvent::Edited { .. } => {
-                f(item::ItemEvent::Edit);
-            }
-            EditorEvent::TitleChanged => {
-                f(item::ItemEvent::UpdateTab);
-            }
-            EditorEvent::Closed => f(item::ItemEvent::CloseItem),
-            _ => {}
-        }
-    }
-
-    fn tab_tooltip_text(&self, _cx: &AppContext) -> Option<SharedString> {
-        None
-    }
-
-    fn as_searchable(&self, _handle: &View<Self>) -> Option<Box<dyn SearchableItemHandle>> {
-        None
-    }
-
-    fn set_nav_history(&mut self, nav_history: pane::ItemNavHistory, cx: &mut ViewContext<Self>) {
-        self.editor.update(cx, |editor, cx| {
-            Item::set_nav_history(editor, nav_history, cx)
-        })
-    }
-
-    fn navigate(&mut self, data: Box<dyn std::any::Any>, cx: &mut ViewContext<Self>) -> bool {
-        self.editor
-            .update(cx, |editor, cx| Item::navigate(editor, data, cx))
-    }
-
-    fn deactivated(&mut self, cx: &mut ViewContext<Self>) {
-        self.editor
-            .update(cx, |editor, cx| Item::deactivated(editor, cx))
-    }
-}

crates/assistant_slash_command/src/assistant_slash_command.rs

@@ -15,35 +15,6 @@ pub fn init(cx: &mut AppContext) {
     SlashCommandRegistry::default_global(cx);
 }
 
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub enum AfterCompletion {
-    /// Run the command
-    Run,
-    /// Continue composing the current argument, doesn't add a space
-    Compose,
-    /// Continue the command composition, adds a space
-    Continue,
-}
-
-impl From<bool> for AfterCompletion {
-    fn from(value: bool) -> Self {
-        if value {
-            AfterCompletion::Run
-        } else {
-            AfterCompletion::Continue
-        }
-    }
-}
-
-impl AfterCompletion {
-    pub fn run(&self) -> bool {
-        match self {
-            AfterCompletion::Run => true,
-            AfterCompletion::Compose | AfterCompletion::Continue => false,
-        }
-    }
-}
-
 #[derive(Debug)]
 pub struct ArgumentCompletion {
     /// The label to display for this completion.
@@ -51,9 +22,7 @@ pub struct ArgumentCompletion {
     /// The new text that should be inserted into the command when this completion is accepted.
     pub new_text: String,
     /// Whether the command should be run when accepting this completion.
-    pub after_completion: AfterCompletion,
-    /// Whether to replace the all arguments, or whether to treat this as an independent argument.
-    pub replace_previous_arguments: bool,
+    pub run_command: bool,
 }
 
 pub trait SlashCommand: 'static + Send + Sync {
@@ -65,18 +34,15 @@ pub trait SlashCommand: 'static + Send + Sync {
     fn menu_text(&self) -> String;
     fn complete_argument(
         self: Arc<Self>,
-        arguments: &[String],
+        query: String,
         cancel: Arc<AtomicBool>,
         workspace: Option<WeakView<Workspace>>,
         cx: &mut WindowContext,
     ) -> Task<Result<Vec<ArgumentCompletion>>>;
     fn requires_argument(&self) -> bool;
-    fn accepts_arguments(&self) -> bool {
-        self.requires_argument()
-    }
     fn run(
         self: Arc<Self>,
-        arguments: &[String],
+        argument: Option<&str>,
         workspace: WeakView<Workspace>,
         // TODO: We're just using the `LspAdapterDelegate` here because that is
         // what the extension API is already expecting.

crates/assistant_slash_command/src/slash_command_registry.rs

@@ -58,14 +58,10 @@ impl SlashCommandRegistry {
 
     /// Unregisters the provided [`SlashCommand`].
     pub fn unregister_command(&self, command: impl SlashCommand) {
-        self.unregister_command_by_name(command.name().as_str())
-    }
-
-    /// Unregisters the command with the given name.
-    pub fn unregister_command_by_name(&self, command_name: &str) {
         let mut state = self.state.write();
-        state.featured_commands.remove(command_name);
-        state.commands.remove(command_name);
+        let command_name: Arc<str> = command.name().into();
+        state.featured_commands.remove(&command_name);
+        state.commands.remove(&command_name);
     }
 
     /// Returns the names of registered [`SlashCommand`]s.

crates/collab/k8s/collab.template.yml

@@ -139,11 +139,6 @@ spec:
                 secretKeyRef:
                   name: anthropic
                   key: staff_api_key
-            - name: LLM_CLOSED_BETA_MODEL_NAME
-              valueFrom:
-                secretKeyRef:
-                  name: llm-closed-beta
-                  key: model_name
             - name: GOOGLE_AI_API_KEY
               valueFrom:
                 secretKeyRef:

crates/collab/migrations.sqlite/20221109000000_test_schema.sql

@@ -295,8 +295,7 @@ CREATE UNIQUE INDEX "index_channel_buffer_collaborators_on_channel_id_connection
 
 CREATE TABLE "feature_flags" (
     "id" INTEGER PRIMARY KEY AUTOINCREMENT,
-    "flag" TEXT NOT NULL UNIQUE,
-    "enabled_for_all" BOOLEAN NOT NULL DEFAULT false
+    "flag" TEXT NOT NULL UNIQUE
 );
 
 CREATE INDEX "index_feature_flags" ON "feature_flags" ("id");

crates/collab/migrations/20240816181658_add_enabled_for_all_to_feature_flags.sql

@@ -1 +0,0 @@
-alter table feature_flags add column enabled_for_all boolean not null default false;

crates/collab/postgrest_app.conf

@@ -1,4 +1,4 @@
-db-uri = "postgres://postgres@localhost/zed"
-server-port = 8081
+db-uri = "postgres://postgres@localhost/zed_llm"
+server-port = 8082
 jwt-secret = "the-postgrest-jwt-secret-for-authorization"
 log-level = "info"

crates/collab/postgrest_llm.conf

@@ -1,4 +1,4 @@
-db-uri = "postgres://postgres@localhost/zed_llm"
-server-port = 8082
+db-uri = "postgres://postgres@localhost/zed"
+server-port = 8081
 jwt-secret = "the-postgrest-jwt-secret-for-authorization"
 log-level = "info"

crates/collab/src/api/events.rs

@@ -1,6 +1,5 @@
 use super::ips_file::IpsFile;
 use crate::api::CloudflareIpCountryHeader;
-use crate::clickhouse::write_to_table;
 use crate::{api::slack, AppState, Error, Result};
 use anyhow::{anyhow, Context};
 use aws_sdk_s3::primitives::ByteStream;
@@ -530,12 +529,12 @@ struct ToUpload {
 impl ToUpload {
     pub async fn upload(&self, clickhouse_client: &clickhouse::Client) -> anyhow::Result<()> {
         const EDITOR_EVENTS_TABLE: &str = "editor_events";
-        write_to_table(EDITOR_EVENTS_TABLE, &self.editor_events, clickhouse_client)
+        Self::upload_to_table(EDITOR_EVENTS_TABLE, &self.editor_events, clickhouse_client)
             .await
             .with_context(|| format!("failed to upload to table '{EDITOR_EVENTS_TABLE}'"))?;
 
         const INLINE_COMPLETION_EVENTS_TABLE: &str = "inline_completion_events";
-        write_to_table(
+        Self::upload_to_table(
             INLINE_COMPLETION_EVENTS_TABLE,
             &self.inline_completion_events,
             clickhouse_client,
@@ -544,7 +543,7 @@ impl ToUpload {
         .with_context(|| format!("failed to upload to table '{INLINE_COMPLETION_EVENTS_TABLE}'"))?;
 
         const ASSISTANT_EVENTS_TABLE: &str = "assistant_events";
-        write_to_table(
+        Self::upload_to_table(
             ASSISTANT_EVENTS_TABLE,
             &self.assistant_events,
             clickhouse_client,
@@ -553,27 +552,27 @@ impl ToUpload {
         .with_context(|| format!("failed to upload to table '{ASSISTANT_EVENTS_TABLE}'"))?;
 
         const CALL_EVENTS_TABLE: &str = "call_events";
-        write_to_table(CALL_EVENTS_TABLE, &self.call_events, clickhouse_client)
+        Self::upload_to_table(CALL_EVENTS_TABLE, &self.call_events, clickhouse_client)
             .await
             .with_context(|| format!("failed to upload to table '{CALL_EVENTS_TABLE}'"))?;
 
         const CPU_EVENTS_TABLE: &str = "cpu_events";
-        write_to_table(CPU_EVENTS_TABLE, &self.cpu_events, clickhouse_client)
+        Self::upload_to_table(CPU_EVENTS_TABLE, &self.cpu_events, clickhouse_client)
             .await
             .with_context(|| format!("failed to upload to table '{CPU_EVENTS_TABLE}'"))?;
 
         const MEMORY_EVENTS_TABLE: &str = "memory_events";
-        write_to_table(MEMORY_EVENTS_TABLE, &self.memory_events, clickhouse_client)
+        Self::upload_to_table(MEMORY_EVENTS_TABLE, &self.memory_events, clickhouse_client)
             .await
             .with_context(|| format!("failed to upload to table '{MEMORY_EVENTS_TABLE}'"))?;
 
         const APP_EVENTS_TABLE: &str = "app_events";
-        write_to_table(APP_EVENTS_TABLE, &self.app_events, clickhouse_client)
+        Self::upload_to_table(APP_EVENTS_TABLE, &self.app_events, clickhouse_client)
             .await
             .with_context(|| format!("failed to upload to table '{APP_EVENTS_TABLE}'"))?;
 
         const SETTING_EVENTS_TABLE: &str = "setting_events";
-        write_to_table(
+        Self::upload_to_table(
             SETTING_EVENTS_TABLE,
             &self.setting_events,
             clickhouse_client,
@@ -582,7 +581,7 @@ impl ToUpload {
         .with_context(|| format!("failed to upload to table '{SETTING_EVENTS_TABLE}'"))?;
 
         const EXTENSION_EVENTS_TABLE: &str = "extension_events";
-        write_to_table(
+        Self::upload_to_table(
             EXTENSION_EVENTS_TABLE,
             &self.extension_events,
             clickhouse_client,
@@ -591,22 +590,48 @@ impl ToUpload {
         .with_context(|| format!("failed to upload to table '{EXTENSION_EVENTS_TABLE}'"))?;
 
         const EDIT_EVENTS_TABLE: &str = "edit_events";
-        write_to_table(EDIT_EVENTS_TABLE, &self.edit_events, clickhouse_client)
+        Self::upload_to_table(EDIT_EVENTS_TABLE, &self.edit_events, clickhouse_client)
             .await
             .with_context(|| format!("failed to upload to table '{EDIT_EVENTS_TABLE}'"))?;
 
         const ACTION_EVENTS_TABLE: &str = "action_events";
-        write_to_table(ACTION_EVENTS_TABLE, &self.action_events, clickhouse_client)
+        Self::upload_to_table(ACTION_EVENTS_TABLE, &self.action_events, clickhouse_client)
             .await
             .with_context(|| format!("failed to upload to table '{ACTION_EVENTS_TABLE}'"))?;
 
         const REPL_EVENTS_TABLE: &str = "repl_events";
-        write_to_table(REPL_EVENTS_TABLE, &self.repl_events, clickhouse_client)
+        Self::upload_to_table(REPL_EVENTS_TABLE, &self.repl_events, clickhouse_client)
             .await
             .with_context(|| format!("failed to upload to table '{REPL_EVENTS_TABLE}'"))?;
 
         Ok(())
     }
+
+    async fn upload_to_table<T: clickhouse::Row + Serialize + std::fmt::Debug>(
+        table: &str,
+        rows: &[T],
+        clickhouse_client: &clickhouse::Client,
+    ) -> anyhow::Result<()> {
+        if rows.is_empty() {
+            return Ok(());
+        }
+
+        let mut insert = clickhouse_client.insert(table)?;
+
+        for event in rows {
+            insert.write(event).await?;
+        }
+
+        insert.end().await?;
+
+        let event_count = rows.len();
+        log::info!(
+            "wrote {event_count} {event_specifier} to '{table}'",
+            event_specifier = if event_count == 1 { "event" } else { "events" }
+        );
+
+        Ok(())
+    }
 }
 
 pub fn serialize_country_code<S>(country_code: &str, serializer: S) -> Result<S::Ok, S::Error>

crates/collab/src/clickhouse.rs

@@ -1,28 +0,0 @@
-use serde::Serialize;
-
-/// Writes the given rows to the specified Clickhouse table.
-pub async fn write_to_table<T: clickhouse::Row + Serialize + std::fmt::Debug>(
-    table: &str,
-    rows: &[T],
-    clickhouse_client: &clickhouse::Client,
-) -> anyhow::Result<()> {
-    if rows.is_empty() {
-        return Ok(());
-    }
-
-    let mut insert = clickhouse_client.insert(table)?;
-
-    for event in rows {
-        insert.write(event).await?;
-    }
-
-    insert.end().await?;
-
-    let event_count = rows.len();
-    log::info!(
-        "wrote {event_count} {event_specifier} to '{table}'",
-        event_specifier = if event_count == 1 { "event" } else { "events" }
-    );
-
-    Ok(())
-}

crates/collab/src/db/queries/users.rs

@@ -312,11 +312,10 @@ impl Database {
     }
 
     /// Creates a new feature flag.
-    pub async fn create_user_flag(&self, flag: &str, enabled_for_all: bool) -> Result<FlagId> {
+    pub async fn create_user_flag(&self, flag: &str) -> Result<FlagId> {
         self.transaction(|tx| async move {
             let flag = feature_flag::Entity::insert(feature_flag::ActiveModel {
                 flag: ActiveValue::set(flag.to_string()),
-                enabled_for_all: ActiveValue::set(enabled_for_all),
                 ..Default::default()
             })
             .exec(&*tx)
@@ -351,15 +350,7 @@ impl Database {
                 Flag,
             }
 
-            let flags_enabled_for_all = feature_flag::Entity::find()
-                .filter(feature_flag::Column::EnabledForAll.eq(true))
-                .select_only()
-                .column(feature_flag::Column::Flag)
-                .into_values::<_, QueryAs>()
-                .all(&*tx)
-                .await?;
-
-            let flags_enabled_for_user = user::Model {
+            let flags = user::Model {
                 id: user,
                 ..Default::default()
             }
@@ -370,10 +361,7 @@ impl Database {
             .all(&*tx)
             .await?;
 
-            let mut all_flags = HashSet::from_iter(flags_enabled_for_all);
-            all_flags.extend(flags_enabled_for_user);
-
-            Ok(all_flags.into_iter().collect())
+            Ok(flags)
         })
         .await
     }

crates/collab/src/db/tables/feature_flag.rs

@@ -8,7 +8,6 @@ pub struct Model {
     #[sea_orm(primary_key)]
     pub id: FlagId,
     pub flag: String,
-    pub enabled_for_all: bool,
 }
 
 #[derive(Copy, Clone, Debug, EnumIter, DeriveRelation)]

crates/collab/src/db/tests/feature_flag_tests.rs

@@ -2,7 +2,6 @@ use crate::{
     db::{Database, NewUserParams},
     test_both_dbs,
 };
-use pretty_assertions::assert_eq;
 use std::sync::Arc;
 
 test_both_dbs!(
@@ -38,27 +37,22 @@ async fn test_get_user_flags(db: &Arc<Database>) {
         .unwrap()
         .user_id;
 
-    const FEATURE_FLAG_ONE: &str = "brand-new-ux";
-    const FEATURE_FLAG_TWO: &str = "cool-feature";
-    const FEATURE_FLAG_THREE: &str = "feature-enabled-for-everyone";
+    const CHANNELS_ALPHA: &str = "channels-alpha";
+    const NEW_SEARCH: &str = "new-search";
 
-    let feature_flag_one = db.create_user_flag(FEATURE_FLAG_ONE, false).await.unwrap();
-    let feature_flag_two = db.create_user_flag(FEATURE_FLAG_TWO, false).await.unwrap();
-    db.create_user_flag(FEATURE_FLAG_THREE, true).await.unwrap();
+    let channels_flag = db.create_user_flag(CHANNELS_ALPHA).await.unwrap();
+    let search_flag = db.create_user_flag(NEW_SEARCH).await.unwrap();
 
-    db.add_user_flag(user_1, feature_flag_one).await.unwrap();
-    db.add_user_flag(user_1, feature_flag_two).await.unwrap();
+    db.add_user_flag(user_1, channels_flag).await.unwrap();
+    db.add_user_flag(user_1, search_flag).await.unwrap();
 
-    db.add_user_flag(user_2, feature_flag_one).await.unwrap();
+    db.add_user_flag(user_2, channels_flag).await.unwrap();
 
     let mut user_1_flags = db.get_user_flags(user_1).await.unwrap();
     user_1_flags.sort();
-    assert_eq!(
-        user_1_flags,
-        &[FEATURE_FLAG_ONE, FEATURE_FLAG_TWO, FEATURE_FLAG_THREE]
-    );
+    assert_eq!(user_1_flags, &[CHANNELS_ALPHA, NEW_SEARCH]);
 
     let mut user_2_flags = db.get_user_flags(user_2).await.unwrap();
     user_2_flags.sort();
-    assert_eq!(user_2_flags, &[FEATURE_FLAG_ONE, FEATURE_FLAG_THREE]);
+    assert_eq!(user_2_flags, &[CHANNELS_ALPHA]);
 }

crates/collab/src/env.rs

@@ -32,7 +32,6 @@ fn add_vars(env_content: String, vars: &mut Vec<(String, String)>) -> Result<()>
             toml::Value::String(value) => value,
             toml::Value::Integer(value) => value.to_string(),
             toml::Value::Float(value) => value.to_string(),
-            toml::Value::Boolean(value) => value.to_string(),
             _ => panic!("unsupported TOML value in .env.toml for key {}", key),
         };
         vars.push((key, value));

crates/collab/src/lib.rs

@@ -1,6 +1,5 @@
 pub mod api;
 pub mod auth;
-pub mod clickhouse;
 pub mod db;
 pub mod env;
 pub mod executor;
@@ -168,7 +167,6 @@ pub struct Config {
     pub google_ai_api_key: Option<Arc<str>>,
     pub anthropic_api_key: Option<Arc<str>>,
     pub anthropic_staff_api_key: Option<Arc<str>>,
-    pub llm_closed_beta_model_name: Option<Arc<str>>,
     pub qwen2_7b_api_key: Option<Arc<str>>,
     pub qwen2_7b_api_url: Option<Arc<str>>,
     pub zed_client_checksum_seed: Option<String>,
@@ -220,7 +218,6 @@ impl Config {
             google_ai_api_key: None,
             anthropic_api_key: None,
             anthropic_staff_api_key: None,
-            llm_closed_beta_model_name: None,
             clickhouse_url: None,
             clickhouse_user: None,
             clickhouse_password: None,
@@ -270,7 +267,7 @@ pub struct AppState {
     pub stripe_client: Option<Arc<stripe::Client>>,
     pub rate_limiter: Arc<RateLimiter>,
     pub executor: Executor,
-    pub clickhouse_client: Option<::clickhouse::Client>,
+    pub clickhouse_client: Option<clickhouse::Client>,
     pub config: Config,
 }
 
@@ -361,8 +358,8 @@ async fn build_blob_store_client(config: &Config) -> anyhow::Result<aws_sdk_s3::
     Ok(aws_sdk_s3::Client::new(&s3_config))
 }
 
-fn build_clickhouse_client(config: &Config) -> anyhow::Result<::clickhouse::Client> {
-    Ok(::clickhouse::Client::default()
+fn build_clickhouse_client(config: &Config) -> anyhow::Result<clickhouse::Client> {
+    Ok(clickhouse::Client::default()
         .with_url(
             config
                 .clickhouse_url

crates/collab/src/llm.rs

@@ -138,11 +138,7 @@ async fn validate_api_token<B>(mut req: Request<B>, next: Next<B>) -> impl IntoR
                 ));
             }
 
-            tracing::Span::current()
-                .record("user_id", claims.user_id)
-                .record("login", claims.github_user_login.clone())
-                .record("authn.jti", &claims.jti)
-                .record("is_staff", &claims.is_staff);
+            tracing::Span::current().record("authn.jti", &claims.jti);
 
             req.extensions_mut().insert(claims);
             Ok::<_, Error>(next.run(req).await.into_response())
@@ -170,10 +166,7 @@ async fn perform_completion(
     country_code_header: Option<TypedHeader<CloudflareIpCountryHeader>>,
     Json(params): Json<PerformCompletionParams>,
 ) -> Result<impl IntoResponse> {
-    let model = normalize_model_name(
-        state.db.model_names_for_provider(params.provider),
-        params.model,
-    );
+    let model = normalize_model_name(params.provider, params.model);
 
     authorize_access_to_language_model(
         &state.config,
@@ -204,21 +197,17 @@ async fn perform_completion(
             let mut request: anthropic::Request =
                 serde_json::from_str(&params.provider_request.get())?;
 
-            // Override the model on the request with the latest version of the model that is
-            // known to the server.
-            //
+            // Parse the model, throw away the version that was included, and then set a specific
+            // version that we control on the server.
             // Right now, we use the version that's defined in `model.id()`, but we will likely
             // want to change this code once a new version of an Anthropic model is released,
             // so that users can use the new version, without having to update Zed.
-            request.model = match model.as_str() {
-                "claude-3-5-sonnet" => anthropic::Model::Claude3_5Sonnet.id().to_string(),
-                "claude-3-opus" => anthropic::Model::Claude3Opus.id().to_string(),
-                "claude-3-haiku" => anthropic::Model::Claude3Haiku.id().to_string(),
-                "claude-3-sonnet" => anthropic::Model::Claude3Sonnet.id().to_string(),
-                _ => request.model,
+            request.model = match anthropic::Model::from_id(&request.model) {
+                Ok(model) => model.id().to_string(),
+                Err(_) => request.model,
             };
 
-            let (chunks, rate_limit_info) = anthropic::stream_completion_with_rate_limit_info(
+            let chunks = anthropic::stream_completion(
                 &state.http_client,
                 anthropic::ANTHROPIC_API_URL,
                 api_key,
@@ -246,19 +235,6 @@ async fn perform_completion(
                 anthropic::AnthropicError::Other(err) => Error::Internal(err),
             })?;
 
-            if let Some(rate_limit_info) = rate_limit_info {
-                tracing::info!(
-                    target: "upstream rate limit",
-                    is_staff = claims.is_staff,
-                    provider = params.provider.to_string(),
-                    model = model,
-                    tokens_remaining = rate_limit_info.tokens_remaining,
-                    requests_remaining = rate_limit_info.requests_remaining,
-                    requests_reset = ?rate_limit_info.requests_reset,
-                    tokens_reset = ?rate_limit_info.tokens_reset,
-                );
-            }
-
             chunks
                 .map(move |event| {
                     let chunk = event?;
@@ -390,13 +366,31 @@ async fn perform_completion(
     })))
 }
 
-fn normalize_model_name(known_models: Vec<String>, name: String) -> String {
-    if let Some(known_model_name) = known_models
+fn normalize_model_name(provider: LanguageModelProvider, name: String) -> String {
+    let prefixes: &[_] = match provider {
+        LanguageModelProvider::Anthropic => &[
+            "claude-3-5-sonnet",
+            "claude-3-haiku",
+            "claude-3-opus",
+            "claude-3-sonnet",
+        ],
+        LanguageModelProvider::OpenAi => &[
+            "gpt-3.5-turbo",
+            "gpt-4-turbo-preview",
+            "gpt-4o-mini",
+            "gpt-4o",
+            "gpt-4",
+        ],
+        LanguageModelProvider::Google => &[],
+        LanguageModelProvider::Zed => &[],
+    };
+
+    if let Some(prefix) = prefixes
         .iter()
-        .filter(|known_model_name| name.starts_with(known_model_name.as_str()))
-        .max_by_key(|known_model_name| known_model_name.len())
+        .filter(|&&prefix| name.starts_with(prefix))
+        .max_by_key(|&&prefix| prefix.len())
     {
-        known_model_name.to_string()
+        prefix.to_string()
     } else {
         name
     }
@@ -554,75 +548,33 @@ impl<S> Drop for TokenCountingStream<S> {
                 .await
                 .log_err();
 
-            if let Some(usage) = usage {
-                tracing::info!(
-                    target: "user usage",
-                    user_id = claims.user_id,
-                    login = claims.github_user_login,
-                    authn.jti = claims.jti,
-                    is_staff = claims.is_staff,
-                    requests_this_minute = usage.requests_this_minute,
-                    tokens_this_minute = usage.tokens_this_minute,
-                );
-
-                if let Some(clickhouse_client) = state.clickhouse_client.as_ref() {
-                    report_llm_usage(
-                        clickhouse_client,
-                        LlmUsageEventRow {
-                            time: Utc::now().timestamp_millis(),
-                            user_id: claims.user_id as i32,
-                            is_staff: claims.is_staff,
-                            plan: match claims.plan {
-                                Plan::Free => "free".to_string(),
-                                Plan::ZedPro => "zed_pro".to_string(),
-                            },
-                            model,
-                            provider: provider.to_string(),
-                            input_token_count: input_token_count as u64,
-                            output_token_count: output_token_count as u64,
-                            requests_this_minute: usage.requests_this_minute as u64,
-                            tokens_this_minute: usage.tokens_this_minute as u64,
-                            tokens_this_day: usage.tokens_this_day as u64,
-                            input_tokens_this_month: usage.input_tokens_this_month as u64,
-                            output_tokens_this_month: usage.output_tokens_this_month as u64,
-                            spending_this_month: usage.spending_this_month as u64,
-                            lifetime_spending: usage.lifetime_spending as u64,
+            if let Some((clickhouse_client, usage)) = state.clickhouse_client.as_ref().zip(usage) {
+                report_llm_usage(
+                    clickhouse_client,
+                    LlmUsageEventRow {
+                        time: Utc::now().timestamp_millis(),
+                        user_id: claims.user_id as i32,
+                        is_staff: claims.is_staff,
+                        plan: match claims.plan {
+                            Plan::Free => "free".to_string(),
+                            Plan::ZedPro => "zed_pro".to_string(),
                         },
-                    )
-                    .await
-                    .log_err();
-                }
+                        model,
+                        provider: provider.to_string(),
+                        input_token_count: input_token_count as u64,
+                        output_token_count: output_token_count as u64,
+                        requests_this_minute: usage.requests_this_minute as u64,
+                        tokens_this_minute: usage.tokens_this_minute as u64,
+                        tokens_this_day: usage.tokens_this_day as u64,
+                        input_tokens_this_month: usage.input_tokens_this_month as u64,
+                        output_tokens_this_month: usage.output_tokens_this_month as u64,
+                        spending_this_month: usage.spending_this_month as u64,
+                        lifetime_spending: usage.lifetime_spending as u64,
+                    },
+                )
+                .await
+                .log_err();
             }
         })
     }
 }
-
-pub fn log_usage_periodically(state: Arc<LlmState>) {
-    state.executor.clone().spawn_detached(async move {
-        loop {
-            state
-                .executor
-                .sleep(std::time::Duration::from_secs(30))
-                .await;
-
-            let Some(usages) = state
-                .db
-                .get_application_wide_usages_by_model(Utc::now())
-                .await
-                .log_err()
-            else {
-                continue;
-            };
-
-            for usage in usages {
-                tracing::info!(
-                    target: "computed usage",
-                    provider = usage.provider.to_string(),
-                    model = usage.model,
-                    requests_this_minute = usage.requests_this_minute,
-                    tokens_this_minute = usage.tokens_this_minute,
-                );
-            }
-        }
-    })
-}

crates/collab/src/llm/authorization.rs

@@ -12,12 +12,11 @@ pub fn authorize_access_to_language_model(
     model: &str,
 ) -> Result<()> {
     authorize_access_for_country(config, country_code, provider)?;
-    authorize_access_to_model(config, claims, provider, model)?;
+    authorize_access_to_model(claims, provider, model)?;
     Ok(())
 }
 
 fn authorize_access_to_model(
-    config: &Config,
     claims: &LlmTokenClaims,
     provider: LanguageModelProvider,
     model: &str,
@@ -26,25 +25,15 @@ fn authorize_access_to_model(
         return Ok(());
     }
 
-    match provider {
-        LanguageModelProvider::Anthropic => {
-            if model == "claude-3-5-sonnet" {
-                return Ok(());
-            }
-
-            if claims.has_llm_closed_beta_feature_flag
-                && Some(model) == config.llm_closed_beta_model_name.as_deref()
-            {
-                return Ok(());
-            }
+    match (provider, model) {
+        (LanguageModelProvider::Anthropic, model) if model.starts_with("claude-3.5-sonnet") => {
+            Ok(())
         }
-        _ => {}
+        _ => Err(Error::http(
+            StatusCode::FORBIDDEN,
+            format!("access to model {model:?} is not included in your plan"),
+        ))?,
     }
-
-    Err(Error::http(
-        StatusCode::FORBIDDEN,
-        format!("access to model {model:?} is not included in your plan"),
-    ))
 }
 
 fn authorize_access_for_country(
@@ -251,14 +240,14 @@ mod tests {
             (
                 Plan::ZedPro,
                 LanguageModelProvider::Anthropic,
-                "claude-3-5-sonnet",
+                "claude-3.5-sonnet",
                 true,
             ),
             // Free plan should have access to claude-3.5-sonnet
             (
                 Plan::Free,
                 LanguageModelProvider::Anthropic,
-                "claude-3-5-sonnet",
+                "claude-3.5-sonnet",
                 true,
             ),
             // Pro plan should NOT have access to other Anthropic models
@@ -314,7 +303,7 @@ mod tests {
 
         // Staff should have access to all models
         let test_cases = vec![
-            (LanguageModelProvider::Anthropic, "claude-3-5-sonnet"),
+            (LanguageModelProvider::Anthropic, "claude-3.5-sonnet"),
             (LanguageModelProvider::Anthropic, "claude-2"),
             (LanguageModelProvider::Anthropic, "claude-123-agi"),
             (LanguageModelProvider::OpenAi, "gpt-4"),

crates/collab/src/llm/db.rs

@@ -67,21 +67,6 @@ impl LlmDatabase {
         Ok(())
     }
 
-    /// Returns the names of the known models for the given [`LanguageModelProvider`].
-    pub fn model_names_for_provider(&self, provider: LanguageModelProvider) -> Vec<String> {
-        self.models
-            .keys()
-            .filter_map(|(model_provider, model_name)| {
-                if model_provider == &provider {
-                    Some(model_name)
-                } else {
-                    None
-                }
-            })
-            .cloned()
-            .collect::<Vec<_>>()
-    }
-
     pub fn model(&self, provider: LanguageModelProvider, name: &str) -> Result<&model::Model> {
         Ok(self
             .models

crates/collab/src/llm/db/queries/usages.rs

@@ -1,6 +1,5 @@
 use crate::db::UserId;
 use chrono::Duration;
-use futures::StreamExt as _;
 use rpc::LanguageModelProvider;
 use sea_orm::QuerySelect;
 use std::{iter, str::FromStr};
@@ -19,14 +18,6 @@ pub struct Usage {
     pub lifetime_spending: usize,
 }
 
-#[derive(Debug, PartialEq, Clone)]
-pub struct ApplicationWideUsage {
-    pub provider: LanguageModelProvider,
-    pub model: String,
-    pub requests_this_minute: usize,
-    pub tokens_this_minute: usize,
-}
-
 #[derive(Clone, Copy, Debug, Default)]
 pub struct ActiveUserCount {
     pub users_in_recent_minutes: usize,
@@ -72,72 +63,6 @@ impl LlmDatabase {
         Ok(())
     }
 
-    pub async fn get_application_wide_usages_by_model(
-        &self,
-        now: DateTimeUtc,
-    ) -> Result<Vec<ApplicationWideUsage>> {
-        self.transaction(|tx| async move {
-            let past_minute = now - Duration::minutes(1);
-            let requests_per_minute = self.usage_measure_ids[&UsageMeasure::RequestsPerMinute];
-            let tokens_per_minute = self.usage_measure_ids[&UsageMeasure::TokensPerMinute];
-
-            let mut results = Vec::new();
-            for ((provider, model_name), model) in self.models.iter() {
-                let mut usages = usage::Entity::find()
-                    .filter(
-                        usage::Column::Timestamp
-                            .gte(past_minute.naive_utc())
-                            .and(usage::Column::IsStaff.eq(false))
-                            .and(usage::Column::ModelId.eq(model.id))
-                            .and(
-                                usage::Column::MeasureId
-                                    .eq(requests_per_minute)
-                                    .or(usage::Column::MeasureId.eq(tokens_per_minute)),
-                            ),
-                    )
-                    .stream(&*tx)
-                    .await?;
-
-                let mut requests_this_minute = 0;
-                let mut tokens_this_minute = 0;
-                while let Some(usage) = usages.next().await {
-                    let usage = usage?;
-                    if usage.measure_id == requests_per_minute {
-                        requests_this_minute += Self::get_live_buckets(
-                            &usage,
-                            now.naive_utc(),
-                            UsageMeasure::RequestsPerMinute,
-                        )
-                        .0
-                        .iter()
-                        .copied()
-                        .sum::<i64>() as usize;
-                    } else if usage.measure_id == tokens_per_minute {
-                        tokens_this_minute += Self::get_live_buckets(
-                            &usage,
-                            now.naive_utc(),
-                            UsageMeasure::TokensPerMinute,
-                        )
-                        .0
-                        .iter()
-                        .copied()
-                        .sum::<i64>() as usize;
-                    }
-                }
-
-                results.push(ApplicationWideUsage {
-                    provider: *provider,
-                    model: model_name.clone(),
-                    requests_this_minute,
-                    tokens_this_minute,
-                })
-            }
-
-            Ok(results)
-        })
-        .await
-    }
-
     pub async fn get_usage(
         &self,
         user_id: UserId,

crates/collab/src/llm/telemetry.rs

@@ -1,8 +1,6 @@
-use anyhow::{Context, Result};
+use anyhow::Result;
 use serde::Serialize;
 
-use crate::clickhouse::write_to_table;
-
 #[derive(Serialize, Debug, clickhouse::Row)]
 pub struct LlmUsageEventRow {
     pub time: i64,
@@ -42,10 +40,9 @@ pub struct LlmRateLimitEventRow {
 }
 
 pub async fn report_llm_usage(client: &clickhouse::Client, row: LlmUsageEventRow) -> Result<()> {
-    const LLM_USAGE_EVENTS_TABLE: &str = "llm_usage_events";
-    write_to_table(LLM_USAGE_EVENTS_TABLE, &[row], client)
-        .await
-        .with_context(|| format!("failed to upload to table '{LLM_USAGE_EVENTS_TABLE}'"))?;
+    let mut insert = client.insert("llm_usage_events")?;
+    insert.write(&row).await?;
+    insert.end().await?;
     Ok(())
 }
 
@@ -53,9 +50,8 @@ pub async fn report_llm_rate_limit(
     client: &clickhouse::Client,
     row: LlmRateLimitEventRow,
 ) -> Result<()> {
-    const LLM_RATE_LIMIT_EVENTS_TABLE: &str = "llm_rate_limit_events";
-    write_to_table(LLM_RATE_LIMIT_EVENTS_TABLE, &[row], client)
-        .await
-        .with_context(|| format!("failed to upload to table '{LLM_RATE_LIMIT_EVENTS_TABLE}'"))?;
+    let mut insert = client.insert("llm_rate_limits")?;
+    insert.write(&row).await?;
+    insert.end().await?;
     Ok(())
 }

crates/collab/src/llm/token.rs

@@ -13,15 +13,7 @@ pub struct LlmTokenClaims {
     pub exp: u64,
     pub jti: String,
     pub user_id: u64,
-    // This field is temporarily optional so it can be added
-    // in a backwards-compatible way. We can make it required
-    // once all of the LLM tokens have cycled (~1 hour after
-    // this change has been deployed).
-    #[serde(default)]
-    pub github_user_login: Option<String>,
     pub is_staff: bool,
-    #[serde(default)]
-    pub has_llm_closed_beta_feature_flag: bool,
     pub plan: rpc::proto::Plan,
 }
 
@@ -30,9 +22,7 @@ const LLM_TOKEN_LIFETIME: Duration = Duration::from_secs(60 * 60);
 impl LlmTokenClaims {
     pub fn create(
         user_id: UserId,
-        github_user_login: String,
         is_staff: bool,
-        has_llm_closed_beta_feature_flag: bool,
         plan: rpc::proto::Plan,
         config: &Config,
     ) -> Result<String> {
@@ -47,9 +37,7 @@ impl LlmTokenClaims {
             exp: (now + LLM_TOKEN_LIFETIME).timestamp() as u64,
             jti: uuid::Uuid::new_v4().to_string(),
             user_id: user_id.to_proto(),
-            github_user_login: Some(github_user_login),
             is_staff,
-            has_llm_closed_beta_feature_flag,
             plan,
         };
 

crates/collab/src/main.rs

@@ -5,7 +5,7 @@ use axum::{
     routing::get,
     Extension, Router,
 };
-use collab::llm::{db::LlmDatabase, log_usage_periodically};
+use collab::llm::db::LlmDatabase;
 use collab::migrations::run_database_migrations;
 use collab::{api::billing::poll_stripe_events_periodically, llm::LlmState, ServiceMode};
 use collab::{
@@ -95,8 +95,6 @@ async fn main() -> Result<()> {
 
                 let state = LlmState::new(config.clone(), Executor::Production).await?;
 
-                log_usage_periodically(state.clone());
-
                 app = app
                     .merge(collab::llm::routes())
                     .layer(Extension(state.clone()));
@@ -152,10 +150,7 @@ async fn main() -> Result<()> {
                             "http_request",
                             method = ?request.method(),
                             matched_path,
-                            user_id = tracing::field::Empty,
-                            login = tracing::field::Empty,
-                            authn.jti = tracing::field::Empty,
-                            is_staff = tracing::field::Empty
+                            authn.jti = tracing::field::Empty
                         )
                     })
                     .on_response(

crates/collab/src/rpc.rs

@@ -71,7 +71,7 @@ use std::{
     time::{Duration, Instant},
 };
 use time::OffsetDateTime;
-use tokio::sync::{watch, MutexGuard, Semaphore};
+use tokio::sync::{watch, Semaphore};
 use tower::ServiceBuilder;
 use tracing::{
     field::{self},
@@ -192,7 +192,7 @@ impl Session {
         }
     }
 
-    pub async fn current_plan(&self, db: MutexGuard<'_, DbHandle>) -> anyhow::Result<proto::Plan> {
+    pub async fn current_plan(&self) -> anyhow::Result<proto::Plan> {
         if self.is_staff() {
             return Ok(proto::Plan::ZedPro);
         }
@@ -201,6 +201,7 @@ impl Session {
             return Ok(proto::Plan::Free);
         };
 
+        let db = self.db().await;
         if db.has_active_billing_subscription(user_id).await? {
             Ok(proto::Plan::ZedPro)
         } else {
@@ -3499,7 +3500,7 @@ fn should_auto_subscribe_to_channels(version: ZedVersion) -> bool {
 }
 
 async fn update_user_plan(_user_id: UserId, session: &Session) -> Result<()> {
-    let plan = session.current_plan(session.db().await).await?;
+    let plan = session.current_plan().await?;
 
     session
         .peer
@@ -4502,7 +4503,7 @@ async fn count_language_model_tokens(
     };
     authorize_access_to_legacy_llm_endpoints(&session).await?;
 
-    let rate_limit: Box<dyn RateLimit> = match session.current_plan(session.db().await).await? {
+    let rate_limit: Box<dyn RateLimit> = match session.current_plan().await? {
         proto::Plan::ZedPro => Box::new(ZedProCountLanguageModelTokensRateLimit),
         proto::Plan::Free => Box::new(FreeCountLanguageModelTokensRateLimit),
     };
@@ -4622,7 +4623,7 @@ async fn compute_embeddings(
     let api_key = api_key.context("no OpenAI API key configured on the server")?;
     authorize_access_to_legacy_llm_endpoints(&session).await?;
 
-    let rate_limit: Box<dyn RateLimit> = match session.current_plan(session.db().await).await? {
+    let rate_limit: Box<dyn RateLimit> = match session.current_plan().await? {
         proto::Plan::ZedPro => Box::new(ZedProComputeEmbeddingsRateLimit),
         proto::Plan::Free => Box::new(FreeComputeEmbeddingsRateLimit),
     };
@@ -4918,10 +4919,7 @@ async fn get_llm_api_token(
     let db = session.db().await;
 
     let flags = db.get_user_flags(session.user_id()).await?;
-    let has_language_models_feature_flag = flags.iter().any(|flag| flag == "language-models");
-    let has_llm_closed_beta_feature_flag = flags.iter().any(|flag| flag == "llm-closed-beta");
-
-    if !session.is_staff() && !has_language_models_feature_flag {
+    if !session.is_staff() && !flags.iter().any(|flag| flag == "language-models") {
         Err(anyhow!("permission denied"))?
     }
 
@@ -4942,12 +4940,11 @@ async fn get_llm_api_token(
     if Utc::now().naive_utc() - account_created_at < MIN_ACCOUNT_AGE_FOR_LLM_USE {
         Err(anyhow!("account too young"))?
     }
+
     let token = LlmTokenClaims::create(
         user.id,
-        user.github_login.clone(),
         session.is_staff(),
-        has_llm_closed_beta_feature_flag,
-        session.current_plan(db).await?,
+        session.current_plan().await?,
         &session.app_state.config,
     )?;
     response.send(proto::GetLlmTokenResponse { token })?;

crates/collab/src/seed.rs

@@ -1,6 +1,7 @@
 use crate::db::{self, ChannelRole, NewUserParams};
 
 use anyhow::Context;
+use chrono::{DateTime, Utc};
 use db::Database;
 use serde::{de::DeserializeOwned, Deserialize};
 use std::{fmt::Write, fs, path::Path};
@@ -12,6 +13,7 @@ struct GitHubUser {
     id: i32,
     login: String,
     email: Option<String>,
+    created_at: DateTime<Utc>,
 }
 
 #[derive(Deserialize)]
@@ -42,17 +44,6 @@ pub async fn seed(config: &Config, db: &Database, force: bool) -> anyhow::Result
     let mut first_user = None;
     let mut others = vec![];
 
-    let flag_names = ["remoting", "language-models"];
-    let mut flags = Vec::new();
-
-    for flag_name in flag_names {
-        let flag = db
-            .create_user_flag(flag_name, false)
-            .await
-            .unwrap_or_else(|_| panic!("failed to create flag: '{flag_name}'"));
-        flags.push(flag);
-    }
-
     for admin_login in seed_config.admins {
         let user = fetch_github::<GitHubUser>(
             &client,
@@ -75,15 +66,6 @@ pub async fn seed(config: &Config, db: &Database, force: bool) -> anyhow::Result
         } else {
             others.push(user.user_id)
         }
-
-        for flag in &flags {
-            db.add_user_flag(user.user_id, *flag)
-                .await
-                .context(format!(
-                    "Unable to enable flag '{}' for user '{}'",
-                    flag, user.user_id
-                ))?;
-        }
     }
 
     for channel in seed_config.channels {
@@ -104,7 +86,6 @@ pub async fn seed(config: &Config, db: &Database, force: bool) -> anyhow::Result
         }
     }
 
-    // TODO: Fix this later
     if let Some(number_of_users) = seed_config.number_of_users {
         // Fetch 100 other random users from GitHub and insert them into the database
         // (for testing autocompleters, etc.)
@@ -124,23 +105,15 @@ pub async fn seed(config: &Config, db: &Database, force: bool) -> anyhow::Result
             for github_user in users {
                 last_user_id = Some(github_user.id);
                 user_count += 1;
-                let user = db
-                    .get_or_create_user_by_github_account(
-                        &github_user.login,
-                        Some(github_user.id),
-                        github_user.email.as_deref(),
-                        None,
-                        None,
-                    )
-                    .await
-                    .expect("failed to insert user");
-
-                for flag in &flags {
-                    db.add_user_flag(user.id, *flag).await.context(format!(
-                        "Unable to enable flag '{}' for user '{}'",
-                        flag, user.id
-                    ))?;
-                }
+                db.get_or_create_user_by_github_account(
+                    &github_user.login,
+                    Some(github_user.id),
+                    github_user.email.as_deref(),
+                    Some(github_user.created_at),
+                    None,
+                )
+                .await
+                .expect("failed to insert user");
             }
         }
     }
@@ -159,9 +132,9 @@ async fn fetch_github<T: DeserializeOwned>(client: &reqwest::Client, url: &str)
         .header("user-agent", "zed")
         .send()
         .await
-        .unwrap_or_else(|error| panic!("failed to fetch '{url}': {error}"));
+        .unwrap_or_else(|_| panic!("failed to fetch '{}'", url));
     response
         .json()
         .await
-        .unwrap_or_else(|error| panic!("failed to deserialize github user from '{url}': {error}"))
+        .unwrap_or_else(|_| panic!("failed to deserialize github user from '{}'", url))
 }

crates/collab/src/tests/test_server.rs

@@ -667,7 +667,6 @@ impl TestServer {
                 google_ai_api_key: None,
                 anthropic_api_key: None,
                 anthropic_staff_api_key: None,
-                llm_closed_beta_model_name: None,
                 clickhouse_url: None,
                 clickhouse_user: None,
                 clickhouse_password: None,

crates/collab_ui/src/chat_panel/message_editor.rs

@@ -314,6 +314,7 @@ impl MessageEditor {
                     server_id: LanguageServerId(0), // TODO: Make this optional or something?
                     lsp_completion: Default::default(), // TODO: Make this optional or something?
                     confirm: None,
+                    show_new_completions_on_confirm: false,
                 }
             })
             .collect()

crates/context_servers/Cargo.toml

@@ -1,29 +0,0 @@
-[package]
-name = "context_servers"
-version = "0.1.0"
-edition = "2021"
-publish = false
-license = "GPL-3.0-or-later"
-
-[lints]
-workspace = true
-
-[lib]
-path = "src/context_servers.rs"
-
-[dependencies]
-anyhow.workspace = true
-collections.workspace = true
-futures.workspace = true
-gpui.workspace = true
-log.workspace = true
-parking_lot.workspace = true
-postage.workspace = true
-schemars.workspace = true
-serde.workspace = true
-serde_json.workspace = true
-settings.workspace = true
-smol.workspace = true
-url = { workspace = true, features = ["serde"] }
-util.workspace = true
-workspace.workspace = true

crates/context_servers/LICENSE-GPL

@@ -1 +0,0 @@
-../../LICENSE-GPL

crates/context_servers/src/client.rs

@@ -1,432 +0,0 @@
-use anyhow::{anyhow, Context, Result};
-use collections::HashMap;
-use futures::{channel::oneshot, io::BufWriter, select, AsyncRead, AsyncWrite, FutureExt};
-use gpui::{AsyncAppContext, BackgroundExecutor, Task};
-use parking_lot::Mutex;
-use postage::barrier;
-use serde::{de::DeserializeOwned, Deserialize, Serialize};
-use serde_json::{value::RawValue, Value};
-use smol::{
-    channel,
-    io::{AsyncBufReadExt, AsyncWriteExt, BufReader},
-    process::{self, Child},
-};
-use std::{
-    fmt,
-    path::PathBuf,
-    sync::{
-        atomic::{AtomicI32, Ordering::SeqCst},
-        Arc,
-    },
-    time::{Duration, Instant},
-};
-use util::TryFutureExt;
-
-const JSON_RPC_VERSION: &str = "2.0";
-const REQUEST_TIMEOUT: Duration = Duration::from_secs(60);
-
-type ResponseHandler = Box<dyn Send + FnOnce(Result<String, Error>)>;
-type NotificationHandler = Box<dyn Send + FnMut(RequestId, Value, AsyncAppContext)>;
-
-#[derive(Debug, Clone, Eq, PartialEq, Hash, Serialize, Deserialize)]
-#[serde(untagged)]
-pub enum RequestId {
-    Int(i32),
-    Str(String),
-}
-
-pub struct Client {
-    server_id: ContextServerId,
-    next_id: AtomicI32,
-    outbound_tx: channel::Sender<String>,
-    name: Arc<str>,
-    notification_handlers: Arc<Mutex<HashMap<&'static str, NotificationHandler>>>,
-    response_handlers: Arc<Mutex<Option<HashMap<RequestId, ResponseHandler>>>>,
-    #[allow(clippy::type_complexity)]
-    #[allow(dead_code)]
-    io_tasks: Mutex<Option<(Task<Option<()>>, Task<Option<()>>)>>,
-    #[allow(dead_code)]
-    output_done_rx: Mutex<Option<barrier::Receiver>>,
-    executor: BackgroundExecutor,
-    server: Arc<Mutex<Option<Child>>>,
-}
-
-#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
-#[repr(transparent)]
-pub struct ContextServerId(pub String);
-
-#[derive(Serialize, Deserialize)]
-struct Request<'a, T> {
-    jsonrpc: &'static str,
-    id: RequestId,
-    method: &'a str,
-    params: T,
-}
-
-#[derive(Serialize, Deserialize)]
-struct AnyResponse<'a> {
-    jsonrpc: &'a str,
-    id: RequestId,
-    #[serde(default)]
-    error: Option<Error>,
-    #[serde(borrow)]
-    result: Option<&'a RawValue>,
-}
-
-#[derive(Deserialize)]
-#[allow(dead_code)]
-struct Response<T> {
-    jsonrpc: &'static str,
-    id: RequestId,
-    #[serde(flatten)]
-    value: CspResult<T>,
-}
-
-#[derive(Deserialize)]
-#[serde(rename_all = "snake_case")]
-enum CspResult<T> {
-    #[serde(rename = "result")]
-    Ok(Option<T>),
-    #[allow(dead_code)]
-    Error(Option<Error>),
-}
-
-#[derive(Serialize, Deserialize)]
-struct Notification<'a, T> {
-    jsonrpc: &'static str,
-    id: RequestId,
-    #[serde(borrow)]
-    method: &'a str,
-    params: T,
-}
-
-#[derive(Debug, Clone, Deserialize)]
-struct AnyNotification<'a> {
-    jsonrpc: &'a str,
-    id: RequestId,
-    method: String,
-    #[serde(default)]
-    params: Option<Value>,
-}
-
-#[derive(Debug, Serialize, Deserialize)]
-struct Error {
-    message: String,
-}
-
-#[derive(Debug, Clone, Deserialize)]
-pub struct ModelContextServerBinary {
-    pub executable: PathBuf,
-    pub args: Vec<String>,
-    pub env: Option<HashMap<String, String>>,
-}
-
-impl Client {
-    /// Creates a new Client instance for a context server.
-    ///
-    /// This function initializes a new Client by spawning a child process for the context server,
-    /// setting up communication channels, and initializing handlers for input/output operations.
-    /// It takes a server ID, binary information, and an async app context as input.
-    pub fn new(
-        server_id: ContextServerId,
-        binary: ModelContextServerBinary,
-        cx: AsyncAppContext,
-    ) -> Result<Self> {
-        log::info!(
-            "starting context server (executable={:?}, args={:?})",
-            binary.executable,
-            &binary.args
-        );
-
-        let mut command = process::Command::new(&binary.executable);
-        command
-            .args(&binary.args)
-            .envs(binary.env.unwrap_or_default())
-            .stdin(std::process::Stdio::piped())
-            .stdout(std::process::Stdio::piped())
-            .stderr(std::process::Stdio::piped())
-            .kill_on_drop(true);
-
-        let mut server = command.spawn().with_context(|| {
-            format!(
-                "failed to spawn command. (path={:?}, args={:?})",
-                binary.executable, &binary.args
-            )
-        })?;
-
-        let stdin = server.stdin.take().unwrap();
-        let stdout = server.stdout.take().unwrap();
-        let stderr = server.stderr.take().unwrap();
-
-        let (outbound_tx, outbound_rx) = channel::unbounded::<String>();
-        let (output_done_tx, output_done_rx) = barrier::channel();
-
-        let notification_handlers =
-            Arc::new(Mutex::new(HashMap::<_, NotificationHandler>::default()));
-        let response_handlers =
-            Arc::new(Mutex::new(Some(HashMap::<_, ResponseHandler>::default())));
-
-        let stdout_input_task = cx.spawn({
-            let notification_handlers = notification_handlers.clone();
-            let response_handlers = response_handlers.clone();
-            move |cx| {
-                Self::handle_input(stdout, notification_handlers, response_handlers, cx).log_err()
-            }
-        });
-        let stderr_input_task = cx.spawn(|_| Self::handle_stderr(stderr).log_err());
-        let input_task = cx.spawn(|_| async move {
-            let (stdout, stderr) = futures::join!(stdout_input_task, stderr_input_task);
-            stdout.or(stderr)
-        });
-        let output_task = cx.background_executor().spawn({
-            Self::handle_output(
-                stdin,
-                outbound_rx,
-                output_done_tx,
-                response_handlers.clone(),
-            )
-            .log_err()
-        });
-
-        let mut context_server = Self {
-            server_id,
-            notification_handlers,
-            response_handlers,
-            name: "".into(),
-            next_id: Default::default(),
-            outbound_tx,
-            executor: cx.background_executor().clone(),
-            io_tasks: Mutex::new(Some((input_task, output_task))),
-            output_done_rx: Mutex::new(Some(output_done_rx)),
-            server: Arc::new(Mutex::new(Some(server))),
-        };
-
-        if let Some(name) = binary.executable.file_name() {
-            context_server.name = name.to_string_lossy().into();
-        }
-
-        Ok(context_server)
-    }
-
-    /// Handles input from the server's stdout.
-    ///
-    /// This function continuously reads lines from the provided stdout stream,
-    /// parses them as JSON-RPC responses or notifications, and dispatches them
-    /// to the appropriate handlers. It processes both responses (which are matched
-    /// to pending requests) and notifications (which trigger registered handlers).
-    async fn handle_input<Stdout>(
-        stdout: Stdout,
-        notification_handlers: Arc<Mutex<HashMap<&'static str, NotificationHandler>>>,
-        response_handlers: Arc<Mutex<Option<HashMap<RequestId, ResponseHandler>>>>,
-        cx: AsyncAppContext,
-    ) -> anyhow::Result<()>
-    where
-        Stdout: AsyncRead + Unpin + Send + 'static,
-    {
-        let mut stdout = BufReader::new(stdout);
-        let mut buffer = String::new();
-
-        loop {
-            buffer.clear();
-            if stdout.read_line(&mut buffer).await? == 0 {
-                return Ok(());
-            }
-
-            let content = buffer.trim();
-
-            if !content.is_empty() {
-                if let Ok(response) = serde_json::from_str::<AnyResponse>(&content) {
-                    if let Some(handlers) = response_handlers.lock().as_mut() {
-                        if let Some(handler) = handlers.remove(&response.id) {
-                            handler(Ok(content.to_string()));
-                        }
-                    }
-                } else if let Ok(notification) = serde_json::from_str::<AnyNotification>(&content) {
-                    let mut notification_handlers = notification_handlers.lock();
-                    if let Some(handler) =
-                        notification_handlers.get_mut(notification.method.as_str())
-                    {
-                        handler(
-                            notification.id,
-                            notification.params.unwrap_or(Value::Null),
-                            cx.clone(),
-                        );
-                    }
-                }
-            }
-
-            smol::future::yield_now().await;
-        }
-    }
-
-    /// Handles the stderr output from the context server.
-    /// Continuously reads and logs any error messages from the server.
-    async fn handle_stderr<Stderr>(stderr: Stderr) -> anyhow::Result<()>
-    where
-        Stderr: AsyncRead + Unpin + Send + 'static,
-    {
-        let mut stderr = BufReader::new(stderr);
-        let mut buffer = String::new();
-
-        loop {
-            buffer.clear();
-            if stderr.read_line(&mut buffer).await? == 0 {
-                return Ok(());
-            }
-            log::warn!("context server stderr: {}", buffer.trim());
-            smol::future::yield_now().await;
-        }
-    }
-
-    /// Handles the output to the context server's stdin.
-    /// This function continuously receives messages from the outbound channel,
-    /// writes them to the server's stdin, and manages the lifecycle of response handlers.
-    async fn handle_output<Stdin>(
-        stdin: Stdin,
-        outbound_rx: channel::Receiver<String>,
-        output_done_tx: barrier::Sender,
-        response_handlers: Arc<Mutex<Option<HashMap<RequestId, ResponseHandler>>>>,
-    ) -> anyhow::Result<()>
-    where
-        Stdin: AsyncWrite + Unpin + Send + 'static,
-    {
-        let mut stdin = BufWriter::new(stdin);
-        let _clear_response_handlers = util::defer({
-            let response_handlers = response_handlers.clone();
-            move || {
-                response_handlers.lock().take();
-            }
-        });
-        while let Ok(message) = outbound_rx.recv().await {
-            log::trace!("outgoing message: {}", message);
-
-            stdin.write_all(message.as_bytes()).await?;
-            stdin.write_all(b"\n").await?;
-            stdin.flush().await?;
-        }
-        drop(output_done_tx);
-        Ok(())
-    }
-
-    /// Sends a JSON-RPC request to the context server and waits for a response.
-    /// This function handles serialization, deserialization, timeout, and error handling.
-    pub async fn request<T: DeserializeOwned>(
-        &self,
-        method: &str,
-        params: impl Serialize,
-    ) -> Result<T> {
-        let id = self.next_id.fetch_add(1, SeqCst);
-        let request = serde_json::to_string(&Request {
-            jsonrpc: JSON_RPC_VERSION,
-            id: RequestId::Int(id),
-            method,
-            params,
-        })
-        .unwrap();
-
-        let (tx, rx) = oneshot::channel();
-        let handle_response = self
-            .response_handlers
-            .lock()
-            .as_mut()
-            .ok_or_else(|| anyhow!("server shut down"))
-            .map(|handlers| {
-                handlers.insert(
-                    RequestId::Int(id),
-                    Box::new(move |result| {
-                        let _ = tx.send(result);
-                    }),
-                );
-            });
-
-        let send = self
-            .outbound_tx
-            .try_send(request)
-            .context("failed to write to context server's stdin");
-
-        let executor = self.executor.clone();
-        let started = Instant::now();
-        handle_response?;
-        send?;
-
-        let mut timeout = executor.timer(REQUEST_TIMEOUT).fuse();
-        select! {
-            response = rx.fuse() => {
-                let elapsed = started.elapsed();
-                log::trace!("took {elapsed:?} to receive response to {method:?} id {id}");
-                match response? {
-                    Ok(response) => {
-                        let parsed: AnyResponse = serde_json::from_str(&response)?;
-                        if let Some(error) = parsed.error {
-                            Err(anyhow!(error.message))
-                        } else if let Some(result) = parsed.result {
-                            Ok(serde_json::from_str(result.get())?)
-                        } else {
-                            Err(anyhow!("Invalid response: no result or error"))
-                        }
-                    }
-                    Err(_) => anyhow::bail!("cancelled")
-                }
-            }
-            _ = timeout => {
-                log::error!("cancelled csp request task for {method:?} id {id} which took over {:?}", REQUEST_TIMEOUT);
-                anyhow::bail!("Context server request timeout");
-            }
-        }
-    }
-
-    /// Sends a notification to the context server without expecting a response.
-    /// This function serializes the notification and sends it through the outbound channel.
-    pub fn notify(&self, method: &str, params: impl Serialize) -> Result<()> {
-        let id = self.next_id.fetch_add(1, SeqCst);
-        let notification = serde_json::to_string(&Notification {
-            jsonrpc: JSON_RPC_VERSION,
-            id: RequestId::Int(id),
-            method,
-            params,
-        })
-        .unwrap();
-        self.outbound_tx.try_send(notification)?;
-        Ok(())
-    }
-
-    pub fn on_notification<F>(&self, method: &'static str, mut f: F)
-    where
-        F: 'static + Send + FnMut(Value, AsyncAppContext),
-    {
-        self.notification_handlers
-            .lock()
-            .insert(method, Box::new(move |_, params, cx| f(params, cx)));
-    }
-
-    pub fn name(&self) -> &str {
-        &self.name
-    }
-
-    pub fn server_id(&self) -> ContextServerId {
-        self.server_id.clone()
-    }
-}
-
-impl Drop for Client {
-    fn drop(&mut self) {
-        if let Some(mut server) = self.server.lock().take() {
-            let _ = server.kill();
-        }
-    }
-}
-
-impl fmt::Display for ContextServerId {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        self.0.fmt(f)
-    }
-}
-
-impl fmt::Debug for Client {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        f.debug_struct("Context Server Client")
-            .field("id", &self.server_id.0)
-            .field("name", &self.name)
-            .finish_non_exhaustive()
-    }
-}

crates/context_servers/src/context_servers.rs

@@ -1,38 +0,0 @@
-use gpui::{actions, AppContext, Context, ViewContext};
-use log;
-use manager::ContextServerManager;
-use workspace::Workspace;
-
-pub mod client;
-pub mod manager;
-pub mod protocol;
-mod registry;
-pub mod types;
-
-pub use registry::*;
-
-actions!(context_servers, [Restart]);
-
-pub fn init(cx: &mut AppContext) {
-    log::info!("initializing context server client");
-    manager::init(cx);
-    ContextServerRegistry::register(cx);
-
-    cx.observe_new_views(
-        |workspace: &mut Workspace, _cx: &mut ViewContext<Workspace>| {
-            workspace.register_action(restart_servers);
-        },
-    )
-    .detach();
-}
-
-fn restart_servers(_workspace: &mut Workspace, _action: &Restart, cx: &mut ViewContext<Workspace>) {
-    let model = ContextServerManager::global(&cx);
-    cx.update_model(&model, |manager, cx| {
-        for server in manager.servers() {
-            manager
-                .restart_server(&server.id, cx)
-                .detach_and_log_err(cx);
-        }
-    });
-}

crates/context_servers/src/manager.rs

@@ -1,278 +0,0 @@
-//! This module implements a context server management system for Zed.
-//!
-//! It provides functionality to:
-//! - Define and load context server settings
-//! - Manage individual context servers (start, stop, restart)
-//! - Maintain a global manager for all context servers
-//!
-//! Key components:
-//! - `ContextServerSettings`: Defines the structure for server configurations
-//! - `ContextServer`: Represents an individual context server
-//! - `ContextServerManager`: Manages multiple context servers
-//! - `GlobalContextServerManager`: Provides global access to the ContextServerManager
-//!
-//! The module also includes initialization logic to set up the context server system
-//! and react to changes in settings.
-
-use collections::{HashMap, HashSet};
-use gpui::{AppContext, AsyncAppContext, Context, EventEmitter, Global, Model, ModelContext, Task};
-use log;
-use parking_lot::RwLock;
-use schemars::JsonSchema;
-use serde::{Deserialize, Serialize};
-use settings::{Settings, SettingsSources, SettingsStore};
-use std::path::Path;
-use std::sync::Arc;
-
-use crate::{
-    client::{self, Client},
-    types,
-};
-
-#[derive(Deserialize, Serialize, Default, Clone, PartialEq, Eq, JsonSchema, Debug)]
-pub struct ContextServerSettings {
-    pub servers: Vec<ServerConfig>,
-}
-
-#[derive(Deserialize, Serialize, Clone, PartialEq, Eq, JsonSchema, Debug)]
-pub struct ServerConfig {
-    pub id: String,
-    pub executable: String,
-    pub args: Vec<String>,
-}
-
-impl Settings for ContextServerSettings {
-    const KEY: Option<&'static str> = Some("experimental.context_servers");
-
-    type FileContent = Self;
-
-    fn load(
-        sources: SettingsSources<Self::FileContent>,
-        _: &mut gpui::AppContext,
-    ) -> anyhow::Result<Self> {
-        sources.json_merge()
-    }
-}
-
-pub struct ContextServer {
-    pub id: String,
-    pub config: ServerConfig,
-    pub client: RwLock<Option<Arc<crate::protocol::InitializedContextServerProtocol>>>,
-}
-
-impl ContextServer {
-    fn new(config: ServerConfig) -> Self {
-        Self {
-            id: config.id.clone(),
-            config,
-            client: RwLock::new(None),
-        }
-    }
-
-    async fn start(&self, cx: &AsyncAppContext) -> anyhow::Result<()> {
-        log::info!("starting context server {}", self.config.id);
-        let client = Client::new(
-            client::ContextServerId(self.config.id.clone()),
-            client::ModelContextServerBinary {
-                executable: Path::new(&self.config.executable).to_path_buf(),
-                args: self.config.args.clone(),
-                env: None,
-            },
-            cx.clone(),
-        )?;
-
-        let protocol = crate::protocol::ModelContextProtocol::new(client);
-        let client_info = types::EntityInfo {
-            name: "Zed".to_string(),
-            version: env!("CARGO_PKG_VERSION").to_string(),
-        };
-        let initialized_protocol = protocol.initialize(client_info).await?;
-
-        log::debug!(
-            "context server {} initialized: {:?}",
-            self.config.id,
-            initialized_protocol.initialize,
-        );
-
-        *self.client.write() = Some(Arc::new(initialized_protocol));
-        Ok(())
-    }
-
-    async fn stop(&self) -> anyhow::Result<()> {
-        let mut client = self.client.write();
-        if let Some(protocol) = client.take() {
-            drop(protocol);
-        }
-        Ok(())
-    }
-}
-
-/// A Context server manager manages the starting and stopping
-/// of all servers. To obtain a server to interact with, a crate
-/// must go through the `GlobalContextServerManager` which holds
-/// a model to the ContextServerManager.
-pub struct ContextServerManager {
-    servers: HashMap<String, Arc<ContextServer>>,
-    pending_servers: HashSet<String>,
-}
-
-pub enum Event {
-    ServerStarted { server_id: String },
-    ServerStopped { server_id: String },
-}
-
-impl Global for ContextServerManager {}
-impl EventEmitter<Event> for ContextServerManager {}
-
-impl ContextServerManager {
-    pub fn new() -> Self {
-        Self {
-            servers: HashMap::default(),
-            pending_servers: HashSet::default(),
-        }
-    }
-    pub fn global(cx: &AppContext) -> Model<Self> {
-        cx.global::<GlobalContextServerManager>().0.clone()
-    }
-
-    pub fn add_server(
-        &mut self,
-        config: ServerConfig,
-        cx: &mut ModelContext<Self>,
-    ) -> Task<anyhow::Result<()>> {
-        let server_id = config.id.clone();
-        let server_id2 = config.id.clone();
-
-        if self.servers.contains_key(&server_id) || self.pending_servers.contains(&server_id) {
-            return Task::ready(Ok(()));
-        }
-
-        let task = cx.spawn(|this, mut cx| async move {
-            let server = Arc::new(ContextServer::new(config));
-            server.start(&cx).await?;
-            this.update(&mut cx, |this, cx| {
-                this.servers.insert(server_id.clone(), server);
-                this.pending_servers.remove(&server_id);
-                cx.emit(Event::ServerStarted {
-                    server_id: server_id.clone(),
-                });
-            })?;
-            Ok(())
-        });
-
-        self.pending_servers.insert(server_id2);
-        task
-    }
-
-    pub fn get_server(&self, id: &str) -> Option<Arc<ContextServer>> {
-        self.servers.get(id).cloned()
-    }
-
-    pub fn remove_server(
-        &mut self,
-        id: &str,
-        cx: &mut ModelContext<Self>,
-    ) -> Task<anyhow::Result<()>> {
-        let id = id.to_string();
-        cx.spawn(|this, mut cx| async move {
-            if let Some(server) = this.update(&mut cx, |this, _cx| this.servers.remove(&id))? {
-                server.stop().await?;
-            }
-            this.update(&mut cx, |this, cx| {
-                this.pending_servers.remove(&id);
-                cx.emit(Event::ServerStopped {
-                    server_id: id.clone(),
-                })
-            })?;
-            Ok(())
-        })
-    }
-
-    pub fn restart_server(
-        &mut self,
-        id: &str,
-        cx: &mut ModelContext<Self>,
-    ) -> Task<anyhow::Result<()>> {
-        let id = id.to_string();
-        cx.spawn(|this, mut cx| async move {
-            if let Some(server) = this.update(&mut cx, |this, _cx| this.servers.remove(&id))? {
-                server.stop().await?;
-                let config = server.config.clone();
-                let new_server = Arc::new(ContextServer::new(config));
-                new_server.start(&cx).await?;
-                this.update(&mut cx, |this, cx| {
-                    this.servers.insert(id.clone(), new_server);
-                    cx.emit(Event::ServerStopped {
-                        server_id: id.clone(),
-                    });
-                    cx.emit(Event::ServerStarted {
-                        server_id: id.clone(),
-                    });
-                })?;
-            }
-            Ok(())
-        })
-    }
-
-    pub fn servers(&self) -> Vec<Arc<ContextServer>> {
-        self.servers.values().cloned().collect()
-    }
-
-    pub fn model(cx: &mut AppContext) -> Model<Self> {
-        cx.new_model(|_cx| ContextServerManager::new())
-    }
-}
-
-pub struct GlobalContextServerManager(Model<ContextServerManager>);
-impl Global for GlobalContextServerManager {}
-
-impl GlobalContextServerManager {
-    fn register(cx: &mut AppContext) {
-        let model = ContextServerManager::model(cx);
-        cx.set_global(Self(model));
-    }
-}
-
-pub fn init(cx: &mut AppContext) {
-    ContextServerSettings::register(cx);
-    GlobalContextServerManager::register(cx);
-    cx.observe_global::<SettingsStore>(|cx| {
-        let manager = ContextServerManager::global(cx);
-        cx.update_model(&manager, |manager, cx| {
-            let settings = ContextServerSettings::get_global(cx);
-            let current_servers: HashMap<String, ServerConfig> = manager
-                .servers()
-                .into_iter()
-                .map(|server| (server.id.clone(), server.config.clone()))
-                .collect();
-
-            let new_servers = settings
-                .servers
-                .iter()
-                .map(|config| (config.id.clone(), config.clone()))
-                .collect::<HashMap<_, _>>();
-
-            let servers_to_add = new_servers
-                .values()
-                .filter(|config| !current_servers.contains_key(&config.id))
-                .cloned()
-                .collect::<Vec<_>>();
-
-            let servers_to_remove = current_servers
-                .keys()
-                .filter(|id| !new_servers.contains_key(*id))
-                .cloned()
-                .collect::<Vec<_>>();
-
-            log::trace!("servers_to_add={:?}", servers_to_add);
-            for config in servers_to_add {
-                manager.add_server(config, cx).detach_and_log_err(cx);
-            }
-
-            for id in servers_to_remove {
-                manager.remove_server(&id, cx).detach_and_log_err(cx);
-            }
-        })
-    })
-    .detach();
-}

crates/context_servers/src/protocol.rs

@@ -1,140 +0,0 @@
-//! This module implements parts of the Model Context Protocol.
-//!
-//! It handles the lifecycle messages, and provides a general interface to
-//! interacting with an MCP server. It uses the generic JSON-RPC client to
-//! read/write messages and the types from types.rs for serialization/deserialization
-//! of messages.
-
-use anyhow::Result;
-use collections::HashMap;
-
-use crate::client::Client;
-use crate::types;
-
-pub use types::PromptInfo;
-
-const PROTOCOL_VERSION: u32 = 1;
-
-pub struct ModelContextProtocol {
-    inner: Client,
-}
-
-impl ModelContextProtocol {
-    pub fn new(inner: Client) -> Self {
-        Self { inner }
-    }
-
-    pub async fn initialize(
-        self,
-        client_info: types::EntityInfo,
-    ) -> Result<InitializedContextServerProtocol> {
-        let params = types::InitializeParams {
-            protocol_version: PROTOCOL_VERSION,
-            capabilities: types::ClientCapabilities {
-                experimental: None,
-                sampling: None,
-            },
-            client_info,
-        };
-
-        let response: types::InitializeResponse = self
-            .inner
-            .request(types::RequestType::Initialize.as_str(), params)
-            .await?;
-
-        log::trace!("mcp server info {:?}", response.server_info);
-
-        self.inner.notify(
-            types::NotificationType::Initialized.as_str(),
-            serde_json::json!({}),
-        )?;
-
-        let initialized_protocol = InitializedContextServerProtocol {
-            inner: self.inner,
-            initialize: response,
-        };
-
-        Ok(initialized_protocol)
-    }
-}
-
-pub struct InitializedContextServerProtocol {
-    inner: Client,
-    pub initialize: types::InitializeResponse,
-}
-
-#[derive(Debug, PartialEq, Clone, Copy)]
-pub enum ServerCapability {
-    Experimental,
-    Logging,
-    Prompts,
-    Resources,
-    Tools,
-}
-
-impl InitializedContextServerProtocol {
-    /// Check if the server supports a specific capability
-    pub fn capable(&self, capability: ServerCapability) -> bool {
-        match capability {
-            ServerCapability::Experimental => self.initialize.capabilities.experimental.is_some(),
-            ServerCapability::Logging => self.initialize.capabilities.logging.is_some(),
-            ServerCapability::Prompts => self.initialize.capabilities.prompts.is_some(),
-            ServerCapability::Resources => self.initialize.capabilities.resources.is_some(),
-            ServerCapability::Tools => self.initialize.capabilities.tools.is_some(),
-        }
-    }
-
-    fn check_capability(&self, capability: ServerCapability) -> Result<()> {
-        if self.capable(capability) {
-            Ok(())
-        } else {
-            Err(anyhow::anyhow!(
-                "Server does not support {:?} capability",
-                capability
-            ))
-        }
-    }
-
-    /// List the MCP prompts.
-    pub async fn list_prompts(&self) -> Result<Vec<types::PromptInfo>> {
-        self.check_capability(ServerCapability::Prompts)?;
-
-        let response: types::PromptsListResponse = self
-            .inner
-            .request(types::RequestType::PromptsList.as_str(), ())
-            .await?;
-
-        Ok(response.prompts)
-    }
-
-    /// Executes a prompt with the given arguments and returns the result.
-    pub async fn run_prompt<P: AsRef<str>>(
-        &self,
-        prompt: P,
-        arguments: HashMap<String, String>,
-    ) -> Result<String> {
-        self.check_capability(ServerCapability::Prompts)?;
-
-        let params = types::PromptsGetParams {
-            name: prompt.as_ref().to_string(),
-            arguments: Some(arguments),
-        };
-
-        let response: types::PromptsGetResponse = self
-            .inner
-            .request(types::RequestType::PromptsGet.as_str(), params)
-            .await?;
-
-        Ok(response.prompt)
-    }
-}
-
-impl InitializedContextServerProtocol {
-    pub async fn request<R: serde::de::DeserializeOwned>(
-        &self,
-        method: &str,
-        params: impl serde::Serialize,
-    ) -> Result<R> {
-        self.inner.request(method, params).await
-    }
-}

crates/context_servers/src/registry.rs

@@ -1,47 +0,0 @@
-use std::sync::Arc;
-
-use collections::HashMap;
-use gpui::{AppContext, Global, ReadGlobal};
-use parking_lot::RwLock;
-
-struct GlobalContextServerRegistry(Arc<ContextServerRegistry>);
-
-impl Global for GlobalContextServerRegistry {}
-
-pub struct ContextServerRegistry {
-    registry: RwLock<HashMap<String, Vec<Arc<str>>>>,
-}
-
-impl ContextServerRegistry {
-    pub fn global(cx: &AppContext) -> Arc<Self> {
-        GlobalContextServerRegistry::global(cx).0.clone()
-    }
-
-    pub fn register(cx: &mut AppContext) {
-        cx.set_global(GlobalContextServerRegistry(Arc::new(
-            ContextServerRegistry {
-                registry: RwLock::new(HashMap::default()),
-            },
-        )))
-    }
-
-    pub fn register_command(&self, server_id: String, command_name: &str) {
-        let mut registry = self.registry.write();
-        registry
-            .entry(server_id)
-            .or_default()
-            .push(command_name.into());
-    }
-
-    pub fn unregister_command(&self, server_id: &str, command_name: &str) {
-        let mut registry = self.registry.write();
-        if let Some(commands) = registry.get_mut(server_id) {
-            commands.retain(|name| name.as_ref() != command_name);
-        }
-    }
-
-    pub fn get_commands(&self, server_id: &str) -> Option<Vec<Arc<str>>> {
-        let registry = self.registry.read();
-        registry.get(server_id).cloned()
-    }
-}

crates/context_servers/src/types.rs

@@ -1,234 +0,0 @@
-use collections::HashMap;
-use serde::{Deserialize, Serialize};
-use url::Url;
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub enum RequestType {
-    Initialize,
-    CallTool,
-    ResourcesUnsubscribe,
-    ResourcesSubscribe,
-    ResourcesRead,
-    ResourcesList,
-    LoggingSetLevel,
-    PromptsGet,
-    PromptsList,
-}
-
-impl RequestType {
-    pub fn as_str(&self) -> &'static str {
-        match self {
-            RequestType::Initialize => "initialize",
-            RequestType::CallTool => "tools/call",
-            RequestType::ResourcesUnsubscribe => "resources/unsubscribe",
-            RequestType::ResourcesSubscribe => "resources/subscribe",
-            RequestType::ResourcesRead => "resources/read",
-            RequestType::ResourcesList => "resources/list",
-            RequestType::LoggingSetLevel => "logging/setLevel",
-            RequestType::PromptsGet => "prompts/get",
-            RequestType::PromptsList => "prompts/list",
-        }
-    }
-}
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct InitializeParams {
-    pub protocol_version: u32,
-    pub capabilities: ClientCapabilities,
-    pub client_info: EntityInfo,
-}
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct CallToolParams {
-    pub name: String,
-    pub arguments: Option<serde_json::Value>,
-}
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ResourcesUnsubscribeParams {
-    pub uri: Url,
-}
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ResourcesSubscribeParams {
-    pub uri: Url,
-}
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ResourcesReadParams {
-    pub uri: Url,
-}
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct LoggingSetLevelParams {
-    pub level: LoggingLevel,
-}
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct PromptsGetParams {
-    pub name: String,
-    pub arguments: Option<HashMap<String, String>>,
-}
-
-#[derive(Debug, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct InitializeResponse {
-    pub protocol_version: u32,
-    pub capabilities: ServerCapabilities,
-    pub server_info: EntityInfo,
-}
-
-#[derive(Debug, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ResourcesReadResponse {
-    pub contents: Vec<ResourceContent>,
-}
-
-#[derive(Debug, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ResourcesListResponse {
-    pub resource_templates: Option<Vec<ResourceTemplate>>,
-    pub resources: Vec<Resource>,
-}
-
-#[derive(Debug, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct PromptsGetResponse {
-    pub prompt: String,
-}
-
-#[derive(Debug, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct PromptsListResponse {
-    pub prompts: Vec<PromptInfo>,
-}
-
-#[derive(Debug, Deserialize, Clone)]
-#[serde(rename_all = "camelCase")]
-pub struct PromptInfo {
-    pub name: String,
-    pub arguments: Option<Vec<PromptArgument>>,
-}
-
-#[derive(Debug, Deserialize, Clone)]
-#[serde(rename_all = "camelCase")]
-pub struct PromptArgument {
-    pub name: String,
-    pub description: Option<String>,
-    pub required: Option<bool>,
-}
-
-// Shared Types
-
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ClientCapabilities {
-    pub experimental: Option<HashMap<String, serde_json::Value>>,
-    pub sampling: Option<HashMap<String, serde_json::Value>>,
-}
-
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ServerCapabilities {
-    pub experimental: Option<HashMap<String, serde_json::Value>>,
-    pub logging: Option<HashMap<String, serde_json::Value>>,
-    pub prompts: Option<HashMap<String, serde_json::Value>>,
-    pub resources: Option<ResourcesCapabilities>,
-    pub tools: Option<HashMap<String, serde_json::Value>>,
-}
-
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ResourcesCapabilities {
-    pub subscribe: Option<bool>,
-}
-
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct Tool {
-    pub name: String,
-    pub description: Option<String>,
-    pub input_schema: serde_json::Value,
-}
-
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct EntityInfo {
-    pub name: String,
-    pub version: String,
-}
-
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct Resource {
-    pub uri: Url,
-    pub mime_type: Option<String>,
-}
-
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ResourceContent {
-    pub uri: Url,
-    pub mime_type: Option<String>,
-    pub content_type: String,
-    pub text: Option<String>,
-    pub data: Option<String>,
-}
-
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ResourceTemplate {
-    pub uri_template: String,
-    pub name: Option<String>,
-    pub description: Option<String>,
-}
-
-#[derive(Debug, Serialize, Deserialize)]
-#[serde(rename_all = "lowercase")]
-pub enum LoggingLevel {
-    Debug,
-    Info,
-    Warning,
-    Error,
-}
-
-// Client Notifications
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub enum NotificationType {
-    Initialized,
-    Progress,
-}
-
-impl NotificationType {
-    pub fn as_str(&self) -> &'static str {
-        match self {
-            NotificationType::Initialized => "notifications/initialized",
-            NotificationType::Progress => "notifications/progress",
-        }
-    }
-}
-
-#[derive(Debug, Serialize)]
-#[serde(untagged)]
-pub enum ClientNotification {
-    Initialized,
-    Progress(ProgressParams),
-}
-
-#[derive(Debug, Serialize)]
-#[serde(rename_all = "camelCase")]
-pub struct ProgressParams {
-    pub progress_token: String,
-    pub progress: f64,
-    pub total: Option<f64>,
-}

crates/copilot/src/copilot_chat.rs

@@ -31,8 +31,6 @@ pub enum Role {
 #[derive(Clone, Debug, Default, Serialize, Deserialize, PartialEq, EnumIter)]
 pub enum Model {
     #[default]
-    #[serde(alias = "gpt-4o", rename = "gpt-4o-2024-05-13")]
-    Gpt4o,
     #[serde(alias = "gpt-4", rename = "gpt-4")]
     Gpt4,
     #[serde(alias = "gpt-3.5-turbo", rename = "gpt-3.5-turbo")]
@@ -42,7 +40,6 @@ pub enum Model {
 impl Model {
     pub fn from_id(id: &str) -> Result<Self> {
         match id {
-            "gpt-4o" => Ok(Self::Gpt4o),
             "gpt-4" => Ok(Self::Gpt4),
             "gpt-3.5-turbo" => Ok(Self::Gpt3_5Turbo),
             _ => Err(anyhow!("Invalid model id: {}", id)),
@@ -53,7 +50,6 @@ impl Model {
         match self {
             Self::Gpt3_5Turbo => "gpt-3.5-turbo",
             Self::Gpt4 => "gpt-4",
-            Self::Gpt4o => "gpt-4o",
         }
     }
 
@@ -61,13 +57,11 @@ impl Model {
         match self {
             Self::Gpt3_5Turbo => "GPT-3.5",
             Self::Gpt4 => "GPT-4",
-            Self::Gpt4o => "GPT-4o",
         }
     }
 
     pub fn max_token_count(&self) -> usize {
         match self {
-            Self::Gpt4o => 128000,
             Self::Gpt4 => 8192,
             Self::Gpt3_5Turbo => 16385,
         }

crates/editor/src/editor.rs

@@ -266,22 +266,6 @@ pub enum Direction {
     Next,
 }
 
-#[derive(Debug, Copy, Clone, PartialEq, Eq)]
-pub enum Navigated {
-    Yes,
-    No,
-}
-
-impl Navigated {
-    pub fn from_bool(yes: bool) -> Navigated {
-        if yes {
-            Navigated::Yes
-        } else {
-            Navigated::No
-        }
-    }
-}
-
 pub fn init_settings(cx: &mut AppContext) {
     EditorSettings::register(cx);
 }
@@ -916,7 +900,6 @@ enum ContextMenuOrigin {
 #[derive(Clone)]
 struct CompletionsMenu {
     id: CompletionId,
-    sort_completions: bool,
     initial_position: Anchor,
     buffer: Model<Buffer>,
     completions: Arc<RwLock<Box<[Completion]>>>,
@@ -1242,57 +1225,55 @@ impl CompletionsMenu {
         }
 
         let completions = self.completions.read();
-        if self.sort_completions {
-            matches.sort_unstable_by_key(|mat| {
-                // We do want to strike a balance here between what the language server tells us
-                // to sort by (the sort_text) and what are "obvious" good matches (i.e. when you type
-                // `Creat` and there is a local variable called `CreateComponent`).
-                // So what we do is: we bucket all matches into two buckets
-                // - Strong matches
-                // - Weak matches
-                // Strong matches are the ones with a high fuzzy-matcher score (the "obvious" matches)
-                // and the Weak matches are the rest.
-                //
-                // For the strong matches, we sort by the language-servers score first and for the weak
-                // matches, we prefer our fuzzy finder first.
-                //
-                // The thinking behind that: it's useless to take the sort_text the language-server gives
-                // us into account when it's obviously a bad match.
+        matches.sort_unstable_by_key(|mat| {
+            // We do want to strike a balance here between what the language server tells us
+            // to sort by (the sort_text) and what are "obvious" good matches (i.e. when you type
+            // `Creat` and there is a local variable called `CreateComponent`).
+            // So what we do is: we bucket all matches into two buckets
+            // - Strong matches
+            // - Weak matches
+            // Strong matches are the ones with a high fuzzy-matcher score (the "obvious" matches)
+            // and the Weak matches are the rest.
+            //
+            // For the strong matches, we sort by the language-servers score first and for the weak
+            // matches, we prefer our fuzzy finder first.
+            //
+            // The thinking behind that: it's useless to take the sort_text the language-server gives
+            // us into account when it's obviously a bad match.
 
-                #[derive(PartialEq, Eq, PartialOrd, Ord)]
-                enum MatchScore<'a> {
-                    Strong {
-                        sort_text: Option<&'a str>,
-                        score: Reverse<OrderedFloat<f64>>,
-                        sort_key: (usize, &'a str),
-                    },
-                    Weak {
-                        score: Reverse<OrderedFloat<f64>>,
-                        sort_text: Option<&'a str>,
-                        sort_key: (usize, &'a str),
-                    },
+            #[derive(PartialEq, Eq, PartialOrd, Ord)]
+            enum MatchScore<'a> {
+                Strong {
+                    sort_text: Option<&'a str>,
+                    score: Reverse<OrderedFloat<f64>>,
+                    sort_key: (usize, &'a str),
+                },
+                Weak {
+                    score: Reverse<OrderedFloat<f64>>,
+                    sort_text: Option<&'a str>,
+                    sort_key: (usize, &'a str),
+                },
+            }
+
+            let completion = &completions[mat.candidate_id];
+            let sort_key = completion.sort_key();
+            let sort_text = completion.lsp_completion.sort_text.as_deref();
+            let score = Reverse(OrderedFloat(mat.score));
+
+            if mat.score >= 0.2 {
+                MatchScore::Strong {
+                    sort_text,
+                    score,
+                    sort_key,
                 }
-
-                let completion = &completions[mat.candidate_id];
-                let sort_key = completion.sort_key();
-                let sort_text = completion.lsp_completion.sort_text.as_deref();
-                let score = Reverse(OrderedFloat(mat.score));
-
-                if mat.score >= 0.2 {
-                    MatchScore::Strong {
-                        sort_text,
-                        score,
-                        sort_key,
-                    }
-                } else {
-                    MatchScore::Weak {
-                        score,
-                        sort_text,
-                        sort_key,
-                    }
+            } else {
+                MatchScore::Weak {
+                    score,
+                    sort_text,
+                    sort_key,
                 }
-            });
-        }
+            }
+        });
 
         for mat in &mut matches {
             let completion = &completions[mat.candidate_id];
@@ -1577,7 +1558,6 @@ pub(crate) struct NavigationData {
     scroll_top_row: u32,
 }
 
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
 enum GotoDefinitionKind {
     Symbol,
     Declaration,
@@ -4125,7 +4105,6 @@ impl Editor {
             trigger_kind,
         };
         let completions = provider.completions(&buffer, buffer_position, completion_context, cx);
-        let sort_completions = provider.sort_completions();
 
         let id = post_inc(&mut self.next_completion_id);
         let task = cx.spawn(|this, mut cx| {
@@ -4137,7 +4116,6 @@ impl Editor {
                 let menu = if let Some(completions) = completions {
                     let mut menu = CompletionsMenu {
                         id,
-                        sort_completions,
                         initial_position: position,
                         match_candidates: completions
                             .iter()
@@ -4396,11 +4374,11 @@ impl Editor {
             this.refresh_inline_completion(true, cx);
         });
 
-        let show_new_completions_on_confirm = completion
-            .confirm
-            .as_ref()
-            .map_or(false, |confirm| confirm(intent, cx));
-        if show_new_completions_on_confirm {
+        if let Some(confirm) = completion.confirm.as_ref() {
+            (confirm)(intent, cx);
+        }
+
+        if completion.show_new_completions_on_confirm {
             self.show_completions(&ShowCompletions { trigger: None }, cx);
         }
 
@@ -4860,7 +4838,7 @@ impl Editor {
 
                             let range = Anchor {
                                 buffer_id,
-                                excerpt_id,
+                                excerpt_id: excerpt_id,
                                 text_anchor: start,
                             }..Anchor {
                                 buffer_id,
@@ -9037,28 +9015,15 @@ impl Editor {
         &mut self,
         _: &GoToDefinition,
         cx: &mut ViewContext<Self>,
-    ) -> Task<Result<Navigated>> {
-        let definition = self.go_to_definition_of_kind(GotoDefinitionKind::Symbol, false, cx);
-        let references = self.find_all_references(&FindAllReferences, cx);
-        cx.background_executor().spawn(async move {
-            if definition.await? == Navigated::Yes {
-                return Ok(Navigated::Yes);
-            }
-            if let Some(references) = references {
-                if references.await? == Navigated::Yes {
-                    return Ok(Navigated::Yes);
-                }
-            }
-
-            Ok(Navigated::No)
-        })
+    ) -> Task<Result<bool>> {
+        self.go_to_definition_of_kind(GotoDefinitionKind::Symbol, false, cx)
     }
 
     pub fn go_to_declaration(
         &mut self,
         _: &GoToDeclaration,
         cx: &mut ViewContext<Self>,
-    ) -> Task<Result<Navigated>> {
+    ) -> Task<Result<bool>> {
         self.go_to_definition_of_kind(GotoDefinitionKind::Declaration, false, cx)
     }
 
@@ -9066,7 +9031,7 @@ impl Editor {
         &mut self,
         _: &GoToDeclaration,
         cx: &mut ViewContext<Self>,
-    ) -> Task<Result<Navigated>> {
+    ) -> Task<Result<bool>> {
         self.go_to_definition_of_kind(GotoDefinitionKind::Declaration, true, cx)
     }
 
@@ -9074,7 +9039,7 @@ impl Editor {
         &mut self,
         _: &GoToImplementation,
         cx: &mut ViewContext<Self>,
-    ) -> Task<Result<Navigated>> {
+    ) -> Task<Result<bool>> {
         self.go_to_definition_of_kind(GotoDefinitionKind::Implementation, false, cx)
     }
 
@@ -9082,7 +9047,7 @@ impl Editor {
         &mut self,
         _: &GoToImplementationSplit,
         cx: &mut ViewContext<Self>,
-    ) -> Task<Result<Navigated>> {
+    ) -> Task<Result<bool>> {
         self.go_to_definition_of_kind(GotoDefinitionKind::Implementation, true, cx)
     }
 
@@ -9090,7 +9055,7 @@ impl Editor {
         &mut self,
         _: &GoToTypeDefinition,
         cx: &mut ViewContext<Self>,
-    ) -> Task<Result<Navigated>> {
+    ) -> Task<Result<bool>> {
         self.go_to_definition_of_kind(GotoDefinitionKind::Type, false, cx)
     }
 
@@ -9098,7 +9063,7 @@ impl Editor {
         &mut self,
         _: &GoToDefinitionSplit,
         cx: &mut ViewContext<Self>,
-    ) -> Task<Result<Navigated>> {
+    ) -> Task<Result<bool>> {
         self.go_to_definition_of_kind(GotoDefinitionKind::Symbol, true, cx)
     }
 
@@ -9106,7 +9071,7 @@ impl Editor {
         &mut self,
         _: &GoToTypeDefinitionSplit,
         cx: &mut ViewContext<Self>,
-    ) -> Task<Result<Navigated>> {
+    ) -> Task<Result<bool>> {
         self.go_to_definition_of_kind(GotoDefinitionKind::Type, true, cx)
     }
 
@@ -9115,16 +9080,16 @@ impl Editor {
         kind: GotoDefinitionKind,
         split: bool,
         cx: &mut ViewContext<Self>,
-    ) -> Task<Result<Navigated>> {
+    ) -> Task<Result<bool>> {
         let Some(workspace) = self.workspace() else {
-            return Task::ready(Ok(Navigated::No));
+            return Task::ready(Ok(false));
         };
         let buffer = self.buffer.read(cx);
         let head = self.selections.newest::<usize>(cx).head();
         let (buffer, head) = if let Some(text_anchor) = buffer.text_anchor_for_position(head, cx) {
             text_anchor
         } else {
-            return Task::ready(Ok(Navigated::No));
+            return Task::ready(Ok(false));
         };
 
         let project = workspace.read(cx).project().clone();
@@ -9183,7 +9148,7 @@ impl Editor {
         mut definitions: Vec<HoverLink>,
         split: bool,
         cx: &mut ViewContext<Editor>,
-    ) -> Task<Result<Navigated>> {
+    ) -> Task<Result<bool>> {
         // If there is one definition, just open it directly
         if definitions.len() == 1 {
             let definition = definitions.pop().unwrap();
@@ -9199,61 +9164,77 @@ impl Editor {
             };
             cx.spawn(|editor, mut cx| async move {
                 let target = target_task.await.context("target resolution task")?;
-                let Some(target) = target else {
-                    return Ok(Navigated::No);
-                };
-                editor.update(&mut cx, |editor, cx| {
-                    let Some(workspace) = editor.workspace() else {
-                        return Navigated::No;
-                    };
-                    let pane = workspace.read(cx).active_pane().clone();
+                if let Some(target) = target {
+                    editor.update(&mut cx, |editor, cx| {
+                        let Some(workspace) = editor.workspace() else {
+                            return false;
+                        };
+                        let pane = workspace.read(cx).active_pane().clone();
 
-                    let range = target.range.to_offset(target.buffer.read(cx));
-                    let range = editor.range_for_match(&range);
+                        let range = target.range.to_offset(target.buffer.read(cx));
+                        let range = editor.range_for_match(&range);
 
-                    if Some(&target.buffer) == editor.buffer.read(cx).as_singleton().as_ref() {
-                        let buffer = target.buffer.read(cx);
-                        let range = check_multiline_range(buffer, range);
-                        editor.change_selections(Some(Autoscroll::focused()), cx, |s| {
-                            s.select_ranges([range]);
-                        });
-                    } else {
-                        cx.window_context().defer(move |cx| {
-                            let target_editor: View<Self> =
-                                workspace.update(cx, |workspace, cx| {
-                                    let pane = if split {
-                                        workspace.adjacent_pane(cx)
-                                    } else {
-                                        workspace.active_pane().clone()
-                                    };
+                        /// If select range has more than one line, we
+                        /// just point the cursor to range.start.
+                        fn check_multiline_range(
+                            buffer: &Buffer,
+                            range: Range<usize>,
+                        ) -> Range<usize> {
+                            if buffer.offset_to_point(range.start).row
+                                == buffer.offset_to_point(range.end).row
+                            {
+                                range
+                            } else {
+                                range.start..range.start
+                            }
+                        }
 
-                                    workspace.open_project_item(
-                                        pane,
-                                        target.buffer.clone(),
-                                        true,
-                                        true,
-                                        cx,
-                                    )
-                                });
-                            target_editor.update(cx, |target_editor, cx| {
-                                // When selecting a definition in a different buffer, disable the nav history
-                                // to avoid creating a history entry at the previous cursor location.
-                                pane.update(cx, |pane, _| pane.disable_history());
-                                let buffer = target.buffer.read(cx);
-                                let range = check_multiline_range(buffer, range);
-                                target_editor.change_selections(
-                                    Some(Autoscroll::focused()),
-                                    cx,
-                                    |s| {
-                                        s.select_ranges([range]);
-                                    },
-                                );
-                                pane.update(cx, |pane, _| pane.enable_history());
+                        if Some(&target.buffer) == editor.buffer.read(cx).as_singleton().as_ref() {
+                            let buffer = target.buffer.read(cx);
+                            let range = check_multiline_range(buffer, range);
+                            editor.change_selections(Some(Autoscroll::focused()), cx, |s| {
+                                s.select_ranges([range]);
                             });
-                        });
-                    }
-                    Navigated::Yes
-                })
+                        } else {
+                            cx.window_context().defer(move |cx| {
+                                let target_editor: View<Self> =
+                                    workspace.update(cx, |workspace, cx| {
+                                        let pane = if split {
+                                            workspace.adjacent_pane(cx)
+                                        } else {
+                                            workspace.active_pane().clone()
+                                        };
+
+                                        workspace.open_project_item(
+                                            pane,
+                                            target.buffer.clone(),
+                                            true,
+                                            true,
+                                            cx,
+                                        )
+                                    });
+                                target_editor.update(cx, |target_editor, cx| {
+                                    // When selecting a definition in a different buffer, disable the nav history
+                                    // to avoid creating a history entry at the previous cursor location.
+                                    pane.update(cx, |pane, _| pane.disable_history());
+                                    let buffer = target.buffer.read(cx);
+                                    let range = check_multiline_range(buffer, range);
+                                    target_editor.change_selections(
+                                        Some(Autoscroll::focused()),
+                                        cx,
+                                        |s| {
+                                            s.select_ranges([range]);
+                                        },
+                                    );
+                                    pane.update(cx, |pane, _| pane.enable_history());
+                                });
+                            });
+                        }
+                        true
+                    })
+                } else {
+                    Ok(false)
+                }
             })
         } else if !definitions.is_empty() {
             let replica_id = self.replica_id(cx);
@@ -9303,7 +9284,7 @@ impl Editor {
                     .context("location tasks")?;
 
                 let Some(workspace) = workspace else {
-                    return Ok(Navigated::No);
+                    return Ok(false);
                 };
                 let opened = workspace
                     .update(&mut cx, |workspace, cx| {
@@ -9313,10 +9294,10 @@ impl Editor {
                     })
                     .ok();
 
-                anyhow::Ok(Navigated::from_bool(opened.is_some()))
+                anyhow::Ok(opened.is_some())
             })
         } else {
-            Task::ready(Ok(Navigated::No))
+            Task::ready(Ok(false))
         }
     }
 
@@ -9375,7 +9356,7 @@ impl Editor {
         &mut self,
         _: &FindAllReferences,
         cx: &mut ViewContext<Self>,
-    ) -> Option<Task<Result<Navigated>>> {
+    ) -> Option<Task<Result<()>>> {
         let multi_buffer = self.buffer.read(cx);
         let selection = self.selections.newest::<usize>(cx);
         let head = selection.head();
@@ -9430,7 +9411,7 @@ impl Editor {
 
             let locations = references.await?;
             if locations.is_empty() {
-                return anyhow::Ok(Navigated::No);
+                return anyhow::Ok(());
             }
 
             workspace.update(&mut cx, |workspace, cx| {
@@ -9450,7 +9431,6 @@ impl Editor {
                 Self::open_locations_in_multibuffer(
                     workspace, locations, replica_id, title, false, cx,
                 );
-                Navigated::Yes
             })
         }))
     }
@@ -11941,12 +11921,6 @@ impl Editor {
         let bounds = self.last_bounds?;
         Some(element::gutter_bounds(bounds, self.gutter_dimensions))
     }
-
-    pub fn has_active_completions_menu(&self) -> bool {
-        self.context_menu.read().as_ref().map_or(false, |menu| {
-            menu.visible() && matches!(menu, ContextMenu::Completions(_))
-        })
-    }
 }
 
 fn hunks_for_selections(
@@ -12071,10 +12045,6 @@ pub trait CompletionProvider {
         trigger_in_words: bool,
         cx: &mut ViewContext<Editor>,
     ) -> bool;
-
-    fn sort_completions(&self) -> bool {
-        true
-    }
 }
 
 fn snippet_completions(
@@ -12162,6 +12132,7 @@ fn snippet_completions(
                     ..Default::default()
                 },
                 confirm: None,
+                show_new_completions_on_confirm: false,
             })
         })
         .collect()
@@ -13292,13 +13263,3 @@ fn hunk_status(hunk: &DiffHunk<MultiBufferRow>) -> DiffHunkStatus {
         DiffHunkStatus::Modified
     }
 }
-
-/// If select range has more than one line, we
-/// just point the cursor to range.start.
-fn check_multiline_range(buffer: &Buffer, range: Range<usize>) -> Range<usize> {
-    if buffer.offset_to_point(range.start).row == buffer.offset_to_point(range.end).row {
-        range
-    } else {
-        range.start..range.start
-    }
-}

crates/editor/src/editor_tests.rs

@@ -13221,127 +13221,6 @@ let foo = 15;"#,
     });
 }
 
-#[gpui::test]
-async fn test_goto_definition_with_find_all_references_fallback(cx: &mut gpui::TestAppContext) {
-    init_test(cx, |_| {});
-    let mut cx = EditorLspTestContext::new_rust(
-        lsp::ServerCapabilities {
-            definition_provider: Some(lsp::OneOf::Left(true)),
-            references_provider: Some(lsp::OneOf::Left(true)),
-            ..lsp::ServerCapabilities::default()
-        },
-        cx,
-    )
-    .await;
-
-    let set_up_lsp_handlers = |empty_go_to_definition: bool, cx: &mut EditorLspTestContext| {
-        let go_to_definition = cx.lsp.handle_request::<lsp::request::GotoDefinition, _, _>(
-            move |params, _| async move {
-                if empty_go_to_definition {
-                    Ok(None)
-                } else {
-                    Ok(Some(lsp::GotoDefinitionResponse::Scalar(lsp::Location {
-                        uri: params.text_document_position_params.text_document.uri,
-                        range: lsp::Range::new(lsp::Position::new(4, 3), lsp::Position::new(4, 6)),
-                    })))
-                }
-            },
-        );
-        let references =
-            cx.lsp
-                .handle_request::<lsp::request::References, _, _>(move |params, _| async move {
-                    Ok(Some(vec![lsp::Location {
-                        uri: params.text_document_position.text_document.uri,
-                        range: lsp::Range::new(lsp::Position::new(0, 8), lsp::Position::new(0, 11)),
-                    }]))
-                });
-        (go_to_definition, references)
-    };
-
-    cx.set_state(
-        &r#"fn one() {
-            let mut a = ˇtwo();
-        }
-
-        fn two() {}"#
-            .unindent(),
-    );
-    set_up_lsp_handlers(false, &mut cx);
-    let navigated = cx
-        .update_editor(|editor, cx| editor.go_to_definition(&GoToDefinition, cx))
-        .await
-        .expect("Failed to navigate to definition");
-    assert_eq!(
-        navigated,
-        Navigated::Yes,
-        "Should have navigated to definition from the GetDefinition response"
-    );
-    cx.assert_editor_state(
-        &r#"fn one() {
-            let mut a = two();
-        }
-
-        fn «twoˇ»() {}"#
-            .unindent(),
-    );
-
-    let editors = cx.update_workspace(|workspace, cx| {
-        workspace.items_of_type::<Editor>(cx).collect::<Vec<_>>()
-    });
-    cx.update_editor(|_, test_editor_cx| {
-        assert_eq!(
-            editors.len(),
-            1,
-            "Initially, only one, test, editor should be open in the workspace"
-        );
-        assert_eq!(
-            test_editor_cx.view(),
-            editors.last().expect("Asserted len is 1")
-        );
-    });
-
-    set_up_lsp_handlers(true, &mut cx);
-    let navigated = cx
-        .update_editor(|editor, cx| editor.go_to_definition(&GoToDefinition, cx))
-        .await
-        .expect("Failed to navigate to lookup references");
-    assert_eq!(
-        navigated,
-        Navigated::Yes,
-        "Should have navigated to references as a fallback after empty GoToDefinition response"
-    );
-    // We should not change the selections in the existing file,
-    // if opening another milti buffer with the references
-    cx.assert_editor_state(
-        &r#"fn one() {
-            let mut a = two();
-        }
-
-        fn «twoˇ»() {}"#
-            .unindent(),
-    );
-    let editors = cx.update_workspace(|workspace, cx| {
-        workspace.items_of_type::<Editor>(cx).collect::<Vec<_>>()
-    });
-    cx.update_editor(|_, test_editor_cx| {
-        assert_eq!(
-            editors.len(),
-            2,
-            "After falling back to references search, we open a new editor with the results"
-        );
-        let references_fallback_text = editors
-            .into_iter()
-            .find(|new_editor| new_editor != test_editor_cx.view())
-            .expect("Should have one non-test editor now")
-            .read(test_editor_cx)
-            .text(test_editor_cx);
-        assert_eq!(
-            references_fallback_text, "fn one() {\n    let mut a = two();\n}",
-            "Should use the range from the references response and not the GoToDefinition one"
-        );
-    });
-}
-
 fn empty_range(row: usize, column: usize) -> Range<DisplayPoint> {
     let point = DisplayPoint::new(DisplayRow(row as u32), column as u32);
     point..point

crates/editor/src/hover_links.rs

@@ -2,7 +2,7 @@ use crate::{
     hover_popover::{self, InlayHover},
     scroll::ScrollAmount,
     Anchor, Editor, EditorSnapshot, FindAllReferences, GoToDefinition, GoToTypeDefinition, InlayId,
-    Navigated, PointForPosition, SelectPhase,
+    PointForPosition, SelectPhase,
 };
 use gpui::{px, AppContext, AsyncWindowContext, Model, Modifiers, Task, ViewContext};
 use language::{Bias, ToOffset};
@@ -157,10 +157,10 @@ impl Editor {
     ) {
         let reveal_task = self.cmd_click_reveal_task(point, modifiers, cx);
         cx.spawn(|editor, mut cx| async move {
-            let definition_revealed = reveal_task.await.log_err().unwrap_or(Navigated::No);
+            let definition_revealed = reveal_task.await.log_err().unwrap_or(false);
             let find_references = editor
                 .update(&mut cx, |editor, cx| {
-                    if definition_revealed == Navigated::Yes {
+                    if definition_revealed {
                         return None;
                     }
                     editor.find_all_references(&FindAllReferences, cx)
@@ -194,7 +194,7 @@ impl Editor {
         point: PointForPosition,
         modifiers: Modifiers,
         cx: &mut ViewContext<Editor>,
-    ) -> Task<anyhow::Result<Navigated>> {
+    ) -> Task<anyhow::Result<bool>> {
         if let Some(hovered_link_state) = self.hovered_link_state.take() {
             self.hide_hovered_link(cx);
             if !hovered_link_state.links.is_empty() {
@@ -211,7 +211,7 @@ impl Editor {
                     .read(cx)
                     .text_anchor_for_position(current_position, cx)
                 else {
-                    return Task::ready(Ok(Navigated::No));
+                    return Task::ready(Ok(false));
                 };
                 let links = hovered_link_state
                     .links
@@ -247,7 +247,7 @@ impl Editor {
                 self.go_to_definition(&GoToDefinition, cx)
             }
         } else {
-            Task::ready(Ok(Navigated::No))
+            Task::ready(Ok(false))
         }
     }
 }

crates/editor/src/hover_popover.rs

@@ -733,8 +733,6 @@ impl DiagnosticPopover {
             .id("diagnostic")
             .block()
             .max_h(max_size.height)
-            .overflow_y_scroll()
-            .max_w(max_size.width)
             .elevation_2_borderless(cx)
             // Don't draw the background color if the theme
             // allows transparent surfaces.

crates/editor/src/hunk_diff.rs

@@ -777,18 +777,19 @@ fn editor_with_deleted_text(
         });
 
         let mut editor = Editor::for_multibuffer(multi_buffer, None, true, cx);
-        editor.set_soft_wrap_mode(language::language_settings::SoftWrap::None, cx);
-        editor.set_show_wrap_guides(false, cx);
-        editor.set_show_gutter(false, cx);
+        editor.soft_wrap_mode_override = Some(language::language_settings::SoftWrap::None);
+        editor.show_wrap_guides = Some(false);
+        editor.show_gutter = false;
         editor.scroll_manager.set_forbid_vertical_scroll(true);
         editor.set_read_only(true);
-        editor.set_show_inline_completions(false);
-        editor.highlight_rows::<DiffRowHighlight>(
-            Anchor::min()..=Anchor::max(),
-            Some(deleted_color),
-            false,
-            cx,
-        );
+
+        let editor_snapshot = editor.snapshot(cx);
+        let start = editor_snapshot.buffer_snapshot.anchor_before(0);
+        let end = editor_snapshot
+            .buffer_snapshot
+            .anchor_after(editor.buffer.read(cx).len(cx));
+
+        editor.highlight_rows::<DiffRowHighlight>(start..=end, Some(deleted_color), false, cx);
 
         let subscription_editor = parent_editor.clone();
         editor._subscriptions.extend([

crates/editor/src/items.rs

@@ -680,12 +680,6 @@ impl Item for Editor {
         self.nav_history = Some(history);
     }
 
-    fn discarded(&self, _project: Model<Project>, cx: &mut ViewContext<Self>) {
-        for buffer in self.buffer().clone().read(cx).all_buffers() {
-            buffer.update(cx, |buffer, cx| buffer.discarded(cx))
-        }
-    }
-
     fn deactivated(&mut self, cx: &mut ViewContext<Self>) {
         let selection = self.selections.newest_anchor();
         self.push_to_nav_history(selection.head(), None, cx);

crates/extension/src/extension_manifest.rs

@@ -137,6 +137,7 @@ impl LanguageServerManifestEntry {
 #[derive(Clone, PartialEq, Eq, Debug, Deserialize, Serialize)]
 pub struct SlashCommandManifestEntry {
     pub description: String,
+    pub tooltip_text: String,
     pub requires_argument: bool,
 }
 

crates/extension/src/extension_slash_command.rs

@@ -39,12 +39,11 @@ impl SlashCommand for ExtensionSlashCommand {
 
     fn complete_argument(
         self: Arc<Self>,
-        arguments: &[String],
+        query: String,
         _cancel: Arc<AtomicBool>,
         _workspace: Option<WeakView<Workspace>>,
         cx: &mut WindowContext,
     ) -> Task<Result<Vec<ArgumentCompletion>>> {
-        let arguments = arguments.to_owned();
         cx.background_executor().spawn(async move {
             self.extension
                 .call({
@@ -55,7 +54,7 @@ impl SlashCommand for ExtensionSlashCommand {
                                 .call_complete_slash_command_argument(
                                     store,
                                     &this.command,
-                                    &arguments,
+                                    query.as_ref(),
                                 )
                                 .await?
                                 .map_err(|e| anyhow!("{}", e))?;
@@ -66,8 +65,7 @@ impl SlashCommand for ExtensionSlashCommand {
                                     .map(|completion| ArgumentCompletion {
                                         label: completion.label.into(),
                                         new_text: completion.new_text,
-                                        replace_previous_arguments: false,
-                                        after_completion: completion.run_command.into(),
+                                        run_command: completion.run_command,
                                     })
                                     .collect(),
                             )
@@ -81,12 +79,12 @@ impl SlashCommand for ExtensionSlashCommand {
 
     fn run(
         self: Arc<Self>,
-        arguments: &[String],
+        argument: Option<&str>,
         _workspace: WeakView<Workspace>,
         delegate: Option<Arc<dyn LspAdapterDelegate>>,
         cx: &mut WindowContext,
     ) -> Task<Result<SlashCommandOutput>> {
-        let arguments = arguments.to_owned();
+        let argument = argument.map(|arg| arg.to_string());
         let output = cx.background_executor().spawn(async move {
             self.extension
                 .call({
@@ -99,7 +97,12 @@ impl SlashCommand for ExtensionSlashCommand {
                                 None
                             };
                             let output = extension
-                                .call_run_slash_command(store, &this.command, &arguments, resource)
+                                .call_run_slash_command(
+                                    store,
+                                    &this.command,
+                                    argument.as_deref(),
+                                    resource,
+                                )
                                 .await?
                                 .map_err(|e| anyhow!("{}", e))?;
 

crates/extension/src/extension_store.rs

@@ -1216,10 +1216,7 @@ impl ExtensionStore {
                                 command: crate::wit::SlashCommand {
                                     name: slash_command_name.to_string(),
                                     description: slash_command.description.to_string(),
-                                    // We don't currently expose this as a configurable option, as it currently drives
-                                    // the `menu_text` on the `SlashCommand` trait, which is not used for slash commands
-                                    // defined in extensions, as they are not able to be added to the menu.
-                                    tooltip_text: String::new(),
+                                    tooltip_text: slash_command.tooltip_text.to_string(),
                                     requires_argument: slash_command.requires_argument,
                                 },
                                 extension: wasm_extension.clone(),

crates/extension/src/wasm_host/wit.rs

@@ -262,11 +262,11 @@ impl Extension {
         &self,
         store: &mut Store<WasmState>,
         command: &SlashCommand,
-        arguments: &[String],
+        query: &str,
     ) -> Result<Result<Vec<SlashCommandArgumentCompletion>, String>> {
         match self {
             Extension::V010(ext) => {
-                ext.call_complete_slash_command_argument(store, command, arguments)
+                ext.call_complete_slash_command_argument(store, command, query)
                     .await
             }
             Extension::V001(_) | Extension::V004(_) | Extension::V006(_) => Ok(Ok(Vec::new())),
@@ -277,12 +277,12 @@ impl Extension {
         &self,
         store: &mut Store<WasmState>,
         command: &SlashCommand,
-        arguments: &[String],
+        argument: Option<&str>,
         resource: Option<Resource<Arc<dyn LspAdapterDelegate>>>,
     ) -> Result<Result<SlashCommandOutput, String>> {
         match self {
             Extension::V010(ext) => {
-                ext.call_run_slash_command(store, command, arguments, resource)
+                ext.call_run_slash_command(store, command, argument, resource)
                     .await
             }
             Extension::V001(_) | Extension::V004(_) | Extension::V006(_) => {

crates/extension_api/Cargo.toml

@@ -8,6 +8,9 @@ keywords = ["zed", "extension"]
 edition = "2021"
 license = "Apache-2.0"
 
+# We'll publish v0.1.0 after the release on Wednesday (2024-08-14).
+publish = false
+
 [lints]
 workspace = true
 

crates/extension_api/PENDING_CHANGES.md

@@ -1,12 +0,0 @@
-# Pending Changes
-
-This is a list of pending changes to the Zed extension API that require a breaking change.
-
-This list should be updated as we notice things that should be changed so that we can batch them up in a single release.
-
-## vNext
-
-### Slash Commands
-
-- Rename `SlashCommand.tooltip_text` to `SlashCommand.menu_text`
-  - We may even want to remove it entirely, as right now this is only used for featured slash commands, and slash commands defined by extensions aren't currently able to be featured.

crates/extension_api/src/extension_api.rs

@@ -114,7 +114,7 @@ pub trait Extension: Send + Sync {
     fn complete_slash_command_argument(
         &self,
         _command: SlashCommand,
-        _args: Vec<String>,
+        _query: String,
     ) -> Result<Vec<SlashCommandArgumentCompletion>, String> {
         Ok(Vec::new())
     }
@@ -123,7 +123,7 @@ pub trait Extension: Send + Sync {
     fn run_slash_command(
         &self,
         _command: SlashCommand,
-        _args: Vec<String>,
+        _argument: Option<String>,
         _worktree: Option<&Worktree>,
     ) -> Result<SlashCommandOutput, String> {
         Err("`run_slash_command` not implemented".to_string())
@@ -257,17 +257,17 @@ impl wit::Guest for Component {
 
     fn complete_slash_command_argument(
         command: SlashCommand,
-        args: Vec<String>,
+        query: String,
     ) -> Result<Vec<SlashCommandArgumentCompletion>, String> {
-        extension().complete_slash_command_argument(command, args)
+        extension().complete_slash_command_argument(command, query)
     }
 
     fn run_slash_command(
         command: SlashCommand,
-        args: Vec<String>,
+        argument: Option<String>,
         worktree: Option<&Worktree>,
     ) -> Result<SlashCommandOutput, String> {
-        extension().run_slash_command(command, args, worktree)
+        extension().run_slash_command(command, argument, worktree)
     }
 
     fn suggest_docs_packages(provider: String) -> Result<Vec<String>, String> {