Piotr Osiewicz
62949d20a7
chore: fmt
2023-08-31 15:43:50 +02:00
Piotr Osiewicz
110bb84261
Merge branch 'main' into gpui_extract_platform
2023-08-31 15:43:32 +02:00
Kirill Bulatov
fad595dca6
Use ctrl-: instead of ctrl-shift-: for inlay hints toggling ( #2921 )
...
The latter is not possible to press in Zed, since `:` is typed as
`shift-;` with typical US keyboard layouts.
In the end, it's the same buttons you have to press to toggle the inlay
hints, but working this time.
Release Notes:
- N/A
2023-08-31 12:10:45 +03:00
Kirill Bulatov
897adb67c5
Log language server stderr output in server logs ( #2918 )
...
<img width="1728" alt="Screenshot 2023-08-31 at 01 07 11"
src="https://github.com/zed-industries/zed/assets/2690773/537a18d6-59bf-4a77-896f-fc2cb6dc7fe8 ">
Line by line, we print stderr to help with debugging and servers that
log into stderr.
Release Notes:
- N/A
2023-08-31 11:13:45 +03:00
Kirill Bulatov
18efc0d5e5
Fix the tests, by not requiring stderr for fake servers
2023-08-31 11:07:37 +03:00
Kirill Bulatov
af665cc3d2
Use ctrl-: instead of ctrl-shift-: for inlay hints toggling
...
The latter is not posible to press in Zed, since `:` is typed as
`shift-;` with typical US keyboard layouts.
In the end, it's the same buttons you have to press to toggle the inlay
hints, but working this time.
2023-08-31 10:43:29 +03:00
Kirill Bulatov
0f619e0b67
Do not write TRACE logs into file for Lua
2023-08-31 01:14:37 +03:00
Kirill Bulatov
54e7e2f59d
Capture language servers' stderr into server logs
2023-08-31 01:14:37 +03:00
Max Brunsfeld
b94955910c
Disable save as prompt for channel notes ( #2917 )
2023-08-30 15:09:53 -07:00
Max Brunsfeld
4b5948e004
Disable save as prompt for channel notes
2023-08-30 15:05:47 -07:00
Kirill Bulatov
d9a72aa1e0
Rewrite inlay hint collab tests to remove races ( #2916 )
...
Release Notes:
- N/A
2023-08-31 00:49:50 +03:00
Max Brunsfeld
6d60960fd2
Fix collab panel regressions ( #2915 )
...
Release Notes:
- Fixed a bug where collaborators' cursors were rendered with the wrong
color when not following them (preview only).
- Fixed an issue where icons were inconsistent sizes in the
collaboration panel (preview only).
2023-08-30 14:41:37 -07:00
Kirill Bulatov
ab49f8c592
Rewrite inlay hint collab tests to remove races
2023-08-31 00:37:00 +03:00
Max Brunsfeld
f9dffc1734
Remove unnecessary ConstrainedBoxes in collab panel
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-30 14:35:02 -07:00
Max Brunsfeld
123bc85a8e
collab panel: Make screen share row line up with shared projects
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-30 14:23:12 -07:00
Max Brunsfeld
e0bdd857f1
Fix cursor colors of non-followed collaborators
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-30 14:14:18 -07:00
Max Brunsfeld
166585a2a8
Avoid accidental gpui transitive dependency in collab ( #2914 )
...
Release Notes:
- N/A
2023-08-30 13:22:10 -07:00
Max Brunsfeld
46429426ef
Avoid accidental gpui transitive dependency in collab
...
* Make Fs depend on Text, not vise versa
Co-authored-by: Joseph <joseph@zed.dev >
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-30 13:16:01 -07:00
Joseph T. Lyons
feb7a8a0f4
collab 0.19.0
2023-08-30 14:37:55 -04:00
Joseph T. Lyons
7204c245ea
v0.103.x dev
2023-08-30 13:41:09 -04:00
Nate Butler
e808386765
WIP UI Tweaks ( #2911 )
...
- Tighten up toolbar
- Reduce intensity of active tools
- Remove divider between project + branch
- Add a styletree for toolbar + move breadcrumb into it
- Some ts theme tidying
[[PR Description]]
Release Notes:
- Improved density and contrast of a number of UI elements.
2023-08-30 11:19:05 -04:00
Nate Butler
1da3be0646
Align diagnostic icons with other statusbar icons
2023-08-30 11:14:50 -04:00
Nate Butler
256949bee0
fmt
2023-08-30 10:56:08 -04:00
Antonio Scandurra
ea17d1638e
Introduce code generation ( #2901 )
...

Release Notes:
- Added a new "Inline Assist" feature that lets you transform a
selection or generate new code at the cursor location by hitting
`ctrl-enter`.
2023-08-30 14:58:22 +02:00
Antonio Scandurra
bf67d3710a
Remove trailing backticks when assistant ends with a trailing newline
2023-08-30 12:08:14 +02:00
Antonio Scandurra
5f6562c214
Detect indentation from GPT output
2023-08-30 12:07:58 +02:00
Antonio Scandurra
c6f4390511
Retain search history for inline assistants
...
This only works in-memory for now.
2023-08-30 11:30:51 +02:00
Antonio Scandurra
5c498c8610
Show inline assistant errors
2023-08-30 11:04:48 +02:00
Kirill Bulatov
7a1b300b25
Do not blink the cursor if Zed app is focused away ( #2907 )
...
Deals with https://github.com/zed-industries/community/issues/1116
Part of https://github.com/zed-industries/community/issues/1098
Use Mac platform callbacks to send a global event and enable/disable
caret blinking in editors when the app is not focused.
Release Notes:
- Stop blinking caret if Zed app is not focused
2023-08-30 10:53:09 +03:00
Nate Butler
6e964acd92
Fix extra theme entry
2023-08-29 20:04:15 -04:00
Nate Butler
97d187bba7
Remove project divider in titlebar
2023-08-29 19:50:27 -04:00
Nate Butler
2af5fc5030
Move breadcrumb style to toolbar
2023-08-29 16:37:48 -04:00
Nate Butler
c9b1237079
Update titlebar size
2023-08-29 16:20:19 -04:00
Nate Butler
93cf52a719
Update toolbar active state style
2023-08-29 16:10:40 -04:00
Nate Butler
d91a9615b5
Format
2023-08-29 16:02:04 -04:00
Nate Butler
33c9f14852
Don't require passing theme to toggleable_icon_button
2023-08-29 16:01:08 -04:00
Nate Butler
0a14e33dba
Pull toolbar into it's own styletree
2023-08-29 15:59:35 -04:00
Max Brunsfeld
e7ba5a1edb
Search UI polish ( #2904 )
...
This PR polishes the search bar UI, making the layout more dense, and
the spacing more consistent with the rest of the app. I've also
re-ordered the toolbar items to reflect some of @iamnbutler's original
search designs. The items related to the search query are on the left,
and the actions that navigate the buffer (next, prev, select all, result
count) are on the right.
2023-08-29 12:53:32 -07:00
Kirill Bulatov
100870aa9c
Do not blink the cursor if Zed window is focused away
...
co-authored-by: Max <max@zed.dev >
2023-08-29 21:33:03 +03:00
Conrad Irwin
dd577074f2
vim: Fix relative motions ( #2888 )
...
This changes vim motions to be relative to fold lines, not display
lines, to match the behaviour of vim.
This is necessary for relative line numbers to make sense (as the most
important thing is you can do `3j` to get th e line that is numbered 3).
Release Notes:
- vim: Fix handling of motions when `soft_wrap` is enabled in zed. Like
in vim `j,k,up,down,$,^,0,home,end` will all now navigate in file
coordinates not display coordinates.
- vim: Add `g {j,k,up,down,$,^,0,home,end}` to navigate in display
coordinates.
- vim: Add `z o` and `z c` to open and close folds.
- vim: Add `z f` in visual mode to fold selection.
Note: this may be a jarring change if you're grown used to the current
behaviour of `j` and `k`. You can make the issue less acute by setting
`"soft_wrap":"none"` in your settings; or you can manually copy the
bindings for `g j` to the binding for `j` (etc.) in your keymap.json to
preserve the existing behaviour.
2023-08-29 11:19:37 -07:00
Kirill Bulatov
859ac1e97f
Add a default binding for toggling inlay hints ( #2910 )
...
Release Notes:
- Add a `"ctrl-shift-:": "editor::ToggleInlayHints"` default binding
2023-08-29 21:09:46 +03:00
Nate Butler
e89ccf2e26
Remove unused label_button
2023-08-29 14:09:31 -04:00
Nate Butler
f0ab27a83d
Reorder "Select All" button
2023-08-29 14:04:17 -04:00
Kirill Bulatov
bbb222b6fc
Add a default binding for toggling inlay hints
2023-08-29 20:56:26 +03:00
Nate Butler
f626c61b1e
Update action_button style
2023-08-29 13:40:58 -04:00
Nate Butler
f6faeea720
Add disabled as an option on text_button
2023-08-29 13:40:46 -04:00
Nate Butler
05da4b740a
Update spacing, button heights
2023-08-29 13:28:06 -04:00
Nate Butler
a5b12d535f
Add margin and padding functions
2023-08-29 13:06:13 -04:00
Nate Butler
53558bc603
Remove baseurl to prevent theme import issue
2023-08-29 13:05:59 -04:00
Max Brunsfeld
7ae5ee699f
Debounce code action and document highlight requests ( #2905 )
...
Lately, I've been finding Rust-analyzer unusably slow when editing large
files (like `editor_tests.rs`, or `integration_tests.rs`). When I
profile the Rust-analyzer process, I see that it sometimes saturates up
to 10 cores processing a queue of code actions requests.
Additionally, sometimes when collaborating on large files like these, we
see long delays in propagating buffer operations. I'm still not sure why
this is happening, but whenever I look at the server logs in Datadog, I
see that there are remote `CodeActions` and `DocumentHighlights`
messages being processed that take upwards of 30 seconds. I think what
may be happening is that many such requests are resolving at once, and
the responses are taking up too much of the host's bandwidth.
I think that both of these problems are caused by us sending way too
many code action and document highlight requests to rust-analyzer. This
PR adds a simple debounce between changing selections and making these
requests.
From my local testing, this debounce makes Rust-analyzer *much* more
responsive when moving the cursor around a large file like
`editor_tests.rs`.
2023-08-29 09:30:36 -07:00
Antonio Scandurra
87e25c8c23
Use model from conversation when available
2023-08-29 18:25:02 +02:00
Antonio Scandurra
16422a06ad
Remember whether include conversation was toggled
2023-08-29 18:25:02 +02:00
Nathan Sobo
84b9c22170
Merge branch 'main' into ai-refactoring
2023-08-29 10:17:01 -06:00
Antonio Scandurra
df377d5195
Use Inline Assist across the board
2023-08-29 17:32:23 +02:00
Piotr Osiewicz
ea0e5e880e
chore: Use IsTerminal trait instead of relying on libc to detect stdout being a terminal ( #2908 )
...
IsTerminal was added in 1.70.
Release Notes:
- N/A
2023-08-29 15:56:50 +02:00
Nathan Sobo
396558755e
Testing: Update build script to make local testing easier ( #2903 )
...
* `script/bundle -l` will only build for the current architecture and
skip DMG creation. It will also copy to `/Applications`.
* `script/bundle -l "My Bundle"` will name the bundle after your
provided name.
* Passing `-f` will overwrite. Passing `-o` will also open the
application.
2023-08-29 07:07:35 -06:00
Antonio Scandurra
72413dbaf2
Remove the ability to reply to specific message in assistant
2023-08-29 14:51:00 +02:00
Antonio Scandurra
2332f82442
More polish
2023-08-29 14:41:02 +02:00
Antonio Scandurra
08df24412a
Delete less aggressively
2023-08-29 14:31:58 +02:00
Antonio Scandurra
c2b60df5af
Allow including conversation when triggering inline assist
2023-08-29 14:08:16 +02:00
Kirill Bulatov
1c6964ee96
Trim off surrounding [] when parsing terminal hover links ( #2906 )
...
Follow-up of https://github.com/zed-industries/zed/pull/2899
Terminal has to accept `[` and `]` as valid word parts, due to
`[slug].tsx` being a valid file name.
Yet, terminal has to exclude these to match paths in strings like
`[/some/path/[slug].tsx]`.
Release Notes:
- N/A
2023-08-29 10:49:33 +03:00
Kirill Bulatov
7c498feb85
Trim off surrounding [] when parsing terminal hover links
...
Terminal has to accept `[` and `]` as valid word parts, due to
`[slug].tsx` being a valid file name.
Yet, terminal has to exclude these to match paths in strings like
`[/some/path/[slug].tsx]`.
2023-08-29 10:40:20 +03:00
Max Brunsfeld
791f6cf9e7
Update some tests to reflect code action debouncing
2023-08-28 17:45:32 -07:00
Max Brunsfeld
5142049515
Demote some Peer logging to trace level
2023-08-28 17:45:19 -07:00
Max Brunsfeld
89eab78cf7
Debounce document highlight and code actions requests
2023-08-28 15:48:55 -07:00
Max Brunsfeld
70bea75897
Change cycle mode action to reflect new mode button order
2023-08-28 15:15:54 -07:00
Max Brunsfeld
3eee282a6b
Overhaul search bar layout
...
* Use a single row, instead of centering the search bar within a double-row toolbar.
* Search query controls on the left, navigation on the right
* Semantic is the final mode, for greater stability between buffer and project search.
* Prevent query editor from moving when toggling path filters
2023-08-28 14:20:09 -07:00
Max Brunsfeld
78f9a1f280
Remove padding from workspace toolbar, increase its content height to compensate
...
The padding makes it difficult to layout toolbar items correctly when they are more than one row tall.
2023-08-28 14:18:30 -07:00
Max Brunsfeld
bb448b91d5
Don't add a quick actions toolbar item for non-editor views
...
Rather than adding primary toolbar item that renders as empty,
don't add an item at all. This prevents spurious spacing from
being added after other primary toolbar items.
2023-08-28 14:16:45 -07:00
Max Brunsfeld
9521f6da42
Simplify implementation of flex with spacing
2023-08-28 14:16:21 -07:00
Nathan Sobo
a1d2ae3095
Add -l option to build script
...
When you pass -l, we build for the local architecture only and copy the
resulting app bundle to /Applications. You can provide a bundle name as
an optional argument.
2023-08-28 13:32:30 -06:00
Max Brunsfeld
04354675ca
Remove search dismiss button
2023-08-28 10:35:23 -07:00
Piotr Osiewicz
9aad602af7
chore: Bump memchr to 2.6.0 ( #2902 )
...
Fresh off the press, memchr 2.6.0 adds vector search routines for
aarch64. That directly improves our search performance for both text and
regex searches. Per BurntSushi's claims, the simple string searches in
ripgrep got ~2 times faster (more details available in
https://github.com/BurntSushi/memchr/pull/129 ).
Release Notes:
- N/A
2023-08-28 18:20:10 +02:00
Antonio Scandurra
ccec59337a
📝
2023-08-28 14:46:05 +02:00
Antonio Scandurra
52e1e014ad
Allow redoing edits performed by inline assistant after cancelling it
2023-08-28 14:42:52 +02:00
Antonio Scandurra
b9df85e01f
Remove todo.md
2023-08-28 14:25:01 +02:00
Antonio Scandurra
8c4d2ccf80
Close inline assist when the associated transaction is undone
2023-08-28 14:23:42 +02:00
Antonio Scandurra
c587cf66ce
Remove ellipsis from tooltip
2023-08-28 12:24:01 +02:00
Antonio Scandurra
44f554f489
Merge remote-tracking branch 'origin/main' into ai-refactoring
2023-08-28 12:16:24 +02:00
Antonio Scandurra
1fb7ce0f4a
Show icon to toggle inline assist
2023-08-28 12:13:44 +02:00
Antonio Scandurra
d804afcfa9
Don't auto-indent when the assistant starts responding with indentation
2023-08-28 11:57:02 +02:00
Piotr Osiewicz
07b9c6c302
language: Make Buffer::new take an explicit ID ( #2900 )
...
See Linear description for the full explanation of the issue. This PR is
mostly a mechanical change, except for the one case where we do pass in
an explicit `next_id` instead of `model_id` in project.rs.
Release Notes:
- Fixed a bug where some results were not reported in project search in
presence of unnamed buffers.
2023-08-28 11:51:50 +02:00
Antonio Scandurra
937aabfdfd
Extract a strip_markdown_codeblock function
2023-08-28 11:24:55 +02:00
Kirill Bulatov
81a5043b61
Allow [ and ] symbols in terminal links ( #2899 )
...
Deals with https://github.com/zed-industries/community/issues/1865
` ./src/pages/[[...slug]].tsx` is a valid file path in macOs and Linux,
and should be available for cmd-hover-click in terminal.
Release Notes:
- Allow `[` and `]` symbols in terminal links
2023-08-28 11:40:52 +03:00
Kirill Bulatov
506ec01df3
Allow [ and ] symbols in terminal links
...
` ./src/pages/[[...slug]].tsx` is a valid file path in macOs and Linux,
and should be available for cmd-hover-click in terminal.
2023-08-28 11:19:57 +03:00
Kirill Bulatov
3bfe78b1df
Use proper property names for inlay hint resolve capabilities
2023-08-28 00:27:59 +03:00
Kirill Bulatov
805ae1be80
More inlay hover fixes ( #2898 )
...
Better handle edge cases around cmd+hover around inlays:
* distinguish between same text anchors' trigger: inlay and text
triggers can have the same anchor, but are different
* forbid cmd+click on inlay that has no label part with location
selected
* properly omit throttled inlays that are outside of the visible range
Release Notes:
- N/A
2023-08-27 19:57:31 +03:00
Kirill Bulatov
38da2a587a
Fix the tests
2023-08-27 19:41:15 +03:00
Kirill Bulatov
81e70905bb
Do not allow cmd+click in invalid inlay context
2023-08-27 19:12:32 +03:00
Kirill Bulatov
693e91f335
Properly compare previous hover trigger point when hover changes
2023-08-27 18:23:40 +03:00
Kirill Bulatov
dad64edde1
Better highlight hint ranges
2023-08-27 15:14:45 +03:00
Piotr Osiewicz
576849c98a
WIP. Fix up some more test scenarios
2023-08-26 23:16:58 +02:00
Kirill Bulatov
5cf51211b6
Use better names, simplify
2023-08-27 00:01:31 +03:00
Piotr Osiewicz
f16105f391
fix up platform namespace in test macro
2023-08-26 23:00:13 +02:00
Piotr Osiewicz
ac329e40dc
Allow dead code for is_empty fn
2023-08-26 22:42:55 +02:00
Piotr Osiewicz
a9db466e67
chore: fmt
2023-08-26 22:40:11 +02:00
Piotr Osiewicz
6f32431d33
Merge branch 'main' into gpui_extract_platform
2023-08-26 22:39:57 +02:00
Kirill Bulatov
73937876b6
Properly omit throttled hint queries
2023-08-26 21:12:04 +03:00
Kirill Bulatov
851d74d5e1
Improve inlay hints management ( #2897 )
...
Apply a rate limiter to hints scrolling, properly invalidate hint task
cached ranges, properly react to multibuffer events, properly highlight
hints and introduce basic debug logging for hints.
Release Notes:
- N/A
2023-08-26 16:50:12 +03:00
Kirill Bulatov
f8a8b998ce
Properly react on excerpts drop
2023-08-26 15:21:45 +03:00
Kirill Bulatov
84284099e2
Properly handle padding when highlighting inlay hints
2023-08-26 15:04:48 +03:00
Kirill Bulatov
2a42a08f46
Invalidate skipped throttled hint fetch tasks' ranges
2023-08-26 14:47:42 +03:00
Kirill Bulatov
9bdf76f445
Properly handle hover-less areas hover
2023-08-26 14:42:20 +03:00
Kirill Bulatov
48659d3b3c
Treat multibuffer edit events properly
...
Miltibuffer emits edit events even if it only got an excerpt
added/removed/etc.
Separate buffer edits and trigger hint invalidation refresh for them
only, also trigger hint new lines refresh on excerpt addition events.
2023-08-26 14:13:24 +03:00
Kirill Bulatov
3fc48fc277
Log LSP inlay hint path
2023-08-26 13:46:55 +03:00
Antonio Scandurra
55bf45d265
Add disabled style for prompt editor after confirming
2023-08-26 12:07:03 +02:00
Kirill Bulatov
e6fb909d89
Limit LSP non-invalidating queries
2023-08-26 13:06:50 +03:00
Antonio Scandurra
658d616b96
Allow multiple inline assistant highlights at once
2023-08-26 11:55:47 +02:00
Kirill Bulatov
2b007930a9
Remove query ranges for failed inlay hint requests
2023-08-26 12:09:12 +03:00
Antonio Scandurra
c8e5c3963b
Clear selection when deploying inline assistant
2023-08-26 09:52:01 +02:00
Mikayla Maki
8ddee0e58d
Server-sent feature flags ( #2894 )
...
This PR adds the wiring to both the server and the client for sending
and receiving individual feature flags, as well as a client side API for
convenient access to these feature flags.
Release Notes:
- N/A
2023-08-25 17:11:33 -07:00
Kirill Bulatov
afdc5012cb
Fix inlay hint bugs ( #2895 )
...
* https://github.com/zed-industries/zed/pull/2891
Fixes ranges pointing at incorrect positions inside multi-codepoint
characters
* https://github.com/zed-industries/zed/pull/2890
Defers hint links' document URL resolution into buffer up until the
hover & cmd-click is made by the user.
Release Notes:
- N/A
2023-08-26 03:09:19 +03:00
Mikayla
74565ed0b8
Add feature flags handling to the client, rewrite staff mode to a trait extension style
2023-08-25 17:00:53 -07:00
Kirill Bulatov
81c64647e8
Fix the test
2023-08-26 03:00:53 +03:00
Kirill Bulatov
e6c4802488
Properly clip request offsets
2023-08-26 02:54:50 +03:00
Kirill Bulatov
b2b0918790
Consider padding during hint highlight range mapping
2023-08-26 02:45:08 +03:00
Kirill Bulatov
665d86ea73
Defer navigation target buffer opening
2023-08-26 02:45:08 +03:00
Kirill Bulatov
ddd7ab116f
Do not convert lsp::Location of hint labels before resolve
2023-08-26 02:45:08 +03:00
Max Brunsfeld
d6ffb68305
Fix bugs in autoscroll with 'fit' strategy ( #2893 )
...
This fixes a bug where text moved up and down by one pixel in the buffer
search query editor, while typing.
Release notes:
* Fixed a bug where editors didn't auto-scroll when typing if all
cursors could not fit within the viewport.
2023-08-25 16:36:33 -07:00
Piotr Osiewicz
2495d6581e
Un serialize project search ( #2857 )
...
This is the first batch of improvements to current project search. There
are few things we can do better still, but I want to get this out in
next Preview.
Most of the slowness at this point seems to stem from updating UI too
often.
Release Notes:
- Improved project search by making it report results sooner.
---------
Co-authored-by: Julia Risley <julia@zed.dev >
2023-08-26 01:31:52 +02:00
Max Brunsfeld
a3b2c03b17
Fix bugs in autoscroll with 'fit' strategy
...
* Scroll to the newest cursor if all cursors can't fit in the viewport.
* Refuse to layout an editor less tall than one line height.
Co-authored-by: Nathan <nathan@zed.dev >
2023-08-25 16:13:12 -07:00
Piotr Osiewicz
8342803ba5
WIP test migration
2023-08-26 00:13:57 +02:00
Piotr Osiewicz
d033475565
Fix playground build
2023-08-25 23:43:45 +02:00
Mikayla
6fdf101745
Update database and RPC to provide configured feature flags
2023-08-25 14:34:32 -07:00
Piotr Osiewicz
2a350e91b2
chore: fmt
2023-08-25 23:29:28 +02:00
Piotr Osiewicz
fe17505100
Use gpui_platform in Zed
2023-08-25 23:29:12 +02:00
Piotr Osiewicz
79179e8fff
Merge branch 'main' into gpui_extract_platform
2023-08-25 23:28:27 +02:00
Piotr Osiewicz
95b4bd467b
chore: fmt
2023-08-25 23:24:23 +02:00
Conrad Irwin
dee1a433dd
A few more fixes for wrapped line motions
2023-08-25 14:40:04 -06:00
Conrad Irwin
20aa2a4c54
vim: Fix relative line motion
...
Before this change up and down were in display co-ordinates, after this
change they are in fold coordinates (which matches the vim behaviour).
To make this work without causing usabliity problems, a bunch of extra
keyboard shortcuts now work:
- vim: `z {o,c}` to open,close a fold
- vim: `z f` to fold current visual selection
- vim: `g {j,k,up,down}` to move up/down a display line
- vim: `g {0,^,$,home,end}` to get to start/end of a display line
Fixes : zed-industries/community#1562
2023-08-25 14:40:04 -06:00
Conrad Irwin
0280d5d010
vim change for wrapped lines
2023-08-25 14:40:03 -06:00
Conrad Irwin
104f5ae9cd
relative line numbers ( #2887 )
...
- Add relative_line_mode
- vim change for wrapped lines
Release Notes:
- Add a `relative_line_numbers` setting
([#988 ](https://github.com/zed-industries/community/issues/998 )).
2023-08-25 14:17:41 -06:00
Joseph T. Lyons
c1fd648390
Add setting to automatically enable virtual environment ( #2882 )
...
This isn't ready to go - I'm opening a PR to ask for some advice. When
activating a python virtual environment, the typical command used is
`source path_to_venv/bin/activate`. The problem is, the activatate
script isn't portable to all shells, so some additional scripts are
bundled in the env, for example, `activate.fish`. We don't have a good
way of knowing what shell we are in, in order to know what script to
run.
Julia gave the alternative of simply activating the virtual environment
while in the zsh context, before the user's custom shell is launched,
which I think does work, but because we activate the virtual environment
before we launch the custom shell, the shell isn't really aware that we
are in the virtual environment and it fails to display the information
in the prompt that is typically shown after activating.
Is there a clean way for us to know for a fact what shell is being ran,
so we know what script to run?
Check out the code comments below for more context.
---
https://github.com/zed-industries/zed/assets/19867440/ddb76aaa-152b-4c93-a513-3cd580b7c40f
I've used Zed to write Python scripts, but working on an actual project
has really magnified where Python dev is falling short. A huge
quality-of-life thing we can do is provide a setting to automaticaly
search for and activate virtual environments when found, when terminals
are created. Manually starting these up in every terminal instance is
such a drag.
A few quirks:
- We don't have a way of knowing if the prompt is ready before we try
run the command, which means we see the text inserted at the top of the
terminal and on the prompt - I dont think this should be a blocker
though.
- If a user has multiple python projects with mutliple virtual
environments, we only detect and activate the first one, since can't
really make any assumptions about which one to activate. I dont think
this should be a blocker either, as I think most users will have a
single project open in Zed.
Release Notes:
- Added a `detect_venv` setting for the terminal. When configured, the
Zed terminal will automatically activate Python virtual environments on
terminal creation.
2023-08-25 15:14:24 -04:00
Joseph T. Lyons
507a5db09c
WIP
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-08-25 15:06:31 -04:00
Conrad Irwin
bde67b2b9c
Fix merge-conflict
2023-08-25 11:59:16 -06:00
Conrad Irwin
1c945a7521
Fix zed-industries/community#1950 ( #2892 )
...
Release Notes:
- vim: fix goal preservation of visual block selections
([#1950 ](https://github.com/zed-industries/community/issues/1950 )).
2023-08-25 11:55:48 -06:00
Conrad Irwin
f18cdcba54
Fix relative line numbers in vim visual mode
...
In visual mode when your selection ends with a newline we show the
cursor at the end of the previous line (not the start of the current
line). We had only been accounting for this if the cursor was on-screen.
2023-08-25 11:50:41 -06:00
Conrad Irwin
8d5dc266a3
Fix relative line numbers when newest cursor offscreen
2023-08-25 11:50:41 -06:00
Conrad Irwin
790aa5d476
Add relative_line_mode
...
Co-Authored-By: joseph@zed.dev
2023-08-25 11:50:41 -06:00
Conrad Irwin
1f3e009b32
Fix zed-industries/community#1950
2023-08-25 11:34:07 -06:00
Max Brunsfeld
f798be6e27
Fix rust 1.72 warnings about shadowed glob re-exports
2023-08-25 10:25:21 -07:00
Max Brunsfeld
404f76739c
Format let-else statements
2023-08-25 10:11:32 -07:00
Max Brunsfeld
732af201dc
Upgrade to rust 1.72
2023-08-25 09:59:16 -07:00
Antonio Scandurra
7c5200e757
More styling
2023-08-25 17:51:13 +02:00
Antonio Scandurra
c4966ff57a
Remove warning
2023-08-25 17:35:14 +02:00
Antonio Scandurra
75a6a94e96
Add placeholder text for inline assistant prompts
2023-08-25 17:24:26 +02:00
Kirill Bulatov
44c340b5f2
Properly invalidate the hint cache
2023-08-25 17:33:17 +03:00
Antonio Scandurra
b101a7edff
Cancel last inline assist when escaping from the editor
2023-08-25 15:54:52 +02:00
Antonio Scandurra
fdbf4680bb
Ensure the inline assistant works with gpt-3.5
2023-08-25 15:39:10 +02:00
Kirill Bulatov
205e101dd0
Query certain editor ranges for inlays with a delay ( #2891 )
...
Part of
https://linear.app/zed-industries/issue/Z-2750/investigate-performance-of-collaborating-on-large-files-with-inlay
Fixes
https://linear.app/zed-industries/issue/Z-2824/inlay-hints-affect-code-layout-in-multibuffer
We query hints for visible part of the screen, and two parts above and
below the visible range, of the same range (if applicable, we can be on
the edge of the document).
When rapidly typing, we do not care about the invisible range updates,
yet still query a lot of them + rust-analyzer sends /refresh hint
requests shortly after every modification too, forcing us to re-query.
Instead querying both visible and invisible ranges altogether, wait for
visible range query first and wait add a `400ms` delay afterwards before
querying the invisible ranges.
This allows any /refresh requests or rapid typing to avoid 2 extra
requests, cancelling them before they start.
Visible part of the screen is still queried after every change, without
any debouncing.
Release Notes:
- Delay certain inlay hint requests to reduce general LSP server load
2023-08-25 16:33:21 +03:00
Kirill Bulatov
2b95f0580e
Fix the tests
2023-08-25 16:25:43 +03:00
Kirill Bulatov
c10c3e2b54
Only invalidate when doing first, visible range query
2023-08-25 15:16:55 +03:00
Kirill Bulatov
a63e1571dc
Defer querying inlay hints for invisible editor ranges
...
This way, only the visible part gets frequently queried on typing (and
hint /refresh requests that follow), with queries for invisible ranges
cancelled eagerly.
2023-08-25 15:16:55 +03:00
Kirill Bulatov
b50762c821
Handle inlay hints resolve, support dynamic hints ( #2890 )
...
Resolves inlay hints on hover, shows hint label parts' tooltips, allows
cmd+click to navigate to the hints' parts with locations,
correspondingly highlight the hints.
Release Notes:
- Support dynamic inlay hints
2023-08-25 15:16:13 +03:00
Kirill Bulatov
0a18aa694f
Use stricter inlay range checks to avoid stuck highlights
...
Often, hint ranges are separated by a single '<` char as in
`Option<Vec<u32>>`. When moving the caret from left to right, avoid
inclusive ranges to faster update the matching hint underline.
2023-08-25 14:46:39 +03:00
Antonio Scandurra
27c90f12f6
Merge remote-tracking branch 'origin/main' into ai-refactoring
2023-08-25 13:37:32 +02:00
Antonio Scandurra
0444b5a775
💄
2023-08-25 13:36:52 +02:00
Kirill Bulatov
8ed280a029
Rebase fixes
2023-08-25 14:30:07 +03:00
Kirill Bulatov
e44516cc6c
Add hover tests
2023-08-25 14:26:17 +03:00
Kirill Bulatov
f19c659ed6
Add link_go_to_definition test for inlays
2023-08-25 14:26:17 +03:00
Kirill Bulatov
abd2d012b1
Properly binary search cached inlay hints
2023-08-25 14:26:17 +03:00
Kirill Bulatov
3c55c933d4
Be more lenient with hint resolution, always return some hint
2023-08-25 14:26:17 +03:00
Kirill Bulatov
852427e87b
Use inlay highlights in randomized tests
2023-08-25 14:26:17 +03:00
Kirill Bulatov
7cd60d6afb
Simplify and restore client resolve capabilities
2023-08-25 14:26:17 +03:00
Kirill Bulatov
dcf570bb03
Fix resolve status conversion
2023-08-25 14:26:17 +03:00
Kirill Bulatov
bcaff0a18a
Propagate inlay background highlights to data storage
2023-08-25 14:26:17 +03:00
Kirill Bulatov
4b78678923
Prepare background highlights for inlay highlights
2023-08-25 14:26:17 +03:00
Kirill Bulatov
12ffbe54fb
Unify text and inlay highlights
2023-08-25 14:26:17 +03:00
Kirill Bulatov
420f8b7b15
Prepare for inlay and text highlight unification
2023-08-25 14:26:17 +03:00
Kirill Bulatov
4cc9f2f525
Highlight inlay hint parts on cmd-hover
...
Co-Authored-By: Antonio <antonio@zed.dev >
2023-08-25 14:26:17 +03:00
Kirill Bulatov
f8874a726c
Attempt to highlight inlays
2023-08-25 14:26:17 +03:00
Kirill Bulatov
6c5761d05b
Pass inlay highlight information
2023-08-25 14:26:17 +03:00
Kirill Bulatov
477fc865f5
Properly resolve inlay label parts' locations and buffers
2023-08-25 14:26:17 +03:00
Kirill Bulatov
7eab18ec89
Pass inlay go to definition data
2023-08-25 14:26:17 +03:00
Kirill Bulatov
ac86bbac75
Prepare for hover functionality refactoring
2023-08-25 14:26:17 +03:00
Kirill Bulatov
80e8714241
Send inlay hint resolve requests
2023-08-25 14:26:17 +03:00
Kirill Bulatov
3434990b70
Store inlay hint resolve data
2023-08-25 14:26:17 +03:00
Kirill Bulatov
e4b78e322e
Revert "Strip off inlay hints data that should be resolved"
...
Without holding all hints in host's cache, this is impossile.
Currenly, we keep hint caches separate and isolated, so this will not
work when we actually resolve.
2023-08-25 14:26:17 +03:00
Kirill Bulatov
d1cb0b3c27
Properly detect hovered inlay hint label part
2023-08-25 14:26:17 +03:00
Kirill Bulatov
d34491e822
Draft inlay hint part hover detection
2023-08-25 14:26:17 +03:00
Antonio Scandurra
971c833e80
Improve background highlighting of inline assists
2023-08-25 12:35:36 +02:00
Antonio Scandurra
144f5c5d41
Use a left bias for the prompt editor
2023-08-25 12:25:43 +02:00
Antonio Scandurra
66a496edd7
Allow generating code without editing it
2023-08-25 12:16:28 +02:00
Antonio Scandurra
c1bd035875
Rework inline assistant
2023-08-25 11:39:27 +02:00
Kyle Caverly
bc7e9088fe
Eager Semantic Indexing Queue ( #2886 )
...
Optimization to the Semantic Indexing Engine.
We've transitioned from a framework in which the entire project tree is
walked at each index command, to an eager queuing method, in which an
initial queue of outstanding indexing work is initialized upon workspace
creation, and then subscriptions are leveraged for file change events to
continually keep an updated view on outstanding work.
This optimization contributes towards quicker user feedback, when
initializing or using Semantic Search functionality. It also opens the
doors towards better transparency across the system on outstanding
indexing work.
Release Notes:
- Refactored index operation queue to an eager queuing framework.
- Moved semantic search initialization to workspace creation.
- Adjusted rate limiting strategy on api delays to reduce time spent
waiting for rate limits.
2023-08-25 11:03:05 +02:00
KCaverly
ee97bc54cf
cleaned up warnings
2023-08-25 10:38:01 +02:00
Joseph T. Lyons
f1586c9923
Automatically enable project search filters when using Search Inside ( #2889 )
...
Now that the filters are hidden behind a toggle-able setting, running
the `Search Inside` action from the project panel feels a bit weird,
since the filter being used is hidden. This PR automatically opens that
filter section after running a `Search Inside` action.
Release Notes:
- N/A
2023-08-25 02:39:44 -04:00
Joseph T. Lyons
8288e5591d
Automatically enable project search filters when using Search Inside
2023-08-25 02:21:07 -04:00
Joseph T. Lyons
0801e5e437
Merge branch 'main' into add-setting-to-automatically-enable-virtual-environment
2023-08-25 01:50:57 -04:00
Joseph T. Lyons
9fe580acb6
WIP
2023-08-25 01:50:54 -04:00
Mikayla Maki
fbc7b37b2f
Introduce channel notes ( #2880 )
...

### Todo
* [x] Snapshot channel buffers when everyone closes the buffer
* [x] Ensure that users who are in both a project and a channel note
have the same color in both places
* [x] Allow following project collaborators into channel notes
* [x] Expose notes for the current channel under "Current Call" section
of the collaboration panel
* [x] Offline state for the channel notes view
* [x] Make the channel context menu accessible to all members (to expose
the notes)
* [x] Wire in view and Item method overrides
Release Notes:
- N/A
2023-08-24 18:01:28 -07:00
Max Brunsfeld
a95dcfa8bc
Make channel notes view searchable and navigable via pane history
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-24 17:18:18 -07:00
Max Brunsfeld
7b6c0c539c
Show non-admin context menu items for all channel members
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-24 17:17:20 -07:00
Max Brunsfeld
c7c220309d
Avoid creating redundant snapshots of channel notes buffers
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-24 16:55:45 -07:00
Max Brunsfeld
358a20494c
Make channel notes read-only when disconnected
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-24 16:50:13 -07:00
Max Brunsfeld
a327320f7d
Show channel notes in current call section of collab panel
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-24 15:00:54 -07:00
Max Brunsfeld
1ae54ca620
Dedup channel views
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-24 14:29:04 -07:00
Max Brunsfeld
5888e7b214
Dedup channel buffers
2023-08-24 13:40:44 -07:00
Max Brunsfeld
90f22cb0d2
Replicate editor state when following into channel notes
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-24 12:36:01 -07:00
Max Brunsfeld
24141c2f16
Ensure collaborators cursor colors are the same in channel buffers as in projects
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-24 11:31:41 -07:00
Max Brunsfeld
3268cce41a
Fix error in update_channel_buffer when there are no operations to store
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-24 11:26:22 -07:00
Mikayla
199be8241c
Add following into channel notes
...
co-authored-by: max <max@zed.dev >
2023-08-24 11:25:20 -07:00
Antonio Scandurra
b6035ee6a6
WIP
2023-08-24 20:00:25 +02:00
Conrad Irwin
3b6794fe36
vim: Fix linewise copy of last line with no trailing newline ( #2885 )
...
Along the way, delete the VimBindingTestContext by updating the
visual tests to no-longer need it.
Release Notes:
- vim: Fix `y` when on the last line of a file with no trailing newline.
2023-08-24 10:45:46 -06:00
KCaverly
131950f670
add handling for Added file events to semantic index
2023-08-24 18:40:08 +02:00
Antonio Scandurra
cb4b816d0e
Add todo for modal assistant
2023-08-24 17:33:59 +02:00
Antonio Scandurra
805e44915c
WIP
2023-08-24 17:23:12 +02:00
Antonio Scandurra
cbf7160054
Improve scoring
2023-08-24 16:32:55 +02:00
Antonio Scandurra
c1d9b37dbc
Move to an inline refactoring prompt
2023-08-24 15:46:18 +02:00
Antonio Scandurra
2468506189
Always clear refactoring text highlights, even if an error occurs
2023-08-24 14:29:05 +02:00
Antonio Scandurra
71a5964c18
Rename merge_transaction_into to merge_transactions
2023-08-24 14:26:42 +02:00
KCaverly
a892a51ec3
update initialize project call to accomodate for test scenarios
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-24 13:46:43 +02:00
KCaverly
0b204bfdc8
reindex semantic index when search project pane is reactivated in semantic mode
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-24 13:40:04 +02:00
KCaverly
a1519e4c38
move semantic search project intialization to a subscribe event for workspace created
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-24 13:14:19 +02:00
KCaverly
e8e7b294d8
add delete files operation for remaining files in database not included in current worktree
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-24 12:49:20 +02:00
Antonio Scandurra
9674b03855
Make scoring more precise by using floats when diffing AI refactors
2023-08-24 12:45:44 +02:00
Antonio Scandurra
481bcbf204
Normalize indentation when refactoring
2023-08-24 12:45:21 +02:00
KCaverly
afe0e74868
remove worktree_file_mtimes in state as it is no longer used
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-24 12:42:41 +02:00
KCaverly
aa07872a24
accomodate for duplicate entries in indexing queue
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-24 12:36:43 +02:00
KCaverly
3f9f742530
update rate limiting embeddings strategy to delay less
2023-08-24 11:45:52 +02:00
Antonio Scandurra
985397b55c
📝
2023-08-24 09:52:07 +02:00
Conrad Irwin
e4794e3134
vim: Fix linewise copy of last line with no trailing newline
...
Along the way, delete the VimBindingTestContext by updating the
visual tests to no-longer need it.
2023-08-24 00:00:12 -06:00
Max Brunsfeld
7e83138805
Start work on showing consistent replica ids for channel buffers
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-23 18:37:01 -07:00
Max Brunsfeld
11ef5e2740
Simplify buffer_operations schema
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-23 18:37:01 -07:00
Max Brunsfeld
1d08f44e70
Snapshot channel notes buffers when everyone leaves
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-23 18:37:01 -07:00
Mikayla
4eff8ad186
Add channel notes view
...
co-authored-by: Max <max@zed.dev >
2023-08-23 18:37:00 -07:00
Mikayla
5a0315c4d5
Achieve end to end channel buffer synchronization
...
co-authored-by: max <max@zed.dev >
2023-08-23 18:34:43 -07:00
Max Brunsfeld
95ea664725
WIP
2023-08-23 18:34:43 -07:00
Max Brunsfeld
71611ee7a2
Get join_buffer_for_channel compiling
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-23 18:34:43 -07:00
Mikayla
364ed1f840
WIP: pass synchronize channel buffers integration test
2023-08-23 18:34:43 -07:00
Mikayla
a7a4e2e369
Add buffer integration test
...
Rearrange channel crate structure
Get channel buffer from database
co-authored-by: Max <max@zed.dev >
2023-08-23 18:34:43 -07:00
Max Brunsfeld
ff5035ea37
Start work on storing channel buffers
2023-08-23 18:34:43 -07:00
Max Brunsfeld
29e43384f0
Simplify macro for running a test with both databases
2023-08-23 18:34:43 -07:00
Mikayla Maki
26c3312049
Fix cursor and hover styles changing when dragging the mouse ( #2884 )
...
Since the resizing rework on docks, I noticed a lot of cursor flickering
when dragging, that drags trigger hover states in underlying elements
instead of being ignored, and that clicking and dragging off a button
can leave that button's click style active. This PR fixes all three
bugs.
Release Notes:
- Fixed several styling bugs related to dragging the mouse cursor
2023-08-23 18:29:29 -07:00
Mikayla
ff75d1663b
Fix stuck click styling when dragging off of a button
2023-08-23 18:22:48 -07:00
Mikayla
4d2f5a8e04
Fix cursor and hover styles changing when dragging the mouse
2023-08-23 18:08:33 -07:00
Mikayla Maki
2ab8ebaaf7
Add disclosable component ( #2868 )
...
This PR adds a disclosable component, related wiring, and uses it to
implement the collaboration panel's disclosure of subchannels. It also
adds a component test page to make style development easier, and
refactors components into v0.2, safe styles (as described in [TWAZ
#16 ](https://zed.dev/blog/this-week-at-zed-16 ))
Release Notes:
- N/A
2023-08-23 16:37:34 -07:00
Mikayla
707ca34f19
Merge branch 'main' into disclosable-component
2023-08-23 16:30:27 -07:00
Mikayla
2a182b6a7b
Tune styles and disclosable elements
2023-08-23 16:25:40 -07:00
Piotr Osiewicz
1320fadc30
Bump rust embed ( #2883 )
...
This is a follow-up to a recent patch I've submitted to this crate to
improve compile time and runtime (in older versions file lookup was
essentially O(n) with respect to path count, now it's O(log n))
Release Notes:
- N/A
2023-08-24 00:16:35 +02:00
KCaverly
b72c4c576b
catchup with main
2023-08-23 22:31:39 +02:00
KCaverly
e42b9e910e
fix async calls on project updated entries to ensure that all files are updating appropriately
2023-08-23 22:28:30 +02:00
Joseph T. Lyons
6c45be2dc4
Add docker system prune command
...
This will hopefully keep the system drive cleaned up so we don't run issues with not enough disk space.
2023-08-23 14:54:39 -04:00
Joseph T. Lyons
af21546a43
collab 0.18.0
2023-08-23 14:19:24 -04:00
Antonio Scandurra
f22acb602e
Apply a score boost when consecutive triplets of characters match
2023-08-23 19:21:44 +02:00
Joseph T. Lyons
72f0efb7b7
v0.102.x dev
2023-08-23 12:49:13 -04:00
Antonio Scandurra
301a12923f
Merge transactions into the original assistant transaction
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-08-23 18:22:17 +02:00
Antonio Scandurra
a69461dba2
Don't score whitespace matches
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-08-23 17:19:07 +02:00
Antonio Scandurra
e4f49746e1
Group modal assistant edits into the same transaction
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-08-23 17:09:15 +02:00
Nathan Sobo
1bc4f22373
Rework element system, phase 1 ( #2881 )
...
This is a deep cut. There's still more work to do until we start
building UI with this. I've approached this as additively as possible,
but I've made a few changes to the rest of the code that I think would
be good to upstream before proceeding too much further.
Most of the interesting pieces are in gpui/playground, which is a
standalone binary that opens a single window and renders a new kind of
element. The layout of these new elements is provided by the taffy
layout engine crate, which conforms to web conventions. The idea is that
playground is relatively cheap to build and work on. As concepts
coalesce in playground, we can drop them into gpui and start
transitioning.
2023-08-23 08:26:38 -06:00
Antonio Scandurra
d3238441ce
🎨
2023-08-23 16:13:37 +02:00
KCaverly
09fd99b1e3
moved semantic_index project intialization to queue and channel method
2023-08-23 15:09:15 +02:00
Antonio Scandurra
2e1a4b2591
Adjust scoring
2023-08-23 13:26:30 +02:00
Antonio Scandurra
aa6d6582fd
Add basic styling
2023-08-23 13:09:02 +02:00
Antonio Scandurra
a2671a29a0
Highlight text when the diff is the same
2023-08-23 10:28:43 +02:00
Joseph T. Lyons
7b170304df
Shorten setting name
2023-08-23 04:07:10 -04:00
Joseph T. Lyons
711f156308
WIP
2023-08-23 04:04:36 -04:00
Antonio Scandurra
a93583065b
Delete unused imports
2023-08-23 09:59:07 +02:00
Antonio Scandurra
c2935056e8
Support multi-byte characters in diff
2023-08-23 09:46:33 +02:00
Antonio Scandurra
a9871a7a70
Add randomized tests for incremental diff
2023-08-23 09:09:01 +02:00
Joseph T. Lyons
b77e661c9f
Update textmate.json
2023-08-23 01:31:01 -04:00
Nathan Sobo
cd72a42bd4
Mark new crates as publish = false
2023-08-22 20:47:05 -06:00
Conrad Irwin
b0815bd13e
vim: Rewrite paste ( #2878 )
...
A complete overhaul of the way vim did paste. This ended up being more
involved than I expected because of the variety of different behaviors
that vim exhibits when copying/pasting between various modes.
Release Notes:
- vim: support P for paste before
([#1869 ](https://github.com/zed-industries/community/issues/1869 )).
- vim: support P in visual modes for paste without overriding clipboard
- vim: fix position when using `p` on text copied outside zed
([#469 ](https://github.com/zed-industries/community/issues/469 )).
- vim: fix indentation when using `p` on text copied from zed
([#1015 ](https://github.com/zed-industries/community/issues/1015 )).
- all: Separate copied multi-selections by `\n`
2023-08-22 20:21:58 -06:00
Piotr Osiewicz
978d074b1d
WIP
2023-08-23 01:33:19 +02:00
Piotr Osiewicz
d0f287772b
chore: fmt
2023-08-23 01:13:04 +02:00
Nathan Sobo
d375f7992d
Merge branch 'main' into divs
2023-08-22 16:35:56 -06:00
Conrad Irwin
27ba77b16f
Ensure editor clipboard contains \n too
2023-08-22 13:52:04 -06:00
Conrad Irwin
215a922680
vim: Dismiss menu in insert mode with escape ( #2879 )
...
Release Notes:
- vim: Fix escape to dismiss suggestions in insert mode.
2023-08-22 13:38:12 -06:00
Joseph T. Lyons
471810a3c2
WIP
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-08-22 15:29:25 -04:00
Conrad Irwin
ef077796f8
vim: Dismiss menu in insert mode with escape
2023-08-22 13:28:50 -06:00
Conrad Irwin
33d7fe02ee
Rewrite paste
...
- vim: support P for paste before
- vim: support P in visual mode for paste without overriding clipboard
- vim: fix position when using `p` on text copied outside zed
- vim: fix indentation when using `p` on text copied from zed
2023-08-22 13:27:57 -06:00
Conrad Irwin
31db5e4f62
Vim z 2819 ( #2875 )
...
Add `$` and `#` and a smoke test for vim-mode respecting the
configuration.
2023-08-22 11:38:06 -06:00
Nathan Sobo
733df38f9b
Checkpoint
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-08-22 11:34:06 -06:00
Antonio Scandurra
3a511db5c9
🎨
2023-08-22 18:41:22 +02:00
Piotr Osiewicz
ccb3f6748c
chore: fmt
2023-08-22 18:14:07 +02:00
Piotr Osiewicz
ccb9b5d278
Query char_kind for completion triggers.
...
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com >
2023-08-22 18:12:05 +02:00
Joseph T. Lyons
d3c7f03fc4
Add default bindings for new file and directory ( #2877 )
...
Release Notes:
- Added default key bindings for `NewFile` and `NewDirectory` in the
project panel (bound to `cmd-n` and `alt-cmd-n`, respectively).
2023-08-22 11:48:02 -04:00
Joseph T. Lyons
ebcb395f1f
Add default bindings for new file and directory
2023-08-22 11:33:40 -04:00
Nathan Sobo
3921278319
Add more style helpers
2023-08-22 09:16:05 -06:00
Nathan Sobo
53679ce045
Checkpoint
2023-08-22 09:07:45 -06:00
KCaverly
328b7e523c
reorganized to stop the race
2023-08-22 15:01:21 +02:00
KCaverly
aabdfa210f
working on initialization + index breakup
2023-08-22 14:45:27 +02:00
Antonio Scandurra
69b6967838
Integrate the new diff algorithm into the modal assistant
2023-08-22 13:59:45 +02:00
Antonio Scandurra
1ae5a909cd
Start on a custom diff implementation
2023-08-22 12:07:41 +02:00
KCaverly
ced2b2aec3
reworked ProjectState to include additional context
2023-08-22 11:58:48 +02:00
Piotr Osiewicz
d27cebd977
Z 2819 ( #2872 )
...
This PR adds new config option to language config called
`word_boundaries` that controls which characters should be recognised as
word boundary for a given language. This will improve our UX for
languages such as PHP and Tailwind.
Release Notes:
- Improved completions for PHP
[#1820 ](https://github.com/zed-industries/community/issues/1820 )
---------
Co-authored-by: Julia Risley <julia@zed.dev >
2023-08-22 10:35:20 +02:00
Joseph T. Lyons
a836f9c23d
Add a default_open_ai_model setting for the assistant ( #2876 )
...
[This PR has been sitting around for a
bit](https://github.com/zed-industries/zed/pull/2845 ). I received a bit
of mixed opinions from the team on how this setting should work, if it
should use the full model names or some simpler form of it, etc. I went
ahead and made the decision to do the following:
- Use the full model names in settings - ex: `gpt-4-0613`
- Default to `gpt-4-0613` when no setting is present
- Save the full model names in the conversation history files (this is
how it was prior) - ex: `gpt-4-0613`
- Display the shortened model names in the assistant - ex: `gpt-4`
- Not worry about adding an option to add custom models (can add in a
follow-up PR)
- Not query what models are available to the user via their api key (can
add in a follow-up PR)
Release Notes:
- Added a `default_open_ai_model` setting for the assistant (defaults to
`gpt-4-0613`).
---------
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-22 02:55:27 -04:00
Antonio Scandurra
5453553cfa
WIP
2023-08-22 08:16:22 +02:00
Conrad Irwin
168a213a44
Add test for word characters in vim
2023-08-21 22:37:14 -06:00
Conrad Irwin
14fa996cdc
Add # and $ for js
2023-08-21 22:36:58 -06:00
Piotr Osiewicz
cfecbc5522
Start moving tests
2023-08-22 01:06:06 +02:00
Piotr Osiewicz
42b0c5dfdd
Remove comment;for real now
2023-08-22 01:04:55 +02:00
Piotr Osiewicz
bca2d02a61
Revert "Remove dead comment"
...
This reverts commit 046759a366 .
2023-08-22 01:04:15 +02:00
Piotr Osiewicz
344a09a4f8
Rename word_boundaries to word_characters
2023-08-22 01:02:25 +02:00
Piotr Osiewicz
046759a366
Remove dead comment
2023-08-22 01:01:27 +02:00
Piotr Osiewicz
94cf1c3336
Use gpui_platform in test_support
2023-08-22 00:50:05 +02:00
Piotr Osiewicz
f3b76e0571
Add gpui_platform crate for a simple dispatch to implementation for current platform
2023-08-22 00:37:19 +02:00
Piotr Osiewicz
b4cba64fd6
Start fixing up platform tests
2023-08-22 00:30:52 +02:00
Nathan Sobo
ff7b25c538
Checkpoint
2023-08-21 16:14:59 -06:00
Piotr Osiewicz
7516e91a56
Extract gpui_mac out of gpui
2023-08-21 22:29:49 +02:00
Joseph T. Lyons
3a13795021
Add channel id to call events ( #2873 )
...
Release Notes:
- N/A
2023-08-21 14:11:35 -04:00
Joseph T. Lyons
f66e6863fa
Add channel id to call events
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-08-21 13:50:04 -04:00
Piotr Osiewicz
6137d88a54
Merge branch 'main' into Z-2819
2023-08-21 17:41:27 +02:00
Piotr Osiewicz
00caad2f17
..and use it in PHP language config
2023-08-21 17:41:05 +02:00
Piotr Osiewicz
ab5bd0ac5a
Use new char_kind (parameterized by language)
2023-08-21 17:39:38 +02:00
Piotr Osiewicz
3e8522b5f2
WIP: Saved state from Friday.
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-08-21 17:09:03 +02:00
KCaverly
3d89cd10a4
added sha1 encoding for each document
2023-08-21 16:35:57 +02:00
Antonio Scandurra
5b9d48d723
Avoid diffing when the length is too small
2023-08-21 15:53:43 +02:00
Antonio Scandurra
42f02eb4e7
Incrementally diff input coming from GPT
2023-08-21 15:13:26 +02:00
Kyle Caverly
bbe6d3b261
Semantic index rough edges ( #2871 )
...
Small PR aimed at improving a few edge cases for semantic indexing large
projects.
Release Notes (Preview-only).
- Batched large files with a number of documents greater than
EMBEDDINGS_BATCH_SIZE.
- Ensured that the job handle counting mechanism is consistent with
inner file batching.
- Updated tab content names for semantic search, to match text/regex
searches.
2023-08-21 13:43:08 +02:00
Piotr Osiewicz
c68b518aec
chore: fix compiler warning
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-21 13:31:45 +02:00
Piotr Osiewicz
67a48ec106
project_search: use search history's current entry as a tab name.
...
Previously the tab name for Semantic Search was not updated, as we didn't have an active query to go off of
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-21 13:30:32 +02:00
Piotr Osiewicz
61041b0cd1
Do not attempt to reindex a file if previous attempts have failed.
...
Add doc comment to JobHandle
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-21 13:23:11 +02:00
Piotr Osiewicz
1a88444f2f
Increment job counter on JobClient::new
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-21 13:00:56 +02:00
KCaverly
def215af9f
update job handle to ensure file count is consistent
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-21 12:47:43 +02:00
Piotr Osiewicz
267c0b9a3f
chore: Update Cargo.lock following rodio PR ( #2870 )
...
That's merely a follow-up to a previous PR.
Release Notes:
- N/A
2023-08-21 11:33:06 +02:00
KCaverly
1cae4758cc
manage for edge case in which file documents are larger than the allowable limit
2023-08-21 11:29:45 +02:00
Piotr Osiewicz
9ea0ed3e95
chore: remove unused features from rodio crate. ( #2869 )
...
This reduces our dep count by 1% at the expense of not supporting
playback of .flac, .mp3 and .vorbis formats. We only use .wav anyways.
Release Notes:
- N/A
2023-08-21 11:07:31 +02:00
Nathan Sobo
f4d8763d2b
WIP
2023-08-19 23:16:20 -06:00
Nathan Sobo
6663d3f8eb
Checkpoint
2023-08-19 22:33:28 -06:00
Nathan Sobo
afff46b335
Checkpoint
2023-08-19 21:24:28 -06:00
Nathan Sobo
2c6f692c56
Checkpoint
2023-08-19 20:29:55 -06:00
Nathan Sobo
0747131bd4
Compiling checkpoint
2023-08-19 19:51:22 -06:00
Mikayla
bfd3e53dcd
Implement component test page
2023-08-19 16:29:24 -07:00
Mikayla
e946b0a2ec
Finish building out adapters and names
...
Document core traits
Add start for a component storybook
2023-08-19 14:40:05 -07:00
Mikayla
bd3ab82dac
Add disclosable components into channels
...
Rename components to more closely match their purpose
2023-08-19 05:18:53 -07:00
Mikayla Maki
b7e03507c2
Update components.rs
2023-08-19 04:30:49 -07:00
Nathan Sobo
76993f6b57
WIP: Trying to find a composable approach to styling that plays nice with layout engine
2023-08-18 20:08:29 -06:00
Mikayla
2d37128693
Actually get it compiling, omg
2023-08-18 19:02:27 -07:00
Mikayla
3178adefde
WIP: Add disclosable channels
2023-08-18 18:11:05 -07:00
Mikayla Maki
29c339e3b4
Revert "Remove semantic search UI" ( #2865 )
...
This reverts commit c0f042b39a , where I
deleted the semantic-search related UI code.
Apologies to @KCaverly for the misunderstanding
Release Notes:
- N/A
2023-08-18 18:05:19 -07:00
Mikayla Maki
15f91f38f6
Remove potential osascript hijacking attack ( #2867 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2818/security-vulnerability-dylib-injection
Release Notes:
- Fixed a potential local code-injection if a user installs the Zed CLI
for the first time with a hijacked `osascript` in their path.
2023-08-18 18:00:39 -07:00
Mikayla
d22caf5a19
Fix erorr in revert
2023-08-18 17:59:06 -07:00
Mikayla
5a356a4710
Remove potential osascript hijacking
2023-08-18 17:40:08 -07:00
Max Brunsfeld
ef9686c988
Reorganize the structure of the collab crate's db module ( #2866 )
...
This PR just moves some code around, with the goal of making it easier
to find things in the `collab::db` module. That has become a large
module. Previously, most of the logic lived in one giant `impl Database`
item in `db.rs`.
I broke up this `impl` into several different `impl` blocks, grouped by
topic, each in a different file in a folder called `queries`.
I also pulled out the macro-generated id types into their own file,
moved the `TestDb` struct into its own file, and moved the `sea_orm`
entity declarations into a folder called `tables`.
New folder structure:
```
db
├── db_tests.rs
├── ids.rs
├── queries
│ ├── access_tokens.rs
│ ├── channels.rs
│ ├── contacts.rs
│ ├── projects.rs
│ ├── rooms.rs
│ ├── servers.rs
│ ├── signups.rs
│ └── users.rs
├── queries.rs
├── tables
│ ├── access_token.rs
│ ├── channel.rs
│ ├── channel_member.rs
│ ├── channel_path.rs
│ ├── contact.rs
│ ├── follower.rs
│ ├── language_server.rs
│ ├── project.rs
│ ├── project_collaborator.rs
│ ├── room.rs
│ ├── room_participant.rs
│ ├── server.rs
│ ├── signup.rs
│ ├── user.rs
│ ├── worktree.rs
│ ├── worktree_diagnostic_summary.rs
│ ├── worktree_entry.rs
│ ├── worktree_repository.rs
│ ├── worktree_repository_statuses.rs
│ └── worktree_settings_file.rs
├── tables.rs
└── test_db.rs
```
Release Notes:
- N/A
2023-08-18 17:29:15 -07:00
Max Brunsfeld
b35aaf144b
Break up Database impl into multiple files, organized by topic
2023-08-18 17:03:34 -07:00
Max Brunsfeld
e964137d79
Reorganize source files of collab::db
...
* Move all sea_orm tables into a 'tables' module
* Move TestDb into its own file
* Move id types into their own module
2023-08-18 16:23:33 -07:00
Mikayla
48553d7c8f
Revert "Remove semantic search UI"
...
This reverts commit c0f042b39a .
2023-08-18 16:18:28 -07:00
Nathan Sobo
eec39dc23c
WIP
2023-08-18 17:14:29 -06:00
Mikayla Maki
cb55204e22
Move the collab panel to the left by default ( #2864 )
...
Increase the indent size on channels
Switch font UI mono
Release Notes:
- Switch the collaboration panel font to Zed's sans-mono (preview only)
- Switch the default dock side to the left (preview-only)
- Increase the indent size on the channels panel (preview-only)
2023-08-18 16:06:10 -07:00
Mikayla Maki
64cbfe088a
Update bump-version.sh
2023-08-18 15:52:21 -07:00
Mikayla Maki
24fbea1557
Update collab_panel.rs
2023-08-18 15:34:35 -07:00
Mikayla
4c15f26eba
Finish rename correctly
2023-08-18 15:26:36 -07:00
Mikayla
4c3227ce2a
Fix example compile erorr
2023-08-18 15:17:24 -07:00
Mikayla
84f35d4e6b
Add pub
2023-08-18 15:12:56 -07:00
Mikayla
8ef671d7a1
Move the collab panel to the left by default
...
Increase the indent size on channels
Switch font UI mono
2023-08-18 15:04:22 -07:00
Conrad Irwin
f0ebbd01e6
Don't show vim mode when disabled ( #2863 )
...
Fixes vim's mode indicator showing up when vim is disabled.
2023-08-18 16:00:46 -06:00
Conrad Irwin
3ab3042e95
Don't show vim mode when disabled
2023-08-18 15:50:34 -06:00
Max Brunsfeld
e48bb1853c
Fix failure to detect string scope, and disable quote autoclose in Rust ( #2862 )
...
This regressed in https://github.com/zed-industries/zed/pull/2723
Fixes https://github.com/zed-industries/community/issues/684
Fixes
https://linear.app/zed-industries/issue/Z-1516/avoid-double-quotes-when-closing-a-string
Release Notes:
- Fixed a bug where auto-closing quotation marks were inserted
incorrectly in Rust.
2023-08-18 14:39:44 -07:00
Max Brunsfeld
1c46749ad7
Fix regression in Buffer::language_scope_at
...
Co-authored-by: Julia <julia@zed.dev >
2023-08-18 12:58:09 -07:00
Joseph T. Lyons
98186fc016
Add more file icons ( #2861 )
...
Release Notes:
- Added file icons for Python and Elixir
2023-08-18 15:27:04 -04:00
Max Brunsfeld
08429169e2
Upgrade Tree-sitter for error recovery bug fix ( #2860 )
...
Bumps Tree-sitter for
https://github.com/tree-sitter/tree-sitter/pull/2526 .
Release Notes:
- Fixed a bug where small syntax errors would mess up syntax
highlighting more than necessary when editing certain languages, like
Scheme and PHP.
2023-08-18 12:01:53 -07:00
Joseph T. Lyons
e26d6d7a49
Add elixir icons
2023-08-18 14:54:53 -04:00
Conrad Irwin
9dab6b6a20
vim: Fix cursor adjustment on scroll ( #2859 )
...
Fixes: zed-industries/community#1929
Also preserves visual modes correctly.
[[PR Description]]
Release Notes:
- vim: Fix scroll offset on `ctrl-{e,y,u,b}`
([#1929 ](https://github.com/zed-industries/community/issues/1929 )).
2023-08-18 12:32:47 -06:00
Max Brunsfeld
09fcacdfd1
Upgrade Tree-sitter for error recovery bug fix
2023-08-18 11:31:40 -07:00
Conrad Irwin
93461d366c
Fix <Enter> to go to non-whitespace character
...
Fixes : zed-industries/community#831
2023-08-18 12:24:39 -06:00
Joseph T. Lyons
ab73375a61
Alphabetize list
2023-08-18 14:07:55 -04:00
Joseph T. Lyons
ffdca77124
Add python file icon
2023-08-18 14:07:17 -04:00
Conrad Irwin
5029587e3b
Add ctrl-q as an alias for ctrl-v
...
Fixes : zed-industries/community#871
2023-08-18 11:39:48 -06:00
Conrad Irwin
e3c0e93e46
Fix cursor adjustment on scroll
...
Fixes : zed-industries/community#1929
Also preserves visual modes correctly.
2023-08-18 11:23:43 -06:00
Antonio Scandurra
3ad7f528cb
Start on a refactoring assistant
2023-08-18 17:58:22 +02:00
Conrad Irwin
d1aa82bb48
vim visual block ( #2849 )
...
Release notes:
- vim: add Visual Block mode
([#984 ](https://github.com/zed-industries/community/issues/984 )),
([#1415 ](https://github.com/zed-industries/community/issues/1415 )).
- vim: add support for `a<object>` and `i<object>` in visual modes
- vim: fix scroll shortcuts (`ctrl-{f,b,d,u,e,y}`) in visual modes
- allow `shift-enter` to type a newline.
2023-08-18 09:55:40 -06:00
Piotr Osiewicz
273a8b4368
editor: Recognize '$' as a Word character.
...
This fixes PHP variable completion. When we were querying for completions, PHP LS returned proper matches for variables which we filtered out as our query did not include a `$` character.
Z-2819
2023-08-18 17:25:20 +02:00
Kirill Bulatov
760c4918cb
Respect completion resolve server capabilities ( #2858 )
...
Only query for additional edits if the server supports it
Release Notes:
- N/A
2023-08-18 17:50:37 +03:00
Kirill Bulatov
269dad5a9c
Respect completion resolve server capabilities
...
Only query for additional edits if the server supports it
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-08-18 16:55:47 +03:00
Kyle Caverly
8451e7eb7e
Project search design ( #2834 )
...
TODO before merging:
- [x] Re-run project search when options (case, word, regex) change
/cc @PixelJanitor
Release Notes:
- Revamped project & buffer search UI.
- Added "Cycle Mode" command for search
2023-08-18 14:38:01 +02:00
Nathan Sobo
b910c85f7f
Still need to wire up MouseMove with the new regions
2023-08-18 02:23:06 -06:00
Nathan Sobo
3709eff34b
Compiling
2023-08-18 01:59:21 -06:00
Nathan Sobo
9b74dc196e
Introduce Refinement trait and derive macro
2023-08-18 01:03:46 -06:00
Mikayla
66e94aa199
Make search re-query eagerly when changing modes
...
Fix a bug where focus could be lost when clearing the search results
2023-08-17 17:53:58 -07:00
Nathan Sobo
19ccb19c96
Compiling
2023-08-17 18:37:54 -06:00
Mikayla
c0f042b39a
Remove semantic search UI
2023-08-17 17:28:09 -07:00
Mikayla
21fa6090b8
Add action button component for rendering the search options
2023-08-17 17:28:09 -07:00
Max Brunsfeld
802911d742
Fix AppKit screen coordinate conversion leading to wrong window bounds ( #2856 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1510/join-project-notification-takes-up-full-screen-on-a-second-monitor
There were multiple mistakes in the positioning of Zed's notification
windows, one of which lead to the notifications taking up the full
screen on secondary displays 😱 .
* Wrong sign for the vertical padding (moving the window *upward*
instead of downward)
* Using the screen's full frame instead of its "visible frame" (which
accounts for app menu bar)
* Wrong coordinate translation between our coordinates and AppKit's
coordinates. Regardless of which display a given window appears on, the
coordinate translation needs to use the height of the *main* display.
Release Notes:
- Fixed a bug where call notifications were accidentally full-screen on
all displays except the main display.
2023-08-17 16:24:46 -07:00
Conrad Irwin
b0ba0f8851
Fix visual objects
...
Adds 'a'/'i' in visual mode
2023-08-17 17:13:23 -06:00
Max Brunsfeld
cd2ef784ea
Translate coordinates using the primary screen not the main screen
2023-08-17 16:12:52 -07:00
Max Brunsfeld
6eba0ef630
Return to master branch of alacritty
2023-08-17 15:31:27 -07:00
Mikayla
8630557ece
Add action button component for rendering the search options
2023-08-17 15:30:40 -07:00
Max Brunsfeld
d9ef987b04
Fix AppKit screen coordinate conversion leading to wrong window bounds
2023-08-17 15:23:28 -07:00
Conrad Irwin
d4276acab8
Give up on monospace indicator
...
Changing mode almost always introduces the (1 selected) text in
the status bar, so we may as well also keep the --'s for block and line
mode.
2023-08-17 16:04:55 -06:00
Conrad Irwin
243d1664e5
shift-enter should also give a newline
...
(reported as vim feedback, but really true of the editor too)
2023-08-17 16:01:19 -06:00
Conrad Irwin
3c483d85f7
Scrolling should work in visual mode
2023-08-17 15:58:10 -06:00
Conrad Irwin
eb0b2e60bb
Preserve line mode selection on undo
...
This diverges from vim's behaviour (which collapses the
cursor to a single point on undo).
2023-08-17 15:40:27 -06:00
Conrad Irwin
59d1a5632f
Fix edge-cases in visual block insert
2023-08-17 15:16:26 -06:00
Conrad Irwin
3514816ece
Store some vim state per-editor
...
This fixes a bug where opening and closing command would reset your
selection incorrectly.
2023-08-17 14:09:47 -06:00
Nathan Sobo
24d19deb0b
Compiling checkpoint
2023-08-17 14:05:18 -06:00
Nathan Sobo
f3a275d339
Revert "Add a proc macro for deriving override structs with optional fields"
...
This reverts commit ab9356e9d8 .
2023-08-17 13:48:46 -06:00
Conrad Irwin
d308c91020
Add I and A in visual block mode
2023-08-17 11:21:58 -06:00
Nathan Sobo
ab9356e9d8
Add a proc macro for deriving override structs with optional fields
2023-08-17 09:39:23 -06:00
Nate Butler
f451e3423d
Fix missing border on tab bar navigation arrows
2023-08-17 11:00:22 -04:00
Piotr Osiewicz
1bd7d7077a
Move nav buttons to the left hand side of a tab bar.
...
Co-authored-by: Nate <nate@zed.dev >
2023-08-17 16:45:11 +02:00
Nathan Sobo
b95b2af3e0
Store generic mouse regions on window that contain their event type id
2023-08-17 08:37:55 -06:00
KCaverly
b7dd12e53e
ensured search results are cleared appropriately while cycling modes
2023-08-17 11:11:09 +01:00
Mikayla
afebe3faf8
Merge branch 'main' into project_search_design
2023-08-17 01:56:05 -07:00
Mikayla Maki
6d3518cb50
Collab panel touch ups ( #2855 )
...
This will also fix the bug that @JosephTLyons observed where accepting a
channel invite would not show sub channels.
Release Notes:
- Offline section is now collapsed by default
- Manage members now shows full list
- Dragging of docks now follows the mouse exactly, and double clicks
reset size. (https://github.com/zed-industries/community/issues/1816 )
2023-08-17 01:09:01 -07:00
Mikayla
75679291a9
Add fix for lost channel update bug
2023-08-17 00:56:21 -07:00
Conrad Irwin
7598030102
Tidy-up
2023-08-16 22:29:28 -06:00
Nathan Sobo
812d3f6af6
Get basic mouse_down and mouse_up working
2023-08-16 22:21:27 -06:00
Mikayla
5bc481112e
Add test for lost channel update
2023-08-16 20:05:21 -07:00
Nate Butler
e0cafffbc8
Fix collab indicator colors ( #2854 )
...
[[PR Description]]
Release Notes:
- N/A
or
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/ <public_issue_number_if_exists>)).
If the release notes are only intended for a specific release channel
only, add `(<release_channel>-only)` to the end of the release note
line.
These will be removed by the person making the release.
2023-08-16 22:59:55 -04:00
Mikayla
05becc75d1
Collapse offline section by default
2023-08-16 19:51:41 -07:00
Nate Butler
8b1322745d
Fix collab indicators
2023-08-16 22:50:02 -04:00
Mikayla
2f16147055
Fix dock resizing
2023-08-16 19:47:54 -07:00
Mikayla
3074455386
WIP
2023-08-16 16:56:00 -07:00
Max Brunsfeld
fa0ddfa15d
Use our fork of alacritty to avoid winit dependency ( #2853 )
...
Bumps `alacritty_terminal` for
https://github.com/alacritty/alacritty/pull/7149
2023-08-16 14:54:55 -07:00
Max Brunsfeld
a5a212e1da
Use our fork of alacritty to avoid winit dependency
2023-08-16 14:31:38 -07:00
Kirill Bulatov
988ea3c16b
Add editor::ToggleInlayHints command and a bar to toggle editor-related items ( #2839 )
...
Closes
https://linear.app/zed-industries/issue/Z-2735/make-inlay-hints-discoverable
Deals with https://github.com/zed-industries/community/issues/1764
Adds `editor::ToggleInlayHints` command and a new panel with two
buttons for
* toggling hints on/off for every editor separately (overrides settings)
Would benefit from a new icon.
* toggling buffer search on/off
Does not have a keybinding shown in its tooltip, that is a separate
issue with the way `KeystrokeLabel` gets these for panels not in the
view directly.
Release Notes:
- Adds `editor::ToggleInlayHints` command and a bar to toggle
editor-related items
2023-08-16 23:50:54 +03:00
Kirill Bulatov
7334bdccbf
Better multibuffer tests
2023-08-16 23:38:11 +03:00
Nate Butler
ef86c08174
Use the ghost variant for a flat button style in the toolbar
2023-08-16 23:38:11 +03:00
Nate Butler
5bb6a14d42
Update inlay_hint icon
2023-08-16 23:38:11 +03:00
Kirill Bulatov
7fcf9022b4
Fix rebase issues
2023-08-16 23:38:11 +03:00
Nate Butler
3ed50708ac
Add inlay_hint icon, update search icon, update tooltips
2023-08-16 23:38:11 +03:00
Kirill Bulatov
f9131f657e
Use InlayHint instead of Inlay where appropriate
2023-08-16 23:38:11 +03:00
Kirill Bulatov
1938fd85e8
Do not leak pane handles
2023-08-16 23:38:11 +03:00
Kirill Bulatov
9c6135f47a
Test hints toggle
2023-08-16 23:38:11 +03:00
Kirill Bulatov
8926c23bdb
Extract quick_action_bar into its own crate
2023-08-16 23:38:11 +03:00
Kirill Bulatov
0f650acc23
Repaint inlays icon on inlays cache disabling/enabling
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-08-16 23:38:11 +03:00
Kirill Bulatov
0b93e490a5
Improve toggle UI, fix inlays update speed
2023-08-16 23:38:11 +03:00
Kirill Bulatov
6a326c1bd8
Toggle buffer search via quick actions
2023-08-16 23:38:11 +03:00
Kirill Bulatov
5c3d563f0f
Draft quick actions bar
2023-08-16 23:38:11 +03:00
Nathan Sobo
187d78011c
WIP
2023-08-16 13:52:42 -06:00
Nathan Sobo
f1aafab61d
Get text rendering
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-08-16 12:50:35 -06:00
Joseph T. Lyons
07675e3c55
v0.101.x dev
2023-08-16 14:22:54 -04:00
Max Brunsfeld
442ec606d0
collab 0.17.0
2023-08-16 11:05:08 -07:00
Max Brunsfeld
4ea8b8292c
Introduce channels and move collab popover contents to a collaboration panel ( #2828 )
...
### Summary
This PR introduces channels: a new way of starting collaboration
sessions. You can create channels and invite others to join them. You
can then hold a call in a channel, where any member of the channel is
free to join the call without needing to be invited.
Channels are displayed in a new panel called the collaboration panel,
which now also contains the contacts list, and the current call. The
collaboration popover has been removed from the titlebar.

For now, the channels functionality will only be revealed to staff, so
the public-facing change is just the move from the popover to the panel.
### To-do
* User-facing UI
* [x] signed-out state for collab panel
* [x] new icon for collab panel
* [x] for now, channels section only appears for zed staff
* [x] current call section styling
(https://zed-industries.slack.com/archives/C05CJUNF2BU/p1691189389988239?thread_ts=1691189120.403009&cid=C05CJUNF2BU )
* [x] Channel members
* Channels
* [x] style channel name editor
* [x] decide on a special "empty state" for the panel, when user has no
contacts
* [x] ensure channels are sorted in a consistent way (expose channel id
paths to client)
* [x] Figure out layered panels UX
* [x] Change add contacts to be the same kind of tabbed modal
* [x] race condition between channel updates and user fetches
(`ChannelStore::handle_update_contacts`)
* [x] race condition between joining channels and channel update
messages `collab::rpc::channel_updated`)
* [x] don't display mic as muted when microphone share is pending upon
first joining call
Release Notes:
- Moved the collaboration dropdown into its own panel.
- Added settings for disabling the AI assistant panel button.
- Switch to lazily initializing audio output sources
(https://github.com/zed-industries/community/issues/1840 ,
https://github.com/zed-industries/community/issues/1919 )
2023-08-16 11:03:53 -07:00
Nate Butler
925e09e012
Update collab panel empty state to match project panel
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-08-16 13:56:11 -04:00
Nate Butler
43127384c6
Update modal icon styles
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-08-16 13:48:12 -04:00
Conrad Irwin
7f06191c9f
Disable autoindent in visual block insert mode
2023-08-16 10:44:59 -06:00
Nate Butler
6c15636ccc
Style cleanup for channels panel
2023-08-16 12:38:44 -04:00
KCaverly
c99b530968
remove kill search, and restart search immediately upon cycle mode
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-16 16:13:21 +01:00
KCaverly
aeda5d9842
fix semantic search panic which is created via incompatible build_search_query path
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-16 15:50:54 +01:00
KCaverly
6e3e61ec95
removed commented out code
2023-08-16 14:01:53 +01:00
KCaverly
2a7df106e1
adjusted icon sizes downwards
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-16 14:01:06 +01:00
KCaverly
6f78a1633d
fix editor height in buffer search, but the dancing is back
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-16 13:51:41 +01:00
Kirill Bulatov
1601892f35
Focus terminal view on mouse click in terminal ( #2852 )
...
Before, terminal view focused the parent (pane) instead and, if
terminal's search bar was open and focused, pane transferred the focus
back
Release Notes:
- Fixed terminal search focus not switching to terminal on mouse click
inside
2023-08-16 15:25:17 +03:00
Nathan Sobo
fea987b459
WIP
2023-08-16 06:22:47 -06:00
Kirill Bulatov
80c779b95e
Focus terminal view on mouse click in terminal
...
Before, terminal view focused the parent (pane) instead and, if
terminal's search bar was open and focused, pane transferred the focus
back
2023-08-16 15:16:20 +03:00
KCaverly
a59535efa1
remove redundant and unneeded styling
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-16 12:55:32 +01:00
KCaverly
d727ba18f2
Merge branch 'main' of github.com:zed-industries/zed into project_search_design
2023-08-16 12:43:04 +01:00
KCaverly
9bf227b884
remove regex keymap, and made spacing consistent between search objects
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-16 12:17:59 +01:00
KCaverly
11ecb7b604
reorganize search bar, enable filters and disable select all during invalid states
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-16 11:35:09 +01:00
Kirill Bulatov
139cbbfd3a
Move gpui derives tests into gpui crate to avoid dependency cycles ( #2851 )
...
`cargo run` on Zed project leads to rust-analyzer evantually emitting
`[ERROR project_model::workspace] cyclic deps:
gpui_macros(Idx::<CrateData>(269)) -> gpui(Idx::<CrateData>(264)),
alternative path: gpui(Idx::<CrateData>(264)) ->
gpui_macros(Idx::<CrateData>(269))`
error after loading the project.
The PR fixes this by moving away the test to the "root" project.
Release Notes:
- N/A
2023-08-16 10:41:12 +03:00
Kirill Bulatov
1c4be24fb7
Move gpui derives tests into gpui crate to avoid dependency cycles
...
`cargo run` on Zed project leads to rust-analyzer evantually emitting
`[ERROR project_model::workspace] cyclic deps:
gpui_macros(Idx::<CrateData>(269)) -> gpui(Idx::<CrateData>(264)),
alternative path: gpui(Idx::<CrateData>(264)) ->
gpui_macros(Idx::<CrateData>(269))`
error after loading the project.
The PR fixes this by moving away the test to the "root" project.
2023-08-16 10:19:20 +03:00
Mikayla
0524abf114
Lazily initialize and destroy the audio handle state on call initiation and end
2023-08-15 23:19:11 -07:00
Nathan Sobo
a8ecc1a643
Add support for a measure function to the layout engine facade
2023-08-15 22:02:56 -06:00
Nathan Sobo
4efc46c763
Add derive macro now new elements
2023-08-15 21:04:48 -06:00
Nathan Sobo
77bc682a69
Render a component
2023-08-15 19:46:07 -06:00
Nathan Sobo
65a5c54a2c
Compiling checkpoint
2023-08-15 19:29:57 -06:00
Max Brunsfeld
706227701e
Keep collab panel focused after deleting a channel
2023-08-15 16:14:24 -07:00
Mikayla Maki
facb942156
Add component traits to GPUI ( #2850 )
...
Release Notes:
- N/A
2023-08-15 15:53:12 -07:00
Mikayla
7d3ffae47d
move component into gpui
2023-08-15 15:44:59 -07:00
Nate Butler
a56747af8c
Update assistant status bar icon
2023-08-15 18:36:30 -04:00
Nate Butler
28649fb71d
Update channel context menu
2023-08-15 18:36:23 -04:00
Max Brunsfeld
3623a9ca5e
Simplify Component implementation
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-15 15:26:02 -07:00
KCaverly
32bec2e401
left align buffer search with new structure
2023-08-15 23:18:03 +01:00
Conrad Irwin
1b4dd49b1d
Vim visual block mode
...
This isn't quite an exact emulation, as instead of using one selection
that is magically in "column mode", we emulate it with a bunch of zed
multi-selections (one per line).
I think this is better, as it requires fewer changes to the codebase,
and lets you see the impact of any changes immediately on all lines.
Fixes : zed-industries/community#984
2023-08-15 16:00:50 -06:00
Max Brunsfeld
1ffde7bddc
Implement calling contacts into your current channel
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-15 14:56:54 -07:00
Kirill Bulatov
2670e2c9ec
Support editor::SelectAll in Terminal ( #2848 )
...

Allows to use `editor::SelectAll`(`cmd-a` by default) in Terminal to
select all text in it, for future copying.
Currently, does not try to be smart and trim the selected whitespaces
after the last prompt, and copies them too.
Release Notes:
- Support `editor::SelectAll` in Terminal
2023-08-15 23:59:26 +03:00
Joseph T. Lyons
88e094c6e2
Associate additional file extensions with known languages ( #2847 )
...
Going to do these in batches. Here is the first one.
Release Notes:
- Associated additional file extensions with known languages
(([#633 ](https://github.com/zed-industries/community/issues/633 )),
([#1822 ](https://github.com/zed-industries/community/issues/1822 ))).
- C++: `cxx`, `hxx`, `inl`
- JavaScript: `cjs`
- Python: `mpy`
- TypeScript: `cts`, `d.cts`, `d.mts`, `mts`
2023-08-15 16:46:42 -04:00
Kirill Bulatov
de69f08c10
Support editor::SelectAll in Terminal
2023-08-15 23:43:32 +03:00
Max Brunsfeld
943aeb8c09
Run until parked when setting editor's state via EditorTestContext
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-15 13:42:54 -07:00
Joseph T. Lyons
d6ca0a1f24
Associate extensions with language
2023-08-15 16:33:02 -04:00
Nate Butler
13cf3ada39
Update checked icon
2023-08-15 16:29:01 -04:00
Max Brunsfeld
ddf3642d47
Avoid flicker when moving between channels
2023-08-15 13:18:56 -07:00
Max Brunsfeld
46928fa871
Reword channel-creation tooltips
2023-08-15 13:08:44 -07:00
Nate Butler
9d60e550be
Additional status bar styles
2023-08-15 15:32:14 -04:00
Mikayla
d13cedb248
seperate out channel styles in theme
2023-08-15 12:12:30 -07:00
KCaverly
1e8a7c7caa
refactor buffer_search to reduce redundancy and simplying height management
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-08-15 20:04:14 +01:00
Mikayla
d05e8852d3
Add dismiss on escape
2023-08-15 11:02:18 -07:00
Mikayla
d95b036fde
Fix cursor style
...
co-authored-by: Nate <nate@zed.dev >
2023-08-15 10:58:31 -07:00
Mikayla
e36dfa0946
Add active styling
2023-08-15 10:53:30 -07:00
Mikayla
9e99b74fce
Add the channel name into the current call
2023-08-15 10:45:36 -07:00
Max Brunsfeld
fafc10d57c
Merge branch 'main' into collab-panel
2023-08-15 09:09:50 -07:00
Conrad Irwin
1cc0798aea
Add a VisualBlock mode
...
Instead of trying to extend the Mode::Visual special case, just split
out into three different modes.
2023-08-15 10:00:45 -06:00
Nathan Sobo
e7489bd4c9
Compiling checkpoint
2023-08-15 09:33:59 -06:00
Nathan Sobo
0fe457020b
WIP
2023-08-15 09:26:16 -06:00
Conrad Irwin
404b1aa65a
Fix vim selection to include entire range ( #2787 )
...
Update vim mode to have vim selection and editor selections match.
Before this we had to adjust between vim selections and real selections
when making changes; now we have to adjust when making selections.
Release Notes:
- vim: Ensure editor selection matches the vim selection
([#1796 ](https://github.com/zed-industries/community/issues/1796 )).
- vim: Fix `s` in visual line mode
- vim: Add `o` and `shift-o` to toggle direction of visual selection
- vim: Fix `v` and `shift-v` to toggle back to normal mode
- vim: Fix block selections like `vi}` to contain correct whitespace
2023-08-15 08:36:17 -06:00
Conrad Irwin
1e3f468fc7
Fix vim escape in normal mode ( #2844 )
...
Fixes: zed-industries/community#1857
- vim: Fix escape in normal mode
([#1857 ](https://github.com/zed-industries/community/issues/1857 )).
2023-08-15 08:35:49 -06:00
KCaverly
695e6d2f2e
fix spacing on editor magnifying glass icon
2023-08-15 15:05:39 +01:00
Mikayla
111e17b220
Merge branch 'main' into collab-panel
2023-08-15 03:25:45 -07:00
Mikayla Maki
22da42fc69
Add components example ( #2846 )
...
This PR is a continuation of the components UI exploration I've been
doing. It adds an example to the GPUI examples page and totally
restructures the generics on our MouseEventHandler.
Release Note:
- N/A
2023-08-15 03:17:50 -07:00
Mikayla
e5eed29c72
Add components example
...
Re-arrange generics on mouse event handler
Add TypeTag struct for dynamically tagged components
2023-08-15 03:06:43 -07:00
Max Brunsfeld
cbf497bc12
Fix race condition when UpdateChannel message is received while fetching participants for previous update
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-14 17:36:35 -07:00
Max Brunsfeld
71454ba27c
Limit number of participants shown in channel face piles
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-14 17:11:03 -07:00
Max Brunsfeld
13982fe2f4
Display intended mute status while still connecting to a room
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-14 16:47:26 -07:00
Max Brunsfeld
5af8ee71aa
Fix clicking outside of modals to dismiss them
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-14 16:38:21 -07:00
Max Brunsfeld
d7f21a9155
Ensure channels are sorted alphabetically
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-14 16:27:35 -07:00
Conrad Irwin
1af7425059
Fix vim escape in normal mode
...
Fixes : zed-industries/community#1857
2023-08-14 16:05:41 -06:00
Conrad Irwin
fb90eada70
Merge branch 'main' into vim-visual-selection
2023-08-14 15:29:33 -06:00
Nate Butler
ef73e77d3d
Update some status bar icons and states
2023-08-14 17:15:25 -04:00
Conrad Irwin
5b37cdcb04
Better tests
2023-08-14 15:03:16 -06:00
Nate Butler
b4b044ccbf
Initial modal styles
2023-08-14 17:01:34 -04:00
Nathan Sobo
f9858445b8
Get a 50% colored box rendering
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-08-14 14:46:09 -06:00
Nate Butler
e0d73842d2
Continue panel styles
2023-08-14 16:12:39 -04:00
Kirill Bulatov
64c2043913
Query less inlay hints ( #2842 )
...
Part of
https://linear.app/zed-industries/issue/Z-2750/investigate-performance-of-collaborating-on-large-files-with-inlay
Instead of querying the entire file for hints, query visible editor(s)
range + the areas above and below, of the same height.
Non-invalidating future queries (e.g. scrolling) query only missing
parts of the ranges.
Release Notes:
- Improved LSP resource usage by querying less hints for big files
2023-08-14 23:06:30 +03:00
Kirill Bulatov
54bcef9420
Strip off inlay hint data that should be resolved ( #2843 )
...
Part of
https://linear.app/zed-industries/issue/Z-2750/investigate-performance-of-collaborating-on-large-files-with-inlay
* Declares client capabilities for hint resolution, marking both fields
available for resolution (`textEdits` and `tooltop`) as resolvable.
We do not use these fields anymore, hence can omit resolving them for
now, but LSP servers can omit them during general hint requests.
* Removes `tooltip` and replaces complex `label` with its simple string
counterpart for clients' hint responses from host: both should be
resolved through host later
Release Notes:
- Reduces collab mode clients' inlay hint footprint by enabling hint
data resolution
2023-08-14 23:06:19 +03:00
Nate Butler
f2d46e0ff9
Use new icons in channel panel
2023-08-14 15:57:31 -04:00
Kirill Bulatov
27bf01c3a8
Strip off inlay hints data that should be resolved
2023-08-14 22:50:55 +03:00
Nate Butler
a5534bb30f
Add new icons
2023-08-14 15:50:42 -04:00
Nate Butler
8531cdaff7
Style channels panel items
2023-08-14 15:50:37 -04:00
Nathan Sobo
740b105330
Merge branch 'main' into taffy
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-08-14 13:50:21 -06:00
Nate Butler
4a5b2fa5dc
Add ghost button variants
2023-08-14 15:13:57 -04:00
Max Brunsfeld
3b10ae9310
Add icon before the empty contacts text
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-14 11:57:19 -07:00
Max Brunsfeld
2bb9f7929d
Structure the contact finder more similarly to the channel modal
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-14 11:37:05 -07:00
Mikayla
b6f3dd51a0
Move default collab panel to the right
2023-08-14 10:47:29 -07:00
Mikayla
b07555b6df
Make empty state interactive
2023-08-14 10:34:00 -07:00
Mikayla
fde9653ad8
Add placeholder implementation
2023-08-14 10:24:00 -07:00
Nate Butler
3856137b6e
Add list empty state style
2023-08-14 13:17:57 -04:00
Kirill Bulatov
e0d011e354
Better assert multibuffer edit test results
2023-08-14 20:12:35 +03:00
Kirill Bulatov
4b3273182a
Do not filter out hints to be removed
2023-08-14 19:20:20 +03:00
Kirill Bulatov
336fbb3392
Clip offsets in inlay hint queries
2023-08-14 18:39:30 +03:00
Nathan Sobo
7756497933
Simplify adapter
2023-08-14 09:26:35 -06:00
Piotr Osiewicz
db36a5fe2d
Refactor buffer search UI rendering in a quest to find the meaning of life.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-14 15:27:57 +02:00
Kirill Bulatov
558367dc8b
Optimize query ranges tracking
2023-08-14 16:19:44 +03:00
Piotr Osiewicz
ff4370f88e
buffer: Extract columns to separate objects.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-14 15:14:57 +02:00
Piotr Osiewicz
4aa5df4cda
Extract columns into separate objects.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-14 15:13:17 +02:00
Kirill Bulatov
87e6651ecb
Fix hint tests, add a char boundary bug test
2023-08-14 16:01:02 +03:00
Piotr Osiewicz
f4121b42da
Add more padding to dismiss button.
...
Add a style for mode buttons group margin
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-14 15:01:01 +02:00
Piotr Osiewicz
d17aba4fd3
Fix double borders in mode buttons.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-14 14:43:06 +02:00
Piotr Osiewicz
7314456685
nav_button: Fix double border between nav buttons.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-14 14:33:40 +02:00
Piotr Osiewicz
b72a42ec29
buffer: fix alignment of editor icon.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-14 14:31:14 +02:00
Piotr Osiewicz
9ae28f81c1
Update option buttons text color
2023-08-14 12:35:33 +02:00
Piotr Osiewicz
ae229d4c52
Align "Select all" to the center
2023-08-14 12:31:11 +02:00
Piotr Osiewicz
94ac84a908
Fix borders being cut off in buffer search
2023-08-14 12:28:35 +02:00
Piotr Osiewicz
8bb3bfa6a8
Style buffer modes like project modes
2023-08-14 12:25:59 +02:00
Piotr Osiewicz
1c35db7e97
project_search: style filters button like the rest of the buttons
2023-08-14 12:20:59 +02:00
Piotr Osiewicz
d37ebe7841
Add option_button_height style
2023-08-14 12:10:37 +02:00
Piotr Osiewicz
9121178ba0
project_search: Swap places of case-sens/whole-word
2023-08-14 11:59:42 +02:00
Kirill Bulatov
449c009639
Properly generate ranges to query
2023-08-14 11:25:02 +03:00
Kirill Bulatov
56f89739f8
Do not add duplicate hints to the cache
2023-08-14 11:25:02 +03:00
Kirill Bulatov
0e2a1fc149
Query inlay hints for parts of the file
2023-08-14 11:25:02 +03:00
Kirill Bulatov
708409e06d
Query hints on every scroll
2023-08-14 11:25:02 +03:00
Kirill Bulatov
5d2750e0d4
Hide inlay cache fields
2023-08-14 11:25:02 +03:00
Nathan Sobo
85f35497b6
Compiling checkpoint
2023-08-13 22:39:06 -06:00
Nathan Sobo
7662210776
I think the adapter is ready. Close to pixels.
2023-08-13 22:06:35 -06:00
Nathan Sobo
625e4a1bd0
Introduce new PaintContext and LayoutContext
2023-08-13 21:57:38 -06:00
Nathan Sobo
2d17e9685f
Compiling checkpoint
2023-08-13 21:20:47 -06:00
Nathan Sobo
be7a43c81c
Get taffy style conversion working
2023-08-13 19:47:49 -06:00
Nathan Sobo
52ad48d50b
WIP
2023-08-13 17:29:07 -06:00
Nathan Sobo
473ac5a842
WIP
2023-08-13 02:27:36 -06:00
Nathan Sobo
36b853ac05
WIP
2023-08-13 01:40:10 -06:00
Nathan Sobo
1ef486b227
WIP
2023-08-13 01:40:05 -06:00
Piotr Osiewicz
b586601cab
Style nav buttons
2023-08-13 01:29:35 +02:00
Piotr Osiewicz
e151555542
Style dismiss button.
...
Fix clipping in nav buttons and mode buttons. Add missing borders to outskirts of mode buttons.
2023-08-13 01:06:35 +02:00
Piotr Osiewicz
c6425b36da
chore: remove redundant mut
2023-08-12 22:20:22 +02:00
Piotr Osiewicz
94f1d8281a
Remove buttonside, use new corner_radii instead
2023-08-12 22:18:27 +02:00
Piotr Osiewicz
6be73e46bf
Merge branch 'main' into project_search_design
2023-08-12 21:57:21 +02:00
Mikayla
a90c0e0326
Merge branch 'main' into collab-panel
2023-08-12 12:44:22 -07:00
Mikayla Maki
5ce7ccac32
Allow individual corner radii on containers, images, and drop shadows ( #2841 )
...
Here's an example in `crates/gpui/examples/corner_radii.rs`

@iamnbutler, in the themes, anywhere we have a container style can now
take either a `corner_radius` or a `corner_radii` field, both of these
fields can either have 1 number (for all 4 corners) or a an object like:
```
{
top_left?: number,
top_right?: number,
bottom_left?: number,
bottom_right?:number
}
```
Fields that are not included in this second representation default to 0
corner radius.
2023-08-12 12:36:05 -07:00
Mikayla
29a85635ea
Make each setting optional
2023-08-12 12:23:46 -07:00
Mikayla
563b25f26f
Add deserialization helper
2023-08-12 12:21:44 -07:00
Nathan Sobo
fa7ebd0825
Include drop shadows with different corner radii in the example
2023-08-12 11:08:58 -06:00
Nathan Sobo
65123e6eed
Allow individual corner radii on drop shadows
2023-08-12 10:58:08 -06:00
Nathan Sobo
40f478937e
Allow distinct corner radii for images
2023-08-12 10:50:04 -06:00
Nathan Sobo
84dc4090bd
Wire up per corner radii for quad
...
Still need to expose this in the styling layer and allow images
to have per corner radii.
2023-08-12 10:40:23 -06:00
Nathan Sobo
0d31d6dac5
WIP
2023-08-12 10:00:08 -06:00
Nathan Sobo
4b4b949972
WIP
2023-08-12 01:11:12 -06:00
Nathan Sobo
5e36040533
Put a Taffy layout engine on window
2023-08-12 00:58:11 -06:00
Mikayla Maki
1911f537b4
Add a compile test for the element derive ( #2840 )
...
Tried to use this the new element derive on a branch and ran into some
bugs, this fixes those.
Release Notes:
- N/A
2023-08-11 18:08:13 -07:00
Mikayla
7970406694
Add a compile test for the element derive
2023-08-11 18:00:12 -07:00
Piotr Osiewicz
c0356fdf16
Decrease row count for buffer search bar
2023-08-11 23:47:16 +02:00
Mikayla
9b5551a079
split into body and header
2023-08-11 11:35:51 -07:00
Nate Butler
ff1261b300
WIP Restyle channel modal
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-08-11 13:32:46 -04:00
Piotr Osiewicz
0a0314eec9
Shrink project search + decrease padding
2023-08-11 18:19:45 +02:00
Piotr Osiewicz
e4c593c2fb
chore: fix compiler warning
2023-08-11 17:09:26 +02:00
Piotr Osiewicz
799278e296
Add row_height
2023-08-11 17:02:25 +02:00
Piotr Osiewicz
100a8961b5
Add accent colors to search option buttons
2023-08-11 16:51:18 +02:00
Piotr Osiewicz
f6ecf83f33
Increase editor's left hand side padding to 10
2023-08-11 16:43:07 +02:00
Piotr Osiewicz
9e9b3093a9
Style mode/option buttons
2023-08-11 16:32:15 +02:00
Nathan Sobo
983641da2b
WIP
2023-08-11 07:39:30 -06:00
Piotr Osiewicz
ffffbbea1f
chore: use Cow instead of String for tooltips ( #2838 )
...
A QoL change to align `Tooltip` with other elements like `Label`
Release Notes:
- N/A
2023-08-11 15:29:55 +02:00
Piotr Osiewicz
3d103546bc
Make ButtonSide respect corner_radius
2023-08-11 14:44:22 +02:00
Piotr Osiewicz
b8df26b194
mode_button: get rid of borders before creating a label
2023-08-11 13:26:22 +02:00
Piotr Osiewicz
a9a2d281c3
Make ButtonSide scale with corner_radius
2023-08-11 13:10:56 +02:00
Nathan Sobo
d6eaa3c6b8
Ditch the hot reloading approach
2023-08-11 00:26:58 -06:00
Mikayla
b21b17c120
Merge branch 'main' into collab-panel
2023-08-10 10:04:01 -07:00
Nathan Sobo
0bf607cd2d
WIP
2023-08-10 10:26:48 -06:00
Nathan Sobo
dd6425e898
WIP
2023-08-10 09:24:16 -06:00
Piotr Osiewicz
096e293c17
Fix rounding artifacts of nav buttons
2023-08-10 15:26:05 +02:00
Piotr Osiewicz
9ad308f2f0
Fix padding inside search input.
...
Adjust borders for toggle buttons
2023-08-10 14:53:25 +02:00
Piotr Osiewicz
da3a4174ce
Bump row_count for buffer search
2023-08-10 13:01:20 +02:00
Piotr Osiewicz
b2f773e91d
Increase padding on search
2023-08-10 12:57:12 +02:00
Nathan Sobo
3b1e5e966a
What if we base themes on Rose Pine
2023-08-09 20:54:30 -06:00
Max Brunsfeld
b3447ada27
Dial in the channel creating/renaming UI
...
* Ensure channel list is in a consistent state with no flicker while the
channel creation / rename request is outstanding.
* Maintain selection properly when renaming and creating channels.
* Style the channel name editor more consistently with the non-editable
channel names.
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-09 17:11:57 -07:00
Max Brunsfeld
076b72cf2b
Improve styling of collab panel
2023-08-09 15:11:30 -07:00
Max Brunsfeld
ac1b2b18aa
Send user ids of channels of which they are admins on connecting
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-09 14:40:47 -07:00
Max Brunsfeld
60e25d780a
Send channel permissions to clients when they fetch their channels
2023-08-09 13:56:03 -07:00
Max Brunsfeld
268f4b1939
Restore shutdown behavior ( #2837 )
...
Deals with https://github.com/zed-industries/community/issues/1898
Restores original close behavior from
https://github.com/zed-industries/zed/pull/2832/files#diff-89af0b4072205c53b518aa977d6be48997e1a51fa4dbf06c7ddd1fec99fc510eL444
(load diff for the last file, zed.rs)
and adds a better name for the variable.
Release Notes:
- Fixes `cmd-q` not working
2023-08-09 13:50:21 -07:00
Kirill Bulatov
704ab33f72
Restore shutdown behavior
2023-08-09 23:39:21 +03:00
Mikayla
a3623ec2b8
Add renames
...
co-authored-by: max <max@zed.dev >
2023-08-09 12:20:48 -07:00
Mikayla
eed49a88bd
Fix bad merge
2023-08-09 11:04:09 -07:00
Mikayla
707e41ce1f
Merge branch 'collab-panel' of github.com:zed-industries/zed into collab-panel
2023-08-09 10:44:50 -07:00
Mikayla
99daa73325
Merge branch 'main' into collab-panel
2023-08-09 10:37:22 -07:00
Max Brunsfeld
778fd6b0a9
Represent channel relationships using paths table
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-09 10:36:27 -07:00
Max Brunsfeld
498d043a0a
Avoid leak of channel store
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-09 10:23:52 -07:00
Nate Butler
beffe6f6a9
WIP BROKEN
2023-08-09 12:44:34 -04:00
Joseph T. Lyons
230b894871
v0.100.x dev
2023-08-09 12:30:39 -04:00
Mikayla Maki
40030f32d9
Fix two mouse event bugs ( #2835 )
...
This PR fixes two bugs we discovered in Zed's mouse event handling while
investigating an interesting and mysterious bug we we were seeing, where
spurious `MouseMoved` events would continuously be dispatched after
control-clicking.
Release Notes:
- Fixed a rendering glitch that could occur after control-clicking
certain elements.
2023-08-09 09:04:32 -07:00
Piotr Osiewicz
c58cf396d3
Add cycle mode command for buffer search
2023-08-09 18:02:21 +02:00
Mikayla
a5cb4c6d52
Fix selections and enter-to-create-file
2023-08-09 08:54:24 -07:00
Nate Butler
6cc0b81e39
Add ui_sans as a font option in the theme ( #2836 )
...
This adds IBM Plex as a font option available to use as `ui_sans`
Note: This PR adds a static list of accepted font types in `/font`, as
LICENSE files were causing the app to crash when Zed was trying to load
them as fonts.
Release Notes:
- N/A (No user facing changes)
Thanks @ForLoveOfCats for getting me unstuck ❤️
2023-08-09 11:54:05 -04:00
Nate Butler
85af025d82
Add IBM Plex license
2023-08-09 11:39:15 -04:00
Nate Butler
af388e7f9c
Only load TTF fonts for now, additional font types will need to be manually added
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-08-09 11:38:02 -04:00
Nate Butler
183c292a5c
Remove license causing unwrap error
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-08-09 11:11:57 -04:00
Nate Butler
b23f1c809a
WIP add IBM Plex Sans
...
(base) natebutler@Nate16 zed % cargo run
Compiling zed v0.99.0 (/Users/natebutler/Code/zed/zed/crates/zed)
Finished dev [unoptimized + debuginfo] target(s) in 9.15s
Running `target/debug/Zed`
Thread "main" panicked with "called `Result::unwrap()` on an `Err` value: parse error" at crates/zed/src/main.rs:667:10
0: backtrace::backtrace::libunwind::trace
at /Users/natebutler/.cargo/registry/src/index.crates.io-6f17d22bba15001f/backtrace-0.3.68/src/backtrace/libunwind.rs:93:5
backtrace::backtrace::trace_unsynchronized
at /Users/natebutler/.cargo/registry/src/index.crates.io-6f17d22bba15001f/backtrace-0.3.68/src/backtrace/mod.rs:66:5
1: backtrace::backtrace::trace
at /Users/natebutler/.cargo/registry/src/index.crates.io-6f17d22bba15001f/backtrace-0.3.68/src/backtrace/mod.rs:53:14
2: backtrace::capture::Backtrace::create
at /Users/natebutler/.cargo/registry/src/index.crates.io-6f17d22bba15001f/backtrace-0.3.68/src/capture.rs:176:9
3: backtrace::capture::Backtrace::new
at /Users/natebutler/.cargo/registry/src/index.crates.io-6f17d22bba15001f/backtrace-0.3.68/src/capture.rs:140:22
4: Zed::init_panic_hook::{{closure}}
at crates/zed/src/main.rs:436:29
5: std::panicking::rust_panic_with_hook
6: std::panicking::begin_panic_handler::{{closure}}
7: std::sys_common::backtrace::__rust_end_short_backtrace
8: _rust_begin_unwind
9: core::panicking::panic_fmt
10: core::result::unwrap_failed
11: core::result::Result<T,E>::unwrap
at /private/tmp/rust-20230613-7622-103lepv/rustc-1.70.0-src/library/core/src/result.rs:1089:23
12: Zed::load_embedded_fonts
at crates/zed/src/main.rs:664:5
13: Zed::main
at crates/zed/src/main.rs:80:5
14: core::ops::function::FnOnce::call_once
at /private/tmp/rust-20230613-7622-103lepv/rustc-1.70.0-src/library/core/src/ops/function.rs:250:5
15: std::sys_common::backtrace::__rust_begin_short_backtrace
at /private/tmp/rust-20230613-7622-103lepv/rustc-1.70.0-src/library/std/src/sys_common/backtrace.rs:134:18
16: std::rt::lang_start::{{closure}}
at /private/tmp/rust-20230613-7622-103lepv/rustc-1.70.0-src/library/std/src/rt.rs:166:18
17: std::panicking::try
18: std::rt::lang_start_internal
19: std::rt::lang_start
at /private/tmp/rust-20230613-7622-103lepv/rustc-1.70.0-src/library/std/src/rt.rs:165:17
20: _mai
2023-08-09 11:01:20 -04:00
Piotr Osiewicz
17d505bb7b
Reset search index on mode change
2023-08-09 14:25:56 +02:00
Piotr Osiewicz
28a57662af
buffer: Add magnifying glass icon
2023-08-09 13:47:48 +02:00
Piotr Osiewicz
6fbef9f3c7
chore: update fn paint
2023-08-09 12:33:14 +02:00
Piotr Osiewicz
7ef5656f6a
Merge branch 'main' into project_search_design
2023-08-09 12:30:48 +02:00
Piotr Osiewicz
8b033223fb
Go back to previous mode on rejection of semantic indexing
2023-08-09 12:28:15 +02:00
Nathan Sobo
82c903de14
Rename node to frame
2023-08-08 21:28:52 -06:00
Nathan Sobo
c95aecdd53
Merge branch 'main' into cells
2023-08-08 21:23:57 -06:00
Nathan Sobo
8ed5e8f86d
Pass PaintContext to Element::paint ( #2788 )
...
I want to use this on another branch, but it's a sweeping change, so
this prepares the ground for it. This can always be reverted if it
doesn't work out.
2023-08-08 21:16:57 -06:00
Joseph T. Lyons
bed0d1d529
Fix language detection when file name begins with a . ( #2833 )
...
I went to add in `zprofile` to the bash language config to get syntax
highlighting for it. After adding it in, Zed was still not highlighting
the file. I checked and saw that we are using `Path::extension()` in
`language_for_file()`, which [returns `None` when a file's name begins
with a
`.`](https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.extension ),
such as in the case of `.zprofile`. This PR adds a custom method, with
some tests, that just tries to grab the last component in the file name
if `Path::extension` returns `None`. Not sure if `ext` is the best name,
but I can't use `extension`.
Maybe this method should be called `extension_or_hidden_file_name()`?
Release Notes:
- Fixed a bug where language detection would fail for files starting
with `.` in their names.
- Added syntax highlighting for `.zprofile` files
2023-08-08 21:48:56 -04:00
Joseph T. Lyons
c523ccc4c7
Fix code that identifies language via extension
2023-08-08 21:35:11 -04:00
Max Brunsfeld
2605ae1ef5
Use Arc::make_mut in ChannelStore
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-08 17:49:29 -07:00
Max Brunsfeld
0b93a30821
Terminate synthetic drag state on mouse up w/ ctrl held
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-08 17:39:45 -07:00
Max Brunsfeld
e3bb5e5103
Fix failure to remove hovered region_ids on element removal
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-08 17:39:05 -07:00
Nathan Sobo
db96fb1307
Merge remote-tracking branch 'origin/main' into paint-context
2023-08-08 18:27:16 -06:00
Nathan Sobo
54ca5f1d44
Replace context methods that take a window id with methods on window handles ( #2832 )
...
With this PR, I've eliminated almost all references to window ids
outside of the internals of GPUI. All public methods taking these ids
are now defined on `AnyWindowHandle`, which provides a more coherent
narrative around windows as a concept.
2023-08-08 17:51:37 -06:00
Piotr Osiewicz
d34da2db69
fix dismiss tooltip for project search
2023-08-09 01:37:17 +02:00
Piotr Osiewicz
22f630e985
chore: remove unused function
2023-08-09 01:30:45 +02:00
Piotr Osiewicz
f978acdd34
buffer: use shared func for nav button rendering
2023-08-09 01:29:22 +02:00
Nathan Sobo
0dc70e6cbf
Rename mac platform Window to MacWindow for clarity
2023-08-08 17:21:06 -06:00
Nathan Sobo
fc96676662
Use AppContext::update when updating windows so we handle effects
2023-08-08 17:20:46 -06:00
Piotr Osiewicz
e2b8e6ce63
chore: fix compiler warnings
2023-08-09 01:16:24 +02:00
Piotr Osiewicz
a583d1c6cc
Do not display match count when query is empty
2023-08-09 01:15:17 +02:00
Piotr Osiewicz
b282bdfe5a
buffer: finish up moving things around
2023-08-09 01:09:07 +02:00
Piotr Osiewicz
e1724daf35
buffer: WIP style sides of buffer search
2023-08-09 00:38:50 +02:00
Nathan Sobo
8e49d1419a
Minimize window id usage
2023-08-08 16:38:46 -06:00
Piotr Osiewicz
a7bd05ec0a
buffer: use icons for search options
2023-08-09 00:16:12 +02:00
Nathan Sobo
afd89b256a
Store AnyWindowHandles instead of usizes
2023-08-08 16:06:53 -06:00
Mikayla
bbe4a9b388
Position and style the channel editor correctly
...
Fix a bug where some channel updates would be lost
Add channel name sanitization before storing in the database
2023-08-08 14:06:29 -07:00
Mikayla
b708824d37
Position and style the channel editor correctly
...
Fix a bug where some channel updates would be lost
Add channel name sanitization before storing in the database
2023-08-08 12:46:13 -07:00
Piotr Osiewicz
c96b03ae55
Piotr/optimize search selections with a limit ( #2831 )
...
/cc @nathansobo @maxbrunsfeld
Release Notes:
- Fixed scrollbar selections causing noticeable slowdowns with large
quantities of selections.
2023-08-08 21:29:24 +02:00
Mikayla
d00f6a490c
Fix a bug where channel invitations would show up in the channels section
...
Block non-members from reading channel information
WIP: Make sure Arc::make_mut() works
2023-08-08 11:47:13 -07:00
Mikayla
6a7245b92b
Fix positioning on face piles, fix panic on member invite removal
2023-08-08 10:44:44 -07:00
Nathan Sobo
1e8a9ccdb5
Merge remote-tracking branch 'origin/main' into window-handles
2023-08-08 11:42:55 -06:00
Nathan Sobo
b77c336a3d
Return window handles from WeakItemHandle
2023-08-08 11:39:56 -06:00
Nathan Sobo
b2d9ccc0a2
Move more window methods off AsyncAppContext
2023-08-08 11:38:07 -06:00
Nathan Sobo
95cd96e4be
Move debug_elements to AnyWindowHandle
2023-08-08 11:27:19 -06:00
Nathan Sobo
4f10f0ee86
Remove window methods from AsyncAppContext
2023-08-08 11:23:49 -06:00
Nathan Sobo
1fd80ba8bd
Remove AsyncAppContext::remove_window
2023-08-08 11:22:43 -06:00
Nathan Sobo
fe6a1886c1
Remove unused dock code
2023-08-08 11:20:42 -06:00
Nathan Sobo
0a4633f88f
Remove more window id usage
2023-08-08 11:20:09 -06:00
Nathan Sobo
da7dc9c880
Work with window handles instead of ids in drag code
2023-08-08 11:14:02 -06:00
Nathan Sobo
d896d89842
Store an AnyWindowHandle in WindowContext
2023-08-08 11:08:37 -06:00
Mikayla
17c9b4ca96
Fix tests
2023-08-08 10:04:29 -07:00
Nate Butler
662e196267
Calculate the range for each color family in a theme ( #2738 )
...
Release Notes:
- N/A (Internal theme stuff)
2023-08-08 11:49:52 -04:00
Nathan Sobo
49f1f1c6c2
Remove window when closing workspace in test
2023-08-08 09:13:17 -06:00
Piotr Osiewicz
2c570fbb72
Move option button rendering to search_bar
2023-08-08 16:26:19 +02:00
Piotr Osiewicz
343e9d080e
Finish migration to modes for buffer search
2023-08-08 15:57:07 +02:00
Piotr Osiewicz
fecea03c90
Add modes to buffer search
2023-08-08 15:25:32 +02:00
Piotr Osiewicz
0374fdfd06
Move mode cycling to mode module
2023-08-08 15:20:34 +02:00
Piotr Osiewicz
7547fa2679
Move mode rendering to a search_bar module
2023-08-08 15:11:32 +02:00
Piotr Osiewicz
31a56720d9
Move nav buttons generation to search_bar
2023-08-08 14:56:21 +02:00
Piotr Osiewicz
c53554ead3
Remove SearchOptions::REGEX.
...
A bit WIP as it awaits migration of buffer search to modes
2023-08-08 14:42:11 +02:00
Piotr Osiewicz
0ca29e56c2
Update keybinds to use new names
2023-08-08 14:33:51 +02:00
Piotr Osiewicz
d497f279f0
Move ButtonSide to new module
2023-08-08 14:24:26 +02:00
Piotr Osiewicz
95891d28d8
Move SearchMode and SearchHistory to separate modules
2023-08-08 14:14:39 +02:00
Piotr Osiewicz
1aff642981
Do not highlgiht selections at all over the threshold
2023-08-08 13:09:27 +02:00
Nathan Sobo
dba2facd23
Remove window via handles
2023-08-07 22:58:01 -06:00
Nathan Sobo
f0da6b05fd
Remove TestAppContext::add_view
...
Instead, we now call this on window handles.
2023-08-07 22:46:48 -06:00
Nathan Sobo
0f332238b3
Remove unused method
2023-08-07 22:08:44 -06:00
Nathan Sobo
d687c3d81f
Merge remote-tracking branch 'origin/main' into window-handles
2023-08-07 22:07:20 -06:00
Nathan Sobo
f2be3181a9
Move window-related methods from TestAppContext to AnyWindowHandle
2023-08-07 20:23:04 -06:00
Nathan Sobo
0197d49230
Move activation simulation to AnyWindowHandle
2023-08-07 19:45:43 -06:00
Nathan Sobo
486f5bc6ca
Get compiling
2023-08-07 19:08:58 -06:00
Max Brunsfeld
299906346e
Change collab panel icon
2023-08-07 18:04:41 -07:00
Piotr Osiewicz
371c669e00
Address review feedback.
...
Rename selected_rows to background_highlight_row_ranges.
Do not return any ranges if there are more than 50k results
2023-08-08 02:47:49 +02:00
Piotr Osiewicz
b0fc6da55b
Use display maps
2023-08-08 02:37:27 +02:00
Piotr Osiewicz
241d3951b8
Remove redundant argument
2023-08-08 02:25:30 +02:00
Piotr Osiewicz
42e1221357
Add upper bound limit. Remove dbg! statements
2023-08-08 02:17:11 +02:00
Mikayla
fa71de8842
Tune UX for context menus
...
Co-authored-by: max <max@zed.dev >
2023-08-07 17:14:14 -07:00
Mikayla
bedf60b6b2
Improve local collaboration script to accept a zed impersonate
...
Gate channels UI behind a flag
co-authored-by: max <max@zed.dev >
2023-08-07 16:45:13 -07:00
Mikayla
8980a9f1c1
Add settings for removing the assistant and collaboration panel buttons
...
Add a not-logged-in state to the collaboration panel
co-authored-by: max <max@zed.dev >
2023-08-07 16:27:47 -07:00
Mikayla
e37e76fc0b
Add context menu controls to the channel member management
...
co-authored-by: Max <max@zed.dev >
2023-08-07 15:29:30 -07:00
Piotr Osiewicz
fa16895976
Do not query start of range if it's end is the same as the previous hunk's
2023-08-08 00:27:38 +02:00
Piotr Osiewicz
ca21626064
Baseline: Improve selection rendering for large quantities from 270ms to 90ms
2023-08-07 23:32:27 +02:00
Mikayla
9913067e51
Remove admin and member button
...
Fix bug with invites in the member list
Fix bug when there are network errors in the member related RPC calls
co-authored-by: Max <max@zed.dev >
2023-08-07 14:32:13 -07:00
Max Brunsfeld
7288be4251
Make LspAdapter::process_diagnostics synchronous ( #2829 )
...
When editing rust code, the project diagnostics view sometimes fails to
update, so that you have to close the view and re-open it to see the
correct state.
This PR fixes one possible cause of that problem. There was an async
step in between *receiving* diagnostics from the language server and
updating the diagnostics, due to an async call to
`LspAdapter::process_diagnostics`. This could cause the following
sequence of events to happen:
1. Rust-analyzer sends us new diagnostics for a file `a.rs`
2. We call `process_diagnostics` with those diagnostics
3. Rust-analyzer sends us a `WorkDoneProgress` message, indicating that
the "flycheck" (aka `cargo check`) process has completed
4. We update the project diagnostics view due to this message.
5. The `process_diagnostics` call for `a.rs` completes
6. 💥 We have the new diagnostics for `a.rs`, but do not update the
project diagnostics view again.
This PR fixes this bug by simply making `process_diagnostics`
synchronous. There is no I/O or expensive computation happening in that
method. If we need to make it asynchronous in the future, we need to
introduce a queue that ensures that `publishDiagnostics` and
`workDoneProgress` messages are processed serially.
Release Notes:
- Fixed a bug where the project diagnostics view would sometimes fail to
update properly when using Rust-analyzer.
2023-08-07 14:31:49 -07:00
Joseph T. Lyons
d417993c9d
Add syntax highlighting for Cargo.toml files ( #2830 )
...
Release Notes:
- Added syntax highlighting for `Cargo.toml` files
2023-08-07 17:28:21 -04:00
Joseph T. Lyons
dbf25ea2ff
Add syntax highlighting for Cargo.toml files
2023-08-07 17:24:22 -04:00
Joseph T. Lyons
580c2ea8eb
Fix test name
2023-08-07 17:07:01 -04:00
Max Brunsfeld
4e33654aba
Make LspAdapter::process_diagnostics synchronous
...
Co-authored-by: Nathan <nathan@zed.dev >
2023-08-07 13:53:41 -07:00
Mikayla
90cdbe8bf3
Fix modal click throughs and adjust height for channel modal
2023-08-07 13:39:05 -07:00
Mikayla
f1957b1737
Push focus and fix keybindings
2023-08-07 13:31:58 -07:00
Nathan Sobo
3e0d0e5c01
WIP
2023-08-07 13:54:47 -06:00
Max Brunsfeld
c537cf2a57
Merge branch 'main' into collab-panel
2023-08-07 11:50:40 -07:00
Conrad Irwin
19eb280351
Fix selection background too
...
Refactor code to centralize the logic too
2023-08-07 19:01:04 +01:00
Piotr Osiewicz
7a1f40405a
Add dismiss button to project search
2023-08-07 12:22:10 +02:00
Nathan Sobo
d4d32611fe
WIP
2023-08-06 18:57:02 -06:00
Nathan Sobo
adc50469ff
WIP
2023-08-06 12:45:31 -06:00
Joseph T. Lyons
e3a4d174de
Fix bash path_suffixes and add cmd-/ line comment support ( #2827 )
...
<img width="1608" alt="SCR-20230806-cyrg"
src="https://github.com/zed-industries/zed/assets/19867440/2491c4bc-5797-4417-9633-08c136b4e8fe ">
I noticed we weren't highlghting bash files if the shebang line didn't
exist. After checking, it looks like the `.` were accidentally added to
the `path_suffixes` list. This PR fixes that and adds in support for
`cmd-/` to trigger line comments.
<img width="1608" alt="SCR-20230806-czxh"
src="https://github.com/zed-industries/zed/assets/19867440/37dd0c8e-c4e7-49e2-9997-9dd8145f460e ">
Release Notes:
- Fixed a bug where shell files weren't syntax highlighted if a shebang
didn't exist.
- Added support for `cmd-/` to add line comments to shell files.
2023-08-06 02:35:00 -04:00
Joseph T. Lyons
ef5b982ea5
Fix bash path_suffixes and add line_comment
2023-08-06 02:20:31 -04:00
Nathan Sobo
dcf8b00656
WIP
2023-08-05 18:00:44 -06:00
Joseph T. Lyons
7777d973cd
Expand empty selections to cover full word when doing case conversions and fix bugs ( #2826 )
...
When doing case conversions, specifically in the case of an empty
selection, in both VS Code and Sublime, the cursor winds up being in a
different place relative to where it started.
In VS Code, the cursor maintains it position in the text, no matter if
the text expands or shrinks
https://github.com/zed-industries/zed/assets/19867440/b24f5d86-c315-4a72-9ed4-3732b490ea9a
In Sublime, I have no idea what is going on:
https://github.com/zed-industries/zed/assets/19867440/05f21303-6e42-47b2-b844-7accd0bf05d7
I thought it would be a better experience if, when doing an empty
selection transformation, we simply expand the selection and park the
cursor at the end of the newly-transformed text.
https://github.com/zed-industries/zed/assets/19867440/833619ef-04e2-47b6-ad4e-e2b43d54fb2b
This feels similar to us expanding the selection when doing line
manipulations:
https://github.com/zed-industries/zed/assets/19867440/c30c5332-787d-4cf0-a9ee-e66c3c159956
Selections are adjusted to match however each word expands and shrinks,
even when there are multiple:
https://github.com/zed-industries/zed/assets/19867440/d7073aac-8a59-4f2c-b0e5-1df37be1694c
Release Notes:
- Improved behavior of empty-selection case transformations by selecting
resulting word.
- Fixed some bugs with overflow
2023-08-05 12:16:46 -04:00
Joseph T. Lyons
1abb6a0176
Expand empty selections to cover full word and fix bugs
2023-08-05 11:31:21 -04:00
Joseph T. Lyons
d1048d03b0
Add more convert to case commands ( #2825 )
...
I'm using [convert_case](https://crates.io/crates/convert_case )
underneath the hood, which has over 35 million downloads and feels
solid.
Release Notes:
- Added commands to convert between variable name styles
([#1821 ](https://github.com/zed-industries/community/issues/1821 )).
- `convert to kebab case`
- `convert to snake case`
- `convert to upper camel case`
- `convert to lower camel case`
- `convert to title case`
2023-08-04 22:51:32 -04:00
Joseph T. Lyons
12e8f417e4
Add more convert to case commands
...
ConvertToTitleCase
ConvertToSnakeCase
ConvertToKebabCase
ConvertToUpperCamelCase
ConvertToLowerCamelCase
2023-08-04 22:45:26 -04:00
Max Brunsfeld
2ccd153233
Fix joining descendant channels, style channel invites
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-04 16:21:43 -07:00
Joseph T. Lyons
5c2f38a0bc
Add convert to {upper,lower} case commands ( #2824 )
...
Release Notes:
- Added `convert to upper case` and `convert to lower case` commands
([#1011 ](https://github.com/zed-industries/community/issues/1011 )).
2023-08-04 18:12:55 -04:00
Max Brunsfeld
87b2d599c1
Flesh out channel member management
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-04 14:12:08 -07:00
Joseph T. Lyons
8c98b02e45
Add convert to {upper,lower} case commands
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-08-04 15:10:33 -04:00
Max Brunsfeld
a2486de045
Don't expose channel admin actions in UI if user isn't admin
2023-08-04 10:24:46 -07:00
Piotr Osiewicz
9889449a81
Adjust row count for project search.
...
Instead of using the same row count as for the breadcrumbs, we double the height so that there's some space for padding.
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-04 18:54:27 +02:00
Max Brunsfeld
1762d2c6d4
Add test assertion where user is not admin of channel
2023-08-04 09:51:37 -07:00
Piotr Osiewicz
de8e1852a8
Align match count
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-04 18:21:46 +02:00
Piotr Osiewicz
8fa082c28b
Center the query editor (for real now)
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-04 17:49:54 +02:00
Piotr Osiewicz
82eb6d8bc3
Change styling of match nav buttons
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-04 17:35:59 +02:00
Nathan Sobo
b6110fed9e
WIP
2023-08-04 07:56:20 -06:00
Conrad Irwin
22927fa1d7
Fix visual selection cursor in multibuffers
2023-08-04 14:39:16 +01:00
Piotr Osiewicz
2c0e3886a5
Align search bar in the middle
2023-08-04 15:38:53 +02:00
Piotr Osiewicz
fcefb37ca0
Prevent modes from being vertically centered when row_count changes
2023-08-04 13:54:50 +02:00
Piotr Osiewicz
792f29e288
Refresh windows on toggle_filters.
2023-08-04 12:25:18 +02:00
Piotr Osiewicz
50d03ffc8c
Revert "Focus filters when enabled"
...
This reverts commit 13a6b65a35 .
2023-08-04 12:24:57 +02:00
Nathan Sobo
196946cbb6
Squelch warnings for now
2023-08-03 21:21:45 -06:00
Nathan Sobo
379652f074
Merge branch 'main' into cells
2023-08-03 19:33:04 -06:00
Max Brunsfeld
7a04ee3b71
Start work on exposing which channels the user has admin rights to
2023-08-03 18:31:00 -07:00
Max Brunsfeld
95b1ab9574
Implement channel member removal, permission check for member retrieval
2023-08-03 18:03:40 -07:00
Nathan Sobo
d3c1966d96
WIP: Return WindowHandle<V: View> from AppContext::add_window ( #2820 )
...
Instead of returning a usize for the window id, I'm instead returning a
`WindowHandle<V: View>` where `V` is the type of the window's root view.
@as-cii helped me with a cool technique using generic associated types
where methods on `WindowHandle` can return either T or Option<T>
depending on the `BorrowWindowContext::Result` associated type.
Some example usage...
```rs
let window = cx.add_window(|cx| MyView::new(cx));
let my_view = window.root(cx); // If cx is TestAppContext, returns MyView. Otherwise returns Option<MyView>, because the window could be closed.
```
This isn't insanely beneficial on its own, but I think it will help
clean up our testing story. I'm planning on making `window` more useful
in tests for laying out elements, etc.
- [x] Rework tests that call `add_window` 😅 to expect only a window in
return.
- [x] Get tests passing
- [x] 🚬 test
2023-08-03 18:45:51 -06:00
Piotr Osiewicz
13a6b65a35
Focus filters when enabled
2023-08-04 02:33:48 +02:00
Nathan Sobo
2d96388be3
Use WindowHandles in a couple places
2023-08-03 17:46:34 -06:00
Max Brunsfeld
4a6c73c6fd
Lay-out channel modal with picker beneath channel name and mode buttons
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-03 16:15:29 -07:00
Nathan Sobo
485c0a482e
Don't refcount window handles
2023-08-03 17:11:47 -06:00
Nathan Sobo
afcc0d621b
WIP
2023-08-03 17:03:39 -06:00
Joseph T. Lyons
ee1b4a52cc
Add PathExt trait ( #2823 )
...
This PR adds a `PathExt` trait. It pulls in our existing `compact()`
function, as a method, and then adds a method, and testing, for
`icon_suffix()`. A test was added to fix:
- https://github.com/zed-industries/community/issues/1877
Release Notes:
- Fixed a bug where file icons would not be registered for files with
with `.` characters in their name
([#1877 ](https://github.com/zed-industries/community/issues/1877 )).
2023-08-03 18:57:43 -04:00
Max Brunsfeld
a7e883d956
Implement basic channel member management UI
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-03 14:49:01 -07:00
KCaverly
c14a99d8fa
updated project_search text
2023-08-03 17:02:46 -04:00
Mikayla Maki
129f2890c5
simplify server implementation
2023-08-03 13:27:00 -07:00
Max Brunsfeld
9a1dd0c6bc
Fetch channel members before constructing channel mgmt modal
2023-08-03 12:10:53 -07:00
Mikayla Maki
6c4964f071
WIP: continue channel management modal and rename panel to collab_panel
2023-08-03 11:40:55 -07:00
Piotr Osiewicz
4658bc610c
Update styling of nav buttons (width, corner_radius)
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-03 20:35:10 +02:00
Piotr Osiewicz
31fb503418
Rewrite permission queries (it no longer blocks)
...
Co-authored-by: Kyle <kyle@zed.dev >
Co-authored-by: Max <max@zed.dev >
2023-08-03 20:26:56 +02:00
Mikayla Maki
d450c4be9a
WIP: add custom channel modal
2023-08-03 10:59:09 -07:00
Piotr Osiewicz
d157e3598d
Query semantic_permissioned on demand.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-03 19:27:27 +02:00
Piotr Osiewicz
799adf6c25
Query Semantic Index Engine for permission state.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-03 19:18:14 +02:00
KCaverly
8dd330a160
add semantic search prompt for the indexing permission on first search
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-03 12:52:20 -04:00
KCaverly
358e4e5ccf
update minor text when actively searching
2023-08-03 10:22:31 -04:00
Piotr Osiewicz
822b1ec002
Clean up compiler warnings
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-03 16:12:08 +02:00
Nathan Sobo
3c938a7377
WIP
2023-08-03 08:10:16 -06:00
Piotr Osiewicz
8831e03eba
Remove reference to pane from a toolbar.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-03 16:09:26 +02:00
Piotr Osiewicz
7d83d15bf3
Move navigation buttons to the tab bar.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-03 16:05:24 +02:00
Mikayla Maki
30e1bfc872
Add the ability to jump between channels while in a channel
2023-08-02 17:13:09 -07:00
Max Brunsfeld
0ae1f29be8
wip
2023-08-02 15:52:56 -07:00
Max Brunsfeld
4d55110452
Restore seeding of random GH users in seed-db
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-02 15:45:22 -07:00
Julia
ad4fd7619b
Use the same font size for hovered state of LSP status ( #2821 )
...
This element is used for the update state as well for some reason so
while we don't normally ever see this state, it is used when the status
is acting as the restart to update button
Release Notes:
- Fixed an inconsistency in the status bar update button font size.
2023-08-02 18:16:39 -04:00
Max Brunsfeld
fca8cdcb8e
Start work on rendering channel participants in collab panel
...
Co-authored-by: mikayla <mikayla@zed.dev >
2023-08-02 15:09:37 -07:00
Julia
df4480ba52
Use the same font size for hovered state of LSP status
...
This element is used for the update state as well for some reason so
while we don't normally ever see this state, it is used when the status
is acting as the restart to update button
2023-08-02 17:33:56 -04:00
KCaverly
b4f6d6eadc
update search text for no results
2023-08-02 17:14:15 -04:00
Nathan Sobo
8e36da1382
Get tests passing
2023-08-02 15:02:55 -06:00
KCaverly
a125e318fe
catch up with main
2023-08-02 16:48:11 -04:00
Nathan Sobo
884cee6dfd
Get tests compiling returning WindowHandle<V: View> from add_window
2023-08-02 14:05:03 -06:00
Max Brunsfeld
9e755bb855
Revert "Extract syntax highlighting properties from tree-sitter highlight queries ( #2797 )"
...
This reverts commit 45c635872b , reversing
changes made to f2b82369f2 .
2023-08-02 12:15:39 -07:00
Max Brunsfeld
a9de73739a
WIP
2023-08-02 12:15:06 -07:00
KCaverly
71bbd5f2f6
update keymaps for cycle search mode and toggle filters
2023-08-02 15:08:54 -04:00
KCaverly
acf78f5fb4
add kill_search function to stop searching on mode change
2023-08-02 14:18:28 -04:00
Nathan Sobo
60e190e500
WIP
2023-08-02 12:08:56 -06:00
Joseph T. Lyons
b0ec05a732
v0.99.x dev
2023-08-02 13:50:30 -04:00
KCaverly
7b43b0d4f1
refactored search mode to ensure state is consistent
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-02 12:29:19 -04:00
Mikayla Maki
61a6892b8c
WIP: Broadcast room updates to channel members
2023-08-02 09:21:30 -07:00
Max Brunsfeld
7d97d1dd8d
Merge branch 'main' into collab-panel
2023-08-02 09:20:53 -07:00
Max Brunsfeld
a127b0d3e6
Fix warnings surfaced in Rust 1.71
2023-08-02 09:19:23 -07:00
Max Brunsfeld
a555fa1ada
Merge branch 'main' into collab-panel
2023-08-02 09:08:50 -07:00
Max Brunsfeld
4c7d60ed13
Upgrade to rust 1.71
2023-08-02 09:08:08 -07:00
Piotr Osiewicz
5b30caa333
Add borders to button sides
2023-08-02 11:27:59 -04:00
KCaverly
caaa4b1618
add theme for search mode option buttons, and adjust padding
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-02 11:23:55 -04:00
Piotr Osiewicz
e0eaf23c28
Add borders to button sides
2023-08-02 16:33:35 +02:00
Nathan Sobo
300ce61bd0
WIP
2023-08-02 08:25:40 -06:00
Conrad Irwin
5f6535e92b
TEMP
2023-08-02 15:06:46 +01:00
Piotr Osiewicz
d39585b240
Fix query editor 'floating' when filters are enabled
2023-08-02 14:05:09 +02:00
Piotr Osiewicz
0253ff3043
Touch up rounding on the sides of mode switcher
2023-08-02 13:52:02 +02:00
Piotr Osiewicz
4ef59899d1
WIP: Add ButtonSide element
2023-08-02 13:05:29 +02:00
Nathan Sobo
b695c42e11
WIP: Return WindowHandle<V: View> from AppContext::add_window
2023-08-01 22:28:04 -06:00
Nathan Sobo
1dfde8eab5
WIP
2023-08-01 20:53:15 -06:00
Mikayla Maki
7145f47454
Fix a few bugs in how channels are moved around
2023-08-01 18:42:14 -07:00
Max Brunsfeld
6a404dfe31
Start work on adding sub-channels in the UI
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-01 18:20:25 -07:00
Mikayla Maki
b389dcc637
Add subchannel creation
...
co-authored-by: max <max@zed.dev >
2023-08-01 16:48:11 -07:00
Mikayla Maki
74437b3988
Add remove channel method
...
Move test client fields into appstate and fix tests
Co-authored-by: max <max@zed.dev >
2023-08-01 16:06:27 -07:00
Piotr Osiewicz
e4871afaf3
Improve styling of mglass icon & search switches
2023-08-02 00:36:46 +02:00
Mikayla Maki
56d4d5d1a8
Add root channel UI
...
co-authored-by: Max <max@zed.dev >
2023-08-01 13:33:31 -07:00
Mikayla Maki
7434d66fdd
WIP: Add channel creation to panel UI
2023-08-01 13:22:06 -07:00
Julia
5e9f7f10c0
Improve panic message usefulness on local dev builds ( #2819 )
...
I got tired of having to hack in a panic hook bypass whenever I wanted a
backtrace with line numbers. Now a dev channel build will behave more
like the default panic hook, printing a pretty traditional backtrace
message and exit with an error code instead of aborting to avoid the
annoying "Zed crashed" dialog.
I have plans to modify our panic reporting to be able to have line
numbers reported without breaking the de-duping but I haven't done that
yet.
Additionally I slightly improved what we do in threads which panic as a
result of another thread's panic.
Release Notes:
- N/A
2023-08-01 15:43:33 -04:00
Julia
3cee181f99
Improve panic message usefulness on local dev builds
2023-08-01 14:30:20 -04:00
KCaverly
cf060f0011
added major and minor display text to project search, and fixed icon padding
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-01 13:28:21 -04:00
KCaverly
7d5ff60ff0
added svg right margin in search bar
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-08-01 12:34:02 -04:00
Piotr Osiewicz
00a9672eca
Scale down the case insensitive icon
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-01 18:02:19 +02:00
Piotr Osiewicz
444b98e32f
Update case insensitive button.
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-08-01 17:56:09 +02:00
Joseph T. Lyons
eb26fb2d45
Fix variable names
2023-08-01 11:52:53 -04:00
Kyle Caverly
ce258dfeb9
Expanded Semantic language support ( #2818 )
...
Expand Language Support within Semantic Search
Release Notes (Preview-only)
- Added semantic search support for lua, ruby, php, svelte, erb, heex,
html and markdown.
- Full details are included here:
https://linear.app/zed-industries/issue/Z-2611/allow-semantic-search-for-all-supported-languages
2023-08-01 11:51:51 -04:00
KCaverly
c28ba3a11a
add cycle mode to project search
...
Co-authored-by: Piotrek <piotr@zed.dev >
2023-08-01 11:47:30 -04:00
Piotr Osiewicz
2e2d0a3884
Hide whole word/case sensitive options under semantic search
2023-08-01 17:07:21 +02:00
KCaverly
300c693d55
catchup with main
2023-08-01 10:40:38 -04:00
KCaverly
e221f23018
add support for markdown files to semantic search
2023-08-01 10:30:34 -04:00
Piotr Osiewicz
b29a535f04
Use icons instead of text in toggles
2023-08-01 11:20:23 +02:00
KCaverly
9a50b43eaa
add templating languages html, erb, heex, svelte as entire parseable file types
2023-07-31 21:03:02 -04:00
Max Brunsfeld
7954b02819
Start work on displaying channels and invites in collab panel
2023-07-31 18:00:14 -07:00
Piotr Osiewicz
a33d8519f2
Move buttons inside of query editor (WIP)
2023-08-01 02:06:40 +02:00
Mikayla Maki
003a711dea
Add room creation from channel join
...
co-authored-by: max <max@zed.dev >
2023-07-31 16:54:12 -07:00
Mikayla Maki
92fa879b0c
Add ability to join a room from a channel ID
...
co-authored-by: max <max@zed.dev >
2023-07-31 16:53:57 -07:00
Kirill Bulatov
06a0c9f82b
Track history items in the buffer and project searches ( #2817 )
...

Tracks last N (20 currently) items in buffer and project search, allows
cycling through between them with up/down keys by default.
Release Notes:
- Track history in buffer and project searches
2023-08-01 01:44:58 +03:00
Piotr Osiewicz
52a48de9ca
Add WIP Normal button (resuses parts of semantic button, gotta wire it proper)
2023-08-01 00:44:52 +02:00
Kirill Bulatov
634baeedb4
Add project search history
2023-08-01 01:31:28 +03:00
Kirill Bulatov
646dabe113
Add buffer search history
2023-08-01 01:31:28 +03:00
KCaverly
599f674827
add php support for semantic search
2023-07-31 16:36:09 -04:00
Mikayla Maki
ef57d444d0
Halve opacity on wrap guides ( #2815 )
...
Wrap guides are a little too bright as is
2023-07-31 10:59:34 -07:00
Mikayla Maki
88474a6048
Clip wrap guides from under the scrollbar
2023-07-31 10:54:29 -07:00
Nate Butler
b530aabff3
Additional storage filetypes ( #2816 )
...
Been working with some db stuff and thought it would be nice to add a
few more associations
Release Notes:
- Added additional filetype associations in the project browser
2023-07-31 13:32:15 -04:00
Nate Butler
bb288eb941
Ensure json uses a tab size of 4
2023-07-31 13:08:40 -04:00
Nate Butler
c4709418d1
Format
2023-07-31 12:50:30 -04:00
Nate Butler
e07a81b225
Add additional storage filetypes
2023-07-31 12:49:55 -04:00
KCaverly
89edb3d1b5
fix templating bug for parseable entire files
2023-07-31 11:41:18 -04:00
Julia
49ef3e35e3
Put LiveKitBridge Swift build directory in target ( #2812 )
...
Helps it get caught in a cargo clean. Joseph was having trouble building
a specific version of the app and deleting the Swift build dir for this
package resolved it. He had run cargo clean which would have handled
that if the Swift build dir was in `target` which this patch does
Release Notes:
- N/A
2023-07-31 11:25:41 -04:00
KCaverly
ca4e21881e
add ruby support for semantic search
2023-07-31 10:54:30 -04:00
KCaverly
a5dd8dd0a9
add lua embedding query for semantic search
2023-07-31 10:02:28 -04:00
Mikayla Maki
8926266952
Halve opacity on wrap guides
2023-07-29 23:53:16 -07:00
Mikayla Maki
6184c60278
disable wrap guides in the assitant panel ( #2814 )
...
Wrap guides do not look correct in the assistant due to it's current
header styling. Disable them in that context now.
Release Notes:
- Fix a visual bug displaying when enabling wrap guides in the
assistant.
2023-07-28 22:39:30 -07:00
Mikayla Maki
d58f031696
disable wrap guides in the assitant panel
2023-07-28 22:27:36 -07:00
Conrad Irwin
645c149344
Fix visual selection of trailing newline
2023-07-28 22:38:39 -06:00
Joseph T. Lyons
0bd6e7bac3
Fix comment
2023-07-28 23:13:36 -04:00
Joseph T. Lyons
b0e81c58dc
Remove unused code in test
2023-07-28 23:06:40 -04:00
Joseph T. Lyons
525c8dacbc
Add a command to collapse all entires ( #2813 )
...
Release Notes:
- Added a `project panel: collapse all entries` command
([#158 ](https://github.com/zed-industries/community/issues/158 )).
2023-07-28 22:44:08 -04:00
Joseph T. Lyons
2c47efcce9
Add a command to collapse all entires
2023-07-28 22:36:15 -04:00
Max Brunsfeld
4b94bfa045
Set up basic RPC for managing channels
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-07-28 17:05:56 -07:00
Julia
fe43bacb6f
Put LiveKitBridge Swift build directory in target
...
Helps it get caught in a cargo clean
2023-07-28 18:53:24 -04:00
Nathan Sobo
6f6096238d
WIP
2023-07-28 16:44:15 -06:00
Mikayla Maki
4626981b25
Make wrap guides respect scroll position ( #2810 )
...
Release Notes:
- Fixed a visual bug when scrolling with wrap guides active
2023-07-28 15:08:52 -07:00
Mikayla Maki
d3b89e16f2
Make wrap guides respect scroll position
2023-07-28 14:56:13 -07:00
Max Brunsfeld
758e1f6e57
Get DB channels query working with postgres
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-07-28 14:56:02 -07:00
Conrad Irwin
9cb0ce7745
Review
2023-07-28 15:36:14 -06:00
Conrad Irwin
0c15ef7305
Merge VisualChange -> Substitute
...
They both are supposed to work the same.
2023-07-28 15:32:02 -06:00
Nathan Sobo
6d10328796
WIP
2023-07-28 15:29:29 -06:00
Conrad Irwin
236b755b1d
Fix substitute in visual line mode
2023-07-28 15:26:40 -06:00
Conrad Irwin
e3788cc6e6
Add o/O for flipping selection
2023-07-28 15:26:40 -06:00
Conrad Irwin
3f2f3bb78d
Fix crash when deleting a long line in visual line mode
2023-07-28 15:26:40 -06:00
Conrad Irwin
5edcb74760
Add support for visual ranges ending with a newline
...
These primarily happen when first entering visual mode, but can also
be created with objects like `vi{`.
Along the way fix the way ranges like `vi{` are selected to be more
similar to nvim.
2023-07-28 15:26:40 -06:00
Conrad Irwin
b53fb8633e
Fix vim selection to include entire range
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-07-28 15:26:40 -06:00
Nathan Sobo
4d66c3237d
WIP
2023-07-28 15:01:45 -06:00
Mikayla Maki
0998440bdd
implement recursive channel query
2023-07-28 13:24:43 -07:00
Mikayla Maki
15631a6fd5
Add channel_tests.rs
2023-07-28 13:24:43 -07:00
Mikayla Maki
26a94b5244
WIP: Channel CRUD
2023-07-28 13:24:43 -07:00
Max Brunsfeld
bb70901e71
WIP
2023-07-28 13:24:43 -07:00
Mikayla Maki
40c293e184
Add channel_modal file
2023-07-28 13:24:43 -07:00
Mikayla Maki
1549c2274f
Create channel adding modal
2023-07-28 13:24:43 -07:00
Max Brunsfeld
4a088fc4ae
Make major collab panel headers non-interactive
2023-07-28 13:24:43 -07:00
Max Brunsfeld
fc49194535
Restructure collab panel, make contact finder into a normal modal
2023-07-28 13:24:43 -07:00
Max Brunsfeld
14fdcadcfc
Add seemingly-redundant export in theme src file to workaround theme build error
2023-07-28 13:24:43 -07:00
Max Brunsfeld
87dfce94ae
Rename contact list theme to collab panel
2023-07-28 13:24:43 -07:00
Max Brunsfeld
969ecfcfa2
Reinstate all of the contacts popovers' functionality in the new collaboration panel
2023-07-28 13:24:43 -07:00
Mikayla Maki
7f9df6dd24
Move channels panel into collab and rename to collab panel
...
remove contacts popover and add to collab panel
2023-07-28 13:24:42 -07:00
Mikayla Maki
fe5db3035f
move channels UI code to channels-rpc
2023-07-28 13:21:41 -07:00
Mikayla Maki
ac35dae66e
Add channels panel with stubbed out information
...
co-authored-by: nate <nate@zed.dev >
2023-07-28 13:21:39 -07:00
Julia
e6f3e0ab9c
Reattempt Node installation if the installation itself errors ( #2808 )
...
This also makes us a bit more aggressive about reinstalling Node
Fixes
https://linear.app/zed-industries/issue/Z-2697/language-server-error-html-failed-to-iterate-over-archive
Release Notes:
- Improved the Node runtime re-installation mechanism for language
servers.
2023-07-28 15:49:42 -04:00
Julia
46101bf110
Reattempt Node installation if the installation itself errors
...
This also makes us a bit more aggressive about reinstalling Node
2023-07-28 15:24:40 -04:00
Joseph T. Lyons
b8690ec1d1
Update release action to choose between preview and stable URL in Discord announcements
...
This is what ChatGPT told me, so we'll see.
2023-07-28 15:12:37 -04:00
Conrad Irwin
5d8370e2a1
Don't highlight project search matches either ( #2807 )
...
@JosephTLyons this is probably worth merging alongside #2803
- vim: Fix a bug where focusing project search results unexpectedly
entered visual mode
2023-07-28 12:25:32 -06:00
Conrad Irwin
fac0e2dd56
Don't highlight project search matches either
2023-07-28 12:17:32 -06:00
Kirill Bulatov
97042eb5aa
Make project search includes and excludes more user-friendly ( #2806 )
...
Closes
https://linear.app/zed-industries/issue/Z-2707/make-inclusionexclusion-with-non-globs-more-intuitive
Allow search results that start with the include/exclude path part.

Release Notes:
- Improved project search include/exclude filters' usability: allow path
entries along with the glob ones
2023-07-28 13:38:53 +03:00
Kirill Bulatov
cf6e524c9a
Make project search includes and excludes more user-friendly
...
Allow search results that start with the include/exclude path part
2023-07-28 12:56:44 +03:00
Nathan Sobo
dc8e7acca0
WIP
2023-07-27 23:52:41 -06:00
Nathan Sobo
239024acd6
WIP
2023-07-27 23:26:12 -06:00
Nathan Sobo
33e49b4962
WIP
2023-07-27 23:00:52 -06:00
Mikayla Maki
1545128ec5
Add Nix language support ( #2781 )
...
This adds rudimentary language support for the Nix expression language,
through tree-sitter-nix.
I spent a little bit of time trying to add support for one of the Nix
language servers too, but wasn't able to get any of them running
reliably without crashing, and so I've opted to stick to just the
tree-sitter grammar for now.

2023-07-27 18:35:52 -07:00
Mikayla Maki
e945b3c0e1
feat(workspace): add action for closing inactive editors on all panes ( #2771 )
...
using zed more and more to develop zed itself I'm finding some small qol
features missing, this is one of them
I'm very used to open two or three splits, and sometimes I want to close
everything except for the active editor, but that wasn't supported, as
the `pane::CloseInactiveItems` action only closes inactive items on the
active pane
so I've implemented it really quick, although I'm not sure it's the
right way to do this
note: I really don't like the default keybinding I've set it to, I have
this action bound to `cmd-shift-w` on all editors, but in zed is taken,
so I chose something that's free but without thinking too much about it
Release Notes:
- Added action for closing inactive editors from all panes
2023-07-27 18:11:11 -07:00
Conrad Irwin
ade8d4d167
Fix jumping to definition in a new file ( #2803 )
...
This is broken because vim currently sets settings only on the active
editor. Fix this by correcting the range on the currently active editor.
It would be nice (at some point) to refactor how vim sets settings, but
that's for another day.
Release Notes:
- vim: Fix bug when jumping to definition in new file accidentally
entered visual mode.
2023-07-27 19:10:01 -06:00
Mikayla Maki
dc5b23e9bb
Update elixir depedency ( #2805 )
...
Fixes https://github.com/zed-industries/community/issues/1761
Redo of https://github.com/zed-industries/zed/pull/2734
This PR increases the version further to one that does not have the
symbol collision issue we found with elm-tree-sitter
Release Notes:
- N/A
2023-07-27 18:01:16 -07:00
Mikayla Maki
4735b07088
Fix warning
2023-07-27 18:00:33 -07:00
Mikayla Maki
a0fc515cfc
Rework close_inactive_items to await all tasks
...
Update action name to be more accurate
2023-07-27 17:58:48 -07:00
Mikayla Maki
45e5d81664
update to dependency without symbol conflict
2023-07-27 17:41:13 -07:00
Mikayla Maki
0dffb728db
Update elixir depedency
...
co-authored-by: Alex <alexviscreanu@gmail.com >
2023-07-27 17:36:09 -07:00
Mikayla Maki
549769491e
Underscore arguments in conditionally compiled code ( #2804 )
...
For some reason, our bundle script doesn't fail on warning, so this
hasn't been caught yet.
Release Notes:
- N/A
2023-07-27 17:32:00 -07:00
Nathan Sobo
480401d65d
WIP
2023-07-27 18:23:23 -06:00
Mikayla Maki
f15a03816f
underscore arguments
2023-07-27 17:19:32 -07:00
Conrad Irwin
1935307b4f
Fix jumping to definition in a new file
...
This is broken because vim currently sets settings only on the active
editor. Fix this by correcting the range on the currently active editor.
It would be nice (at some point) to refactor how vim sets settings, but
that's for another day.
2023-07-27 18:10:17 -06:00
Mikayla Maki
ae765bbca3
Make mode indicator follow vim enabled state ( #2802 )
...
There was a minor visual bug introduced in
https://github.com/zed-industries/zed/pull/2801 , this PR corrects it.
Release Notes:
- N/A
2023-07-27 16:30:49 -07:00
Mikayla Maki
03bc430bdd
Make mode indicator follow vim enabled state
2023-07-27 16:14:56 -07:00
Mikayla Maki
17fa15d989
Avoid panic by accessing view handle by global in wrong window ( #2801 )
...
View handles are window specific but the Vim global will be doing things
in all windows, that would cause a panic when Vim attempted to update a
status bar mode indicator in a background window
Release Notes:
- N/A
2023-07-27 16:02:46 -07:00
Julia
fc9687d163
Avoid panic by accessing view handle by global in wrong window
...
View handles are window specific but this global will be doing things
in all windows, that would cause a panic when it attempted to update
a status bar mode indicator in a background window
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-07-27 18:53:05 -04:00
Joseph T. Lyons
3979454485
Follow naming convention for menu items
2023-07-27 17:13:37 -04:00
Joseph T. Lyons
e3201857ce
Publish preview releases to discord ( #2800 )
...
Release Notes:
- N/A
2023-07-27 15:26:08 -04:00
Joseph T. Lyons
7a9af7c663
Publish preview releases to discord
2023-07-27 15:17:13 -04:00
Julia
6a0e1d5345
Update Alacritty ( #2798 )
...
This will potentially fix a number of Alacritty related panics, however
it is tricky to figure out which ones in particular will be impacted for
sure. We've said we were going to do this for a while but with the
constant trickle of panics it seemed reasonable to just go and do it
Release Notes:
- Fixed a few potential terminal related crashes.
2023-07-27 15:03:53 -04:00
Nathan Sobo
2ef19e48bc
WIP
2023-07-27 13:00:28 -06:00
Nathan Sobo
70c9959ebc
WIP
2023-07-27 12:35:54 -06:00
Mikayla Maki
0455311371
Downgrade our dependency on treesitter-cpp ( #2799 )
...
Our dependency on `tree-sitter-cpp` got upgraded to an incompatible
version despite semver 'guarantees'. This pins the dependency onto the
commit of version 0.20.0
Release Notes:
- Restored language detection for C++ (preview-only)
2023-07-27 11:20:29 -07:00
Mikayla Maki
a829b5be01
fmt
2023-07-27 11:14:21 -07:00
Mikayla Maki
d835274306
Downgrade our dependency on treesitter-cpp
2023-07-27 11:11:24 -07:00
Nate Butler
27931663d9
chore: add theme types docs ( #2737 )
...
Release Notes:
- Added documentation about theme types generation
2023-07-27 13:21:31 -04:00
Nate Butler
45c635872b
Extract syntax highlighting properties from tree-sitter highlight queries ( #2797 )
...
This should be a purely internal change. Let me know if any visual
changes are observed from this!
### Syntax theme
- Update the theme to allow any syntax highlighting property used in any
`highlight.scm` to be styled
- Only define syntax styles that are baked into the default theme &
don't use the default text style
- Adds the `generate-syntax` command
- Removes a few unused properties that we were styling for some reason,
like `enum` and `variant`, neither of which exist in any `highlight.scm`
- Moves `@constructor` symbols to `@method.constructor` to prevent
issues with `constructor` being a reserved property in ts/js.
Syntax is now build as the theme is created rather than as part of the
styleTree. This means it no longer requires a compiled `Theme`, which
makes things a bit more straightforward if we need to access it in other
components that should be built before the styleTrees.
### Scheme
Also updates all uses of `#match` in our `highlights.scm` files, as
these break the scheme tree-sitter query. This fixes _most_ instances of
our scheme highlighting breaking.
For some reason something in here breaks the `highlights.scm` for PHP:
```scheme
((name) @constant.builtin
(.match? @constant.builtin "^__[A-Z][A-Z\d_]+__$"))
((name) @method.constructor
(.match? @method.constructor "^[A-Z]"))
((name) @variable.builtin
(.eq? @variable.builtin "this"))
```
Release Notes:
- No public facing changes
2023-07-27 13:14:01 -04:00
Nate Butler
b08a2770b8
Remove redundant syntax_highlights
2023-07-27 13:02:40 -04:00
Nate Butler
b9d5cc5828
Format
2023-07-27 12:56:54 -04:00
Nate Butler
0b7e75c25a
Add the generate-syntax action
2023-07-27 12:55:32 -04:00
Nate Butler
86fa27eb54
Update uses of # to . in our scheme files where they are interchangeable.
...
uses of `#` cause ERRORs in our scheme highlighting
2023-07-27 12:41:19 -04:00
Nate Butler
85f193dd09
Extract syntax highlighting properties from tree-sitter highlight queries
2023-07-27 12:25:53 -04:00
Julia
8c9c8362ec
Update Alacritty
2023-07-27 12:19:07 -04:00
Julia
f2b82369f2
Make LSP status message match new font size of diagnostic message ( #2796 )
...
The status bar diagnostic message font size was updated in
1f65effe57
but the LSP status message font size remained the same causing a font
size change when swapping between the two


Release Notes:
- Fixed an inconsistency in status bar font size.
2023-07-27 11:16:28 -04:00
Piotr Osiewicz
b9cdb851d2
Update results text
2023-07-27 16:31:24 +02:00
Julia
0ab1c6ac8e
Make LSP status message match new font size of diagnostic message
2023-07-27 10:25:46 -04:00
Piotr Osiewicz
dff9bf7d7e
Make row_count of toolbaritem dynamic (WIP).
...
Move result count to the left hand side.
2023-07-27 16:03:26 +02:00
Antonio Scandurra
46dd717857
Maintain cursor stack's position correctly when ascending the tree ( #2795 )
...
This fixes a bug that could cause the cursor to incorrectly report its
start when using `slice` or `seek_forward`, and then calling `prev`. We
didn't notice this because we were not testing those three methods
together.
I suppose this could explain some of the panics we've observed because
we do use `slice`/`seek_forward` followed by `prev` calls in production.
2023-07-27 13:51:09 +02:00
Piotr Osiewicz
8ca1e0b15b
Add dummy filter icon
2023-07-27 13:09:19 +02:00
Piotr Osiewicz
4761197d62
Add filter button.
...
Move semantic & regex buttons to the right hand side.
Add default tab name for the new project search.
2023-07-27 13:08:31 +02:00
Antonio Scandurra
2e0d051a78
Maintain cursor stack's position correctly when ascending the tree
...
This fixes a bug that could cause the cursor to incorrectly report its
start when using `slice` or `seek_forward`, and then calling `prev`. We
didn't notice this because we were not testing those three methods
together.
I suppose this could explain some of the panics we've observed because
we do use `slice`/`seek_forward` followed by `prev` calls in production.
2023-07-27 12:34:03 +02:00
Piotr Osiewicz
f2a35a7e1d
Use a three-way layout
2023-07-27 12:18:19 +02:00
Piotr Osiewicz
91c32ed307
WIP: project search redesign
2023-07-27 11:43:32 +02:00
Nathan Sobo
ab8906551d
WIP
2023-07-26 22:37:59 -06:00
Mikayla Maki
129e711545
Downgrade tree sitter elm to 5.6.4 ( #2794 )
...
The tree sitter elm parser contains a c symbol which collides with other
linked symbols. This PR downgrades the tree sitter elm parser to a
version which doesn't have this problem.
Release Notes:
- Fixed crash when parsing elm files
2023-07-26 15:54:55 -07:00
Mikayla Maki
d5c30709b3
Downgrade tree sitter elm to 5.6.4
2023-07-26 15:44:06 -07:00
Mikayla Maki
b8a2a2ecd3
Block extra drag events in original drag handlers ( #2793 )
...
In https://github.com/zed-industries/zed/pull/2790 I added an extra drag
event on mouse_up which signaled the end of a drag event, as mouse_up
event themselves wouldn't reliably fire if users moved their mouse too
quickly. This broke the assumptions of the terminal element. This PR
adds filters to all current on_drag handlers which removes this new
event.
Release Notes:
- Fixed a bug causing terminal links to never open (preview only)
- Fixed a bug in terminal link detection causing it to miss files with a
`-` in it
2023-07-26 15:15:31 -07:00
Mikayla Maki
354c020612
Block extra drag events in original drag handlers
2023-07-26 14:57:46 -07:00
Kyle Caverly
ee66f99ce6
Parallel vector db ( #2792 )
...
Parallelize Vector Database calls for project semantic search.
Release Notes: (Preview-only)
- Parallelize Vector database calls for project semantic search. Cuts
query time by 2/3rds.
- Removed default keymap for old semantic search modal.
2023-07-26 17:17:59 -04:00
KCaverly
fbede4a5a3
removed old code
2023-07-26 17:11:30 -04:00
KCaverly
e2b38f7a31
remove unused imports
2023-07-26 17:01:44 -04:00
KCaverly
06167889c3
remove default keymap for semantic search modal
2023-07-26 16:59:19 -04:00
KCaverly
5c48729c7c
managed for small batch size edge case in semantic search
2023-07-26 16:56:41 -04:00
KCaverly
89bbcdfa4f
remove debug logging for project_search semantic search
2023-07-26 16:51:25 -04:00
KCaverly
98fde36834
batch search queries in the vector database
2023-07-26 16:36:39 -04:00
Nathan Sobo
c602d98680
WIP
2023-07-26 13:34:57 -06:00
Nathan Sobo
0374bc66ce
WIP
2023-07-26 12:54:23 -06:00
Joseph T. Lyons
40fcec1495
Follow naming convention for menu items
2023-07-26 14:35:23 -04:00
Joseph T. Lyons
6cd10f3d5e
v0.98.x dev
2023-07-26 13:27:55 -04:00
Derek Briggs
603387ace5
icon updates ( #2791 )
...
Updated app icon and icon system updates
2023-07-26 11:23:23 -06:00
Derek Briggs
9fc1ebcb5b
icon updates
2023-07-26 11:19:34 -06:00
Mikayla Maki
711073cf3c
Simple cascading split ( #2790 )
...
This PR cascades the split resizing to adjacent splits, if the current
split has already hit the minimum size. This PR also adds support for
detecting the end of a drag event to GPUI, via a bool on the dispatched
drag.
Release Notes:
- Made split resizing more flexible
2023-07-26 09:49:27 -07:00
Mikayla Maki
a58c9ed7d3
fmt
2023-07-26 09:39:35 -07:00
Mikayla Maki
56704c7c5f
Remove placeholders
2023-07-26 09:37:52 -07:00
Kyle Caverly
fc1844d684
Semantic search v2 ( #2789 )
...
Move semantic search from navigation modal, to project search option.
This PR is intended to be released in Preview only, and requires an
opt-in semantic_index option to enable. Without this opt-in setting
enable, the user should perceive no differences between previous project
search.
Release Notes: (Preview-only)
- Added Semantic Search as a opt-in feature within Project Search
- Show indexing feedback on indexing process within project search view
2023-07-26 10:34:58 -04:00
KCaverly
0b61c93a25
ensure semantic search is not enabled on stable
2023-07-26 10:22:33 -04:00
KCaverly
394a105639
fix warnings
2023-07-26 10:03:30 -04:00
KCaverly
0ac919f6e0
catchup with main
2023-07-26 09:50:38 -04:00
KCaverly
ca6f7d8a80
add worktree previously indexed functionality to vector db
2023-07-26 09:17:04 -04:00
Conrad Irwin
39f02c2b72
Add a mode indicator for vim ( #2763 )
...
Release Notes:
- vim: add a mode indicator
([#409 ](https://github.com/zed-industries/community/issues/409 ))
Now updated screenshots with @iamnbutler
<img width="1043" alt="Screenshot 2023-07-25 at 11 11 57"
src="https://github.com/zed-industries/zed/assets/94272/8301479a-8b58-42d8-81a1-bc40e1e0a4df ">
<img width="1043" alt="Screenshot 2023-07-25 at 11 12 00"
src="https://github.com/zed-industries/zed/assets/94272/89c3b8bd-9cbc-4fd7-ad10-dac5538ed3a3 ">
<img width="1043" alt="Screenshot 2023-07-25 at 11 12 12"
src="https://github.com/zed-industries/zed/assets/94272/adc87fe3-a720-4779-853b-df9443407046 ">
2023-07-25 20:18:23 -06:00
Nathan Sobo
c48d8af204
Merge branch 'paint-context' into cells
2023-07-25 17:36:05 -06:00
Nathan Sobo
1b03c5d69c
Pass PaintContext to Element::paint
...
I want to use this on another branch, but it's a sweeping change,
so this prepares the ground for it. This can always be reverted if
it doesn't work out.
2023-07-25 17:32:31 -06:00
Nathan Sobo
df9c17176e
WIP
2023-07-25 16:33:58 -06:00
KCaverly
75999204ad
update project search to only show semantic button visible with semantic_index enabled
2023-07-25 16:26:37 -04:00
Joseph T. Lyons
cc23360bab
Add sort lines command ( #2786 )
...
This PR adds command palette actions for:
- `sort lines case sensitive`
- `sort lines case insensitive`
- `reverse lines`
- `shuffle lines`
Closes out:
- https://github.com/zed-industries/community/issues/658
and partially closing out:
- https://github.com/zed-industries/community/issues/57 (which is
currently a top-ranked issue)
There are issues with dedupe lines and I didn't try to tackle converting
variable names between different conventions. I'll likely close out 57
with a note to just upvote the remaining individual issues
Release Notes:
- added command palette actions for `sort lines case sensitive`, `sort
lines case insensitive`, `reverse lines`, and`shuffle lines`
(([#57 ](https://github.com/zed-industries/community/issues/57 )),
([#658 ](https://github.com/zed-industries/community/issues/658 )))
2023-07-25 15:39:45 -04:00
KCaverly
e8210b827d
move visible text to just start anchor with context lines for semantic search
2023-07-25 15:24:27 -04:00
KCaverly
cdceddd2cc
update semantic index tests for elixir
2023-07-25 15:20:35 -04:00
Joseph T. Lyons
4085df5146
Add tests for manipulate_lines()
2023-07-25 15:17:16 -04:00
Conrad Irwin
64b252e81a
A little refactor
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-07-25 12:55:01 -06:00
Joseph T. Lyons
bf2ca57f55
Remove { and } from single-line closure
2023-07-25 14:48:11 -04:00
Mikayla Maki
b5630eb901
Merge branch 'main' into quinn/nix
2023-07-25 11:34:57 -07:00
Mikayla Maki
c32fd57643
Add support for Elm and GLSL ( #2782 )
...
This adds tree-sitter grammars for both Elm and GLSL, with injections
for GLSL embedded within Elm. It also adds an `outline.scm` for Elm,
though limitations in the tree-sitter grammar meant that I wasn't able
to get it looking exactly how I'd have liked.
In particular, it wasn't clear how to nicely annotate functions in the
outline as being functions, or how to prevent the fields of a record
declaration from being increasingly indented.



fixes https://github.com/zed-industries/community/issues/598
Release Notes:
- Added syntax highlighting for the Elm and GLSL languages
2023-07-25 11:34:22 -07:00
Joseph T. Lyons
93ec73da29
Fix code computing new selections
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-07-25 14:04:25 -04:00
KCaverly
97c3d97792
update semantic index tests for cpp
2023-07-25 13:30:38 -04:00
Conrad Irwin
1f65effe57
Update status bar theming
...
Co-Authored-By: Nate Butler <iamnbutler@gmail.com >
2023-07-25 11:06:41 -06:00
Joseph T. Lyons
299818cde0
Fix rand import and tweak callbacks
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-07-25 11:44:13 -04:00
KCaverly
c86096a886
update semantic index tests for javascript
2023-07-25 10:38:37 -04:00
Joseph T. Lyons
1a84382881
WIP
2023-07-25 10:33:20 -04:00
Nathan Sobo
54a7419fa2
WIP
2023-07-24 23:27:14 -06:00
Joseph T. Lyons
bdd0b9f387
Add open file in project finder via space ( #2785 )
...
@mikayla-maki for 👀
[This PR added in the ability to rename a file via
`enter`](https://github.com/zed-industries/zed/pull/2784 ). Previously,
`enter` was used to both open a file and confirm a rename, so this PR
changes the opening of a file to use `space`, which is what VS Code
uses. It also makes a bit more sense because now `enter` is just used to
start a rename and confirm the rename, vs being used for 2 different
actions.
N/A on the release notes, as I adjusted the release note in the
previously-tagged PR.
Release Notes:
- N/A
2023-07-24 16:35:01 -04:00
Max Brunsfeld
a01d973477
More git status optimizations ( #2779 )
...
Follow-up to https://github.com/zed-industries/zed/pull/2777
Refs https://github.com/zed-industries/community/issues/1770
In this PR, I reworked the way that git statuses are retrieved. In a
huge repository like `WebKit`, the really slow part of computing a list
of git statuses is the *unstaged* portion of the diff. For the *staged*
diff, `git` can avoid comparing the contents of unchanged directories,
because the index contains hashes of every tree. But for the *unstaged*
portion, Git needs to compare every file in the worktree against the
index. In the common case, when there are no changes, it's enough to
check the `mtime` of every file (because the index stores the mtimes of
files when they are added). But this still requires an `lstat` call to
retrieve each file's metadata.
I realized that this is redundant work, because the worktree is
*already* calling `lstat` on every file, and caching their metadata. So
in this PR, I've changed the `Repository` API so that there are separate
methods for retrieving a file's *staged* and *unstaged* statuses. The
*staged* statuses are retrieved in one giant batch, like before, to
reduce our git calls (which also have an inherent cost). But the
`unstaged` statuses are retrieved one-by-one, after we load files'
mtimes. Often, all that's required is an index lookup, and an mtime
comparison.
With this optimization, it once again becomes pretty responsive to open
`WebKit` or `chromium` in Zed.
Release Notes:
- Optimized the loading of project file when working in very large git
repositories
2023-07-24 11:23:32 -07:00
Quinn Wilton
e199a6a3a1
Highlight all Elm function calls
2023-07-24 10:55:15 -07:00
Mikayla Maki
7603659479
Add MacOS standard key binding for file renames ( #2784 )
...
Release Notes:
- Added a default keybinding for using enter to rename files in the
project panel
2023-07-24 10:46:43 -07:00
Quinn Wilton
3cc88904bf
Add all Elm functions to the outline, including locals
2023-07-24 10:45:46 -07:00
Quinn Wilton
62ee52a5fc
Highlight qualified Elm function calls
2023-07-24 10:45:15 -07:00
Quinn Wilton
fbe0108959
Highlight Elm arrows as keywords
2023-07-24 10:44:56 -07:00
Mikayla Maki
41105136a4
Add MacOS standard key binding for file renames
2023-07-24 10:20:10 -07:00
Mikayla Maki
d95c4fdb2b
Remove unbound highlight queries
2023-07-24 09:01:15 -07:00
Conrad Irwin
baa16a2fc6
Better method ordering
2023-07-24 09:57:51 -06:00
Mikayla Maki
ea74734b0a
Touch up elm tree sitter integration
2023-07-24 08:52:51 -07:00
Conrad Irwin
43d94e37ec
Refactor mode indicator to remove itself
...
One of the problems we had is that the status_bar shows a gap between
items, and we want to not add an additional gap for an invisible status
indicator.
2023-07-24 09:51:54 -06:00
Mikayla Maki
25e4bcea7f
Implement cascading resize algorithm
2023-07-24 08:04:46 -07:00
Kirill Bulatov
52154f76ac
Fixes a crash when SelectAllMatches action was called on no matches ( #2783 )
...
Release Notes:
- Fixes a crash when SelectAllMatches action was called on no matches
2023-07-24 15:48:45 +03:00
Kirill Bulatov
7dccb487de
Fixes a crash when SelectAllMatches action was called on no matches
2023-07-24 15:42:10 +03:00
Quinn Wilton
6ad0852a70
Add outline.scm for Elm
2023-07-24 00:58:59 -07:00
Quinn Wilton
dd504f5965
Add tree-sitter-glsl
2023-07-23 22:22:11 -07:00
Quinn Wilton
a4914fcf3b
Add tree-sitter-elm
2023-07-23 22:22:11 -07:00
Max Brunsfeld
8fff0b0ff8
Fix pathspec in staged_statuses
...
Enable non-literal matching so that directory paths match
all files contained within them.
2023-07-23 21:36:29 -07:00
Quinn Wilton
fe388ed71e
Add tree-sitter-nix
2023-07-23 17:24:50 -07:00
Mikayla Maki
429a2fc623
Add drag end events
...
Fix left dragging cascade
WIP: Implement right dragging, WIP: use drag end events to set and reset state around initial flex orientation
2023-07-23 13:28:30 -07:00
Mikayla Maki
28ee05b324
WIP: cascade split resizes
2023-07-23 01:20:25 -07:00
Mikayla Maki
b4b53eb5f1
Refactor resize handle code to be amenable to cascading resizes
2023-07-22 21:48:45 -07:00
Max Brunsfeld
a3a9d024ba
Fix filtering of staged statuses
2023-07-22 17:53:58 -07:00
Max Brunsfeld
b338ffe8d8
Rely on git status for any paths not matching the git index
2023-07-22 17:47:36 -07:00
Kirill Bulatov
e0915190d4
In terminal, open paths starting with ~ and focus on project panel when opening directories ( #2780 )
...
Further improves terminal navigation with cmd+click, now allowing to
open paths starting with `~` (if they are present otherwise) and
focusing project panel with highlighted entry for the directories
opened.
Release Notes:
- Further improves terminal navigation with cmd+click, now allowing to
open paths starting with `~` (if they are present otherwise) and
focusing project panel with highlighted entry for the directories
opened.
2023-07-23 00:23:19 +03:00
Kirill Bulatov
f05095a6dd
Focus project panel on directory select
2023-07-23 00:12:25 +03:00
Max Brunsfeld
6c09782aa2
Optimize full file status via passing in known file mtime
2023-07-22 11:53:26 -07:00
Max Brunsfeld
51d311affd
Compute unstaged git status separately, to take advantage of our cached file mtimes
2023-07-21 17:58:43 -07:00
Max Brunsfeld
ff0864026e
Only fetch statuses for changed paths
2023-07-21 17:08:31 -07:00
Max Brunsfeld
05b161118c
Don't call git status when ignored files change
2023-07-21 17:05:42 -07:00
Kirill Bulatov
dcaf8a9af8
Open paths starting with ~ from terminal click
2023-07-22 01:34:25 +03:00
Conrad Irwin
d14a484a20
Add support for adding/removing status items
2023-07-21 16:06:14 -06:00
Conrad Irwin
458916409c
Add a mode indicator for vim
...
This is the second most common remaining complaint (after :w not
working).
Fixes : zed-industries/community#409
2023-07-21 16:06:14 -06:00
Max Brunsfeld
7788eabec0
Avoid performance bottlenecks from git status calls during worktree scanning ( #2777 )
...
Closes
https://linear.app/zed-industries/issue/Z-2689/huge-slowdown-when-working-in-large-git-repositories-like-webkit
Closes https://github.com/zed-industries/community/issues/1770
In large git repositories (like Webkit), `git status` can be very slow.
And our current approach of retrieving git statuses (one by one as we
load paths), causes catastrophic slowdowns in these repos. This PR
further optimizes our retrieval of git statuses (started in
https://github.com/zed-industries/zed/pull/2728 ), so that when scanning
a directory, we only load git statuses once, in a single batch, at the
beginning of the scan.
There is still an initial lag when opening `WebKit` in Zed, while the
initial git status runs. But once this call completes, everything is
fast. Let's come back to this problem later.
For now, this makes Zed's directory scanning massively more efficient,
even in the case of normal-sized repos like `zed`. The git status code
was a huge percentage of zed's CPU usage when launching. Here is that
code, highlighted in a flamegraph before and after this change:
Before:

After:

Release Notes:
- Fixed a bug where project paths took a very long time to load when
working in large git repositories
([#1770 ](https://github.com/zed-industries/community/issues/1770 ))
2023-07-21 14:46:53 -07:00
Kirill Bulatov
bd9118f673
Do not scroll when selecting all ( #2778 )
...
In big buffers, when I press `cmd-a`, the view gets scrolled to the very
bottom.
Usually it's now that I want, I can scroll to bottom with `cmd-down`
separately, and selecting all text is used for copy-pasting it
somewhere, no need to scroll anywhere for that — I can get back to the
same place later.
Release Notes:
- Removed the scroll to the end of the editor after `editor::SelectAll`
action
2023-07-22 00:25:37 +03:00
Kirill Bulatov
c538504b9c
Do not scroll when selecting all
2023-07-22 00:17:02 +03:00
Max Brunsfeld
4bd415f2b6
Retrieve git statuses in one batch when scanning dirs
2023-07-21 13:50:54 -07:00
Kirill Bulatov
25ea07cd41
When renaming in project panel, select file names without extensions ( #2776 )
...
Closes
https://github.com/zed-industries/community/issues/1789#issuecomment-1646061712
<img width="196" alt="Screenshot 2023-07-21 at 23 23 47"
src="https://github.com/zed-industries/zed/assets/2690773/f5c7025b-6dc8-4f0c-81e5-3cc98a3a9c8b ">
<img width="197" alt="Screenshot 2023-07-21 at 23 23 52"
src="https://github.com/zed-industries/zed/assets/2690773/596f8ab0-15e0-4285-be34-ce4c276b686f ">
When renaming in project panel, select file names without extensions.
Release Notes:
- Improved project panel rename by selecting file names without
extensions
2023-07-21 23:30:55 +03:00
Kirill Bulatov
33b215a288
Add search in directory action in the project panel ( #2774 )
...
Part of https://github.com/zed-industries/zed/issues/1153
Closes https://github.com/zed-industries/community/issues/1326
<img width="432" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/a50ee073-9d2e-4e5c-ae5e-23312693c540 ">
Adds an `project_panel::NewSearchInDirectory` action ("alt-shift-f"
default) in the project editor context to open a new project search in
the selected directory.
Release Notes:
- Adds an action to open project search in the project panel's directory
2023-07-21 23:25:45 +03:00
Julia
f2c9738a69
Put our downloaded copy of Node in the env for every NPM action ( #2775 )
...
Intelephense (PHP language server) has a dependency on `protobufjs`
which invokes `node` in the `postinstall` script and if the user did not
have a system Node runtime installed that would fail. Have this use our
downloaded installation too
Fixes
https://linear.app/zed-industries/issue/Z-2687/php-language-server-failed
Release Notes:
- Fixed PHP language server installation on systems without a system
Node installation.
2023-07-21 16:24:05 -04:00
Kirill Bulatov
804da68af7
When renaming in project panel, select file names without extensions
2023-07-21 23:22:22 +03:00
Julia
2d8159998d
Put our downloaded copy of Node in the env for every NPM action
...
Intelephense (PHP language server) has a dependency on `protobufjs`
which invokes `node` in the `postinstall` script and if the user did
not have a system Node runtime installed that would fail. Have this
use our downloaded installation too
2023-07-21 16:13:00 -04:00
Kirill Bulatov
595bc16749
Add search in directory action in the project panel
2023-07-21 22:47:57 +03:00
Julia
e002d9efb0
Avoid panic from assuming a vim operator exists on the operator stack ( #2773 )
...
Fixes
https://linear.app/zed-industries/issue/Z-338/operator-popped-when-no-operator-was-on-the-stack-this-likely-means
Release Notes:
- Fixed a panic that could occur when invoking a Vim object without an
operator.
2023-07-21 14:47:38 -04:00
Julia
243a1a854e
Avoid panic from assuming a vim operator exists on the operator stack
2023-07-21 14:25:30 -04:00
Conrad Irwin
56c657fe79
Vim shortcuts ( #2760 )
...
Refactors some of the vim bindings to make the vim.json file less
obtuse.
Release Notes:
- vim: add `;` and `,` to repeat last `{f,F,t,T}`
- vim: add zed-specific shortcuts for common IDE actions:
- - `g A` to find all references
- - `g .` to open the code actions menu.
- - `c d` for rename
2023-07-21 10:31:18 -06:00
Conrad Irwin
4772e4ccee
vim: add , and ;
2023-07-21 09:50:22 -06:00
Conrad Irwin
a50d30bf8e
Quality of life shortcuts for code actions
2023-07-21 09:47:15 -06:00
Conrad Irwin
8ba69c15d1
refactor: Remove G/Z Namespace support
...
This previously enabled things like `d g g` to work, but we can
fix that instead by not clearing out pending vim state on change.
Either way, it is unnecessary and causes some user-confusion
(zed-industries/community#176 ), so remove this code for now; and use
comments to organize the file a bit instead.
2023-07-21 09:47:14 -06:00
Conrad Irwin
bf2583414b
Fix shift-enter in search ( #2772 )
...
Fixes shift-enter to go to previous result.
Release Notes:
- To type a newline in search use `ctrl-enter` (or `ctrl-shift-enter`
for a newline below).
2023-07-21 09:23:04 -06:00
Conrad Irwin
807279208d
Fix shift-enter in search
...
If you want to type a newline in an auto_height editor, ctrl and
ctrl-shift are your friends.
2023-07-21 09:10:12 -06:00
Joseph T. Lyons
5f89de0b80
Add key binding to close all docks ( #2769 )
...
Fixes:
https://linear.app/zed-industries/issue/Z-2680/add-a-close-all-docks-action
I frequently get stuck in this state:
<img width="1608" alt="SCR-20230721-dgvs"
src="https://github.com/zed-industries/zed/assets/19867440/13257e6d-f75a-4d1c-9718-153499e90c60 ">
I could zoom, but I dont want to in this case, I just want to close
everything, to get back to a truly decluttered state. Running 3 toggle
commands is cumbersome. I'd like to be able to close all docks with one
action.
I added an action with the key binding `alt-cmd-y` (similar
to`alt-cmd-t`, which is used to close all tabs). My original choice was
`alt-cmd-d` (`d` for dock), but that is the default macOS key binding to
hide the system dock.
Release Notes:
- Added a `workspace: close all docks` action (deployed via
`alt-cmd-y`).
2023-07-21 11:08:43 -04:00
Alex Viscreanu
1610e270d6
feat(workspace): add action for closing inactive editors on all panes
2023-07-21 13:16:00 +02:00
Kirill Bulatov
35400d5797
Do not highlight fake URLs in terminal ( #2770 )
...
Closes https://github.com/zed-industries/community/issues/1794
See also https://github.com/alacritty/alacritty/pull/7101
Release Notes:
- Fixed terminal incorrectly highlighting certain strings as URLs
2023-07-21 11:57:29 +03:00
Kirill Bulatov
cd3620692b
Do not highlight fake URLs in terminal
2023-07-21 11:28:56 +03:00
Joseph T. Lyons
d98fcc4402
Add key binding to close all docks
2023-07-21 02:44:44 -04:00
Conrad Irwin
57b6e25278
Fix enter in search ( #2768 )
...
Fixes a regression in non-vim search caused by my changes to vim search.
Release Notes:
- N/A
2023-07-20 20:53:31 -06:00
Conrad Irwin
7337910034
Fix enter in search
2023-07-20 20:48:36 -06:00
Mikayla Maki
76188c9508
Add wrap guides ( #2767 )
...
fixes https://github.com/zed-industries/community/issues/48
Release notes
- Added wrap guides and two associated language settings:
`"show_wrap_guides": bool` and `"wrap_guides": [..]`. The first controls
whether wrap guides are shown when `"soft_wrap":
"preferred_line_length"` is enabled and the second allows Zed to show
additional wrap guides at whichever column index you prefer.
Here's a screenshot of Zed with wrap guides at 60 and 90, and soft wrap
active with a preferred_line_length of 80:
<img width="956" alt="Screenshot 2023-07-20 at 4 42 11 PM"
src="https://github.com/zed-industries/zed/assets/2280405/48f36be1-3bdc-48eb-bfca-e61fcfd6dbc2 ">
2023-07-20 17:15:06 -07:00
Mikayla Maki
05a8409363
bump the brightness of the active wrap guide
2023-07-20 16:45:41 -07:00
Mikayla Maki
a9bfe97361
Add wrap guides and associated settings
2023-07-20 16:39:13 -07:00
Max Brunsfeld
81b05f2a08
Optimize glob filtering of semantic search
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-07-20 14:23:11 -07:00
Derek Briggs
4557adf693
Icon adjustments ( #2766 )
...
Icon tweaks
2023-07-20 15:06:50 -06:00
Derek Briggs
1d1da74d72
Adjustment
2023-07-20 15:05:26 -06:00
Derek Briggs
0769458ae4
Detail adjustments
2023-07-20 15:04:23 -06:00
Mikayla Maki
a85af79892
Folder icons ( #2764 )
...
- Updates icons and adds more
- Adds ability to choose folders or chevrons in user settings
- Adds ability to set indent size in user settings
2023-07-20 13:59:21 -07:00
Mikayla Maki
6b95ac9b26
fmt
2023-07-20 13:45:19 -07:00
Joseph T. Lyons
719c56734a
Reuse previously-obtained call object
2023-07-20 16:21:21 -04:00
Joseph T. Lyons
6095525b56
Add microphone toggle events ( #2765 )
...
Release Notes:
- N/A
2023-07-20 16:10:20 -04:00
Joseph T. Lyons
429daf5f8c
Add microphone events to calls
2023-07-20 16:00:11 -04:00
Joseph T. Lyons
7d3d54652b
Remove unused method
2023-07-20 15:54:26 -04:00
Derek Briggs
1242b5b4a2
Solid tab on folder icon
2023-07-20 13:13:44 -06:00
Julia
0b6155609d
In macOS platform layer map a ctrl-click to a right click ( #2755 )
...
Maps a ctrl left down event into a ctrl-less right down and then up pair
and filters out ctrl left up. Hopefully this ensures that mouse down/up
events remain balanced and somewhat matching.
Release Notes:
- Added the ability to ctrl-click in place of right click to summon
context menus
([#1150 ](https://github.com/zed-industries/community/issues/1150 )).
2023-07-20 14:54:55 -04:00
Derek Briggs
abb145da70
add indent size to project panel settings
2023-07-20 12:30:35 -06:00
Derek Briggs
95947f6d3a
icon adjustment
2023-07-20 12:29:57 -06:00
Derek Briggs
c56d62fd84
gitmodules to git icon
2023-07-20 12:29:50 -06:00
Derek Briggs
0e068a644f
organize settings
2023-07-20 12:23:47 -06:00
Derek Briggs
13ae1249f5
Allow for folders or chevrons
2023-07-20 12:23:28 -06:00
Nate Butler
2f4e5b7e0e
Add the local and declare keywords to bash syntax highlighting ( #2761 )
...
Release Notes:
- Improved Bash / Shell Script syntax highlighting
2023-07-20 14:17:29 -04:00
Derek Briggs
a7695c47bf
Update default settings
2023-07-20 12:03:07 -06:00
Derek Briggs
8f0b24b264
Add moar icons
2023-07-20 12:01:41 -06:00
Mikayla Maki
0e9cad4935
Add a double click to reset resized splits ( #2762 )
...
fixes https://github.com/zed-industries/community/issues/1791
Release Notes:
- Double clicking on split resize handles now resets the split's
dimensions
2023-07-20 10:55:19 -07:00
KCaverly
e02d6bc0d4
add glob filtering functionality to semantic search
2023-07-20 13:46:27 -04:00
Mikayla Maki
d84d663ac3
fmt
2023-07-20 10:36:23 -07:00
Mikayla Maki
4d1dbb8aa3
Add a double click to reset resized splits
2023-07-20 10:33:28 -07:00
Nate Butler
5d22a300c3
Add the local and declare keywords to bash syntax highlighting
2023-07-20 13:18:15 -04:00
Conrad Irwin
372f66c88a
Add workspace::ActivatePaneInDirection ( #2757 )
...
This change adds support for choosing a pane based on direction; and
adds default keybindings (`cmd+k cmd+{left,right,up,down}`) and vim
keybindings.
Release Notes:
- Add support for navigating to the next pane in a given direction using
`cmd+k cmd-{up,down,left,right}`
([#476 ](https://github.com/zed-industries/community/issues/476 ),
[#478 ](https://github.com/zed-industries/community/issues/478 ))
- Vim: adds support for many window related shortcuts: `ctrl-w
{h,j,k,l,up,down,left,right,w,W,p}` for navigating around panes, `ctrl-w
{q,c}` for closing panes and `ctrl-w {v,s}` for splitting panes.
2023-07-20 11:17:13 -06:00
Conrad Irwin
0e984e1e69
Ignore off-screen cursors
2023-07-20 11:11:47 -06:00
Conrad Irwin
464cc2e71a
Assertions for assumptions
2023-07-20 11:11:37 -06:00
Conrad Irwin
d6a463afb8
Better calculation of pane distance
2023-07-20 11:06:16 -06:00
Derek Briggs
f051e66231
code icon adjustment
2023-07-20 10:15:20 -06:00
Derek Briggs
a90b151d52
Updated icons with additions
2023-07-20 10:07:32 -06:00
Kirill Bulatov
54378a5f57
Keep basic line height for single line editors ( #2759 )
2023-07-20 17:37:41 +03:00
Kirill Bulatov
0237276557
Fully revert the line height change
2023-07-20 15:39:22 +03:00
Kirill Bulatov
0e6048a85d
Keep basic line height for single line editors
2023-07-20 13:42:11 +03:00
Kirill Bulatov
257dd57fe4
Properly display keybindings in context menus ( #2758 )
...
Fixes https://github.com/zed-industries/community/issues/1751


Release Notes:
- Fixed context menu keybindings not updating with custom keybinding
values
2023-07-20 12:25:41 +03:00
Kirill Bulatov
a5e63fbf77
Properly display keybindings in context menus
2023-07-20 12:18:04 +03:00
Conrad Irwin
15dc8b43c4
Default keybindings for activating pane by direction
...
Breaking change: previously cmd-k cmd-{left,right} moved to the
{previous,next} pane; now they will move in the specified direction.
2023-07-19 18:33:08 -06:00
Conrad Irwin
2762f9b1c6
vim: Add support for ctrl-w commands
...
Primarily {h,j,k,l,left,right,up,down} for moving to a pane by
direction; but also {w,W,p} for going forward/back, and {v,s} for
splitting a pane vertically/horizontally, and {c,q} to close a pane.
There are a large number of ctrl-w commands that are not supported, and
which fall into three buckets:
* switch this pane with that one (VScode also has this, and it's a
requested feature)
* move to top/bottom/leftmost/rightmost
* counts on any of these
* jump to "definition/file-under-cursor/etc.etc." in a new pane.
2023-07-19 18:29:13 -06:00
Conrad Irwin
e1379f0ef0
Add support for activating a pane by direction
...
Contributes: zed-industries/community#476
Contributes: zed-industries/community#478
2023-07-19 18:29:11 -06:00
Mikayla Maki
6f1dcb4e94
Fix buffer_line_height bugs ( #2756 )
...
Release Notes:
- Bug fix: Raise minimum line height to 1.1
- Bug fix: Disable buffer_line_height setting in non-buffer UI
2023-07-19 17:11:45 -07:00
Mikayla Maki
cb97f5a69c
fmt
2023-07-19 16:56:49 -07:00
Mikayla Maki
aa67413abc
Raise minimum line height to 1.1
...
Disable buffer_line_height setting in non-buffer editors
2023-07-19 16:55:28 -07:00
Conrad Irwin
b13e86aba6
Make tab non-functional in vim mode ( #2753 )
...
Make tab do nothing (a surprisingly common vim request).
- Fixes
([#988 ](https://github.com/zed-industries/community/issues/988 )).
- Fixes
([#897 ](https://github.com/zed-industries/community/issues/897 )).
2023-07-19 16:26:32 -06:00
KCaverly
efe973ebe2
add embedding query for json with nested arrays and strings
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-07-19 16:52:44 -04:00
Joseph T. Lyons
7e904183bf
Fix return type in watch_file_types()
2023-07-19 16:24:29 -04:00
KCaverly
9809ec3d70
update treesitter parsing to accomodate for collapsed nested functions
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-07-19 15:47:05 -04:00
Julia
2e3aa703d9
In macOS platform layer map a ctrl-click to a right click
2023-07-19 15:43:45 -04:00
Mikayla Maki
491b3d5515
Mute mics by default ( #2754 )
...
This adds a setting to mute mics by default.
fixes https://github.com/zed-industries/community/issues/1769
Release notes:
- Fixed a bug with gutter spacing on files that end on a new significant
digit
- Added a setting for muting on join, and set it to true by default.
2023-07-19 12:42:30 -07:00
Mikayla Maki
1e4bddd276
fmt
2023-07-19 12:34:56 -07:00
Mikayla Maki
5ceb258b3e
Mute mics by default
...
Fix bug when file ends in line with 1 more digit displayed than previous lines
Remove stale UI elements from voice call development
2023-07-19 12:34:24 -07:00
Joseph T. Lyons
34488ca863
v0.97.x dev
2023-07-19 15:33:58 -04:00
Joseph T. Lyons
64d134a0dc
Update Cargo.lock
2023-07-19 15:32:41 -04:00
Mikayla Maki
07dc82409b
File icons ( #2719 )
...
This PR adds the next most requested editor feature.
TODO:
- [x] Figure out styles and icons for supported file types with
fixes https://github.com/zed-industries/community/issues/206
Release Notes:
- Added file icons
2023-07-19 11:17:01 -07:00
Mikayla Maki
9c9ce15afc
Add a few more spare associations
2023-07-19 11:14:31 -07:00
Mikayla Maki
e3f9a01f6b
fmt
2023-07-19 11:10:31 -07:00
Derek Briggs
f4413b0969
Fix files that don’t have a prefix
2023-07-19 11:10:30 -07:00
Derek Briggs
c754c1e9e2
Update icons to new zed file icon set
2023-07-19 11:10:30 -07:00
Mikayla Maki
aacc4bb8b0
fmt
2023-07-19 11:10:30 -07:00
Mikayla Maki
8c855680e7
Make file types live reload
2023-07-19 11:10:30 -07:00
Mikayla Maki
96ef6ab326
Add willow license
2023-07-19 11:10:30 -07:00
Mikayla Maki
929a9f97b2
Fix tests
2023-07-19 11:10:30 -07:00
Mikayla Maki
fd72f4526d
Added file suffix and icon associations data
2023-07-19 11:10:30 -07:00
Mikayla Maki
d023189bda
Add settings
2023-07-19 11:10:30 -07:00
Mikayla Maki
d26f76ba90
Add suffix based file icons
2023-07-19 11:10:30 -07:00
Conrad Irwin
dd8863d0de
Make tab non-functional in vim mode
...
Fixes : zed-industries/community#988
Fixes : zed-industries/community#897
2023-07-19 10:25:17 -06:00
Conrad Irwin
843e74689d
Vim search ( #2657 )
...
This PR makes searching in vim mode significantly more like vim.
I re-used search to implement "go to next instance of word under cursor"
as this is how it works in vim (for integration with other
search-related keyboard shortcuts) and to avoid having to rewrite all
the logic to be vim-specific; but that did mean I had to make some
changes to the way search works (in particular to allow different
searches to run with specific options).
Release Notes:
- vim: `<enter>` in search now puts you back in normal mode
([#1583 ](https://github.com/zed-industries/community/issues/1583 ))
- vim: `?` now works to search backwards.
- vim: jumping to definitions or search results keeps you in normal mode
([#1284 ](https://github.com/zed-industries/community/issues/1284 ))
([#1514 ](https://github.com/zed-industries/community/issues/1514 ))
- vim: `n`/`N` are now supported to jump to next/previous match after a
search
([#1583 ](https://github.com/zed-industries/community/issues/1583 ))
- vim: `*`/`#`/`g*`/`g#` are now supported to jump to the next/previous
occurrence of the word under the cursor.
- vim: `gD` now jumps to type definition
2023-07-19 10:15:23 -06:00
Conrad Irwin
98b8008bcc
Merge branch 'main' into vim-search
2023-07-19 09:48:25 -06:00
Kirill Bulatov
c528880155
Clean up stale conflicting hints ( #2751 )
...
Closes
https://linear.app/zed-industries/issue/Z-2618/thread-main-panicked-at-excerpt-not-found-crateseditorsrcmulti
Closes
https://linear.app/zed-industries/issue/Z-2616/thread-main-panicked-at-excerpt-not-found-crateseditorsrcmulti
Fixes inlay hints cache not removing stale hints on invalidating
refreshes.
Release Notes:
- Fixes inlay hint panics after visible kinds settings update
2023-07-19 15:38:27 +03:00
Kirill Bulatov
3058a96dee
Clean up stale conflicting hints
2023-07-19 15:29:00 +03:00
Kirill Bulatov
c5e47f27f5
Rework terminal highlight mechanism ( #2743 )
...
<img width="807" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/ef3bfeef-28f5-458f-abe6-7c19bf820106 ">
Closes https://github.com/zed-industries/community/issues/10
Closes https://github.com/zed-industries/community/issues/560
Initial version of improved terminal highlights and "open link"
functionality: drops old behavior where URLs were highlighted on hover.
Now, Cmd + hover is needed to highlight the links and click opens both
URLs and files that exist (either abs paths, or anything relative to the
project workspace worktree roots).
Only paths eligible for opening are highlighted.
Release Notes:
- Improved terminal highlights and selections: Cmd+Click opens local
files and links
2023-07-19 09:05:48 +03:00
KCaverly
0e071919a0
parellelize embedding api calls
2023-07-18 16:09:44 -04:00
Kirill Bulatov
33921183dc
Avoid extra blinking on mouse moves
2023-07-18 22:59:41 +03:00
Kirill Bulatov
6ed7820f7c
Consider all terminal when searching for words
2023-07-18 22:59:41 +03:00
Kirill Bulatov
10db05f87f
Rework terminal highlight event flow
2023-07-18 22:59:41 +03:00
Kirill Bulatov
6f7a6e57fc
Avoid excessive blinking on cmd-hover
2023-07-18 22:59:41 +03:00
Kirill Bulatov
94358ffb16
Use lines and columns from the file url strings
2023-07-18 22:59:41 +03:00
Kirill Bulatov
82a9d53c8a
Only highlight the openable things
2023-07-18 22:59:41 +03:00
Kirill Bulatov
6349d90cac
Properly open project directories
2023-07-18 22:59:41 +03:00
Kirill Bulatov
6123c67de9
Detect and open URLs properly
2023-07-18 22:59:41 +03:00
Kirill Bulatov
23f25562b5
Map initial approach to string opening
2023-07-18 22:59:41 +03:00
Kirill Bulatov
f52722b6a4
Properly handle Cmd press for terminal highlights
2023-07-18 22:59:41 +03:00
Kirill Bulatov
75d900704e
Refactor terminal highlights and open mechanisms
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-07-18 22:59:41 +03:00
Kirill Bulatov
91ba80ae98
Ignore empty hover contents, trim final hover label text ( #2747 )
...
Removes empty hovers from appearing:

And trims final hover label to ensure no trailing whitespaces are
present:

Release Notes:
- Tidies up hover elements by trimming them and removing the empty ones
2023-07-18 22:59:24 +03:00
Kirill Bulatov
9aeb970f09
Ignore empty hover contents, trim final hover label text
2023-07-18 22:53:44 +03:00
Nathan Sobo
19e4cad7a9
WIP
2023-07-18 13:32:07 -06:00
Max Brunsfeld
342dbc6945
Fix rendering of project search while semantic index is indexing or running
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-07-18 12:01:42 -07:00
Max Brunsfeld
8d0614ce74
Populate project search results multi-buffer from semantic search
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-07-18 11:44:58 -07:00
Joseph T. Lyons
7cb5326ba0
Fix ZED_SERVER_URL port number
...
This change accidentally slipped into https://github.com/zed-industries/zed/pull/2746
2023-07-18 12:43:27 -04:00
Joseph T. Lyons
e73f394604
Add is_staff to events ( #2746 )
...
Release Notes:
- N/A
2023-07-18 12:41:24 -04:00
Joseph T. Lyons
018eb06091
Add is_staff to events
2023-07-18 12:32:53 -04:00
Nate Butler
b00703a149
Add syntax highlighting for Bash, Shell Scripts ( #2722 )
...
Release Notes:
- Added syntax highlighting for Bash, Shell Scripts
2023-07-18 12:21:52 -04:00
Nate Butler
bf2dcd4582
Update cargo.toml
2023-07-18 12:15:03 -04:00
Nate Butler
fab26267db
Merge branch 'main' into nate/add-bash-highlighting
2023-07-18 12:08:53 -04:00
KCaverly
80ef92a3e1
fix db schema update process to ensure all tables are dropped
2023-07-18 11:14:13 -04:00
KCaverly
ed1b1a5ccd
update logging for open ai embedding and remove redundant truncation
2023-07-18 11:00:21 -04:00
KCaverly
b9fdfd60f0
catch up with main
2023-07-18 10:26:28 -04:00
Julia
192f747bd1
Detect Node broken-ness initially ( #2745 )
...
This will help cases where Node is broken causing Copilot to fail to
start but because it doesn't install via NPM we would not have caught it
prior.
Release Notes:
- Improved detection of broken Node installation impacting Copilot
([#1551 ](https://github.com/zed-industries/community/issues/1551 )).
2023-07-18 10:20:47 -04:00
Julia
aee008440b
Detect Node broken-ness initially
...
This will help cases where Node is broken causing Copilot to fail to
start but because it doesn't install via NPM we would not have caught
it prior.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-07-18 10:02:14 -04:00
Piotr Osiewicz
137734cfcf
Piotr/z 2588 php ( #2721 )
...
Release Notes:
- Added syntax highlighting & Intelephense LSP support for PHP language.
([#46 ](https://github.com/zed-industries/community/issues/406 )).
2023-07-18 14:57:40 +02:00
Kirill Bulatov
009cf48b26
Slightly tidy up vector_db code ( #2744 )
...
Code snippet
```rust
fn main() {
//√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√√
}
```
has length of 191, but consists of 87 chars, and the debug code with
`.truncate(100)` panicked.
Fixed that issue, cc @KCaverly
Release Notes:
- N/A
2023-07-18 14:22:34 +03:00
Kirill Bulatov
a884bd77e1
Slightly tidy up vector_db code
...
Avoid panicking when truncating code with special chars
2023-07-18 14:06:57 +03:00
Piotr Osiewicz
fa529d9590
Remove redundant debug impl
2023-07-18 12:21:00 +02:00
Piotr Osiewicz
7fde3614fe
Remove leftover comment
2023-07-18 12:19:35 +02:00
Max Brunsfeld
afc4c10ec1
Start work on exposing semantic search via project search view
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-07-17 18:10:51 -07:00
Nathan Sobo
18b0385d73
WIP
2023-07-17 16:48:31 -06:00
Nathan Sobo
f5682a3cb5
Paint basic children
...
Co-Authored-By: Derek Briggs <derek.briggs@me.com >
2023-07-17 16:39:58 -06:00
KCaverly
d83c4ffb07
remove debug logging for enabled settings
2023-07-17 17:09:51 -04:00
Conrad Irwin
96abba2b7d
vim: Allow ctrl+[ as an alias for escape ( #2741 )
...
Also remove unneeded mappings in `g` and `z` modes
Release Notes:
- Adds `ctrl+[` as an alias for escape
([#538 ](https://github.com/zed-industries/community/issues/538 )).
2023-07-17 15:07:53 -06:00
KCaverly
8b42f5b1b3
rename vector_store crate to semantic_index
2023-07-17 17:06:10 -04:00
Conrad Irwin
9e44de90af
Allow ctrl+[ as an alias for escape
...
Also remove unneeded mappings in `g` and `z` modes
Fixes : zed-industries/community#358
2023-07-17 14:59:08 -06:00
KCaverly
e630ff38c4
add embedding treesitter queries for elixir
2023-07-17 16:29:25 -04:00
Joseph T. Lyons
9f650dfa52
Prevent multiple submissions of the same feedback text ( #2740 )
...
Fixes:
https://linear.app/zed-industries/issue/Z-2416/improvements-to-feedback-submission
We get a lot of duplicate messages through our in-app feedback. My best
guess is that because we do not tell the user we are doing anything, and
because submission takes awhile, users are hitting the submission button
mutliple times. This PR blocks the submission code, once an initial
submission is sent. If the original submission fails, we unblock the
submission code. The submit button is disabled and enabled accordingly
as well.
Release Notes:
- N/A
2023-07-17 16:15:49 -04:00
Mikayla Maki
1a8bfdfa21
feat(workspace): add option for moving the tab close button to the left ( #2739 )
...
Fixes https://github.com/zed-industries/community/issues/1760
Release Notes:
- Add option for chosing where the close button should be displayed on
editor tabs
2023-07-17 13:10:42 -07:00
Joseph T. Lyons
ede86a686c
Prevent multiple submissions of the same feedback text
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-07-17 16:10:34 -04:00
Alex Viscreanu
4efcf492ee
feat(workspace): add option for moving the tab close button to the left
2023-07-17 21:17:28 +02:00
Mikayla Maki
04625fe376
feat(workspace): show git status on editor tabs ( #2736 )
...
Fixes https://github.com/zed-industries/community/issues/1674
Release Notes:
- Added option for showing git status on editor tabs
2023-07-17 12:14:39 -07:00
KCaverly
f0bf60fded
add css as a embeddable file type in which the entire file is embedded individually
2023-07-17 14:53:57 -04:00
Alex Viscreanu
6793d4b6b8
feat(workspace): show git status on editor tabs
2023-07-17 20:53:42 +02:00
Conrad Irwin
c9bf407431
Avoid optional on select_match
2023-07-17 12:49:59 -06:00
KCaverly
1362c5a3d9
add embedding treesitter query for cpp
2023-07-17 14:43:29 -04:00
Max Brunsfeld
fef73ae921
Make macOS application menu aware of which key bindings are disabled ( #2735 )
...
Follow-up of https://github.com/zed-industries/zed/pull/2678
Deals with https://github.com/zed-industries/community/issues/772
Refreshes macOs menu panel on keymap file change and properly ignore
disabled actions.
Release Notes:
- Fixes a bug when disabled actions from macOs menu were still working
2023-07-17 11:20:41 -07:00
Julia
3e136943c0
After first panic, ignore others and tear down process even if in thread ( #2725 )
...
Spent a bit in a deep dive into how to handle this and honestly the
situation is rather unfortunate. The core problem is that when we have a
panic anywhere we need to tear down the app, and we'd like to do that as
cleanly as possible, avoiding throwing any other panics along the way if
possible.
We've been seeing a number of panics being reported which are
nonsensical, seemingly pointing to being a fallout panic from a worker
thread panic-ing, at which point we would write multiple panics to the
panic file, and we could possibly upload either both or the wrong panic
causing a wild goose chase. Unfortunately I've been entirely unable to
reproduce the specific panic we've been seeing but I was able to read
through the code responsible and confirm that under specific situations
a panic on one worker can cause another worker or the main thread to
also panic.
An easy solution to this is just to ignore any panics after the first
one. I'm thinking that *hopefully* we can trust the first panic to reach
the panic hook first so that the flag doesn't accidentally filter out
the panic we actually care about.
That being said we were expecting that to have already been the case
about which panic gets written to the panic file first, the first one in
the file being the one we upload, which doesn't seem to have been the
case. I'm hoping it was IO silliness causing that and that the flag
shouldn't be race-y, however this is still a shot in the dark. 🤞
As for cleanly shutting down, there's not really much we can do. One
thread physically cannot cause another to unwind without somehow sending
a message which isn't super useful. The only way for a thread to shut
down all threads and the process is to go nuclear and abort/exit the
process. This will never unwind other threads, effectively having the
same effect on those threads as compiling with `panic = "abort"` would.
With some (mis)use of `std::panic::resume_unwind` we can at least say
that for whatever thread actually panic-ed we will unwind, and any other
threads that panic as a result will probably get at least partway
through unwinding. This is weird, almost a combination of panic
rewinding and aborting, and may actually be worse than just biting the
bullet and aborting immediately.
I'm really not a fan of where I've ended up but it does seem to at the
very least an improvement. The main question in my mind at this point is
whether it would be better to attempt to unwind what we can or go all in
on abort. I'd love some input on that.
Release Notes:
- Improved panic reporting when a background thread panics.
2023-07-17 13:52:33 -04:00
Julia
6770aeeb3c
After first panic, ignore others and tear down process even if in thread
2023-07-17 13:43:43 -04:00
Kirill Bulatov
a4bf19c5bd
Simplify NoAction filtering logic
...
co-authored-by: Max Brunsfeld <max@zed.dev >
2023-07-17 20:42:35 +03:00
Sergey Onufrienko
cb8762d855
chore: add theme types docs
2023-07-17 17:54:37 +01:00
Kirill Bulatov
4cc06748c9
Ignore keybindings with NoAction in config overrides
2023-07-17 18:34:39 +03:00
Conrad Irwin
f887a17ffe
Merge branch 'main' into vim-search
2023-07-17 09:27:02 -06:00
KCaverly
cf0dd09b5c
update vector_store to accomodate for full file parsing for JSON, TOML and YAML files
2023-07-17 10:04:32 -04:00
KCaverly
4bece54655
update jsx family of languages for preceeding comments and nested exports
2023-07-17 09:22:37 -04:00
Piotr Osiewicz
dd6b674e7e
Remove dbg calls
2023-07-17 13:08:41 +02:00
Piotr Osiewicz
8642a1d074
Remove dbg! calls
2023-07-17 13:03:57 +02:00
Piotr Osiewicz
ee9123a7da
Remove test
2023-07-17 12:56:25 +02:00
Piotr Osiewicz
5b6582a7c2
rustfmt
2023-07-17 12:51:00 +02:00
Piotr Osiewicz
6c7a6d43fc
Cargo fix
2023-07-17 12:38:35 +02:00
Piotr Osiewicz
94796e943b
Set language id for PHP. LSP works!
2023-07-17 12:36:08 +02:00
Piotr Osiewicz
965cc2efbc
Fix a crash in tree-sitter-php
2023-07-17 12:07:25 +02:00
Piotr Osiewicz
11173b2199
Merge branch 'main' into piotr/z-2588-php
2023-07-17 11:47:08 +02:00
Piotr Osiewicz
dc557e1647
Add scaffolding of php language server
2023-07-17 11:43:32 +02:00
Kirill Bulatov
f5eac82e81
Reload menu after keybindings change
2023-07-17 12:30:42 +03:00
Kirill Bulatov
eaa8224076
Use id instead of type_id for actions
...
Currently, both are the same thing, so the logic is not changed.
2023-07-17 12:24:56 +03:00
Mikayla Maki
10a1df3faa
Fix fold indicator active hover style ( #2731 )
...
Release Notes:
- Fix: adjusted fold indicator styles
2023-07-15 23:06:01 -07:00
Mikayla Maki
419cbcbaf8
Fix fold indicator active hover style
2023-07-15 22:51:04 -07:00
Mikayla Maki
f24001c130
Simplify db tests ( #2730 )
...
The open_db function I wrote was doing far more than it needed to to
preserve the database and it was doing it badly. It no longer does all
of that.
2023-07-14 16:16:33 -07:00
Mikayla Maki
322ebc33d1
Simplify db tests
2023-07-14 16:09:02 -07:00
Nathan Sobo
248f5dfd4b
Get a red box on screen
...
Co-Authored-By: Derek Briggs <derek.briggs@me.com >
2023-07-14 17:03:07 -06:00
Joseph T. Lyons
4d91409bbc
Require only a single click to split pane when using cmd in project panel ( #2729 )
...
Release Notes:
- N/A
2023-07-14 18:31:38 -04:00
Joseph T. Lyons
c3e8ea304a
Require only a single click to split pane when using cmd in project panel
2023-07-14 18:27:40 -04:00
Max Brunsfeld
dcc2cd8dff
Optimize two slow code paths ( #2728 )
...
Linear:
https://linear.app/zed-industries/issue/Z-2578/zed-launches-very-slow-for-user
I was searching for the cause of a slow startup time reported in the
above issue, and I don't think I found it, but I did find two very
noticeable slow code paths while profiling, and fixed them.
### Notes
1. When starting the JSON language server, we provide it with a JSON
schema for our settings. For the `theme` setting, the JSON schema needs
to read all of the themes in the registry, to generate a list of valid
theme names. Previously, as part of this, we were deserializing each
theme from JSON, which took a lot of CPU. Now, we don't do that.
2. When an FS event occurs within a git repository, we reload the git
status for all entries in that git repository. Previously, we did that
via a separate `libgit2` call per FS entry (including ignored entries,
so many thousands in the case of the `zed` repo). Now we do one
`libgit2` call, asking for all of the statuses. Git carries an index of
all of the files with statuses, so this is fast.
Release Notes:
- Improved the the performance of starting up a JSON language server.
- Improved the performance of handling changes to git repositories, such
as changing branches or committing.
2023-07-14 14:38:55 -07:00
Nathan Sobo
87bafb04e2
Get playground app launching
...
Not sure if it should be in the workspace, but it's easier for now.
Co-Authored-By: Derek Briggs <derek.briggs@me.com >
2023-07-14 15:34:31 -06:00
Max Brunsfeld
b9e0074793
Perform only one git statuses call when reloading a git repo after it changes
2023-07-14 14:29:22 -07:00
Max Brunsfeld
c69d0d50cd
Avoid deserializing all themes to compute settings JSON schema
2023-07-14 14:29:22 -07:00
Nathan Sobo
4b2054215a
Get cell compiling
2023-07-14 15:20:53 -06:00
Alex Viscreanu
031172d3f2
file/symbol navigation modifiers ( #2727 )
...
Fixes https://github.com/zed-industries/community/issues/54
Release Notes:
- Added modifiers for opening files and symbols on a split
- Added modifiers for navigating to definition and type definitions on a
split
2023-07-14 22:03:48 +02:00
Alex Viscreanu
c0b2326053
fix(flexes): reset flexes when collapsing axis
...
Co-authored-by: Mikayla Maki <mikayla@zed.dev >
2023-07-14 21:49:33 +02:00
Alex Viscreanu
c7669317ec
feat(workspace): allow alternative actions to open files and symbols in split
...
Co-authored-by: Mikayla Maki <mikayla@zed.dev >
2023-07-14 21:49:15 +02:00
Piotr Osiewicz
369ccc725c
branch_list: Bail in case of missing worktrees. ( #2726 )
...
Z-2632
Release Notes:
- Fixed a crash that occurred when opening a modal branch picker without
a corktree.
2023-07-14 21:41:11 +02:00
Kirill Bulatov
cde5b3952d
Select all matches ( #2717 )
...
Closes https://github.com/zed-industries/community/issues/75
Closes https://github.com/zed-industries/community/issues/1749
The PR
* changes keybindings for `Editor && mode == auto_height` context:
before, `alt-enter` and `alt-shift-enter` added new lines in such
editors, including the one from buffer search.
New bindings are the same as in `Editor && mode == full` context.
* adds `search::SelectAllMatches` action and binds it to `Alt + Enter`
by default, to select all matches of a buffer search
The behavior mimics VSCode: we do not move the screen even if all
selections are out of the visible range (Cmd+G will navigate there) and
allow reselecting the results from both pane and search field, as long
as the search is not dismissed.
Release Notes:
- Added `search::SelectAllMatches` (`Alt + Enter` default) action to
place carets and select all buffer search results
([#75 ](https://github.com/zed-industries/community/issues/75 ),
[#1749 ](https://github.com/zed-industries/community/issues/1749 )).
2023-07-14 21:37:04 +03:00
KCaverly
2dae42b1ba
update embedding query for tsx to accomodate for leading comments
2023-07-14 14:25:08 -04:00
Nathan Sobo
0db8f681ba
WIP
2023-07-14 11:58:43 -06:00
KCaverly
d4971e9ead
update typescript parsing to manage for leading tsdoc comments
2023-07-14 13:47:10 -04:00
Piotr Osiewicz
c6195e6176
branch_list: Bail in case of missing worktrees.
...
Z-2632
2023-07-14 19:33:27 +02:00
Max Brunsfeld
0f5489397f
Fix syntax map issues that caused bugs in editing HEEx ( #2723 )
...
Fixes [Z-2575 : HEEX files are using deprecated commenting
sytle](https://linear.app/zed-industries/issue/Z-2575/heex-files-are-using-deprecated-commenting-sytle )
- Fixed a bug where comment toggling and bracket matching used the wrong
characters in templating languages like ERB and HEEx
([#1724 ](https://github.com/zed-industries/community/issues/1724 )).
- Fixed a bug where interpolated code was sometimes not parsed correctly
within templating languages like ERB and HEEx.
2023-07-14 10:23:25 -07:00
Piotr Osiewicz
c466711cd1
branch_list: Ensure index is within list bounds. ( #2724 )
...
Z-2630
Release Notes:
- Fixed a crash in branch list that occurred when confirming a match in
empty list.
2023-07-14 19:11:24 +02:00
Piotr Osiewicz
9c150252aa
branch_list: Ensure index is within list bounds.
...
Z-2630
2023-07-14 19:00:14 +02:00
Max Brunsfeld
31720d8825
Add randomized syntax map test with elixir within heex within elixir
2023-07-14 09:58:34 -07:00
Max Brunsfeld
21e7e35e73
Include newlines in between combined injection ranges on different lines
2023-07-14 09:25:56 -07:00
Max Brunsfeld
2f2ef7c165
Use workspace dependencies for tree-sitter grammars
2023-07-14 09:25:51 -07:00
Max Brunsfeld
2e2333107a
Find the layer with the smallest enclosing node in language_scope_at
2023-07-14 09:11:56 -07:00
KCaverly
3a625d15d3
update c embedding query for preceding comments
2023-07-14 11:33:49 -04:00
Kirill Bulatov
b14cd5f56d
Add a new button for the action
2023-07-14 17:32:10 +03:00
Kirill Bulatov
ccc78000bd
Preserve serach index for multicaret selection editor events
2023-07-14 14:47:12 +03:00
Nate Butler
c130dd6b47
Add styles for an action_button ahead of the "Select all matches" UI button
2023-07-14 14:47:12 +03:00
Kirill Bulatov
f710efca3b
Use a better name
2023-07-14 14:47:12 +03:00
Kirill Bulatov
2053418f21
Use VSCode-like shortcuts by default
2023-07-14 14:47:12 +03:00
Kirill Bulatov
29cbeb39bd
Allow selecting all search matches in buffer
2023-07-14 14:47:12 +03:00
Mikayla Maki
bf9dfa3b51
Add Svelte support ( #2720 )
...
fixes https://github.com/zed-industries/community/issues/432
Release Notes:
- Added support for the svelte language
2023-07-13 22:43:46 -07:00
Mikayla Maki
f1b034d4f8
fmt
2023-07-13 22:32:29 -07:00
Mikayla Maki
ff8a89a075
Refine svelte queries to work with zed-style highlights
...
Bump scheme dependency:
2023-07-13 22:30:58 -07:00
Mikayla Maki
1424a7a56a
Add svelte language server
...
Add svelte tree sitter
Add svelte config file
Add svelte highlighting
2023-07-13 21:43:53 -07:00
Mikayla Maki
415b8f0147
Add line height settings for the editor ( #2718 )
...
I'm a bit tired of the complaining for this feature. But also, we should
have it. Hence, this PR.
fixes:
https://github.com/zed-industries/community/issues/304#issue-1305112032
Release Notes:
- Added a `buffer_line_height` setting
2023-07-13 16:21:47 -07:00
Mikayla Maki
77c4fc98bd
Add line height settings for the editor
2023-07-13 16:14:33 -07:00
Mikayla Maki
b7ed467690
WIP: Resizing splits ( #2715 )
...
We're finally doing the thing.
TODO:
- [x] Choose an approach
- Decided to add a new element just for the pane axis, containing a
slimmed down copy of the flex code.
- [x] Wire through callbacks and pointers so that data goes where it
needs to
- [x] Do the flex juggling math on resize
- [x] Update the flexes when updating the split tree
- [x] Restore the active_pane_magnification setting
- [x] Serialize an axis' flexes
Release Notes:
- Made the center pane group splits resizable. Note that resizing is
disabled if the `active_pane_magnification` setting is changed from
default.
2023-07-13 15:29:34 -07:00
KCaverly
b38e3b804c
remove reindexing subscription, and add status methods for vector store
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-07-13 18:14:44 -04:00
Mikayla Maki
50623c018c
Fix serialization error
2023-07-13 14:48:56 -07:00
Mikayla Maki
9da8f609cf
tidy up names
2023-07-13 14:34:32 -07:00
Mikayla Maki
331fd896b5
fmt
2023-07-13 14:21:30 -07:00
Mikayla Maki
5797282b98
Add resising serialization
2023-07-13 14:21:14 -07:00
Sergey Onufrienko
036d3e811a
feat: add low, high, range and scaling
2023-07-13 22:09:31 +01:00
KCaverly
d8fd0be598
update vector store to remove dummy embeddings
2023-07-13 17:01:56 -04:00
KCaverly
623cb9833c
add tests for rust context parsing, and update rust embedding query
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-07-13 16:58:42 -04:00
KCaverly
0a0e40fb24
refactored code context retrieval and standardized database migration
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-07-13 16:34:32 -04:00
Mikayla Maki
00b04f1c85
Restore active pane magnification
2023-07-13 13:10:36 -07:00
KCaverly
5eab628580
Added go parsing for semantic search, and added preceeding comments on go and rust.
...
Co-authored-by: Alex <alexviscreanu@gmail.com >
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-07-13 14:33:31 -04:00
Mikayla Maki
d5f7ad08fa
Styled and refined behavior for split resizing
2023-07-13 11:28:21 -07:00
Nate Butler
ef7aa66959
Add first line pattern
2023-07-13 12:09:43 -04:00
Nate Butler
9a1a9813cb
WIP
2023-07-13 11:56:53 -04:00
KCaverly
a56d454a07
added semantic search support for c
2023-07-13 10:10:24 -04:00
Piotr Osiewicz
608c16342c
Update outline queries; add enum as a highlighted keyword
2023-07-13 12:23:49 +02:00
Kirill Bulatov
c2ffd8975b
Update another deprecated plugin ( #2716 )
...
Follow-up of https://github.com/zed-industries/zed/pull/2713 , fixing the
same for the bundling part of the pipeline.
Release Notes:
- N/A
2023-07-13 12:12:42 +03:00
Kirill Bulatov
8cce403c11
Update another deprecated plugin
2023-07-13 11:52:35 +03:00
Mikayla Maki
26b9be628e
Add the math for pane resizing
2023-07-12 22:35:51 -07:00
Mikayla Maki
5385ca411b
Added the new elements and wired through the pointers to update the pane axis ratios
2023-07-12 17:53:01 -07:00
Joseph T. Lyons
c9ba4c764a
Fix screen sharing panic introduced by call events ( #2714 )
...
Release Notes:
- Fixed a bug where Zed would crash when enabling screen share.
2023-07-12 16:22:42 -04:00
Joseph T. Lyons
6da5008f32
Fix screen sharing panic introduced by call events
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-07-12 16:12:07 -04:00
Mikayla Maki
488b41826b
WIP
2023-07-12 12:46:56 -07:00
Kirill Bulatov
1e8ee5361d
Update GH Actions ( #2713 )
...
Fixes deprecation warnings the CI jobs started to have:
https://github.com/zed-industries/zed/actions/runs/5535503789
<img width="1383" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/a33ecc2a-d6d3-451d-8033-da5754df4731 ">
Release Notes:
- N/A
2023-07-12 22:25:59 +03:00
Kirill Bulatov
7cbcc28b1b
Update checkout actions
2023-07-12 22:18:37 +03:00
Kirill Bulatov
d164034198
Allow all completions with preresolved additional text edits ( #2711 )
...
Deals with https://github.com/zed-industries/community/issues/752
Deals with https://github.com/zed-industries/community/issues/566
Currently, when converting from LSP to Zed objects, completions with
non-empty `additional_text_edits` are filtered out.
Later, all other completions form a list and the selected one gets the
`Editor::confirm_completion` call, which always queries an LSP
completion resolve request to get the `additional_text_edits` field.
Otherwise, `additional_text_edits` field is ignored entirely for the
rest of the completion lifetime — and we always pass the selected
completion through the resolve request.
The PR changes the logic, removing the `additional_text_edits` filtering
and instead of resolving every completion, now we check for
`additional_text_edits` in the completion before resolving: resolve
happens only if the data is absent.
Generally, feels like resolve has to happen before the completion
selection: LSP servers may send us markdown for completion documentation
preview pop ups and similar extra info.
Also, the server may lack resolve capabilities entirely, always sending
the request seems dangerous.
For now, the PR does not attempt to change either.
Release Notes:
- Brings rust-analyzer's postfix completions and others completions with
preresolved additional text edits
2023-07-12 22:10:18 +03:00
Nate Butler
ad4f5e55cb
Update docs ( #2712 )
...
Update docs
Release Notes:
- N/A
2023-07-12 15:00:11 -04:00
Kirill Bulatov
0c7949bdee
Force resolve all completions, to ensure their edits are up-to-date
...
co-authored-by: Max Brunsfeld <max@zed.dev >
2023-07-12 21:10:01 +03:00
Nate Butler
6297675055
Update building-zed.md
...
Co-Authored-By: Derek Briggs <1648941+PixelJanitor@users.noreply.github.com >
2023-07-12 14:09:21 -04:00
Derek Briggs
0e600ad2a4
Update README.md
2023-07-12 11:35:38 -06:00
Piotr Osiewicz
1cc8ecad12
Fix HTML injections (Thanks Max!)
...
Co-authored-by: Max <max@zed.dev >
2023-07-12 19:33:09 +02:00
Joseph T. Lyons
af9506b21d
v0.96.x dev
2023-07-12 13:30:28 -04:00
Kirill Bulatov
c732aa1617
Do not resolve completions if extra edits are available
2023-07-12 20:28:16 +03:00
Kyle Caverly
37568ccbf0
Vector store ( #2658 )
...
This PR includes a new crate, aimed at maintaining a consistent semantic
embedding database, for any project opened with Zed. At a high level,
for each file in a project, we parse the file with treesitter, embed the
symbol "document" objects with OpenAI, and maintain a consistent
database of these embeddings and offset locations in a sqlite database.
Once stored, we have built a simple modal interface for querying on
these symbols embeddings using natural language, offering the
opportunity to navigate to the selected symbol.
This initial PR is intended to provide this functionality only in preview,
as we explore, evaluate and iterate on the vector store.
- Full task details are provided in the [Semantic Search Linear
Project](https://linear.app/zed-industries/project/semantic-search-7c787d198ebe/Z )
2023-07-12 13:26:17 -04:00
KCaverly
c141519dba
merged with main
2023-07-12 13:15:23 -04:00
Derek Briggs
dc09a11090
Update README.md
2023-07-12 10:58:39 -06:00
Derek Briggs
2cb7d8aa96
Update README.md
2023-07-12 10:51:09 -06:00
Piotr Osiewicz
e69240cf13
Piotr/z 2556 add create branch button ( #2696 )
...
Release Notes:
- N/A
2023-07-12 18:46:33 +02:00
Nate Butler
001e848393
Update picker footer button style
...
Co-Authored-By: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com >
2023-07-12 12:40:37 -04:00
Piotr Osiewicz
2ac485a6ec
Merge branch 'main' into piotr/z-2556-add-create-branch-button
2023-07-12 18:11:52 +02:00
Piotr Osiewicz
c12821f6c5
Increase trailoff limit for modal branch picker. ( #2710 )
...
Z-2601
Follow-up to modal branch picker, this is the updated version:

Previously a trail off limit was much smaller:

Release notes:
- N/A
2023-07-12 18:07:54 +02:00
Piotr Osiewicz
6260d977fb
Increase trailoff limit for modal branch picker.
...
Z-2601
2023-07-12 17:58:00 +02:00
Kirill Bulatov
6d96c6ef51
Draft the postfix completions support
2023-07-12 18:32:03 +03:00
Julia
3db1aac119
Avoid user menu toggle button overlapping with tab bar top border ( #2707 )
...
Something little I noticed today
| | Normal | Hovered |
| ------------- | ------------- | - |
| Before | 

| 

|
| After | 

| 

|
Also makes it match the contacts button and seems to more closely
resemble the mockups as far as I can tell

Release Notes:
- Fixed the titlebar user menu button obscuring part of the border below
it.
2023-07-12 11:31:42 -04:00
Piotr Osiewicz
99c2395a86
chore: Disable http2 feature in isahc. ( #2709 )
...
This removes transitive dependency on libnghttp2, which is pretty heavy.
Release Notes:
- N/A
2023-07-12 17:24:01 +02:00
Piotr Osiewicz
78c8324698
chore: Disable http2 feature in isahc.
...
This removes transitive dependency on libnghttp2, which is pretty heavy.
2023-07-12 16:53:01 +02:00
Piotr Osiewicz
10c62779d9
chore: Bump ipc-channel to 0.16.1. ( #2708 )
...
Kevin Hovsäter reported a crash in cli when running 'cargo run -p cli --
--bundle-path target/debug/Zed'. It was caused by unaligned pointer
access in ipc-channel library; rustc started generating debug_asserts
for pointer alignment starting with 1.70, which we have
oh-so-conveniently upgraded to shortly before Kevin noticed a crash.
Rust 1.70 did not introduce this panic, it merely started triggering on
UB that was previously ignored.
/cc @hovsater @SomeoneToIgnore
Release Notes:
- N/A
2023-07-12 13:49:55 +02:00
Piotr Osiewicz
5086e37e73
chore: Bump ipc-channel to 0.16.1.
...
Kevin Hovsäter reported a crash in cli when running 'cargo run -po cli -- --bundle-path target/debug/Zed'. It was caused by unaligned pointer access in ipc-channel library; rustc started generating debug_asserts for pointer alignment starting with 1.70, which we have oh-so-conveniently upgraded to shortly before Kevin noticed a fix.
Rust 1.70 did not introduce this panic, it merely started triggering on UB that was previously ignored.
2023-07-12 13:27:14 +02:00
Piotr Osiewicz
b9f5cb0301
recent_projects: Perform fuzzy search on compacted paths. ( #2703 )
...
Match highlighting for recent projects picker was off, because the path
representation was compacted - for a path '/Users/hiro/Projects/zed' we
compact it to use a tilde instead of home directory. However, the
highlight positions were always calculated for a full path, leading to a
mismatch in highlights. This commit addresses this by running fuzzy
search on compacted paths instead of using long paths. This might lead
to a slight performance hit, but given that recent projects modal
shouldn't have that many items in the first place, it should be okay.
Z-2546
Release Notes:
- Fixed result highlighting in "Recent projects" modal.
2023-07-12 11:47:28 +02:00
KCaverly
33e2b52a01
added test registration for project settings
2023-07-11 20:12:43 -04:00
KCaverly
297fa029e3
Merge branch 'main' of github.com:zed-industries/zed into vector_store
2023-07-11 20:05:29 -04:00
KCaverly
b68cd58a3b
updated vector store settings to remove batch embeddings size
2023-07-11 19:54:03 -04:00
Max Brunsfeld
4b3bb2c661
Define semantic search action regardless of whether the feature is enabled
2023-07-11 15:02:43 -07:00
Max Brunsfeld
4a4dd39875
Fix TSX embedding query
2023-07-11 15:02:19 -07:00
Max Brunsfeld
d244c0fcea
Get vector store test passing - wait for indexing
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-07-11 14:30:11 -07:00
Max Brunsfeld
badf94b097
Update dot product test to use larger vectors
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-07-11 14:29:48 -07:00
Max Brunsfeld
08e24bbbae
Use cmd-ctrl-t for semantic search key binding
...
Co-authored-by: Kyle <kyle@zed.dev >
2023-07-11 14:29:06 -07:00
KCaverly
af7b2f17ae
added initial keymap for toggle semantic search
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-07-11 17:13:58 -04:00
Julia
ef296e46cb
Avoid user menu toggle button overlapping with tab bar top border
2023-07-11 16:49:53 -04:00
KCaverly
2ca4b3f4cc
cleaned up warnings and added javascript
2023-07-11 16:41:08 -04:00
KCaverly
debe6f107e
updated embedding queries for tsx and typescript
2023-07-11 16:22:40 -04:00
KCaverly
02f523094b
expanded embeddable context to accomodate for struct context and file paths
2023-07-11 15:58:33 -04:00
Mikayla Maki
9165320390
Fix a bug where the terminal would not be closed by the terminal exiting ( #2706 )
...
Release Notes:
- Fixed a bug where terminal tabs in the panel would not close on tty
process exit.
2023-07-11 12:23:26 -07:00
Mikayla Maki
550aa2d6bd
fmt
2023-07-11 12:17:50 -07:00
Mikayla Maki
be881369fa
Fix a bug where the terminal panel's items wouldn't be hooked up properly to workspace actions
2023-07-11 12:12:37 -07:00
Kirill Bulatov
5483bd1404
Refactor LSP restart logic ( #2705 )
...
Instead of storing `initialization_options` in every LSP adapter as
before, store previous LSP settings in `Project` entirely.
This way, we can later have use multiple different project
configurations per single LSP with its associated adapter.
Release Notes:
- N/A
2023-07-11 22:09:40 +03:00
Kirill Bulatov
4b4d049b0a
Refactor LSP restart logic
...
Instead of storing `initialization_options` in every LSP adapter as
before, store previous LSP settings in `Project` entirely.
This way, we can later have use multiple different project
configurations per single LSP with its associated adapter.
co-authored-by: Max Brunsfeld <max@zed.dev >
2023-07-11 21:56:55 +03:00
KCaverly
dd0dbdc5bd
brought up to speed with main
2023-07-11 14:50:48 -04:00
KCaverly
1649cf81de
added versioning to files table
2023-07-11 14:42:03 -04:00
Joseph T. Lyons
5012d618e6
Add call events ( #2704 )
...
Release Notes:
- N/A
2023-07-11 14:40:07 -04:00
Joseph T. Lyons
98a0113ac3
Add call events
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-07-11 13:58:55 -04:00
Kirill Bulatov
efe8b8b6d0
Revert "Fix language servers improper restarts"
...
This reverts commit 91832c8cd8 .
2023-07-11 20:46:45 +03:00
KCaverly
298c2213a0
added opt-in default settings for vector store
2023-07-11 12:03:56 -04:00
Kirill Bulatov
8161438a85
Fix language servers improper restarts ( #2702 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2595/language-servers-are-unnecessarily-restarted-when-unrelated-settings
Language servers mixed `initialization_options` from hardcodes and user
settings, fix that to ensure we restart servers on their settings
changes only.
Release Notes:
- N/A
2023-07-11 17:15:19 +03:00
Kirill Bulatov
748e7af5a2
Add a test
2023-07-11 17:10:34 +03:00
KCaverly
f5fec55930
updated vector_store to handle for removed files
2023-07-11 10:03:53 -04:00
Kirill Bulatov
91832c8cd8
Fix language servers improper restarts
...
Language servers mixed `initialization_options` from hardcodes and user
settings, fix that to ensure we restart servers on their settings
changes only.
2023-07-11 16:36:20 +03:00
Piotr Osiewicz
15010e94fd
fixup! recent_projects: Perform fuzzy search on compacted paths.
2023-07-11 15:29:15 +02:00
Piotr Osiewicz
f164eb5289
recent_projects: Perform fuzzy search on compacted paths.
...
Match highlighting for recent projects picker was off, because the path representation was compacted - for a path '/Users/hiro/Projects/zed' we compact it to use a tilde instead of home directory. However, the highlight positions were always calculated for a full path, leading to a mismatch in highlights.
This commit addresses this by running fuzzy search on compacted paths instead of using long paths. This might lead to a slight performance hit, but given that recent projects modal shouldn't have that many items in the first place, it should be okay.
Z-2546
2023-07-11 15:23:17 +02:00
Piotr Osiewicz
1fbf09fe4c
branches: Add a modal branch list. ( #2697 )
...
Extract branch list into a separate vcs_menu crate akin to
recent_projects. Add current bind for a modal branch to branch popover's
tooltip.
Z-2555
Release Notes:
- N/A
2023-07-11 14:40:00 +02:00
Piotr Osiewicz
a1fe5abeaf
Add rudimentary PHP syntax highlighting
2023-07-11 12:31:20 +02:00
Piotr Osiewicz
3c1ab3d0b8
Piotr/z 2590 search result marks jump around in scrollbar as cursor ( #2700 )
...
This closes ticket Z-2590 reported by @JosephTLyons . Thanks Joseph =)
Release Notes:
- N/A
2023-07-11 09:40:00 +02:00
Piotr Osiewicz
4125e7eccc
editor: Keep scrollbar up if there are selections ( #2698 )
...
Z-2556
/cc @JosephTLyons
Release Notes:
- N/A
2023-07-11 09:32:34 +02:00
Piotr Osiewicz
e83afdc5ab
Rename background_highlights_in_range_for_key to background_highlights_in_range_for
2023-07-11 09:31:08 +02:00
Piotr Osiewicz
4f60679861
Highlight only search results
2023-07-11 09:28:34 +02:00
KCaverly
dce72a1ce7
updated tests to accomodate for new dot location
2023-07-10 18:19:29 -04:00
KCaverly
307d8d9c8d
Reduced redundant database connections on each worktree change.
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-07-10 17:50:19 -04:00
KCaverly
82079dd422
Updated batching to accomodate for full flushes, and cleaned up reindexing.
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-07-10 16:33:14 -04:00
Sergey Onufrienko
fbf1552be9
Add color_family to theme
2023-07-10 20:41:39 +01:00
Piotr Osiewicz
a6d713eb3d
editor: Keep scrollbar up if there are selections
...
Z-2556
2023-07-10 17:44:27 +02:00
Piotr Osiewicz
e00e73f608
branches: Add a modal branch list.
...
Extract branch list into a separate vcs_menu crate akin to recent_projects.
Add current bind for a modal branch to branch popover's tooltip.
Z-2555
2023-07-10 17:18:12 +02:00
Nate Butler
6739c31594
Update assistant styles ( #2665 )
...
Updates the assistant with some style quality of life changes.
## Changes
Restyled the conversation list
<img width="646" alt="CleanShot 2023-07-10 at 10 25 23@2x"
src="https://github.com/zed-industries/zed/assets/1714999/5c9a4f94-11c1-4d28-8aac-4d38141829a9 ">
Updated the assistant header to be a bit more compact, and use a new tab
bar icon style. The existing tab bar icons will be updated in a later
PR.
<img width="646" alt="CleanShot 2023-07-10 at 10 26 30@2x"
src="https://github.com/zed-industries/zed/assets/1714999/3ef9a053-59fa-4d34-9b76-3bb2701acb33 ">
Updated the remaining token indicator to have 3 steps:
<img width="662" alt="CleanShot 2023-07-10 at 10 29 51@2x"
src="https://github.com/zed-industries/zed/assets/1714999/13d31545-5b00-427c-b7da-b4dfeac037d6 ">
Updated role labels, added a hover state to make it more clear these are
interactive
<img width="984" alt="CleanShot 2023-07-10 at 10 32 28@2x"
src="https://github.com/zed-industries/zed/assets/1714999/24748495-dde4-4ee9-98f1-6a082f0c1d4d ">
Release Notes:
- Improved the UI of some elements in the Assistant panel.
2023-07-10 10:54:20 -04:00
Piotr Osiewicz
a75a7e2b1d
Add tooltip to recent projects button ( #2694 )
...
Z-2545
Release Notes:
- N/A
2023-07-10 16:53:50 +02:00
Piotr Osiewicz
92a0a4e367
Add styles for branch create button
2023-07-10 16:51:18 +02:00
Nate Butler
273b9e1636
Avoid overlapping the scrollbar
2023-07-10 10:44:39 -04:00
Nate Butler
9ffe220def
Update tab_bar_button.ts
2023-07-10 10:24:24 -04:00
Nate Butler
4029481fd0
Merge branch 'main' into update-assistant-styles
2023-07-10 10:22:18 -04:00
Nate Butler
f0cddeb478
Update zoom icons
2023-07-10 10:09:59 -04:00
KCaverly
0189742497
pulled treesitter parsing to own file for ease of testing and management
2023-07-10 10:06:07 -04:00
Piotr Osiewicz
3318896ad9
Display key bind of a modal project picker
2023-07-10 14:29:30 +02:00
Piotr Osiewicz
6c8cb6b2a9
project_search: display result count on cmd-enter
...
It also focuses the first result (just like a normal enter).
2023-07-10 14:21:55 +02:00
Piotr Osiewicz
6e24ded2bc
collab_ui: Add tooltip to branches popover ( #2695 )
...
Z-2554
Release Notes:
- N/A
2023-07-10 14:20:12 +02:00
Joseph T. Lyons
52a497be21
Remove code block for GitHub release notes
...
Discord can directly render the Markdown now.
2023-07-08 18:03:18 -04:00
Conrad Irwin
b4b0f622de
Rebuild vim search experience on refactored code
2023-07-07 15:57:54 -06:00
Conrad Irwin
232d14a3ae
Make search less magic
...
Co-Authored-By: Antonio <antonio@zed.dev >
2023-07-07 15:57:54 -06:00
Conrad Irwin
dea728a7e5
Better waiting in tests
2023-07-07 15:57:54 -06:00
Conrad Irwin
6cf13c62d1
vim: ? to search backwards, and /<enter> to repeat search
2023-07-07 15:57:52 -06:00
Conrad Irwin
d70f415e8e
vim: add gD to go to type definition
2023-07-07 15:57:37 -06:00
Conrad Irwin
dbec2ed1f1
vim: add */#/g*/g# for jumping to next word
...
As in vim, this toggles the normal search experience.
2023-07-07 15:57:35 -06:00
Conrad Irwin
96ce0bb783
vim: Enter/n/N to navigate search results
2023-07-07 15:57:14 -06:00
Conrad Irwin
2ffce24ef0
vim: Don't enter visual mode in search/go to definition
...
Fixes : zed-industries/community#1514
Contributes: zed-industries/community#1284
2023-07-07 15:56:37 -06:00
Conrad Irwin
75fe77c11d
search: Allow running a search with different options
...
Refactor search options to use bitflags so that we can represent
the entire set of settings in one place.
2023-07-07 15:56:37 -06:00
Conrad Irwin
20d8a2a1ec
vim: indent in visual mode uses only one <
...
Fixes : zed-industries/community#1562
2023-07-07 15:56:35 -06:00
Conrad Irwin
460bf93866
vim: { } to navigate by paragraph ( #2668 )
...
As part of this I added `assert_shared_state()` to the
NeovimBackedTestContext so that it is more like a drop-in replacement
for the VimTestContext.
The remaining part of zed-industries/community#682 is adding bracket
matching to plain text. It looks like the current logic requires there
to be a tree sitter language for the language in order to support
bracket matching. I didn't fix this in this PR because I was unsure
whether to try and work around that, or to try and add a plain text tree
sitter language.
Release Notes:
- vim: support `{` and `}` for paragraph motion
([#470 ](https://github.com/zed-industries/community/issues/470 )).
- vim: fix `%` at the end of the line
([#682 ](https://github.com/zed-industries/community/issues/682 )).
2023-07-07 14:59:06 -06:00
Conrad Irwin
362023ccf2
vim: keymap tweaks ( #2674 )
...
A few small tweaks to fix some of the community issues
Release Notes:
- vim: Fix `escape` in command palette
([#1347 ](https://github.com/zed-industries/community/issues/1347 )).
- vim: Allow `^` as a motion in actions
([#856 ](https://github.com/zed-industries/community/issues/856 )).
- vim: Allow `ctrl-c` to exit visual mode
([#1447 ](https://github.com/zed-industries/community/issues/1447 )).
2023-07-07 14:58:01 -06:00
Julia
da7dce79f6
Prevent duplicate instances by coordinating via a socket ( #2691 )
...
We've been getting a bunch of panics from duplicate app instances
competing over the local sqlite DB. After chatting with @mikayla-maki we
determined it was probably best to add our own mechanism to prevent
duplicates rather than just relying on the OS. My logic is that we'd
need to build a system like this eventually for Windows/Linux anyway so
it's more appealing than reworking our local DB access to be able to
cooperate with another process while likely isn't something we want to
support anyway.
I attempted to keep this mechanism conservative so in the case of
another program interfering with it we should fail somewhat gracefully
and still continue to launch, albeit without the ability to prevent
another instance from launching.
Fixes
https://linear.app/zed-industries/issue/Z-2435/thread-background-executor-1-panicked-at-could-not-send-write-action
Release Notes:
- Added a mechanism to prevent duplicate Zed instances from launching to
avoid a crash.
2023-07-07 14:38:55 -04:00
KCaverly
3f5667b101
merged main
2023-07-07 14:24:29 -04:00
Julia
caa29d57c2
Avoid checking for duplicate instance when local DB is disabled
2023-07-07 14:20:39 -04:00
Julia
b70b76029e
Use different port and handshake for different release channels
2023-07-07 14:20:39 -04:00
Julia
66bf56fc4f
Prevent duplicate instances by coordinating via a socket
2023-07-07 14:19:44 -04:00
Piotr Osiewicz
4a69c71167
fixup! vcs: Add 'create branch' button
2023-07-07 18:37:53 +02:00
Piotr Osiewicz
cb24cb1ea5
vcs: Add 'create branch' button
2023-07-07 18:36:55 +02:00
Piotr Osiewicz
d69b07bafd
Add tooltip to recent projects button
...
Z-2545
2023-07-07 16:30:19 +02:00
Piotr Osiewicz
abf3b4a54e
chore: Replace lazy_static Mutex with const. ( #2693 )
...
Mutex::new() is const-stable as of Rust 1.63.
Release Notes:
- N/A
2023-07-07 15:07:12 +02:00
Antonio Scandurra
79ece8a86e
Skip key down event if preceded by its key equivalent version ( #2692 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2552/pressing-two-keystrokes-in-rapid-succession-ignores-the-latter
Previously, we would only track whether the previous key down event was
a key equivalent. However, this could cause issues when pressing certain
keystrokes in rapid succession, e.g.:
- Pressing `shift-right` (to select a character, dispatched as a key
equivalent)
- Pressing a character (with or without `shift` held down, dispatched as
a key down)
This would cause GPUI to ignore the second event because it was preceded
by a key equivalent event. With this commit, we track the last key
equivalent event, and skip the key down event only if it matches the
last key equivalent event.
Release Notes:
- Fixed a bug that could cause certain keystrokes performed in rapid
succession to incorrectly get ignored.
2023-07-07 12:13:32 +02:00
Antonio Scandurra
318deed25b
Skip key down event if preceded by its key equivalent version
...
Previously, we would only track whether the previous key down event
was a key equivalent. However, this could cause issues when pressing
certain keystrokes in rapid succession, e.g.:
- Pressing `shift-right` (to select a character)
- Pressing a character (with or without `shift` held down)
This would cause GPUI to ignore the second event because it was
preceded by a key equivalent event. With this commit, we track the
last key equivalent event, and skip the key down event only if it
matches the last key equivalent event.
2023-07-07 12:02:08 +02:00
KCaverly
c03dda1a0c
fixed bug on absolute vs relative path
2023-07-06 17:15:41 -04:00
KCaverly
6f1e988cb9
updated embedding treesitter query for python
2023-07-06 16:36:28 -04:00
KCaverly
7d634f66e2
updated vector_store to include extra context for semantic search modal
2023-07-06 16:33:54 -04:00
Kirill Bulatov
4ab2b8b24b
Restart LSP server on corresponding initialization_options change ( #2690 )
...
Inlay hints depend on LSP server settings, but servers do not update the
initialization options and query hints with old settings.
Generally, we cannot know whether a certain option can be changed
without server restart, which the name of the options implies too, so be
on the safe side and restart the server.
Hints will update automatically after the server either sends a /refresh
request or reports its work progress end after startup.
Release Notes:
- Fixed LSP server not restarting after `initialization_options`
settings changes
2023-07-06 23:32:34 +03:00
Kirill Bulatov
e6ec0af743
Remove redundant hint kind checks in tests
2023-07-06 23:27:25 +03:00
Kirill Bulatov
fff65968bf
Restart LSP server on initialization options change
2023-07-06 23:27:22 +03:00
KCaverly
e57f6f21fe
reindexing update to appropriately accomodate for buffer delay and persistent pending files list
2023-07-06 15:26:43 -04:00
Piotr Osiewicz
3ca0170264
Z 1332/show search results in scrollbar ( #2687 )
...
This PR adds highlighting of search results to the scrollbar.
Release Notes:
- Added highlighting of search results to the scrollbar.
2023-07-06 19:28:21 +02:00
KCaverly
a86b6c42c7
corrected batching order and managed for open ai embedding errors
2023-07-06 11:11:39 -04:00
Nate Butler
793eff1695
Update scrollbar selection style
2023-07-06 10:54:47 -04:00
Antonio Scandurra
b4ed0347b4
Filter out non-json files when loading conversations ( #2688 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2540/filter-out-non-conversation-files-from-the-assistant-history
2023-07-06 16:51:52 +02:00
Kirill Bulatov
2c7e5e0671
Clip find preceding boundary ( #2689 )
...
Fixes inability to do `alt + left arrow` when an inlay with `Bias::Left`
is right to the left of the caret.
Release Notes:
- N/A
2023-07-06 17:24:03 +03:00
Kirill Bulatov
11ae99fbd6
Add a test
2023-07-06 17:16:34 +03:00
Antonio Scandurra
708852aa00
Clip left when finding preceding (line) boundary
...
This fixes an issue that was causing `alt-left` to not move the cursor
when it was located right after an inlay hint with a `Left` bias.
2023-07-06 16:25:27 +03:00
Kirill Bulatov
348c93e8bb
Show inlay hints on startup for every language server with work events ( #2686 )
...
Closes https://linear.app/zed-industries/issue/Z-2537/inlay-hint-issues
Language servers such as typescript-language-servers report a single
work event, ending right after server's startup.
Other servers might send more similar event, also during startup. The
rest of the events are diagnostic-related and we filter them out.
React on such events with /refresh-like hint update, that will check
only the visible part of the editor for hints and might be replaced by
other /refresh requests, if needed.
Release Notes:
- N/A
2023-07-06 16:18:22 +03:00
Antonio Scandurra
5408275c7a
Filter out non-json files when loading conversations
2023-07-06 14:38:05 +02:00
Piotr Osiewicz
3e245fec90
Save a flushing line instead of discarding it
2023-07-06 13:52:03 +02:00
Piotr Osiewicz
5e7d9dc718
Add hunk merging
2023-07-06 13:31:45 +02:00
Piotr Osiewicz
b66453e771
fixup! Do not render multiple hunks for the same line
2023-07-06 12:11:08 +02:00
Kirill Bulatov
0b0a161626
Show inlay hints on startup for every language server with work events
...
Language servers such as typescript-language-servers report a single
work event, ending right after server's startup.
Other servers might send more similar event, also during startup.
The rest of the events are diagnostic-related and we filter them out.
React on such events with /refresh-like hint update, that will check
only the visible part of the editor for hints and might be replaced by
other /refresh requests, if needed.
2023-07-06 13:10:59 +03:00
Piotr Osiewicz
492b849ea1
Do not render multiple hunks for the same line
2023-07-06 12:09:33 +02:00
Piotr Osiewicz
8ced7ab00a
Merge branch 'main' into Z-1292/show_search_results_in_scrollbar
2023-07-06 11:43:44 +02:00
Kirill Bulatov
c298cf7527
Use less padding for typescript parameter hints ( #2684 )
...
Part of https://linear.app/zed-industries/issue/Z-2537/inlay-hint-issues
Release Notes:
- N/A
2023-07-06 11:23:20 +03:00
Kirill Bulatov
1936bdebb3
Use less padding for typescript parameter hints
2023-07-06 11:16:39 +03:00
Antonio Scandurra
dd6629416c
Fix panic when saved conversations directory changes ( #2685 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2542/deleting-assistant-conversations-with-zed-open-can-cause-a-crash
We were updating the view's state but missed a `notify`, which caused
the `UniformList` responsible for rendering the saved conversations to
panic when some files were deleted.
Release Notes:
- Fixed a crash that could happen when deleting a saved assistant
conversation from the filesystem.
2023-07-06 10:06:43 +02:00
Antonio Scandurra
f6c96ec892
Fix panic when saved conversations directory changes
...
We were updating the view's state but missed a `notify`, which caused
the `UniformList` responsible for rendering the saved conversations
to panic when some files were deleted.
2023-07-06 09:53:34 +02:00
Mikayla Maki
801f41e68e
Move audio dependency to dev
2023-07-05 12:15:56 -07:00
Mikayla Maki
8b8bafef22
Remove spurious audio depedency
2023-07-05 12:05:16 -07:00
Mikayla Maki
594b6e8d64
collab 0.16.0
2023-07-05 11:47:17 -07:00
Joseph T. Lyons
6a15ae9c01
v0.95.x dev
2023-07-05 14:17:37 -04:00
Nate Butler
76873c508a
Z-2276/Z-2275: Project & Branch switchers ( #2662 )
...
This PR adds project and branch switchers in top left corner.
Release Notes:
- Added a project & branch switcher under project name.
2023-07-05 13:09:40 -04:00
Piotr Osiewicz
b80281e556
cargo fmt
2023-07-05 18:57:06 +02:00
Nate Butler
1baa13561d
Update project & git menus to be Toggleable<Interactive<ContainedText>>
...
Co-Authored-By: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com >
2023-07-05 12:50:56 -04:00
KCaverly
afccf608f4
updated both embed and parsing tasks to be multi-threaded.
2023-07-05 12:39:08 -04:00
Nate Butler
de01fa1794
Update collaboration sounds, add sounds to screensharing ( #2679 )
...
Updates all collab sounds, add screen sharing sounds.
Release Notes:
- Improved collaboration sounds for joining and leaving a call, muting
and unmuting the mic.
- Added a sound when you start and stop screen sharing.
2023-07-05 12:30:47 -04:00
Piotr Osiewicz
0e0d78df84
Do not render recent paths in toolbar's project switcher
2023-07-05 18:04:40 +02:00
Piotr Osiewicz
ec47464bba
branch_list: Show match count on the right hand side of a header.
...
Co-authored-by: Antonio <antonio@zed.dev >
2023-07-05 16:56:08 +02:00
Piotr Osiewicz
85add260f6
Track regions instead of clicks.
...
Get rid of superfluous params in RenderParams related to hover & click state.
Co-authored-by: Antonio <antonio@zed.dev >
2023-07-05 16:48:52 +02:00
KCaverly
eff0ee3b60
enabled batching for embedding calls
2023-07-05 10:02:42 -04:00
Kirill Bulatov
91a94d299e
Simplify inlay map data ( #2683 )
...
Current logic does not need to access inlays by id in O(1), future
dynamic hints would need to know which hint they hover at, but that will
be done using binary search over the position's anchor we hover on;
nothing else seems to need this HashMap in the near future.
Because of that removal, no need to store `InlayId` apart from the
`Inlay`, hence remove the `InlayProperties` struct entirely.
This allows to eliminate a few generics along the way.
Release Notes:
- N/A
2023-07-05 16:31:47 +03:00
Piotr Osiewicz
cc88bff1ff
Fix click-through behaviour of git panel
...
Co-authored-by: Antonio <antonio@zed.dev >
2023-07-05 15:25:33 +02:00
Kirill Bulatov
d7f6b5e1a0
Remove InlayProperties
2023-07-05 16:17:14 +03:00
Kirill Bulatov
6ba1c3071a
Simplify inlay map data
2023-07-05 15:23:56 +03:00
Piotr Osiewicz
8b3b1a6074
fixup! Remove stacks from branch list header
2023-07-05 14:08:21 +02:00
Piotr Osiewicz
64b77bfa8d
Remove stacks from branch list header
...
Co-authored-by: Antonio <antonio@zed.dev >
2023-07-05 14:04:16 +02:00
Antonio Scandurra
5505ebf4bc
Support assistant: quote selection on multibuffers ( #2682 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2430/assistant-quote-selection-does-not-work-in-multi-buffer
Release Notes:
- Added support for invoking `assistant: quote selection` (`cmd->`) when
editing a multi-buffer.
2023-07-05 11:49:03 +02:00
Antonio Scandurra
d5f0df94f7
Support assistant: quote selection on multibuffers
2023-07-05 11:41:24 +02:00
Antonio Scandurra
1914037922
Restore focus to previously focused view when dismissing a modal ( #2680 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2500/focus-is-moved-from-the-assistant-panel-when-opening-and-closing
Release Notes:
- Fixed a bug that caused modals (such as the command palette) to not
restore focus when dismissing them.
2023-07-05 11:37:45 +02:00
Antonio Scandurra
03a00df8b1
Restore focus to previously focused view when dismissing a modal
2023-07-05 09:40:26 +02:00
Antonio Scandurra
a8602b2a0c
Add Modal::has_focus and introduce a ModalHandle trait object
2023-07-05 09:39:56 +02:00
Antonio Scandurra
25564ea058
Introduce a WindowContext::focus method that implies the window id
2023-07-05 09:39:04 +02:00
Nate Butler
a7ce602bac
Update collaboration sounds, add sounds to screensharing
2023-07-04 16:18:42 -04:00
Kirill Bulatov
31483db5d8
Accept null as a valid action, to disable a keystroke ( #2678 )
...
Deals with https://github.com/zed-industries/community/issues/772
Closes
https://linear.app/zed-industries/issue/Z-1518/allow-keybindings-to-be-removed
Now, configuration like
```json5
[
{
"context": "Editor",
"bindings": {
"alt-v": null,
}
}
]
```
will make `alt+v` to print `√` instead of moving the caret one page up.
Release Notes:
- Added a way to disable keybindings with `null` value
2023-07-04 21:51:46 +03:00
KCaverly
b6520a8f1d
updated vector_store to reindex on save after timed delay
2023-07-04 14:42:12 -04:00
Kirill Bulatov
4c51ab8a25
Accept null as a valid action, to disable a keystroke
...
co-authored-by: Mikayla Maki <mikayla@zed.dev >
2023-07-04 21:11:28 +03:00
Nate Butler
76af424d79
Rename color_scheme -> theme ( #2677 )
...
Just some theme tidying, renames some things to be more consistent with
our planned naming conventions going forward.
Release Notes:
- N/A (No public facing changes)
2023-07-04 11:56:30 -04:00
KCaverly
e45d3a0a63
WIP: initial reindexing logic worked out
2023-07-04 11:46:09 -04:00
Piotr Osiewicz
48371ab8b2
Remove PickerEvent::Dismiss emission from picker header
2023-07-04 16:30:17 +02:00
Piotr Osiewicz
e9b34de7c8
Fix click behaviour of vcs/project dropdowns
2023-07-04 16:00:59 +02:00
Conrad Irwin
0d18b72cf8
vim: Further improve ~ handling
...
Now works with Visual{line} mode, collapses selections like nvim,
and doesn't fall off the end of the line.
2023-07-03 23:58:09 -06:00
Nate Butler
f461a70970
Remove unused ts aliases
2023-07-04 01:37:45 -04:00
Nate Butler
65dbb38926
color_scheme -> theme
2023-07-04 01:20:56 -04:00
Nate Butler
c5a42c317a
Remove unused color_scheme field in the theme ( #2676 )
...
We removed the `theme_testbench` crate a while back - It seems like that
was the only thing using the `color_scheme` field in the exported theme.
Removing this from the theme removes something like 42k lines of
generated JSON every time we build the theme (2k lines / 28% of the
total lines per generated theme!)
Release Notes:
- N/A (No public facing changes)
2023-07-04 00:58:37 -04:00
Nate Butler
a732b2e043
Remove unused color_scheme field in the theme
...
I totally didn't mean to commit this right to main T_T
2023-07-04 00:44:12 -04:00
Nate Butler
c409059dc4
Revert "Remove unused color_scheme field in the theme"
...
This reverts commit 5a1476a1e5 .
2023-07-04 00:41:13 -04:00
Nate Butler
5a1476a1e5
Remove unused color_scheme field in the theme
2023-07-04 00:40:01 -04:00
Nate Butler
0b4c5db5e2
Use theme store to pass color_scheme directly to components ( #2675 )
...
This PR adds a theme store to allow components to directly access the
theme without requiring it to be passed down as props every time it is
used.
So before, you might need to do something like `text(theme, "variant",
"hovered")`, you could now just call `text("variant", "hovered")`.
This also means that style_trees don't need to be called with a theme
either:
```ts
export default function app(): any {
const theme = useTheme()
return {
meta: {
name: theme.name,
is_light: theme.is_light,
},
command_palette: command_palette(),
contact_notification: contact_notification(),
// etc...
}
}
```
We do this by creating a zustand store to store the theme, and allow it
to be accessed with `useThemeStore.getState().theme`.
```ts
import { create } from "zustand"
import { ColorScheme } from "./color_scheme"
type ThemeState = {
theme: ColorScheme | undefined
setTheme: (theme: ColorScheme) => void
}
export const useThemeStore = create<ThemeState>((set) => ({
theme: undefined,
setTheme: (theme) => set(() => ({ theme })),
}))
export const useTheme = (): ColorScheme => {
const { theme } = useThemeStore.getState()
if (!theme) throw new Error("Tried to use theme before it was loaded")
return theme
}
```
Release Notes:
- N/A (No public facing changes)
2023-07-04 00:37:45 -04:00
Nate Butler
8a5e7047f0
Update a few more components
2023-07-04 00:32:27 -04:00
Nate Butler
d5acfe8fc1
Use theme store to pass color_scheme directly to components
2023-07-04 00:13:04 -04:00
Conrad Irwin
0733e8d50f
Remove editor::Cancel binding from vim
...
When you hit <escape> in the command palette, it first editor::Cancel
because the command palette is also a focused editor; this binding was
catching before the `menu::Cancel` that you probably want.
From looking at the uses of editor::Cancel it seems like the only way to
trigger this is with <escape> in an editor. Rather than trying to hook
into the existing editor cancel and add vim-specific behaviour, we'll
instead take responsibility for binding directly to <escape> when
necessary.
Fixes : zed-industries/community#1347
2023-07-03 15:26:39 -06:00
Mikayla Maki
f8316dd127
Add sound effects to calls ( #2673 )
...
This PR adds joined, leaving, mute, and unmute sound effects to Zed.
Release Notes:
- Added joined, leaving, mute, and unmute sound effects (preview-only)
2023-07-03 13:55:48 -07:00
Mikayla Maki
c700342a1c
Guard against uninstantiated globals in tests
2023-07-03 13:48:17 -07:00
Mikayla Maki
0e4c904091
Add joined sound effect when new participants join the room
2023-07-03 13:36:03 -07:00
Mikayla Maki
d2127825e3
Add first-pass sound support to Zed
2023-07-03 13:30:04 -07:00
Conrad Irwin
fe57e04016
vim: Allow ^ as a motion
...
Fixes : zed-industries/community#856
2023-07-03 12:55:41 -06:00
Conrad Irwin
b055f594b0
vim: ctrl-c to exit visual mode
...
Fixes : zed-industries/community#1447
Contributes: zed-industries/community#1089
2023-07-03 12:52:33 -06:00
Piotr Osiewicz
14eab4e94f
branch list: dismiss correct window on PickerEvent.
...
Query proper window
2023-07-03 19:22:43 +02:00
Kirill Bulatov
6c01aeaf77
Do not perform OnTypeFormating after pair brace insert ( #2672 )
...
Closes
https://linear.app/zed-industries/issue/Z-2358/ra-brace-auto-surround-causes-duplicate-end-char-with-selection
Release Notes:
- Fixed a bug when duplicate brace appeared after selected text got
surrounded with braces
2023-07-03 17:26:55 +03:00
Piotr Osiewicz
806268f0db
Merge branch 'main' into git-menu
2023-07-03 16:25:36 +02:00
Kirill Bulatov
85701c9b80
Do not perform OnTypeFormating after pair brace insert
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-07-03 17:21:44 +03:00
Piotr Osiewicz
4eedc3e646
Remove flex from underneath the pickers
2023-07-03 16:16:14 +02:00
Kirill Bulatov
8efb66be67
Do not add extra spaces to hints ( #2671 )
...
Closes
https://linear.app/zed-industries/issue/Z-2526/inlay-hints-in-typescript-types-have-extra-space-before#comment-ac88a101
Release Notes:
- N/A
2023-07-03 11:18:07 +03:00
Kirill Bulatov
43d4f04331
Do not add extra spaces to hints
2023-07-03 11:17:12 +03:00
Conrad Irwin
e36d5f41c8
Fix % when on the last character of the line
...
Contributes: zed-industries/community#682
2023-07-01 13:51:11 -06:00
Piotr Osiewicz
026ad191eb
Dismiss dropdowns on click out
2023-07-01 01:49:00 +02:00
Piotr Osiewicz
525521eeb3
Render match count next to branch label
2023-07-01 01:38:36 +02:00
Mikayla Maki
138de37cbf
Add basic sound handling infrastructure
2023-06-30 16:10:49 -07:00
KCaverly
18a5a47f8a
moved semantic search model to dev and preview only.
...
moved db update tasks to long lived persistent task.
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-06-30 18:41:19 -04:00
KCaverly
3408b98167
updated file compare in the semantic indexing engine, to work off of modified system times as opposed to file hashes
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-06-30 16:53:23 -04:00
KCaverly
36907bb4dc
updated vector store indexing to only use languages with an embedding.scm treesitter query
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-06-30 16:14:11 -04:00
Kirill Bulatov
e017d62e92
Remove excessive hint update queries ( #2667 )
...
Closes
https://linear.app/zed-industries/issue/Z-2513/panic-in-refresh-inlay-hints
* Filter out queries for outdated buffers just before hint tasks spawn:
multicaret edits might emit standalone events simultaneously
* Only spawn inlay update tasks for visible buffers with corresponding
language
* Do not spawn tasks for local projects' buffers without LSP servers
Release Notes:
- N/A
2023-06-30 22:15:36 +03:00
Kirill Bulatov
ae54e1d224
Remove excessive hint update queries
...
* Filter out queries for outdated buffers just before hint tasks spawn:
multicared edits might empit standalone events simultaneously
* Only spawn inlay update tasks for visible buffers with corresponding
language
* Do not spawn tasks for local projects' buffers without LSP servers
2023-06-30 22:03:21 +03:00
Max Brunsfeld
f83514cde4
Fix regression in handling git FS events ( #2670 )
...
As part of an optimization in
https://github.com/zed-industries/zed/pull/2663 , I changed the way that
the worktree ignores FS events within unloaded directories. But this
accidentally prevented us from detecting some events that occur inside
of `.git` directories.
In this PR, I've made further tweaks to which FS events we can ignore.
We now explicitly opt *in* to scanning `.git` (shallowly) directories
(even though they are ignored). Note that we still don't recursively
scan the git directory (including all of the files inside `objects`
etc). This seems like the correct amount of work to do, and from my
testing (and our unit tests that use the real FS and real git
repositories), it seems to work correctly.
Release Notes:
- Fixed a bug where Zed would not detect some git repository changes
(preview only).
2023-06-30 11:40:49 -07:00
Max Brunsfeld
92df76e632
Fix accidental ignoring of git FS events
2023-06-30 11:20:50 -07:00
Piotr Osiewicz
7c2c1a279b
Add missing rust-side definitions
2023-06-30 20:09:30 +02:00
Piotr Osiewicz
cec884b5a5
Add styles for project name/git menu
2023-06-30 20:07:44 +02:00
Piotr Osiewicz
a5d9a10d7b
Focus dropdowns on open
2023-06-30 19:48:28 +02:00
Joseph T. Lyons
6042cf928c
Fix bug preventing the assist command from working in certain keymaps ( #2669 )
...
Fixes: https://github.com/zed-industries/community/issues/1712
The keymaps were adding in a `"cmd-enter": "editor::NewlineBelow",`
entry in the context of `Editor`, and this was clobbering the assist
command in the assistant panel context. Zed now defines this command in
the default keymap under the context of `"context": "Editor && mode ==
full"`. All I needed to basically do was remove that command from the
keymaps. I also removed the `"cmd-shift-enter": "editor::NewlineAbove"
from the `Editor` context in those keymaps as wel, as it is also defined
in the default keymap.
Release Notes:
- Fix bug preventing the `assistant: assist` command from working in
certain keymaps
2023-06-30 13:32:42 -04:00
Joseph T. Lyons
4a654f5252
Fix bug preventing the assist command from working in certain keymaps
2023-06-30 13:27:48 -04:00
KCaverly
0db0876289
implemented file deletes on project indexing
2023-06-30 11:01:35 -04:00
Mikayla Maki
a9c1395b9b
WIP: Add the ability to make new directories by adding slashes to a file name ( #2638 )
...
This PR adds a new way to make files / directories in the project panel,
by writing a path instead of a file.
TODO:
- [x] Solve a race condition that sometimes causes the newly created
file to not be selected / expanded correctly.
- [x] Change file refreshes to be minimal
Release Notes:
- Adds the ability to create new folders in the create-file action
([743](https://github.com/zed-industries/community/issues/743 ))
2023-06-30 07:46:32 -07:00
Piotr Osiewicz
ed75c31640
Improve styling of git menu
2023-06-30 16:38:38 +02:00
Piotr Osiewicz
b699e5c142
Add styles to git menu
2023-06-30 16:23:27 +02:00
KCaverly
e3ab54942e
removed sleep from directory scanning as fixes upstream appear to be scanning correctly
2023-06-30 10:17:31 -04:00
KCaverly
1d737e490b
Merge branch 'main' of github.com:zed-industries/zed into vector_store
2023-06-30 09:58:13 -04:00
Piotr Osiewicz
3be8977ee8
Switch branches within spawn()
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
c1a6292152
Add missing call to cx.notify
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
081e340d26
Do not query db on foreground thread.
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
818ddbc703
Make project dropdown exclusive wrt git menu
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
888d3b3fd6
Project dropdown menu
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
d000ea9739
Fix warning about unused variable
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
1eb0f3d091
Update toast for checkout failure
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
98f71a7fa3
Trail off project/branch name
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
e57364ede6
Remove unnecessary imports
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
aeafa6f6d6
Fix build after rebase
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
c84f3b3bfc
Add toast for git checkout failure
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
54fad5969f
List recent branches
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
3027e4729a
Add timestamps to branches
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
6747acbb84
Trail off branch names
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
ac6e9c88e9
Render header and footer of git menu
2023-06-30 14:05:55 +02:00
Piotr Osiewicz
d8d0bdc479
WIP: git menu
2023-06-30 14:05:55 +02:00
Mikayla Maki
3d6e063a6d
Fix method header
2023-06-29 23:53:57 -07:00
Mikayla Maki
d22a576f5e
fix failing test
2023-06-29 23:50:24 -07:00
Conrad Irwin
abb58c41db
vim: Fix edge-case in } when trailing newline is absent
...
Added .assert_shared_state() to NeovimBackedTestContext – although it's
not strictly necessary to show the expected behaviour in the test file
(as we can just compare to neovim's JSON recording), it makes it much
easier to understand what we're testing.
2023-06-29 23:31:22 -06:00
Conrad Irwin
9ee2707d43
vim: Add }/{ for start/end of paragraph
...
Fixes : zed-industries/community#470
2023-06-29 23:31:22 -06:00
Mikayla Maki
a9a51ab3ad
Added more tests and minimal file updates
2023-06-29 18:21:35 -07:00
Mikayla Maki
a6dabf7acf
Make path updates minimal
2023-06-29 18:15:40 -07:00
Mikayla Maki
787412b545
fmt and update dependency
2023-06-29 17:49:42 -07:00
Mikayla Maki
cd670e340f
Fix edge case with absolute file paths
2023-06-29 17:48:01 -07:00
Mikayla Maki
33f5248d4f
Add the ability to make new directories by adding slashes to a file name
2023-06-29 17:35:22 -07:00
Mikayla Maki
f6b64dc67a
Add click out events to GPUI ( #2659 )
...
This PR adds a new mouse event type for catching when a click happens
outside of a given region.
This was added because I noticed a 'race condition' between the context
menu and the buttons which deploy a context menu. Buttons use on
an`on_click()` handler to deploy the context menu, but the context menu
was closing itself with an `on_down_out()` handler. This meant that the
order of operations was:
0. Context menu is open
1. User presses down on the button, _outside of the context menu_
2. `on_down_out()` is fired, closing the context menu
3. User releases the mouse
4. `click()` is fired, checks the state of the context menu, finds that
it's closed, and so opens it
You can see this behavior demonstrated with this video with a long-click
here:
https://github.com/zed-industries/zed/assets/2280405/588234c3-1567-477f-9a12-9e6a70643527
~~Switching from `on_down_out()` to `on_click_out()` means that the
click handler for the button can close the menu before the context menu
gets a chance to close itself.~~
~~However, GPUI does not have an `on_click_out()` event, hence this
PR.~~
~~Here's an example of the new behavior, with the same long-click
action:~~
https://github.com/zed-industries/zed/assets/2280405/a59f4d6f-db24-403f-a281-2c1148499413
Unfortunately, this `click_out` is the incorrect event for this to
happen on. This PR now adds a mechanism for delaying the firing of a
cancel action so that toggle buttons can signal that this on_down event
should not result in a menu closure.
Release Notes:
* Made context menus deployed from buttons toggle, instead of
hide-and-re-show, visibility on click
2023-06-29 17:33:37 -07:00
Mikayla Maki
73b0f3b23d
fmt
2023-06-29 17:19:35 -07:00
Mikayla Maki
5366631173
Remove on_click_out handler from context menu
...
Add 'delay_cancel()' method and on_down handler to relevant buttons
2023-06-29 17:10:51 -07:00
Nate Butler
530561e4eb
Extract assistant tool buttons into tab_bar_button
2023-06-29 18:13:31 -04:00
Nate Butler
77b120323b
Add low_tokens_remaining case to the assistant
2023-06-29 17:44:47 -04:00
Nate Butler
d6112e4a59
Add doc comments for ColorScheme layer properties
2023-06-29 17:32:19 -04:00
Nate Butler
2678dfdc57
Update assistant styles
2023-06-29 17:32:04 -04:00
Kirill Bulatov
167dd1c5d2
Support basic inlay hints ( #2660 )
...
Part of https://github.com/zed-industries/community/issues/138
Part of https://linear.app/zed-industries/issue/Z-477/inlay-hints
Supports LSP requests for inlay hints, LSP /refresh request to reload
them.
Reworks DisplayMap and underlying layer to unite suggestions with inlay
hints into new, `InlayMap`.
Adds a hint cache inside `Editor` that tracks buffer/project/LSP request
events, updates the hints and ensures opened editors are showing up to
date text hints on top.
Things left to do after this PR:
* docs on how to configure inlay hints
* blogpost
* dynamic hints: resolve, hover, navigation on click, etc.
Release Notes:
- Added basic support of inlay hints
2023-06-29 22:49:39 +03:00
Kirill Bulatov
b146762f68
Remove a flacky test, fix the failing one
2023-06-29 22:45:04 +03:00
Kirill Bulatov
652909cdba
Post-rebase fixes
2023-06-29 22:39:33 +03:00
Kirill Bulatov
3445bc42b6
Invalidate refresh tasks better
2023-06-29 22:39:18 +03:00
Kirill Bulatov
98edc0f885
Simplify the hint cache code
2023-06-29 22:39:18 +03:00
Kirill Bulatov
083e4e76e2
Better tests, invalidate multibuffer excerpts better
2023-06-29 22:39:18 +03:00
Kirill Bulatov
943c93fda7
Simplify hint task queueing
2023-06-29 22:39:18 +03:00
Kirill Bulatov
30e77aa388
More inlay hint cache tests
2023-06-29 22:39:18 +03:00
Kirill Bulatov
429a9cddae
Use fold points to go to display map's prev/next line boundary
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:39:18 +03:00
Kirill Bulatov
bb9ade5b6f
Fix wrap map test
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:39:18 +03:00
Kirill Bulatov
2b59f27c3b
Fix fold map tests
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:39:18 +03:00
Kirill Bulatov
0972766d1d
Add more hint tests
2023-06-29 22:39:18 +03:00
Kirill Bulatov
15e0feb91d
Move highlights from fold to inlay randomized tests
2023-06-29 22:39:18 +03:00
Kirill Bulatov
667b70afde
Move hint settings on the language level
2023-06-29 22:39:18 +03:00
Kirill Bulatov
480d8c511b
Theme hints and suggestions differently
2023-06-29 22:39:18 +03:00
Kirill Bulatov
3312c9114b
Improve inlay hint highlights
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:39:18 +03:00
Kirill Bulatov
2c54d926ea
Test inlay hint cache
2023-06-29 22:39:18 +03:00
Nate Butler
143a020694
Update Hint Style
...
zzz
2023-06-29 22:39:17 +03:00
Kirill Bulatov
67214f0e55
Only skip /refresh inlay queries when vislble range is not updated
2023-06-29 22:25:50 +03:00
Kirill Bulatov
096bad1f73
Revert useless changes, simplify
2023-06-29 22:25:50 +03:00
Antonio Scandurra
f77b680db9
Account for inlay biases when clipping a point
2023-06-29 22:25:50 +03:00
Antonio Scandurra
976edfedf7
Add Cursor::next_item
2023-06-29 22:25:50 +03:00
Kirill Bulatov
5c21ed4263
Properly filter out task hints
2023-06-29 22:25:50 +03:00
Kirill Bulatov
dfb30218ca
Remove mutex usage from *Map contents
2023-06-29 22:25:50 +03:00
Kirill Bulatov
acef5ff195
Query hints when editors gets open and visible
2023-06-29 22:25:50 +03:00
Kirill Bulatov
11fee4ce42
Do not eagerly cancel running tasks
2023-06-29 22:25:49 +03:00
Kirill Bulatov
4d4544f680
Split excerpts into mutliple ranges for inlay hint queries
2023-06-29 22:25:49 +03:00
Kirill Bulatov
2c7900e11b
Use excerpt visible range in query filtering
2023-06-29 22:25:49 +03:00
Kirill Bulatov
83b3a914bc
Support better inlay cache parallelization
2023-06-29 22:25:49 +03:00
Kirill Bulatov
890b164278
Forward inlay hint refresh requests to clients, test coop inlay hints
2023-06-29 22:25:49 +03:00
Kirill Bulatov
a68e68a0d9
Properly filter out new hints outside of excerpts' visible ranges
2023-06-29 22:25:49 +03:00
Kirill Bulatov
ba3d1e4dba
Deduplicate inlay hints queries with buffer versions
2023-06-29 22:25:49 +03:00
Kirill Bulatov
f25a09bfd8
Avoid excessive allocations with Arc around excerpt cached inlays
2023-06-29 22:25:49 +03:00
Kirill Bulatov
48982c3036
Filter away new hints not in excerpt range
2023-06-29 22:25:49 +03:00
Kirill Bulatov
316e19ce94
Remove stale cancelled inlay hints workaround
2023-06-29 22:25:49 +03:00
Kirill Bulatov
96a34ad0ee
Use text anchors as hint position in hints cache
...
co-authored-by: Max Brunsfeld <max@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
781fa0cff4
Deduplicate LSP requests on multibuffer scroll
2023-06-29 22:25:49 +03:00
Kirill Bulatov
c61de29c11
Use proper anchors for remote LSP queries
2023-06-29 22:25:49 +03:00
Kirill Bulatov
cb4b92aa61
Simplify hint event management slightly
2023-06-29 22:25:49 +03:00
Kirill Bulatov
d59e91aff2
Insert new hints into cache better
2023-06-29 22:25:49 +03:00
Kirill Bulatov
d6828583d8
Box the cache for better performance
2023-06-29 22:25:49 +03:00
Kirill Bulatov
1722d61190
Mitigate odd offset calculations
2023-06-29 22:25:49 +03:00
Kirill Bulatov
7fddc223cd
Move away heavy inlay computations into background tasks
2023-06-29 22:25:49 +03:00
Kirill Bulatov
31f0f9f7b1
Forbid extra inlay updates
2023-06-29 22:25:49 +03:00
Kirill Bulatov
97e5d40579
Add snapshot version to use when avoiding wrong state updates
2023-06-29 22:25:49 +03:00
Kirill Bulatov
8d982a6c2d
Finish modelling
2023-06-29 22:25:49 +03:00
Kirill Bulatov
4c78019317
Start to model the background threads for InlayHintCache
2023-06-29 22:25:49 +03:00
Kirill Bulatov
2f1a27631e
React on multibuffer scrolls again
2023-06-29 22:25:49 +03:00
Kirill Bulatov
a31d3eca45
Spawn cache updates in separate tasks
2023-06-29 22:25:49 +03:00
Antonio Scandurra
9698b51524
Prevent insertion of empty inlays into InlayMap
2023-06-29 22:25:49 +03:00
Kirill Bulatov
3b9a2e3261
Do not track editor ranges in InlayHintCache
2023-06-29 22:25:49 +03:00
Kirill Bulatov
70a45fc800
Fix cache incremental updates
2023-06-29 22:25:49 +03:00
Kirill Bulatov
7ac1885449
Properly refresh hints on editor open
2023-06-29 22:25:49 +03:00
Kirill Bulatov
58343563ba
Fix hint querying bugs
2023-06-29 22:25:49 +03:00
Kirill Bulatov
debdc3603e
Finish rest of the inlay cache logic
2023-06-29 22:25:49 +03:00
Kirill Bulatov
ddcbc73bf0
Implement inlay hint replaces for conflict-less case
2023-06-29 22:25:49 +03:00
Kirill Bulatov
6368cf1a27
Merge excerpt-related hint data, move next_inlay_id into Editor
2023-06-29 22:25:49 +03:00
Kirill Bulatov
8c03e9e122
Move InlayId generation back to InlayCache
2023-06-29 22:25:49 +03:00
Kirill Bulatov
e82b4d8957
Properly handle hint addition queries
2023-06-29 22:25:49 +03:00
Kirill Bulatov
5322aa09b9
Properly handle settings toggle
2023-06-29 22:25:49 +03:00
Kirill Bulatov
8f68688a64
Allow readding inlays with existing ids, move inlay types
2023-06-29 22:25:49 +03:00
Kirill Bulatov
49c00fd571
Generate InlayIds in InlayMap, prepare InlayCache for refactoring
2023-06-29 22:25:49 +03:00
Kirill Bulatov
e217a95fcc
Cleanup the warnings
2023-06-29 22:25:49 +03:00
Kirill Bulatov
76d35b7122
Use proper, limited excerpt ranges and manage inlay cache properly
2023-06-29 22:25:49 +03:00
Kirill Bulatov
2b989a9f12
Fix all the tests
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
d4d88252c3
Fix most of the FoldMap random tests with inlays
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
f2c510000b
Fix all FoldMap tests (without real inlays inside)
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
29bb6c67b0
Fix first FoldMap methods after the map move
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
9ae611fa89
Fix InlayMap bugs after the map order revers
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
05dc672c2a
Apply questionable changes to make things compile
2023-06-29 22:25:49 +03:00
Kirill Bulatov
10765d69f4
Move inlay map to be the first one
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
e744fb8842
Avoid having carriage returns (\r) in inlays
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
d2fef07782
Remove the SuggestionMap
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
8cdf1a0faf
Switch over to inlay map for Copilot suggestions
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Antonio Scandurra
89137e2e83
Fix InlayMap::buffer_rows
2023-06-29 22:25:49 +03:00
Kirill Bulatov
34c6d66d04
Implement InlayBufferRows properly
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
bec9c26fa2
Fix more inlay_map corner cases and hangings
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
02e124cec4
Fix inlay map tests
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
b231fa47af
Apply hints setings on startup
2023-06-29 22:25:49 +03:00
Kirill Bulatov
c898298c5c
Properly update inlay hints when settings are changed
2023-06-29 22:25:49 +03:00
Kirill Bulatov
1ed52276e0
Add inlay hint settings
2023-06-29 22:25:49 +03:00
Kirill Bulatov
ea837a183b
Store inlays per paths and query on editor open
2023-06-29 22:25:49 +03:00
Kirill Bulatov
8acc5cf8f4
Deserialize more LSP inlay hint information
2023-06-29 22:25:49 +03:00
Kirill Bulatov
f155f5ded7
Better rpc inlay hint handling
2023-06-29 22:25:49 +03:00
Kirill Bulatov
b3aa75a363
Refresh inlays on buffer reopens
2023-06-29 22:25:49 +03:00
Kirill Bulatov
e1f22c3684
Cache anchors from all versions, remove out of range hints
2023-06-29 22:25:49 +03:00
Kirill Bulatov
7abaf22b93
Generate proper inlay diffs for splice
2023-06-29 22:25:49 +03:00
Kirill Bulatov
6d1068d1e9
Query inlay hints for excerpt ranges only
2023-06-29 22:25:49 +03:00
Kirill Bulatov
271cd25a1d
Display excerpt-ranged hints only
2023-06-29 22:25:49 +03:00
Kirill Bulatov
addb62c1fc
Fix the duplicate hints
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
63074c5cd8
Better bias selection for hints that prefix the type
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Antonio Scandurra
2b1b1225f5
Simplify InlayMap::splice interface
2023-06-29 22:25:49 +03:00
Antonio Scandurra
7684a26daa
Fix point/offset translation and clipping in the InlayMap
...
This makes all randomized tests pass. We're only missing `buffer_rows`
now and we should move the map right above `MultiBuffer` and below `FoldMap`.
2023-06-29 22:25:49 +03:00
Kirill Bulatov
c7fa8dbc70
React with inlay updates on excerpt events
2023-06-29 22:25:49 +03:00
Kirill Bulatov
df20a43704
Reuse the copilot suggestion style for inlays
2023-06-29 22:25:49 +03:00
Kirill Bulatov
8a64b07622
Fixed inlay hints' edits generation and moved on with the randomized
...
test
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Antonio Scandurra
e280483c5f
Make the randomized tests pass
...
Right now we only check that the text is correct, but I think
we're getting there.
2023-06-29 22:25:49 +03:00
Kirill Bulatov
afa59eed01
Fix the randomized tests
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
f940104b6f
Add inlay hint randomization in the text
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
dbd4b33568
Fix splice edits generation
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
9ce9b73879
Generate edits for inlay hints
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
f5f495831a
Add inlay hints randomized test, fix the errors
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
2e730d8fa4
Implement initial changes reporting for inlay hints
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
4d76162da8
Report the edits per transform summary generated
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
2ba3262f29
Add line_len snapshot method
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
ab7dd80423
Add more InlaySnapshot text summary impls
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
568a67c4d7
Implement more InlaySnapshot methods
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:49 +03:00
Kirill Bulatov
daa2ebb57f
Calculate anchors for new hints
2023-06-29 22:25:49 +03:00
Kirill Bulatov
5fadbf77d4
Implement InlayHint sync method and fix the bugs
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:48 +03:00
Kirill Bulatov
5ad85b44d6
Implement chunks of the InlayMap
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:48 +03:00
Kirill Bulatov
3028767d12
Improve on inlya locations
2023-06-29 22:25:48 +03:00
Kirill Bulatov
b193d62a5d
Initial InlayMap tests and splice fn impl
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-29 22:25:48 +03:00
Kirill Bulatov
7397b8028c
Simplify inlay hint version handling
2023-06-29 22:25:48 +03:00
Kirill Bulatov
d506522eef
Correctly pass inlay hints
2023-06-29 22:25:48 +03:00
Kirill Bulatov
b5233b3ad5
Rename the new map
2023-06-29 22:25:48 +03:00
Kirill Bulatov
9287634548
Prepare to find diffs between inlay hint generations
2023-06-29 22:25:48 +03:00
Kirill Bulatov
78b3c9b88a
Store hints in the new map only
2023-06-29 22:25:48 +03:00
Kirill Bulatov
83f4320b60
Replace todo!s with stub calls to make Zed work
2023-06-29 22:25:48 +03:00
Kirill Bulatov
4c3c0eb796
Draft the hint render data flow
2023-06-29 22:25:48 +03:00
Kirill Bulatov
2ead3de7de
Add basic infrastructure for inlay hints map
2023-06-29 22:25:48 +03:00
Kirill Bulatov
6e3d1b962a
Draft the initial protobuf changes
2023-06-29 22:25:48 +03:00
Kirill Bulatov
387415eb01
Request hints for all buffers in editor
2023-06-29 22:25:48 +03:00
Kirill Bulatov
f83cfda9bc
React on message-less LSP requests properly
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-29 22:25:48 +03:00
Kirill Bulatov
7a268b1cf6
Improve obvious faults
2023-06-29 22:25:48 +03:00
Kirill Bulatov
79b97f9e75
Stub initial hint requests
2023-06-29 22:25:48 +03:00
Kirill Bulatov
8a3b515f56
Initial protocol check commit
2023-06-29 22:25:48 +03:00
KCaverly
39137fc19f
updated vector_store db to leverage EMBEDDINGS_DIR path
2023-06-29 15:18:32 -04:00
Max Brunsfeld
1ae5261024
Avoid redundant FS scans when LSPs changed watched files ( #2663 )
...
Release Notes:
- Fixed a performance problem that could occur when a language server
requested to watch a set of files (preview only).
2023-06-29 12:07:24 -07:00
Max Brunsfeld
922d8f30d6
Tweak debug log message when ignoring fs events
2023-06-29 12:01:59 -07:00
Max Brunsfeld
8609ccdcf7
Add test coverage for FS events happening inside unloaded dirs
2023-06-29 11:55:25 -07:00
Nate Butler
ae9eb7c67a
Re-add missing active state ( #2664 )
...
[[PR Description]]
Release Notes:
- Fixes project panel active state that was incorrectly removed.
2023-06-29 14:45:19 -04:00
Nate Butler
764968e7d0
Re-add missing active state
2023-06-29 14:40:00 -04:00
Max Brunsfeld
ba80c53278
Avoid redundant FS scans when LSPs changed watched files
...
* Don't scan directories if they were already loaded.
* Do less work when FS events occur inside unloaded directories.
2023-06-29 11:35:49 -07:00
KCaverly
0a7245a583
updated semantic search modal to manage for duplicate queries
2023-06-29 13:50:49 -04:00
Nate Butler
c7c38c7da2
snake_case theme ( #2661 )
...
This PR moves the theme / `/styles` typescript app to use snake_case to
better align with the rust app and make it easier to reference things
across both apps.
It also configures ESLint in the styles app and fixes many ESLint
errors.
Going forward from this PR we will use `snake_case` throughout the
theme.
Release Notes:
- N/A (No public facing changes)
2023-06-29 12:47:15 -04:00
KCaverly
a08d60fc61
added navigation on confirm to semantic search modal
2023-06-29 11:58:47 -04:00
Nate Butler
5211328234
Delete snake_case.ts
2023-06-29 11:56:14 -04:00
Nate Butler
d285d56fe3
Update package-lock.json
2023-06-29 11:48:17 -04:00
Nate Butler
8bff641cc4
Organize and update dotfiles
2023-06-29 11:47:58 -04:00
Nate Butler
a6f7e31bb9
Update & format
2023-06-29 11:41:51 -04:00
Nate Butler
97dc7b77f4
WIP snake_case 5/?
2023-06-29 11:31:23 -04:00
Nate Butler
0627c198fd
WIP snake_case 4/?
2023-06-29 10:57:19 -04:00
Nate Butler
17f2fed3c8
WIP snake_case 3/?
2023-06-29 02:16:21 -04:00
Nate Butler
ba17fae8d9
WIP snake_case 2/?
2023-06-29 01:48:40 -04:00
Nate Butler
b015f506da
WIP snake_case 1/?
...
through `contact_notification`
2023-06-28 22:42:57 -04:00
Julia
14ff411907
Detect and fix broken lsp installations ( #2646 )
...
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
Closes
https://linear.app/zed-industries/issue/Z-665/add-a-mechanism-for-detecting-and-fixing-broken-language-server
Fixes https://github.com/zed-industries/community/issues/1671
Fixes https://github.com/zed-industries/community/issues/1691
Fixes https://github.com/zed-industries/community/issues/1524
Fixes https://github.com/zed-industries/community/issues/1352
Fixes https://github.com/zed-industries/community/issues/1109
Fixes https://github.com/zed-industries/community/issues/996
Fixes https://github.com/zed-industries/community/issues/782
Things this PR does:
- Updates our elixir-ls fetching to use new release name format
- Detect when a server fails to launch
- If the adapter claims to be reinstallable, get a test binary
- If the test binary fails to launch or returns a failure error code
- Clear container dir and reinstall
- Detect/fix broken Node
Things it does not do:
- Restart server on failure, I have most of the stuff for this already
so it should be a fast follow up
- Detect/fix broken Copilot
Node and Copilot shouldn't be too bad, they are handled via different
mechanisms. Originally I put effort into detecting failure of the server
during normal operation post launch, but that's not really needed. If
the server gets borked while running then we'll catch that on next
startup. Realizing that allowed for pruning a bunch of the work I did
and made the overall system a lot nicer
Copilot is nominally a language server but does not have an adapter and
does not run through the same mechanism in the project.
We're going to have an issue with multiple language server instances in
different projects once we add a "Reinstall Language Server" action,
which is why it's not in this PR. Each project has its own list of
server instances and is currently vaguely responsible for managing the
installations which means they can step on each others toes. This should
change, probably
Release Notes:
- Added a mechanism to detect and reinstall broken language servers
([#1691 ](https://github.com/zed-industries/community/issues/1691 ))
([#1524 ](https://github.com/zed-industries/community/issues/1524 ))
([#1352 ](https://github.com/zed-industries/community/issues/1352 ))
([#1109 ](https://github.com/zed-industries/community/issues/1109 ))
([#996 ](https://github.com/zed-industries/community/issues/996 ))
([#782 ](https://github.com/zed-industries/community/issues/782 )).
2023-06-28 21:26:35 -04:00
Mikayla Maki
6ffa6afd20
fmt
2023-06-28 16:35:57 -07:00
Mikayla Maki
e0d618862c
Add click out handler
...
Make all context menus on button click toggles instead of re-shows
2023-06-28 16:23:07 -07:00
Nate Butler
2e162f8af7
WIP convert to snake_case
2023-06-28 18:20:43 -04:00
Max Brunsfeld
fd68a2afae
Debounce searches in semantic search modal
2023-06-28 15:02:20 -07:00
Nate Butler
bfdd0824e2
Resolve TS errors and warnings
...
TODO: Use StyleTree types to remove `any`s from styleTrees.
2023-06-28 17:54:36 -04:00
Julia
2ed0284d49
Stub out for language plugin
2023-06-28 17:06:50 -04:00
Julia
48bed2ee03
Merge branch 'main' into fix-broken-lsp-installations
2023-06-28 16:46:06 -04:00
Nate Butler
1177980172
Fix basic eslint errors
2023-06-28 16:44:18 -04:00
Julia
db2b3e47bc
Reinstall Node whenever a NodeRuntime operation has serious error
2023-06-28 16:43:45 -04:00
Nate Butler
e30ad9109c
wip
2023-06-28 16:28:46 -04:00
KCaverly
85e71415fe
updated embedding database calls to maintain project consistency
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-06-28 16:25:05 -04:00
KCaverly
400d39740c
updated both indexing and search method for vector store, to maintain both zed worktree ids and db worktree ids
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-06-28 16:21:03 -04:00
KCaverly
3ca3de807c
Merge branch 'main' of github.com:zed-industries/zed into vector_store
2023-06-28 14:42:24 -04:00
Mikayla Maki
0b900f4faf
Fix project panel bug ( #2656 )
...
Release Notes:
* Fix a bug where project panel entries would not be styled correctly
(preview only)
2023-06-28 10:36:59 -07:00
Mikayla Maki
1d4a922185
prettier format
2023-06-28 10:35:28 -07:00
Mikayla Maki
bf2c2fe242
fix bug with dragged entry
2023-06-28 10:34:47 -07:00
Nate Butler
cf8e0befc8
Update
2023-06-28 13:27:41 -04:00
KCaverly
40ff7779bb
WIP: Working modal, without navigation and search on every keystroke
2023-06-28 13:27:26 -04:00
Mikayla Maki
4659c34d46
WIP: Fix style overwriting in project panel
2023-06-28 09:55:25 -07:00
Mikayla Maki
18dd3102bf
WIP: Add click out event to fix context menus
2023-06-28 09:29:49 -07:00
Joseph T. Lyons
6c53653831
v0.94.x dev
2023-06-28 12:23:42 -04:00
Mikayla Maki
ce52d90a9d
Collab UI v2 ( #2618 )
...
This PR implements
https://www.figma.com/file/pLq7dvhx2mFeWFOedXpUQ5/Project-%E2%80%93-Collaboration-UI?type=design&node-id=666%3A8610&t=XFGk6KEtTCFXBvCQ-1
Release notes:
- [x] Redesigned collaboration UI
- [x] Added voice support
2023-06-28 09:14:39 -07:00
Mikayla Maki
cb782c5a7b
Remove menu tracking state
2023-06-28 09:06:06 -07:00
Max Brunsfeld
34b81e2aab
collab 0.15.0
2023-06-28 09:01:07 -07:00
Mikayla Maki
88b30dea10
fmt
2023-06-28 08:44:17 -07:00
Mikayla Maki
9ab0efa1f8
Fix microphone and speaking styles
2023-06-28 08:41:31 -07:00
Julia
00212d4383
Handle new elixir-ls release zip name ( #2655 )
...
Fix downloading Elixir being broken
Release Notes:
- N/A
(Should be mentioned in 0.92.x)
2023-06-28 10:28:30 -04:00
Julia
1882ce48be
Handle new elixir-ls release zip name
2023-06-28 10:22:39 -04:00
Nate Butler
c381e8821c
Update icon sizes
2023-06-28 10:19:30 -04:00
Nate Butler
a889f3db54
Reduce the right spacing of the contacts menu
2023-06-28 10:06:12 -04:00
Piotr Osiewicz
49ce1977e3
Optimize user menu trigger
2023-06-28 15:27:38 +02:00
Piotr Osiewicz
c2f5855fdc
Fix warning
2023-06-28 15:22:17 +02:00
Piotr Osiewicz
456be1f86e
Hide user menu on second click
2023-06-28 15:19:32 +02:00
Piotr Osiewicz
dddff644ca
tests: Test 'db' package sequentially ( #2654 )
...
/cc @as-cii @nathansobo
Release Notes:
- N/A
2023-06-28 15:00:43 +02:00
KCaverly
9d19dea7dd
updated vector_store to remove parsing module
2023-06-28 08:58:50 -04:00
Antonio Scandurra
2cb4616609
Enable assistant on stable
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-06-28 12:09:49 +02:00
Antonio Scandurra
0d0c71e215
Polish assistant ( #2653 )
...
This is a mix of styling and behavioral improvements to the assistant
that we wanted to land before shipping today.
Release Notes:
- N/A
2023-06-28 12:02:18 +02:00
Nathan Sobo
8f8a99d788
Bind cmd-? to assistant::toggle_focus
...
Bypass system help menu shortcut at the app delegate level to achieve this.
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-28 11:43:24 +02:00
Piotr Osiewicz
2ddf0e12bf
Undeafen: unmute if user was not muted prior to deafening
2023-06-28 11:10:56 +02:00
Nathan Sobo
7efcd60608
Remove border from assistant message header
...
Also: Increase right margin on token count to space it from the scrollbar.
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-28 10:54:44 +02:00
Nathan Sobo
83fc7b9b7c
Avoid scrolling to the new cursor position so the assistant's output is stable
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-28 10:32:06 +02:00
Nathan Sobo
f52d3ea5ef
Clean up tooltips, create conversation on cmd-n
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-28 10:27:29 +02:00
Nathan Sobo
d41a7f41fb
Space out assistant icons to match pane icons
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-28 10:00:28 +02:00
Mikayla Maki
749f60ba81
fmt
2023-06-27 19:25:46 -07:00
Mikayla Maki
5d02b49058
Added muted and currently speaking tracking
2023-06-27 19:23:13 -07:00
Max Brunsfeld
f128cf4a33
Defer scanning some worktree subdirectories until they are expanded in the project panel ( #2622 )
...
Closes
https://linear.app/zed-industries/issue/Z-352/high-memory-usage-from-fs-scanning-if-project-contains-symlinks-that
### Background
Currently, when you open a project, Zed eagerly scans the directory,
building an in-memory representation of all of the files and directories
within. This scanning includes all git-ignored files and follows any
symlinks. When any directory changes on disk, Zed recursively rescans it
in order to keep its in-memory representation up-to-date. When
collaborating, all of these files are replicated to all guests.
Right now, there are some performance problems associated with the
maintenance of this filesystem state:
* For various reasons, some projects contain symlinks that point out to
large folders like `$HOME`, which itself contains many symlinks that
point to the same large directory. When these projects are opened, the
worktree scans endlessly, using more and more memory.
* Some git-ignored directories (like `target` in a rust project) contain
*many* more files than are actually tracked in the git repository. These
files often change as a result of saving, (e.g. because the compiler
runs). Maintaining in memory all of these paths isn't useful to the
user, and causes significant CPU usage on every save. Most importantly,
when collaborating sending all of these changes to guests can be slow,
and can delay all other RPC messages.
### Change
This PR changes the worktree's filesystem-scanning logic to be *lazy*
about scanning two types of directories:
* git ignored directories
* "external" directories (those that are canonically located outside of
the worktree root, but accessed via symlinks)
The laziness works as follows. When, during a recursive scan, a
directory is found that falls into one of the above 2 categories, that
directory is marked as "unloaded". The directory might later be scanned,
if some explicit operation is performed within it (like opening a
buffer, or creating a file), if any collaborator expands that directory
in their project panel, or if an LSP requests that it be watched.
### Results
When collaborating on the `zed` folder:
| metric | before | after |
|-------|--------|------|
| # `worktree_entries` in collab db initially | 154,763 | 77,679 |
| # `worktree_entries` in collab db after 5 saves | 181,952 | 77,679
(nothing new to scan) |
| app memory footprint (host) | 260MB | 228.5 MB |
The db thing is a win, because reading and writing to the
`worktree_entries` table is one of the most expensive thing that the
`collab` server does.
There's also generally lower background CPU usage after every save,
because we don't need to recursively rescan directories inside of
`target`.
### Limitations
We still end up scanning some unnecessary directories (like
`target/debug/build/zed-b612db829aeac16e/out`) because the LSP instructs
us to watch those.
### To do:
* [x] Expand parent directories of any path opened via LSP
* [x] Avoid creating orphaned entries when FS events happen inside of
unscanned directories
* [x] Scan any newly-non-ignored directories after gitignore changes
* [x] Emit correct events for newly-discovered paths when expanding dirs
* [x] GC the set of expanded directory ids when dirs are removed
* [x] Don't include "external" entries in file-finder
* [x] Expand any directories watched by LSP
* [ ] manual testing and profiling
### Release Notes:
- Fixed a bug where Zed would use excessive memory when a project folder
contained symlinks pointing to directories outside of the project.
- Reduced Zed's memory and CPU usage when working in folders containing
many git-ignored files.
2023-06-27 17:07:23 -07:00
Max Brunsfeld
201188fdaa
Use FakeFs in worktree gitignore test
2023-06-27 15:40:36 -07:00
Max Brunsfeld
fc02381196
Fix bugs in handling combined injections exposed by HEEx ( #2652 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2481/heex-this-snippet-triggers-a-hard-crash
Release Notes:
- Fixed a crash that would sometimes occur when editing a HEEx file
([#1703 ](https://github.com/zed-industries/community/issues/1703 )).
2023-06-27 15:17:29 -07:00
Max Brunsfeld
81c26cfea0
Fix bugs in handling combined injections exposed by HEEx
2023-06-27 15:08:26 -07:00
Nate Butler
9a07696240
Update titlebar item spacing
2023-06-27 17:56:44 -04:00
Nate Butler
8b2732c3aa
workspace.titlebar -> titlebar in Theme
2023-06-27 17:27:58 -04:00
Mikayla Maki
19ca6a8875
Seperate online and offline
2023-06-27 13:33:04 -07:00
Nate Butler
825a7cb799
Update screenshare toggle, titlebar spacing
2023-06-27 16:20:45 -04:00
Mikayla Maki
60ce584427
WIP: Add mute icons
2023-06-27 13:12:52 -07:00
KCaverly
d1bdfa0be6
Added a dummy action for testing the semantic search functionality in the command palette.
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-06-27 15:53:07 -04:00
KCaverly
4bfe3de1f2
Working incremental index engine, with streaming similarity search!
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-06-27 15:31:21 -04:00
Julia
b2de28ccfc
Match original logic when determining server to request formatting
2023-06-27 14:16:01 -04:00
Mikayla Maki
37cb202c93
Rename and toggle screenshare
2023-06-27 09:58:01 -07:00
Nate Butler
b4f9faee3b
Update share, call control buttons
2023-06-27 12:24:19 -04:00
Nate Butler
5af33407f0
Add script for building theme types
2023-06-27 11:34:26 -04:00
Nate Butler
331800c14d
Use icon_button for leave call
2023-06-27 11:34:12 -04:00
Piotr Osiewicz
3104275d87
Keep users muted once they undeafen themselves
2023-06-27 17:19:18 +02:00
Nate Butler
9389b50646
Update local-collaboration.md
...
Add missing livekit info
2023-06-27 10:52:38 -04:00
Nate Butler
0548df09d9
Update local-collaboration.md
2023-06-27 10:05:37 -04:00
Nate Butler
f311d307b1
Create local-collaboration.md ( #2651 )
...
I forget how to do this every single time 😅 Please update anything that
is incorrect!
[[PR Description]]
Release Notes:
- N/A
2023-06-27 09:52:15 -04:00
Nate Butler
a67eba9fed
Create local-collaboration.md
...
I forget how to do this every single time 😅
2023-06-27 09:51:30 -04:00
Piotr Osiewicz
625814d30a
Merge branch 'main' into collab-titlebar-2
2023-06-27 15:40:43 +02:00
Nathan Sobo
04d93dfbd9
vim: indent/outdent ( #2644 )
...
Release Notes:
- vim: support indent/outdent
([#832 ](https://github.com/zed-industries/community/issues/832 >)).
2023-06-27 04:15:55 -06:00
Nathan Sobo
fd3ee0ebd0
Vim toggle case ( #2648 )
...
Release Notes:
- vim: Add ~ to toggle case
([#1410 ](https://github.com/zed-industries/community/issues/1410 ))
2023-06-27 04:13:24 -06:00
Nathan Sobo
29b2639b4c
Merge remote-tracking branch 'origin/main' into vim-indent
2023-06-27 12:09:47 +02:00
Nathan Sobo
16c23557b8
vim: Fix scrolling ( #2647 )
...
After #2641 we noticed that scrolling didn't take a count parameter, and
a few other issues with the way that we calculated the distance to
scroll.
Release Notes:
- Improved distance calculations for page-up/page-down
- vim: Allow counts to work with scrolling shortcuts.
2023-06-27 04:01:14 -06:00
Nathan Sobo
7294314ce7
vim: shortcuts for tab navigation ( #2649 )
...
Release Notes:
- vim: added gt/ctrl-pagedown and gT/ctrl-pageup for tab navigation
2023-06-27 03:57:01 -06:00
Nathan Sobo
0fd0b60bd6
vim: Fix code actions menu ( #2650 )
...
Fixes: zed-industries/community#1690
I'm not sure this is the correct way to fix this...
* A simpler approach would be to just say `!showing_code_actions` in the
binding file (as `showing_completions` can only happen in insert mode -
and `VimControl` will be false). This seemed a little error prone if
more menus were added in the future.
* A more complicated approach would be to copy the way this is done from
the MouseContextMenu, which registers its own keyboard shortcuts, and as
such uses those when it's open. This seems "more correct", but is a
major refactoring for a very small reward.
Release Notes:
- vim: Fix code actions menu
([#1690 ](https://github.com/zed-industries/community/issues/1690 ))
2023-06-27 03:56:08 -06:00
Piotr Osiewicz
71c0b7d74d
Add styles for user menu
2023-06-27 11:55:06 +02:00
Conrad Irwin
a1343f0d2c
vim: Fix code actions menu
...
Fixes : zed-industries/community#1690
2023-06-26 21:46:06 -06:00
Conrad Irwin
a9aa5e5196
vim: Add ~ to change case
...
Fixes : zed-industries/community#1410
2023-06-26 20:22:24 -06:00
Conrad Irwin
77dc22bff6
vim: Fix cursor restoration when undoing substitute
2023-06-26 20:22:24 -06:00
KCaverly
953e928bdb
WIP: Got the streaming matrix multiplication working, and started work on file hashing.
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-06-26 19:01:19 -04:00
Conrad Irwin
73920807a9
vim: shortcuts for tab navigation
2023-06-26 15:07:19 -06:00
Conrad Irwin
02fc5dd6c9
vim: Fix scrolling
...
After #2641 we noticed that scrolling didn't take a count parameter.
The PageDown/PageUp logic was also broken by an additional -1 (for both
vim mode and not).
2023-06-26 13:29:14 -06:00
KCaverly
74b693d6b9
Updated database calls to share single connection, and simplified top_k_search sorting.
...
Co-authored-by: maxbrunsfeld <max@zed.dev >
2023-06-26 14:57:57 -04:00
Joseph T. Lyons
a09c6b2691
Add installation_id to panic events ( #2642 )
...
We want to add installation_id to the panic events so that we can easily
know if multiple panics are coming from the same person or different
people. 5 panics from one person isn't as bad as 5 panics from 5 people.
[zed.dev pr](https://github.com/zed-industries/zed.dev/pull/343 )
Release Notes:
- N/A
2023-06-26 13:35:23 -04:00
Joseph T. Lyons
c0fb98cb3f
Factor out key name
2023-06-26 13:31:41 -04:00
Joseph T. Lyons
8d1cc8815b
Merge branch 'main' into add-installation-id-to-panic-events
2023-06-26 13:27:14 -04:00
Nate Butler
37814bc4fc
Fix incorrect ThemeAppearance ( #2645 )
...
[[PR Description]]
When we updated the way themes were built it looks like we accidentally
gave `Atelier Forest Light` the wrong `ThemeAppearance`. This PR fixes
that.
Release Notes:
- Fixed the `Atelier Forest Light` theme, which was incorrectly set as a
dark theme.
2023-06-26 13:20:32 -04:00
Antonio Scandurra
0d3e75e873
Introduce the ability to load and save conversations with the assistant ( #2623 )
...
Closes
https://linear.app/zed-industries/issue/Z-1890/save-assistant-conversations-to-the-filesystem
Closes
https://linear.app/zed-industries/issue/Z-2459/cycling-message-roles-on-the-last-empty-message-alters-the-message
Closes
https://linear.app/zed-industries/issue/Z-2460/cycling-role-in-an-empty-message-cycles-wrong-messages-role
Closes https://linear.app/zed-industries/issue/Z-2365/assistant-toolbar
Closes
https://linear.app/zed-industries/issue/Z-2461/always-insert-an-empty-message-at-the-end-of-the-conversation
Release Notes:
- You can now save conversations with the assistant to
`~/.config/zed/conversations` with `cmd-s`. Conversations are also
automatically saved as they are edited.
2023-06-26 19:17:16 +02:00
Antonio Scandurra
43723168fc
Remove assistant panel zoom test
...
The test was testing pretty straightforward logic, but for some strange reason
it was failing on CI (but passed locally). I think it's fine to delete it and
make progress, if zooming regresses we'll find out pretty quickly.
2023-06-26 19:10:59 +02:00
Nate Butler
1dc52c7547
Fix incorrect ThemeAppearance
2023-06-26 13:07:33 -04:00
Antonio Scandurra
d46d3e6d15
Try fixing test on CI
2023-06-26 18:18:22 +02:00
Conrad Irwin
c3e8cae20f
vim: indent/outdent
...
Fixes : zed-industries/community#832
2023-06-26 10:08:34 -06:00
Julia
2a8d1343d6
Add installation test binaries for all remaining adapters
2023-06-26 11:54:20 -04:00
Antonio Scandurra
e77abbf64f
Add hover state to assistant buttons
2023-06-26 17:48:43 +02:00
Antonio Scandurra
723c8b98b3
Show quote selection button
2023-06-26 17:24:31 +02:00
Antonio Scandurra
e723686b72
Shwo tooltips for assistant buttons
2023-06-26 17:17:45 +02:00
Piotr Osiewicz
f6edc68613
picker: fix warnings
2023-06-26 17:07:33 +02:00
Antonio Scandurra
edc7f30660
Add assistant icons to the toolbar
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-06-26 16:49:33 +02:00
KCaverly
0f232e0ce2
added file metadata retrieval from db
2023-06-26 10:35:56 -04:00
KCaverly
7937a16002
added brute force search and VectorSearch trait
2023-06-26 10:34:12 -04:00
Julia
5632f24d24
Handle new elixir-ls release zip name
2023-06-26 10:18:30 -04:00
Antonio Scandurra
c5b3785be5
Revert "Panic in debug if global settings can't be deserialized from defaults"
...
This reverts commit 7a051a0dcb .
2023-06-26 16:03:19 +02:00
Antonio Scandurra
00e37bc2a2
Merge remote-tracking branch 'origin/main' into save-conversations
2023-06-26 15:59:19 +02:00
Antonio Scandurra
9d4dd5c42b
Insert empty user message when assisting with the current last message
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-06-26 15:57:36 +02:00
Antonio Scandurra
92d7b6aa3b
Allow toggling back and forth between conversation list and editor
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-06-26 15:43:21 +02:00
Piotr Osiewicz
55f06dcdb5
Add headers and footers to file finder
2023-06-26 13:31:46 +02:00
Piotr Osiewicz
a9b5c1d867
Remove unnecessary call to context.notify
2023-06-26 12:45:50 +02:00
KCaverly
65bbb7c57b
added proper blob serialization for embeddings and vector search trait
2023-06-25 20:02:56 -04:00
Nathan Sobo
3f4a06f576
Add an Element derive macro for building components out of other elements ( #2643 )
...
To turn any struct into a composite element, you can implement a render
method with the following signature:
```rs
fn render<V: View>(&mut self, view: &mut V, cx: &mut ViewContext<V>) -> AnyElement<V>;
```
Then add #[derive(Element)] to the struct definition.
This will make it easier to introduce higher-level components that are
expressed in terms of other elements. Instead of calling functions that
return elements, we can now make any struct into an element fairly
easily. The advantage is that we can use method chaining to express
optional state on these components, and they blend in better with other
elements.
cc @mikayla-maki @osiewicz @iamnbutler
Release Notes:
- N/A
2023-06-25 08:12:02 -06:00
Nathan Sobo
bede668b14
Add a derive macro for Element
...
To turn any struct into a composite element, you can implement a render method
with the following signature:
fn render<V: View>(&mut self, view: &mut V, cx: &mut ViewContext<V>) -> AnyElement<V>;
Then add #[derive(Element)] to the struct definition.
This will make it easier to introduce higher-level components that are expressed in
terms of other elements.
2023-06-25 07:51:50 -06:00
Julia
c4b83c86cc
Avoid validating/reinstalling server which refuses will_fetch/start
...
These adapters have indicated some broader reason to the user why
they cannot be started, don't waste time/bandwidth attempting to
validate and reinstall them
2023-06-24 22:42:06 -04:00
Kirill Bulatov
82bd5fb564
Fix main compilation
2023-06-25 01:43:58 +03:00
Joseph T. Lyons
7d065fa14e
Add installation_id to panic events
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-06-23 21:02:01 -04:00
Max Brunsfeld
030984dca4
Vim: substitute support ( #2641 )
...
Release Notes:
- vim mode now supports `s` for substitute
2023-06-23 12:58:14 -07:00
Max Brunsfeld
b0631e90ad
vim: Fix 1G ( #2640 )
...
Before this change code could not distinguish between a user providing a
count of 1 and no count at all.
Fixes : zed-industries/community#710
Release Notes:
- 1G now correctly goes to the first line in vim mode
([710](zed-industries/community#710 ))
2023-06-23 12:55:46 -07:00
Max Brunsfeld
91f87bb31f
Scan any external/ignored directories needed for LSP watchers
...
Also, don't include "external" files in project searches. Treat them
the same as ignored files.
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2023-06-23 12:53:25 -07:00
Julia
7caa096bd0
Remove installation test binary from language server instance
2023-06-23 13:24:50 -04:00
Max Brunsfeld
27b74e9ea1
Prune the set of expanded dir ids as entries are removed
2023-06-23 10:23:21 -07:00
Max Brunsfeld
b22a18345e
Emit loaded events for lazily loaded paths in worktree
2023-06-23 09:39:37 -07:00
KCaverly
c071b271be
removed tokio and sqlx dependency, added dummy embeddings provider to save on open ai costs when testing
2023-06-23 10:25:12 -04:00
Piotr Osiewicz
4b52ff65c1
Add styles for button
2023-06-23 13:30:40 +02:00
Piotr Osiewicz
6c676121f2
Fixed mic's state not being updated in titlebar if user mutes a mic via command palette
2023-06-23 13:22:33 +02:00
Piotr Osiewicz
62786cd508
Add button
2023-06-23 13:15:25 +02:00
Piotr Osiewicz
437e41f99d
Add styles for microphone and speakers buttons
2023-06-23 11:52:06 +02:00
Antonio Scandurra
5c5d598623
Insert new message right before the next valid one
2023-06-23 11:13:52 +02:00
Antonio Scandurra
6c7271c633
Test serialization roundtrip
2023-06-23 10:42:15 +02:00
Antonio Scandurra
c38bf2de33
Sort conversations in descending chronological order
2023-06-23 10:05:21 +02:00
Antonio Scandurra
5ea5368c07
Re-enable buffer search in assistant
2023-06-23 09:57:31 +02:00
Antonio Scandurra
ed88f52619
Remove double constrained call
2023-06-23 09:23:52 +02:00
Antonio Scandurra
6f0efec146
Merge remote-tracking branch 'origin/main' into save-conversations
2023-06-23 09:09:42 +02:00
Antonio Scandurra
ff07d0c2ed
Fix Conversation::messages_for_offsets with empty message at the end
2023-06-23 08:58:30 +02:00
Julia
374c1a3a3e
Remove some status stuff
2023-06-23 00:17:27 -04:00
Julia
3302e1133f
Whoops
2023-06-22 20:22:05 -04:00
Julia
a8acf28989
Remove now-unnecessary complexity
2023-06-22 20:19:07 -04:00
Max Brunsfeld
9ad1ebf387
Fix project panel test helper
2023-06-22 17:02:01 -07:00
Max Brunsfeld
ffb0a215ea
Fix randomized worktree test failures
...
* Distinguish between unloaded and pending directories via separate entry kind.
* Scan directories before updating ignore statuses after fs events.
2023-06-22 16:52:04 -07:00
KCaverly
dd309070eb
open ai indexing on open for rust files
2023-06-22 16:50:07 -04:00
Conrad Irwin
926acd6033
vim: substitute handles multibyte characters
...
And is now in its own file
2023-06-22 13:22:19 -06:00
Conrad Irwin
0cacf01f90
vim: Fix 1G
...
Before this change code could not distinguish between a user providing a
count of 1 and no count at all.
Fixes : zed-industries/community#710
2023-06-22 12:11:14 -06:00
Piotr Osiewicz
8bd9fe1fb0
Deafen now also mutes microphone
2023-06-22 20:05:06 +02:00
Conrad Irwin
16022e9c1a
Add counts to subsitute (and all)
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-06-22 11:50:56 -06:00
Max Brunsfeld
5350164db9
Get integration test passing. Wait for expand entry on remote projects.
2023-06-22 10:34:28 -07:00
Max Brunsfeld
400e3cda32
Scan directories when they stop being ignored
2023-06-22 10:34:28 -07:00
Max Brunsfeld
bfc90f4502
Add failing test for changing a gitignore so a pending dir is no longer ignored
2023-06-22 10:34:28 -07:00
Max Brunsfeld
d3477f75ac
Fix reloading of git repositories
...
Also, clean up logic for reloading git repositories.
2023-06-22 10:34:28 -07:00
Max Brunsfeld
4424dafcd7
Fix expansion of ancestor directories when refreshing a path
2023-06-22 10:34:28 -07:00
Max Brunsfeld
3e6aedfc69
Expand dirs on-demand when opening buffers inside unloaded dirs
2023-06-22 10:34:28 -07:00
Max Brunsfeld
cd823ede4d
Add a bit to each entry indicating if it's outside of the worktree root
2023-06-22 10:34:28 -07:00
Max Brunsfeld
1b71589514
Fix confusion between canonical vs non-canonical paths when rescanning, expanding paths
2023-06-22 10:34:28 -07:00
Max Brunsfeld
3c06bd056a
Load git repositories when inserting the entry for the .git
...
Don't wait until populating that directory entry, for two reasons:
* In the case of submodules, .git is not a directory
* We don't eagerly populate .git directories, since their contents
are automatically ignored.
2023-06-22 10:34:28 -07:00
Max Brunsfeld
6fe74602ac
Fix detection of when refreshed paths are outside of worktree root
2023-06-22 10:34:28 -07:00
Max Brunsfeld
205c758e4e
Wait for ignored directory to be expanded in descendant entries test
2023-06-22 10:34:28 -07:00
Max Brunsfeld
aa6f2f1816
Remove logic for marking worktree entries as collapsed
2023-06-22 10:34:28 -07:00
Max Brunsfeld
f910d8fe3e
Only scan ignored or externals paths if expanded in a project panel
2023-06-22 10:34:28 -07:00
Max Brunsfeld
55f1a6647f
Model symlinks better in FakeFs, add read_link Fs method
2023-06-22 10:34:28 -07:00
Max Brunsfeld
4c03231863
Maintain on the background scanner a set of expanded directories
2023-06-22 10:34:28 -07:00
KCaverly
d4a4db42aa
WIP: started DB creating and naive inserts
2023-06-22 13:25:33 -04:00
Piotr Osiewicz
f774dbfe2e
Use new icons, delete old ones
2023-06-22 18:58:11 +02:00
Piotr Osiewicz
18c4d43ee7
Add deafen button
2023-06-22 18:51:26 +02:00
Nate Butler
a305d93567
Z-2308 - Export Theme Types from Rust ( #2621 )
...
This PR adds JSON Schema definitions into GPUI's styles and adds a tool
for generating typescript types from these schema definitions.
Release Notes:
- N/A
2023-06-22 12:33:18 -04:00
Piotr Osiewicz
10cc0d567f
Reintroduce package-lock.json
2023-06-22 18:26:18 +02:00
Nate Butler
1a0b2bfef8
Update stream control icons
2023-06-22 12:21:59 -04:00
Piotr Osiewicz
fcce1bc488
Fixup xtask compilation
2023-06-22 18:06:52 +02:00
Piotr Osiewicz
417a743b5e
chore: use codegen_units=1 ( #2633 )
...
Reduces binary size by about 31Mb (total .dmg size down by 15Mb after compression).
2023-06-22 18:06:17 +02:00
Nate Butler
1079838443
Add mic and mic-mute icons
2023-06-22 12:00:42 -04:00
Piotr Osiewicz
b430be5bc6
cargo fmt
2023-06-22 17:59:56 +02:00
Piotr Osiewicz
af252888c4
Merge branch 'main' into sergey/z-2308-create-a-proof-of-concept-of-exporting-a-type-from-rust-and
2023-06-22 17:58:56 +02:00
Nate Butler
05730afdf0
Add radix icons
...
There are a lot of them, but they add less than 350kb to the app
2023-06-22 11:58:51 -04:00
Julia
0abda54d3c
Remove individual location's request error handling
2023-06-22 11:43:26 -04:00
Piotr Osiewicz
1a55b687b0
Merge branch 'main' into collab-titlebar-2
2023-06-22 17:41:00 +02:00
Piotr Osiewicz
b16b6dcec7
Render microphone toggle
2023-06-22 17:40:29 +02:00
Piotr Osiewicz
5291bf3d9f
Use nextest instead of test ( #2639 )
...
This should speed up our test CI by a minute or so. =)
[current best case CI
run](https://github.com/zed-industries/zed/actions/runs/5337351944/jobs/9673291188 ),
where we don't rebuild anything (and only run tests) takes about 2m30s
[with
nextest](https://github.com/zed-industries/zed/actions/runs/5346819257/jobs/9694617720?pr=2639 ),
that's down to 1m30s.
Release Notes:
- N/A
2023-06-22 16:50:26 +02:00
Julia
e1cd6cebb9
Revert "Route language server requests through wrapper object"
...
This reverts commit 9b63d6f832 .
2023-06-22 10:45:08 -04:00
Piotr Osiewicz
bee6c59154
Add caret next to user avatar
2023-06-22 16:28:05 +02:00
Nathan Sobo
1707652643
Always focus a panel when zooming it
...
This allows us to zoom a panel when clicking a button, even if the
panel isn't currently focused.
2023-06-22 06:55:31 -06:00
Nathan Sobo
ea5398a702
vim: binding fixes ( #2637 )
...
Release Notes:
- In vim mode you can now use count modifiers with arrow keys (`5<down>`
will go down 5 lines).
- In vim mode `ctrl+]` and `ctrl+o` now work to go to definition and
back
2023-06-22 06:44:12 -06:00
Nathan Sobo
cd008d1503
Add support for joining lines ( #2636 )
...
🚧 We have a couple more refinements to this to add 🚧
Release Notes:
You can now join lines with `ctrl-j` or `shift-J` in Vim normal mode.
🍐 'd with @ConradIrwin
2023-06-22 06:38:57 -06:00
Piotr Osiewicz
bdccdaca1c
Remove unused variable
2023-06-22 13:57:41 +02:00
Piotr Osiewicz
85d1c89d34
Remove unused import
2023-06-22 13:52:21 +02:00
Piotr Osiewicz
4583d22ede
cargo fmt
2023-06-22 13:49:36 +02:00
Piotr Osiewicz
76366422a6
Merge branch 'main' into collab-titlebar-2
2023-06-22 13:48:16 +02:00
Julia
9b63d6f832
Route language server requests through wrapper object
2023-06-21 23:05:37 -04:00
Nathan Sobo
a49189a704
Add Zoom button to assistant panel
2023-06-21 19:50:22 -06:00
Nathan Sobo
a75341db97
Move model and remaining tokens to assistant toolbar
2023-06-21 19:01:30 -06:00
Conrad Irwin
e1f975e52e
vim: Support s on selections and with multiple cursors
2023-06-21 15:44:19 -06:00
Conrad Irwin
dcca98b5cc
vim: Add basic 's' support
2023-06-21 15:06:34 -06:00
Conrad Irwin
0c40ed5d85
vim: ctrl+] and ctrl+o to jump to definition and back
...
Equivalent to f12 and ctrl-- in non-vim mode.
2023-06-21 14:34:35 -06:00
Conrad Irwin
d6b1af6244
vim: Allow up/down/left/right in vim mode
...
The user impact of this is to 5<down> to move 5 lines at a time.
2023-06-21 14:20:39 -06:00
Conrad Irwin
91bd8e305e
join_lines: Skip over leading indentation
2023-06-21 13:44:31 -06:00
Nate Butler
6ab0143469
Split Interactive into Interactive and Toggleable ( #2628 )
...
This is a part of the intensity driven theme rewrite.
It introduces the `toggle` and `interactive` helper functions to build
Toggle<T> and Interactive<T> styles for interactive elements in the
theme.
This PR also removes the `theme_testbench` crate and related actions.
Huge thanks to @osiewicz and @mikayla-maki for pushing this forward 🙏🏽
Release Notes:
- Updated the style of many interactive elements.
2023-06-21 15:03:08 -04:00
KCaverly
80a894b829
WIP: started work on vector store db, by walking project worktrees.\n\nCo-Authored-By: Max <max@zed.dev>
2023-06-21 14:53:08 -04:00
Kirill Bulatov
1f35ddc44e
Run LSP response deserialization outside of main thread ( #2635 )
...
Improves latency for big inlay hints LSP responses for ~8k line files.
Before, the CPU usage sample for editing a single line inside
`edirot.rs` file in Zed contained serde inside the main thread traces:
<img width="1728" alt="Screenshot 2023-06-21 at 00 33 23"
src="https://github.com/zed-industries/zed/assets/2690773/d9789efe-8055-487f-bbe7-8beb49605bcb ">
Release Notes:
- N/A
2023-06-21 21:03:18 +03:00
Julia
e15be61ded
The log-ification
2023-06-21 14:02:21 -04:00
Joseph T. Lyons
cc027dc626
v0.93.x dev
2023-06-21 13:59:07 -04:00
Nate Butler
9d9bbfdabf
Format
2023-06-21 13:58:54 -04:00
Nate Butler
a845e82173
Update settings.json
2023-06-21 13:58:42 -04:00
Nathan Sobo
a365b2f177
Add shift-J binding to Vim normal mode
...
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com >
2023-06-21 11:58:31 -06:00
Nate Butler
ed8bdd186e
Update toggle active styles
2023-06-21 13:56:27 -04:00
Nathan Sobo
cde8d7d747
Don't use test-only method; add ctrl-j binding
...
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com >
2023-06-21 11:53:11 -06:00
Nathan Sobo
cf38264eda
Handle multiple selections when joining lines
...
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com >
2023-06-21 11:47:06 -06:00
Nathan Sobo
61352f68ea
Add more assertions for joining lines at the end of the file
...
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com >
2023-06-21 11:21:09 -06:00
Nathan Sobo
f07a929350
Allow joining multiple lines and deleting empty lines
...
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com >
2023-06-21 11:18:28 -06:00
Nate Butler
127f4aa506
Fix status bar buttons
2023-06-21 13:14:39 -04:00
Piotr Osiewicz
86506a89ab
Remove theme_testbench
2023-06-21 19:11:55 +02:00
Piotr Osiewicz
d3a333b873
Tidy up xtask
2023-06-21 19:06:34 +02:00
Piotr Osiewicz
d194edc49f
xtask: publish = false
2023-06-21 18:51:06 +02:00
Piotr Osiewicz
9aa7a50951
Use xtask for theme generation
2023-06-21 18:48:09 +02:00
Nate Butler
af8671cf7f
Update rose pine theme family ( #2624 )
...
Update the Rose Pine theme family, including new syntax overrides
matching the official theme docs:
https://rosepinetheme.com/palette/ingredients/
Also adds a doc to our internal docs starting to outline how our syntax
highlighting works.
Before:
<img width="626" alt="CleanShot 2023-06-21 at 12 19 17@2x"
src="https://github.com/zed-industries/zed/assets/1714999/5ebe1cd0-1707-483b-a50f-bb53dbf89ba2 ">
After:
<img width="718" alt="CleanShot 2023-06-21 at 12 18 48@2x"
src="https://github.com/zed-industries/zed/assets/1714999/46b588aa-31a0-4402-934b-e3de7bc2f6b5 ">
From their site:

Release Notes:
- Updated Rose Pine theme family to better match original theme.
2023-06-21 12:46:18 -04:00
Nathan Sobo
c48bd394c1
Start on joining lines
...
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com >
2023-06-21 10:32:02 -06:00
Nate Butler
a3e65528ba
Update syntax colors
2023-06-21 12:21:01 -04:00
Nate Butler
eeb155a951
Remove unused light variable
2023-06-21 12:20:47 -04:00
Nate Butler
f0138a7a87
Add initial syntax highlighting doc
2023-06-21 12:15:24 -04:00
Mikayla Maki
05c97ed355
Fix segfault with remote track publications
...
co-authored-by: antonio <antonio@zed.dev >
2023-06-21 09:05:36 -07:00
Nathan Sobo
d78fbbc63e
Add title to assistant panel and move + to right
2023-06-21 09:54:49 -06:00
Mikayla Maki
5ffe74f47e
Fix race condition in sharing mic on connection
...
co-authored-by: antonio <antonio@zed.dev >
2023-06-21 08:50:38 -07:00
Sergey Onufrienko
6e4439b4ca
feat: move gen to styles and add scripts
2023-06-21 16:13:41 +02:00
Sergey Onufrienko
a9fec7f15b
fix: create schemas folder
2023-06-21 16:13:04 +02:00
Sergey Onufrienko
01b9e88079
chore: move schema gen to theme
2023-06-21 16:12:27 +02:00
Sergey Onufrienko
43b912bc40
chore: ignore generated files
2023-06-21 16:12:01 +02:00
Antonio Scandurra
a011ced698
Allow loading a previously-saved conversation
2023-06-21 16:06:09 +02:00
Kirill Bulatov
bd97767c72
Run LSP response deserialization outside of main thread
...
Improves latency when big inlay hints LSP responses for ~8k line files
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-21 13:20:42 +03:00
Antonio Scandurra
06701e78aa
WIP
2023-06-21 11:44:32 +02:00
Antonio Scandurra
9217224fa6
Finish renaming AssistantEditor to ConversationEditor
2023-06-21 09:00:26 +02:00
Nathan Sobo
0932149c48
Fix filename
2023-06-20 20:21:43 -06:00
Nathan Sobo
3a61fd503f
WIP: Trying to display the toolbar but tired. May be worth discarding this.
2023-06-20 20:11:37 -06:00
Nathan Sobo
23bc11f8b3
Remove the nested Pane from the assistant
...
Since we don't want tabs, I think it would be better to render the toolbar
for ourselves directly and handle switching between conversations.
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-20 18:52:48 -06:00
Nathan Sobo
7a051a0dcb
Panic in debug if global settings can't be deserialized from defaults
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-20 18:12:59 -06:00
Mikayla Maki
5860b7b143
Add copy-on-click to diagnostic messages ( #2634 )
...
I finally got fed up with being unable to copy error messages. This adds
a click target and tooltip to f8-style diagnostics that copies their
text on click.
Release Notes:
- Added the ability to copy under-line diagnostic errors on click
2023-06-20 17:05:20 -07:00
Mikayla Maki
11125a62c7
Add copy-on-click to diagnostic messages
2023-06-20 16:48:30 -07:00
Mikayla Maki
f1dc6124dd
Fix rebase mistake
2023-06-20 16:09:17 -07:00
Mikayla Maki
b1b4b563c2
Add zed typescript settings
...
Remove 2 space indent
2023-06-20 16:05:23 -07:00
Mikayla Maki
da94014141
Fix flipped boolean
2023-06-20 16:05:23 -07:00
Mikayla Maki
dacfd70fb4
Remove unescessary enum
2023-06-20 16:05:23 -07:00
Piotr Osiewicz
60b4054b0a
Fix up toggles
2023-06-20 16:05:23 -07:00
Nate Butler
ae53c3e623
WIP: Start updating style trees to new toggle() format.
2023-06-20 16:05:23 -07:00
Nate Butler
61535ed41f
Update toggle, add tests
2023-06-20 16:05:23 -07:00
Nate Butler
040881df3f
Update toggle
2023-06-20 16:05:23 -07:00
Nate Butler
5c034ab63c
Format
2023-06-20 16:05:23 -07:00
Nate Butler
1f3feacb21
Add path aliases
2023-06-20 16:05:23 -07:00
Nate Butler
5369f2c25a
Set up vitest and add tests for interactive
2023-06-20 16:05:23 -07:00
Piotr Osiewicz
4bd89c4c8c
further style adjustments; cargo-run works
2023-06-20 16:05:23 -07:00
Piotr Osiewicz
63630949ba
Fix up uses of interactive
2023-06-20 16:05:23 -07:00
Nate Butler
247f618d4f
Update the interactive function
2023-06-20 16:05:23 -07:00
Nate Butler
16564707df
Use TS-flavored doc comments
2023-06-20 16:05:23 -07:00
Piotr Osiewicz
31c1177737
Adjust some of the styles to the new Toggleable format
2023-06-20 16:05:23 -07:00
Piotr Osiewicz
198a446b03
Implement Toggleable<T> and Interactive<T> properly
2023-06-20 16:05:23 -07:00
Piotr Osiewicz
c47d1e9f51
Add toggle.ts and interactive.ts
2023-06-20 16:05:23 -07:00
Piotr Osiewicz
b9959ffdc0
Do not flatten Interactive::default
2023-06-20 16:05:23 -07:00
Piotr Osiewicz
0256f89dd6
Rename on/off states to active/inactive
2023-06-20 16:05:23 -07:00
Piotr Osiewicz
e92015b12f
Split out Interactive<T> into Toggle<T> and Interactive<T>
2023-06-20 16:05:20 -07:00
Mikayla Maki
9b77cafd7b
Add a mic sharing to room joining
2023-06-20 15:35:19 -07:00
Mikayla Maki
8273e08d4a
Add is_muted and is_deafened
2023-06-20 15:23:06 -07:00
Nathan Sobo
bd7f8e8b38
Scan conversations dir on assistant panel open and on changes
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-20 16:19:43 -06:00
Mikayla Maki
cf4251fb55
Fix deafened -> enabled mistranslation
...
Fix mislocation of caller query in detach_and_log_error
Fix incorrect wording on livekit integration
Add share_mic action for manually enabling the microphone
Make mic sharing wait until the room has been fully established
2023-06-20 15:17:49 -07:00
Julia
f91e95f24a
Merge branch 'main' into fix-broken-lsp-installations
2023-06-20 17:23:34 -04:00
Mikayla Maki
dbd95e35cf
fmt
2023-06-20 12:36:36 -07:00
Mikayla Maki
b828a74ad6
Add deafen controls
2023-06-20 12:34:32 -07:00
Nathan Sobo
230b4d237e
Add SavedConversation::list() method
...
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-06-20 13:29:34 -06:00
Nathan Sobo
9f783944a7
Wait until we have a summary before saving a conversation
...
Also, avoid collisions by adding a discriminant.
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-06-20 13:03:23 -06:00
Antonio Scandurra
c416551318
Don't use the summary as the filename if it's not done yet
2023-06-20 19:19:02 +02:00
Antonio Scandurra
f904698457
Use the OPENAI_API_KEY environment variable when present
2023-06-20 19:18:49 +02:00
Antonio Scandurra
31a70efe66
Autosave conversations
2023-06-20 19:10:52 +02:00
Mikayla Maki
e58f0ac72f
Add mute toggling controls
2023-06-20 09:35:57 -07:00
Antonio Scandurra
c83a918a7e
Merge remote-tracking branch 'origin/main' into save-conversations
2023-06-20 18:16:40 +02:00
Antonio Scandurra
6ed86781b2
Instruct the assistant to reply to a specific message ( #2631 )
...
Closes
https://linear.app/zed-industries/issue/Z-2384/hitting-cmd-enter-in-a-user-or-system-message-should-generate-a
Release Notes:
- Introduced the ability to generate assistant messages for any
user/system message, as well as generating multiple assists at the same
time, one for each cursor. (preview-only)
2023-06-20 18:16:23 +02:00
Nathan Sobo
03993ea719
Rename SumTree::push_tree to ::append ( #2626 )
...
This is something I've been meaning to rename in SumTree. Was looking at
the code and figure why not now.
2023-06-20 08:37:55 -06:00
Julia
adccfdfbbf
Avoid assigning NSCursor style when it already is that style ( #2632 )
...
This avoids a high cost which appears to be the system rasterizing the
cursor every time we call this, fixes a slowdown when scrolling rapidly
while mouse motion continually attempted to assign the style
Fixes
https://linear.app/zed-industries/issue/Z-2200/editor-scroll-slowdown
Release Notes:
- Improved the performance of scrolling by avoiding unnecessary cursor
changes
([#1597 ](https://github.com/zed-industries/community/issues/1597 )).
2023-06-20 10:02:04 -04:00
Antonio Scandurra
1d84da1d33
Improve prompt
2023-06-20 15:32:51 +02:00
Julia
dc07b60e40
Avoid assigning NSCursor style when it already is that style
...
This avoids a high cost which appears to be the system rasterizing the
cursor every time we call this, fixes a slowdown when scrolling rapidly
while mouse motion continually attempted to assign the style
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-06-20 09:31:30 -04:00
Antonio Scandurra
8673b0b75b
Avoid including pending or errored messages on assist
2023-06-20 11:59:51 +02:00
Max Brunsfeld
ebf0c96130
Show a notification when a dependency for a language server is missing ( #2630 )
...
Closes
https://linear.app/zed-industries/issue/Z-2402/elixir-ls-requires-a-system-elixir-runtime-to-be-installed
Closes
https://linear.app/zed-industries/issue/Z-666/notify-users-that-they-need-go-installed-to-use-go-language-server
Release Notes:
- Added a notification when unable to download the Go language server
because Go is not installed.
- Added a notification when unable to run the Elixir language server
because Elixir is not installed.
2023-06-19 20:03:30 -07:00
Max Brunsfeld
050c22312c
Update plugin runtime LspAdapter impl
2023-06-19 19:38:31 -07:00
Nathan Sobo
8c298a9da5
Rename SumTree::push_tree to ::append
2023-06-19 19:49:33 -06:00
Max Brunsfeld
1215de0c42
Show a notification when unable to start elixir-ls
2023-06-19 18:05:30 -07:00
Max Brunsfeld
57c2d85c66
Show a notification that gopls can't be installed without go
2023-06-19 18:05:12 -07:00
Max Brunsfeld
360bbebbd9
Introduce LspAdapterDelegate trait, passed to LspDelegates
2023-06-19 16:12:25 -07:00
Julia
7e70e24bfc
Remove server from both hashmaps
2023-06-19 18:02:57 -04:00
Julia
afa1434aa9
Get further reinstalling a server which died on startup
2023-06-19 17:45:27 -04:00
Max Brunsfeld
05d69c804c
Fix issues with syntax highlighting in elixir and heex ( #2629 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2391/text-within-h-isnt-highlighted-the-same-as-in-heex-files
Fixes
https://linear.app/zed-industries/issue/Z-2415/syntax-highlighting-bug-in-strings
Release Notes:
- Fixed some issues with syntax highlighting in Elixir and Heex.
If the release notes are only intended for a specific release channel
only, add `(<release_channel>-only)` to the end of the release note
line.
These will be removed by the person making the release.
2023-06-19 12:56:09 -07:00
Max Brunsfeld
04430fdbd6
Fix issues with syntax highlighting in elixir and heex
2023-06-19 12:34:46 -07:00
Julia
da2ee55013
Route some more information for reinstall after startup failure
...
Doesn't actually reinstall on that particular failure due to wrong
variant in hashmap
2023-06-19 15:18:12 -04:00
Mikayla Maki
6ad0b5d79f
Change color representation in json schema
2023-06-19 11:47:11 -07:00
Mikayla Maki
ea46947489
Tidy up font schema a little
2023-06-19 11:36:42 -07:00
Mikayla Maki
193ad64d18
Add JsonSchema to container style and fix compile errors
2023-06-19 11:31:17 -07:00
Piotr Osiewicz
2a3c660d1f
settings: accept trailing commas ( #2606 )
...
Z-2357
I've found a crate that handles both comments and trailing commas in
JSON. It is a fork of `serde_json`, but it is maintained & up-to-date.
Sadly RawValue seems to not play nicely with it; I've ran into
deserialisation issues around use of RawValue. For this PR I've migrated
to `Value` API.
Obviously this is just a point of discussion, not something I'd merge
straight away. There may be better solutions to this particular problem.
I've also noticed that `serde_json_lenient` does not handle trailing
commas after bindings array. I'm not sure how big of an issue that is.
Release Notes:
- Improved handling of trailing commas in settings files.
[#1322 ](https://github.com/zed-industries/community/issues/1322 )
2023-06-19 18:29:03 +02:00
Antonio Scandurra
cb55356106
WIP
2023-06-19 17:53:05 +02:00
Antonio Scandurra
75e2329028
Allow for multi-cursor assist and cycle_role actions
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Kyle Caverly <kyle@zed.dev >
2023-06-19 17:23:40 +02:00
Antonio Scandurra
9191a82447
Remove Assistant::open_ai_request_messages
2023-06-19 14:35:33 +02:00
Antonio Scandurra
dc9231d5a3
Merge remote-tracking branch 'origin/main' into replies
2023-06-19 14:28:21 +02:00
Antonio Scandurra
70ccbbafc1
Allow message splitting with multiple cursors ( #2627 )
...
Closes
https://linear.app/zed-industries/issue/Z-2408/make-block-splitting-work-with-multiple-cursors
2023-06-19 12:07:16 +02:00
Piotr Osiewicz
3e3079b513
cargo fmt
2023-06-19 12:07:02 +02:00
Piotr Osiewicz
91f2f31daa
Split git/project label into a flex row
2023-06-19 12:06:42 +02:00
Antonio Scandurra
c9df963142
Allow message splitting with multiple cursors
2023-06-19 12:00:45 +02:00
Joseph T. Lyons
c858ab263c
Add pane activation bindings for Atom keymap ( #2625 )
...
Release Notes:
- N/A
2023-06-18 02:09:26 -04:00
Joseph T. Lyons
bb04d65b8e
Add pane activation bindings for Atom keymap
2023-06-18 02:05:25 -04:00
Nate Butler
ffd1190cca
Update rose pine theme family
2023-06-16 23:02:32 -04:00
Nathan Sobo
882009bc75
Save conversations to ~/.config/zed/conversations
...
Still need to implement loading / listing.
I'd really be rather write operations to a database. Maybe we
should be auto-saving? Integrating with panes? I just did
the simple thing for now.
2023-06-16 16:15:07 -06:00
Nathan Sobo
c3b2b4c4e3
Cycle message roles on ctrl-r ( #2619 )
...
I'd like to follow up to allow roles to be cycled for the selected range
and support multi-cursors, but this is a start and contains a
refactoring, so going to merge.
Release Notes:
- Added the ability to cycle roles in the assistant with `ctrl-r`
2023-06-16 14:11:01 -06:00
Kirill Bulatov
7ff194f21f
React on message-less LSP requests properly ( #2620 )
2023-06-16 23:00:14 +03:00
Sergey Onufrienko
ac42522987
chore: remove ts-rs
2023-06-16 21:45:37 +02:00
Sergey Onufrienko
4badef19f1
feat: add Nodejs script to convert Json to TS
2023-06-16 21:39:22 +02:00
Sergey Onufrienko
6d6b7020a0
feat: export_schema
2023-06-16 21:38:06 +02:00
Sergey Onufrienko
a87b39a2d1
feat: add JsonSchema to Theme
2023-06-16 21:37:56 +02:00
Sergey Onufrienko
b45f5f0489
feat: add JsonSchema to gpui
2023-06-16 21:36:42 +02:00
Kirill Bulatov
77f5b5a80d
React on message-less LSP requests properly
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-16 22:02:29 +03:00
Nathan Sobo
54c71c1a35
Insert reply after the currently selected user message
2023-06-16 12:41:07 -06:00
Mikayla Maki
ecd2129c2f
Add deafen and mute stubs
2023-06-16 11:16:36 -07:00
Nathan Sobo
11f318566e
Allow splitting of messages using shift-enter ( #2613 )
...
Closes
https://linear.app/zed-industries/issue/Z-2364/allow-splitting-blocks
Release Notes:
- Added support for splitting messages in the assistant panel using
`shift-enter`. (preview-only)
2023-06-16 11:50:50 -06:00
Nathan Sobo
75b5ac8488
Cycle message roles on ctrl-r
2023-06-16 11:50:18 -06:00
Mikayla Maki
53062e8422
turn mic off by default in dev builds, add enviroment variable for turning it back on
2023-06-16 10:44:31 -07:00
Nathan Sobo
c179dd9990
Remove redundant tests
2023-06-16 11:43:16 -06:00
Mikayla Maki
dedc117cca
Add audio APIs to Zed
...
Share mic on joining room
2023-06-16 10:13:27 -07:00
Nathan Sobo
6c0f65cfe0
Avoid inserting redundant newlines
...
Co-Authored-By: Piotr Osiewicz <piotr@zed.dev >
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-06-16 10:36:42 -06:00
Piotr Osiewicz
ef6cb11d5c
Emit editor event whether we insert a newline or not.
2023-06-16 13:29:12 +02:00
Piotr Osiewicz
ae68be64c0
Move share button to the right hand side
2023-06-15 22:05:43 -07:00
Piotr Osiewicz
d079a0eb20
Render user avatar only if an user is not in a call
2023-06-15 22:05:43 -07:00
Piotr Osiewicz
83c1bb07bb
Add background to user avatar
2023-06-15 22:05:43 -07:00
Piotr Osiewicz
433c5d30f5
Add Sign in button for an unregistered user
2023-06-15 22:05:43 -07:00
Piotr Osiewicz
092cf93dae
Move zed actions to zed-actions
2023-06-15 22:05:43 -07:00
Piotr Osiewicz
4b87ce8952
add zed-actions crate
2023-06-15 22:05:43 -07:00
Piotr Osiewicz
0fe65b945f
Remove user avatar from dropdown menu
...
Add new options in context menu
2023-06-15 22:05:43 -07:00
Piotr Osiewicz
5f7fdd25eb
Fix compile error (use of moved value)
2023-06-15 22:05:43 -07:00
Mikayla Maki
47ef800dc6
WIP: Add face to right hand menu
2023-06-15 22:05:43 -07:00
Mikayla Maki
aac71fdcfe
Remove border from sign in button
...
Co-authored-by: Piotr <piotr@zed.dev >
2023-06-15 22:05:43 -07:00
Mikayla Maki
8235d78afe
Voice support ( #2602 )
...
This PR adds APIs for voice chat to our live kit integration
Release Notes:
- N/A
2023-06-15 19:40:01 -07:00
Mikayla Maki
d7dbc3b5d3
Implement test stubs
2023-06-15 19:28:59 -07:00
Max Brunsfeld
8592208d3a
Fix failure to upload panics when multiple panics happen at the same time ( #2616 )
...
When multiple panics occur at the same time (usually because one thread
panics, and another thread joins it), multiple panic JSON objects can
get written to the same panic file. The resulting file won't be valid
JSON.
This PR addresses that problem via two changes:
* Format panic files as single-line JSON objects
* When a panic file isn't valid JSON, try taking the first line
In the future, we could try combining all of the backtraces, but for
now, I just want to avoid a problem of not reporting a panic at all.
Release Notes:
- Fixed a problem with Zed's internal crash reporting.
2023-06-15 15:31:49 -07:00
Mikayla Maki
b9270925dd
Focus on toggle dock ( #2612 )
...
This PR updates some dock behaviors. Now the toggle-dock commands
(cmd-j/b/r) also toggle focus. This also adds zoom serialization to the
docks.
Release Notes:
- Bug fix: Toggle dock commands (cmd-j/b/r) now move focus
- Bug fix: Dock zoom is now restored with the rest of the workspace
2023-06-15 15:20:20 -07:00
Max Brunsfeld
e525706581
Fix failure to upload panics when multiple panics happen at the same time
2023-06-15 15:16:26 -07:00
Mikayla Maki
b156644daf
fixed tests to match new behavior
2023-06-15 15:09:37 -07:00
Mikayla Maki
b7e3ac5bf4
Fix bug on workspace deserialization
2023-06-15 14:56:37 -07:00
Mikayla Maki
b9cb594626
Fix fmt
2023-06-15 14:51:38 -07:00
Max Brunsfeld
5f93a4effd
Don't rely on debug symbols for panic reporting ( #2615 )
...
This fixes a regression introduced in
https://github.com/zed-industries/zed/pull/2560 , where panic reports did
not include backtraces. The problem was that in that PR, I assumed we
could retrieve file paths for symbols in our backtraces. But actually,
that functionality only works when the app is built locally, and a
`.dSYM` file can be magically found by the OS. We don't ship those dSYM
files with Zed, so panic symbols do not have file paths available.
Panic backtraces will still be more useful and less noisy than before
though: we will strip out frames for which we don't have symbol names,
and remove leading panic-handling stack frames from the backtraces.
Release Notes:
- N/A
2023-06-15 14:09:42 -07:00
Max Brunsfeld
e7e0f2183f
Don't rely on debug symbols for panic reporting
2023-06-15 12:27:39 -07:00
Julia
abe5ecc5ec
Actually fully start reinstalled language server
2023-06-15 13:56:07 -04:00
Julia
f81ccbd652
Setup C adapter with test binary
2023-06-15 12:18:34 -04:00
Julia
4d24eae901
Actually check and reinstall broken server
2023-06-15 12:18:34 -04:00
Julia
bca625a197
Many steps toward validating and reinstalling server after failure
2023-06-15 12:18:34 -04:00
Julia
ec0409a3d1
Detect LSP startup failure
2023-06-15 12:18:34 -04:00
Antonio Scandurra
0a8d67c4ca
Activate screen-sharing when leader activates a panel ( #2614 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1875/screen-sharing-tab-is-not-activated-when-leader-is-on-a-panel
Release Notes:
- Fixed a bug that caused followers to not see the leader's screen when
they activated a panel.
2023-06-15 18:13:07 +02:00
Antonio Scandurra
f068712a0a
Activate screen-sharing when leader activates a panel
2023-06-15 18:01:30 +02:00
Nathan Sobo
8c6ba13fef
Never insert an empty prefix when splitting a message with a non-empty range
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
Co-Authored-By: Piotr Osiewicz <piotr@zed.dev >
2023-06-15 09:02:15 -06:00
Nate Butler
0863486803
Add internal markdown docs ( #2598 )
...
This PR adds internal docs directly to the codebase.
There are a few goals here:
- Make it easier to document our internal processes
- Put the documentation where people already are
- Allow changes to be in sync with PRs
- Make it easier for people coming in to discover our docs and onboard
faster.
With 2 more people joining us in the next few weeks it would be great to
get these up.
Release Notes:
- N/A (No public facing changes)
2023-06-15 10:55:55 -04:00
Nate Butler
87c3216236
Fix design tools link
2023-06-15 10:38:15 -04:00
Nate Butler
5149db6acd
Update docs/index.md
...
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com >
2023-06-15 10:36:53 -04:00
Antonio Scandurra
21e8e8763e
Allow splitting of messages using shift-enter
2023-06-15 14:05:26 +02:00
Piotr Osiewicz
86247bf657
editor: Highlight search results
...
Z-1292
2023-06-15 09:44:44 +02:00
Mikayla Maki
6662066821
Add zoom serialization to the workspace
2023-06-14 23:43:45 -07:00
Mikayla Maki
790d995381
Add focusing into the toggle dock commands
2023-06-14 23:04:41 -07:00
Mikayla Maki
a4b009a497
Update test-app sound
2023-06-14 18:40:45 -07:00
Mikayla Maki
ce3847c9fc
WIP: Use audio support to send live data
2023-06-14 18:40:45 -07:00
Mikayla Maki
bbf05c8eac
Wire in audio APIs from swift
...
co-authored-by: nathan <nathan@zed.dev >
2023-06-14 18:40:45 -07:00
Mikayla Maki
8ccb75029f
Add entitlements file to bundle step ( #2611 )
...
This completes the bundle changes that will be needed to access voice,
as well as adds permissions for accessing other MacOS services, the
camera, and the necessary permissions for plugins. This was developed by
combining the entitlements of iTerm and VSCode, cross-referenced with
the entitlements of Firefox.
Release Notes:
- Fixed a bug in enabling authorization for macOS services (preview
only)
2023-06-14 18:06:55 -07:00
Mikayla Maki
b481e383ce
Update bundle
2023-06-14 17:37:47 -07:00
Mikayla Maki
493e489c51
Add entitlements file to bundle step
2023-06-14 17:34:48 -07:00
Joseph Lyons
2e723cac62
v0.92.x dev
2023-06-14 13:27:36 -04:00
Mikayla Maki
75b1f60126
Add UsageDescriptions to Info.plist ( #2609 )
...
This updates our dependency on cargo-bundle to point at a fork I've
created that adjusts the latest version's behavior to work for our use
case. This PR also updates the Zed Info.plist to include the following
keys:
- NSSystemAdministrationUsageDescription
- NSAppleEventsUsageDescription
- NSBluetoothAlwaysUsageDescription
- NSCalendarsUsageDescription
- NSCameraUsageDescription
- NSContactsUsageDescription
- NSLocationAlwaysUsageDescription
- NSLocationUsageDescription
- NSLocationWhenInUseUsageDescription
- NSMicrophoneUsageDescription
- NSSpeechRecognitionUsageDescription
- NSRemindersUsageDescription
Release Notes:
- Bug fix: Allow applications run via the Zed terminal to request
authorization for macOS services (e.g. microphone and camera)
2023-06-14 10:04:54 -07:00
Antonio Scandurra
2b8b954c3e
Overhaul assistant panel ( #2610 )
...
Closes
https://linear.app/zed-industries/issue/Z-2368/use-a-different-icon-for-the-assistant-panel
Closes
https://linear.app/zed-industries/issue/Z-2363/ship-the-assistant-only-on-preview
Closes
https://linear.app/zed-industries/issue/Z-2331/scrolling-makes-it-hard-to-read
Closes
https://linear.app/zed-industries/issue/Z-2306/allow-undo-and-collaboration-in-assistant
This pull request is a significant overhaul of the assistant panel,
which now uses a simple `Buffer` as opposed to a `MultiBuffer` to show
messages. Specifically, we track the start of each message with an
anchor located right after the newline (or `Anchor::MIN` for the first
message). When the anchor becomes invalid (that is, the newline is
deleted), we merge the message with the preceding ones. Crucially,
messages don't actually get deleted so that, if the newline anchor
becomes valid again (such as when undoing/redoing), we can restore the
messages as well.
As part of this overhaul, we are also improving the scrolling behavior
to maintain the viewport stable only when editing or moving the cursor,
but otherwise leave the scroll position unchanged when manually
scrolling up or down.
Note that with these changes, we are limiting access to the assistant to
users on preview (and dev), as we want to polish the behavior a little
more before shipping to the general public. Users on stable will still
be able to see the default settings/keybindings of the assistant, but I
think that's okay, as they won't be able to do anything with them.
Release Notes:
- Added support for undo/redo in the assistant (preview-only)
- Improved the scrolling behavior of the assistant when it was
generating responses. Now Zed will keep the viewport stable only when
editing or moving the cursor, but otherwise leave the scroll position
unchanged when manually scrolling up or down (preview-only)
- Changed the icon of the assistant panel (preview-only)
**Note for @JosephTLyons: given that we're feature flagging this, let's
make sure things on stable look reasonable and work correctly. Things to
look out for: ensure a stock installation works, changing the settings
on stable works, changing the keybinding on stable works.**
2023-06-14 14:09:09 +02:00
Antonio Scandurra
4efe62b3e5
Use robot icon for assistant to prevent confusion with conversations
2023-06-14 12:14:43 +02:00
Antonio Scandurra
049c987310
Avoid loading the assistant panel on stable
2023-06-14 12:08:49 +02:00
Antonio Scandurra
56b0bf8601
Save cursor scroll position when the editor is auto-scrolled
2023-06-14 12:00:27 +02:00
Antonio Scandurra
1aa1774688
Avoid auto-scrolling the editor when inserting/removing headers
2023-06-14 10:49:23 +02:00
Antonio Scandurra
f8b9417406
Keep cursor stable as autocompletions are being streamed
2023-06-14 10:41:18 +02:00
Antonio Scandurra
75ad76bfb2
💄
2023-06-14 09:47:30 +02:00
Antonio Scandurra
7dab17e233
Re-enable copy support in the assistant
2023-06-14 09:40:43 +02:00
Antonio Scandurra
27c83ca3f7
Remove unnecessary set_render_excerpt_header method
2023-06-14 09:38:49 +02:00
Antonio Scandurra
9b7617403d
Parse buffer as Markdown
2023-06-14 09:31:41 +02:00
Antonio Scandurra
ea5d677ef8
Merge remote-tracking branch 'origin/main' into assistant-buffer
2023-06-14 09:16:45 +02:00
Mikayla Maki
adc8337ad4
Restore misconfigured Cargo.toml
2023-06-13 18:08:33 -07:00
Mikayla Maki
8ad7eb7598
Switch to using new version of cargo bundle with more capabilities
2023-06-13 18:01:51 -07:00
Kevin Hovsäter
b365e48ff0
Toggle comments for empty single line selections ( #2594 )
2023-06-13 20:15:11 +02:00
Max Brunsfeld
77367bf2e4
Move worktree tests into their own file ( #2608 )
...
The worktree has a lot of tests. Let's reduce their indentation, and
make it easier to navigate to them. We deserve it.
Just doing this in its own PR, to minimize conflicts.
Release Notes:
- N/A
2023-06-13 10:50:49 -07:00
Max Brunsfeld
5b6d1a27ff
Flatten worktree tests module structure
2023-06-13 10:31:29 -07:00
Max Brunsfeld
c17dbab6f1
Move worktree tests to their own file
2023-06-13 10:22:14 -07:00
Piotr Osiewicz
b272db9e21
editor: Add language setting for comment continuations ( #2605 )
...
Per @JosephTLyons request I've added a language setting for comment
continuations.
Release Notes:
- Added a language setting for comment continuations.
2023-06-13 18:59:46 +02:00
Max Brunsfeld
aedef7bc58
Remove panic when programatically updating an invalid setting ( #2607 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2170/thread-main-panicked-at-could-not-deserialize-setting-type-welcomebase
Fixes
https://linear.app/zed-industries/issue/Z-2228/thread-main-panicked-at-could-not-deserialize-setting-type
2023-06-13 09:50:54 -07:00
Max Brunsfeld
1cd11bfe66
Remove panic when programatically updating an invalid setting
2023-06-13 09:43:57 -07:00
Antonio Scandurra
0db0a1ccef
Skip merged messages when inserting new ones
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-13 16:06:50 +02:00
Antonio Scandurra
6e5de2fbbb
Update blocks when cycling the message role
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-13 16:00:13 +02:00
Antonio Scandurra
00cede63a8
Show message headers again
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-13 15:55:52 +02:00
Antonio Scandurra
2842fc2b1d
Merge messages whose header has been invalidated
2023-06-13 15:16:04 +02:00
Antonio Scandurra
2ae8b558b9
Get back to a compiling state with Buffer backing the assistant
2023-06-13 13:43:06 +02:00
Joseph T. Lyons
5e68dc5c92
Fix comments in settings files ( #2604 )
...
I accidentally added the information about folder-specific settings to
the user settings default file - just fixing that.
Release Notes:
- N/A
2023-06-13 04:06:53 -04:00
Joseph Lyons
5821bc4161
Fix comments in settings files
2023-06-13 04:03:51 -04:00
Max Brunsfeld
d8a2e176e6
Add support for HEEx templates in Elixir, fix a bug in handling nested language injections ( #2603 )
...
Closes https://linear.app/zed-industries/issue/Z-2211/heex-support
Release Notes:
- Added support for Elixir HEEx templates.
- Fixed a bug that caused incorrect syntax highlighting in ERB templates
([#1619 ](https://github.com/zed-industries/community/issues/1619 )).
2023-06-12 17:49:07 -07:00
Max Brunsfeld
df76ab98cf
Add Heex language
2023-06-12 17:32:20 -07:00
Max Brunsfeld
01bd5c30fc
Fix syntax map bug with combined injections inside of other injections
2023-06-12 17:32:20 -07:00
Max Brunsfeld
ac1882b99b
Move SyntaxMap tests to their own file
2023-06-12 16:24:17 -07:00
Max Brunsfeld
04e43899c0
Change action namespace to 'debug' for LSP log and syntax tree view
2023-06-12 15:54:36 -07:00
Max Brunsfeld
8542911eec
Add a syntax tree view, for developing and debugging language support ( #2601 )
...
This PR adds a syntax tree view, which lets you view the syntax tree of
any layer in the active editor's `SyntaxMap`.
This view uses some new APIs that I added to Tree-sitter, which allow us
to efficiently render the syntax tree using a `UniformList`. Tree-sitter
PR: https://github.com/tree-sitter/tree-sitter/pull/2316

Release Notes:
- Added a *syntax tree view* that shows Zed's internal syntax tree(s)
for the active editor. You can open it running the `debug: open syntax
tree view` command from the command palette.
2023-06-12 15:50:39 -07:00
Max Brunsfeld
018466171b
Include field names in the syntax tree
2023-06-12 15:32:16 -07:00
Max Brunsfeld
594b9def20
Upgrade Tree-sitter
2023-06-12 15:31:59 -07:00
Max Brunsfeld
b4f3a88b38
Close the menu when selecting a different layer in the syntax tree view
2023-06-12 15:14:57 -07:00
Max Brunsfeld
56b749788f
Improve the look of the syntax tree view UI
2023-06-12 15:14:57 -07:00
Max Brunsfeld
e969e3b028
Sync selection between syntax tree view and editor
2023-06-12 15:14:57 -07:00
Max Brunsfeld
086cfe57c5
Start work on a syntax tree view
2023-06-12 15:14:56 -07:00
Sergey Onufrienko
cfc1856210
feat: add ts export
2023-06-12 22:13:19 +02:00
Sergey Onufrienko
b494b43496
chore: add ts-rs
2023-06-12 22:12:24 +02:00
Piotr Osiewicz
3d02f7ce5f
Move plugins to feature-gate ( #2599 )
...
This PR:
- Reduces our dependency count for a release build by 20%
- Reduces our release compile time by about 30s (out of ~5 minutes)
2023-06-12 21:04:09 +02:00
Antonio Scandurra
7db690b713
WIP
2023-06-12 17:50:13 +02:00
Nate Butler
7f71ee0870
Expand tools doc further
2023-06-12 09:45:42 -04:00
Nate Butler
f142449014
Add back links
2023-06-12 09:02:49 -04:00
Nate Butler
57ae64d44a
Use simple markdown
2023-06-12 09:00:59 -04:00
Joseph T. Lyons
db5bb4ec03
Do not rely on user's system time for telemetry events ( #2597 )
...
Some user's don't have their system clocks configured right and we are
seeing events 10 years into the future. I'm stripping out the code that
adds time via the client and am adding it in on zed.dev. We will lose a
little accuracy, as the time will be when the batch hits the server, but
I think its negligible (currently, batches send up every 30 seconds, at
the max) and worth it to protect our data from user's who wonkily dont
set care about their system time.
- https://github.com/zed-industries/zed.dev/pull/332
Release Notes:
- N/A
2023-06-09 18:08:11 -04:00
Joseph Lyons
0b3b732310
Do not rely on user's system time for telemetry events
2023-06-09 18:02:20 -04:00
Max Brunsfeld
56a4c2afae
Bump tree-sitter-yaml to avoid submodule error during build
2023-06-09 14:58:31 -07:00
Joseph T. Lyons
d8c1ab9c68
Fix formatter comment in default settings ( #2593 )
...
Fix comment related to the `formatter` configuration option in Zed's
default settings.
Release Notes:
- N/A
2023-06-09 15:14:04 -04:00
Max Brunsfeld
c1f1ee6b05
collab 0.14.2
2023-06-09 11:50:35 -07:00
Max Brunsfeld
b2bdca4779
Bump protocol version
2023-06-09 11:50:15 -07:00
Max Brunsfeld
097632467d
collab 0.14.1
2023-06-09 11:37:47 -07:00
Max Brunsfeld
87efd25d42
Avoid dropping the worktree_repository_statuses table for now
2023-06-09 11:37:39 -07:00
Max Brunsfeld
bb65d75798
Enable rust backtraces on kubernetes
2023-06-09 11:15:21 -07:00
Max Brunsfeld
9cbb63d374
collab 0.14.0
2023-06-09 11:12:45 -07:00
Piotr Osiewicz
5bef2f1778
Z-2303 editor: fix comment extension on the start of line ( #2595 )
...
Release Notes:
- Improved comment extension for cases where cursor was placed before
start of comment marker
2023-06-09 20:02:51 +02:00
Max Brunsfeld
fb83ab8e9f
Add outline support for Ruby singleton methods ( #2592 )
...
This pull request add support for Ruby singleton methods in the document
outline.
**Before**
<img width="1490" alt="outline-before"
src="https://github.com/zed-industries/zed/assets/503025/e90afd4c-bcdd-477b-92cf-fe34cec54980 ">
**After**
<img width="1493" alt="outline-after"
src="https://github.com/zed-industries/zed/assets/503025/067cc80b-7718-4395-9079-4677a689b9be ">
Release Notes:
- Added support for singleton methods in Ruby outline view. Fixed
[#1442 ](https://github.com/zed-industries/community/issues/1442 ).
2023-06-09 08:35:34 -07:00
Max Brunsfeld
738b06a778
Update JavaScript outline queries ( #2596 )
...
Add support for exported const declarations in the outline view. Did not
include more context (e.g., whether or not the it's exported or not)
because we're not doing that for TypeScript right now. We could do that
in a follow up pull request, addressing both JavaScript and TypeScript
at once.
**Before**
<img width="1186" alt="outline-before"
src="https://github.com/zed-industries/zed/assets/503025/e72b0ed4-52b0-4a7c-af70-b2f4758e3554 ">
**After**
<img width="1186" alt="outline-after"
src="https://github.com/zed-industries/zed/assets/503025/cd91bc7f-8ce3-485f-9b33-d487ad6c718d ">
Release Notes:
- Added support for exported const declarations in the JavaScript
outline view. Fixed
[#1399 ](https://github.com/zed-industries/community/issues/1399 ).
2023-06-09 08:34:14 -07:00
Kevin Hovsäter
4213cc013c
Update JavaScript outline queries
...
Add support for exported const declarations in the outline view.
2023-06-09 15:33:27 +02:00
Kevin Hovsäter
6ce3f3bf27
Refactor toggle comment tests
2023-06-09 13:22:04 +02:00
Kevin Hovsäter
a8d43c6d71
Toggle comments for empty single line selections
2023-06-09 10:10:49 +02:00
Kevin Hovsäter
7deddd1149
Fix formatter comment in default settings
2023-06-09 08:08:07 +02:00
Kevin Hovsäter
57ff173e29
Add outline support for Ruby singleton methods
2023-06-09 07:31:09 +02:00
Nate Butler
85b049f250
Build tokens for each theme ( #2590 )
...
This PR adds the ability to export tokens for each theme.
You can export tokens by:
1. `cd styles`
2. `npm run build-tokens`
3. Tokens will be output in the target folder (`styles/target`)
The tokens match the ColorScheme object. In the future we may also
export tokens for our styleTrees.
Release Notes:
- N/A (No public facing changes)
---
TODO:
- [x] Generate Token Studio theme index file
- [x] ColorScheme
- [x] name:
- [x] isLight
- [x] lowest
- [x] middle
- [x] highest
- [x] popoverShadow
- [x] modalShadow
- [x] players
- [x] syntax
2023-06-08 16:40:46 -04:00
Nate Butler
ddcbc774ab
$tokens.json => $themes.json
2023-06-08 16:36:15 -04:00
Nate Butler
e4cbc29f98
Update buildTokens to export $metadata.json and $themes.json
2023-06-08 16:19:28 -04:00
Max Brunsfeld
6304897abc
Make the LSP log view searchable ( #2591 )
...
Also, I noticed errors in the logs of the Elixir LSP that we were
sending `goToTypeDefinition` requests, which that server does not
support. We now respect that server capability.
Release Notes:
- N/A
2023-06-08 13:15:05 -07:00
Nate Butler
3719c206c9
Only export color tokens for syntax
2023-06-08 15:14:59 -04:00
Nate Butler
91e1bb8fd4
WIP syntax tokens
2023-06-08 15:12:11 -04:00
Max Brunsfeld
a7f06f962b
Enable type definition capability in fake LSPs in tests
2023-06-08 12:09:37 -07:00
Max Brunsfeld
e0dd9e4185
Make the LSP log view searchable
2023-06-08 11:33:20 -07:00
Max Brunsfeld
11dbbcc9dd
Respect LSP goToTypeDefinition server capability
2023-06-08 11:33:09 -07:00
Nate Butler
999b2365a8
Export additional tokens, standardize naming convention
2023-06-08 12:21:51 -04:00
Max Brunsfeld
e3f319467a
Enhance LSP log viewer to show server logs in addition to RPC trace ( #2586 )
...
In debugging what's going on with the Elixir language server, there was
some interesting content in the server's logs (sent to the app via the
`window/logMessage` LSP endpoint). I decided to invest in making
language server issues easier to debug by exposing these `logMessage`
contents in the app.
Also, improve the UI of the view slightly:
* Select one of the servers by default (instead of "no server selected")
* Make it clearer that the menu is clickable
2023-06-08 09:03:52 -07:00
Max Brunsfeld
908de23b72
Tweak LSP log menu styling
2023-06-08 08:58:57 -07:00
Max Brunsfeld
afaff7f9a9
Merge branch 'main' into lsp-log-messages
2023-06-08 08:49:08 -07:00
Max Brunsfeld
817644eb20
Style new lsp log menu, add a test for it
2023-06-08 08:43:25 -07:00
Nate Butler
e2f46d5448
Build layer tokens for each theme
2023-06-08 11:15:59 -04:00
Nate Butler
16e3e04501
Update TSConfig ( #2589 )
...
Based on #2558 . Also fixes errors resulting from the stricter options.
Release Notes:
- N/A (No public facing changes)
2023-06-08 01:31:21 -04:00
Nate Butler
1e43fec1c5
Update buildLicenses to only include the theme url if there is one
2023-06-08 01:23:19 -04:00
Nate Butler
e996a66596
Update TSCondif
...
Based on #2558 . Also fixes errors resulting from the stricter options.
2023-06-08 01:15:57 -04:00
Nate Butler
a75e9faa83
Add foundation for exporting tokens from our color schemes ( #2588 )
...
We removed our Figma Tokens/Tokens Studio export a while back when we
moved to the theme to ColorSchemes. I'd like to get back to exporting
these so we can be working from up to date themes in Figma, especially
with the large amount of UI design work we'll be doing in the next few
weeks on channels.
This PR adds some basic plumbing to start working through the
theme/colorScheme and export the parts as tokens.
I also discovered that Tokens Studio now publishes their types, so we
can use them directly rather than writing our own:
https://github.com/tokens-studio/types
Pulled those in and started connecting them as well.
Running `npm run build-tokens` will export the tokens for each theme to
`styles/target/tokens`.
Currently only a few element's tokens are exported, will expand this
further as time permits.
Release Notes:
- N/A (No public facing changes)
2023-06-08 00:53:16 -04:00
Nate Butler
c8a9d73ea6
Add foundation for exporting tokens
2023-06-08 00:37:00 -04:00
Nate Butler
d4192fc3e9
Organize misc files into theme, themes and styleTrees ( #2587 )
...
We've accumulated a number of miscellaneous folders in the styles
folder. Simplifying these down to `theme`, `themes` and `styleTrees`.
Release Notes:
- N/A (No public facing changes)
2023-06-07 22:47:48 -04:00
Mikayla Maki
8216d26a7a
Switch to attaching git statuses to their associated entries ( #2571 )
...
This rewrites and simplifies the git status system by attaching the git
status to each individual entry. This also improves the git testing
infrastructure to cover more cases and be more accurate to how file
events actually occur. This also fixes several other bugs in the worktree and the buffer, and stops any randomly generated actions from happening inside a `.git` folder. Hopefully, we can undo this change soon once our randomized testing is more robust.
Release Notes:
- Will require a DB migration
TODO:
- [x] Pass randomized tests
- [x] Get ready for merging
2023-06-07 17:11:43 -07:00
Mikayla Maki
fc1f8c5657
Fixed ci
2023-06-07 16:58:55 -07:00
Mikayla Maki
8ca1a7d43d
add scan_complete await
2023-06-07 16:51:54 -07:00
Max Brunsfeld
66f215cd13
Restructure LSP log view to show log messages in addition to RPC trace
2023-06-07 16:51:09 -07:00
Mikayla Maki
9e9d8e3a7b
add mroe dbg
2023-06-07 16:50:15 -07:00
Mikayla Maki
9d58c4526d
Fix warning
2023-06-07 16:45:36 -07:00
Mikayla Maki
5f143f689f
Attempting to debug on ci...
2023-06-07 16:44:13 -07:00
Mikayla Maki
572d40381a
Add track caller
2023-06-07 16:39:10 -07:00
Mikayla Maki
2c5e83bf72
Fixed a bug where buffer saved clocks would desynchronize in rare execution paths
...
co-authored-by: Max <max@zed.dev >
2023-06-07 16:10:45 -07:00
Max Brunsfeld
78f9642ac2
Emit project event when a language server sends a logMessage notification
2023-06-07 14:46:08 -07:00
Mikayla Maki
cd63ec2c7f
fmt
2023-06-07 14:20:01 -07:00
Mikayla Maki
03a96d2793
Feature gate import
2023-06-07 14:15:20 -07:00
Mikayla Maki
0ac7a3bc21
fmt
2023-06-07 14:13:57 -07:00
Mikayla Maki
28ba27c9c5
Merge branch 'main' into stream-git-statuses
2023-06-07 14:12:58 -07:00
Mikayla Maki
34e134fafb
Fix several randomized test failures with the new git status implementation
2023-06-07 14:10:17 -07:00
Max Brunsfeld
351e4863cd
Fix some issues found when testing Elixir-LS ( #2583 )
...
Closes
https://linear.app/zed-industries/issue/Z-2209/popovers-dont-always-have-syntax-highlighted-code
Closes
https://linear.app/zed-industries/issue/Z-2206/highlight-syntax-in-hover-docs
* Fix a ton of errors in our logs due to us not recognizing that
`elixir-ls` does not support code actions.
* Syntax-highlight elixir code blocks in hover popovers
2023-06-07 12:21:48 -07:00
Max Brunsfeld
11ab1a8cc6
collab 0.13.1
2023-06-07 10:54:27 -07:00
Max Brunsfeld
be8d268eb9
Bump tree-sitter-yaml submodule to avoid broken child submodule
2023-06-07 10:50:03 -07:00
Max Brunsfeld
72372ddf0e
Highlight hover code blocks as LSP's own language by default
...
The elixir LSP does not include a language name on its elixir code blocks.
2023-06-07 10:01:19 -07:00
Nate Butler
86ec43c908
Update createColorScheme to accept ThemeConfig ( #2557 )
...
- Added ThemeConfig
- Updated themes use ThemeConfig
- Refactoring
- Fixed TypeScript errors
Release Notes:
- N/A (No public facing changes)
2023-06-07 12:57:34 -04:00
Nate Butler
29de420b59
Organize misc files into theme, themes and styleTrees
2023-06-07 12:50:37 -04:00
Nate Butler
6269cec4f1
Minor updates
2023-06-07 12:40:49 -04:00
Max Brunsfeld
6067575e38
collab 0.13.0
2023-06-07 09:29:58 -07:00
Max Brunsfeld
f56d642b88
Disable scheduled randomized test workflow for now
2023-06-07 09:20:25 -07:00
Joseph Lyons
8882b22c9c
v0.91.x dev
2023-06-07 11:57:41 -04:00
Piotr Osiewicz
e94129446d
Z 1618/extend comments ( #2585 )
...
Fixes Z-1618. In the current state, this only works for line comments
such as `//` (and whatever's set in `{language}.toml` as a
line_comment).
Release Notes:
- Comments are now extended on new line.
2023-06-07 17:37:02 +02:00
Sergii Onufriienko
b1f009cdce
Merge branch 'main' into sergey/z-1768-update-createcolorscheme-to-accept-a-theme-in-the
2023-06-07 16:12:13 +01:00
Sergey Onufrienko
4c405e65a3
feat: use theme index to build licenses
2023-06-07 16:10:16 +01:00
Sergey Onufrienko
0ad76ac92c
feat: use theme index to build themes
2023-06-07 16:10:02 +01:00
Sergey Onufrienko
02c1efc60d
feat: re-export chroma
2023-06-07 16:09:24 +01:00
Sergey Onufrienko
f5d1f314e0
feat: add themes index
2023-06-07 16:08:58 +01:00
Sergey Onufrienko
d2b8501347
feat: change themes to return ThemeConfig
2023-06-07 16:08:48 +01:00
Antonio Scandurra
d5441ba386
Introduce an Assistant Panel ( #2584 )
...
This pull request introduces a new assistant panel to Zed that lets
users interact with OpenAI using their API key:

After setting the key up, it will be saved to the keychain and
automatically loaded the next time the assistant panel is opened. The
key can be reset using `assistant: reset key`.

From there, users can type messages in a multi-buffer and hit
`cmd-enter` (`assistant: assist`) to stream assistant responses using
the OpenAI API. Responses can be canceled by hitting `escape`.

Users can quote a selection from the active editor by hitting `cmd->`
(`assistant: quote selection`), which will embed the selected piece of
text in a Markdown fenced code block. Conversations with the assistant
are ephemeral at the moment, but can be easily copy/pasted:

Release Notes:
- Added a new assistant panel feature that enables interacting with
OpenAI using an API key. This replaces the previous experimental `ai:
assist` command that would work on any buffer. The experience is similar
to the one offered by ChatGPT with the added ability to edit, delete or
enhance previous messages. When hitting `cmd-enter`, the assistant will
start streaming responses from OpenAI. A response stream can be canceled
using `escape`. Moreover, the active editor's selection can be quoted in
the assistant panel using `cmd->`, which will automatically embed the
selected piece of text in a Markdown fenced code block.
2023-06-07 16:05:57 +02:00
Antonio Scandurra
d3e0d38bef
Fix assistant panel tests
2023-06-07 15:24:08 +02:00
Antonio Scandurra
d26cc2c897
Maintain scroll bottom when streaming assistant responses
2023-06-07 15:01:50 +02:00
Antonio Scandurra
43500dbf60
Fix zed tests
2023-06-07 10:02:35 +02:00
Antonio Scandurra
0dae8f2dd8
Merge remote-tracking branch 'origin/main' into assistant-2
2023-06-07 09:34:16 +02:00
Antonio Scandurra
a6feaf1300
Allow search assistant editors
2023-06-07 09:24:18 +02:00
Joseph Lyons
c93b6cc599
Tweak comment wording
2023-06-07 00:23:58 -04:00
Max Brunsfeld
e8479f23f9
Improve log message on invalid LSP message from server's stdout
2023-06-06 17:13:59 -07:00
Max Brunsfeld
6f2726524e
Remove stray println
2023-06-06 17:13:59 -07:00
Max Brunsfeld
fccbac4887
Handle LSP codeActions capability set to false
2023-06-06 17:13:59 -07:00
Max Brunsfeld
0d90c6d02e
Improve syntax highlighting and outline view for Elixir ( #2582 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2208/outline-view-doesnt-differentiate-between-overloaded-functions
Fixes
https://linear.app/zed-industries/issue/Z-2205/elixir-syntax-highlighting-not-working-properly-for-doc-attributes-and
This PR improves syntax highlighting and outline view in Elixir. It's
common to overload elixir functions, with many different versions of the
function for different patterns of parameters, so I updated the outline
view to show functions' parameters in Elixir. But if we showed functions
the same way in the *breadcrumbs*, it would take up too much space.
So I added a new capture in languages' `outline` queries called
`@context.extra`, which is included in the outline view, but not in
breadcrumbs.
Release Notes:
- Improved syntax highlighting of doc attributes and special macros in
Elixir
- Updated the outline view in Elixir to display function parameters, to
allow differentiating between function overloads.
2023-06-06 16:34:33 -07:00
Max Brunsfeld
4b9a3c66e6
Show function parameters in elixir outline view
...
Introduce a new capture in the outline query called 'context.extra', which
causes text to appear in the outline, but not in the breadcrumbs.
2023-06-06 16:27:05 -07:00
Max Brunsfeld
7aeaa84657
Fix the order of some patterns in elixir highlight query
2023-06-06 16:06:16 -07:00
Max Brunsfeld
8dc679e74e
Upgrade tree-sitter-elixir
2023-06-06 16:06:16 -07:00
Max Brunsfeld
6737ee1495
Avoid panic when failing to load a language's queries
2023-06-06 16:06:16 -07:00
Piotr Osiewicz
cc63d3d048
chore: add targets to rust-toolchain.toml ( #2581 )
2023-06-07 00:12:47 +02:00
Max Brunsfeld
a9f865d828
Don't apply the 'literal' color to entire markdown code blocks ( #2579 )
...
### Before

### After

Release Notes:
* Improved the syntax highlighting of fenced code blocks in markdown.
2023-06-06 14:54:24 -07:00
Piotr Osiewicz
dfd72770e7
chore: bump MSRV to 1.70, add rust-toolchain ( #2580 )
...
This time I've added a `components` section to rust-toolchain.toml file
to explicitly require a rustfmt component. Fingers crossed.
2023-06-06 23:49:34 +02:00
Max Brunsfeld
3fc2e0754b
Don't apply the 'literal' color to entire markdown code blocks
2023-06-06 14:34:45 -07:00
Max Brunsfeld
bdd3e77e02
Live-reload tree-sitter queries in development ( #2578 )
...
This PR adds live reloading of Tree-sitter queries when running in debug
mode, similar to what we do for the themes. This way, you can change a
highlighting query or an outline query, and immediately see the result
in the app.
Release Notes:
- N/A
2023-06-06 14:30:28 -07:00
Max Brunsfeld
7bfb51ee76
Live-reload tree-sitter queries in development
2023-06-06 14:20:21 -07:00
Piotr Osiewicz
559a58d737
Revert "chore: bump MSRV to 1.70" ( #2577 )
...
Reverts zed-industries/zed#2573
2023-06-06 22:21:34 +02:00
Piotr Osiewicz
c1c91dc2e3
chore: bump MSRV to 1.70 ( #2573 )
...
Add rust-toolchain.toml
Release Notes:
- N/A
2023-06-06 21:50:27 +02:00
Piotr Osiewicz
572c59eec4
chore: Enable full LTO ( #2548 )
...
Per conversation with Antonio, I've suggested enabling full LTO; right
now we use a crate-local ThinLTO, which does not inline function calls
across crates.
| Configuration | Current main (788f97e ) | Thin LTO | Full LTO |
|------------------|------------------------|-----------|-----------|
| Size in bytes | 158806721 | 155868753 | 111115553 |
| % of `main` size | 100% | 98.14% | 69.96% |
| Size in bytes (no debug info) | 129186657 | 127942929 | 108281345 |
2023-06-06 21:50:08 +02:00
Max Brunsfeld
17560cc5b0
Eliminate assets crate ( #2575 )
...
Previously, all static assets were embedded into Zed using a single
`RustEmbed` struct called `Assets`, which was in a crate of its own,
also called `assets`. Many crates depended on this crate. The problem
with this situation was that changing *any* static asset file caused
almost every crate in the codebase to need recompilation (because of
recursive dependencies on `assets`).
Now, most of the assets are embedded only into the top-level `zed`
crate. A few assets (such as settings JSON files and AI prompts) are
needed in lower-level crates such as `settings` and `ai`. For these,
I've created separate `RustEmbed` structs in those specific crates,
which embed those specific sub-folders of `assets`.
The result is that now, when you change a theme file, the only crate
that needs to recompile is `zed`.
Release Notes:
- N/A
2023-06-06 12:00:44 -07:00
Max Brunsfeld
dbbd0558c3
Eliminate assets crate
2023-06-06 11:46:46 -07:00
Joseph Lyons
2003d3dbe4
Update initial_user_settings.json
2023-06-06 14:39:56 -04:00
Antonio Scandurra
7a78e64831
Merge remote-tracking branch 'origin/main' into assistant-2
2023-06-06 19:18:22 +02:00
Antonio Scandurra
16090c35ae
Insert reply after assistant message when hitting cmd-enter
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-06-06 19:15:06 +02:00
Antonio Scandurra
ef7ec265c8
Cycle message roles on click
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-06-06 18:45:08 +02:00
Max Brunsfeld
53906fd3da
Add an application menu item for creating/opening a project-specific settings file ( #2572 )
...
Previously, project-specific settings were not discoverable. This PR
adds a `Zed > Preferences > Local Settings` application menu command
that creates a `.zed/settings.json` at the root of your current
worktree. This command works in both local and remote projects.
Limitations:
* Currently, if you have an empty project open, the command just shows a
notification that there are no folders open.
* The JSON-schema-based autocomplete is the same in local settings files
as in your main settings, even though not all settings can be locally
customized.
Release Notes:
- Added an application menu command - `Zed > Preferences > Local
Settings` for creating a folder-specific settings file.
2023-06-06 09:27:36 -07:00
Antonio Scandurra
ac7178068f
Include message headers in copied assistant text
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-06-06 18:18:04 +02:00
Max Brunsfeld
cfcfc3bf6b
Show notification when attempting to open local settings in a project w/ no folders
2023-06-06 09:03:57 -07:00
Antonio Scandurra
093ce8a9ac
Simplify prompt
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-06-06 17:45:58 +02:00
Nate Butler
7b066df7e6
Tighten up spacing in the project panel ( #2574 )
...
Following https://github.com/zed-industries/zed/pull/2559 the project
panel entries become pretty wide again. This PR tries to mitigate that
and just make some general improvements to visual density in the project
panel.
- Reduces padding around items
- Removes top margin
- Slightly reduces the height of each item
- Fixes an issue where ignored files had the wrong color chevron
Release Notes:
- Improved density of the project panel and tidied up some visual
issues.
2023-06-06 11:31:53 -04:00
Piotr Osiewicz
a0e2e5db7d
project panel/styles: Align child's chevron with parent path ( #2559 )
...
Z-1012
Release notes:
- Adjust indent of files in subdirectories.
2023-06-06 16:55:38 +02:00
Antonio Scandurra
2b1aeb07bc
Show error message when requests to OpenAI fail
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-06 16:53:56 +02:00
Antonio Scandurra
9c59146026
Set assistant editor's title based on the first question/answer pair
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-06-06 15:59:10 +02:00
Antonio Scandurra
69b8267b6b
Show the current model and allow clicking on it to change it
2023-06-06 13:13:44 +02:00
Antonio Scandurra
ada222078c
Insert a user reply when hitting cmd-enter in an assistant message
2023-06-06 13:13:41 +02:00
Antonio Scandurra
f4f060667e
Add assertion to pinpoint how deletion works across excerpts
2023-06-06 12:36:26 +02:00
Antonio Scandurra
337dda8e3a
Only remove excerpts when an edit touches them
2023-06-06 12:27:05 +02:00
Antonio Scandurra
8032324470
Prevent moving across excerpts on Editor::delete
2023-06-06 12:26:53 +02:00
Antonio Scandurra
e46d1549d6
Retain selection's head (as opposed to its end) on insertion
...
This makes a difference when an edit spans two excerpts and the selection
start won't necessarily be the same as the selection end after the edit.
2023-06-06 10:12:15 +02:00
Nathan Sobo
23836eb251
Not working yet: Remove empty messages unless they contain the cursor
...
Problem is, I'm trying to trust the excerpt id of the selection head,
but it's a sentinel value and not the actual excerpt id of the message.
I think we probably need to resolve to offsets instead.
2023-06-05 22:58:08 -06:00
Max Brunsfeld
296a0bf510
Populate created local settings file with an empty JSON object and comments
2023-06-05 18:20:02 -07:00
Max Brunsfeld
cb975f1252
Add Zed > Preferences > Local Settings to application menu
2023-06-05 17:45:42 -07:00
Max Brunsfeld
0949ee84d8
🎨 Move OpenSettings action back to the zed crate
2023-06-05 17:43:05 -07:00
Mikayla Maki
a2d58068a7
Improve test generation and implement status propogation
...
co-authored-by: max <max@zed.dev >
2023-06-05 17:30:12 -07:00
Mikayla Maki
c12bdc894a
Silence not found errors
2023-06-05 15:19:59 -07:00
Max Brunsfeld
398b0f303c
Apply bounds to all windows when using start-local-collaboration script ( #2570 )
...
The `start-local-collaboration` script opens two instances of Zed, each
logged in as a different user, and each one taking up half of the
screen. But previously, when joining a remote project as one of the
collaborators, that newly-opened window would be full screen.
Now, each instance of Zed keeps *all* of its windows on its half of the
screen. This is implemented by respecting the `ZED_WINDOW_{SIZE,BOUNDS}`
env vars, even when joining *remote* projects.
Release Notes:
- N/A
2023-06-05 14:49:39 -07:00
Max Brunsfeld
3d1ba1b363
Apply bounds to all windows when using start-local-collaboration script
2023-06-05 14:36:21 -07:00
Max Brunsfeld
571151173c
Fix copilot state corruption when there are multiple buffers with the same remote id in different projects ( #2569 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1511/thread-main-panicked-at-assertion-failed-left-==-right-left-local-0-1
Previously, when exchanging messages about buffers with a copilot
language server, we identified buffers using their **remote id**. This
caused problems when there were multiple projects open, where one or
more were remote, because buffers' remote ids are only unique within a
given project.
When you have multiple projects open, and one or more of the projects is
remote, it's pretty easy to have two buffers open with the same remote
id. In my testing, when this happened, copilot would stop working in
both buffers. But I believe that depending on the editing patterns that
occur in the two buffers, it could cause the crash reported in the
Linear issue above.
This PR changes our copilot logic to use buffers' local handle ids for
identifying them. This fixed the problems I was able to reproduce when
using copilot in both remote and local projects.
Release Notes:
- Fixed a crash that would sometimes occur when editing buffers after
having collaborated on a remote project.
2023-06-05 14:33:56 -07:00
Max Brunsfeld
12dd91c89c
Use local ids, not remote ids, to identify buffers to copilot
2023-06-05 14:12:19 -07:00
Mikayla Maki
5e4da6433f
Add file and line number information to logs ( #2568 )
...
This PR adds codegen from rustc to track the file and line number of
calls to `log_err()`. I haven't noticed much longer compile times on my
machine, and looking at the
[implementation](https://rustc-dev-guide.rust-lang.org/backend/implicit-caller-location.html )
it essentially adds an extra argument and secret reference pass.
However, this will show a lot more data in our logs on user machines.
Requesting review from @ForLoveOfCats, who usually knows a bunch about
this kind of thing :)
2023-06-05 13:24:07 -07:00
Mikayla Maki
624467ebca
Add file and line number information to logs
2023-06-05 12:53:37 -07:00
Mikayla Maki
9a13a2ba2c
WIP: Add status bubbling to project panel
2023-06-05 12:53:04 -07:00
Joseph T. Lyons
7fbafc8030
Remove code sending zed events to mixpanel ( #2567 )
...
Release Notes:
- N/A
2023-06-05 15:40:27 -04:00
Joseph Lyons
311074e397
Remove code sending zed events to mixpanel
2023-06-05 15:33:17 -04:00
Mikayla Maki
49c5a3fa86
Add postgres migration
2023-06-05 12:17:21 -07:00
Joseph T. Lyons
2190a27dff
Stop sending editor events to mixpanel ( #2566 )
...
Release Notes:
- N/A
2023-06-05 15:15:30 -04:00
Joseph Lyons
70c5489c13
Stop sending editor events to mixpanel
2023-06-05 15:09:47 -04:00
Mikayla Maki
4ac5f7b14e
Add statuses to test integration
2023-06-05 12:06:23 -07:00
Mikayla Maki
e56fcd69b5
Track git status changes with the changed_paths system
2023-06-05 11:50:23 -07:00
Joseph T. Lyons
4f3165692f
Move app version into panic object ( #2565 )
...
Final tweaks to clean up how we structure our panic data
Release Notes:
- N/A
2023-06-05 14:40:28 -04:00
Joseph Lyons
917d8949b7
Move app version into panic object
2023-06-05 14:17:48 -04:00
Julia
6b89243902
Update rust-bindgen dev-dependencies ( #2563 )
...
I did \*something\* Friday afternoon which changed something about my
system SDK to break the `media` crate's bindings generation. Some of the
types and consts were not being generated despite being able to prove
that they exist in the source, such as when running the header through
the preprocessor myself and feeding that through the generator. Updating
my OS, XCode, command line tools, and reinstalling Rust as well as
working from fresh clones of the repo had no effect.
Updating rust-bindgen resolved the issue and downgrading the version
back to the original version caused the issue to reappear. I'm still not
sure what happened to change the SDK but at this point with being able
to build the project again I'm not going to look a gift horse in the
mouth.
Release Notes:
- N/A
2023-06-05 09:21:07 -04:00
Antonio Scandurra
0ed8bbc818
Query rect_for_text_range on focused view instead of root element ( #2564 )
...
This was causing IME input to be drawn in the wrong place when there
were splits or panels in the window.
Release Notes:
- Fixed a bug that was causing IME input to sometimes be rendered in the
wrong position.
2023-06-05 12:11:35 +02:00
Antonio Scandurra
c872f581d1
Query rect_for_text_range on focused view instead of root element
...
This was causing IME input to be drawn in the wrong place when there
were splits or panels in the window.
2023-06-05 12:00:40 +02:00
Antonio Scandurra
bef6932da7
Avoid accidentally taking the api_key when requesting an assist
2023-06-05 11:25:21 +02:00
Julia
5790d6993e
Update rust-bindgen dev-dependencies
2023-06-04 23:34:22 -04:00
Joseph T. Lyons
a89f3ed445
Fix typos ( #2562 )
...
Quite literally just ran `typos --write-changes` from
https://crates.io/crates/typos . Its pretty impressive - wonder if we
should run it on CI.
Release Notes:
- N/A
2023-06-02 22:08:45 -04:00
Joseph Lyons
7c60f636d5
Fix typos
2023-06-02 22:02:19 -04:00
Mikayla Maki
ca077408d7
Fix bug where git statuses would not be initialized on startup
...
move git status queries to be on entry creation
co-authored-by: max <max@zed.dev >
2023-06-02 17:38:39 -07:00
Mikayla Maki
2f97c7a4f1
Remove stale comments
...
Implement status bubbling query with sum tree traversals
co-authored-by: max <max@zed.dev >
2023-06-02 16:41:01 -07:00
Mikayla Maki
e377459948
Remove stateful bubbling
...
co-authored-by: max <max@zed.dev >
2023-06-02 15:07:49 -07:00
Mikayla Maki
99a0e11e70
Abandoning stateful bubbling approach
...
co-authored-by: max <max@zed.dev >
2023-06-02 14:51:40 -07:00
Max Brunsfeld
46d2cbaa4c
Improve panic reports ( #2560 )
...
* Add an `identifying_backtrace` field that only contains symbols in
*our* own codebase, which can be used for better deduplication.
* In the main backtrace, include file and line numbers for all symbols
in our codebase
* Exclude any stack frames within the panic handling/hooking system
itself, so that the top line of the backtrace is where the panic
originated in our codebase.
This should improve our panic deduplication, and also make panic reports
a bit more readable.
example:
```
{
"thread": "main",
"payload": "wtf",
"location_data": {
"file": "crates/zed/src/zed.rs",
"line": 459
},
"backtrace": [
"zed::open_log_file::{{closure}}::{{closure}}::{{closure}}",
" crates/zed/src/zed.rs:459",
"gpui::app::AppContext::spawn_internal::{{closure}}",
" crates/gpui/src/app.rs:2073",
"gpui::executor::any_local_future::{{closure}}",
" crates/gpui/src/executor.rs:1026",
"<core::pin::Pin<P> as core::future::future::Future>::poll",
"<async_task::runnable::spawn_local::Checked<F> as core::future::future::Future>::poll",
"async_task::raw::RawTask<F,T,S>::run",
"async_task::runnable::Runnable::run",
"<gpui::platform::mac::dispatcher::Dispatcher as gpui::platform::Dispatcher>::run_on_main_thread::trampoline",
" crates/gpui/src/platform/mac/dispatcher.rs:40",
"<() as objc::message::MessageArguments>::invoke",
"objc::message::platform::send_unverified",
"objc::message::send_message",
"<gpui::platform::mac::platform::MacForegroundPlatform as gpui::platform::ForegroundPlatform>::run",
" crates/gpui/src/platform/mac/platform.rs:366",
"gpui::app::App::run",
" crates/gpui/src/app.rs:251",
"Zed::main",
" crates/zed/src/main.rs:118",
"core::ops::function::FnOnce::call_once",
"std::sys_common::backtrace::__rust_begin_short_backtrace",
"std::rt::lang_start::{{closure}}",
"core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once",
"std::rt::lang_start"
],
"release_channel": "dev",
"os_name": "macOS",
"os_version": "12.6.1",
"architecture": "aarch64",
"panicked_on": 1685734744050,
"identifying_backtrace": [
"zed::open_log_file::{{closure}}::{{closure}}::{{closure}}",
"gpui::app::AppContext::spawn_internal::{{closure}}",
"gpui::executor::any_local_future::{{closure}}",
"<gpui::platform::mac::dispatcher::Dispatcher as gpui::platform::Dispatcher>::run_on_main_thread::trampoline",
"<gpui::platform::mac::platform::MacForegroundPlatform as gpui::platform::ForegroundPlatform>::run",
"gpui::app::App::run",
"Zed::main"
]
}
```
Release Notes:
N/A
2023-06-02 13:11:57 -07:00
Max Brunsfeld
33c4c32196
Avoid writing spurious nulls to the settings file when updating it programatically ( #2561 )
...
Thanks for catching this @iamnbutler.
2023-06-02 13:11:35 -07:00
Max Brunsfeld
7417835f06
Avoid writing spurious nulls to settings file when updating it programatically
2023-06-02 13:02:17 -07:00
Max Brunsfeld
f6a4706410
Improve panic reports
...
* Add an 'identifying_backtrace' field that only contains symbols in our
codebase, which can be used for better deduplication.
* In the main backtrace, include file and line numbers for all symbols
in our codebase
2023-06-02 12:37:39 -07:00
Joseph T. Lyons
00265c19a0
Add additional panic information to panic events ( #2555 )
...
Adds the following to the panic event
release_channel
os_name
os_version
architecture
Merge first: https://github.com/zed-industries/zed.dev/pull/322
Release Notes:
- N/A
2023-06-02 14:30:16 -04:00
Piotr Osiewicz
345fad3e9d
editor: add select previous command ( #2556 )
...
Added a `select previous` command to complement `select next`.
Release Notes:
- Added "Select previous" editor command, mirroring `Select next`.
Ticket number: Z-366
2023-06-02 17:32:34 +02:00
Antonio Scandurra
f00f16fe37
Show remaining tokens
2023-06-02 17:27:21 +02:00
Sergey Onufrienko
f97999d97f
feat: update themes to use ThemeConfig
2023-06-02 14:11:11 +02:00
Sergey Onufrienko
5fbbc1936f
fix: typescript errors
2023-06-02 14:10:44 +02:00
Sergey Onufrienko
b38f760fcd
feat: add index export
2023-06-02 14:10:19 +02:00
Sergey Onufrienko
d3ed958308
chore: make SyntaxHighlightStyle.color optional
2023-06-02 14:10:02 +02:00
Sergey Onufrienko
6b00db75ad
feat: update and refactor colorScheme
2023-06-02 14:08:35 +02:00
Sergey Onufrienko
56ecfaf2f0
feat: add themeConfig types
2023-06-02 14:07:43 +02:00
Antonio Scandurra
3750e64d9f
Save OpenAI API key in the keychain
2023-06-02 12:15:25 +02:00
Piotr Osiewicz
571d2f4966
Z-1074/search default label ( #2547 )
...
This commit adds a default "Project search" tooltip for empty search
panes. Fixes Linear ticket Z-1074
Release Notes:
- Added default tooltip to empty search panes.
([#1533 ](https://github.com/zed-industries/community/issues/1533 )).
2023-06-02 11:42:40 +02:00
Antonio Scandurra
a81d164ea6
Allow saving the OpenAI API key in the assistant panel
2023-06-02 11:38:02 +02:00
Antonio Scandurra
d0aff65b1c
Allow moving the assistant panel to other docks
2023-06-02 10:55:19 +02:00
Antonio Scandurra
55c8c6d3fb
Allow adding new contexts
2023-06-02 10:29:22 +02:00
Antonio Scandurra
cf934ab696
Fix compile errors
2023-06-02 10:08:06 +02:00
Antonio Scandurra
20e65a533c
Merge remote-tracking branch 'origin/main' into assistant-2
2023-06-02 09:32:11 +02:00
Mikayla Maki
3768851799
WIP: Git statuses
2023-06-01 23:27:49 -07:00
Joseph Lyons
c55aee84d3
Rename field to panicked_on
2023-06-02 01:33:25 -04:00
Joseph Lyons
cc055901e1
Add additional panic information to panic events
2023-06-01 23:34:39 -04:00
Mikayla Maki
5e43dcaab8
WIP: Add stateful status bubbling to worktree
2023-06-01 16:51:34 -07:00
Max Brunsfeld
0bd9d5b1fa
Zoom out all panes when opening a dock ( #2554 )
...
Fixes
https://linear.app/zed-industries/issue/Z-2051/center-zoom-isnt-unset-when-opening-project-panel
Release Notes:
- Fixed a bug where opening the project panel did not reset the zoom
state of a pane.
2023-06-01 15:26:46 -07:00
Max Brunsfeld
585d13d3db
Unzoom all panes when opening a dock
2023-06-01 15:20:15 -07:00
Max Brunsfeld
a55eafa726
Fix ambiguous glob export warnings in rust 1.70 ( #2553 )
...
This fixes a warning that is introduced when upgrading to Rust 1.70.
Release Notes:
- N/A
2023-06-01 14:37:36 -07:00
Max Brunsfeld
e67e6e6f70
Fix ambiguous glob export warnings in rust 1.70
2023-06-01 14:07:59 -07:00
Joseph T. Lyons
6d24a8a763
Add panic events ( #2552 )
...
Adds a time field to support panic events. See
https://github.com/zed-industries/zed.dev/pull/321
Release Notes:
- N/A
2023-06-01 16:47:29 -04:00
Joseph Lyons
0065f5715c
Add panic events
2023-06-01 16:40:54 -04:00
Mikayla Maki
9d6b3744f7
Redraw the terminal on every wakeup ( #2551 )
...
For whatever reason, the optimizations of panes and workspace have
caused the terminal to notify less often then it should. This PR fixes
that oversight.
2023-06-01 10:56:13 -07:00
Mikayla Maki
40c6baf7cb
Redraw the terminal on every wakeup
...
co-authored-by: max <max@zed.dev >
2023-06-01 10:49:31 -07:00
Mikayla Maki
d64dc3960d
Make settings store handle no user settings ( #2550 )
...
This fixes the crash users have been reporting with the theme selector
2023-06-01 10:25:30 -07:00
Mikayla Maki
2390815d67
Make settings store handle no user settings
...
co-authored-by: max <max@zed.dev >
2023-06-01 10:09:04 -07:00
Julia
2ffbeca7dd
Avoid blocking forever on startup if config files do not exist ( #2549 )
...
The files will still get created if the user opens their settings and
saves, otherwise everything will transparently work
Release Notes:
- Fixed an issue where a missing settings file would cause a hang on
startup
([#1590 ](https://github.com/zed-industries/community/issues/1590 )).
2023-06-01 12:13:22 -04:00
Julia
51c82da840
Avoid blocking forever on startup if config files do not exist
...
The files will still get created if the user opens their settings and
saves, otherwise everything will transparently work
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-06-01 12:04:45 -04:00
Kirill Bulatov
d8ce333cf8
Remove wrong assertion
2023-06-01 16:51:29 +03:00
Piotr Osiewicz
01621972c5
Change "Project search" to "Project Search"
2023-06-01 12:31:37 +02:00
Piotr Osiewicz
e1a6dc9077
search: Add a default tooltip for empty searches
...
Z-1074
2023-06-01 11:17:33 +02:00
Max Brunsfeld
788f97ec68
Add support for folder-specific settings ( #2537 )
...
This PR allows you to customize Zed's settings within a particular
folder by creating a `.zed/settings.json` file within that folder.
Todo
* [x] respect folder-specific settings for local projects
* [x] respect folder-specific settings in remote projects
* [x] pass a path when retrieving editor/language settings
* [x] pass a path when retrieving copilot settings
* [ ] update the `Setting` trait to make it clear which types of
settings are locally overridable
Release Notes:
* Added support for folder-specific settings. You can customize Zed's
settings within a particular folder by creating a `.zed` directory and a
`.zed/settings.json` file within that folder.
2023-05-31 16:27:08 -07:00
Max Brunsfeld
ae7606ce21
collab 0.12.5
2023-05-31 15:38:26 -07:00
Max Brunsfeld
0d281c1b89
🎨
2023-05-31 15:13:01 -07:00
Max Brunsfeld
0dd7694ff5
Make language_settings take a language, not a language name
2023-05-31 15:10:30 -07:00
Max Brunsfeld
03a351fb26
Make language settings accessors take an arc dyn file
2023-05-31 14:57:04 -07:00
Max Brunsfeld
38078b93cc
v0.90.x dev
2023-05-31 14:44:48 -07:00
Max Brunsfeld
a2ab7c9eb9
Respect project-specific settings for copilot
2023-05-31 14:42:15 -07:00
Mikayla Maki
6f4fd74f43
Add a dock-keybinding-changed one-time notification ( #2546 )
...
This code is intended to be removed at a later date.
Release Notes:
- N/A
2023-05-31 14:28:12 -07:00
Mikayla Maki
bf2016adf5
Remove version check
2023-05-31 14:23:56 -07:00
Mikayla Maki
27ef0e2b52
De-morgans properly
2023-05-31 14:21:38 -07:00
Mikayla Maki
45b42c512d
fmt
2023-05-31 14:17:27 -07:00
Mikayla Maki
705e36827c
add version check
2023-05-31 14:16:37 -07:00
Mikayla Maki
b875d4ed40
Remove silly panic
2023-05-31 14:10:50 -07:00
Mikayla Maki
ed0b9acb0a
Add panic if version is 0.91
2023-05-31 14:06:36 -07:00
Mikayla Maki
ef80b539d1
Fix notification styling, minimize database reads
2023-05-31 13:56:41 -07:00
Max Brunsfeld
62660f2766
Fix more issues with panels and zoom ( #2545 )
...
Release Notes:
* Fixed the behavior of panel buttons when their panel is open. Show the
key binding for closing the containing dock (preview only).
* Improved the styling of zoomed panels and panes, giving them a
stronger border, and color the zoom button with an "active" style
(preview only).
* Improved the stability of panels' zoom state. Close their dock instead
of resetting their zoom state when dismissing panels to reveal other
items (preview only).
2023-05-31 13:17:12 -07:00
Max Brunsfeld
193474a346
🎨
2023-05-31 13:07:20 -07:00
Max Brunsfeld
c48fed26bd
When revealing items, zoom-out any inactive panes
2023-05-31 13:05:50 -07:00
Mikayla Maki
4717ce1da3
WIP: Move statuses to entries
...
co-authored-by: julia <julia@zed.dev >
2023-05-31 12:55:31 -07:00
Max Brunsfeld
3f6aa94a5f
Use active color for zoom button in a zoomed pane
2023-05-31 12:51:57 -07:00
Max Brunsfeld
893615236d
Only include one border edge for zoomed panels
2023-05-31 12:45:55 -07:00
Nate Butler
1f72f9e18b
Add un-hooked up zoomIcon styles
2023-05-31 12:45:55 -07:00
Nate Butler
a10933c063
Update pane/panel zoom styling
2023-05-31 12:45:55 -07:00
Max Brunsfeld
ac41564a8f
Dismiss zoomed panels by closing their dock, not zooming them out
2023-05-31 12:45:55 -07:00
Mikayla Maki
22e4086658
WIP: Move statuses to be on their associated file entries in worktree
...
co-authored-by: Julia <julia@zed.dev >
2023-05-31 11:03:11 -07:00
Sergii Onufriienko
c6672dbac2
Update theme license logic ( #2541 )
...
Use new theme file structure
```
themes/
[theme_name]
[theme_name]-common.ts
[theme_name]-light.ts
[theme_name]-dark.ts
LICENSE
```
Release Notes:
- N/A
2023-05-31 18:36:13 +01:00
Max Brunsfeld
76927b6d95
Make active panel's button close its dock
2023-05-31 10:29:59 -07:00
Max Brunsfeld
eeba72d775
Bump protocol version
2023-05-31 09:03:45 -07:00
Max Brunsfeld
8f95435548
Replicate project-specific settings when collaborating
2023-05-30 18:08:03 -07:00
Mikayla Maki
c9820fde61
WIP: Add toast when users attempt to use shift-escape for the first time
2023-05-30 17:48:41 -07:00
Mikayla Maki
584e5f7958
Fix usability issues with new panel system. ( #2544 )
...
This PR updates the dock key bindings according to the following model:
There are three bits:
Visible: Opened / closed.
Focus: Panel focused / center focused.
Zoom: Zoomed / Not zoomed.
Each of these variables is 'sticky' in that they won't effect each other
unless they need to. 'Zooming' a panel conceptually merges the visible
and focus bits.
cmd-shift-j/b/r have all been removed.
cmd-j/b/r have been updated to mean 'toggle visibility of a certain
dock', firing them should *always* reveal the panel to you (where you
last left it), or hide it, without moving focus (unless the focused
element is invisible). This means that, when the terminal panel is
zoomed, cmd-j has the same effect as ctrl-`
ctrl-` and cmd-shift-e now toggle a panel's focus, without updating the
zoom state of a panel. Toggling the focus of a zoomed panel causes it to
automatically hide itself, without losing the zoom bit.
When focused or made visible, panels which cannot be zoomed
automatically unzoom everything else so as to preserve user intent of
'show me this panel' and 'everything stays where it is if I don't take
an action'
Release Notes:
- cmd-shift-j/b/r have been removed. (preview only)
- cmd-j/b/r unconditionally show or hide their associated dock,
respecting zoom settings. (preview only)
- ctrl-` and cmd-shift-e now retain zoom state. (preview only)
- Fixed a bug where terminal dock tab would always be in the active
state (preview only)
- Fixed a bug where terminals would not always open in the terminal
panel
- Changed the look of zoomed panels to fill more of the screen (preview
only)
2023-05-30 16:39:06 -07:00
Mikayla Maki
0122cd61c5
fmt
2023-05-30 16:33:42 -07:00
Mikayla Maki
685e8d7007
Seperate pane and panel styling
...
co-authored-by: max <max@zed.dev >
2023-05-30 16:23:16 -07:00
Mikayla Maki
9c707eff27
Rework new terminal actions
2023-05-30 16:10:07 -07:00
Mikayla Maki
e80ab5f096
Fix focus bug with new docks
...
co-authored-by: max <max@zed.dev >
2023-05-30 15:40:30 -07:00
Mikayla Maki
5e4a9abd09
Fix bug in panel button dispatch
2023-05-30 15:17:42 -07:00
Mikayla Maki
5065804388
WIP: iron out bugs in interaction between toggle and toggle focus key bindings
...
co-authored-by: max <max@zed.dev >
2023-05-30 14:55:49 -07:00
Julia
8f0fc918e9
TextStyle::default() ask system for known existing font family (#2542 )
...
Rather than assuming a specific family exists, try a set of specific
names and if they fail, just grab any old font that the system reports
as existing
Closes
https://linear.app/zed-industries/issue/Z-445/thread-main-panicked-at-called-resultunwrap-on-an-err-value-could-not
Release Notes:
* Fixed crash that could happen if system did not have a specific
fallback font
2023-05-30 16:25:07 -04:00
Mikayla Maki
9c9af5ed94
Remove focus side effects from toggle dock commands
...
co-authored-by: max <max@zed.dev >
2023-05-30 12:32:00 -07:00
Joseph Lyons
efcf78cbe9
Update pull_request_template.md
2023-05-30 15:15:20 -04:00
Joseph T. Lyons
e9ce85ebc0
Scrape email from feedback editor ( #2543 )
...
Add release note lines here:
N/A
2023-05-30 15:13:35 -04:00
Joseph Lyons
501f9ab2c6
Scrape email from feedback editor
2023-05-30 15:06:35 -04:00
Mikayla Maki
1a23fe91b4
WIP: Remove focus side effects from toggle dock commands
...
co-authored-by: max <max@zed.dev >
2023-05-30 12:00:15 -07:00
Mikayla Maki
84f98f13c4
Seperate open and zoom bits conceptually for new panels
...
co-authored-by: max <max@zed.dev >
2023-05-30 11:52:14 -07:00
Julia
31516b7863
TextStyle::default() ask system for known existing font family
...
Rather than assuming a specific family exists, try a set of specific
names and if they fail, just grab any old font that the system reports
as existing
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-05-30 14:46:27 -04:00
Sergey Onufrienko
51c7078f47
chore: remove license_text
2023-05-30 18:16:50 +02:00
Sergey Onufrienko
4568f80f2e
feat: read from LICENSE file
2023-05-30 18:12:31 +02:00
Sergey Onufrienko
14efc18eca
refactor: add license file and check it exists
2023-05-30 18:11:54 +02:00
Sergey Onufrienko
05d1dd6b11
refactor: move common to theme folder
2023-05-30 16:53:12 +02:00
Sergey Onufrienko
ac63043c27
chore: move similar themes to one folder
2023-05-30 16:52:28 +02:00
Sergey Onufrienko
0d62e76cd6
refactor: colorSchemes
2023-05-30 15:52:32 +02:00
Antonio Scandurra
69e8a166e4
Start on assistant::QuoteSelection
2023-05-30 15:25:53 +02:00
Antonio Scandurra
dc365472a6
Merge remote-tracking branch 'origin/main' into assistant-2
2023-05-30 15:11:06 +02:00
Antonio Scandurra
1fc9103b61
Remove methods taking &mut Workspace from Pane ( #2540 )
...
This pull request simplifies the `Pane` struct by replacing methods like
`Pane::add_item` that would previously take a `&mut Workspace` with
methods that take a `&mut self`. When access to the workspace is needed,
we now either emit an event from the `Pane` or directly move the method
to the `Workspace` struct.
2023-05-30 15:01:35 +02:00
Antonio Scandurra
bd494037bb
Call ItemHandle::added_to_pane when an item is added to a pane
2023-05-30 14:46:41 +02:00
Sergey Onufrienko
2269c19169
chore: add LICENSE files
2023-05-30 14:06:19 +02:00
Nathan Sobo
8a851ad7f8
Fix annoying system prompt ( #2538 )
...
I was having fun, but it was too much. It makes the assistant too
annoying to be useful.
Release Notes:
Use `N/A` in this section if this item should be skipped in the release
notes.
Add release note lines here:
* Dialed back the system prompt on the assistant.
2023-05-29 22:05:40 -06:00
Nathan Sobo
063613bf4e
Fix annoying system prompt
...
I was having fun, but it was too much. It makes the assistant too annoying to be useful.
2023-05-29 21:47:59 -06:00
Max Brunsfeld
ed0fa2404c
Use settings JSON schema when editing local settings files
2023-05-29 14:31:54 -07:00
Max Brunsfeld
89446c7fd4
Start work on respecting project-specific settings
2023-05-29 14:25:49 -07:00
Antonio Scandurra
88eb2b2163
Move history navigation logic to Workspace
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-05-29 19:47:59 +02:00
Antonio Scandurra
6d3464fd1f
Make Pane::add_item a proper Pane method
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-05-29 19:16:22 +02:00
Antonio Scandurra
890c42a75a
Show time in assistant messages
2023-05-29 16:23:16 +02:00
Kirill Bulatov
edf8e276af
Improves project search panel shortcut handling ( #2536 )
...
* ESC (project_search::ToggleFocus) toggles focus from include/exclude
fields to the editor
* Cmd+Shift+F (workspace::NewSearch) can be triggered from the editor,
and moves focus to the query editor
Release Notes:
* Improved project search panel shortcut handling, allowing more actions
to trigger from panel elements
2023-05-29 17:06:38 +03:00
Kirill Bulatov
d593377e45
Improves project search panel shortcut handling
...
* ESC (project_search::ToggleFocus) toggles focus from
include/exclude fields to the editor
* Cmd+Shift+F (workspace::NewSearch) can be triggered from the editor,
and moves focus to the query editor
2023-05-29 16:58:06 +03:00
Antonio Scandurra
52e8bf2928
Show custom header for assistant messages
2023-05-29 15:57:55 +02:00
Sergey Onufrienko
cf75b090d3
feat: organize themes by folders with LICENSE
2023-05-29 15:45:13 +02:00
Kirill Bulatov
986b02e217
Update LSP to the newest version ( #2535 )
...
Current `lsp-types:0.91.1` crate lacks inlay hints' definitions. Crate's
changelog is not very descriptive, but it appears that `0.92.1` could be
used:
https://github.com/gluon-lang/lsp-types/blob/master/CHANGELOG.md#v0921-2022-03-21
The latest is crate version is `0.94.0` (2023-02-08), the PR updates Zed
to the latest version.
Notable changes:
* workspace symbols may arrive unresolved if the corresponding client
capability is enabled:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#partialResults
Zed has this capability disabled, forcing all symbols to arrive
synchronously (?).
Resolve capabilities are important for inlay hints too, but I've not
found any code in Zed for that outside tests, so I'd love to learn more
and implement the resolution for workspace symbols separately.
* since LSP `3.17` (current), watch file changes can use relative glob
patterns:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_didChangeWatchedFiles
That seemed just a straightforward extra `match` to use the same Ruse
`Glob` to handle the relative path one.
Release Notes:
N/A
2023-05-29 12:49:37 +03:00
Antonio Scandurra
404bebab63
Set markdown as the assistant's buffer languages
2023-05-29 11:34:26 +02:00
Kirill Bulatov
fdad1adaf6
Update LSP to the newest version
2023-05-28 21:55:08 +03:00
Max Brunsfeld
e4530471de
Make worktree UpdatedEntries events fully describe all changes ( #2533 )
...
This PR makes the worktree's change events more useful in a few ways:
* The changes are now described by a cheaply clone-able collection, so
that they can be used in background tasks. Right now, I'm using a simple
Arc slice.
* The `UpdatedEntries` event now captures not only changes due to FS
changes, but also newly-loaded paths that are discovered during the
initial scan.
* The `UpdatedGitRepositories` event now includes repositories whose
work-dir changed but git dir didn't change. A boolean flag is included,
to indicate whether the git content changed.
* The `UpdatedEntries` and `UpdatedGitRepositories` events are now
*used* to compute the worktree's `UpdateWorktree` messages, used to sync
changes to guests. This unifies two closely-related code paths, and
makes the host more efficient when collaborating, because the
`UpdateWorktree` message computation used to require walking the entire
`entries` tree on every FS change.
2023-05-26 15:55:14 -07:00
Max Brunsfeld
1f42bfc1bd
Include repositories with workdir changes in worktree UpdatedGitRepsositories event
2023-05-26 15:47:37 -07:00
Max Brunsfeld
2db57b5139
Adjust diagnostic transformation test to not wait for two buffer notifications
2023-05-26 15:47:37 -07:00
Max Brunsfeld
02b95ef320
Derive worktree update messages from existing change events
2023-05-26 15:47:37 -07:00
Kirill Bulatov
9cfe39f1aa
Display external paths in history ( #2534 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1793/file-finder-external-recent-paths-are-not-rendered-properly
Long paths get trimmed, but same do many of our other elements, such as
type definitions, so I think it's ok for now:

Also, we seem to do a lot of odd diagnostics handling on every external
stdlib file opened:

Other external files also emit similar messages, but not that much.
@\mikayla-maki mentioned, that this was happening before, so can be
fixed separately.
The PR adds path printing to these logs.
Release Notes:
* Fixed external files not being displayed properly in the recently
opened list in the file finder panel
2023-05-27 01:27:24 +03:00
Kirill Bulatov
5fda9e934d
Shorten full paths with ~
2023-05-27 01:21:38 +03:00
Kirill Bulatov
3a3c1c5a5b
Add a test
...
co-authored-by: Mikayla <mikayla@zed.dev >
2023-05-27 01:12:22 +03:00
Nathan Sobo
ffbfbe422b
WIP: Not sure I actually want to rip this out
2023-05-26 16:11:58 -06:00
Nathan Sobo
3904971bd8
Hide assistant gutter
2023-05-26 15:38:03 -06:00
Nathan Sobo
8f6e67f440
Cancel assists on escape
2023-05-26 14:49:27 -06:00
Max Brunsfeld
6628c4df28
Store worktree changes in a sorted arc slice, not a HashMap
...
We don't need to look-up change types by an arbitrary key, but we
do need to iterate it. It would also be useful to be able to
cheaply clone the changes, to use them in a background task.
2023-05-26 09:24:15 -07:00
Max Brunsfeld
59bfd40679
Make stricter assertions about change events in random worktree test
2023-05-26 09:24:15 -07:00
Max Brunsfeld
f890eefdef
Include paths loaded during initial scan in worktree UpdatedEntries event
2023-05-26 09:24:15 -07:00
Nathan Sobo
80080a43e4
Start on an assistant panel based on multi-buffers
...
Each message is represented as a multibuffer excerpt to allow for
fluid editing of the conversation transcript.
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-05-26 10:09:55 -06:00
Kirill Bulatov
cf2bbfc85a
Better display labels for external files
2023-05-26 18:18:32 +03:00
Kirill Bulatov
508533ebb7
Track abs paths in history
2023-05-26 17:31:35 +03:00
Kirill Bulatov
2fdc960704
Properly display labels for currently opened external files
2023-05-26 15:44:44 +03:00
Kirill Bulatov
b75c27da6f
Simplify selected index handling
2023-05-26 14:15:58 +03:00
Kirill Bulatov
364631a155
Add absolute paths to historic elements
2023-05-26 14:03:44 +03:00
Kirill Bulatov
128c19875d
Fix duplicate item creation in project panel ( #2532 )
...
Closes
https://linear.app/zed-industries/issue/Z-1760/creating-a-new-file-with-the-same-name-as-an-existing-file-overwrites
Now every rename/creation editor won't do anything if a duplicate name
is submitted.
Release Notes:
* Fixed a bug when created in project panel items with duplicate names
were overwriting the old files
2023-05-26 10:14:50 +03:00
Kirill Bulatov
5501dd741c
Fix duplicate item creation in project panel
2023-05-26 02:07:25 +03:00
Julia
7900d2a20a
Multibuffer edit perf ( #2531 )
...
This took so much longer than I wanted, so glad to finally be rid of
this
Release Notes:
* Improved performance when editing many git-tracked files in a
multi-buffer at the same time
2023-05-25 15:01:05 -04:00
Julia
5e39ba596e
Clean up final remaining code paths calling old diff update method
2023-05-25 14:41:09 -04:00
Julia
f40c498491
Fix tests
2023-05-25 14:29:28 -04:00
Julia
8d662edb6c
Remove concept of git diff refresh from Item trait
2023-05-25 14:29:28 -04:00
Julia
cede296b04
Project level git diff recalc handling
...
This avoids an issue where in a many-buffer multi-buffer, each modified
buffer could complete its recalc independently, causing a cascade of
repeated notifies
Now all recalcs started at the same time must complete before
A: Starting another recalc pass
B: The master notify occurring
Each buffer can still show its new diff if something else triggers it
to notify earlier, this is desirable and does not have the same negative
effects as the notify cascade as those re-layouts would need to happen
anyway
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-05-25 14:10:27 -04:00
Max Brunsfeld
54421b11f3
wip
2023-05-25 14:10:27 -04:00
Kirill Bulatov
ae3bdd755e
Support OnTypeFormatting LSP request ( #2517 )
...
Supports
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_onTypeFormatting
rust-analyzer uses this feature to add matching brackets semantically,
e.g.
before:

after:

`use_on_type_format` settings entry was added, enabled by default, to
disable the new feature.
Release Notes:
* Support `OnTypeFormatting` LSP protocol feature, allowing
rust-analyzer to add matching brackets
2023-05-25 18:35:47 +03:00
Kirill Bulatov
739d5ca373
Have proper undo for both client and host
2023-05-25 18:29:57 +03:00
Antonio Scandurra
24098c561d
Prevent bottom dock from becoming too large or too small ( #2529 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1834/bottom-dock-can-be-dragged-down-far-enough-such-that-the-tab-bar-is
Release Notes:
- Improved the resize experience for the bottom dock, preventing it from
becoming too large or too small. (preview-only)
2023-05-25 15:44:23 +02:00
Antonio Scandurra
4185a178e7
Prevent bottom dock from becoming too large or too small
2023-05-25 15:29:59 +02:00
Antonio Scandurra
f549ada54f
Restore the ability to search terminals in the terminal panel ( #2528 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1812/find-in-terminal-panel-is-broken

This also removes navigation controls from the terminal panel, given
that terminals don't make use of that feature anyway. When the toolbar
is empty, we'll avoid showing it altogether.

Release Notes:
- Fixed a regression that was preventing the terminal panel from being
searched.
2023-05-25 15:28:32 +02:00
Antonio Scandurra
aa8c0475b1
Don't show navigation controls for terminal panel
2023-05-25 15:15:20 +02:00
Kirill Bulatov
e2ff829f98
Use Transaction instead of ProjectTransaction
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-05-25 16:12:14 +03:00
Antonio Scandurra
414b97adce
Add search bar to terminal panel
2023-05-25 14:46:10 +02:00
Antonio Scandurra
dba7ec4a35
Prevent pane from being erroneously zoomed when toggling the outline pane ( #2527 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1818/toggling-the-outline-pane-causes-the-pane-to-zoom
Add release note lines here:
- Fixed a bug that could cause panes to be erroneously zoomed when
toggling modals. (preview-only)
2023-05-25 14:10:08 +02:00
Antonio Scandurra
c2f3ac24a4
Prevent zoom from being restored when focusing a modal
2023-05-25 12:11:11 +02:00
Antonio Scandurra
7e1ea8f274
Remove stray dbg!
2023-05-25 12:04:41 +02:00
Kirill Bulatov
aa58d0fd77
Do not send edits over the wire
2023-05-25 12:55:44 +03:00
Kirill Bulatov
f812151840
Add integration tests
2023-05-25 09:45:50 +03:00
Kirill Bulatov
eca6d2b597
Process remote format typing also
2023-05-25 09:45:50 +03:00
Kirill Bulatov
58a56bdda2
Always use server formatting settings
2023-05-25 09:45:50 +03:00
Kirill Bulatov
d1f4b60fa1
Allow to disable the new feature
2023-05-25 09:45:50 +03:00
Kirill Bulatov
b9dabb165e
Use formatting options
2023-05-25 09:45:50 +03:00
Kirill Bulatov
3327e8a6dd
Support remote sessions
2023-05-25 09:45:50 +03:00
Kirill Bulatov
f6d7b3d2e8
Send and handle OnTypeFormatting LSP request
2023-05-25 09:45:50 +03:00
Nate Butler
793486b2e8
Update Diff Modified Color ( #2526 )
...
For some reason the yellow I used for the modified color in light themes
was really light
.
Release Notes:
* Improved the contrast of diff modified color in the editor in light
themes.
2023-05-24 23:50:37 -04:00
Joseph Lyons
3f79b0c7cc
Don't hardcode dates into script
2023-05-24 17:39:02 -04:00
Joseph Lyons
cc3186cb4a
Add script to print all prs merged between a previous date and now
2023-05-24 16:58:56 -04:00
Nathan Sobo
0b7d095c0a
Introduce the ability to talk to GPT-4 within buffers on preview and dev ( #2524 )
...
This adds basic ability to interact with OpenAI inside a buffer.
Release Notes:
* If`OPENAI_API_KEY` is defined in your environment, you can now run the
`ai: assist` command to pass the text of your current buffer to GPT-4.
If you're editing a file with a `.zmd` extension, you can also invoke
the model with `cmd-enter.` (preview-only)
2023-05-24 12:00:43 -06:00
Joseph Lyons
37d35db3d7
v0.89.x dev
2023-05-24 13:22:00 -04:00
Nathan Sobo
26051de160
Clean up
2023-05-24 11:08:00 -06:00
Max Brunsfeld
a1a66b8da4
Make toggle dock actions appear in the command palette ( #2525 )
...
This makes the `Toggle{Left,Right,Bottom}Dock` actions deserializable
from empty JSON, so that they can be constructed for the command
palette. It also fixes a bug in GPUI's `available_actions` method, in
which we'd include key bindings for actions of the same type but
different values.
Note that, for now, the command palette will perform the *focusing*
version of the actions. I'm not totally sure this is the right behavior,
but it seems more useful to me.
Release Notes:
N/A
2023-05-24 10:07:34 -07:00
Nathan Sobo
747322a02d
Merge remote-tracking branch 'origin/main' into zmd
2023-05-24 11:04:07 -06:00
Max Brunsfeld
66b3be8687
Make toggle dock actions appear in the command palette
2023-05-24 09:58:41 -07:00
Nathan Sobo
d495c1b804
Only run AI agent on dev and preview
2023-05-24 10:58:33 -06:00
Antonio Scandurra
35f9996a4f
WIP
2023-05-24 18:45:47 +02:00
Nathan Sobo
ba79a8ba94
WIP
2023-05-24 10:26:14 -06:00
Nathan Sobo
50e1e17d09
WIP
2023-05-24 09:53:08 -06:00
Nathan Sobo
051c7566cc
WIP
2023-05-24 09:38:37 -06:00
Nathan Sobo
8abaf66602
WIP
2023-05-24 09:21:50 -06:00
Nathan Sobo
6368ade1da
WIP
2023-05-24 09:12:16 -06:00
Antonio Scandurra
8832248bb9
Polish panel experience ( #2523 )
...
In this pull request we improved key bindings (as described below) and
added tooltips.
Add these release notes to the panels release notes:
- The left, right and bottom dock can be toggled and focused at the same
time respectively via `cmd-b`, `cmd-r` and `cmd-j`. Holding `shift` will
toggle them without changing the focus.
2023-05-24 16:23:24 +02:00
Antonio Scandurra
f67a22828b
Show keystroke in panel tooltips
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-05-24 16:13:58 +02:00
Antonio Scandurra
0cf1632d39
Only focus new terminal if the panel contains focus
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-05-24 16:04:02 +02:00
Antonio Scandurra
50cfe5eec3
Use cmd-b/cmd-r/cmd-j to toggle left/right/bottom dock and focus when opening
...
Also, bind the same keys with shift to toggle the dock without focusing.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-05-24 15:59:06 +02:00
Antonio Scandurra
7534c4e670
Fix opening excerpt when the cursor is at the end of a multi-buffer ( #2522 )
...
Fixes
https://linear.app/zed-industries/issue/Z-987/option-enter-doesnt-open-buffer-from-multibuffer-if-on-the-last-line
This was caused by seeking with a right bias, which in the case of the
last excerpt in the buffer would seek past the end of the buffer. This
commit changes the behavior to move the cursor back to the previous
excerpt if we overshoot, to ensure we always land on an excerpt.
Release Notes:
- Fixed a bug that prevented opening excerpts when the cursor was at the
end of a multi-buffer.
2023-05-24 15:08:18 +02:00
Antonio Scandurra
2a8e0824a6
Fix opening excerpt when the cursor is at the end of a multi-buffer
...
This was caused by seeking with a right bias, which in the case of the
last excerpt in the buffer would seek past the end of the buffer. This
commit changes the behavior to move the cursor back to the previous excerpt
if we overshoot, to ensure we always land on an excerpt.
2023-05-24 15:02:57 +02:00
Antonio Scandurra
8f49552121
Show maximize/minimize icon for panes and terminal panel ( #2521 )
...
Closes
https://linear.app/zed-industries/issue/Z-1790/show-zoomunzoom-icons-for-panes-and-terminal-panel

2023-05-24 11:44:39 +02:00
Antonio Scandurra
e5fd953b4f
Provide tooltips for pane buttons
2023-05-24 11:18:30 +02:00
Antonio Scandurra
1a353ad25d
Show maximize/minimize icon for panes and terminal panel
2023-05-24 11:00:12 +02:00
Antonio Scandurra
9575ffc1e3
Prevent empty panes from being zoomed ( #2520 )
...
Closes
https://linear.app/zed-industries/issue/Z-1789/empty-panes-should-not-be-zoomable
2023-05-24 10:51:52 +02:00
Antonio Scandurra
168ff99927
Prevent empty panes from being zoomed
2023-05-24 10:34:56 +02:00
Joseph T. Lyons
e463e3b2e8
Update terminal panel tooltip ( #2519 )
...
The actions in Zed now call this the Terminal Panel and the crate is
called that as well, so I think the tooltip should be updated to use
that same name.
Release Notes:
N/A
2023-05-23 22:33:08 -04:00
Joseph Lyons
e6857866d4
Update terminal panel tooltip
2023-05-23 22:23:38 -04:00
Nathan Sobo
637ed79603
WIP
2023-05-23 18:16:49 -06:00
Nathan Sobo
65fc50745b
WIP
2023-05-23 18:04:33 -06:00
Nathan Sobo
d934da1905
WIP
2023-05-23 15:25:34 -06:00
Joseph T. Lyons
ba7659fa77
add toggle right and bottom dock actions ( #2518 )
...
Release Notes:
N/A
2023-05-23 13:59:45 -04:00
Joseph Lyons
2457c55fe7
add toggle right and bottom dock actions
2023-05-23 13:53:56 -04:00
Joseph T. Lyons
aac83ceea7
Add architecture to clickhouse event request body ( #2514 )
...
See title
Release Notes:
N/A
2023-05-23 11:11:17 -04:00
Nathan Sobo
7be41e19f7
WIP
2023-05-23 08:52:21 -06:00
Antonio Scandurra
ad866c5b21
Update LiveKit client SDK to 1.0.12 ( #2516 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1756/screen-sharing-is-slow-and-sometimes-doesnt-work-at-all
Release Notes:
* Fixed some cases where screen-sharing would have low bitrate or
completely fail to start.
2023-05-23 16:19:12 +02:00
Antonio Scandurra
774530dd05
Update LiveKit client SDK to 1.0.12
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-05-23 15:32:55 +02:00
Nathan Sobo
073967c80b
WIP
2023-05-23 01:56:28 -06:00
Nathan Sobo
5362e7d346
WIP
2023-05-23 01:52:37 -06:00
Nathan Sobo
394e87d17c
WIP
2023-05-23 01:23:01 -06:00
Antonio Scandurra
dcc4dd7eb8
Allow multiple docks to be visible at once and only let them contain panels ( #2450 )
...
Closes
https://linear.app/zed-industries/issue/Z-1188/allow-docks-to-be-visible-on-left-bottom-right
To prepare the way for the AI assistant, we want to revamp the way docks
and panels work. In this PR, we replace the dock as it currently exists
with 3 independent docks at the left, bottom, and right edge of the
workspace. To replace the "expanded" dock, we will introduce a zoom
feature that works on any pane and some panels. When showing a dock with
an active panel that is zoomed, it will automatically appear zoomed.
This replicates the expanded dock experience. If you unzoom, the panel
will still be visible.
### Panels only
We want to simplify these docks to only allow them to contain *panels*.
By doing this, we don't need to give each dock a tab bar, minimizing
clutter in the workspace. Each panel will remember its size, and the
dock will adjust to that size when the panel is toggled. This will allow
each panel to take up the amount of space that makes sense for its use
case.
There will be 3 kinds of panels:
* Project panel: This currently lives in the left "sidebar", which this
PR renames to the left dock. Users will be able to left click the icon
and switch the project panel to the right dock.
* Terminal panel: This is the primary user of the previous dock. Now all
terminals will live in a terminal panel, which can be docked at the
left, bottom, or right. This dock will contain tabs, but only for
terminals. Terminals will still be able to be dragged into the
workspace, but by default, the first new terminal will live in the
terminal panel which lives in one of the 3 docks.
* Feedback: Instead of opening a pane, let's explore making this a panel
instead.
### Status bar icons
A nice feature of this change is that it simplifies our status bar by
eliminating the dock button. We will only show icons for specific
panels. Panel in the left dock will appear at the left side of the
status bar. Panels in the right dock on the far right, panels in the
bottom will appear on the right, to the immediate left of the buttons
for right panels. Left clicking any panel button will allow it to be
redocked to any valid location for that panel.
### Paving the way for the AI assistant
I'm envisioning the assistant living in the far right panel by default.
So in the stock config, you'll have the project panel on the left,
terminal on the bottom, assistant on the right, and code in the middle.
Let's fucking go!
2023-05-23 09:09:43 +02:00
Antonio Scandurra
19b817e48a
Improve styling of bottom and right docks
2023-05-23 09:02:45 +02:00
Antonio Scandurra
208ff2fba7
Merge remote-tracking branch 'origin/main' into panels
2023-05-23 08:24:28 +02:00
Nathan Sobo
0de5a444d3
WIP
2023-05-23 00:22:21 -06:00
Nathan Sobo
234dbc3ca9
WIP
2023-05-23 00:16:44 -06:00
Nathan Sobo
c4d88bc529
WIP
2023-05-22 23:43:02 -06:00
Nathan Sobo
30de64845f
WIP
2023-05-22 23:11:27 -06:00
Mikayla Maki
a5b5de5651
Add initial project panel settings ( #2515 )
...
This PR adds project panel settings for disabling git status.
Release Notes:
- Adds `project_panel: { git_status: bool }` to the settings, for
controlling whether git status information appears.
2023-05-22 20:43:24 -07:00
Mikayla Maki
a37b1b6a45
Add other setting init
2023-05-22 20:38:30 -07:00
Mikayla Maki
b19a712799
Add init_settings to tests
2023-05-22 20:33:18 -07:00
Mikayla Maki
da96802bf0
fmt
2023-05-22 20:25:27 -07:00
Mikayla Maki
7be8dead07
Add initial project panel settings
2023-05-22 20:23:07 -07:00
Nathan Sobo
7e6cccfa3d
WIP: Stream in completions
...
Drop dependency on tokio introduced by async-openai and do it ourselves.
The approach I'm taking of replacing instead of appending is causing issues. Need to just append.
2023-05-22 20:28:22 -06:00
Joseph Lyons
049b72e3ac
Add architecture to clickhouse event request body
2023-05-22 21:45:58 -04:00
Mikayla Maki
54c04a6618
Fix race condition in diff base initializaiton ( #2513 )
...
fixes
https://linear.app/zed-industries/issue/Z-1657/diff-markers-in-gutter-do-not-show-up-until-after-first-save
Release Notes:
- Fixes a race condition on buffer initialization that would cause git
diffs to not load.
2023-05-22 18:43:59 -07:00
Mikayla Maki
9307719a4b
Add run until parked for test
2023-05-22 18:40:12 -07:00
Mikayla Maki
51d94f532b
Load diff base for buffers that are opening but not yet opened when repositories are discovered
2023-05-22 18:26:33 -07:00
Mikayla Maki
fc82489128
Update scrollbar styling
2023-05-22 16:23:36 -07:00
Mikayla Maki
1b5be04f76
Fixed contrast in project panel and scrollbar ( #2512 )
...
Redo of https://github.com/zed-industries/zed/pull/2504
This makes the different git locations individually style-able
Release Notes:
- Improve git contrast (preview only)
2023-05-22 15:59:02 -07:00
Mikayla Maki
e4454f1e7f
fmt
2023-05-22 15:53:29 -07:00
Mikayla Maki
5c31c84c90
Fixed contrast in project panel and scrollbar
...
co-authored-by: nate <nate@zed.dev >
2023-05-22 15:51:31 -07:00
Mikayla Maki
fb2f17e5c9
Revert "Touch up git in project panel and scroll bar styling" ( #2511 )
...
Reverts zed-industries/zed#2504 , due to accidentally pulling in main
2023-05-22 15:36:15 -07:00
Mikayla Maki
2d1c4a1971
Revert "Touch up git in project panel and scroll bar styling"
2023-05-22 15:31:14 -07:00
Mikayla Maki
dcf4791182
WIP: Touch up git in project panel and scroll bar styling ( #2504 )
...
This makes the different git locations individually style-able
Release Notes:
* Improve git contrast (preview only)
2023-05-22 15:11:10 -07:00
Mikayla Maki
9bec74f1d4
fmt
2023-05-22 15:04:51 -07:00
Mikayla Maki
9a47415cb5
Merge branch 'main' into git-project-panel-and-scrollbar-styling
2023-05-22 15:02:28 -07:00
Mikayla Maki
5dfb0e3691
remove border from thumb
2023-05-22 14:56:55 -07:00
Nate Butler
11eb9b17c9
Update project panel & scroll bar git colors
2023-05-22 17:47:52 -04:00
Mikayla Maki
4c9d24da7c
Only fire update diff base when the dot repo is scanned ( #2510 )
...
This PR fixes a bug in the firing of the UpdatedRepositories event which
caused it to flood collaboration with new messages on every file save.
Release Notes:
* Fixed a bug in repository detection that caused it to fire
over-eagerly (preview only)
2023-05-22 14:11:19 -07:00
Mikayla Maki
96224fa7e8
Only fire update diff base when the dot repo is scanned
2023-05-22 13:57:07 -07:00
Max Brunsfeld
0e332b5f94
Clear old diagnostics when restarting a language server ( #2509 )
...
Previously, restarting a language server did not clear out the
diagnostics that were published by that server. Those diagnostics would
stick around forever.
Release Notes:
* Fixed a bug where restarting a language server would sometimes leave
buffers with stale diagnostics associated with that server.
2023-05-22 13:06:32 -07:00
Max Brunsfeld
7689cdf3f9
Clear old diagnostics when restarting a language server
2023-05-22 12:53:22 -07:00
Mikayla Maki
1d07cff765
Adjust scrollbar settings to be expandable ( #2507 )
...
Note that this PR cannot be cherrypicked into preview, as it relies on
the new settings infrastructure.
Switches settings from `show_scrollbars: "auto"` to `scrollbar: {show:
"auto", git_diffs: true}`.
fixes
https://linear.app/zed-industries/issue/Z-1650/scroll-bar-feature-settings
Release Notes:
- Changed scrollbar settings from `show_scrollbars: "auto"` to
`scrollbar: {show: "auto", git_diffs: true}`. (preview only)
2023-05-22 12:51:21 -07:00
Mikayla Maki
dcb987ba9d
Diagnostics pane was not focusable with the mouse ( #2506 )
...
fixes
https://linear.app/zed-industries/issue/Z-1432/cant-cmd-w-an-empty-diagnostics-in-a-split-pane
Release Notes:
* Fixed a bug where the diagnostics pane could not be focused or closed
in certain circumstances.
2023-05-22 12:44:39 -07:00
Mikayla Maki
cfdf9198da
Switch back to
2023-05-22 12:16:47 -07:00
Mikayla Maki
687ccd4c6f
fmt
2023-05-22 12:13:23 -07:00
Mikayla Maki
366f13bb5c
Adjust scrollbar settings to be expandable
2023-05-22 12:12:56 -07:00
Joseph Lyons
49566e5677
Update pull_request_template.md
2023-05-22 15:00:57 -04:00
Joseph Lyons
9c32b774aa
Add example of changelog line in PR template
2023-05-22 14:53:07 -04:00
Mikayla Maki
bafc1d922e
fmt
2023-05-22 11:46:52 -07:00
Mikayla Maki
e59c8e9d61
Fix diagnostic pane not being closeable
2023-05-22 11:44:23 -07:00
Max Brunsfeld
e129ed2d91
Fix spurious setting error log messages ( #2498 )
...
Fixes a bug introduced in
https://github.com/zed-industries/zed/pull/2448 , where error messages
would be logged if the user config didn't specify certain fields like
`journal` or `telemetry`.
2023-05-22 11:44:21 -07:00
Joseph Lyons
04355215b2
Indent all release note lines for each PR
2023-05-22 14:44:05 -04:00
Julia
a69144911f
Add paragraph based vertical movements ( #2502 )
...
Very selfish patch I worked on yesterday, I kept saying I wanted these
and finally decided to just add them. Feedback on the keybindings
welcome
Release Notes:
* Added `MoveToStartOfParagraph` and `MoveToEndOfParagraph` movements
for paragraph based vertical navigation
2023-05-22 14:31:34 -04:00
Mikayla Maki
85266131cf
Fix perf problem with scrollbars in large multibuffers ( #2505 )
...
Remove scrollbars from multibuffers
Release Notes:
* Removes git scrollbar highlights from multibuffers (preview only)
2023-05-22 11:11:27 -07:00
Mikayla Maki
6f4b6eec5b
Diagnostics pane was not focusable with the mouse
2023-05-22 11:10:13 -07:00
Mikayla Maki
6264b24788
fmt
2023-05-22 11:04:36 -07:00
Mikayla Maki
8669dcdc81
Make scrollbar content detection cheaper
...
Remove scrollbars from multibuffers
co-authored-by: max <max@zed.dev >
2023-05-22 10:55:44 -07:00
Antonio Scandurra
f22067b236
Remove unused imports
2023-05-22 19:38:57 +02:00
Antonio Scandurra
33f6c56b14
Fix more warnings
2023-05-22 19:36:01 +02:00
Antonio Scandurra
6f39d49b18
Fix warnings
2023-05-22 19:33:11 +02:00
Antonio Scandurra
048498e39b
Test zooming panels
2023-05-22 19:30:31 +02:00
Mikayla Maki
ef81813d56
Wire in conflict styling
2023-05-22 10:10:47 -07:00
Mikayla Maki
a355b4c135
Add conflict styles to project panel
2023-05-22 10:09:55 -07:00
Mikayla Maki
af73c1af06
Add seperate scrollbar styling
2023-05-22 10:03:02 -07:00
Antonio Scandurra
3ca95678f1
Avoid leaking docks when adding panels
2023-05-22 18:57:14 +02:00
Kirill Bulatov
9e46b17149
Do not refocus project search query on ESC press ( #2494 )
...
Closes
https://linear.app/zed-industries/issue/Z-1471/escape-should-not-move-focus-to-project-search
Makes ESC more predictable as a shortcut that cancels/roll backs the
state in project search panel.
Release Notes:
* Fixes ESC making focus to jump in project search panel
2023-05-22 19:56:10 +03:00
Mikayla Maki
2200a22c07
Wire project panel themes into rust
2023-05-22 09:55:59 -07:00
Antonio Scandurra
75a0742c90
Uncomment persistence test
2023-05-22 18:32:28 +02:00
Antonio Scandurra
5b7e852903
Await closing of items in tests
2023-05-22 18:28:30 +02:00
Antonio Scandurra
deaf60005c
Fix more tests
2023-05-22 18:21:12 +02:00
Nate Butler
b80cb73745
Add git to project panel in theme, use different values for dark and light
2023-05-22 12:09:54 -04:00
Antonio Scandurra
4aa2858b2b
Transfer focus to root view only if previously-focused view was dropped
2023-05-22 18:05:08 +02:00
Max Brunsfeld
21ada545b0
Remove assertions about behavior on invalid settings file
2023-05-22 08:48:37 -07:00
Julia
44903bc193
Add test for paragraph vertical movements
2023-05-22 11:48:07 -04:00
Antonio Scandurra
185a624b99
Fix some project panel tests
2023-05-22 16:18:53 +02:00
Nate Butler
48dcacc7ce
Sort & add some docs
2023-05-22 10:03:10 -04:00
Antonio Scandurra
10e947cb5f
Persist project and terminal panel sizes
2023-05-22 15:55:44 +02:00
Julia
7190840081
Add paragraph based vertical movements
2023-05-22 09:12:36 -04:00
Antonio Scandurra
146809eef0
Merge branch 'main' into panels
2023-05-22 14:10:17 +02:00
Antonio Scandurra
2098ac2c77
Fix formatting for keymap.json
2023-05-22 10:41:48 +02:00
Joseph Lyons
cb1b64e51b
Fix up formatting for get preview channel changes script
2023-05-22 00:02:19 -04:00
Joseph T. Lyons
f2a74017df
Fix get preview channel changes script ( #2501 )
...
Fixes the text we match on to get PR commits and also prints the release
notes of each PR
Release Notes:
* Skip
2023-05-21 23:47:07 -04:00
Joseph Lyons
c701901c7b
Fix get preview channel changes script
2023-05-21 23:40:07 -04:00
Nathan Sobo
d5cf595761
Enable "test-support" feature on editor dependencies for tests ( #2499 )
...
Enable the `"test-support"` feature whenever we depend on the `editor`
crate in tests.
If we don't do this, we end up depending on `livekit_client` without
enabling `"test-support"`, and this causes us to link against
`WebRTC.framework` in its build script, which causes a dynamic linker
error when starting the tests.
Fixes
https://linear.app/zed-industries/issue/Z-1646/cant-run-package-tests-for-activity-monitor-and-auto-update
Release Notes:
* No notes
2023-05-20 10:19:59 -06:00
Nathan Sobo
986eafd84e
Enable test-support on editor in tests
2023-05-20 09:54:38 -06:00
Nathan Sobo
912fd23006
Parse markdown into an OpenAI chat completion request
2023-05-20 09:43:12 -06:00
Mikayla Maki
35a9b90528
Fix bugs in git implementation ( #2495 )
...
fixes
https://linear.app/zed-industries/issue/Z-1593/clean-up-git-integration
- Fixes calculation of git offsets in the scrollbar:
fixes
https://linear.app/zed-industries/issue/Z-1608/fix-scrollbar-diffs-sliding-out-of-sync-with-gutter-diffs-in
fixes
https://linear.app/zed-industries/issue/Z-1629/project-search-panel-has-git-marks-on-the-scrollbar-misaligned
fixes
https://linear.app/zed-industries/issue/Z-1625/soft-wrap-affects-diff-locations-in-scrollbar
- Improves the performance of scrollbar hunks:
fixes
https://linear.app/zed-industries/issue/Z-1640/double-check-performance-of-scrollbar-hunks
- Fixes a long standing bug with how git gutters interact with soft
wraps:
fixes
https://linear.app/zed-industries/issue/Z-1442/make-hunks-grow-to-the-end-of-softwraps-when-ending-on-a-softwrapped
- Allows work directories to be renamed
fixes
https://linear.app/zed-industries/issue/Z-1577/fix-stale-git-repositories-when-directory-is-renamed
Release Notes:
* Fix the offsets of the git diffs in the scrollbar when there are
folds, wraps, or excerpts (preview only)
* Allow the work directory of a repository to be renamed (preview only)
* Extend git gutter to cover the entirety of a wrapped line
(https://github.com/zed-industries/community/issues/937 )
2023-05-19 18:15:11 -07:00
Mikayla Maki
bbb68c523c
Refactored apart the forward and the backwards iterator for diff hunks
2023-05-19 18:09:47 -07:00
Max Brunsfeld
e32233c826
Fix spurious setting error logs on non-existent setting keys
2023-05-19 17:15:05 -07:00
Mikayla Maki
43e301eeef
refine batched anchor conversions
...
co-authored-by: max <max@zed.dev >
2023-05-19 16:52:57 -07:00
Max Brunsfeld
fb11c3e4bf
Remove stray prints
2023-05-19 16:52:30 -07:00
Mikayla Maki
1474429271
fmt
2023-05-19 16:32:07 -07:00
Mikayla Maki
c795c9b844
Rearrange git tests in worktree
...
Add support for renaming work directories
2023-05-19 16:30:00 -07:00
Mikayla Maki
623a177fe6
Fix bug where git diff hunks would not extend through a soft wrap
2023-05-19 16:23:45 -07:00
Mikayla Maki
560160b100
Batch anchor conversions in git hunk iterator
2023-05-19 16:23:45 -07:00
Mikayla Maki
2a41a32aac
Calculate y offsets correctly
2023-05-19 16:23:45 -07:00
Max Brunsfeld
d7d29472c2
Remove expensive-to-clone fields from worktree's LocalSnapshot ( #2497 )
...
This fixes performance problems that @nathansobo and I have seen in some
cases, when a large number of files changed on disk. A lot of time was
being spent in `worktree::LocalSnapshot::clone`. I think this may have
been because of needing to clone the `removed_entry_ids` map. This
structure is only really used when *mutating* the `LocalSnapshot` in the
background scanner, so I moved it off of the snapshots.
2023-05-19 16:20:19 -07:00
Mikayla Maki
06a89d9104
Add guards to other pane index removals ( #2496 )
...
These should be impossible for users to reach, but why leave it to
chance?
Release Notes:
* N/A
2023-05-19 15:21:00 -07:00
Max Brunsfeld
7ae642b9b8
Avoid storing removed_entry_ids on the LocalSnapshot
2023-05-19 15:16:04 -07:00
Mikayla Maki
c193b0b8fc
Add guards to other pane index removals
2023-05-19 15:10:44 -07:00
Max Brunsfeld
32c7157906
🎨 Make worktree repositories more consistent
2023-05-19 15:04:37 -07:00
Max Brunsfeld
6359333749
Don't store next_entry_id on worktree's local snapshot
2023-05-19 13:49:24 -07:00
Kirill Bulatov
065f71d671
Do not refocus project search query on ESC press
2023-05-19 22:06:47 +03:00
Kirill Bulatov
7d1833b759
When the file is deleted via project panel, close it in editors ( #2490 )
...
Deals with https://github.com/zed-industries/community/issues/179 by
sending a message about it, to asynchronously apply on all workspaces.
Release Notes:
* Fixes a bug when files, deleted in the project panel were left open in
the editor
2023-05-19 21:51:37 +03:00
Max Brunsfeld
844b8d9e1e
Remove unnescessary double lookup in repo for ( #2492 )
...
Release Notes:
* Optimize repository queries (preview only)
2023-05-19 11:47:05 -07:00
Kirill Bulatov
2c8fffc4f8
Use better name for the method that closes deleted buffers
...
co-authored-by: Max <max@zed.dev >
2023-05-19 21:47:00 +03:00
Max Brunsfeld
01a3e49946
Optimize retrieving repos for entries when rendering the project panel ( #2493 )
...
This fixes slowness in rendering the project panel due to retrieving the
repository for a given entry.
Release Notes:
* Fixed a lag that would occur when lots of files changed on disk while
the project panel was open (preview only).
2023-05-19 11:46:32 -07:00
Mikayla Maki
9f157bdb67
Remove unescessary methods
2023-05-19 11:30:10 -07:00
Max Brunsfeld
729a93db6b
Optimize retrieving repos for entries when rendering the project panel
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-05-19 11:29:02 -07:00
Mikayla Maki
6792788216
Remove unnescessary double lookup
2023-05-19 11:08:58 -07:00
Antonio Scandurra
5a8fb18c20
Show workspace only after initializing it
2023-05-19 19:35:00 +02:00
Antonio Scandurra
5ff49bde31
Serialize and deserialize TerminalPanel
2023-05-19 19:26:32 +02:00
Max Brunsfeld
d480555ec9
Fix performance problems in reporting changed FS paths to language servers ( #2491 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1611/main-thread-hangs-while-sending-filesystem-change-events-to-lsp
Release Notes:
* Fixed a lag that would sometime occur when large numbers of files
changed on disk, due to reporting the changed files to language servers.
2023-05-19 09:42:55 -07:00
Max Brunsfeld
847d1e73a3
Replace remaining usages of glob crate with globset
2023-05-19 09:36:46 -07:00
Max Brunsfeld
459cc9c959
Optimize matching of multiple file-watch globs using the globset crate
2023-05-19 09:13:34 -07:00
Kirill Bulatov
583b15badc
When the file is deleted via project panel, close it in editors
2023-05-19 18:52:30 +03:00
Nate Butler
32849d1e43
Add initial internal docs from Meta
2023-05-19 11:02:18 -04:00
Antonio Scandurra
e49281699c
Add new terminal when the terminal panel is activated, and not on focus
2023-05-19 16:07:47 +02:00
Antonio Scandurra
924ec961ff
Toggle project panel when opening new workspace in a dock-agnostic way
2023-05-19 15:27:18 +02:00
Antonio Scandurra
3d6b728364
Activate the correct panel when deserializing workspace
2023-05-19 14:18:11 +02:00
Kirill Bulatov
3984cc6d39
Properly handle WorktreeId
2023-05-19 12:37:36 +03:00
Max Brunsfeld
4bda5c4d69
Optimize LSP watched file reporting in 2 simple ways
...
* Convert globs to relative paths in advance. This avoids needing to convert
every changed path to an absolute path before performing glob matching.
* Avoid duplicate reporting for language servers with multiple worktrees.
2023-05-18 17:08:51 -07:00
Max Brunsfeld
34b0d6200f
collab 0.12.4
2023-05-18 14:58:57 -07:00
Max Brunsfeld
ffe35d171c
Avoid unnecessary code action requests when applying leader updates t… ( #2489 )
...
We noticed a huge amount of code actions requests being issued by
followers when applying leader updates. It was caused by a call to
`MultiBuffer::remove_excerpts` with an empty list of excerpts to remove.
This PR fixes that by avoiding emitting spurious events when multibuffer
excerpt manipulation methods are called with empty lists.
2023-05-18 14:52:21 -07:00
Max Brunsfeld
58f704abcb
Avoid unnecessary code action requests when applying leader updates to an editor
2023-05-18 14:46:23 -07:00
Mikayla Maki
87e206c451
Fixed an imprecise join in rejoin room ( #2488 )
...
This fixed a pre-existing bug in rejoin room that got expanded to
stalling collab with the new git status feature.
Release Notes:
* N/A
2023-05-18 14:42:59 -07:00
Mikayla Maki
99fcf23798
fmt
2023-05-18 14:31:08 -07:00
Mikayla Maki
95a7d69bce
Fixed an imprecise join in rejoin room
2023-05-18 14:29:18 -07:00
Max Brunsfeld
2883d6f1ef
Improve collab logging ( #2487 )
...
This adds some logging to the collab server, to help us identify the
source of the collaboration latency we're seeing in the 0.87 preview
version of zed.
2023-05-18 14:17:17 -07:00
Max Brunsfeld
2a11a89827
collab 0.12.3
2023-05-18 12:27:08 -07:00
Joseph Lyons
55b241a4f6
collab 0.12.2
2023-05-18 12:27:01 -07:00
Max Brunsfeld
c71b59b248
Log how long it takes to handle each RPC message
2023-05-18 12:24:07 -07:00
Kirill Bulatov
923be1892d
Maintain recently opened files history ( #2467 )
...
Part of https://github.com/zed-industries/community/issues/351 and
https://github.com/zed-industries/community/issues/1125
Adds navigation history to the search file dialogue:

The history is only shown on empty query and gets replaced by the query
results after an input.
Currently, history gets lost between the project restarts.
Release Notes:
* Added a recently opened file list to search file dialogue
2023-05-18 22:06:25 +03:00
Kirill Bulatov
2ec994dfcd
Add a unit test
2023-05-18 21:53:42 +03:00
Kirill Bulatov
201d513c50
Show navigation history in the file finder modal
...
co-authored-by: Max <max@zed.dev >
2023-05-18 21:50:38 +03:00
Kirill Bulatov
711d2c6fe7
Maintain recently opened files history
2023-05-18 21:50:38 +03:00
Julia
bd29812391
Avoid panic in get_injections ( #2486 )
2023-05-18 13:35:10 -04:00
Julia
5ab1ae1521
Avoid panic in get_injections
2023-05-18 12:23:49 -04:00
Max Brunsfeld
83f8981308
Define empty theme for tests regardless of cargo features ( #2485 )
...
This fixes some errors that were happening when running a single crate's
tests, if the test did not enable the `test-support` feature in the
`theme` crate.
2023-05-18 09:14:46 -07:00
Max Brunsfeld
71ad7e7612
Define empty theme for tests regardless of cargo features
...
Co-authored-by: Kirill <kirill@zed.dev >
2023-05-18 09:01:38 -07:00
Antonio Scandurra
f2ad17dbc0
WIP
2023-05-18 15:35:46 +02:00
Kirill Bulatov
263afc75a8
Merge pull request #2484 from zed-industries/kb/unite-dmg-build
...
Unite dmg build jobs
Follow-up of https://github.com/zed-industries/zed/pull/2472 actually doing the proper thing: allow running dmg builds on PRs if `run-build-dmg` label is attached.
2023-05-18 14:39:41 +03:00
Kirill Bulatov
5ab4eab369
Unite dmg build jobs
2023-05-18 13:49:55 +03:00
Mikayla Maki
89d8bb1425
WIP: Add persistence to new docks
2023-05-17 17:34:20 -07:00
Max Brunsfeld
5c437e2098
Fix crashes when running zed bundled
2023-05-17 16:53:48 -07:00
Max Brunsfeld
a9b107f155
Fix release-mode stub for watch_themes
2023-05-17 16:36:06 -07:00
Max Brunsfeld
d23fc6f135
Merge pull request #2448 from zed-industries/setting-store
...
Separate the settings struct into a set of dynamically-registered setting types
2023-05-17 16:19:09 -07:00
Max Brunsfeld
a56793c214
Clear buffer font size adjustments when buffer font size setting changes
2023-05-17 16:14:05 -07:00
Max Brunsfeld
823e15d85a
Refresh windows when settings file changes
2023-05-17 16:02:21 -07:00
Max Brunsfeld
667f476f7f
Remove unused watched_json file
2023-05-17 16:02:08 -07:00
Max Brunsfeld
42eca3048f
Move font size adjustment code to the theme crate
2023-05-17 15:56:32 -07:00
Max Brunsfeld
258723566f
Rename settings::register_setting -> settings::register
2023-05-17 15:06:11 -07:00
Max Brunsfeld
2d5f03e148
Remove optional path argument when getting settings
2023-05-17 15:05:20 -07:00
Max Brunsfeld
1f0e79ee9d
Merge branch 'main' into setting-store
2023-05-17 14:56:35 -07:00
Max Brunsfeld
67a25126d4
Define theme/ui text style settings in theme crate
2023-05-17 14:44:59 -07:00
Mikayla Maki
5ef03992c5
Merge pull request #2483 from zed-industries/add-scrollbar-settings
...
Add scrollbars setting
2023-05-17 14:44:08 -07:00
Mikayla Maki
f4e99ecde4
Add never option to scrollbar settings
2023-05-17 14:19:35 -07:00
Mikayla Maki
88bc55ddf5
Add a dependency on rustfmt to the CI tests
2023-05-17 14:17:10 -07:00
Mikayla Maki
6cf439e734
fmt
2023-05-17 14:12:04 -07:00
Mikayla Maki
ae3394f4de
Add scrollbars setting
2023-05-17 14:09:26 -07:00
Mikayla Maki
1c9a7a7ad8
Merge pull request #2482 from zed-industries/add-hunks-to-scrollbar
...
Add diff hunks to the scroll bar
2023-05-17 11:51:01 -07:00
Mikayla Maki
aa89632286
Add diff hunks to the scroll bar
2023-05-17 11:40:30 -07:00
Max Brunsfeld
5c729c0e56
Define base keymap setting in welcome crate
2023-05-17 11:23:09 -07:00
Julia
7d11329e80
Merge pull request #2481 from zed-industries/update-font-kit
...
Update font-kit to resolve panics when loading malformed fonts
2023-05-17 13:57:39 -04:00
Julia
9e5983305b
Update font-kit to resolve panics when loading malformed fonts
2023-05-17 13:38:54 -04:00
Max Brunsfeld
89204e85c0
Merge branch 'main' into setting-store
2023-05-17 09:55:24 -07:00
Joseph Lyons
cb0c613da2
v0.88.x dev
2023-05-17 12:39:08 -04:00
Max Brunsfeld
d2ba18eae9
Customize language settings JSON schema in language crate
2023-05-17 09:26:36 -07:00
Antonio Scandurra
4898417617
Drop foreign key constraint from workspaces.dock_pane to panes table
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-05-17 18:21:35 +02:00
Antonio Scandurra
05fb051924
Store whether a panel is zoomed in the panel itself
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-05-17 17:51:11 +02:00
Antonio Scandurra
f097444546
Rebind ctrl-` to toggle terminal panel focus
...
Also, add `ctrl-~` to create new terminals.
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-05-17 17:35:10 +02:00
Antonio Scandurra
747fbfadeb
Notify old/new ancestors of the focused view when they change
2023-05-17 17:12:12 +02:00
Antonio Scandurra
981129ef8e
Show a panel/pane as zoomed only if it's the active item in workspace
2023-05-17 15:06:58 +02:00
Max Brunsfeld
6403bb86e1
Define workspace settings in workspace crate
2023-05-16 20:25:18 -07:00
Max Brunsfeld
cbd4771f10
Define project settings in project crate
2023-05-16 17:45:04 -07:00
Max Brunsfeld
65e3713d4d
Define editor settings in editor crate
2023-05-16 17:30:29 -07:00
Max Brunsfeld
39618ae32d
Define language settings in the language crate
2023-05-16 17:29:53 -07:00
Julia
0a0769d4b9
Merge pull request #2479 from zed-industries/dont-use-svg-text-feature
...
Disable usvg's text feature flags to include less dependency code
2023-05-16 18:48:12 -04:00
Julia
d61b12a05b
Disable usvg's text feature flags to include less dependency code
2023-05-16 18:44:16 -04:00
Joseph T. Lyons
362f56d519
Merge pull request #2478 from zed-industries/Fix-telemetry-bugs
...
Send editor event when saving a new file
2023-05-16 18:18:07 -04:00
Joseph Lyons
c27859871f
Send editor event when saving a new file
2023-05-16 18:16:09 -04:00
Joseph T. Lyons
2e27f26339
Merge pull request #2475 from zed-industries/add-copilot-events
...
Add events for copilot suggestion accepting and discarding
2023-05-16 17:25:54 -04:00
Joseph Lyons
ffd503951b
Don't make events for every rejected suggestion
2023-05-16 17:19:05 -04:00
Kirill Bulatov
55950e52c2
Remove extra dbg!
2023-05-16 22:15:56 +03:00
Kirill Bulatov
685f3de796
Merge pull request #2462 from zed-industries/kb/go-to-line-column-numbers
...
Support go to file_query:row:column syntax in Find File, Go To Line dialogs and CLI
Deals slightly differently with zed-industries/community#557
Deals with zed-industries/community#1184
Fixes Go To Line not respecting column number when navigating to a place
Changes a line-row separator from , to : to show it more uniformly with other tools
Adjusts file finder dialogue to allow file_query:row:column syntax and opens the buffer at the lines given
Extends CLI with file_path:row_column syntax and opens these files similarly
2023-05-16 21:24:57 +03:00
Kirill Bulatov
5d4fc99750
Unit test file:row:column parsing
2023-05-16 21:07:48 +03:00
Kirill Bulatov
be7a58b508
Finalize the CLI opening part
2023-05-16 21:07:48 +03:00
Kirill Bulatov
0c6f103899
Return proper items on workspace restoration.
...
co-authored-by: Mikayla <mikayla@zed.dev >
2023-05-16 21:07:48 +03:00
Kirill Bulatov
106064c734
Do not break Zed & Zed CLI compatibility
2023-05-16 21:07:47 +03:00
Kirill Bulatov
628558aa39
Attempt to open rows and columns from CLI input
2023-05-16 21:07:26 +03:00
Kirill Bulatov
d719352152
Unify path:row:column parsing, use it in CLI
2023-05-16 21:07:26 +03:00
Kirill Bulatov
89fe5c6b09
Test caret selection in file finder
...
co-authored-by: Max <max@zed.dev >
2023-05-16 21:07:26 +03:00
Kirill Bulatov
477bc8da05
Make Go To Line to respect column numbers
2023-05-16 21:07:26 +03:00
Kirill Bulatov
e5bca9c871
Simplify file-row-column parsing
2023-05-16 21:07:26 +03:00
Kirill Bulatov
e9606982e6
Use ':' instead of ',' to separate files, rows and columns
2023-05-16 21:07:26 +03:00
Kirill Bulatov
0db7f4202a
Properly place the caret into the window of the file opened
...
co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-05-16 21:07:26 +03:00
Kirill Bulatov
54c1e77aff
Move the caret to the opened file
2023-05-16 21:07:26 +03:00
Kirill Bulatov
3eea2fb5f8
Parse file find queries with extra data
2023-05-16 21:07:26 +03:00
Kirill Bulatov
9de4a1b70f
Merge pull request #2476 from zed-industries/kb/faster-dev-cli
...
Allow CLI to start Zed from local sources
2023-05-16 21:06:40 +03:00
Joseph Lyons
afe75e8cbd
Send copilot events even if file_extension is not known at the time
2023-05-16 14:02:36 -04:00
Joseph Lyons
6976d60bfe
Rework code to contain submitting of copilot events within editor
2023-05-16 13:26:05 -04:00
Julia
16cab5d021
Merge pull request #2477 from zed-industries/fixup-some-more-worktree-bugs
...
Fixup some more worktree bugs
2023-05-16 13:13:22 -04:00
Julia
8b63caa0bd
Fix worktree refresh request causing gitignore to not update
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-05-16 13:01:29 -04:00
Julia
f50240181a
Avoid removing fake fs entry when rename fails later in the process
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-05-16 13:00:39 -04:00
Antonio Scandurra
f87ae6032e
Don't rely on action propagation for zooming in and out
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-05-16 10:34:50 -06:00
Joseph Lyons
2d4b2e0844
Fix compile error
2023-05-16 11:51:20 -04:00
Kirill Bulatov
903eed964a
Allow CLI to start Zed from local sources
...
Zed now is able to behave as if it's being started from CLI
(`ZED_FORCE_CLI_MODE` env var)
Zed CLI accepts regular binary file path into `-b` parameter (only *.app before),
and tries to start it as Zed editor with `ZED_FORCE_CLI_MODE` env var
and other params needed.
2023-05-16 17:41:32 +03:00
Kirill Bulatov
421db9225a
Merge pull request #2470 from zed-industries/kb/fix-project-search-esc
...
In project search on ESC, reduce multiple carets to one first
2023-05-16 15:16:34 +03:00
Antonio Scandurra
adf361b374
Implement zooming for panes and docks
2023-05-16 11:49:48 +02:00
Joseph Lyons
a7fc07a8cd
Init copilot with client instead of http client
2023-05-16 03:12:39 -04:00
Joseph Lyons
f50afefed3
Subscribe to copilot events (WIP)
2023-05-16 00:35:21 -04:00
Joseph Lyons
a6a2f93607
Update telemetry client to accept copilot events
2023-05-16 00:34:58 -04:00
Mikayla Maki
ead9ac6f23
Fix typo
2023-05-15 16:47:46 -07:00
Mikayla Maki
606d5e36e1
Add events for copilot suggestion accepting and discarding
2023-05-15 16:44:09 -07:00
Mikayla Maki
790223f23a
Merge pull request #2473 from zed-industries/fix-styling-feedback
...
Fix git status issues
2023-05-15 16:28:57 -07:00
Mikayla Maki
e4d509adf4
fmt
2023-05-15 16:22:52 -07:00
Mikayla Maki
4d40aa5d6f
Restore trickle up git status to folder
...
co-authored-by: max <max@zed.dev >
2023-05-15 16:22:00 -07:00
Mikayla Maki
f59256f761
Update git repositories to be streamed with their entries
...
co-authored-by: max <max@zed.dev >
2023-05-15 16:22:00 -07:00
Mikayla Maki
68078853b7
Made status tracking resilient to folder renames
...
co-authored-by: max <max@zed.dev >
2023-05-15 16:21:58 -07:00
Mikayla Maki
307dd2b83e
Update proto names to reflect new status info
2023-05-15 16:20:01 -07:00
Mikayla Maki
1e4ab6cd75
Add index tracking to status
2023-05-15 16:20:01 -07:00
Mikayla Maki
6c26f3d0e4
Fixed formatting
2023-05-15 16:20:01 -07:00
Mikayla Maki
2b18975cdc
Change folder styling from a reduce over all child files to a simple 'always modified'
...
Remove git status from tab titles
2023-05-15 16:20:01 -07:00
Joseph T. Lyons
17f138906e
Merge pull request #2474 from zed-industries/update-jetbrains-keymap
...
Update jetbrains keymap
2023-05-15 14:17:36 -04:00
Joseph Lyons
6a7d718381
Update jetbrains keymap
2023-05-15 14:12:02 -04:00
Julia
cf53b2ca87
Merge pull request #2471 from zed-industries/optimize-update-local-worktree-buffers
...
Optimize update local worktree buffers
2023-05-15 13:13:09 -04:00
Antonio Scandurra
c03e470fe6
Introduce Panel::can_zoom
2023-05-15 17:10:30 +02:00
Kirill Bulatov
18e0ee44a6
Remove redundant scopes and actions to fix the focus toggle on ESC
...
co-authored-by: Antonio <antonio@zed.dev >
2023-05-15 13:10:15 +03:00
Kirill Bulatov
93705cbe55
Merge pull request #2472 from zed-industries/kb/zed-main-builds
...
Build Zed for main and labeled PR commits
Add a job to build Zed images marked with the SHA of the commit it was built from.
The job triggers on every commit to main or every PR with run-build-dmg label and produces an install-ready *.dmg artifact attached to the corresponding CI run.
2023-05-15 11:30:26 +03:00
Kirill Bulatov
5465948f20
Build Zed dmg
2023-05-15 11:26:41 +03:00
Kirill Bulatov
4f36ba3b1e
Add a job to build Zed images from current main
...
The job triggers on every commit to `main` or every PR with
`run-build-dmg` label and produces an install-ready *.dmg artifact attached to the
corresponding CI run.
2023-05-14 22:06:33 +03:00
Julia
fa32adecd5
Fixup more, tests finally pass
2023-05-14 12:06:00 -04:00
Nathan Sobo
ba50b35de6
wip
2023-05-13 14:34:09 -06:00
Mikayla Maki
db87e83bad
Merge pull request #2469 from zed-industries/fix-git-init-bug
...
Fix repository initialization bug
2023-05-13 10:47:55 -07:00
Mikayla Maki
a6a4b846bc
fmt
2023-05-13 10:43:16 -07:00
Mikayla Maki
5e2aaf45a0
Fix repository initialization bug
2023-05-13 10:38:24 -07:00
Mikayla Maki
3534665e2b
Merge pull request #2468 from zed-industries/touch-up-status
...
Improve status integration
2023-05-13 09:38:02 -07:00
Mikayla Maki
04041af78b
Fixed bug with failing to clear git file status
2023-05-13 02:40:22 -07:00
Mikayla Maki
62c445da57
Match priority of folder highlights to vscode
2023-05-13 02:30:59 -07:00
Mikayla Maki
41bef2e444
Refactor out git status into FileName component
...
Integrate file name component into the editor's tab content
2023-05-13 02:26:45 -07:00
Nathan Sobo
6c60853842
Don't close panel on event unless active; add tests
2023-05-12 15:44:09 -06:00
Nathan Sobo
bd795d7607
Preserve panel size when re-docking between left and right
2023-05-12 15:15:11 -06:00
Joseph T. Lyons
e1c1100c7b
Merge pull request #2466 from zed-industries/update-release-links
...
Update release links
2023-05-12 14:08:10 -04:00
Joseph Lyons
b70c874a0e
Update release links
2023-05-12 14:04:36 -04:00
Mikayla Maki
ad7ed56e6b
Delete pull_request_template.md
2023-05-12 10:15:13 -07:00
Mikayla Maki
4663ac8abf
Create pull_request_template.md
2023-05-12 10:14:54 -07:00
Mikayla Maki
e71846c653
Create pull_request_template.md
2023-05-12 10:12:47 -07:00
Mikayla Maki
deac8a6ff9
Merge pull request #2465 from zed-industries/stream-branch-first
...
Send the root branch along with it's entry
2023-05-12 09:45:40 -07:00
Mikayla Maki
60320c6b09
Send the root branch along with it's entry
2023-05-12 09:37:02 -07:00
Mikayla Maki
54e9e7c35b
Merge pull request #2464 from zed-industries/remove-between
...
Add TreeMap::remove_between that can take abstract start and end points
2023-05-12 08:59:56 -07:00
Nathan Sobo
214354b4da
Make panels independently resizable
2023-05-12 09:44:14 -06:00
Mikayla Maki
6ef0f70528
Made the map seek target a publicly implementable interface
...
Integrated remove_range with the existing git code
co-authored-by: Nathan <nathan@zed.dev >
2023-05-12 08:37:32 -07:00
Nathan Sobo
ee3637216e
Add TreeMap::remove_between that can take abstract start and end points
...
This commit introduces a new adaptor trait for SeekTarget that works around
frustrating issues with lifetimes. It wraps the arguments in a newtype wrapper
that lives on the stack to avoid the lifetime getting extended to the caller
of the method.
This allows us to introduce a PathSuccessor object that can be passed as the
end argument of remove_between to remove a whole subtree.
2023-05-12 08:21:01 -07:00
Kirill Bulatov
89352a2bdc
Merge pull request #2463 from zed-industries/kb/reapply-modal-accessibility
...
Reintroduce more accesible modal keybindings
2023-05-12 06:11:04 +03:00
Max Brunsfeld
9ae10a5dd9
Add a better API for updating settings in the SettingsStore in tests
2023-05-11 17:24:58 -07:00
Mikayla Maki
defc9c8591
Merge pull request #2455 from zed-industries/git-status-viewer
...
Add Git Status to the project panel
2023-05-11 16:13:34 -07:00
Mikayla Maki
5fe8b73f04
compile error 😅
2023-05-11 16:07:41 -07:00
Mikayla Maki
d526fa6f1f
fmt
2023-05-11 16:06:56 -07:00
Mikayla Maki
d538994c7f
Use more efficient sum tree traversals for removal and improve ergonomics with iter_from
...
co-authored-by: Nathan <nathan@zed.dev >
2023-05-11 16:06:25 -07:00
Mikayla Maki
72655fc41d
fmt
2023-05-11 13:25:57 -07:00
Mikayla Maki
6f87f9c51f
Don't scan for statuses in files that are ignored
2023-05-11 13:25:07 -07:00
Mikayla Maki
1bb34e08bb
Fix test
2023-05-11 12:03:39 -07:00
Mikayla Maki
dfb6a2f7fc
fmt
2023-05-11 12:02:25 -07:00
Mikayla Maki
5b2ee63f80
Added status trickle up
2023-05-11 12:01:42 -07:00
Kirill Bulatov
f12dffa60c
Reintroduce more accesible modal keybindings
...
Brings commit 475fc40923 back
2023-05-11 20:59:10 +03:00
Mikayla Maki
5accf7cf4e
Update is_deleted when sending new repositories
2023-05-11 10:21:25 -07:00
Max Brunsfeld
bebb5456c7
Merge pull request #2461 from zed-industries/ci-target-dir-size
...
During CI, clear the target directory if it gets larger than a maximum size
2023-05-11 09:57:36 -07:00
Max Brunsfeld
3550110e57
ci: clear the target dir if it gets too big
2023-05-11 09:43:13 -07:00
Mikayla Maki
191ac86f09
Remove the CORRECT, overly agressive deletion codepath
2023-05-11 09:24:36 -07:00
Joseph Lyons
0ab94551f4
Revert "More keybindings in macOs modals with buttons"
...
This reverts commit 1398a12062 .
2023-05-11 11:37:34 -04:00
Julia
0f34af50a8
Use path list generated during entry reload of a refresh request
2023-05-10 23:37:02 -04:00
Mikayla Maki
adfbbf21b2
fmt
2023-05-10 20:09:37 -07:00
Mikayla Maki
f5c633e80c
Fixed bug in status deletion marking
2023-05-10 19:54:02 -07:00
Mikayla Maki
fca3bb3b93
Add randomized test for git statuses
2023-05-10 19:21:27 -07:00
Mikayla Maki
9800a149a6
Remove some external context from git status test
2023-05-10 17:59:33 -07:00
Mikayla Maki
f55ca7ae3c
Fix incorrect import
2023-05-10 17:52:23 -07:00
Mikayla Maki
18becabfa5
Add postgres migration
2023-05-10 17:50:35 -07:00
Max Brunsfeld
bc5b78198a
Define terminal settings in terminal crate
2023-05-10 17:43:10 -07:00
Mikayla Maki
c7166fde3b
Bump protocol version
2023-05-10 17:38:29 -07:00
Mikayla Maki
65d4c4f6ed
Add integration test for git status
2023-05-10 17:37:36 -07:00
Mikayla Maki
e20eaca595
Got basic replication working :)
2023-05-10 17:37:36 -07:00
Mikayla Maki
2b80dfa81d
Update protos
2023-05-10 17:37:36 -07:00
Mikayla Maki
00b345fdfe
Use sum tree traversal to remove paths
2023-05-10 17:37:36 -07:00
Mikayla Maki
23a19d85b8
Fix bug in status detection when removing a directory
2023-05-10 17:37:36 -07:00
Mikayla Maki
0082d68d4a
Revert "Convert git status calculation to use Entry IDs as the key instead of repo relative paths"
...
This reverts commit 728c6892c924ebeabb086e308ec4b5f56c4fd72a.
2023-05-10 17:37:36 -07:00
Petros Amoiridis
21e1bdc8cd
Fix yellow to be yellow
2023-05-10 17:37:36 -07:00
Petros Amoiridis
6b4242cded
Use theme.editor.diff for the colors
2023-05-10 17:37:36 -07:00
Mikayla Maki
f935047ff2
Convert git status calculation to use Entry IDs as the key instead of repo relative paths
2023-05-10 17:37:36 -07:00
Mikayla Maki
94a0de4c9f
Fix compile errors
2023-05-10 17:37:36 -07:00
Mikayla Maki
a58a33fc93
WIP: integrate status with collab
2023-05-10 17:37:36 -07:00
Mikayla Maki
18cec8d64f
Format
2023-05-10 17:37:36 -07:00
Mikayla Maki
e98507d8bf
Added git status to the project panel, added worktree test
2023-05-10 17:37:36 -07:00
Mikayla Maki
93f57430da
Track live entry status in repository
2023-05-10 17:37:36 -07:00
Mikayla Maki
bd98f78101
Fix compile error
2023-05-10 17:37:36 -07:00
Mikayla Maki
67491632cb
WIP: Track live entry status in repository
...
co-authored-by: petros <petros@zed.dev >
2023-05-10 17:37:36 -07:00
Mikayla Maki
7169f5c760
Add git status to the file system abstraction
...
co-authored-by: petros <petros@zed.dev >
2023-05-10 17:37:36 -07:00
Max Brunsfeld
cee7edabf9
Ensure the SettingsStore global is added in tests
2023-05-10 16:39:59 -07:00
Joseph Lyons
6385e51957
collab 0.12.1
2023-05-10 18:16:20 -04:00
Joseph Lyons
9405b49957
v0.87.x dev
2023-05-10 16:47:09 -04:00
Max Brunsfeld
68867fe2e1
Define journal settings in journal crate
2023-05-10 12:59:24 -07:00
Max Brunsfeld
aa6ea920e2
Define telemetry settings in the client crate
2023-05-10 12:59:24 -07:00
Max Brunsfeld
9b06be2aa2
Define vim_mode setting in vim crate
2023-05-10 12:59:24 -07:00
Max Brunsfeld
926d7b356d
Define auto_update setting in the auto_update crate
2023-05-10 12:59:24 -07:00
Max Brunsfeld
b6b2c5d1d1
Generalize settings JSON schema logic to work w/ arbitrary setting types
2023-05-10 12:59:24 -07:00
Max Brunsfeld
9a6a2d9d27
Start using the SettingsStore in the app
2023-05-10 12:59:24 -07:00
Max Brunsfeld
316f791a77
Add generic update method to SettingsStore
2023-05-10 12:59:24 -07:00
Max Brunsfeld
24e06334d0
Allow registering additional settings after loading global settings
2023-05-10 12:59:24 -07:00
Max Brunsfeld
5de9652a22
Create proof-of-concept SettingStore struct
2023-05-10 12:59:22 -07:00
Nathan Sobo
5549669316
Test moving panels
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-05-10 10:41:03 -06:00
Mikayla Maki
c7fcc031eb
Merge pull request #2460 from zed-industries/show-dock-on-activate
...
Fix bug with terminal button
2023-05-10 09:08:45 -07:00
Nathan Sobo
cc21421ea8
Rename item to panel in various locations
2023-05-10 09:54:20 -06:00
Mikayla Maki
0dce5ba7ae
Fix bug with terminal button
2023-05-10 08:15:20 -07:00
Antonio Scandurra
0ccb4a50e6
Create more specific dock position settings associated with each panel
2023-05-10 16:52:10 +02:00
Antonio Scandurra
e507eadb4b
Rely on root getting re-focused when panel isn't rendered
...
This achieves two things:
- When a panel like `TerminalPanel` closes its last tab, the focus
is returned to the root view (the `Workspace`)
- When a panel is moved from a dock to another, it will get rendered
in another spot but the focus will be kept on the panel
This also ensures the focus is not lost when a panel is moved from
a dock to another because that view
2023-05-10 15:43:44 +02:00
Antonio Scandurra
9b9d53fcf8
Focus the root view if the previously-focused view isn't rendered
2023-05-10 15:40:46 +02:00
Antonio Scandurra
cdcb7c8084
Merge branch 'main' into panels
2023-05-10 15:23:37 +02:00
Antonio Scandurra
f28eee88b6
Add context menu to change panel position
2023-05-10 14:05:48 +02:00
Antonio Scandurra
8fa379bbc5
Maintain panel visibility when changing its position
2023-05-10 11:06:37 +02:00
Antonio Scandurra
6e3ce6332a
Fix panic when not specifying a project_panel setting
2023-05-10 10:43:42 +02:00
Kirill Bulatov
eec60556ab
Highlight include/exclude inputs when errors happen there
2023-05-10 11:11:31 +03:00
Kirill Bulatov
dfdf7e4866
Test the search inclusions/exclusions
2023-05-10 11:11:31 +03:00
Kirill Bulatov
80fc1bc276
Use placeholder in include/exclude editors
2023-05-10 11:11:31 +03:00
Kirill Bulatov
0e31d13a1e
Rework tab and escape key handling in search panel
...
Fixes
https://linear.app/zed-industries/issue/Z-1238/focus-the-results-multibuffer-in-project-search-on-esc
and adds a tab shortcut for project search inputs
co-authored-by: Julia <julia@zed.dev >
2023-05-10 11:11:31 +03:00
Kirill Bulatov
3da55c14a6
Fix arrow layout
2023-05-10 11:11:31 +03:00
Kirill Bulatov
6fb8679184
Trim glob input
2023-05-10 11:11:31 +03:00
Kirill Bulatov
13296d502c
Extra rows approach draft
...
co-authored-by: Max <max@zed.dev >
2023-05-10 11:11:31 +03:00
Kirill Bulatov
b5abac6af6
Draft search include/exclude logic
2023-05-10 11:11:31 +03:00
Kirill Bulatov
915154b047
Add initial include/exclude project search UI
2023-05-10 11:11:31 +03:00
Antonio Scandurra
3115c8381d
Merge pull request #2458 from zed-industries/fix-context-menu-click
...
Always dismiss context menu on click
2023-05-10 09:24:23 +02:00
Antonio Scandurra
1b5e79251c
Always dismiss context menu on click
2023-05-10 09:18:13 +02:00
Nathan Sobo
9173916ab8
Remove unused terminal_button module
2023-05-09 20:24:37 -06:00
Nathan Sobo
f554877ff4
Render the bottom dock buttons before the right dock buttons
2023-05-09 17:41:24 -06:00
Nathan Sobo
ba248244ec
Allow terminal to be docked left, bottom, or right
...
Co-Authored-By: Joseph Lyons <joseph@zed.dev >
2023-05-09 17:36:49 -06:00
Nathan Sobo
6a7feb4c4c
Allow the project panel to be docked right or left
...
Co-Authored-By: Joseph Lyons <joseph@zed.dev >
2023-05-09 17:26:54 -06:00
Nathan Sobo
0d78266ddb
Replace todo with unimplemented to reduce distractions
2023-05-09 16:41:10 -06:00
Nathan Sobo
6d16d2224d
Merge branch 'main' into panels
2023-05-09 16:35:04 -06:00
Nathan Sobo
5e8b7bd06d
Replace todo with unimplemented to reduce distractions
2023-05-09 16:31:53 -06:00
Mikayla Maki
26d80eef0a
Merge pull request #2456 from zed-industries/fix-dock-pane-focus
...
Make dock not eagerly steal focus from sub items
2023-05-09 15:59:06 -04:00
Mikayla Maki
0214228689
Fix format
2023-05-09 12:54:53 -07:00
Nathan Sobo
6645323f1b
WIP
2023-05-09 13:28:34 -06:00
Mikayla Maki
6dfb48dbd5
Fix center items not being activated when deserialized
2023-05-09 12:27:07 -07:00
Mikayla Maki
8d561d6408
Make dock not eagerly steal focus from sub items
2023-05-09 12:00:09 -07:00
Antonio Scandurra
8f12489937
WIP: Allow panels to be moved
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-05-09 18:57:25 +02:00
Antonio Scandurra
45df09245b
Remove unused code
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-05-09 18:06:59 +02:00
Antonio Scandurra
37d3ed5f5f
Focus new item if pane was focused when removing previous active item
...
Previously, we were relying on the item getting blurred and the workspace
receiving focus, which would in turn focus the active pane. This doesn't
play well with docks because they aren't part of the workspace panes.
2023-05-09 17:38:54 +02:00
Antonio Scandurra
641f5d1107
Ensure ctrl-` works in the terminal panel
2023-05-09 17:38:18 +02:00
Antonio Scandurra
2bc7be9a76
WIP
2023-05-09 17:14:33 +02:00
Antonio Scandurra
48ad3866b7
Randomly mutate worktree in addition to mutating the file-system
...
This ensures that we test the code path that refreshes entries.
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-05-09 17:01:11 +02:00
Antonio Scandurra
7f27d72b20
Deliver file-system change events in batches in randomized worktree test
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-05-09 16:55:03 +02:00
Julia
5c859da457
Only update changed local worktree buffers
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-05-09 15:13:12 +02:00
Antonio Scandurra
634b699281
Allow customization of Pane tab bar buttons
2023-05-09 15:05:29 +02:00
Antonio Scandurra
ad7f32d7d2
Fix bottom dock resizing
2023-05-09 14:46:15 +02:00
Antonio Scandurra
26fe7a81f3
Prevent splits in the terminal panel
2023-05-09 12:29:16 +02:00
Antonio Scandurra
e6be35c9a5
Show terminal count in panel button
2023-05-09 12:21:35 +02:00
Antonio Scandurra
02066afb0e
Don't pass &mut Workspace when closing items in a Pane
...
This allows closing items via actions even in the `TerminalPanel`
where the `Pane` is not directly owned by a `Workspace`.
2023-05-09 11:45:39 +02:00
Antonio Scandurra
506f978c41
Automatically close terminal dock when the last terminal was closed
2023-05-09 10:18:11 +02:00
Antonio Scandurra
916612caf1
Prevent dragging items that aren't terminals to the terminal panel
2023-05-09 10:18:11 +02:00
Antonio Scandurra
6ddc610fa2
WIP: Start on TerminalPanel
2023-05-09 10:18:11 +02:00
Nathan Sobo
1ddbda5095
Rename DockItem to Panel
2023-05-09 10:18:11 +02:00
Nathan Sobo
03f8c1206a
Rename Sidebar to Dock
2023-05-09 10:18:10 +02:00
Nathan Sobo
1919a826f9
Remove dock from workspace
2023-05-09 10:18:10 +02:00
Mikayla Maki
2d7cfb8c7c
Merge pull request #2454 from zed-industries/fix-mismatching-panes-when-deserializing-empty-panes
...
Fully remove panes and update internal data structures
2023-05-08 20:37:06 -04:00
Mikayla Maki
fa049bea6e
Refactor and fix format
2023-05-08 17:32:40 -07:00
Mikayla Maki
49335d017a
Add manual removal code to remove_panes
2023-05-08 17:25:28 -07:00
Mikayla Maki
9b2d3fcd48
Fully remove panes and update internal data structures
2023-05-08 17:09:29 -07:00
Max Brunsfeld
8fd0c9fb0e
collab 0.12.0
2023-05-08 15:54:11 -07:00
Mikayla Maki
1d66f24f23
Merge pull request #2428 from zed-industries/add-branch-name
...
Add branch name and synchronize repository representations on the worktree.
2023-05-08 17:40:47 -04:00
Mikayla Maki
9366a0dbee
Bump protocol version number
2023-05-08 14:34:14 -07:00
Mikayla Maki
f28419cfd1
Fix styling of titlebar highlights
2023-05-08 14:33:59 -07:00
Mikayla Maki
712fb5ad7f
Add postgres migration
2023-05-08 14:33:59 -07:00
Mikayla Maki
1a9afd186b
Restore randomized integration tests
2023-05-08 14:33:59 -07:00
Mikayla Maki
15d2f19b4a
fix format
2023-05-08 14:33:59 -07:00
Mikayla Maki
d2279674a7
Fix panic in tests
2023-05-08 14:33:59 -07:00
Mikayla Maki
62e763d0d3
Removed test modifications, added special case to git initialization for when the repository is inside a .git folder
2023-05-08 14:33:59 -07:00
Mikayla Maki
f9e4464658
Refresh titlebar on project notifications
2023-05-08 14:33:59 -07:00
Mikayla Maki
2c2076bd77
Adjust tests to not create repositories inside repositories
2023-05-08 14:33:59 -07:00
Mikayla Maki
ab952f1b31
Fixed randomized test failures
...
co-authored-by: Max <max@zed.dev >
2023-05-08 14:33:59 -07:00
Mikayla Maki
d8dac07408
Removed scan ID from repository interfaces
...
co-authored-by: Max <max@zed.dev >
2023-05-08 14:33:59 -07:00
Mikayla Maki
270147d20c
Finished RepositoryEntry refactoring, smoke tests passing
...
co-authored-by: Max <max@zed.dev >
2023-05-08 14:33:59 -07:00
Mikayla Maki
53569ece03
WIP: Change RepositoryEntry representation to be keyed off of the work directory
...
Removes branches button scaffolding
2023-05-08 14:33:59 -07:00
Mikayla Maki
b6d6f5c650
WIP: re-arranging the RepositoryEntry representation
...
Added branches to the randomized test to check the git branch
Added the remaining database integrations in collab
Co-authored-by: Max <max@zed.dev >
Co-authored-by: Petros <petros@zed.dev >
2023-05-08 14:33:59 -07:00
Mikayla Maki
8bde496e74
Add branch name in title UI
...
co-authored-by: Petros <petros@zed.dev >
2023-05-08 14:33:59 -07:00
Petros Amoiridis
5302c256a4
Rebase main and fix error
2023-05-08 14:33:59 -07:00
Mikayla Maki
8301ee43d6
WIP: Add repository entries to collab and synchronize when rejoining the room
...
co-authored-by: Max <max@zed.dev >
2023-05-08 14:33:59 -07:00
Mikayla Maki
2fe5bf419b
Add proto fields for repository entry maintenance
2023-05-08 14:33:59 -07:00
Mikayla Maki
c6d7ed33c2
Add smoke test for collaboration
2023-05-08 14:33:59 -07:00
Petros Amoiridis
ca4da52e39
Remove unused functions
2023-05-08 14:33:59 -07:00
Petros Amoiridis
e057b0193f
Introduce BrancesButton in title bar
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-05-08 14:33:58 -07:00
Petros Amoiridis
797d47a08c
Render title root names without branches
2023-05-08 14:33:58 -07:00
Petros Amoiridis
92a222aba8
Introduce a version control branch icon
2023-05-08 14:33:58 -07:00
Mikayla Maki
8f0aa3c6d9
Add branch name into title
2023-05-08 14:33:58 -07:00
Petros Amoiridis
d34ec462f8
Display branch information per worktree root
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-05-08 14:33:58 -07:00
Mikayla Maki
ffd9d4eb59
Fix bug in repo detection
2023-05-08 14:33:58 -07:00
Mikayla Maki
3570810516
Add API for accessing git branch
2023-05-08 14:33:58 -07:00
Mikayla Maki
26afd592c5
Wire in the branch name
2023-05-08 14:33:58 -07:00
Mikayla Maki
5b4e58d1de
Fix repo_for and clean up repository_entries
2023-05-08 14:33:58 -07:00
Mikayla Maki
023d665fb3
Fix TreeMap retain
2023-05-08 14:33:58 -07:00
Mikayla Maki
ae890212e3
Restored a lost API and got everything compiling
2023-05-08 14:33:58 -07:00
Mikayla Maki
bcf608e9e9
WIP: Refactor existing git code to use new representation.
...
co-authored-by: petros <petros@zed.dev >
2023-05-08 14:33:58 -07:00
Mikayla Maki
563f13925f
WIP: Convert old git repository vec to new treemap based approach.
...
co-authored-by: Nathan <nathan@zed.dev >
2023-05-08 14:33:58 -07:00
Mikayla Maki
a58d3d8128
Add a data driven representation of the current git repository state to the worktree snapshots
...
WIP: Switch git repositories to use SumTrees
Co-authored-by: Nathan <nathan@zed.dev >
2023-05-08 14:33:58 -07:00
Mikayla Maki
bb93447a0d
Merge pull request #2453 from zed-industries/fix-click-fallthrough
...
Fixed clicks falling through the modal terminal
2023-05-08 13:59:57 -04:00
Mikayla Maki
2cf928c85a
Fixed clicks falling through the modal terminal
...
co-authored-by: Antonio <antonio@zed.dev >
2023-05-08 10:54:12 -07:00
Kirill Bulatov
39bddfc7b7
Only allow invisbles in local and leader selections
2023-05-08 19:36:51 +03:00
Kirill Bulatov
98ff18c430
Code review fixes
2023-05-08 19:36:51 +03:00
Kirill Bulatov
e6489e999d
Add invisibles wrapping test
2023-05-08 19:36:51 +03:00
Kirill Bulatov
d2b2dc39d9
Do not print invisibles in non-full mode editors
2023-05-08 19:36:51 +03:00
Nate Butler
ab6b3adb2b
Add a theme entry for whitespace, use it to style whitespaces
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
Co-Authored-By: Kirill Bulatov <mail4score@gmail.com >
2023-05-08 19:36:51 +03:00
Kirill Bulatov
fb3ef4bcf6
Fix wrapped line detection
2023-05-08 19:36:51 +03:00
Kirill Bulatov
075bab2ea9
Use more convntional name for the settings
2023-05-08 19:36:51 +03:00
Kirill Bulatov
706f6f495a
Add a test
2023-05-08 19:36:51 +03:00
Kirill Bulatov
ec725fe399
Do not print extra invisibles on line wraps
2023-05-08 19:36:51 +03:00
Kirill Bulatov
95bcd19020
Refactor line glyphs drawing methods
2023-05-08 19:36:51 +03:00
Kirill Bulatov
4aaf44df94
Support invisibles in the selection
2023-05-08 19:36:51 +03:00
Kirill Bulatov
1eeeec157e
Use cached standard glyphs for invisible symbols
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-05-08 19:36:51 +03:00
Kirill Bulatov
714734d279
Add whitespaces rendering
2023-05-08 19:36:51 +03:00
Kirill Bulatov
2d8c88ad73
Draw tabs with svg icons in editor code only
2023-05-08 19:36:51 +03:00
Kirill Bulatov
f0a88b3337
Make invisibles display configurable
2023-05-08 19:36:51 +03:00
Kirill Bulatov
ad731ea6d2
Draft invisibles' tabs display
2023-05-08 19:36:51 +03:00
Max Brunsfeld
4f8607039c
Add is_tab field to chunks
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-05-08 19:36:51 +03:00
Julia
cf304a0edc
Merge pull request #2452 from zed-industries/prevent-some-rounding-clipping
...
Prevent some cases of clipping icons due to pixel coord rounding
2023-05-08 11:48:33 -04:00
Julia
332b364a30
Prevent some cases of clipping icons due to pixel coord rounding
2023-05-08 11:42:00 -04:00
Antonio Scandurra
235470bbfd
Merge pull request #2451 from zed-industries/kb/extra-deps
...
Remove unused dependencies
2023-05-08 14:46:27 +02:00
Kirill Bulatov
6cb0bc89d2
Remove unused dependencies
2023-05-07 21:07:55 +03:00
Antonio Scandurra
0296974ab1
Merge pull request #2441 from zed-industries/implicit-ancestry
...
Determine view ancestry during layout
2023-05-05 10:58:00 +02:00
Antonio Scandurra
5e16f70067
💄
2023-05-05 10:53:15 +02:00
Antonio Scandurra
080a1f00a3
Delay focus_in event for window activation till after layout
2023-05-05 10:47:42 +02:00
Antonio Scandurra
b9ed327b94
Replace usages of is_parent_view_focused with is_self_focused
...
Previously, this was used because we didn't have access to the current
view and `EventContext` was an element-only abstraction. Now that the
`EventContext` wraps the current view's `ViewContext` we can simply check
for the view's focus and avoid querying ancestors.
2023-05-05 10:08:22 +02:00
Antonio Scandurra
80ad59a620
Make focusing the parent an effect to avoid querying ancestors
2023-05-05 10:04:54 +02:00
Joseph T. Lyons
c55a4c0feb
Merge pull request #2447 from zed-industries/fix-auto-update
...
Do not use post_json() to auto update
2023-05-04 17:15:09 -04:00
Mikayla Maki
3631b3a86c
Merge pull request #2446 from zed-industries/fix-copilot-logged-out
...
Fix copilot stuck in logged out state
2023-05-04 16:52:04 -04:00
Mikayla Maki
89af803565
Rearrange the state machine
2023-05-04 13:45:31 -07:00
Julia
137cbaba34
Merge pull request #2445 from zed-industries/construct-text-buffer-in-background
...
Construct text buffer in background
2023-05-04 16:01:39 -04:00
Julia
eacea55aaf
Fixup cases using buffer model handle id as buffer id
2023-05-04 12:32:31 -04:00
Julia
1883e260ce
Offload text::Buffer construction to background worker
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-05-04 12:32:31 -04:00
Julia
7e06062bdb
Store history base text as rope
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-05-04 12:32:31 -04:00
Joseph Lyons
8313414e1e
Do not use post_json() to auto update
2023-05-04 12:12:36 -04:00
Antonio Scandurra
d6b0569bed
Merge branch 'main' into implicit-ancestry
2023-05-04 17:19:06 +02:00
Antonio Scandurra
f51425d390
Merge pull request #2444 from zed-industries/fix-clicking-sidebar-buttons
...
Use `Workspace::toggle_sidebar_item` when clicking on sidebar button
2023-05-04 17:14:40 +02:00
Antonio Scandurra
64e0c16baa
Use Workspace::toggle_sidebar_item when clicking on sidebar button
...
Previously, we were mistakenly using `Sidebar::toggle_item`, which only
performs part of the toggle operation.
2023-05-04 17:06:37 +02:00
Antonio Scandurra
cbae4e751b
Merge pull request #2443 from zed-industries/fix-vim-mode-rename
...
Avoid calling `update_window` twice in `blurred` event handler
2023-05-04 16:24:51 +02:00
Antonio Scandurra
912a4cf549
Avoid calling update_window twice in blurred event handler
...
This was preventing us from unhooking vim when performing a rename,
which prevented typing in the rename editor.
2023-05-04 16:18:01 +02:00
Antonio Scandurra
0f93714d4f
Merge pull request #2442 from zed-industries/filter-vim-commands
...
Filter out vim commands when vim mode is disabled
2023-05-04 15:00:19 +02:00
Antonio Scandurra
b1f5cfaa79
Merge pull request #2440 from zed-industries/fix-navigate-to-definitions-panic
...
Fix panic when opening multiple definitions in a multibuffer
2023-05-04 14:56:43 +02:00
Antonio Scandurra
b3baebde22
Filter out vim commands when vim mode is disabled
2023-05-04 14:52:34 +02:00
Antonio Scandurra
da19edc3e3
Merge branch 'main' into implicit-ancestry
2023-05-04 14:39:58 +02:00
Antonio Scandurra
121264d35a
Fix panic when opening multiple definitions in a multibuffer
...
The editor is on the stack, so adding an item to the `Pane` containing
the editor will cause a double borrow and a consequent panic. This
commit fixes the issue by deferring the opening of the definitions.
2023-05-04 14:34:42 +02:00
Antonio Scandurra
7e2a461486
Merge pull request #2439 from zed-industries/fix-keystrokes-for-action
...
Cache view's type id and keymap context into a separate map
2023-05-04 14:22:42 +02:00
Antonio Scandurra
5cc6304fa6
Verify keystrokes can be queried while views are on the stack
2023-05-04 12:09:32 +02:00
Antonio Scandurra
3d679ddb26
Avoid re-allocating KeymapContext after every view notification
2023-05-04 12:04:30 +02:00
Antonio Scandurra
18e39ef2fa
Cache view's type id and keymap context into a separate map
...
During `layout`, we now pass a mutable reference to the element's
parent view. This is a recursive process that causes the view to
be removed from `AppContext` and then re-inserted back into it once
the layout is complete.
As such, querying parent views during `layout` does not work as such
views will have been removed from `AppContext` and not yet re-inserted
into it. This caused a bug in `KeystrokeLabel`, which used the `keystrokes_for_action`
method to query its ancestors to determine their type id and keymap context.
Now, any time a view notifies, we will cache its keymap context so that
we don't need to query the parent view during `layout`.
2023-05-04 10:47:56 +02:00
Antonio Scandurra
7b7a495be3
Remove stray dbg! statement
2023-05-04 09:56:49 +02:00
Antonio Scandurra
f6f18be9c3
Remove WindowContext::is_child_focused
2023-05-04 09:53:35 +02:00
Antonio Scandurra
67a3891f15
Make dispatch_event related methods public to the crate only
2023-05-04 09:53:35 +02:00
Antonio Scandurra
92183e0d72
Ensure querying keystrokes or actions is safe
...
This is achieved by moving `available_actions` into `AsyncAppContext` (where
we know no view/window is on the stack) and `keystrokes_for_action` into `LayoutContext`
where we'll fetch the previous frame's ancestors and notify the current view if those
change after we perform a layout.
2023-05-04 09:53:31 +02:00
Joseph Lyons
053b34875b
collab 0.11.0
2023-05-03 14:59:04 -04:00
Joseph Lyons
653ea3a85d
v0.86.x dev
2023-05-03 14:38:41 -04:00
Max Brunsfeld
c2c29d3fb6
Merge pull request #2427 from zed-industries/copilot-disabled-globs
...
Add copilot.disabled_globs setting
2023-05-03 11:00:08 -07:00
Max Brunsfeld
9d41f83b1b
Merge branch 'main' into copilot-disabled-globs
2023-05-03 10:53:28 -07:00
Antonio Scandurra
040cc4d4c3
Allow notifying views when the ancestry of another view is outdated
2023-05-03 19:25:00 +02:00
Max Brunsfeld
8eb1312deb
Add copilot menu item for enabling paths by glob
2023-05-03 10:14:01 -07:00
Antonio Scandurra
7250754f8e
Make dispatch_keystroke public to the crate only
2023-05-03 19:13:17 +02:00
Antonio Scandurra
9e8f852afb
Remove ViewContext::is_child
2023-05-03 19:09:07 +02:00
Antonio Scandurra
5157442703
Fix integration test relying on deferred happening after focus
...
Focus is now one of the last things that happens during `flush_effects`,
and we shouldn't have relied on `defer` in the first place to verify
focus changes.
2023-05-03 19:00:32 +02:00
Antonio Scandurra
c65465b0b5
Ensure workspace gets rendered in collab integration tests
2023-05-03 18:31:07 +02:00
Antonio Scandurra
e9ed40da37
Remove the ability to retrieve the view's parent
2023-05-03 16:52:55 +02:00
Antonio Scandurra
7f137ed3dd
Compute view ancestry at layout time
2023-05-03 16:36:14 +02:00
Antonio Scandurra
7f345f8bf5
Separate Window::build_scene into layout and paint
2023-05-03 12:18:16 +02:00
Antonio Scandurra
3f037e5128
Merge pull request #2437 from zed-industries/fix-joining-call
...
Fix "IncomingCallNotification was dropped" error when accepting a call
2023-05-03 10:49:04 +02:00
Antonio Scandurra
376aa1235f
Fix "IncomingCallNotification was dropped" error when accepting a call
...
This was caused by accepting the call, which caused the notification to
be removed. When `active_call.accept_incoming()` finally completed, we
would try to get the app state from it in order to join the project, but
couldn't becuase the view would have already been dropped.
This commit fixes the bug by capturing a weak handle to the app state
when accepting the call as opposed to trying to read it from the view
when the accept completes.
2023-05-03 10:37:57 +02:00
Antonio Scandurra
c3cf9e3185
Merge pull request #2436 from zed-industries/close-window-end-call
...
Move methods querying window state into `AsyncAppContext`
2023-05-03 10:27:05 +02:00
Joseph T. Lyons
f576586cd7
Merge pull request #2435 from zed-industries/use-json-post-request-for-update-requests
...
Use json_post() request for update requests
2023-05-02 23:42:25 -04:00
Joseph Lyons
41d4454f45
Use post_json so that the Content-Type is set to application/json
2023-05-02 23:23:43 -04:00
Joseph Lyons
69a4fffae2
Update post_json to take in a bool for allowing for redirects
2023-05-02 23:22:55 -04:00
Joseph T. Lyons
7f5afeb9fa
Merge pull request #2434 from zed-industries/add-download-and-uplodate-metadata-to-update-request
...
Add download and upload metadata to update request
2023-05-02 22:27:58 -04:00
Joseph Lyons
2b95aba99c
Add download and upload metadata to update request
2023-05-02 17:16:42 -04:00
Kirill Bulatov
1398a12062
More keybindings in macOs modals with buttons
...
Closes https://github.com/zed-industries/community/issues/1095
by forcing the non-Cancel button to get a focus.
Due to the way macOs handles buttons on modals, the focus gain had to be
achieved via certain button addition order, rather than conventional
"setFocus"-ish API, see the related comment for details.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-05-02 21:10:20 +03:00
Antonio Scandurra
70f8cf4cf6
Move methods querying window state into AsyncAppContext
2023-05-02 19:38:48 +02:00
Julia
4f6939732e
Merge pull request #2432 from zed-industries/more-diagnostic-source
...
Show diagnostic source in more places
2023-05-02 09:16:11 -04:00
Julia
185c1650df
Show diagnostic source in inline diagnostic
2023-05-02 09:08:07 -04:00
Antonio Scandurra
9108e4151e
Merge pull request #2431 from zed-industries/fix-broken-contact-finder
...
Fix broken styling in contact finder
2023-05-02 13:55:14 +02:00
Antonio Scandurra
94f1775533
Fix broken styling in contact finder
...
This regressed as part of #2372 , where we forgot to theme the contact
finder picker differently from the rest of the app.
2023-05-02 13:46:49 +02:00
Antonio Scandurra
e8f2d985ff
Merge pull request #2430 from zed-industries/fix-toggle-contacts-panic
...
Fix panic when showing contacts popover via keybinding
2023-05-02 11:53:24 +02:00
Antonio Scandurra
f985fac6f9
Fix panic when showing contacts popover via keybinding
2023-05-02 11:47:05 +02:00
Antonio Scandurra
484cda51cf
Merge pull request #2429 from zed-industries/fix-debug-elements-panic
...
Move `debug_elements` to `AsyncAppContext`
2023-05-02 11:15:57 +02:00
Kirill Bulatov
f5278c49b0
Clarify GH Token scope requirements
2023-05-02 12:12:57 +03:00
Antonio Scandurra
794446bf8b
Move debug_elements to AsyncAppContext
...
Previously, `debug_elements` was available on `WindowContext`. If that
method was called while having a borrow out to a view, it would panic because
the view would already have been borrowed.
By moving it to an `AsyncAppContext` we ensure the method can't be called while
a view is being used.
2023-05-02 11:09:40 +02:00
Antonio Scandurra
4c1cba6def
Remove unnecessary Element impl for RootElement
2023-05-02 10:09:57 +02:00
Julia
f7de0ad8ae
Show diagnostic source in diagnostic multibuffer headers
2023-05-01 16:48:27 -04:00
Max Brunsfeld
c485fc86a2
Add copilot.disabled_globs setting
2023-05-01 13:45:47 -07:00
Joseph T. Lyons
f62ba2eec7
use installation_id over device_id
2023-05-01 16:29:51 -04:00
Julia
5fb9d53dd0
Merge pull request #2425 from zed-industries/trim-eslint-workspace-configuration
...
Trim eslint workspace configuration & remove diagnostic source underline
2023-05-01 13:24:14 -04:00
Julia
40ab5c1fb9
Remove underline from diagnostic source
2023-05-01 13:15:41 -04:00
Julia
4966a4a681
Reduce hardcoded ESLint workspace configuration
2023-05-01 13:14:35 -04:00
Antonio Scandurra
a8084ad3f4
Merge pull request #2424 from zed-industries/constrain-programmatic-dispatch
...
Allow programmatic action dispatch only via `AsyncAppContext`
2023-05-01 17:10:57 +02:00
Antonio Scandurra
780ece551e
Defer hiding the dock and going back/forward when Pane is on the stack
2023-05-01 17:06:05 +02:00
Antonio Scandurra
e3b2407ebf
Run until parked now that the command palette spawns to dispatch action
2023-05-01 16:58:07 +02:00
Antonio Scandurra
6c931ab9da
Inline test-only AppContext methods
2023-05-01 16:49:17 +02:00
Antonio Scandurra
eb2cce98a7
Move dispatch_action_any_action_at to AsyncAppContext
2023-05-01 16:40:57 +02:00
Antonio Scandurra
c4472b0786
Remove ViewContext::dispatch_action
2023-05-01 16:27:36 +02:00
Antonio Scandurra
d815fc88ae
Remove ViewContext::dispatch_any_action
2023-05-01 14:24:00 +02:00
Antonio Scandurra
029538fe21
Make dispatch_global_action private
2023-05-01 11:45:35 +02:00
Antonio Scandurra
0f44648b38
Merge pull request #2423 from zed-industries/fix-panic-in-go-to-definition
...
Fix panic when clicking on a definition
2023-04-29 15:02:18 +02:00
Antonio Scandurra
e566929d9e
Fix panic when clicking on a definition
...
This was introduced with #2420 and was caused by re-entrantly updating
the workspace. Instead of passing the workspace reference from the outside,
we now define the definition navigation as a method on the editor which solves
the issue.
Note that we also needed to introduce a `defer` call when navigating to a definition
to prevent the workspace from reading the editor during `open_project_item`.
2023-04-29 14:53:17 +02:00
Joseph T. Lyons
ae5794d911
Merge pull request #2421 from zed-industries/metrics-2
...
Rework telemetry code to support sending events to Clickhouse
2023-04-28 17:16:33 -04:00
Julia
32f26d1e9a
Merge pull request #2422 from zed-industries/source-eslint-server-from-github
...
Source ESLint server from Github rather than 3rd party NPM package
2023-04-28 16:53:07 -04:00
Julia
1bf85214a4
Source ESLint server from Github rather than 3rd party NPM package
2023-04-28 16:42:36 -04:00
Joseph Lyons
6b0faa2d9c
Rework telemetry code to support sending events to Clickhouse
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-04-28 16:06:55 -04:00
Antonio Scandurra
dc999f719b
Merge pull request #2420 from zed-industries/simplify-action-dispatch
...
Remove `impl_internal_actions!` macro
2023-04-28 17:39:56 +02:00
Antonio Scandurra
106ebeb386
Remove obsolete presenter modules
2023-04-28 17:37:25 +02:00
Antonio Scandurra
489b1f6a63
Merge remote-tracking branch 'origin/main' into simplify-action-dispatch
2023-04-28 17:31:12 +02:00
Antonio Scandurra
1c5376a560
Remove impl_internal_actions macro
2023-04-28 17:29:57 +02:00
Antonio Scandurra
1d41a703ad
Remove internal actions from terminal_button
2023-04-28 17:29:17 +02:00
Antonio Scandurra
33da9e5690
Remove internal actions from project_panel
2023-04-28 17:21:10 +02:00
Antonio Scandurra
e1535735b8
Remove DeployContextMenu internal action
2023-04-28 16:51:01 +02:00
Antonio Scandurra
f65e64829e
Remove Scroll internal action
2023-04-28 16:43:31 +02:00
Antonio Scandurra
3409ee1785
Remove DeployMouseContextMenu internal action
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-28 16:41:46 +02:00
Antonio Scandurra
c22342e271
💄
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-28 16:38:00 +02:00
Antonio Scandurra
1f35e1dbf9
Remove internal actions from copilot_button
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-28 16:36:57 +02:00
Antonio Scandurra
a91903c2ab
Remove internal actions from link_go_to_definition
2023-04-28 16:24:46 +02:00
Antonio Scandurra
264a2c1835
Remove HideHover and HoverAt internal actions
2023-04-28 16:12:24 +02:00
Antonio Scandurra
e6f561ce46
Remove unused Jump internal action
2023-04-28 15:57:36 +02:00
Antonio Scandurra
c04cb0286a
Remove Dismiss and RespondToContactRequest internal actions
2023-04-28 15:56:41 +02:00
Antonio Scandurra
0469e25de6
Remove LeaveCall internal action
2023-04-28 14:14:25 +02:00
Antonio Scandurra
83436213ad
Remove Jump internal action
2023-04-28 14:13:07 +02:00
Antonio Scandurra
3763b985e3
Fix panic due to re-entrantly reading Workspace
2023-04-28 12:36:50 +02:00
Antonio Scandurra
a978f3fe4f
Remove Select internal action
2023-04-28 12:33:22 +02:00
Antonio Scandurra
5215adbd3f
Remove ToggleExpanded and Call internal actions
2023-04-28 12:26:47 +02:00
Antonio Scandurra
5d8fcceee3
Remove RespondToCall internal action
2023-04-28 12:24:07 +02:00
Antonio Scandurra
4bcba487c5
Remove SplitWithProjectEntry internal action
2023-04-28 12:19:38 +02:00
Antonio Scandurra
272039a858
Remove SplitWithItem internal action
2023-04-28 12:17:31 +02:00
Antonio Scandurra
6857426b78
Remove RemoveWorktreeFromProject internal action
2023-04-28 12:11:59 +02:00
Antonio Scandurra
71a4bc7905
Remove OpenSharedScreen internal action
2023-04-28 12:09:34 +02:00
Antonio Scandurra
d953729233
Remove JoinProject internal action
2023-04-28 11:22:04 +02:00
Antonio Scandurra
f881f9e3d8
Remove ToggleFollow internal action
2023-04-28 10:07:44 +02:00
Antonio Scandurra
06c01a5937
Eliminate OpenPaths global action for workspace and replace with methods
...
We no longer want to invoke this with dispatch_action.
2023-04-27 18:36:28 -06:00
Max Brunsfeld
db73ba5a1a
Merge pull request #2419 from zed-industries/zombie-copilot-process
...
Shutdown copilot server when quitting zed
2023-04-27 14:47:30 -07:00
Max Brunsfeld
1533c17cd7
Shutdown copilot server when quitting zed
2023-04-27 14:39:00 -07:00
Max Brunsfeld
7258db7a4e
Merge pull request #2417 from zed-industries/hover-markdown
...
Render markdown more correctly in the editor hover popover
2023-04-27 14:15:04 -07:00
Max Brunsfeld
6042df393b
Give code spans in markdown a background highlight
2023-04-27 13:58:30 -07:00
Max Brunsfeld
8eb9c6563a
Generalize Text element to let you add arbitrary scene primitives for runs of text
2023-04-27 13:58:06 -07:00
Julia
92c9de1f50
Merge pull request #2415 from zed-industries/diagnostic-hovers-source
...
Show source of diagnostic on hover
2023-04-27 15:12:22 -04:00
Julia
87539e7b82
Update test to not fail due to absence of diagnostic source
2023-04-27 15:04:48 -04:00
Max Brunsfeld
66d4cb8c14
Tweak rendering of multi-paragraph list items in markdown
2023-04-27 11:39:34 -07:00
Julia
a284fae515
Don't hardcode workspaceFolder for ESLint adapter
2023-04-27 14:35:34 -04:00
Julia
678c188de0
Re-allow diagnostics hovers to soft wrap
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-04-27 14:35:34 -04:00
Julia
3f7533a0b4
Show source of diagnostic hovers
2023-04-27 14:35:34 -04:00
Max Brunsfeld
45c7073934
Merge pull request #2418 from zed-industries/vim-inactive-window-crash
...
Fix vim mode crash when active editor changes in inactive window
2023-04-27 10:48:49 -07:00
Max Brunsfeld
30f20024c0
Fix vim mode crash when active editor changes in inactive window
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-27 10:43:35 -07:00
Antonio Scandurra
6cbc1dcd87
💄
2023-04-27 14:56:16 +02:00
Antonio Scandurra
20e38d2def
Remove OpenProjectEntryInPane internal action
2023-04-27 14:51:02 +02:00
Antonio Scandurra
b6437d6d9e
Remove Toast and DismissToast internal actions
2023-04-27 14:43:10 +02:00
Antonio Scandurra
2950344c25
Remove internal actions from Dock
2023-04-27 14:29:15 +02:00
Antonio Scandurra
15d83d40b0
Remove internal actions from menu crate
2023-04-27 14:29:11 +02:00
Antonio Scandurra
816eb06a7b
Remove internal actions from CopilotCodeVerification
2023-04-27 14:25:34 +02:00
Antonio Scandurra
32f21771a6
Remove internal actions from ContextMenu
2023-04-27 14:25:14 +02:00
Antonio Scandurra
022368225e
Remove internal actions from Pane
2023-04-27 14:23:26 +02:00
Antonio Scandurra
5521ff1b22
Allow passing a handler function to context menu items
2023-04-27 11:32:12 +02:00
Antonio Scandurra
d3b976d044
Remove ContextMenu::element_item
2023-04-27 11:11:21 +02:00
Antonio Scandurra
df2f471ddf
Remove unused ContextMenu::ViewAction
2023-04-27 10:55:37 +02:00
Antonio Scandurra
06b12bbb68
Remove unnecessarily general keystroke_label_for function
2023-04-27 10:55:14 +02:00
Max Brunsfeld
c6abb0db3a
Improve rendering of multi-paragraph list items in hover markdown
2023-04-26 17:09:20 -07:00
Max Brunsfeld
c75207c4e5
Merge pull request #2416 from zed-industries/outline-view-leaving-lines-highlighted
...
Remove highlighted rows when confirming outline view
2023-04-26 16:11:22 -07:00
Max Brunsfeld
c15dadbb8c
Remove highlighted rows when confirming outline view
2023-04-26 15:46:29 -07:00
Max Brunsfeld
d298ce3fd3
Render more markdown features in hover popover
2023-04-26 15:33:10 -07:00
Max Brunsfeld
7960067cf9
Fix bug where Text element would wrap at the right glyph in the wrong run
2023-04-26 15:33:10 -07:00
Max Brunsfeld
54e7464163
collab 0.10.0
2023-04-26 13:24:08 -07:00
Max Brunsfeld
1bbcff543b
Add API for adding mouse regions within Text
2023-04-26 12:00:26 -07:00
Joseph Lyons
99e82d829f
v0.85.x dev
2023-04-26 14:19:52 -04:00
Nathan Sobo
a45282eb63
Merge pull request #2414 from zed-industries/spawn-weak-for-views
...
Pass a `WeakViewHandle` to `ViewContext::spawn`
2023-04-26 06:10:44 -06:00
Antonio Scandurra
6317e885c7
Don't allow strong view handles to be read/updated with an AsyncAppContext
...
This avoids an invitation to hold strong view handles across async await
points, which is a common source of leaks.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-26 13:36:13 +02:00
Antonio Scandurra
689e878bd8
Use a WeakViewHandle in Client for view message handlers
2023-04-26 12:21:02 +02:00
Antonio Scandurra
57beec6071
Allow direct read/update of WeakViewHandle only in AsyncAppContext
2023-04-26 12:20:57 +02:00
Antonio Scandurra
2b6830c798
Remove unnecessary calls to WeakViewHandle::upgrade
2023-04-26 11:13:46 +02:00
Antonio Scandurra
94c2eaad23
Replace ViewContext::spawn with ViewContext::spawn_weak
2023-04-26 10:23:27 +02:00
Antonio Scandurra
09f7e41907
Merge pull request #2405 from zed-industries/fewer-context-traits
...
Simplify traits for accessing app state uniformly across different kinds of contexts
2023-04-26 10:02:56 +02:00
Antonio Scandurra
7ca412ade3
Merge remote-tracking branch 'origin/main' into fewer-context-traits
2023-04-26 09:54:58 +02:00
Max Brunsfeld
a7145021b6
Extract a named struct from text_layout::Line's style runs
2023-04-25 14:05:23 -07:00
Max Brunsfeld
3cb50ed6b7
Merge pull request #2413 from zed-industries/project-search-focus
...
Preserve previous focus when re-focusing project search
2023-04-25 09:33:09 -07:00
Max Brunsfeld
3db67a48b5
Preserve previous focus when re-focusing project search
2023-04-25 09:28:50 -07:00
Max Brunsfeld
c31a5063d0
Merge pull request #2411 from zed-industries/rust-snippet-variable-completions
...
Avoid treating snippet completions' details as their variable types
2023-04-25 08:59:35 -07:00
Max Brunsfeld
db276a422f
Merge pull request #2412 from zed-industries/more-workspace-deps
...
Specify more dependencies at the cargo workspace level, to avoid repeating versions
2023-04-24 18:09:35 -07:00
Max Brunsfeld
ebbe52e6b0
🎨 Specify more dependencies at the workspace level
2023-04-24 17:41:55 -07:00
Max Brunsfeld
dd3f6ff4ca
Avoid treating snippet completions' details as their variable types
2023-04-24 16:20:14 -07:00
Max Brunsfeld
b76194db97
Merge pull request #2409 from zed-industries/stale-excerpts
...
Fix stale project diagnostic excerpts for guests
2023-04-24 14:22:04 -07:00
Max Brunsfeld
7bd51851c2
🎨
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-04-24 13:54:47 -07:00
Max Brunsfeld
a8ddba55d8
Send language server updates via the same task that sends buffer operations
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-04-24 13:52:03 -07:00
Max Brunsfeld
ce34bf62fe
Add failing test for diagnostic message ordering
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-04-24 13:18:37 -07:00
Max Brunsfeld
d2ba1ec275
Merge pull request #2407 from zed-industries/lsp-log-view
...
Add a simple language server log view
2023-04-24 10:15:29 -07:00
Max Brunsfeld
f3ada72785
Avoid accidentally dropping subscription when detaching it
2023-04-24 10:04:45 -07:00
Max Brunsfeld
1793c5ff6c
Upgrade tree-sitter-json
2023-04-24 09:43:31 -07:00
Max Brunsfeld
e7cb996044
Improve the LSP log UI
2023-04-24 09:43:31 -07:00
Max Brunsfeld
6ed7f1281f
Persist LSP logs after log view is closed
2023-04-24 09:43:31 -07:00
Max Brunsfeld
6ef6f03322
Update LspLog view to use new gpui APIs
2023-04-24 09:43:31 -07:00
Max Brunsfeld
a280a93cd8
Start work on a language server log view
2023-04-24 09:43:31 -07:00
Max Brunsfeld
2dd4920625
Add LanguageServer::on_io method, for observing JSON sent back and forth
2023-04-24 09:43:31 -07:00
Max Brunsfeld
abdccf7393
Use a workspace dependency for the futures crate
2023-04-24 09:43:31 -07:00
Mikayla Maki
d82cc49f79
Merge pull request #2408 from zed-industries/change-copilot-wording
...
Change copilot wording to be more explicit
2023-04-25 04:28:23 +12:00
Mikayla Maki
c12e2ac3fb
fix formatting
2023-04-24 09:25:04 -07:00
Mikayla Maki
c7874cf169
Update copilot_button.rs
2023-04-24 09:03:54 -07:00
Antonio Scandurra
c165fb9be5
Remove ReadView and UpdateView traits
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-24 17:36:14 +02:00
Antonio Scandurra
a6115d9330
Remove UpdateModel trait
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-24 16:52:09 +02:00
Antonio Scandurra
a9417f3d2e
Remove ReadModelWith trait
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-24 16:44:54 +02:00
Antonio Scandurra
5f500d34b2
Remove UpgradeModelHandle trait
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-24 16:40:30 +02:00
Antonio Scandurra
b8fab6fde9
Remove UpgradeViewHandle trait
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2023-04-24 16:33:27 +02:00
Mikayla Maki
455d383d08
Change copilot wording to be more explicit
2023-04-21 21:42:23 -07:00
Mikayla Maki
f10de10915
Merge pull request #2406 from zed-industries/fix-nondeterministic-terminal-test
...
Fix minor terminal bugs
2023-04-22 12:42:20 +12:00
Mikayla Maki
fa7f4974a0
Remove unused import
2023-04-21 17:26:45 -07:00
Mikayla Maki
733abc9ed2
Revert previous change
2023-04-21 17:24:20 -07:00
Mikayla Maki
616188c541
Fix a bug where the character under a cursor could not reliably be selected
2023-04-21 17:15:29 -07:00
Mikayla Maki
8e0d359c63
Merge branch 'main' into fix-nondeterministic-terminal-test
2023-04-22 11:17:06 +12:00
Mikayla Maki
d841c3729b
Wire through the gutter, rather than implicitly adding it
2023-04-21 16:12:33 -07:00
Mikayla Maki
23932b7e6c
Fixed non-deterministic test failure and made mouse to cell conversion work correctly
2023-04-21 16:06:07 -07:00
Max Brunsfeld
06cb388beb
Merge pull request #2404 from zed-industries/fix-command-palette
...
Stopgap: Fix missing actions in the command palette
2023-04-21 15:16:45 -07:00
Nathan Sobo
e6604d1641
Fix missing actions in the command palette
...
Previously, the workspace view was on the stack when we were computing the
available actions, which excluded it. This is a stopgap. We should find a
better solution ASAP.
2023-04-21 15:59:29 -06:00
Nathan Sobo
83bf3d071d
WIP
2023-04-21 15:36:52 -06:00
Nathan Sobo
55db28e074
Eliminate ReadModel trait
2023-04-21 15:05:19 -06:00
Nathan Sobo
5dac95c47c
Eliminate ReadView trait
2023-04-21 15:03:57 -06:00
Nathan Sobo
bce51c521a
Merge pull request #2403 from zed-industries/into-element
...
Rename Element to AnyElement, Drawable to Element, and make containers generic over any Element type
2023-04-21 14:44:22 -06:00
Nathan Sobo
993dbf86cb
Merge remote-tracking branch 'origin/main' into into-element
2023-04-21 14:27:25 -06:00
Nathan Sobo
09111b65d8
Merge pull request #2401 from zed-industries/simplify-context-lifetimes
...
Remove unnecessary lifetime parameter from WindowContext
2023-04-21 14:26:26 -06:00
Nathan Sobo
caf3d5c163
Fix more formatting
2023-04-21 14:25:49 -06:00
Nathan Sobo
c1810e8ec9
Fix formatting
2023-04-21 13:09:36 -06:00
Nathan Sobo
fe492eacbf
Refine naming of element-related types and traits
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-04-21 13:06:37 -06:00
Antonio Scandurra
03619dfa55
Rename Drawable::boxed to into_element and make containers generic
...
Multi-element are now generic over any drawable child, which can be converted
into an element.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-04-21 12:43:19 -06:00
Mikayla Maki
69273648b3
Merge pull request #2402 from zed-industries/fix-panics
...
Fix panic in pane.rs
2023-04-22 05:53:48 +12:00
Mikayla Maki
b8fd6435d7
Fix test covering this case
2023-04-21 10:48:34 -07:00
Mikayla Maki
aa2af53f56
Align return of close_active_item to match original format
2023-04-21 10:44:27 -07:00
Mikayla Maki
39512655aa
Remove unused cyclic dependency from copilot crate
...
Move notification handling earlier so that there are less copilot messages in the log
2023-04-21 10:38:36 -07:00
Mikayla Maki
6ee0d104d6
Fix panic in remove active item
2023-04-21 10:08:52 -07:00
Petros Amoiridis
c9048b54c1
Merge pull request #2399 from zed-industries/petros/z-827-copy-the-newline-shortcuts-to-zed
...
Add newline shortcuts for popular editors
2023-04-21 19:09:10 +03:00
Antonio Scandurra
4ac894ffbe
Remove unnecessary lifetime parameter from WindowContext
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-21 18:06:53 +02:00
Antonio Scandurra
a4fbcbf160
Merge pull request #2400 from zed-industries/fix-breadcrumbs-signature
...
Fix `ProjectDiagnosticsEditor::breadcrumbs` signature
2023-04-21 18:06:22 +02:00
Antonio Scandurra
4d433663bd
Fix ProjectDiagnosticsEditor::breadcrumbs signature
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-21 17:54:26 +02:00
Antonio Scandurra
238ebafa48
Merge pull request #2372 from zed-industries/window_context_2
...
Give elements access to their parent views and simplify contexts
2023-04-21 17:32:14 +02:00
Julia
88406045f5
Merge pull request #2398 from zed-industries/fix-diagnostics-breadcrumbs
...
Render breadcrumbs for diagnostics multi-buffer
2023-04-21 11:31:35 -04:00
Petros Amoiridis
3992e95109
Add newline shortcuts for popular editors
2023-04-21 18:29:35 +03:00
Antonio Scandurra
f54a289b6f
Remove handle to view from TerminalElement
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-21 16:56:06 +02:00
Antonio Scandurra
a860a6cd62
Make App::notify_view private
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-21 16:50:57 +02:00
Antonio Scandurra
8c7f821d14
Introduce a new WindowContext::remove_window API
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-21 16:39:53 +02:00
Petros Amoiridis
c3231047ad
Merge pull request #2396 from zed-industries/petros/z-77-the-start-local-collaboration-script-no
...
Fix script/start-local-collaboration
2023-04-21 17:36:22 +03:00
Antonio Scandurra
f12746c4b7
Avoid double borrow of view in ProjectPanel drag and drop
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-21 16:23:47 +02:00
Antonio Scandurra
31e906d068
Avoid double borrow of views on up and up_out in DragAndDrop
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-21 16:19:51 +02:00
Petros Amoiridis
65c5605e68
Look for the main display always
2023-04-21 17:18:01 +03:00
Petros Amoiridis
3c54b14c5b
Remove debugging information
2023-04-21 17:17:04 +03:00
Antonio Scandurra
5b40641fde
Take a target view when marking an element as draggable
2023-04-21 15:52:05 +02:00
Antonio Scandurra
b0cbd13e7a
Remove stray push_layer from EditorElement::paint
2023-04-21 11:46:13 +02:00
Antonio Scandurra
e5192a4853
Use update_default_global to filter command palette items for copilot
2023-04-21 11:07:36 +02:00
Antonio Scandurra
c76b9794e4
Merge branch 'main' into window_context_2
2023-04-21 10:58:08 +02:00
Antonio Scandurra
d32a7218cd
Remove stray dbg! statements
2023-04-21 10:49:47 +02:00
Julia
c7cc5bca02
Render breadcrumbs for diagnostics multi-buffer
2023-04-20 23:39:45 -04:00
Mikayla Maki
8e4cc549dc
Merge pull request #2397 from zed-industries/finally-fix-terminal-line-height
...
Create a new setting to adjust the line height in the terminal
2023-04-21 12:39:49 +12:00
Mikayla Maki
1fa52adabd
Fix warning
2023-04-20 17:34:47 -07:00
Mikayla Maki
c72b70d4ae
Fixed silly custom settings parsing
2023-04-20 17:33:06 -07:00
Mikayla Maki
f54ab73b47
Merge branch 'main' into finally-fix-terminal-line-height
2023-04-21 12:26:32 +12:00
Mikayla Maki
dfdc826015
Create a new setting to adjust the line height in the terminal
2023-04-20 17:24:27 -07:00
Nathan Sobo
1b2e480e1e
Remove unnecessary replace
2023-04-20 15:26:48 -06:00
Nathan Sobo
0bce80b6f8
Fix remaining vim failures
2023-04-20 15:25:11 -06:00
Antonio Scandurra
137d9384b5
Initialize the active editor when vim mode is enabled
...
Instead of waiting for a focus event. This makes more tests pass.
2023-04-20 14:02:40 -06:00
Petros Amoiridis
7b4b1d6312
Use regex to make extraction bulletproof
2023-04-20 20:06:33 +03:00
Max Brunsfeld
abdfb5a451
collab 0.9.0
2023-04-20 09:52:32 -07:00
Max Brunsfeld
3a855184bc
v0.84.x dev
2023-04-20 09:52:07 -07:00
Joseph T. Lyons
65f7228fed
Merge pull request #2389 from zed-industries/save-panics-as-structured-data
...
Save panics as structured data
2023-04-20 12:51:00 -04:00
Max Brunsfeld
b414d43ee3
Merge pull request #2392 from zed-industries/eslint-multiple-language-server-adapters-rebased
...
Allow buffers to use multiple language servers
2023-04-20 09:40:23 -07:00
Petros Amoiridis
dcc804783c
Install jq if it's missing
2023-04-20 19:06:23 +03:00
Petros Amoiridis
460ea8e16c
Increase reliability and support multiple monitors
2023-04-20 19:06:23 +03:00
Petros Amoiridis
b11e239779
Make the script more reliable
2023-04-20 19:06:22 +03:00
Mikayla Maki
ad71020990
Merge pull request #2395 from zed-industries/remove-stable-hiding-copilot
...
Remove stable guard for copilot
2023-04-21 04:04:04 +12:00
Max Brunsfeld
21bb13d309
Fix comment formatting errors for rust 1.69
2023-04-20 09:03:42 -07:00
Max Brunsfeld
32c57bcd22
Store buffer's diagnostic sets in a smallvec
2023-04-20 08:58:41 -07:00
Max Brunsfeld
960a2bc589
Don't use ESLint for now
2023-04-20 08:58:41 -07:00
Max Brunsfeld
0ebe44bfd5
Handle multiple language servers for a given path in project diagnostics view
2023-04-20 08:58:41 -07:00
Max Brunsfeld
4dd917c123
Introduce a LanguageServerId wrapper type
...
Clarify the meaning of all the usizes in use in all of these
struct fields an method signatures.
2023-04-20 08:58:41 -07:00
Julia
c5f86bc6af
Avoid language servers fighting over diagnostics summaries
...
Previously each server would stomp all over the existing results
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-04-20 08:58:41 -07:00
Julia
9e2949e7ba
Refactor language server startup
...
Avoid parallel vecs
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-04-20 08:58:41 -07:00
Julia
c59204c5e6
Cleanup
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-04-20 08:58:41 -07:00
Julia
26abc824a9
Bump protocol version
2023-04-20 08:58:41 -07:00
Julia
df94aee758
Fix failing tests
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-04-20 08:58:41 -07:00
Julia
6156dbced0
Finish getting multiple diagnostics sources building and running
2023-04-20 08:58:41 -07:00
Julia
bb4de47b15
Start getting diagnostics sets to work with multiple servers
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-20 08:58:41 -07:00
Julia
2a5c0fa5f8
Get ESLint to launch and provide diagnostics
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-04-20 08:58:41 -07:00
Julia
6e68ff5a50
Get it to build with multiple adapters per language! 🎉
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-04-20 08:58:41 -07:00
Julia
ba7233f265
Incomplete refactor to allow for multiple adapters per language
2023-04-20 08:58:39 -07:00
Mikayla Maki
c1daf0fc36
Fix format
2023-04-20 08:54:44 -07:00
Mikayla Maki
ad8162fc9c
Make sign_in init conditional
2023-04-20 08:36:29 -07:00
Mikayla Maki
f5bbb41cc2
Remove import
2023-04-20 08:34:50 -07:00
Mikayla Maki
5c8b41dd54
Remove stable guard for copilot
2023-04-20 08:33:45 -07:00
Antonio Scandurra
0d5eea8169
Track active window id in test platform
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-20 17:22:11 +02:00
Antonio Scandurra
d9bb37c649
Add WindowContext::update_default_global
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-20 17:13:13 +02:00
Antonio Scandurra
1d487e19f9
Fix editor tests
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-20 16:15:14 +02:00
Antonio Scandurra
c52b6328b7
Merge branch 'main' into window_context_2
2023-04-20 16:01:47 +02:00
Antonio Scandurra
e282c7ad45
Finish converting all the pickers to the new API
2023-04-20 15:26:05 +02:00
Petros Amoiridis
21e39e7523
Merge pull request #2394 from zed-industries/petros/z-804-change-default-settings-for-json-to-2
...
Set default tab_size for JSON to 2 and apply new formatting
2023-04-20 14:45:52 +03:00
Antonio Scandurra
370875b1d4
Merge pull request #2393 from zed-industries/relay-change-events-to-copilot
...
Relay buffer change events to Copilot language server
2023-04-20 13:34:42 +02:00
Petros Amoiridis
eca93c124a
Apply the tab_size change to keymaps and settings
2023-04-20 14:08:30 +03:00
Petros Amoiridis
bed76462e2
Define tab_size equal to 2 in default settings
2023-04-20 14:06:43 +03:00
Antonio Scandurra
df71a9cfae
Move buffer change reporting to a background task
2023-04-20 11:59:05 +02:00
Antonio Scandurra
4151bd39da
Add buffer management test to Copilot
2023-04-20 10:51:50 +02:00
Antonio Scandurra
4d207981ae
Notify LSP when Copilot suggestions are accepted/rejected
2023-04-20 10:15:31 +02:00
Antonio Scandurra
5d57167302
Make it easier to access a running/authenticated copilot server
2023-04-20 10:12:10 +02:00
Antonio Scandurra
4c3d6c854a
Send editor information to copilot
2023-04-20 09:34:20 +02:00
Antonio Scandurra
b9a7b70e52
Register unknown buffer on the fly if completions are requested for it
2023-04-20 09:34:20 +02:00
Antonio Scandurra
34bcf6f072
Reopen file in Copilot language server when language or URI changes
2023-04-20 09:34:20 +02:00
Antonio Scandurra
672cf6b8c7
Relay buffer change events to Copilot
2023-04-20 09:34:20 +02:00
Nathan Sobo
d70644618a
WIP: Make PickerDelegate a fully owned object instead of a view
...
This avoids issues with the parent view being on the stack when we want to
interact with the delegate from the picker. Still have several picker usages
to convert.
2023-04-19 22:05:29 -06:00
Mikayla Maki
ce8442a3d8
Fix underflow potential
2023-04-19 17:42:19 -07:00
Mikayla Maki
dd73233973
Merge pull request #2386 from zed-industries/copilot-shipping
...
Get copilot ready to ship
2023-04-20 12:38:27 +12:00
Mikayla Maki
26ab774b7f
Removed debounce on suggestion cycling code
2023-04-19 17:34:09 -07:00
Mikayla Maki
f16b96cafc
add copilot menu
2023-04-19 17:27:44 -07:00
Mikayla Maki
9b8a3e4de5
Fixed panic in new cycling code
...
Made cycling fire without debounce
2023-04-19 16:50:31 -07:00
Mikayla Maki
2882e0fa5b
Remove new CTA in copilot sign in UI
...
Add a trim_end to copilot suggestions
2023-04-19 16:39:55 -07:00
Mikayla Maki
745e5e3a09
Add italic styles to copilot suggestions
2023-04-19 15:23:19 -07:00
Mikayla Maki
70ff4ca48f
WIP: lower our usage of the copilot API by seperating out the cycling completion
...
Restore copilot setting visibility
co-authored-by: antonio <antonio@zed.dev >
2023-04-19 15:23:17 -07:00
Mikayla Maki
ea1c3fa7a0
Only fire completion cycling requests if specifically asked for by the user
2023-04-19 15:21:30 -07:00
Antonio Scandurra
8610f3acf3
Introduce a button to disable copilot integration
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-19 20:25:59 +02:00
Joseph Lyons
0326a45a91
Give closure parameter a name
2023-04-19 14:21:53 -04:00
Antonio Scandurra
54a78d7024
Clarify Copilot context menu
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-19 20:18:06 +02:00
Antonio Scandurra
4a9989fe38
Clear all suggestions from Editor when disabling Copilot
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-19 20:10:57 +02:00
Antonio Scandurra
1fd07b6fcf
Clarify copilot settings
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-19 20:07:05 +02:00
Petros Amoiridis
699b2060b3
Merge pull request #2390 from zed-industries/petros/z-66-command-to-add-a-new-line-on-the
...
Add newline above and improve newline below
2023-04-19 21:02:55 +03:00
Petros Amoiridis
b3b8f8532d
Assert the editor and unmarked texts are the same
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-04-19 20:52:01 +03:00
Petros Amoiridis
f9c60b98c0
Add newline above and improve newline below
...
Add a new action for inserting a new line above the current line. @ForLoveOfCats also helped fix a bug among other things. When two collaborators had their cursors at the end of a line, and one collaborator performed a newline below action, the second collaborator's cursor would be dragged to the new line. This is also fixing that.
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-04-19 19:57:23 +03:00
Joseph Lyons
27a6bacab8
Save panics as structured data
2023-04-19 08:31:47 -04:00
Nathan Sobo
5514349b6b
Add Component elements
2023-04-18 22:49:06 -06:00
Max Brunsfeld
c5e56a5e45
Fail the randomized test build after reporting the error to zed.dev
2023-04-18 18:41:33 -07:00
Max Brunsfeld
5934e882b8
Merge pull request #2379 from zed-industries/shebang
...
Select language based on a file's first content line in addition to its path
2023-04-18 17:31:19 -07:00
Max Brunsfeld
ad9fe79cf2
Merge pull request #2388 from zed-industries/cmd-o-new-window
...
When opening projects, only reuse the current window if it is empty
2023-04-18 17:31:08 -07:00
Max Brunsfeld
7cc868bc8c
When opening projects, only reuse the current window if it is empty
2023-04-18 17:05:26 -07:00
Max Brunsfeld
44d26b69ae
Merge pull request #2387 from zed-industries/panic-in-set-selections-from-remote
...
Fix 'invalid insertion' panic when following
2023-04-18 16:43:47 -07:00
Max Brunsfeld
bd7d50f339
Fix 'invalid insertion' panic when following
...
Wait for the necessary buffer operations to arrive before attempting to
set selections and scroll top.
2023-04-18 16:13:18 -07:00
Nate Butler
a8b3826955
Merge pull request #2384 from zed-industries/update-copilot-styles
...
Update copilot styles
2023-04-18 15:17:10 -04:00
Julia
4c086a4836
Merge pull request #2385 from zed-industries/rerender-breadcrumbs-on-focus-change
...
Re-render toolbar items when updating their knowledge of pane focus
2023-04-18 15:13:53 -04:00
Julia
721baf5746
Re-render toolbar items when updating their knowledge of pane focus
2023-04-18 14:56:39 -04:00
Nate Butler
957ab65422
Mix neutral and blue to make a predictive color that is unique
2023-04-18 14:47:52 -04:00
Joseph T. Lyons
614a9c8977
Merge pull request #2377 from zed-industries/add-tab-tooltips
...
Add tab tooltips
2023-04-18 14:37:38 -04:00
Nate Butler
ae0647c3a9
Update predictive color
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-04-18 14:29:08 -04:00
Joseph Lyons
304eddbbe4
Remove unnecessary lifetimes from tab_description
2023-04-18 14:15:56 -04:00
Joseph Lyons
9afd804062
Remove unnecessary lifetimes from tab_tooltip_text
2023-04-18 14:03:02 -04:00
Antonio Scandurra
eee39b4c5c
Don't capture Workspace handle in defer when rendering Dock
...
GPUI already provides a mutable reference to the `Workspace` in the
`defer` callback.
2023-04-18 17:41:40 +02:00
Antonio Scandurra
136e599051
Merge branch 'main' into window_context_2
2023-04-18 17:29:37 +02:00
Antonio Scandurra
bcba11ba82
Reflect new behavior in test now that we don't replace windows anymore
2023-04-18 17:27:05 +02:00
Antonio Scandurra
d03c431f9a
Fix warnings/errors now that AsyncAppContext::update returns Result
2023-04-18 14:58:57 +02:00
Antonio Scandurra
31e6bb4fc1
Return Result from AsyncAppContext::update_view
2023-04-18 12:03:53 +02:00
Antonio Scandurra
1b477c9e38
Merge pull request #2383 from zed-industries/show-copilot-more-often
...
Clean up completion tasks, even if they fail or return no results
2023-04-18 11:16:47 +02:00
Antonio Scandurra
d26d0ac56f
Clean up completion tasks, even if they fail or return no results
...
This fixes a bug where leaving the completion task in `completion_tasks`
could cause the Copilot suggestion to not be shown due to the LSP not
successfully return a completion.
2023-04-18 11:03:17 +02:00
Antonio Scandurra
75d6b6360f
Add failing test to demonstrate Copilot not showing enough suggestions
2023-04-18 10:24:20 +02:00
Max Brunsfeld
8f25b98e6f
Print the final minimized test plan before sending it to zed.dev
2023-04-17 16:35:54 -07:00
Max Brunsfeld
695973d117
Use Node 18 on CI, for fetch API
2023-04-17 16:22:30 -07:00
Max Brunsfeld
516964280b
Merge pull request #2376 from zed-industries/randomized-tests-runner
...
Add an Actions workflow that repeatedly runs the randomized integration tests
2023-04-17 15:45:45 -07:00
Max Brunsfeld
485c56e3bd
Don't run randomized tests on pushes to main
2023-04-17 15:43:12 -07:00
Max Brunsfeld
837866f962
Consolidate logic for running randomized tests in scripts
2023-04-17 15:37:11 -07:00
Julia
4adc92b8e5
Merge pull request #2382 from zed-industries/dont-have-contacts-popover-affect-share-unshare-button
...
Don't have contacts popover affect appearance of Share/Unshare button
2023-04-17 14:18:39 -04:00
Julia
14ef0edd7f
Don't have contacts popover affect appearance of Share/Unshare button
2023-04-17 14:13:28 -04:00
Max Brunsfeld
233cd80f63
Merge pull request #2381 from zed-industries/fix-buffer-latency
...
Send buffer operations in batches to reduce latency
2023-04-17 10:59:51 -07:00
Max Brunsfeld
5d73e646d8
Delete pull_request_template.md
2023-04-17 10:23:57 -07:00
Antonio Scandurra
1f284408a9
Send buffer operations in batches to reduce latency
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-04-17 10:22:13 -07:00
Julia
f5a2534c1b
Merge pull request #2380 from zed-industries/show-followers-full-color
...
Unconditionally display followers in full color
2023-04-17 13:16:19 -04:00
Julia
61f4f8aaeb
Unconditionally display followers in full color
2023-04-17 13:10:40 -04:00
Antonio Scandurra
493a418c91
WIP
2023-04-17 18:52:48 +02:00
Antonio Scandurra
38ab6b123f
Make production code compile again
2023-04-17 12:33:33 +02:00
Antonio Scandurra
bed94455b9
Avoid calling focus_in when creating window
...
This is redundant because when creating a window we will receive
an activation event if the window was effectively focused. And if
it wasn't, we shouldn't call `focus_in`.
2023-04-17 11:57:51 +02:00
Max Brunsfeld
1dcd4717b1
Select language based on a file's first content line in addition to its path
2023-04-16 12:28:27 -07:00
Joseph Lyons
ebe57254e0
Add tab tooltips
2023-04-15 06:46:14 -04:00
Max Brunsfeld
3569c61784
Minimize randomized test failures before reporting issues
2023-04-14 17:51:24 -07:00
Max Brunsfeld
5c3da91e15
Report randomized test failures to zed.dev, to create issues in linear
2023-04-14 15:45:01 -07:00
Max Brunsfeld
c329546570
Extract randomized test CI process into a script
2023-04-14 14:25:55 -07:00
Max Brunsfeld
253411bfd0
Start work randomized test runner GH action workflow
2023-04-14 13:54:57 -07:00
Max Brunsfeld
e655a6c767
Merge pull request #2375 from zed-industries/worktree-scan-id-fix
...
Always bump worktree's scan_id when refreshing an entry
2023-04-14 09:53:40 -07:00
Antonio Scandurra
f09e21aa93
WIP: force using (at least) a window context to update views
2023-04-14 17:08:13 +02:00
Antonio Scandurra
a820862165
Take WindowContext in workspace::ItemHandle methods
2023-04-14 16:36:23 +02:00
Antonio Scandurra
a8e75a9b55
Remove weak handle from EditorElement to Editor
2023-04-14 14:29:03 +02:00
Antonio Scandurra
060242a28a
Take a WindowContext in StatusItemViewHandle::set_active_pane_item
2023-04-14 14:26:20 +02:00
Antonio Scandurra
2652f65bee
Fix handle_window_activation_effect updating the wrong view
2023-04-14 12:33:13 +02:00
Antonio Scandurra
98dce89379
Pass WindowContext to ViewHandle::is_focused
2023-04-14 12:12:08 +02:00
Antonio Scandurra
74ca223114
Fix formatting for the entire workspace
2023-04-14 12:08:33 +02:00
Antonio Scandurra
33bc47dbe2
Merge branch 'main' into window_context_2
2023-04-14 12:07:09 +02:00
Antonio Scandurra
183b9ef809
Make full-screen and window bounds callbacks take a WindowContext
2023-04-14 11:56:31 +02:00
Antonio Scandurra
7394bf1cdc
Fix most of the warnings
2023-04-14 10:51:53 +02:00
Antonio Scandurra
5666e8301e
Log an error when a scene fails to build
2023-04-14 10:32:56 +02:00
Antonio Scandurra
9ef79735dc
Move more window-specific methods from AppContext to WindowContext
2023-04-14 10:29:35 +02:00
Antonio Scandurra
c62357db02
Fix window activation
2023-04-14 08:24:01 +02:00
Max Brunsfeld
5ea49b3ae3
Fix inconsistent worktree state when renaming entries while scanning
2023-04-13 22:34:34 -07:00
Max Brunsfeld
bb1cfd51b8
Add randomized test for mutating worktree during initial scan
2023-04-13 22:34:03 -07:00
Max Brunsfeld
debb694d97
Always bump scan_id when refreshing an entry
...
The scan_id needs to be bumped even if a scan is already in progress,
so that worktree updates can detect that entries have changed. This
means that the worktree's completed_scan_id may increase by more than
one at the end of a scan.
2023-04-13 16:51:11 -07:00
Max Brunsfeld
c13914bda1
Merge pull request #2371 from zed-industries/refresh-entry-delay
...
Restructure background scanner to handle refresh requests even while scanning directories
2023-04-13 12:44:04 -07:00
Joseph T. Lyons
6a75e884c0
Merge pull request #2374 from zed-industries/add-vim-mode-metric
...
Add vim mode metric
2023-04-13 13:52:31 -04:00
Joseph Lyons
5f0bf5929f
Add vim mode metric
2023-04-13 13:46:22 -04:00
Antonio Scandurra
84d2605ccf
Avoid passing cx when emitting from CallbackCollection
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-13 16:53:44 +02:00
Antonio Scandurra
ff774786bf
Reimplement AppContext::handle_focus_effect
2023-04-13 16:21:39 +02:00
Antonio Scandurra
4900e04ff3
Fix window refreshing
2023-04-13 12:19:11 +02:00
Antonio Scandurra
0269a8699b
Start removing some warnings
2023-04-13 12:04:37 +02:00
Antonio Scandurra
702c4ce403
Uncomment List tests and fix related problems in WindowContext
2023-04-13 12:01:18 +02:00
Antonio Scandurra
f4daeb4778
Merge pull request #2373 from zed-industries/fix-copilot-panic
...
Avoid interpolating Copilot suggestion if cursor excerpt differs
2023-04-13 10:48:57 +02:00
Antonio Scandurra
495c7acadf
Avoid interpolating Copilot suggestion if cursor excerpt differs
2023-04-13 10:44:08 +02:00
Max Brunsfeld
5ca603dbeb
Don't process gitignore updates after the initial scan
2023-04-12 18:17:29 -07:00
Max Brunsfeld
3d14bfd90c
Prioritize path refresh requests over gitignore status updates
2023-04-12 18:08:00 -07:00
Max Brunsfeld
2d97387f49
Restructure background scanner to handle refresh requests even while scanning
2023-04-12 16:29:51 -07:00
Nathan Sobo
b89c4e06be
WIP: Compiling, many warnings, haven't tested
2023-04-12 12:54:24 -06:00
Nathan Sobo
25ad635577
WIP
2023-04-12 12:38:26 -06:00
Nathan Sobo
4cb13fb39c
WIP
2023-04-12 12:22:26 -06:00
Nathan Sobo
a25f962185
WIP
2023-04-12 12:13:35 -06:00
Max Brunsfeld
a85c2d71ad
collab 0.8.3
2023-04-12 11:11:32 -07:00
Joseph Lyons
afbd275f4f
v0.83.x dev
2023-04-12 13:31:39 -04:00
Joseph T. Lyons
ee238a300e
Merge pull request #2368 from zed-industries/Improve-tab-closing-experience
...
Add tab context menu
2023-04-12 13:08:46 -04:00
Joseph T. Lyons
b39b3541e9
Merge pull request #2370 from zed-industries/flip-screen-sharing-icon-states
...
Flip screen sharing icon states
2023-04-12 12:50:00 -04:00
Nathan Sobo
40896352ff
wip
2023-04-12 10:28:53 -06:00
Nathan Sobo
868301bedb
WIP
2023-04-12 10:07:17 -06:00
Antonio Scandurra
83070a19c4
WIP
2023-04-12 15:55:43 +02:00
Nathan Sobo
b54f08db77
WIP
2023-04-12 06:51:03 -06:00
Antonio Scandurra
6d8635fa29
Merge pull request #2349 from zed-industries/randomized-tests-operation-script
...
Restructure randomized integration test to allow editing and replaying a plan, fix discovered bugs
2023-04-12 11:45:47 +02:00
Antonio Scandurra
12a286ac50
Forget buffered operations when resyncing with the host
...
Previously, we could end up with a situation where the host did not
see an operation but a guest that didn't have that buffer open would. When
such guest would finally open the buffer, they would apply the operation
without however sending it to the host. The guest wouldn't bother resyncing
it because it wasn't part of its open buffers.
2023-04-12 10:39:01 +02:00
Nathan Sobo
d9e4136b02
WIP
2023-04-11 21:56:37 -06:00
Nathan Sobo
e6cc132b19
WIP
2023-04-11 18:48:00 -06:00
Nathan Sobo
e115baa60c
WIP
2023-04-11 18:21:56 -06:00
Joseph Lyons
0b52308c99
Represent dirty state in item-testing code
2023-04-11 16:27:12 -04:00
Joseph Lyons
c39764487c
Construct context menu in a more clear way
2023-04-11 15:46:52 -04:00
Max Brunsfeld
61d048cb25
Don't wait for host's reply before broadcasting buffer updates to guests
2023-04-11 12:37:08 -07:00
Joseph Lyons
ae930bde87
Flip screen sharing icon states
2023-04-11 15:30:44 -04:00
Max Brunsfeld
727afae4ff
Fix unit tests after fixing gpui model drop semantics
...
co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-11 10:58:01 -07:00
Nate Butler
209e9a59c5
Merge pull request #2369 from zed-industries/nate/update-ayu-theme
...
Update `Ayu` Theme Family
2023-04-11 13:05:25 -04:00
Nate Butler
7ba094e10e
add license_checksum
2023-04-11 12:56:18 -04:00
Nate Butler
20ec9f6daf
Add meta fields to ayu
2023-04-11 12:37:20 -04:00
Nate Butler
65c2fb1cc6
Fix paths after publishing
2023-04-11 12:25:02 -04:00
Nate Butler
de60657d53
Ignore the target folder
2023-04-11 12:23:54 -04:00
Nate Butler
975f5d5fa8
Format
2023-04-11 12:23:21 -04:00
Nate Butler
527f0310e2
Update + publish the Ayu theme
2023-04-11 12:22:49 -04:00
Antonio Scandurra
42b10044fc
Fix running client crate tests
2023-04-11 17:43:05 +02:00
Antonio Scandurra
5eb1719ab8
Re-send worktree if reconnecting while initial scan isn't finished yet
...
Previously, if the client was disconnected while the initial worktree
state was being sent, it would not see the remaining state after reconnecting.
This was due to `scan_id` and `completed_scan_id` both being initialized to
`0`, so the client would ask for updates since `0` and get nothing.
This commit changes the worktree to initialize `scan_id` to `1` and
`completed_scan_id` to `0`, so that we get the full worktree again on reconnect.
2023-04-11 17:15:43 +02:00
Antonio Scandurra
172441ab72
Cancel pending calls when participant fails to reconnect
...
Previously, we would only cancel pending calls when the room became
empty.
2023-04-11 16:33:08 +02:00
Antonio Scandurra
5e37c893c2
Ensure project is still alive by the time remote LSP request starts
2023-04-11 15:14:32 +02:00
Antonio Scandurra
5898600239
Use LspCommand to handle code actions
2023-04-11 15:12:58 +02:00
Antonio Scandurra
651a83977e
🔥
2023-04-11 14:53:08 +02:00
Antonio Scandurra
ac532cb6fa
Use LspCommand to handle completions
2023-04-11 14:52:07 +02:00
Antonio Scandurra
9e6d865882
Prevent already dropped model from being upgraded during release
2023-04-11 10:43:05 +02:00
Antonio Scandurra
6ba5e06247
Stop waiting for buffers when releasing a remote project
2023-04-11 10:42:43 +02:00
Antonio Scandurra
643381ce0c
Make UpdateDiffBase a Foreground message to prevent reordering
2023-04-11 08:50:26 +02:00
Joseph Lyons
67cb046298
Add tab context menu
2023-04-11 00:03:47 -04:00
Max Brunsfeld
abfbba68f0
Improve randomized test assertion message when diff base is wrong
2023-04-10 18:28:34 -07:00
Max Brunsfeld
25e3c4e586
Fix leak when project is unshared while LSP handler waits for edits
2023-04-10 17:03:58 -07:00
Nathan Sobo
3de8fe0f87
WIP
2023-04-10 17:27:47 -06:00
Max Brunsfeld
e853e77d59
Upgrade postage for oneshot channel drop fix
...
Previously, dropping a oneshot sender didn't wake the receiver.
2023-04-10 16:03:49 -07:00
Nathan Sobo
6638407ff9
WIP: Everything shredded
2023-04-10 16:10:32 -06:00
Julia
0e4de87e0e
Merge pull request #2367 from zed-industries/log-github-api-response-for-deserialize-error
...
In the case of Github release deserialize error, log response text
2023-04-10 17:04:59 -04:00
Julia
189784f5fd
In the case of Github release deserialize error, log response text
...
Co-Authored-By: Joseph Lyons <joseph@zed.dev >
2023-04-10 16:45:15 -04:00
Max Brunsfeld
e79815622c
Preserve ordering between UpdateProject and CreateBufferForPeer messages
...
Previously, because UpdateProject messages were sent in a separately-
spawned task, they could be sent after CreateBufferForPeer messages that
were intended to be sent after them.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-10 12:54:25 -07:00
Antonio Scandurra
9761febf82
Avoid broadcasting SaveBuffer in response to a client's save request
...
The host will send a `SaveBuffer` message anyway and this prevents re-querying
the database, which could cause two `BufferSaved` messages to race and, as a
result, cause guest to apply them in the wrong order.
2023-04-10 10:02:13 +02:00
Antonio Scandurra
3a82c04248
Improve assertion message when buffer state diverges
2023-04-10 10:01:44 +02:00
Antonio Scandurra
016343e65d
Merge branch 'main' into randomized-tests-operation-script
2023-04-10 08:45:22 +02:00
Antonio Scandurra
7f73ebdab5
Apply BufferReloaded message to incomplete remote buffers
2023-04-10 08:41:31 +02:00
Antonio Scandurra
116d4f20fa
Merge pull request #2366 from zed-industries/avoid-unwrapping-on-try-send
...
Don't panic if worktree was dropped before sending path changes
2023-04-10 08:36:53 +02:00
Antonio Scandurra
372e31d54f
Don't panic if worktree was dropped before sending path changes
...
In `refresh_entry`, we send a message to the `self.path_changes_tx` channel
to notify the background thread that a path has changed. However, given that
`refresh_entry` uses `spawn_weak`, the worktree could get dropped before sending
the message, which could cause a panic.
This commit changes the code to return an error instead of panicking.
2023-04-10 08:16:08 +02:00
Nathan Sobo
7536645eea
WIP
2023-04-08 08:01:05 -06:00
Nathan Sobo
9d23a98157
WIP
2023-04-08 06:43:39 -06:00
Max Brunsfeld
acbf9b55d7
Halt UpdateBuffer messages until sync if one errors
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-07 17:31:52 -07:00
Max Brunsfeld
e50c48852a
Wait for host to acknowledge buffer updates before sending them to other guests
2023-04-07 16:27:48 -07:00
Max Brunsfeld
f519f32ec2
Fixed removal of closed projects in randomized test
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-07 12:24:59 -07:00
Joseph Lyons
035189a2a1
Put file location details of panic on separate line
2023-04-07 14:32:14 -04:00
Nathan Sobo
676dbdc57b
Merge pull request #2365 from zed-industries/dont_export_gpui_platform_module
...
Don't export platform::* from gpui
2023-04-07 12:12:05 -06:00
Nathan Sobo
2186de38ab
Merge AppContext impl blocks
2023-04-07 11:54:08 -06:00
Nathan Sobo
2615a11f7c
Don't export platform::* from gpui
...
I'd like to avoid cluttering the top-level namespace with all the platform-
specific types.
2023-04-07 11:45:53 -06:00
Joseph T. Lyons
f450692e77
Merge pull request #2364 from zed-industries/put-backtrace-on-a-newline-when-reporting-panics
...
Put backtrace on a new line when reporting panics
2023-04-07 12:46:53 -04:00
Joseph Lyons
9cf3481fc7
Put backtrace on a new line when reporting panics
2023-04-07 12:12:18 -04:00
Joseph T. Lyons
c58601ab8d
Merge pull request #2363 from zed-industries/add-copy-path-commands
...
Update copy path commands
2023-04-07 12:09:39 -04:00
Joseph Lyons
5e55eb279c
Update copy path commands
2023-04-07 02:36:56 -04:00
Nathan Sobo
dad403f483
Merge pull request #2362 from zed-industries/eliminate-mutable-app-context
...
Merge MutableAppContext into AppContext
2023-04-06 16:19:47 -06:00
Nathan Sobo
95eb918b4c
Fix broken test due to trimmed trailing whitespace during formatting
2023-04-06 16:10:39 -06:00
Nathan Sobo
8136d8a8a6
Fix formatting
2023-04-06 15:54:44 -06:00
Nathan Sobo
de9bf6dfbd
Merge MutableAppContext into AppContext
...
There may have been a good reason for the difference at some point, or I was
still learning Rust. But now it's just &mut AppContext vs &AppContext.
2023-04-06 15:49:03 -06:00
Max Brunsfeld
aa7918c4b5
Fix handling of redundant buffer creation messages on guests
...
Check if the buffer already exists *before* overwriting it.
Ignore redundant registrations on remote projects.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-06 12:17:25 -07:00
Max Brunsfeld
22a6a243bc
Move project assertions into main assertion function
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-04-06 11:38:42 -07:00
Joseph T. Lyons
dd00966cc6
Merge pull request #2361 from zed-industries/add-close-items-to-left-and-right
...
Add close items to left and right
2023-04-06 13:06:25 -04:00
Antonio Scandurra
ef04dc14cc
Update file on incomplete buffer instead of waiting for it to be opened
...
This ensures that two successive file updates coming from the host are
not applied in reverse order.
2023-04-06 17:48:44 +02:00
Julia
4b39df4a6b
Merge pull request #2304 from zed-industries/bump-diff-width
...
Increase git diff gutter width slightly
2023-04-06 10:58:55 -04:00
Antonio Scandurra
8020ea783f
Wait to see guest's buffer version before converting completion anchor
2023-04-06 16:23:10 +02:00
Antonio Scandurra
4a61e2dfa4
Save server operations that were in the middle of being applied
...
Previously, if the test panicked before it had a chance to fully
apply an operation, it would end up not being saved in the plan.
With this commit we will mark the operation as applied before we
start processing it, and mark it as not applied if, once we're done,
we've found out that it couldn't be applied. This is consistent with
what we do for client operations.
2023-04-06 16:02:16 +02:00
Antonio Scandurra
f995d07542
Return error if subscribing to an entity that was already subscribed to
2023-04-06 14:42:19 +02:00
Antonio Scandurra
d7f56d6126
Forget which buffers were shared when host reconnects
...
This fixes a bug where the host would momentarily disconnect and the guest
would close and reopen the project. This would cause the host to not observe
the guest closing the project. When the guest tried to open one of the
buffers opened prior to closing the project, the host would not send them the
buffer state because it would still remember that the buffer was shared.
The `shared_buffers` map is now cleared when the host reconnects and will slowly
get re-filled as guests issue `SynchronizeBuffers` requests.
2023-04-06 13:49:09 +02:00
Joseph Lyons
4883ec2201
Add close items to left and right
2023-04-06 03:33:38 -04:00
Max Brunsfeld
bf3b8adf35
Avoid async fs call before checking if operation is applicable
...
This way, the executor isn't influenced by operations that aren't applicable.
2023-04-05 18:11:33 -07:00
Max Brunsfeld
1064b14779
Don't use TestPlan's rng in fake LSP handlers
...
These should use the test context's rng, so that they behave the same whether
a pre-recorded plan was used, or the plan is being generated.
2023-04-05 17:50:04 -07:00
Max Brunsfeld
2d63ed3ca4
Merge branch 'main' into randomized-tests-operation-script
2023-04-05 17:10:20 -07:00
Nathan Sobo
e5861d6c35
Fix typos in EULA
2023-04-05 18:02:35 -06:00
Max Brunsfeld
bda7086220
Clear guest's shared buffers if they rejoin project after leaving while host was disconnected
2023-04-05 16:53:36 -07:00
Max Brunsfeld
8e68c7f808
Do include operations in serialized test plan if they cause a client to hang
2023-04-05 16:52:39 -07:00
Max Brunsfeld
43a94cda5f
Don't skip worktree updates if unknown entries are removed
...
When rejoining a project, if entries were both created and deleted since
joining the project, the guest will receive those entries ids in as
removed.
2023-04-05 15:36:01 -07:00
Max Brunsfeld
661fba8640
Run executor until parked at end of each iteration of random collaboration test
...
Without this, the server doesn't get dropped at the end of the test, and we eventually run
out of file handles due to sqlite connections being retained.
2023-04-05 15:05:32 -07:00
Max Brunsfeld
781d66f628
Omit operations for non-existent users from serialized test plan
2023-04-05 15:04:27 -07:00
Julia
43b6e7a944
Merge pull request #2360 from zed-industries/maybe-fix-lock-screen-crash
...
Hesitant possible fix for lock screen crash
2023-04-05 14:10:40 -04:00
Julia
6e3bf7fed4
Hesitant possible fix for lock screen crash
...
This may cause issues in this situations but as I cannot repro this I'm
making the call to try something and see how it plays out
2023-04-05 14:01:54 -04:00
Joseph Lyons
e4bb5c296c
v0.82.x dev
2023-04-05 13:00:52 -04:00
Joseph T. Lyons
3b6c975658
Merge pull request #2357 from zed-industries/update-eula
...
Update EULA
2023-04-05 12:57:34 -04:00
Joseph Lyons
5becdbdea8
Fix spacing in EULA
2023-04-05 12:45:48 -04:00
Julia
af826f5efd
Merge pull request #2359 from zed-industries/prefer-right-statusbar-items
...
Prioritize displaying right statusbar items overtop left items if needed
2023-04-05 12:16:30 -04:00
Julia
77bb52f72c
Prioritize displaying right statusbar items overtop left items if needed
2023-04-05 12:08:52 -04:00
Mikayla Maki
64428bac15
Merge pull request #2358 from zed-industries/more-copilot-fixes
...
Invalidate copilot suggestion on backspaces
2023-04-05 08:59:30 -07:00
Mikayla Maki
78742d5615
Add additional case to range invalidation test
...
co-authored-by: antonio <antonio@zed.dev >
2023-04-05 08:52:56 -07:00
Mikayla Maki
b585470518
Invalidate copilot suggestion on backspaces
...
Restore an observation on initialization
co-authored-by: antonio <antonio@zed.dev >
2023-04-05 08:48:39 -07:00
Antonio Scandurra
e2c690cece
Merge pull request #2356 from zed-industries/copilot-on-preview
...
Disable Copilot entirely for stable releases
2023-04-05 16:20:53 +02:00
Nathan Sobo
0d0f6b5a05
Update EULA
2023-04-05 08:18:51 -06:00
Antonio Scandurra
7ba46a0630
Honor ZED_RELEASE_CHANNEL environment variable only in development
...
We don't want people to be able to override the release channel in
production.
2023-04-05 15:55:44 +02:00
Antonio Scandurra
15b26e10d4
Disable Copilot entirely for stable releases
...
This lets us remove the logic for detecting whether a user is a staff
member.
2023-04-05 15:49:59 +02:00
Antonio Scandurra
781d065d0b
Merge pull request #2355 from zed-industries/refine-copilot
...
Iterate some more on Copilot
2023-04-05 14:21:18 +02:00
Antonio Scandurra
03a4c9d6d5
Use the cursor variable instead of selection.start
2023-04-05 14:15:58 +02:00
Antonio Scandurra
dd416cdfd2
📝
2023-04-05 14:14:43 +02:00
Antonio Scandurra
f920e02d96
Indent instead of accepting suggestion if cursor is in leading whitespace
2023-04-05 14:09:09 +02:00
Antonio Scandurra
908a7cf47e
💄
2023-04-05 13:59:19 +02:00
Antonio Scandurra
dcd8bdfc88
Update visible suggestion if edit occurs outside the current editor
2023-04-05 11:06:14 +02:00
Antonio Scandurra
6e821eea4b
Prevent tab from accepting a copilot suggestion when it isn't visible
2023-04-05 10:31:11 +02:00
Antonio Scandurra
661be7ba51
Refresh copilot suggestions when accepting a completion
2023-04-05 10:28:00 +02:00
Antonio Scandurra
7a7dc95611
Refresh copilot suggestions when undoing/redoing
2023-04-05 10:27:19 +02:00
Antonio Scandurra
399451b676
Capture copilot behavior in a editor unit test
2023-04-05 10:26:43 +02:00
Max Brunsfeld
1159f5517b
Avoid applying outdated UpdateProject methods after rejoining a room
2023-04-04 21:49:37 -07:00
Max Brunsfeld
1ccf174388
Avoid applying outdated UpdateProject messages
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2023-04-04 18:34:39 -07:00
Antonio Scandurra
808ddc26e7
Merge pull request #2353 from zed-industries/more-intuitive-autocomplete-with-copilot
...
Match VS Code's behavior when deciding whether to show Copilot suggestion
2023-04-04 20:03:07 +02:00
Antonio Scandurra
65fd605b82
Revert "Return the previous suggestion when replacing it"
...
This reverts commit 971c88db80 .
2023-04-04 18:59:28 +02:00
Nate Butler
e7150d0b66
Merge pull request #2354 from zed-industries/nate/fix-embedded-highlight-in-ruby
...
Fix embedded highlight in ruby
2023-04-04 12:46:32 -04:00
Nate Butler
7ff97e50a7
Fix embedded highlight in ruby
2023-04-04 12:41:38 -04:00
Antonio Scandurra
b58ac815a8
Trigger copilot only on insertion and deletion
...
Also, avoid showing the suggestion if a completion is in progress to
avoid flickering.
2023-04-04 17:51:37 +02:00
Antonio Scandurra
971c88db80
Return the previous suggestion when replacing it
2023-04-04 17:14:52 +02:00
Antonio Scandurra
a2aad31cf1
Merge pull request #2352 from zed-industries/debounce-copilot
...
Debounce copilot completions
2023-04-04 16:52:59 +02:00
Antonio Scandurra
e970d84184
Debounce copilot completions
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-04-04 16:02:25 +02:00
Antonio Scandurra
5df5973262
Merge pull request #2351 from zed-industries/more-copilot-enhancements
...
Fix additional Copilot issues
2023-04-04 14:22:12 +02:00
Antonio Scandurra
60955fb8ee
Refresh active copilot suggestion when accepting completion
2023-04-04 11:15:14 +02:00
Antonio Scandurra
79d5bb45dc
Clear Copilot suggestions when it gets disabled from the settings
2023-04-04 10:45:56 +02:00
Antonio Scandurra
abf158a9e4
Merge pull request #2347 from zed-industries/disable-yaml-key-ordering
...
Disable key ordering diagnostic for YAML
2023-04-04 10:00:48 +02:00
Max Brunsfeld
bcf9b2f10d
Add missing random delays in FakeFs
2023-04-03 22:42:34 -07:00
Mikayla Maki
91d85987b9
Merge pull request #2350 from zed-industries/copilot-disable
...
Disable copilot unless the staff mode flag is flipped
2023-04-03 22:00:47 -07:00
Mikayla Maki
fa32a20c42
fixup! fixup! fixup! removed copilot from generated schema and command palette
2023-04-03 21:46:59 -07:00
Mikayla Maki
a1abe8d33c
fixup! fixup! removed copilot from generated schema and command palette
2023-04-03 21:46:30 -07:00
Mikayla Maki
ae6a671fea
fixup! removed copilot from generated schema and command palette
2023-04-03 21:45:18 -07:00
Mikayla Maki
47de4dcd32
removed copilot from generated schema and command palette
2023-04-03 21:38:26 -07:00
Mikayla Maki
6bfecd7f66
Refactor staff mode into a seperate crate and make copilot initialization wait for the staff mode flag to be flipped
2023-04-03 20:16:45 -07:00
Max Brunsfeld
b251e249a7
Check for consistency between clients every time the system quiesces
2023-04-03 19:11:37 -07:00
Max Brunsfeld
7b0a6c0dfa
Add an 'on_failure' attribute to gpui tests
...
This lets us perform a finalization step when a randomized test fails.
2023-04-03 18:16:08 -07:00
Max Brunsfeld
5ecc9606af
Use synchronous locks in FakeFs
...
This way, the state can be accessed without running the deterministic
executor.
2023-04-03 18:15:07 -07:00
Mikayla Maki
55297c1a26
Merge pull request #2348 from zed-industries/copilot-feedback
...
Fix issues from copilot feedback
2023-04-03 16:29:41 -07:00
Max Brunsfeld
f95732e981
Fix bug where guest would drop BufferSaved messages while opening the buffer
2023-04-03 16:23:44 -07:00
Mikayla Maki
1627cf7eae
Add standard copilot keybinding
2023-04-03 16:14:07 -07:00
Mikayla Maki
bab0e88b6f
Fix bug where copilot auth window will only be shown once
2023-04-03 16:01:04 -07:00
Max Brunsfeld
543301f949
Avoid repeatedly loading/saving the test plan for each iteration
2023-04-03 15:58:11 -07:00
Mikayla Maki
2e33f8b228
fixup! Remove per-file copilot enable/disable
2023-04-03 15:21:43 -07:00
Mikayla Maki
48d9c30b0e
Remove per-file copilot enable/disable
2023-04-03 15:15:42 -07:00
Mikayla Maki
0250898a2b
Enable copilot in all file types by default
2023-04-03 15:06:49 -07:00
Max Brunsfeld
c960277349
Merge branch 'main' into randomized-tests-operation-script
2023-04-03 13:09:25 -07:00
Antonio Scandurra
2c0a645f19
Provide workspace_folders capability when initializing LSP
...
This fixes the YAML language server which was erroring on startup
after adding the `did_change_watched_files` capability in #2258 .
2023-04-03 20:12:26 +02:00
Antonio Scandurra
588b2da40a
Disable key ordering diagnostic for YAML language server
2023-04-03 20:02:29 +02:00
Petros Amoiridis
69557655ee
Merge pull request #2346 from zed-industries/petros/z-360-dragging-file-from-tree-to-split-results
...
Fix dragging file from tree to split results in empty pane
2023-04-03 16:43:12 +03:00
Petros Amoiridis
5a397726d2
Do not drop the task
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-04-03 16:36:08 +03:00
Nathan Sobo
cdfe873802
Merge pull request #2343 from zed-industries/handles
...
Make typed handles wrappers around their untyped equivalents
2023-04-03 09:20:37 -04:00
Antonio Scandurra
0cb73b6579
Merge pull request #2345 from zed-industries/autocomplete-vs-copilot
...
Make autocompletion and copilot mutually exclusive
2023-04-03 14:37:02 +02:00
Antonio Scandurra
b88aa9af1d
Clear active copilot suggestion only if there is one
2023-04-03 14:32:41 +02:00
Antonio Scandurra
ec5309b543
Make autocompletion and copilot mutually exclusive
2023-04-03 14:15:21 +02:00
Antonio Scandurra
b6a9d90609
Move creation of GetCompletionsParams entirely to the background
2023-04-03 13:30:57 +02:00
Antonio Scandurra
0b9e609e2a
Merge pull request #2344 from zed-industries/copilot-collaboration
...
Fix Copilot errors when opening buffers that don't exist locally
2023-04-03 13:26:21 +02:00
Antonio Scandurra
b26d4f4f62
🔥
2023-04-03 13:18:16 +02:00
Antonio Scandurra
75ecf92ae4
Fix Copilot errors when opening buffers that don't exist locally
2023-04-03 12:28:32 +02:00
Nathan Sobo
138aa0492a
Add downcast_ref to AnyViewHandle
...
I use unsafe code to transmute an AnyViewHandle to a ViewHandle<T> when
the type matches. Because ViewHandle<T> is repr(transparent) to the
wrapped AnyViewHandle, this is safe.
2023-04-02 16:10:16 -06:00
Nathan Sobo
71cf6ec5ae
Use into_any instead of weird 'as' hack
2023-04-02 15:55:30 -06:00
Nathan Sobo
27258a0889
Remove From trait for AnyViewHandle in favor of into_any method
...
I think it's more explicit.
2023-04-02 15:50:42 -06:00
Nathan Sobo
aed8df96ff
Wrap AnyWeak handles with their typed counterparts
2023-04-02 15:42:03 -06:00
Nathan Sobo
82a713fd1d
Store AnyViewHandle inside ViewHandle and Deref to it
2023-04-02 14:59:55 -06:00
Julia
59fb4b3d29
Merge pull request #2342 from zed-industries/trust-npm-version-management
...
Trust NPM instead of managing dirs for different Node server versions
2023-03-31 17:21:16 -04:00
Julia
8c0db17634
Trust NPM instead of managing dirs for different Node server versions
2023-03-31 17:15:44 -04:00
Mikayla Maki
c19e6f8f0e
Merge pull request #2338 from zed-industries/more-copilot-bugs
...
More copilot bugs
2023-03-31 12:45:19 -07:00
Mikayla Maki
297fd5f985
Merge pull request #2340 from zed-industries/fix-json-lsp-remove
...
Fix bug where JSON LSP would be deleted on installation.
2023-03-31 12:41:28 -07:00
Mikayla Maki
dcaa355ad2
Switch from removing all directories in the container dir to removing the non-version dir
2023-03-31 12:36:23 -07:00
Julia
0ae298a86f
Merge pull request #2339 from zed-industries/revert
...
Revert "Merge pull request #2335 from zed-industries/dont-delete-json…
2023-03-31 15:33:12 -04:00
Julia
0f4f3bfbde
Revert "Merge pull request #2335 from zed-industries/dont-delete-json-server-after-downloading-it"
...
This reverts commit 516e77906e , reversing
changes made to 54582fd77f .
2023-03-31 15:31:50 -04:00
Mikayla Maki
57b5c1ee20
Fix crash on initiating copilot during collaboration. Copilot is now disabled when collaborating.
2023-03-31 12:28:58 -07:00
Mikayla Maki
f616e8bac9
Merge pull request #2336 from zed-industries/respect-languages-alias-in-settings-file
...
Add support for writing to the langauge_overrides alias in settings
2023-03-31 11:51:25 -07:00
Mikayla Maki
b6882f0cbf
Fix typo in copilot button
2023-03-31 11:50:31 -07:00
Mikayla Maki
e5a6b11d8f
Merge pull request #2334 from zed-industries/quiet-copilot-loggin
...
Add handlers for LogMessage and statusNotification to copilot LSP
2023-03-31 11:22:23 -07:00
Mikayla Maki
c1445fe015
Add support for the langauge_overrides alias in the settings file updating code
2023-03-31 11:20:46 -07:00
Mikayla Maki
bdce96b19a
Update copilot.rs
2023-03-31 11:16:52 -07:00
Julia
516e77906e
Merge pull request #2335 from zed-industries/dont-delete-json-server-after-downloading-it
...
Don't delete JSON language server directly after downloading it
2023-03-31 14:08:09 -04:00
Julia
0199ffed5f
Don't delete JSON language server directly after downloading it
...
This was accidentally added during the messy NodeRuntime/Copilot rebase
Co-Authored-By: Joseph Lyons <joseph@zed.dev >
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-03-31 14:01:04 -04:00
Mikayla Maki
f561e5ef2c
remove spare debug
2023-03-31 11:00:06 -07:00
Mikayla Maki
4865ea2efc
Add handlers for LogMessage and statusNotification to copilot LSP
2023-03-31 10:58:18 -07:00
Antonio Scandurra
54582fd77f
Merge pull request #2333 from zed-industries/copilot-improvements
...
Fix several Copilot bugs
2023-03-31 18:14:39 +02:00
Antonio Scandurra
b208d1a489
🎨
2023-03-31 18:10:10 +02:00
Antonio Scandurra
5f579a4287
Fix prefix/suffix calculation when determining copilot suggestion
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-03-31 18:05:07 +02:00
Antonio Scandurra
b588ba1435
Avoid auto-indenting when accepting copilot suggestion
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-03-31 17:17:35 +02:00
Antonio Scandurra
6e43e77c3f
Use copilot's Completion::{range,text} to determine suggestion
...
Previously, we were using display text, but this isn't always correct. Now,
we just attempt to determine what text Copilot wants to insert by finding
a prefix and suffix in the existing text with the suggested text.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-03-31 17:08:41 +02:00
Mikayla Maki
9b16277cf8
Merge pull request #2316 from zed-industries/copilot
...
🚨 WIP 🚨 Copilot
2023-03-30 18:27:14 -07:00
Mikayla Maki
713f5f604f
Fix leaked handle and failure to update language in context menu
2023-03-30 17:40:11 -07:00
Mikayla Maki
e38f52d595
Fix unrelated panics in tests
2023-03-30 17:19:29 -07:00
Mikayla Maki
c3188be4c1
cargofmt
2023-03-30 16:58:11 -07:00
Mikayla Maki
81411b9114
Merge branch 'main' into copilot
2023-03-30 16:57:18 -07:00
Mikayla Maki
c28d2c490b
Remove test modals
2023-03-30 16:52:55 -07:00
Mikayla Maki
afc9b832c8
Finish device code flow for copilot
2023-03-30 16:50:33 -07:00
Mikayla Maki
f5d4bcd934
Added erorr states and first-pass error handling to the copilot status bar item.
...
Added correct icons
Added a new 'Toast' action which allows other crates to easily pop toasts with an optional click action
2023-03-30 14:10:57 -07:00
Julia
3cfe61a4f4
Merge pull request #2332 from zed-industries/per-server-code-action-kinds
...
Allow each language adapter to provide their own code action kinds array
2023-03-30 15:54:55 -04:00
Julia
cdde523ea4
Allow each language adapter to provide their own code action kinds array
2023-03-30 15:41:54 -04:00
Nate Butler
f235d9f411
Add zed plus copilot icon
2023-03-30 14:34:33 -04:00
Nate Butler
655897b182
Update icons
2023-03-30 14:32:51 -04:00
Nate Butler
58b453ad6e
Add new copilot state icons
2023-03-30 14:18:03 -04:00
Mikayla Maki
b7461c32dd
Improve settings writing for more cases
2023-03-30 10:40:53 -07:00
Mikayla Maki
e46cd2def3
Switch to using zed hosted copilot LSP (again)
...
co-authored-by: antonio <antionio@zed.dev >
2023-03-30 09:29:49 -07:00
Petros Amoiridis
007aa92581
Merge pull request #2323 from zed-industries/petros/z-402-recent-projects-replace-expanded-home
...
Replace home directory with the tilde substitution
2023-03-30 18:12:39 +03:00
Petros Amoiridis
dc51735112
Fix doctests
2023-03-30 17:57:14 +03:00
Petros Amoiridis
adc5ef911f
Remove the Errors section from rust docs
...
The section does not add anything that we don't already know.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-30 14:04:37 +03:00
Petros Amoiridis
18c6c7ebb7
Fix error
2023-03-30 14:03:59 +03:00
Petros Amoiridis
9ef3e45bcd
Update crates/recent_projects/src/highlighted_workspace_location.rs
...
Co-authored-by: Antonio Scandurra <me@as-cii.com >
2023-03-30 11:35:17 +03:00
Antonio Scandurra
e3a311fda9
Merge pull request #2331 from zed-industries/tab-map-sync
...
Speed up tab searching in `TabMap::sync`
2023-03-30 10:20:57 +02:00
Antonio Scandurra
af4c4c7cf0
Speed up tab searching in TabMap::sync by looking for \t only
...
Instead of looking for `\n` as a stopping condition, we cap the range
we pass to `SuggestionSnapshot::chunks` to stop on the next line. This
makes character searching faster, because looking for a single character
uses `memchr`. Also, this avoids an extra conditional in a tight loop such
as the chunk scanning one contained in `TabMap::sync`.
2023-03-30 10:03:13 +02:00
Antonio Scandurra
79346b0706
Use + instead of | to break out of tab expansion in TabMap::sync
2023-03-30 09:49:07 +02:00
Mikayla Maki
5b3b74345d
Remove some strays
2023-03-29 22:22:02 -07:00
Mikayla Maki
a8033b266d
Fix bug with enable setting, clean up sign in UIs
2023-03-29 21:51:07 -07:00
Mikayla Maki
cc7c5b416c
Add status bar icon reflecting copilot state to Zed status bar
2023-03-29 21:31:33 -07:00
Mikayla Maki
8fac32e1eb
WIP, not compiling
2023-03-29 17:59:21 -07:00
Max Brunsfeld
ec5ffe9922
Merge pull request #2329 from zed-industries/new-window-on-click-doc
...
Open a new window when activating Zed from the dock w/ no windows open
2023-03-29 17:33:32 -07:00
Mikayla Maki
76efab005f
WIP
2023-03-29 17:25:41 -07:00
Max Brunsfeld
b5f762ab25
Open a new window when activating Zed from the dock w/ no windows open
2023-03-29 17:24:44 -07:00
Nate Butler
e3822a5b5c
Add copilot icons
2023-03-29 20:23:32 -04:00
Mikayla Maki
ae3b3ea458
Merge branch 'main' into copilot
2023-03-29 16:57:38 -07:00
Mikayla Maki
ebd06b43f5
Add copilot settings
...
Add copilot pause / resume
Add copilot statusbar item stub
2023-03-29 16:40:52 -07:00
Max Brunsfeld
7601e7902a
Merge pull request #2325 from zed-industries/tab-map-long-lines
...
Avoid slowdowns with long lines by skipping tab expansion beyond a certain column
2023-03-29 14:48:23 -07:00
Max Brunsfeld
0c07a373a8
🎨
2023-03-29 14:43:01 -07:00
Julia
e558d3f903
Merge pull request #2328 from zed-industries/breadcrumbs-outline-toggle
...
Open symbol outline when clicking on editor breadcrumbs
2023-03-29 15:51:30 -04:00
Julia
737e2e1b3c
Open symbol outline when clicking on editor breadcrumbs
2023-03-29 15:46:43 -04:00
Mikayla Maki
f812796283
Make modal behavior stateless
...
Co-authored-by: antonio <antonio@zed.dev >
2023-03-29 12:45:53 -07:00
Antonio Scandurra
49447128a9
Make edits smaller when tab expansion changes on a line
2023-03-29 21:40:37 +02:00
Joseph Lyons
6e2a9297ff
v0.81.x dev
2023-03-29 14:13:01 -04:00
Antonio Scandurra
b86f8188d1
Expand edit to end of the line when old/new row exceeds max expansion
2023-03-29 16:49:21 +02:00
Petros Amoiridis
b15632bd45
Remove convert_to_shortened_path from gpui platform
2023-03-29 17:41:01 +03:00
Petros Amoiridis
b4593cd90b
Use util::paths::compact
2023-03-29 17:40:39 +03:00
Petros Amoiridis
69989d0463
Introduce compact function in util create
2023-03-29 17:32:27 +03:00
Petros Amoiridis
d5f53111e8
Enable doctests in util crate
2023-03-29 17:31:55 +03:00
Petros Amoiridis
a128439699
Move code into the platform
...
Co-Authored-By: Joseph T. Lyons <19867440+JosephTLyons@users.noreply.github.com >
2023-03-29 16:25:13 +03:00
Petros Amoiridis
87c1b190a8
Replace home directory with the tilde substitution
2023-03-29 16:25:10 +03:00
Antonio Scandurra
719d0f0abf
Rename skip_leading_tab to inside_leading_tab
2023-03-29 14:53:28 +02:00
Antonio Scandurra
813f722925
Increment input_column correctly when inside the leading tab
2023-03-29 14:52:50 +02:00
Antonio Scandurra
056f4e914f
Merge pull request #2327 from zed-industries/remove-unused-code
...
Delete unused code
2023-03-29 09:09:47 +02:00
Antonio Scandurra
a64296938d
Delete unused code
2023-03-29 09:04:13 +02:00
Mikayla Maki
d60ef03d66
WIP Add copilot disabled setting
2023-03-28 20:52:50 -07:00
Mikayla Maki
0b0c7e4ce9
Move command palette filter into collections crate
...
Filter out copilot commands from command palette when not active
2023-03-28 20:13:17 -07:00
Mikayla Maki
aea8475d30
Apply cargo fmt
2023-03-28 18:45:37 -07:00
Antonio Scandurra
a5cec18775
Remove copilot smoke test
2023-03-28 18:41:35 -07:00
Antonio Scandurra
12370f120e
🎨
2023-03-28 18:40:51 -07:00
Antonio Scandurra
ce9774be53
Improve detection of common prefix in text_for_active_completion
2023-03-28 18:40:42 -07:00
Mikayla Maki
9d8d2bb8f4
Add rough versions of all 3 modals
2023-03-28 18:00:09 -07:00
Max Brunsfeld
5c1f82ae3d
Don't use TabMap::expand_tabs in line_indent_for_buffer_row
2023-03-28 17:37:57 -07:00
Max Brunsfeld
08e93e9321
Only expand tabs up until a limited column
2023-03-28 16:40:04 -07:00
Max Brunsfeld
c23feeab3a
🎨 Make expand_tabs and collapse_tabs instance methods on TabSnapshot
2023-03-28 14:10:43 -07:00
Mikayla Maki
941da24f73
Refactor out the node runtime crate and hook up all related imports
2023-03-28 10:27:31 -07:00
Mikayla Maki
0ef9cefe0f
Finish shape of copilot auth UI
2023-03-28 09:42:01 -07:00
Mikayla Maki
6ff09865eb
Create copilot auth popup UI
2023-03-28 09:42:01 -07:00
Antonio Scandurra
da81ff3295
Optimize CopilotState::text_for_active_completion
2023-03-28 09:42:01 -07:00
Antonio Scandurra
034bc75467
Refresh copilot suggestions when hitting alt-] if none are showing
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-03-28 09:42:01 -07:00
Antonio Scandurra
d236d9e8c9
Clear copilot suggestions when hitting escape
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-03-28 09:42:01 -07:00
Nate Butler
ef6c28326d
Update editor.ts
2023-03-28 09:42:01 -07:00
Nate Butler
2fede1c01f
Use syntax.predictive.color to style suggestions
2023-03-28 09:42:01 -07:00
Antonio Scandurra
1162615043
Reuse existing suggestion when inserting to avoid flickering
2023-03-28 09:42:01 -07:00
Antonio Scandurra
6715e5247c
Rework SuggestionMap to take highlight style when retrieving chunks
2023-03-28 09:42:01 -07:00
Antonio Scandurra
093e0a30e9
Replace editor::CycleCopilotSuggestions with copilot::NextSuggestion
2023-03-28 09:42:01 -07:00
Antonio Scandurra
2f95510a2e
Start integrating Copilot with editor
...
There's still a bit to do in terms of reusing the previous suggestion
when the prefix matches, but we're getting there.
2023-03-28 09:42:01 -07:00
Antonio Scandurra
b16e2169ce
WIP: Start on showing window for authenticating with copilot
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-03-28 09:42:01 -07:00
Antonio Scandurra
9713d1bb31
Fix invalid translation between bottom/top left coordinate spaces
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-03-28 09:42:01 -07:00
Antonio Scandurra
99cca59c84
Restructure verification code prompting to open a window instead
...
Also, prevent multiple calls to `sign_in` from racing with each other.
2023-03-28 09:42:01 -07:00
Mikayla Maki
19cc86a2d4
Wait to show the auth modal until the sign request has returned
2023-03-28 09:42:00 -07:00
Mikayla Maki
15e29d44b9
Add basic copilot modal
2023-03-28 09:42:00 -07:00
Mikayla Maki
b57d5174aa
Add copilot theme, start sketching out the auth modal
2023-03-28 09:42:00 -07:00
Antonio Scandurra
591e246450
Implement Copilot::completions_cycling
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-03-28 09:42:00 -07:00
Antonio Scandurra
155594c8b8
Successfully fetch completions from Copilot
...
We still need to process them and return them into a more Zed-friendly
structure, but we're getting there.
2023-03-28 09:42:00 -07:00
Antonio Scandurra
180371929b
Start on copilot completions
2023-03-28 09:42:00 -07:00
Antonio Scandurra
8ba9e63ab8
🎨
2023-03-28 09:42:00 -07:00
Antonio Scandurra
59d9277a74
Implement Copilot sign in and sign out
2023-03-28 09:42:00 -07:00
Antonio Scandurra
797bb7d780
Start copilot and check sign in status
2023-03-28 09:42:00 -07:00
Antonio Scandurra
5471217089
Use the same serde version across the entire workspace
2023-03-28 09:42:00 -07:00
Mikayla Maki
9a99eaee96
Fix bad global
2023-03-28 09:42:00 -07:00
Mikayla Maki
455cdc8b37
Add copilot crate
...
Refactor HTTP and github release downloading into util
Lazily download / upgrade the copilot LSP from Zed
Co-authored-by: Max <max@zed.dev >
Co-Authored-By: Antonio <antonio@zed.dev >
2023-03-28 09:41:59 -07:00
Julia
35b2aceffb
Merge pull request #2324 from zed-industries/download-node
...
Automatically download Node for Node based language servers
2023-03-28 12:10:24 -04:00
Julia
ee3ac9c344
Rename installation.rs -> github.rs now that is all it concerns
2023-03-28 11:51:09 -04:00
Julia
350f8ed304
Download the JSON LSP package instead of our own bundled binary
2023-03-28 11:48:00 -04:00
Julia
d4560fe321
Prevent deadlock when multiple languages attempt to install Node at once
2023-03-28 10:18:22 -04:00
Max Brunsfeld
c68c8462bb
Merge pull request #2322 from zed-industries/project-panel-paste-infinite-loop
...
Fix infinite loop in ProjectPanel::paste when filename has multiple dots
2023-03-27 17:09:10 -07:00
Max Brunsfeld
17bc83d699
Fix infinite loop in ProjectPanel::paste when filename has multiple dots
2023-03-27 16:45:11 -07:00
Max Brunsfeld
e5d552ef97
Merge pull request #2321 from zed-industries/new-file-with-no-window
...
Make 'new file' action open a window when there are no windows open
2023-03-27 16:10:30 -07:00
Max Brunsfeld
4a2132bc91
Make 'new file' action open a window when there are no windows open
2023-03-27 16:05:00 -07:00
Joseph T. Lyons
e10338ed17
Merge pull request #2313 from zed-industries/unify-spelling-of-key-binding-to-be-two-words
...
Unify spelling of `key binding` to be two words
2023-03-27 15:58:12 -04:00
Petros Amoiridis
eb7c6028f4
Merge pull request #2320 from zed-industries/petros/z-349-make-restart-to-update-zed-look
...
Make "Restart to update Zed" look clickable
2023-03-27 20:19:06 +03:00
Julia
df4380b066
Download aarch64 or x64 Node binary according to system architecture
2023-03-27 11:05:17 -04:00
Petros Amoiridis
b153bf7118
Add a hovered style to lspStatus background
2023-03-27 14:26:56 +03:00
Petros Amoiridis
374b284a3d
Run prettier on TS files
2023-03-27 14:26:05 +03:00
Julia
c72d33e029
Initial impl of NodeRuntime w/JSON borked and a deadlock :)
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-27 00:00:16 -04:00
Julia
1a2e509e35
Remove server_args from LspAdapter
...
Prepare to remove concept of a runtime from greater server startup code,
which is important for future language server extensibility
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-27 00:00:16 -04:00
Julia
ed442cfc8c
Invoke npm from downloaded Node
2023-03-27 00:00:16 -04:00
Julia
edd6c85af7
Initial running of servers on downloaded Node
2023-03-27 00:00:16 -04:00
Julia
b579211861
Report if language server requires Node or not
2023-03-27 00:00:16 -04:00
Nathan Sobo
d89936e4a9
Merge pull request #2319 from zed-industries/copy-highlight-json
...
Add "editor: copy highlight json" command
2023-03-24 17:17:45 -06:00
Nathan Sobo
f0992e7d67
Trim empty tokens; copy selected range if non-empty
2023-03-24 17:10:50 -06:00
Nathan Sobo
3dfedd1b21
Merge adjacent chunks with the same highlight name in copied JSON
2023-03-24 16:52:00 -06:00
Nathan Sobo
195215f1e0
Add "editor: copy highlight json" command
...
Nate needs this to feed to Figma for highlighted code in designs.
2023-03-24 16:37:57 -06:00
Max Brunsfeld
c74f8eb9e3
Merge pull request #2258 from zed-industries/lsp-file-change-notifications
...
Implement `DidChangedWatchedFiles` LSP feature
2023-03-24 14:42:23 -07:00
Max Brunsfeld
455ffb17f1
Handle path changes and progress updates from all worker threads during initial scan
2023-03-24 14:35:18 -07:00
Max Brunsfeld
027def6800
Merge branch 'main' into lsp-file-change-notifications
2023-03-24 08:52:43 -07:00
Max Brunsfeld
a0e98ccc35
🎨 BackgroundScanner::run
2023-03-23 18:05:12 -07:00
Max Brunsfeld
89e99d2902
🎨 Don't store path changes statefully on the background scanner
2023-03-23 16:04:47 -07:00
Max Brunsfeld
3ff5aee4a1
Respect LSP servers watch glob patterns
2023-03-23 16:03:07 -07:00
Mikayla Maki
76b75b4b43
Merge pull request #2318 from zed-industries/fix-unknown-in-non-editor-buffers
...
changed language status bar item to only show on editors
2023-03-23 13:33:42 -07:00
Mikayla Maki
5db11c628b
changed language status bar item to only show on editors
2023-03-23 13:29:23 -07:00
Mikayla Maki
5cad3d3a67
Merge pull request #2317 from zed-industries/fix-titlebar-right-spacing
...
Fix misaligned UI in the right titlebar
2023-03-23 13:16:40 -07:00
Mikayla Maki
bb5c2833a3
Aligned title bar items to the center and fixed left spacing on the sign in button
...
co-authored-by: max <max@zed.dev >
2023-03-23 13:08:31 -07:00
Petros Amoiridis
566a04ebca
Merge pull request #2311 from zed-industries/petros/z-279-add-terminals-count
...
Add terminals count
2023-03-23 10:52:01 +02:00
Mikayla Maki
f9d3963dbb
Merge pull request #2315 from zed-industries/fix-fold-indicator-offsets
...
Fix fold indicator offsets
2023-03-22 17:13:13 -07:00
Mikayla Maki
e87c3b6dd7
Update element.rs
...
remove spare parens
2023-03-22 17:05:54 -07:00
Mikayla Maki
e729c4ad4f
Fix fold indicator offsets
2023-03-22 17:04:52 -07:00
Max Brunsfeld
361b7c3a0c
Clear auto-indent requests when replacing a buffer's entire text
2023-03-22 15:10:16 -07:00
Max Brunsfeld
eaee5571a0
Use a more stable, readable serialization format for neovim-backed vim tests
2023-03-22 14:31:11 -07:00
Joseph Lyons
6de38f7410
v0.80.x dev
2023-03-22 16:33:06 -04:00
Julia
df553de363
Merge pull request #2314 from zed-industries/another-one
...
Remove another spot with a flag old npm does not like
2023-03-22 15:56:23 -04:00
Julia
4fc37cf982
Remove another spot with a flag old npm does not like
2023-03-22 15:40:51 -04:00
Joseph Lyons
9d88cd8842
Unify spelling of key binding to be two words
2023-03-22 13:34:12 -04:00
Petros Amoiridis
fd9eff3a78
Remove struct
2023-03-22 19:28:06 +02:00
Petros Amoiridis
bd1515cdd2
Only show count when we have terminals
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-03-22 18:23:41 +02:00
Joseph T. Lyons
bd85ef363f
Merge pull request #2312 from zed-industries/unkown
...
Fix typo in "Unknown" language
2023-03-22 11:20:18 -04:00
Nathan Sobo
e017b99384
Fix typo
2023-03-22 09:13:10 -06:00
Petros Amoiridis
15406ff2d9
Remove comment
2023-03-22 16:31:42 +02:00
Petros Amoiridis
d5bb2d13b8
Introduce terminal button count
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-22 16:13:58 +02:00
Petros Amoiridis
aa7254167a
Fix typo
2023-03-22 15:31:21 +02:00
Antonio Scandurra
005eb559ee
Merge pull request #2310 from zed-industries/fix-sharing-status-indicator
...
Remove screen sharing indicator when call ends
2023-03-22 09:40:23 +01:00
Antonio Scandurra
7df798ded5
Remove screen sharing indicator when call ends
...
Previously, we would only remove it when the screen sharing stopped.
2023-03-22 09:32:27 +01:00
Max Brunsfeld
c1f53358ba
Remove unnecessary Arc around background scanner's snapshot
2023-03-21 15:47:02 -07:00
Max Brunsfeld
f7b2713b77
Fix error in joining empty paths
2023-03-21 15:41:24 -07:00
Max Brunsfeld
5da2b123b5
Allow refreshing worktree entries while the initial scan is in-progress
2023-03-21 15:15:12 -07:00
Max Brunsfeld
b10b0dbd75
Only mutate background snapshot in the background scanner
2023-03-21 11:26:33 -07:00
Max Brunsfeld
d742c758bc
Restructure communication from BackgroundScanner to LocalWorktree
...
The worktree no longer pulls the background snapshot from the background scanner.
Instead, the background scanner sends both snapshots to the worktree. Along with
these, it sends the path change sets.
Also, add randomized test coverage for the worktree UpdatedEntries events.
2023-03-21 11:26:13 -07:00
Max Brunsfeld
cbeb6e692d
Move postage crate version specification to workspace Cargo.toml
2023-03-21 11:26:13 -07:00
Max Brunsfeld
d36b2a3129
🎨 Simplify some worktree methods
...
* Consolidate local worktree construction into one method
* Simplify remote worktree construction
* Reduce indirection around pulling worktree snapshots from the background
2023-03-21 11:26:13 -07:00
Max Brunsfeld
399f082415
Update wrong assertions after fixing missing event in FakeFs
2023-03-21 11:26:13 -07:00
Max Brunsfeld
51b093197d
Add missing import in project tests
2023-03-21 11:26:13 -07:00
Max Brunsfeld
27ad6a57ce
Tweak logging in worktree randomized test
2023-03-21 11:26:13 -07:00
Max Brunsfeld
c730dca3c5
Update worktree randomized test to use worktree's public interface and the fake fs
2023-03-21 11:26:13 -07:00
Max Brunsfeld
be5868e1c0
Conservatively report fs events that occurred during initial worktree scan
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2023-03-21 11:26:13 -07:00
Max Brunsfeld
61172c8478
Notify language servers of FS changes
2023-03-21 11:26:13 -07:00
Max Brunsfeld
9837a6e288
Add failing test for reporting FS change events to language servers
2023-03-21 11:26:13 -07:00
Antonio Scandurra
194c7a3af0
Merge pull request #2309 from zed-industries/suggestion-map
...
Introduce `DisplayMap::replace_suggestion`
2023-03-21 18:18:50 +01:00
Antonio Scandurra
2893c9bdb7
Don't move up/down by more rows than the requested ones
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-03-21 17:52:53 +01:00
Antonio Scandurra
f7cba4cec4
Make Suggestion fields public
2023-03-21 16:51:33 +01:00
Antonio Scandurra
ba3913df8c
Expose a DisplayMap::replace_suggestion method
2023-03-21 16:41:54 +01:00
Antonio Scandurra
9c8732a355
Integrate SuggestionMap into the rest of DisplayMap
2023-03-21 16:39:02 +01:00
Antonio Scandurra
d1978a719b
Add a version field to SuggestionSnapshot
2023-03-21 12:47:04 +01:00
Antonio Scandurra
3d165f705f
Extract a SuggestionMap::randomly_mutate method
2023-03-21 11:51:06 +01:00
Antonio Scandurra
35830a0271
Implement SuggestionSnapshot::to_{fold,suggestion}_point
2023-03-21 11:39:29 +01:00
Antonio Scandurra
d448a5cb5c
Implement SuggestionSnapshot::to_point
2023-03-21 11:28:36 +01:00
Antonio Scandurra
f829ce5641
Implement SuggestionSnapshot::to_offset
2023-03-21 11:28:33 +01:00
Antonio Scandurra
c0e124a55a
Implement SuggestionSnapshot::text_summary_for_range
2023-03-21 11:28:30 +01:00
Antonio Scandurra
52a156aebe
Implement SuggestionSnapshot::clip_point
2023-03-21 11:28:27 +01:00
Antonio Scandurra
ccb6196224
Implement SuggestionSnapshot::buffer_rows
2023-03-21 11:28:23 +01:00
Antonio Scandurra
1a9dbfa86a
Add unit test to verify basic properties of the SuggestionMap
2023-03-21 08:29:33 +01:00
Joseph T. Lyons
8c0dd887ff
Merge pull request #2299 from zed-industries/correct-verb-tense-in-default-settings
...
Correct verb tense in default settings
2023-03-20 14:50:46 -04:00
Antonio Scandurra
3edf83cb99
Implement SuggestionSnapshot::line_len
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-03-20 19:45:39 +01:00
Antonio Scandurra
f44549eb29
Enhance randomized test to verify SuggestionMap::{chunks,sync}
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-03-20 19:29:22 +01:00
Antonio Scandurra
4d6726ef39
WIP: Flesh out more of the suggestions randomized test
2023-03-20 18:06:24 +01:00
Petros Amoiridis
98ae69a61f
Merge pull request #2282 from zed-industries/petros/z-283-make-pop-up-positioning-consistent
...
Consistent pop-up menu positions
2023-03-20 17:55:40 +02:00
Petros Amoiridis
24bbca7326
Position pane new, split, and dock context menus
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-03-20 17:49:33 +02:00
Nathan Sobo
d429ce0f62
Merge pull request #2308 from zed-industries/feedback-icon
...
Use an envelope as the feedback icon so we can use the speech bubble for discussions
2023-03-20 09:14:34 -06:00
Nathan Sobo
10e6c5b651
Use an envelope as the feedback icon
...
This makes room to use the speech bubble for discussion threads.
2023-03-20 09:04:30 -06:00
Antonio Scandurra
9970e5f60c
Start on randomized test and add SuggestionMapSnapshot::chunks
2023-03-20 15:56:15 +01:00
Antonio Scandurra
fb48854e5a
Simplify signature of SuggestionMap::replace
2023-03-20 14:00:14 +01:00
Antonio Scandurra
83051f1e86
Add SuggestionMap::replace
2023-03-20 13:50:14 +01:00
Antonio Scandurra
94a9e28e35
Start on SuggestionMap
2023-03-20 13:22:14 +01:00
Mikayla Maki
2a024a255f
Merge pull request #2307 from zed-industries/fix-panic-in-editor-tab-content
...
Do UTF8-aware truncation on long item names in editor item
2023-03-18 15:49:06 -07:00
Mikayla Maki
436c59d8ef
Do UTF8-aware truncation on long item names in editor item
2023-03-18 15:44:23 -07:00
Mikayla Maki
5356ec4730
Merge pull request #2287 from zed-industries/fix-fold-range-finding
...
Fix code folds with wraps
2023-03-17 17:18:56 -07:00
Mikayla Maki
5a3d5dff42
Make folds tab aware
2023-03-17 17:14:40 -07:00
Mikayla Maki
c39b4ac229
Fix boundary condition in buffer_line_len when at the end of a file
...
co-authored-by: max <max@zed.dev >
2023-03-17 16:56:44 -07:00
Mikayla Maki
5a1bbb96ba
Merge pull request #2302 from zed-industries/fix-dispatch-path-panic
...
Align dispatch_keystroke with other uses of ancestors iterator
2023-03-17 16:34:00 -07:00
Mikayla Maki
b16e53a577
Merge pull request #2306 from zed-industries/fix-panic-with-multi-line-env
...
Parse user enviroment using null terminators instead of newlines
2023-03-17 16:18:05 -07:00
Mikayla Maki
109e17b4b2
Parse user enviroment using null terminators instead of newlines
2023-03-17 16:14:07 -07:00
Mikayla Maki
eba119b914
Fix fold tests with new representation
...
Switch UI code from using display rows to using buffer rows
Make folds only show up on lines with line layouts
co-authored-by: Max <max@zed.dev >
2023-03-17 16:00:22 -07:00
Max Brunsfeld
fc828971f1
collab 0.8.2
2023-03-17 15:00:31 -07:00
Max Brunsfeld
691383ca68
Merge pull request #2305 from zed-industries/faster-access-token-validation
...
Faster access token validation
2023-03-17 14:56:30 -07:00
Max Brunsfeld
b8e8363a72
Add logging and metric for time spent hashing auth tokens
...
Co-authored-by: Mikayla Maki <mikayla@zed.dev >
2023-03-17 14:32:13 -07:00
Max Brunsfeld
623133ffa0
Reduce scrypt work factor to speed up websocket authentication
...
Co-authored-by: Mikayla Maki <mikayla@zed.dev >
2023-03-17 14:31:39 -07:00
Max Brunsfeld
9633a4b527
Return a 400, not a 500 when token validation fails
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-03-17 13:56:12 -07:00
Julia
368a6405a1
Increase git diff gutter width slightly
2023-03-17 15:28:38 -04:00
Mikayla Maki
459e320d79
Merge pull request #2303 from zed-industries/add-unknown-language
...
Add an 'Unknown' state for a mouse-driven way to select a file language
2023-03-17 11:41:40 -07:00
Mikayla Maki
04f52c3d50
Show active buffer language in all cases
2023-03-17 11:34:17 -07:00
Max Brunsfeld
26dae3c04e
Lookup access tokens by id when authenticating a connection
...
This avoids the cost of hashing an access token multiple times,
to compare it to all known access tokens for a given user.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-03-17 11:13:50 -07:00
Mikayla Maki
578c69476d
Align dispatch_keystroke with other uses of ancestors iterator and filter out non-existant views
2023-03-17 11:07:10 -07:00
Mikayla Maki
1125a168f4
Merge pull request #2301 from zed-industries/fix-file-finder-panic
...
Never call set_selected_index with an invalid index
2023-03-17 10:18:27 -07:00
Antonio Scandurra
d8758658e3
Merge pull request #2300 from zed-industries/ligatures
...
Allow customization of OpenType features
2023-03-17 17:34:17 +01:00
Mikayla Maki
f7f9b8cffe
Never call set_selected_index with an invalid index
2023-03-17 09:32:01 -07:00
Antonio Scandurra
1af8f4be19
Deserialize Theme directly into the heap to avoid stack overflow
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-03-17 15:58:52 +01:00
Antonio Scandurra
786d95b8c8
Avoid storing fonts::Features in TextStyle
...
We were only using it for debugging purposes and that was causing
the `Theme` struct to become too big to hold on the stack.
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-03-17 15:12:02 +01:00
Antonio Scandurra
4d915f4530
Don't make fonts::Features Copy
2023-03-17 13:54:56 +01:00
Antonio Scandurra
989c9f0196
Mention calt: false in the default settings to disable ligatures
2023-03-17 13:48:34 +01:00
Antonio Scandurra
f9d793cb4a
Honor more OpenType features
2023-03-17 13:40:00 +01:00
Petros Amoiridis
3bddf01962
Run prettier to format things
2023-03-17 14:05:49 +02:00
Petros Amoiridis
86ed5b8b83
Position contacts and user menus
...
Using the new approach for consistency
2023-03-17 14:05:46 +02:00
Antonio Scandurra
9181ac9872
Honor the calt font feature
2023-03-17 12:01:27 +01:00
Antonio Scandurra
76167ca65c
Allow setting font features on TextStyle
2023-03-17 11:49:22 +01:00
Antonio Scandurra
7d13b00914
Allow setting font features on the terminal as well
2023-03-17 11:42:24 +01:00
Antonio Scandurra
b2c733baab
WIP: Allow specifying font features in the editor
...
This just lays the foundation for threading through a `fonts::Features`
struct, but it's not used yet.
2023-03-17 09:51:36 +01:00
Joseph Lyons
6eb65eb989
Correct verb tense in default settings
2023-03-17 00:51:03 -04:00
Julia
3464961aa4
Merge pull request #2298 from zed-industries/fix-deadlock
...
Fix deadlock while initializing JSON language server
2023-03-16 17:41:54 -04:00
Julia
757f05042d
Fix deadlock while initializing JSON language server
...
As it turns out both parking-lot and std's `RwLock` disallows taking
multiple read locks on the same thread
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-03-16 17:32:51 -04:00
Max Brunsfeld
9633732db7
collab 0.8.1
2023-03-16 14:21:35 -07:00
Max Brunsfeld
e34d80cff4
Merge pull request #2296 from zed-industries/tx-serialization-retry-delay
...
Introduce a delay before retrying a transaction after a serialization failure
2023-03-16 14:16:20 -07:00
Mikayla Maki
f2492666d4
Merge pull request #2297 from zed-industries/fix-random-panics
...
WIP: Fix random panics
2023-03-16 13:20:54 -07:00
Joseph T. Lyons
b3b20e4c46
Merge pull request #2295 from zed-industries/swap-atom-keybinding-for-CollapseSelectedEntry
...
Swap atom keybinding for CollapseSelectedEntry
2023-03-16 16:12:28 -04:00
Max Brunsfeld
b9bc66aa9b
Log the delay when retrying a transaction
2023-03-16 13:07:38 -07:00
Max Brunsfeld
35280f7d80
Introduce a delay before retrying a transaction after a serialization failure
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-03-16 13:07:38 -07:00
Mikayla Maki
6571555c4d
Fix unwrap in git2 library causing panics in Zed
2023-03-16 13:06:23 -07:00
Joseph Lyons
a252c2a15b
Swap atom keybinding for CollapseSelectedEntry
...
This is a temporary solution to this bug:
https://linear.app/zed-industries/issue/Z-340/the-project-panel-shouldnt-be-listening-to-key-commands-when-editing-a
2023-03-16 15:59:14 -04:00
Mikayla Maki
c3325430ca
Fix divide by 0 in terminal
...
Fix fail to remove contact in contact list
2023-03-16 12:31:50 -07:00
Julia
1fbdea6a03
Merge pull request #2294 from zed-industries/remove-flag-old-npm-does-not-like
...
Remove CLI flag which old versions of NPM do not like
2023-03-16 13:11:45 -04:00
Julia
24dba2157f
Remove CLI flag which old versions of NPM do not like
...
TODO: Bundle or version restrict Node
2023-03-16 13:07:09 -04:00
Mikayla Maki
c427a8c584
WIP - DEBUGGING
2023-03-16 08:41:19 -07:00
Antonio Scandurra
356b8c6980
Merge pull request #2293 from zed-industries/yaml-hover-bug
...
Fix hover popover rendering lots of `&emsp` for YAML
2023-03-16 16:15:14 +01:00
Antonio Scandurra
9498f02f2c
Retrieve workspace configuration before initializing language server
2023-03-16 15:01:31 +01:00
Antonio Scandurra
f5a4c6a7c1
Provide editor.tabSize in workspace configuration for YAML
...
This fixes a bug that caused the hover popover to display lots of
` ` occurrences.
2023-03-16 10:46:55 +01:00
Antonio Scandurra
88e664bfd9
Add test for language registration and loading
2023-03-16 10:46:55 +01:00
Antonio Scandurra
8a685fa52a
Use LanguageRegistry::workspace_configuration everywhere
2023-03-16 10:46:55 +01:00
Antonio Scandurra
4d52fc0d12
Remove available language only when it has loaded
...
This also ensures that, if you load the same language more than once,
a future that resolves to the language (or an error) is returned at
all times. Previously, we would only return it the first time the language
was loaded.
2023-03-16 10:46:55 +01:00
Antonio Scandurra
a8ac08f5bd
Coalesce multiple RwLocks into one LanguageRegistryState struct
2023-03-16 10:46:55 +01:00
Antonio Scandurra
e30ea43a14
Include loaded languages when computing lsp workspace configuration
2023-03-16 10:46:55 +01:00
Antonio Scandurra
60d3fb48e2
Start computing workspace configuration more dynamically
2023-03-16 10:46:55 +01:00
Max Brunsfeld
ed9927b495
Merge pull request #2292 from zed-industries/restart-app
...
Make 'restart' action more reliable
2023-03-15 18:01:22 -07:00
Max Brunsfeld
d69868fa44
Make restart action more reliable
2023-03-15 17:44:50 -07:00
Julia
1ed3aedb16
Merge pull request #2291 from zed-industries/change-LSHandlerRank
...
Change `LSHandlerRank` to `Alternate`
2023-03-15 19:33:33 -04:00
Julia
905e2586e9
Change LSHandlerRank to Alternate
2023-03-15 19:18:39 -04:00
Max Brunsfeld
51eb53be0d
Merge pull request #2290 from zed-industries/close-remote-projects-when-leaving-call
...
Close remote project windows when leaving a call
2023-03-15 15:34:51 -07:00
Max Brunsfeld
b34477458e
Close remote project windows when leaving a call
2023-03-15 15:24:58 -07:00
Nathan Sobo
385dfe1661
Merge pull request #2289 from zed-industries/sort-language-names-case-agnostically
...
Sort language names case agnostically
2023-03-14 20:00:52 -06:00
Joseph Lyons
3c7237e600
Sort language names case agnostically
2023-03-14 21:45:17 -04:00
Nathan Sobo
44a2506c40
Merge pull request #2288 from zed-industries/cut-off-collaborator-avatars
...
Fix collaborator avatars being clipped and not centered
2023-03-14 19:39:01 -06:00
Max Brunsfeld
c4e7611d04
Fix collaborator avatars being clipped and not centered
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
Co-authored-by: Julia Risley <julia@zed.dev >
2023-03-14 17:59:33 -07:00
Mikayla Maki
75bea91245
Convert code folding to be in terms of buffer points instead of display points
...
Co-authored-by: max <max@zed.dev >
2023-03-14 16:48:03 -07:00
Max Brunsfeld
828e9c1bb8
v0.79.x dev
2023-03-14 12:49:33 -07:00
Max Brunsfeld
2042188f5a
Merge pull request #2286 from zed-industries/discoverable-sign-in
...
Make sign-in more discoverable
2023-03-14 11:08:18 -07:00
Max Brunsfeld
0bbb4b22c6
Rename 'Authenticate' action to 'Sign In'
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-03-14 11:01:23 -07:00
Max Brunsfeld
75901f1c33
Show sign in button directly in titlebar when not signed in
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-03-14 10:59:39 -07:00
Antonio Scandurra
a6ebc9bd26
collab 0.8.0
2023-03-14 18:21:16 +01:00
Antonio Scandurra
9e3085b0c4
Merge pull request #2284 from zed-industries/automatic-user-creation
...
Create user record automatically when someone logs in on the website
2023-03-14 18:20:13 +01:00
Mikayla Maki
7af9dda869
Merge pull request #2285 from zed-industries/fix-failed-theme-setting
...
Fix failed theme setting
2023-03-14 10:10:39 -07:00
Mikayla Maki
2a5ac4f203
Merge pull request #2283 from zed-industries/fix-code-fold-indicator-scaling
...
Change fold icon width to scale with font size
2023-03-14 10:07:25 -07:00
Mikayla Maki
d8a3f16891
Refactor load into a seperate function
2023-03-14 09:56:27 -07:00
Mikayla Maki
99257a8213
Fix failed initialization of setting file in welcome experience
2023-03-14 09:46:28 -07:00
Antonio Scandurra
0f429243d7
Fix seed binary
2023-03-14 12:37:56 +01:00
Antonio Scandurra
cba41ef7c5
Create user record automatically when someone logs in on the website
...
Now that we are moving out of the private alpha, we should let everyone
in when they try to log into zed.dev.
2023-03-14 12:25:04 +01:00
Mikayla Maki
2ba38b2fca
Change icon width to scale with font size
2023-03-14 00:42:15 -07:00
Petros Amoiridis
e7f78c4f74
Merge pull request #2281 from zed-industries/petros/z-298-the-terminal-button-is-not-shown-for
...
Remove check for staffmode
2023-03-14 00:12:13 -07:00
Petros Amoiridis
8980df1f5d
Remove feature flag
...
It wasn't working in production anyway
2023-03-14 09:05:04 +02:00
Nathan Sobo
2db8ac4a6f
Merge pull request #2280 from zed-industries/terms
...
Add terms of use to DMG in the bundle script
2023-03-13 16:08:07 -06:00
Nathan Sobo
818a514110
Add terms of use to DMG in the bundle script
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-03-13 15:47:59 -06:00
Mikayla Maki
1b4f783b97
Merge pull request #2279 from zed-industries/remove-invite-link
...
Remove UI for invite link in prep for beta launch
2023-03-13 14:35:52 -07:00
Mikayla Maki
88599add56
Remove UI for invite link in prep for beta launch
2023-03-13 12:54:20 -07:00
Max Brunsfeld
05f6747132
v0.78.x dev
2023-03-13 12:00:56 -07:00
Max Brunsfeld
1096720b41
Merge pull request #2244 from zed-industries/less-surprising-defaults
...
Clean up some default settings
2023-03-13 11:54:46 -07:00
Julia
5c7c4dd4dd
Clean up some default settings
2023-03-13 14:54:28 -04:00
Max Brunsfeld
da35202bbf
Merge pull request #2278 from zed-industries/screenshares-from-before-joining
...
Fix failure to see screenshare tracks that were started prior to join…
2023-03-13 11:22:40 -07:00
Max Brunsfeld
f5c4a2a0dd
Fix failure to see screenshare tracks that were started prior to joining a call
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-03-13 11:15:22 -07:00
Mikayla Maki
77a63c6598
Merge pull request #2277 from zed-industries/switch-invite-person-icon
...
Update Collab + icon
2023-03-13 10:54:33 -07:00
Nate Butler
edd925f77b
Format
2023-03-13 13:49:00 -04:00
Nate Butler
6d0f8290a4
Merge pull request #2276 from zed-industries/improve-picker-state-contrast
...
Improve picker state contrast
2023-03-13 13:48:04 -04:00
Nate Butler
6497ca8ccb
Update icon
2023-03-13 13:47:58 -04:00
Max Brunsfeld
e60dea7049
collab 0.7.2
2023-03-13 10:11:44 -07:00
Nate Butler
e64fe6d660
Improve contrast of project panel active state in light themes
2023-03-13 13:10:46 -04:00
Antonio Scandurra
f6f09e8661
Merge pull request #2274 from zed-industries/leave-on-quit
...
Leave room on quit
2023-03-13 18:08:01 +01:00
Max Brunsfeld
ef7d8f46df
Merge pull request #2273 from zed-industries/fix-dock-opening-in-collaboration
...
Fix dock opening on collaboration
2023-03-13 10:04:43 -07:00
Nate Butler
7df2440757
Format
2023-03-13 12:59:23 -04:00
Nate Butler
6fd4e28813
Update picker active and hover styles
...
Thanks for pointing this out @ForLoveOfCats
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-03-13 12:59:17 -04:00
Antonio Scandurra
bca1acf6d3
Leave room on quit
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-03-13 17:52:10 +01:00
Mikayla Maki
097a768725
Remove panic in recent projects picker
2023-03-13 09:44:42 -07:00
Mikayla Maki
404dd43c30
Fix dock opening on collaboration
2023-03-13 09:36:45 -07:00
Petros Amoiridis
c6f27903cc
Merge pull request #2271 from zed-industries/petros/z-278-lock-pop-up-to-the-terminal-button
...
A new approach for positioning pop-up menus tied to an icon/button
2023-03-13 08:46:44 -07:00
Antonio Scandurra
f6b0c56a47
Merge pull request #2268 from zed-industries/mention-username-of-user-in-prompt-when-removing-a-contact
...
Mention username of user in prompt when removing a contact
2023-03-13 14:28:11 +01:00
Antonio Scandurra
e45d680126
Merge pull request #2272 from zed-industries/add-textmate-keymap
...
Add TextMate keymap
2023-03-13 14:26:32 +01:00
Antonio Scandurra
e993d32900
Merge pull request #2270 from zed-industries/add-default-keybindings-for-reveal-in-finder
...
Add default keybindings for reveal in finder
2023-03-13 14:25:26 +01:00
Antonio Scandurra
09911d43bc
Merge pull request #2269 from zed-industries/unify-action-names-with-keybinding-names
...
Unify action names with keybinding name
2023-03-13 14:24:42 +01:00
Joseph Lyons
c8696149b8
Add TextMate keymap
2023-03-13 08:27:04 -04:00
Petros Amoiridis
db73d831c7
Use local overlay position mode and alignment
...
When we show the context menu, we don't specify an explicit position other than the default one which is equal to the origin in the context of a local overlay position mode. We then rely on `AnchorCorner` and aligning the context menu child view in the stack with `top().right()` for pop-ups that need to appear at the top of the icon/button.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-13 12:50:12 +02:00
Petros Amoiridis
d2411a6c86
Merge pull request #2253 from zed-industries/joseph/z-226-add-terminal-popup-menu
...
Add terminal pop up menu
2023-03-13 02:47:44 -07:00
Petros Amoiridis
726c8eb43f
Use type_id to determine what has the focus
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-13 11:42:40 +02:00
Joseph Lyons
c59dafab7e
Update method names to match action names
2023-03-12 06:08:12 -04:00
Joseph Lyons
e272a1a18f
Switch github_login to String
...
One of our macros, `impl_actions!`, didn't like that `RemoveContact` had a lifetime.
2023-03-12 05:03:31 -04:00
Joseph Lyons
90bca1b94a
Add default keybindings for reveal in finder
2023-03-12 04:58:17 -04:00
Joseph Lyons
06ad3a7f7b
Unify action names with keybinding name
2023-03-12 04:37:39 -04:00
Joseph Lyons
c18f1b6246
Mention username of user in prompt when removing a contact
2023-03-11 19:28:35 -05:00
Joseph Lyons
46efb844af
Remove hardcoding of "Terminal" string
2023-03-11 16:27:00 -05:00
Petros Amoiridis
29f0078084
Show tooltip for Give Feedback icon
2023-03-11 17:40:47 +02:00
Petros Amoiridis
432aeeac56
Remove comment
...
I know @JosephTLyons you had added that, but I am not entirely sure this is how the view should be called. Let's discuss this further if you fill strong about it.
2023-03-11 17:22:21 +02:00
Petros Amoiridis
8440a98850
Activate terminal button when a terminal is focus
...
This is code I brought over from https://github.com/zed-industries/zed/pull/2267 by @mikayla-maki after fixing the conflicts.
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-03-11 16:45:28 +02:00
Petros Amoiridis
bccc34c61a
Merge branch 'main' into joseph/z-226-add-terminal-popup-menu
2023-03-11 16:42:42 +02:00
Max Brunsfeld
e8b3d4e0fa
Encode db-max-connections env var as a string in k8s manifest
2023-03-10 17:19:16 -08:00
Max Brunsfeld
ff1c7db38f
collab 0.7.1
2023-03-10 16:36:03 -08:00
Mikayla Maki
30a08467b0
Merge pull request #2263 from zed-industries/language-status-bar
...
Language status bar
2023-03-10 16:26:42 -08:00
Mikayla Maki
c8de738972
Align feedback button styles with other sidebar buttons
...
Make feedback button reflect whether you're in a feedback buffer
2023-03-10 16:19:33 -08:00
Mikayla Maki
87ac409e51
Merge pull request #2265 from zed-industries/fix-menu-bar-greying-out
...
Fix too-agressive menu bar greying
2023-03-10 16:05:07 -08:00
Mikayla Maki
badfe70a93
Merge pull request #2267 from zed-industries/fix-terminal-icon-active-state
...
Activate and deactivate the terminal icon based on focused view
2023-03-10 16:02:34 -08:00
Mikayla Maki
11d8394af2
Fix the terminal icon button to only be active when a terminal is focused
2023-03-10 15:54:42 -08:00
Mikayla Maki
c24194156e
Merge pull request #2257 from zed-industries/check-all-contexts
...
Fix keyboard shortcuts not showing
2023-03-10 15:52:56 -08:00
Mikayla Maki
ece2af1e22
Fix a corner case in available action resolution
...
Add tests for new keybinding resolution behavior
co-authored-by: max <max@zed.dev >
2023-03-10 15:36:20 -08:00
Mikayla Maki
adf94a1681
Switch from using the key window to the main window mac platform API
...
When the help menu is open, the help menu's search field is the key window, and this was causing menu item action resolution to fail
co-authored-by: Max <max@zed.dev >
2023-03-10 14:43:28 -08:00
Julia
09d306df85
Merge pull request #2266 from zed-industries/avoid-panic
...
Avoid panic scanning recursive symlink before gitignore is encountered
2023-03-10 17:19:55 -05:00
Julia
0a5cf4b831
Avoid panic scanning recursive symlink before gitignore is encountered
2023-03-10 16:54:57 -05:00
Mikayla Maki
9398de6a57
Add feedback for telemetry item when there's no data
2023-03-10 13:15:36 -08:00
Mikayla Maki
e45104a1c0
Move feedback to overflow menu and help menu
2023-03-10 12:48:11 -08:00
Mikayla Maki
74b10e4ba5
Merge pull request #2264 from zed-industries/make-terminal-default-better
...
Make terminal fallback correctly when unable to deserialize a cwd
2023-03-10 12:27:54 -08:00
Mikayla Maki
ddbffd2c41
Make terminal fallback correctly when unable to deserialize your cwd
2023-03-10 12:23:29 -08:00
Mikayla Maki
00a38e4c3b
Bound the search range for the keybindings by the highest handler path
2023-03-10 12:12:32 -08:00
Mikayla Maki
37d01c7fb3
Merge pull request #2199 from zed-industries/welcome-experience
...
Welcome experience
2023-03-10 10:48:30 -08:00
Mikayla Maki
281ff92236
Stub out blank pane experience
2023-03-10 09:58:11 -08:00
Antonio Scandurra
bb721a08f5
💄
2023-03-10 17:43:48 +01:00
Antonio Scandurra
f50b51bdad
Adjust styling
2023-03-10 17:37:45 +01:00
Antonio Scandurra
693172854c
Show active buffer's language on the right in the status bar
2023-03-10 17:37:34 +01:00
Antonio Scandurra
b3c7526fb5
Return last excerpt in MultiBuffer::excerpt_containing if overshooting
2023-03-10 17:28:08 +01:00
Antonio Scandurra
6e37ff880f
Replace "Give Feedback" with an icon and move it to the left
...
This is so we can show the current language in the status bar on
the right, and having two pieces of text sitting next to each other
felt too busy.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-03-10 17:02:52 +01:00
Antonio Scandurra
f08685f65f
Merge pull request #2262 from zed-industries/manual-language-selection
...
Introduce language selector
2023-03-10 16:38:17 +01:00
Antonio Scandurra
ce828d55d5
Bind language_selector::Toggle to cmd-k m
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-03-10 16:32:18 +01:00
Antonio Scandurra
f28806d09b
Emphasize currently-selected language
2023-03-10 15:48:39 +01:00
Antonio Scandurra
686f5439ad
Set buffer language when confirming selection in language selector
...
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-03-10 15:34:26 +01:00
Antonio Scandurra
b402f27d50
Introduce a new language picker that displays available languages
...
Right now this panics when trying to select a language, so that's
what we're going to implement next.
Co-Authored-By: Julia Risley <julia@zed.dev >
2023-03-10 15:28:10 +01:00
Antonio Scandurra
d39c761de5
Merge pull request #2261 from zed-industries/async-language-loading
...
Allow waiting for language to be loaded in LanguageRegistry APIs
2023-03-10 15:27:08 +01:00
Antonio Scandurra
7a600e7a65
Allow waiting for language to be loaded in LanguageRegistry APIs
2023-03-10 12:17:47 +01:00
Antonio Scandurra
221bb54e48
Introduce a new TryFutureExt::unwrap method
2023-03-10 11:41:13 +01:00
Antonio Scandurra
431e11a033
Merge pull request #2260 from zed-industries/increase-max-connections
...
Increase the amount of max connections to the database
2023-03-10 10:27:26 +01:00
Antonio Scandurra
8b7273e46e
Increase the amount of max connections to the database
2023-03-10 10:10:59 +01:00
Mikayla Maki
9dc608dc4b
Switch from changing the meaning of the predicate to adding an additional match_dispatch_path_context API for UI elements
2023-03-09 19:32:09 -08:00
Mikayla Maki
648f0e5b7b
Remove new logo from style tree
2023-03-09 19:18:17 -08:00
Julia
b40ea4df14
Merge pull request #2259 from zed-industries/preserve-contacts-editor-contents
...
Preserve contacts popover editor contents when switching to search mode
2023-03-09 22:10:46 -05:00
Julia
01e3173ed0
Preserve contacts popover editor contents when switching to search mode
2023-03-09 22:05:32 -05:00
Nate Butler
8ee25be7b9
Update empty pane styling
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-03-09 20:18:29 -05:00
Mikayla Maki
0384456e7d
Change context matcher to search the entire stack
2023-03-09 16:18:37 -08:00
Mikayla Maki
20064b5629
Add welcome to menu
...
remove debug
2023-03-09 15:38:28 -08:00
Mikayla Maki
daed75096e
Fix editor test to clearly show trailing whitespace
...
Adjsut default dock size to be a multiple of 16
2023-03-09 13:18:03 -08:00
Mikayla Maki
718052bb72
Undo accidental indent change of hoverpopover.ts
2023-03-09 13:02:25 -08:00
Mikayla Maki
4eb75f058f
Fix bug with wrong view ids being passed
2023-03-09 12:00:58 -08:00
Petros Amoiridis
6c68a3e709
Remove unneeded code
2023-03-09 20:02:40 +02:00
Nate Butler
e7af3f223a
Merge pull request #2254 from zed-industries/nate/update-themes
...
WIP: More theme updates
2023-03-09 11:00:20 -05:00
Nate Butler
baff428de5
Re-add Ayu
2023-03-09 10:51:28 -05:00
Nate Butler
3952e98320
Remove Zed Pro theme
2023-03-09 10:50:11 -05:00
Nate Butler
51be0efa1f
Format
2023-03-09 10:47:58 -05:00
Nate Butler
5bfd5e35b3
Add light themes
2023-03-09 10:47:01 -05:00
Petros Amoiridis
d53c18cc57
Open menu relative to the mouse cursor
2023-03-09 16:57:38 +02:00
Petros Amoiridis
5b7d0ee6fe
Show button in a normal state
2023-03-09 16:54:47 +02:00
Petros Amoiridis
e2bdd261a1
Remove debugging statement
2023-03-09 16:53:34 +02:00
Mikayla Maki
9187863d0e
re-add spaces removed by new setting
2023-03-09 00:45:05 -08:00
Antonio Scandurra
3daeabc1d6
collab 0.7.0
2023-03-09 09:30:04 +01:00
Antonio Scandurra
bebfe53e89
Merge pull request #2256 from zed-industries/liveness-probe
...
Introduce Kubernetes liveness probe to ensure database works
2023-03-09 09:26:21 +01:00
Antonio Scandurra
9328bb0153
Introduce Kubernetes liveness probe to ensure database works
2023-03-09 09:17:55 +01:00
Antonio Scandurra
89c283ecf0
Merge pull request #2252 from zed-industries/limit-messages-processed-in-parallel
...
Prevent collab server from being overwhelmed with messages
2023-03-09 08:51:48 +01:00
Antonio Scandurra
a00ce3f286
Add randomized test to remove active selections from buffer
2023-03-09 07:47:05 +01:00
Antonio Scandurra
4ce51c8138
Limit dirty buffer save optimization to multi-buffers
2023-03-09 07:26:22 +01:00
Mikayla Maki
f626920af1
Remove permanent Zed stateless
2023-03-08 19:03:50 -08:00
Mikayla Maki
325827699e
Adjust styling for blank page experience
2023-03-08 19:02:13 -08:00
Julia
a3b1980a5e
Merge pull request #2255 from zed-industries/sort-collaborators-alphabetical
...
Sort collaborators in titlebar alphabetically instead of by replica id
2023-03-08 21:54:29 -05:00
Mikayla Maki
709c101834
Adjust styles on usage note
2023-03-08 18:50:17 -08:00
Mikayla Maki
943ea61452
Add a note on how to check the telemetry
2023-03-08 18:47:52 -08:00
Julia
981b3a459f
Sort collaborators in titlebar alphabetically instead of by replica id
2023-03-08 21:38:30 -05:00
Mikayla Maki
a65dd0fd98
Restore correct checkbox text
2023-03-08 18:15:29 -08:00
Mikayla Maki
cf6ea6d698
Fix bug with action keybindings not being resolved
2023-03-08 18:11:11 -08:00
Mikayla Maki
152755b043
Add blank pane experience
2023-03-08 17:56:39 -08:00
Mikayla Maki
dad66eb3fb
Make the workspace always open the dock
2023-03-08 14:49:52 -08:00
Mikayla Maki
f62e0b502a
Remove welcome experience action
...
Make logo switch between light and dark
co-authored-by: Nathan <nathan@zed.dev >
2023-03-08 14:49:48 -08:00
Nate Butler
344f59adf7
Tweak welcome design
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-03-08 17:14:15 -05:00
Nate Butler
cc33f83e4e
Add Zed logo icon
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-03-08 16:45:35 -05:00
Nate Butler
9842b7ad1a
WIP
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-03-08 16:34:27 -05:00
Max Brunsfeld
14497027d4
collab 0.6.2
2023-03-08 12:22:16 -08:00
Joseph Lyons
ae510c80db
v0.77.x dev
2023-03-08 13:25:32 -05:00
Petros Amoiridis
ad7e49ed06
Give focus to the selected terminal
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-03-08 19:47:57 +02:00
Antonio Scandurra
b687aec9d9
Avoid saving buffer if it's neither dirty nor in conflict
...
However, keep emitting `Saved` events so that the language server
is notified and can perform tasks related to saving (e.g., running
`cargo check` in the case of rust-analyzer).
2023-03-08 17:04:01 +01:00
Antonio Scandurra
a435dc1339
Clear selections on buffer only if they hadn't been cleared already
2023-03-08 17:04:01 +01:00
Antonio Scandurra
b4561b848d
Limit the number of parallel messages handled for any given connection
2023-03-08 17:04:01 +01:00
Petros Amoiridis
baa9e271d5
Make pop up open on the side of the button
2023-03-08 11:00:30 +02:00
Mikayla Maki
350ddf2025
Add keymap picker UI
...
Co-authored-by: Max <max@zed.dev >
2023-03-07 17:29:08 -08:00
Mikayla Maki
3594243644
Fix bug where open would offer to hang up a remote call
...
Co-authored-by: max <max@zed.dev >
2023-03-07 17:29:08 -08:00
Mikayla Maki
904993dfc9
Change open paths to replace the existing window if dispatched from a window
...
co-authored-by: Max <max@zed.dev >
2023-03-07 17:28:52 -08:00
Julia
4179ed66a6
Merge pull request #2251 from zed-industries/clear-follow-state-on-project-close
...
Update db followers table when user leaves a project
2023-03-07 19:09:09 -05:00
Julia
d173b1d412
Update db followers table when user leaves a project
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-03-07 18:56:03 -05:00
Mikayla Maki
ab4b3293d1
Fix project panel button and style it
...
Co-authored-by: max <max@zed.dev >
2023-03-07 14:49:13 -08:00
Mikayla Maki
5892f16602
Add test for base keymap setting
2023-03-07 14:02:42 -08:00
Nate Butler
84aefb9dcb
Add the rest of the Atelier dark themes
2023-03-07 13:47:18 -08:00
Nate Butler
4e81513af1
Add more Atelier themes
2023-03-07 13:35:32 -08:00
Nate Butler
90296667b0
Remove current staff themes
2023-03-07 13:35:23 -08:00
Nate Butler
e0f9b2b40f
Update Atelier Dune
2023-03-07 13:27:01 -08:00
Nate Butler
477453c396
Update existing Atelier themes
2023-03-07 13:22:07 -08:00
Mikayla Maki
19fc143209
Add base keymap setting
...
Format all files
Co-Authored-by: Nathan <nathan@zed.dev >
2023-03-07 12:19:51 -08:00
Joseph Lyons
ca03d871a6
Add a separator between the New Terminal button and existing terminal buttons
2023-03-07 15:09:06 -05:00
Joseph Lyons
0a3f0c5252
Use terminal titles for buttons
2023-03-07 15:04:12 -05:00
Joseph Lyons
c80942ea00
Begin work to dynamically add terminal names to menu
2023-03-07 14:41:18 -05:00
Joseph Lyons
caa6a75238
Show a pop up menu for terminals
...
Co-Authored-By: Joseph T. Lyons <19867440+JosephTLyons@users.noreply.github.com >
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-07 20:16:08 +02:00
Julia
4f4af55329
Merge pull request #2248 from zed-industries/increase-reconnect-timeout
...
Increase room reconnect timeout
2023-03-07 12:30:20 -05:00
Julia
1e5aff9e51
Update collab integration test to new reconnect timeout
2023-03-07 12:23:18 -05:00
Nate Butler
ee154feda4
Merge pull request #2231 from zed-industries/nate/add-gruvbox
...
Add Gruvbox Theme
2023-03-06 18:49:26 -08:00
Mikayla Maki
3b31f10c6f
Made the theme picker sort from dark to light
...
Added a layer into 'ConstrainedBox' to clip it
's children
Made the welcome experience responsive to small and large sizes
2023-03-06 18:36:18 -08:00
Mikayla Maki
8db7e17ac5
Move install_cli function to a seperate crate
...
Add install cli button to welcome experience
Add toast pop ups for CLI installation status
2023-03-06 17:55:58 -08:00
Mikayla Maki
1f6bd0ea77
Fix edge case where the welcome page might open in the dock if the user's actions race the welcome experience action
2023-03-06 16:35:15 -08:00
Mikayla Maki
ba652fc033
Finish basic welcome experience
2023-03-06 16:28:23 -08:00
Max Brunsfeld
7163ba429b
Merge pull request #2250 from zed-industries/syntax-highlighting-tweaks
...
Syntax highlighting tweaks
2023-03-06 16:05:10 -08:00
Max Brunsfeld
c832e4406e
Remove more colors from default syntax theme
...
These default colors weren't consistent with the rest of the
syntax theme.
2023-03-06 15:57:04 -08:00
Max Brunsfeld
515724821e
Make racket highlight query more consistent with other langs
2023-03-06 15:56:20 -08:00
Max Brunsfeld
0867162c87
Fix lua highlight query
...
* Fix regex predicate on constants.
* Remove 'function.call' highlight name. In other languages, we
differentiate calls from definitions with the 'function.definition'
highlight name. We actually don't use this in any themes though.
2023-03-06 15:54:17 -08:00
Max Brunsfeld
aba2914a31
Fix constant highlighting in JS, TypeScript
...
Previously, SCREAMING_SNAKE_CASE identifiers were highlighted as
types due to a mistake in the order of patterns in the highlight
queries.
2023-03-06 15:38:12 -08:00
Max Brunsfeld
246a6adab7
Merge pull request #2239 from zed-industries/add-constructor-to-syntax-overrides
...
Add constructor to syntax overrides
2023-03-06 15:27:09 -08:00
Mikayla Maki
020a0965b0
WIP
2023-03-06 14:26:32 -08:00
Mikayla Maki
b74553455f
Add an element to pane to take care of wiring initial mouse handlers
2023-03-06 14:26:32 -08:00
Mikayla Maki
4a8527478d
Add child item alignment to flex implementation
...
Fix checkbox styling
co-authored-by: Nathan <nathan@zed.dev >
2023-03-06 14:26:32 -08:00
Mikayla Maki
4c179875ab
Add png image loading to gpui
...
add zed logo into welcome experience
Co-authored-by: Nathan <nathan@zed.dev >
2023-03-06 14:26:32 -08:00
Mikayla Maki
f89f33347d
Added CTA buttons to welcome experience
...
Co-authored-by: Nathan <nathan@zed.dev >
2023-03-06 14:26:32 -08:00
Mikayla Maki
9dee2ca2be
WIP
2023-03-06 14:26:32 -08:00
Mikayla Maki
62aeb6b8b3
Added background to welcome page
2023-03-06 14:26:32 -08:00
Mikayla Maki
5210be95fe
Added welcome experience sketch
...
Made toolbar hideable
2023-03-06 14:26:32 -08:00
Mikayla Maki
7d7053b990
Move to using stateless
2023-03-06 14:26:31 -08:00
Mikayla Maki
118435a348
Added basic styling for checkboxes, yay
...
Co-authored-by: Max <max@zed.dev >
2023-03-06 14:25:10 -08:00
Mikayla Maki
86e2101592
Added the ability to nested values to the settings file, while preserving user formatting
...
co-authored-by: max <max@zed.dev >
2023-03-06 14:25:10 -08:00
Mikayla Maki
50586812ec
Make generate licenses quieter
2023-03-06 14:25:10 -08:00
Mikayla Maki
416c793076
Start on welcome experience settings
2023-03-06 14:25:10 -08:00
Mikayla Maki
a0637a769c
WIP
2023-03-06 14:25:10 -08:00
Mikayla Maki
9401ef223d
Add welcome crate and associated types
2023-03-06 14:25:10 -08:00
Julia
620890c411
Merge pull request #2247 from zed-industries/tidy-up-sprite-cache
...
Tidy up `SpriteCache::render_glyph`
2023-03-06 11:29:51 -05:00
Antonio Scandurra
0ec984f924
Tidy up SpriteCache::render_glyph
2023-03-06 17:08:35 +01:00
Max Brunsfeld
01bbf20962
Merge pull request #2235 from zed-industries/no-panic-uploads-in-debug
...
Don't upload panic files when running in a PTY
2023-03-04 09:42:46 -08:00
Mikayla Maki
996294ba67
Merge pull request #2246 from zed-industries/fix-lsp-derive-error
...
Make diagnostic processing order independent
2023-03-04 02:25:47 -08:00
Mikayla Maki
ddf2f2cb0a
Update test to use new group ids and new ordering of diagnostics.
2023-03-04 02:21:55 -08:00
Mikayla Maki
bd4d7551a5
Make diagnostic processing order independent
...
Co-authored-by: max <max@zed.dev >
2023-03-03 16:35:12 -08:00
Julia
5097cf5cb7
Merge pull request #2245 from zed-industries/confirm-restart-unsaved
...
Confirm restart if prompt-quit is enabled or there are unsaved changes
2023-03-03 16:10:40 -08:00
Julia
13212d274e
Confirm restart if prompt-quit is enabled or there are unsaved changes
2023-03-03 16:06:03 -08:00
Julia
b9110c9268
Increase reconnect timeout
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-03 13:10:08 -08:00
Joseph T. Lyons
b9573872e1
Merge pull request #2243 from zed-industries/joseph/z-225-track-open-terminals
...
Keep track of open terminals
2023-03-03 12:55:28 -08:00
Joseph Lyons
3ec71a742d
Keep track of open terminals
...
Co-Authored-By: Petros Amoiridis <petros@hey.com >
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-03-03 12:50:08 -08:00
Mikayla Maki
50682dc685
Merge pull request #2233 from zed-industries/fix-code-folding-initialization
...
Initialize code fold indicators on buffer startup
2023-03-03 12:30:53 -08:00
Julia
2bca64f13b
Merge pull request #2242 from zed-industries/mouse-event-handlers-yes
...
Fix surprising mouse propagation & avoid focusing tab while closing
2023-03-03 12:29:50 -08:00
Mikayla Maki
606d683f29
Add interactable fold markers
...
Change fold handlers to be driven by the fold map
Switch to a mouse region based implementation for click regions
Co-authored-by: Max <max@zed.dev >
2023-03-03 12:26:36 -08:00
Julia
ff2e6bc3bd
Fix surprising mouse propagation & avoid focusing tab while closing
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-03 12:22:58 -08:00
Joseph T. Lyons
218f2fd0fe
Merge pull request #2241 from zed-industries/joseph/z-223-add-terminal-button-to-status-bar
...
Add a terminal button to status bar
2023-03-03 12:15:59 -08:00
Max Brunsfeld
bb0257bbac
Merge branch 'main' into no-panic-uploads-in-debug
2023-03-03 12:02:44 -08:00
Joseph Lyons
929ebd7175
Add a terminal button to status bar
...
Co-Authored-By: Petros Amoiridis <petros@hey.com >
2023-03-03 12:00:41 -08:00
Max Brunsfeld
124aa74b03
Merge pull request #2234 from zed-industries/error-on-combined-injections-in-injections
...
Fix range relativization when combined injections occur inside of other injections
2023-03-03 11:58:13 -08:00
Petros Amoiridis
a2f75eb031
Merge pull request #2240 from zed-industries/petros/update-setup-instructions
...
Add missing steps to the setup instructions
2023-03-03 11:47:38 -08:00
Petros Amoiridis
6194c5df16
Add missing steps to the setup instructions
2023-03-03 11:36:26 -08:00
Max Brunsfeld
d14b684237
Merge pull request #2236 from zed-industries/avoid-clobbering-panic-file
...
Avoid clobbering panic files when they happen at the same time
2023-03-03 11:15:48 -08:00
Max Brunsfeld
7a8cba0544
Merge pull request #2227 from zed-industries/strip-trailing-whitespace
...
Add settings to normalize whitespace on save
2023-03-03 11:15:32 -08:00
Nate Butler
f1b5bf051a
Fornat
2023-03-03 10:58:43 -08:00
Nate Butler
ad4201f768
Hack to fix syntax.constructor causing TS error
2023-03-03 10:58:25 -08:00
Nate Butler
75a9cfdabe
Remove leftover log
2023-03-03 10:22:50 -08:00
Julia
3b6f66791f
Merge pull request #2238 from zed-industries/subpixel-variant-incorrectly-wrapping
...
Avoid wrapping to the 0th glyph variant when the 4th should be used
2023-03-03 13:13:34 -05:00
Julia
9311e01271
Avoid wrapping to the 0th glyph variant when the 4th should be used
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-03-03 10:04:44 -08:00
Nate Butler
6d068e926b
Merge pull request #2237 from zed-industries/revert-2232-tab-bar-background-focus-drag
...
Revert "Avoid tab bar background activating an item at the end of a tab drag"
2023-03-03 09:49:55 -08:00
Nate Butler
6854063d0b
Revert "Avoid tab bar background activating an item at the end of a tab drag"
2023-03-03 09:47:58 -08:00
Mikayla Maki
7ca0b38048
Made fold inline styles be driven by the fold map
...
co-authored-by: Max <max@zed.dev >
2023-03-03 09:32:58 -08:00
Max Brunsfeld
a598f0b13c
Avoid clobbering panic files when they happen at the same time
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-03-02 20:51:29 -08:00
Max Brunsfeld
eb6088701e
Don't upload panic files when running in a PTY
2023-03-02 20:32:49 -08:00
Mikayla Maki
24ba47e75d
Merge pull request #2230 from zed-industries/fix-tab-x
...
Fix tab bar x
2023-03-02 19:48:08 -08:00
Mikayla Maki
3dd5b3f426
Attempted to initialize code-fold indicators, does not work
2023-03-02 19:42:59 -08:00
Mikayla Maki
9f86ca8574
Update tabBar.ts
2023-03-02 15:48:31 -08:00
Julia
bc2ea58c6a
Merge pull request #2232 from zed-industries/tab-bar-background-focus-drag
...
Avoid tab bar background activating an item at the end of a tab drag
2023-03-02 16:18:04 -05:00
Julia
b343e8056a
Avoid tab bar background activating an item at the end of a tab drag
2023-03-02 13:06:58 -08:00
Mikayla Maki
6a2a1303c4
Fix failing license
...
co-authored-by: nate <nate@zed.dev >
2023-03-02 12:32:47 -08:00
Max Brunsfeld
a366ba19af
Fix range relativization when combined injections occur inside of other injections
...
For example, ERB template inside of a markdown code block
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-03-01 14:38:35 -08:00
Max Brunsfeld
70cb2fa8d7
Apply external command formatting if buffer has changed while computing it
2023-03-01 10:17:04 -08:00
Nate Butler
f67c3f1f1d
Add Gruvbox syntax overrides
2023-03-01 11:49:13 -05:00
Nate Butler
bde0456111
Init gruvbox theme
2023-03-01 10:16:45 -05:00
Mikayla Maki
8734bd8435
Seperate out x-mark width
2023-03-01 00:18:45 -08:00
Mikayla Maki
34fbffb4cc
Fix tab bar x
2023-02-28 22:48:31 -08:00
Max Brunsfeld
368d2a73ea
Perform whitespace formatting regardless of whether buffer has a language server or path
2023-02-28 21:52:00 -08:00
Max Brunsfeld
e7b56f6342
adjust buffer-formatting assertion to reflect final newline addition
2023-02-28 21:52:00 -08:00
Max Brunsfeld
1deff43639
Avoid calling edits_since in apply_diff
2023-02-28 21:52:00 -08:00
Max Brunsfeld
a890b8f3b7
Add a setting for ensuring a single final newline on save
2023-02-28 21:52:00 -08:00
Max Brunsfeld
7faa0da5c7
Avoid finalizing transactions inside Buffer::apply_diff
2023-02-28 21:52:00 -08:00
Max Brunsfeld
ff85bc6d42
Add setting for removing trailing whitespace on save
2023-02-28 21:52:00 -08:00
Max Brunsfeld
b00e467ede
Add APIs for stripping trailing whitespace from a buffer
2023-02-28 21:52:00 -08:00
Mikayla Maki
2e1adb0724
Merge pull request #2229 from zed-industries/fix-click-range-bug
...
Fix off by one error in click ranges
2023-02-28 20:33:00 -08:00
Mikayla Maki
269df10a16
Fix off by one error in click ranges
2023-02-28 20:27:34 -08:00
Mikayla Maki
8358efbd6c
Merge pull request #2228 from zed-industries/make-folds-show-on-active-lines
...
Made code fold indicators show up on active line indicators
2023-02-28 20:01:09 -08:00
Mikayla Maki
dc11d2726e
Made code fold indicators show up on active line indicators
2023-02-28 19:53:53 -08:00
Mikayla Maki
41d3c5287b
Merge pull request #2220 from zed-industries/add-fold-indicators
...
Add code folding indicators into the gutter.
2023-02-28 17:30:17 -08:00
Mikayla Maki
2198c295b3
Fix comments
2023-02-28 17:25:35 -08:00
Mikayla Maki
6cf62a5b02
Update tests to use new fold indicator
2023-02-28 17:17:29 -08:00
Mikayla Maki
f8401394f5
Removed DisplayRow abstraction
2023-02-28 17:12:48 -08:00
Mikayla Maki
b53d1eef71
Added background styling of the ...
2023-02-28 16:35:44 -08:00
Mikayla Maki
c397fd9a71
Added click regions and cursor styles
2023-02-28 16:34:28 -08:00
Mikayla Maki
9b8adecf05
Adjusted code-folding behavior
2023-02-28 16:34:28 -08:00
Mikayla Maki
e0f553c0f5
WIp
2023-02-28 16:34:28 -08:00
Mikayla Maki
37a2ef9d41
Make chevrons and lightning bolt interactive
2023-02-28 16:34:28 -08:00
Mikayla Maki
89b93d4f6f
Added fold changes on gutter hover
2023-02-28 16:34:28 -08:00
Mikayla Maki
2036fc48b5
moved code action indicator to the left
2023-02-28 16:34:28 -08:00
Mikayla Maki
cb3e873a67
Fixed autoscroll timing
2023-02-28 16:34:28 -08:00
Mikayla Maki
da78abd99f
Added DisplayRow abstraction to make folding code more readable
2023-02-28 16:34:28 -08:00
Mikayla Maki
637e8ada42
Fix bugs in code folding
2023-02-28 16:34:28 -08:00
Mikayla Maki
e3061066c9
Add code folding indicators into the gutter.
2023-02-28 16:34:28 -08:00
Nate Butler
514da604d7
Merge pull request #2223 from zed-industries/nate/extend-syntax
...
Extend syntax styles available in the theme
2023-02-28 11:26:47 -05:00
Nate Butler
b9811e48e4
One family tune up + tidy
2023-02-28 11:20:16 -05:00
Nate Butler
fb69611568
Fix order of template_substitution in highlights.scm
2023-02-28 11:19:55 -05:00
Nate Butler
a8a045e8bf
Merge branch 'main' into nate/extend-syntax
2023-02-28 11:07:35 -05:00
Nate Butler
59bd503696
Tidy theme names
2023-02-28 10:55:08 -05:00
Nate Butler
fb7818f93c
Revert changes to Andromeda
2023-02-28 10:50:03 -05:00
Joseph T. Lyons
3fb426e8b2
Merge pull request #2209 from zed-industries/add-link-to-community-repo-in-feedback-editor
...
Add link to community repo in feedback editor text
2023-02-28 09:03:21 -05:00
Kay Simmons
f0a31f86c7
remove commented line
2023-02-27 12:06:10 -08:00
Kay Simmons
dc7fe72f18
Merge pull request #2226 from zed-industries/fix-infinite-loop-in-path-distance
...
fix infinite loop in path distance for fuzzy finder
2023-02-27 12:03:40 -08:00
Kay Simmons
b3dffeaf2a
fix infinite loop in path distance for fuzzy finder
2023-02-27 11:57:21 -08:00
Kay Simmons
81cbefec22
Merge pull request #2225 from zed-industries/vim-go-to-definition
...
add go to definition binding to vim normal mode
2023-02-27 11:10:23 -08:00
Joseph Lyons
4f9a07cffc
Merge branch 'main' into add-link-to-community-repo-in-feedback-editor
2023-02-27 13:56:01 -05:00
Kay Simmons
184f37015a
add go to definition binding to vim normal mode
2023-02-27 10:23:30 -08:00
Nate Butler
c9997a81a3
Move syntax types to syntax.ts
2023-02-27 11:01:32 -05:00
Nate Butler
df798c1a7f
Remove punctuation.special until bug is fixed
2023-02-27 10:52:53 -05:00
Nate Butler
465fcec36d
Format
2023-02-27 10:48:55 -05:00
Nate Butler
40c2409b80
Add missing variable property to Syntax
2023-02-27 10:47:52 -05:00
Nate Butler
46dc347a1a
Bring andromeda in line with it's correct colors
2023-02-27 10:47:30 -05:00
Nate Butler
f84046b74f
use @boolean in all flavors of js
2023-02-27 10:40:01 -05:00
Nate Butler
8c51a62a8d
Unify regex highlight style under @string.regex
2023-02-27 10:08:24 -05:00
Nate Butler
794e6e22a6
Format
2023-02-26 17:12:48 -05:00
Nate Butler
504d88d56c
Remove unused code
2023-02-26 17:12:11 -05:00
Nate Butler
94c76c45e6
Style One Dark with new properties
2023-02-26 17:11:02 -05:00
Nate Butler
f2d6a03dff
Finish adding default properties
2023-02-26 17:10:52 -05:00
Nate Butler
3b19a409f8
Add some comments
2023-02-26 15:01:18 -05:00
Nate Butler
7854f4a1ef
WIP need to finish default styles
2023-02-26 14:57:43 -05:00
Nate Butler
6cb35536b3
Start on syntax organization
2023-02-26 14:15:06 -05:00
Nate Butler
161373710c
WIP
2023-02-26 13:24:41 -05:00
Joseph T. Lyons
11e2caff15
Merge pull request #2222 from zed-industries/update-app-icons
...
Update app icons
2023-02-26 11:07:07 -05:00
Joseph Lyons
36ada13966
Update app-icon@2x.png
2023-02-26 11:03:43 -05:00
Joseph Lyons
2c61eeb56d
Update app-icon.png
2023-02-26 11:03:31 -05:00
Joseph Lyons
ccae9448d4
Update app-icon-preview@2x.png
2023-02-26 11:03:22 -05:00
Joseph Lyons
bb46b26494
Update app-icon-preview.png
2023-02-26 11:03:03 -05:00
Nate Butler
098e6969f7
Merge pull request #2221 from zed-industries/theme-syntax-overrides
...
Theme syntax overrides 🎉
2023-02-26 10:56:45 -05:00
Nate Butler
d910eed1f1
Format
2023-02-26 10:31:19 -05:00
Nate Butler
64b07dbfeb
Add syntax overrides for One Light
2023-02-26 10:09:16 -05:00
Nate Butler
4f307c7601
Use syntax as merged name instead of mergedSyntax
...
This lets us retain the existing uses of syntax, and fixes colors that were being assigned incorrectly.
2023-02-26 01:20:44 -05:00
Nate Butler
23c967418a
Add a syntax override style for One Dark
2023-02-26 01:07:45 -05:00
Nate Butler
77ed437cda
Add the ability to override the system syntax config
2023-02-26 01:07:21 -05:00
Kay Simmons
0b1334b8c5
Merge pull request #2218 from zed-industries/file-finder-distance-sorting
...
Sort matches in file finder by distance to active item after score
2023-02-25 14:26:05 -08:00
Kay Simmons
cdc6566d87
fixup poor utility naming
2023-02-25 14:12:25 -08:00
Kay Simmons
36f3d3d738
Add test for new sorting behavior
2023-02-25 14:06:54 -08:00
Nate Butler
27712c25ef
Merge pull request #2219 from zed-industries/nate/theme-tidying
...
Tidy `styles` app
2023-02-25 12:07:02 -05:00
Nate Butler
68af726ee4
Update packages
...
Tested post update.
2023-02-25 11:53:01 -05:00
Nate Butler
0ea7959ba4
Remove unused/old base16 theme code
...
Neither of these files have anything in them that is used anywhere else in the styles app.
Tested both `build` and `build-licenses` after removing these.
2023-02-25 11:50:22 -05:00
Nate Butler
bcb7b80517
Don't format package or package-lock
2023-02-25 11:47:27 -05:00
Nate Butler
10a30cf330
Format styles with updated prettier config
...
In the system color PR I updated the prettier config to match what we use on zed.dev. I didn't want to format all of styles as it would add a lot of unrelated line changes to that PR.
Doing that format now.
2023-02-25 11:46:33 -05:00
Nate Butler
06a86162bb
Merge pull request #2150 from zed-industries/nate/system-colors
...
Add system color palette
2023-02-25 11:43:02 -05:00
Nate Butler
b986c38a31
Format using new prettier config
2023-02-25 11:33:57 -05:00
Nate Butler
69fd273367
Add the same prettier config as zed.dev
2023-02-25 11:33:16 -05:00
Nate Butler
8e828947fb
Add missing dep
2023-02-25 11:32:04 -05:00
Nate Butler
2d8adf4c56
Remove theme tool for now
...
This is likely the biggest thing I'm unsure about for this PR, so I'm going to pull it into a seperate branch so I can merge the system color library in.
I think a better approach for this will be one of two things:
- Have a single next app that covers everything to do with themes (previewing ramps, generated themes, components etc.)
- Create a mono or turborepo that splits things up into packages (system, theme, themes, theme-tool, etc)
2023-02-25 11:27:18 -05:00
Kay Simmons
0b48e238f2
Sort file finder matches by distance to the active item after match score
2023-02-24 18:13:26 -08:00
Max Brunsfeld
04495aa8cd
Merge pull request #2217 from zed-industries/format-on-save-trigger
...
Pass the 'Save' format trigger when formatting on save
2023-02-24 17:29:52 -08:00
Max Brunsfeld
5fea49e639
Pass the 'Save' format trigger when formatting on save
...
In an earlier refactor, I accidentally caused the 'Manual'
trigger to *always* be passed.
Co-authored-by: Mikayla Maki <mikayla@zed.dev >
2023-02-24 17:11:35 -08:00
Mikayla Maki
0704d9dcdb
Merge pull request #2216 from zed-industries/update-bromberg
...
Update bromberg dependency to have alloc
2023-02-24 14:41:32 -08:00
Mikayla Maki
a57fcf5afc
Update bromberg dependency to have alloc
2023-02-24 14:34:24 -08:00
Max Brunsfeld
e910fd8493
collab 0.6.1
2023-02-24 09:44:23 -08:00
Mikayla Maki
d5123bc832
Merge pull request #2215 from zed-industries/revert-2214-fix-reveal-path-panic
...
Revert "Remove borrow from reveal_path()"
2023-02-24 09:40:03 -08:00
Mikayla Maki
8656708de4
Revert "Remove borrow from reveal_path()"
2023-02-24 09:39:52 -08:00
Joseph Lyons
72197802a2
Tweak code to remove duplication
2023-02-24 08:53:58 -05:00
Joseph Lyons
f8f1a3f86e
Unify text style names
2023-02-24 08:46:28 -05:00
Mikayla Maki
2ec25bef84
Merge pull request #2214 from zed-industries/fix-reveal-path-panic
...
Remove borrow from reveal_path()
2023-02-23 21:48:09 -08:00
Mikayla Maki
89ddf14b0e
Remove borrow from reveal_path()
2023-02-23 21:36:17 -08:00
Julia
be86cb35ba
Merge pull request #2213 from zed-industries/per-project-follow-status
...
Differentiate between follow state on a per-project basis
2023-02-24 00:26:41 -05:00
Julia
465d8cc2ff
Differentiate between follow state on a per-project basis
2023-02-24 00:07:17 -05:00
Max Brunsfeld
93b9e762ec
Merge pull request #2212 from zed-industries/initial-traffic-light-position
...
Adjust window's traffic light position when setting its title
2023-02-23 15:02:05 -08:00
Max Brunsfeld
fbc934b884
Adjust window's traffic light position when setting its title
2023-02-23 14:44:45 -08:00
Mikayla Maki
350b7b82f7
Merge pull request #2207 from zed-industries/project-panel-actions
...
Fix project panel actions
2023-02-23 14:31:29 -08:00
Mikayla Maki
b179fc2b99
Remove comment
2023-02-23 14:24:53 -08:00
Mikayla Maki
8860346324
Fix broken dock command
2023-02-23 14:15:29 -08:00
Mikayla Maki
9004640586
Convert keymap context to use generics and Cow<'static> so we don't have to add .to_string() and .into() for each usage
2023-02-23 14:10:55 -08:00
Kay Simmons
03498314fa
Merge pull request #2211 from zed-industries/hover-binding
...
add hover binding from vscode
2023-02-23 14:05:28 -08:00
Kay Simmons
ce4b672a14
add hover binding from vscode
2023-02-23 13:50:43 -08:00
Kay Simmons
3f9405f8f1
Merge pull request #2210 from zed-industries/fix-enter-vim-normal-mode
...
Fix enter in normal mode acting incorrectly
2023-02-23 13:46:15 -08:00
Kay Simmons
2276d25bdf
Fix enter in normal mode acting incorrectly
2023-02-23 13:40:31 -08:00
Mikayla Maki
ffe53bed87
Reverts keymap precedence order change
2023-02-23 13:32:45 -08:00
Joseph Lyons
37f910949d
Add link to community repo in feedback editor
2023-02-23 16:30:00 -05:00
Julia
1e3b4f0387
Merge pull request #2208 from zed-industries/new-collab-ui-3
...
Add same grayscale logic to followers which leaders have; new call UI [3/N]
2023-02-23 16:05:42 -05:00
Julia
e1df85e86d
Add same grayscale logic to followers which leaders have
2023-02-23 15:59:37 -05:00
Mikayla Maki
f6601f64e5
Added editor-in-project-panel overrides to the default keymap
2023-02-23 09:36:30 -08:00
Antonio Scandurra
6ccc90327c
Merge pull request #2206 from zed-industries/fix-refresh-room
...
Fix error when deleting rooms containing projects on refresh
2023-02-23 16:03:14 +01:00
Antonio Scandurra
bbeb33bc7e
Fix error when deleting rooms containing projects on refresh
...
A foreign key violation was causing the server to never delete stale
rooms during `Database::refresh_room` due to having one or more project
records referencing the room.
2023-02-23 15:54:35 +01:00
Antonio Scandurra
e74db2d180
Merge pull request #2205 from zed-industries/call-ui-follow-up
...
Refine new call UI
2023-02-23 15:39:59 +01:00
Antonio Scandurra
74e0bed38f
Fix compilation errors after restructuring room_transaction
2023-02-23 15:17:22 +01:00
Antonio Scandurra
832549f1a3
Merge branch 'main' into call-ui-follow-up
2023-02-23 15:15:46 +01:00
Antonio Scandurra
b965333325
Show avatar in user menu
2023-02-23 15:09:32 +01:00
Joseph T. Lyons
2be0283bf2
Merge pull request #2204 from zed-industries/fix-description-of-telemetry-setting
...
Fix description of telemetry setting
2023-02-23 08:59:30 -05:00
Antonio Scandurra
59a66190e5
Avoid trying to reconnect to a room if client is signed out
2023-02-23 14:53:10 +01:00
Antonio Scandurra
9334267bd0
Tear down peer when signing out
2023-02-23 14:47:02 +01:00
Antonio Scandurra
a0daf47134
Don't panic when rendering collab titlebar item while signed out
2023-02-23 14:46:02 +01:00
Petros Amoiridis
9a729a2e64
Merge pull request #2202 from zed-industries/petros/z-86-replace-terminal-tab-title-with-an-icon
...
Replace terminal tab title with an icon
2023-02-23 11:04:43 +02:00
Antonio Scandurra
1c636500de
Merge pull request #2200 from zed-industries/fix-slow-project-join
...
Hold room lock through the entirety of a `room_transaction`
2023-02-23 09:11:58 +01:00
Max Brunsfeld
65a9ac449f
Remove leave button from the title bar
2023-02-22 23:30:32 -08:00
Max Brunsfeld
bf5c3d963a
Rearrange collab titlebar items to avoid movement of the toggle contacts button
...
* Replace username in titelbar with a `...` user menu that shows
the current user name and contains a sign-in/sign-out button.
* Move the '+' (toggle contacts) button back to the right side.
* Move the collaborators back to the right side.
* Move the share/unshare button to the left side, beside the project title
* Only show the share/unshare button when in a call.
2023-02-22 22:56:11 -08:00
Joseph Lyons
c33d0f940a
Fix description of telemetry setting
2023-02-22 23:50:20 -05:00
Max Brunsfeld
24e0a027ee
Run check-formatting CI job on a mac mini
2023-02-22 15:35:05 -08:00
Max Brunsfeld
d49e35f947
Merge pull request #2203 from zed-industries/collab-ui-fixes
...
Fix minor issues with new collab UI
2023-02-22 14:22:05 -08:00
Max Brunsfeld
40aee8d7bc
Add missing tooltip for contacts menu button
...
Co-authored-by: Joseph Lyons <joseph@zed.dev >
2023-02-22 14:18:17 -08:00
Max Brunsfeld
d33d27faa4
Fix ToggleContactsMenu action name in keymap
...
Co-authored-by: Joseph Lyons <joseph@zed.dev >
2023-02-22 14:17:59 -08:00
Max Brunsfeld
46ead28971
Bump RPC protocol version number
2023-02-22 13:40:14 -08:00
Max Brunsfeld
111aff29cc
collab 0.6.0
2023-02-22 12:35:15 -08:00
Max Brunsfeld
e2a2e40599
v0.76.x dev
2023-02-22 12:34:29 -08:00
Max Brunsfeld
b73423daaa
Merge pull request #2114 from zed-industries/new-collaboration-ui
...
New collaboration UI part 1/N
2023-02-22 12:32:41 -08:00
Julia
0324ca3b08
Be more specific about clearing (leader, follower) row
...
Previously anyone unfollowing someone would clear all other rows for
other followers leading to an incorrect state, fix and test
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 15:29:20 -05:00
Julia
36040cd0e1
Add top level leave call button
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 14:44:23 -05:00
Julia
a07867d628
Fiddle with titlebar item spacing
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 14:13:29 -05:00
Julia
812145f9ab
Only show in-call share/unshare button if own project
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 13:40:43 -05:00
Julia
dbe5b0205c
Add style leader selection container
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 13:36:06 -05:00
Petros Amoiridis
3d6c81584f
Add an icon to the terminal view tab
...
The terminal icon already existed in `assets/icons`
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-22 20:30:44 +02:00
Petros Amoiridis
81ece4fd44
Deduplicate tab theme related code
...
We've noticed that the search theme struct had two fields for a tab icon width and spacing. But we already have those in the tab theme struct. We decided to remove the duplicate and reuse the tab fields.
We also wanted to move where the spacing is being used. Instead of doing it at the left of the label, we do it at the right of the icon to match how it is done in other areas of the UI.
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-22 20:28:57 +02:00
Petros Amoiridis
2ec5c88f98
Make icon width match other areas
...
This was 8 but we've seen areas where this was 14, like the project search tab icon. We want to match this.
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-22 20:25:39 +02:00
Mikayla Maki
7b559176f1
Merge pull request #2201 from zed-industries/save-shortcuts
...
Add OS UI Keybindings
2023-02-22 09:16:19 -08:00
Mikayla Maki
d7305077bf
Merge pull request #2198 from zed-industries/more-item-defaults
...
Add more default impls to the item trait
2023-02-22 09:14:12 -08:00
Mikayla Maki
4798b72cb8
Fixed keyboard shortcuts in mac os native panels
...
co-authored-by: Antonio <antonio@zed.dev >
2023-02-22 09:10:16 -08:00
Mikayla Maki
71d8ead318
Introduce an OSAction that can be associated with menu items for mac platform compatibility.
...
Co-authored-by: Antonio <antonio@zed.dev >
2023-02-22 09:02:31 -08:00
Julia
9b92a8e3fe
Add mockup accurate avatar background
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 11:34:55 -05:00
Julia
7f4da80386
Initial dedicated face pile element
...
Rather than overload Flex with yet another special case, add a dedicated
element to handle this overlap instead
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 11:34:55 -05:00
Julia
6a731233c5
Remove Flex::with_reversed_pain_order
2023-02-22 11:34:55 -05:00
Max Brunsfeld
b7cf426908
Start work on styling of follower avatars in facepiles
...
* Make follower avatars smaller than top-level avatars
* Make avatars in facepiles overlap
* Render an opaque background behind avatars in facepiles.
2023-02-22 11:34:55 -05:00
Max Brunsfeld
0dc92bec5c
Retrieve room id from the project when following/unfollowing
...
Previously, we were accidentally using the project id as the room id.
2023-02-22 11:34:55 -05:00
Julia
c75aca25b6
Remove left side collaborator list
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 11:34:55 -05:00
Julia
ae87961a77
Close contacts popover when call ends
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-02-22 11:34:55 -05:00
Julia
e9464815e0
Make tooltip lie less
2023-02-22 11:34:55 -05:00
Julia
1ed47663ef
Avoid moving contacts popover during call start & add button style state
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-02-22 11:34:55 -05:00
Julia
dd02bc7748
Initial adding of contact menu to call-less share button
2023-02-22 11:22:37 -05:00
Julia
e403b868b7
Add followers table to sqlite scheme for tests
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-02-22 11:22:37 -05:00
Julia
3105ecd0bd
Shuffle share/unshare button back to the right side
2023-02-22 11:22:37 -05:00
Julia
05e9615507
Highlight face pile which local user is following
2023-02-22 11:22:37 -05:00
Julia
1abb7794cb
Handle case where follower is local user
2023-02-22 11:22:37 -05:00
Julia
50e681bbb1
Add username to right side
2023-02-22 11:22:37 -05:00
Julia
3fb8395085
Make things a bit more infallible
2023-02-22 11:22:37 -05:00
Julia
4513c40993
Following face piles finally take their first breath
2023-02-22 11:21:23 -05:00
Julia
4ffc8cd9fd
Fix deadlock in db get_room
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-22 11:21:23 -05:00
Julia
33c265d3cf
Abuse a closure instead of abusing options/iterators quite so much
2023-02-22 11:21:23 -05:00
Julia
58c41778e7
Absolute pain of the iterator kind (start laying out a user's followers)
2023-02-22 11:21:23 -05:00
Julia
2592ec7265
Initial tracking of unfollows on collab server
2023-02-22 11:21:23 -05:00
Julia
d6462c611c
Begin tracking follow states on collab server
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-02-22 11:21:23 -05:00
Julia
28786a3c18
Add Flex with_reversed_paint_order & initially move face piles to left
...
Co-Authored-By: Petros Amoiridis <petros@zed.dev >
2023-02-22 11:21:23 -05:00
Julia
a5fd0250ab
Start fleshing out layout of collaborator list entries
...
Co-Authored-By: Petros Amoiridis <petros@zed.dev >
2023-02-22 11:21:23 -05:00
Julia
f68eda97fb
Tell project when it has been unshared
...
Co-Authored-By: Petros Amoiridis <petros@zed.dev >
2023-02-22 11:21:23 -05:00
Julia
99236f1875
Add collaborators to collaborator list, including self user
2023-02-22 11:21:23 -05:00
Julia
bf8658067f
Add collaborator count to collaborator list button
2023-02-22 11:21:23 -05:00
Julia
c697c1a96a
Switch collaborator list to using own style
2023-02-22 11:21:23 -05:00
Julia
2b6aa3f5d1
Begin adding collaborator list popover
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-02-22 11:21:23 -05:00
Julia
e96d52f35a
Move share button and support unsharing
2023-02-22 11:21:23 -05:00
Julia
ed2f1ddd2d
Move workspace title into collaboration titlebar item render
2023-02-22 11:21:11 -05:00
Antonio Scandurra
8dd249a7cd
Hold room lock through the entirety of a room_transaction
...
Previously, when the host repeatedly sent `UpdateWorktree` messages,
new guests attempting to join a project would observe a severe slowdown
caused by a database serialization error (e.g., the coherence of the data
would get violated midway through `Database::join_project` due to worktree
entries being mutated as the user joined). Writing entries is pretty fast,
whereas reading all of them for a project can take more than 100ms.
Transactions that failed due to a serialization error are retried, but the guest
would keep retrying until the host finished writing because the guest's read
was slow.
This commit changes the semantics of `room_transaction` to acquire a room
lock before even starting the transaction and holding it all the way after
commit (storing it, as before, in the `RoomGuard`). This ensures that a fast
writer (the host) can't starve a slow reader (the guest), allowing the latter
to make progress by temporarily pausing writes by the former.
2023-02-22 16:04:29 +01:00
Kay Simmons
24fcad3fa2
Merge pull request #2189 from zed-industries/labeled-tasks
...
Labeled Tasks
2023-02-21 21:31:47 -08:00
Kay Simmons
46af9a90ce
fix test warning
2023-02-21 21:13:03 -08:00
Kay Simmons
1c69e289b7
Fix formatting
2023-02-21 21:07:45 -08:00
Mikayla Maki
9d782be4c8
Remove now-default stubs
2023-02-21 17:51:49 -08:00
Mikayla Maki
cae9e733a1
Add more default impls to the item trait
...
Change pane to not split if the underlying item cannot be cloned
2023-02-21 17:29:39 -08:00
Mikayla Maki
77c396a0ab
Merge pull request #2197 from zed-industries/label-text-cow
...
Changed label and text to be generic over static and owned strings
2023-02-21 17:05:57 -08:00
Mikayla Maki
b500ed3171
Changed label and text to be generic over static strings and owned strings
2023-02-21 16:47:29 -08:00
Kay Simmons
6b6e4e3bfe
Add basic test for labeled tasks
2023-02-21 16:14:22 -08:00
Joseph T. Lyons
1683a54698
Merge pull request #2195 from zed-industries/add-reveal-in-finder-to-additional-locations
2023-02-21 18:48:16 -05:00
Mikayla Maki
14488619a3
Merge pull request #2196 from zed-industries/open_urls
...
Fix open URLs, restarts, and make bundling easier to use
2023-02-21 15:36:50 -08:00
Mikayla Maki
cf4e719484
Fixes a race condition in the restart implementation
...
Fixes open_urls racing workspace initialization and causing a double-open (community#927)
Adds a -d flag to the bundle script to compile in debug mode
Co-Authored-by: Max <max@zed.dev >
2023-02-21 15:28:16 -08:00
Joseph Lyons
8c3232bb9b
Add reveal in finder to additional locations
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-21 16:09:11 -05:00
Joseph Lyons
ebf1da1de8
Remove print macros
2023-02-21 10:46:12 -05:00
Kay Simmons
3564e95f27
Add labeled tasks to gpui and observe them in the activity status to give feedback when we are still waiting for the language server
2023-02-20 20:28:48 -08:00
Max Brunsfeld
ecf77a510a
Merge pull request #2194 from zed-industries/window-position-env-vars
...
Fix handling of ZED_WINDOW_{SIZE,POSITION} env vars
2023-02-20 15:29:51 -08:00
Max Brunsfeld
927f7b3363
Fix handling of ZED_WINDOW_{SIZE,POSITION} env vars
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2023-02-20 15:11:20 -08:00
Max Brunsfeld
07bb42898f
Merge pull request #2193 from zed-industries/autoclose-fixes
...
Restructure scope-specific auto-close pairs, fix regression in skipping over auto-closed brackets
2023-02-20 13:51:29 -08:00
Max Brunsfeld
a11165ad0a
Add unit test for auto-closing quotation marks with overrides
2023-02-20 13:46:17 -08:00
Max Brunsfeld
ab82e13167
Run cargo fmt
2023-02-20 11:10:30 -08:00
Julia
0e0170712e
Merge pull request #2192 from zed-industries/format-ci-enforcement
...
Enforce rustfmt on CI & clean up some let-else format errors
2023-02-20 13:55:34 -05:00
Max Brunsfeld
8be844a13f
Add test that loads all bundled languages
2023-02-20 10:53:37 -08:00
Max Brunsfeld
7c98395e77
Add missing comment pattern to TSX overrides query
2023-02-20 10:53:37 -08:00
Max Brunsfeld
8922156923
Restructure how bracket pairs are overridden to unify lists
...
This way, a bracket pair that is disabled in a given scope can still be skipped, if
it was auto-closed before that scope existed.
2023-02-20 10:53:37 -08:00
Max Brunsfeld
51cea1b1fb
Merge branch 'main' into randomized-tests-operation-script
2023-02-20 10:39:00 -08:00
Julia
bda37ffb9c
Enforce rustfmt on CI & clean up some let-else format errors
2023-02-20 13:27:35 -05:00
Max Brunsfeld
2982a98d1c
Merge pull request #2187 from zed-industries/save-untitled-buffer-bugs
...
Fix newly-discovered bugs in saving untitled buffers
2023-02-20 10:05:58 -08:00
Max Brunsfeld
010eba509c
Make Project::save_buffer and ::save_buffers into methods
2023-02-20 09:42:44 -08:00
Max Brunsfeld
56b7eb6b6f
Only send UpdateBufferFile messages for buffers whose files have changed
...
Send that message when saving a buffer as a new path.
2023-02-20 09:41:59 -08:00
Petros Amoiridis
6551742c58
Merge pull request #2191 from zed-industries/petros/z-53-reveal-in-finder-crashes-zed
...
Move reveal_path to ForegroundPlatform
2023-02-20 19:09:54 +02:00
Petros Amoiridis
4bb986b3be
Move reveal_path to ForegroundPlatform
...
So that we can use spawn to use the OS API call.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-02-20 18:57:37 +02:00
Kay Simmons
efafd1d8d3
Merge pull request #2188 from zed-industries/dont-open-project-items-in-dock
...
Dont open project items in dock
2023-02-18 13:53:29 -08:00
Kay Simmons
0981244797
further tweak comment
2023-02-18 13:53:13 -08:00
Kay Simmons
159d3ab00c
Add comment explaining push_keystroke
2023-02-18 13:49:08 -08:00
Kay Simmons
3fb6e31b92
revert for loop change and store matched actions in a sorted set instead
2023-02-18 13:42:28 -08:00
Kay Simmons
04df00b221
Iterate over keymap then dispatch path when matching keybindings to make precedence more intuitive
...
Rename action which adds the active tab to the dock to be more intuitive
Add action which moves the active tab out of the dock and bind it to the same keybinding
2023-02-18 13:10:01 -08:00
Kay Simmons
dc6f7fd577
pull toggle button into its own file
2023-02-18 12:32:19 -08:00
Kay Simmons
ac3e8f61ef
Merge pull request #2186 from zed-industries/better-vim-matching-motion
...
Better vim matching motion
2023-02-17 22:10:28 -08:00
Kay Simmons
fc811d14b1
Fix failing test
2023-02-17 22:00:39 -08:00
Max Brunsfeld
cdf64b6cad
Unify save and save_as for local worktrees
...
This fixes state propagation bugs due to missing RPC calls in save_as.
2023-02-17 17:21:48 -08:00
Max Brunsfeld
3a7cfc3901
Move the save and save_as code paths close together
2023-02-17 17:21:48 -08:00
Kay Simmons
5e4d113308
fix bracket ranges failing test
2023-02-17 17:19:23 -08:00
Max Brunsfeld
de6eb00e2b
Start work on making save and save_as code paths more similar
2023-02-17 15:52:13 -08:00
Max Brunsfeld
76975c29a9
Refactor: split Project::format logic into local and remote cases
2023-02-17 15:29:54 -08:00
Kay Simmons
57a7ff9a6f
fix vim percent motion to better match the docs and observed behavior
2023-02-17 14:55:19 -08:00
Max Brunsfeld
eebce28b32
Respect UpdateBufferFile messages on guest buffers without file
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2023-02-17 12:38:04 -08:00
Max Brunsfeld
31dac39e34
Fix assignment of language to formerly-untitled buffers
...
When lazy-loading a language, check if it matches plain text buffers.
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2023-02-17 11:12:57 -08:00
Mikayla Maki
5cfe206433
Merge pull request #2185 from zed-industries/refactor-restart
...
Used the pre-existing app_path call in the GPUI platform
2023-02-17 10:39:45 -08:00
Mikayla Maki
ff2fb06b2c
Used the pre-existing app_path call in the GPUI platform
2023-02-17 10:30:28 -08:00
Mikayla Maki
a5ad2f544e
Update README.md
2023-02-16 16:51:57 -08:00
Mikayla Maki
7b291df21f
Merge pull request #2184 from zed-industries/relaunch
...
Restart
2023-02-16 16:50:20 -08:00
Mikayla Maki
6e33f33da1
Switch to open based restarting
2023-02-16 16:47:43 -08:00
Mikayla Maki
4ea7a24b93
Made the 'update zed to collaborate' button clickable
2023-02-16 14:53:50 -08:00
Julia
48b76f96fc
Merge pull request #2183 from zed-industries/default-settings-yaml-casing
...
Use correct case for YAML in default settings
2023-02-16 16:37:37 -05:00
Julia
c72a50e203
Use correct case for YAML in default settings
2023-02-16 16:37:07 -05:00
Mikayla Maki
43f61ab413
Added action to autoupdate
2023-02-16 13:35:32 -08:00
Mikayla Maki
cf83ecccbb
Added workspace restart command
2023-02-16 13:28:56 -08:00
Kay Simmons
848c6b78d5
Merge pull request #2181 from zed-industries/update-typesript-tree-sitter
...
update tree-sitter-typescript to add support for new satisfies operator
2023-02-16 12:56:40 -08:00
Max Brunsfeld
b90fc046ca
Merge pull request #2180 from zed-industries/turbofish-highlight
...
Highlight functions called with a turbofish in Rust
2023-02-16 12:52:37 -08:00
Max Brunsfeld
98b51634c4
Merge pull request #2182 from zed-industries/faster-injections
...
Fix syntax-related performance problems on gigantic files
2023-02-16 12:52:13 -08:00
Max Brunsfeld
28eb69e74e
Bump tree-sitter for optimization of querying in range
2023-02-16 12:35:35 -08:00
Kay Simmons
b03eebeb6c
update tree-sitter-typescript to add support for new satisfies operator
2023-02-16 12:24:35 -08:00
Kay Simmons
eac33d732e
wip
2023-02-16 12:23:45 -08:00
Max Brunsfeld
2d39358323
rust: Highlight functions called with a turbofish
2023-02-16 12:11:57 -08:00
Joseph T. Lyons
a4a179763a
Merge pull request #2171 from zed-industries/add-option-to-advance-cursor-downward-when-toggling-comment
...
Add option to advance cursor downward when toggling comment
2023-02-16 15:03:38 -05:00
Julia
19b686ad65
Merge pull request #2177 from zed-industries/check-before-test
...
Cargo check before test to catch warnings/errors
2023-02-16 14:43:33 -05:00
Antonio Scandurra
ac882c7db5
Merge pull request #2179 from zed-industries/debounce-diagnostics
...
Simulate disk-based diagnostics finishing 1s after saving buffer
2023-02-16 16:34:19 +01:00
Antonio Scandurra
baee6d0342
Simulate disk-based diagnostics finishing 1s after saving buffer
...
Previously, we would simulate disk-based diagnostics finishing after
saving a buffer. However, the language server may produce diagnostics
right after emitting the event, causing the diagnostics status bar item
to not reflect the latest state of the buffer.
With this change, we will instead simulate disk-based diagnostics finishing
after 1s after saving the buffer (only for language servers that
don't have the concept of disk-based diagnostics, such as TypeScript). This
ensures we always reflect the latest state and doesn't cause the UI to flicker
as a result of the LSP sending us diagnostics after every input.
2023-02-16 16:04:08 +01:00
Julia
50ccf16de1
Cargo check before test to catch warnings/errors
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-02-15 17:53:28 -05:00
Kay Simmons
bef2013c7f
wip
2023-02-15 14:40:14 -08:00
Kay Simmons
2c904cb0bf
Merge pull request #2176 from zed-industries/better-move-to-brackets
...
Make jump to matching bracket action more predictable
2023-02-15 14:32:51 -08:00
Kay Simmons
33306846a6
add tree-sitter-typescript to editor crate test support features
2023-02-15 14:28:50 -08:00
Kay Simmons
30caeeaeb5
fix comment typo
2023-02-15 14:11:00 -08:00
Kay Simmons
0ba051a754
use more predictable rules for selecting which bracket to jump to and where
2023-02-15 14:04:16 -08:00
Max Brunsfeld
32191e318e
Merge pull request #2175 from zed-industries/restore-toggle-dock-binding
...
Put back shift-escape binding for FocusDock action
2023-02-15 14:04:01 -08:00
Max Brunsfeld
7037842bef
Put back shift-escape binding for FocusDock action
2023-02-15 13:57:07 -08:00
Julia
8bd20d8c3a
Merge pull request #2173 from zed-industries/tab-bar-background-focus-pane
...
Focus pane when clicking on tab bar background
2023-02-15 16:07:10 -05:00
Julia
df1775326c
Merge pull request #2172 from zed-industries/window-title-shenanigans
...
Window title shenanigans
2023-02-15 16:03:30 -05:00
Julia
df0715e7c9
Indicate in native window title if project is shared or remote
2023-02-15 15:56:16 -05:00
Julia
e56dfd9177
Tell OS about window title
2023-02-15 15:55:55 -05:00
Joseph Lyons
afb375f909
v0.75.x dev
2023-02-15 14:57:51 -05:00
Joseph T. Lyons
bcf7a32284
Update pull_request_template.md
2023-02-15 14:10:23 -05:00
Joseph Lyons
5fbc9736e5
Add option to advance cursor downward when toggling comment
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-15 14:00:49 -05:00
Petros Amoiridis
fbd23986e3
Merge pull request #2161 from zed-industries/community/3-reveal-in-finder
...
Introduce Reveal in Finder
2023-02-15 16:11:04 +02:00
Antonio Scandurra
114eef8592
Merge pull request #2170 from zed-industries/fix-persistent-lsp-messages
...
Fix LSP status messages persisting
2023-02-15 15:09:01 +01:00
Antonio Scandurra
5df50e2fc9
Add timeouts to HTTP client
2023-02-15 15:00:44 +01:00
Petros Amoiridis
7a667f390b
Use open_url from the platform module
...
And remove the open function from the `util` crate.
2023-02-15 15:58:57 +02:00
Antonio Scandurra
2482a1a9ce
Add timeout to HTTP requests during npm info and npm fetch
2023-02-15 14:48:36 +01:00
Antonio Scandurra
7641965326
Merge pull request #2169 from zed-industries/improve-autocomplete
...
Score matches case-sensitively when query contains an uppercase char
2023-02-15 13:30:05 +01:00
Antonio Scandurra
8db131a3a1
Score matches case-sensitively when query contains an uppercase char
2023-02-15 13:12:45 +01:00
Mikayla Maki
4f1e8c953e
Merge pull request #2168 from zed-industries/auto-update-setting
...
Add auto update setting
2023-02-14 18:10:56 -08:00
Mikayla Maki
c2de0f6b5e
Add auto update setting
2023-02-14 18:05:42 -08:00
Mikayla Maki
17e8172dc3
Merge pull request #2167 from zed-industries/clear-terminal-highlights
...
Reset search matches when the terminal is cleared
2023-02-14 10:02:06 -08:00
Mikayla Maki
8e9d95fefc
Fix error where terminal search matches wouldn't be updated when clearing
2023-02-14 09:54:31 -08:00
Julia
3a7ac9c0ff
Focus pane when clicking on tab bar background
2023-02-14 12:39:29 -05:00
Antonio Scandurra
88c6b890bc
Merge pull request #2165 from zed-industries/toggle-soft-wrap
...
Introduce `editor: toggle soft wrap` bound to `alt-z`
2023-02-14 15:27:31 +01:00
Antonio Scandurra
1012cea4af
Soft wrap at editor width if it's narrower than preferred line length
2023-02-14 15:22:00 +01:00
Antonio Scandurra
4a2b7e4820
Use alt-z to toggle soft wrap in active editor
...
When there isn't a default soft-wrapping for the active editor, we
will soft wrap at the editor width. This is consistent with Visual
Studio Code.
2023-02-14 15:16:06 +01:00
Antonio Scandurra
6c0b35acb0
Merge pull request #2164 from zed-industries/fix-surround-rust-star
...
Surround with bracket only when opening brace is 1 character long
2023-02-14 14:42:13 +01:00
Antonio Scandurra
888fcb5b1b
Surround with bracket only when opening brace is 1 character long
2023-02-14 14:36:18 +01:00
Petros Amoiridis
015b8db1c3
Introduce reveal_path in Platform
...
And implement it for MacPlatform, and instead of using an external process to run `open`, use the NSWorkspace selectFile instance method.
2023-02-14 15:14:15 +02:00
Antonio Scandurra
ebe1fa7a96
Merge pull request #2163 from zed-industries/quick-invite-bug
...
Avoid creating more than one room when inviting multiple people at once
2023-02-14 12:55:21 +01:00
Antonio Scandurra
7be868e372
Avoid creating more than one room when inviting multiple people at once
...
Previously, when initiating a call by calling multiple people, only
the first person would get the call while all the others would briefly
show a "pending" status but never get the call.
This would happen because `ActiveCall` was trying to a create a different
room for each person called, because the original room creation hadn't finished
and so a `ModelHandle<Room>` wasn't being store in the active call.
With this commit, only one room can be created at any given time and further
invites have to wait until that room creation is done.
2023-02-14 12:03:30 +01:00
Antonio Scandurra
087d51634d
Fix test that wasn't properly verifying disconnection from livekit
2023-02-14 10:46:29 +01:00
Max Brunsfeld
ea663f3017
Bump tree-sitter for tree-balancing bugfix
2023-02-13 23:46:44 -08:00
Kay Simmons
5041300b52
Merge pull request #2157 from zed-industries/vim-fixes
...
Vim fixes
2023-02-13 14:21:47 -08:00
Kay Simmons
2c9199fd32
fix build error
2023-02-13 14:12:43 -08:00
Kay Simmons
327932ba3b
Remove catch all keymap and KeyPressed action
2023-02-13 13:50:37 -08:00
Kay Simmons
459060764a
fix sqlez warning, introduce tab and enter bindings to vim for inputing tab and enter text when waiting for text
2023-02-13 13:50:37 -08:00
Kay Simmons
3d53336916
More vim fixes and move some more things out of app.rs
2023-02-13 13:50:37 -08:00
Kay Simmons
c1812ddc27
fix issue with single line editors in vim not properly unhooking vim mode bindings
2023-02-13 13:50:37 -08:00
Mikayla Maki
d80dba1fe3
Switch from vec to smallvec
2023-02-13 12:49:57 -08:00
Antonio Scandurra
6703264600
Limit BufferSnapshot::chunks to the outline item range
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-02-13 19:57:15 +01:00
Nate Butler
5ce147a2ad
Remove unneeded API from theme-tool
2023-02-12 21:04:54 -05:00
Nate Butler
a32c0d1c9b
Update colors.
2023-02-12 21:04:31 -05:00
Nate Butler
e65c0810ba
Add gray color families
2023-02-12 20:02:51 -05:00
Nate Butler
1fcfa5d272
Generate color meta, document functions and tidy.
2023-02-12 19:45:16 -05:00
Nate Butler
addfcdc1f4
Remove bezier-easing from styles
...
This was installed in the wrong app
2023-02-12 11:59:36 -05:00
Nate Butler
4501a5a7ee
Add initial system palette reference colors
2023-02-12 00:15:41 -05:00
Nate Butler
a120996f0d
Test using HSL + curves to build a scale
2023-02-11 23:34:46 -05:00
Joseph T. Lyons
0a50d271b7
Merge pull request #2158 from zed-industries/split-feedback-editor
...
Split up feedback_editor.rs
2023-02-11 23:19:25 -05:00
Joseph T. Lyons
01a590a1fb
Merge pull request #2160 from zed-industries/remove-toggle-right-sidebar-command
...
Remove toggle right sidebar command
2023-02-11 22:17:38 -05:00
Joseph Lyons
d42d495cb0
Remove toggle right sidebar command
2023-02-11 21:53:10 -05:00
Nate Butler
187fac1579
Allow passing a chroma color as a start/mid/end color
2023-02-11 21:10:47 -05:00
Nate Butler
0acb820f04
Document ref/color further
2023-02-11 08:14:13 -05:00
Nate Butler
dda0febf39
Organize
2023-02-11 07:56:41 -05:00
Petros Amoiridis
9143790602
Include code only on macOS
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-02-11 11:12:46 +02:00
Kay Simmons
b31813fad3
Split concepts out into self contained files in feedback editor
2023-02-10 22:50:05 -08:00
Nate Butler
0e238210bb
Update chip style
2023-02-10 22:06:03 -05:00
Mikayla Maki
912c396b37
Merge pull request #2156 from zed-industries/fix-atelier-cave-license
...
Update the atelier cave license file
2023-02-10 12:04:36 -08:00
Mikayla Maki
436ab6e454
Fix other atelier license
2023-02-10 11:58:25 -08:00
Mikayla Maki
889b15683d
Update the atelier cave license file
2023-02-10 11:52:31 -08:00
Mikayla Maki
135dcf19a2
Merge pull request #2154 from zed-industries/fix-tooltip-crash
...
Don't render tooltip keystroke label if there's no focused view
2023-02-10 11:41:03 -08:00
Petros Amoiridis
5d23aaacc8
Introduce an open function
...
And refactor some of the older code to simplify it
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-02-10 21:11:54 +02:00
Petros Amoiridis
a789476c95
Introduce reveal_in_finder function
...
And use this function in a new Reveal in Finder option of the project panel context menu.
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-02-10 21:11:05 +02:00
Nathan Sobo
da5a6a8b4f
Don't render tooltip keystroke label if there's no focused view
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-02-10 07:57:01 -07:00
Nate Butler
76685406ed
Add remaining colors
2023-02-09 23:26:44 -05:00
Nate Butler
70eedbb48e
Group light and dark scales
2023-02-09 13:41:37 -05:00
Nate Butler
42b5fa1fa3
WIP: Use algorithm to generate reference color palette
...
Adapted from @k-vyn/coloralgorithm
Generate colors for our reference palette.
2023-02-09 12:37:05 -05:00
Joseph T. Lyons
7de04abdcb
Merge pull request #2146 from zed-industries/feedback-editor-polish
...
Feedback editor polish
2023-02-09 10:01:27 -05:00
Antonio Scandurra
373e88e9fb
Merge pull request #2147 from zed-industries/fix-pyright
...
Always respond to language server, even when its requests are malformed
2023-02-09 15:52:57 +01:00
Antonio Scandurra
c3a88857f9
Always respond to language server, even when its requests are malformed
...
This was causing Pyright to get stuck waiting for a response when sending
us the `workspace/configuration` request. For some reason, after upgrading
to Pyright 1.1.293, `scopeUri` is being sent as an empty string sometimes,
which causes serde to error when trying to deserialize that request.
Co-Authored-By: Petros Amoiridis <petros@zed.dev >
2023-02-09 15:30:10 +01:00
Nate Butler
f787f6054b
List colors for reference palette in theme tool
2023-02-09 00:39:57 -05:00
Nate Butler
6f342bb2c6
Remove leftovers from create-next-app
2023-02-09 00:10:32 -05:00
Nate Butler
0ba44c6dc4
Start on system colors
2023-02-09 00:09:52 -05:00
Nate Butler
2ff82732b9
Init theme tool
2023-02-09 00:09:44 -05:00
Nate Butler
cbfdfa8124
Remove comment
2023-02-08 22:52:27 -05:00
Joseph Lyons
57e10ce7c6
Style info text
2023-02-08 21:26:27 -05:00
Joseph Lyons
a9c2f42f70
Move string to variable
2023-02-08 21:26:27 -05:00
Joseph Lyons
83f9d51dee
Fix layout of elements in the feedback editor's toolbar
...
Co-Authored-By: Kay Simmons <3323631+Kethku@users.noreply.github.com >
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-08 21:26:27 -05:00
Mikayla Maki
767d2f9766
Merge pull request #2134 from zed-industries/fix-action-keystroke-bugs
...
Fix several action dispatching bugs
2023-02-08 15:56:50 -08:00
Joseph Lyons
3fb14d7caf
v0.74.x dev
2023-02-08 14:55:21 -05:00
Antonio Scandurra
952cdb4e98
Merge pull request #2145 from zed-industries/fix-focus-in-project-search
...
Focus results editor only when starting a new project search
2023-02-08 18:25:02 +01:00
Joseph Lyons
bbe8297297
Add feedback information text
2023-02-08 11:23:44 -05:00
Antonio Scandurra
76c066baee
Focus results editor only when starting a new project search
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev >
2023-02-08 17:22:14 +01:00
Joseph Lyons
654ee48feb
Add tooltip to submit feedback button
2023-02-08 10:37:04 -05:00
Joseph Lyons
ef16963772
Remove placeholder text
2023-02-08 10:22:36 -05:00
Joseph T. Lyons
37c052f53d
Include is_staff boolean in in-app feedback
2023-02-08 10:14:18 -05:00
Joseph T. Lyons
582f5d0114
Merge pull request #2130 from zed-industries/inform-user-that-telemetry-can-be-disabled
...
Inform user that telemetry can be disabled
2023-02-07 21:15:16 -05:00
Joseph T. Lyons
fd016b9bcd
Merge pull request #2133 from zed-industries/feedback-submit-button
...
Implement a button for submitting feedback
2023-02-07 21:13:42 -05:00
Joseph Lyons
317eb7535c
Fix variable names
2023-02-07 21:08:07 -05:00
Kay Simmons
55589533e2
Update yaml-tree-sitter git hash
...
Update yaml-tree-sitter git hash
2023-02-07 15:51:45 -08:00
Kay Simmons
9a8585ce0c
Merge pull request #2144 from zed-industries/yaml-lsp
...
Add yaml language server
2023-02-07 15:44:10 -08:00
Kay Simmons
aa0a18968a
removed unused import
2023-02-07 15:40:29 -08:00
Kay Simmons
0777f459ba
Add yaml language server
2023-02-07 15:34:27 -08:00
Joseph T. Lyons
2732cc2cbe
Merge pull request #2143 from zed-industries/remove-release-action-for-Discourse
...
Remove release action for Discourse
2023-02-07 18:34:21 -05:00
Joseph Lyons
e8dad56af9
Remove release action for Discourse
2023-02-07 18:26:55 -05:00
Mikayla Maki
87cf8ac60e
Fixed strange y results from faulty conversion to screen coordinates
...
co-authored-by: Nathan <nathan@zed.dev >
2023-02-07 15:26:03 -08:00
Joseph T. Lyons
f44658ad2a
Merge pull request #2142 from zed-industries/update-links-to-community-repository
...
Update links to community repository
2023-02-07 18:23:50 -05:00
Joseph Lyons
20377ea4e9
Update links to community repository
2023-02-07 18:19:27 -05:00
Mikayla Maki
db2aaa4367
Fixed bug in setting cursor style
2023-02-07 14:35:46 -08:00
Kay Simmons
099b79910f
Merge pull request #2137 from zed-industries/yaml
...
yaml highlighting
2023-02-07 14:32:02 -08:00
Kay Simmons
fe25994fb3
fix highlights, indents, and tab size for yaml
2023-02-07 14:20:23 -08:00
Joseph Lyons
7cef4a5d40
Allocate theme struct directly into the heap
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-02-07 13:39:48 -05:00
Max Brunsfeld
0c49030ade
Merge pull request #2140 from zed-industries/feedback/929-project-search-crashes
...
Feedback/929 project search crashes
2023-02-07 10:12:00 -08:00
Petros Amoiridis
e15ffc8560
Make truncate_and_trailoff a bit more clear
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-02-07 20:06:20 +02:00
Joseph Lyons
58987275fc
Merge branch 'main' into feedback-submit-button
2023-02-07 12:55:53 -05:00
Petros Amoiridis
9bff82f161
Use truncate_and_trailoff function
...
A function that already works with unicode characters.
2023-02-07 19:25:57 +02:00
Petros Amoiridis
be0241bab1
Add test for string with unicode characters
2023-02-07 19:25:07 +02:00
Kay Simmons
de0b136be2
wip yaml highlighting
2023-02-07 01:00:50 -08:00
Kay Simmons
4e80ae13ec
Merge pull request #2136 from zed-industries/fix-recent-projects-panic
...
Fix Recent Project Panic
2023-02-07 00:38:18 -08:00
Kay Simmons
b020955ac4
show notification if no recent projects
2023-02-07 00:10:11 -08:00
Max Brunsfeld
a606058537
Merge pull request #2135 from zed-industries/handle-window-moved-crash
...
Fix crash when unplugging display containing a zed window
2023-02-06 17:05:32 -08:00
Max Brunsfeld
f065399799
Fix crash when unplugging display containing a zed window
...
Co-authored-by: Kay Simmons <kay@zed.dev >
2023-02-06 16:44:06 -08:00
Mikayla Maki
926b59b15d
Fixed a bug where the command palette wouldn't check the keymap context when showing available actions
...
Fixed a bug where context menus wouldn't show action keystrokes
WIP Fixing a bug where tooltips won't show action keystrokes
Co-Authored-By: Max <max@zed.dev >
2023-02-06 15:42:14 -08:00
Kay Simmons
2d6219ebe2
Merge pull request #2131 from zed-industries/lua
...
Add lua syntax highlighting and lsp support
2023-02-06 15:40:03 -08:00
Joseph Lyons
8228618b9e
Correct theme function name
2023-02-06 18:19:15 -05:00
Joseph Lyons
d4d9a142fc
Implement a button for submitting feedback
...
Co-Authored-By: Kay Simmons <3323631+Kethku@users.noreply.github.com >
2023-02-06 17:41:36 -05:00
Kay Simmons
035901127a
remove unused version regex
2023-02-05 23:25:20 -08:00
Kay Simmons
37bfeed2e6
Merge pull request #2129 from zed-industries/move-sharing-status-indicator
...
Move sharing status indicator to collab ui
2023-02-05 23:24:23 -08:00
Kay Simmons
4642817e72
Add lua syntax highlighting and lsp support
2023-02-05 23:21:29 -08:00
Joseph Lyons
83e21387af
Inform user that telemetry can be disabled
2023-02-04 22:18:07 -05:00
Kay Simmons
3e92e4d110
fix unsaved change
2023-02-03 12:47:20 -08:00
Kay Simmons
303216291b
Move sharing status indicator out of the call crate and into collab_ui in order so that the model doesn't depend on the view
2023-02-03 11:17:50 -08:00
Kay Simmons
8be9d21340
Merge pull request #2128 from zed-industries/feedback/922-unify-find-all-references-label
...
Make app menu and context menu labels consistent
2023-02-03 10:29:43 -08:00
Joseph Lyons
9742bd7fd4
Reduce length of feedback placeholder text
2023-02-03 08:14:14 -05:00
Petros Amoiridis
3014cc5299
Do not capitalize prepositions in title case
...
This also match the app menu
2023-02-03 12:16:09 +02:00
Petros Amoiridis
d6b728409f
Be consistent in the app & context menus
2023-02-03 12:14:13 +02:00
Petros Amoiridis
433f284571
Merge pull request #2126 from zed-industries/731-make-cursor-visible-immediately
...
Focus the editor when activating previous pane
2023-02-03 10:12:34 +02:00
Kay Simmons
7270f950b8
Merge pull request #2115 from zed-industries/call-status-indicator
...
Add call status indicator to the status bar
2023-02-02 17:18:22 -08:00
Kay Simmons
ae15673dfd
Merge pull request #2124 from zed-industries/fix-display-uuid-panic
...
Make display uuid optional if the display is disconnected
2023-02-02 17:17:01 -08:00
Joseph T. Lyons
8697f81a37
Merge pull request #2127 from zed-industries/fix-discourse-release
...
Fix discourse release
2023-02-02 14:29:50 -05:00
Joseph T. Lyons
21ded7639a
Merge pull request #2125 from zed-industries/trim-leading-and-trailing-whitespace-in-feedback
...
Trim leading and trailing whitespace in feedback
2023-02-02 13:43:35 -05:00
Joseph Lyons
3f95788d45
Clean up whitespace
2023-02-02 13:38:41 -05:00
Joseph Lyons
1afd6f859d
Fix discourse release action
...
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com >
2023-02-02 13:38:25 -05:00
Petros Amoiridis
2b0592da21
Guard against tab_bar_context_menu
...
We don't want to have the tab_bar_context_menu as the active item of the pane where the split started from
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-02-02 20:15:43 +02:00
Petros Amoiridis
8f61134e7e
Allow comparing ViewHandle to AnyViewHandle
...
Since they both have a window_id and a view_id.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-02-02 20:15:40 +02:00
Joseph Lyons
888145ebed
Trim leading and trailing whitespace in feedback
2023-02-02 12:43:55 -05:00
Kay Simmons
a50f0181fb
Add setting to disable the call icon
2023-02-01 16:21:53 -08:00
Kay Simmons
62d32db66c
Make display uuid optional if the display is disconnected
2023-02-01 14:59:43 -08:00
Nate Butler
d6962d957b
Add note to base16.ts
2023-02-01 16:26:08 -05:00
Joseph Lyons
fd2a9b3df9
v0.73.x dev
2023-02-01 13:45:06 -05:00
Kay Simmons
460dc62888
start adding setting for the screen sharing status indicator
2023-01-31 15:17:16 -08:00
Kay Simmons
e35db69dbd
Add call status indicator to the status bar
2023-01-31 15:00:49 -08:00
Mikayla Maki
a89cc22af4
Merge pull request #2113 from zed-industries/terminal-lost-cwd
...
Fix lost terminal working directories
2023-01-30 14:43:43 -08:00
Mikayla Maki
e682e2dd72
Changed SQLez migrations to be executed eagerly
...
Added fix for terminal working directory's sometimes getting lost
co-authored-by: Kay <kay@zed.dev >
2023-01-30 14:38:48 -08:00
Joseph T. Lyons
65641b1d3e
Merge pull request #2112 from zed-industries/fix-version-for-feedback-related-commands
...
Fix version for feedback-related commands
2023-01-30 14:43:33 -05:00
Joseph Lyons
248161aa63
Fix version for feedback-related commands
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-01-30 14:13:25 -05:00
Mikayla Maki
d9278f7416
Merge pull request #2066 from zed-industries/remove-staff-mode
...
Small patches
2023-01-27 15:50:00 -08:00
Mikayla Maki
57781fd7aa
Move StaffMode declaration out of paths
2023-01-27 15:45:33 -08:00
Mikayla Maki
2d889f59bf
Rewrite license documentation to be more clear
2023-01-27 15:44:19 -08:00
Mikayla Maki
2802e3a1c6
Fixed failling tests
2023-01-27 15:44:17 -08:00
Mikayla Maki
ea39983f78
Removed old experiments settings and staff mode flag, added new StaffMode global that is set based on the webserver's staff bit
2023-01-27 15:43:12 -08:00
Mikayla Maki
ca2e0256e1
Renamed open recent action to match menu
2023-01-27 15:38:48 -08:00
Mikayla Maki
070b89243f
Merge pull request #2107 from zed-industries/fix-ci
...
Add an install step to the CI build script
2023-01-27 15:38:12 -08:00
Mikayla Maki
e530406d62
Add an install step to the CI build script
2023-01-27 15:24:21 -08:00
Kay Simmons
ea0dd8972f
Merge pull request #2090 from zed-industries/workspace-window-position-persistence
...
Workspace window position persistence
2023-01-27 15:24:01 -08:00
Kay Simmons
a1308d20ce
Merge pull request #2105 from zed-industries/fix-focus-stealing-when-collaborating
...
Limit focus grabbing in followed pane
2023-01-27 15:23:43 -08:00
Kay Simmons
486b3f64d1
Merge pull request #2106 from zed-industries/fix-local-integration-test-failure
...
fix local failing test
2023-01-27 15:23:23 -08:00
Kay Simmons
0f93386071
Add run until parked to test_fs_operations to ensure both update chunks are completed before asserting the changes
2023-01-27 15:07:51 -08:00
Kay Simmons
77a4f907a0
removed invalid focus assertion
2023-01-27 13:43:36 -08:00
Kay Simmons
d6acea525d
add test for is_child_focused
2023-01-27 13:00:26 -08:00
Kay Simmons
89a5506f43
Add function which checks if a child of a view is focused and use that to only focus item updates from the leader when that the active item was focused
2023-01-27 12:39:32 -08:00
Antonio Scandurra
5431488a9a
collab 0.5.4
2023-01-27 11:07:12 +01:00
Antonio Scandurra
ac7618da17
Merge pull request #2103 from zed-industries/connection-staleness
...
Fix connection staleness issues
2023-01-27 11:01:24 +01:00
Antonio Scandurra
647d9861b1
Abort collaboration process if any thread panics
2023-01-27 09:50:59 +01:00
Mikayla Maki
d7ac15fa71
Merge pull request #2101 from zed-industries/theme-licenses
...
Added build-licenses command to style tree
2023-01-26 18:29:20 -08:00
Mikayla Maki
3a1d533c01
Combine both license generations into one file
2023-01-26 18:25:28 -08:00
Mikayla Maki
c44acaefff
Added build-licenses command to style tree
2023-01-26 17:33:54 -08:00
Kay Simmons
1593b1e13d
window position restoration working
2023-01-26 16:35:00 -08:00
Max Brunsfeld
fabcdb909a
Merge pull request #2100 from zed-industries/visible-worktrees-in-collab-ui
...
Omit hidden worktrees when showing projects in collaboration UI
2023-01-26 15:01:10 -08:00
Max Brunsfeld
f99e4043c4
Run CI for version branches but not all branches starting with 'v'
2023-01-26 14:57:24 -08:00
Max Brunsfeld
1b45911857
Omit hidden worktrees when showing projects in collaboration UI
2023-01-26 14:47:37 -08:00
Max Brunsfeld
4918ad5789
Merge pull request #2099 from zed-industries/empty-go-to-def-multibuffer
...
Avoid opening a definitions tab if there are no definitions found
2023-01-26 10:35:35 -08:00
Max Brunsfeld
9f86748aff
Avoid opening a definitions tab if there are no definitions found
2023-01-26 10:30:01 -08:00
Petros Amoiridis
489be5e77b
Merge pull request #2077 from zed-industries/2064-remove-contacts
...
Remove contact from contact list
2023-01-26 20:04:15 +02:00
Max Brunsfeld
b396e153d1
Merge pull request #2098 from zed-industries/help-menu-licenses
...
Add 'view dependency licenses' item to Help appication menu
2023-01-26 09:56:44 -08:00
Max Brunsfeld
1c572fd86e
Add 'view dependency licenses' item to Help appication menu
2023-01-26 09:53:46 -08:00
Petros Amoiridis
73af155dd6
Refactor Database::remove_contact
...
Refactor it to avoid sending irrelevant messages to update the UI.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-01-26 19:01:51 +02:00
Antonio Scandurra
eca6115e4b
Ensure proto::UpdateWorktree::removed_entries doesn't exceed chunk size
...
This was causing the database to panic because we were trying to remove too
many entries at once.
2023-01-26 17:26:31 +01:00
Antonio Scandurra
74aeec360d
Cancel pending call when participant leaves room after a reconnection
...
Previously, if a user temporarily disconnected while there was a pending
call, we would fail to cancel such pending call when the caller left the
room. This was due to the caller reconnecting and having a different connection
id than the one originally used to initiate the call.
2023-01-26 16:44:55 +01:00
Petros Amoiridis
2f26fcd889
Merge branch 'main' into 2064-remove-contacts
2023-01-26 16:34:17 +02:00
Joseph T. Lyons
a4d9d6c750
Merge pull request #2095 from zed-industries/fix-crash-when-opening-feedback-while-in-call
...
Fix crash when opening feedback while in call
2023-01-25 21:16:12 -05:00
Max Brunsfeld
a2a3ebc42f
Merge pull request #2096 from zed-industries/lazy-load-languages
...
Load languages lazily in the background
2023-01-25 18:09:45 -08:00
Max Brunsfeld
ddf4e1a316
Load languages lazily in the background
2023-01-25 17:47:46 -08:00
Kay Simmons
a369fb8033
better but still broken
2023-01-25 17:05:57 -08:00
Joseph Lyons
9ff34bcb6a
Remove no-longer-needed method
2023-01-25 20:03:44 -05:00
Julia
10f130ee30
Merge pull request #2094 from zed-industries/project-lost-window-close-action-shortcut-accessibility
...
Add "Close Window" global action which does not need a focused workspace
2023-01-25 18:58:22 -05:00
Julia
3819a67185
Add "Close Window" global action which does not need a focused workspace
2023-01-25 18:51:25 -05:00
Joseph Lyons
6e7101ca6b
Fix crash when opening feedback while in call
2023-01-25 17:48:01 -05:00
Julia
2df2d09e3c
Merge pull request #2091 from zed-industries/style
...
Style
2023-01-25 15:22:52 -05:00
Joseph Lyons
4c3244b982
v0.72.x dev
2023-01-25 15:20:41 -05:00
Julia
a79b4e312b
Style
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-01-25 15:09:57 -05:00
Kay Simmons
5eac797a93
mostly working now
2023-01-25 11:36:38 -08:00
Kay Simmons
a581d0c5b8
wip
2023-01-25 11:32:19 -08:00
Kay Simmons
15799f7af6
wip
2023-01-25 11:32:19 -08:00
Joseph T. Lyons
81ed961659
Merge pull request #2088 from zed-industries/add-cursor-position-to-feedback-editor
...
Add cursor position to feedback editor
2023-01-25 14:29:24 -05:00
Max Brunsfeld
9db55b3029
Merge pull request #2087 from zed-industries/buffer-language-registry
...
Assign the language registry to all buffers in the project
2023-01-25 11:25:40 -08:00
Joseph Lyons
328b779185
Clean up construction of FeedbackEditor
2023-01-25 14:20:58 -05:00
Joseph Lyons
7f3d937938
Count chars
2023-01-25 14:20:40 -05:00
Joseph Lyons
f68f9f37ab
Add cursor position to feedback editor
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2023-01-25 14:20:23 -05:00
Julia
c22d13286d
Merge pull request #2085 from zed-industries/cleanup-debug-printing
...
Clean up some debug printing
2023-01-25 14:18:43 -05:00
Joseph Lyons
44c7f162b6
Merge branch 'main' into add-cursor-position-to-feedback-editor
2023-01-25 14:01:45 -05:00
Max Brunsfeld
7003a475a7
Assign the language registry to all buffers in the project
2023-01-25 10:44:15 -08:00
Julia
3d8dbee76a
Clean up some debug printing
2023-01-25 13:37:04 -05:00
Petros Amoiridis
160870c9de
Improve user notification
...
The message is not really true. When one declines, the other person can notice that the contact request is not pending any more. They will know. Switching to not alerted is closer to what is really happening.
2023-01-25 19:46:51 +02:00
Mikayla Maki
ba6ffd8256
Merge pull request #2081 from zed-industries/fix-failing-ci
...
Fixes a broken conditional that is only caught on darwin systems
2023-01-25 09:45:30 -08:00
Mikayla Maki
ecb7d1072f
Fixes a broken conditional that is only caught on darwin systems
2023-01-25 09:33:07 -08:00
Mikayla Maki
38b83a70aa
Merge pull request #2078 from zed-industries/fix-cursor-style
...
Fix cursor style thrashing on overlapping windows
2023-01-25 09:15:55 -08:00
Mikayla Maki
1fc6276eab
Remove debug wiring
2023-01-25 09:10:51 -08:00
Mikayla Maki
45e4e3354e
Changed the presenter to only send 'set_cursor_style' on the topmost window
...
co-authored-by: Antonio <antonio@zed.dev >
2023-01-25 09:10:35 -08:00
Mikayla Maki
27a80a1c94
WIP
2023-01-25 09:10:35 -08:00
Mikayla Maki
426aeb7c5e
WIP - adds platform APIs for checking the top most window
2023-01-25 09:10:35 -08:00
Petros Amoiridis
35524db136
Add a confirmation prompt
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-01-25 18:55:08 +02:00
Petros Amoiridis
e928c1c61e
Test removing a contact
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-01-25 17:31:42 +02:00
Petros Amoiridis
5d4eb2b7ae
Push responder and requester to remove_contacts
...
When we ask the server to remove a contact we need to push the requester and responder ids to `remove_contacts` so that when the UI updates, the correct contacts will disappear from the list.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-01-25 13:10:29 +02:00
Petros Amoiridis
db978fcb6c
Add an x mark icon to the list of contacts
...
We want to be able to remove contacts from our list. This was not possible. This change add an icon and dispatches the RemoveContact action.
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-01-25 13:10:29 +02:00
Joseph Lyons
3329b2bbd6
Remove gpui:: prefix from parameters
2023-01-24 19:46:04 -05:00
Joseph T. Lyons
a66a0cfd70
Merge pull request #2075 from zed-industries/add-upper-character-count-limit
...
Add upper character count limit
2023-01-24 19:44:19 -05:00
Julia
27ee994e17
Merge pull request #2074 from zed-industries/decode-openurl-to-pathbuf
...
Decode URL from `openURLs` to handle percent encoded paths
2023-01-24 19:08:17 -05:00
Julia
0414723a54
Decode URL from openURLs to handle percent encoded paths
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-01-24 18:48:15 -05:00
Joseph Lyons
588419492a
Add upper character count limit
2023-01-24 17:38:20 -05:00
Max Brunsfeld
52296836fe
Merge pull request #2069 from zed-industries/markdown-fenced-blocks
...
Support syntax highlighting in Markdown fenced code blocks
2023-01-24 14:19:36 -08:00
Max Brunsfeld
678ee26c5e
Merge branch 'main' into markdown-fenced-blocks
2023-01-24 14:13:50 -08:00
Julia
29d67452e0
Merge pull request #2072 from zed-industries/os-file-associations
...
Insert macOS file association metadata during bundle process
2023-01-24 17:09:41 -05:00
Max Brunsfeld
51984f0d39
Fix feedback editor compile error due to LanguageRegistry API change
2023-01-24 14:09:24 -08:00
Julia
4d73d4b1b9
Insert macOS file association metadata during bundle process
2023-01-24 17:07:02 -05:00
Max Brunsfeld
9c25d37dfc
Merge branch 'main' into randomized-tests-operation-script
...
In randomized integration test, incorporate random updates of existing
files into the test's new structure.
2023-01-24 12:39:24 -08:00
Nathan Sobo
e8cea130a4
Merge pull request #2068 from zed-industries/doc-reparse
...
Document Buffer::reparse
2023-01-24 09:09:38 -07:00
Antonio Scandurra
dff08d3cfe
Merge branch 'main' into markdown-fenced-blocks
2023-01-24 15:43:35 +01:00
Antonio Scandurra
c48e3f3d05
Reparse unknown injection ranges in buffer when adding a new language
2023-01-24 15:29:59 +01:00
Antonio Scandurra
f3509824e8
WIP: Start on SyntaxMapSnapshot::unknown_injection_languages
2023-01-24 12:55:49 +01:00
Antonio Scandurra
14c72cac58
Store syntax layers even if a language for the injection can't be found
2023-01-24 12:25:12 +01:00
Joseph T. Lyons
f95bda64ba
Merge pull request #2009 from zed-industries/in-app-feedback
...
In app feedback
2023-01-24 01:05:05 -05:00
Nathan Sobo
96ffe84edb
Document Buffer::reparse
2023-01-23 21:51:10 -07:00
Joseph Lyons
2b3d09f70a
Fix CI missing license check
2023-01-23 18:34:10 -05:00
Joseph Lyons
8e8f66a5e1
Merge branch 'main' into in-app-feedback
2023-01-23 18:24:12 -05:00
Joseph Lyons
c9299a49e1
Clean out unused code
2023-01-23 18:19:10 -05:00
Mikayla Maki
9f048a4b1c
Merge pull request #2044 from zed-industries/licensing-scripts
...
Licensing scripts
2023-01-23 12:58:27 -08:00
Mikayla Maki
0f0d5d5726
Added cargo-about auto-install and CI steps
2023-01-23 12:51:32 -08:00
Mikayla Maki
d060114f00
Added complete scripts for generating third party license files
2023-01-23 12:47:12 -08:00
Mikayla Maki
9d58032064
Add action to open licenses file
2023-01-23 12:45:18 -08:00
Mikayla Maki
4609be20de
WIP: Adding license compliance to CI
2023-01-23 12:43:42 -08:00
Mikayla Maki
4d05d61ed7
Merge pull request #2049 from zed-industries/425-create-file-for-cli
...
Create files passed as args to CLI
2023-01-23 10:44:55 -08:00
Antonio Scandurra
8dabdd1baa
Ensure injection layer is recomputed when language changes
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-01-23 19:02:06 +01:00
Julia
4678f6e0a5
Merge pull request #2063 from zed-industries/active-tab-close-icon-pointing-hand
...
Avoid stomping on tab close icon's cursor style
2023-01-23 11:48:35 -05:00
Julia
95b259b841
Avoid stomping on tab close icon's cursor style
2023-01-23 11:43:50 -05:00
Antonio Scandurra
79cf6fb8b6
WIP: Add test for dynamic language injection
2023-01-23 09:45:36 +01:00
Antonio Scandurra
cb610f37f2
WIP: Search language injections also by file extension
...
There are still a few things left:
1. Add test to verify we can successfully locate a language by its extension
2. Add test to reproduce bug where changing the fenced code block language
won't reparse the block with the new language
3. Reparse injections for which we couldn't find a language when the language
registry changes.
4. Check why the markdown grammar considers the trailing triple backtick as
`(code_block_content)`, as opposed to being part of the outer markdown.
2023-01-23 08:56:41 +01:00
Antonio Scandurra
36e4dcef16
Avoid allocating a string to compare language names
2023-01-23 08:56:41 +01:00
Antonio Scandurra
c49dc8d6e5
Rename LanguageRegistry::get_language to language_for_name
2023-01-23 08:56:41 +01:00
Antonio Scandurra
f086fa3f21
Add syntax injections for Markdown fenced code blocks
2023-01-23 08:56:41 +01:00
Joseph Lyons
c118f9aabd
Fix new errors after merge
2023-01-23 01:31:02 -05:00
Joseph Lyons
f2a5a4d0fd
Merge branch 'main' into in-app-feedback
2023-01-23 01:20:10 -05:00
Joseph Lyons
fb2278dc6d
Complete first iteration of in-app feedback
2023-01-23 00:59:46 -05:00
Mikayla Maki
50d37e1ae7
Merge pull request #2060 from zed-industries/fix-ci-fail
...
Fix mismatched return types on CI
2023-01-20 18:28:59 -08:00
Mikayla Maki
8dcaa81aad
switch return type of accepts_first_mouse
2023-01-20 18:19:24 -08:00
Max Brunsfeld
e1a58e9381
Merge pull request #2059 from zed-industries/no-indent-adjustment-on-error
...
Avoid adjusting indentation of lines inside of newly-created errors
2023-01-20 17:13:30 -08:00
Max Brunsfeld
56080771e6
Add test for avoiding indent adjustment inside newly-created errors
2023-01-20 17:02:38 -08:00
Mikayla Maki
bb24f1142f
Removed dbg
2023-01-20 16:47:23 -08:00
Mikayla Maki
94b2f8e07f
Merge pull request #2054 from zed-industries/notification-mouse-events
...
Notification mouse events
2023-01-20 16:41:27 -08:00
Mikayla Maki
310d867aab
Switch PopUp windows to use the NSTrackingArea API and add support for the mouseExited event
...
Co-authored-by: Antonio <antonio@zed.dev >
2023-01-20 16:35:25 -08:00
Max Brunsfeld
9f74d6e4ac
Highlight and auto-indent await expressions in rust
2023-01-20 15:56:56 -08:00
Max Brunsfeld
f7ceebfce3
Avoid adjusting indentation of lines inside newly-created errors
2023-01-20 15:56:45 -08:00
Joseph Lyons
083986dfae
WIP
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-01-20 18:05:24 -05:00
Max Brunsfeld
df1e1295e3
Merge pull request #2056 from zed-industries/confirm-quit
...
Add confirm_quit setting
2023-01-20 14:11:02 -08:00
Joseph Lyons
c1934d6232
WIP
2023-01-20 16:56:56 -05:00
Kay Simmons
4bee273511
Merge pull request #2057 from zed-industries/multiple-definitions-multibuffer
...
Multiple Definitions Multibuffer
2023-01-20 13:49:07 -08:00
Kay Simmons
2e37c0ea4a
Open multiple definitions in a multibuffer instead of opening the files directly
2023-01-20 13:28:13 -08:00
Max Brunsfeld
2f42af2ac3
Add confirm_quit setting
2023-01-20 13:02:38 -08:00
Max Brunsfeld
be2c601176
Merge pull request #2055 from zed-industries/language-config-overrides
...
Language config overrides
2023-01-20 11:15:26 -08:00
Max Brunsfeld
8dcef46842
Drop 'override.' prefix from capture names in override query
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-01-20 10:44:33 -08:00
Max Brunsfeld
2aa7a9e95b
Add overrides for all languages
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-01-20 10:39:31 -08:00
Mikayla Maki
8af1294ba5
Changed platform mouse moved handling to only fire on active or popup windows
...
co-authored-by: Antonio <antonio@zed.dev >
2023-01-20 09:37:09 -08:00
Mikayla Maki
5a00729fad
Merge pull request #2051 from zed-industries/show-following-to-followed
...
Show following to followed
2023-01-20 09:23:34 -08:00
Mikayla Maki
97203e1e02
Fix broken merge
2023-01-20 09:19:58 -08:00
Mikayla Maki
95e661a78c
Switched from active hover to NSViews acceptsFirstMouse API
...
Co-authored-by: Nathan <nathan@zed.dev >
2023-01-20 09:14:38 -08:00
Julia
b54b77b9ec
Merge pull request #2053 from zed-industries/on-move-out
...
Hide hovers when mouse leaves area & window focus is lost
2023-01-20 10:55:26 -05:00
Julia
467e3dc50a
Hide editor hover on mouse move out & always notify when hiding hover
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-01-20 10:16:24 -05:00
Julia
131f3471fc
Don't dispatch mousemove without focus & avoid swallowing external moves
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-01-20 10:11:28 -05:00
Mikayla Maki
88170df7f0
Switched from active hover to NSViews acceptsFirstMouse API
2023-01-19 15:21:26 -08:00
Max Brunsfeld
2967b46a17
Implement scope-specific bracket matching and comment toggling
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-01-19 15:04:27 -08:00
Mikayla Maki
4eeb1aec50
Adds UI for showing the followed-by status to collaboration
2023-01-19 14:22:12 -08:00
Max Brunsfeld
1851e2e77c
Start work on language config overrides
...
Co-authored-by: Julia Risley <julia@zed.dev >
2023-01-19 12:32:08 -08:00
Mikayla Maki
4a46227909
Change incoming call notification to only require one click
2023-01-19 11:43:46 -08:00
Mikayla Maki
86371d9f5e
Merge pull request #2050 from zed-industries/disable-soft-wrap-in-single-line-editors
...
Disable soft wrap in single line editors
2023-01-19 11:26:54 -08:00
Joseph Lyons
38476f5429
Disable soft wrap in single line editors
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-01-19 13:45:05 -05:00
Petros Amoiridis
6c9422808a
Merge pull request #2048 from zed-industries/408-add-date-to-zedlog
...
Add date to the log format
2023-01-19 20:26:01 +02:00
Petros Amoiridis
d30e129d63
Create files passed as args to CLI
...
Co-Authored-by: Mikayla <mikayla@zed.dev >
2023-01-19 19:38:05 +02:00
Julia
ad1947fa50
Add in-window on-move-out mouse handler concept
2023-01-19 12:34:13 -05:00
Petros Amoiridis
f088de5947
Add date to the log format
...
Co-Authored-By: Mikayla <mikayla@zed.dev >
2023-01-19 19:05:17 +02:00
Antonio Scandurra
c85ad96b45
Merge pull request #2047 from zed-industries/optimize-large-multi-buffers
...
Avoid stalling the UI thread when running large searches
2023-01-19 17:31:14 +01:00
Antonio Scandurra
1f649e52de
Document RopeFingerprint
2023-01-19 17:25:59 +01:00
Antonio Scandurra
0a7111d216
Fix tests
2023-01-19 16:26:27 +01:00
Antonio Scandurra
a58b39f884
Merge branch 'main' into optimize-large-multi-buffers
2023-01-19 16:18:21 +01:00
Antonio Scandurra
c124caeb0d
Add test for stream_excerpts_with_context_lines
2023-01-19 15:54:32 +01:00
Antonio Scandurra
5ce065ac92
Introduce MultiBuffer::stream_excerpts_with_context_lines
...
This allows us to push excerpts in a streaming fashion without blocking
the main thread.
2023-01-19 15:42:14 +01:00
Max Brunsfeld
5189dea3d5
Merge pull request #2046 from zed-industries/line-breaks-in-outline-items
...
Prevent outline items from accidentally spanning multiple lines
2023-01-18 16:46:45 -08:00
Max Brunsfeld
d9948bf772
Prevent outline items from accidentally spanning multiple lines
2023-01-18 16:43:18 -08:00
Max Brunsfeld
062e7a03a9
Update comments in Pane::close_items
2023-01-18 15:17:44 -08:00
Max Brunsfeld
17b4bfdf98
Merge pull request #2045 from zed-industries/fewer-unsaved-prompts
...
Avoid prompting to save when closing an untitled buffer that is still open elsewhere
2023-01-18 15:10:19 -08:00
Max Brunsfeld
06c31a0daa
Fix workspace tests after changing Item trait
2023-01-18 15:00:40 -08:00
Mikayla Maki
203f569f2e
collab 0.5.3
2023-01-18 12:52:58 -08:00
Mikayla Maki
b0fb5913b6
v0.71.x dev
2023-01-18 12:39:38 -08:00
Petros Amoiridis
6cc84a77c8
Merge pull request #2042 from zed-industries/fix-pasting-files
...
Allow pasting the same entry more than once in project panel
2023-01-18 18:37:31 +02:00
Petros Amoiridis
27a6951403
Allow pasting the same entry more than once in project panel
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-01-18 17:35:21 +02:00
Petros Amoiridis
9f3c8c1e3a
Merge pull request #2041 from zed-industries/fix-renaming-file
...
Fix mouse interrupting file/dir editing in project panel
2023-01-18 15:53:08 +02:00
Antonio Scandurra
a8f466b422
Don't starve the main thread adding too many search excerpts at once
2023-01-18 14:22:23 +01:00
Petros Amoiridis
f8d092fdc6
Fix mouse interrupting file/dir editing in project panel
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com >
2023-01-18 15:22:20 +02:00
Antonio Scandurra
8ca0f9ac99
Fix compile errors
2023-01-18 13:58:01 +01:00
Antonio Scandurra
a653e87658
WIP: Avoid converting RopeFingerprint into a string
...
Co-Authored-By: Petros Amoiridis <petros@zed.dev >
2023-01-18 12:22:08 +01:00
Joseph Lyons
bec03dc882
WIP
2023-01-18 00:12:52 -05:00
Kay Simmons
2c3c8b4cb0
Merge pull request #2039 from zed-industries/vim-mode-single-line-editors
...
disable vim mode in non full editors
2023-01-17 18:43:16 -08:00
Max Brunsfeld
a0a50cb412
Set up fake project paths correctly in tests
2023-01-17 17:40:34 -08:00
Kay Simmons
cf193154e1
fix broken test
2023-01-17 17:35:39 -08:00
Kay Simmons
c3518cefe8
disable vim mode in non full editors
2023-01-17 17:32:10 -08:00
Kay Simmons
4746fb5936
Merge pull request #2038 from zed-industries/fix-sidebar-width-with-dock
...
Fix issue with sidebars resizing themselves when dock is toggled
2023-01-17 17:22:24 -08:00
Max Brunsfeld
8651320c9f
Make workspace items expose their underlying models, remove file-related methods
2023-01-17 17:21:06 -08:00
Kay Simmons
c9a306b4ac
Change sidebars to use the window width as a max width rather than participating in the flex
...
co-authored-by: Mikayla <mikayla@zed.dev >
2023-01-17 16:58:55 -08:00
Max Brunsfeld
292708573f
Replace MultiBuffer::files with ::for_each_buffer
2023-01-17 16:16:44 -08:00
Joseph T. Lyons
c3b102f5a8
Add users to mailing list when using an invite link
2023-01-17 16:46:01 -05:00
Max Brunsfeld
f61b870db6
Merge pull request #2034 from zed-industries/tab-focus-search
...
Use tab instead of command-f to move focus from the search editor to the main editor
2023-01-17 10:25:04 -08:00
Max Brunsfeld
1a6a807db5
Merge pull request #2035 from zed-industries/always-auto-indent-block-on-paste
...
Always auto-indent in block-wise mode when pasting
2023-01-17 10:24:41 -08:00
Antonio Scandurra
01aac0de48
Merge pull request #2036 from zed-industries/spurious-modified-buffers
...
Fix buffers appearing as modified when guest joined after buffer had been saved
2023-01-17 18:21:21 +01:00
Antonio Scandurra
dc88a67f50
Fix assertions
2023-01-17 18:09:45 +01:00
Julia
5ce0472a75
Merge pull request #2037 from zed-industries/go-to-fit
...
Utilize fit autoscroll for various go-to actions
2023-01-17 10:49:22 -05:00
Antonio Scandurra
cc788dc5f7
Verify saved_version, saved_version_fingerprint and saved_mtime
2023-01-17 16:46:06 +01:00
Julia
7726a9ec3d
Utilize fit autoscroll for various go-to actions
2023-01-17 10:42:53 -05:00
Antonio Scandurra
fcf97ab41e
Bump protocol version
2023-01-17 16:32:54 +01:00
Antonio Scandurra
bb200aa082
Relay saved version metadata to ensure buffers modified state converges
2023-01-17 16:32:54 +01:00
Antonio Scandurra
2cd9db1cfe
Ensure Buffer::{is_dirty,has_conflict} converge in randomized test
2023-01-17 16:32:51 +01:00
Antonio Scandurra
467e5691b9
Include saved mtime and fingerprint when serializing buffers
...
This still doesn't include:
- An assertion in the randomized test to ensure buffers are not spuriously
marked as modified
- Sending an update when synchronizing buffers after a reconnection
2023-01-17 10:46:19 +01:00
Max Brunsfeld
0bd6f9b6ce
Add a test for block-wise auto-indent without original indent info
2023-01-16 18:06:58 -08:00
Max Brunsfeld
244f259331
Always auto-indent in block-wise mode when pasting
...
If the text was copied outside of Zed, so the original indent column is unknown,
then act as if the first line was copied in its entirety.
2023-01-16 17:42:06 -08:00
Max Brunsfeld
625151806a
Merge pull request #2022 from zed-industries/restart-lsp-after-invalid-version-reported
...
Fix crash when restarting a language server after it reports an unknown buffer version
2023-01-16 16:26:50 -08:00
Max Brunsfeld
6810490bf4
Remove tree-sitter dependency from gpui
2023-01-16 16:11:13 -08:00
Max Brunsfeld
3312a06368
Move focus back from buffer search using tab, not cmd-f
2023-01-16 16:01:15 -08:00
Max Brunsfeld
373902d933
Add '>' child operator in keymap context predicates
2023-01-16 16:00:46 -08:00
Max Brunsfeld
f62d13de21
Use a hand-coded parser for keymap context predicates
2023-01-16 15:53:49 -08:00
Julia
df2e9625b3
Merge pull request #2033 from zed-industries/open-with-zed
...
Make Finder "Open With" work correctly
2023-01-16 16:39:02 -05:00
Julia
765773cfe6
Make Finder "Open With" work correctly
2023-01-16 16:34:10 -05:00
Max Brunsfeld
9e5612348c
Merge pull request #2032 from zed-industries/drag-split-dock-panic
...
Fix panic when trying to create a split in the dock by dragging
2023-01-16 11:51:28 -08:00
Max Brunsfeld
aa9710f7c3
Avoid unwrapping pane split in SplitWithProjectEntry
...
Also, implement pane-splitting operations more consistently.
2023-01-16 11:46:47 -08:00
Max Brunsfeld
b90e1012bf
Don't render split drag targets in the dock
2023-01-16 10:24:17 -08:00
Max Brunsfeld
2c84b74126
Avoid retaining project in randomized test while LSP request is outstanding
2023-01-16 09:48:54 -08:00
Antonio Scandurra
96186a3dae
Merge pull request #2030 from zed-industries/fix-typescript-lsp
...
Fix error when running TypeScript language server after version 3.0.2
2023-01-16 17:33:44 +01:00
Antonio Scandurra
2c1fd7b0bf
Add a 5s timeout when running npm info and npm install
...
This prevents those two commands from getting stuck when there is
no internet connection.
2023-01-16 16:51:45 +01:00
Antonio Scandurra
9779663c6b
Use cli.mjs when available in TypeScript language server
...
Otherwise, fall back to using `cli.js`.
2023-01-16 16:50:30 +01:00
Joseph T. Lyons
8e02266d07
Add Discourse release action
2023-01-14 02:30:21 -05:00
Max Brunsfeld
1a9ff2420e
Clean up how applications are marked as inapplicable
2023-01-12 22:09:36 -08:00
Max Brunsfeld
e04d0be853
Remove unneeded log messages in randomized test
2023-01-12 14:30:53 -08:00
Max Brunsfeld
00e8625037
Simplify management of entity ids for different app contexts in randomized test
2023-01-12 14:30:10 -08:00
Max Brunsfeld
a3c7416218
Don't include user ids with MutateClients ops in serialized test plans
2023-01-12 14:28:31 -08:00
Mikayla Maki
24ef80f4b6
Merge pull request #2027 from zed-industries/fix-keybindings-in-command-palette
...
Fix bug where keybindings would not show in command palette
2023-01-11 16:40:04 -08:00
Mikayla Maki
febf992a43
Fix bug where keybindings would not show in command palette
2023-01-11 16:35:49 -08:00
Kay Simmons
e9fdb13cb5
Merge pull request #2025 from zed-industries/vim-r
...
Vim replace
2023-01-11 16:28:39 -08:00
Kay Simmons
216b1aec08
fix replace in normal and visual modes
2023-01-11 14:57:40 -08:00
Max Brunsfeld
02f6928328
collab 0.5.2
2023-01-11 14:00:44 -08:00
Max Brunsfeld
fe27f135c0
Bump protocol version after reconnect support
2023-01-11 14:00:16 -08:00
Max Brunsfeld
74f8b493b2
collab 0.5.1
2023-01-11 13:25:28 -08:00
Max Brunsfeld
49379924cb
Avoid dropping is_complete column for backward compatibility
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-01-11 13:25:02 -08:00
Kay Simmons
14eec66e38
in progress
2023-01-11 12:10:55 -08:00
Mikayla Maki
048da9ddce
collab 0.5.0
2023-01-11 10:50:16 -08:00
Mikayla Maki
9c627e82a0
v0.70.x dev
2023-01-11 10:34:11 -08:00
Mikayla Maki
14899d867e
Merge pull request #2020 from zed-industries/telemtry-opt-out
...
Telemetry opt out
2023-01-10 17:43:30 -08:00
Max Brunsfeld
db831c3fbb
Remove roadmap from readme
2023-01-10 17:38:34 -08:00
Mikayla Maki
bfb43c67f8
Silence spurious log error
...
co-authored-by: Kay <kay@zed.dev >
2023-01-10 16:50:54 -08:00
Mikayla Maki
a3da41bfad
Fix test failures due to dependency on Settings global in client for telemetry
...
co-authored-by: kay <kay@zed.dev >
2023-01-10 16:39:03 -08:00
Max Brunsfeld
ef987cae6b
Merge pull request #2019 from zed-industries/panic-activating-next-pane-in-dock
...
Fix crash when activating prev/next pane while dock is active
2023-01-10 16:27:39 -08:00
Max Brunsfeld
41ff42ddec
Fix crash when restarting a language server after it reports an unknown buffer version
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-01-10 16:27:15 -08:00
Mikayla Maki
37a4de1a84
Add opt-out for metric reporting
...
co-authored-by: kay <kay@zed.dev >
2023-01-10 15:49:54 -08:00
Max Brunsfeld
551dc1f318
Fix crash when activating prev/next pane while dock is active
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2023-01-10 15:32:14 -08:00
Mikayla Maki
866f0e1344
Add the ability to opt-out of panic reporting
...
Co-authored-by: Kay <kay@zed.dev >
2023-01-10 15:07:01 -08:00
Kay Simmons
a222821dfa
Merge pull request #2017 from zed-industries/dont-save-single-file-workspaces
...
Don't save single file worktrees
2023-01-09 17:31:34 -08:00
Mikayla Maki
d49a29d793
Merge pull request #2016 from zed-industries/serialization-updates
...
Serialization touch ups
2023-01-09 16:18:30 -08:00
Kay Simmons
176738d674
Address issue with workspaces where single file worktrees such as those from git commit messages would get restored
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-01-09 16:18:04 -08:00
Max Brunsfeld
576a9bb92c
Drop project's buffers when closing a remote project
2023-01-09 14:49:36 -08:00
Mikayla Maki
ebbe6e7aa9
Add serializing and restoring editor scroll position
...
Co-authored-by: Kay <kay@zed.dev >
2023-01-09 14:06:40 -08:00
Mikayla Maki
d237bdaa9b
Added support for ALTER TABLE syntax in the syntax error checker function
...
Co-authored-by: Kay <kay@zed.dev >
2023-01-09 12:41:37 -08:00
Max Brunsfeld
5a4fa4b11e
Merge branch 'main' into randomized-tests-operation-script
2023-01-09 12:26:11 -08:00
Max Brunsfeld
3e3a703b60
Skip inapplicable operations when running an edited test plan
2023-01-09 11:36:53 -08:00
Joseph Lyons
5517e743e1
Merge branch 'main' into in-app-feedback
2023-01-09 14:05:30 -05:00
Joseph Lyons
c1e61b479c
Move feedback items into a feedback crate
2023-01-09 13:55:06 -05:00
Mikayla Maki
828f406b4f
Fixed issue where serialized terminal working directories would be lost in complex interactions
...
Co-authored-by: Kay <kay@zed.dev >
Co-authored-by: Julia <julia@zed.dev >
2023-01-09 10:54:13 -08:00
Mikayla Maki
e743f3b1d8
Merge pull request #2015 from zed-industries/screenshare-on-terminal
...
Added open screenshare when following into non-followable buffer
2023-01-09 10:28:46 -08:00
Mikayla Maki
69e28d04b0
Added open screenshare when following into non-followable buffer
2023-01-09 10:19:11 -08:00
Julia
2be4f41964
Merge pull request #2013 from zed-industries/autocomplete-require-word-start-match
...
Require first codepoint of autocomplete query to match the first codepoint of some completion's subword
2023-01-09 13:06:43 -05:00
Julia
97ed89a797
Test that completion word splitting does reasonable things
2023-01-09 13:02:44 -05:00
Antonio Scandurra
ad7eaca443
Make Buffer::diff_base available outside of tests
2023-01-08 09:36:58 -07:00
Antonio Scandurra
ddbf251b5f
Merge pull request #2014 from zed-industries/git-diff-reconnect
...
Update git diff base when synchronizing a guest's buffers
2023-01-08 09:28:51 -07:00
Antonio Scandurra
95098e4f29
Update git diff base when synchronizing a guest's buffers
2023-01-08 09:10:57 -07:00
Antonio Scandurra
529ccbda3a
Introduce git index mutations to randomized collaboration test
...
The test now fails at the following seed:
```bash
SEED=850 ITERATIONS=1 OPERATIONS=131 cargo test --package=collab random
```
2023-01-08 08:52:16 -07:00
Joseph Lyons
a73e264c3d
Merge branch 'in-app-feedback' of https://github.com/zed-industries/zed into in-app-feedback
2023-01-07 18:53:11 -05:00
Joseph Lyons
0200fc5542
WIP
...
Don't rely on contacts popover or contacts list for theming
Add metrics id to request body
Clean up some code and comments
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-01-07 18:53:00 -05:00
Joseph Lyons
9694771752
Move notes into PR
2023-01-07 18:53:00 -05:00
Joseph Lyons
9fc7f54631
Add to TODO
2023-01-07 18:53:00 -05:00
Joseph Lyons
1545b2ac61
Update TODO
2023-01-07 18:53:00 -05:00
Joseph Lyons
318a0b7ed0
In-app feedback WIP
2023-01-07 18:53:00 -05:00
Julia
a46ca32356
Completion word start filtering which is codepoint aware
2023-01-07 15:34:28 -05:00
Julia
12cd712b53
Require start autocomplete query byte to match a completion word start byte
2023-01-06 22:47:06 -05:00
Max Brunsfeld
c503ba00b6
Add env vars to store and load test plan from JSON files
2023-01-06 17:51:25 -08:00
Nathan Sobo
3cffee4065
Merge pull request #2011 from zed-industries/project-reconnection
...
Retain connection to remote projects when temporarily disconnected
2023-01-06 18:01:08 -07:00
Nathan Sobo
213658f1e9
Fix tests that failed due to defaulting the grouping interval to zero in tests
2023-01-06 17:56:21 -07:00
Kay Simmons
6b337914d7
Merge pull request #2010 from zed-industries/vim-f-t
...
Vim f and t bindings
2023-01-06 16:32:39 -08:00
Nathan Sobo
386f7ba16d
Merge remote-tracking branch 'origin/main' into project-reconnection
2023-01-06 16:52:22 -07:00
Max Brunsfeld
2351f2bd0c
Tolerate failure to join remote projects in randomized test
2023-01-06 15:40:42 -08:00
Max Brunsfeld
99390a7237
Represent all randomized test actions as operations
2023-01-06 15:32:11 -08:00
Max Brunsfeld
210286da48
Make operations for all buffer manipulations
2023-01-06 15:32:11 -08:00
Max Brunsfeld
f1b3692a35
Tweak operation rates
2023-01-06 15:32:11 -08:00
Max Brunsfeld
f243633f3e
Set up flow for mutating clients via explicit operation values
2023-01-06 15:32:11 -08:00
Max Brunsfeld
ce8dd5a286
wip
2023-01-06 15:32:11 -08:00
Max Brunsfeld
a74c5073a4
Start work on allowing random collab test to be minimized
...
Represent operations as an explicit enum.
2023-01-06 15:32:11 -08:00
Joseph Lyons
5387695ee0
WIP
...
Don't rely on contacts popover or contacts list for theming
Add metrics id to request body
Clean up some code and comments
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2023-01-06 17:40:30 -05:00
Kay Simmons
73e7967a12
working f and t bindings
2023-01-06 14:24:20 -08:00
Joseph Lyons
9d4cf2ff62
Move notes into PR
2023-01-06 15:41:31 -05:00
Antonio Scandurra
83c98ce049
Prevent making further requests after language server shut down
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-01-06 13:40:32 -07:00
Joseph Lyons
658541ec9f
Add to TODO
2023-01-06 15:32:28 -05:00
Max Brunsfeld
6a57bd2794
Merge pull request #2008 from zed-industries/callback-leaks
...
Fix callback leaks when subscriptions are added and dropped in the same effect cycle
2023-01-06 12:01:27 -08:00
Antonio Scandurra
8487ae77e7
Share new worktrees when resharing project
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-01-06 12:58:19 -07:00
Max Brunsfeld
b762d70202
Remove unused CallbackCollection method
2023-01-06 11:51:36 -08:00
Max Brunsfeld
53cb3a4429
Remove GC step for callback collections, always drop callbacks asap
2023-01-06 11:33:50 -08:00
Max Brunsfeld
ef192a902a
Remove dropped subscription eagerly when removing callbacks
2023-01-06 11:03:45 -08:00
Antonio Scandurra
585c23e9f6
Match guest's reported buffers on host when synchronizing after reconnect
...
If the host thinks a guest has a buffer that they don't have, the host won't
send it to them when they attempt to open it the next time. This can happen
if the guest disconnected before they received the host's response to an
initial open buffer request.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-01-06 11:48:34 -07:00
Max Brunsfeld
4708f5d88f
Add test for notifying and dropping subscriptions in an update cycle
2023-01-06 10:46:03 -08:00
Max Brunsfeld
a165cd596b
Make event tests in gpui more consistent
2023-01-06 10:44:45 -08:00
Antonio Scandurra
0d31c8c1c8
Only share worktrees when UpdateProject succeeded
2023-01-06 10:41:11 -07:00
Antonio Scandurra
8c5a0ca3a4
Couple worktree sharing with project metadata updates
2023-01-06 10:31:36 -07:00
Antonio Scandurra
5c05b7d413
Ensure initial project metadata is sent when first sharing a project
2023-01-06 10:18:26 -07:00
Max Brunsfeld
3da69117ae
Use a CallbackCollection for action dispatch observations
2023-01-06 09:15:53 -08:00
Nathan Sobo
4256a96051
Avoid holding project handle on a call that could hang
...
This fixes a leaked handle error.
2023-01-05 21:01:27 -07:00
Max Brunsfeld
82e9f736bd
Use a CallbackCollection for release observations
...
Co-authored-by: Kay Simmons <kay@zed.dev >
2023-01-05 18:02:53 -08:00
Max Brunsfeld
fa620bf98f
Fix logic error in dropping callback subscriptions
...
Co-authored-by: Kay Simmons <kay@zed.dev >
2023-01-05 17:30:39 -08:00
Max Brunsfeld
378f0c32fe
Restructure callback subscriptions
...
Fix a callback leak that would occur when dropping a subscription
to a callback collection after triggering that callback, but before
processing the effect of *adding* the handler.
Co-authored-by: Kay Simmons <kay@zed.dev >
2023-01-05 16:41:23 -08:00
Joseph Lyons
404f59090c
Update TODO
2023-01-05 18:14:28 -05:00
Joseph Lyons
eb02834582
In-app feedback WIP
2023-01-05 17:58:52 -05:00
Nathan Sobo
77e322cb75
Wait for incomplete buffers when handling incoming buffer file updates
2023-01-05 13:50:25 -07:00
Julia
f669b8a029
Merge pull request #2007 from zed-industries/recent-projects-prefer-first-match
...
Prefer first max while fuzzy matching projects fixes unexpected behavior
2023-01-05 12:10:51 -05:00
Julia
09d57d1f26
Prefer first max while fuzzy matching projects fixes unexpected behavior
2023-01-05 11:27:50 -05:00
Nathan Sobo
7a629769b7
Re-request incomplete remote buffers when syncing buffers
...
Any buffers we requested but that haven't been fully sent will cause
outstainding open requests to hang. If we re-request them, any
waiting open requests will resume when the requested buffers finish
being created.
Co-authored-by: Max Brunsfeld <max@zed.dev >
Co-authored-by: Mikayla Maki <mikayla@zed.dev >
2023-01-04 16:00:43 -07:00
Joseph T. Lyons
bd223f5a1f
Merge pull request #2002 from zed-industries/appease-clippy
...
Appease clippy
2023-01-04 16:33:29 -05:00
Nathan Sobo
1006ada458
Update scan_id on worktree entries when there is a conflict
...
Forgetting to do this meant we were unable to sync changes with reconnecting
guests in some cases.
2023-01-04 13:59:16 -07:00
Mikayla Maki
79f8f08caf
v0.69.x dev
2023-01-04 11:45:25 -08:00
Nathan Sobo
789bbf15b7
Update buffer files when synchronizing buffers
...
It's possible that the host was disconnected when attempting to notify
guests of a file save, so we need to transmit this in order to correctly
update the file's mtime.
Next failing seed OPERATIONS=200 SEED=6894
2023-01-04 12:33:48 -07:00
Nathan Sobo
1dd085fc92
Introduce completed_scan_id to worktree
...
We need to know the most recent scan id we have actually completed. This is to
handle the case where a guest disconnects when we're in the middle of streaming
worktree entries to them. When they reconnect, they need to report a scan_id
from before we started streaming the entries, because we have no record of when
the stream was interrupted.
Next failure:
SEED=5051 ITERATIONS=1 OPERATIONS=200 cargo test --release --package=collab random -- --nocapture
2023-01-03 18:26:57 -07:00
Julia
1e18480808
Merge pull request #2005 from zed-industries/tsserver-include-completion-detail
...
Include Typescript completion item `detail` field in completion label
2023-01-03 16:44:10 -05:00
Julia
93a634991b
Include Typescript completion item detail field in completion label
2023-01-03 16:37:35 -05:00
Nathan Sobo
90fb9b53ad
WIP
2023-01-03 13:30:14 -07:00
Julia
d0ce7b3516
Merge pull request #2003 from zed-industries/correct-ra-name-key-default-settings
...
Correct default settings' name key for RA in init options example
2023-01-03 13:51:03 -05:00
Julia
b94c265240
Correct default settings' name key for RA in init options example
2023-01-03 13:50:08 -05:00
Nathan Sobo
8d70a22fa3
Record failing seed
2023-01-02 21:12:39 -07:00
Nathan Sobo
a6ffcdd0cf
Track open buffers when handling sync requests
...
When a host sends a buffer to a guest for the first time, they record that
they have done so in a set tied to that guest's peer id. When the guest
reconnects and syncs buffers, they do so under a different peer id, so we
need to be sure we track which buffers we have sent them to avoid sending
them the same buffer twice, which violates the guest's assumptions.
2023-01-02 20:27:59 -07:00
Max Brunsfeld
74843493f4
Assign fake fs entries' mtimes more consistently
2023-01-02 10:20:52 -08:00
Julia
6b62ce2aaa
Merge pull request #2001 from zed-industries/dissmis-search-button
...
Add dismiss buffer search button & fix some faulty icon button styling
2023-01-02 11:21:16 -05:00
Julia
2b1118f597
Add dismiss buffer search button & fix some faulty icon button styling
...
Co-Authored-By: Nate Butler <nate@zed.dev >
2023-01-01 23:50:46 -05:00
Joseph Lyons
233b28a1b9
Appease clippy
2023-01-01 23:50:45 -05:00
Mikayla Maki
eeb21af841
Merge pull request #2000 from zed-industries/fix-line-seperator
...
Add other line seperators to regex normalization
2022-12-30 18:24:36 -08:00
Mikayla Maki
a5bccecd48
Add other line seperators to regex normalization
2022-12-30 18:18:02 -08:00
Joseph T. Lyons
0f818f2458
Merge pull request #1996 from zed-industries/add-close-clean-items-command
...
Add close clean items command
2022-12-29 14:12:04 -05:00
Joseph T. Lyons
7187cc8a4c
Merge pull request #1994 from zed-industries/add-close-all-items-command
...
Add close all items command
2022-12-29 14:11:44 -05:00
Joseph Lyons
2bc36600d4
Rename variable
2022-12-29 13:43:56 -05:00
Joseph Lyons
60f29410ca
Add close clean items command
2022-12-29 13:28:52 -05:00
Joseph Lyons
ca3c4566dd
Add close all items command
2022-12-29 01:43:49 -05:00
Nathan Sobo
f3dee2d332
Remove printlns, found a failure
...
Failing seed:
SEED=416 MAX_PEERS=2 ITERATIONS=5000 OPERATIONS=159 cargo +beta test --package=collab random -- --nocapture
2022-12-27 17:01:31 -07:00
Nathan Sobo
273988b8d5
Set transaction group interval to ZERO by default in tests
...
We were seeing non-deterministic behavior in randomized tests when
generating backtraces took enough time to cause transactions to group
in some cases, but not group in others.
Tests will need to explicitly opt into grouping if they want it by
setting the interval explicitly. We have tests in the text module that
currently test the history grouping explicitly, but I'm not sure
it's needed elsewhere.
2022-12-27 16:47:28 -07:00
Joseph T. Lyons
b6337f59fd
Merge pull request #1992 from zed-industries/add-home-and-end-key-support
...
Add home and end key support
2022-12-26 00:34:37 -05:00
Joseph Lyons
21a0df406f
Add home and end key support
2022-12-26 00:24:26 -05:00
Max Brunsfeld
599acf0daa
WIP - Panic immediately when detecting non-determinism via a change to the execution trace
2022-12-23 17:34:13 -08:00
Antonio Scandurra
6458a9144e
WIP: failing randomized test
...
SEED=175 MAX_PEERS=2 ITERATIONS=1 OPERATIONS=159 cargo test --package=collab random -- --nocapture
2022-12-23 15:02:06 +01:00
Antonio Scandurra
344d05045d
Avoid hanging waiting for operations when buffer has none
2022-12-23 12:26:48 +01:00
Antonio Scandurra
75803d8dbb
Respond with an error when client hasn't got a registered handle
2022-12-23 11:53:13 +01:00
Joseph T. Lyons
04e053a216
Merge pull request #1991 from zed-industries/add-actions-for-requesting-features-and-filing-bug-reports
...
Add actions for requesting features and filing bug reports
2022-12-22 23:17:44 -05:00
Joseph Lyons
41bff3947c
Add actions for requesting features and filing bug reports
2022-12-22 23:04:33 -05:00
Joseph T. Lyons
46152c6249
Merge pull request #1990 from zed-industries/add-memory-to-system-specs
...
Add memory to system specs
2022-12-22 18:16:50 -05:00
Joseph Lyons
f65fda2fa4
Add memory to system specs
2022-12-22 18:10:49 -05:00
Joseph T. Lyons
96ac650465
Merge pull request #1989 from zed-industries/add-command-to-copy-system-information-to-the-clipboard
...
add command to copy system information to the clipboard
2022-12-22 14:31:23 -05:00
Joseph Lyons
ea16082a42
Factored data into a SystemSpecs struct
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com >
2022-12-22 14:27:32 -05:00
Max Brunsfeld
42e74e7eef
Excluded deleted entries when initially sending worktrees to guests
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2022-12-22 11:18:10 -08:00
Antonio Scandurra
738e161bc6
WIP: failing test
...
SEED=882 RUST_LOG=collab::tests::randomized_integration_tests=info MAX_PEERS=2 ITERATIONS=1 OPERATIONS=49 cargo test --package=collab random -- --nocapture
2022-12-22 18:32:21 +01:00
Antonio Scandurra
559e14799c
Restructure randomized test to be a bit clearer and test more stuff
2022-12-22 17:54:25 +01:00
Joseph Lyons
eeb5b03d63
add command to copy system information to the clipboard
2022-12-22 03:43:04 -05:00
Max Brunsfeld
d750b02a7c
Handle file and diff updates to incomplete buffers
...
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2022-12-21 15:39:57 -08:00
Max Brunsfeld
c321f5d94a
Assert that buffers' file state matches in randomized collab test
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-12-21 15:38:44 -08:00
Max Brunsfeld
89da738fae
In randomized test, open remote projects via the room
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-12-21 14:13:43 -08:00
Max Brunsfeld
8cd94060bb
💄 Avoid referring to all clients as guests in random integration test
2022-12-21 11:37:18 -08:00
Max Brunsfeld
d8ccdff9fc
Move randomized integration test into its own file
2022-12-21 11:26:24 -08:00
Antonio Scandurra
47348542ef
Synchronize buffers when either the host or a guest reconnects
2022-12-21 14:20:56 +01:00
Antonio Scandurra
b5fb8e6b8b
Remove unused JoinProjectError
2022-12-21 13:10:07 +01:00
Antonio Scandurra
b0336cd27e
Add failing test for buffer synchronization after disconnecting
2022-12-21 11:56:15 +01:00
Antonio Scandurra
ecd80c553c
Verify removing worktrees while host is offline
2022-12-21 11:47:01 +01:00
Antonio Scandurra
59d7f06c57
Handle proto::UpdateProjectCollaborator message in Project
2022-12-21 11:09:27 +01:00
Max Brunsfeld
15f666a50a
Refresh project collaborator connection id for rejoined projects
2022-12-20 18:03:33 -08:00
Max Brunsfeld
ec6f2a3ad4
💄 Reorder private Project method
2022-12-20 17:32:42 -08:00
Max Brunsfeld
213be3d6bd
Delete stale projects after cleanup interval, via server foreign key cascade
2022-12-20 17:27:42 -08:00
Max Brunsfeld
55800fc696
💄 Avoid repeated sql condition in rejoin_room
2022-12-20 17:23:52 -08:00
Max Brunsfeld
6a2066af6c
💄 Reduce indentation in Database::rejoin_room
2022-12-20 17:16:56 -08:00
Max Brunsfeld
cb8962691a
Remove unnecessary UnshareProject message sent to clients leaving a project
2022-12-20 16:58:44 -08:00
Max Brunsfeld
bb00134f5f
Clean up projects when leaving a room
2022-12-20 16:44:57 -08:00
Max Brunsfeld
21d6665c37
Merge branch 'main' into project-reconnection
2022-12-20 15:50:09 -08:00
Max Brunsfeld
6542b30d1f
Implement rejoining projects as guest when rejoining a room
...
Co-authored-by: Julia Risley <julia@zed.dev >
2022-12-20 15:02:26 -08:00
Max Brunsfeld
55ebfe8321
Handle unshared projects when rejoining a room
...
Also, construct remote projects via the room, to guarantee
that the room can manage the projects' sharing lifecycle.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2022-12-20 11:10:46 -08:00
Antonio Scandurra
9d15b3d295
Remove unused import
2022-12-20 17:47:22 +01:00
Antonio Scandurra
d31fd9bbf2
Support adding worktrees to project while host is offline
2022-12-20 17:42:08 +01:00
Antonio Scandurra
52babc51a0
Make host reconnection test pass when mutating worktree while offline
2022-12-20 17:30:58 +01:00
Antonio Scandurra
1a3940a12e
Fix project reconnection test to ensure rooms actually reconnects
2022-12-20 14:51:46 +01:00
Antonio Scandurra
1aec691b35
Sketch out project reconnection routine on the server
2022-12-20 12:03:43 +01:00
Max Brunsfeld
70dd586be9
Start work on rejoining rooms, supplying all project info at once
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-12-19 17:50:43 -08:00
Max Brunsfeld
af85db9ea5
WIP - Retain hosts' project state when they disconnect
2022-12-19 11:38:08 -08:00
Max Brunsfeld
67b265b3d5
Add failing integration test for resharing projects on reconnect
2022-12-19 11:37:28 -08:00
Max Brunsfeld
c8b209306e
collab 0.4.2
2022-12-19 11:29:22 -08:00
Max Brunsfeld
61c6c825b5
Merge pull request #1980 from zed-industries/following-panics
...
Fix panics when following
2022-12-19 11:26:28 -08:00
Antonio Scandurra
0ede89d82a
WIP
2022-12-19 20:05:00 +01:00
Julia
6f211292b2
Merge pull request #1984 from zed-industries/format-problematic-db-macros
...
Format problematic DB macros
2022-12-19 11:17:34 -05:00
Julia
c49573dc11
Format problematic DB macros
2022-12-19 11:11:10 -05:00
Julia
de9c58d216
Merge pull request #1983 from zed-industries/multi-buffer-git-gutter
...
Multi buffer git gutter
2022-12-19 10:53:42 -05:00
Antonio Scandurra
84a860e54d
Merge pull request #1982 from zed-industries/fix-rust-analyzer
...
Update rust-analyzer's `disk_based_diagnostics_progress_token`
2022-12-19 16:33:01 +01:00
Antonio Scandurra
cb60eb8a57
Update rust-analyzer's disk_based_diagnostics_progress_token
2022-12-19 16:27:25 +01:00
Antonio Scandurra
d8219545c9
💄
2022-12-19 16:17:27 +01:00
Antonio Scandurra
06f6d02579
Stop counting extensions in worktree
2022-12-19 16:05:22 +01:00
Max Brunsfeld
1e02ebbd11
Replicate pending selections separately from other selections
...
This fixes a panic that would occur when a leader created
a pending selection that overlapped another selection,
because the follower would attempt to treat that pending
selection as non-pending, which would violate the invariant
that selections are sorted and disjoint.
2022-12-17 14:00:53 -08:00
Max Brunsfeld
8c64514570
Add ZED_STATELESS env var, for suppressing persistence
...
Use this env var in the start-local-collaboration script to make
the behavior more predictable.
2022-12-17 12:03:51 -08:00
Kay Simmons
6fcb3c9020
Merge pull request #1972 from zed-industries/recent-workspace
...
Recent Project Picker
2022-12-16 15:51:57 -08:00
Kay Simmons
2c47bd4a97
Clear stale projects if they no longer exist
2022-12-16 15:45:17 -08:00
Antonio Scandurra
a5f624203e
collab 0.4.1
2022-12-16 12:02:03 +01:00
Antonio Scandurra
98d1b6ec5a
Merge pull request #1975 from zed-industries/screen-share-after-reconnect
...
Prevent screen-sharing from being lost after a reconnection
2022-12-16 12:00:02 +01:00
Antonio Scandurra
457e1046c8
Bump protocol version
2022-12-16 11:48:14 +01:00
Antonio Scandurra
21ab1bb434
Remove unnecessary PeerId parsing code
2022-12-16 11:45:42 +01:00
Antonio Scandurra
aa44de3d16
Fix test ensuring room is left when disconnected from LiveKit
2022-12-16 10:52:32 +01:00
Max Brunsfeld
ad37034960
Identify LiveKit room participants by user id, not peer id
...
This way, their participant id can remain the same when they reconnect.
2022-12-15 17:19:32 -08:00
Julia
ebd0c5d000
Handle reversed=true for multi-buffer git-hunks-in-range iteration
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-12-15 18:17:32 -05:00
Julia
f88b413f6a
Rewrite multi-buffer aware git hunks in range to be more correct
...
Less ad-hoc state tracking, rely more on values provided by the
underlying data
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2022-12-15 17:09:09 -05:00
Antonio Scandurra
c2f5381e5a
collab 0.4.0
2022-12-15 19:37:53 +01:00
Antonio Scandurra
ea1f6689b9
Merge pull request #1971 from zed-industries/update-app-icons
...
Update Zed & Zed Preview icons
2022-12-15 19:37:04 +01:00
Antonio Scandurra
b1affb13bb
Merge pull request #1973 from zed-industries/fix-reconnects-after-deploy
...
Improve reconnections to server after it is redeployed
2022-12-15 19:35:42 +01:00
Antonio Scandurra
2679e245a5
Minor stylistic change
2022-12-15 16:40:16 +01:00
Antonio Scandurra
5a334622ea
💄
2022-12-15 16:34:59 +01:00
Antonio Scandurra
5720c43fe7
Merge branch 'main' into fix-reconnects-after-deploy
2022-12-15 15:32:05 +01:00
Joseph T. Lyons
af4d846428
Merge pull request #1954 from zed-industries/add-symlink-to-applications-directory-in-dmg
2022-12-15 08:06:17 -05:00
Antonio Scandurra
5fb522a9b1
collab 0.3.14
2022-12-15 11:31:51 +01:00
Antonio Scandurra
86e5ae1f2e
Allow nulls in projects.host_connection_{id,server_id}
...
The server version on stable won't be able to fill values for those
columns when we deploy the migration to preview.
With this commit we're also dropping the unused `worktree_extensions`
and `project_activity_periods` tables. The last version of the server
on stable (0.2.6) doesn't contain any code that accesses those tables.
2022-12-15 11:30:51 +01:00
Antonio Scandurra
aadd7f2886
collab 0.3.13
2022-12-15 10:53:17 +01:00
Antonio Scandurra
067a19c971
Avoid logging an error when user who hasn't joined any room disconnects
2022-12-15 10:45:03 +01:00
Antonio Scandurra
688f179256
Use "id" nomenclature more consistently
2022-12-15 10:15:59 +01:00
Antonio Scandurra
af77f1188a
Re-add server_id indices for room_participants/project_collaborators
2022-12-15 09:58:25 +01:00
Julia
0dedc1f3a4
Get tests building again
2022-12-15 00:17:28 -05:00
Max Brunsfeld
6c58a4f885
Fix stale server queries, use foreign keys from connectionsn to servers
2022-12-14 17:34:24 -08:00
Kay Simmons
81e3b48f37
Add keybinding
2022-12-14 16:14:16 -08:00
Kay Simmons
6da59311d1
Add open recent project to file menu
2022-12-14 16:02:48 -08:00
Kay Simmons
2bc685281c
Add recent project picker
2022-12-14 15:59:50 -08:00
Max Brunsfeld
7e0b6ed1c6
Bump RPC version due to multibuffer following PR
2022-12-14 15:34:22 -08:00
Max Brunsfeld
e08d6cd6de
Merge pull request #1921 from zed-industries/multibuffer-following
...
Allow following collaborators into editors with multi-excerpt buffers (refactors + find-all-refs)
2022-12-14 15:33:11 -08:00
Max Brunsfeld
954c9ac3fd
Add integration test coverage for following into multibuffers
2022-12-14 15:28:58 -08:00
Max Brunsfeld
e4c5dfcf6c
Use run_until_parked instead of 'condition' in all integration tests
2022-12-14 15:05:35 -08:00
Nate Butler
5f6313d336
Update Zed & Zed Preview icons
2022-12-14 17:41:18 -05:00
Max Brunsfeld
70efd2bebe
Introduce a ViewId message, identifying views across calls
2022-12-14 14:40:07 -08:00
Max Brunsfeld
43b7e16c89
Handle retina screens in start-local-collaboration script
2022-12-14 11:50:15 -08:00
Max Brunsfeld
f99f581bfc
Clean up state matching in from_state_proto using let/else statements
2022-12-14 11:09:33 -08:00
Max Brunsfeld
09d3fbf04f
In editor following test, apply excerpt removals to both followers
2022-12-14 11:08:08 -08:00
Antonio Scandurra
363e3cae4b
WIP
2022-12-14 19:25:07 +01:00
Antonio Scandurra
930be6706f
WIP
2022-12-14 18:02:39 +01:00
Antonio Scandurra
05e99eb67e
Introduce an epoch to ConnectionId and PeerId
2022-12-14 15:55:56 +01:00
Antonio Scandurra
9bd400cf16
collab 0.3.12
2022-12-14 11:43:33 +01:00
Antonio Scandurra
553585b9a1
Add more logging to Room
2022-12-14 11:43:12 +01:00
Antonio Scandurra
674fddac87
Instrument rpc::Server::start and reduce cleanup timeout again
2022-12-14 11:42:12 +01:00
Antonio Scandurra
63e7b9189d
collab 0.3.11
2022-12-14 11:25:04 +01:00
Antonio Scandurra
9530976f61
Try using a longer timeout for cleaning up stale rooms
2022-12-14 11:24:36 +01:00
Antonio Scandurra
02c30b0091
collab 0.3.10
2022-12-14 09:35:52 +01:00
Antonio Scandurra
b9c7796547
Reduce readiness probe delay and period
2022-12-14 09:35:36 +01:00
Antonio Scandurra
e00cb6b074
collab 0.3.9
2022-12-14 09:05:19 +01:00
Antonio Scandurra
dc47552180
Fix kubernetes configuration for readiness probe
2022-12-14 08:58:19 +01:00
Antonio Scandurra
98a593b263
collab 0.3.8
2022-12-14 08:56:02 +01:00
Antonio Scandurra
897506c797
Define readiness probe to know when the new server can accept traffic
2022-12-14 08:54:46 +01:00
Antonio Scandurra
59c9a57570
collab 0.3.7
2022-12-14 08:43:18 +01:00
Antonio Scandurra
dde6cf596e
Don't wait for stale project deletion before listening for connections
2022-12-14 08:42:34 +01:00
Antonio Scandurra
2596fefa04
collab 0.3.6
2022-12-13 23:09:02 +01:00
Antonio Scandurra
34b69896e4
Listen to SIGTERM in addition to ctrl-c for graceful shutdown
2022-12-13 23:08:43 +01:00
Julia
cf72173282
Clamp end of visual git hunk to requested range
2022-12-13 13:58:50 -05:00
Julia
ecd44e6914
Git diff recalc in project diagnostics
2022-12-13 12:35:58 -05:00
Julia
2cd9987b54
Git diff recalc in project search
2022-12-13 12:35:58 -05:00
Julia
7c3dc1e3dc
Cleanup
2022-12-13 12:35:58 -05:00
Julia
00b7c78e33
Initial hacky displaying of git gutter in multi-buffers
2022-12-13 12:35:58 -05:00
Max Brunsfeld
11800a8a78
Merge branch 'main' into multibuffer-following
2022-12-13 09:25:18 -08:00
Max Brunsfeld
f797dfb88f
Merge branch 'main' into multibuffer-following
2022-12-12 11:47:39 -08:00
Joseph Lyons
7608875625
Remove extraneous newline
2022-12-10 09:56:42 -05:00
Joseph Lyons
dcf11ac7e5
Add symlink to applications directory in dmg
2022-12-10 09:48:40 -05:00
Max Brunsfeld
82824f78b6
Make each Zed instance use half the screen in 'start-local-collaboration' script
2022-12-01 16:43:39 -08:00
Max Brunsfeld
e4507c1d74
Fetch missing buffers when adding excerpts to a multibuffer while following
...
Make FollowableItem::apply_update_proto asynchronous. Use a single
task per workspace to process all leader updates, to prevent updates
from being interleaved.
Co-authored-by: Antonio Scandurra <antonio@zed.dev >
2022-12-01 15:17:51 -08:00
Max Brunsfeld
9314c0e313
Replicate multibuffer excerpt additions and removals to followers
2022-11-30 13:20:13 -08:00
Max Brunsfeld
a48cd9125b
Start-local-collaboration script: put peers' windows at different positions
2022-11-30 09:29:49 -08:00
Max Brunsfeld
6120d6488b
Start work on following in multi-buffers
2022-11-29 14:50:43 -08:00
Max Brunsfeld
82abf31ef1
Add start-local-collaboration script
2022-11-29 14:50:12 -08:00
Max Brunsfeld
6d9b55a654
Send full multibuffer anchors to following peers
2022-11-28 18:00:38 -08:00
Max Brunsfeld
3eac3e20d5
Emit events from a multibuffer when adding/removing excerpts
2022-11-28 17:57:55 -08:00