Anthony Eid
9dfd2f5bdd
Get load workspace to get breakpoint data
2024-08-01 18:29:46 -04:00
Anthony Eid
ca844637f7
Get workplace to serialize breakpoints
2024-08-01 16:56:36 -04:00
Anthony Eid
42aefb4034
Change breakpoints DS to use project path as key instead of bufferID
2024-08-01 14:50:59 -04:00
Anthony Eid
e974ddedce
Start work on setting up workplace serialization for breakpoints
2024-08-01 11:22:28 -04:00
Remco Smits
2ab7f834b2
Implement startDebugging reverse request ( #9 )
...
* Wip move handle reverse requests on the debug panel
* Remove todo for startDebugging
* Remove unused code
* Make clippy happy
* Log error instead of ignoring it
* Remove debug code
2024-07-30 18:07:33 +02:00
Anthony Eid
26a5770e08
Merge pull request #7 from Anthony-Eid/breakpoints
...
This pull request enables users to set breakpoints by clicking to the left of a line number within editor. It also anchor's breakpoints to the original line they were placed on, which allows breakpoints to stay in their relative position when a line before a breakpoint is removed/added.
2024-07-29 20:06:56 -04:00
Anthony Eid
d6dd59c83f
Merge with debugger branch
2024-07-29 20:03:48 -04:00
Anthony Eid
655b23c635
Get clippy to pass
2024-07-29 18:48:27 -04:00
Anthony Eid
620e65411b
Fix crash that can happen after placing breakpoint in file and changing files
...
The crash was happening because editor was trying to render all breakpoints even if they didn't
belong to the current buffer. Breakpoint don't persistent after closing a tab, will need to
change the breakpoint DS key from buffer_id to something more permament
2024-07-29 17:58:52 -04:00
Anthony Eid
d222fbe84c
Fix breakpoint indicator lagging behind mouse in gutter
2024-07-29 16:42:19 -04:00
Anthony Eid
74931bd472
Make active debug line stand out more & set unique DAP client ids ( #8 )
2024-07-29 19:27:07 +02:00
Anthony Eid
4c5deb0b4e
Finalize refactoring breakpoints to use RWLocks
2024-07-28 18:13:14 -04:00
Anthony Eid
a545400534
Set up breakpoint toggle to send breakpoints to dap when necessary
2024-07-28 13:51:28 -04:00
Anthony Eid
12c853e3f0
Merge branch 'remco-debugger' into breakpoints
2024-07-27 18:54:40 -04:00
Anthony Eid
4bb8ec96fd
Get gutter breakpoint hint to display at correct point and set breakpoint
...
The breakpoints that are added through clicking on the gutter can't be affect by the toggle
breakpoint command. This is a bug
2024-07-27 18:10:12 -04:00
Anthony Eid
08dbf365bb
Start work on getting breakpoint indicator to show in gutter
...
The end goal of this commit is to allow a user to set a breakpoint by
hovering over a line in the editor's gutter. Currently breakpoints
only show on line 6 when the mouse is on a gutter.
2024-07-27 17:53:44 -04:00
Anthony Eid
c39c0a55f5
Have project share breakpoints pointer with editor
...
Instead of editor sharing with project each time a breakpoint is toggled. An
editor will clone project's breakpoints if a project is passed into the editors
new function
2024-07-27 15:44:46 -04:00
Anthony Eid
4373e479f7
Get Editor & Project to share breakpoints through RWLock
...
Previously editor would send breakpoints to project whenever
a new breakpoint was deleted or added. Now editor shares a
shared pointer to a breakpoint datastructure. This behavior
is more efficient because it doesn't have to repeatly send
breakpoints everytime one is updated.
Still have to handle cases when a breakpoint is added/removed during
a debugging phase. I also have to figure out how to share the breakpoints
pointer only once per project and editor.
2024-07-27 14:05:11 -04:00
Remco Smits
7f8c28877f
Wip start debugging request
2024-07-27 10:46:55 +02:00
Remco Smits
1ff23477de
Clean up run in terminal code
2024-07-27 10:45:31 +02:00
Remco Smits
d28950c633
Line up toggle debug panel focus with other panels action names
2024-07-26 23:29:08 +02:00
Remco Smits
6ff5e00740
Fix don't go to stack frame if only the thread id matches of the stopped event
...
This makes sure if you have multiple debug adapters running we don't match a thread id that belongs to a different client
2024-07-25 22:21:27 +02:00
Remco Smits
b70acdfa4a
Wip run in terminal request
2024-07-25 21:30:49 +02:00
Remco Smits
403ae10087
Fix infinite loop of threads, because sequence id was wrong
...
This was added to make sure we had the same sequence id as python debugger. But resulting in breaking xdebug(php) debug adapter
2024-07-25 21:22:51 +02:00
Anthony Eid
9a8a54109e
Fix race condition in debugger ( #6 )
...
* Add support for DAP to use std for communication
* Add more descriptive error logs for DAP
* Implement handler for continued event
* Add PR feedback to handle_continued_event function
* Updated debugger
* Fix race condition when using late case debug adapters
The main thing this commit does is fix race conditions between a
dap client's event handler and sending a launch/attach request.
Some adapters would only respond to a starting request after the
client handled an init event, which could never happen because
the client used to start it's handler after it sent a launch request.
This commit also ignores undefined errors instead of crashing. This
allows the client to work with adapters that send custom events.
Finially, I added some more descriptive error messages and change
client's starting request seq from 0 to 1 to be more in line with
the specs.
* Get clippy to run successfully
* Add some function docs to dap client
* Fix debugger's highlight when stepping through code
Merging with the main zed branch removed a function that
the debugger panel relied on. I added the function back
and changed it to work with the updated internals of zed.
* Get clippy to pass & add an error log instead of using dbg!()
* Get sequence id to be incremented after getting respond and event
---------
Co-authored-by: Remco Smits <djsmits12@gmail.com >
2024-07-25 20:24:19 +02:00
Anthony Eid
f0a5775204
Fix toggle breakpoints having a max of one bp per buffer
...
Breakpoints are now stored in a BTreeMap<buffer_id, HashSet<Breakpoint>>
I did this becauase we need to constant check if a breakpoint exists in
a buffer whenever we toggle one.
2024-07-25 14:23:33 -04:00
Anthony Eid
916150a8e0
Get breakpoints to use anchors instead
...
Warning: Project is not being sent breakpoints right now
2024-07-25 14:23:33 -04:00
Anthony Eid
61533d737c
Merge branch 'remco-debugger' into debugger
2024-07-25 14:22:44 -04:00
Remco Smits
11c740b47a
Merge branch 'main' into debugger
2024-07-25 20:03:06 +02:00
Anthony Eid
9c2b909df5
Merge branch 'remco-debugger' into debugger
2024-07-25 13:47:48 -04:00
Remco Smits
8b05b88ada
Merge branch 'main' into debugger
2024-07-25 18:59:05 +02:00
Harsh Narayan Jha
b7c6f3e98e
linux: Update TryExec value in desktop file ( #15149 )
...
Release Notes:
- Fixed ([#15148 ](https://github.com/zed-industries/zed/issues/15148 )).
2024-07-25 10:16:23 -06:00
Thorsten Ball
7146087b44
zed: Mark restored buffers as conflicted if file changed on disk between store & restore ( #15207 )
...
Previously, we've only marked restored buffers as dirty. This PR changes
that behavior in case the buffer has been associated with a file and
that file has changed on disk since the last time Zed stored its
contents.
Example timeline:
1. User edits file in Zed, buffer is dirty
2. User quites Zed with `cmd-q`
3. User changes file on disk: `echo foobar >> file.txt` or `git checkout
file.txt`
4. User starts Zed
5. File/buffer are now marked as having a conflict (yellow icon)
Release Notes:
- Unsaved files that are restored when Zed starts are now marked as
having a conflict if they have been changed on disk since the last time
they were stored.
Demo:
https://github.com/user-attachments/assets/6098b485-b325-49b7-b694-fd2fc60cce64
2024-07-25 18:04:47 +02:00
Marshall Bowers
6d3eaa055f
renovate: Fix wasmtime package prefix
2024-07-25 11:45:14 -04:00
Marshall Bowers
f31c55a76f
zig: Bump to v0.1.5 ( #15203 )
...
This PR bumps the Zig extension to v0.1.5.
Changes:
- #15197
Release Notes:
- N/A
2024-07-25 11:36:50 -04:00
Marshall Bowers
97750529fe
renovate: Fix selector for wasmtime group ( #15202 )
...
This PR fixes the package name selector for the `wasmtime` group.
Release Notes:
- N/A
2024-07-25 11:30:31 -04:00
Uberlicious
cd9dd5ccf7
zig: Add Windows support ( #15197 )
...
Release Notes:
- N/A
Currently Windows environments do not have a `shell_env`. This causes
the Zig extension to error when trying to call `worktree.shell_env()`
since extensions api isn't yet on `0.0.7` and thus not using wasm-host
`0.0.7` we need to only call for the shell env only on non-windows
systems. 0.0.7 and onward at the moment return a Result from
`shell_env()`. The binary path is also slightly different on windows.
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com >
2024-07-25 11:30:02 -04:00
Marshall Bowers
3ce864e69e
renovate: Group wasmtime updates ( #15199 )
...
This PR updates the Renovate config to group `wasmtime` crates together
(e.g., `wasmtime` and `wasmtime-wasi`).
Release Notes:
- N/A
2024-07-25 11:21:51 -04:00
Marshall Bowers
9eeb564c5c
danger: Upgrade danger to v12 ( #15194 )
...
This PR upgrades `danger` to v12.
Release Notes:
- N/A
2024-07-25 11:07:04 -04:00
Conrad Irwin
847bd35bd9
vim remap 2 ( #15193 )
...
Release Notes:
- N/A
2024-07-25 09:00:53 -06:00
renovate[bot]
b8e5ddf456
Update actions/checkout action to v4 ( #15189 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [actions/checkout](https://togithub.com/actions/checkout ) | action |
major | `v2` -> `v4` |
---
### Release Notes
<details>
<summary>actions/checkout (actions/checkout)</summary>
###
[`v4`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v417 )
[Compare Source](https://togithub.com/actions/checkout/compare/v3...v4 )
- Bump the minor-npm-dependencies group across 1 directory with 4
updates by [@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/actions/checkout/pull/1739 ](https://togithub.com/actions/checkout/pull/1739 )
- Bump actions/checkout from 3 to 4 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/actions/checkout/pull/1697 ](https://togithub.com/actions/checkout/pull/1697 )
- Check out other refs/\* by commit by
[@​orhantoy](https://togithub.com/orhantoy ) in
[https://github.com/actions/checkout/pull/1774 ](https://togithub.com/actions/checkout/pull/1774 )
- Pin actions/checkout's own workflows to a known, good, stable version.
by [@​jww3](https://togithub.com/jww3 ) in
[https://github.com/actions/checkout/pull/1776 ](https://togithub.com/actions/checkout/pull/1776 )
###
[`v3`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v360 )
[Compare Source](https://togithub.com/actions/checkout/compare/v2...v3 )
- [Fix: Mark test scripts with Bash'isms to be run via
Bash](https://togithub.com/actions/checkout/pull/1377 )
- [Add option to fetch tags even if fetch-depth >
0](https://togithub.com/actions/checkout/pull/579 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-07-25 09:48:15 -04:00
Peter Tripp
6998c03c59
Document git permalinks (GitHub, Gitlab, Bitbucket, SourceHut, Codeberg, etc) ( #15113 )
...
- Docs: Added "Copy Permalink to Line" and "Open Permalink to Line"
2024-07-25 09:39:57 -04:00
Antonio Scandurra
8631180e43
Avoid buffering line content to compute indent guides ( #15167 )
...
Release Notes:
- Improved performance when computing indent guides for buffers with
extremely long lines.
---------
Co-authored-by: Nathan <nathan@zed.dev >
Co-authored-by: Bennet <bennet@zed.dev >
Co-authored-by: Thorsten <thorsten@zed.dev >
2024-07-25 15:21:50 +02:00
renovate[bot]
cd9a42e8da
Pin dependencies ( #15188 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[2428392/gh-truncate-string-action](https://togithub.com/2428392/gh-truncate-string-action )
| action | pinDigest | -> `67b1b81` |
| [actions/checkout](https://togithub.com/actions/checkout ) | action |
pinDigest | -> `692973e` |
| [actions/checkout](https://togithub.com/actions/checkout ) | action |
pinDigest | -> `ee0669b` |
| [actions/setup-node](https://togithub.com/actions/setup-node ) | action
| pinDigest | -> `1e60f62` |
| [actions/setup-python](https://togithub.com/actions/setup-python ) |
action | pinDigest | -> `39cd149` |
|
[actions/upload-artifact](https://togithub.com/actions/upload-artifact )
| action | pinDigest | -> `0b2256b` |
|
[cloudflare/wrangler-action](https://togithub.com/cloudflare/wrangler-action )
| action | pinDigest | -> `f84a562` |
|
[dcarbone/install-jq-action](https://togithub.com/dcarbone/install-jq-action )
| action | pinDigest | -> `8867ddb` |
|
[peaceiris/actions-mdbook](https://togithub.com/peaceiris/actions-mdbook )
| action | pinDigest | -> `ee69d23` |
| [rui314/setup-mold](https://togithub.com/rui314/setup-mold ) | action |
pinDigest | -> `2e332a0` |
|
[softprops/action-gh-release](https://togithub.com/softprops/action-gh-release )
| action | pinDigest | -> `de2c0eb` |
| [swatinem/rust-cache](https://togithub.com/swatinem/rust-cache ) |
action | pinDigest | -> `23bce25` |
|
[tsickert/discord-webhook](https://togithub.com/tsickert/discord-webhook )
| action | pinDigest | -> `c840d45` |
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions ) if
that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-07-25 09:19:05 -04:00
Marshall Bowers
3246a932ca
renovate: Pin GitHub Action versions with SHAs ( #15184 )
...
This PR updates the Renovate config to pin all GitHub Action versions to
SHAs.
From the Renovate docs:
> The [GitHub Docs, using third-party
actions](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions )
recommend that you pin third-party GitHub Actions to a full-length
commit SHA.
>
> We recommend pinning all Actions. That's why the
helpers:pinGitHubActionDigests preset pins all GitHub Actions.
>
> For an in-depth explanation why you should pin your Github Actions,
read the [Palo Alto Networks blog post about the GitHub Actions
worm](https://www.paloaltonetworks.com/blog/prisma-cloud/github-actions-worm-dependencies/ ).
Release Notes:
- N/A
2024-07-25 09:02:48 -04:00
Marshall Bowers
8ba392bba6
purescript: Upgrade zed_extension_api to v0.0.6 ( #15181 )
...
This PR upgrades the PureScript extension to use v0.0.6 of the
`zed_extension_api`.
Release Notes:
- N/A
2024-07-25 08:55:16 -04:00
Kirill Bulatov
856a8ef5e8
Layout gutter hunk diff close button (X) better ( #15178 )
...
Closes https://github.com/zed-industries/zed/issues/15164
* Deleted hunk
Before:
After:
* Modified hunk
Before:
After:
* Added hunk
Before:
After:
Release Notes:
- N/A
2024-07-25 15:50:57 +03:00
renovate[bot]
6dd9ce1376
Update Rust crate smallvec to v1.13.2 ( #15179 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [smallvec](https://togithub.com/servo/rust-smallvec ) |
workspace.dependencies | minor | `1.11.1` -> `1.13.2` |
---
### Release Notes
<details>
<summary>servo/rust-smallvec (smallvec)</summary>
###
[`v1.13.2`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.13.2 )
[Compare
Source](https://togithub.com/servo/rust-smallvec/compare/v1.13.1...v1.13.2 )
#### What's Changed
- Add more tests for UB by
[@​workingjubilee](https://togithub.com/workingjubilee ) in
[https://github.com/servo/rust-smallvec/pull/346 ](https://togithub.com/servo/rust-smallvec/pull/346 )
- Fix UB on out-of-bounds insert() by
[@​mbrubeck](https://togithub.com/mbrubeck ) in
[https://github.com/servo/rust-smallvec/pull/345 ](https://togithub.com/servo/rust-smallvec/pull/345 )
**Full Changelog**:
https://github.com/servo/rust-smallvec/compare/v1.13.1...v1.13.2
###
[`v1.13.1`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.13.1 )
[Compare
Source](https://togithub.com/servo/rust-smallvec/compare/v1.13.0...v1.13.1 )
- Remove the optional `get-size` feature, to avoid a cyclic dependency
([#​335](https://togithub.com/servo/rust-smallvec/issues/335 )).
**Full Changelog**:
https://github.com/servo/rust-smallvec/compare/v1.13.0...v1.13.1
###
[`v1.13.0`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.13.0 )
[Compare
Source](https://togithub.com/servo/rust-smallvec/compare/v1.12.0...v1.13.0 )
#### What's Changed
- Impl get_size::GetSize (behind feature flag) by
[@​amandasaurus](https://togithub.com/amandasaurus ) in
[https://github.com/servo/rust-smallvec/pull/335 ](https://togithub.com/servo/rust-smallvec/pull/335 )
**Full Changelog**:
https://github.com/servo/rust-smallvec/compare/v1.12.0...v1.13.0
###
[`v1.12.0`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.12.0 )
[Compare
Source](https://togithub.com/servo/rust-smallvec/compare/v1.11.2...v1.12.0 )
#### What's Changed
- Add `from_const_with_len_unchecked` by
[@​Expyron](https://togithub.com/Expyron ) in
[https://github.com/servo/rust-smallvec/pull/329 ](https://togithub.com/servo/rust-smallvec/pull/329 )
#### New Contributors
- [@​Expyron](https://togithub.com/Expyron ) made their first
contribution in
[https://github.com/servo/rust-smallvec/pull/329 ](https://togithub.com/servo/rust-smallvec/pull/329 )
**Full Changelog**:
https://github.com/servo/rust-smallvec/compare/v1.11.2...v1.12.0
###
[`v1.11.2`](https://togithub.com/servo/rust-smallvec/releases/tag/v1.11.2 )
[Compare
Source](https://togithub.com/servo/rust-smallvec/compare/v1.11.1...v1.11.2 )
#### What's Changed
- Automated testing improvements by
[@​waywardmonkeys](https://togithub.com/waywardmonkeys ) in
[https://github.com/servo/rust-smallvec/pull/322 ](https://togithub.com/servo/rust-smallvec/pull/322 )
and
[https://github.com/servo/rust-smallvec/pull/326 ](https://togithub.com/servo/rust-smallvec/pull/326 )
- fix: don't special-case `doc` for `feature = "const_generics"` by
[@​mkroening](https://togithub.com/mkroening ) in
[https://github.com/servo/rust-smallvec/pull/328 ](https://togithub.com/servo/rust-smallvec/pull/328 )
- Code cleanup by [@​emilio](https://togithub.com/emilio ) in
[https://github.com/servo/rust-smallvec/pull/316 ](https://togithub.com/servo/rust-smallvec/pull/316 )
and [@​waywardmonkeys](https://togithub.com/waywardmonkeys ) in
[https://github.com/servo/rust-smallvec/pull/323 ](https://togithub.com/servo/rust-smallvec/pull/323 )
- Minor tweaks to doc formatting. by
[@​waywardmonkeys](https://togithub.com/waywardmonkeys ) in
[https://github.com/servo/rust-smallvec/pull/318 ](https://togithub.com/servo/rust-smallvec/pull/318 )
#### New Contributors
- [@​mkroening](https://togithub.com/mkroening ) made their first
contribution in
[https://github.com/servo/rust-smallvec/pull/328 ](https://togithub.com/servo/rust-smallvec/pull/328 )
**Full Changelog**:
https://github.com/servo/rust-smallvec/compare/v1.11.1...v1.11.2
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-07-25 08:48:56 -04:00
Marshall Bowers
fbbea7ab01
prisma: Upgrade zed_extension_api to v0.0.6 ( #15180 )
...
This PR upgrades the Prisma extension to use v0.0.6 of the
`zed_extension_api`.
Release Notes:
- N/A
2024-07-25 08:46:17 -04:00
Marshall Bowers
aded3dfb05
emmet: Upgrade zed_extension_api to v0.0.6 ( #15177 )
...
This PR upgrades the Emmet extension to use v0.0.6 of the
`zed_extension_api`.
Release Notes:
- N/A
2024-07-25 08:34:45 -04:00
