Commit Graph

26038 Commits

Author SHA1 Message Date
Piotr Osiewicz
58640da34b Annotate cacheable requests on LocalDapCommand level 2025-02-20 01:21:15 +01:00
Piotr Osiewicz
597371960f Invalidate all stack frames on thread event 2025-02-20 01:07:33 +01:00
Anthony Eid
3378b7a859 Get module list to render correctly 2025-02-19 14:56:10 -05:00
Anthony Eid
eeded3d0a4 Allow starting session from action and add new session as item to debug panel 2025-02-19 14:07:13 -05:00
Piotr Osiewicz
9bac1ff9a2 Display selected thread & auto-select first thread if we don't have a selected thread 2025-02-19 18:15:04 +01:00
Piotr Osiewicz
6e17f91bb6 send out breakpoints in the initial batch
Co-authored-by: Remco <
2025-02-19 18:14:57 +01:00
Anthony Eid
9815a8f4b6 Clean up errors and only send modules requests when thread is stopped 2025-02-19 11:54:51 -05:00
Piotr Osiewicz
0358cdc562 Start sketching out config view
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: Remco Smits <djsmits12@gmail.com>
2025-02-19 17:39:51 +01:00
Piotr Osiewicz
55a39d5358 Use LocalDapCommand::is_supported for ConfigurationDone 2025-02-19 17:09:50 +01:00
Remco Smits
26502cdd9e Read thread status from session
Make exited the ultimate fallback so we disable all the UI buttons.
2025-02-19 15:58:40 +01:00
Remco Smits
c8632a3323 Show stack frames when you a select thread 2025-02-19 15:53:01 +01:00
Remco Smits
f4cb78f5c6 Fix a few clippy errors 2025-02-19 14:41:11 +01:00
Piotr Osiewicz
03144d7792 Mark thread list as disabled when there are no threads. 2025-02-19 14:25:31 +01:00
Remco Smits
8a5e75408b Impl continued event 2025-02-19 14:10:17 +01:00
Remco Smits
2e83b375a2 Fix didn't do anything with returned task 2025-02-19 14:08:44 +01:00
Piotr Osiewicz
14eab34e61 Show threads in the dropdown
Co-authored-by: Remco Smits <djsmits12@gmail.com>
2025-02-19 13:54:36 +01:00
Piotr Osiewicz
c711168ad4 Start wiring through thread state handling
Co-authored-by: Remco Smits <djsmits12@gmail.com>
2025-02-19 13:41:38 +01:00
Piotr Osiewicz
b43a2d1a8a Bubble up event handling to Session and Dap Store
Co-authored-by: Remco Smits <djsmits12@gmail.com>
2025-02-19 12:56:52 +01:00
Piotr Osiewicz
650984bfe5 Send out breakpoints in the configuration sequence
Co-authored-by: Remco Smits <djsmits12@gmail.com>
2025-02-19 12:12:37 +01:00
Piotr Osiewicz
83a8933a27 Merge branch 'main' into debugger 2025-02-19 11:37:20 +01:00
smit
48417866cc terminal: Handle shift+click selection (#25143)
Closes #16951

Handle the case where you click on the terminal while pressing Shift. 

Instead of setting a new selection head, we simply update the selection
to that point. This allows you to repeatedly extend the selection to new
points by pressing Shift while preserving the original selection head.

Preview:

Selection works in direct terminal, but doesn't on Vim like program,
which is expected.


https://github.com/user-attachments/assets/e46987d8-a9a3-495d-8dd9-98d461317a8d


Release Notes:

- Added ability to extend selection with Shift + click in the terminal.
2025-02-19 14:43:59 +05:30
smit
1fa105eaa5 docs: Fix selection highlight default value (#25134)
Changed default debounce value in docs to match default settings.

Release Notes:

- N/A
2025-02-19 13:27:49 +05:30
Anthony Eid
13dd3aa2b5 Enable session to send changed breakpoints to active dap servers 2025-02-19 02:26:00 -05:00
smit
043c4ed296 editor: Fix highlight selection panic (#25141)
Use the latest selection state for highlighting instead of the state
before debounce.

Release Notes:

- N/A
2025-02-19 12:50:49 +05:30
Anthony Eid
ac68f31550 Allow session to handle toggling ignore breakpoint 2025-02-19 01:58:05 -05:00
Kirill Bulatov
e57b9e5f83 Ignore selections persistence for multi buffer editors (#25140)
Follow-up of https://github.com/zed-industries/zed/pull/25083

Release Notes:

- N/A
2025-02-19 06:42:22 +00:00
Conrad Irwin
13da468e22 Fix for #25039 (#25138)
Release Notes:

- vim: Fix crash in `ci{`
2025-02-19 06:24:54 +00:00
Conrad Irwin
1678e3cbf1 Fix clicking on file links in editor (#25117)
Closes #18641
Contributes: #13194

Release Notes:

- Open LSP documentation file links in Zed not the system opener
- Render completion documentation markdown consistently with
documentation markdown
2025-02-18 22:54:35 -07:00
Ben Kunkle
ebbc6a9752 Highlight super and this as keywords in JS/TS/TSX (#25135)
Closes #24951

We were highlighting both as `@variable.special` however, they are
_techinically_ keywords and other editors (VSCode/WebStorm) seem to
highlight them as keywords as well.

Release Notes:

- N/A
2025-02-19 05:53:16 +00:00
Ben Kunkle
bb600acaa1 Set base highlight for identifiers in go to variable highlight color (#25128)
Closes #24947 

Release Notes:

- N/A
2025-02-19 01:54:51 +00:00
Marshall Bowers
372aaecdb4 language_model_selector: Authenticate all providers up front (#25123)
This PR fixes an issue where configured language model providers would
not show up unless the configuration view was opened.

The problem was that we were filtering unauthenticated language model
providers out of the language model selector, but would only
authenticate the active provider when the selector loaded.
Authenticating the rest of the providers was deferred until the
configuration view was opened for the first time.

Closes https://github.com/zed-industries/zed/issues/21821.

Release Notes:

- Fixed an issue where configured languages models were not showing up
in the language model selector until the configuration view was opened
for the first time.
2025-02-19 01:40:07 +00:00
Piotr Osiewicz
95eca602c4 Bring back old UI 2025-02-19 02:02:07 +01:00
Piotr Osiewicz
1af8c11ef4 Initialization sequence 2025-02-19 01:31:23 +01:00
Piotr Osiewicz
859cc67fa1 WIP 2025-02-19 01:20:16 +01:00
Marshall Bowers
7a6b652ebc language_model: Return AuthenticateErrors from LanguageModelProvider::authenticate (#25126)
This PR updates the `LanguageModelProvider::authenticate` method to
return an `AuthenticateError` instead of an `anyhow::Error`.

This allows us to model the "credentials not found" state explicitly as
`AuthenticateError::CredentialsNotFound`, which enables the caller to
check for this state and act accordingly.

Planning to use this in #25123 to silence errors about missing
credentials when authenticating providers in the background.

Release Notes:

- N/A
2025-02-19 00:01:48 +00:00
Danilo Leal
2627a5fdbe assistant: Improve the language model selector (#25125)
This PR includes change such as:

- Ensures the popover width is fixed/not dancing around
- Ensures the popover is not obscuring the trigger in the buffer and
terminal inline assistant scenarios
- Removes ellipsis from the trigger button label
- Ensures the scrollbar doesn't hide the check icon

| Terminal | Prompt Editor | Buffer |
|--------|--------|--------|
| ![Screenshot 2025-02-18 at 8 43
46 PM](https://github.com/user-attachments/assets/9cdfbaf1-f27e-4f48-877e-9cf61767ecee)
| ![Screenshot 2025-02-18 at 8 43
49 PM](https://github.com/user-attachments/assets/7abf9be2-bd2a-43d7-9a5d-d665e7e9fda3)
| ![Screenshot 2025-02-18 at 8 43
52 PM](https://github.com/user-attachments/assets/017bbdb3-185a-4bf6-9005-018ecafef9dd)
|

Release Notes:

- N/A
2025-02-18 21:01:09 -03:00
Piotr Osiewicz
060c8df7e8 Remove code 2025-02-19 00:13:02 +01:00
Marshall Bowers
a6006afdd7 language_model_selector: Fix variable name (#25121)
This PR fixes an inaccurate variable name that I noticed in the language
model selector.

Release Notes:

- N/A
2025-02-18 23:10:47 +00:00
Kirill Bulatov
92f128ebb0 Do not fail hard on selection persistence if the editor is removed (#25120)
Follow-up of https://github.com/zed-industries/zed/pull/25083

Follows practices from editors' scroll position persisting:
5a05b7461e/crates/editor/src/persistence.rs (L200)
and do not fail hard if the editor with the ID given does not exist.
Also add the problematic IDs into the error context to see them in the
error logs.

Release Notes:

- N/A
2025-02-18 22:52:23 +00:00
Marshall Bowers
98ea659af6 assistant2: Fix thread history only working in one Zed window (#25119)
This PR fixes an issue where the thread history would only work in one
Zed window at a time.

The backing LMDB database can only be opened once per Zed instance.
However, the `ThreadStore` has one instance per Zed window.

To fix this, we need to create the `heed` environment once and store it
as a global, and then reference the same environment across all of the
`ThreadStore`s.

Release Notes:

- N/A
2025-02-18 22:44:43 +00:00
João Marcos
d0816ef2e2 edit predictions: Fix fold not expanding after jump (#25116)
Closes #24938.

Release Notes:

- Edit predictions: Fix fold not expanding after jump
2025-02-18 18:55:00 -03:00
Agus Zubiaga
6885b28c22 assistant2: Deploy inline assistant in PromptEditor (#25094)
Release Notes:

- N/A

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
2025-02-18 18:29:12 -03:00
Conrad Irwin
48f87a8d9a Don't open file finder menu on command (#25097)
Closes #24740

Release Notes:

- Don't open the split menu in the file finder when command is pressed
2025-02-18 14:27:10 -07:00
Danilo Leal
bff1548b48 assistant2: Add file icons for mentioned creases (#25111)
This PR makes the mentioned file creases/buttons use `FileIcons`.

<img width="700" alt="Screenshot 2025-01-21 at 11 20 49 AM"
src="https://github.com/user-attachments/assets/876da534-c11a-4d13-af82-a5948863f954"
/>

Release Notes:

- N/A

Co-authored-by: Anthony Eid <hello@anthonyeid.me>
2025-02-18 18:22:01 -03:00
Conrad Irwin
60a44359e4 Terminal mouse improvements (#25104)
Closes #24911
Closes #17983
Closes #7073

Release Notes:

- Terminal: Fix cmd-click on links/files when terminal is not focused
- Terminal: Remove hover treatment after Zed hides/re-opens

---------

Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
2025-02-18 13:10:10 -08:00
Michael Sloan
b1872e3afd cx.background_executor().spawn(...) -> cx.background_spawn(...) (#25103)
Done automatically with

> ast-grep -p '$A.background_executor().spawn($B)' -r
'$A.background_spawn($B)' --update-all --globs "\!crates/gpui"

Followed by:

* `cargo fmt`
* Unexpected need to remove some trailing whitespace.
* Manually adding imports of `gpui::{AppContext as _}` which provides
`background_spawn`
* Added `AppContext as _` to existing use of `AppContext`

Release Notes:

- N/A
2025-02-18 20:30:33 +00:00
Piotr Osiewicz
f606b0641e workspace: Prevent user from undoing persistent session deserialization (#25106)
Closes #21846

Release Notes:

- Fixed a bug that made it possible to undo changes in dirty
deserialized buffer (with `restore_unsaved_buffers: true`)
2025-02-18 19:49:39 +00:00
Joseph T. Lyons
e5d8bd27da Issue response: pull team members from staff team (#25102)
Release Notes:

- N/A
2025-02-18 18:43:37 +00:00
Cole Miller
529c65276e Revert gutter stripes as indicator of hunk staged status (#25089)
We've decided to go in a different direction on indicating the staged
status of hunks, so go back for now to a world where we don't display
staged and unstaged hunks differently outside the (still gated) project
diff editor.

cc @iamnbutler 

This reverts commit 8c202b3b09.

Release Notes:

- N/A
2025-02-18 13:20:39 -05:00
Anthony Eid
1644871336 Start work on handling stopped event
I didn't have time to finish this beacuse I have a pairing session
that I have to go too. Will resume soon
2025-02-18 12:59:22 -05:00