Marshall Bowers
043cef89eb
Remove unneeded wrapping divs in ListItem left content ( #3438 )
...
This PR removes some unneeded wrapping `div`s around the left content in
`ListItem`s.
Release Notes:
- N/A
2023-11-29 12:40:35 -05:00
Marshall Bowers
912c30c05b
Remove unneeded .clones
2023-11-29 12:35:39 -05:00
Marshall Bowers
97e6fd295a
Remove unneeded wrapping divs in ListItem left content
2023-11-29 12:29:48 -05:00
Nate Butler
a8bf0834e6
Button2 – Part1 ( #3420 )
...
## TODO
- [x] Remove `InteractionState`
- [ ] `Selectable` should use `Selection` instead of a boolean
- [x] Clean out ui2 prelude
- [ ] Build out button2 button types
- [ ] Port old buttons
Release Notes:
- N/A
---------
Co-authored-by: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-11-29 12:23:09 -05:00
Conrad Irwin
5d59108b97
Inviting/Responding/Creating Channels... etc. ( #3433 )
...
Release Notes:
- n/a
2023-11-29 09:29:25 -07:00
Joseph T. Lyons
f735f5287e
v0.116.x dev
2023-11-29 11:08:32 -05:00
Kirill Bulatov
a62c4845a9
Make prettier more robust to offline work and errors ( #3434 )
...
Refactors prettier support:
* moves away prettier-related code into a separate module, makes
prettier installation & start phases more type-restricted
* ensures prettier installation and start attempts are capped with a
fixed attempts amount: after it's exceeded, no further attempts to
install and/or start prettier area made
* improves default prettier management, by correctly preserving its
plugin set between (re) installations and always installing the prettier
server part
* slightly improves prettier logging
Release Notes:
- N/A
2023-11-29 14:02:31 +02:00
Kirill Bulatov
d92153218c
Log prettier installation start & success
2023-11-29 13:44:19 +02:00
Kirill Bulatov
3e3b64bb1c
Fix the tests
2023-11-29 12:10:41 +02:00
Kirill Bulatov
3796e7eecb
Port to gpui2
2023-11-29 11:52:26 +02:00
Kirill Bulatov
6e44f53ea1
Style fixes
2023-11-29 11:33:29 +02:00
Kirill Bulatov
f1314afe35
Simplify default prettier installation function
2023-11-29 10:58:22 +02:00
Kirill Bulatov
96f6b89508
Clear failed installation task when error threshold gets exceeded
2023-11-29 10:58:22 +02:00
Kirill Bulatov
acd1aec862
Properly determine default prettier plugins to install
2023-11-29 10:58:22 +02:00
Kirill Bulatov
64259e4a0b
Properly increment installation attempts
2023-11-29 10:58:22 +02:00
Kirill Bulatov
43d28cc0c1
Ignore initialized LSP request in prettier wrapper
2023-11-29 10:58:22 +02:00
Kirill Bulatov
465e53ef41
Always install default prettier
2023-11-29 10:58:22 +02:00
Kirill Bulatov
46ac82f498
Do not attempt to run default prettier if it's not installed yet
2023-11-29 10:58:22 +02:00
Kirill Bulatov
938f2531c4
Always write prettier server file
2023-11-29 10:58:22 +02:00
Kirill Bulatov
eab3476304
Split prettier code off to a separate module
2023-11-29 10:58:22 +02:00
Kirill Bulatov
e7e56757dc
Limit prettier installation and start attempts
2023-11-29 10:58:22 +02:00
Kirill Bulatov
c288c6eaf9
Use enum variants for prettier installation and startup phases
2023-11-29 10:58:22 +02:00
Kirill Bulatov
d010f5f98d
Exctract the common code
2023-11-29 10:58:22 +02:00
Conrad Irwin
5fbc60d8da
Inviting/Responding/Creating Channels... etc.
2023-11-28 22:47:04 -07:00
Conrad Irwin
396ecefa4f
use the right click event for buttons ( #3432 )
...
Previously we used mouse down
Release Notes:
- N/A
2023-11-28 21:27:42 -07:00
Conrad Irwin
0d4839b973
use the right click event for buttons
2023-11-28 21:14:48 -07:00
Marshall Bowers
e36c7dd301
Remove ID hack in ListItem ( #3431 )
...
This PR removes the ID hack in `ListItem`, since the underlying issue
was fixed in #3430 .
Release Notes:
- N/A
2023-11-28 23:11:29 -05:00
Conrad Irwin
9e7a90a3d4
Fix stateful elements in Components ( #3430 )
...
No more wrapper divs for buttons
Release Notes:
- N/A
2023-11-28 20:59:58 -07:00
Conrad Irwin
db5ded0252
Remove useless method
...
We need to move state from layout to paint in any case
2023-11-28 20:53:46 -07:00
Conrad Irwin
8d1518d70c
Fix stateful elements in Components
...
Previously a component assumed its element was stateless, this was
incorrect!
2023-11-28 20:47:11 -07:00
Mikayla Maki
fbe440250e
Restore welcome page ( #3429 )
...
Also restores the theme selector and base keymap selector. This does not
include a UI port.
Release Notes:
- N/A
2023-11-28 16:34:41 -08:00
Conrad Irwin
7677998470
Channel joining ( #3428 )
...
- Remove debugging
- Basic channel joining!
[[PR Description]]
Release Notes:
- N/A
2023-11-28 17:00:21 -07:00
Conrad Irwin
60ce75c34a
Togglable channels, the greatest since sliced bread
2023-11-28 16:52:12 -07:00
Mikayla
a41c857855
Merge branch 'main' into welcome2
2023-11-28 15:38:51 -08:00
Mikayla
ed8e62cd18
Restore welcome page and several pickers
2023-11-28 15:25:28 -08:00
Conrad Irwin
4c2348eb53
Fix tests, notify errors
2023-11-28 16:20:54 -07:00
Mikayla
d927c2f497
Implement all but the UI
2023-11-28 15:18:19 -08:00
Conrad Irwin
af3fa4ec0b
Basic channel joining!
2023-11-28 16:10:18 -07:00
Conrad Irwin
75891e83f3
Fix mouse events when element is occluded ( #3417 )
...
This commit adds a depth map to the frame so we can find the "top most"
opaque layer by stacking order for a given point.
This lets us determine whether the element being hovered was part of the
given layer in the previous frame, which fixes the hover issue.
Still to do:
* [ ] Fix up mouse events too (I tried this, but it's not working yet,
and I want to understand why)
Release Notes:
- N/A
2023-11-28 15:57:22 -07:00
Conrad Irwin
b13638fa76
Remove debugging
2023-11-28 15:33:44 -07:00
Conrad Irwin
450f2bf6b6
More progress on collab panel ( #3426 )
...
Release Notes:
- n/a
2023-11-28 15:30:51 -07:00
Marshall Bowers
5666066db4
Merge branch 'main' into collab-panel2
2023-11-28 17:07:40 -05:00
Marshall Bowers
ee027bc112
Fix tooltips not showing on IconButtons ( #3427 )
...
This PR fixes tooltips not showing on `IconButton`s.
The "fix" here is the same hack that we used to fix `on_click` handlers
for `ListItem`s, where we introduce another layer of wrapping with an
element with an ID set.
This PR also adds a story for the `IconButton` so this issue can be
tested/observed in isolation.
Release Notes:
- N/A
2023-11-28 17:01:53 -05:00
Conrad Irwin
a85e0db1f4
More progress on collab panel
2023-11-28 14:40:32 -07:00
Marshall Bowers
8ee84249ec
storybook2: Unsuppress and fix warnings ( #3425 )
...
This PR unsupresses the warnings in `storybook2` and summarily fixes
them.
Release Notes:
- N/A
2023-11-28 15:43:43 -05:00
Marshall Bowers
64376ad37a
ui2: Reference theme2 and settings2 crates without the 2 ( #3424 )
...
This PR updates the `ui2` crate to reference the `theme2` and
`settings2` crates without the `2` the way we do in our other crates.
Release Notes:
- N/A
2023-11-28 15:30:29 -05:00
Nate Butler
d8fd422cf4
Refine keybindings ( #3368 )
...
[[PR Description]]
Refine the `Keybinding` component.
Still some issues:
Lots of things moving so want to get this in.
Changes:
- use icons for some keys & modifiers
- updates some icons
- updates some state colors
Release Notes:
- N/A
Zed 2 Release Notes:
- Keybindings now use icons for common keys and modifiers
2023-11-28 15:22:38 -05:00
Nate Butler
b24a3b8fcb
Unused imports
2023-11-28 15:17:09 -05:00
Nate Butler
525fe70de6
Fix missing arrows
2023-11-28 15:15:49 -05:00
Nate Butler
21755c7d20
Update keybinding.rs
2023-11-28 15:12:40 -05:00
