23835 Commits

Author SHA1 Message Date
mgsloan@gmail.com
4c43ec918e A little bit more progress 2024-12-13 00:00:44 -07:00
mgsloan@gmail.com
1e61989790 Progress! 2024-12-12 23:21:59 -07:00
Nathan Sobo
c3e5bc767a WIP: 177 errors left in workspace 2024-12-12 16:53:41 -07:00
Nathan Sobo
cf8c356d27 WIP 2024-12-12 16:00:14 -07:00
Nathan Sobo
3da7e7195e WIP 2024-12-12 15:29:33 -07:00
Nathan Sobo
10f88c841c WIP 2024-12-12 14:03:05 -07:00
Nathan Sobo
eb4f81abd8 WIP 2024-12-12 13:50:31 -07:00
Nathan Sobo
cd8fdeb15b WIP 2024-12-12 13:02:27 -07:00
Nathan Sobo
72d264063f WIP 2024-12-12 11:00:50 -07:00
Nathan Sobo
77e2816265 WIP 2024-12-12 09:46:42 -07:00
mgsloan@gmail.com
49cc0b8d68 Progress! 2024-12-12 04:08:08 -07:00
Nathan Sobo
7344dbbe2d Just kidding, workspace isn't compiling 2024-12-12 00:03:31 -07:00
Nathan Sobo
c345532126 WIP 2024-12-11 22:13:15 -07:00
Nathan Sobo
67870c8d53 The workspace crate compiles! 2024-12-11 22:08:01 -07:00
Nathan Sobo
edbb526401 WIP 2024-12-11 21:19:33 -07:00
Nathan Sobo
5987d8b78d WIP 2024-12-11 21:12:43 -07:00
Nathan Sobo
933157bae8 WIP: Now just workspace (more after that I know) 2024-12-11 18:06:23 -07:00
Nathan Sobo
d4dc607ac2 WIP: remote_server compiles 2024-12-11 18:00:03 -07:00
Nathan Sobo
fdb8e92178 WIP: Call crate compiles 2024-12-11 17:38:00 -07:00
Nathan Sobo
8d61c42a8f WIP: project crate compiles 2024-12-11 17:27:28 -07:00
Nathan Sobo
d0984600f7 WIP 2024-12-11 16:06:07 -07:00
Nathan Sobo
be776138b3 WIP 2024-12-11 09:00:41 -07:00
Nathan Sobo
0240f32099 WIP 2024-12-10 16:35:56 -07:00
Nathan Sobo
7ac00f30fa WIP 2024-12-10 09:59:25 -07:00
Nathan Sobo
282ad91336 WIP 2024-12-09 20:20:03 -07:00
Nathan Sobo
857000f535 WIP 2024-12-09 13:07:13 -07:00
Nathan Sobo
6d36e6f27a WIP: Remove ViewContext 2024-12-08 22:08:11 -07:00
Nathan Sobo
33fbfb83e5 WIP: Eliminate ModelContext usages 2024-12-08 21:34:34 -07:00
Nathan Sobo
299852cc7d Not compiling, removed WindowContext references 2024-12-08 21:19:06 -07:00
Nathan Sobo
7db32fbdf4 Merge remote-tracking branch 'origin/main' into gpui4 2024-12-08 13:54:54 -07:00
Nathan Sobo
54d59981da Remove *3 crates 2024-12-08 13:28:22 -07:00
Nathan Sobo
714af18afc Copy 3 versions of crates back to original 2024-12-08 13:24:33 -07:00
Nathan Sobo
906a2d9b9b Eliminate ModelContext 2024-12-08 13:21:42 -07:00
Cole Miller
ac07b9197a gpui: Don't panic on failing to set X11 cursor style (#21689)
One more panic (well, two) that should be a `log_err`.

Release Notes:

- N/A
2024-12-08 13:30:23 -05:00
Michael Sloan
4b93a5ca44 Make completions selector continue to show docs aside if ever shown (#21704)
In #21286, documentation fetch was made more efficient by only
fetching the current completion. This has a side effect of causing the
aside to disappear and reappear when navigating the list. This is
particularly jarring when there isn't enough space for the aside,
causing the completions list to jump to the left.

The solution here is to continue to show the aside even if the current
selection does not yet have docs fetched.

Release Notes:

- N/A
2024-12-08 09:44:48 -07:00
Cole Miller
c5b6d78d5b project_diff: Keep going after failing to rescan a buffer (#21673)
I ran into a case locally where the project diff view was unexpectedly
empty because the first file to be scanned wasn't valid UTF-8, and the
inmost loop in `schedule_worktree_rescan` currently breaks when any
loading task fails. It seems like it might make more sense to continue
with the rest of the buffers in this case and also when
`Project::open_unstaged_changes` fails. I've left the error handling for
`update` as-is.

Release Notes:

- Fix project diff view missing files
2024-12-07 12:56:52 -05:00
Danilo Leal
eb3d3eaebf Adjust diagnostic in tabs behavior (#21671)
Follow up to https://github.com/zed-industries/zed/pull/21637

After discussing about this feature with the team, we've decided that
diagnostic display in tabs should be: 1) turned off by default, and 2)
only shown when there are file icons. The main reason here being to keep
Zed's UI uncluttered.

This means that you can technically have this setting:

```
  "tabs": {
    "show_diagnostics": "all"
  },
```

...and still don't see any diagnostics because you're missing
`file_icons": true`.

| Error with file icons | Error with no file icons |
|--------|--------|
| <img width="800" alt="Screenshot 2024-12-06 at 21 05 13"
src="https://github.com/user-attachments/assets/babf9cc3-b3b0-492e-9748-3e97d96ce90e">
| <img width="800" alt="Screenshot 2024-12-06 at 21 05 24"
src="https://github.com/user-attachments/assets/5247a5f1-55a0-4c56-8aaf-a0cdd115464f">
|


Release Notes:

- N/A
2024-12-07 11:00:31 -03:00
Piotr Osiewicz
fdc7751457 toolchains: Do not use as_json representation for PartialEq (#21682)
Closes #21679

Release Notes:

- N/A
2024-12-07 14:52:55 +01:00
Piotr Osiewicz
f561a91daf lsp: Add support for didRename/willRename LSP messages (#21651)
Closes #21564

Notably, RA will now rename module references if you change the source
file name via our project panel.

This PR is a tad bigger than necessary as I torn out the Model<> from
didSave watchers (I tried to reuse that code for the same purpose).
Release Notes:

- Added support for language server actions being executed on file
rename.
2024-12-07 13:08:18 +01:00
Kirill Bulatov
14ba4a9c94 Fix zoomed terminal pane issues on split (#21668)
Closes https://github.com/zed-industries/zed/issues/21652

* prevents zooming out the panel when any terminal pane is closed
* forces focus on new terminal panes, to prevent the workspace from
getting odd pane events in the background

Release Notes:

- (Preview only) Fixed zoomed terminal pane issues on split
2024-12-07 10:39:01 +02:00
Cole Miller
fa7dddd6b5 gpui: Don't panic when failing to exec system opener (#21674) 2024-12-06 22:11:40 -05:00
Conrad Irwin
4d22a07a1e Remove last few alt- bindings (#21669)
Although I hoped we could keep the non-ascii alt characters, it turns
out this is not the case for all keyboards.

Fixes #21175

Release Notes:

- (breaking change) editor::ShowInlineCompetion is now `option-tab` on
macOS
(not `option-/`). editor::{Next,Previous}Completion are `option-tab` and
  `option-shift-tab` (not `option-[` and `option-]`). This fixes typing
  characters generated by option-{/,[,]} on keyboards like Croatian.
2024-12-06 16:43:12 -07:00
Conrad Irwin
9e287b33e5 Update NorwegianExtended equivalents (#21665)
Release Notes:

- Impoved key equivalents for Norwegian Extended layout
2024-12-06 16:42:58 -07:00
Conrad Irwin
9d44ed0894 Stop overriding cancelOperation (#21667)
This was added before we were handling key equivalents, and is no longer
needed. Furthermore in the gpui2 re-write we stopped sending the correct
modifiers so this hasn't worked for the last year.

Fixes #21520

Release Notes:

- Fixed a bug where cmd-escape could act like .
2024-12-06 16:42:50 -07:00
Matin Aniss
21a6664cf8 gpui: Support animated WebP image (#20778)
Add support for decoding animated WebP images into their individual
frames.

Release Notes:

- N/A
2024-12-06 14:53:27 -08:00
Joseph T. Lyons
e019d1405a Send an event when user changes their max monthly spend limit (#21664)
Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
2024-12-06 17:35:00 -05:00
feeiyu
e5374f5d7d windows: Ignore WM_SIZE event when minimizing window (#21533)
Closes #21364

Release Notes:

- Fixed minimize window and then reopen cause the layout changed


![layout1204](https://github.com/user-attachments/assets/e823da90-0cc6-4fc9-8b8e-82680357c6fe)
2024-12-06 14:15:04 -08:00
Mikayla Maki
de939e718a Simplify livekit config so that cargo check Just Works (#21661)
Supersedes https://github.com/zed-industries/zed/pull/21653

This enables us to use `cargo test -p workspace` on macOS and Linux.

Note that the line diffs in `shared_screen.rs` are spurious, I just
re-ordered the `macos` and `cross-platform` modules to match the order
in the call crate.

Release Notes:

- N/A
2024-12-06 13:50:59 -08:00
geemili
7d80d1208c vim: Add delete action to HelixNormal mode (#21544)
Related issue: https://github.com/zed-industries/zed/issues/4642

Release-Notes:

* N/A
2024-12-06 14:05:41 -07:00
Conrad Irwin
78ca297282 Make use_key_equivalents opt-in (#21662)
When revamping international keyboard shortcuts I wanted to make the
default to use key equivalents; in hindsight, this is not what people
expect.

Release Notes:

- (Breaking) In keymap.json `"use_layout_keys": true` is now the
default. If you want to opt-out of this behaviour, set
`"use_key_equivalents": true` to have keys mapped for your keyboard. See
[documentation](https://zed.dev/docs/key-bindings#non-qwerty-keyboards)

---------

Co-authored-by: Peter Tripp <peter@zed.dev>
2024-12-06 14:05:03 -07:00