5e37a7b78c
The bug occurred because `smol::process::Command::from(_)` doesn't set
the correct fields for stdio markers. So moving the stdio configuration
after converting to a `smol` command fixed the issue.
I added the `std::process::Command::{stdout, stderr, stdin}` functions
to our disallowed list in clippy to prevent any bugs like this appearing
in the future.
Release Notes:
- N/A
24 lines
2.2 KiB
TOML
24 lines
2.2 KiB
TOML
allow-private-module-inception = true
|
|
avoid-breaking-exported-api = false
|
|
ignore-interior-mutability = [
|
|
# Suppresses clippy::mutable_key_type, which is a false positive as the Eq
|
|
# and Hash impls do not use fields with interior mutability.
|
|
"agent_ui::context::AgentContextKey"
|
|
]
|
|
disallowed-methods = [
|
|
{ path = "std::process::Command::spawn", reason = "Spawning `std::process::Command` can block the current thread for an unknown duration", replacement = "smol::process::Command::spawn" },
|
|
{ path = "std::process::Command::output", reason = "Spawning `std::process::Command` can block the current thread for an unknown duration", replacement = "smol::process::Command::output" },
|
|
{ path = "std::process::Command::status", reason = "Spawning `std::process::Command` can block the current thread for an unknown duration", replacement = "smol::process::Command::status" },
|
|
{ path = "std::process::Command::stdin", reason = "`smol::process::Command::from()` does not preserve stdio configuration", replacement = "smol::process::Command::stdin" },
|
|
{ path = "std::process::Command::stdout", reason = "`smol::process::Command::from()` does not preserve stdio configuration", replacement = "smol::process::Command::stdout" },
|
|
{ path = "std::process::Command::stderr", reason = "`smol::process::Command::from()` does not preserve stdio configuration", replacement = "smol::process::Command::stderr" },
|
|
{ path = "serde_json::from_reader", reason = "Parsing from a buffer is much slower than first reading the buffer into a Vec/String, see https://github.com/serde-rs/json/issues/160#issuecomment-253446892. Use `serde_json::from_slice` instead." },
|
|
{ path = "serde_json_lenient::from_reader", reason = "Parsing from a buffer is much slower than first reading the buffer into a Vec/String, see https://github.com/serde-rs/json/issues/160#issuecomment-253446892, Use `serde_json_lenient::from_slice` instead." },
|
|
]
|
|
disallowed-types = [
|
|
# { path = "std::collections::HashMap", replacement = "collections::HashMap" },
|
|
# { path = "std::collections::HashSet", replacement = "collections::HashSet" },
|
|
# { path = "indexmap::IndexSet", replacement = "collections::IndexSet" },
|
|
# { path = "indexmap::IndexMap", replacement = "collections::IndexMap" },
|
|
]
|