feeiyu 42ed032f12 Fix circular reference issue between EditPredictionButton and PopoverMenuHandle (#42351) ...

Closes #ISSUE

While working on issue #40906, I discovered that RemoteClient was not
being released after the remote project closed.
Analysis revealed a circular reference between EditPredictionButton and
PopoverMenuHandle.

Dependency Chain: RemoteClient → Project → ZetaEditPredictionProvider →
EditPredictionButton ↔ PopoverMenuHandle

<img width="400" height="300" alt="image"
src="https://github.com/user-attachments/assets/6b716c9b-6938-471a-b044-397314b729d4"
/>

a) EditPredictionButton hold the reference of PopoverMenuHandle 

5f8226457e/crates/zed/src/zed.rs (L386-L394)

b) PopoverMenuHandle hold the reference of Fn which capture
`Entity<EditPredictionButton>`

5fc54986c7/crates/edit_prediction_button/src/edit_prediction_button.rs (L382-L389)


a9bc890497/crates/ui/src/components/popover_menu.rs (L376-L384)


Release Notes:

- N/A

2025-11-10 16:52:03 +02:00

..

acp_thread

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

acp_tools

acp_tools: Add vertical scrollbar to ACP logs (#41740)

2025-11-02 18:11:21 +00:00

action_log

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

activity_indicator

Support numeric tokens in work report LSP requests (#41448)

2025-10-29 19:35:16 +00:00

agent

agent: Add ability to set a default_model per profile (#39220)

2025-11-10 11:11:24 -03:00

agent_servers

git: Fix panic in git2 due to empty repo paths (#42304)

2025-11-10 09:27:51 +00:00

agent_settings

agent: Add ability to set a default_model per profile (#39220)

2025-11-10 11:11:24 -03:00

agent_ui

agent: Add ability to set a default_model per profile (#39220)

2025-11-10 11:11:24 -03:00

ai_onboarding

ai onboarding: Add dismiss button to the sign in banner (#40660)

2025-10-20 08:35:28 -03:00

anthropic

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

askpass

Use ShellKind::try_quote whenever we need to quote shell args (#41104)

2025-10-24 18:19:53 +02:00

assets

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

assistant_slash_command

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

assistant_slash_commands

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

assistant_text_thread

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

audio

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

auto_update

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

auto_update_helper

Fix autoupdate nuking the app on Windows (#41571)

2025-11-04 15:06:30 +01:00

auto_update_ui

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

aws_http_client

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

bedrock

bedrock: Add support for Claude Haiku 4.5 model (#41045)

2025-10-29 16:41:43 +01:00

breadcrumbs

project_search: Add button to collapse/expand all excerpts (#41654)

2025-11-03 14:50:34 -03:00

buffer_diff

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

call

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

channel

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

cli

rope: Prevent stack overflows by bumping rayon stack sizes (#41397)

2025-10-28 20:21:49 +00:00

client

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

clock

text: Improve panic messages with more information (#42072)

2025-11-06 09:16:45 +00:00

cloud_api_client

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

cloud_api_types

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

cloud_llm_client

Make it easy to point zeta2 at ollama (#42329)

2025-11-09 21:10:36 -08:00

cloud_zeta2_prompt

zeta2: Targeted retrieval search (#42240)

2025-11-08 01:06:12 +00:00

codestral

zeta2: Build edit prediction prompt and process model output in client (#41870)

2025-11-06 18:36:58 -05:00

collab

git: Add base branch support to create_branch (#42151)

2025-11-09 21:35:29 -05:00

collab_ui

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

collections

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

command_palette

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

command_palette_hooks

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

component

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

context_server

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

copilot

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

crashes

Fix windows crash handler (#42039)

2025-11-05 22:34:05 +00:00

credentials_provider

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

dap

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

dap_adapters

Allow for using config specific gdb binaries in gdb adapter (#37193)

2025-11-06 12:53:59 -05:00

db

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

debug_adapter_extension

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

debugger_tools

Keep selection in SwitchToHelixNormalMode (#41583)

2025-10-31 01:53:46 +00:00

debugger_ui

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

deepseek

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

denoise

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

diagnostics

diagnostics: Keep diagnostic excerpt ranges properly ordered (#42298)

2025-11-09 10:55:56 +00:00

docs_preprocessor

docs: Ensure macOS and Linux keybindings are escaped in HTML (#39802)

2025-10-23 14:13:35 -04:00

edit_prediction

zeta2: Build edit prediction prompt and process model output in client (#41870)

2025-11-06 18:36:58 -05:00

edit_prediction_button

Fix circular reference issue between EditPredictionButton and PopoverMenuHandle (#42351)

2025-11-10 16:52:03 +02:00

edit_prediction_context

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

editor

git: Fix panic in git2 due to empty repo paths (#42304)

2025-11-10 09:27:51 +00:00

eval

agent: Add ability to set a default_model per profile (#39220)

2025-11-10 11:11:24 -03:00

explorer_command_injector

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

extension

Run ACP login from same cwd as agent server (#42038)

2025-11-05 18:17:50 -05:00

extension_api

Windows: Fix issues with paths in extensions (#37811)

2025-09-11 13:56:06 -07:00

extension_cli

Fix categorization of agent server extensions (#41689)

2025-10-31 21:18:22 +00:00

extension_host

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

extensions_ui

extension_ui: Fix card label truncation (#41784)

2025-11-03 03:54:47 +00:00

feature_flags

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

feedback

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

file_finder

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

file_icons

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

fs

git: Fix panic in git2 due to empty repo paths (#42304)

2025-11-10 09:27:51 +00:00

fs_benchmarks

fs: Reintroduce benchmarks crate (#40689)

2025-10-20 10:30:06 +00:00

fsevent

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

fuzzy

file_finder: Include worktree root name in multi-worktrees workspace (#40415)

2025-10-20 23:54:56 +03:00

git

git: Fix panic in git2 due to empty repo paths (#42304)

2025-11-10 09:27:51 +00:00

git_hosting_providers

git: Fix support for self-hosted Bitbucket (#42002)

2025-11-09 21:37:22 -05:00

git_ui

git: Fix panic in git2 due to empty repo paths (#42304)

2025-11-10 09:27:51 +00:00

go_to_line

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

google_ai

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

gpui

Additional Windows keyboard input fixes (#42294)

2025-11-09 03:51:39 -05:00

gpui_macros

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

gpui_tokio

workspace: Handle non-cloneable items better (#41215)

2025-10-26 13:24:26 +00:00

html_to_markdown

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

http_client

node_runtime: Improve proxy mapping (#41807)

2025-11-04 17:11:54 -05:00

http_client_tls

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

icons

agent_ui: Improve display of external agents in configuration view (#41869)

2025-11-03 22:22:50 -03:00

image_viewer

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

inspector_ui

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

install_cli

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

journal

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

json_schema_store

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

keymap_editor

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

language

zeta2: Targeted retrieval search (#42240)

2025-11-08 01:06:12 +00:00

language_extension

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

language_model

zeta2: Targeted retrieval search (#42240)

2025-11-08 01:06:12 +00:00

language_models

agent_ui: Add component to standardize the configured LLM card (#42314)

2025-11-09 14:32:05 -03:00

language_onboarding

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

language_selector

Fix keybind hints flickering in certain scenarios (#40927)

2025-10-22 19:52:38 +00:00

language_tools

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

languages

Add better labels for completions for ty lsp (#42233)

2025-11-10 13:28:12 +01:00

line_ending_selector

Fix keybind hints flickering in certain scenarios (#40927)

2025-10-22 19:52:38 +00:00

livekit_api

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

livekit_client

gpui: Add to support check state to MenuItem (#39876)

2025-11-07 09:42:55 +00:00

lmstudio

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

lsp

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

markdown

Remove Markdown CodeBlock metadata and Custom rendering (#42211)

2025-11-08 14:00:53 +01:00

markdown_preview

markdown: Add support for HTML styling attributes (#42143)

2025-11-07 16:12:27 +00:00

media

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

menu

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

migrator

Support relative line number on wrapped lines (rework) (#41805)

2025-11-04 08:24:17 -07:00

mistral

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

multi_buffer

diagnostics: Keep diagnostic excerpt ranges properly ordered (#42298)

2025-11-09 10:55:56 +00:00

nc

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

net

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

node_runtime

node: Move managed runtime to v24 LTS (#41956)

2025-11-05 14:10:42 -07:00

notifications

sum_tree: Implement recursive Sumtree::find, use it over Cursor::seek if possible (#40700)

2025-10-20 17:20:09 +00:00

ollama

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

onboarding

workspace: Handle non-cloneable items better (#41215)

2025-10-26 13:24:26 +00:00

open_ai

zeta2: Build edit prediction prompt and process model output in client (#41870)

2025-11-06 18:36:58 -05:00

open_router

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

outline

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

outline_panel

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

panel

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

paths

recent_projects: Do not try to watch /etc/ssh/ssh_config on windows (#42200)

2025-11-07 15:46:37 +00:00

picker

Increased the max height of pickers (#41617)

2025-10-31 04:26:36 +00:00

prettier

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

project

git: Fix panic in git2 due to empty repo paths (#42304)

2025-11-10 09:27:51 +00:00

project_panel

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

project_symbols

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

prompt_store

prompt_store: Remove unused code (#41473)

2025-10-29 16:27:30 +00:00

proto

git: Add askpass delegate to git-commit handlers (#42239)

2025-11-10 07:57:50 +00:00

recent_projects

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

refineable

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

release_channel

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

remote

remote: Flush to stdin when writing to sftp 2 (#42126)

2025-11-06 18:18:19 +00:00

remote_server

git: Add base branch support to create_branch (#42151)

2025-11-09 21:35:29 -05:00

repl

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

reqwest_client

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

rich_text

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

rope

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

rpc

ACP Extensions (#40663)

2025-10-24 07:52:51 -04:00

rules_library

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

scheduler

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

schema_generator

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

search

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

semantic_version

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

session

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

settings

agent: Add ability to set a default_model per profile (#39220)

2025-11-10 11:11:24 -03:00

settings_json

settings_ui: Show migration banner (#41112)

2025-10-27 10:13:26 -04:00

settings_macros

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

settings_profile_selector

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

settings_ui

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

snippet

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

snippet_provider

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

snippets_ui

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

sqlez

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

sqlez_macros

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

story

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

storybook

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

streaming_diff

Revert "sum_tree: Replace rayon with futures (#41586) (#41846)

2025-11-03 19:25:15 +00:00

sum_tree

diagnostics: Keep diagnostic excerpt ranges properly ordered (#42298)

2025-11-09 10:55:56 +00:00

supermaven

zeta2: Build edit prediction prompt and process model output in client (#41870)

2025-11-06 18:36:58 -05:00

supermaven_api

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

svg_preview

svg_preview: Update preview on every buffer edit (#41270)

2025-10-29 18:49:39 +01:00

system_specs

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

tab_switcher

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

task

Use ShellKind::try_quote whenever we need to quote shell args (#41104)

2025-10-24 18:19:53 +02:00

tasks_ui

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

telemetry

Fix telemetry (#42184)

2025-11-07 11:36:05 +00:00

telemetry_events

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

terminal

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

terminal_view

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

text

text: Improve panic messages with more information (#42072)

2025-11-06 09:16:45 +00:00

theme

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

theme_extension

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

theme_importer

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

theme_selector

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

time_format

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

title_bar

Add support for closing window tabs with middle mouse click (#41628)

2025-11-10 15:09:37 +01:00

toolchain_selector

Fix keybind hints flickering in certain scenarios (#40927)

2025-10-22 19:52:38 +00:00

ui

gpui: Add to support check state to MenuItem (#39876)

2025-11-07 09:42:55 +00:00

ui_input

Fix integer underflow in autosave mode after delay in the settings (#41898)

2025-11-04 14:12:05 -05:00

ui_macros

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

ui_prompt

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

util

shell_env: Wrap error context in format! where missing (#42267)

2025-11-08 15:46:01 +00:00

util_macros

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

vercel

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

vim

Surpress more rust-analyzer error logs (#42299)

2025-11-09 11:27:16 +00:00

vim_mode_setting

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

watch

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

web_search

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

web_search_providers

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

workspace

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

worktree

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

worktree_benchmarks

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00

x_ai

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

zed

agent: Improve AddSelectionToThread action display (#42280)

2025-11-08 14:41:08 -03:00

zed_actions

git: Add git worktree picker (#38719)

2025-11-03 21:38:00 -05:00

zed_env_vars

Remove workspace-hack (#40216)

2025-10-17 18:58:14 +00:00

zeta

Make it easy to point zeta2 at ollama (#42329)

2025-11-09 21:10:36 -08:00

zeta2

Make it easy to point zeta2 at ollama (#42329)

2025-11-09 21:10:36 -08:00

zeta2_tools

zeta2: Targeted retrieval search (#42240)

2025-11-08 01:06:12 +00:00

zeta_cli

zeta2: Targeted retrieval search (#42240)

2025-11-08 01:06:12 +00:00

zlog

zlog: Add env var to enable line number logging (#41905)

2025-11-06 15:31:26 +00:00

zlog_settings

Automate settings registration (#42238)

2025-11-07 22:27:14 +00:00