81cd435e08
This PR primarily does two things: - replace `serde_json::from_reader` with `serde_json::from_slice`, as the latter is much much faster, even with loading the file into memory first. - runs the initial loading of themes and icon themes coming from extensions in parallel instead of sequential. Measuring the `eager_load_active_theme_and_icon_theme` method, this drastically improves the speed at which this happens (tested this method primarily with debug builds on my MacBook Pro, but the `Before` measurement was also confirmed against a `release-fast` build): - Before: ~260ms on average (in one run, it even took 600ms) - After: ~20ms on average Which reduces the time this method takes to load these by around ~92%. Given that we block on this during the initial app startup, this should drastically improve Zeds initial startup loading time. Yet, it also improves responsiveness when installing theme extensions and trying these. I also replaced all other `serde_json::from_reader` implementations with `serde_json::from_slice` and added the former to `disallowed_methods`, given https://github.com/serde-rs/json/issues/160#issuecomment-253446892. Release Notes: - Improved Zed startup speed when using themes provided by extensions
21 lines
1.7 KiB
TOML
21 lines
1.7 KiB
TOML
allow-private-module-inception = true
|
|
avoid-breaking-exported-api = false
|
|
ignore-interior-mutability = [
|
|
# Suppresses clippy::mutable_key_type, which is a false positive as the Eq
|
|
# and Hash impls do not use fields with interior mutability.
|
|
"agent::context::AgentContextKey"
|
|
]
|
|
disallowed-methods = [
|
|
{ path = "std::process::Command::spawn", reason = "Spawning `std::process::Command` can block the current thread for an unknown duration", replacement = "smol::process::Command::spawn" },
|
|
{ path = "std::process::Command::output", reason = "Spawning `std::process::Command` can block the current thread for an unknown duration", replacement = "smol::process::Command::output" },
|
|
{ path = "std::process::Command::status", reason = "Spawning `std::process::Command` can block the current thread for an unknown duration", replacement = "smol::process::Command::status" },
|
|
{ path = "serde_json::from_reader", reason = "Parsing from a buffer is much slower than first reading the buffer into a Vec/String, see https://github.com/serde-rs/json/issues/160#issuecomment-253446892. Use `serde_json::from_slice` instead." },
|
|
{ path = "serde_json_lenient::from_reader", reason = "Parsing from a buffer is much slower than first reading the buffer into a Vec/String, see https://github.com/serde-rs/json/issues/160#issuecomment-253446892, Use `serde_json_lenient::from_slice` instead." },
|
|
]
|
|
disallowed-types = [
|
|
# { path = "std::collections::HashMap", replacement = "collections::HashMap" },
|
|
# { path = "std::collections::HashSet", replacement = "collections::HashSet" },
|
|
# { path = "indexmap::IndexSet", replacement = "collections::IndexSet" },
|
|
# { path = "indexmap::IndexMap", replacement = "collections::IndexMap" },
|
|
]
|