Rendering breaks when both an element and its parent have opacity set.
The following code reproduces the issue:
```rust
struct Repro;
impl Render for Repro {
fn render(&mut self, _window: &mut Window, _cx: &mut Context<Self>) -> impl IntoElement {
fn make_box(bg: impl Into<Fill>) -> impl IntoElement {
div().size_8().bg(bg).hover(|style| style.opacity(0.5))
}
div()
.flex()
.items_center()
.justify_center()
.size(px(500.0))
.hover(|style| style.opacity(0.5))
.child(make_box(gpui::red()))
.child(make_box(gpui::green()))
.child(make_box(gpui::blue()))
}
}
```
Before (broken behavior):
https://github.com/user-attachments/assets/2c5c1e31-88b2-4f39-81f8-40060e3fe958
The child element resets its parent and siblings' opacity, which is an
unexpected behavior.
After (fixed behavior):
https://github.com/user-attachments/assets/48527033-b06f-4737-b6c3-0ee3d133f138
Release Notes:
- Fixed an issue where nested opacity is rendered incorrectly.
176 lines
6.1 KiB
Rust
176 lines
6.1 KiB
Rust
use std::{fs, path::PathBuf};
|
|
|
|
use anyhow::Result;
|
|
use gpui::{
|
|
App, Application, AssetSource, Bounds, BoxShadow, ClickEvent, Context, SharedString, Task,
|
|
Window, WindowBounds, WindowOptions, div, hsla, img, point, prelude::*, px, rgb, size, svg,
|
|
};
|
|
|
|
struct Assets {
|
|
base: PathBuf,
|
|
}
|
|
|
|
impl AssetSource for Assets {
|
|
fn load(&self, path: &str) -> Result<Option<std::borrow::Cow<'static, [u8]>>> {
|
|
fs::read(self.base.join(path))
|
|
.map(|data| Some(std::borrow::Cow::Owned(data)))
|
|
.map_err(|e| e.into())
|
|
}
|
|
|
|
fn list(&self, path: &str) -> Result<Vec<SharedString>> {
|
|
fs::read_dir(self.base.join(path))
|
|
.map(|entries| {
|
|
entries
|
|
.filter_map(|entry| {
|
|
entry
|
|
.ok()
|
|
.and_then(|entry| entry.file_name().into_string().ok())
|
|
.map(SharedString::from)
|
|
})
|
|
.collect()
|
|
})
|
|
.map_err(|e| e.into())
|
|
}
|
|
}
|
|
|
|
struct HelloWorld {
|
|
_task: Option<Task<()>>,
|
|
opacity: f32,
|
|
animating: bool,
|
|
}
|
|
|
|
impl HelloWorld {
|
|
fn new(_window: &mut Window, _: &mut Context<Self>) -> Self {
|
|
Self {
|
|
_task: None,
|
|
opacity: 0.5,
|
|
animating: false,
|
|
}
|
|
}
|
|
|
|
fn start_animation(&mut self, _: &ClickEvent, _: &mut Window, cx: &mut Context<Self>) {
|
|
self.opacity = 0.0;
|
|
self.animating = true;
|
|
cx.notify();
|
|
}
|
|
}
|
|
|
|
impl Render for HelloWorld {
|
|
fn render(&mut self, window: &mut Window, cx: &mut Context<Self>) -> impl IntoElement {
|
|
if self.animating {
|
|
self.opacity += 0.005;
|
|
if self.opacity >= 1.0 {
|
|
self.animating = false;
|
|
self.opacity = 1.0;
|
|
} else {
|
|
window.request_animation_frame();
|
|
}
|
|
}
|
|
|
|
div()
|
|
.flex()
|
|
.flex_row()
|
|
.size_full()
|
|
.bg(rgb(0xe0e0e0))
|
|
.text_xl()
|
|
.child(
|
|
div()
|
|
.flex()
|
|
.size_full()
|
|
.justify_center()
|
|
.items_center()
|
|
.border_1()
|
|
.text_color(gpui::blue())
|
|
.child(div().child("This is background text.")),
|
|
)
|
|
.child(
|
|
div()
|
|
.id("panel")
|
|
.on_click(cx.listener(Self::start_animation))
|
|
.absolute()
|
|
.top_8()
|
|
.left_8()
|
|
.right_8()
|
|
.bottom_8()
|
|
.opacity(self.opacity)
|
|
.flex()
|
|
.justify_center()
|
|
.items_center()
|
|
.bg(gpui::white())
|
|
.border_3()
|
|
.border_color(gpui::red())
|
|
.text_color(gpui::yellow())
|
|
.child(
|
|
div()
|
|
.flex()
|
|
.flex_col()
|
|
.gap_2()
|
|
.justify_center()
|
|
.items_center()
|
|
.size(px(300.))
|
|
.bg(gpui::blue())
|
|
.border_3()
|
|
.border_color(gpui::black())
|
|
.shadow(vec![BoxShadow {
|
|
color: hsla(0.0, 0.0, 0.0, 0.5),
|
|
blur_radius: px(1.0),
|
|
spread_radius: px(5.0),
|
|
offset: point(px(10.0), px(10.0)),
|
|
}])
|
|
.child(img("image/app-icon.png").size_8())
|
|
.child("Opacity Panel (Click to test)")
|
|
.child(
|
|
div()
|
|
.id("deep-level-text")
|
|
.flex()
|
|
.justify_center()
|
|
.items_center()
|
|
.p_4()
|
|
.bg(gpui::black())
|
|
.text_color(gpui::white())
|
|
.text_decoration_2()
|
|
.text_decoration_wavy()
|
|
.text_decoration_color(gpui::red())
|
|
.child(format!("opacity: {:.1}", self.opacity)),
|
|
)
|
|
.child(
|
|
svg()
|
|
.path("image/arrow_circle.svg")
|
|
.text_color(gpui::black())
|
|
.text_2xl()
|
|
.size_8(),
|
|
)
|
|
.child(
|
|
div()
|
|
.flex()
|
|
.children(["🎊", "✈️", "🎉", "🎈", "🎁", "🎂"].map(|emoji| {
|
|
div()
|
|
.child(emoji.to_string())
|
|
.hover(|style| style.opacity(0.5))
|
|
})),
|
|
)
|
|
.child(img("image/black-cat-typing.gif").size_12()),
|
|
),
|
|
)
|
|
}
|
|
}
|
|
|
|
fn main() {
|
|
Application::new()
|
|
.with_assets(Assets {
|
|
base: PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("examples"),
|
|
})
|
|
.run(|cx: &mut App| {
|
|
let bounds = Bounds::centered(None, size(px(500.0), px(500.0)), cx);
|
|
cx.open_window(
|
|
WindowOptions {
|
|
window_bounds: Some(WindowBounds::Windowed(bounds)),
|
|
..Default::default()
|
|
},
|
|
|window, cx| cx.new(|cx| HelloWorld::new(window, cx)),
|
|
)
|
|
.unwrap();
|
|
cx.activate(true);
|
|
});
|
|
}
|