5dcb90858e
Instead of holding a connection for potentially long LSP queries (e.g. rust-analyzer might take minutes to look up a definition), disconnect right after sending the initial request and handle the follow-up responses later. As a bonus, this allows to cancel previously sent request on the local Collab clients' side due to this, as instead of holding and serving the old connection, local clients now can stop previous requests, if needed. Current PR does not convert all LSP requests to the new paradigm, but the problematic ones, deprecating `MultiLspQuery` and moving all its requests to the new paradigm. Release Notes: - Improved resource usage when querying LSP over Collab --------- Co-authored-by: David Kleingeld <git@davidsk.dev> Co-authored-by: Mikayla Maki <mikayla@zed.dev> Co-authored-by: David Kleingeld <davidsk@zed.dev>
101 lines
3.1 KiB
Rust
101 lines
3.1 KiB
Rust
#[macro_export]
|
|
macro_rules! messages {
|
|
($(($name:ident, $priority:ident)),* $(,)?) => {
|
|
pub fn build_typed_envelope(sender_id: PeerId, received_at: std::time::Instant, envelope: Envelope) -> Option<Box<dyn AnyTypedEnvelope>> {
|
|
match envelope.payload {
|
|
$(Some(envelope::Payload::$name(payload)) => {
|
|
Some(Box::new(TypedEnvelope {
|
|
sender_id,
|
|
original_sender_id: envelope.original_sender_id,
|
|
message_id: envelope.id,
|
|
payload,
|
|
received_at,
|
|
}))
|
|
}, )*
|
|
_ => None
|
|
}
|
|
}
|
|
|
|
$(
|
|
impl EnvelopedMessage for $name {
|
|
const NAME: &'static str = std::stringify!($name);
|
|
const PRIORITY: MessagePriority = MessagePriority::$priority;
|
|
|
|
fn into_envelope(
|
|
self,
|
|
id: u32,
|
|
responding_to: Option<u32>,
|
|
original_sender_id: Option<PeerId>,
|
|
) -> Envelope {
|
|
Envelope {
|
|
id,
|
|
responding_to,
|
|
original_sender_id,
|
|
payload: Some(envelope::Payload::$name(self)),
|
|
ack_id: None,
|
|
}
|
|
}
|
|
|
|
fn from_envelope(envelope: Envelope) -> Option<Self> {
|
|
if let Some(envelope::Payload::$name(msg)) = envelope.payload {
|
|
Some(msg)
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
}
|
|
)*
|
|
};
|
|
}
|
|
|
|
#[macro_export]
|
|
macro_rules! request_messages {
|
|
($(($request_name:ident, $response_name:ident)),* $(,)?) => {
|
|
$(impl RequestMessage for $request_name {
|
|
type Response = $response_name;
|
|
})*
|
|
};
|
|
}
|
|
|
|
#[macro_export]
|
|
macro_rules! entity_messages {
|
|
({$id_field:ident, $entity_type:ty}, $($name:ident),* $(,)?) => {
|
|
$(impl EntityMessage for $name {
|
|
type Entity = $entity_type;
|
|
|
|
fn remote_entity_id(&self) -> u64 {
|
|
self.$id_field
|
|
}
|
|
})*
|
|
};
|
|
}
|
|
|
|
#[macro_export]
|
|
macro_rules! lsp_messages {
|
|
($(($request_name:ident, $response_name:ident, $stop_previous_requests:expr)),* $(,)?) => {
|
|
$(impl LspRequestMessage for $request_name {
|
|
type Response = $response_name;
|
|
|
|
fn to_proto_query(self) -> $crate::lsp_query::Request {
|
|
$crate::lsp_query::Request::$request_name(self)
|
|
}
|
|
|
|
fn response_to_proto_query(response: Self::Response) -> $crate::lsp_response::Response {
|
|
$crate::lsp_response::Response::$response_name(response)
|
|
}
|
|
|
|
fn buffer_id(&self) -> u64 {
|
|
self.buffer_id
|
|
}
|
|
|
|
fn buffer_version(&self) -> &[$crate::VectorClockEntry] {
|
|
&self.version
|
|
}
|
|
|
|
fn stop_previous_requests() -> bool {
|
|
$stop_previous_requests
|
|
}
|
|
})*
|
|
};
|
|
}
|